Error when using --cveUrlModified parameter. How should I rather provide local cveURLModified?

I am using version 10.0.3 of the dependency check using jenkins.
When calling with the arguments:
--cveUrlModified        '${cveUrlModified}'
--nvdDatafeed           '${cveUrlBase}'
--retireJsUrl           '${retireJsUrl}'
--kevURL                '${kevURL}'
--retireJsForceUpdate
I get the following error:
:50:11  Unpacking https://github.com/jeremylong/DependencyCheck/releases/download/v10.0.3/dependency-check-10.0.3-release.zip to /home/jenkins/agent/tools/org.jenkinsci.plugins.DependencyCheck.tools.DependencyCheckInstallation/dependencyCheck on deployer-bcwz4
14:50:13  Unrecognized option: --cveUrlModified
14:50:13  usage: Dependency-Check Core [--advancedHelp] [--enableExperimental]
14:50:13         [--exclude <pattern>] [-f <format>] [--failOnCVSS <score>] [-h]
14:50:13         [--junitFailOnCVSS <score>] [-l <file>] [-n] [--nvdApiKey <apiKey>]
14:50:13         [-o <path>] [--prettyPrint] [--project <name>] [-s <path>]
14:50:13         [--suppression <file>] [-v]
14:50:13
14:50:13  Dependency-Check Core can be used to identify if there are any known CVE
14:50:13  vulnerabilities in libraries utilized by an application. Dependency-Check
14:50:13  Core will automatically update required data from the Internet, such as
14:50:13  the CVE and CPE data files from nvd.nist.gov.
14:50:13
14:50:13      --advancedHelp              Print the advanced help message.
14:50:13      --enableExperimental        Enables the experimental analyzers.
14:50:13      --exclude <pattern>         Specify an exclusion pattern. This option
14:50:13                                  can be specified multiple times and it
14:50:13                                  accepts Ant style exclusions.
14:50:13   -f,--format <format>           The report format (HTML, XML, CSV, JSON,
14:50:13                                  JUNIT, SARIF, JENKINS, GITLAB or ALL). The
14:50:13                                  default is HTML. Multiple format
14:50:13                                  parameters can be specified.
14:50:13      --failOnCVSS <score>        Specifies if the build should be failed if
14:50:13                                  a CVSS score above a specified level is
14:50:13                                  identified. The default is 11; since the
14:50:13                                  CVSS scores are 0-10, by default the build
14:50:13                                  will never fail.
14:50:13   -h,--help                      Print this message.
14:50:13      --junitFailOnCVSS <score>   Specifies the CVSS score that is
14:50:13                                  considered a failure when generating the
14:50:13                                  junit report. The default is 0.
14:50:13   -l,--log <file>                The file path to write verbose logging
14:50:13                                  information.
14:50:13   -n,--noupdate                  Disables the automatic updating of the
14:50:13                                  NVD-CVE, hosted-suppressions and RetireJS
14:50:13                                  data.
14:50:13      --nvdApiKey <apiKey>        The API Key to access the NVD API.
14:50:13   -o,--out <path>                The folder to write reports to. This
14:50:13                                  defaults to the current directory. It is
14:50:13                                  possible to set this to a specific file
14:50:13                                  name if the format argument is not set to
14:50:13                                  ALL.
14:50:13      --prettyPrint               When specified the JSON and XML report
14:50:13                                  formats will be pretty printed.
14:50:13      --project <name>            The name of the project being scanned.
14:50:13   -s,--scan <path>               The path to scan - this option can be
14:50:13                                  specified multiple times. Ant style paths
14:50:13                                  are supported (e.g. 'path/**/*.jar'); if
14:50:13                                  using Ant style paths it is highly
14:50:13                                  recommended to quote the argument value.
14:50:13      --suppression <file>        The file path to the suppression XML file.
14:50:13                                  This can be specified more then once to
14:50:13                                  utilize multiple suppression files
14:50:13   -v,--version                   Print the version information.
14:50:13  ERROR: Mark build as failed because of exit code 2

Is this parameter no longer valid? which parameter should I use instead?

--nvdDatafeed which you already found is the replacement for cases where in past the cveUrlModified would be used (directly connecting to the NVD is not possible) to use a local cache/mirror of the NVD API data saved by the vulnz CLI.


Azure SignalR Service is not connected yet, please try again later.

Here's my code. I am getting error as soon as I try and connect to server.
Server code:
ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12;
            app.UseCors(CorsOptions.AllowAll);
            var hubConfiguration = new HubConfiguration();
            hubConfiguration.EnableDetailedErrors = true;
            app.MapAzureSignalR(this.GetType().FullName, hubConfiguration);

Client code:
        //Getting the connection object
        this.connection = $.hubConnection(this.globals.webApiBaseUrl + 'signalr', { useDefaultPath: false });
        //Enable logging
        this.connection.logging = true;
        (<any>this.connection).EnableDetailedErrors = true;

        //Creating proxy
        this.storyHubProxy = this.connection.createHubProxy('storyHub');

        //Track events
        this.storyHubService.startTracking(this.storyHubProxy);

        //Starting connection
        this.connection.start().done( ()=> {
            //console.log("Connection succeeded");
            deferred.resolve();
        }).fail(function () {
            console.log("SignalR Connection failed");
            deferred.reject();
        });;

        this.connection.connectionSlow(() => {
            console.warn('We are currently experiencing difficulties with the connection.')
        });

        this.connection.error((error) => {
            console.error('SignalR error: Name- ' + error.name
                + "\nContext: " + JSON.stringify(error.context, null, 4)
                + "\nMessage: " + error.message
                + "\nTransport: " + error.transport)
        });

Error I am getting on client when it tries to connect to server:
SignalR error: Name- Error
Context: {
    "readyState": 4,
    "responseText": "Azure SignalR Service is not connected yet, please try again later.",
    "status": 500,
    "statusText": "error"
}
Message: Error during negotiation request.
Transport: undefined

@realwanpengli @JialinXin

Please follow https://github.com/Azure/azure-signalr/blob/dev/docs/tsg.md#troubleshooting-guide-3 to see what's the error from the server side when connecting to Azure SignalR. If it can be reproed from localhost, local debugging following https://github.com/Azure/azure-signalr/blob/dev/docs/tsg.md#troubleshooting-guide-1 also helps.

@vicancy Server side I am not getting any errors, its only showing the following as stated earlier in the client side:
SignalR error: Name- Error
Context: {
    "readyState": 4,
    "responseText": "Azure SignalR Service is not connected yet, please try again later.",
    "status": 500,
    "statusText": "error"
}
Message: Error during negotiation request.
Transport: undefined

The client side error indicates that the server failed to establish server connections with the Azure SignalR service. When app server starts, it tries to establish server connections with Azure SignalR Service, could you capture that server side traffic? For example, the below one is when I set the ConnectionString to an unexist Azure SignalR and 502 returns when I start my server side.
From console:

From fiddler:

Closing this as we haven't heard from you and generally close issues with no response after ~7 days. Please feel free to comment if you're able to get the information we're looking for and we can reopen the issue to investigate further!


disable universal newlines

Hello,
On windows, bumpver ends up always rewriting files with '\r\n' endings due to universal newlines in text mode. The PR disables this.
In more detail, universal newline text mode always returns '\n' to the code, but ends up translating it to '\r\n' on write. This causes bumpver to fail to preserve the original newlines.

I would have expected the behaviour to be that the line endings are preserved as is in the file, so this is surprising to me. I'm not sure why this would be OS specific.
Do you have time to add a test case for this?

No clue about the test, but I know how to show the newline translation from opening files in text mode with universal newlines.
Note how in both cases .read() returns '\n'.
import platform
assert platform.system() == 'Windows'
assert platform.python_version() == '3.10.1'

# only shows newlines being translated
import io
buffer = io.BytesIO(b'\r\n')
txt = io.TextIOWrapper(buffer)
assert txt.read() == '\n'
txt.write('\n')
txt.flush()
assert buffer.getvalue() == b'\r\n\r\n'

# this is similar to what happens in practice. a '\n' ends up a '\r\n' in the new file
import io
input_buffer = io.BytesIO(b'\n')
txt = io.TextIOWrapper(input_buffer)
assert txt.read() == '\n'

output_buffer = io.BytesIO()
txt = io.TextIOWrapper(output_buffer)
txt.write('\n')
txt.flush()
assert output_buffer.getvalue() == b'\r\n'

https://docs.python.org/3/glossary.html#term-universal-newlines
https://docs.python.org/3/library/functions.html?highlight=newline#open


 Have tried everything suggested in the issues section..nothing seems to work. m getting 404 error.

@lemarian this image is a png

But why can't i load it? it can neither load png or gif.
This for instance is a gif : https://amojee-icons-production.s3.amazonaws.com/2017/08/16/TXa9UVzdpAd1QkQX18kw8Q.png?AWSAccessKeyId=AKIAIVS2WNLFM4XXFU6A&Expires=1523343346&Signature=A2S%2BwyaWK5P5YqHYLIGRIsuAs2Q%3D

cell.imgView.sd_setImage(with: urlImage!, placeholderImage: ImageNames.placeholderImage, options: [SDWebImageOptions.transformAnimatedImage], completed:  {(image, error, cacheType, url) in
    if error != nil

    {
        print(error?.localizedDescription ?? "")
    }

})

This is my code and it always gives me the error Optional("The operation couldn’t be completed. (NSURLErrorDomain error 400.)")
I am using pod 'SDWebImage/GIF',pod 'SDWebImage'

I just tried your image with our demo project and it works fine. You should debug the code and see why it doesn't work. Maybe it has something to do with your network. Please try another image, for instance http://assets.sbnation.com/assets/2512203/dogflops.gif


ci: windows cicd and tests

Enable CI/CD for tracking issues on windows.
https://github.com/redhat-developer/app-services-cli/issues/828

Problem replicated. It appears to be inside the library we use

Problem is with embed.
Even on windows path should be forward slash https://pkg.go.dev/embed
CC @rkpattnaik780 @ankithans

we should add fmt print to strings loaded by embed.
If that works then we have to log issue with lib

Obsolete.


Why removed the keyboardDisplayRequiresUserAction at v0.3.0?

https://github.com/pichillilorenzo/flutter_inappwebview/pull/2312


Official documents omit too much

Operate according to the official document Quick Start, no success, the document omits too many details, which is unfriendly。
https://carbondata.apache.org/quick-start-guide.html

please share the issue you faced


[SPARK-46050][SQL]: Allow additional rules for the Substitution batch

What changes were proposed in this pull request?

Analyzer improvement that allows providing addtional rules for the Substitution batch
Why are the changes needed?

Required for DataSourceV2 view support.
Does this PR introduce any user-facing change?

No
How was this patch tested?

N/A
Was this patch authored or co-authored using generative AI tooling?

N/A

/cc @jzhuge @aokolnychyi @holdenk

@jzhuge I think we need this PR independently from https://github.com/apache/spark/pull/39796#discussion_r1091732398 for Iceberg to have a way to hook into the substitution batch.
@holdenk could you review this one please?


Missing privileged support for docker container

While I was using the GenericContainer I found a problem using it. There is the privileged option missing. Since I'm using a IBM DB2 in project in a docker container, I need that support of docker.

Hi @Jojo255
Thanks for this - good idea!
Richard

@rnorth I see implementation and feel that we really should move to 2.0 and traits :)

@bsideup @rnorth
Do you have any clue why the circleci build has failed? Haven't changed anything there and I think I didn't destroyed anything :-D

Sadly we have a couple of flapping tests that fail more frequently on CircleCI - it's likely to be one of those :(
I need to address when I have a bit of time...

@rnorth
Is there a roadmap for 2.0 or any plans when it should be released or the work get's started

@Jojo255 thanks for this, and sorry for taking such a long time to respond. This PR looks good to me so I'll merge. The Circle CI failure is, unfortunately, random and I'm thinking of disabling that for CI (Travis is serving us a bit better).
Re 2.0, I think @bsideup was suggesting that this change is good justification for something we want to do in 2.0, but it doesn't have to wait until 2.0. I'm not sure about 2.0 release timeframe - likely early next year rather than this year.
I'll merge and try and release ASAP, though.

Released in 1.1.7 - sorry for the delay in getting this out.


Strip the BOM from the source string if it is present

While the Yarn Docs say they only accept UTF-8 the examples in the C# repos have yarn files using a UTF-8 with BOM encoding. This does not mess with them as C# will strip the BOM when reading the file as text. Rust though does not do this by default, instead reading it in as a character which causes compilation failures or sometimes panics to occur.
https://github.com/rust-lang/rfcs/issues/2428
This change adds a quick sanitation step when processing the files to strip the BOM from the file if it is present to line the expected behavior up with the core Yarn Spinner lib.

Resolves #191


[Contrib] Initial commit NIBR 2019 substructure filters

This implements a revised set of 444 SMARTS substructure filters to annotate, flag and exclude compounds. These filters were revised and developed in the course of the NIBR screening deck re-design. More details on this work can be found in a recent publication: Schuffenhauer, A. et al. Evolution of Novartis' small molecule screening deck design, J. Med. Chem. (2020), DOI. https://dx.doi.org/10.1021/acs.jmedchem.0c01332

Many thanks for the feedback @greglandrum!
It would be nice if we could integrate them into the Contrib for now (we added that link to the paper :)) and add them in addition at some point in the C++ FilterCatalog. What do you think?

@NadineSchneider @greglandrum Once they are merged I can add them to the filter catalog along with pat Walters collections as well.
This is great work!

Hi @bp-kelley , thanks for the feedback! We actually had a look at Pat's collection and included most of them in our review. Please let me know when you have more questions or need help.


Adding Conventions Support

How about adding an info box of some sort that shows the correct convention e.g. Class name should be CamelCase or function names be separated by underscores etc? I guess it can be done using Google Python Style Guide/PEP 8.

We are using the python language server which as far as I know doesn't support conventions for casing.
Please open a issue on the language server repo.

Thank you for guiding. Will do :smile:


disable hud for fanciness

make the bot press ctrl + h when starting to spectate a player

one downside: you dont have conformation in the client itself who is playing, like if the person being specced is speccing someone else osuceleb bot will spec that person, but will show it as the first person in osu celeb overlay

You can't send keystrokes to osu in any basic fashion. Cheat protection. I
guess it works if you try really hard and hack around the directx input or
whatever is going on there, but that's not worth.
On Fri, Feb 3, 2017 at 10:03 PM Olle Kelderman<EMAIL_ADDRESS>wrote:

one downside: you dont have conformation in the client itself who is
playing, like if the person being specced is speccing someone else osuceleb
bot will spec that person, but will show it as the first person in osu
celeb overlay
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/OsuCelebrity/OsuCelebrity/issues/64#issuecomment-277361677,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABL9ZTee9gVXbtVCXZf49BC1xEFZiawvks5rY5YYgaJpZM4L2zS_
.


[WCOW] Document how to setup windows dev/test environment

Ref https://github.com/containerd/cri/issues/1257
We should have a document for this.

Yeah - we need better building steps. I'm trying to cross-build and am having a lot of issues.
from containerd/containerd: GOOS=windows make will build containerd and ctr.exe, but it skips CRI plugin
containerd/containerd: GOOS=windows make cri-release fails
containerd/cri: GOOS=windows make containerd works
containerd/cri: GOOS=windows make release fails


samples: led_ws2812: force SPIM on nRF52-DK

The WS2812 SPI driver needs the pixel data to be clocked out on time,
with no gaps between SPI frames. This makes the nordic,nrf-spi
compatible unsuitable for use, since the corresponding driver doesn't
use EasyDMA to clock out the tx buffers.
Force the arduino_spi node in the DT to SPIM mode by setting its
compatible to nordic,nrf-spim. On nRF52832, this driver is disabled by
default due to Product Anomaly Notice (PAN) 58.
We happen to not be affected by PAN 58 in this instance, because we
never read data over the SPIM, only write it. So it's safe to enable
the SPIM driver. This requires a board-specific Kconfig fragment for
nRF52-DK to enable CONFIG_SOC_NRF52832_ALLOW_SPIM_DESPITE_PAN_58.
Fixes: #29877
Signed-off-by: Martí Bolívar<EMAIL_ADDRESS>

Hi @mbolivar-nordic. It is interesting. I have been using this driver on a compatible LED controller (Everlight B1414) with both SPI and SPI+DMA (STM32 MCU). And without DMA, indeed there are gaps between the bits sent over SPI but it is OK as long as the gaps are lesser than the reset/latch delay. IMHO, the gaps are not an issue and "low" delay can be longer by a lot than the values defined in the specification. But the "high" delay have to match the specifications within a 150ns allowance. And from I can see in the oscilloscope pictures attached to #29877, it is the case...
But whatever, it is always better to use SPI+DMA wherever it is possible to drive this kind of LEDs.

IMHO, the gaps are not an issue and "low" delay can be longer by a lot than the values defined in the specification.

Yep, but if the gap length is Treset or longer, you have a problem. This can happen in some use cases if a higher priority task or IRQ pre-empts the driver thread in the middle of shifting the bits out. It seems that doesn't happen in your applications, though.

Looks good to me.

Thanks for review!


ios 8 foreground not show banner, android background not show banner

ios 10 working properly but ios 8 foreground and android (7) background only show on tray not show banner.
Please guide.
payload:
`notif = {
id = 123,
title = "title",
content = "content",
badge = 1
}
payload = {
collapse_key = "xxx",
time_to_live = 864000,
content_available = true,
notification =
{
id = notif.Id,
color = "#66BB6A",
title = notif.title,
body = notif.content,
icon = "ic_notification",
priority = "high",
show_in_foreground = true,
content_available = true,
badge = notif.badge,
sound = "default",
},
data = notif,
registration_ids = [token array],
priority = "high",
};`

iOS <= 9  doesn't show foreground banner when remove notification comes. system limit
Android doesn't show banner because FCM doesn't support it. you have to use "custom_notification", check readme

@evollu
I using custom_notification in data and remove notification in payload now it work ok in foreground and background but not work when app killed. Should i send both payload, one for notification and one for custom_notification?

i tried, if send both will not show banner in background


Feature request: support dark themes

First: I love this extension!
I know the title is scary, but I propose a simplistic solution to make life better for dark GitHub users in a hurry. Here's what I'm doing locally:
.icon .octicon:before {
    filter: brightness(125%) contrast(150%) drop-shadow(0 0 0 #fff) drop-shadow(1px 1px 1px #444);
}

I'm sure a designer could do far better than I, but something like this rigged to a "Dark Mode" checkbox in the options would make it super simple for those with dark themes to have much better looking icons.
Here's a compare on my machine of extension+dark vs. extension+dark+tweak above:

I think it's hard to tell in a 2:1 block up issue picture, but they're far more readable on a HiDPI screen. I'm not saying use my styling (though you're welcome to), but I just wanted to pitch the idea in general: a checkbox hooked to a CSS tweak to improve life a bit.
Thoughts?

Great suggestion! I like this improvement, but I'm busy these weeks. PR is always welcome, or I will do it later.


How to add timeline view

I want to make like this official demo but it is not working
https://fullcalendar.io/docs/timeline-standard-view-demo

this function it depend Sheduller, Sheduller for non free version https://fullcalendar.io/scheduler/license


support Column(regex=True) for applying checks to regex column pattern

The purpose of this feature is to make is to make it easier for users to specify column checks for groups of meaningfully grouped columns. For example, if a dataframe contains columns:

numerical_feature_1
numerical_feature_2
...
numerical_feature_n

That are all expected to share the same properties, the user should be able to express a schema in the following way:
DataFrameSchema({
    "numerical_feature_*": Column(..., regex=True)
})

In order to apply the same checks and assertions.

This is a great idea.
It would be super useful to handle columns like:

numerical_feature_cats
numerical_feature_dogs
...
numerical_feature_mouse

Fixed by: #184


Requests initiated by LWM2M Server get sent to wrong LWM2M client with same IP:Port

When a request to a LWM2M client, e.g. read request, gets triggered, Leshan looks up the client with the desired endpoint name from the client registry and sends the request to the IP:Port saved there. When this IP:Port gets used by another client in the meantime, e.g. port re-usage of NAT device, the request gets sent to the wrong client. I think without usage of DTLS this behavior is just fine.
However, the same applies also with DTLS. Example:

     client1 registers with Leshan using PSK1

     client2 creates new DTLS session with Leshan/Scandium from same IP:Port but with PSK2 (client does not need to register at LWM2M level)

     server sends read request to client1, however request arrives at client2 (as client2 has IP:Port of client1) and client2 can even decrypt it

One way to solve this would be to handover recipient principal somehow to scandium and scandium only sends the message when this is the same as the active DTLS session. Or even more strict handover the DTLS sessionId etc. of the last message received from the according client to scandium (like Scandium CorrelationContext but only the other way around).
See also mailing list discussion: http://dev.eclipse.org/mhonarc/lists/leshan-dev/msg00610.html

Thx to the great works done by @boaks. This should be fixed in this PR #440.
A test was added to check that : https://github.com/eclipse/leshan/pull/440/commits/5292951027750e812ecbca36d3b5de2255953c28
Feedback is welcome :)


Add case commit, rollback and correct exception throw

Hi @craftzdog
I updated Windows module support :

Correct transaction work
Fix bug exception throw

Windows Module's credit from @scubism http://s-cubism.jp/

@zerglingno1 Thanks for the PR 👍

@craftzdog Hi, we've just updated Windows library. Could you please release new version?

Published as v1.4.0. Thanks for the PR.


📝 Update includes in ./docs/zh/docs/advanced/generate-clients.md

Thanks for the effort! :cake:
This was handled in another PR, so I'll close this one now. :coffee:


add copy right string

Summary of the changes (in less than 80 characters):

Add localized copyright string:
© Microsoft Corporation. 保留所有权利.

Before change:  example packages contain copyright string above
Executing the verify tool...
Using the following package path argument:
*.nupkg
INVALID.
.\Microsoft.AspNet.SignalR.nupkg
The package Microsoft.AspNet.SignalR 2.2.1 is not compliant.
There is 1 problem.

The package metadata contains a non-compliant copyright element.

After change:
Executing the verify tool...
Using the following package path argument:
*.nupkg
VALID.
.\Microsoft.AspNet.SignalR.nupkg
The package Microsoft.AspNet.SignalR 2.2.1 is compliant.
Addresses https://github.com/NuGet/Engineering/issues/4308

I think there is a README.md in the verify tool directory that has a list of copyright strings. Could you update that too?


Nightly spec runner no longer runs

https://natalie-lang.org/specs
"The specs were completed at Thu, 01 Jun 2023 05:58:09 GMT"

I think this is fixed now. The mounted storage for the stats API server had become disconnected, and restarting the container seems to have fixed it. If the stats post tonight, we can close this issue.

Last update now shows "The specs were completed at Thu, 24 Aug 2023 05:18:17 GMT", so it had a recent run


[ignore] update ws to latest version to resolve GHSA-3h5v-q93c-6h6q

resolves GHSA-3h5v-q93c-6h6q

ws 8 breaking changes

clean up old overrides
update mocha to latest version
update to latest version of itwin.oidc-client-signin

drafting in favor of #6863 for getting around audit in the easiest way possible, but we do need to carry the rest of the changes in this pr forward because we will be blocked next time someone runs rush update --full


Scale off for results

The program runs without issue, but the scale of the SDF molecule does not match the input scale/protein.
Have you seen this before?  Is there any recourse here?

I have not encountered this before and am not sure how the issue occurs

The odd thing is, the molecule in general is in a good docked place.  The SDF molecule is preserved as well, but the scale is off by about 12 fold.

I have now tried with Mol2 format and PDB format and I still get the same strange scale, so something is wrong with the post-processing.  They are consistently the same scale - IE C-C bonds are 6.1A.  I will see if I can share the inputs that I am using.

I can not reproduce this issue and have also not encountered it before with other people using EquiBind.
Sorry that I cannot be of further help here.

Sounds good.  Looks like the Cuda torch version was different than system Cuda toolkit system version - 11.3 vs 11.4.  I installed 11.4 and re-running on both GPU and CPU to see if anything comes out from that.  Also working on being able to get you exact inputs to see if it can be reproduced, but that might take some time to get through.


#2983 constraints of union rule

Description
the union rule works for same schema only.
Related Issue :
2983
How Has This Been Tested?
add a union rule with datasets have different schema
the union button must be disabled
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have read the CONTRIBUTING document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.

Additional Context

deploy to 2


Numbered list does not display correctly in Safari

Bug Report
Description
Bug Summary:
Markdown numbered lists generated by LLMs do not display correctly in Safari. Number starting from 10 will be cropped out.
Steps to Reproduce:

Use Safari browser
Ask models to generate a numbered list with more than 10 entries
Problem starts appearing starting from number 10

Expected Behavior:
Numbers display correctly
Actual Behavior:
Numbers does not display correctly
Environment

Operating System: macOS Sonoma 14.3.1
Browser (if applicable): Safari 17.3.1 (1966<IP_ADDRESS>.12)

Reproduction Details
Confirmation:

[x] I have read and followed all the instructions provided in the README.md.
[x] I have reviewed the troubleshooting.md document.
[ ] I have included the browser console logs.
[ ] I have included the Docker container logs.

Logs and Screenshots
Browser Console Logs:
N/A
Docker Container Logs:
N/A
Screenshots (if applicable):

Installation Method
Docker
Additional Information
N/A

Can you copy the answer with the copy icon at the bottom of the message and paste it here?

I've lost the previous conversation, but here's another one.
 1. Aki
2. Anna
3. Annika
4. Elina
5. Esa
6. Helmi
7. Heikki
8. Jarkko
9. Johanna
10. Juhani
11. Kaarlo
12. Kati
13. Kirsi
14. Kustaa
15. Lauri
16. Liisa
17. Lumi
18. Mia
19. Mikko
20. Niilo
21. Noora
22. Ossi
23. Paula
24. Pekka
25. Piia
26. Riikka
27. Salla
28. Teija
29. Tina
30. Tommi

It seems like the numbers are really cropped out.

Ok thanks!
Can someone reproduce this on safari? For me on Win 11 / Chrome it is working.

I confirmed this happened with safari on Mac. Changed to Edge (also on Mac) it works fine.

Ok, looks like a formatting issue like margin or something.
But the cut off text on the left looks like a 2 for me not the expected 1.
Like it would count 9. 20. 21.


ci: add smoke tests integration

Closes https://github.com/elastic/apm-aws-lambda/issues/217

:broken_heart: Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-09-19T01:54:29.155+0000

Duration: 8 min 34 sec

Steps errors
Expand to view the steps failures

make build

Took 0 min 5 sec . View more details here
Description: make build

make build

Took 0 min 2 sec . View more details here
Description: make build

:robot: GitHub comments
Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kruskall could you provide a sentence or two to the description.
@v1v could you (or someone from the team) review the ci automation part here please (does not need to be merged before 8.5 FF).

I've just added the support to run always when pushing into the main branch by default. And also support for running on PR basis by using the Jenkins UI.
For instance, this particular PR can be validated manually by running the job -> https://apm-ci.elastic.co/job/library/job/apm-aws-lambda-smoketests-mbp/view/change-requests/job/PR-310/

It seems the job is failing because the aws provider is not configured (missing credentials), could you help with that ? I'm not familiar with the process/guidelines regarding adding credentials to jenkins.

Everything is in Vault, as far as I know it uses the secrets defined in secret/observability-team/ci/elastic-observability-aws-account-auth. https://github.com/elastic/apm-aws-lambda/pull/310/files#diff-377731352d232f58c31c9af00e5e8dbbf25eb9a2db0edb045a9853ab9d99fd99R115 is the section to configure AWS accordingly with the command aws configure import csv file
What's the error? Maybe there are some missing permissions for the existing AWS account?

What's the error? Maybe there are some missing permissions for the existing AWS account?

[2022-10-12T12:14:35.035Z] Error: error configuring Terraform AWS Provider: failed to get shared config profile<EMAIL_ADDRESS>
[2022-10-12T12:14:35.035Z]
[2022-10-12T12:14:35.035Z]   with provider["registry.terraform.io/hashicorp/aws"],
[2022-10-12T12:14:35.035Z]   on main.tf line 1, in provider "aws":
[2022-10-12T12:14:35.035Z]    1: provider "aws" {

See https://apm-ci.elastic.co/blue/organizations/jenkins/library%2Fapm-aws-lambda-smoketests-mbp/detail/PR-310/5/pipeline

I'm not much familiar with that error, I just searched and found:

If I downgrade to version = "~> 3.0" it fixes the problem. But I would like to upgrade to the latest version.

In here
I also see some references about some specific terraform configuration:

https://github.com/hashicorp/terraform-provider-aws/issues/15361#issuecomment-699175180
https://registry.terraform.io/providers/hashicorp/aws/latest/docs#shared-configuration-and-credentials-files

I'm not much familiar with the existing terraform/aws configuration for this project, that particular withAWSEnv steps  works in some other projects, do you happen to know what's the profile meaning in terms of terraform?


alinged devfolio and mlh buttons in same line

I had to change the "apply-changes" div class to button(cause in the main site it was a button) and remove a div.
solves #3

😭


The problem with Russian names for photos

There was a problem with downloading files in Russian. Has solved a problem so. Possible to update.
In addition to Russian words, there was a problem with spaces.

In our v1.8.0 release, we have fixed an iconv bug while processing non-utf8 folders. Please update your package to this version and see if this bug still exists.


Feature: allow users to link datasets to each other

Add an interface (in the broadest possible sense of that word) for users to annotate that the measurement they are about to perform has N parents and also allow some text-based annotations for that relationship (e.g. "fit", "analysis").
It is only possible to link to datasets in the same DB file as the new measurement will be written to.


Redirect to HTTPS with IIS standalone deployment

Blazor produces its own web.config. Is there any way to enable HTTP to HTTPS redirection on IIS without having to edit the generated web.config file?
As a workaround, I have added this to my App.razor file:
protected override void OnInitialized()
{
    if (NavigationManager.Uri.StartsWith("http://"))
    {
        NavigationManager.NavigateTo("https://" + NavigationManager.Uri.Substring(7));
        return;
    }
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 89b4d6a1-1436-7ba8-a5c5-8dcb6a955bb0
Version Independent ID: 4a6a13b4-fe5c-a9fb-5d7d-33d5aa0fbac3
Content: Host and deploy ASP.NET Core Blazor WebAssembly
Content Source: aspnetcore/host-and-deploy/blazor/webassembly.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @guardrex
Microsoft Alias: riande

Hello @cornem ... Yes! ... BUT ... you just flagged 😵 unexpected behavior 😵 in the framework.
Normally, you would supply your own custom web.config file in the root of the project and add this to the project file ...
<PropertyGroup>
  <IsTransformWebConfigDisabled>true</IsTransformWebConfigDisabled>
</PropertyGroup>

Reference: https://docs.microsoft.com/aspnet/core/host-and-deploy/iis/#configuration-of-iis-with-webconfig
BUT ... I just ran a test on that. The custom web.config is moved to the target framework folder (bin/Release/netstandard2.1 folder); however, it isn't moved to the bin/Release/netstandard2.1/publish folder, which is where you'd really want it for deployment.
Turns out that engineering is already using that property for Blazor WebAssembly ...
https://github.com/dotnet/aspnetcore/blob/blazor-wasm/src/Components/WebAssembly/Build/src/targets/Publish.targets#L9
Therefore, don't use that ...... use this instead ...
<Target Name="CopyWebConfigOnPublish" AfterTargets="Publish">
  <Copy SourceFiles="web.config" DestinationFolder="$(PublishDir)" />
</Target>

... which should do the trick.
I'll put that into the topic. Thanks, and I'll ping u on the PR.
I opened https://github.com/dotnet/aspnetcore/issues/20569 for engineering to see if they want to do something else for this scenario.

Thanks!
Just to be sure... This means one has to actually include the contents of Blazor's own web.config file as well, right? Because if I make a new web.config file with just the HTTPS redirection rules, then it just copies my file right over to /publish without the <staticContent>, <httpCompression> and <rewrite> sections that Blazor produces.
So if you want to use a custom web.config file, you start with the one produced by Blazor, and then add you own stuff, correct?

include the contents of Blazor's own web.config file

Correct ... supply your custom web.config at the root of the project exactly the way that you want it deployed. It's going to copy that file at the end of the MSBuild publish to the publish folder and overwrite the one that the framework places there.


Update to typescript 2.0

TS 2.0 beta is out, now is a good time to make the switch from the 1.9.x-dev-? build currently being used.
Ref: https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#typescript-20
Blocked by https://github.com/ubiquits/toolchain/issues/18

Closed in #126


Members not sorted in Structure view with "Group methods by Defining Type" mode on

See screenshot: http://dl2.joxi.net/drive/2016/10/26/0006/0599/434775/75/7089bd01d4.jpg

Reproduce in Version: 1.3.1-SNAPSHOT-201610250243 (and in earlier version 20161001 too)

I can't reproduce here. What version of IntelliJ are you using? If you disable then re-enable the sort button, does it fix the problem?

IDE Version:
IntelliJ IDEA 2016.2.5
Build #IU-162.2228.15, built on October 14, 2016
JRE: 1.8.0_92-b14 amd64
JVM: Java HotSpot(TM) 64-Bit Server VM by Oracle Corporation
If button "Group methods by Defining Type" is enabled then disable and re-enable the sort button is not working for me - member sorting state is not changes (stay the same) in any case (sorted or not-sorted current state). If I disable button "Group methods by Defining Type" then the sort button switch member sorting state correctly.

I had a bit of a look at this one, and I can't figure out what's wrong here. Debugging the code, I can see the ALPHA_SORTER getting called and doing the right thing. I've no clue why the result of that is ultimately ignored.


The recommended static URL is not optimal

Thank you @ahmedaljazzar for creating the library!
In the README.md file this library recommends the following:

To include a static file url:
${ static }/home.png

Which has been added with in djangomako/backends.py:
context['static'] = staticfiles_storage.url

I think this variable should not be used directly. Instead we should use the static helper instead. Quoting a StackOverflow answer:

Since this is the top result on Google, I thought I'd add another way to do this. Personally I prefer this one, since it leaves the implementation to the Django framework.
from django.contrib.staticfiles.templatetags.staticfiles import static

url = static('x.jpg')
# url now contains '/static/x.jpg', assuming a static path of '/static/'

I'm recommending this approach since it will correctly renames x.png to x.f0de3f9.png when needed for cache busting.
Let me know if I should clarify more!

No need @OmarIthawi, and thanks for your suggestion. Please find your comment addressed in #2.
If you have any other comments please feel free to write them. 😄

Awesome 😃

Solved in #2


[Question] How to use OpenAIAssistantRunnable on langgraph?

Hello,
I would like to use OpenAIAssistantRunnable with langgraph, but I faced an error.
I create an assistant as following:
assistant = OpenAIAssistantRunnable.create_assistant(             name=name,             instructions=instructions,             tools=tools,             model="gpt-4-1106-preview",             assistant_id="asst_kqRc9iTKmgv3j5Usr0ulcYSf",             streaming=True         )
After that I create an agent note:
agent = RunnablePassthrough.assign(     agent_outcome = assistant )
Then I use this agent on sample code of langgraph,
but i faced an error as following:
File "/home/thiepnq/Sample/graph.py", line 50, in execute_tools     tool_to_use = {t.name: t for t in tools}[agent_action.tool] AttributeError: 'list' object has no attribute 'tool'
Could you help me to solve this issue.

Hi @nqthiep , Could you share more of your code? It looks like the issue may be that the ToolExecutor node isn't being initialized correctly, but I'm not sure from what has been shared so far

Closing as stale


Separate components that ship separately into their own repos

Is your feature request related to a problem?
Coming from https://github.com/opensearch-project/opensearch-build/issues/2188, it's not possible to release and tag the multiple components (workbench, sql-odbc, sql-jdbc, ...) that come out of this repo separately as, for example, 2.0.0. This means we must release all these parts together, or nobody can ever locate the correct code using tags.
What solution would you like?
The plugins/drivers should live in their own repos.
What alternatives have you considered?
A tagging scheme such as opensearch-2.0.0 vs. opensearch-odbc-driver-2.0.0.

See https://github.com/opensearch-project/opensearch-build/issues/2188#issuecomment-1259874232 in which we decided to split front-end and back-end components. For the SQL plugin there are a lot more individual components. Those that ship separately should split, and those that ship at the same time as the SQL plugin, can stay. @anirudha what do you think we should keep/split?

@YANG-DB I assume you've worked on this. Please close this once done. Thanks!

https://github.com/opensearch-project/sql/issues/964
https://github.com/opensearch-project/sql/issues/965
https://github.com/opensearch-project/sql/issues/966

New Repos generated from internal folder in SQL :

jdbc-sql ==> https://github.com/opensearch-project/sql-jdbc
odbc-sql ==> https://github.com/opensearch-project/sql-odbc
cli-sql ==> https://github.com/opensearch-project/sql-cli
dashboards-query-workbench ==> https://github.com/opensearch-project/dashboards-query-workbench

Main SQL repo remains the plugin container with focus on SQL / PPL engine


BatchInsert Annotation Support?

Is that possible add annotation BatchInsert just as Insert? So we do not copy too much code like
"".

MyBatis version
3.x.x
Database vendor and version
Test case or example project
Steps to reproduce
Expected result
Actual result

I don't think so.
It is just concatenating multiple insert statements and passing it to PreparedStatement#insert() as a single big string which is inefficient. Plus, not all drivers support it.
Please see this FAQ entry for how to perform JDBC batch operation which is suitable for inserting/updating many rows.


691 product product tile fixes

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #691
Test URLs:

Before: https://main--danaher-ls-aem--hlxsites.hlx.page/us/en/products/family/m80-routine-stereo-microscopes
After: https://691-product-product-tile-fixes--danaher-ls-aem--hlxsites.hlx.page/us/en/products/family/m80-routine-stereo-microscopes

Looks good to me.  The CLS is OK on this, but I noticed that as the title header changes the CLS is impacted on Desktop:  https://pagespeed.web.dev/analysis/https-691-product-product-tile-fixes--danaher-ls-aem--hlxsites-hlx-page-us-en-products-family-m80-routine-stereo-microscopes/paomj3uki0?form_factor=desktop


Enable first paginator button when results have an offset.

When using the paginator, naviging to page 2, the first is disabled when the eof is reached.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (911e056) 100.00% compared to head (e040298) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##              master       #19   +/-   ##
===========================================
  Coverage     100.00%   100.00%
- Complexity       218       219    +1
===========================================
  Files             47        47
  Lines            603       604    +1
===========================================
+ Hits             603       604    +1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Integrate kubelogin for Azure AD Authentication to AKS Clusters

What problem are you facing?
We are provisioning Azure AKS Kubernetes Clusters using the Azure Provider by Upbound. After provisioning, we install software inside of the clusters using this Helm Provider as well as the related Kubernetes Provider. When using Local Accounts for authentication with the clusters API servers, this works out of the box. However, we would like to switch to authentication based on Azure AD Service Principals and Managed Identities, as this is the best practice and recommended by Azure. The Kubernetes Go Client which is used by this provider does not support this authentication method by default, so currently we can't use this provider with AKS clusters configured with Azure AD Authentication. As the same problem arises with standard kubectl usage and Terraform providers as well (see e.g. https://github.com/Azure/kubelogin/issues/114), Azure provides the kubelogin client-go credential plugin which can be used to retrieve the user credentials and pass it to the Kubernetes Go Client.
How could Crossplane help solve your problem?
I propose to integrate the official kubelogin Go package into this provider (as well as the Kubernetes Provider), so that it's possible to use it with AKS clusters configured with Azure AD Authentication. I'm open to provide an implementation for this and open a PR. Also, I would be happy to hear the maintainer's thoughts about this. Are you open to such contribution? @turkenh @negz

Related issue in Kubernetes Provider repo: https://github.com/crossplane-contrib/provider-kubernetes/issues/105

I'm encountering the same issue when trying to connect to an AKS cluster with authentication based on Azure AD Service Principals and Managed Identities. The error message indicates that the kubelogin executable is not found.
Error Details:
Type     Reason                   Age                 From                                Message
  ----     ------                   ----                ----                                -------
  Warning  CannotConnectToProvider  23m (x10 over 27m)  managed/release.helm.crossplane.io  cannot create new Kubernetes client: cannot create Kubernetes client: Get "https://test123-aks-23c35881-9a9e-4ee3-aef9-2b4cc02d7d00-rq3nt806.hcp.westus.azmk8s.io:443/api?timeout=32s": getting credentials: exec: executable kubelogin not found

It looks like you are trying to use a client-go credential plugin that is not installed.

To learn more about this feature, consult the documentation available at:
      https://kubernetes.io/docs/reference/access-authn-authz/authentication/#client-go-credential-plugins

kubelogin is not installed which is required to connect to AAD enabled cluster.

To learn more, please go to https://aka.ms/aks/kubelogin

Provided Kubeconfig:
apiVersion: v1
clusters:
- cluster:
    certificate-authority-data: xyz==
    server: https://test123-aks-23c35881-9a9e-4ee3-aef9-2b4cc02d7d00-rq3nt806.hcp.westus.azmk8s.io:443
  name: test123-aks-j5wsb-f2b4q
contexts:
- context:
    cluster: test123-aks-j5wsb-f2b4q
    user: clusterUser_start123-rg_test123-aks-j5wsb-f2b4q
  name: test123-aks-j5wsb-f2b4q
current-context: test123-aks-j5wsb-f2b4q
kind: Config
preferences: {}
users:
- name: clusterUser_start123-rg_test123-aks-j5wsb-f2b4q
  user:
    exec:
      apiVersion: client.authentication.k8s.io/v1beta1
      args:
      - get-token
      - --environment
      - AzurePublicCloud
      - --server-id
      - 6dae42f8-1234-4678-1234-3960e28e3630
      - --client-id
      - 80faf920-1234-4b52-1234-a8e7bedfc67a
      - --tenant-id
      - b9925bc4-1234-4c37-1234-fa456d1bb1c7
      - --login
      - devicecode
      command: kubelogin
      env: null
      installHint: |2
        kubelogin is not installed which is required to connect to AAD enabled cluster.
        To learn more, please go to
        https://aka.ms/aks/kubelogin

using the following manifest for kubernetesCluster:
apiVersion: containerservice.azure.upbound.io/v1beta1
kind: KubernetesCluster
metadata:
  name: test123-aks-j5wsb-wdh8r
spec:
  deletionPolicy: Delete
  forProvider:
    apiServerAccessProfile:
    - vnetIntegrationEnabled: true
    autoScalerProfile:
    - emptyBulkDeleteMax: "10"
      expander: random
      maxGracefulTerminationSec: "600"
      maxNodeProvisioningTime: 15m
      maxUnreadyNodes: 3
      maxUnreadyPercentage: 45
      newPodScaleUpDelay: 0s
      scaleDownDelayAfterAdd: 10m
      scaleDownDelayAfterDelete: 10s
      scaleDownDelayAfterFailure: 3m
      scaleDownUnneeded: 10m
      scaleDownUnready: 20m
      scaleDownUtilizationThreshold: "0.5"
      scanInterval: 10s
      skipNodesWithSystemPods: true
    azureActiveDirectoryRoleBasedAccessControl:
    - adminGroupObjectIds:
      - 6f49479a-1234-480b-1234-741b51a973a1
      azureRbacEnabled: true
      managed: true
      tenantId: b9925bc4-1234-4c37-1234-fa456d1bb1c7
    azurePolicyEnabled: true
    defaultNodePool:
    - customCaTrustEnabled: false
      enableAutoScaling: true
      enableHostEncryption: false
      enableNodePublicIp: false
      fipsEnabled: false
      kubeletDiskType: OS
      maxCount: 10
      maxPods: 30
      minCount: 1
      name: nodepool1
      nodeCount: 1
      onlyCriticalAddonsEnabled: false
      orchestratorVersion: 1.27.3
      osDiskSizeGb: 128
      osDiskType: Ephemeral
      osSku: Ubuntu
      scaleDownMode: Delete
      type: VirtualMachineScaleSets
      ultraSsdEnabled: false
      vmSize: Standard_DS3_v2
      workloadRuntime: OCIContainer
    dnsPrefix: test123-aks-d679da55-b462-415e-8b04-7487ac5bbd3d
    identity:
    - identityIds:
      - /subscriptions/038f2b7c-1234-43b8-1234-c9ad5da610a8/resourceGroups/start123-rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/test123-aks-j5wsb-q46cg
      type: UserAssigned
    imageCleanerIntervalHours: 48
    kubernetesVersion: 1.27.3
    location: westus
    networkProfile:
    - networkPlugin: azure
    nodeResourceGroup: MC_start123-rg_test123-aks-j5wsb-wdh8r_westus
    oidcIssuerEnabled: true
    omsAgent:
    - logAnalyticsWorkspaceId: /subscriptions/038f2b7c-1234-43b8-1234-c9ad5da610a8/resourceGroups/start123-rg/providers/Microsoft.OperationalInsights/workspaces/test123-aks-j5wsb-clzf4
      msiAuthForMonitoringEnabled: true
    publicNetworkAccessEnabled: true
    resourceGroupName: start123-rg
    roleBasedAccessControlEnabled: true
    runCommandEnabled: true
    skuTier: Standard
    tags:
      app: test123
      env: dev
      namespace: start123
    windowsProfile:
    - adminUsername: azureuser
    workloadIdentityEnabled: true
  initProvider: {}
  managementPolicies:
  - '*'
  providerConfigRef:
    name: default
  writeConnectionSecretToRef:
    name: 7867facd-54cd-42ed-8402-bff9af903ba0-akscluster
    namespace: upbound-system

I was playing around with the missing kubelogin - my first idea was to ship the kubelogin simply with the Dockerfile. The result is the following:
kubectl logs -n upbound-system crossplane-contrib-provider-helm-1e553bfdff7a-5f968cb5d8-49kvm
Error: failed to get token: expected an empty error but received: AzureCLICredential: fork/exec /bin/sh: no such file or directory
Error: failed to get token: expected an empty error but received: AzureCLICredential: fork/exec /bin/sh: no such file or directory
Error: failed to get token: expected an empty error but received: AzureCLICredential: fork/exec /bin/sh: no such file or directory
Error: failed to get token: expected an empty error but received: AzureCLICredential: fork/exec /bin/sh: no such file or directory
Error: failed to get token: expected an empty error but received: AzureCLICredential: fork/exec /bin/sh: no such file or directory

The next thing I tried was to add the Azure CLI, which relies on a lot of Python. For that reason, I switched the base image and needed to install many other tools. But the result is still as follows:
kubectl logs -n upbound-system crossplane-contrib-provider-helm-4a269aae5ec5-6cd44f9464-sj8h7
Error: failed to get token: expected an empty error but received: AzureCLICredential: ERROR: Please run 'az login' to set up the account.
Error: failed to get token: expected an empty error but received: AzureCLICredential: ERROR: Please run 'az login' to set up the account.
Error: failed to get token: expected an empty error but received: AzureCLICredential: ERROR: Please run 'az login' to set up the account.
Error: failed to get token: expected an empty error but received: AzureCLICredential: ERROR: Please run 'az login' to set up the account.
Error: failed to get token: expected an empty error but received: AzureCLICredential: ERROR: Please run 'az login' to set up the account.
Error: failed to get token: expected an empty error but received: AzureCLICredential: ERROR: Please run 'az login' to set up the account.

What I tried then was to exec into the provider and did an az login with device authentication. After that, the Helm release was synced, and ready true.
I think adding the right credentials could do the trick, but overall, this way is not the best because the Docker image is more than 650MB, and we rely on some CLI and binary tools. Therefore, we should try to use the suggested kubelogin Go library for better integration.
for reference:
# Use Alpine as the base image
FROM alpine

ARG TARGETOS
ARG TARGETARCH

ENV HELM_CACHE_HOME /tmp/helm-cache
ENV HELM_CONFIG_HOME /tmp/helm-config
ENV HELM_DATA_HOME /tmp/helm-data

# Add necessary binaries
ADD bin/$TARGETOS\_$TARGETARCH/provider /usr/local/bin/provider-helm

# Download and unzip kubelogin binary
ADD https://github.com/Azure/kubelogin/releases/download/v0.0.33/kubelogin-${TARGETOS}-${TARGETARCH}.zip /tmp/kubelogin.zip
RUN unzip /tmp/kubelogin.zip -d /tmp && \
    mv /tmp/bin/$TARGETOS\_$TARGETARCH/kubelogin /usr/local/bin/ && \
    rm -rf /tmp/kubelogin.zip /tmp/bin

# Install Azure CLI
RUN apk add --no-cache --update python3 py3-pip && \
    apk add --no-cache --update --virtual=build gcc musl-dev python3-dev libffi-dev openssl-dev cargo make && \
    pip3 install --no-cache-dir --prefer-binary azure-cli && \
    apk del build

# Create .azure directory
RUN mkdir -p /home/65532/.azure && chown -R 65532:65532 /home/65532/.azure

USER 65532
ENTRYPOINT ["provider-helm"]

Thanks a lot @haarchri for your investigations. I agree that we should better fix this in the go code rather than introducing binaries and other dependencies as you've find out.
I believe we can come up with a similar API and solution as https://github.com/crossplane-contrib/provider-helm/pull/109 here, and started looking the code at https://github.com/Azure/kubelogin. Based on my observations so far, the code there is not friendly to be imported as a library with private methods and inflexible options in the exposed methods. I will dig further.


SetWindowLongPtr is not generated

Actual behavior
SetWindowLong is generated, but SetWindowLongPtr is not.
Expected behavior
SetWindowLongPtr should be generated to be able to set a pointer value on window.
Repro steps

NativeMethods.txt content:

Windows.Win32.UI.WindowsAndMessaging

NativeMethods.json content (if present):
N/A

Any of your own code that should be shared?

unsafe private static LRESULT WindowProcedure(HWND window, uint message, WPARAM wparam, LPARAM lparam)
{
    if (message == PInvoke.WM_CREATE)
    {
        var createStruct = (CREATESTRUCTW*)lparam.Value;
        PInvoke.SetWindowLongPtr(window, WINDOW_LONG_PTR_INDEX.GWLP_USERDATA, (IntPtr)(*createStruct).lpCreateParams);
    }

    return PInvoke.DefWindowProc(window, message, wparam, lparam);
}

Context

CsWin32 version: 0.1.635-beta
Win32Metadata version (if explicitly set by project): N/A
Target Framework: net6.0
LangVersion (if explicitly set by project): 10.0

This works as you expect when you target x64. AnyCPU or x86 targeted compilations don't get SetWindowLongPtr because that function only exists for 64-bit processes.
CsWin32 only generates arch-specific APIs when your compilation commits to those architectures, so this is by design.

If it is by design then that honestly sounds like bad design. When you include windows.h you get SetWindowLongPtr, even on 32 bit processes. The documentation even recommend you to use it to be compatible with both 32 bit and 64 bit systems:

Note  To write code that is compatible with both 32-bit and 64-bit versions of Windows, use SetWindowLongPtr. When compiling for 32-bit Windows, SetWindowLongPtr is defined as a call to the SetWindowLong function.

The Win32 api docs say that this function is available. This library is a wrapper around the Win32 api. The function is missing from the wrapper. This should be considered a defect, not "design".

This library is a wrapper around the Win32 api. The function is missing from the wrapper.

Not exactly. This is a source generator that transforms a metadata file into C#. It doesn't read header files or try to cover any more than the metadata does in general. In some cases we go slightly beyond it just to make the existing APIs more usable, but we don't add extra APIs. CsWin32 is used with other metadata inputs than Win32Metadata, so in fact adding win32 APIs to other libraries' C# projections would be wholly inappropriate.
But I want to give you what you're asking for here. If we can get the codebase to a point where it can be flexible enough to do this, and after we get the defective code generation bugs fixed, we can circle back and look at adding conveniences like this.
It's easy for C++ to support what they do because they use macros in the header files. But in C# we can't invoke macros. We can only invoke real exported functions. And sure, we can emit totally custom code to make up for that, but users can write that code themselves too, so we need to prioritize the defect bugs.
Thanks for understanding.

I'm also hearing: contributions potentially welcome.

Yes, in general they are. But anything more than a trivial change should be presented in an issue with a design proposal before sending a PR to help avoid wasted effort in case it's not a PR we could accept or at least not in a particular form.
And just as fair warning for this issue, if the solution added general complexity to the overall system, we may turn it down at least for now since we don't want the added complexity to slow down our fixing of the defect issues.


Unit Test Naming Conventions

I vote:

handler tests end in "Should"
controller tests end in "Tests". the reason I think this is b/c some of our controller's are so large, and some of the semantics are "long" b/c of the work they're doing in a single action method, that ending in the word "Tests", IMO, makes naming the unit tests easier
anything that is NOT a controller unit test (providers, services, etc..) should end "Should"

thoughts?

@mgmccarthy Sounds reasonable to me. Probably something we introduce over time. Perhaps some good jump in issues to on-board new contributors as well. Something for our coding conventions concept as well.

@stevejgordon the code is already moving in this direction, but I agree, this refactoring is a good "jump-in" label...
@tonysurma did yo want to mark this "jump-in" as @stevejgordon suggested?

Sounds like a good item for folks to jump in on so agree.
Also sounds like an item to add to wiki
@MisterJames any other thoughts?

@tonysurma Love to pick this up. can you assign this to me please?

@bmaluijb, what would also be nice to roll into this task is not only the technical work, but to update our "Humanitarian Toolbox Developer Guide" at http://htbox.github.io/ under the DevelopmentGuidelines section at http://htbox.github.io/development-guidelines.html.
This site is a separate repository that is written using Markdown. You can find the repo here:
https://github.com/HTBox/htbox.github.io
If that's asking too much, @tonysurma, I recommend breaking out the updating of the Developer Guide into a separate Issue and labeling with jump-in.

Sure, that seems a good fit. It seems silly to do the technical work and keep the documentation outdated.

@tonysurma could you please assign me to this one?

@tonysurma I was trying to assign @bmaluijb but seems he's not in the list. Over to you!

Yeah with a recent update to GitHub you have to invite someone to repo before you can assign.  Will do that when I am on a PC later.  Thanks

@tonysurma Will this interfere with our code-a-thon that is coming up? Can we turn it off temporarily for that day or have people work on issues without being assigned to them?

@tonysurma any news on this one?

@bmaluijb sorry for delay, assigning and related items are the one thing I can't do on mobile and been in transit lately.
As for the codeathon, no this won't.  This has been in place by GitHub for about a year and isn't a turn on/off item.  What folks do is put a comment on the item they are working on to say "I am working on this" or similar and that is the flag for others.

@bmaluijb you have been invited to collaborate on this repository, once you accept I can assign you

Thanks @tonysurma !

@tonysurma I've created two PR's for this:

https://github.com/HTBox/allReady/pull/1404
https://github.com/HTBox/htbox.github.io/pull/6

Hi, I'm new to the project and going through 'jump-in' issues to hopefully find issues to contribute on.  It seems that this issue has been resolved with merged PRs from @bmaluijb and can be closed?


Modal autofocus option doesn't work

The paramenter "autofocus" for the modal() module has no  effect.
I have a modal dialog with a login form inside and and none of the input fields gets focused after show.
The code of modal.js reveals that the problem seems to be the use of $module.filter(':input') to select the input elements. In my case $module is the jquery-wrapped "div" containing all the dialog contents and filter's job is to filter an array of elements by applying a selector to them, not that of "finding" child elements.

This code is just wrong. Sorry about that

What about making this autofocus feature more flexible by allowing it to receive a boolean or a function/callback that would set the focus?
I am thinking about scenarios where I wouldn't want to the set focus on the first input or where my first field isn't exactly an input (e.g a select2 dropdown).

You always have the "show" action callback to perform more complex tasks that's the one i'm using now to focus the first input. By the way, are you sure $(':input') doesn't match a select2 dropdown. I've tried here https://select2.github.io/examples.html but without a clear answer

But we have a multi select :smile:

Right now I am using the show action callback for this, but it doesn't seems quite "right" to me. Also it took me sometime to figure I could pass a callback to it, since there's no example of this in the documentation.
Maybe something with an onVisible callback would make more sense, but it will be called before autofocus :(

@jlukic multi select currently doesn't have all the features I need :(

What features?

I created an issue about they: https://github.com/Semantic-Org/Semantic-UI/issues/2746

Met the problem. Hope 2.1 will come soon.


#19 Add restricted file handling

Resolves #19

[x] When a video file is found by the transcoder, check to see whether the basename ends in 'RESTRICTED' and ignore if so.
[x] Create a ticket to lint the transcoder #20

Testing

Create a dev.env file: cp dev.tmpl.env dev.env
Add the watch folders to your filesystem... e.g.

SMB_WATCH=/Users/sloffler/Code/transcoder-test-folders/watch
SMB_ACCESS=/Users/sloffler/Code/transcoder-test-folders/access
SMB_WEB=/Users/sloffler/Code/transcoder-test-folders/web
SMB_MASTER=/Users/sloffler/Code/transcoder-test-folders/master
SMB_OUTPUT=/Users/sloffler/Code/transcoder-test-folders/output

Build the project: make build
Run tests: docker exec -it transcoder_transcoder_1 make test
Make a short video file with the name: B2004203_mo01_RESTRICTED_AmazingVideo.mp4
Add it to your watch folder
Start the transcoder: make up
Note that it doesn't get transcoded
Remove RESTRICTED from the filename, delete the .lock file, and start the transcoder again: make up
Note that it does get transcoded

@alihaberfield Good catch. I'll create a ticket for us to fix that later: https://github.com/ACMILabs/transcoder/issues/22


Non-unit test versions of full cross-matches as a suite of tests

The code could offer full end-to-end test suites for various combinations of cross-matches, via the creation of simulated datasets which are then subject to noise, crowding, etc.
These catalogues, with a known truth, could be used as larger diagnostic sets for completeness, false positive/negative rates, baselines for optimisation comparisons, etc.
Likely easier to wrap the catalogue creation code -- certainly for small, ~square degree regions of simulated sources -- with optionally fixed RNG -- for ease of transportation, instead of creating simulated objects and carrying those around. Of course, this assumes the creation of O(10^5 - 10^6) objects, but that should hopefully be relatively computationally efficient.

Probably want some or all of these tests to be run:

Catalogues not subject to perturbation (i.e., include just noise in positions)

With photometric likelihood
Without photometric likelihood ("naive Bayes" cross-match)

Subject one (or both) catalogue(s) to crowding from blended sources

Without both extra AUF component or photometric likelihood
With just extra AUF component
With just photometric likelihood
With full treatment of both AUF components and photometric likelihoods

Astrometrically shifted data (or just simulate sources independently in position), to test false positive rate

Most likely only run the full cross-match for the false positive test, but could include all combinations of treatment

Possibly wrap code for downloading and setting up a "real world" test

Gaia vs WISE as the current poster child of these matches?

Upwards of 8 tests might be quite a few, but current run times are of order an hour for 42 square degrees of Gaia-WISE cross-matches in the Galactic plane, so a reduction by a factor 10 in area (running 2x2 degrees, to give ~4 "regions") might potentially still be feasible, especially with any optimisation of the algorithms versus V0.1.


Okta support

Same thing as the sal-saml container. This adds Okta support. So that I didn't create merge conflicts I've pre-merged @erikng's two open PRs. Thus merging this one PR will merge all open requests for this repo.
This updates djangosaml2 to 0.15.0 to support okta without crashing. I've also updated the docs and changed all sample URLs to sal.example.com so it is easier to follow the README and settings.py, plus we can now do a find all and replace.
I've also created a temporary test container:
repo: clburlison/crypt-server-saml-test
tag: 2.2.0-okta
I have not tested this update with OneLogin or Okta at this time.

Alright, I was able to spin up a OneLogin instance on their Developer platform. I've now tested this with Okta and OneLogin. I've also updated the documentation so that hopefully it is more clear.
At least it is clear to me since I was able to get both instances working


Fix segfault by ensuring that we have created the context in the VM. …

…(#189)

Fix segfault by ensuring that we have created the context in the VM.
https://github.com/envoyproxy/envoy-wasm/issues/180

Signed-off-by: John Plevyak<EMAIL_ADDRESS>For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

cc @istio/release-managers-1-3


Update README.md

Add Templates command to help output.

Opened https://github.com/devcontainers/devcontainers.github.io/pull/121 for containers.dev, and working on separate PR for VS Code docs.


Removing lifetime parameter for Executor and LocalExecutor

What is the point of it? It is not reasonable to statically track the lifetime of Executor which only contain a Arc.

IIUC, this is needed to spawn a non-static future: https://github.com/smol-rs/async-executor/commit/f9e28cd6d8ed85af9efcac870562394bb667cf59
https://github.com/smol-rs/async-executor/blob/dacd4db652a8062cedd835e4c1f9da0e4e0d32d0/src/lib.rs#L68-L69
https://github.com/smol-rs/async-executor/blob/dacd4db652a8062cedd835e4c1f9da0e4e0d32d0/tests/drop.rs#L76
See also safety requirements of async_task::spawn_unchecked


rancher-gatekeeper chart sets --exempt-namespace to wrong Namespace on gatekeeper-controller-manager

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

Deploy the rancher-gatekeeper 3.3.000 chart in a Rancher v2.5.7 instance

Result:
Observe the --exempt-namespace arg on the gatekeeper-controller-manager Deployment is set to gatekeeper-system where the gatekeeper chart is actually installed in the namespace cattle-gatekeeper-system.
Other details that may be helpful:
The hardcoded gatekeeper-system value (https://github.com/rancher/charts/blob/release-v2.5/charts/rancher-gatekeeper/rancher-gatekeeper/3.3.000/templates/gatekeeper-controller-manager-deployment.yaml#L57) appears to originate from the upstream v3.3.0 chart (https://github.com/open-policy-agent/gatekeeper/blob/v3.3.0/charts/gatekeeper/templates/gatekeeper-controller-manager-deployment.yaml#L57), but has subsequently been updated upstream to {{ .Release.Namespace }} (https://github.com/open-policy-agent/gatekeeper/blob/v3.4.0/charts/gatekeeper/templates/gatekeeper-controller-manager-deployment.yaml#L49).
In addition to setting the default --exempt-namespace dynamically and adding the admission.gatekeeper.sh/ignore label to the Namespace (https://github.com/open-policy-agent/gatekeeper/blob/v3.4.0/charts/gatekeeper/templates/namespace-post-install.yaml), it would be helpful to allow a templated list of additional --exempt-namespaces to permit user exemption of other Namespaces, such as kube-system (https://open-policy-agent.github.io/gatekeeper/website/docs/exempt-namespaces/).
Environment information

Rancher v2.5.7 / rancher-gatekeeper 3.3.000

The issue is with 2.5 chart. This release line is EOM as of v2.5.12 & the only fixes to follow will be the security patches and/or high severity bugs. Closing this issue since it's no longer required.


Help text is not showing when used in actions

Not sure if this package is meant to be used in actions but so far everything seems to work great, except for the help text that is missing.

Help text doesn't show in forms either.


BLE split keyboard

Hello, first I want to say thanks for writing this great project, I'm very interested in seeing it grow
I just wanted to comment here about something, for wireless split keyboards being able to use either side as the master is fairly important, because the master side usually uses a lot more battery meaning it will die first (and need to charge) before the other side, for this reason a lot of wireless split keyboards choose the master side depending on higher battery voltage each time they power up
(also, having the ability to plug in either side with USB and have it work automatically is cool)
once again thanks for your work, I'll try my hand at helping with code once I have hardware that supports it and I get further in the rust embedded book

I just wanted to comment here about something, for wireless split keyboards being able to use either side as the master is fairly important, because the master side usually uses a lot more battery meaning it will die first (and need to charge) before the other side, for this reason a lot of wireless split keyboards choose the master side depending on higher battery voltage each time they power up

Thanks a lot for the reminder!
I did consider the auto-master-switching feature, but I found it is quite difficult since RMK implements the split keyboard in a single-master + multiple-slave way. That means it's possible to make a multi-split keyboard, but brings the complexity of choosing the master. I haven't got a good idea about how to implement it, do you have any reference, or code example for how to implement it? I'd like to add this awesome feature.

I actually misremembered, they just use random numbers here https://github.com/vE5li/butterware
But this should be helpful since it's also in rust and embassy, the relevant function is in the split determine.rs file
I also thought zmk already had this implemented but apparently not, maybe I read the to do list long ago and assumed it would be done four years later, lol
Having it over more than two devices will be quite a bit more complex, you could have a specific config for like if it's just two halves then you can use it, and if it's more you have just one central? That would make things easier and would (in my opinion) cover most cases, but having it be generic and for any number of pieces would be better

Thanks for the reference! I'll take a look. Currently I'm focusing on implementing basic functionalities of the split keyboard(there is still lots of work to do..). I'll keep it in mind making sure we can add this feature with little effort.
If you want to involve, I'd be very happy to help:D


Introduce a failing test for char[] type conversion

When I have a char[]-typed @Option in my command-line object, I get an error when trying to set it from the command line:
Invalid value for option '-charArray' (<charArrayField>): 'abcd' is not a single character

It appears that Picocli treats char[] as char. The expected behavior instead would be that the input String is converted to char[] using its toCharArray() method.
Couple more notes:

Using char[] as the data type is a pretty common thing when the parameter is a password. The array can be manually zeroed when the password is no longer needed, thus completely removing it from memory while its parent object still lives.
Using String for the same purpose is sub-optimal, as JVM does all kinds of magic with Strings and the password could, for example, be interned - irrevocably burning it into the JVM memory for the entire runtime of the application.
The original code is lifted directly from a JCommander-based implementation, which handled this situation properly.
I attempted to fix the problem, but the type conversion code seems very convoluted. Without gaining a deep understanding of all the code branches, I risk causing more problems than I solve.

Hi,
What you're saying makes total sense. It has been on the todo list to improve this but other things took priority.
As you pointed out, the type conversion logic in picocli is not easy, because it needs to support adding values to multi-value types like Map, Collection and arrays, as well as simply replacing values of single-value fields. However, I have some idea for adding support for password char[] values without changing the type conversion logic too much.
I am considering combining a fix for this with #536 to improve password handling overall and cutting a separate 3.9.x maintenance release for this.
How urgent is this for you? I am currently working on #358, which is quite involved and will probably take some more time. I'd like to finish that and do a picocli-4.0-alpha-1 release before context-switching to the topic of passwords.

@remkop I can wait. Combining this with #536 makes a lot of sense.

@triceo Would you be okay with getting this in 4.0.0-alpha-2, or do you need a backport to the 3.9.x branch? I would prefer to spend as much time as possible on 4.0...

@remkop That depends on how many incompatible changes there are in 4.0, and when that is coming out. Right now, I don't know anything about the release.

So far it’s all backwards compatible.
The final GA release is a few months away, but the alpha releases are high quality and pass all 1500+ unit tests.
I’m releasing this functionality as alpha releases so that I have the option to change the API if peer review turns up any issues.

@remkop Unfortunately, the release rules won't let me depend on a non-final artifact. That said, I understand your motivation for not putting this into a 3.9 - I'll wait for a final 4.0 then.

the release rules won't let me depend on a non-final artifact.

Understood. Thanks for the clarification. I’ll try to do a separate 3.9.x release for these then.

@triceo I’ve pushed some commits to the 3.X branch to improve support for interactive (password) options. I’ll create a 3.9.6 release for this soon, maybe later today.
This includes the char[] type support you requested, but I’ve limited my changes so far to only impact interactive options.
So, for “normal” (non-interactive) options, using a field of type char[] still works similar to using a field of type int[]: picocli expects each option parameter to be a single value that can be converted to a char or int and added to the array. Your PR adds a test for “normal” (non-interactive) options, and this test will still fail, so I cannot merge this PR yet.
It does make sense to go one step further and treat char[] more like Strings than like int[] also for “normal” (non-interactive) options. (I’ll probably hold off on this until 4.0.) Making this change would potentially break existing applications so we need to provide a setting that allows users to switch back to the old behavior. Any ideas for a good name for such a configuration?

Hmm... picocli.disableCharArrayToStringConversion?
A bit long, but descriptive.

Adding some ideas:

charArraysCanCaptureStrings
charArraysCaptureSingleCharacters

I just took another look at this, but I'm not sure that I want to go ahead with this:
The main goal (support for char[] types for interactive password options) has been achieved in 3.9.6.
This ticket is still open because we are considering to go one step further and also allow normal (non-interactive) options to capture multi-char (String) values in a char[] type. On the face of it this would make things more consistent, but I hesitate to go ahead:

I'm not sure if there is any user demand for this (nobody asked for this)
it would introduce more special logic for char[] in a few places, like CommandLine$Interpreter.getTypeConverter and CommandLine$Interpreter.applyValuesToArrayField (this is a minor issue, just mentioning it)
I am unsure how to deal with multiple values: append to the array, or overwrite the previous value? For other array types, the expected behaviour is to append, while for single value types the expected behaviour is to overwrite. Would we need to introduce another parser switch for this? Seems overkill since nobody asked for this...

So I will probably postpone this remaining work until someone asks for this feature.
Thoughts?

@remkop It is true that, since 3.9.6, my use case is solved and I don't need anything more. If doing this feature in its entirety is too much for the existing system, feel free to postpone/ignore it. :-)

Finally merged! 😅
Thank you for the contribution!


Create 2DChart component

Based on the conrec output format be able to draw contours.
You may check the kind of output based on the test cases:
https://github.com/mljs/conrec/blob/master/src/__tests__/conrec.test.js
There should be 2 colors: one for positive and one for negative.
This new component should use D3 for calculations. You should check how it was done for the 1D.
Please make incremental commit so that we can comment quickly and efficiently.

Instead of just two colors, why not have the possibility to define a color map or have a function returning the color code(sign,contour number)

Yes indeed a color per contour layer may be planned it will give more flexibility.
By the way the conrec algorithm returns closed contour which means that it is possible to fill each contour. This is also a feature we could use in the future.


Comparing another known ruby 3/rails 7 fork

Why
Until we move to rails AR 7 encryption, we need this gem. Another team has previously used a similar branch, however this one has a couple minor additional changes - notably a ruby 3 fix, and a few other methods were renamed. TBH from what I've seen I think we don't strictly need the other renames, however there are some breaking changes:

SomeModel.encrypt/decrypt is renamed to .attr_encrypted_encrypt/.attr_encrypted_decrypt
some_record.encrypt/decrypt is renamed to #attr_encrypted_encrypt/#attr_encrypted_decrypt
This is so that the methods don't conflict with methods added in AR 7 encryption

What is changing
See above - most methods get prefixed with attr_encrypted_ to clarify they are not using AR 7 encryption
How I tested

Security 🛡 (required)
Checklist

[ ] Reviewed the Checklist

How does this PR handle security?

Screenshot

Next steps

🙏 thanks @6! To get tests working I ended up creating a new branch based off this (since this is coming from another github org I couldn't add it into this same branch/PR), see #3


bidResponse.currency - required or not?

The doc says bidRequest.currency is required, but in the same sentence it says it has a default value of 'USD'. I find that confusing. If there is a default value, is it really required?
Same goes for netRevenue and ttl.

@thewizarodofoz -- Thanks for pointing this out.  We will remove the wording specifying default values for required fields on the bidObject.

Looks like this was addressed in https://github.com/prebid/prebid.github.io/pull/390 , so I'll close.  Thanks for pointing this out, @thewizarodofoz


Excluding files with 100% coverage from the clearTextReporter

Is your feature request related to a problem? Please describe.
We adhere to a test policy mandating that all modifications made by developers to the source code reach 100% test coverage. While deviations are permissible, they must be clearly denoted through explicit exceptions in the form of corresponding comment blocks, which the test system recognizes.
To enforce this policy, we set the coverage threshold to 100% (utilizing thresholds: { break: 100 }). This ensures that every change is accompanied by either a test or a formally acknowledged deviation, as indicated by comments like // Stryker disable ....
When assessing our progress using the score table from the clear-text reporter, numerous rows with a 100.00 value in the score column are displayed, which makes it more difficult to find the file that still need to be worked on, especially with a large code base.
-----------|---------|----------|-----------|------------|----------|----------|
File       | % score | # killed | # timeout | # survived | # no cov | # errors |
-----------|---------|----------|-----------|------------|----------|----------|
All files  |   99.70 |      987 |         0 |          3 |        0 |        0 |
 file1.js  |  100.00 |       10 |         0 |          0 |        0 |        0 |
 file2.js  |   90.00 |        9 |         0 |          1 |        0 |        0 |
 file3.js  |  100.00 |       10 |         0 |          0 |        0 |        0 |
 ...       |     ... |      ... |       ... |        ... |      ... |      ... |
 file33.js |  100.00 |       10 |         0 |          0 |        0 |        0 |
 file34.js |   90.00 |        9 |         0 |          1 |        0 |        0 |
 file35.js |  100.00 |       10 |         0 |          0 |        0 |        0 |
 ...       |     ... |      ... |       ... |        ... |      ... |      ... |
 file97.js |  100.00 |       10 |         0 |          0 |        0 |        0 |
 file98.js |   90.00 |        9 |         0 |          1 |        0 |        0 |
 file99.js |  100.00 |       10 |         0 |          0 |        0 |        0 |
-----------|---------|----------|-----------|------------|----------|----------|

Describe the solution you'd like
Similar to the --skip-full option in https://github.com/bcoe/c8, an option to hide files with a perfect score in the clear-text reporter would be great.
Using this option should produce the following report compared to the example above:
-----------|---------|----------|-----------|------------|----------|----------|
File       | % score | # killed | # timeout | # survived | # no cov | # errors |
-----------|---------|----------|-----------|------------|----------|----------|
All files  |   90.00 |       27 |         0 |          3 |        0 |        0 |
 file2.js  |   90.00 |        9 |         0 |          1 |        0 |        0 |
 file34.js |   90.00 |        9 |         0 |          1 |        0 |        0 |
 file98.js |   90.00 |        9 |         0 |          1 |        0 |        0 |
-----------|---------|----------|-----------|------------|----------|----------|

We are open to contributing a merge request. 😃
An open question would be how you want to deal with the all files entry. Whether it should only refer to the displayed lines (as here), to all lines (as above), or not be displayed at all if the new option is used.
For us, each variant would be equally suitable, as this summary has no influence on our reviews.

Hi @sebiniemann, and welcome. I'm sorry I didn't reply sooner. I've been quite busy and have yet to notice this issue sneaking in.
This sounds like an excellent new feature. It seems like a great addition to the clearTextReporter option. The name 'skip full' sounds good 👍.

An open question would be how you want to deal with the all files entry. Whether it should only refer to the displayed lines (as here), to all lines (as above), or not be displayed at all if the new option is used.

Ah yes. I would say the All files shouldn't be shown when all files result in a 100% score. And with that, we can also choose to not show the table at all in that case. What do you think?

And with that, we can also choose to not show the table at all in that case. What do you think?

Sounds good to me.
I've created a pull request (#4875) to implement this feature. I wasn't sure where you wanted these changes, so I've tried to be minimally invasive while covering everything mentioned -- excluding files with a 100% score, skipping "All files" and omitting the entire table if all files achieve a 100% score.


Brew auth is default to not be set

Brew token is not mandatory for rhods addon since we pick released version from the API.
For version 1.29.0 the fact we set it caused failures.

/verified

Wont do


Fails if line does not start with address

$readmemh in iVerilog defaults to starting at the lowest address when the text input file does not define a starting address. This program doesn't account for this and just breaks if an address isn't provided at the beginning of each line. A simple fix would be to have the program assume an address of 0 if one isn't provided, though this doesn't necessarily reflect readmemh's actual behavior.
I'll accept a pull request that implements the simple fix above or a better solution.

Hey,I would like to contribute to this issue. Please assign it to me.


Dark UI in Linux?

Hi, I just installed ungoogled-chromium on my Windows partition and I noticed the whole UI was dark by default. On both of my Linux machines (one running the appimage, the other one the package from the ppa), the whole menus are white. Is it an expected behaviour? If yes, is there a way to turn it completely dark, like on the Windows build? Or maybe this has something to do with GTK? I'm pretty lost tbh :laughing:

Just use these flags when starting chromium
--force-dark-mode
--enable-features=WebUIDarkMode

Just use these flags when starting chromium
--force-dark-mode
--enable-features=WebUIDarkMode

Thank you!

@jstkdng Does #enable-force-dark work for you in 85? On my system, it inverts the content, Developer tools, but not the UI: tabs, address bar, menu are all still white.

@PF4Public
Yeah, if you use the GTK+ theme it will depend on your current theme. Using the classic option makes everything dark regarldess of the GTK theme.

why can't the browser detect the system's theme ?

Just use these flags when starting chromium
--force-dark-mode
--enable-features=WebUIDarkMode

To further help mitigate the issue for those who are wondering how they can force dark mode permanently but not use Google's "Force Dark Mode for Web Contents" e.g. because honestly Dark Reader is better, I would like to quote this post:

@pashinskikh If you're asking for a good way to do this, you'd create a file with full path ~/.var/app/com.github.Eloston.UngoogledChromium/config/chromium-flags.conf and the contents of this should be:
--force-dark-mode
--enable-features=WebUIDarkMode


Changes for passing filterbank tests and Ignite0.4.2 changes

This PR does two things:
Raises the atol for L118 for tests/ml/test_filterbank.py to 1e-5
This is a small patch for now that should be fixed in a later update. @pseeth mentioned that the reason for this breaking is type changes.
BaseDataset now inherits Iterable
Pytorch-Ignite requires that any dataset used in a Engine inherits Iterable. I have also also implemented a simple __iter__ function, as Iterable requires this.

LGTM

LGTM, let's wait for tests and squash + merge.


Legend name does not update with new file name

https://i.imgur.com/8Gi7aWe.png
Borked - see title.

This isn't a bug, you set the name of the line within the configuration of the graph.
Check out docs here: https://github.com/feds01/Graphika/blob/main/docs/api/legend-options.md


Add fill level sprites for all the drinks

About the PR

You heard me.
Which drinks? These drinks:

Why / Balance

It bothers me that we have nice fill level visuals for drinks in plain glasses, while all the fancy drinks are stuck with a single, static sprite. So I changed that.
Technical details

No code changes, but have fun with the number of files changed!

This PR requires #25022 in order to function, so it's a draft until that gets merged.
Media

Note: Drinks marked with "Tint" use the actual solution color instead of one baked into the sprite. Many drinks were not able to support this, typically due to details that would be lost. Also, some of the previews here show the fills as white - this is because Aseprite doesn't have a convenient way of applying a tint with alpha, and I got tired of trying to fake it each time, so you'll just have to use your imagination.
Absinthe (Tint):

Acid Spit (Animated):

Ale (Animated):

Allies Cocktail:

Aloe:

Amasec:

Andalusia:

Antifreeze:

Atomic Bomb (Animated):

B-52:

Bahama Mama (Tint)

Banana Honk:

Barefoot (Tint):

Beepsky Smash (Animated):

Beer (Tint):

Black Russian:

Blood:

Bloody Mary (Tint):

Booger (Tint):

Brave Bull:

Cafe Latte:

Champagne (Tint) (Animated):

Coffee Liqueur:

Cogchamp (Animated):

Cognac (Tint):

Cuba Libre:

Demon's Blood (Animated) (Tint):

Devil's Kiss (Tint):

Doctor's Delight (Animated) (Geneva Conventioned):

Driest Martini:

Erika Surprise (Tint):

Gargle Blaster (Animated):

Gildlager (Tint):

Gin Fizz:

Gin & Tonic/Vodka & Tonic:

Gin/Vodka:

Green Tea/Iced Green Tea:

Grenadine (Tint):

Grog (Tint):

Hippies' Delight:

Ice Cream (Tint):

Iced Beer:

Iced Coffee:

Iced Tea:

Irish Car Bomb:

Irish Coffee:

Irish Cream:

Kira Special (Animated):

Lemonade:

Long Island Iced Tea:

Manhattan Project (Animated):

Manhattan:

Manly Dorf:

Margarita (Tint):

Martini/Vodka Martini:

Mead (Tint):

Mojito:

Neurotoxin (Animated):

Nuclear Cola (Animated):

Patron (Tint):

Poison Wine (Tint) (Animated):

Red Mead (Tint):

Rewriter (Tint):

Rootbeer Float:

Rootbeer:

Rum/Deadrum:

Sbiten (Tint):

Screwdriver:

Silencer:

Singulo (Animated):

Snow White:

Soy Latte:

Sui Dream:

Syndicate Bomb (Tint):

Tequila Sunrise:

Tequila:

The Martinez:

Blue Curacao/Melon Liquor (Tint):

Three Mile Island (Animated):

Toxins Special (Animated):

Vermouth:

Whiskey Cola:

Whiskey Soda:

Whiskey:

White Russian:

Wine (Tint)

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Nah.
Changelog

:cl:

add: Added fill level visuals to all the drinks. Cheers!

These are fantastic.
I can think of a very nice interaction with a bartender as you can actively watch him fix a drink from a mixer.

as much as i want to review 3850 changes im gonna have to just trust you dawg


Add the example on how to communicate with particular node(s)

Problem
The user submitted an issue asking how to communicate with particular node(s), so seems like it's not very clear from the Java SDK codebase.
Solution
To add an example of how to communicate with particular node(s).
For reference, see the issue #1569  and PR #1570.
Alternatives
No response

Please assign me to this issue @thenswan


[atip] Add new step for atip

Impacted TCs num(approved): New 1, Update 0, Delete 0
Unit test Platform: Crosswalk Project for Android 15.44.374
Unit test result summary: Pass 1, Fail 0, Blocked 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-4757

LGTM


Restore insertion marker fields; set them to display: none

Here is a strawman fix for #250. It reverts #215 and extends the old methodology to vertical blocks.
Basically, the fields are "actually" rendered and then hidden. After thinking about it, I'm pretty sure there's no way around this unless we grab dimensions from the block generating the insertion marker. If you wanted to try implementing that instead, we could do it...

Is the goal for the blocks to be exactly the same size as the originating block?
Agreed that the only way to get proper dimensions without fully rendering is to grab dimensions from the other block.

^ yep, they should be the same size as the originating block. Well....actually, I guess except for statement inputs....
I'll merge for now :)