Art Request for Blog - FlowFuse Device Agent  as a Service on Windows

Related Issue
1384
Description
Considerations:

Where will the image be displayed/shared, product? blog post? social media? presentation? website?

The biggest takeaways are "Auto start on reboot on Windows"  Those are the keywords that we would like to be incorporated in the artwork.
Key is to highlight Windows vs Linux or other platforms.
Inspirations:

<windows service manager>

Blog - https://github.com/FlowFuse/website/pull/1384

Image added to the PR 😉

Hi @Steve-Mcl let's have a chat so I can better understand the message it should convey.
Should I use the same title as the article instead?
"Running the FlowFuse Device Agent as a service on Windows"

Yeah, I am good for a chat in the morning @Yndira-FlowForge
Also, if in the mean time Grey pops in and overrules (more than happy for that) then fine also.
In the mean time, I will put my thinking cap on and be prepared for a chat tomorrow.

The image you did for the PI + Device agent was a nice layout
https://flowfuse.com/blog/2023/11/raspberry-pi-5-flowfuse-edge-agent/
Perhaps something similar for Windows might be better suited?
Here is my best effort (dont laugh)

The wording might still need a little work.
Perhaps "Run Node-RED with FlowFuse Device Agent as a Windows Service"

Thanks for the reference @Steve-Mcl!!
I did this using your image as guide.

But reading the title, maybe it makes more sense to replace the FlowFuse logo inside the device with the Node-RED one? I did that version too just in case you guys think it works better 😉

I think the 2nd one (with Node-RED inside the service) is fine.
I am not 100% certain I nailed the title. I did suggest an alternative but still not sure 🤔
Could I be a total pain and ask for a few variations (of the Node-RED version) with different titles so that when Grey comes online later today he has something to chose from?  If that is too much of an ask, then please wait for Grey to evaluate and suggest a final title (Just wanted to see if we can make a jump on it as I seem to remember you saying art requests must be in before end of today?)
Alternative versions

V2a - the Node-RED version (already done)
V2b - with the title "Run Node-RED as a Windows Service with a FlowFuse Device Agent"
V2c - with the title "Run your FlowFuse Device Agent as a Windows Service"
V2d - with the title  "Run and Manage your Node-RED edge instances in a Windows Service"

Thankyoooooo.

I said art requests must be in before the end of next week 😉
So we can wait until @gdziuba comes online, and I'll only update the artwork once to the final version.

I said art requests must be in before the end of next week 😉

🤦♂

So we can wait until @gdziuba comes online, and I'll only update the artwork once to the final version.

Perfect
Thanks Yndira.

Hi @gdziuba, could you please provide the title so that I can update the image accordingly? Thank you!

@Yndira-FlowForge
Title: Running Node-RED as a service on Windows
Subtitle: Step by step guide to run FlowFuse device agent as a Windows service

Here's the updated image

@Yndira-FlowForge Can you remove the subtitle?  Thank you.

There you go 😉


Support for checkstyle plugin java.

Hi! Is it possible to add checkstyle linter support in guard-collection.

Just took a quick look, it doesn't seem that checkstyle has a widely used cli interface.

Just took a quick look, it doesn't seem that checkstyle has a widely used cli interface.

You can actually install checkstyle in ubuntu using sudo apt install checkstyle.

Sure then I guess pr is welcome.
Feel free to ask any questions :)

Sure then I guess pr is welcome.
Feel free to ask any questions :)

I was going to implement this but my only doubt is about how to parse messages from the output. Checkstyle support xml and plain text and does not support json. So I cannot use vim.json to parse it.

[INFO] Scanning for projects...
[INFO]
[INFO] ----------------------< com.fibonacci:fibonacci >-----------------------
[INFO] Building fibonacci 1.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.6.0:check (default-cli) @ fibonacci ---
[INFO] There are 15 errors reported by Checkstyle 9.3 with sun_checks.xml ruleset.
[ERROR] src/main/java/com/fibonacci/Worker.java:[1] (javadoc) JavadocPackage: Missing package-info.java file.
[ERROR] src/main/java/com/fibonacci/Worker.java:[4,3] (javadoc) JavadocVariable: Missing a Javadoc comment.
[ERROR] src/main/java/com/fibonacci/Worker.java:[5,3] (javadoc) JavadocVariable: Missing a Javadoc comment.
[ERROR] src/main/java/com/fibonacci/Worker.java:[7,3] (modifier) RedundantModifier: Redundant 'public' modifier.
[ERROR] src/main/java/com/fibonacci/Worker.java:[7,17] (misc) FinalParameters: Parameter question should be final.
[ERROR] src/main/java/com/fibonacci/Worker.java:[7,21] (coding) HiddenField: 'question' hides a field.
[ERROR] src/main/java/com/fibonacci/Worker.java:[15,32] (misc) FinalParameters: Parameter n should be final.
[ERROR] src/main/java/com/fibonacci/App.java:[12,1] (design) HideUtilityClassConstructor: Utility classes should not have a public or default constructor.
[ERROR] src/main/java/com/fibonacci/App.java:[13,30] (misc) FinalParameters: Parameter n should be final.
[ERROR] src/main/java/com/fibonacci/App.java:[35,27] (misc) FinalParameters: Parameter args should be final.
[ERROR] src/main/java/com/fibonacci/App.java:[36,65] (coding) MagicNumber: '8081' is a magic number.
[ERROR] src/main/java/com/fibonacci/App.java:[40] (sizes) LineLength: Line is longer than 80 characters (found 89).
[ERROR] src/main/java/com/fibonacci/App.java:[46] (sizes) LineLength: Line is longer than 80 characters (found 100).
[ERROR] src/main/java/com/fibonacci/App.java:[47,42] (coding) MagicNumber: '400' is a magic number.
[ERROR] src/main/java/com/fibonacci/App.java:[51,42] (coding) MagicNumber: '400' is a magic number.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.549 s
[INFO] Finished at: 2024-12-08T21:20:07Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.6.0:check (default-cli) on project fibonacci: You have 15 Checkstyle violations. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

The output looks something of this sort. And I have to parse the ones in between.

It's possible to use regex https://github.com/nvimdev/guard-collection/blob/95309915a441307b0f77f7377e87b96f2807dc3b/lua/guard-collection/linter/clang-tidy.lua#L1-L16
Maybe it's possible to use some flags to silent some of the non-diagnostic output

Ok. I reduced it to less output using mvn -q checkstyle:check.
[ERROR] src/main/java/com/fibonacci/Worker.java:[1] (javadoc) JavadocPackage: Missing package-info.java file.
[ERROR] src/main/java/com/fibonacci/Worker.java:[4,3] (javadoc) JavadocVariable: Missing a Javadoc comment.
[ERROR] src/main/java/com/fibonacci/Worker.java:[5,3] (javadoc) JavadocVariable: Missing a Javadoc comment.
[ERROR] src/main/java/com/fibonacci/Worker.java:[7,3] (modifier) RedundantModifier: Redundant 'public' modifier.
[ERROR] src/main/java/com/fibonacci/Worker.java:[7,17] (misc) FinalParameters: Parameter question should be final.
[ERROR] src/main/java/com/fibonacci/Worker.java:[7,21] (coding) HiddenField: 'question' hides a field.
[ERROR] src/main/java/com/fibonacci/Worker.java:[15,32] (misc) FinalParameters: Parameter n should be final.
[ERROR] src/main/java/com/fibonacci/App.java:[12,1] (design) HideUtilityClassConstructor: Utility classes should not have a public or default constructor.
[ERROR] src/main/java/com/fibonacci/App.java:[13,30] (misc) FinalParameters: Parameter n should be final.
[ERROR] src/main/java/com/fibonacci/App.java:[35,27] (misc) FinalParameters: Parameter args should be final.
[ERROR] src/main/java/com/fibonacci/App.java:[36,65] (coding) MagicNumber: '8081' is a magic number.
[ERROR] src/main/java/com/fibonacci/App.java:[40] (sizes) LineLength: Line is longer than 80 characters (found 89).
[ERROR] src/main/java/com/fibonacci/App.java:[46] (sizes) LineLength: Line is longer than 80 characters (found 100).
[ERROR] src/main/java/com/fibonacci/App.java:[47,42] (coding) MagicNumber: '400' is a magic number.
[ERROR] src/main/java/com/fibonacci/App.java:[51,42] (coding) MagicNumber: '400' is a magic number.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.6.0:check (default-cli) on project fibonacci: You have 15 Checkstyle violations. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

The log looks something like this. But it still has few redundant lines at the end. How do you think I can get around these.

Maybe you try to match the src/main/... and check if it's a file. Use a parse function in this case
https://github.com/nvimdev/guard-collection/blob/716d7ee165509e5253a9940fdb1af5dff0c5beb8/lua/guard-collection/linter/codespell.lua#L1-L20

Can't seem to reproduce.

@xiaoshihou514 sorry for this ping but I wanted you to take a look at this configuration for checkstyle and let me know if everything is right since even if I call :lua require("guard.lint").do_lint(), it does not show any diagnostics.
	ft("java"):lint({
		cmd = "checkstyle",
		args = {
			"-c",
			"sun_checks.xml",
		},
		fname = true,
		parse = lint.from_regex({
			source = "checkstyle",
			regex = "%[(%w+)%]%s+.-:(%d+):?(%d*):%s+(.-)%s+%[(.-)%]",
			groups = { "severity", "lnum", "col", "message", "code" },
			severities = {
				ERROR = lint.severities.error,
				WARN = lint.severities.warning,
				INFO = lint.severities.info,
				DEBUG = lint.severities.style,
			},
		}),
	})

I will just put print statements inside guard _ツ_/
Not ideal, but then again most formatters and linters aren't that complicated...

I will just put print statements inside guard ツ/
Not ideal, but then again most formatters and linters aren't that complicated...
I think a nil column number is fine?
As for none matching lines I need to check the source, I think they are skipped.

Ok. I think I found out what the issue is. The thing is that #data is returning 0 even though this is the data coming as part of #data
{
  code = 9,
  signal = 0,
  stderr = "Checkstyle ends with 9 errors.\n",
  stdout = "Starting audit...\n[ERROR] /home/zeltron/git/concurrency/java-platf
orm/src/main/java/com/fibonacci/App.java:1: Missing package-info.java file. [Ja
vadocPackage]\n[ERROR] /home/zeltron/git/concurrency/java-platform/src/main/jav
a/com/fibonacci/App.java:12:1: Utility classes should not have a public or defa
ult constructor. [HideUtilityClassConstructor]\n[ERROR] /home/zeltron/git/concu
rrency/java-platform/src/main/java/com/fibonacci/App.java:13:30: Parameter n sh
ould be final. [FinalParameters]\n[ERROR] /home/zeltron/git/concurrency/java-pl
atform/src/main/java/com/fibonacci/App.java:35:27: Parameter args should be fin
al. [FinalParameters]\n[ERROR] /home/zeltron/git/concurrency/java-platform/src/
main/java/com/fibonacci/App.java:36:65: '8081' is a magic number. [MagicNumber]
\n[ERROR] /home/zeltron/git/concurrency/java-platform/src/main/java/com/fibonac
ci/App.java:40: Line is longer than 80 characters (found 89). [LineLength]\n[ER
ROR] /home/zeltron/git/concurrency/java-platform/src/main/java/com/fibonacci/Ap
p.java:46: Line is longer than 80 characters (found 100). [LineLength]\n[ERROR]
 /home/zeltron/git/concurrency/java-platform/src/main/java/com/fibonacci/App.ja
va:47:42: '400' is a magic number. [MagicNumber]\n[ERROR] /home/zeltron/git/con
currency/java-platform/src/main/java/com/fibonacci/App.java:51:42: '400' is a m
agic number. [MagicNumber]\nAudit done.\n"
}

https://github.com/nvimdev/guard.nvim/blob/d5b4a492ed77107eef43261c2b76124583c27aea/lua/guard/lint.lua#L54

I will just put print statements inside guard ツ/
Not ideal, but then again most formatters and linters aren't that complicated...
I think a nil column number is fine?
As for none matching lines I need to check the source, I think they are skipped.

Ok. I think I found out what the issue is. The thing is that #data is returning 0 even though this is the data coming as part of #data
{
  code = 9,
  signal = 0,
  stderr = "Checkstyle ends with 9 errors.\n",
  stdout = "Starting audit...\n[ERROR] /home/zeltron/git/concurrency/java-platf
orm/src/main/java/com/fibonacci/App.java:1: Missing package-info.java file. [Ja
vadocPackage]\n[ERROR] /home/zeltron/git/concurrency/java-platform/src/main/jav
a/com/fibonacci/App.java:12:1: Utility classes should not have a public or defa
ult constructor. [HideUtilityClassConstructor]\n[ERROR] /home/zeltron/git/concu
rrency/java-platform/src/main/java/com/fibonacci/App.java:13:30: Parameter n sh
ould be final. [FinalParameters]\n[ERROR] /home/zeltron/git/concurrency/java-pl
atform/src/main/java/com/fibonacci/App.java:35:27: Parameter args should be fin
al. [FinalParameters]\n[ERROR] /home/zeltron/git/concurrency/java-platform/src/
main/java/com/fibonacci/App.java:36:65: '8081' is a magic number. [MagicNumber]
\n[ERROR] /home/zeltron/git/concurrency/java-platform/src/main/java/com/fibonac
ci/App.java:40: Line is longer than 80 characters (found 89). [LineLength]\n[ER
ROR] /home/zeltron/git/concurrency/java-platform/src/main/java/com/fibonacci/Ap
p.java:46: Line is longer than 80 characters (found 100). [LineLength]\n[ERROR]
 /home/zeltron/git/concurrency/java-platform/src/main/java/com/fibonacci/App.ja
va:47:42: '400' is a magic number. [MagicNumber]\n[ERROR] /home/zeltron/git/con
currency/java-platform/src/main/java/com/fibonacci/App.java:51:42: '400' is a m
agic number. [MagicNumber]\nAudit done.\n"
}

https://github.com/nvimdev/guard.nvim/blob/d5b4a492ed77107eef43261c2b76124583c27aea/lua/guard/lint.lua#L54

@xiaoshihou514, I think this part of the code is the issue
https://github.com/nvimdev/guard.nvim/blob/d5b4a492ed77107eef43261c2b76124583c27aea/lua/guard/lint.lua#L54
It is a table instead of an array and so returns length 0.

Looks fishy... Will take a look tomorrow.

Ahh I see what's happening, checkstyle gave non zero exit code and non empty stderr, so guard thinks it errored out.
You will have to override the default spawn function: https://github.com/nvimdev/guard.nvim/blob/main/ADVANCED.md#custom-logic-with-linters


[SPARK-16633] [SPARK-16642] [SPARK-16721] [SQL] Fixes three issues related to lead and lag functions

What changes were proposed in this pull request?
This PR contains three changes.
First, this PR changes the behavior of lead/lag back to Spark 1.6's behavior, which is described as below:

lead/lag respect null input values, which means that if the offset row exists and the input value is null, the result will be null instead of the default value.
If the offset row does not exist, the default value will be used.
OffsetWindowFunction's nullable setting also considers the nullability of its input (because of the first change).

Second, this PR fixes the evaluation of lead/lag when the input expression is a literal. This fix is a result of the first change. In current master, if a literal is used as the input expression of a lead or lag function, the result will be this literal even if the offset row does not exist.
Third, this PR makes ResolveWindowFrame not fire if a window function is not resolved.
How was this patch tested?
New tests in SQLWindowFunctionSuite

Test build #62593 has started for PR 14284 at commit c2fd2d7.

Without a good reason and providing a way  to make lead and lag respect Bulls, we should not change the behavior.
On Wed, Jul 20, 2016 at 2:04 AM -0700, "Apache Spark QA"<EMAIL_ADDRESS>wrote:
Test build #62593 has started for PR 14284 at commit c2fd2d7.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Test build #62593 has finished for PR 14284 at commit c2fd2d7.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62593/
Test FAILed.

test this please

Test build #62609 has started for PR 14284 at commit c2fd2d7.

Test build #62611 has started for PR 14284 at commit 51e6937.

Test build #62609 has finished for PR 14284 at commit c2fd2d7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62609/
Test PASSed.

Test build #62611 has finished for PR 14284 at commit 51e6937.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62611/
Test PASSed.

Test build #62626 has started for PR 14284 at commit faa7d89.

Test build #62626 has finished for PR 14284 at commit faa7d89.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class WindowData(month: Int, area: String, product: Int)
class SQLWindowFunctionSuite extends QueryTest with SharedSQLContext

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62626/
Test PASSed.

Test build #62690 has started for PR 14284 at commit 073ac94.

Test build #62690 has finished for PR 14284 at commit 073ac94.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62690/
Test PASSed.

this this please

should we also update the doc for OffsetWindowFunction.default?

retest this please

yea. that's a good point.

Test build #62854 has started for PR 14284 at commit ff3029e.

LGTM

Test build #62854 has finished for PR 14284 at commit ff3029e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62854/
Test PASSed.

Thanks for review. I am merging this to master and branch 2.0.

Are we able to enable ignore null feature in Spark 2.1?
like lag(comm ignore nulls) over (order by empno) prev_comm.
thx

Is possible add feature to enable ignore nulls?
for example:
LAG (value_expr [, offset ])
[ IGNORE NULLS | RESPECT NULLS ]
OVER ( [ PARTITION BY window_partition ] ORDER BY window_ordering )
thanks
Cheng Feng

@chengat1314 this has never been supported, and is a new feature. There was some discussion on the JIRA a while back: https://issues.apache.org/jira/browse/SPARK-17423. Lets move the discussion there.


Layout templates mess up pages using them when published

When a layout template is used as the base layout for pages, re-publishing the layout template causes the pages using it to have their content moved into different zones than they were originally placed in.
Steps to repro:

Create a new layout template.
Create a new page that uses the layout template and place content inside the zones defined in the layout.
Go back to the layout (you'll need to make the Layout content type listable as another bug currently prevents them from being displayed on the admin page) and re-publish the layout template.
Go back to the page that uses the layout template. You'll see that the content you placed on the page originally is now arranged differently.

IMO, this is a serious issue as layout templates are not really of much use as long as this bug is in place. If you were to use them now, every time you go to update a layout template, you'd need to go back and redo every page that used it - which kind of defeats the purpose of layout templates in the first place.

Yeah that renders the feature pretty much useless.

I was just coming here to post about this issue. All I did was add a CSS class to one of my rows, published the Layout, and it blew up about 30 pages I had using the Layout template. I had to manually open up the HTML elements I had in each page, copy the source code, place a new HTML element in the zone I wanted it, rinse, repeat for all 30 pages (and the 4-5 different zones I had).
In other words, cut/paste won't work since the Grid>Row>Column is in the Layout template itself. Also, trying to drag/drop the HTML element into the corrected zone won't work either (it just moves up and down, like it can only be drag/dropped within the "zone" it's in.
I will note that I simply cloned my first page using the layout and then changed the markup for each individual page originally. So I don't know if that is part of the problem.
Back in May 2015, I posted this Issue, which is similar.


Typescript support

Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide?

Closing for lack of response. Happy to reopen if you're still interested.


[2/2] Citizenship upgrade fixes

🗃 Github Issue Or Explanation for this PR. (What is it supposed to do and Why is needed)
When upgrading to citizen there were many bugs and graphics errors.
The graphic and state errors appeared when upgrading from resident to citizen -> the citizenship card then disappears.
I traced the cause of these issues to the usage of a fixed ListView component - that component does not like when its contents change size.
✅ Checklist

[x] I have tested all my changes.

🕵♂ Notes for Code Reviewer
isVisitor value in settings - was not being used, removed.
isCitizen value in settings

Reducing usage of the isCitizen value stored in settings, since this value is a server value. Storing it client side leads to bugs.
It's still used in the vote module as a sort of cached value - it's OK to use there. Does no harm.

Fixed list view issues
A fixed list view shows errors when component sizes inside the fixed list view change. So adding or removing the citizen card on the profile view caused graphics errors. The components inside the list view would change size, but the list view would not update.
Bugfix:

Added fixed size to shimmer component so whether it's shimmering or not, it has the same height.
Moved variable length list view elements to builder, out of fixed list view. Not sure there's a more elegant method?!

🙈 Screenshots

Process

👯♀ Paired with

Realizing I put 2 fixes in this PR, I will split this in 2

Fixed merge issues

I confirmed it is still all working, no graphics issues, merging this now


Bug with mask in metadata creation?

Probably, there is a bug with the mask variable in metadata creation. The variable is created in the loop over all images, but is modified in the loop over the annotations of an image. When sampling more than one annotation per image, the mask is not reset back to 0s but instead still holds the 1s from the bbox of the previous annotation. The next annotation then sets 1s for its bbox which could result in a wrong mask for that annotation, since old 1s are still present.
Originally, there was a limit to sample at most one annotation per image
https://github.com/YoungXIAO13/FewShotDetection/blob/6eac710dae379ff025fac697c9d5ed80ef5bf06a/lib/datasets/metadata_coco.py#L234
which would prevent that inconsistency of mask variable, since it would be reset back to 0s before processing annotations of a new image.
But since commit 838f471, we allow for sampling multiple annotations per image which could lead to the inconsistency described above. Curently, we have a phase-dependent strategy,
https://github.com/YoungXIAO13/FewShotDetection/blob/fc0b453029cffb8719b9d65421f9a91019c1a392/lib/datasets/metadata_coco.py#L240-L241
which could still lead to problems for phase 2.
I'm not sure if we should reset the masks values back to zero mask[y1:y2, x1:x2] = 0 or to completely redefine the variable mask = np.zeros((self.img_size, self.img_size), dtype=np.float32), directly after
https://github.com/YoungXIAO13/FewShotDetection/blob/fc0b453029cffb8719b9d65421f9a91019c1a392/lib/datasets/metadata_coco.py#L238

Hi @Jonas-Meier ,
Good catch! I think that makes sense to reinitialize the mask each time an object is to add, a new commit has been made.
Thanks a lot !

It probably needs to be adjusted in other metadata creation files as well. But I'm closing the issue since it's essentially fixed as of b703ae7.


button to set all references to a specific mod_corpus_association_cor…

…pus boolean value wasn't doing that right.  remove unnecessary corpus fields from store

Thanks @sweng66 !


Support rootUri

This pull request depends on https://github.com/felixfbecker/php-advanced-json-rpc/pull/27 to ensure that the arguments do not shift.

:tada: This PR is included in version 5.4.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Flake8 fixes for py311 branch

cherrypicking #8680, #8728 to fix flake8 on py3.11 branch.

All flake8 errors are fixed according azure. I'll be suppressing other known failures in #8748


New GitHub release?

Hi,
It's been 6 years without any release. It'd be great if there can be a new upstream release now.
I need the version thingy for a project.
Thanks!

@dougblack could you please do the needful? :)

Seems like a "GitHub releases" vs "git tags" situation:
Latest GitHub release: 0.2.12 (4 Mar 2014)
Latest git tag: 0.3.9 (17 May 2020)
Git tags act as official releases, but are not in sync with the "GitHub releases", thus not presented right in the WebUI.

the git tags show up on the releases list, idk what everyone is talking about here https://github.com/flask-restful/flask-restful/releases

This is what people see, the project looks dead at first sight. Maybe removing Releases would be better than keeping them?


Adding note regarding record indexes

Adding note regarding record indexes starting at index 1 to the getting started page documentation.
Signed-off-by: Chris Desch<EMAIL_ADDRESS>

Merged in https://github.com/satyan/sugar/commit/db4ceb4e2fdd1764db65dcc9d4ce0d06607be33b.
Thanks @cdesch for the pull request!


fix oadp changes in version 0.5

Signed-off-by: Valentina Birsan<EMAIL_ADDRESS>https://github.com/open-cluster-management/backlog/issues/18187

/cherry-pick release-2.4


[front] - chore: bump sparkle

Description
This PR aims at updating front to fit with the new sparkle Tree component introduced in https://github.com/dust-tt/dust/pull/6606
Risk
Breaking UI
Deploy Plan

[x]  Wait for https://github.com/dust-tt/dust/pull/6606 to be deployed
[x]  Test on front-edge
[x] Bump sparkle version in front

PMRR


[labs/react] Warning: Invalid attribute name: _$Gl

Which package(s) are affected?
React (@lit-labs/react)
Description
When using a ref with a react wrapper around my Lit component:
<MyReactWrapper ref={console.log} />

I see the following error logged in the console:
Warning: Invalid attribute name: `_$Gl`

After doing some digging, this identifier  _$Gl appears in the minified published code of @lit-labs/react. In the source this corresponds to __forwardedRef.
I am wondering if the minification has been overly aggressive and has mangled the property?
Previously i raised an issue relating to refs causing an l attribute to appear in DOM: https://github.com/lit/lit/issues/2593
It seems like this is the same bug, but now instead of the incorrectly adding a valid attribute name, it is incorrectly adding an invalid attribute name
Reproduction
Check the console here: https://stackblitz.com/edit/react-ts-1d2hjj?file=App.tsx%3AL9
Workaround
n/a
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
1.0.8
Browser/OS/Node environment
Browser: Chrome 105.0.5195.125

Seems related: https://github.com/lit/lit/pull/3217/files

+1, facing the same issue here

@taylor-vann is this now fixed via #3408? is there a release plan?

Awesome thanks! I've had a few developers ask me why this was getting logged by our design system. Will keep and eye out for the release, then test and report back 👍

@WickyNilliams Is this fixed for you in v1.1.1? Because I still see the same error with v1.1.1.

I'm pretty sure it was fixed, but I noticed it again recently. But I didn't have the time to report back.


#4117: Added tip of the day functionality.

I'm not sure that I need add another plugin to solve this issue. I guess my solition is also fine, but if I'm wrong can make it as a separate plugin.
Also I haven't found any ways to add config to General tab. To my mind it is not extensible. Because of this I've looked at other configs and found out, that all general custom configs are on PrefPageDatabaseGeneral, but may I'm also wrong :) I am open to any discussions.
Issue: Tip of the day popup #4117

I've created a separate plugin and changed the way of parsing tips file. Current parser supports only primitive html tags.
And I also use an URL.openConnection to read the file with tips. There are some pros and cons. What do you think, is it OK?

Do you think it is possible to use just standard .properties file for tips definition?
tip_id1=Some rich text content
tip_id2=Another cool tip

This may simplify both implementation and localization.

If it is a property file, the support will be more difficult. Each time, when you need to add new tip, you will have to add a constat to java code, to get this tip as a property or think about the solution to dermine the count of tips and configure property id in runtime. I recon xml file is better in this case.

Constant in java code is not required to work with .properties, you can just use all the properties loaded with some InputStream like you do for .xml now.
Anyway, please do not forget to support localization of tips with $nl$ segment in your URL

Going to merge but can't. DBeaverPreferences.java and DBeaverPreferencesInitializer.java were changed in every line (different line feeds I guess) so any change in them leads to a conflict :(


Pinecone Import: Multiple matches for FieldRef.Name(__filename) in id: string

Attached is one of the parquet files generated from a Pinecone export.  When I try to re-import I get these errors regarding duplicate fields.
Multiple matches for FieldRef.Name(__filename) in id: string vector: list<element: double> __filename: string __ingested_at: string content_id: string filename: string ingested_at: string text: string __fragment_index: int32 __batch_index: int32 __last_in_fragment: bool __filename: string
i2.parquet.zip

Thanks for reporting! Will have a look soon

I have pushed a potential fix to the export script (can't test since I'm not sure how the __filename is showing up in the vectors as well as metadata).
You can install the latest version of the package: vdf-io==0.1.232 and try exporting your dataset again. Please let me know if that works. Thanks

Well after exporting for 2 hours, it failed with the below.  To get around my original problem, I modified the code to use JSON as the output since it is human readable and easy to fix.  Worked great.
Final Step: Fetching vectors: 196it [00:03, 60.60it/s]        | 0/1 [1:53:47<?, ?it/s]
Fetching namespaces: 100%|████████████████████████| 624/624 [1:53:48<00:00, 10.94s/it]
Fetching indexes: 100%|█████████████████████████████| 1/1 [1:53:49<00:00, 6829.88s/it]
Error: 1 validation error for VDFMeta                          | 0/78 [00:00<?, ?it/s]
authorStep: Fetching vectors: 100%|███████████████████| 78/78 [00:02<00:00, 33.79it/s]
  Input should be a valid string [type=string_type, input_value=None, input_type=NoneType]
    For further information visit https://errors.pydantic.dev/2.6/v/string_type
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/vdf_io/export_vdf_cli.py", line 64, in main
    run_export(span)
  File "/usr/local/lib/python3.11/site-packages/vdf_io/export_vdf_cli.py", line 131, in run_export
    export_obj = slug_to_export_func[args["vector_database"]](args)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/vdf_io/export_vdf/pinecone_export.py", line 118, in export_vdb
    pinecone_export.get_data()
  File "/usr/local/lib/python3.11/site-packages/vdf_io/export_vdf/pinecone_export.py", line 448, in get_data
    internal_metadata = VDFMeta(
                        ^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/pydantic/main.py", line 171, in __init__
    self.__pydantic_validator__.validate_python(data, self_instance=self)
pydantic_core._pydantic_core.ValidationError: 1 validation error for VDFMeta
author
  Input should be a valid string [type=string_type, input_value=None, input_type=NoneType]
    For further information visit https://errors.pydantic.dev/2.6/v/string_type
Final Step: Fetching vectors: 156it [00:02, 58.90it/s]


Typing sometime results in cursor not after last character

This happened to me like once a day. I remember it started to show up since 1-2 months ago.
The behavior:

Typing foo
You expect foo|, where | is the cursor
You get fo|o, where cursor is not after last character

Unfortunately I don't have a repro and I don't know what's causing it. I'm also not sure if it's caused by Vim mode. But AFAIK Vim mode in insert mode doesn't do anything special, so this might as well be a VS Code  issue.

Just right after this happens, is there anyway I can get logs or collect info as to what went wrong?

I honestly believe this is a vim issue.
We have no logging built-in for edits / selection changes. You would need to build a custom version of VS Code which logs each and every stacktrace of the cursor position getting changed.
I would try to reproduce in dev mode, and log from here https://github.com/Microsoft/vscode/blob/76e18d0915b18b1aa5971272293fb923b5c2040e/src/vs/editor/common/controller/cursorCollection.ts#L111 and check which code path last sets the cursor.

Hi @alexandrudima, I'm not a VIM user and experiencing the same behavior (as well as some of my colleagues).
Could you please provide me some steps which can help us to determine where the issue comes from?

@terrysahaidak Have you found any steps which can reproduce the problem? Does this reproduce when typing in any file (i.e. .txt) or is it specific to a certain file type. Do you have quick suggestions enabled?
@octref same questions for you.

This just happened when I'm typing a comment in a TS file, where there aren't any completions (originally I thought it could be timing issues related to slow completions).
@alexandrudima I don't have a repro. Do you want to make a build which would log all required information for you to debug? I can install it and next time it happens send you the logs.

@octref I've created a branch alex/71238 where various things are traced using our log infrastructure. Be careful before sharing this log as it contains every keystroke you do. You can trigger a build of that branch and selfhost using it.
This is the regular renderer log:
[2019-04-02 16:14:28.713] [renderer1] [info] KeybindingService: dispatching [Enter]
[2019-04-02 16:14:28.713] [renderer1] [info] CommandService: executing acceptSelectedSuggestionOnEnter
[2019-04-02 16:14:28.723] [renderer1] [info] ----------------------------
textModel: file:///Users/alex/src/working_dir/game-of-life.ts
stack: Error
    at Tracer.finish (file:///Users/alex/src/vscode/out/vs/editor/common/controller/cursorCollection.js:30:27)
    at CursorCollection.setStates (file:///Users/alex/src/vscode/out/vs/editor/common/controller/cursorCollection.js:139:19)
    at Cursor.setStates (file:///Users/alex/src/vscode/out/vs/editor/common/controller/cursor.js:134:27)
    at Cursor._onModelContentChanged (file:///Users/alex/src/vscode/out/vs/editor/common/controller/cursor.js:214:22)
    at Cursor._register._model.onDidChangeRawContent (file:///Users/alex/src/vscode/out/vs/editor/common/controller/cursor.js:76:22)
    at _eventEmitter.slowEvent (file:///Users/alex/src/vscode/out/vs/editor/common/model/textModel.js:210:56)
    at Emitter.fire (file:///Users/alex/src/vscode/out/vs/base/common/event.js:477:38)
    at DidChangeContentEmitter.endDeferredEmit (file:///Users/alex/src/vscode/out/vs/editor/common/model/textModel.js:2372:39)
    at TextModel.pushEditOperations (file:///Users/alex/src/vscode/out/vs/editor/common/model/textModel.js:882:36)
    at SnippetSession.insert (file:///Users/alex/src/vscode/out/vs/editor/contrib/snippet/snippetSession.js:350:38)
    at SnippetController2._doInsert (file:///Users/alex/src/vscode/out/vs/editor/contrib/snippet/snippetController2.js:66:31)
    at SnippetController2.insert (file:///Users/alex/src/vscode/out/vs/editor/contrib/snippet/snippetController2.js:43:22)
    at SuggestController._onDidSelectItem (file:///Users/alex/src/vscode/out/vs/editor/contrib/suggest/suggestController.js:178:71)
    at SuggestController.acceptSelectedSuggestion (file:///Users/alex/src/vscode/out/vs/editor/contrib/suggest/suggestController.js:286:22)
    at EditorControllerCommandImpl.handler [as _callback] (file:///Users/alex/src/vscode/out/vs/editor/contrib/suggest/suggestController.js:393:25)
    at EditorControllerCommandImpl.runEditorCommand (file:///Users/alex/src/vscode/out/vs/editor/browser/editorExtensions.js:74:30)
    at editor.invokeWithinContext (file:///Users/alex/src/vscode/out/vs/editor/browser/editorExtensions.js:93:29)
    at InstantiationService.invokeFunction (file:///Users/alex/src/vscode/out/vs/platform/instantiation/common/instantiationService.js:37:27)
    at CodeEditorWidget.invokeWithinContext (file:///Users/alex/src/vscode/out/vs/editor/browser/widget/codeEditorWidget.js:191:47)
    at EditorControllerCommandImpl.runCommand (file:///Users/alex/src/vscode/out/vs/editor/browser/editorExtensions.js:87:27)
    at handler (file:///Users/alex/src/vscode/out/vs/editor/browser/editorExtensions.js:40:55)
    at InstantiationService.invokeFunction (file:///Users/alex/src/vscode/out/vs/platform/instantiation/common/instantiationService.js:37:27)
    at Proxy._tryExecuteCommand (file:///Users/alex/src/vscode/out/vs/workbench/services/commands/common/commandService.js:72:74)
    at waitFor.then._ (file:///Users/alex/src/vscode/out/vs/workbench/services/commands/common/commandService.js:61:47)
1/1: view state: [9,10 -> 9,24] --->>>window.addEventListener|
1/1: model state: [9,10 -> 9,24] ---->>>window.addEventListener|

By the way, I've tried the insider build and it happens with it as well :(
I will try that custom build later this week and share logs.

@terrysahaidak If you want to run on this build as well, here you go: https://az764295.vo.msecnd.net/insider/efa47d77cfd55cbad68bef54a2d765b73d7beb13/VSCode-darwin-insider.zip
Remember to set "update.mode": "none", and logs are available in Cmd + Shift + P -> Developer: Open Logs Folder -> the rendererX.logs

I got a log and sent to you on Slack @alexandrudima

@octref do you use prettier?
I've just realized I'm using prettier with both formatOnSave and autosave, so I think prettier formats just when I'm typing and breaks everything down.

I do but I don’t have format on save on.

How consistent is this for everyone? I have a work station that this rarely happens on with no bias towards repository and I have another work station where it's a consistent thing but only for certain repositories. Both for local and network shares. Both instances have formatOnSave off

@mcarpenterjr I still hit it once or twice a day in my faster work machine. In a Macbook Air 13 that's less powerful and there are programs taking most of the resources, it can happy every few minutes.
All my repos are local.

@alexandrudima This still happens to me every day, especially when the machine is under heavy load.

Here is the relevant log from @octref:
Raw output
[2019-04-15 12:01:03.637] [renderer189] [info] CommandService: executing setContext
[2019-04-15 12:01:04.680] [renderer189] [info] KeybindingService: dispatching [KeyN]
[2019-04-15 12:01:04.681] [renderer189] [info] CommandService: executing type
[2019-04-15 12:01:04.720] [renderer189] [info] KeybindingService: dispatching [KeyO]
[2019-04-15 12:01:04.721] [renderer189] [info] CommandService: executing type
[2019-04-15 12:01:04.739] [renderer189] [info] CommandService: executing default:type
[2019-04-15 12:01:04.740] [renderer189] [info] ----------------------------
textModel: file:///Users/octref/Code/mine/v/vetur/server/src/modes/script/transformTemplate.ts
stack: Error
    at r.finish (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1387:460)
    at a.setStates (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1390:475)
    at a.setSelections (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1390:180)
    at m._interpretCommandResult (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1398:347)
    at m._executeEditOperation (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1398:91)
    at m._type (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1401:106)
    at m.trigger (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1399:828)
    at e.trigger (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1890:934)
    at y.runCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1581:669)
    at handler (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1553:205)
    at d.invokeFunction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1372:251)
    at Proxy._tryExecuteCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3008:470)
    at r.then.i (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3008:169)
    at process._tickCallback (internal/process/next_tick.js:68:7)
1/1: view state: [51,8 -> 51,8] --->>>      n|
1/1: model state: [51,8 -> 51,8] ---->>>      n|

[2019-04-15 12:01:04.745] [renderer189] [info] ----------------------------
textModel: file:///Users/octref/Code/mine/v/vetur/server/src/modes/script/transformTemplate.ts
stack: Error
    at r.finish (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1387:460)
    at a.setStates (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1390:475)
    at m.setStates (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1395:690)
    at m.setSelections (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1397:745)
    at e.setSelections (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1888:648)
    at h.setSelections (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3185:243)
    at e.$trySetSelections (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3191:266)
    at u._doInvokeHandler (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3295:202)
    at u._invokeHandler (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3294:894)
    at u._receiveRequest (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3293:547)
    at u._receiveOneMessage (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3292:283)
    at _protocol.onMessage.e (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3290:565)
    at d.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:75:806)
    at a (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:314:769)
    at e (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:314:815)
    at d.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:75:806)
    at _receiveMessage (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:323:432)
    at _socketDisposables.push._socketReader.onMessage.e (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:320:722)
    at d.fire (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:75:806)
    at g.acceptChunk (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:317:344)
    at _register._socket.onData.e (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:316:714)
    at Socket.t (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:325:664)
    at Socket.emit (events.js:182:13)
    at addChunk (_stream_readable.js:279:12)
    at readableAddChunk (_stream_readable.js:264:11)
    at Socket.Readable.push (_stream_readable.js:219:10)
    at Pipe.onread (net.js:636:20)
1/1: view state: [51,7 -> 51,7] --->>>      |n
1/1: model state: [51,7 -> 51,7] ---->>>      |n

[2019-04-15 12:01:04.746] [renderer189] [info] CommandService: executing default:type
[2019-04-15 12:01:04.746] [renderer189] [info] ----------------------------
textModel: file:///Users/octref/Code/mine/v/vetur/server/src/modes/script/transformTemplate.ts
stack: Error
    at r.finish (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1387:460)
    at a.setStates (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1390:475)
    at a.setSelections (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1390:180)
    at m._interpretCommandResult (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1398:347)
    at m._executeEditOperation (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1398:91)
    at m._type (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1401:106)
    at m.trigger (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1399:828)
    at e.trigger (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1890:934)
    at y.runCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1581:669)
    at handler (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1553:205)
    at d.invokeFunction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1372:251)
    at Proxy._tryExecuteCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3008:470)
    at r.then.i (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3008:169)
    at process._tickCallback (internal/process/next_tick.js:68:7)
1/1: view state: [51,8 -> 51,8] --->>>      o|n
1/1: model state: [51,8 -> 51,8] ---->>>      o|n

[2019-04-15 12:01:04.780] [renderer189] [info] CommandService: executing setContext
[2019-04-15 12:01:04.856] [renderer189] [info] KeybindingService: dispatching [KeyD]
[2019-04-15 12:01:04.858] [renderer189] [info] CommandService: executing type
[2019-04-15 12:01:04.862] [renderer189] [info] CommandService: executing default:type
[2019-04-15 12:01:04.864] [renderer189] [info] ----------------------------
textModel: file:///Users/octref/Code/mine/v/vetur/server/src/modes/script/transformTemplate.ts
stack: Error
    at r.finish (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1387:460)
    at a.setStates (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1390:475)
    at a.setSelections (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1390:180)
    at m._interpretCommandResult (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1398:347)
    at m._executeEditOperation (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1398:91)
    at m._type (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1401:106)
    at m.trigger (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1399:828)
    at e.trigger (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1890:934)
    at y.runCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1581:669)
    at handler (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1553:205)
    at d.invokeFunction (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:1372:251)
    at Proxy._tryExecuteCommand (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3008:470)
    at r.then.i (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.main.js:3008:169)
    at process._tickCallback (internal/process/next_tick.js:68:7)
1/1: view state: [51,9 -> 51,9] --->>>      od|n
1/1: model state: [51,9 -> 51,9] ---->>>      od|n

And with my explanations:
- KeybindingService: dispatching [KeyN]
- CommandService: executing type (this sends a message to the extension host to vim)
- KeybindingService: dispatching [KeyO]
- CommandService: executing type (this sends a message to the extension host to vim)
- CommandService: executing default:type (I think vim invokes default:type with `n`)
- the default:type command modifies the buffer and the selection:
1/1: view state: [51,8 -> 51,8] --->>>      n|
1/1: model state: [51,8 -> 51,8] ---->>>      n|
- [!!BUG!!] a call comes from the extension host to change the selection location (`$trySetSelections`). Somebody (an extension, perhaps vim) is setting `TextEditor.selection` or `TextEditor.selections`:
1/1: view state: [51,7 -> 51,7] --->>>      |n
1/1: model state: [51,7 -> 51,7] ---->>>      |n
- CommandService: executing default:type (I think vim invokes default:type with `o`)
- the default:type command modifies the buffer and the selection:
1/1: view state: [51,8 -> 51,8] --->>>      o|n
1/1: model state: [51,8 -> 51,8] ---->>>      o|n
...

@terrysahaidak If you are not using Vim, are you using format on save?
My guess is there's a long running formatting operation like so:
function foo() {
  |
}

And if you type n, it should become n|, but after the formatting finishes (with the old text), it replaces (or fails to replace) the current text with the old text, with the side effect of resetting cursor position to   |n from   n|.

Hey there, it's not happening for me for a month or so, don't know if it a fix in some new version or I changed something in my settings/extensions list, but it's good now.

After adding more log I think we find the root cause for the particular case @octref is running into: Editor Config has a document watcher which tries to set selections, when the extension host is being blocked by some heavy lifting work, Editor Config messed up with the current selection.
For everyone who has similar issues but didn't know which extension might modify the selection, you can narrow it down by

Disable auto save, which will disable Save Participants when type
Disable format on save/type, which will disable formatters when save/type

@rebornix It's great that you found the root cause! Should we report this to the editorconfig extension?

@alexandrudima thanks, posted there ;)


lab-04-done

It looks as though you submitted lab01. This LAb4 submission is challenging to download and test on my machine since you completed it in a previous lab and you did not merge your PR.
Additional things to consider when you submit this assignment:
The deployed site does not contain content for lab 4.
No written comments as stated in the submission assignment.


Onomastic Analysis

Finish onomastic analysis

[x] Embed onomastic analysis into MIU annotation routine

Extraction of entities is done in #2

Done here:
https://github.com/EIS1600/eis1600-pkg/commit/12319045b65eb1e5b8ce7803f24d8d7c1c013065


Search in a Matrix

🚀 Feature
An article on Search in a matrix
Have you read the Contributing Guidelines on Pull Requests?
Yes

Please assign me sir @HarshCasper @iamrajiv @atarax665 @ankitaggarwal23


Change check for which emote.

Recently, custom emote :yes2: was changed to :check:, and the custom emote :yes: was removed entirely.
This has been updated in the code. The reason why this is hardcoded is because the emote is not always processed into an emote, or so my last testing reflected. For now, I wanted to get a quick fix up.
Unless Horace is being updated tomorrow, please do not merge this PR. I would like to create an array in the config that stores these emotes as strings (versus IDs) in my free time tomorrow when I work on the highlight feature in case emotes get updated in the future

Well the emotes were changed back, or :check: was changed back to :yes: so we'll just close this up


Loading loop after connection with IDP Azure

I set up the setup.env file as described in the documentation, but I get an error in the management container logs:
Error: failed retrieving a new idp manager with err: azure IdP configuration is incomplete, GraphAPIEndpoint is missing.
I've double-checked the doc and the problems reported here several times, but I can't seem to make any progress....
here is my setup.env :

I think on mine, I hade to change my mgmt idp to "none"

No idea whats missing but here is my config to compare:
openid-configuration.json:
openid-configuration.json {"token_endpoint":"https://login.microsoftonline.com/TENANT-ID/oauth2/v2.0/token","token_endpoint_auth_methods_supported":["client_secret_post","private_key_jwt","client_secret_basic"],"jwks_uri":"https://login.microsoftonline.com/TENANT-ID/discovery/v2.0/keys","response_modes_supported":["query","fragment","form_post"],"subject_types_supported":["pairwise"],"id_token_signing_alg_values_supported":["RS256"],"response_types_supported":["code","id_token","code id_token","id_token token"],"scopes_supported":["openid","profile","email","offline_access"],"issuer":"https://login.microsoftonline.com/TENANT-ID/v2.0","request_uri_parameter_supported":false,"userinfo_endpoint":"https://graph.microsoft.com/oidc/userinfo","authorization_endpoint":"https://login.microsoftonline.com/TENANT-ID/oauth2/v2.0/authorize","device_authorization_endpoint":"https://login.microsoftonline.com/TENANT-ID/oauth2/v2.0/devicecode","http_logout_supported":true,"frontchannel_logout_supported":true,"end_session_endpoint":"https://login.microsoftonline.com/TENANT-ID/oauth2/v2.0/logout","claims_supported":["sub","iss","cloud_instance_name","cloud_instance_host_name","cloud_graph_host_name","msgraph_host","aud","exp","iat","auth_time","acr","nonce","preferred_username","name","tid","ver","at_hash","c_hash","email"],"kerberos_endpoint":"https://login.microsoftonline.com/TENANT-ID/kerberos","tenant_region_scope":"EU","cloud_instance_name":"microsoftonline.com","cloud_graph_host_name":"graph.windows.net","msgraph_host":"graph.microsoft.com","rbac_url":"https://pas.windows.net"}
docker-compose.yml:
version: "3"
services:
  #UI dashboard
  dashboard:
    image: netbirdio/dashboard:latest
    restart: unless-stopped
    ports:
      - 80:80
      - 443:443
    environment:
      # Endpoints
      - NETBIRD_MGMT_API_ENDPOINT=https://netbird.MY-DOMAIN.com:33073
      - NETBIRD_MGMT_GRPC_API_ENDPOINT=https://netbird.MY-DOMAIN.com:33073
      # OIDC
      - AUTH_AUDIENCE=APPLICATION-ID
      - AUTH_CLIENT_ID=APPLICATION-ID
      - AUTH_CLIENT_SECRET= # NOT SURE WHY THIS IS EMPTY ON MINE > The secret is in management.json
      - AUTH_AUTHORITY=https://login.microsoftonline.com/TENANT-ID/v2.0
      - USE_AUTH0=false
      - AUTH_SUPPORTED_SCOPES=openid profile email offline_access User.Read api://APPLICATION-ID/api
      - AUTH_REDIRECT_URI=/auth
      - AUTH_SILENT_REDIRECT_URI=/silent-auth
      - NETBIRD_TOKEN_SOURCE=idToken
      # SSL
      - NGINX_SSL_PORT=443
      # Letsencrypt
      - LETSENCRYPT_DOMAIN=netbird.MY-DOMAIN.com
      -<EMAIL_ADDRESS>
management.json:
{
    "Stuns": [
        {
            "Proto": "udp",
            "URI": "stun:netbird.MYDOMAIN.com:3478",
            "Username": "",
            "Password": ""
        }
    ],
    "TURNConfig": {
        "TimeBasedCredentials": false,
        "CredentialsTTL": "12h0m0s",
        "Secret": "secret",
        "Turns": [
            {
                "Proto": "udp",
                "URI": "turn:netbird.MYDOMAIN.com:3478",
                "Username": "self",
                "Password": "PASSWORD
            }
        ]
    },
    "Signal": {
        "Proto": "http",
        "URI": "netbird.MYDOMAIN.com:10000",
        "Username": "",
        "Password": ""
    },
    "Datadir": "/var/lib/netbird/",
    "DataStoreEncryptionKey": "Encryption-KEY",
    "HttpConfig": {
        "LetsEncryptDomain": "",
        "CertFile": "/etc/letsencrypt/live/netbird.MYDOMAIN.com/fullchain.pem",
        "CertKey": "/etc/letsencrypt/live/netbird.MYDOMAIN.com/privkey.pem",
        "AuthAudience": "APPLICATION-ID",
        "AuthIssuer": "https://login.microsoftonline.com/TENANT-ID/v2.0",
        "AuthUserIDClaim": "oid",
        "AuthKeysLocation": "https://login.microsoftonline.com/TENANT-ID/discovery/v2.0/keys",
        "OIDCConfigEndpoint": "https://login.microsoftonline.com/TENANT-ID/v2.0/.well-known/openid-configuration",
        "IdpSignKeyRefreshEnabled": false
    },
    "IdpManagerConfig": {
        "ManagerType": "azure",
        "ClientConfig": {
            "Issuer": "https://login.microsoftonline.com/TENANT-ID/v2.0",
            "TokenEndpoint": "https://login.microsoftonline.com/TENANT-ID/oauth2/v2.0/token",
            "ClientID": "APPLICATION-ID",
            "ClientSecret": "MY-Entra-ID-SECRET",
            "GrantType": "client_credentials"
        },
        "ExtraConfig": {
            "GraphApiEndpoint": "https://graph.microsoft.com/v1.0",
            "ObjectId": "Object-ID-Of-Entra-ID-AppRegistration"
        },
        "Auth0ClientCredentials": null,
        "AzureClientCredentials": null,
        "KeycloakClientCredentials": null,
        "ZitadelClientCredentials": null
    },
    "DeviceAuthorizationFlow": {
        "Provider": "none",
        "ProviderConfig": {
            "ClientID": "",
            "ClientSecret": "",
            "Domain": "",
            "Audience": "APPLICATION-ID",
            "TokenEndpoint": "https://login.microsoftonline.com/TENANT-ID/oauth2/v2.0/token",
            "DeviceAuthEndpoint": "https://login.microsoftonline.com/TENANT-ID/oauth2/v2.0/devicecode",
            "AuthorizationEndpoint": "",
            "Scope": "openid",
            "UseIDToken": false,
            "RedirectURLs": null
        }
    },
    "PKCEAuthorizationFlow": {
        "ProviderConfig": {
            "ClientID": "APPLICATION-ID",
            "ClientSecret": "",
            "Domain": "",
            "Audience": "APPLICATION-ID",
            "TokenEndpoint": "https://login.microsoftonline.com/TENANT-ID/oauth2/v2.0/token",
            "DeviceAuthEndpoint": "",
            "AuthorizationEndpoint": "https://login.microsoftonline.com/TENANT-ID/oauth2/v2.0/authorize",
            "Scope": "openid profile email offline_access User.Read api://APPLICATION-ID/api",
            "UseIDToken": true,
            "RedirectURLs": [
                "http://localhost:53000"
            ]
        }
    },
    "StoreConfig": {
        "Engine": "sqlite"
    },
    "ReverseProxy": {
        "TrustedHTTPProxies": [],
        "TrustedHTTPProxiesCount": 0,
        "TrustedPeers": [
            "<IP_ADDRESS>/0"
        ]
    }
}%

Thank you for sharing your conf @florian-obradovic
It works! The content of the Scope line was empty in the PKCEAuthorizationFlow block in the management.json file.

Netbird displays a UserID that is impossible to remember. How can I retrieve the first name, surname and email?

I would suggest to follow the steps of https://docs.netbird.io/selfhosted/identity-providers#azure-ad-microsoft-entra-id
Looks like you don't submit the names, etc but only the object id.

I would suggest to follow the steps of https://docs.netbird.io/selfhosted/identity-providers#azure-ad-microsoft-entra-id Looks like you don't submit the names, etc but only the object id.

I've already followed this guide to setting up Azure...
I can't explain the fact that it worked for 20 minutes and then I had these invalid token problems.


How to keep parent tag information after copying a portion of the inner text?

I have defined a blot for a custom tag, <YUM>.
It works great when I paste in the whole thing, but if I copy some text from the middle of a <YUM> element and paste it somewhere else, the tag is not carried over (only the formatting).
Is there a way to keep the copied texts surrounding element(s)?
For example, if I were to have this in the DOM:
<YUM>This is here</YUM> and it cannot be stopped.
And I were to highlight and copy is is her, when I paste it, I would expect it to be wrapped up like this: <YUM>is is her</YUM>, instead of is is her, or at least <YUM>is is her</YUM>.
Here's my blot:
let Inline = Quill.import('blots/inline');
class YumBlot extends Inline {
  static create(value: { url: any }) {
    let node = super.create();
    node.setAttribute('style', 'font-size:150%; color: purple');
    node.setAttribute('src', value.url);
    return node;
  }

  static value(node: { getAttribute: (arg0: string) => any }) {
    return {
      alt: node.getAttribute('alt'),
      url: node.getAttribute('src'),
    };
  }
}

YumBlot.blotName = 'yEmp';
YumBlot.tagName = 'YUM';
YumBlot.className = 'YUMCLASS';
Quill.register('formats/em', YumBlot);

And I've set my editor up to give me a ref so I can set some sample text, as well as poke around for some information.
let Delta = Quill.import('delta');
const sampleData = `<em><strong><YUM>This is here</YUM> and it cannot be stopped.</strong></em>`;

export const RichTextEditor: React.FC = () => {
  const quillRef = React.useRef<ReactQuill | null>(null);

  const measuredRef = React.useCallback<any>((node) => {
    if (node !== null) {
      quillRef.current = node;

      //Add a matcher for the <YUM> tag
      quillRef
        .current!.getEditor()
        .clipboard.addMatcher('YUM', function(node, delta) {
          console.log(delta);
          return delta.compose(
            new Delta().retain(delta.length(), {yEmp: true})
          );
        });

        //Set the editor to the HTML string provided
        quillRef.current!.getEditor().clipboard.dangerouslyPasteHTML(sampleData);
    }
  }, []);

  return (
    <>
      <ReactQuill ref={measuredRef} />
      <button
        onClick={(_) => {
          if (quillRef.current) {
            console.log('Its here');
            quillRef.current.getEditor().insertText(0, 'Hello!');
            quillRef.current.getEditor().formatText(0, 4, 'yEmp', true);
          }
        }}
      />
    </>
  );
};

React-Quill version

[x] master (1.3.3 ?)

Is this also a problem when you use native Quill without React? Might be better to ask over on the parent repo because I think it has more to do with the parsing behavior than the React integration.

I cross-posted in the Quill github repo, nobody has responded yet but I did make a discovery.
If I create a custom clipboard and override the onPaste method with something simple (like a console.log), it works as I'd expect it to normally work.
var Clipboard = Quill.import('modules/clipboard');

class SampleClipboard extends Clipboard {
  onPaste(e) {
    if (e.defaultPrevented || !this.quill.isEnabled()) return;
  }
}

Quill.register('modules/clipboard', SampleClipboard, true);

It's interesting that Quills default behavior strips all formatting out, unless you copy the entire line.


Add pkg/dev PJ-037

SUMMARY

Adding PJ-037B power jack:

DATASHEETS / REFERENCES

PJ-037A: https://www.cuidevices.com/product/resource/pj-037a.pdf
PJ-037AH: https://www.cuidevices.com/product/resource/pj-037ah.pdf
PJ-037B: https://www.cuidevices.com/product/resource/pj-037b.pdf
PJ-037BH: https://www.cuidevices.com/product/resource/pj-037bh.pdf

OPEN QUESTIONS / UNRESOLVED ISSUES

Not sure about the zero rotation of the footprint. Maybe better rotate it 90° CCW? I think it's fine the way it is.
The pad sizes are according datasheet, but for me they feel quite large. I'll check that as soon as I get the ordered device. If there's a lot of tolerance, I'll make the pads smaller. Made pads smaller.
Before merging, I think I'll also add the PJ-037A variants by duplicating the pkg/dev since it differs only in the inner plug diameter (2.0mm vs. 2.5mm). Done.

CHECKLIST

[x] I have read and followed the library conventions¹.
[x] For packages, I followed IPC7351C (see details in library conventions).
[x] For modified elements, I bumped their version number².
[ ] I already used the new library elements in a design and verified their correctness (optional).
[x] I'm the copyright owner of the added content (i.e. the changes are made by myself, not copied/imported from somewhere else).
[x] I agree to publish all my changes under the CC0 Public Domain License³, allowing everyone to use and modify the content without any restrictions.

¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0

As expected, the pad sizes according datasheet are too large, the device sits very loose on the PCB. Therefore I made them smaller now. Also added the PJ-37A[H] device, so this PR should be ready.


Remove tar copy-up for tmpfs mounts

We cannot rely on the tar command for this type of operation because tar
versions, flags, and functionality can very from distro to distro.
Since this is in the container execution path it is not safe to have
this as a dependency from dockers POV where the user cannot change the
fact that docker is adding these pre and post mount commands.
Signed-off-by: Michael Crosby<EMAIL_ADDRESS>

design LGTM

docs need updating for this "The mount copies the underlying content of my_image into /tmp" in man/docker-create.1 and man/docker-run.1

LGTM

So where/how is this copying going to take place as an alternative?

@tianon we can release this and see if it's actually an issue for users and if it is find a better solution that does not shell out to tar

I think it is useful without the tar feature myself, eg to mount /tmp with read only. Changing the behaviour later to reinstate does not seem to be a problem though if there is a clean solution.

Ok

sounds reasonable to me, so LGTM

browsing through the docs for tmpfs:
does L#172 here need to change?
docs/reference/commandline/run.md
166:### mount tmpfs (--tmpfs)
167-
168:    $ docker run -d --tmpfs /run:rw,noexec,nosuid,size=65536k my_image
169-
170:    The --tmpfs flag mounts a tmpfs into the container with the rw,noexec,nosuid,size=65536k options.
171-
172-    Underlying content from the /run in the my_image image is copied into tmpfs.

How about L#1369 here:
docs/reference/run.md
1367:    --tmpfs=[]: Create a tmpfs mount with: container-dir[:<options>], where the options are identical to the Linux `mount -t tmpfs -o` command.
1368-
1369-    Underlying content from the "container-dir" is copied into tmpfs.
1370-
1371:    $ docker run -d --tmpfs /run:rw,noexec,nosuid,size=65536k my_image
1372-

Merging: @MHBauer docs updates will be taken care of by @thaJeztah in a followup PR.

It would have been nice if I was notified.
This is definitely a problem.  As I stated in the other pull request, this breaks --read-only feature for running containers like httpd which depend on having a writable /run.  Since the underlying  image will have /run/httpd and httpd will blow up without it.
If the distribution does not have tar, the commands will not run.   And do we have an example of a tar command that does not support these options?
Could we ship a gotar version in docker for this support?
@cpuguy83 Does docker volumes do something similar to this?


PUBG mobile block

Energized Protection - block ⚡

Let's make an annoyance free, better open internet, altogether!

Issue Submit Form

  Provide the following infos properly, which will help us to resolve your issue quickly.

Issue(s):
Type x in between [ ] and make sure there isn't any space between brackets. Example; for Your Selected Issue(s), type like this - [x]
You can select more than one category of issues if you need to!

[ ] Whitelist
[ ] Blacklist
[x] App Broken
[ ] Website Broken
[ ] Request
[ ] Other Issue

Pack(s):
Write the name of the pack(s) you are using.

Pack(s) Name: Unified

Extension(s):
Also name the extension(s) if you are using any. If you don't then leave it blank.

Extension(s) Name: Xtreme

Domain(s):
If you are submitting this issue for whitelist/blacklist issue, send us the domain(s) for whitelisting/blacklisting here. Kindly use the Code Tag to prevent tracking.

Domain(s):

Your Config:
Just to ensure there is no issues or conflicts with other app/software/magisk module/extension/source list.
Make sure you are running Energized Protection Service only.

Client:

Version:

Details:
Write us a lil bit more about your issue or query. You can attach any screen shot or log of the issue or advert, this will help to highlight it.

Your Issue Detail: i needed to edit and remove some tencent cloud/related domains in order to start PUBG mobile,as for now using unified and xtreme blocks the game if host isnt edited

Thank you for making Energized Protection great with your kind help!

A project by Ador with ❤

Energized Protection - block ⚡
Let's make an annoyance free, better open internet, altogether!
Issue Submit Form
Provide the following infos properly, which will help us to resolve your issue quickly.
Issue(s):
Type x in between [ ] and make sure there isn't any space between brackets. Example; for Your Selected Issue(s), type like this - [x]
You can select more than one category of issues if you need to!

[ ]  Whitelist
[ ]  Blacklist
[x]  App Broken
[ ]  Website Broken
[ ]  Request
[ ]  Other Issue

Pack(s):
Write the name of the pack(s) you are using.

Pack(s) Name: Unified

Extension(s):
Also name the extension(s) if you are using any. If you don't then leave it blank.

Extension(s) Name: Xtreme

Domain(s):
If you are submitting this issue for whitelist/blacklist issue, send us the domain(s) for whitelisting/blacklisting here. Kindly use the Code Tag to prevent tracking.

Domain(s):

Your Config:
Just to ensure there is no issues or conflicts with other app/software/magisk module/extension/source list.
Make sure you are running Energized Protection Service only.

Client:

Version:

Details:
Write us a lil bit more about your issue or query. You can attach any screen shot or log of the issue or advert, this will help to highlight it.

Your Issue Detail: i needed to edit and remove some tencent cloud/related domains in order to start PUBG mobile,as for now using unified and xtreme blocks the game if host isnt edited

Thank you for making Energized Protection great with your kind help!
A project by Ador with ❤

WTF

@LoreBadTime
Please remove the "Xtreme" extension and switch to a smaller pack, like "BLU" or "BLU Go" for playing games on your device.

Thanks but i have alread6 modified the host ,i only deleted tencent related
apps
Il mar 10 mar 2020, 14:54 Avinash Reddy<EMAIL_ADDRESS>ha
scritto:

@LoreBadTime https://github.com/LoreBadTime
Please remove the "Xtreme" extension and switch to a smaller pack, like
"BLU" or "BLU Go" for playing games on your device.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/EnergizedProtection/block/issues/372?email_source=notifications&email_token=AK7YRPENR2RI6WAWIV6RRU3RGZBBDA5CNFSM4LASBFW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOLP5RQ#issuecomment-597098182,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AK7YRPDMU7DOUKA7PDTNGGDRGZBBDANCNFSM4LASBFWQ
.

if (std::find(playerIDs.begin(), playerIDs.end(), curActorID) != playerIDs.end())
{
int64_t rootCmpPtr = _Reader->readType<int64_t>(curActor + 0x188);
int64_t playerState = _Reader->readType<int64_t>(curActor + 0x3D0);
Vector3 actorLocation = _Reader->readVec(rootCmpPtr + 0x2DC);
Vector3 relativeRotation = _Reader->readVec(rootCmpPtr + 0x02DC); // <---- here
// ...

w_data["players"].emplace_back(json::object({ { "t", actorTeam }, {"hp", hp}, { "x", actorLocation.X },{ "y", actorLocation.Y }, {"r", relativeRotation.Y } })); // <---- and here

}

if (std::find(playerIDs.begin(), playerIDs.end(), curActorID) != playerIDs.end())
{
int64_t rootCmpPtr = _Reader->readType<int64_t>(curActor + 0x188);
int64_t playerState = _Reader->readType<int64_t>(curActor + 0x3D0);
Vector3 actorLocation = _Reader->readVec(rootCmpPtr + 0x2DC);
Vector3 relativeRotation = _Reader->readVec(rootCmpPtr + 0x02DC); // <---- here
// ...

w_data["players"].emplace_back(json::object({ { "t", actorTeam }, {"hp", hp}, { "x", actorLocation.X },{ "y", actorLocation.Y }, {"r", relativeRotation.Y } })); // <---- and here

}

Can you explain this?

WTF lol sorry I don't know!
On Sun, Apr 12, 2020, 9:10 PM Avinash Reddy<EMAIL_ADDRESS>wrote:

if (std::find(playerIDs.begin(), playerIDs.end(), curActorID) !=
playerIDs.end())
{
int64_t rootCmpPtr = _Reader->readType<int64_t>(curActor + 0x188);
int64_t playerState = _Reader->readType<int64_t>(curActor + 0x3D0);
Vector3 actorLocation = _Reader->readVec(rootCmpPtr + 0x2DC);
Vector3 relativeRotation = _Reader->readVec(rootCmpPtr + 0x02DC); // <----
here
// ...
w_data["players"].emplace_back(json::object({ { "t", actorTeam }, {"hp", hp}, { "x", actorLocation.X },{ "y", actorLocation.Y }, {"r", relativeRotation.Y } })); // <---- and here
}
Can you explain this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/EnergizedProtection/block/issues/372#issuecomment-612635014,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOZFU4MCSAGDYYHS6UAC3V3RMHOGHANCNFSM4LASBFWQ
.


Allow >>> Python style doctests

We're using Sphinx for generating HTML docs out of help texts. Sphinx recognizes doctests starting with >>>  and formats them as accordingly. Maybe we could add support for that.
This would allow us to use:
function number = getMyNumber()
% Returns the number
%
%   Returns:
%       number (numeric): The number
%
%   Example:
%       >>> getMyNumber()
%       5
%
    number = 5;
end

Instead of:
function number = getMyNumber()
% Returns the number
%
%   Returns:
%       number (numeric): The number
%
%   Example:
%       ::
%
%           >> getMyNumber()
%           5
%
    number = 5;
end

I'm on fence (say "+0" to merge) and would like a little more information first.  Thoughts:

>> is the actual Matlab/Octave GUI prompt so in my mind that's the preferred notation.
doctests are primarily documentation for users.
Is it difficult to configure Sphinx to recognize >> instead?
OTOH, flexibility is good and I don't see this as likely to cause problems.  And we already suppose texinfo-style as well as >>.

I think I would be ok with this change, but maybe change the regex to allow any number of >>>>>>> (2 or more) followed by a space to indicate a prompt?
I certainly don't think this should be advertised or encouraged, but it seems fairly harmless to allow as an option for those who want to exploit this magic shortcut.
I glanced at Sphinx and Docutils, and as far as I can tell, the prompt is hardcoded here, no option to teach Docutils to recognize a different prompt string. But again, this is just a convenience shortcut recognized by Sphinx for embedded Python doctests.

Doctests come from Python (to my best knowledge). Since Matlab does not have a mature documentation system, we are required to use s.th. like Sphinx instead. Afaik it is not possible to change that in Sphinx, since Python doctests are pretty straight-forward.

>> is the actual Matlab/Octave GUI prompt so in my mind that's the preferred notation.

That's right. But, as @mtmiller stated, I wouldn't advertise this, just add support for people, who are using Sphinx for document generation. That's why I only changed the regex searching for tests not the other occurances of >> , e.g. in error messages.

doctests are primarily documentation for users.

You're right. Readability is most important here. I don't expect users to care about two or three guillemet. But I think they care more about the addition indentation level and two extra lines.

Ok, I'm convinced, with or without @mtmiller's regex.
@catch22 are you ok with this too?

One possible counterargument to this: Octave, but not Matlab, uses the >>> marker when reporting syntax errors. So a valid Octave doctest block might be written like this
## >> x = 2 * (1 + 1))
## ??? parse error:
##
##   syntax error
##
## >>> x = 2 * (1 + 1))
##                    ^

Unfortunately this doesn't work with doctest right now, should it? Obviously recognizing >>> as a prompt would change this from one test into two tests.

Hmm, that's a good point @mtmiller. It is probably something that one could reasonably expect to work with doctest. The reason that it hasn't come up yet is that one would typically just match on the syntax error but add ... in place of the last line, so it wouldn't be terrible if we didn't support it. What do you think, @cbm755?

Hmm, I think the issue with this example is different one. Python doctest is using the keyword <BLANKLINE> for empty lines. Doctests are then defined as one block of text, starting with >>>  and no real empty lines. So your example would become:
## >> x = 2 * (1 + 1))
## ??? parse error:
## <BLANKLINE>
##   syntax error
## <BLANKLINE>
## >>> x = 2 * (1 + 1))
##
## >> % The next doctest

See https://docs.python.org/3.7/library/doctest.html#how-are-docstring-examples-recognized

I believe we are not using a special keyword for empty lines (unlike Python).
From a quick glance the regex part capturing the output does stop upon meeting >> (rather than >> ).

I filed #237 for the "quick glance" comment of @catch22.
But I'm not sure what we should do here.  They way we handle errors is already a bit wonky.  We prepend whatever Matlab/Octave give us with ??? (see doctest_format_exception.m).
We could prepend all lines of error messages with ???...   Then (I think) we could fix #237 and accept this PR.  But why are prepending with ??? at all?

I filed #238 for ??? discussions.

Turns out we've actually had much of this discussion already in #100 sigh.
Interestingly, @oheim claimed almost no one was using >> in octave and matlab.  Symbolic was an exception but is no longer using it.
@catch22: do use use >>?
Perhaps Sphinx usage (with >>>) is the main thing that would drive Matlab use of Doctest.

What if the first >>>* string on the page defined the prompt?  That is, we find it, then build the regex.  I think this would allow us to fix #237 and also accept something like this PR...  I'll see if I can flesh this out a little.

That would certainly be a clever solution! (Is it too clever? 😄)
@skycaptain - are you directly running Sphinx on your Matlab code, or are you doing some preprocessing/extraction first? Is there a GitHub repository where we can have a look at your work flow?

@catch22: I'm using sphinx-contrib/matlabdomain for in addition to Sphinx. The project itself is private I fear. I'll try to setup a public repo mimicing my usecase.

In a way, it would make more sense to "fix" sphinx-contrib/matlabdomain so that it can deal with Matlab/Octave-style prompts than for us to use Python's prompt. Is this a realistic option?
On the other hand, even Octave itself isn't consistent in its prompt. I think it's >> in the GUI and octave:n> in the terminal.  My main concerns about supporting >>> are rather:

The issue that syntax errors often contain lines starting with >>>: One way to overcome this would be to prefix every line of the exception message by error: . Perhaps this is anyways how it should be?

That we'll identify more and more discrepancies where Python's doctest format differs from idiomatic Octave/Matlab, including ones that we will not be able to "patch over".

Is this a realistic option?

Hmm. Not an elegant solution, but one could Monkey-patch this line.
I filed https://github.com/sphinx-contrib/matlabdomain/issues/94

Thanks for filing the issue at sphinx-contrib/matlabdomain#94. This sounds like a problem best solved by discussing across projects.


Added my homework URL

Please use the URL to access the git repository and the branch:
https://github.com/anjali-deshpande-hub/githomework1
The snapshots are in 'playing-with-bash' branch of this repository.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)
@michaeladrouillard @dtxe
Checklist

[ ] I can confirm that my changes are working as intended

uoft-dsi-c3-homework-20240426

Please use the URL to access the git repository and the branch:
https://github.com/anjali-deshpande-hub/githomework1
The snapshots are in 'playing-with-bash' branch of this repository.


[Bug Report] Link error in envrionment_creation tutorial

Describe the bug
https://github.com/Farama-Foundation/Gymnasium/blob/8f0baf62aa13c69c77dc00bed0060e09d700890a/docs/tutorials/environment_creation.py#L23
If you click the documentation of Gymnasium’s API in Make your own custom environment of the doc's tutorial, '404 Page not found' occurs.
The link connects to /api/core, which does not currently exist in the "gymnasium.farama.org" doc.
It seems to be a problem caused by moving the doc from gymlibrary.dev.
It would be nice to change from /api/core to /api/env.
Code example
No response
System info
No response
Additional context
No response
Checklist

[X] I have checked that there is no similar issue in the repo

Thanks, could you make a PR to solve this.
You will need to modify the docs/api/core


Updated run-functional-tests.sh

Added options:

SAI Server IP address
Paths to port map and port config files
Underlay/Overlay tests selection
Hardware/BMv2 selection
Interfaces specifing

Signed-off-by: Yuriy Harhas<EMAIL_ADDRESS>

I suggest you consider to rename/move this script to test/test-cases/functional/ptf/run-tests.sh and the test path would nominally be . I am contemplating doing the same for saic tests under functional/ and scale/

I can do this, but than I'll need to update Makefile as well. If it is ok, I'll update this PR.

I suggest you consider to rename/move this script to test/test-cases/functional/ptf/run-tests.sh and the test path would nominally be . I am contemplating doing the same for saic tests under functional/ and scale/

I can do this, but than I'll need to update Makefile as well. If it is ok, I'll update this PR.

Updating the Makefile is fine by me, thanks.


feature: store container image list to image spec

Signed-off-by: yuxing.lyx<EMAIL_ADDRESS>
Describe what this PR does / why we need it
Does this pull request fix one issue?

Fixes https://github.com/sealerio/sealer/pull/1960
Describe how you did it
Describe how to verify it
Special notes for reviews

Codecov Report
Base: 17.51% // Head: 16.88% // Decreases project coverage by -0.63% :warning:

Coverage data is based on head (05240c6) compared to base (05a9c6c).
Patch coverage: 13.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
- Coverage   17.51%   16.88%   -0.64%
==========================================
  Files         103      109       +6
  Lines        9184     9652     +468
==========================================
+ Hits         1609     1630      +21
- Misses       7362     7806     +444
- Partials      213      216       +3

Impacted Files
Coverage Δ

build/buildimage/middleware.go
0.00% <0.00%> (ø)

pkg/define/image/v1/sealer_image_extension.go
0.00% <0.00%> (ø)

pkg/imageengine/buildah/config.go
0.00% <0.00%> (ø)

pkg/imageengine/buildah/inspect.go
0.00% <0.00%> (ø)

build/buildimage/differ.go
0.68% <2.56%> (-2.27%)
:arrow_down:

types/api/v1/image_types.go
69.23% <84.21%> (ø)

build/layerutils/utils.go
85.18% <100.00%> (+1.18%)
:arrow_up:

types/api/v1/plugin_types.go
100.00% <0.00%> (ø)

types/api/v1/config_types.go
100.00% <0.00%> (ø)

types/api/v1/cluster_types.go
22.22% <0.00%> (ø)

... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


PowerWalker STL

can this library work with PowerWalker Basic VI STL ?

No, this library is only for the ATS and PDU. But that UPS has HID USB connection, which works with nut: https://networkupstools.org/docs/man/usbhid-ups.html
This is how I configure my PowerWalker UPS with nut:
maxretry = 3
retrydelay = 5
pollinterval = 5
synchronous = yes

[ups]
        driver = usbhid-ups
        port = auto
        vendorid = 06da

Thanks!

No problem :)


Option to start minimized to system tray

With "system tray icon" and "close to the tray" options the only thing left is an option to "start minimized to system tray" for this tool to be put into system's startup and to be persistent in background. This PR implements that option.

Thank you.
Added with https://github.com/moson-mo/cryptor/commit/59402e01dd5255b4ba0a1159a81d5481125741d3


Behavior of NfcManager.getLaunchTagEvent doesn't get worked, If I scan the tag, it does not launch the app.

Behavior of NfcManager.getLaunchTagEvent doesn't get worked, If I scan the tag, it does not launch the app.
So I have to open the app manually, And even if NfcManager.getLaunchTagEvent is called after opening app, It always retrun null tag.
SO please correct me.. What should be changed in code to launch the app when I scan the Tag. Should I change in AndroidManifest.xml file ? or when NfcManager.getLaunchTagEvent() method should be called ?

@KinjalDroid sorry for the late response.
It depends on the data you put inside your NDEF, but for general cases, you should do both. Because those two steps are for different purposes:

AndroidManifest.xml can wake your app up directly (it's Android's native behavior, not RN related)
Then, once your RN app launched, call getLanuchTagEvent to retrieve the parsed launching tag (it's actually an Intent, in Android's term)

For example, if you want your app to be launched when a NDEF contains an URI like http://myapp.com, you should add following intent into your AndroidManifest:
<intent-filter>
    <action android:name="android.nfc.action.NDEF_DISCOVERED"/>
    <category android:name="android.intent.category.DEFAULT"/>
    <data android:scheme="http"
              android:host="myapp.com" />
</intent-filter>

The, call getLaunchTagEvent when your app starts up. (the resolved tag might be null if your app is not launched via tag)
I think you're asking a great question, and I'm sorry that we didn't explain this well in the doc. Please kindly tell me if above suggestion works!

close inactive issue


Fix the "dev" docs badge

cc: @stevengj

The stable link is also broken…

Yeah the stable link will not work until you have tagged a new release.

You'll need to merge https://github.com/JuliaLang/IJulia.jl/pull/943 before you register a new release.

Tagged at https://github.com/JuliaRegistries/General/pull/19534

I'm temporarily blocking automerge on https://github.com/JuliaRegistries/General/pull/19534
If https://github.com/JuliaRegistries/General/pull/19534 is merged before https://github.com/JuliaLang/IJulia.jl/pull/943 is merged, it's possible that the tag will be created but the docs won't be built on that tag, which is an annoying situation to be in.

Whoops I should have said #944