v4.0.0-alpha.8: does not comply with statusbarPadding

Bug Report
Ionic Info
Using @ionic/core version 4.0.0-alpha.8 directly from npm / unpkg CDN.
Chromium and Firefox browsers
Describe the Bug
Ionic retrieves some configuration options from the location query parameters that start with ionic:.
In particular, ionic:statusbarPadding=true adds a top margin to account for the mobile status bar / notch (iPhone X).
But in version 4.0.0-alpha.8, this configuration option is no longer applied.
Steps to Reproduce

Go to https://beta.ionicframework.com/docs/api/action-sheet/
In "ios" mode (as default), the top toolbar displays behind the mobile simulator notch.

It was working fine in previous versions, e.g. in 4.0.0-alpha.7:
https://beta.ionicframework.com/docs/api/4.0.0-alpha.7/action-sheet
Related Code
Direct link to demo app: https://beta.ionicframework.com/docs/content/api//action-sheet-demo.html?ionic:mode=ios&ionic:statusbarPadding=true
With a Plunker: https://plnkr.co/edit/Iy74e71fNDoiYPm7VcBo?p=preview (includes an iframe calling a 2nd HTML page so that we can set the option in the src query params)
Expected Behavior
When the location includes the query parameter ionic:statusbarPadding=true, the App should add an extra top margin to account for the device status bar / notch.
Additional Context
None.

Hello! Are you still running into this issue with alpha.10 ?

Hi, thank you for your message!
Yes indeed, the situation is the same with latest release version alpha.10:
https://plnkr.co/edit/W9JuuGZ8zeSuurbEndwV?p=preview
Same with the demo apps on Ionic docs beta, which seem to have been updated to alpha.10 as well:

https://beta.ionicframework.com/docs/api/action-sheet/ (with both es5<EMAIL_ADDRESS>and es6 (https://unpkg.com/<EMAIL_ADDRESS>versions)
direct link: https://beta.ionicframework.com/docs/content/api//action-sheet-demo.html?ionic:mode=ios&ionic:statusbarPadding=true

FWIW, same with alpha.11:
https://plnkr.co/edit/kfrB50EfgHmdqOqyjtMr?p=preview

Same issue on beta.0
I made a fresh install of the tabs app, both nav bar and tabs rendered without the proper padding on an iPhone X.

Same issue on 4.0.0-beta.1

I agree @Mobiletainment. I am having the same issue, there is too much padding now on 4.0.0-beta.1

Yes! Thank you for posting the issue. Too much padding now on 4.0.0-beta.1

This should be fixed in beta.3. I updated your sample demos and I see it working now so I am going to close this. Please let me know if you're still seeing issues though, thanks!

Works fine now indeed! :+1:
Just for the sake of testing, here is a Plunker updated with<EMAIL_ADDRESS>and some radio inputs to easily switch between modes and statusbarPadding config:
https://plnkr.co/edit/GJnEC8qpfit8fWuWDdIa?p=preview
=> statusbarPadding correctly applied for both iOS and MD modes, and hidden when statusbarPadding query parameter is omitted.


Review firewall rule as currently a pod can access https:// server outside of the VM

Issues
A pod cannot access an external server and will report this error Get https://acme-v02.api.letsencrypt.org/directory: dial tcp: i/o timeout.
Remark: We can curl this external http server within the VM
We should review/improve the firewall rules

This stackoverflow post could certainly help us to figure out what to do : https://stackoverflow.com/questions/30449843/how-to-connect-a-kubernetes-pod-to-the-outside-world-without-a-forwarding-rule

The log of the kube-proxy reports this error
ks logs kube-proxy-42kpq
W0226 11:18:38.884664       1 proxier.go:513] Failed to load kernel module ip_vs with modprobe. You can ignore this message when kube-proxy is running inside container without mounting /lib/modules
W0226 11:18:38.885941       1 proxier.go:513] Failed to load kernel module ip_vs_rr with modprobe. You can ignore this message when kube-proxy is running inside container without mounting /lib/modules
W0226 11:18:38.887409       1 proxier.go:513] Failed to load kernel module ip_vs_wrr with modprobe. You can ignore this message when kube-proxy is running inside container without mounting /lib/modules
W0226 11:18:38.888672       1 proxier.go:513] Failed to load kernel module ip_vs_sh with modprobe. You can ignore this message when kube-proxy is running inside container without mounting /lib/modules
W0226 11:18:38.895700       1 server_others.go:249] Flag proxy-mode="" unknown, assuming iptables proxy
I0226 11:18:38.905147       1 server_others.go:143] Using iptables Proxier.
I0226 11:18:38.906233       1 server.go:534] Version: v1.15.9
I0226 11:18:38.917394       1 conntrack.go:100] Set sysctl 'net/netfilter/nf_conntrack_max' to 131072
I0226 11:18:38.917432       1 conntrack.go:52] Setting nf_conntrack_max to 131072
I0226 11:18:38.917494       1 conntrack.go:100] Set sysctl 'net/netfilter/nf_conntrack_tcp_timeout_established' to 86400
I0226 11:18:38.917543       1 conntrack.go:100] Set sysctl 'net/netfilter/nf_conntrack_tcp_timeout_close_wait' to 3600
I0226 11:18:38.918750       1 config.go:187] Starting service config controller
I0226 11:18:38.918784       1 controller_utils.go:1029] Waiting for caches to sync for service config controller
I0226 11:18:38.918803       1 config.go:96] Starting endpoints config controller
I0226 11:18:38.918814       1 controller_utils.go:1029] Waiting for caches to sync for endpoints config controller
I0226 11:18:39.018994       1 controller_utils.go:1036] Caches are synced for service config controller
I0226 11:18:39.019077       1 controller_utils.go:1036] Caches are synced for endpoints config controller
E0226 11:24:09.499368       1 proxier.go:706] Failed to ensure that filter chain KUBE-EXTERNAL-SERVICES exists: error creating chain "KUBE-EXTERNAL-SERVICES": exit status 3: modprobe: ERROR: could not insert 'ip_tables': Exec format error
iptables v1.6.0: can't initialize iptables table `filter': Table does not exist (do you need to insmod?)
Perhaps iptables or your kernel needs to be upgraded.

Is the DNS server well defined as I get such error when I curl within the pod
[jboss@demo-ff5d9bc5b-45rjf ~]$ curl -k https://acme-v02.api.letsencrypt.org/directory
curl: (6) Could not resolve host: acme-v02.api.letsencrypt.org
[jboss@demo-ff5d9bc5b-45rjf ~]$ cat /etc/resolv.conf
nameserver <IP_ADDRESS>
search demo.svc.cluster.local svc.cluster.local cluster.local
options ndots:5

If I use the IP address, then we got an IP route issue
curl -k https://<IP_ADDRESS>/directory
curl: (7) Failed to connect to <IP_ADDRESS> port 443: No route to host

If we stop the firewall, then that works
[jboss@demo-ff5d9bc5b-t955g ~]$ curl http://localhost:8080
{"timestamp":"2020-02-26T16:32:30.525+0000","path":"/","status":404,"error":"Not Found","message":null,"requestId":"2a96d8ad"}[jboss@demo-ff5d9bc5b-t955g ~]$
[jboss@demo-ff5d9bc5b-t955g ~]$ curl -k https://acme-v02.api.letsencrypt.org/directory
{
  "9VuaR79uG44": "https://community.letsencrypt.org/t/adding-random-entries-to-the-directory/33417",
  "keyChange": "https://acme-v02.api.letsencrypt.org/acme/key-change",
  "meta": {
    "caaIdentities": [
      "letsencrypt.org"
    ],
    "termsOfService": "https://letsencrypt.org/documents/LE-SA-v1.2-November-15-2017.pdf",
    "website": "https://letsencrypt.org"
  },
  "newAccount": "https://acme-v02.api.letsencrypt.org/acme/new-acct",
  "newNonce": "https://acme-v02.api.letsencrypt.org/acme/new-nonce",
  "newOrder": "https://acme-v02.api.letsencrypt.org/acme/new-order",
  "revokeCert": "https://acme-v02.api.letsencrypt.org/acme/revoke-cert"
}[jboss@demo-ff5d9bc5b-t955g ~]$

For outgoing traffic towards http or https server, we need something like
IPTABLES -A INPUT  -p tcp -m multiport --dports 80,443 -m state --state NEW,ESTABLISHED -j ACCEPT
IPTABLES -A OUTPUT -p tcp -m multiport --sports 80,443 -m state --state ESTABLISHED -j ACCEPT

WDYT @jacobdotcosta

There is still an issue with your change as I got the followign error from the Cert Challange pod which contact Letsencrypt HTTP Server. So incoming traffic to the port 80 and eth0 IP is not allowed.
Waiting for http-01 challenge propagation: failed to perform self check GET request 'http://k8s-console.<IP_ADDRESS>.nip.io/.well-known/acme-challenge/kYteZAmYx-Fxk3m-y6H8u35ZdcMb7hLMcOcQwAPnX6w': Get http://k8s-console.<IP_ADDRESS>.nip.io/.well-known/acme-challenge/kYteZAmYx-Fxk3m-y6H8u35ZdcMb7hLMcOcQwAPnX6w: dial tcp <IP_ADDRESS>:80: connect: connection refused

@jacobdotcosta

We can access the console https://k8s-console.<IP_ADDRESS>.nip.io/#/overview?namespace=default
oken pwd shared on zulip
I added these rules and rebooted the VM
sudo iptables -A OUTPUT -o eth0 -p tcp --dport 80 -m state --state NEW,ESTABLISHED -j ACCEPT
sudo iptables -A OUTPUT -o eth0 -p tcp --dport 443 -m state --state NEW,ESTABLISHED -j ACCEPT
sudo iptables -A INPUT -i eth0 -p tcp --sport 80 -m state --state ESTABLISHED -j ACCEPT
sudo iptables -A INPUT -i eth0 -p tcp --sport 443 -m state --state ESTABLISHED -j ACCEPT

To be validated of course @Antonio Costa

Firewalld uses zones to manage traffic. With this in mind I configured the following zones, having as source a sample installation with podman I have in the office to test containers.
First I got the list of interfaces using nmcli.
# nmcli
xxxxxxxx: connected to System xxxxxxxx
...

xxxxxxxx, the physical interface, was added to the public zone. This zone is the default where ssh and other configurations where applied. This could be subject to discussion and move xxxxxxxx to the external zone.
# firewall-cmd --permanent --zone=public --add-interface=xxxxxxxx

To allow traffic related to k8s I added traffic having as source the k8s address range to the trusted zone.
# firewall-cmd --permanent --zone=trusted --add-source=xxx.xxx.xxx.xxx/xx

All sensitive data to be shared on zulip.

the physical interface, was added to the public zone.

What are then the rules in/out applied to the interface assigned to a zone then ? @jacobdotcosta

In the new installation I have to review the puiblic zone and try understanding why port 80 and 443 weren't open.

In the new installation I have to review the puiblic zone and try understanding why port 80 and 443 weren't open.

This is not very well documented and the reason why I was questioning you ;-) Then, I think that it will be needed to also add additional rules to open the needed ports : 80, 443, ...

FYI. Applying this rule was enough to allow the coreDNS pod to start and to access the Kube Api Service
sudo firewall-cmd --permanent --zone=trusted --add-source=<IP_ADDRESS>/16

During this step, the FW was modifying this file
/etc/firewalld/zones/trusted.xml
-->
<?xml version="1.0" encoding="utf-8"?>
<zone target="ACCEPT">
  <short>Trusted</short>
  <description>All network connections are accepted.</description>
  <source address="<IP_ADDRESS>/16"/>
</zone>

No iptables commands were reported within the FW Log !
@jacobdotcosta

This rule is only needed sudo firewall-cmd --permanent --zone=trusted --add-source=<IP_ADDRESS>/16. We have tested it


Use BIDS URIs to track Sources in sidecars

Closes #3252. This is just a first pass- it only modifies the RawSources for now. I can add the immediate Sources in another PR (this'll require a lot more effort).
Changes proposed in this pull request

Add DatasetLinks field to the dataset_description.json

The input dataset is called raw
Any other datasets supplied through --derivatives are automatically named deriv-<index>. We might want to support named derivatives at some point.

Replace BIDS-relative paths in RawSources fields with BIDS-URIs.
Change RawSources to Sources in the sidecar files, since RawSources is deprecated.

Documentation that should be reviewed
I'll probably need to update the documentation, but haven't yet.

I'm stumped. I can't figure out why config.execution.dataset_links isn't working.

It's working! Thanks @mgxd!
I have a few ideas for next steps:

Unit test of BIDSURI, as you recommended.
Modify BIDSURI to accept a numinputs parameter and populate in[i] inputs, similar to Nipype's Merge interface.

This way, we can provide filenames from different sources without having to merge them.

Return DerivativesDataSink out_files from some output workflows to pass along to others.

For example, take the output file from ds_bold_native_wf and pass it along to ds_volumes_wf.

I have the unit test implemented, as well as a more flexible BIDSURI class. I think tracking immediate source files should happen in a future PR.

From the artifacts, full-run/sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-coreg_boldref.json has:
{
  "Sources": [
    "/scratch/fmriprep_24_0_wf/sub_01_wf/bold_task_mixedgamblestask_run_01_wf/bold_fit_wf/hmc_boldref_wf/gen_avg/sub-01_task-mixedgamblestask_run-01_bold_average.nii.gz"
  ]
}

Possibly we were already screwing this up, but this seems worth fixing.

@effigies I took a crack at it. I'll fix any bugs that come up in the CI.

Aha!
{
  "Sources": [
    "bids::sub-01/func/sub-01_task-mixedgamblestask_run-01_desc-hmc_boldref.nii.gz"
  ]
}

One last one:
sub-02/func/sub-02_task-cuedSGT_run-01_desc-brain_mask.json
{
  "Sources": [
    "bids:raw:sub-02/func/sub-02_task-cuedSGT_run-01_echo-1_bold.nii.gz",
    "bids:raw:sub-02/func/sub-02_task-cuedSGT_run-01_echo-2_bold.nii.gz",
    "bids:raw:sub-02/func/sub-02_task-cuedSGT_run-01_echo-3_bold.nii.gz",
    "/scratch/fmriprep_24_0_wf/sub_02_wf/bold_task_cuedSGT_run_01_echo_1_wf/bold_fit_wf/bold_hmc_wf/fsl2itk/mat2itk.txt",
    "bids::sub-02/func/sub-02_task-cuedSGT_run-01_from-boldref_to-auto00000_mode-image_xfm.txt"
  ]
}

This is awesome. Thanks so much for taking the time to work on this.

I can't figure out what's going on with ds005. It's failing but I'm not seeing any crash files in the artifacts.

Fun:
Traceback (most recent call last):
  File "/opt/conda/envs/fmriprep/lib/python3.11/multiprocessing/forkserver.py", line 274, in main
    code = _serve_one(child_r, fds,
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/fmriprep/lib/python3.11/multiprocessing/forkserver.py", line 313, in _serve_one
    code = spawn._main(child_r, parent_sentinel)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/fmriprep/lib/python3.11/multiprocessing/spawn.py", line 131, in _main
    prepare(preparation_data)
  File "/opt/conda/envs/fmriprep/lib/python3.11/multiprocessing/spawn.py", line 246, in prepare
    _fixup_main_from_path(data['init_main_from_path'])
  File "/opt/conda/envs/fmriprep/lib/python3.11/multiprocessing/spawn.py", line 297, in _fixup_main_from_path
    main_content = runpy.run_path(main_path,
                   ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen runpy>", line 291, in run_path
  File "<frozen runpy>", line 98, in _run_module_code
  File "<frozen runpy>", line 88, in _run_code
  File "/opt/conda/envs/fmriprep/bin/fmriprep", line 5, in <module>
    from fmriprep.cli.run import main
  File "/opt/conda/envs/fmriprep/lib/python3.11/site-packages/fmriprep/cli/run.py", line 25, in <module>
    from .. import config
  File "/opt/conda/envs/fmriprep/lib/python3.11/site-packages/fmriprep/config.py", line 378, in <module>
    class execution(_Config):
  File "/opt/conda/envs/fmriprep/lib/python3.11/site-packages/fmriprep/config.py", line 442, in execution
    work_dir = Path('work').absolute()
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/fmriprep/lib/python3.11/pathlib.py", line 979, in absolute
    return self._from_parts([self.cwd()] + self._parts)
                             ^^^^^^^^^^
  File "/opt/conda/envs/fmriprep/lib/python3.11/pathlib.py", line 907, in cwd
    return cls(os.getcwd())
               ^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory

Let's hope this is just a weird one-off. Rerunning.

I think the error is actually #3256. Not sure why the error text is hidden, but nothing in this PR seems to be causing any error.


Changing Owner and Active Public Keys to Ledger Keys Error

I sucsesfully changed my Owner and Active Public Keys to the one of my Nano Ledger, no the problem is that I cannot operate anymore with my account... I tried going to the Manage Wallets section and change my Hot wallet to a Ledger Wallet

I can see the message on the opened box:

But where is the 'Modify account permissions' button to click???
At the end of the box I have this button:

But it cannot be clicked...
What can I do? I cannot even cancel that account to re-import it...

With the information provided I'm not exactly sure what's going on.
Are there 2 different accounts in the screenshots above? You said you changed the account to use the Ledger, so what are you trying to convert now?

Found the problem, 0.6.6 will have the fix.


Add Search Devices Endpoint

Add support for the Search Devices endpoint. Searching devices was previously done via the List Devices endpoint /devices, but now has it's own dedicated endpoint /devices/search.
This issue has two parts:

Update the documentation for List Devices
Add support for Search Devices

Example of this update in the Ruby library: https://github.com/attm2x/m2x-ruby/commit/20e563d31e13dbca8771d10f856935dab7ee33cc

Resolved in 7f65eac1896856585ee950bceab36d1b2ad2a837.


Game crashes when using Stone Cutter

Itemblacklist-1.19.2-1.2.1
Fabric-api-0.75.1+1.19.2
Causes crash in stonecutter whenever removing stone blocks placed into table.
Either by crafting them all or removing manually.

Sorry realized this is the forge github.


Opengraph Metadata

Embeds don't look nice, would be nice to have opengraph metadata available on all the dashboard pages and proposal pages so things look nice when posting a link in social media.

This issue is partially fixed. There is generic OpenGraph metadata for links to the DAO, but not specific for proposals yet.


Portable scrubbers

About the PR
Related to https://github.com/space-wizards/space-station-14/issues/9148.

[x] Succ works
[x] Check for anchored, power, etc
[x] Scrubber fills up
[x] You can check how full the scrubber is
[x] Reach some reasonable balance
[x] Working visuals
[x] Emptiable scrubber
[x] Ambience
[x] Scrubber can be built like other machines
[x] Localization
[x] Cleanup
[x] Comments

Changelog

:cl: Rane

add: Added portable scrubbers.

woops i meant to open as draft

@Zumorica

Added a blue light that displays if it's connected via port.

Ok I did all the cleanup


[UPDATE] Need to clean up DEPRECATED list

Will be soon start list the DEPRECATED but will be preserved the last updated file.

!watch @Skiddle-Git

!watch @Skiddle-Git

Added to watchlist.


Where does the dependency on bootloader have to be placed?

I'm currently trying to build rusty-hermit with bootimage in order to use your bootloader and custom test framework. However I can't seem to figure out where to place the dependency for bootloader.
In rusty-hermit the library containing the kernel libhermit-rs is built via a build script, since the application and the kernel are built with different targets. The library is then linked with the application.
Where exactly does bootimage expect the bootloader dependency? The Top level Cargo.toml is just a workspace, which also leads to WARNING: There is no root package to read the cargo-xbuild config from.
Also do I need to modify the build script to use cargo-xbuild ? I'm not sure if I'm doing something wrong in that regard but it doesn't seem to make a difference whether I use xbuild or build in the build script for the kernel. In both cases I have to pass "-Z build-std=core,alloc"
I tried:

putting bootloader = "0.9.2" in every single Cargo.toml file (except for the workspace one). For the 2015 edition crates I also added extern crate bootloader; to the lib.rs file. I ran cargo bootimage --target x86_64-unknown-hermit -Z build-std=std,core,alloc,panic_abort

Error

Created bootimage for `rusty_demo` at `/home/xxx/Dev/rusty-hermit/target/x86_64-unknown-hermit/debug/bootimage-rusty_demo.bin`
Error: An error occured while trying to build the bootloader: Bootloader dependency not found

You need to add a dependency on a crate named `bootloader` in your Cargo.toml.

Caused by:
    Bootloader dependency not found

    You need to add a dependency on a crate named `bootloader` in your Cargo.toml.

I also tried building the bootloader as described in the bootloader README with ~/Dev/rusty-hermit$ KERNEL=target/x86_64-unknown-hermit/debug/rusty_demo KERNEL_MANIFEST=libhermit-rs/Cargo.toml cargo xbuild --release --features binary --target x86_64-unknown-hermit-kernel. Here rusty_demo is the Kernel linked together with a demo application. The error is error: --features is not allowed in the root of a virtual workspace.
Running that command in the demo directory: error: Package `rusty_demo v0.1.0 (/home/xxx/Dev/rusty-hermit/demo)` does not have these features: `binary` .

Do you have any ideas / hints on what I could do or look at to get this running?

The bootloader dependency needs to be in the Cargo.toml of the executable, so for example in demo/Cargo.toml if you want to build the rusty_demo executable.
The problem you are seeing occurs because cargo build builds all binaries in the project by default. In this situation, bootimage tries to also create bootable disk images for all built binaries, but some of the binaries have no bootimage dependency. (In the error message you posted, you see that bootimage successfully created the bootable disk image for the rusty_demo binary but failed afterwards when it tried to created the bootable disk image for the next binary. We should definitely improve the error message to make this more clear.)
To fix this problem, either add a bootimage dependency to all your binaries in the workspace if you want to build them all with bootimage. Alternatively, try building from the subdirectory of an executable or specifying a single executable to build by passing e.g. --bin rusty_demo.

Thanks a lot, that was very helpful!


As a tutor, I would want to be warned if the student owes money

... so that I know who to collect money from in the day.

(Completed already? By Caden?)

Have a UI to indicate to the user that the student owes money (highlighting in red)

Closed in #146


[Bug] [Website] The Cluster doc is not update to 3.x still 2.x.x version

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
The Cluster doc is not update to 3.x still 2.x.x version
What you expected to happen
The Cluster doc update to 3.x
How to reproduce
check https://dolphinscheduler.apache.org/zh-cn/docs/latest/user_doc/guide/installation/cluster.html
Anything else
No response
Version
3.0.0-alpha
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

after https://github.com/apache/dolphinscheduler/pull/9726 merged, we have 3.0.0 doc in dev branch and dev docs https://dolphinscheduler.apache.org/zh-cn/docs/dev/user_doc/guide/installation/cluster.html. and the docs will be released alone with 3.0.0-beta


Updates to cttso pipeline

TODO

[x] Waiting on PR #111 first
[x] Rebase onto main after PR #111 is approved

Updates to TSO500 pipeline

Allow for coercion of a valid index for a fastq file
Validate dsdm json file at the end of the tso500-ctdna workflow

Asserts that all samples have passed the pipeline, this improves debugging ability as workflow will halt earlier in event of a failure.

Added multiqc on the aligncollapsefusion caller output directory as part of the post-processing workflow

@alexiswl - can you link ICA workflow run ID for the testing of these changes?

Done, retriggering sync to place run in the catalogue


Problem in the Command npm test

Node version: 0.12.2
npm version:2.7.4
Operating system:Windows 10
Command line used: npm test
Steps to reproduce:

Finally I have got my solution. I have uninstalled old node.js version and install version 6.8.1 and it's work Properly.

Great to hear!


Cached Activities - Data Cleanup, Code Table Mapping

Overview
Accidentally closed https://github.com/bcgov/invasivesbc/issues/692, re-opening with proper dev merge resolution and linting
This PR includes the following proposed change(s):

https://github.com/bcgov/invasivesbc/issues/686

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Screenshots
Please add any relevant UI screenshots if applicable.
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation
[x] New and existing unit tests pass locally with my changes

Lint errors are for other files here.  @micheal-w-wells let me know if this is causing git weirdness again... if so, it's the last time I use in-browser merge resolution.

@dogcomplex looks like what you've got here doesn't build


Updating DBaaS flavours and price

Changing numbers to reflect steering group meeting.
Added some clarification about how backup billing works.

Change: https://csc-guide-preview.rahtiapp.fi/origin/DBAAS-2023-06-06/cloud/dbaas/flavors/
For the reviewer I think the important part is to make sure that the added text makes sense to you.


[feat] 819 Plugin installation / development

Description
According to proposal 1, we are now all agree that plugin is a folder under plugins for the moment.
Describe the solution you'd like
Plugin developer should clone our repo and create an subfoder under plugins for his plugin. Plugin could import stuff from Framework, but not the other way around, that is, Framework should not import anything from a specific plugin directly.
Has the Feature been Requested Before?
No
Describe alternatives you've considered
Could we leverage npm  for our Plugin Installation? Feel free to share your thought.

https://github.com/merico-dev/lake/pull/243

closed due to language switching.


feat: enabled loading yaml config for the main node

Added config_path flag to the main node binary.
If set, binary will load the config from a yaml file instead of env vars.
I've moved each proto descriptor file to its own package, because prost seems to be unable to import package from multiple files.
I've moved secrets out of TempConfigStore, so that they are delivered separately.

Although we have this fellow. This was added as a quick fix to make it possible to not have a private key in each env we use, not sure if this in or out of scope for this PR.

Although we have this fellow. This was added as a quick fix to make it possible to not have a private key in each env we use, not sure if this in or out of scope for this PR.

I'd say it's out of scope and i'll move it to secret part


jsk_planning: 0.1.10-0 in 'jade/distribution.yaml' [bloom]

Increasing version of package(s) in repository jsk_planning to 0.1.10-0:

upstream repository: https://github.com/jsk-ros-pkg/jsk_planning
release repository: https://github.com/tork-a/jsk_planning-release.git
distro file: jade/distribution.yaml
bloom version: 0.5.24
previous version for package: 0.1.9-0

jsk_planning

No changes

pddl_msgs

No changes

pddl_planner
* [task_compiler] fix: symbol is compared with string (#60 <https://github.com/jsk-ros-pkg/jsk_planning/issues/60>)
* Contributors: Yuki Furuta

pddl_planner_viewer

No changes

task_compiler
* [task_compiler] fix: symbol is compared with string (#60 <https://github.com/jsk-ros-pkg/jsk_planning/issues/60>)
* Contributors: Yuki Furuta

Holding for sync...


Loss records

Are the losses for the generator/discriminator being recorded in some file?

Yes, they are recorded in the tfevents file that can be visualized via tensorboard.

Great, thanks!


CSA 2015 FRQs to PBL Association

Links to my FRQ question breakdowns:

FRQ Submenu
Link

FRQ 1
Link

FRQ 2
Link

FRQ 3
Link

FRQ 4
Link

Question 1: The first FRQ was about Arrays/Array Lists, specifically checking weather they are diverse or not. There are lots of use cases of this in our project. One such case is when the teacher is creating an assignment. We can use both 1D arrays and array lists to store the names of assignments, and we should always check to see if there's an existing assignment with the same name.
Here's an example with 1D arrays
public class AssignmentManager {

    private static final int MAX_ASSIGNMENTS = 100;
    private String[] assignmentNames = new String[MAX_ASSIGNMENTS];
    private int nextIndex = 0;

    public void addAssignment(String assignmentName) {
        // Check for diversity before adding
        if (!isAssignmentNameAlreadyUsed(assignmentName)) {
            // Add the assignment if diverse
            assignmentNames[nextIndex] = assignmentName;
            nextIndex++;
        } else {
            // Handle duplicate assignment names
            System.out.println("Assignment name already exists. Please choose a different name.");
        }
    }

    public boolean isAssignmentNameAlreadyUsed(String newAssignmentName) {
        for (int i = 0; i < nextIndex; i++) {
            if (assignmentNames[i] != null && assignmentNames[i].equals(newAssignmentName)) {
                // Assignment name already exists
                return true;
            }
        }
        // Assignment name is diverse
        return false;
    }

    public static void main(String[] args) {
        AssignmentManager manager = new AssignmentManager();

        // Example of adding assignments
        manager.addAssignment("Homework 1");
        manager.addAssignment("Lab 1");
        manager.addAssignment("Homework 2");
        manager.addAssignment("Project 1");
    }
}

And here's an example using an ArrayList:
import java.util.ArrayList;

public class AssignmentManagerWithArrayList {

    private ArrayList<String> assignmentList = new ArrayList<>();

    public void addAssignment(String assignmentName) {
        // Check for diversity before adding
        if (!assignmentList.contains(assignmentName)) {
            // Add the assignment if diverse
            assignmentList.add(assignmentName);
        } else {
            // Handle duplicate assignment names
            System.out.println("Assignment name already exists. Please choose a different name.");
        }
    }

    // Other methods and functionalities related to your assignment management system

    public static void main(String[] args) {
        AssignmentManagerWithArrayList manager = new AssignmentManagerWithArrayList();

        // Example of adding assignments
        manager.addAssignment("Homework 1");
        manager.addAssignment("Lab 1");
        manager.addAssignment("Homework 2");
        manager.addAssignment("Project 1");
    }
}

Question 2 - The second FRQ question was based on classes, and was the word guessing game. The user would have to guess the hidden word, and would receive hints based on asterisks or plus signs - depending on whether or not a particular letter they guessed was in the word or not, until they eventually guessed the word correctly. Creating classes is an essential Java skill, and is used essentially everywhere in our projects. One specific way I can incorporate this guessing game logic into our newest feature (the flashcards feature), is to make it so that the student receives the definition of the word and has to guess what the word is. This would help the student study better and fully understand the terms on the flashcards.
import java.util.ArrayList;
import java.util.Scanner;

public class AssignmentManagerWithWordGuess {
    private ArrayList<Flashcard> flashcards = new ArrayList<>();
    private Scanner scanner = new Scanner(System.in);

    public class Flashcard {
        private String term;
        private String definition;

        public Flashcard(String term, String definition) {
            this.term = term.toLowerCase();  // Convert to lowercase for case-insensitivity
            this.definition = definition;
        }

        public String getTerm() {
            return term;
        }

        public String getDefinition() {
            return definition;
        }
    }

    public class WordGuessGame {
        private String targetWord;
        private String guessedWord;

        public WordGuessGame(String targetWord) {
            this.targetWord = targetWord.toLowerCase();  // Convert to lowercase for case-insensitivity
            initializeGuessedWord();
        }

        private void initializeGuessedWord() {
            guessedWord = "*".repeat(targetWord.length());
        }

        public String getGuessedWord() {
            return guessedWord;
        }

        public boolean makeGuess(char guessedLetter) {
            guessedLetter = Character.toLowerCase(guessedLetter);  // Convert to lowercase for case-insensitivity

            boolean letterFound = false;
            StringBuilder newGuessedWord = new StringBuilder(guessedWord);

            for (int i = 0; i < targetWord.length(); i++) {
                if (targetWord.charAt(i) == guessedLetter) {
                    newGuessedWord.setCharAt(i, guessedLetter);
                    letterFound = true;
                }
            }

            guessedWord = newGuessedWord.toString();
            return letterFound;
        }
    }

    // Method to add flashcards to the system
    public void addFlashcard(String term, String definition) {
        Flashcard flashcard = new Flashcard(term, definition);
        flashcards.add(flashcard);
    }

    // Method to play the flashcard game
    public void playFlashcardGame() {
        for (Flashcard flashcard : flashcards) {
            System.out.println("Definition: " + flashcard.getDefinition());

            WordGuessGame wordGuessGame = new WordGuessGame(flashcard.getTerm());

            System.out.println("Guess the term:");
            int maxGuesses = 3;
            int guessesMade = 0;

            while (!wordGuessGame.getGuessedWord().equals(flashcard.getTerm()) && guessesMade < maxGuesses) {
                char guessedLetter = getUserGuess();
                boolean letterFound = wordGuessGame.makeGuess(guessedLetter);

                if (letterFound) {
                    System.out.println("Good guess! Updated word: " + wordGuessGame.getGuessedWord());
                } else {
                    System.out.println("Incorrect guess. Try again. Updated word: " + wordGuessGame.getGuessedWord());
                }

                guessesMade++;
            }

            if (wordGuessGame.getGuessedWord().equals(flashcard.getTerm())) {
                System.out.println("Correct! The term is: " + flashcard.getTerm());
            } else {
                System.out.println("Sorry, you've reached the maximum number of guesses. The correct term was: " + flashcard.getTerm());
            }
        }
    }

    private char getUserGuess() {
        System.out.print("Enter your guess (single letter): ");
        return scanner.next().toLowerCase().charAt(0);
    }

    public static void main(String[] args) {
        AssignmentManagerWithWordGuess manager = new AssignmentManagerWithWordGuess();

        // Example of adding flashcards
        manager.addFlashcard("OOP", "Object-Oriented Programming");
        manager.addFlashcard("GUI", "Graphical User Interface");
        manager.addFlashcard("API", "Application Programming Interface");

        // Example of playing the flashcard game
        manager.playFlashcardGame();
    }
}

Question 3 - FRQ 3 was about 2D arrays, and more specifically sparse arrays. I wasn't too familiar with the concept of sparse arrays prior to this FRQ test, so this is definitely something I need to give more thought about on how we can incorporate it into our project. However here is one quick idea that I had:
import java.util.HashMap;

public class AssignmentManagerWithSparseArray {

    public class SparseArray {
        private HashMap<String, HashMap<String, Integer>> sparseArray;

        public SparseArray() {
            sparseArray = new HashMap<>();
        }

        public void setGrade(String studentName, String assignmentName, int grade) {
            sparseArray.computeIfAbsent(studentName, k -> new HashMap<>()).put(assignmentName, grade);
        }

        public int getGrade(String studentName, String assignmentName) {
            return sparseArray.getOrDefault(studentName, new HashMap<>()).getOrDefault(assignmentName, 0);
        }
    }

    private SparseArray gradeArray = new SparseArray();

    // Method to set a student's grade for a specific assignment
    public void setGrade(String studentName, String assignmentName, int grade) {
        gradeArray.setGrade(studentName, assignmentName, grade);
        System.out.println("Grade set for " + studentName + " in " + assignmentName + ": " + grade);
    }

    // Method to get a student's grade for a specific assignment
    public int getGrade(String studentName, String assignmentName) {
        return gradeArray.getGrade(studentName, assignmentName);
    }

    // Example of usage
    public static void main(String[] args) {
        AssignmentManagerWithSparseArray manager = new AssignmentManagerWithSparseArray();

        // Example of setting grades
        manager.setGrade("Aniket Chakradeo", "Homework 1", 95);
        manager.setGrade("Soham Kamat", "Lab 1", 88);

        // Example of getting grades
        int johnGrade = manager.getGrade("Aniket Chakradeo", "Homework 1");
        System.out.println("Aniket's grade in Homework 1: " + johnGrade);

        int janeGrade = manager.getGrade("Soham Kamat", "Lab 1");
        System.out.println("Soham's grade in Lab 1: " + janeGrade);
    }
}

In this example, a sparse array is implemented through the SparseArray class, which efficiently stores grades for students in various assignments. The SparseArray uses a nested HashMap structure, allowing for the dynamic addition and retrieval of grades. The AssignmentManagerWithSparseArray class extends an assignment manager and incorporates the sparse array to set and retrieve grades. The setGrade and getGrade methods interact with the SparseArray instance, enabling the assignment manager to efficiently manage grades by avoiding unnecessary memory allocation for default values. The usage in the main method demonstrates how the AssignmentManagerWithSparseArray class can be employed to set and retrieve grades for specific students and assignments.
Question 4 - The last FRQ placed significant emphasis on methods and control structures. It required a solid understanding of these concepts throughout. Initially, in creating the NumberGroup interface, we developed an interface representing a group of integers, incorporating a "contains" method to check if a given integer belonged to the group. Then, in the Range class, part b demanded the implementation of the contains method. Here, control structures played a key role as conditional statements were employed to determine if an integer fell within the specified range. Lastly, in the MultipleGroups class, which implemented the NumberGroup interface, control structures were utilized to iterate over each NumberGroup, checking if a given integer was present in any of them. This is another topic which I hadn't given too much thought into, as I wasn't sure if it was on the AP test or not. However if we were to incorporate it into our project, we could do something like a system that uses control structures to check weather or not a student has submitted a homework assignment.
import java.util.List;

public class AssignmentManagerWithBasicLogic {

    public interface Assignment {
        boolean isCompleted(Student student);
    }

    public static class Homework implements Assignment {
        private List<String> submittedHomework;

        public Homework(List<String> submittedHomework) {
            this.submittedHomework = submittedHomework;
        }

        public boolean isCompleted(Student student) {
            // Logic to check if the student has submitted the homework
            return submittedHomework.contains(student.getName());
        }
    }

    public static class Project implements Assignment {
        private boolean completed;

        public Project(boolean completed) {
            this.completed = completed;
        }

        public boolean isCompleted(Student student) {
            // Logic to check if the student has completed the project
            return completed;
        }
    }

    public static class Student {
        private String name;

        public Student(String name) {
            this.name = name;
        }

        public String getName() {
            return name;
        }
    }

    public static class AssignmentManager {
        private List<Assignment> assignments;

        public AssignmentManager(List<Assignment> assignments) {
            this.assignments = assignments;
        }

        public void checkAssignmentsCompletion(Student student) {
            for (Assignment assignment : assignments) {
                if (assignment.isCompleted(student)) {
                    System.out.println(student.getName() + " has completed " + assignment.getClass().getSimpleName());
                } else {
                    System.out.println(student.getName() + " has not completed " + assignment.getClass().getSimpleName());
                }
            }
        }
    }

    public static void main(String[] args) {
        Student student1 = new Student("John");
        Student student2 = new Student("Jane");

        // Homework logic: John has submitted, Jane hasn't
        List<String> submittedHomework = List.of("John");
        Homework homework = new Homework(submittedHomework);

        // Project logic: John completed, Jane not completed
        Project project = new Project(true);

        List<Assignment> assignments = List.of(homework, project);

        AssignmentManager manager = new AssignmentManager(assignments);

        manager.checkAssignmentsCompletion(student1);
        manager.checkAssignmentsCompletion(student2);
    }
}

In this example, we've built a system to manage homework and projects for students using Java. Each type of assignment, represented by the Homework and Project classes, has a method to check if it's completed. For Homework, we check if a student's name is in the list of submitted homework, and for Project, we directly check if it's marked as completed. The AssignmentManager class uses a method that incorporates loops to go through the assignments, applying the completion check method for each and displaying whether a student has completed each assignment or not. This example highlights the use of basic control structures like loops and methods to handle assignment completion in a straightforward manner. Obviously this is a very basic example, and we would have to adjust the logic based on our specific requirements and consider how we would track completion for homework and projects.

Grading For Association;
FRQ 1; Good knowledge and connections and demonstration and usage within projects , demonstrated storing of values and a checking arrays by index which connected to the FRQ,
Score: 1/0.9
FRQ 2: Classes made shown but didn't really have a clean explanation on how the FRQ worked which is where I would dock some points off but had an understanding of the class.
0.9/0.9
FRQ 3: had a good understanding and how did PBL would work towards however  didn't implement this specific code rather but talked about what
0.9/0.9
FRQ 4 : This Didn't necessarily talk about the specific connections between what interfaces are used for rather just gave an example could be more detailed but had a good example and talked about what they had learned about the specific interface.
0.9/1
TOTAL:
3.7/3.6

FRQ 1
Part A: Code Was Executed good and implementation, had a great understanding of the arrays and how they return a sum. Overall Great
Part B:  Good explanation of how the code would work and how sums and iteration works within an array
Part C: Made sense of diversify within the arrays and code ran well all expectation were met and turned in early  For the specific FRQ he had implemented correct methods
Score 1/0.9
FRQ 2

FRQ 2 , Had a good understanding of how the implementation and methods of the CLAss and a fluent explanation. FRQ was cleanly coded but could have used more documentation,

Score 1/0.9
FRQ 3
Part A: Good


deps: updates mariadb and armeria to latest

technically, this version of the mariadb driver is the only one officially supported for JRE 21

ok fire in the hole git push origin release-2.25.1


Update secure-your-business-data.md

Corrected the admin center link

@SuPotter @AndreaBarr - PR is ready for final review based on issue #684. This is just for a broken link issue.
Thank you.


Hugo: Formatting guidelines

Here are formatting guidelines - needs some improvement, though.

I should add a few more tips, like alerts and such.
New URL is at:
https://alguidelines.dev/docs/contributing/formattingtips/
There's lots of great shortcodes, and alert is a great example.
https://www.docsy.dev/docs/adding-content/shortcodes/#alert


Change in containerd Windows paths interpretation breaks pre-existing hostProcess manifests

Description
After upgrading from containerd 1.6.8 to 1.7.0-beta.3 on Windows 2022, the Calico Windows HostProcess based manifest broke with an inability to find paths to files.
This can be resolved with a different approach to specifying paths in the manifests.
However, Calico is an important project for Windows users, so backward compatibility with this pre-existing manifest is desired.
Steps to reproduce the issue

Apply this manifest with Windows nodes onto a containerd 1.6.8 cluster:

---
apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: calico-node-windows
  namespace: kube-system
spec:
  selector:
    matchLabels:
      k8s-app: calico-node-windows
  updateStrategy:
    type: RollingUpdate
    rollingUpdate:
      maxUnavailable: 1
  template:
    metadata:
      labels:
        k8s-app: calico-node-windows
    spec:
      serviceAccountName: calico-node
      securityContext:
        windowsOptions:
          hostProcess: true
          runAsUserName: "NT AUTHORITY\\system"
      hostNetwork: true
      tolerations:
        # Make sure calico-node gets scheduled on all nodes.
        - effect: NoSchedule
          operator: Exists
        # Mark the pod as a critical add-on for rescheduling.
        - key: CriticalAddonsOnly
          operator: Exists
        - effect: NoExecute
          operator: Exists
      initContainers:
        - name: install
          image: calico/windows:v3.23.5
          args:
            - ".\\host-process-install.ps1"
          imagePullPolicy: Always
          envFrom:
            - configMapRef:
                name: calico-windows-config
          # Calico needs to know the name of the node on which it is running.
          env:
            - name: NODENAME
              valueFrom:
                fieldRef:
                  apiVersion: v1
                  fieldPath: spec.nodeName
      containers:
        - name: node
          image: calico/windows:v3.23.5
          imagePullPolicy: Always
          args:
            - ".\\node\\node-service.ps1"
          # The node container's working dir is in c:\CalicoWindows on the host,
          # which is two-levels up from the CONTAINER_SANDBOX_MOUNT_POINT.
          workingDir: "..\\..\\CalicoWindows"
          envFrom:
            - configMapRef:
                name: calico-windows-config
          # Calico needs to know the name of the node on which it is running.
          env:
            - name: NODENAME
              valueFrom:
                fieldRef:
                  apiVersion: v1
                  fieldPath: spec.nodeName
        - name: felix
          image: calico/windows:v3.23.5
          imagePullPolicy: Always
          args:
            - ".\\felix\\felix-service.ps1"
          # The felix container's working dir is in c:\CalicoWindows on the host,
          # which is two-levels up from the CONTAINER_SANDBOX_MOUNT_POINT.
          workingDir: "..\\..\\CalicoWindows"
          envFrom:
            - configMapRef:
                name: calico-windows-config
          # Calico needs to know the name of the node on which it is running.
          env:
            - name: NODENAME
              valueFrom:
                fieldRef:
                  apiVersion: v1
                  fieldPath: spec.nodeName
          livenessProbe:
            exec:
              command:
                - c:\\CalicoWindows\\calico-node.exe
                - -felix-live
            periodSeconds: 10
            initialDelaySeconds: 10
            failureThreshold: 6
            timeoutSeconds: 10
          readinessProbe:
            exec:
              command:
                - c:\\CalicoWindows\\calico-node.exe
                - -felix-ready
            periodSeconds: 10
            timeoutSeconds: 10
        - name: confd
          image: calico/windows:v3.23.5
          imagePullPolicy: Always
          args:
            - ".\\confd\\confd-service.ps1"
          # The confd container's working dir is in c:\CalicoWindows on the host,
          # which is two-levels up from the CONTAINER_SANDBOX_MOUNT_POINT.
          workingDir: "..\\..\\CalicoWindows"
          envFrom:
            - configMapRef:
                name: calico-windows-config
          # Calico needs to know the name of the node on which it is running.
          env:
            - name: NODENAME
              valueFrom:
                fieldRef:
                  apiVersion: v1
                  fieldPath: spec.nodeName
      nodeSelector:
        kubernetes.io/os: windows

Observe the pods start.
Upgrade to containerd 1.7.0-beta.3
Observe the pods error with:

~ $ kubectl logs -n kube-system calico-node-windows-9nmkf install -f
.\host-process-install.ps1 : The term '.\host-process-install.ps1' is not recognized as the name of a cmdlet,
function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the
path is correct and try again.
At line:1 char:1
+ .\host-process-install.ps1
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (.\host-process-install.ps1:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Apply the following manifest instead:

---
apiVersion: apps/v1
kind: DaemonSet
metadata:
  name: calico-node-windows
  namespace: kube-system
spec:
  selector:
    matchLabels:
      k8s-app: calico-node-windows
  updateStrategy:
    type: RollingUpdate
    rollingUpdate:
      maxUnavailable: 1
  template:
    metadata:
      labels:
        k8s-app: calico-node-windows
    spec:
      serviceAccountName: calico-node
      securityContext:
        windowsOptions:
          hostProcess: true
          runAsUserName: "NT AUTHORITY\\system"
      hostNetwork: true
      tolerations:
        # Make sure calico-node gets scheduled on all nodes.
        - effect: NoSchedule
          operator: Exists
        # Mark the pod as a critical add-on for rescheduling.
        - key: CriticalAddonsOnly
          operator: Exists
        - effect: NoExecute
          operator: Exists
      initContainers:
        - name: install
          image: calico/windows:v3.23.5
          args:
            - ".\\host-process-install.ps1"
          imagePullPolicy: Always
          envFrom:
            - configMapRef:
                name: calico-windows-config
          workingDir: "$env:CONTAINER_SANDBOX_MOUNT_POINT"
          # Calico needs to know the name of the node on which it is running.
          env:
            - name: NODENAME
              valueFrom:
                fieldRef:
                  apiVersion: v1
                  fieldPath: spec.nodeName
      containers:
        - name: node
          image: calico/windows:v3.23.5
          imagePullPolicy: Always
          args:
            - "C:/CalicoWindows/node/node-service.ps1"
          # The node container's working dir is in c:\CalicoWindows on the host,
          # which is two-levels up from the CONTAINER_SANDBOX_MOUNT_POINT.
          workingDir: "C:/CalicoWindows"
          envFrom:
            - configMapRef:
                name: calico-windows-config
          # Calico needs to know the name of the node on which it is running.
          env:
            - name: NODENAME
              valueFrom:
                fieldRef:
                  apiVersion: v1
                  fieldPath: spec.nodeName
        - name: felix
          image: calico/windows:v3.23.5
          imagePullPolicy: Always
          args:
            - "C:/CalicoWindows/felix/felix-service.ps1"
          # The felix container's working dir is in c:\CalicoWindows on the host,
          # which is two-levels up from the CONTAINER_SANDBOX_MOUNT_POINT.
          workingDir: "C:/CalicoWindows"
          envFrom:
            - configMapRef:
                name: calico-windows-config
          # Calico needs to know the name of the node on which it is running.
          env:
            - name: NODENAME
              valueFrom:
                fieldRef:
                  apiVersion: v1
                  fieldPath: spec.nodeName
          livenessProbe:
            exec:
              command:
                - c:\\CalicoWindows\\calico-node.exe
                - -felix-live
            periodSeconds: 10
            initialDelaySeconds: 10
            failureThreshold: 6
            timeoutSeconds: 10
          readinessProbe:
            exec:
              command:
                - c:\\CalicoWindows\\calico-node.exe
                - -felix-ready
            periodSeconds: 10
            timeoutSeconds: 10
        - name: confd
          image: calico/windows:v3.23.5
          imagePullPolicy: Always
          args:
            - "C:/CalicoWindows/confd/confd-service.ps1"
          # The confd container's working dir is in c:\CalicoWindows on the host,
          # which is two-levels up from the CONTAINER_SANDBOX_MOUNT_POINT.
          workingDir: "C:/CalicoWindows"
          envFrom:
            - configMapRef:
                name: calico-windows-config
          # Calico needs to know the name of the node on which it is running.
          env:
            - name: NODENAME
              valueFrom:
                fieldRef:
                  apiVersion: v1
                  fieldPath: spec.nodeName
      nodeSelector:
        kubernetes.io/os: windows

Observe the manifest now installs.

For your convenience, the diff between the two manifests:
diff --git a/apps/base/calico-windows-3.23.5.yaml b/apps/base/calico-windows-3.23.5.yaml
index 6060456..1f0fdbc 100644
--- a/apps/base/calico-windows-3.23.5.yaml
+++ b/apps/base/calico-windows-3.23.5.yaml
@@ -41,6 +41,7 @@ spec:
           envFrom:
             - configMapRef:
                 name: calico-windows-config
+          workingDir: "$env:CONTAINER_SANDBOX_MOUNT_POINT"
           # Calico needs to know the name of the node on which it is running.
           env:
             - name: NODENAME
@@ -53,10 +54,10 @@ spec:
           image: calico/windows:v3.23.5
           imagePullPolicy: Always
           args:
-            - ".\\node\\node-service.ps1"
+            - "C:/CalicoWindows/node/node-service.ps1"
           # The node container's working dir is in c:\CalicoWindows on the host,
           # which is two-levels up from the CONTAINER_SANDBOX_MOUNT_POINT.
-          workingDir: "..\\..\\CalicoWindows"
+          workingDir: "C:/CalicoWindows"
           envFrom:
             - configMapRef:
                 name: calico-windows-config
@@ -71,10 +72,10 @@ spec:
           image: calico/windows:v3.23.5
           imagePullPolicy: Always
           args:
-            - ".\\felix\\felix-service.ps1"
+            - "C:/CalicoWindows/felix/felix-service.ps1"
           # The felix container's working dir is in c:\CalicoWindows on the host,
           # which is two-levels up from the CONTAINER_SANDBOX_MOUNT_POINT.
-          workingDir: "..\\..\\CalicoWindows"
+          workingDir: "C:/CalicoWindows"
           envFrom:
             - configMapRef:
                 name: calico-windows-config
@@ -105,10 +106,10 @@ spec:
           image: calico/windows:v3.23.5
           imagePullPolicy: Always
           args:
-            - ".\\confd\\confd-service.ps1"
+            - "C:/CalicoWindows/confd/confd-service.ps1"
           # The confd container's working dir is in c:\CalicoWindows on the host,
           # which is two-levels up from the CONTAINER_SANDBOX_MOUNT_POINT.
-          workingDir: "..\\..\\CalicoWindows"
+          workingDir: "C:/CalicoWindows"
           envFrom:
             - configMapRef:
                 name: calico-windows-config

Describe the results you received and expected
I expect a manifest that works under 1.6.8 to work with 1.7.0-beta.3, i.e. upgrading containerd should not change how paths are interpreted so greatly as to violate the assumptions/expectations of Kubernetes manifest authors writing against 1.6.
What version of containerd are you using?
containerd github.com/containerd/containerd v1.7.0-beta.3 b8962099e7ce533cc62e540ec25f6d1d93e35a0b
Any other relevant information
Windows 2022 LTSC
microk8s Kubernetes 1.26.1 on Linux, vanilla Kubernetes workers 1.26.0 on Windows
Show configuration if it is related to CRI plugin.
No response

The changes in volume mounts for host process containers between containerd v1.6.x and v1.7.x is by design.
https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/1981-windows-privileged-container-support#container-mounts for more information

Okay I'll keep this a strictly Calico issue

A bajillion things are affected by this so you probably want to test it more?


Document Reporting API

User story
As a web developer, I want to read about the Reporting API, so I can use it to gather better reporting information about my web sites
Acceptance criteria

[ ] Report-To header documented

[x] ReportingObserver interface documented

[x] Report interface documented

[x] ReportingObserverOptions dictionary documented

[x] DeprecationReportBody documented

[x] InterventionReportBody documented

[x] CrashReportBody documented

[ ] GroupData.json entry added for Reporting API

[ ] BCD added for Reporting API features

[ ] Write "Using the Reporting API" guide

Report-To header BCD was done in https://github.com/mdn/browser-compat-data/pull/3550

Update: All of the work is done, except for Report-To docs, which I'm still trying to get from engineering on, and BCD, and writing a short guide to teach people about it.
I also need to check when this is going to be finally enabled. Incould defer it to later on, if it isn't going to hit 67.

New estimate set for remaining work — 1.5 points.

@chrisdavidmills This had an EOS comment of "Probably done this week, really" at the end of Q1 Sprint 3. Is it actually done?

This is still not done; I've hit a brick wall as the engineer reponsible for it has become unresponsive.
I was going to put it into the next sprint as a task to get to if I get time.


DS-3040 fix discovery detection in "dspace version"

fixes the issue
removes lucene detection (as lucene search is now removed)

https://jira.duraspace.org/browse/DS-3040

I concur with tdonohue's suggestion about positively stating when Discovery is not enabled.  Otherwise, +1.


please make windows terminal into microsoft terminal with gtk3 buttons

Description of the new feature/enhancement

port to linux
Proposed technical implementation details (optional)

rewrite and compile for linux

Thanks for the idea! We're not planning on porting Windows Terminal to any other platforms at the moment, but we'll keep it in mind.

May I please do it?

Of course you can try it. You can do almost anything with this source code, as it's MIT licensed. But as Dustin said, you will fail in porting this project. It's almost entirely Windows-specific.


Fix markdown to prevent interpreting as HTML

@simonalpha looks like I totally missed your update to this, way back in the day, and now it's out of date. Oops! Sorry! Thanks for the work. You're one of three people in umpteen workshops who took me up on the offer to improve the lesson. =D


Scrolling to the top of MyObservations doesn't always bring back Header

A user should be able to scroll to the top and see both the Header and Toolbar. Currently, scrolling to the top is inconsistent -- sometimes it shows the Header & Toolbar, sometimes it only shows the Toolbar, and sometimes it shows half of the header (the username, but not the Welcome back line of text).

This is actually working pretty well for me, @albullington. Would you try and replicate again or close?

@kueda included a screen recording with repro conditions. For the original issue here, the main thing that I'm seeing is that when a user scrolls to the top, sometimes the whole header is displayed, but sometimes the "Welcome back" text is cut off.
This screen recording also highlights a separate (maybe related) issue, that when a user scrolls down and loads more observations, the top part of the header disappears suddenly so only the toolbar is displayed.
https://github.com/inaturalist/iNaturalistReactNative/assets/35536439/6de931cc-9c32-47a6-ac85-b11451dbb063
So things to fix here are:

[ ] Welcome back text is occasionally cut off when scrolling up on MyObservations
[ ] Top half of header disappears suddenly when user pulls down to load more observations

What device are you using? I'm not seeing that on an iPad Air (5th gen) or an iPhone SE, so maybe it has to do with using a device with a camera in the screen area?

This is on iPhone 15 Pro -- maybe has something to do with the SafeAreaView, if you're not seeing it on the other iOS devices


Use exception translation in streaming methods

Currently, streaming methods don't translate exceptions, so the user just sees the raw StatusRuntimeException. We need to add exception translation like unary methods have.

I think this has been fixed

@andreamlin can you confirm and close this?

Thanks @igorbernstein2 !


Fix Issue #1109: Expose relevant info about Electron, node, platform,…

… architecture in the 'About' dialog.

Description
Fixes #1109 and included more info as was previously already present for Windows version of Ferdi.
Motivation and Context
As techies/developers who contribute to Ferdi, we need a quick way to access the pertinent information.
Also, for security-aware non-techies, exposing the Electron version in the 'About' dialog will reassure them of us being ahead of the curve in adopting newer Electron releases for security patches.
Screenshots

Checklist:

[x] My pull request is properly named
[x] The changes respect the code style of the project ($ npm run lint)
[x] I tested/previewed my changes locally

I've tried merging this locally on top of #1308, and my about box is the same as it were before. This is a bit suprising, as I would have expected it to display Arch: x64 as a new piece of info. Nevertheless, not both platforms display roughly the same info.
It seems about dialog behavior is not consistent across platforms in Electron, though: https://github.com/electron/electron/issues/23851

Yes, each os seems to be different.
sent using an itty-bitty keyboard that assumes it can think
On Wed, 28 Apr, 2021, 2:37 PM Kristóf Marussy, @.***>
wrote:

I've tried merging this locally on top of #1308
https://github.com/getferdi/ferdi/pull/1308, and my about box is the
same as it were before. This is a bit suprising, as I would have expected
it to display Arch: x64 as a new piece of info. Nevertheless, not both
platforms display roughly the same info.
It seems about dialog behavior is not consistent across platforms in
Electron, though: electron/electron#23851
https://github.com/electron/electron/issues/23851
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/getferdi/ferdi/pull/1309#issuecomment-828289203, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAQ77L7Q5LPFELGYHNUF4LTK7F5XANCNFSM43WMY6ZA
.

@kytwb @vantezzen - please merge asap?

@vraravam thanks!


Prioritize documentation for full release versions

"Hi PyFluent, I see that the examples on GitHub apply to the latest release of PyFluent (installed using --pre option). For example, launch_fluent 'mode' option is not available with the version that's available with the standard pip install. Since most customers will not use the --pre option, they will get tripped up when working through the example."
Applies to all repos

@seanpearsonuk @mkundu1 - So, basically should we have 2 sets of documentation (new and old)? Or shall we revert to the earlier way as of now?

@seanpearsonuk @mkundu1 , It seems this has already been done. I have confirmed for all the 3 repos - "pyfluent", "pyfluent-parametric" and "pyfluent-visualization"


Compilation failed due to difference in package names

I have a package that depends on this package and it fails on tests due to following
➜  logrus_sentry git:(master) ✗ go test
# _/Users/<username>/Projects/logrus_sentry
./sentry.go:71: undefined: raven.New
./sentry.go:82: undefined: raven.NewWithTags
./sentry_test.go:107: undefined: raven.New
FAIL	_/Users/<username>/Projects/logrus_sentry [build failed]

sorry, forgot to update the local deps, problem solved.


Make UI for authentication flow match the rest of the dashboard

Pull Request Description

Changes all authentication screens to look similar to the rest of the dashboard
Greatly simplifies HTML structure

Important Notes

This is being added before the official design is ready, but it should be useful anyway, because it greatly simplifies the HTML, which should make it easier to implement the new design
The auth screens have a larger border-radius than all other elements in the app. This is intentional, to make them look like they continue naturally from the fully rounded submit buttons.
Basic testing done:

Logging in should still work
Signing up should still work
Setting username should still work
Changing password should still work
Forgot password should still work
Password reset should still work

Screenshots

Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[x] The documentation has been updated, if necessary.
[x] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[x] Unit tests have been written where possible.
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

Tested with new GUI and everything seems alright. Merging.

gui / ide watch google / github sign in redirects stopped working.. I guess it was while ago.. are we not sending the proper redirect url anymore? user lands on cloud.enso.org


Repo sync for protected CLA branch

The pull request is created from main637999812952608121sync_temp to main to fix git push error for protected CLA branch

Learn Build status updates of commit 123a865:
:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Crash in TerraFirmaGreg Modpack

One of my players is experiencing a consistent startup crash with this mod (v1.8.0) in the TerraFirmaGreg modpack (v0.7.14, MC 1.20.1). When he disables just this mod, the game starts normally. When he enables this mod, even after updating to 2.1.0, the crash happens. Here's the crash report:
crash-2024-12-07_18.16.31-client.txt
Any help is appreciated!

His config files must be corrupt, tell him to delete the additional placements configs and let them regenerate, and see if it still happens. If it does, have him send the config files (just the additional placements ones) over.

That fixed it. Thanks!

Meant to close with previous comment...


low.js

Add support for low.js as alternative Javascript runtime instead of Node.js. This will be useful for embedded systems.

Hey @piranna, did you think about ShadowNode as the alternative Node.js runtime, which has supported the N-API.


Close editor inspector popup on scroll

Fixes: #65191
I'm not sure if the scroll wheel should close all popups because this may break some functionality when used in games, so I limited it to just the editor inspectors.
I tried to find a more straightforward and more efficient way to do this, but this was the simplest that didn't seem to have any side effects or require major surgery in the code.
Before:
https://github.com/godotengine/godot/assets/105675984/a23d90ab-6aae-4811-9e3a-4e9e5ab014bd
After:
https://github.com/godotengine/godot/assets/105675984/d7d82f00-99e2-4644-b447-d14de0b5ac8e

I realized that the popup menus that are already visible in the inspector (without right clicking) are also broken. I pushed a change that calls a close request any time you're scrolling regardless of what's open. It's not as efficient, but I think the performance penalties are minimal.

That's a very hacky solution .-.
I wonder if it's possible to close the popups directly. Also the issue technically isn't about inspector only, the same problem occurs in scene dock, file dock etc.

Single line hacks are the best hacks though 😂
I take your point, however. I couldn't find an easy direct way to do it at the time. I'll try to revisit the problem in the future.

The problem with this hack is that it's abusing a notification sent when window is being closed. Something may already handle it, leading to invalid behavior.

I think you're right, I didn't consider looking upstream and see what propagated the notification itself, so I see now that is definitely is hackier that I thought. Maybe the solution is to just build something similar with a new notification?

You could also add a signal. It requires connecting it in every EditorProperty, but it's probably better than propagating a notification to every node in the inspector.


Breakdown of needed models

Create a list of needed models for the project; what databases do we need?

is there a better example of this from class? I attempted to create the models, Let me know if things look ok


Maintenance: Untether Actors From Lanes

@AisenGinn
Issue:
Agents are locked into being close to a lane. Essentially they are on a tether.
Request:
Agents should be able to move far off-road without causing the simulation to crash.

Currently the lookahead in smarts.core.road_map.curevature_radius_at_offset only accept lookahead>=1, but lookahead is calculated by lookahead = math.ceil(1 + math.log(self._target_speed)) in smarts.core.local_traffic_provider._slow_for_curves. The error will occur when the self.target_speed is very small which make the  math.log(self._target_speed)<-1. This will cause lookahead to be negative and thus raise the assertion error. Try to fixed it in PR1673:https://github.com/huawei-noah/SMARTS/pull/1673


Fix screenshots

ez_c() function was removed in the latest version. Without this function it seems like the screenshots aren't working.

ezXSS 2.1 will no longer have screenshots by default. Of course you can add screenshots yourself with Custom JS.
Closing for now.


Language from the Host project should be managed by the library

[ ] Language from the Host project should be managed by the library
It should be a language selector that will be adapted dynamically regarding the language declared in the env variable and then used by the host project where the css can be modified

@jfayad I let you add more details as there is maybe technical stuff needed to be mentioned

This is done, closing it


Allow --strict to take a version number

This is mostly from offhand conversations with @wycats, but I needed to finally file this on the issue tracker.
Background
One of the stances that we've taken is that strict opts you into all strictness settings unless users specifically opt out. That way, users can upgrade, and only if they experience breaks do they need to manually turn options off.
This has some benefits of pushing users towards writing safer code and avoiding bugs (and often getting a better experience in general), but users may not want to have their semantics changed under them by an upgrade, or have to look into new options right away.
Proposal
One way we can alleviate this is by allowing users to lock down their strictness settings by version number. For example, right now we are experimenting adding a new --strictFunctionTypes option under the --strict bucket. For users to avoid this, they could write
{
  "compilerOptions": {
    "strict": "2.5"
  }
}

instead of
{
  "compilerOptions": {
    "strict": true,
    "strictFunctionTypes": false
  }
}

Upsides
I think @wycats might do a better job with the benefits.

Users could lock down their strictness settings and upgrade (or just allow npm to do its thing) without being as concerned with breaks.

This mean existing code with no maintainers has less of a chance of breakage.

Downsides
Here are some concerns I've come up with off the top of my head:

Why do we expect users to be able to lock down on a --strict version number than to lock down on major.minor in npm?
Is version number allowed to be an actual number (i.e. 2.5) instead of a string (i.e "2.5") in tsconfig.json? Because inevitably, someone will use a number instead of a string and they will be unhappy when it doesn't work.
If we don't expect to introduce many more strictness flags, then that may play a part here.
Will new options be discoverable to those users? Is that a problem?

For me, the whole purpose of strict is the automatic opt-in for the newest security options. If library authors/users don't want that, then they shouldn't use strict and list the pertinent flags separately in their tsconfigs instead.

If you're trying to preemptively say "strict, but no future strict stuff", you can just list all the individual tags currently grouped under "strict", instead of using "strict" directly. The flag even came with the promise, as @gcnew mentioned, that more strictness checks would be added to it in the future... I feel like the version tag is both somewhat redundant and subverts the flag's goal.

I actually think --strict itself is a bit of a red herring... Up to this point, pretty much everything has been forward compatible and strict compatible for definitions.  There have been instances where they haven't been backwards compatible (readonly, keyof, unions, intersections, etc...).  The only challenge with strictness and definition files that I am aware of is #18773.
It feels to me like it is a solution looking for a problem.  Not only would it have to be in the tsconfig.json, if it is truly going to be compiler compatible, definition files would need to be emitted with the meta data for library sharing.  It feels like something that should be tackled if/when something strict is going to be introduced that has significant opt-in issues.  I can understand it is a worry not having granular opt in, but is it a rational fear...  Our experience (@dojo) has been that once we got mostly to strict, each new release was a straight forward process.  In fact the changes from 2.4 to 2.5 so far has been trivial and things we should have typed better in the first place anyways, and nothing to do with strict.

I'm also not a fan. As Daniel pointed out to me when we discussed this yesterday, there's not really an observable difference between "strict": "2.5" in tsconfig.json vs "typescript": "2.5"in package.json other than creating more headaches for us.

This would be confusing. It implies that a given version of the language is potentially aware of both past and future versions.
It would also seem to suggest that the right way to think about new checks is in the context of language versions when in fact there are individual flags for all significant new strictness improvements precisely because they cross cut with other language improvements.
I would argue that if a new --strict check is introduced in one finds themselves wanting to opt out of it_and_ any further new --strict checks the encouraged approach should be to enable all of the desired ones explicitly.

Major points from SBS

strict is supposed to be "lightly breaky"
What does "2.6" even mean? You have to go read old release notes?

Specifying the individual flags works fine and solves that problem

We have no way guarantee any specific behavior in the future


Fix reviewdog token

WHY
WHAT
REF

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   76.56%   76.56%
=======================================
  Files           4        4
  Lines         192      192
=======================================
  Hits          147      147
  Misses         38       38
  Partials        7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e442151...56c8a7a. Read the comment docs.


Dungeon cracker returning [0] on some servers

After "short-cutting to dungeons" it finds several structure seeds, [0] among them.
When it then looks for world seeds it just returns [0] and finishes, as can be seen in the screenshot.
I am far out enough that everything is newly generated.
Let me know if you need more info.

Cause the seed is literally 0. :p


krt: initial debug interface

This adds an initial krtz debug interface.
Example output:
name: ServiceEntryWorkloads
state:
  inputs:
    default/external-svc-https:
      dependencies:
      - AuthzDerivedPolicies with filter {generic}
      - AuthzDerivedPolicies with filter {generic}
      - MeshConfig with filter {}
      - PeerAuthentications with filter {generic}
      - PeerAuthentications with filter {generic}
      - static with filter {}
      - static with filter {}
      outputs:
      - Kubernetes/networking.istio.io/ServiceEntry/default/external-svc-https/api.facebook.com
      - Kubernetes/networking.istio.io/ServiceEntry/default/external-svc-https/www.googleapis.com
  outputs:
    Kubernetes/networking.istio.io/ServiceEntry/default/external-svc-https/api.facebook.com:
      CreationTime: '2024-10-21T15:38:28-07:00'
      Labels: null
      Source: 43
      canonical_name: external-svc-https
      canonical_revision: latest
      cluster_id: Kubernetes
      hostname: api.facebook.com
      name: external-svc-https
      namespace: default
      services:
        default/api.facebook.com:
          ports:
          - service_port: 443
            target_port: 443
      uid: Kubernetes/networking.istio.io/ServiceEntry/default/external-svc-https/api.facebook.com
      workload_name: external-svc-https
      workload_type: 2
    Kubernetes/networking.istio.io/ServiceEntry/default/external-svc-https/www.googleapis.com:
      CreationTime: '2024-10-21T15:38:28-07:00'
      Labels: null
      Source: 43
      canonical_name: external-svc-https
      canonical_revision: latest
      cluster_id: Kubernetes
      hostname: www.googleapis.com
      name: external-svc-https
      namespace: default
      services:
        default/www.googleapis.com:
          ports:
          - service_port: 443
            target_port: 443
      uid: Kubernetes/networking.istio.io/ServiceEntry/default/external-svc-https/www.googleapis.com
      workload_name: external-svc-https
      workload_type: 2

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
efc729e1c194a0c864472a1eeb8b629b0dd13c04
link
true
/test lint

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Can we have a debug output that shows only the collection dependencies and outputs?

Without looking at the code it is hard to understand the meaning. Can you add a key beforedefault/external-svc-https:

And also for dependencies,

Can you add a key beforedefault/external-svc-https:

I am not sure I understand. that string is the key.. what key would we add?

I mean like kubectl output, you can add a explicit  kind ServiceEntry, etc

ah good point. let me see if I can pass the input type through. ill clean up the filters to be more clear as well

What does inputs and outputs signify?

What does inputs and outputs signify?

https://github.com/istio/istio/blob/915ac2bf05dbc7a08ae61a8bc39fcd6ea1f3d11a/pilot/pkg/serviceregistry/kube/controller/ambient/workloads.go#L134
Input: WorkloadEntrys
Output: WorkloadInfos

OK I have implemented all the TODOs and cleaned things up a bit, this is ready to go from my perspective. See the original description for the new output

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
efc729e1c194a0c864472a1eeb8b629b0dd13c04
link
true
/test lint

gencheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test gencheck

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test gencheck

lint_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test lint

integ-distroless_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test gencheck

lint_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test lint

integ-distroless_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-distroless

integ-telemetry_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test gencheck

lint_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test lint

integ-distroless_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-distroless

integ-telemetry_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-telemetry

unit-tests_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test gencheck

lint_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test lint

integ-distroless_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-distroless

integ-telemetry_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-telemetry

unit-tests_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test unit-tests

macbuildcheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test macbuildcheck

integ-cni_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-cni

integ-ipv6_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-ipv6

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test gencheck

lint_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test lint

integ-distroless_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-distroless

integ-telemetry_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-telemetry

unit-tests_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test unit-tests

macbuildcheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test macbuildcheck

integ-cni_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-cni

integ-ipv6_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-ipv6

integ-telemetry-discovery_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-telemetry-discovery

integ-security_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-security

integ-ds_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-ds

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test gencheck

lint_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test lint

integ-distroless_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-distroless

integ-telemetry_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-telemetry

unit-tests_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test unit-tests

macbuildcheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test macbuildcheck

integ-cni_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-cni

integ-ipv6_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-ipv6

integ-telemetry-discovery_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-telemetry-discovery

integ-security_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-security

integ-ds_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-ds

integ-basic-arm64_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-basic-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test gencheck

lint_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test lint

integ-distroless_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-distroless

integ-telemetry_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-telemetry

unit-tests_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test unit-tests

macbuildcheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test macbuildcheck

integ-cni_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-cni

integ-ipv6_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-ipv6

integ-telemetry-discovery_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-telemetry-discovery

integ-security_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-security

integ-ds_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-ds

integ-basic-arm64_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test gencheck

lint_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test lint

integ-distroless_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-distroless

integ-telemetry_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-telemetry

unit-tests_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test unit-tests

macbuildcheck_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test macbuildcheck

integ-cni_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-cni

integ-ipv6_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-ipv6

integ-telemetry-discovery_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-telemetry-discovery

integ-security_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-security

integ-ds_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-ds

integ-basic-arm64_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-basic-arm64

unit-tests-arm64_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test unit-tests-arm64

integ-helm_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-helm

integ-ambient_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-ambient

integ-pilot-istiodremote_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-security

integ-ambient_istio
156e8eb98f5799565f4107a4877bc462c85fa0b9
link
true
/test integ-ambient

lint_istio
3f070f51064154e30fbd96ec47b8a1afca25e3c2
link
true
/test lint

integ-distroless_istio
3f070f51064154e30fbd96ec47b8a1afca25e3c2
link
true
/test integ-distroless

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

default/external-svc-https:
  dependencies:
  - AuthzDerivedPolicies          // can this be set to user aware istio API
  - AuthzDerivedPolicies   // duplicate
  - MeshConfig
  - PeerAuthentications
  - PeerAuthentications
  - static                       // what does static mean
  - static

default/external-svc-https:
  dependencies:
  - AuthzDerivedPolicies          // can this be set to user aware istio API
  - AuthzDerivedPolicies   // duplicate
  - MeshConfig
  - PeerAuthentications
  - PeerAuthentications
  - static                       // what does static mean
  - static

oops, my bad - I fixed this already but forgot to update the description after fixing that one. Now it says NetworkTrigger I believe


Element Plus - A Vue.js 3.0 UI library
https://github.com/element-plus/element-plus/
You can check the progress here, https://github.com/ElemeFE/element/issues/20061

We have recommend Element Plus in the main page already, so close the issue.


Implement a more user-friendly "literal replace" functionality

Description of the problem or steps to reproduce
This is a feature request which naturally grows out of some reported issues/bugs related to the "replace" functionality. See:
#2951 #2937 #2887 #2832 #2174 #2155 #1920
(I'm not sure if some of the older issues have been partially or fully resolved by now but the issues are still technically open)
Basically the request is to implement:

A way to have literal replace that is actually literal, a.k.a not interpreting absolutely anything, including spaces, backslashes, quotation marks, "$" and other special symbols. You just enter whatever arbitrary string you want to replace, enter another arbitrary string to replace with, and get it done.
Probably implement a better UI for that which should feature separate fields for "string-to-replace" and "replacement-string" (see the rationale in my comment in the discussion inside #2951).
[if not too much work ] As a part of that UI, implement a simple switch for regex or literal mode (maybe toggle by pressing a specific key)
As a part of that UI, implement a button for "replace all" (maybe activate by pressing a specific key)
[ if not too much work ] implement a switch to toggle case-sensitive (or not) search/replace
Consider setting literal replace as the default since (my personal opinion) literal replace is used much more frequently by most users.
Possibly combine the replace UI with the "Find" UI so it's easy to do a task like find all instances of a string in a file, [possibly tweak the string to match exactly what you need to], switch to "replace" mode and replace all instances in one go, without having to re-enter the string again (would be a nice perk but not life-changing). See for example Notepad++ implementation (although that's GUI of course but I don't see why something equivalent, while limited to the above-mentioned features, can't be implemented in a text-based UI, at least the way it's done in Nano for example).

(1) which, as I think, requires (2), is the essential part, at least for me, although each of the other parts will definitely help if possible to implement.

Commit hash: c2cebaa
OS: Debian
Terminal: xterm

A way to have literal replace that is actually literal, a.k.a not interpreting absolutely anything, including spaces, backslashes, quotation marks, "$" and other special symbols. You just enter whatever arbitrary string you want to replace, enter another arbitrary string to replace with, and get it done.

This is more or less exactly what Find (Ctrl-f) and FindLiteral (Alt-Shift-f) already do. Instead of the command line (with all its headache of escaping, single and double quotes and so on), you have a prompt where you type just the searched string (regex or literal) and nothing more. It seems like a good idea to implement the same for replace, e.g. Replace and ReplaceLiteral actions, with some default keybindings for them. (Unlike Find, they would have 2 prompts, one after another: for the search string and for the replace string.)

Consider setting literal replace as the default since (my personal opinion) literal replace is used much more frequently by most users.

I'm not sure about that. We don't know how many users prefer using regex replace. We don't hear them complaining about regex replace not being the default, just because, well, it is the default. https://en.wikipedia.org/wiki/Selection_bias

Maybe 3 stages to add additional modes? Speaking for myself I usually like to define within the replace step if it shall be done with ignorecase or not.

I wouldn't enjoy going through this extra step every time.

And I wouldn't like to use set ignorecase true|false or toggle ignorecase every time before I use replace.
In that moment I feel more comfortable with the current approach and allowing me to add -i or not to reach what I want.


Recognize jsx and tsx extensions

This adds simple support for the .jsx and .tsx extensions. There's no special support for react here, it just uses the javascript and typescript modes respectively.

Looks good to me, at least until/if we grow some more specific solution for react.


Duck has black background

Hey, firstly, I want to say thanks for the plugin, I love watching the duck waddle around when I'm bored :smile:
Coming to my issue, the duck doesn't have a transparent background, like neovim. Instead it has a black bg around it. Do you have an idea on how to fix it?

I'm using neovim 0.5 in alacritty, running picom as my compositor

oops, sorry for being a lil late.

I love watching the duck waddle around when I'm bored.

Haha same

Instead it has a black bg around it

Its probably the winblend property. Will check and report back

ok, thanks!

Heyyo @classPythonAddike, I've added a quick setup function for changing some values.
Heres what the default values look like:
require("duck").setup {
    character = "🦆",
    winblend = 100,   -- 0 to 100
    speed = 1,      -- optimal: 1 to 99
    width = 2
}

So in ur case, u could try changing winblend. Another way is to set highlight for the Duck group manually like:
vim.cmd("highlight Duck guibg=your_normal_bg")

Will add the docs later and lemme know if it works when u have time 😬

thanks a lot :grinning:

Just tried it out, the winblend works, tyvm!


Recreate the catalogue pipeline with new queues/services

An attempt to get better namespacing working.
🤷♀

Closed in favour of #2661.


Updated some markdown to fix an error with Python3 and Pygments

Fixed an error using Python 3.
Python 3 with Pygments does not work (only 2.7 works with Pygments)

Thank U @t4r4ll0

@nandomoreirame is a small patch that avoid errors running the project (I've tried it locally).