Check and update packages in the package.json file

npm warn deprecated<EMAIL_ADDRESS>Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.

This warning can be ignored, regedit-simple is a simple node module to handle the interaction with the Windows registry system, it doesn't need a regular update as it depends on the genuine reg.exe Windows binary:
https://github.com/utyfua/regedit-simple/blob/master/index.js#L4
npm warn deprecated<EMAIL_ADDRESS>This functionality has been moved to @npmcli/fs
npm warn deprecated<EMAIL_ADDRESS>Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm warn deprecated<EMAIL_ADDRESS>This package is no longer supported.
npm warn deprecated<EMAIL_ADDRESS>This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated<EMAIL_ADDRESS>Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm warn deprecated<EMAIL_ADDRESS>This functionality has been moved to @npmcli/fs
npm warn deprecated<EMAIL_ADDRESS>This package is no longer supported.
npm warn deprecated<EMAIL_ADDRESS>This package is no longer supported. Please use @npmcli/package-json instead.
npm warn deprecated<EMAIL_ADDRESS>Rimraf versions prior to v4 are no longer supported
npm warn deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm warn deprecated<EMAIL_ADDRESS>Glob versions prior to v9 are no longer supported
npm warn deprecated<EMAIL_ADDRESS>This package is no longer supported.
npm warn deprecated<EMAIL_ADDRESS>This package is no longer supported.
npm warn deprecated<EMAIL_ADDRESS>This package is no longer supported.

All those warnings are related to modules that depend on them; the app doesn't depend on those modules that are getting warnings about directly. Authors would consider to update the dependencies of their projects.
npm warn deprecated<EMAIL_ADDRESS>This package is now deprecated. Move to @xterm/addon-fit instead.
npm warn deprecated<EMAIL_ADDRESS>This package is now deprecated. Move to @xterm/addon-canvas instead.
npm warn deprecated<EMAIL_ADDRESS>Please use @electron/rebuild moving forward.  There is no API change, just a package name change
npm warn deprecated<EMAIL_ADDRESS>This package is now deprecated. Move to @xterm/xterm instead.

All those modules/packages have been updated, and changes in the codebase have been implemented.


Modifying sensitivity of seekbar, specially useful when the seekbar is inside a RecyclerView

Hi, I found useful this behaviour in order to improve the user experience when you have a seekbar in every item of a RecyclerView. Sometimes if you fail scrolling you can change the progress of a seekbar accidentally.
Changes in my branch:

Modifying sensitivity of seekbar, specially useful when the seekbar is inside a RecyclerView.
Added two new parameters longClick, longClickTime expressed in ms and modified onTouchEvent in IndicatorSeekBar.
Also created an example of the use in sample app

If you find useful this you could add it to the project!
Thanks in advance.

@anjovazquez Really thanks for you pull request, I will test this and combine in next version  as soon as I have time.

Hi @warkiz
Great news! Whatever I can do in order to improve just tell me!
Thanks

@anjovazquez Have you tried setting isb_only_thumb_draggable="true"? This works well for me in RecyclerView.


Issues with shadowed parameter names

These two issues both show up when parameter names are reused in declarations. The universe polymorphism in the first example seems to be necessary to make #check produce an error.
To me, the optimal solution would be to forbid shadowing parameter names completely, and throw an error at the declaration of blah.
section
def {u} typer (α : Type u) := α
parameter n : ℕ

meta def blah (n : typer ℕ) : ℕ := n

#check blah
/-
type mismatch at application
  blah
term
  n
has type
  typer nat
but is expected to have type
  typer.{0} nat
-/

end

section

parameter n : false
def blah (n : false) : false := n
#check @blah -- blah : false

end

#check @blah -- blah : false

theorem fs : false := blah -- failed to add declaration to environment, it contains local constants

#print blah -- error: invalid #print command (reported at a line below)

Note: lean-server was crashing intermittently as I put together these examples (Emacs 25.1.1 on Windows). I can't pinpoint what changes were triggering the crash, though.

Closed by https://github.com/leanprover/lean/commit/748eb856c3e44924c6b707494293e0a764937086


Non-superuser cannot edit/delete inventory items under device

Issue type: bug
Python version: 2.7.12
NetBox version: 2.0.4
If a normal user tried to edit or delete an inventory item within a device, they are not provided with the edit or delete buttons. Access has been grated through the admin permissions group for the user to add/edit/delete however they are only allowed to add. If you have admin permissions you are able to make all the relevant changes. This bug was also reported and resolved previously for managing IP's linked to interfaces.

Typo in the permission name in the template

Thanks!


fix: wms monitor arg ints

Description
Fixing an issue I was experiencing when passing in wms-monitor-arg values, it was casting everything to integers, and I want to be able to pass in other things like Strings. So just removing usage of the parse_resources() in the WMS logger.
QC

[X] The PR contains a test case for the changes or the changes are already covered by an existing test case.
[X] The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

Thanks a lot @Tobias-Ternent . I just tested the changes and it works fine for me.
@vsoch I think it would be great to have your input and make sure that we no breaking changes are introduced for snakeface.

@johanneskoester It would be great if you can include this fix for the next release.


Limit number of organizations on collective page

From @hzoo:

is there a way for us to hide backers that have given a minimum amount from the main OC page for the project? Not sure if I'd want an org to be on there just because they gave $2? even an individual contributor could of given more in my mind

To mitigate that I suggest we limit to 30 instead of 100 the number of organizations to show on the collective page. Then we should just show the "load more" button.

Actually, it should be a multiple of 4, so the top 20?
This will also speed up loading time of the page since there is less images to load.

I agree this is a way to solve this immediate problem, but there's a larger conversation here. Why should a company that gives $2 have more real estate than a person who gives $1000? Even with the load more, companies are far more visible than individual backers.

Showing the top 20 sets the bar at $1,250 to show up on the Babel page.
Whereas we show the top 100 backers on the page.

I mean that the companies are easier to see, the backers are small and hard to see who's giving how much.


Replace custom release scripts with a script using xyz

XYZ by David Chambers has some nice utility, like automatically tagging, atomic push, and other safety checks.
New commands for creating releases would be:

npm run release major
npm run release minor
npm run release patch

Would you mind doing a quick npm run release minor (in a clean working directory), to get futurizeV out the door? :)
I don't think I would have permission to publish to NPM.

@Avaq You should have access. Could you try if that's true?

I published it! so no need for you to try, but you should be able to next time.

Alright, thanks! :+1: :D


WOR-1088 Refactor Landing zone service after migrating to Stairway-based LZ flights

This PR:

Removes unused code related to LZ deployment
Update some tests
Update readme

@sergiygetlin I am done reviewing. This is a great cleanup and will really help us going forward-- thank you!!


Can not find command run_preCluster.py

Hello Magdoll:
I am trying to use Cogent to do family finding for large datasets and found there is no run_preCluster.py on directory (anaconda2/bin/ or anaconda2/envs/anaCogent/bin/).
run_preCluster.py: command not found
I have installed all the necessary components of Cogent (minimap2 version 2.12, Cogent version 3.3). The test scripts and family finding for small dataset runs smoothly.
These are scripts found on Cogent/Cogent/:

all_simple_paths.py                              GFF.py                    process_kmer_to_graph.pyc  sanity_checks.pyc  splice_graph.pyc
all_simple_paths.pyc                             helper_scripts            process_path.py            settings.py        test
BioReaders.py init.py               process_path.pyc           settings.pyc       Utils.py
BioReaders.pyc                                   init.pyc              reconstruct_contig.py      splice_align.py    Utils.pyc
draw_kmer_graphs.py                              MinimapIO.py              reconstruct_contig.pyc     splice_align.pyc
generate_batch_cmd_for_Cogent_family_finding.py  process_kmer.py           run_mash.py                splice_cycle.py
generate_batch_cmd_for_Cogent_reconstruction.py  process_kmer.pyc          run_mash.pyc               splice_cycle.pyc
gff3_to_collapsed.py                             process_kmer_to_graph.py  sanity_checks.py           splice_graph.py

hi @huajiachicat ,
run_preCluster.py is an additional script from cDNA_Cupcake. Please install Cupcake accordingly.
-Liz


Texture issue

Texture breaks when using the fix tool.
This is an FBX model. (not sure how to post the image so it shows.)
https://i.imgur.com/nWMCpSP.png
after hitting fix.
https://i.imgur.com/YAsBfze.png

the uvmapping should still be fine, it just made it transparent for some reason. Try importing it into Unity and see if it's still OK?

When I import into unity it only shows the jacket and shirt texture.  Which is an odd thing to have happen.

I had another avatar I did the same process with a few weeks back and it worked out just fine. So it is rather odd this one is causing so much issue.

This is fixed in newer cats versions


bump proxmox to 2.2.1 at stable (#2841)

cloned from #2841

2.2.1 created 28.10.2023
218 user (5%)


Documentation about C++ function AddMetadata() is unclear with respect to format

Hi, The AddMetadata() Documentation specifies a format to use.
However it is not clear how to read the format specification:

Metadata must conform to the following format: Custom-Metadata -> Binary-Header / ASCII-Header Binary-Header -> {Header-Name "-bin" } {binary value} ASCII-Header -> Header-Name ASCII-Value Header-Name -> 1*( x30-39 / x61-7A / "_" / "-" / ".") ; 0-9 a-z _ - . ASCII-Value -> 1*( x20-x7E ) ; space and printable ASCII

Could you update the documentation to be more specific and/or use some standard CFG/Regex language to describe the desired grammar?
It is also not clear if the format requirements are for metadata_key or for metadata_value content.

Thanks for pointing this out, part of the issue is that Doxygen stripped newlines from the method's comments. In the code comment itself, the formatting is the same ABNF used in RFCs (replacing = with ->. See rfc5234). We could make the docs more readable by updating the comments to wrap the format definition in \code{.unparsed} ... \endcode or \verbatim ... \endverbatim tags. I'd gladly accept a pull request for that if you'd like to fix it.
I believe metadata_key needs to conform to the Header-Name format (0-9a-z_-.)


Removed beta flag from release version

The lock file needs updating too doesn't it?

Absolutely right. Will do.

:+1:

:+1:

:+1:

Thank you @maschmann.


[ts-sdk] Transaction Builder improvements

Some areas of opportunity for improving the TypeScript transaction builder:

[ ] Currently, we assign input and command indexes when values are added to the transaction. We could instead use references and lazily assign indexes at serialization. This would allow easy dynamic re-ordering, which can be useful in cases where we want to potentially automatically prepend coin management logic to transactions. Alternatively, we could just add some addBack method that handles re-ordering of result indexes in other commands automatically.
[ ] Return types from commands should be configurable, so that we can tell users when they're using the API correctly.
[x] Add objectRef and sharedObjectRef shorthand and encourage folks to use it for more offline processing.
[ ] Add well-known object IDs, to fast path serializing objects like the system object.
[ ] Allow for commands to be used directly as command arguments, and automatically insert them into the transaction. This will allow for one .add() call that also includes things like a coin split command.

@Jordan-Mysten I assume that this is outdated, so let me know if we can close it. Thanks!


Ghost entry in favorites

OS: Arch Linux
Kernel: Linux 6.10.10-arch1-1
WM: hyprland 0.43.0-1
Package ver.: nwg-menu 0.1.4-1
If a launcher for a package was pinned to favorites, but that package was uninstalled before unpinning from favorites, then a ghost entry for that package will remain pinned as a blank space. Unpinning via right-click will only remove it temporarily; if the launcher is invoked again, then the ghost entry will come back.
Steps to reproduce:

Install any package that includes a .desktop entry
Open nwg-menu, pin the package to favorites, then close nwg-menu
Uninstall said package
Open nwg-menu again; the ghost entry should appear

To get rid of the ghost entry, re-install the package, unpin it from nwg-menu, then uninstall again.

It doesn't behave like this on my side. Tried with emacs. If I pin emacs and then uninstall it, the pinned item no longer appears, until I install emacs back.

https://github.com/user-attachments/assets/6b64b4eb-846e-4617-bebd-3e0906d9d385

Sorry, I should've been clearer. By ghost entry I meant a blank space where the previously pinned entry would've been.

OK, got it. I'll add a check if the DesktopID actually exists.

I've also added some lines to check and remove non-existent items while saving pinned cache.


feat!: use RBAC for connecting to Storage

Use role-based access control for connecting to Storage account.
Requires Owner role at the Storage account scope.
BREAKING CHANGE: Remove variables storage_account_access_key and identity. Add variables storage_account_id and identity_ids.
Fixes #96

Tests pass 🎉

Tests pass 🎉


Add a hawkular client command line tool

Description
Add a ops-hawk-client cli for sending metrics to a hawkular server using a bash script
or from the command line.
Depends on https://github.com/openshift/openshift-tools/pull/1178
Default in hawk_client.yaml.example is incative=True
Examples
# Send a heartbeat (looks in a config file for specifics)
ops-hawk-client --send-heartbeat

# Send a single metric (generic interface, send any adhoc metrics)
ops-hawk-client -s hostname.example.com -k zbx.item.name -o someval

@alongoldboim @simon3z @twiest please review

This PR is deprecated by #1180 , now the ops-zagg-client cli will send data to hawkular.
Closing, because the ops-hawk-client is not needed any more.


RuntimeError: selected index k out of range

Hi, when I run the code, I have this error, maybe it's a naive question but I can't solve it right now.
I have data with batch_size=8, each batch has 3 points, and each point has dimension of 5, so the code is below. I want to seperate 3 points into two clusters, one contains 1 point and the other contains 2 points.
>>> model = ConstrainedKMeans()
>>> a = torch.rand(8, 3, 5)
>>> w = torch.ones(a.shape[:-1])
>>> w /= 2
>>> b = model(a, k=2, weights=w)

but I got this error

Is there any ways to solve it? thanks :)

Thank you for using torch_kmeans and posting this issue.
For this  very small example the error is caused by n_trials being larger than the total number N of points in the instance, in your case 3. The default value for trials is 5, which is reasonably small for usual instances (which normally consist of hundreds or thousands of points) but causes the index out of range here.
A quick fix will be to set the number of trials to 1 by specifying:
model = ConstrainedKMeans(n_priority_trials_before_fall_back=1)
However, I will ASAP push a fix to adapt the number of trials in case of very small instances automatically.

Thanks for the reply! it works now.
btw is there any way to disable the printing of Full batch converged at iteration /100 with center shifts:?  because I need to do clustering many times and there will be a lot of print like this.

Yes, simply set verbose=False in the constructor:
model = ConstrainedKMeans(verbose=False)
I will close this issue now, if there are any other problems feel free to (re-)open.


network is the test network. Why is the query still about the main network

client = Tron(HTTPProvider(api_key=“"), network="nile")

I found out why. The apikey is mainnet


Keyword enforcer duplicated in two places

Making a note of this so I don't forget.
Both MAPL_Shared and GMAO_pFIO have an identical keyword enforcer.
GMAO_pFIO has a file KeywordEnforcer.F90 with a module pFIO_KeywordEnforcerMod
MAPL_Shared has a file MAPL_KeywordEnforcer.F90 with module MAPL_KeywordEnforcerMod
Other than the names the code is identical.
This should be consolidated under shared.
If we are following the MAPL conventions document the file should be
KeywordEnforcer.F90
the module should be MAPL_KeywordEnforcer

Yes - this was one of the files that was supposed to be refactored into the new shared subdirectory.

@tclune says this is trivial. I'll assign to him.

Reexamined on 2021-Apr-12 with @bena-nasa and @tclune


Entity Templates

Background
Would be pretty neat if we could clone entities and its components based on a template which defines its values.
Basically a way to create entities with set values. Has many advantages, can be serialized easily and is more effective in many ways.
Idea
Either:
var template = new Template(
   new Position(10,10),
   new Mesh(5, Mode.Batched),
   ...
);

var clone = world.Create(template);

Or using source generation:
[Template]
public struct PlayerTemplate{

   public Transform Transform;
   public Velocity Velocity;
   public Model Modell;
   public ...
   ....
}

var template = new PlayerTemplate(whateverData);
var clone = world.Create(template);

When we choose source generators we could even build more cool constructs around this. Like an extremely efficient identifier mechanic to clone certain templates:
[TemplateStorage]
public struct Templates{

   [Identifier("1:1")]  // Or raw ints e.g. for networking?
   public PlayerTemplate playerTemplate;

   [Identifier("1:2")]
   public MobTemplate mobTemplate;

   [Identifier("2:1")]
   public FireGolemTemplate fireGolemTemplate;
}

var cloneByIdentifier = world.Create("1:1");
var fireGolem = world.Create("2:1");

Is this feature available ?

Is this feature available ?

Not yet, but its still on the roadmap :)
Will probably be part of Arch.Extended with its own source-generator and persistence integration ^^
However that could still take a while (need to do query caching first), so if anyone wanna contribute... feel free to :p

Svelto Ecs has interesting implementation, called Entity Descriptor's. Very robust and boilerplate (like many features in Svelto).

Here's the snippet of sample code without abstraction layer.
I don't really like how dependencies are injected (maybe there shouldn't be dependencies at all)
public class PlayerTemplate
    {
        private readonly CommandBuffer _buffer;
        private readonly PlayerConfig _config;

        private readonly int _gravityId;
        private readonly int _moveId;
        private readonly int _groundDetectionID;
        private readonly int _playerCameraID;

        public PlayerTemplate(World world, PlayerConfig config, int gravityId, int moveId, int groundDetectionID, int playerCameraID)
        {
            _buffer = new CommandBuffer(world);
            _config = config;
            _gravityId = gravityId;
            _moveId = moveId;
            _groundDetectionID = groundDetectionID;
            _playerCameraID = playerCameraID;
        }

        private ComponentType[] Archetype { get; } =
        {
            typeof(MoveInput),
            typeof(JumpInput),
            typeof(LookDeltaInput),

            typeof(DataReference<GravityData>),
            typeof(DataReference<ControllerMovementData>),
            typeof(DataReference<PlayerCameraData>),
            typeof(DataReference<GroundDetectionData>),

            typeof(ComponentReference<PlayerTag, Transform>),
            typeof(ComponentReference<PlayerCameraTag, Transform>),

            typeof(SensorComponent<GroundTag>),

            typeof(MoveDirection),

            typeof(PlayerRotation),
            typeof(Velocity),

            typeof(CharacterController),
        };

        public Entity Init()
        {
            Entity entity = _buffer.Create(Archetype);

            _buffer.Set(entity, new DataReference<GravityData>
            {
                Reference = _gravityId
            });
            _buffer.Set(entity, new DataReference<ControllerMovementData>
            {
                Reference = _moveId
            });
            _buffer.Set(entity, new DataReference<GroundDetectionData>
            {
                Reference = _groundDetectionID
            });
            _buffer.Set(entity, new DataReference<PlayerCameraData>
            {
                Reference = _playerCameraID
            });

            _buffer.Set(entity, _config.Prefab.GetComponent<CharacterController>());
            _buffer.Set(entity, new ComponentReference<PlayerTag, Transform>
            {
                Value = _config.Prefab.transform
            });
            _buffer.Set(entity, new ComponentReference<PlayerCameraTag, Transform>
            {
                Value = _config.PlayerCameraConfig.Camera.transform
            });

            _buffer.Set(entity, new SensorComponent<GroundTag>
            {
                Direction = _config.GroundDetectionData.Direction,
                MaxDistance = _config.GroundDetectionData.MaxDistance,
                HalfSize = _config.GroundDetectionData.HalfSize,
                Offset = _config.GroundDetectionData.Offset,
            });

            _buffer.Playback();
            return entity;
        }
    }

Svelto Ecs has interesting implementation, called Entity Descriptor's. Very robust and boilerplate (like many features in Svelto).

It could look similar for Arch. But with less boilerplate code of course ^^

What If we extract Creation logic from World and move it into some sort of EntityFactory?
Let World be management class still, but instead of Create it would have Add method?
This would allow user use 1 entity factory to create different entities and put them in any world they need.
With that, world would have only concern to manage already added entities, give queries based on the already added entities, etc.


Add the ability to compile unsafe code .

Use the /unsafe compiler option to compile unsafe code.

@KrzysztofCwalina, please review.

LGTM

looks good.


feat(quay): Refractor code and add tests

Resolves #103
Changes:

Refactor the code that was mentioned in #101
Add tests for most of the functions outside of the react components
Part of adding tests was also adding fixtures so that the API can be tested using the msw package

A dev setup could also be created using the defined fixtures, let me know if that is something we want to do.

This PR looks good overall, just some minor changes and then it should be good to merge ok_hand

Thanks for the feedback!

I've updated the PR according to your suggestions, let me know what you think.

/LGTM

Fixed grammatical errors in docs.


Use rust-toolchain.toml instead

Note: rustup 1.24.0 (which adds support for this) was released on 2021-04-27, i.e. 29 days ago
Unfortunately, I don't think this will degrade gracefully for those using older rustups, but I expect that should be rare.
Note also that we started to depend on the toml format in #284, on 2020-12-07, around 10 days after rustup 1.23 (2020-11-27) released.

Not sure if we want to wait longer on this, there was a lot of pain due to outdated rustup on the original toml-ification, and we even had the graceful fallback of the error message telling you to update.

Note also that we started to depend on the toml format in #284, on 2020-12-07, around 10 days after rustup 1.23 (2020-11-27) released.

The reason the original change was merged only 10 days after release is because it contained critical behavior differences (inclusion of required components), whereas this change is much less urgent as it doesn't contain any new functionality.
Is it possible to include both rust-toolchain and rust-toolchain.toml files, and have the rust-toolchain file contain a comment that causes a syntax error that tells you to update rustup? That would solve my concerns.

Unfortunately, rustup prioritises rust-toolchain over rust-toolchain.toml - that is, we could do that, but the result would be that rustup only uses the rust-toolchain file.
It would appear that this is not going to be workable at the moment.


Tag TSM stats with database and retention policy

(This probably should have been part of #5810. Hindsight is 20/20.)
The primary intent of this changeset is to tag stats for TSM cache, WAL, and filestore with the owner database and retention policy.
This change was implemented by passing a ShardConfig, rather than path and/or walPath strings, to:

tsdb.NewEngine
tsm1.NewCache
tsm1.NewWAL
tsm1.NewFileStore

At this point ShardConfig may or may not be a misnomer, so I'm open to any other suggestions on what to name that type.

I missed the part where the database and retention policy from the shard config were being used since I only saw how the tests were modified.
I retract my previous comments.
:+1:

After some out-of-band discussion, I'm going to amend the commit to continue passing path as before, but to introduce a function like DecodePath to identify the database and retention policy.

Rebased to address comments and now ready for re-review @jsternberg @jwilder.

:+1:

Needs a changelog entry, but :+1: after that.

I'll remove the read lock from DiskSize as @e-dard suggested, update the changelog, and merge on gren.


[suggestion] use defaults for unspecified config params

Feature request
If unspecified in the config.json, iroha should use the default value for the configuration parameter. config.json should export all current parameter values as it currently does, but they should be commented out
Motivation
we're shooting ourselves in the foot with this. Currently, if we change any parameter in the config the new version is guaranteed not to work for users downstream.
Who can help?
No response

we have to make a change in kagami so that it produces config with most of the fields commented out


Stream performance

This doesn't yet change any behavior of pyacq, but implements some benchmarks that should start us on the path to maximizing stream performance.

Added data_transfer_sandbox, which is a zmq-only demonstration of (I think) the best performance we can expect to see in streams. It minimizes copies and preserves array memory layout (turns out these are mutually dependent goals). This should obviate the need for autoswapaxes (if I understand it correctly).
Moved stream benchmarking to its own file and reworked it a bit such that performance is measured exactly as in the sandbox. Using tcp/plaindata stream gets me ~700MB/s, whereas I can get ~1.3GB/s in the equivalent sandbox test.

@samuelgarcia, I am thinking about giving Streams a little overhaul. Here are the things on my mind:

Implement data transfer for streams as described above
Get rid of timeaxis, autoswapaxes, and nb_channel options.
Allow inputstream to write data into a circular buffer without re-sending through sharedmem stream

This should simplify the nodes a lot. Can you think of any reasons these should not be done?

Hi luke, I also think about some refactoring about streams and Node instance/init/configure/start/stop/close scenario.
There is a need of simplifying but timeaxis is a need (in my mind at least). autoswapeaxis is a consequence. nb_channel was to simplify the things because it is redundant with shape[X] were X is not the stimeaxis. The ordering of bytes in memory is crucial. We need to cover all possibilities (channel then sample or reversed).
So:

+1
what do you have in mind.
I don't have it exactly understand. Would it be a 'localmem' than would behave exactly like 'sharedmem' but without memmap and without sending the position in the socket ?

I had in a first time somethinng else in mind split Ouput(Intput)Stream in two classes:
1- one used for connecting Nodes
2- one (several) for streaming data with multiple scenario (sharedmeme, paliondata in soscket, 'localmem', sharedmeme in GPU, ...)
Now all of theses all intermixed and this is bad. This over complicated Nodes conenction (and the order of connection).

There is a need of simplifying but timeaxis is a need (in my mind at least). autoswapeaxis is a consequence. nb_channel was to simplify the things because it is redundant with shape[X] were X is not the stimeaxis. The ordering of bytes in memory is crucial. We need to cover all possibilities (channel then sample or reversed).

Why is timeaxis needed? With the changes I proposed above, we can force timeaxis=0 and still preserve the memory order (and plus we get a performance boost for doing this).

Would it be a 'localmem' than would behave exactly like 'sharedmem' but without memmap and without sending the position in the socket ?

Yes, something like that. Possibly it could be integrated directly into InputStream so that any stream can have an internal ring buffer and use get_array_slice, regardless of the transfer mode (because right now, that effort is placed on the nodes instead).

I had in a first time somethinng else in mind split Ouput(Intput)Stream in two classes:
1- one used for connecting Nodes
2- one (several) for streaming data with multiple scenario (sharedmeme, paliondata in soscket, 'localmem', sharedmeme in GPU, ...)

Isn't that exactly how it is implemented now (InputStream/OutputStream are separated from the various Receiver classes) ?

It appear that your doing exactly what I was about to do : make a clear RingBuffer class.
Alway ahead luke!! Do you need help (except reviewing ) ?
I don't anderstand exactly how we will play with timeaxis (0 or 1) but the code is cristal clear. thanks.
Does this code depend on another branch ? there lots of RPC stuff in the commit list.

Some comment on the fly while reading:

what do you think of a separate file for ringbuffer class ?

Weird--the RPC changes have already been merged into master. I'm not sure why they are showing up here.

I rebased; that seems to have fixed it.

FYI, these changes are still in mid-overhaul. I am happy to hear your thoughts about the direction it is going, nevertheless..

what do you think of a separate file for ringbuffer class ?

Definitely, and more. I am planning to add pyacq/core/stream/ with several new files. (later, to prevent diff confusiuon)

core.tools.StreamConverter should loose the ability of transposing automatically swap axis by configuring different timaxis on ouputstream_spec

Yes.. I am still somewhat experimenting with this stream code. After that appears to be working, we can start thinking about how it affects the rest of the system. I hope the nodes will become much simpler.

I guess the goal is to remove timeaxis Given that timeaxis is always 0 now. Internally we have the 2 possibility of (sampleXchannel) and (channelXsample). So in that case we need also to give the strides in SharredArray.to_dict() and SharedMem.to_dict() and in there init() to reconstruct the array as they are. Am I missing something.

You are correct; SharedArray is still broken.

This will imply lots of changes in my viewers. Do you need help for that ?

Yes, but not yet. :)

SharedArraySender/SharedArrayReceiver will need a complete refactor based on RingBuffer do you need help ?

Let me get SharedMemSender/Receiver working first. I'm really not sure how everything should fit together yet.

Great. I wait. have you seen comments in the code ?

Update: I reverted back several commits to a simpler version of RingBuffer. From there it was almost trivial to set the memory order of the buffer.
I came across an issue with swapaxes: if you have a 3D stream (maybe a 2d electrode array or a video stream) and you want the channels to be contiguous in memory, then you would need swapaxes=0,2 to make the time axis last. But perhaps you want to keep the order of the (1,2) axes intact. In that case, you need to be able to specify the order of all three axes (1, 2, 0). So instead of swapaxes, I added an axisorder option. It works like:

For plaindata streams, data is sent in exactly its original memory order because this is the most efficient. If the receiver has a ring buffer attached, though, then the memory layout in the buffer will be determined by axisorder.
For sharedmem streams, the shared ring buffer uses axisorder for its memory layout.
Both stream types have the same API for accessing data chunks as they arrive, or via ring buffer.

Let me know what you think..

This is excactly what I wanted but I was to shy for asking.
Gogogo, you are the best.

You asked me for this about 6 times.  I just thought I could make it work without swapaxes until I finally understood the ringbuffer solution  :)

I was mentioning the axisorder . :)

I feel happy with that changes.
Could you also split in two files (stream and ring) as we discuss it previously ?
We are near something good no ?

Split classes into a new stream subpackage. Still have several of your comments to address, and nodes need to be adapted (want to help? See changes to qoscilloscope--mostly just deleted code and a few minor changes).
This is getting close!

Yes I want to help.
I can take care all viewer/dsp Nodes with this new design.
I will do PR directly on your place and so we will have one only PR for this new streamm design.
OK ?

Yeah, go ahead and start a sub-PR from this one. I won't rebase anymore.
Meanwhile, there are tests for me to fix..

I am super happy. This new design really smart. Thanks a lot.
I have only one small conern about file names:
pyacq/core/stream/sharedarray.py and pyacq/core/stream/sharedmem.py are similar names BUT are differents beast.
I propose :
git mv yacq/core/stream/sharedmem.py yacq/core/stream/sharedmemstream.py
git mv yacq/core/stream/plaindata.py yacq/core/stream/plaindatastream.py

I have a question for InputStream.set_buffer in case of SharedMemReceiver.set_buffer.
If I understand correctly, this create a new RingBuffer that is not the original sharedmemory so a new copy is done at each pacquet. No ?
Is it what we want. Won't it be safer to put set_buffer only for PlainDataReceiver.set_buffer ?

I am back.
In class SharedMemReceiver(DataReceiver):
This data = self.buffer[index+1-size:index+1] make me worry.
Why is that +1 for.
Are we agree that when receive index, index is not included this is the upper bound like any python spirit buffer manipulation.
In short, if index is 10, this means that I have 10 samples in the buffer and I when to slice buffer[0:10] so why this +1 for ?

I have a small problem with the new design.
I try to explain.
On a viewer I want the last 1000 samples but my index_head=100.
So I expect to have 900 samples filled with nan or 0 (depending filler=..) and 100 samples with the valid samples.
I can do self.input[-10000:] and this works. This is done in oscilloscope.
I would also like to write self.input[index_head-10000:index_head] because sometimes index_head=index_head%downsampling_factor.
This case do not work because index_head-10000 is negative.
This come from RingBuffer._interpret_index do you think we could fix that easily ?
Before this was handle by playing with the stop and not the start.
Something like (see SharedArrayReceiver.get_array_slice in master)
if double and stop>0:
    length=stop-start
    i2 = stop%self.shape[0] + self.shape[0]
    i1 = i2 - lenght
   buffer[i1:i2]

I have another problem with the new design.
In case of transfermode='sharedmem' if the receiver do a self.input.set_buffer(..) like in oscilloscope.
Then this add an extra complexity to ensure that there is extra work to recreate a each packet an array that already exists in the poller
See new changes in Oscilloscope.

I would also like to write self.input[index_head-10000:index_head] because sometimes index_head=index_head - index_head%downsampling_factor for alignement case when downsampling. This case do not work because index_head-10000 is negative.

I think we should keep the negative index behavior as it is, because this is consistent with how indexing usually works in arrays/lists. If you want to be able to request a truly negative index, then we should expose RingBuffer.get_data() instead.

In case of transfermode='sharedmem' if the receiver do a self.input.set_buffer(..) like in oscilloscope.
Then this add an extra complexity to ensure that there is extra work to recreate a each packet an array that already exists in the poller

I'm not sure I understand (because I thought I answered this already), but .. InputStream._own_buffer is a flag that prevents the stream from copying data into the buffer. So if we have a sharedmem receiver, and the receiver's buffer is sufficiently large, then the inputstream will just use that existing buffer and avoid making any unnecessary copies (at least, that is how it is supposed to work; perhaps there is a bug). Is this the issue you are worried about, or did I misunderstand?

The mecanism with InputStream._own_buffer is OK.
I try to explain better. I am confused too.
Have a look to my sub PR.
I try step what make me incofortable:
1 - I did not like the the core.tool.ThreadPollInput was always receving data even for shermem. Bad performences, a np.array is constructed at each packet.
2 - I forced SharedMemReceiver.recv(self, return_data=False) by default. This is more natural. We do not need to reconstruct the last chunk in that case event if it is a view this could lead overhead. We often need a larger buffer less but less otfen. I hope you will be ok with that.
3 - So I needed to introduce core.tools.ThreadPollInput.__init__(..., with_data=True/False, ...)
4 - So I needed to indroduced also with_data in PlainDataReceiver.recv(with_data=True). this could make sens in some case and we just need the index and not the data. This was mostly to have same API for the 2 streams class.
5 - I needed to take care of with_data=True/False in ThreadPollInput depending the case. If False this make that input.buffer is not filled in plaindata so we need True.  We could deal with directly in ThreadPollInput with
ThreadPollInput.__init__(.., with_data=None, ...)

It was not obvious last nigth.
I try it and get back.
At the end everything is OK.

I have finish the sub PR on your account
https://github.com/campagnola/pyacq/pull/4
There are still some monior problem arround InputStream.connect when checking if params correspond to spec. For shape this is bugguy for some pair of device<->viewer because the device have shape (1024, 2) and the viewer have (1, 2). This occours for audio_pyaudio, webcam_av and certrainly more. Have a look you will understand. I have no idea the best way to fix. ignore when -1 in shape. In that case shape would be a special case of readonly_params.
Otherwise, have a look in dsp/* and device/*. This is the main work from me here.
If you are happy you can merge into your big PR.
Them we should be OK for merging in the master.
And so come back on many other fronts.
Thanks a lot.

This PR is replace by PR #51.


Allow passing the path to the config file via the command line

Please allow passing the path to the config file via a flag on the command line.
I've sent the pull request #824

Hey, any thoughts on this? @kyleconroy

Hey, any thoughts on this? @kyleconroy


Non-existent method Page.get_title_object

If you specify a language to ExtensionToolbar.get_title_extension_admin, it calls Page.get_title_object, which doesn’t exist.  This should probably be Page.get_title_obj instead.

@yakky, it appears a fix has already been merged. Can/should we close this issue, or are we keeping it open so we can ensure the same fix is in develop?

Uhm, autoclosing seem not consistent ...
Closing this. Merge back from support to develop it's still possible, I'd prefer going along this way


x/build: gccgo builder for testing $GOROOT/test directory

The $GOROOT/test directory contains test files that are also tested by gccgo, but that we don't regularly test against gccgo.  E.g., these CLs span about 3 weeks from late Nov 2020 to mid Dec 2020: b94346e69bb01e1cd522ddfa9d09f41d9d4d3e98, d6abf298cf1ef56dc8cbec2ee9a18c071bb6eb3c, a45e12fd4bd2cc4d5970f374499b603bfb793891, 848dff6dda4d38d3d2e9ab128954f50d085d9313, 73e796cb007989449da95fb4adf936ee76b766ca, 58768ae15b3f892b9b1902220ba3564375e5c6de,  bacb307b80747deaf6a017f5b3cee4e3cb115f61, 6d2b3351f6312ebc924d0014013088c69b9c1bc2, ce61ccca8f9e101b13b61907024ee48afadca403, be10af7c4e818566f0b19fb9ffefce2853722842, 5a25a3fd1d8248c039e34f5ae02cc9c8198fc6d6, 685a322fe404d725e6bfb2766388c4b95ed84603, 731bb540381e1b79c85b0bdcb95af90f6bde7b89,

When updating existing tests, folks are scared to ever remove pattern alternatives from existing regexps for fear of breaking gccgo. For example, test/fixedbugs/issue11326.go has tests with 5 alternatives, even though we've only ever supported 3 type checkers (gc, gccgo, and go/types):
https://github.com/golang/go/blob/1ed0d129e9ba9b55e9ae36ac1d7f2766ba16b373/test/fixedbugs/issue11326.go#L21-L25
Additionally, the 5th alternative "overflows" is a substring of alternatives 1 and 4, so they needn't be included anymore.

I think both of these issues would be helped if we had a builder (and slowbot) that ran the $GOROOT/test tests in gccgo mode.
/cc @ianlancetaylor @golang/release

I would support this but I'll note that many tests still do not pass with gccgo.  I ran out of my self-determined time to work on updating the testsuite.

@ianlancetaylor Ack, I noticed that while re-triaging the types2 expected-failures list last night. (E.g., several of fixedbugs/issue7525*.go still ICE with gccgo.)
I'd be supportive of extending the types2 expected-failures mechanism to allow gccgo expected-failures and just checking in what we currently have as a baseline. That way we at least halt further backsliding.


Add fuzz inputs

Merged with: test/fuzz/test_runner.py -l DEBUG --m_dir ./target_new_seeds ./qa-assets/fuzz_seed_corpus
Also bump valgrind CI check to prevent possible timeout

This still contains script_assets_test_minimizer, which has been removed in https://github.com/bitcoin/bitcoin/commit/b69eab9025678654acd0dda1861152c239f07699

Removed in https://github.com/bitcoin-core/qa-assets/commit/eaa13044b29822356634d8f2c4e38b0aebdf67f4


Remove <> from surroundingPairs for JavaScript files.

In #136127 I requested <> to be added to surroundingPairs for JavaScript files. But I'll be honest, since then I've only used the functionality exactly once, and that is in a project with a lot of TypeScript in JSDoc comments.
I do frequently run into case where I want to replace > with < though, causing it to wrap two arrows around it :<>>
https://user-images.githubusercontent.com/2737650/164004255-6109b8bd-9947-406e-a1cf-6e493129e87f.mp4
Ideally VSCode would detect this, and only add surrounding pairs when the selection is not just a single character of the surrounding pair itself.
But to be honest, just removing the surrounding pairs from vscode/extensions/javascript/javascript-language-configuration.json would work as well:
https://github.com/microsoft/vscode/blob/ffd414feeb1727bdd0ab770da0cfec6187fe5934/extensions/javascript/javascript-language-configuration.json#L28-L28
Not sure how anyone else feels about this.

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Blog post on system strings

Fixes #2636

coverage: 94.298%. remained the same when pulling b8ef50b1fa26fe9cdb65c9b806eeb24b5d4a5cbc on rahul-blog-system-strings into db77e5f422c6b45fdb38919f15ff8b17e1063b4f on main.


URI handling no longer supports project specific pathing.

Prerequisites

[ X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
URI handling used to support opening files via a project specific path. IE the path given to a file by right clicking and selecting "copy project path".
I am unsure of which specific version of Atom this behavior stopped working, but it was recent.
Steps to Reproduce
Example (in an external webpage):
Relative path - does not work. (used to work)
 link
Absolute path - does work.
 link
Expected behavior:
Relative paths to open files as they used too in previous versions
Actual behavior:
Atom is focused, but no file opens
Reproduces how often:
100%
Versions
1.39.1
Additional Information
This breaks various chrome plugins that use the source maps to open the original file.

Thanks for the report -

I am unsure of which specific version of Atom this behavior stopped working, but it was recent.

How recently did this work?  That might helping testing particular versions to see where this worked and stopped working
And just to clarify your repro steps, you need to have a project open that has a templates/styles.css file off of the root of the project before clicking the example link?

I'd say the last couple of months. I can spend some time trying older versions of Atom if it is helpful. Prior to that it has been functioning since at least Nov 20, 2018 - which is when I wrote the extension that was using this call.
Yes - to clarify the repro steps the project is open, and contains a file by the path specified.

I have not done an exhaustive test but I can confirm that Atom 1.36.0 will open relative paths as expected so it was broken by a release after that.

Thanks for checking, I was poking around too and it looks like 1.36.1 might be where the problem started.  I started Atom in the foreground with atom --foreground and when trying to reproduce, I see this in the terminal after clicking one of those open links:
2019-07-31 20:46:17.836 Atom[70418:2607446] stat.isFile is not a function
2019-07-31 20:46:17.837 Atom[70418:2607446] TypeError: stat.isFile is not a function
    at win (/Applications/Atom.app/Contents/Resources/app.asar/src/core-uri-handlers.js:27:18)
    at bestWindow.getLastFocusedWindow.win (/Applications/Atom.app/Contents/Resources/app.asar/src/main-process/atom-application.js:1234:76)
    at Array.find (native)
    at WindowStack.getLastFocusedWindow (/Applications/Atom.app/Contents/Resources/app.asar/src/main-process/atom-application.js:1666:25)
    at AtomApplication.getLastFocusedWindow (/Applications/Atom.app/Contents/Resources/app.asar/src/main-process/atom-application.js:416:29)
    at AtomApplication.openPackageUriHandler (/Applications/Atom.app/Contents/Resources/app.asar/src/main-process/atom-application.js:1234:25)
    at AtomApplication.openUrl (/Applications/Atom.app/Contents/Resources/app.asar/src/main-process/atom-application.js:1225:19)
    at App.disposable.add.ipcHelpers.on (/Applications/Atom.app/Contents/Resources/app.asar/src/main-process/atom-application.js:612:12)
    at emitTwo (events.js:126:13)
    at App.emit (events.js:214:7)

To confirm, I git-blamed that first line mentioned in the stack trace back to https://github.com/atom/atom/pull/19169 which looks like it landed in 1.36.1 I think.

Is there a chance this might get resolved in the near-term, or should I rewrite my packages to expect absolute paths (seems like the wrong thing to do).

I don't believe this would get resolved in the near-term unfortunately - if someone in the community opened a well-written pull request to address the problem that would be helpful, though we couldn't promise a specific timeframe for when it would get reviewed in that case.


Can't set labels for scanvi

scanvae = scvi.model.SCANVI.from_scvi_model(
    vae,
    adata=source_adata,
    labels_key=cell_type_key,
    unlabeled_category="Unknown"
)

This initialization always gives empty labelled indices because here
https://github.com/scverse/scvi-tools/blob/7ba36b13e940fbb89e2f1c5fde4ffe3c461cb5b5/scvi/model/_scanvi.py#L255
labels != self.unlabeled_category_ always evaluates to just scalar value True (not an array) and therefore self._labeled_indices is always [].
This happens because labels is integer and self.unlabeled_category_ is a string

Thank you for finding this! We have a PR out for this bug now. It will be included in a patch release that should come out soon.


Using UMD to create Singleton Instance across Micro Frontends

Hi,
I have a use case where I want to shared Singleton instance across Microfrontend with following condition:

First Micro frontend created in Vanilla JS
Other Micro frontend created in React JS
which ever load first initializes the instance of my JS script and other while loading just uses it.

I was looking forward to use UMD but couldn't work it out without attaching initialised instance to window object. But I don't want to expose it at global variable level.

As per my under standing of your query ill assume the following things
1.You created a module based on UMD namely myMicroFrontend that is used by another vannila js script
2.You created a component on React JS that requires your myMicroFrontend
you need a hack to achieve the singleton instance across the code without a global declaration
you can try custom events to load your micro frontend 😁 but without global variable how you store if your microfrontend has loaded ? how you know it its not loaded because javascript is not syncronous by default


Remove stray byte order marks from C source files.

I was getting this on OpenBSD with GCC 4.2.1:
Building debug object Debug/assets/assetManager.cc.o
gcc -c -I/usr/local/include -I../../source -ggdb -DTORQUE_DEBUG -DTORQUE_DEBUG_GUARD -DTORQUE_NET_STATS ../../source/assets/assetManager.cc -o Debug/assets/assetManager.cc.o
In file included from ../../source/assets/assetManager.cc:58:
../../source/assets/assetManager_ScriptBinding.h:1: error: stray '\357' in program
../../source/assets/assetManager_ScriptBinding.h:1: error: stray '\273' in program
../../source/assets/assetManager_ScriptBinding.h:1: error: stray '\277' in program
Torque2D:464: recipe for target 'Debug/assets/assetManager.cc.o' failed
gmake: *** [Debug/assets/assetManager.cc.o] Error 1

Hi Bentley!  Thanks for all the pull requests.  I'm sure you're fellow OpenBSD users will appreciate it.  Unfortunately you made all your pull requests into the Master branch and we only merge into the Development branch.  If you could, please close these and remake them for the Development branch.  We plan on moving everything up to the Master branch soon.  Thanks!

Unfortunately it appears Visual Studio adds Byte Order Marks (BOM) automatically unless explicitly told not to.  Inevitably these will eventually slip back in even if we merge in your request so we've decided to close this instead of merge it.


Show the download progress for velad, because it is too big

The download process is taking too long, we best print the progress like the wget stdout.

    echo "Downloading $DOWNLOAD_URL ..."
    if [ "$VELAD_HTTP_REQUEST_CLI" == "curl" ]; then
        curl -SL "$DOWNLOAD_URL" -o "$ARTIFACT_TMP_FILE"
    else
        wget -O "$ARTIFACT_TMP_FILE" "$DOWNLOAD_URL"
    fi

Just change this part of the scirpt

Solved here: #36


how to install gogs as windows service?

One option is to integrate gogs into github.com/kardianos/service .

See https://gogs.io/docs/installation/install_gogs_on_windows

@kardianos thank your info!

@Unknwon
If gogs add the following import to one of the files
import _ "github.com/kardianos/minwinsvc"

It won't affect non-windows at all, but on windows allow installing directly as a windows service.

@kardianos sure!
Can you explain or give some references about how does this package actually work?

Windows requires services to maintain callbacks and respond to query messages and stop messages. The package minwinsvc works by:

only doing anything at compile time on windows
detecting if the program is running as a service, if not, it does nothing
if running as a service it starts a go routine to setup, monitor, and service the windows required callbacks.
when the stop message is called, it calls os.Exit(0)

Under the covers on windows it uses golang.org/x/sys/windows/svc which works on go1.3+.
You would still need a wiki for installing, but you could install directly as a windows service. If you use a windows command like "sc" to install, you would need to make sure the binPath included the "web" and --config arguments as the working dir on windows is always set to "C:\windows\system32".

@kardianos sounds great!
Would you mind to PR a section to https://github.com/gogits/docs/blob/master/en-US/installation/install_gogs_on_windows.md for

You would still need a wiki for installing, but you could install directly as a windows service. If you use a windows command like "sc" to install, you would need to make sure the binPath included the "web" and --config arguments as the working dir on windows is always set to "C:\windows\system32".

Will do.

Thanks!

There are minimal changes needed to natively support windows services. To log to the windows event log, or enable a command like gogs.exe web -service install you would probably want to make slighly more invasive changes by using something like `github.com/kardianos/service (though not by much). But not sure if that is worth it.

Hi, thank you so much for this project.
as of 0.9.13, when installing as a builtin windows service with gogs-ssh builtin option, the directories ssh and sessions are created under c:\windows\system32\data, regardles of --config argument of gogs.
To have everything under c:\GOGS-INSTALL-DIR\data, we created a link like this:
mklink /d c:\windows\system32\data c:\GOGS-INSTALL-DIR\data
Thanks


Cannot remove GitHub account

I have tried a fine-grained access token and now I cannot remove this account. Selecting the account, then clicking remove does not remove the account.
This is mandatory as new tokens, fine-grained or personal access tokens, must have an expire date.

Can you provide more information about this? I cannot reproduce it

I have a Stream Deck MK.2 connected to a Macbook Pro with M1 chip, installed the stream deck software, added your plugin and added my GitHub account but when I click to remove the account nothing happens.

I have the same issue. I have a MBP with M1.

If it helps to get to the bottom of this, if I add the Github account again it shows alongside the original. However, I can remove one of them. But not the other one - my assumption here is that it doesn't allow the final account to be removed, whatever it may be.


Access log log_format.text_format field is not printing logs

I am trying to enable v3 access logs for my application, where I am using text_format option. Logs are not getting printed if I use text_format, however if I use json_format, i can see the logs. Below is the snippet I used for enabling access logs -
filters:
            - name: envoy.filters.network.http_connection_manager
              typed_config:
                '@type': >-
                  type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
                stat_prefix: ingress_http
                codec_type: AUTO
                access_log:
                  name: envoy.access_loggers.http_grpc
                  typed_config:
                    '@type': >-
                      type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog
                    log_format:
                      text_format: "plain_text - %REQ(:path)% - %RESPONSE_CODE%"
                    path: "/dev/stdout"
     ```
Please suggest how can i enable access logs using text option.

Hi, did you find a solution to this issue @hinawatts ?

Hi @jleskovar-tyro, no I didn't find a solution to this. I have switched to json_format type.

@hinawatts @hinawatts
Example of access log config for a v3 HttpConnectionManager is as follows:
        typed_config:
          "@type": type.googleapis.com/envoy.extensions.filters.network.http_connection_manager.v3.HttpConnectionManager
          access_log:
            name: "envoy.access_loggers.http_file"
            typed_config:
              "@type": "type.googleapis.com/envoy.extensions.access_loggers.file.v3.FileAccessLog"
              path: "/dev/stdout"
              log_format:
                text_format: "path=%REQ(:path)%\n"

And for v2:
        typed_config:
          "@type": type.googleapis.com/envoy.config.filter.network.http_connection_manager.v2.HttpConnectionManager
          access_log:
            name: "envoy.access_loggers.http_file"
            typed_config:
              "@type": "type.googleapis.com/envoy.config.accesslog.v2.FileAccessLog"
              path: "/dev/stdout"
              format: "path=%REQ(:path)%\n"

Note that logs printing is buffered, so there will be a delay (for envoy to print a log corresponding log line) if you test it with a single request.


NFR's catalog - Types of non-functional requirements to consider

Description
It is for the ART team to decide if this .md should be published as a inspiration on what NFR's are and what to consider.
I have done the list and added to feature on NFR's as well - so please only approve this PR if you think it should be published

Hej Anita.
Jeg har denne her stående som opgave. Jeg når det ikke før fredag, tror jeg
Venlig hilsen
Mogens Juul Sass-Petersen
Domænearkitekt
Processer og Design
+4524916740
<EMAIL_ADDRESS>Fra: Anita Soerensen @.>
Sendt: 10. maj 2021 12:39
Til: Energinet-DataHub/green-energy-hub @.>
Cc: Mogens Juul Sass-Petersen @.>; Review requested @.>
Emne: Re: [Energinet-DataHub/green-energy-hub] NFR's catalog - Types of non-functional requirements to consider (#97)
Vær opmærksom på afsender, links og filer.
@ASQ-ENhttps://github.com/ASQ-EN requested your review on: #97https://github.com/Energinet-DataHub/green-energy-hub/pull/97 NFR's catalog - Types of non-functional requirements to consider.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHubhttps://github.com/Energinet-DataHub/green-energy-hub/pull/97#event-4715951524, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARCTJ2GO2UA3Y36T4MCCM7DTM6ZTHANCNFSM44Q3LNWQ.

Hej Anita. Jeg har denne her stående som opgave. Jeg når det ikke før fredag, tror jeg Venlig hilsen Mogens Juul Sass-Petersen Domænearkitekt Processer og Design +4524916740<EMAIL_ADDRESS>Fra: Anita Soerensen @.> Sendt: 10. maj 2021 12:39 Til: Energinet-DataHub/green-energy-hub @.> Cc: Mogens Juul Sass-Petersen @.>; Review requested @.> Emne: Re: [Energinet-DataHub/green-energy-hub] NFR's catalog - Types of non-functional requirements to consider (#97) Vær opmærksom på afsender, links og filer. @ASQ-ENhttps://github.com/ASQ-EN requested your review on: #97<#97> NFR's catalog - Types of non-functional requirements to consider. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub<#97 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARCTJ2GO2UA3Y36T4MCCM7DTM6ZTHANCNFSM44Q3LNWQ.

Hi Mogens,
Please consider this - as we have determined for now, that this .md will be a central place for collecting this input, so that the teams know where to finds this. The document and placement will be demo'ed on friday.
Thank you, Anita


Introduce gMSA accounts support

Description:
At the moment Azure Pipelines Agent doesn't support Group Managed Service Accounts. This PR introduces support for such accounts.
Note:
This PR recovered changes made previously:

#1294
#3791
#3845

Changelog:
NativeWindowsServiceHelper class:

Introduced IsManagedServiceAccount and CheckNetIsServiceAccount methods - to check if the account is managed service
Introduced SanitizeManagedServiceAccountName method - to remove $ character from managed service account name
Introduced NetIsServiceAccount method

WindowsServiceControlManager class:

Added a warning message if an account is not gMSA

Unit tests:

Introduced MockNativeWindowsServiceHelper class
Added unit tests to NativeWindowsServiceHelperL0 test suit

Documentation changes required:

Yes

Added unit tests:

Yes

Attached related issue:

TBD

Checklist:

[x] There are no risky dependency updates
[x] Changes have been tested

thank you. .\config.cmd --unattended --runAsService --windowsLogonAccount 'xxx\msaDevopsAgent$' works now!

This unfortunately doesn't work for me, I have just opened #4343 for that.

Update: it did eventually work for me, I have amended #4343 to reflect that. More details there.


getmail6: Fix FHS reference

Description of changes
For the issue reported in https://github.com/NixOS/nixpkgs/pull/191881#issuecomment-1252108145
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 192101 run on x86_64-linux 1

1 package built:

getmail6

Thank you for the fix!


.Net8 Isolated worker Service Bus Trigger "No Job functions found" error when deploying code to azure functions

Description
Hi there,
Getting the following error with a .Net8 Isolated worker project when deployed to a Consumption based Windows based Azure Function in West Europe:

"No job functions found. Try making your job classes and methods public. If you're using binding extensions (e.g. Azure Storage, ServiceBus, Timers, etc.) make sure you've called the registration method for the extension(s) in your startup code (e.g. builder.AddAzureStorage(), builder.AddServiceBus(), builder.AddTimers(), etc.)."

The code I am trying to deploy works perfectly fine locally and the service bus trigger is correctly registered and triggered. However, after deployment, the no job function error occurs in application insights and the trigger does not show up as a function in the azure portal, as if its just been ignored.
I'm using all the latest nuget packages however ill list the relevant ones below:

<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
I've verified that the connection string has been placed in the environment variable section of the azure function correctly and that the azure function is set to zip deploy.
Csproj

host.json

Relevant local.settings.json (AzureWebJobsStorage points to Azure Storage in cloud)

Relevant service bus trigger in code

Relevant Program.cs startup code
(Note, this project has a requirement to connect to multiple service buses so im using a named azure client approach)

Any help would be greatly appreciated!
Thanks,
Ben
Steps to reproduce
Create a .net8 isolated worker project, with a single service bus trigger as described above. Use the latest sdks in nuget for azure worker projects. Run and verify the code works locally then deploy to a windows based azure function.

Hi @PFXBen can you share your app privately using these instructions so we can investigate the deployed app?
And can you see if adding the MSBuild prop <FunctionsEnableWorkerIndexing>false</FunctionsEnableWorkerIndexing> to your project fixes the problem in deployment?

Same issue here.... .net 8 service bus triggered azure function works perfectly on my local. The release pipeline by using zip deployment also succeed. However, no functions found in azure portal.

Hi @PFXBen can you share your app privately using these instructions so we can investigate the deployed app?
And can you see if adding the MSBuild prop <FunctionsEnableWorkerIndexing>false</FunctionsEnableWorkerIndexing> to your project fixes the problem in deployment?

Adding the MSBuild prop unfortunately hasn't made any difference. As for sharing the app privately, as there are no azure functions shown, i can only do option 2, and when i try to do that i just get a 404 error back and nothing logged on the azure function. Is there a way i can privately share the function app URL or other identifying information with you guys so I don't have to post it here?

Same issue here.... .net 8 service bus triggered azure function works perfectly on my local. The release pipeline by using zip deployment also succeed. However, no functions found in azure portal.
@satvu Adding that MSBuild prop fixed the problem. Wondering what is that prop doing? if this prop is needed, why it is not included in the VS template (I created the service bus triggered azure function via VS new project)

The prop is true by default as part of some performance improvements (see here).  @iqoOopi, can you share your function app privately with these instructions so we can inspect it in prod?

Hi @PFXBen can you share your app privately using these instructions so we can investigate the deployed app?
And can you see if adding the MSBuild prop <FunctionsEnableWorkerIndexing>false</FunctionsEnableWorkerIndexing> to your project fixes the problem in deployment?

Adding the MSBuild prop unfortunately hasn't made any difference. As for sharing the app privately, as there are no azure functions shown, i can only do option 2, and when i try to do that i just get a 404 error back and nothing logged on the azure function. Is there a way i can privately share the function app URL or other identifying information with you guys so I don't have to post it here?

@PFXBen Can you provide a minimal repro and share a GH link to it? I will see if I can repro the issue myself deploying it to the same region.

Hi @PFXBen can you share your app privately using these instructions so we can investigate the deployed app?
And can you see if adding the MSBuild prop <FunctionsEnableWorkerIndexing>false</FunctionsEnableWorkerIndexing> to your project fixes the problem in deployment?

Adding the MSBuild prop unfortunately hasn't made any difference. As for sharing the app privately, as there are no azure functions shown, i can only do option 2, and when i try to do that i just get a 404 error back and nothing logged on the azure function. Is there a way i can privately share the function app URL or other identifying information with you guys so I don't have to post it here?

@PFXBen Can you provide a minimal repro and share a GH link to it? I will see if I can repro the issue myself deploying it to the same region.

@satvu sure ok ill try and sort that out today for you. On the basis that its not a production facing app, has no HTTP triggers and i can edit this post to remove it, Im happy to share the URL here aswell, its https://func-dms-dev-09.azurewebsites.net In West Europe

FYI - I'm experiencing this exact issue, and the MSBuild property isn't working for me either.

Any update @satvu ?

@PFXBen We are still investigating- will post more updates when we are more confident on a root cause.

@PFXBen @alanmk We investigated another similar incident where we had the full app payload, and the issue was due to the folder structure of the deployed zip. How are you building/deploying your app? Are either of you MacOS users by any chance? Additionally, if you could open a support case, it may be easier/quicker for us to investigate as there are many root causes that can lead to this scenario.

@satvu/@PFXBen We've managed to resolve our issues after a bit more investigation.
After a bit of digging, we found that the following device gave us considerably more diagnostic information to work with:
 using eventSourceListener = new AzureEventSourceListener(
            (args, message) => Logger.LogInformation("[{0:HH:mm:ss:fff}][{1}] {2}", DateTimeOffset.Now, args.Level, message),
            level: EventLevel.Verbose);

We used it to bookend our host configuration and were able to deduce that we were encountering a number of issues relating to network configuration and MSI. Once corrected, everything seem to work as intended.
It's probably worth mentioning that we also needed to include the MSBuild prop in our csproj files.
<FunctionsEnableWorkerIndexing>false</FunctionsEnableWorkerIndexing>

I hope this helps.

@PFXBen You should be able to open one from the Azure Portal - if you navigate to "Support + Troubleshooting" you should be able to open a support case and fill out the fields as best you can (not 100% sure what the UI is currently, but you should be able to link the exact resource to the case in a dropdown box specific to you).

@satvu Tried logging a support ticket but it wont let me proceed with opening that ticket until ive address the exception its raising, which is the same one at the start of this ticket...so it wont let me open it

@PFXBen , @satvu
We are facing this exact same issue, when we tried upgrading Azure Function from .Net-6 to .Net-8
Please share if we have solution for it now?

I'm adding a comment here for anyone who may come across this issue and how we potentially solved it on our end. Like many others we started experiencing this issue when we had upgraded our azure functions from in-process to isolated worker (and from .net 6.0 to .net 8.0). We had followed many of the other solutions which I will mention here as to consolidate our attempts and elaborate on the actual fix for us.
Potential reason for not seeing deployed functions:
The structure of the files for each azure function in its deployed state needs to be in a certain 'format' or 'layout'. More specifically, if anything subverts that layout you may not see the azure function at all or may see errors already mentioned here. This means any method for 'zip deploying' could alter the structure of that layout.
The steps to produce a resolution
From previous research on this same topic we obtained a solution as follows:

We initially released from the publishing option by right clicking the Azure function within our visual studio solution and going through the 'publish wizard' to release the function to its original deployed location. In place of this step I have also verified that creating the azure function in the portal itself set to the isolated worker model with all needed resources and then deploying in the same manner should be equivalent to this step. This step was needed because the previous application settings are pointing to a previous version of dotnet and not the isolated model which we explain in the next few steps. During the process make sure to unselect 'Run from package file (recommended)' and DO NOT HIT PUBLISH YET. You may receive errors upon publishing that give no real vital information if you do.

To note:
For Continuous Deployments of Azure Function App using GitHub Actions, you have to enable the setting 'SCM_DO_BUILD_DURING_DEPLOYMENT' to true in the Application Configuration.

The 'publish wizard' updates the application settings and generally points to the dotnet-isolated version of functions along with putting in a placeholder for the isolated worker model. Navigate to the azure function in the portal and ensure that these settings are correct in our environment variables/application settings:

Whether you created the function in the portal then deployed or used the 'publish wizard' you must ensure these settings exist before continuing.

Next click 'publish' from the final step in the 'publish wizard' which will deploy the function to the location of your choosing. If the settings are correct from the previous step the deployment should succeed and you should see the functions not in the 'Overview' window in Azure portal. To some varying degrees I've seen some errors when clicking 'publish' and then checked the error message to only get something akin to:

System.AggregateException: One or more errors occurred. ---> Microsoft.WebTools.Shared.Exceptions.WebToolsException: Publish has encountered an error. We were unable to determine the cause of the error. Check the output log for more details.
   --- End of inner exception stack trace ---
---> (Inner Exception #0) Microsoft.WebTools.Shared.Exceptions.WebToolsException: Publish has encountered an error. We were unable to determine the cause of the error. Check the output log for more details. <---

Microsoft.WebTools.Shared.Exceptions.WebToolsException: Publish has encountered an error. We were unable to determine the cause of the error. Check the output log for more details.

Which I believe generally means the settings from the previous step did not gel correctly with the publishing step. If the error continues try going through the publishing process again and removing connections to resources. I noted that once I had just the 'bare-bones' of deploying the azure function this worked as well.
CI/CD Deployment Fix
Besides the manual fix to this issue we also noticed that our CI/CD deployment through Azure Devops caused the function to disappear or not be found in some manner. This is because all mentions of build steps that zip or archive the project files before creating a release caused the files to be zipped twice. Meaning, any build pipeline steps that mention needing to archive a zip artifact need to be removed.
Previously we had a task to publish the files and archive them like so:
...
- task: DotNetCoreCLI@2
  displayName: 'Publish Azure Functions'
  inputs:
    command: 'publish'
    publishWebProjects: false
    projects: '$(System.DefaultWorkingDirectory)/$(functionProjectAppName)/$(functionProjectAppName).csproj'
    arguments: '--configuration Release --output $(Build.ArtifactStagingDirectory)/publish/$(environmentName)/$(functionProjectAppName)'
    zipAfterPublish: true
...

We entirely removed zipAfterpublish - which is the main culprit or generally any task or job that zips the files before release (via publishing or a publish command). Following the Microsoft documents you can explicitly set it to false so the task should look like this now (along with a few other options explicitly set):
...
- task: DotNetCoreCLI@2
  displayName: 'Publish Azure Functions'
  inputs:
    command: 'publish'
    projects: '$(System.DefaultWorkingDirectory)/$(functionProjectAppName)/$(functionProjectAppName).csproj'
    arguments: '--configuration Release --output $(Build.ArtifactStagingDirectory)/publish/$(environmentName)/$(functionProjectAppName)'
    publishWebProjects: false
    modifyOutputPath: false
    zipAfterPublish: false
...

Then our release is just a standard Azure Function Deployment Release - ensure you can see the zip file in the location you have chosen. I was extra precautious by having a task that would extract the files from the zip location and then move them into a separate folder location. Then from that location we would deploy the zip file.

The deployment method allowed was to leave it as 'Auto-Detect'.
Potential Pitfalls
I've seen that the 'Auto-Detect' feature will choose publish using the package which it will zip and use a positional argument that publishes the versions that are already in the package.json files. If the settings in Azure portal do not reflect the method in which you are attempting to deploy you will receive another error on publish. As part of the CI/CD pipeline the release step for deploying the actual azure function will set this variable to either zero or one in the portal.

There are also sources listed in the next section that mention removing the archiving of files from the CI/CD pipeline. I have tried both versions of leaving them in and also removing them and was able to see the functions in their deployed location. It could just be a matter of being conscious of the steps taken to zip your deployment.
Again be warry of your settings.
Sources

https://stackoverflow.com/questions/66662364/deploying-azure-function-isolated-process-to-azure-using-azure-devops-is-not-w
https://stackoverflow.com/questions/76255239/deployed-isolated-function-app-returns-404
https://stackoverflow.com/questions/75503474/azure-functions-deployment-from-git-does-not-work-with-net-7
https://stackoverflow.com/questions/55623529/azure-function-deployed-successfully-but-not-working
https://learn.microsoft.com/en-us/azure/azure-functions/functions-how-to-azure-devops?tabs=csharp%2Cyaml&pivots=v1

I'm adding a comment here for anyone who may come across this issue and how we potentially solved it on our end. Like many others we started experiencing this issue when we had upgraded our azure functions from in-process to isolated worker (and from .net 6.0 to .net 8.0). We had followed many of the other solutions which I will mention here as to consolidate our attempts and elaborate on the actual fix for us.
Potential reason(s) for not seeing deployed functions:
The structure of the files for each azure function in its deployed state needs to be in a certain 'format' or 'layout'. More specifically, if anything subverts that layout you may not see the azure function at all or may see errors already mentioned here. This means any method for 'zip deploying' could alter the structure of that layout.
That and the application settings needs to have very specific options selected.
The steps to produce a resolution
From previous research on this same topic we obtained a solution as follows:

We initially released from the publishing option by right clicking the Azure function within our visual studio solution and going through the 'publish wizard' to release the function to its original deployed location. In place of this step I have also verified that creating the azure function in the portal itself set to the isolated worker model with all needed resources and then deploying in the same manner should be equivalent to this step. This step was needed because the previous application settings are pointing to a previous version of dotnet and not the isolated model which we explain in the next few steps. DO NOT HIT PUBLISH YET. You may receive errors upon publishing that give no real vital information if you do.

The 'publish wizard' updates the application settings and generally points to the dotnet-isolated version of functions along with putting in a placeholder for the isolated worker model. Navigate to the azure function in the portal and ensure that these settings are correct in our environment variables/application settings:

Whether you created the function in the portal then deployed or used the 'publish wizard' you must ensure these settings exist before continuing.
To note: For Continuous Deployments of Azure Function App using GitHub Actions, you have to enable the setting 'SCM_DO_BUILD_DURING_DEPLOYMENT' to true in the Application Configuration.

Next click 'publish' from the final step in the 'publish wizard' which will deploy the function to the location of your choosing. If the settings are correct from the previous step the deployment should succeed and you should see the functions not in the 'Overview' window in Azure portal. To some varying degrees I've seen some errors when clicking 'publish' and then checked the error message to only get something akin to:

System.AggregateException: One or more errors occurred. ---> Microsoft.WebTools.Shared.Exceptions.WebToolsException: Publish has encountered an error. We were unable to determine the cause of the error. Check the output log for more details.
   --- End of inner exception stack trace ---
---> (Inner Exception #0) Microsoft.WebTools.Shared.Exceptions.WebToolsException: Publish has encountered an error. We were unable to determine the cause of the error. Check the output log for more details. <---

Microsoft.WebTools.Shared.Exceptions.WebToolsException: Publish has encountered an error. We were unable to determine the cause of the error. Check the output log for more details.

Which I believe generally means the settings from the previous step did not gel correctly with the publishing step. If the error continues try going through the publishing process again and removing connections to resources. I noted that once I had just the 'bare-bones' of deploying the azure function this worked as well.
CI/CD Deployment Fix
Besides the manual fix to this issue we also noticed that our CI/CD deployment through Azure Devops caused the function to disappear or not be found in some manner. This is because all mentions of build steps that zip or archive the project files before creating a release caused the files to be zipped twice.
Previously we had a task to publish the files and archive them like so:
...
- task: DotNetCoreCLI@2
  displayName: 'Publish Azure Functions'
  inputs:
    command: 'publish'
    publishWebProjects: false
    projects: '$(System.DefaultWorkingDirectory)/$(functionProjectAppName)/$(functionProjectAppName).csproj'
    arguments: '--configuration Release --output $(Build.ArtifactStagingDirectory)/publish/$(environmentName)/$(functionProjectAppName)'
    zipAfterPublish: true
...

We entirely removed zipAfterpublish - which is the main culprit or generally any task or job that zips the files before release (via publishing or a publish command). Following the Microsoft documents you can explicitly set it to false so the task should look like this now (along with a few other options explicitly set):
...
- task: DotNetCoreCLI@2
  displayName: 'Publish Azure Functions'
  inputs:
    command: 'publish'
    projects: '$(System.DefaultWorkingDirectory)/$(functionProjectAppName)/$(functionProjectAppName).csproj'
    arguments: '--configuration Release --output $(Build.ArtifactStagingDirectory)/publish/$(environmentName)/$(functionProjectAppName)'
    publishWebProjects: false
    modifyOutputPath: false
    zipAfterPublish: false
...

Then our release is just a standard Azure Function Deployment Release - ensure you can see the zip file in the location you have chosen. I was extra precautious by having a task that would extract the files from the zip location and then move them into a separate folder location. Then from that location we would deploy the zip file.
The deployment method allowed was to leave it as 'Auto-Detect'.
Potential Pitfalls
I've seen that the 'Auto-Detect' feature will choose 'publish using the package' which it will zip and use a positional argument that publishes the versions that are already in the package.json files. If the settings in Azure portal do not reflect the method in which you are attempting to deploy you will receive another error on publish. As part of the CI/CD pipeline the release step for deploying the actual azure function will set this variable to either zero or one in the portal.
Note that if your release becomes out of sync then it will not deploy. I have seen that the 'manual' publish through visual studio will sometimes change the application settings and then other times it won't.
There are also sources listed in the next section that mention removing the archiving of files from the CI/CD pipeline. I have tried both versions of leaving them in and also removing them and was able to see the functions in their deployed location. It could just be a matter of being conscious of the steps taken to zip your deployment.
Again be warry of your settings.
Sources

https://stackoverflow.com/questions/66662364/deploying-azure-function-isolated-process-to-azure-using-azure-devops-is-not-w
https://stackoverflow.com/questions/76255239/deployed-isolated-function-app-returns-404
https://stackoverflow.com/questions/75503474/azure-functions-deployment-from-git-does-not-work-with-net-7
https://stackoverflow.com/questions/55623529/azure-function-deployed-successfully-but-not-working
https://learn.microsoft.com/en-us/azure/azure-functions/functions-how-to-azure-devops?tabs=csharp%2Cyaml&pivots=v1

Thanks for the reply @longmatthew , this worked for me and has solved the issue above, service bus triggers are now showing as expecting. Hopefully this can help @satvu find the root cause.

@longmatthew Thanks for the excellent, detailed writeup! We will review this flow to create more specific work items for improving it and adding instrumentation to better diagnose these kinds of issues for customers.

Closing this as it is primarily a host issue - you can track our first improvement task in the host: https://github.com/Azure/azure-functions-host/issues/10021.

In my case, my github action was split into two jobs - Build and Deploy. I was using actions/upload-artifact@v4 and actions/download-artifact@v4. Removing this and combining into one job was all that was needed to not cause the zipping issue described above.


Fix TO Go logging unauthenticated endpoints

Also adds info logging for requests, and adds a quasi-unique request
ID to the APIInfo object for logging and other uses.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1832/
Test PASSed.


Extra projects, change code styling strategy

Checklist

[x] I have read the Contributor Guide
[x] I have read and agree to the Code of Conduct
[x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes
Add missing projects, hiding those we don't want advertised. With a "hidden" property.
Linting
I've gone out on a limb and swaped the deprecated eslint action for prettier, which is closer to Rustfmt which we use on Rust projects. This has the nice bonus of not needing errors to be manually fixed, prettier will automatically do it for us.
This doesn't align with the current JS guidelines (a single line saying we use airbnb style eslint) but I think it could be worth changing that as prettier has a lot less maintenance overhead than eslint, and the migration of our other JS project can be done by running npx prettier --write **/*.js.
What do you think?
Closes: #48

I'm fine with moving to prettier, this PR should also delete eslintrc too :)

this PR should also delete eslintrc too :)

More stuff to delete, sweet

@lpil you can also make the relevant change to the guidelines, saying we use prettier with single quote and whatever other rules.

For sure, I'll update the other bits and bobs.
I added the single quote bit to make the diff smaller, but it might be easier to just use the Prettier defaults and tolerate one larger diff. Easier installation and less config.

Approving this and we can take the JS formatting discussion when we update the guidelines!

I'll put that config then :)
On Thu, 10 Dec 2020, 11:15 Ari V<EMAIL_ADDRESS>wrote:

hmhmmmm...I do like single-quotes...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/EmbarkStudios/opensource-website/pull/66#issuecomment-742455653,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABOZVBRUQPUUCSOJLXT77TLSUCUTHANCNFSM4UU2VFWQ
.

Huh, turns out the other project already uses Prettier

As does review-action

well I guess that gives our answer then! I will live with double-quotes :P


feat: 🎸 add typescript type definitions

Adds support for Typescript by adding type definitions allowing users of
this component to get autocomplete and type-safe usage of this component
Closes #76

any chance to get this merged?

This package is pretty important for most of the people who uses Filestack with React, I don't see many activity by the Filestack team maintaining it, if more effort was put on this would be very appreciated by your customers.

Please approve


logs size

What are you experiencing an issue with?

[x ] Aurora
[ ] Aurora supported game, (Fill in the game)
[ ] Aurora Wrapper
[ ] Aurora Profile
[ ] Aurora supported device, (Fill in problematic devices)
[ ] Aurora Scripts
[ ] Aurora Updater
[ ] Aurora Lighting issue
[ ] Other, (Fill in another issue here)

What kind of an issue is it?

[ ] Crash
[ ] Performance problems
[ ] Visual bug
[ ] Localization issue
[ ] Enhancement suggestion
[ ] Device issue
[x ] Other, (Fill in another type of issue here)

Expected behavior:
Explain here what should happen.
Actual behavior:
Logs are getting way too big ! had to delete the logs folder as there was 241gb of logs in there.
How often does this problem occur?

This problem occurs... (always)
Please describe the steps to reproduce this issue:
The issue can be reproduced by doing following steps:

What is the version of Aurora you are experiencing this issue with?

My version is... (0.6.1 dev4)
Does the previous version of Aurora have this issue?
The previous version, (Fill in the version here), did/did not have this issue.
Please include any logs, screenshots, or files that are related to this issue:

For logs, you can use: http://pastebin.com/
For screenshots, you can use: http://imgur.com/
For files, you can use: http://www.tinyupload.com/ , https://www.dropbox.com/ , or attach them to the issue.

Duplicate of #1065


MAINT: Simplify masking of bad values in stats._multivariate.

Instead of relying on a custom _checkresult and manual broadcasting, we can just use np.where and np.select as appropriate, which is simpler to read (or at least not worse even if you don't know the semantics of these functions); these also handle the broadcasting for us.
This will make all affected functions consistently return size-() arrays for scalar inputs, which is a slight API change but actually more consistent that the previous situation (multinomial would return a size-() array for valid scalar inputs and a plain scalar for invalid inputs; hypergeom would always return a plain scalar for scalar inputs).
(Noted while working on #17750.)

Reference issue

What does this implement/fix?

Additional information

@anntzer Thanks; I just thought I'd mention that I (personally) do not plan to review/merge this because this is related to gh-16278, which @tupui and I plan to address within the next year or so as part of this project. Others are welcome to, though.

I could easily take advantage of the refactor here to introduce small _where and _select helpers which behave as np.where and np.select but additionally return scalars when the selector input is scalar, which should certainly help to improve the consistency re: scalars (without making guarantees to fix everything).
I don't feel overly strongly about this, though.


Config ignores insecure-skip-tls-verify field

Tightly related to #554, also broken ever since Kubeclient::Config was added (I'm fixing them together): insecure-skip-tls-verify field in kubeconfig was never honored.
The distinction is that #554 is about the default being dangerous, and this ticket is about inability to override the default (either way) by insecure-skip-tls-verify.

Closing, this has been fixed both in 4.9.3 and on master branch.


groupBy query: optional limit push down to segment scan

Fixes ##8413
Description
This patch enables optimization to exploit limit push down in segment scan phase during V2 GroupBy query processing.
At a high level following changes are introduced.

applyLimitPushDownToSegment property is introduced to enable this optimization both at cluster and query level (true by default)
GroupByQueryEngineV2.HashAggregateIterator.newGrouper() is updated to return LimitedBufferHashGrouper when query.isApplyLimitPushDown() == true
GroupByQueryEngineV2.GroupByEngineKeySerde is updated to correctly implement Grouper.BufferComparator bufferComparator() and Grouper.BufferComparator bufferComparatorWithAggregators(..) methods.
A new method Grouper.BufferComparator bufferComparator(int keyBufferPosition, @Nullable StringComparator stringComparator) is added to GroupByColumnSelectorStrategy
Code related to creation of Grouper.BufferComparator from RowBasedGrouperHelper into a new class GrouperBufferComparatorUtils for reuse.

This PR has:

[X] been self-reviewed.
[X] added documentation for new or modified features or behaviors.
[X] been tested in a test Druid cluster.

@jon-wei not sure if this is on your radar, thanks.

Thanks @clintropolis  for the review. We have had this running on our cluster and found a bug related to sql compatible null handling that I fixed. Aside from that it has been working well. It appears some UTs are failing due to changes, I will fix those and then merge.


Update log4j-api, log4j-core to 2.17.1

Updates

org.apache.logging.log4j:log4j-api
org.apache.logging.log4j:log4j-core

from 2.17.0 to 2.17.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.logging.log4j" } ]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #436.


Week 7 Review Ticket

Quiz 5 MCQ over 50% w test corrections
Github pages
Tangibles

4/5/5

Quiz is complete over 50% and all corrections are done.
Github page with corrections and quiz are complete. Crossover and study plan are up to date.


README refers to a missing LICENSE file

First of all, thank you for creating and sharing this project with us!
The README says this project is under the MIT license and refers to a LICENSE file:
https://github.com/wizenheimer/tinkerbird/blob/4c987b6380988e2eb53422c14ae8faf96056aa4a/README.md?plain=1#L231-L233
However, there's no LICENSE file in this repo.
Since you said it's MIT-licensed, please add a LICENSE file; you can use this MIT license template (the site is by GitHub): https://choosealicense.com/licenses/mit/ or you can use https://opensource.org/license/mit, but GitHub's site is providing an already properly formatted and word-wrapped text file template, which is easier to read, so I suggest using that one.

Thanks for bringing this up.
Would be pushing a fix.


Incompatible generic types between react components using refs

Flow try link
Bar is meant to "extend" Foo while maintaining the generic type T.
import React, {Component} from 'react';

type PropsFoo<T> = {
  generic?: T,
  doSomethingWithGeneric: (generic: ?T) => any,
};

class Foo<T> extends Component<PropsFoo<T>> {}

type PropsBar<T> = PropsFoo<T> & {
  otherProp: any,
};

class Bar<T> extends Component<PropsBar<T>> {

  foo: ?Foo<*>;
  setRef = (ref: ?Foo<*>) => this.foo = ref;

  render() {
    return (
      <Foo
        ref={this.setRef} // remove this, no error
        {...this.props}
      />
    )
  }
}

21:       <Foo           ^ Cannot create `Foo` element because `T` [1] is incompatible with `T` [2] in property `generic`.
References:
4:   generic?: T,
               ^ [1]
5:   doSomethingWithGeneric: (generic: ?T) => any,
                                        ^ [2]

Am I doing something incorrectly or is this a flow bug?

The fix.
Do not use *, it's deprecated.

Thank you @apsavin. Why do I have to bind(this) instead of using an arrow function?

You don't have to.

Also, what were the motives behind deprecating * in 0.72.0?

I'm not sure (I'm not from the flow team) but I heard that * caused perf issues.


Nav item indexing issues

Noticed a few weird issues with the list / nav items
https://www.loom.com/share/c0908295966e4c7fa6de76c783692cbe

[ ] Rearranging the nav-items isn't reflected in the page (until the nav-item itself is edited)

https://www.loom.com/share/7c9387e0483441128ab24b746776f33a

[ ] Nav item is occasionally duplicated.

It may make sense to split this up into separate issues.

There was an upstream fix so this should be resolved but there may be a delay. I'll check once things are published.


Add option to enable dark mode

WIP

The PR was closed because the branch update_playground was deleted. You need to re-create a PR pointing to main 😊


Prevent escalation of privileges

Coverage decreased (-0.03%) to 99.033% when pulling 2eb4676df918fcb30ebbd5e959aaac1436bbe5bd on tf:permission-fixes into e4260dbb87163c8a3a46bb7f15395811020711a0 on codevise:master.

Coverage decreased (-0.03%) to 99.033% when pulling 2eb4676df918fcb30ebbd5e959aaac1436bbe5bd on tf:permission-fixes into e4260dbb87163c8a3a46bb7f15395811020711a0 on codevise:master.