Added more

@Rexadev I need help to figure out why you think tenor is any porn related. at best I can find something infidels or other new religious milf's would call pornographic


pre trained model

hi aftab i tried ur pre trained model on my dataset, but it giving me match = true on every verification pic. I tried on real, forge and fake data and reduce threshold too but nothing work

real

real

real

fake

forge

forge

forge
can u please check and if you have new saved model can u please give link with threshold value.
Thank you.

Threshold value for the pretrained model is available in the code.
Model can be downloaded by running the DownloadData.py file as mentioned in the Readme.


Adding two failing tests

Here are two failing scenarios I stumbled upon while playing with this addon.

Good catch!

Those two cases are fixed now, but I'm sure there is more, specially around templates as it's the least production-ready feature of the library yet.


DRILL-5359: Fix ClassCastException when Drill pushes down filter on t…

…he output of flatten operator.

Move findItemOrFlatten as a static method in DrillRelOptUtil.
Exclude filter conditions if they contain item/flatten operator.

+1


Add tl.welford to allow var_mean to be implemented in one pass

Currently PyTorch inductor is forced to implement torch.var_mean as two passes over the input data, which causes a slowdown for batch norm. To allow single-pass computation we need a new reduction operator tl.welford(mean, m2, count) which implements the combination step of parallel Welford's algortihm.
A more general solution might be to instead add a tl.reduce which takes a function acting on scalars, so users can write their own reductions without needing to change the triton language.

I feel like such a function would not belong in the triton.language namespace. As you suggested, the right solution is probably to have some more flexible reduce op, but this would be a significant amount of work as none of our optimizer and backend codegen is ready to support instructions that take in functions as arguments


Platform.OS always returning "web"

Description
Hello, how are you?
I'm currently teaching react-native to my students and facing this problem.
Always I use Platform.OS I'm getting "web": on the web (obviously), android emulator (pixel API 30), and my smartphone (also android).
Version
0.68.2
Output of npx react-native info
System:
OS: Linux 5.15 Ubuntu 22.04 LTS 22.04 LTS (Jammy Jellyfish)
CPU: (4) x64 Intel(R) Core(TM) i5-6600K CPU @ 3.50GHz
Memory: 6.80 GB / 15.50 GB
Shell: 5.1.16 - /bin/bash
Binaries:
Node: 16.14.2 - ~/node-v16.14.2-linux-x64/bin/node
Yarn: Not Found
npm: 8.5.0 - ~/node-v16.14.2-linux-x64/bin/npm
Watchman: Not Found
SDKs:
Android SDK: Not Found
IDEs:
Android Studio: Not Found
Languages:
Java: javac 18-ea - /usr/bin/javac
npmPackages:
@react-native-community/cli: Not Found
react: 17.0.2 => 17.0.2
react-native: 0.68.2 => 0.68.2
npmGlobalPackages:
react-native: Not Found
Steps to reproduce
Just using Platform.OS.
Snack, code example, screenshot, or link to a repository
https://github.com/julianofischer/reactnative-simple-contact-list

I think there might be some problem with react-native-web.
Try replace
import { Platform } from 'react-native-web';

With
import { Platform } from 'react-native';

I'm not a contributor so I don't know exactly but in my opinion it should be in react-native-web repository.

@julianofischer thank you for reporting, @nucleartux thank you for the solution. Closing the issue as resolved.


How to Install on iphone  with phonegap

Expected Behaviour
Iphone should recive notifications
Actual Behaviour
Iphone dont recive notifications
Reproduce Scenario (including but not limited to)
Steps to Reproduce
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
PhoneGap (iOS / Android / Windows)
cli-6.4.0 (4.3.0 / 6.1.0 / 4.4.3)
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Cordova CLI version and cordova platform version
PhoneGap (iOS / Android / Windows)
cli-6.4.0 (4.3.0 / 6.1.0 / 4.4.3)
Plugin version
phonegap-plugin-push    	npm 	~1.9.2
Im using phonegap build and added the plugin ...it registers and gives me the id :38cf2edbec74da4a05c56e12fb2a77a54d000e9e74b5d19b725cd166100e77b1
..
does this means that im all set ?
do i need to use xcode for anything ?
i tried to test and send a msg via http://apns-gcm.bryantan.info/
but i get  Error: Pem File cannot be blank.
can some one helme with the steps to get this working ?
i did :
on apple dev:
-create the push certificates
-create the certificates for the build of the app
-install plugin via cloud on phonegap build

i get the reg.id but still cant recive msgs

@brunoalex seems like you are all set if you have received a notification ID but if you are getting an error setting up the remote service to send a push which is outside the scope of this plugin. You'll need to create the .pem file and upload it to your service.


fix(route-recognizer): a full static segment match should take precedence over a partial dynamic segment match

fixes https://github.com/aurelia/router/issues/575

Nice work. There's a deeper issue here that I'd like to address as well. In the test case you added, if fooBar/:id? wasn't present, 'fooBar' would still match route 'foo/:id?'. It shouldn't.
I'm guessing that we actually should add an entirely new segment for this case, as the logic around DynamicSegment is insufficient.

Yeah, I kind of eluded that in my comment a moment ago. I thought I had it for a split second and then realized how deeply naive this solution is :-)
I only learned how this thing works just an hour ago. Should let it sink in a bit more, hah.

It's cool if you just reject this one. I'm guessing you already have a proper solution in the works and there's no point in me working on it simultaneously with the little knowledge I have of this :)

We always appreciate submissions from contributors! I'm here to help you by sharing what I know.

I get that, I just wanted to make sure you don't feel held up by me considering the sense of urgency you expressed in the issue


allocpool: match cmd name when pid found

In case allocpool finds a process with the pid of the pid file,
also the cmdline needs to be matched to verify, if this process
was an mkcloud run.
Otherwise it might happen (and it did) that the pid counter runs
over and restarts and a pidfile now holds a pid of a different
process (in our case a deamon). This would block a slot from
allocpool even though there no longer is an mkcloud process.
This change does the comparision of the cmdline.

Please do not merge it as it is now. I will force push a general approach to the issue.


find a way to avoid writing your own entity parser

HI if you ℎ𝑎𝑣𝑒 to write your own entity parser, be aware of these:

avoid looping system entity references
e.g. &haha; is used in &token.en; which uses &haha;

not to forget to resolve entity references in a referred file
e.g. &haha; is used in &token.en;

make sure new entities are not mistaken as system entity (think emoji)

make sure entities in CDATA is 𝑛𝑜𝑡 resolved.

make sure entity injection attack isn't possible
One typical way to do so is &entHaha now I escaped prison;

make sure you don't break normal entity references like 'author'
e.g. <!ENTITY author "James Brown">

In general, I suggest to let c10n work out the way and your code should work with a canonicalized copy, not the original. Please avoid writing your own parser and only do so if it's completely not feasible to use a library to canonicalize the XML file dropped on Android. Please bear in mind that regexp will not do it.

we have two major enemies.

fireman thinking (the first plausible cause must be the cause of the problem; the first solution we can think of must be the best solution).

gateway assumption: to make the area inaccessible, we don't need to go through the trouble to defend the area; we just need to remove the gateway to that area.

Kindly not lower your guard in developer mode. Developer mode might be triggered by another bug or the user might be coerced to run it. That is, although normally we run signed code which is already
canonicalized, we shouldn't assume that because developer mode is turned on, the uncanonicalized code isn't intended to breach the system.

I tried the Google recommended Xerces-For-Android source, which does work correctly but because it uses internal versions of the XML structure (eg NodeList, Node, Element etc) it can't be used with the DMZ and peter's tool code.
One solution is to spend time to port a universal implementation of the javax Apache code so one body of code works on both native Java and Android Java. This means we need to maintain another module, but once the project is done it shouldn't need to be touched again for a while.

One solution is to spend time to port a universal implementation of the javax Apache code so one body of code works on both native Java and Android Java. This means we need to maintain another module, but once the project is done it shouldn't need to be touched again for a while.

If the way these objects are used is the same, there might be a duck typing method, perhaps even provided by Gradle so we don't have to use 3rd party modules.


Resource provider Microsoft.Insights should be lower case as microsoft.insights

Microsoft.Insights provider does not follow capitalization norms and is available as lower case microsoft.insights. Programmatically if you attempt to use the non-lowercase form you will get an error in registration. Please update all of the documentation to indicate that it needs to be lowercase or fix the issue with requiring lowercase.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 16b4bb50-25ad-a3c6-f42a-84f33c84e362
Version Independent ID: 6188226a-1f56-2a0a-fc57-4b8616b5fe32
Content: Resource providers by Azure services - Azure Resource Manager
Content Source: articles/azure-resource-manager/management/azure-services-resource-providers.md
Service: azure-resource-manager
Sub-service: management
GitHub Login: @tfitzmac
Microsoft Alias: tomfitz

@Roblarson - Thanks again for bringing this to our attention. We have updated the Doc and it will be live once its merged.  We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Jenkins pipeline step not writing to env

Within my pipeline i want to get some Data from a consul. For that I try to get them with this plugin. From Log output I can see that the value is correct but it isn't written to a environment.
When I try to do that without pipeline it works fine.
Here's the code, maybe i did sth. wrong?
node ('consul') {
    stage('Get service node') {

        step([
            $class: 'ConsulKVBuilder',
            debugMode: 'ENABLED',
            requestMode: 'READ',
            envVarKey: 'SERVICE_HOST',
            keyValue: '',
            key: 'service/'+params.SERVICE_NAME])

        print env.SERVICE_HOST

    }
}

And here the Logoutput from Jenkins:
Started by user user
[Pipeline] node
Running on <NODE> in /home/jenkins/workspace/Docker-Consul-Deployments/with-pipeline
[Pipeline] {
[Pipeline] stage
[Pipeline] { (Get service node)
[Pipeline] step
Consul READ URL:  http://<CONSUL_URL>:8500/v1/kv/service/lala
Response Headers:
Content-Type=application/json
X-Consul-Index=10370
X-Consul-Knownleader=true
X-Consul-Lastcontact=0
Date=Fri, 28 Oct 2016 13:18:23 GMT
Content-Length=111
Consul K/V pair:  service/lala=fooooooo
Stored ENV variable (k,v):  SERVICE_HOST=null
Raw content:  [{"LockIndex":0,"Key":"service/lala","Flags":0,"Value":"Zm9vb29vb28=","CreateIndex":10370,"ModifyIndex":10370}]
[Pipeline] echo
null
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Finished: SUCCESS

I will have to look at this.  It looks like a bug.  In the meantime, the wrapper function seems to work fine.  Perhaps you could use the wrapper instead of a step that reads.
    // some block
}```

I have fixed this and it will be in the next release; I hope to drop that release tonight.

Hi @jimmyraywv thx for fast support. Wrapper works fine so far. But need to use the step because i need keys in different stages where they get modified. I'm waiting for your new release.

@jimmyraywv any idea when your fix will be available?

This is in now.  It will take a while to propagate to the update center JSON:  https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/consul-kv-builder/2.0.13/

Hey @jimmyraywv,
again thx for the fix. I installed the version manually, but still the problem is existent. With the same Jenkinsfile above i got now the following result:

Started by user Björn Heneka
[Pipeline] node
Running on <NODE> in /home/jenkins/workspace/Docker-Consul-Deployments/with-pipeline
[Pipeline] {
    [Pipeline] stage
    [Pipeline] { (Get service node)
        [Pipeline] step
        Consul READ URL:  http://<CONSUL_URL>/v1/kv/service/lala
        Response Headers:
        Content-Type=application/json
        X-Consul-Index=10370
        X-Consul-Knownleader=true
        X-Consul-Lastcontact=0
        Date=Wed, 02 Nov 2016 14:21:33 GMT
        Content-Length=111
        Consul K/V pair:  service/lala=fooooooo
        Stored ENV variable (k,v):  SERVICE_HOST=fooooooo
        Raw content:  [{"LockIndex":0,"Key":"service/lala","Flags":0,"Value":"Zm9vb29vb28=","CreateIndex":10370,"ModifyIndex":10370}]
        [Pipeline] echo
        null
        [Pipeline] }
    [Pipeline] // stage
    [Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
Finished: SUCCESS

As you can see the Variable seems to be written:
Stored ENV variable (k,v):  SERVICE_HOST=fooooooo
But when doing a echo there is a null
Again maybe I'm doing sth. wrong and I just don't see it?

So, this seems to be a limitation, maybe by design, of the SimpleBuildStep in a Pipeline.  While this works fine in a Freestyle job, it does not work in Pipeline.  This link (https://groups.google.com/forum/#!topic/jenkinsci-dev/OG03cDc7Gew) makes it look like it may never work that way.
The workaround may be to write a single-value custom step that returns a string, or use the wrapper to set a local var in the node.
node('master') {
    TEST_KEY = ''

    wrap([$class: 'ConsulKVReadWrapper', reads: [[aclToken: '', apiUri: '', debugMode: 'ENABLED', envKey: 'test_key', hostUrl: '', key: 'test/test-key']]]) {
        echo env.test_key
        TEST_KEY = env.test_key
    }

    echo TEST_KEY
}

Alright. This works fine so far. Thank you so much for support.

Hi,
I found out that, according to you, issue has been resolved.
But i am facing the same issue in a freestyle job too.
In my job, i am reading the values from consul using consul kv builder step.
But when i am trying to print the values using execute shell step. I am not able to print the values.
Can you please help me here.
Attaching the logs
Started by user unknown or anonymous
Building remotely on mac-local in workspace /Users/rudhrarai/workspace/test_consul1
Using default API URI:  /v1/kv/
Consul READ URL:  http://<consul url>/v1/kv/test1/test2/test3/key_internal
Response Headers:
Content-Type=application/json
Vary=Accept-Encoding
X-Consul-Index=2286
X-Consul-Knownleader=true
X-Consul-Lastcontact=0
Date=Tue, 01 Jan 2019 13:52:31 GMT
Consul K/V pair:  test1/test2/test3/key_internal=value_internal_jenkins
Stored ENV variable (k,v):  test=value_internal_jenkins
Raw content:  [{"LockIndex":0,"Key":"test1/test2/test3/key_internal","Flags":0,"Value":"dmFsdWVfaW50ZXJuYWxfamVua2lucw==","CreateIndex":2266,"ModifyIndex":2286}]
[test_consul1] $ /bin/bash -xe /var/folders/k7/3zv2wztj6ys942gvfxtpz7wr0000gn/T/jenkins322123237512924365.sh
+ echo 'value is => '
value is =>
Finished: SUCCESS

Hi, I am writing from the future (almost 3 years after this was opened). The bug is still here :(

@a0s Wow, that's really funny.  You know what else is really funny?  I don't work with Jenkins anymore.


Don't deny warning when developing, only on CI

This changes the lint settings to only emit warnings by default. This means that during development, you'll get to see warnings, but rustc will continue on with compiling diesel.
When explicitly checking the code for code style (on CI in the clippy build step, or when using bin/check), we supply --deny warnings as a flag to rustc to error out on warnings.
This does not change anything when using diesel as a dependency, as cargo automatically sets all lints to allow in that case.

I finally came around to it, @llogiq! :)


Multiprocess refresh views

If can't get tests to pass, can switch back to ThreadPoolExecutor and set max_workers more conservatively.

Restarting after closing #162.


MARK03 - Better Initialisation Strategies

Start from: deep, shallow, random, huntress and count the average number of iteration until true tree is reached.
For several scenarios (again, FPR, FNR, number of mutations and cells - hardness of task):
-Generate a fixed tree

Generate a fixed data set from that tree
For each initialization strategy generate an starting tree and do 2,000 iterations
For each strategy generate ~10 starting trees

For each initialization strategy plot all lines (i.e. one color). - i.e. hope all random tree lines converge. - Also, Huntress and shallow has just one.

Do the same plot with log_prob.
Outcome: Is initialization important for speed of convergence of SCITE?

@pawel-czyz What is our true tree here ? If we plot all initial tree conditions (random, deep, start, huntress) on one plot, I assume they all have the same true tree. I propose a random tree.

Great. - will implement it as such.


EMC complex update

is defined
A transmembrane protein complex that is involved in protein folding in the endoplasmic reticulum. In S. cerevisiae, it has six members: EMC1, EMC2, AIM27, EMC4, KRE27, and EMC6.
PMID:19325107
referencing a paper from a screen.
This seems quite out of date? It doesn't appear to have a role in folding?
The ubiquitous and ancient ER membrane protein complex (EMC): tether or not?
Wideman JG.
Version 2. F1000Res. 2015 Aug 25 [revised 2015 Oct 5];4:624. doi: 10.12688/f1000research.6944.2. eCollection 2015.
PMID: 26512320
A conserved endoplasmic reticulum membrane protein complex (EMC) facilitates phospholipid transfer from the ER to mitochondria.
Lahiri S, Chao JT, Tavassoli S, Wong AK, Choudhary V, Young BP, Loewen CJ, Prinz WA.
PLoS Biol. 2014 Oct 14;12(10):e1001969. doi: 10.1371/journal.pbio.1001969. eCollection 2014 Oct.
PMID: 25313861
ER membrane protein complex required for nuclear fusion.
Ng DT, Walter P.
J Cell Biol. 1996 Feb;132(4):499-509.
PMID: 8647883

Note I only came across this because I was preparing
PMID: 27708008
A global genetic interaction network maps a wiring diagram of cellular function.
for journal club.
I wasn't annotating.  I sent a list of potential GO and phenotype annotations  to SGD with a link to this ticket.
Lots of nice use of GO.....

HI Val,
Do you just think the definition needs updating? and do you have a proposal for a new definition?
-Karen

Our findings indicate that
the EMC mediates lipid transfer from the ER to mitochondria by
facilitating tethering between these organelles.
I guess the primary role is "membrane tethering"
How about:
A transmembrane protein complex that is involved in  ER-mitochondrial membrane tethering to facilitate phospholipid transfer. In S. cerevisiae, it has six members: EMC1, EMC2, AIM27, EMC4, KRE27, and EMC6.
PMID:19325107

Interesting that intermembrane lipid transfer proteins I've recently been annotating might be part of the "as yet unknown" non-vesicular mechanism by which the lipids are actually transferred...
I took a quick look at PMID:25313861, which showed the complex is in the ER, so if I add that tidbit, and change the wording a little to try to make it clear that it's the tethering that is facilitating the lipid transfer. I also made it more general, on the suspicion that it's probably not specific to phospholipids, but is true for any of the lipids transferred by intermembrane transfer. How does this sound to you?:
A transmembrane protein complex located in the ER that is involved in ER-mitochondrial membrane tethering, which is required to facilitate lipid transfer. In S. cerevisiae, it has six members: EMC1, EMC2, AIM27, EMC4, KRE27, and EMC6.
PMID:19325107, PMID:25313861, GOC:vw, GOC:krc

Yes, that sounds good. There seem to a lot of new biology in 2 areas of membrane organization, organelle tethering and membrane curvature....Interesting stuff.

Lovely. I don't know if I'll have time to put that in Friday since I'm getting ready to go to Bar Harbor for a week, but if not, I'll put it in next week.
-K

When I went to do it, I had another thought, so I put in the def with this addition to what I suggested previously:
A transmembrane protein complex located in the ER that is involved in ER-mitochondrial membrane tethering, which is required to facilitate lipid transfer from the ER to the mitochondrial membrane. In S. cerevisiae, it has six members: EMC1, EMC2, AIM27, EMC4, KRE27, and EMC6.
This link shows a really good colorized diff between the original definition and what I put in:
https://github.com/geneontology/go-ontology/commit/83a4b55cd824c5c4fa3006bfbcfc51be6cde18af

sounds good...


Support cloud-init bootstrap generating

What this PR does / why we need it:
Generate cloud-init bootstrap, to fetch the provisioning cloud-init over the api server. There are couple of issues regarding injecting the original cloud-init configs, which configure and install all the needed libs and bins to provision a worker node. One of those issues is the cloud-init size, as some cloud providers limit the size.
Which issue(s) this PR fixes (optional, in fixes #<issue number> format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
At the moment, this utility is not used, however in a following up PR, it would be used by the baremetal provisioner.
Optional Release Note:

Fetch the provisioning cloud-init over the api-server

/lgtm

/retest

/test pull-machine-controller-yamllint

/lgtm cancel
@moadqassem The yamllint failure seems legitimate, PTAL.

/retest

/retest

/retest


Use cargo check consistently in prepare

Description of change
Small PR to change cargo sqlx prepare to always use cargo check.
Currently, prepare invokes cargo rustc by default but switches to check when the --merged flag is used. This can lead to confusion since certain flags passed to cargo check will be rejected by cargo rustc when running prepare.
The current behaviour also contradicts the sqlx-cli README, which states:

In order for sqlx to be able to find queries behind certain feature flags you need to turn them on by passing arguments to rustc.
This is how you would turn all targets and features on.
cargo sqlx prepare -- --all-targets --all-features

Which actually fails with the following error:
error: extra arguments to `rustc` can only be passed to one target, consider filtering
the package by passing, e.g., `--lib` or `--bin NAME` to specify a single target
error: `cargo check` failed with status: exit code: 101

But passes with --merged, regardless of whether the current directory is a workspace root or a sub-crate.
cargo sqlx prepare --merged -- --all-targets --all-features
This PR ensures it works with or without --merged.
When the working directory is a crate in a workspace, it still only builds the queries for it and not the entire workspace.
Is there any reason to retain the behaviour of using rustc directly? Edit: does this negatively affect plans for #1706?
This arose from the following comment thread: https://github.com/launchbadge/sqlx/pull/2069#issuecomment-1226870482
Alternative: update the documentation/README.md to specify --merged must be used to combine the queries of multiple targets, even when in a single crate.
P.S. sorry for spamming PRs.
Type of change
Bug fix to match the intended behaviour, but might technically be a breaking change as it changes which flags are accepted or not.
How the change has been tested
cd sqlx-cli && cargo test and running cargo sqlx prepare -- --all-targets --all-features in a sample project.

This PR has conflicts after merging #2069.

Thanks for the ping; rebased the changes.


[bug]:  auto install fails on model download

Is there an existing issue for this?

[X] I have searched the existing issues

OS
Windows
GPU
cuda
VRAM
6gb
What happened?
Running automatic install bat , installed all dependencies ok but on resuming download of default models , i chose skip as I have the stable diffusion main .ckpt models already downloaded to add later .
the installation fails and I get the following message after attempt to download StableDiffusionSafetyChecker
see attached  txt
error.txt
Screenshots
No response
Additional context
No response
Contact Details
telegram  https://t.me/johnthecrow

i deleted the folder C:\Users\Home\invokeai\models\CompVis\stable-diffusion-safety-checker and resumed the install which worked


[Operational] get windows CI builds working again

Some configuration change is causing the windows CI builds to fail on the similarity map tests.
This PR is to try and track that down and fix it.
Try cleaning up the similarity map tests a bit before disabling them completely on windows (temporarily)
We should track the configuration problem down eventually, but I think it make sense to wait until we've moved to the new windows CI platform (with VS2019 instead of VS2017) before doing that. Here's the issue for that:
https://github.com/rdkit/rdkit/issues/4677

merging this myself since it's a configuration change and the problem is causing every PR to fail


Choose the css framework

I would like you to choose a frontend CSS framework to work with:

Tailwind (with Tailwind UI)
Bootstrap
something else?

The result of this task should be to choose one technology.

Tailwind looks promising.

I agree that Tailwind is a good pick. It provides more utility classes than Bootstrap, which will make it easier to create webpage similar to the mock-up given in #3.


Window.Close documentation missing return value for CloseDialog

Type of issue
Missing information
Description
https://learn.microsoft.com/en-us/dotnet/desktop/wpf/windows/how-to-close-window-dialog-box?view=netdesktop-8.0#cancel-close-and-hide
This page states that Close will return false when the window is shown using ShowDialog. This information is missing from this page.
Page URL
https://learn.microsoft.com/en-us/dotnet/desktop/wpf/windows/how-to-close-window-dialog-box?view=netdesktop-8.0
Content source URL
https://github.com/dotnet/docs-desktop/blob/main/dotnet-desktop-guide/net/wpf/windows/how-to-close-window-dialog-box.md
Document Version Independent Id
84dce3df-b013-726d-b5ec-cffd901051ae
Article author
@adegeo

Hi @RedX2501 thank you for opening this issue. However, I don't see what you're referencing. Can you add some more information about what is missing and where specifically it's missing?

I see, i thought the linked pointed to the close API.
So i mean that this page https://learn.microsoft.com/en-us/dotnet/api/system.windows.window.close?view=windowsdesktop-8.0 about the close method on the window class
Is missing the information that ShowDialog will return false (and not null) when a dialog is closed via Close.

OK thank you for that clarification! I see what you're talking about. I'll look at getting an update in there. Thanks again!


caffemodel

Hi,as vpn service is shutdown,we can hardly access google.So can you share the pretrained caffemodel with us through pan.baidu.com or others?

you can check this repo to download the model: https://github.com/cdwat/MobileNet-Caffe

hi, I tried to train the model by the  deploy.prototxt . but it always take wrong ,can you share your trained document like train.prototxt ?

you can not train a model using deploy.prototxt. you can use most part of the deploy.prototxt and write your own train_val.prototxt.

yes, I know that .I had tried to write my own train_val.prototxt file. but it still get wrong. Maybe somewhere is wrong, so I want to can get your own train_val.prototxt file so that I can know where is wrong. Thanks
发自网易邮箱大师
On 9/4/2017<EMAIL_ADDRESS>wrote：
you can not train a model using deploy.prototxt. you can use most part of the deploy.prototxt and write your own train_val.prototxt.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@LiuRJun please make sure that you add params to control lr and wd for conv and scale layers.

yes, I do that
my own train_val.prototxt like this
name: "MOBILENET"
layer {
name: "data"
type: "Data"
top: "data"
top: "label"
include {
phase: TRAIN
}
transform_param {
scale: 0.017
mirror: false
crop_size: 224
mean_value: [103.94,116.78,123.68]
}
data_param {
source: "examples/myMobileNet/english_train_lmdb"
batch_size: 42
backend: LMDB
}
}
layer {
name: "data"
type: "Data"
top: "data"
top: "label"
include {
phase: TEST
}
transform_param {
scale: 0.017
mirror: false
crop_size: 224
mean_value: [103.94,116.78,123.68]
}
data_param {
source: "examples/myMobileNet/english_test_lmdb"
batch_size: 42
backend: LMDB
}
}
layer {
name: "conv1"
type: "Convolution"
bottom: "data"
top: "conv1"
param {
lr_mult: 1
decay_mult: 1
}
convolution_param {
num_output: 32
bias_term: false
pad: 1
kernel_size: 3
stride: 2
weight_filler {
type: "msra"
}
}
}
layer {
name: "conv1/bn"
type: "BatchNorm"
bottom: "conv1"
top: "conv1"
param {
lr_mult: 0
decay_mult: 0
}
param {
lr_mult: 0
decay_mult: 0
}
param {
lr_mult: 0
decay_mult: 0
}
}
......
and when I train the net, I got the wrong:
[libprotobuf ERROR google/protobuf/text_format.cc:245] Error parsing text-format caffe.NetParameter: 91:15: Message type "caffe.LayerParameter" has no field named "scale_param"
At 2017-09-04 17:24:38, "shicai"<EMAIL_ADDRESS>wrote:
@LiuRJun please make sure that you add params to control lr and wd for conv and scale layers.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

do you use the official caffe?
if yes, please check line 91 of your prototxt.

do i need to add a fc layer after the last conv layer when i write my own train.prototxt?

you dont need add a new layer, just change the name and num_output of the last conv layer.
of course, you can also remove the last conv layer, then add a new fc layer.

Hello Shicai,
I hope you are doing well, I wish to ask you how you can add params to control lr and wd for conv and scale layers?
Can you please show me one short example?
Thanks and regards,
Manu Goyal.

可以加你微信请教一下吗？？


MAVLink XML change to allow exponentiation operator in bitmask flag

FYI We're modifying the MAVLink XSD validation file in https://github.com/ArduPilot/pymavlink/pull/920 to allow a bitmask value to be declared using the Python exponentiation operator.
This makes it easier to immediately visualize which bit is set by a flag, because you can use the syntax
<entry value="2**15" name="BIT15" />

rather than
<entry value="32768" name=" BIT15" />

This is transparent to mavgen because the parser evaluates the number before creating the generated headers. However it may affect other parsers.
We're not updating the XML yet to allow other parsers time to update.
Any concerns, please raise on https://github.com/ArduPilot/pymavlink/pull/920

Hello Hamish, thanks for reporting the update and for taking into consideration the effects on this library.
I've updated the library and its unit tests in order to support all enum formats listed inside the PR you mentioned.

THanks @aler9 . As an aside, this has been and interesting exercise in working out which libraries are most active :-)


Preparing for NUnit 3: Switch from ExpectedException attribute to Ass…

Ok, here's a new pull request with just the commit to prepare for NUnit 3 which still is compatible with NUnit2.
I'll send a separate PR with XMLUnit.NUnit3.Constraints as soon as I've done this.

Ok - I've updated the PR. There's now a xmlunit-nunit2-contstraints for NUnit 2.6.4.
xmlunit-contstraints now uses NUnit 3.0.1. The tests for xmlunit-contstraints and xmlunit-core are done using nunit3-console.exe.
I tried to change as little as possible, but had to do some refactoring and linking to be able to share the tests for the nunit 2 and 3 projects.

Thanks!
I may need a few days to review things, but fully intend to merge this PR before cutting alpha-03.

Great! Take your time!

Thanks a lot.
I've renamed the constraints project to have NUnit 3 in its name, just to make things explicit.

Cool! And I have to thank you! Thanks to xmlunit.net all my pesky unit tests for xml output actually became readable :-)


Removed scrollbars by overflow

Hey umm I have never coded in python for backend, but I am a front-end developer
i noticed that the scrollbars were useless, so I decided to add overflow-hidden property to keep the ui clean and minimalist

nvm, i don't know why i asked u to do such a minor chore. LGTM!

sorry I accidentally used '' quotes haha TT


RASS-205 populate form during edit

I wonder if there's any scope to shift some of the business/validation logic from the router to the service class? we tend to have a lot of logic in the router classes but minimal code in the service classes


feat: storybook: adds storybook controls and documentation

SUMMARY:
feat: storybook: adds storybook controls and documentation
JIRA TASK (Eightfold Employees Only):
ENG-13963
CHANGE TYPE:

[ ] Bugfix Pull Request
[X] Feature Pull Request

TEST COVERAGE:

[X] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:
Verify the changes at:
https://eightfoldai.github.io/octuple.github.io/

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@a83bccc). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #147   +/-   ##
=======================================
  Coverage        ?   77.84%
=======================================
  Files           ?       64
  Lines           ?     1598
  Branches        ?      630
=======================================
  Hits            ?     1244
  Misses          ?      344
  Partials        ?       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83bccc...c200171. Read the comment docs.


Bypass SENTRY_ENVIRONMENT variable in order to send relevant value to Sentry.

Neon-proxy and neon-broker-storage charts were affected.

Haven't tired deploying, but looks ok.


Better errors

Per #814, this attempts to better recover from errors. I've confirmed with @robinheinze that this would have displayed somewhat better errors (still need https://github.com/infinitered/gluegun/issues/157 resolved for best errors).

@robinheinze Done.


Avoid marking columns in composite keys unique or primary.

Previously columns in a composite key (e.g. KEY
my_compound_key (columnA,columnB)) would have a composite key
generated for them but would also have each individual column marked
as unique; this obviously causes problems when trying to insert into the
table.
While fixing this, I noticed that the same issue would occur for primary
keys so I have also avoided marking these as primary if they are part of
a composite key.

I was unable to verify this issue. I checked out the commit right before your changes and created a model with a table with a compound index. Using the Doctrine2-Annotation exporter, the result was correct:
/**
 * MyBundle\Entity\CompositeTest
 *
 * @ORM\Entity(repositoryClass="CompositeTestRepository")
 * @ORM\Table(name="composite_test", indexes={@ORM\Index(name="my_compound_key", columns={"columnA", "columnB"})})
 */
class CompositeTest
{
    /**
     * @ORM\Column(type="integer")
     */
    protected $columnA;

    /**
     * @ORM\Column(type="integer")
     */
    protected $columnB;

If this issue still exists, we need further information on how to reproduce it.

I was unable to verify this issue. I checked out the commit right before your changes and created a model with a table with a compound index. Using the Doctrine2-Annotation exporter, the result was correct:
/**
 * MyBundle\Entity\CompositeTest
 *
 * @ORM\Entity(repositoryClass="CompositeTestRepository")
 * @ORM\Table(name="composite_test", indexes={@ORM\Index(name="my_compound_key", columns={"columnA", "columnB"})})
 */
class CompositeTest
{
    /**
     * @ORM\Column(type="integer")
     */
    protected $columnA;

    /**
     * @ORM\Column(type="integer")
     */
    protected $columnB;

If this issue still exists, we need further information on how to reproduce it.


Warn users not to tweak Chef::Config[:file_atomic_update] setting

people are actually doing this in order to work around issues with
writing /etc/hosts in docker containers.  they should seriously
stop doing it and fix this problem in the cookbooks.

@chef/client-core nobody should really be tweaking this variable, but people are, i kinda regret adding it now

Sighhhh :+1:

:+1:

:laughing: :+1:


Android build fails without app-settings.json

When I remove app-settings.json (as I don't need the interface), building on Android fails:
platforms/android/src/me/apla/cordova/AppPreferencesActivity.java:27:
error: cannot find symbol
addPreferencesFromResource(R.xml.apppreferences);

I found that it does work when I use an app-settings.json with an empty array in it ([]). It seems to have to do with the fact that it can't find the res/xml/apppreferences.xml file. Maybe the plugin should create that file even if there is no app-settings.json.
PS: seems related to #81

Seems like something is wrong with your setup:
$ ls -la app-settings.json
-rw-r--r--  1 apla  staff  447 Jul 10 22:16 app-settings.json
$ cordova build android --simulator
will push strings array {"name":"lang","titles":["English (US)","English (UK)"],"values":["en-us","en-gb"]}
android preferences file was successfully generated
ANDROID_HOME=/Applications/devel/android
JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_40.jdk/Contents/Home
…
BUILD SUCCESSFUL

Total time: 4.253 secs
Built the following apk(s):
	platforms/android/build/outputs/apk/android-debug.apk
$ rm app-settings.json
$ cordova build android --simulator
app-settings.json not found: skipping build
ANDROID_HOME=/Applications/devel/android
JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.7.0_40.jdk/Contents/Home
…
BUILD SUCCESSFUL

Total time: 1.877 secs
Built the following apk(s):
	platforms/android/build/outputs/apk/android-debug.apk

Try to install latest version

I got the same error pointed above.
It actually works, if you build once with a app-settings.json file and then remove the file and build after-wards. Try adding the plugin and removing the settings file directly after that and building afterwards. This fails for me.
I have a after_plugin_add hook in my config.xml, which removes the app-settings.json file because I have no other control over the build process. This seems to work on our build server (Cordova 5.4.1) but not on my local machine (Cordova 6.2.0).

Seems like AppPreferencesActivity.java not removed somehow. Very strange.


add website collection APIs

Pre-Flight checklist

[x] Migrations

[x] Migration is backwards-compatible with current production code

[x] Testing

[x] Code is tested
[x] Changes have been manually tested

What are the relevant tickets?
closes #344
closes #316
What's this PR do?
This adds APIs for creating and updated WebsiteCollections and also WebsiteCollectionItems. Together these allowing creating and naming collections and then adding websites to them, changing their order, and so on.
How should this be manually tested?
You can try things out at /api/collections and /api/collections/$ID/items. You should be able to do things like:

POST to /api/collections to create a new one
GET /api/collections/$ID to get info about a collection
PATCH or PUT to /api/collections/$ID to change description, title
GET /api/collections/$ID/items to get a list of items
POST to /api/colletctions/$ID/items to add an item to a collection (i.e. to create a new WebsiteCollectionItem)
PATCH or PUT to /api/collections/$COL_ID/items/$ITEM_ID to change position and so on

And you should also be able to DELETE things. I think that covers what is here.
One thing I am a little unsure about is the permissions. I implemented some new permissions classes to use with this, but as I am a little unfamiliar with how these work I thought they probably could use a close review.
I also added an owner field to the WebsiteCollection which is used to record who creates the object (or, well, I guess it could be changed later too if we wanted someone else to own a given collection).

Codecov Report

Merging #349 (14cc26f) into master (9ce3077) will increase coverage by 4.89%.
The diff coverage is n/a.

:exclamation: Current head 14cc26f differs from pull request most recent head 8b6bc69. Consider uploading reports for the commit 8b6bc69 to get more accurate results

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   88.64%   93.54%   +4.89%
==========================================
  Files         123       60      -63
  Lines        3805     1378    -2427
  Branches      572      302     -270
==========================================
- Hits         3373     1289    -2084
+ Misses        392       88     -304
+ Partials       40        1      -39

Impacted Files
Coverage Δ

main/urls.py

content_sync/models.py

websites/site_config_api.py

main/constants.py

conftest.py

users/admin.py

main/apps.py

ocw_import/api.py

main/s3_utils.py

main/__init__.py

... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce3077...8b6bc69. Read the comment docs.

@mbertrand ok I added a test, lmk what you think


QA: prevent double comment by the bot

The bot should edit the appropriate response comment for the comment/command edited by the user.

TEST
I am first time commenter. I will edit this message but bot should not reply me twice.

TEST
I will post /help, then edit it to /wallet 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2 and bot should edit its previous response instead of posting a new response.

/help

/wallet 0x1F9FCc0E84dc2094499b848AE37Cd6a51db03Ff2


Support for layered masters?

As a developer, I frequently switch from my ticket board, to my IDE, and a separate browser as master windows. I then have Slack, docs, and other misc windows as slaves. This requires me to move the IDE/browser/etc into the master area to switch between them. What would be nice is a way to set a config value to allow N number of windows as masters (as in, occupying the same rectangle, not split space between them and shown simultaneously, which is already supported), and I can use my WM's panel to switch between them quicker than dragging them around.

I will check if this can be added to some later release.


The first byte of the proxy settings binary was '60' but should have been 0x46.

Problem description
Received Error:
The first byte of the proxy settings binary was '60' but should have been 0x46.
But DefaultConnectionSettings and SavedLegacySettings is a completely fresh entry

Verbose logs
AUSFÜHRLICH: [xxx]:                            [[ProxySettings]ManualProxy] Test-TargetResource: Checking the CurrentUser proxy settings to ensure 'Present'.
AUSFÜHRLICH: [xxx]:                            [[ProxySettings]ManualProxy] Test-TargetResource: Checking that the CurrentUser proxy settings 'DefaultConnectionSettings' are in the desired state.
AUSFÜHRLICH: [xxx]: LCM:  [ BeendenTesten   ]  [[ProxySettings]ManualProxy]  in 0.1750 Sekunden.
 Fehlermeldung: "System.InvalidOperationException: The first byte of the proxy settings binary was '60' but should have been 0x46."
    + CategoryInfo          : InvalidOperation: (:) [], CimException
    + FullyQualifiedErrorId : ProviderOperationExecutionFailure
    + PSComputerName        : xxx

DSC configuration
ProxySettings ManualProxy
        {
            Target = 'CurrentUser'
            Ensure = 'Present'
            EnableAutoDetection = $false
            EnableAutoConfiguration = $false
            EnableManualProxy = $true
            ProxyServer = 'proxy.xxx.local:3128'
            ProxyServerExceptions = '*.xxx.local', '*.e-xxx.de', '*.xx.xxxx.de'
            ProxyServerBypassLocal = $true
        }

Suggested solution
Allow updating the proxy settings
Operating system the target node is running
OsName               : Microsoft Windows 10 Pro
OsOperatingSystemSKU : 48
OsArchitecture       : 64-Bit
WindowsVersion       : 2009
WindowsBuildLabEx    : 19041.1.amd64fre.vb_release.191206-1406
OsLanguage           : de-DE
OsMuiLanguages       : {de-DE}

PowerShell version and build the target node is running
Name                           Value
----                           -----
PSVersion                      5.1.19041.3031
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.3031
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

NetworkingDsc version
NetworkingDsc 9.0.0   C:\Program Files\WindowsPowerShell\Modules\NetworkingDsc\9.0.0\NetworkingDsc.psd1

Hint for some reason it was reading the
Computer\HKEY_USERS.DEFAULT\Software\Microsoft\Windows\CurrentVersion\Internet Settings\Connections
instead of CurrentUser


Memory leak program on big Youtube playlist

When I download big playlist (more than 500 videos) from Youtube with --datebefore (may be and without datebefore), on Debian 8 machine, youtube-dl have leak memory - full 4G RAM is occupied by the youtube-dl. And PC is frozen afret ~450 skipped videos
/usr/local/bin/youtube-dl -v -ci -x --audio-format mp3 --audio-quality 128K --datebefore 20170329 -o '%(upload_date)s-%(uploader)s-%(title)s-%(id)s.%(ext)s' https://www.youtube.com/channel/UCTwUWzrI3iAxQwzbj5yJsvw/videos
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'-ci', u'-x', u'--audio-format', u'mp3', u'--audio-quality', u'128K', u'--datebefore', u'20170329', u'-o', u'%(upload_date)s-%(uploader)s-%(title)s-%(id)s.%(ext)s', u'https://www.youtube.com/channel/UCTwUWzrI3iAxQwzbj5yJsvw/videos']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 2.7.9 - Linux-3.16.0-4-amd64-x86_64-with-debian-8.9
[debug] exe versions: ffmpeg 2.6.9, ffprobe 2.6.9
[debug] Proxy map: {}
[youtube:channel] UCTwUWzrI3iAxQwzbj5yJsvw: Downloading channel page
[youtube:playlist] UUTwUWzrI3iAxQwzbj5yJsvw: Downloading webpage
[download] Downloading playlist: Uploads from БМ Знания
[youtube:playlist] UUTwUWzrI3iAxQwzbj5yJsvw: Downloading page #1
[youtube:playlist] UUTwUWzrI3iAxQwzbj5yJsvw: Downloading page #2
[youtube:playlist] UUTwUWzrI3iAxQwzbj5yJsvw: Downloading page #3
[youtube:playlist] UUTwUWzrI3iAxQwzbj5yJsvw: Downloading page #4
[youtube:playlist] UUTwUWzrI3iAxQwzbj5yJsvw: Downloading page #5
[youtube:playlist] playlist Uploads from БМ Знания: Downloading 545 videos
[download] Downloading video 1 of 545
[youtube] F0Ldm10xbn4: Downloading webpage
[youtube] F0Ldm10xbn4: Downloading video info webpage
[youtube] F0Ldm10xbn4: Extracting video information
[youtube] F0Ldm10xbn4: Downloading MPD manifest
[youtube] F0Ldm10xbn4: Downloading MPD manifest
[download] 2017-08-01 upload date is not in range 0001-01-01 - 2017-03-29
[download] Downloading video 2 of 545
[youtube] x1ryKOZU0DY: Downloading webpage
[youtube] x1ryKOZU0DY: Downloading video info webpage
[youtube] x1ryKOZU0DY: Extracting video information
[youtube] x1ryKOZU0DY: Downloading MPD manifest
[youtube] x1ryKOZU0DY: Downloading MPD manifest
[download] 2017-08-01 upload date is not in range 0001-01-01 - 2017-03-29
[download] Downloading video 3 of 545
[youtube] AWXrhlPMvFM: Downloading webpage
^C
ERROR: Interrupted by user

With download we also see same
...
[download] Downloading video 369 of 550
[youtube] fl5C8LIR1Zk: Downloading webpage
[youtube] fl5C8LIR1Zk: Downloading video info webpage
[youtube] fl5C8LIR1Zk: Extracting video information
[youtube] fl5C8LIR1Zk: Downloading MPD manifest
[youtube] fl5C8LIR1Zk: Downloading MPD manifest
[dashsegments] Total fragments: 393
[download] Destination: 20170424-БМ Знания-Строим Самолёт. Учеба в Бизнес Молодости. Работа в команде. «Любой может стать любым» [БМ]-fl5C8LIR1Zk.m4a
[download] 100% of 29.67MiB in 00:37
WARNING: fl5C8LIR1Zk: writing DASH m4a. Only some players support this container. Install ffmpeg or avconv to fix this automatically.
ERROR: WARNING: unable to obtain file audio codec with ffprobe
...

But my ffpeg can convert m4a

There is no memory leak. High memory consumption is due to lost of DASH segments formats that carry fragments metafield. fragments metafield may be quite heavy (ranging from 0.5 to 15 MiB per video) since it contains a list of all fragments of a DASH video. Due to a high number of such videos collected metadata grows.
You can use --playlist-start and --playlist-end to process playlist in parts.

https://github.com/ytdl-org/youtube-dl/blob/7c24a58bdb60af80137beac85c8804c70194a455/youtube_dl/YoutubeDL.py#L1007 is responsible for sometimes retaining > 2.5GB of objects when downloading very long playlists


Upgrade to Django 1.9 (update PR #2435)

This updates #2435, which seems to have disappeared.
Things still needed to do:

[x] Run local tests to make sure things work in real builds

Ran a few local builds, and things look good

Running into an issue with the build state not updating correctly. Looking into it.

Got it working. total_seconds() was returning a non-int, which broke the API :)

Calling this Ready for Review -- it is passing on local builds, and looks good on my side.

@agjohnson I was doing all my conda debugging and other local dev on this branch yesterday, and it seemed to be working fine. I'm not sure if it will get any real testing until we push it to production, so I'm not sure what we really gain from not merging it. Are you thinking about hotfixing it into prod and keeping it off master?

Ah, you're suggesting merging it into a dev branch for a couple weeks, and doing mainline dev in there, to work out the kinks?

Okay, yeah that's fine. I don't have a strong opinion here either. We don't have a good pattern for this, and yeah, the most testing will come with prod deploy.

 Going to merge this and get it deployed today. 🎆
Thanks to @travcunn for the original patch!


Feature/eslint

problem statement

linting is a little out-of-date!

solution

address #11
add git-validate, which installs a generic git pre-commit hook

add pre-commit tasks in package.json, particularly the "lint" task
remove the old pre-commit script

make files comply with new .eslintrc.js

discussion
i'd really like a "zero configuration" eslint setting, in that regard we never debate or discuss opinions on rules.  but arrrg, no-unused-vars was really killin me!  if we're all cool with this, just as it stands, great, we can use it and not make a fuss.  or, if someone wants to try another standard, no-sweat!

@cdaringe how did you commit without the tests passing? Isn't the pre-commit hook supposed to catch that?

@paulcpederson, because i didn't realize i needed to update the .travis.yml too.  bumping...

word

Why change the travis config to npm run lint instead of just updating the make lint target?  At the very least I would remove the now-dead make lint, but IMO it should stay in place and get updated.  If you like being able to npm run lint you can also just pass that through to make lint once updated.
Full disclosure: I am somewhat obsessed with GNU Make, it's one of my favorite tools.

@cdaringe I think I agree with @Lochlan on that. I'd leave make lint and update it to run the new linter (https://github.com/node-swig/swig/blob/master/Makefile#L90). Then you could just do:
"scripts": {
  "lint": "make lint"
}

There is quite a bit of stuff in the Makefile and unless we wanted to do away with Make entirely, it would be cleaner to keep all the tasks run through make IMO.

Also, I had a question, does this maintain linting for indentation/punctuation errors?

Why change the travis config to npm run lint instead of just updating the make lint target?

i want to run the lint task automatically on pre-commit s.t. all contributors don't forget to lint their code manually. i could surely use the make command, but

it's extra overhead (i.e. runs an extra child process vs running the eslint directly), and
adds an extra level of indirection

runs a command purely as a proxy to another command npm => make => eslint vs just npm => eslint
npm scripts are already acting as a task runner--why sustain a redundant secondary task runner?

I am somewhat obsessed with GNU Make, it's one of my favorite tools

make is great, but IMHO it's not friendly or common in the js community. if this were a C++ library, id say rock on, but using js standards in a js lib seems kind of like an "of course" sort of thing to me.  i would lobby that make is not as friendly to new contributors.
it's sort of bikeshedding in the grand scheme of things. anyway, hopefully we can come to resolution

I appreciate that argument, that it's not node-like. If we go ahead with moving towards npm scripts we should clean up the stuff we don't need the Makefile to do now, though. Like remove https://github.com/node-swig/swig/blob/master/Makefile#L88 through line 92.
Also you could remove the githooks stuff here https://github.com/node-swig/swig/blob/master/Makefile#L16 right?

if this were a C++ library, id say rock on

Yes, Make is essentially designed for C and C++, but ultimately it is a declarative language for describing the relationships between files.  And it comes out of the box on pretty much every unix/linux machine!

i would lobby that make is not as friendly to new contributors.

Makefiles can be arcane, but generally recipes contain a lot of straightforward shell commands.  That's one of the things I love about Make, is its accessibility on the low end.

using common js practices in a js lib seems kind of like an "of course" sort of thing to me.

I certainly agree with you here in the sense that using JS build tools is the most common practice, though I don't think that conforming to common practices is always necessary or beneficial.
Despite my gushy love of Make, I'm not actually opposed to using a JS build tool.  I agree with @paulcpederson re: "I appreciate that argument, that it's not node-like."

npm scripts are already acting as a task runner--why sustain a redundant secondary task runner?

Because where we are today is that we already have the makefile.  As @paulcpederson said:

There is quite a bit of stuff in the Makefile and unless we wanted to do away with Make entirely, it would be cleaner to keep all the tasks run through make IMO.

I'm very leery of moving to a state where we have some parts of our build inside the makefile and some outside.  And I'm definitely not wanting to leave in dead recipes in the makefile.  Perhaps there can be a separate issue and PR for discussing a new build tool?  At this exact moment in time, and for the actual scope of this work (moving to a new linter), I would prefer to just update the make lint recipe and keep things simple.
I definitely think the makefile as-is has problems and we should consider some alternative/improvement to what exists currently.

I also want to state that this is merely my preference, and that I consider moving the lint target out of the makefile a pretty minor thing.  I would not want this trend to continue, however, unless/until moving to a new build tool.

Yeah this gets my +1. Let's open a new issue to discuss the build tool and get this merged.

nice work @cdaringe :+1:

restored to make.  should have had that discussion before starting a change.  best to do it all at once if at all!  i originally didn't consider it scope creep as we already sorta-kinda use both, but that's arguably grey!
hopefully travis get's its act together and gives us green soon and we can call this one done!

@cdaringe Thank you for making these most recent changes, I really appreciate it.  And I'm greatly looking forward to improving our build, it definitely needs some attention!
Since it looks like we've reached consensus on this PR I'm going to go ahead and merge this in.


Support for Map

Add test cases and minor fixes to existing map impl.
Test cases are based on the ones from Immutable.js with some extras around types. All test cases currently passing but didn't have to do much (eg. no custom implementation of map() like in  List). Not sure if I'm missing something but seems to do what's expected currently - let me know if there's anything I've missed.
Resolves #9

Any chance you would have time to look at this sometime soon?
Are you looking for help maintaining this project? I'd be happy to help out however I can

Thanks for the implementation.

Is there any chance of this being merged? I also would like to use it.

Unfortunately I am no longer able to maintain this project, I apologize. If someone wishes to step up and take leadership of this project please respond to #21

@davecoates asked in #21 for a review of this pull request. I wanted to mention that I have been using it in production for a month now, and it works. :-)

👍
I feel weird hitting the button on this, is everyone ok with it? Looking at you @udnisap?

I have realised there's one problem with this - the way it handles map. Currently it will throw an error if you return anything other than the type specified whereas it should probably do what List does and return a new typed map based on what you return.
eg. if it was a Map(number, Record({id: Number})) and you did instance.map(record => record.id) the return type would be Map(number, number)
I'll hopefully look at this soon

@davecoates I think I understand what you're saying, that the .map in your comment would error, if that's the case I think we should merge this because I would expect that to error anyway. If you want to play with it some more we can leave this open, but I want to release a new minor version soon.

Sure, happy to continue looking into this as a separate request.
Regarding map - it's more to be consistent with the behaviour of lists, see https://github.com/typed-immutable/typed-immutable#mapping-lists-form-one-type-to-other

I misinterpreted your comment, I see what you're saying. It looks like there's something going on with the TypeInferer that you might be able to abstract out.
Speaking of the readme, there is one huge thing this is missing -- documentation. Just stating that it exists would be a huge win.

Ah yes, forgot about readme! I've updated it now basic overview of it.

@davecoates Can you push a trivial change to this branch so Travis can pick it up?

👍

@davecoates Sorry, one more thing. You need to merge the latest changes from master into your branch. As soon as you have done that, I will merge.

sorry that was my bad, I had rebased but neglected to do it from upstream

:tada:


Improve interface for retrieving authentication sessions

Is your feature request related to a problem? Please describe.
The recent issue #680 highlighted an ambiguity around the AzureSessionProvider interfaces.
Specifically, it is unclear whether the selectedTenant property is necessarily accessible without further user interaction. Internally (within the AzureSessionProviderImpl class) we try to ensure that it is immediately accessible. That means we can return a ReadyAzureSessionProvider with that property populated, and be reasonably sure it can be used immediately, without the user being directed away to a browser authentication tab.
The problem here arises from the fact that the selectedTenant property serves two purposes: to represent the user's selected tenant AND to indicate they are fully authenticated.
Additionally, the parameters for getAuthSession do not allow for specifying additional/different scopes. These are needed in two scenarios:

When using a graph client (or any client for endpoints other than ARM).
When specifying an Entra ID application other than the default VS Code one (which doesn't have delegated permissions for some graph-related requests relating to managing applications and service principals).

Describe the solution you'd like
I think there are two possible ways to resolve the ambiguity of the selectedTenant property:

Give up on the idea that 'ready' means 'no further user interaction', and instead interpret it as 'user is signed in and has selected a tenant, but further authentication may be required to access that tenant'.
Add an extra property (perhaps on the Tenant type) to indicate whether the user is fully signed in to the selected tenant.

The first option is technically simpler and so it makes sense to try that first. If it degrades the user experience somehow, we can use that as justification for the more complex option.
For the getAuthSession parameters, I'd like to make a change similar to that discussed here:
export type GetAuthSessionParams {
    tenantId: string;
    applicationClientId?: string;
    scopes?: string[];
}

It's uncertain whether a similar AzureSessionProvider class will make it into the azuretools library.
In case that does go ahead, it might make sense to adhere to the structure proposed there, so that we can swap the implementation at a later date with minimal refactoring.
That would entail separating the session provider from the tenant selection logic, which are currently bound together in our implementation. This is arguably worthwhile in its own right, and could serve as a model for the 2-3 other extensions which might want an abstraction over the VS Code API, but not necessarily the same tenant selection logic as us.

Resolved by #695


update h#

What does this PR do and why?
Provide a description of what this PR does. Link to any relevant GitHub issues, Notion tasks or Discord discussions.
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] (if relevant) I have tested this PR in all supported browsers.
[ ] (if relevant) I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #3359

PR #3360   👈

This comment was auto-generated by Graphite.

@wraeth-eth queued this pull request to merge with Graphite.

@wraeth-eth merged this pull request with Graphite.


Java: Improve precision of java/unchecked-cast-in-equals

As discussed on slack. See https://lgtm.com/query/6961820689409815191/ for a comparison of the 3 versions.

For reference, this addresses https://discuss.lgtm.com/t/false-positive-equals-does-not-check-argument-type/2121


can't connect to the site - connection refused

I know it's old problem..
MBP-Vitaly:dock dyatlov$ fig ps
Name             Command             State              Ports
dock_db_1          /docker-           Up                 <IP_ADDRESS>:49157->5
entrypoint.sh                         432/tcp
postgres
dock_web_1         bundle exec        Up                 <IP_ADDRESS>:3000->30
rackup -p 3000                        00/tcp
MBP-Vitaly:dock dyatlov$ boot2docker ip
<IP_ADDRESS>
MBP-Vitaly:dock dyatlov$ fig port web 3000
<IP_ADDRESS>:3000
MBP-Vitaly:dock dyatlov$ curl <IP_ADDRESS>:3000
curl: (7) Failed to connect to <IP_ADDRESS> port 3000: Connection refused
Im running latest virtual box and latest boot2docker (installed just 2day)
any idea how to solve this without virtual box cli and port forwarding?

to add, I tried to use it as described here: http://viget.com/extend/how-to-use-docker-on-os-x-the-missing-guide
but it seems that behavior changed since then?

rails was listening to localhost, solved this by adding -b <IP_ADDRESS> to the start command: bundle exec rails s -b <IP_ADDRESS>
now all is working. Sorry for false alarm

Whoa this needs more attention!

@dyatlov thanks so much. I feel silly for not thinking of that earlier :/


Support querying guardduty of partition 'aws-cn' in session

Describe the bug
cn-north-1 and cn-northwest-1 regions are not available when querying regions for service 'guardduty' for 'aws-cn':
>>> import botocore.session
>>> session = botocore.session.Session(profile = 'default')
>>> session.get_available_partitions()
['aws', 'aws-cn', 'aws-us-gov', 'aws-iso', 'aws-iso-b']
>>> session.get_available_regions('guardduty', 'aws-cn')
[]
>>> session.get_available_regions('guardduty', 'aws')
['ap-east-1', 'ap-northeast-1', 'ap-northeast-2', 'ap-south-1', 'ap-southeast-1', 'ap-southeast-2', 'ca-central-1', 'eu-central-1', 'eu-north-1', 'eu-west-1', 'eu-west-2', 'eu-west-3', 'me-south-1', 'sa-east-1', 'us-east-1', 'us-east-2', 'us-west-1', 'us-west-2']

Expected Behavior
session.get_available_regions('guardduty', 'aws-cn')
['cn-north-1', 'cn-northwest-1']

Current Behavior
session.get_available_regions('guardduty', 'aws-cn')
[]

Reproduction Steps
session.get_available_regions('guardduty', 'aws-cn')
Possible Solution
No response
Additional Information/Context
No response
SDK version used

Environment details (OS name and version, etc.)
python3.6, boto3==1.11.9 botocore==1.14.9

Hi @Zpa48 thanks for reaching out. It looks like you're using a very old version of boto3, but even with a newer version the response may not be up to date.
We have a tracking issue related to this: https://github.com/aws/aws-sdk/issues/206. I will follow up there and try to find out what needs to happen in order to fix this. Please let us know if you had any further questions and refer to that issue for updates going forward.


NOT READY (willbe): add readme.headers.generate command

Add new command ( aggregation of readme.modules.headers.generate &  readmde.header.generate )

@SRetip get completed

what is with this? @SRetip

what is with this? @SRetip
I can't complete this


fix: properly format jwtkey prior to file save

@W-8856585@ Add function to format a jwt key before saving the key data to a file.

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d836df8). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage        ?   68.55%
=======================================
  Files           ?        6
  Lines           ?      318
  Branches        ?       59
=======================================
  Hits            ?      218
  Misses          ?       75
  Partials        ?       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d836df8...c6045d3. Read the comment docs.


Add scoverage aggregator and fail on low coverage.

Small Scoverage update --> sets aggregate to true, which produces a report under ${ADAM_HOME}/target at the end of the build containing the aggregated coverage across all submodules.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1499/
Test PASSed.

Merged as commit d914ee4aa023440ff52cef9dd72daa5ea47ed558.
Thank you, @fnothaft!


header_rewrite: handle multi-value headers

As of ATS 7.1, header_rewrite handles 1 multi-value header -- cookie:

rm-cookie
add-cookie

and the documentation indicates other "Repeated Headers -- Some headers may appear more than once in a request or a response. When this occurs, all values will be collapsed into a single comma-delimited string before the conditions see them."
it would be nice to generalize the cookie options to other multi-value headers. For instance, most CDNs do not allow the origin to specify Vary: user-agent. But, this isn't really implementable by header_rewrite, as it could be Vary: User-agent, Cookie -- the current semantics wouldn't allow for deleting the User-agent but keeping other values.

@mlibbey Do we want to work on / fix this ?


Notifications don't close even with closeable set.

Note: for support questions, please use stackoverflow. This repository's issues are reserved for feature requests and bug reports.

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, see note at the top of this template.

Do you want to request a feature or report a bug?
Bug

What is the current behavior?
Notifications do not close or send an event with closeable.  This does not currently work on the demo either.

If the current behavior is a bug, please provide the steps to reproduce, ideally also a screenshot or gif if it's a style issue

Go to the notifications demo page and try to close one.

What is the expected behavior?

It should close on clicking the x.

Not sure what's the status here.
Expect to be not done.

Fixed. Now correctly emits @input false.
Fixes will be up for vuestic admin 2.1.


Block Launcher intel

Please help me my Block Launcher does not open my device is Intel (DL x-pro) and the following message when I open the app: Unfortunately the version of Minecraft PE in this device is not compatibile whit BlockLauncher.Please install  Minecraft PE for intel processors.

Install MCPE from the Play Store.

But I already have the MCPE the play store.

Oh, never mind I've got :)

How did I do it? I gt the same problem

Lancego is very easy guy is just you download the MCPE the Play Store :)

Lancego is very easy guy is just you download the MCPE of Aptoide :)

hey i have windows 10 and im running xeplayer android emulator i bought minecraft pe through google play and i downloaded block launcher and it says its no compatable that i have to get minecraft pe that uses arm processor what do i do help please


Could not remove or logout in terminal,but it can add app

it's always tip about "[Error]  read ECONNRESET" when I run "code-push logout" or "code-push remove app xxx".
But it can works about "code-push app add xxx"


Missing NetworkVersion

Mod Version 1.1.3
Vintage Story Version 1.19.1
modinfo.json is missing NetworkVersion value causing a download loop when in use on servers. Players are stuck being asked to download from the ModDB when it cannot determine the version.
This can be fixed by adding the NetworkVersion value like so below:
"NetworkVersion": "1.1.3"

Thank you for reporting this, the issue should now be fixed!


fix nested props conflicts

[Current coverage][cc-pull] is 100%

Merging [#6][cc-pull] into [master][cc-base-branch] will not change coverage

@@           master    #6   diff @@
===================================
  Files           1     3     +2
  Lines          15    55    +40
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
+ Hits           15    55    +40
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last updated by [431afcd...80bf9a4][cc-compare]
[cc-base-branch]: https://codecov.io/gh/borovin/createClass/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/borovin/createClass/compare/431afcda8944118a9dd96664dc1e7916e2b03f10...80bf9a4086c377adb1d3727283fffb6d09fc89b8?src=pr
[cc-pull]: https://codecov.io/gh/borovin/createClass/pull/6?src=pr


  Below, "accurate" is repeated.

Hey @notuntoward,
Sorry for the delay in getting back to you on this. Things have been a little hectic.
We've just released Harper v0.13.0, which incorporates some significant improvements to this rule, thanks to @grantlemons.
Would you mind testing to make sure you don't get any more false-negatives like this so we can close issue?

@elijah-potter , Thanks.  Unfortunately, it still doesn't work for me in this example:

this paper shows that, while the method may be more accurate accurate, the turnout overestimate suggests that self-selection bias is not sufficiently reduced.

"accurate" is typed twice but the repetition isn't detected.
But I should note that I had difficulties updating -- the install procedure stalled on Harper.  When I restarted obsidian, then I got a message saying something like "Harper cannot be restarted," After uninstall and then reinstall, Harper did restart, and appeared to be the newest version (1.3.0).  But maybe it's not, really?

Ah, the obsidian plugin seemed to have had a large problem on 0.13.0 (#338), but @elijah-potter has pushed out 0.14.0 which should hopefully resolve the issue.
In my local tests I found that harper linted your example correctly, so if you update the obsidian plugin to the 0.14.0 version, it will probably work as intended.


Compatibility with Thunderbird 57?

My Thunderbird just updated to version 57beta1 (I have generally been running on the beta release channel) and Nostalgy seems to have stopped working. Can anyone verify whether or not Nostalgy should work with Thunderbird 57? If it is not currently working with Thunderbird 57, what are the prospects for it being enhanced to work with that version?  Thanks so much, it is a wonderful add-on.

There exists already a patch, which looks like fixing this problem:
https://github.com/oeekker/nostalgy/commit/9d1ddfebeb8186f25d98134d6c6b54cec7e1cdbd

Nostalgy 0.2.35 fixed this compatibility problem, but it has struck again with Thunderbird 60, so I opened #46 for that; closing this one.


check_lastest_version doesn't work on arm macs

Seems like latest version still has check for x86_64 targets.
https://github.com/nathanbabcock/ffmpeg-sidecar/blob/c4dff09800dcbe503eca99a01a0272380c99d31d/src/download.rs#L19-L23

Hi there, you are correct, and the reason check_latest_version doesn't work for ARM is because the website we use as a source (https://www.osxexperts.net/) does not list a simple text endpoint that displays the latest version number. Short of scraping and parsing the HTML of the webpage there is no easy way of determining it. The other providers have something very convenient like this. (Unless you happen to know of an endpoint I am overlooking).
I'll change this function to return the same version number as what would be provided by the ffmpeg_download_url function (which also has to be manually updated).
I just updated the CI pipelines for Mac M1 in this PR: https://github.com/nathanbabcock/ffmpeg-sidecar/pull/37. So everything appears to be in working order. In the future I might want to revisit  this whole auto download functionality (and #19) as it's proving to be very brittle over time.


Implement Merge Sort in Java

The code should go inside classical_algorithms

Hey can you assign this to me please?

sure @adenashameem !

PR sent. Please review.


fix bug in cldr calculation

fixes bugs in Locale CLDR output (locale data can be inherited)

Merging, thank you @johnspackman


Incorrect conversion of numbered list

Described this issue here
Basically, I have a numbered list with some markdown using back ticks in between each item, seen here.
When showdown renders the list, each line begins with a 1. rather than displaying in order.

You need to indent subblocks 4 spaces

TL;DR;
It's not a bug in showdown, but rather a problem the the input. List's Sub-blocks must be indented 4 spaces (or they will be treated as a "root block")
Explanation
A bunch of things are happening here:
List's Sub-blocks must be indented 4 spaces
According to the original markdown spec a sub-block, in a list, must be indented to be considered part of the list.
Example: (see showdown's live demo)
input MD:
1. Does every software system have an architecture?  Why or why not?

    ```
    _________________________________________________________________________
    _________________________________________________________________________
    ```

2.   Why or why not?

_________________________________________________________________________
_________________________________________________________________________

You are designing a climate control system, which accepts inputs from a variety...

_________________________________________________________________________
_________________________________________________________________________

In your md source, your code blocks are not indented so each list item is interpreted as  "new" list. see demo
This happens in every markdown implementation, even in github's implementation. ([see babelmark2 for comparison in implementations][bb2_1])

Does every software system...

_____________________________________________________________

You are designing a climate control system...

The numbering in lists is not important
According to the same spec:

It’s important to note that the actual numbers you use to mark the list have no effect on the HTML output Markdown produces. (...)
The point is, if you want to, you can use ordinal numbers in your ordered Markdown lists, so that the numbers in your source match the numbers in your published HTML. But if you want to be lazy, you don’t have to.

Your input "seems" to work in github's
The issue, however, arises when you consider the next paragraph the spec:

If you do use lazy list numbering, however, you should still start the list with the number 1. At some point in the future, Markdown may support starting ordered lists at an arbitrary number.

Github supports this "planned feature" where the number you in the first list item counts as the starting value of the ordered list. For instance, copy/paste the following markdown in a comment here in github and click preview:
Input:
2. foo
6. bar
2. baz
9. bazinga

Output:

foo
bar
baz
bazinga

This feature is non standard and not implemented in showdown (although it's planned for a soonish future release),
So, in your MD, every list item is considered a new list, rather than a list item. But since github supports defining the starting number of ordered lists, the output seems correct (although it's not)
[bb2_1]: https://johnmacfarlane.net/babelmark2/?normalize=1&text=1.+Does+every+software+system+have+an+architecture%3F++Why+or+why+not%3F

```
________________________________________________________________________

```

2.+You+are+designing+a+climate+control+system%2C+which+accepts+inputs+from+a+variety+of+distributed+sensors+(e.g.%2C%0AOf+the+architectural+styles+listed+in+Tsui+et+al%2C+which+one+would+be+best+for+this+kind+of+system%3F++Why%3F%0A%0A%60%60%60%0A________________________________________________________________________%0A%0A________________________________________________________________________%0A%60%60%60

Ah I see, thanks for the clarification.


Use regex to validate account_id or zone_id are valid hex

🐛 Bug Report

Environment

operating system: WSL (Linux) on Windows 10
output of rustc -V:

Command 'rustc' not found, but can be installed with:

sudo apt install rustc

output of node -v: v14.13.1
output of wrangler -V: 👷 ✨  wrangler 1.11.0
contents of wrangler.toml

name = "andrew-app"
type = "webpack"
account_id = "<REDACTED-EMAIL>"
workers_dev = true

Steps to reproduce

Obtain global API key
Run wrangler config
Output of 2:

💁  Validating credentials...
✨  Successfully configured. You can find your configuration file at: /home/andrew/.wrangler/config/default.toml

Run wrangler publish

What did you expect to see?
Successful build, go to andrew-yang.workers.dev and see a static site I loaded through workers
What did you see instead?
After running 3, I see
✨  Built successfully, built project size is 1004 bytes.
Error: Something went wrong! Status: 400 Bad Request, Details {"success":false,"errors":[{"code":7003,"message":"Could not route to \/accounts\/<REDACTED-EMAIL>\/workers\/scripts\/andrew-app, perhaps your object identifier is invalid?"},{"code":7000,"message":"No route for that URI"}],"messages":[],"result":null}

I've updated this issue to reflect the problem, wrangler should probably validate that your account_id is in a valid form (and not an email)

Thanks for the support, I've used the correct account_id now


[web] Encode AssetManifest.bin as JSON and use that on the web.

This PR modifies the web build slightly to create an AssetManifest.json, that is a JSON(base64)-encoded version of the AssetManifest.bin file.
(This should enable all browsers to download the file without any interference, and all servers to serve it with the correct headers.)
It also modifies Flutter's AssetManifest class so it loads and uses said file if (kIsWeb).
Issues

Fixes https://github.com/flutter/flutter/issues/124883

Tests

Unit tests added.
Some tests that run on the Web needed to be informed of the new filename, but their behavior didn't have to change (binary contents are the same across all platforms).
I've deployed a test app, so users affected by the BIN issue may take a look at the PR in action:

https://dit-tests.web.app

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

base64 decoding is pretty slow. Have you benchmarked this versus the new binary for and/or the old JSON format?

Have you benchmarked this versus the new binary for and/or the old JSON format?

@jonahwilliams Nope, do those benchmarks exist or do they need to be written?

See https://github.com/flutter/flutter/blob/master/dev/benchmarks/microbenchmarks/lib/foundation/decode_and_parse_asset_manifest.dart

This change will also still require us to make an additional network requst before any assets can be downloaded.

@jonahwilliams @yjbanov
I took the microbenchmark that Jonah suggested here (thanks!), and modified it slightly to run on the web.
I had to:

Add a web/index.html (I actually did flutter create --platform web .)
Changed the number of iterations from 1000 to 10000 (with 1k, each time I refreshed the benchmark, master would be even faster, so I assumed this was the browser warming up. I raised the number of iterations to try to give a chance to all benchmarks to be "similarly warm" without having to run them several times).

I ran the benchmark in master and the 2 PRs. I ran each example like this:
refresh-tools && flutter clean && flutter run -d web-server --target lib/foundation/decode_and_parse_asset_manifest.dart --web-port 7357 --release

(refresh-tools is a small command that I have to delete the flutter_tools cache, to ensure that changes actually work)
Here's the results after 10k iterations:

master
#130419
#131382 (this)

57078ms
58278ms
59956ms

I only ran each microbenchmark once in my gLinux machine, so I take the numbers with a healthy amount of skepticism. Squinting a little bit, we could say that "this" is 2878ms slower than master, so I guess downloading a ~30% larger file and json-base64-decoding it incurs in an (average(, not the best for benchmarks)) ~0.3ms penalty.
It also seems that #130419 is still downloading the AssetManifest.bin on the web, which is hurting it badly in this benchmark, I expected it to wipe the floor with the other two branches (I don't know exactly if I messed up here, but it seems that the global window array is being set, so changes are being applied. I can also take a look there and see what's up.)

FYI @andrewkolos maybe you can help out with the benchmark issue here? Do we need to use a different method to load and parse the manifest?

Thanks for benchmarking this, @ditman! Looks like there's no material performance difference between these approaches. If so, I'd say let's go with the simplest solution.

@yjbanov Andrew's PR should be much, much faster, I'm shaving that yak now to find why is it downloading the manifest (when it's set in the DOM already)

I pushed a fix to @andrewkolos' PR, and NOW it's chugging!

11ms for 10k iterations of parsing the manifest (now that the bytes are getting inlined, there's not much work to do for the loader, other than juggling the bytes coming from the JS global).
/cc @jonahwilliams @yjbanov.

What are the numbers here? Sorry its a bit hard to follow the different issues/threads.

Heya, sorry for the silence--I was out at the tail end of last week.
I initially considered generating a separate version of the asset manifest for web, but I wanted to cut out the network request for the asset manifest to speed up (initial) asset loading and avoid having all pending asset loads depending on a single network request). However, if we are willing to delay addressing these properly (i.e. fixing #118115), I don't mind this adopting this solution. The other reason I avoided a solution like this one is that I wanted to avoid having to write/maintain a bunch of logic to construct/consume a JSON file, but your solution of just taking the existing bin data and encoding it as a string is pretty clever and doesn't strike me as too slow or data-consuming.
Barring strong opinions from others, I'd like to adopt this PR and close my original PR (after a few days or so).

Thanks @andrewkolos! I'll take a second look at the tests I broke here and get this one ready to land. I'd like to give this version a shot before we do drastic changes to the build process, but when we do those, we'll be sure to include both the font manifests and the assets one!

Agh, I was forgetting to pass --platform=chrome to my flutter test commands, that's why things were working locally but still failing in CI!

@andrewkolos offered to prepare a g3Fix for this so the "Google Testing" check passes and the PR can land. (It may be this PR that one that lands, or some other that @andrewkolos owns so he can do any changes he needs!)

One challenge I failed to foresee with this is the amount of change that might be required in g3. Unlike past asset manifest changes, this adds a file that is conditionally included in the build. This makes updating tests and build rules more difficult. In addition (though not as important), these kind of changes tend to break tests for customers that mock/fake AssetBundle in their tests. One of the reasons I initially liked this PR over my initial PR was it's relative simplicity. However, when considering g3 and testing, it may not be so simple.
It's possible that updating g3 to work with this PR might not be that complicated, but there are unknowns. Given that I've already invested at least 3x as much time as I wanted to on this issue, I'd like to go with the option that will probably have the fewest surprises. As a result, I may revisit my previous PR (https://github.com/flutter/flutter/pull/130419).

It's possible that updating g3 to work with this PR might not be that complicated, but there are unknowns.

OK, I guess I'll give that a shot too.

It's possible that updating g3 to work with this PR might not be that complicated, but there are unknowns.

~OK, I guess I'll give that a shot too.~
@andrewkolos is right, this is a world of hurt internally, what a shame :/

Do you have opinions against the core idea of https://github.com/flutter/flutter/pull/130419? As far as I can tell, @jonahwilliams and @yjbanov are satisfied with the core idea, as long as it uses a public dart API (as opposed to a hidden JS global).  I'm happy to rework #130419 instead (though I can only hope g3 doesn't use custom code for generating the web entry point 🙃--I never got to find out because FroB bugged out and refused to test the PR).

I have a g3fix ready for this, applying.

I can only hope g3 doesn't use custom code for generating the web entry point 🙃

@andrewkolos sorry, I've just seen this message 😅
In fact, g3 does uses custom code to generate the web entrypoint (see cs//depot/google3/mobile/flutter/build_defs/internal/web_rules.bzl;l=195), so you'd still have to go through the g3fix process to land the other version of the change.
I prefer this PR because it keeps about the same complexity that we currently have in master, fixes the problem that some people have, and gives us some extra time to actually design what's going to be our web inlining strategy. (As Jonah said, it's not the responsibility of your PR to find that solution.)
I guess I'm trying to avoid having one-offs for each file we may want to inline, and find a consolidated solution. What if tomorrow we want to make the FontManifest.json a binary file? (I'd rather it became a .bin.json for initial web solution, than creating another different setter to the engine, etc...)

Google testing should pass with this g3fix: cl/553547021

@ditman looks like the testing cl didn't apply your g3fix: cl/553348554. Should we retry?

friendly ping @ditman

(Apologies, I've been OOO for the last few weeks!)
@christopherfujino Yes please!
This PR has supposedly passed a TGP run (cl/553273631), but I never got it to run alongside its g3fix (cl/553547021).
If there's anything you can do (or that I need to do) to move things along, I'd love to get it done!

(Apologies, I've been OOO for the last few weeks!)
@christopherfujino Yes please!
This PR has supposedly passed a TGP run (cl/553273631), but I never got it to run alongside its g3fix (cl/553547021).
If there's anything you can do (or that I need to do) to move things along, I'd love to get it done!

Well unrelated, Google testing is borked: https://github.com/flutter/flutter/issues/133814

😿

Looks like the FROB test passed, yay! Can you PTAL @yjbanov?

Working on addressing yegor's nits (also giving some internal code time to land before landing this fix!)

Adding autosubmit, 🤞

Hi @ditman
Do you know when this fix will land on a stable release?
We currently have the problem that in some companies the firewalls block the bin-file of our flutter-web-app.
Regards,
Florian


Remove unnecessary Files from the Release-Zip

This is related to #56. We have to assure that the release zip stays below a certain file size limit. I think we could move the CONTRIBUTING.md and the images required for the README.md to a separate docs/ directory which is not included in the zip. This would save ~1.2 MB. We could also remove the README.md from the zip file as we always directly link to the GitHub page anyways.

@daPhipz would you like to look into this?

Will do!

Everything in the /resources directory apart from the GIFs is only used in the README - is this correct? (just double-checking, in case I missed something :wink:)

Only tutorial1.gif, tutorial2.gif, and tutorial3.gif are required for the release-zip. I think all others can be moved to a docs/ directory!


Start with "What and why"

I followed a link to Quint from a community of interest (Future of Coding Slack).
The link didn't discuss what Quint is, and I'm sad to see that the documentation for Quint doesn't appear to, either. Which seems odd.
This might be something I'm interested in, but after a few minutes poking around, I still have no idea what problems this solves, or in what way it's different, or really much of anything.

Regarding the what: it says pretty much everywhere that it is an executable specification language, which is what it is. Perhaps it would be useful to add pointers to what a specification language is (like this one from Wikipedia).
The why is a bigger story, which I tried making as concise as possible through an example. The website also has a big "find bug" button that is supposed to help getting this motivation out. But we do have larger pieces of content about the why spread all across the documentation, so it might be useful to group them better and link them for people who are just arriving.
Thanks for your feedback! I'm realizing that there are many different needs from people looking at our landing page and readme. It's hard to satisfy all of it, but we should at least have pointers to different pieces of information so people can find what they are looking for in this sense.

I came to this wanting to know:

is this Turing Complete?
is this a general-purpose language (ML was developed for writing compilers, but is also a terrific general-purpose langauge; this might be like that — who knows?)

I still don’t know.

I see. I don't think we specifically talk about this things anywhere.
As a language, it is Turing complete. However, keep in mind that both the simulator and the model checker will only consider executions of up to --max-steps and there is no recursion, so in practice it is impossible to have infinite loops.
It is a general-purpose specification language. It is not a programming language, so you can't use it for things you'd use a programming languages for. For example, there is no IO.

Hi @gisborne! I am not developing Quint atm. Just curious, whether you could point the developers to a good example of a website that does a better job at presenting a programming language than Quint?

https://ziglang.org/


[BUG] Editing a ConfigMap with \n or \t in the data field via edit Config results in a line break is expected error in the UI

Rancher Server Setup

Rancher version: 2.7.6
Installation option (Docker install/Helm Chart):

If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc):

Proxy/Cert Details: n/a

Information about the Cluster

Kubernetes version: 1.25.10
Cluster Type (Local/Downstream): local

User Information

What is the role of the user logged in? Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom

Describe the bug
ConfigMap edit doesn't work properly when you are using "\t" (tabulator) character.
To Reproduce

Create new config map
key: a, value: a
a	b 	c  <- with tab instead of space
key: b, value:a
a	b 	c  <- with tab instead of space
save

Result
Error: "a line break is expected"
Expected Result
Saved properly
Screenshots

Additional context
The issue happens when values are saved as string. Rancher adds additional key into first data section.

Caused by #7670. Same as in [BUG] configmap formatting breaking on creation/edit #42288 It seems that https://github.com/nodeca/js-yaml doesen't work properly.

Internal reference: SURE-7246

内部参考：SURE-7246

can we get any help? @gaktive

Also see rancher/rancher#43118

https://github.com/rancher/dashboard/issues/10067 should be tackled at the same time as this. If it's the same issue can be closed as a duplicate

/backport v2.7.next1

@rak-phillip Is it possible to write automated tests for this?

@nwmac Of course we can! We wrote tests in both #10179 & #10178 that address this area of dashboard. Are there  any specific cases that we would like to see represented here?

@rak-phillip I'm just looking for tests that test the changes in the PR for this issue - it looks like https://github.com/rancher/dashboard/pull/10168/files# has a unit test - if that is sufficient, then we should move this to QA Review, rather than To Test.

@nwmac I've moved to QA Review. I think that the test covers in such a way we'll prevent regressions of this type in the future. Behavior should remain unchanged otherwise.

/backport v2.8.next1

Manual validation would complement any automation coverage before closing, let's move to To Test @yonasberhe23

Since this was tested in 2.7.next1 & 2.8.next1 and marked done, I'll defer to QA whether this needs to be retested or if automation was in fact built up in the other tix.

@gaktive @nwmac can SURE-7246 be closed in light of this issue status?

this issue closed in 2.7.11, 2.7.12, but this version is non public

@LaoZhang-best This specific issue is for 2.9.0 which is the next minor release. It looks like it was also shipped in 2.8.3 which is the current minor release and is available to the community. Patch versions of a previous minor release (2.7) are for rancher prime customers and we would recommend community uses upgrade to the current minor release (2.8)


Better check of object types

The code was checking the type of objects using obj.__class__.__name__ rather than the more conventional (and more class hierarchy-friendly) isinstance. Functions were moved to the
end of the module in few cases because or the order of function or class definition (but after thinking about it might not have been necessary).
This PR is arguably improving the modularity by allowing the definition of child classes and their inclusion in the rest of keras thanks to inheritability.

Reworking the PR (and trying to defeat nagging pep8)


Error when using custom profile with string arg on linux

Testing #119427
Maybe update the json schema to disallow string argument on linux?
The terminal process failed to launch: A native exception occurred during launch (args as a string is not supported on unix.).

👍 we should ignore args when it's a string for linux/macos, on main this will give a warning as well.


Confusing clone! macro error message

I upgraded to gtk-rs master, now I get this "confusing" error message :-)
error: proc macro panicked
   --> ../src/ui/package_widgets/action_button.rs:112:23
    |
112 |           let closure = clone!(@weak self.builder as builder, @weak package => @default-return None::<glib::Value>, move |_:&[glib::Value]|{
    |  _______________________^
113 | |             Self::update_stack(builder.clone(), package.clone());
114 | |             None
115 | |         });
    | |__________^
    |
    = help: message: Expected `,` after `@default-return None::<`, found `,`

No idea if this can be improved a bit ^^

What error did you get before?
CC @GuillaumeGomez

Oh, interesting case.

What error did you get before?

Before it didn't throw me an error. This appeared after upgrading to the latest gtk-rs commit.

Ah I see, so something that worked before. When fixing that, this should also get a test :)


Refactoring vtgate and l2vtgate status pages.

@michael-berlin @enisoc whoever gets to this first, it's very straightforward and should be quick to review.

This change is

Reviewed 10 of 10 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable