Snapshot does not generate report and indicates success despite missing files

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
When running snapshot, the output indicates that my screenshots succeeded (green hearts everywhere)
However:

I'm missing three screenshots in the directory where they are all saved
The HTML was not re-generated properly.

I check some related issues, including #1648, and I tried running ReportsGenerator.new.generate  but I got the following Error:

Fastfile:32:in `block (3 levels) in parsing_binding': [!] uninitialized constant Fastlane::FastFile::ReportsGenerator (NameError)
	from Fastfile:30:in `chdir'
	from Fastfile:30:in `block (2 levels) in parsing_binding'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/lane.rb:33:in `call'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/runner.rb:45:in `chdir'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/runner.rb:45:in `execute'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/lane_manager.rb:56:in `cruise_lane'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
	from /usr/local/lib/ruby/gems/2.3.0/gems/commander-fastlane-4.4.5/lib/commander/command.rb:178:in `call'
	from /usr/local/lib/ruby/gems/2.3.0/gems/commander-fastlane-4.4.5/lib/commander/command.rb:153:in `run'
	from /usr/local/lib/ruby/gems/2.3.0/gems/commander-fastlane-4.4.5/lib/commander/runner.rb:476:in `run_active_command'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:75:in `run!'
	from /usr/local/lib/ruby/gems/2.3.0/gems/commander-fastlane-4.4.5/lib/commander/delegates.rb:15:in `run!'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/commands_generator.rb:337:in `run'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/commands_generator.rb:42:in `start'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/fastlane/lib/fastlane/cli_tools_distributor.rb:98:in `take_off'
	from /usr/local/lib/ruby/gems/2.3.0/gems/fastlane-2.78.0/bin/fastlane:20:in `<top (required)>'
	from /usr/local/bin/fastlane:22:in `load'
	from /usr/local/bin/fastlane:22:in `<main>'

Here is the final output of the snapshot run:
Complete output when running fastlane, including the stack trace and command used

fastlane screenshots

-----

+---------------+-------+-------+-------+
|           snapshot results            |
+---------------+-------+-------+-------+
| Device        | en-US | fr_FR | ja_JP |
+---------------+-------+-------+-------+
| iPhone SE     |  💚    |  💚    |  💚    |
| iPhone 6      |  💚    |  💚    |  💚    |
| iPhone 7 Plus |  💚    |  💚    |  💚    |
| iPhone X      |  💚    |  💚    |  💚    |
+---------------+-------+-------+-------+

+------------------+-----------------+
|            Lane Context            |
+------------------+-----------------+
| DEFAULT_PLATFORM | ios             |
| PLATFORM_NAME    | ios             |
| LANE_NAME        | ios screenshots |
+------------------+-----------------+
[21:24:34]: iPhone SE: Element Window cannot request screenshot data because it does not exist (<unknown>:0), Failure requesting automation session for com.prynt.staging:13297: Timed out waiting for target to check in. (<unknown>:0); iPhone 6: No matches found for Find: Descendants matching type Table from input {(
    Application, 0x600000387360, pid: 15006
)} (<unknown>:0), Failed to scroll to visible (by AX action) Button, 0x6000001998b0, traits:<PHONE_NUMBER>, identifier: 'cameraButton', label: 'record', error: Error -25204 performing AXAction 2003 on element <XCAccessibilityElement: 0x7fc74ed1bc50> pid: 15013, elementOrHash.elementID:<PHONE_NUMBER>33968.295 (<unknown>:0); iPhone 7 Plus: XCTAssertTrue failed -  (/Users/henry/Documents/XCode Projects/Swan/SwanUITests/LibraryUITests.swift:133); iPhone 7 Plus: XCTAssertTrue failed -  (/Users/henry/Documents/XCode Projects/Swan/SwanUITests/LibraryUITests.swift:133), No matches found for Find: Descendants matching type Table from input {(
    Application, 0x60400039f480, pid: 17971
)} (<unknown>:0), No matches found for Find: Descendants matching type Table from input {(
    Application, 0x600000387290, pid: 17978
)} (<unknown>:0)

+------+---------------------+-------------+
|             fastlane summary             |
+------+---------------------+-------------+
| Step | Action              | Time (in s) |
+------+---------------------+-------------+
| 1    | Verifying fastlane  | 0           |
|      | version             |             |
| 2    | default_platform    | 0           |
| 3    | cocoapods           | 210         |
| 💥    | snapshot            | 11165       |
+------+---------------------+-------------+

[21:24:34]: fastlane finished with errors

[!] iPhone SE: Element Window cannot request screenshot data because it does not exist (<unknown>:0), Failure requesting automation session for com.prynt.staging:13297: Timed out waiting for target to check in. (<unknown>:0); iPhone 6: No matches found for Find: Descendants matching type Table from input {(
    Application, 0x600000387360, pid: 15006
)} (<unknown>:0), Failed to scroll to visible (by AX action) Button, 0x6000001998b0, traits:<PHONE_NUMBER>, identifier: 'cameraButton', label: 'record', error: Error -25204 performing AXAction 2003 on element <XCAccessibilityElement: 0x7fc74ed1bc50> pid: 15013, elementOrHash.elementID:<PHONE_NUMBER>33968.295 (<unknown>:0); iPhone 7 Plus: XCTAssertTrue failed -  (/Users/henry/Documents/XCode Projects/Swan/SwanUITests/LibraryUITests.swift:133); iPhone 7 Plus: XCTAssertTrue failed -  (/Users/henry/Documents/XCode Projects/Swan/SwanUITests/LibraryUITests.swift:133), No matches found for Find: Descendants matching type Table from input {(
    Application, 0x60400039f480, pid: 17971
)} (<unknown>:0), No matches found for Find: Descendants matching type Table from input {(
    Application, 0x600000387290, pid: 17978
)} (<unknown>:0)

Environment
✅ fastlane environment ✅
Stack

Key
Value

OS
10.13.3

Ruby
2.3.3

Bundler?
false

Git
git version 2.14.3 (Apple Git-98)

Installation Source
/usr/local/bin/fastlane

Host
Mac OS X 10.13.3 (17D47)

Ruby Lib Dir
/usr/local/Cellar/ruby/2.3.3/lib

OpenSSL Version
OpenSSL 1.0.2j  26 Sep 2016

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
9.2

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./Fastfile`
# Customise this file, documentation can be found here:
# https://github.com/fastlane/fastlane/tree/master/fastlane/docs
# All available actions: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md
# can also be listed using the `fastlane actions` command

# Change the syntax highlighting to Ruby
# All lines starting with a # are ignored when running `fastlane`

# If you want to automatically update fastlane if a new version is available:
# update_fastlane

# This is the minimum version number required.
# Update this, if you use features of a newer version
fastlane_version "2.78.0"

default_platform :ios

platform :ios do

  before_all do |lane|
    ENV["SLACK_URL"] = "https://hooks.slack.com/services/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"
    if lane != :refresh_dsyms && lane != :lint && lane != :matchDev
    	cocoapods(repo_update: true)
    end
  end

  desc "Run the UI tests and generate the localized screenshots of the app"
  lane :screenshots do
    snapshot
  end

  desc "Pass swiftlint on the project"
  lane :lint do
    sh "ls"
    sh "pwd"
    sh "./lint.sh"
  end

  after_all do |lane|
    # This block is called, only if the executed lane was successful
    if lane == :beta || lane == :staging || lane == :releaseTestFlight || lane == :release
      slack(message: "Successfully deployed new App Update on lane: " + lane.to_s)
    end
  end

  error do |lane, exception|

  end
end

# More information about multiple platforms in fastlane: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Platforms.md
# All available actions: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Actions.md

# fastlane reports which actions are used
# No personal data is recorded. Learn more at https://github.com/fastlane/enhancer

fastlane gems

Gem
Version
Update-Status

fastlane
2.78.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.0.0

slack-notifier
2.3.2

CFPropertyList
2.3.4

claide
1.0.2

colored2
3.1.2

nanaimo
0.2.3

xcodeproj
1.5.3

rouge
1.11.1

xcpretty
0.2.4

terminal-notifier
1.7.1

terminal-table
1.4.5

plist
3.2.0

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

tty-screen
0.6.3

tty-cursor
0.5.0

tty-spinner
0.8.0

babosa
1.0.2

colored
1.2

highline
1.7.8

commander-fastlane
4.4.5

excon
0.45.1

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20161021

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

fastimage
2.1.0

gh_inspector
1.0.2

json
1.8.3

mini_magick
4.5.1

multi_xml
0.5.5

security
0.1.3

xcpretty-travis-formatter
0.0.4

dotenv
2.1.1

bundler
1.12.3

uber
0.0.13

declarative
0.0.9

declarative-option
0.1.0

representable
3.0.4

retriable
2.1.0

mime-types-data
3.2016.0521

mime-types
3.1

little-plugger
1.1.4

logging
2.1.0

jwt
1.5.6

memoist
0.15.0

os
0.9.6

signet
0.7.3

googleauth
0.5.1

httpclient
<IP_ADDRESS>

google-api-client
0.13.6

io-console
0.4.5

rubyzip
1.2.1

mini_portile2
2.3.0

nokogiri
1.8.1

faraday
0.10.0

faraday_middleware
0.10.1

generated on: 2018-01-26

Is there any way I could manually force the HTML report generation after the run of snapshot ?
Tell me if you need any more stack trace of the issue or if I can provide additional infos.

Fastfile:32:in `block (3 levels) in parsing_binding': [!] uninitialized constant Fastlane::FastFile::ReportsGenerator (NameError)
	from Fastfile:30:in `chdir'

That seems to not be an issue snapshot but with your Fastfile it seems

Uh that's weird, something is fishy here. Do the other lanes work? Can you remove the snapshot call from your Fastfile and see if that works?

@HHK1 Heyyyy 👋 Were you able to figure this out?

The main issue with snapshot indicating a success while failing to generate the report still happen randomly, I need to re-investigate this though.
Regarding the fix I was trying:
I've successfully managed to use the report generator, I've added this in my lane:
Dir.chdir("..") do
    fastlane_require 'snapshot'
    Snapshot.config = FastlaneCore::Configuration.create(Snapshot::Options.available_options, {})
    Snapshot::ReportsGenerator.new.generate
end

This allows me to generate the report event if snapshot fails. I failed to pinpoint the issue in snapshot however


[Feature Request]: API server

Describe the feature
Provide a way to transcribe through HTTP API.
Using axum and topia (for swagger) on port 3082 through --server option in cli.
Use shared state for models in both tauri and axum for efficient memory use.

Added. use --server


Dictionary error

Hi,
I'm trying to use your library and it seems I'm getting errors.
The given key '-16' was not present in the dictionary.

@pherbel Please can you give me more context and if possible error details

Closing this issue. You can reopen with more context.


[Discover Page] Cannot clear dates

When I click the red x to clear all dates, the dates do not clear.

duplicate of https://github.com/hydroshare/hydroshare/issues/2432


Anyways to use ForceAtlas layout without using Sigma's rendering utilities?

Apologize in advance if this is where a question should be asked. @Yomguithereal Basically I wanted to test out the ForceAtlas2 layout but without having to render the graph through Sigma itself.

You should be able to do that by instantiating sigma with no renderer, this way every time FA2 calls sigma.refresh won't have anything to process for the visual rendering
Otherwise, you should probably fork the repo, comment the sigma.refresh line in FA2's code and build your own version of sigma with it.

I was able to get FA2 working without giving it a DOM element ID to bind to. Is there an explicit option to disable the renderer?

Looking at https://github.com/jacomyal/sigma.js/wiki/Public-API I guess instantiating sigma without a container is enough, otherwise maybe set renderers to an empty array but I guess that's what happens with no container

@RouxRC That works. Thanks for the help!


complete overhaul

Complete overhaul to mimick the strided implementation from TensorOperations.jl. Also more tests.
It seems TBLIS does support a beta argument by encoding it in the C tensor structure, before entering the add or mult method. It also supports the conjugation flag in the add method (also used for trace), but unfortunately not in the mult (tensor contraction) method. We work around this by allocating a temporary for the conjugated tensor.
I think this is ready for review.

Ok, I think I covered all of your comments. I just changed everything locally and pushed the changes, which was easier than committing some of the changes you made and merging them with the ones I already had locally.


Puller using Kademlia Depth rather than Storage Radius

Context
Mainnet bee v1.10.0
Summary
I had a connectivity issue and lost some peers (bee_kademlia_currently_connected_peers) causing the Kademlia Radius to drop from 8 to 3 and the puller went nuts trying to fill my reserve to the wrong radius.  The offending topology bin ping-ponged a bit and you can see a drop in the puller actions when the Kademlia Depth temporarily recovered.
See the pictures in Discord at:
https://discord.com/channels/799027393297514537/811553590170353685/1062756263135543306
https://discord.com/channels/799027393297514537/811553590170353685/1062757281546109008
Expected behavior
If the Storage Radius (reserve) doesn't change, the puller shouldn't be getting active.  Losing Kademlia Radius simply means connectivity is down, not that new chunks need to be pulled.
Actual behavior
The puller got over-active when the Kademlia Radius dropped to 3 even though the Storage Radius was still happy at 8.
Steps to reproduce
That'll be tricking, but get a low neighborhood to have too few connected peers causing the Kademlia Radius to be substantially lower than the Storage Radius.
Possible solution
Have the puller pull bins based on the Storage Radius, not the Kademlia Radius.

See also the Discord thread starting at
https://discord.com/channels/799027393297514537/811553590170353685/1063439576795988078


Remove default trust_remote_code=True

TODO:

[x] fix tests

yay! 🎉

@lhoestq Thanks for the PR, Is there a way to detect if trust_remote_code=True will be required for loading the dataset, without loading it? It would be great if you could please point me to the relevant documentation.

You can check the presence of a python loading script in the repository.
If there is a .py file named after the repository name, then it requires trust_remote_code.

Thanks @lhoestq for the reference.


Update for gem5@mem: Make MemCtrl a ClockedObject

Fix some bitrot. The changes for part1 and part2 are copied from gem5/configs/learning_gem/*. The change for part5 was manually derived and hasn't been tested (although the prior part5 script was broken anyway with a typo, so not doing any worse).

Thanks for the contribution! I'll go ahead and merge this, but, more importantly, I need to redirect learning.gem5.org to https://www.gem5.org/documentation/learning_gem5/introduction/
@bobbyrbruce, can you put this on our todo list?


7 upgrade solidity version to 0818 and update to named parameters in mappings

Leaving as draft until #4 is merged


Feature: Add Repository lang stats like Github

How about adding an Repository lang stats feature like Github has?
Have 2 Screenshots here to underline what i mean:

Onclick:

Cant find similar issues to this one.

Looks like the guys at gogs are in holidays since 2 weeks :laughing:

Just to clarify: I'm sure Unknwon added the "dont send pull request" label because the oldest open pull request handles exactly this. 😉

Merge thread to https://github.com/gogits/gogs/issues/4154.


Model assembler claims conflicting members - false positive

Consider the following model IDL:
$version: "2"
namespace test

@mixin
structure Common {
  @required description: String
}

structure Str with [Common] {
  description: String = "test"
}

When you load and serialize this to Smithy again, you'll get an apply node for the @default trait:
$version: "2.0"

namespace test

@mixin
structure Common {
    @required
    description: String
}

structure Str with [Common] {}

apply Str$description @default("test")

This is also reflected in the normal ModelSerializer (outputting JSON):

JSON dump
{
    "smithy": "2.0",
    "shapes": {
        "test#Common": {
            "type": "structure",
            "members": {
                "description": {
                    "target": "smithy.api#String",
                    "traits": {
                        "smithy.api#required": {}
                    }
                }
            },
            "traits": {
                "smithy.api#mixin": {}
            }
        },
        "test#Str": {
            "type": "structure",
            "mixins": [
                {
                    "target": "test#Common"
                }
            ],
            "members": {}
        },
        "test#Str$description": {
            "type": "apply",
            "traits": {
                "smithy.api#default": "test"
            }
        }
    }
}

and it also loads fine if you have this one model file.
However, if you have another model file that happens to duplicate these structures, and you try to load them both during assembly, it fails:
software.amazon.smithy.model.validation.ValidatedResultException: Result contained ERROR severity validation events:
[ERROR] test#Str: Conflicting shape definition for `test#Str` found at `test2.json [18, 21]` and `test.json [18, 21]`. Members differ: [description] vs [description] | Model test.json:18:21
	at software.amazon.smithy.model.validation.ValidatedResult.validate(ValidatedResult.java:145)
	at software.amazon.smithy.model.validation.ValidatedResult.unwrap(ValidatedResult.java:132)

That seems wrong: the model merging process is able to resolve the "conflict" once, but not twice, in what otherwise seemed like an idempotent process.
Is this something that should be fixed?
The entire process can be reproduced with the following scala-cli script:
//> using scala "3.3.1"
//> using option "-Wunused:imports"
//> using lib "software.amazon.smithy:smithy-model:1.39.1"
import software.amazon.smithy.model.shapes.SmithyIdlModelSerializer
import software.amazon.smithy.model.node.Node
import software.amazon.smithy.model.shapes.ModelSerializer
import software.amazon.smithy.model.loader.ModelAssembler
import software.amazon.smithy.model.Model
import scala.jdk.CollectionConverters._

val model =
  """$version: "2"
    |namespace test
    |
    |@mixin
    |structure Common {
    |  @required description: String
    |}
    |
    |structure Str with [Common] {
    |  description: String = "test"
    |}
    |""".stripMargin

val loaded = Model
  .assembler()
  .putProperty(ModelAssembler.DISABLE_JAR_CACHE, true)
  .addUnparsedModel(
    "test.smithy",
    model,
  )
  .assemble()
  .unwrap()

SmithyIdlModelSerializer.builder().build().serialize(loaded).asScala.head._2

val serialized = Node.prettyPrintJson(ModelSerializer.builder().build().serialize(loaded))

Model
  .assembler()
  .addUnparsedModel("test.json", serialized)
  .addUnparsedModel("test2.json", serialized)
  .assemble()
  .unwrap()

Hey team, this is causing us more trouble nowadays. Can someone please triage the issue and drop some hints for a solution so that we can contribute a fix?

The diff between the shape is due to the required  trait from the mixin only being applied once since the trait gets “claimed” the first time the shape is built and removed from the unclaimed traits. When the shape gets built for the second time, the unclaimed traits is empty, so the member doesn’t get the required  trait applied, and hence the comparison between previous and built shows a diff.
There's a few ways we could go about this, but a simple way is to track what is "claimed" in addition to "unclaimed" (and don't remove items from unclaimed), and then if anything in unclaimed is not in claimed, validation event should be emitted (in emitUnclaimedTraits).


pfs-162: Downloads files from S3 by proxying the response stream betw…

…een the services

Codecov Report
Attention: Patch coverage is 40.97222% with 85 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@221b402). Learn more about missing BASE report.

Files with missing lines
Patch %
Lines

finance-admin/internal/server/download_file.go
0.00%
22 Missing :warning:

finance-admin/internal/server/auth.go
0.00%
18 Missing :warning:

finance-admin/internal/api/request_report.go
68.29%
9 Missing and 4 partials :warning:

finance-admin/internal/server/server.go
0.00%
13 Missing :warning:

finance-admin/internal/api/api_client.go
27.27%
8 Missing :warning:

finance-admin/internal/api/session.go
0.00%
6 Missing :warning:

finance-admin/internal/api/download.go
0.00%
3 Missing :warning:

finance-admin-api/api/download.go
95.83%
1 Missing :warning:

finance-admin-api/api/server.go
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage        ?   37.70%
=======================================
  Files           ?       39
  Lines           ?     1273
  Branches        ?        0
=======================================
  Hits            ?      480
  Misses          ?      768
  Partials        ?       25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


RemoteFs methods should take immutable self

Just ran across an issue where I'm trying to call methods of a struct implementing RemoteFs across several threads, but since the RemoteFs trait requires that self must be passed mutably, I cannot access it without using some form of interior mutability, like a Mutex or RwLock. I'm currently implementing a file system and there could be thousands of operations happening at once and using locks would mean each operation would have to wait on another resulting in a significant performance impact. Most of the protocols don't require mutability on their methods which is why this feature is reasonable, however, the ones that do could implement interior mutability themselves.

I admit I've never used interior mutability before, but this will be the right time to start using it.
I'm taking a break right now from my opensource projects, but I will implement this for sure when I'm back (I've already seen your PR, but I need to fix this in the clients too)

Merged, but I just realized that connect and disconnect must be kept as mutable (I don't think will be a problem for you anyway)

Client implementation:

[x] FTP
[ ] SSH
[ ] AWS-s3

I took a quick look at the implementations in the various clients and noticed that you used a RefCell instead of something like a RwLock or Mutex. RefCell's are meant for single threading programs whereas the locking ones are meant for multithreading.
I'm not too familiar with the in-depths of multithreading, but one thing to watch out for with a RwLock is writer starvation. Meaning, that there could be too many readers to the point where writers are never able to write. In a library like this, I could see that happening often.
Now if you were to use a Mutex since in most of the protocols you are wrapping the current path, you'd have constant locking and you'd pretty much fall into the same trap I described when I created this issue, where each operation is blocked by the other.
I think the solution here is to use something like arc-swap. Again, I'm not too familiar with this kind of stuff, but with some basic googling and research this is what I've found. IIRC an ArcSwap is basically a RwLock<Arc<T>>, however, instead of waiting for all the RwLock readers to drop before writing (which could happen), the ArcSwap will allow writers to write into a new set of data so that any existing readers could keep reading the old data. I'm not sure if this is just overcomplicating things or if it's the correct route to go, but as I said, this is what I've gathered.

To partially address the aforementioned issue, check out issue #22.

To get a gist, basically, relative paths should just be removed completely. No matter what, even if you use what I said above there could still be issues. A big one is if you change the current directory then you try and call, for example, list_dir. In that time frame from when u called cwd to list_dir, cwd could've been called again and it would pretty much break everything.
My solution was to always use absolute paths, even in FTP where it would have to send a separate request for that. While this works, it only really works to an extent. A protocol like FTP isn't meant to be multithreaded on a single connection and typically you'd open another if you are working on a file elsewhere. So I think the goal here is to not make protocols that are not meant to be thread-safe, thread-safe. However, I do believe that relative paths should still be removed.
Without relative paths, FTP would send a separate request to change the working directory first, if necessary. This will allow for consistency on all protocols and in general, make everything better. Now, to make FTP actually thread-safe, the remotefs-ftp crate could expose a separate struct that wraps the inner one (that we currently have) to automatically manage new connections and optimize everything for maximum performance. This way users could use protocols like FTP almost as if it was naturally thread-safe.

@veeso any thoughts on this? I might go ahead and implement it,


Report performance

It would be nice to have a "report performance" option as well.
This could show query per sec or similar metrics.
I could think about two possible options:

the metric name (like qps, MiB/s, km/h or similar)
the metric interval in seconds (1 means per second, 3600 means per hour)

Why is the close?


usage to stdout

consider using stdout instead of stderr printing usage information so the lengthy output could be viewed with for example | less:
# lxc config | less

So I'd actually expect "lxc config" to go to stderr as it's printing the help as a result of an error "wrong number of subcommand arguments".
However, "lxc help" or "lxc config --help" should be going to stdout as the user actually did request the help.
It looks like we're not doing things quite that way right now, as --help and the help command both go to stderr when they shouldn't.

agree with errors to stderr part, but the problem is that "lxc config" is not just showing error but also dumping usage (which is the long part). it probably should just show error and suggest to use "lxc config --help"
i think that's the way to go, as it's really hard to notice errors if some long output is printed (that usage help)

We always dump usage on command parsing error in the lxc tool as a convenience. Maybe we should stop doing that, but it's been pretty useful to our users I think.
We used to print the error at the top which was particularly hard to find, though @tych0 moved the error message to the bottom a little while back to make it easier for folks to see.

On Sun, Aug 21, 2016 at 08:15:28AM -0700, Stéphane Graber wrote:

We always dump usage on command parsing error in the lxc tool as a convenience. Maybe we should stop doing that, but it's been pretty useful to our users I think.
We used to print the error at the top which was particularly hard to find, though @tych0 moved the error message to the bottom a little while back to make it easier for folks to see.

We could try to colorize the errors, perhaps. Would that help?

--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/lxc/lxd/issues/2301#issuecomment-241263330

I think errors should be brief and concise. lxc config --help could be added as single line aside the error message to assist new users. for advanced users always showing usage aside error makes errors hard to follow and makes more efforts to eyes to extract error from usage noise.


Secondary action for list-group

A common usage on mobile apps is to have a list with a large primary action area and a smaller secondary action to the side.
Where 3 in the image below could be for example a ⋮ (vertical ellipsis) button.
The list group component in Bootstrap currently does not support this usage. It would be nice if it did.

Could you not just use a non-action list-group-item, and then embed a flex row with the avatar, a link and the checkbox (or ellipsis button)?  Or nest a media component inside the list-group-item with the avatar, link, and checkbox?

I don't know. The image is just an example, I am not all that interested in a avatar, but more interested in having a secondary action (aligned to the right side) with a checkbox, switch, button or dropdown menu.
https://jsfiddle.net/vgdh6nr8/
It doesn't seem to be any clear way to have a primary and secondary action.

@vanillajonathan you can combine some utility classes.
https://jsfiddle.net/sqxpcgef/6/

That has only one action that covers the whole row. It does not have a primary action and a secondary action.

Something like this? https://jsfiddle.net/d987234a/6/
(It's true that the switch it's not clickable without label 🤔 )

A bit messy with so many classes, but yeah something like that.

Many of us out here are looking to do something similar but with a checkbox and label https://jsfiddle.net/dragontheory/78aj5dhr/ . The entire list-item toggles the checkbox. Seen various implementations but all seemed a bit kludgy. This type of layout enables bulk actions such as select/deselect all or groups of product filters like Amazon.  Is there a better or even an "official solution"?

Why not place a media conponent I side a list group item? The media aside could be the dripdown/checkbox, etc, and the content could be an anchor tag.

In my case, I need the entire list-item (or whatever) to be clickable to toggle the checkbox. I am just looking for the most efficient semantic solution or if there is an "official solution" that I may have missed. This is probably not the right context and I should post my question in a new thread? Thanks!


Sk show default member permissions

Closes #510
In this PR, we add the ability for instructors to see current default member permissions for a course organization.
We also provide a warning if it is not the recommended value and a link to the place to change it.

The link takes you directly to the github settings page where the permissions can be changed.

Codecov Report

Merging #511 (d960bb3) into master (6f3fe32) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #511   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines           65        65
  Branches         4         4
=========================================
  Hits            65        65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3fe32...d960bb3. Read the comment docs.


App 1252 add robot count to location

Adding a robot_count field to the Location message, since it is a common use case to want to know the amount of robots, if any, in a location.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Skill Name
gromacs
Why?
A free and open-source software suite for high-performance molecular dynamics and output analysis.
Reference Image

Svg Availability

[X] I have given the official svg version of the logo in the Reference Image field.

Code of Conduct Acknowledgment

[X] I have read and agree to the Code of Conduct.

Hi! FYI, the logo has been updated 3 years ago, and now look like this:

Different formats, including SVG, are available here: https://gitlab.com/gromacs/gromacs/-/tree/v2024.4/docs/reference-manual/plots/GMX_logos?ref_type=tags


add option to disable mutating webhook for KE chart

Hi! Can you add option to disable mutating webhook for KE chart?

open PR. https://github.com/aquasecurity/aqua-helm/pull/805


TAPASonnx optimum.exporters.onnx support

What does this PR do?
Added changes for TAPAS model. And rearranged alphabetical order in test_optimization.py files.

Fixes #555 issue

Hi @someshfengde , thank you for the PR! It appears you forgot to add tapas in exporters/tasks.py.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

okay got it sorry I'm replying late got busy with other tasks and exams but surely make time for this


[(ngModel)] directive is not working in production mode.

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
Report a bug

What is the current behavior?
App is not working. Exception in logs: ng2-webpack.txt

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem:

Open https://github.com/AngularClass/angular2-webpack-starter/blob/master/src/app/home/home.html file
Comment 3rd line
Uncomment 7th line
Build project in production mode (npm run build:prod)
Open app. It's not working. Watch exception in logs

What is the expected behavior?
App is working!

What is the motivation / use case for changing the behavior?
It's usual ng2 directive.

Please tell us about your environment:
Latest code from master, Chrome, MacOS.

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
See attachments.

see changes https://github.com/AngularClass/angular2-webpack-starter/commit/7780e22f90dc643f72c1e094b2c228c2176eacc6#diff-1a19ad1ad8c7b53ba23a02dcba546ee8
it might be better to turn mangle off


[2.x] Exclusivity with OC v3

Bump RainLab.User to v2.0.0 for exclusive support with October CMS v3. Now developers don't have to worry about backward compatibility and breaking legacy sites, specifically v1, with contributions.
Following the Translate plugin's lead for continuity.

October CMS Version
User Version

1.0, 1.1, 2.0, 2.1, 2.2, 3.0
1.x

3.1
2.x

No upgrade guide is required for this version.
There is only one feature introduced in User v2:

Introduces a "Password Policy" tab to the settings area

Thanks, this will be great 👍


improve the statistics:

transport more infos in statistics api and pcapProcessedEvent
transport the accurate number of streams/packets in StreamCount and PacketCount next to the counters that double count (StreamRecordCount / PacketRecordCount)

fixes #111

The index merge event could include the updated index count too now that that stat is updated through websockets too.


Update README, including themes

Once antibody allow us to install themes, on #69, we should update the README for that.

Done.


Test Teleop Control System

Extensively test control system; document errors. They are there, trust me.

Shakout Test run 1 had few to no issues. Decelerates a little slow for my liking still, but should be okay. Maybe actuate the brakes?


Sync is not happening

I am a beginner to Android applications. I need to use Health Connect to collect real-time data for my research. I am using your code, but when i import the application I get an error. Could you please let me know is there any initial setting I need to make in android studio?

Hi
You can follow the documentation here. Hope that helps.

I am facing the below error. Could you please help me in solving this?

Where:
Script<EMAIL_ADDRESS>line: 413

What went wrong:
A problem occurred evaluating script.

Cannot run program "node" (in directory "C:\Users\DELL\Downloads\react-native-health-connect-main\react-native-health-connect-main\example\android"): CreateProcess error=2, The system cannot find the file specified

You don't have node installed or your environment is not set up properly. If you are ono Windows and you just want to experiment this on Android I suggest you to use Native solution. Setting up React Native is a bit harder to follow.
As you can see in the error your command line on Windows cannot detect where node installed or it's not installed at all.
Going to close this issue. Feel free to move this to discussions section.

Hello team,
Thank you for your reply.
I am using on windows. I want to use this android solution to collect the
health info from health connect app.
Could you please suggest the solution for me?
Thank you in advance.
Best Regards
Goutami Sheshappanavar
On Sat, 7 Sept 2024, 12:37 am Matin Zadeh Dolatabad, <
@.***> wrote:

You don't have node installed or your environment is not set up properly.
If you are on Windows and you just want to experiment this on Android I
suggest you to use Native solution. Setting up React Native is a bit harder
to follow.
As you can see in the error your command line on Windows cannot detect
where node installed or it's not installed at all.
Going to close this issue. Feel free to move this to discussions section.
—
Reply to this email directly, view it on GitHub
https://github.com/matinzd/react-native-health-connect/issues/138#issuecomment-2334902664,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BG3UKDWE5IE3BKXWRTXUDDTZVIVDDAVCNFSM6AAAAABM5NQYBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZUHEYDENRWGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>


When running a pyscript I get "RuntimeError: No device connected"

Before opening a new issue, we wanted to provide you with some useful suggestions (Click "Preview" above for a better view):

Consider checking out SDK examples.
Have you looked in our documentations?
Is you question a frequently asked one?
Try searching our GitHub Issues (open and closed) for a similar issue.

All users are welcomed to report bugs, ask questions, suggest or request enhancements and generally feel free to open new issue, even if they haven't followed any of the suggestions above :)

Required Info

Camera Model
T265

Firmware Version
<IP_ADDRESS>1

Operating System & Version
Ubuntu 22.04

Kernel Version (Linux Only)
5.10

Platform
Orange Pi

SDK Version
v2.54.1 (Manually built)

Language
Python

Segment
Robot

Issue Description
When I'm trying to run my Python script I get this error:
self.pipeline.start(config)
RuntimeError: No device connected

I tried running the script on a Windows 10 computer, and even though the camera was connected through the RealSense Viewer it still gave me the same error.
I tried using both the serial number and product id (from the viewer) as the device_id but still no luck.
Some help would be very appreciated!

2.54.1移除了对T265的支持，你需要使用2.53.1的sdk,它支持T265的使用


Expose errors

Hi. I'm using your package for some basic R&D, however I would like you to expose errors in order to have more granular error handling when using your package.

Hi @slimcdk, thank you for contributing to my package. I will look into your pr today.
If you have more feature requests, feel free to make issues.


Upgrade to JasperReports Server 7.1.0

Is it possible to upgrade to the latest version (currently 7.0.1) ?

Just a reminder that pull requests are always welcome too.


[Feature][Connector-V2][File] Support compress

Purpose of this pull request
close #3839

Check list

[ ] Code changed are covered with tests, or it does not need tests for reason:
[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

Add e2e test may be better.


Survey package, svydesign help

Hey all,
Trying to use the survey package command svydesign to make sure our data is properly weighted and has proper estimates.

I tried the above, the survey design object seems okay then I try the logic and I keep getting the error of:
Error in svyglm.survey.design(vote_2012 ~ education + unemployed + female +  :
all variables must be in design= argument
I already set the variables=NULL because, from my understanding, that defaults it to using the data frame (e.g. - all of the variables) so I don't understand why it keeps telling me to specify the variables again...?
If someone could clue me in as to what I'm missing, I would greatly appreciate it.
Marie

Hi @MarieAgosta have you tried specifying the variables explicitly with the variables argument? If so, what happens?


GH-35875: [R] Update Readme

Rationale for this change
#35875 #35082 and #32895 make a number of recommendations to update the the Readme
What changes are included in this PR?
Rewording and reorganizing the Readme and sidebar.
Are these changes tested?
n/a
Are there any user-facing changes?
Yes

Closes: #35875

@github-actions crossbow submit preview-docs

Hi @dgreiss, thanks for submitting a PR for this, it looks like a nice improvement so far. I see there have been some comments by others and I wanted to check in with you to see if you had time and interest to response to them. Let us know if there's anything we can do to help.

I'm keen to progress this, as we've had another person not really understanding what the packages does: https://community.rstudio.com/t/the-purpose-of-apache-arrow/178781
I'll pick this up in the next week or so if nobody else wants to do it?

I'm really sorry I haven't had the time to get back to this. I was having trouble reverting the changes to the yaml file. I'd appreciate the help @thisisnic

Absolutely no problem @dgreiss!
If it was me, I'd probably just make a note of the non-whitespace changes I'd made, and then make a fresh copy of the file from the main branch and manually re-apply the changes I wanted to keep.  There may be a smarter way to do this, but this way is pretty straightforward!

@thisisnic @amoeba sorry for the delay on this. I think it's ready for another review

@github-actions crossbow submit preview-docs

ugh rather than fighting git I'm going to close this and open a new PR. Sorry about this.


Add University of Chicago

@zh4ngx I am sorry, the domain uchicago.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Allow usage for inventory variables and indented module parameters.

hi, same here as in this pull request.
Please provide an example usage and / or see if the other comment would resolve this.

And the same answer applies also for franklinkim.cron :smile: See: https://github.com/weareinteractive/ansible-files/pull/1#issuecomment-133691467

Same, same ;) https://github.com/weareinteractive/ansible-files/pull/1#issuecomment-133702912

Same as https://github.com/weareinteractive/ansible-files/pull/1#issuecomment-133714152
I leave this open for voting and if more people want this to be included I'll also check all my other roles to be sync with this feature.


Can't get child tags?

We can trivially get Parent tags using the getTag function, but that function doesn't seem to expose child tags, despite that being available on AO3? Metatags also seem to be inaccessable.

This makes it not possible to traverse tags.

Yup, that's not currently available! I've asked in our fandom coders Discord whether anyone wants to take a stab at it, so let me give some details on what it would need to be added:

Implementation of the subtag parsing would go in the /src/tags/page-getters.ts file
The method should then be used as part of the getTag function
And here is the Tag type that would need to be updated.

The Fluff tag seems like a good tag to write tests for this (though we should have tests for one page without subtags). Tests would go in this file.
The one difficulty I see is that some subtags also have subtags and those are also displayed on the parent tag page.
I see two solutions:

We only return first-level subtags
We always return subtags as "subTags: { tagName: string; subTags: Array<string> }" with array being empty by default.

I have a slight preference for 2 since people would need to query every single subtag to know if subtags existed without it, though i don't know if there's cases where AO3 doesn't surface subtags there even if they exist. It complicates code a little bit compared to having subTags: Array<string> as a type (solution 1), but it's both more future proof and not that huge of a complication.
Thank you for reporting this as a need and using our library :D hopefully we can get a taker for the issue.

Hey there, I'd like to take a stab at this! I'm working on getting the repo set up and figuring out the implementation.

Hey there, I'd like to take a stab at this! I'm working on getting the repo set up and figuring out the implementation.

Seems like someone else in our Discord might already be working on it (sorry about not assigning the issue, just woke up). However, if you've gotten the thing setup we could also use the 'Tags with the same meaning' section, which should have very similar implementation!

(Please disregard if you're the same person who said they were doing this in fandom coders!)

Nevermind, rhyses is indeed the same person as our fandom coders' tribute 👯

How does one join the discord server? Perhaps add the link to Contributing.md? Or did I just miss something?

https://github.com/FujoWebDev/AO3.js/pull/75 solves getting Subtags, but we still aren't getting Child tags.

How does one join the discord server? Perhaps add the link to Contributing.md? Or did I just miss something?

We don't publicize the link prominently since we're still working on scaling moderation, but if you submit an application here and let us know who you are we'll send an invite shortly :)
I saw some comments on the PR so i'll go continue the rest of the convo there!

#75 solves getting Subtags, but we still aren't getting Child tags.

#83


Fix to allow disbursementData to evaluate as empty

Description
In a couple of cases the disbursementData variable was compared agains null instead of Empty comparation. And It can not be null due this parameter is required
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

LGTM


Moving weather provider specific code and configuration into each provider and making hourly part of the interface.

Changed weather module to check type instead of weatherEndpoint to make it possible for providers without weatherEndpoint to support hourly.
Removed the fallback to a non-existing template since all 3 types is handled. An invalid value keeps the "Loading..." like for other errors.
Made the fetchWeatherData less generic since it was only used for hourly data and removed all the usages of the generic weatherData from the templates.
Moved default values for config properties regarding each provider into the provider. I've set default values from the documentation for each provider.

I've tested it with openweathermap (current, forecast, hourly) and smhi (current, forecast) but I don't have an API-key for the other ones.

Codecov Report

Merging #2432 (5a42122) into develop (a3cb0b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2432   +/-   ##
========================================
  Coverage    39.40%   39.40%
========================================
  Files           20       20
  Lines         1609     1609
========================================
  Hits           634      634
  Misses         975      975

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3cb0b7...5a42122. Read the comment docs.

Codecov Report

Merging #2432 (5a42122) into develop (a3cb0b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2432   +/-   ##
========================================
  Coverage    39.40%   39.40%
========================================
  Files           20       20
  Lines         1609     1609
========================================
  Hits           634      634
  Misses         975      975

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3cb0b7...5a42122. Read the comment docs.


[Frontend] Tool calling parser for Granite 3.0 models

This PR adds a tool calling parser for ibm-granite/granite-3.0-8b-instruct. The smaller models in
the Granite 3.0 Language Models models collection pass some of the tests..
cc: @njhill

This is ready for review.
cc: @njhill @wseaton

cc @K-Mistele in case you'd like to take a look too

will take another look!

Giving it a final once-over :)
Out of curiosity it looks like the model's default context is 4096; is there any way to scale this if I want to test longer-context tool calls? no worries if there's not a good way to do with with vLLM

Looks great to me! Seems pretty robust, and passing tests on my machine :)

Looks like the only failing tests were AMD-related which was expected last I checked. cc @mgoin @DarkLight1337

Looks like the only failing tests were AMD-related which was expected last I checked. cc @mgoin @DarkLight1337

The test is not failing on main branch, so I think it's introduced by this PR. Do tell me if I'm mistaken though.

Looks like the only failing tests were AMD-related which was expected last I checked. cc @mgoin @DarkLight1337

The test is not failing on main branch, so I think it's introduced by this PR. Do tell me if I'm mistaken though.

Oops, missed that. I just remembered the last time I did one there were some expected to fail, but I'm sure you're right :)
Seems related to the FP8 granite 20B quantization (mbayser/granite-20b-functioncalling-FP8-KV) that's being used:
https://buildkite.com/vllm/ci-aws/builds/10840#01930511-9576-45cb-aebb-e237d5f07c9b/974-5501
AMD supports FP8 in ROCM > 6.2. Could also be an OOM issue since this is a 20B that we had issues fitting into other CI GPUs; or could be related to CPU offloading.
Whatever the case, seems more like a model+configuration+hardware compatibility issue rather than a code issue. Is there any way to disable this particular model for AMD tests, and would that be an acceptable solution?

I think this is alright. @njhill any thoughts?

I've pushed a change to disable skip the granite-20b-functioncalling test on AMD. Let's see if it passes now :crossed_fingers:

Out of curiosity it looks like the model's default context is 4096; is there any way to scale this if I want to test longer-context tool calls? no worries if there's not a good way to do with with vLLM

I'm not sure, but as we add more models and tests, we might have to get the max sequence length for each model and skip the tests that require longer ones.

Thanks again @maxdebayser @K-Mistele @DarkLight1337!


Add read the docs

@mgrauer Let me know what you think.
I have a few nitpicks, but I think this is a decent start.

LGTM, but Travis failed.  Something about ssl verify in requests.  My first approach of course is to not think about it, restart Travis, and hope the problem goes away.

Nice!! @danlamanna @mgrauer

We are getting some 2 test failures.  I doubt they are related to this work, but haven't had time to investigate.  One is with the contour analysis test and one is with the mean contour analysis test.
For MCA, we are getting

127: ======================================================================
127: ERROR: testAnalysis (plugin_tests.mean_contour_analysis_test.MeanContourAnalysisTestCase)
127: ----------------------------------------------------------------------
127: Traceback (most recent call last):
127:   File "/home/travis/build/girder/plugins/minerva/plugin_tests/mean_contour_analysis_test.py", line 247, in testAnalysis
127:     outputs = romanesco.run(romAnalysis, data['inputs'], data['outputs'])
127:   File "/home/travis/virtualenv/python2.7.9/src/romanesco/romanesco/utils.py", line 285, in wrapped
127:     return fn(*args, **kwargs)
127:   File "/home/travis/virtualenv/python2.7.9/src/romanesco/romanesco/init.py", line 268, in run
127:     auto_convert=auto_convert, validate=validate, **kwargs)
127:   File "/home/travis/virtualenv/python2.7.9/src/romanesco/romanesco/plugins/spark/pyspark_executor.py", line 31, in run
127:     exec task["script"] in custom.dict
127:   File "", line 231, in
127:   File "/home/travis/build/girder/clients/python/girder_client/init.py", line 613, in downloadFile
127:     headers={'Girder-Token': self.token})
127:   File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/api.py", line 69, in get
127:     return request('get', url, params=params, **kwargs)
127:   File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/api.py", line 50, in request
127:     response = session.request(method=method, url=url, **kwargs)
127:   File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/sessions.py", line 468, in request
127:     resp = self.send(prep, **send_kwargs)
127:   File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/sessions.py", line 597, in send
127:     history = [resp for resp in gen] if allow_redirects else []
127:   File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/sessions.py", line 195, in resolve_redirects
127:     **adapter_kwargs
127:   File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/sessions.py", line 576, in send
127:     r = adapter.send(request, **kwargs)
127:   File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/adapters.py", line 433, in send
127:     raise SSLError(e, request=request)
127: Exception: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:581)

For the contour analysis test, the error we are getting is that output_dir is not defined.  I suspect that there is some other exception (probably the same SSL type error most likely here) getting thrown, and when the finally block runs, output_dir hasn't been defined.
Travis is also not showing the status of the builds in the PR, so it is helpful to go to
https://travis-ci.org/Kitware/minerva/builds

I've started looking into this on a separate branch - something about this PR and my force push destroyed Travis for it. Will update once it's finished.

What I'm curious about is why there is an ssl error there at all.  That request to the local girder instance shouldn't even be using ssl right?

We're having a number of issues with Travis right now - but the changes from this branch were placed in #153 which built and merged successfully.


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.#
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Changes made to insure user name begins with a letter.


check: Un-sigmap the check command

I suspect there are hidden issues with module connections being made in the reverse order. That is, with some passes making the connections in the reverse order and other passes expecting the RHS of connections to be the driver.
The change here modifies the check command not to rely on sigmap, instead considering the connections explicitly. So it catches cases like
module top;
	wire a, b, c;
	assign a = b;
	assign a = c;
endmodule

which are not caught otherwise.

From the Jenkins log:
make[1]: Entering directory '/var/lib/jenkins/workspace/Yosys-PR/tests/techmap'
Warning: multiple conflicting drivers for top.\o:
    assignment of $not$<<EOT:3$1100_Y
    assignment of $abc$1186$o
Warning: multiple conflicting drivers for top.\w:
    assignment of $and$<<EOT:2$1099_Y
    assignment of $abc$1186$w
ERROR: Found 2 problems in 'check -assert'.
make[1]: *** [run-test.mk:6: abc9.ys] Error 1

I guess the suspicion was right?

IIRC there were some additional issues related to not using sigmap there. Talk to Claire maybe?

i'm all for adding that functionality to check, but can we add the following two options, instead of changing the default behavior?
    -alias
        Interpret wire-to-wire connections as directionless aliases.
        (This is currently the default behavior.)

    -conn
        Interpret wire-to-wire connections as directional buffers.
        (This may be made the default behavior in the future.)

Note: You can define sigmap as following to turn sigmap() into a no-op when in conn_mode:
    SigMap sigmap(conn_mode ? nullptr : module);

Another case currently not caught by check (stumbled on by @mattvenn):
module top;
	wire a;
	assign a = 0;
	assign a = 1;
endmodule

With the change here it's caught:
Checking module top...
Warning: multiple conflicting drivers for top.\a:
    assignment of 1'0
    assignment of 1'1
Found and reported 1 problems.


fix: Normalize keys of headers from server side requests

fixes [edit: unclear that this solves this issue?] #1127
also fixes the so called body parsing bug that currently needs to be mitigated by adding the following line to some server side routes
if (typeof request.body === 'string') request.body = JSON.parse(request.body);
Before submitting the PR, please make sure you do the following

[ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[ ] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

Thank you, though I'm unclear on how this would solve #1127? Lowercasing headers for consistency makes sense, but I think it probably needs to happen here... https://github.com/sveltejs/kit/blob/5d8146fd2909ed2828860327a46a226cf7c80f74/packages/kit/src/runtime/server/index.js#L31-L34 ...using this helper: https://github.com/sveltejs/kit/blob/5d8146fd2909ed2828860327a46a226cf7c80f74/packages/kit/src/runtime/server/endpoint.js#L45-L55
Can you add a test that would fail without this PR, and a changeset? The PR template is there for a reason :)

Thank you, @Rich-Harris. Unfortunately, I'm unable to add the test. It's kind of difficult to reproduce the issue. Without this PR I'm getting the same stack trace as posted on the issue #1127, once I visit the site on localhost:3000, but on a project that I cannot disclose.
If I add just console.log('incoming.headers', incoming.headers); I get the following.
user@debian:~/buggy-site$ npm run dev

><EMAIL_ADDRESS>dev /home/user/buggy-site
> svelte-kit dev

  SvelteKit v1.0.0-next.85

  local:   http://localhost:3000
  network: not exposed

  Use --host to expose server to other devices on this network

incoming.headers {
  'Content-Type': 'application/json',
  cookie: undefined,
  authorization: undefined
}
TypeError: Cannot read property 'split' of undefined
    at parse_body (file:///home/user/buggy-site/node_modules/@sveltejs/kit/dist/ssr.js:1333:60)
    at ssr (file:///home/user/buggy-site/node_modules/@sveltejs/kit/dist/ssr.js:1456:9)
    at fetch (file:///home/user/buggy-site/node_modules/@sveltejs/kit/dist/ssr.js:700:30)
    at load (/home/user/buggy-site/src/routes/[list]/[page].svelte:13:21)
    at load_node (file:///home/user/buggy-site/node_modules/@sveltejs/kit/dist/ssr.js:788:30)
    at respond (file:///home/user/buggy-site/node_modules/@sveltejs/kit/dist/ssr.js:1010:21)
    at async render_page (file:///home/user/buggy-site/node_modules/@sveltejs/kit/dist/ssr.js:1158:20)
    at async render (file:///home/user/buggy-site/node_modules/@sveltejs/kit/dist/ssr.js:1475:10)
    at async ssr (file:///home/user/buggy-site/node_modules/@sveltejs/kit/dist/ssr.js:1462:10)
    at async Immediate.<anonymous> (file:///home/user/buggy-site/node_modules/@sveltejs/kit/dist/chunks/index.js:3301:23)

When I add the same change proposed in this PR and leave the console.log in there, I get the following.
user@debian:~/buggy-site$ npm run dev

><EMAIL_ADDRESS>dev /home/user/buggy-site
> svelte-kit dev

  SvelteKit v1.0.0-next.85

  local:   http://localhost:3000
  network: not exposed

  Use --host to expose server to other devices on this network

incoming.headers {
  'content-type': 'application/json',
  cookie: undefined,
  authorization: undefined
}

If you need more info, please, let me know.  I realize the PR totally looked like a code butchering attempt at the time of your last comment, but thanks to @rawtaz this PR now looks much better.

The current changes have been rebased on master and should be conflict-free, but it seems that the Windows test has a problem launching Chrome: 117: browserType.launch: Failed to launch chromium because executable doesn't exist at C:\Users\runneradmin\AppData\Local\ms-playwright\chromium-857950\chrome-win\chrome.exe
I'm not sure neither @phaleth nor I can do anything about that, what do you think @Rich-Harris?

tried to make edits on this branch but it seems github PRs can't properly track branch relationships across forks, and so this turned into a mess of all the recent commits on master. So I had to git merge --squash locally, which means this is merged, but I still have to close this manually: b4d0d6c6ef4b96f380e7918c35944cda7e6ea1f5
thank you!


Even faster enums

Python's IntEnums are even faster to hash and compare than our HashEnum, but are gross because they inherit int.__str__ and int.__eq__. The latter causes some annoying issues, e.g. EnumA.FOO == EnumB.BAR == some_int can be true.
Turns out this is fairly easy to work around by overriding auto() to be globally unique. Still have to be careful about comparing enums to ints, but tinygrad code doesn't do that.
This makes stuff another ~5% faster.

Sadly can't do [run_process_replay] because this changes how the enums are pickled

Nice! Crazy how much gain there was to be had here


Maybe type is now an opt-in extension

@solnic pls, have a look. Especially on that resolve_missing_value trick

it seems private constants don't work well enough on rbx

It would be good to separate specs for this extension, so we'd need to put its suite under spec/extensions/maybe and extend spec task to run the whole suite (along with its additional specs) so that we can run the suite with and without the extension loaded. WDYT?

@solnic I agree completely, I made the PR to let you merge it and release a new gem version before reworking specs structure, because this is a dry-v dependency and the later more or less is ready to go afaik. I'm going to work on specs during this day

I never used this feature even though I knew it exists. I'm not against it
but if it causes issues then it doesn't feel like it's worth the effort tbh.
On 17 September 2016 at 17:07:22, John Backus<EMAIL_ADDRESS>wrote:

@backus commented on this pull request.
In lib/dry/types/hash/schema.rb
https://github.com/dry-rb/dry-types/pull/147:

@@ -149,8 +149,6 @@ def resolve(hash)
end
end
end

 private_constant(*constants(false))

Alrighty. I played with rubinius and found that you are able to do private_constant(:Foo,
:Bar) but my trick to do private_constant(*constants(false)) doesn't work
(the latter privatizes all constants already defined in the current scope).
Anyways yes nothing is truly private in ruby and even with private
constants you can still do const_get. Ping me if you think there is no
way to keep them private. I put work into these classes and wanted to
clarify their interface too which is why I chimed in here.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dry-rb/dry-types/pull/147, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAEKgwIRwzfjuXkoZQDUCJlcPzM1mt1ks5qrGSagaJpZM4J-wRg
.

I never used this feature even though I knew it exists. I'm not against it but if it causes issues then it doesn't feel like it's worth the effort tbh.

Shouldn't be an issue using the explicit version (private_constant(:Foo)) instead of the dynamic trick I was doing (private_constant(*constants(false)))

@solnic I added a new rake task and configured rspec to run specs twice, take a look https://github.com/dry-rb/dry-types/pull/147/files#diff-52c976fc38ed2b4e3b1192f8a8e24cffR6

@backus fyi, that's what fails on rubinius and works on mri and jruby:
module Foo
  module Bar
  end
  private_constant :Bar

  Bar # => Bar

  module Bar # => Private constant: Foo::Bar (NameError)
  end
end

Huh strange that rubinius has such different behavior

Please just remove this. This PR is blocking the release and this constant visibility has very little value at the moment.

@solnic we already solved the issue, this was a side remark only :) feel free to merge it unless you have any further comments
PS I'll file an issue in rubinius' tracker later today

@flash-gordon thanks, could you update the changelog in master?

@solnic done 🎉 !


dynamic pages end up without filename extension after build

I am using proxy to generate dynamic pages based on yaml data:
data.portfolio.projects.each do |p|
  proxy "/projects/#{p.client.name.parameterize}/#{p.title.parameterize}", "/projects/show.html", locals: { project: p }, ignore: true
end

Also I'm using directory indexes:
configure :development do
  activate :directory_indexes
  […]

configure :build do
  activate :directory_indexes
  […]

During DEV mode everything works nicely, however when I build my middleman project all my generated pages are nested false, named false and are missing a filename extension. Instead of build/projects/clientname/projectname/index.html I end up with build/projects/clientname/projectname (file with no extension).
I'm using middleman 4.0.0.beta.2.

Definitely add .html to your proxy output path. Directory index will see that and correctly rename.

I tried adding .html but unfortunately directory_indexes won't rename accordingly during build, the filename extension stays. Also during development my routes (/projects/clientname/projectname) stopped working.

Hmm, probably an ordering issue in v3. I guess add /index.html for now.

This problem still exists unfortunately in Middleman 4.2.1

@dkastl Given that this ticket is ~3 years old. Can you please open a new ticket with a reproducible test case?
Also, can you test against the current beta release: 4.3.0.rc.3


Add constraint identifiers as an option during ConstraintMaker finalization.

New Issue Checklist

[X] I have looked at the Documentation
[X] I have read the F.A.Q.

Environment / Configuration
Platform

[X] OS X
[X] iOS

Versions

Platform version is: iOS 9.0
SnapKit version is: 0.19.1

Integration

[ ] Carthage
[X] Cocoapods
[ ] Manually / Other

Issue
Having identifiers on constraints allows for easier debugging when constraints are broken:
http://useyourloaf.com/blog/using-identifiers-to-debug-autolayout/
I was hoping for a solution to add identifiers to each constraint. as part of the ConstraintMaker syntax.
My thought was to add a method:
`func identifiedAs(string: String) -> ConstraintDescriptionFinalizable`

to ConstraintDescriptionFinalizable
as well as a variable to ConstraintDescription leaving it optional, and adding the actual setting of the NSLayoutConstraint property in installOnView.
If thats ok with you i can make a pull request as soon as I'm done testing it.

:+1: Sounds good to me!


Feature/docs

@mjkoo can you please document in readme whether or not deploy with existing contracts in consul is safe /idempotent?