Issue with ZZH on ESXi 6.7 with USB passthrough

I cannot get ZZH to work on ESXi 6.7 passthrough. After inserting a flashed (on another computer) stick with the latest firmware (znp_CC26X2R1_LAUNCHXL_tirtos_ccs)
I an getting:
[  316.939929] usb 2-2.2: ch341-uart converter now attached to ttyUSB0
which is fine, but already at this point when I'm trying to run znp-uart-test.py script I am getting:
./znp-uart-test.py
Got 0 bytes in response to PING command: b''
FAIL|Expected length mismatch

But the things get worse when I'm trying to run Zigbee2MQTT on this machine - Z2M fails to connect to the adapter and dmesg shows a lot of -110 errors on that interface. I also tried connecting the stick through a powered USB hub and after even more of -110 errors the hub just switched off the port (seems like some kind of failsafe).
Ive got several other USB devices connected to that server (including RFlink which uses same ch341-uart driver) and USB passthrough works perfectly fine with all of them.

Same here

@Zuse2k donypu remember what have you done? Im still struggling with this, reflashed the stick multiple times and went back to using conbee

I've exactly the same issue with my new ZZH stick flashed with CC26X2R1_20201026.hex.

I've exactly the same issue with my new ZZH stick flashed with CC26X2R1_20201026.hex.

Uses zigbee2mqtt as LXC - Linux container without usb pass through.
i don’t have anymore this issue.
For promox, use this guide:
https://www.martinellis.me/posts/2020/03/zig-a-zig-ah/

Uses zigbee2mqtt as LXC - Linux container without usb pass through.
i don’t have anymore this issue.
For promox, use this guide:
https://www.martinellis.me/posts/2020/03/zig-a-zig-ah/

Same issue here with esxi 7.0.1. Anyone tried to pass-through the usb controller ?
[mer. févr.  3 00:14:26 2021] ch341-uart ttyUSB0: failed to read modem status: -110
[mer. févr.  3 00:15:39 2021] usb 2-2.1: failed to send control message: -110

Same issue here with esxi 7.0.1 (Intel NUC). Anyone tried to pass-through the usb controller ?
[mer. févr. 3 00:14:26 2021] ch341-uart ttyUSB0: failed to read modem status: -110
[mer. févr. 3 00:15:39 2021] usb 2-2.1: failed to send control message: -110

In my case this error was solved by disabling zigbee2mqtt in HA. As far as I understand you cannot run both zigbee2mqtt and ZHA to use the same USB controller.

a new version of firmware has been released today, could you guys test if it helps (i have loaned my stick to a friend since i couldnt use it myself)

Bumping up to avoid bot

Bump

After many hours of troubleshooting I finally stumbled upon this issue. I also have this exact problem, and have performed quite a bit of troubleshooting. Up until now I have been using the CC2531 which have served me well, but with the continuous Zigbee expansion in my home it was time to upgrade to CC2652R. It was recognized by ESXi as "QinHeng USB Serial" and it's showing up on the guest OS:
ls /dev/serial/by-id/
usb-1a86_USB_Serial-if00-port0

However, the system is not able to access it either through the flashing (Python script) as well as accessing it using Z2M. Also checked with the UART test script and it returns fail as well:
python3 znp-uart-test.py
Got 0 bytes in response to PING command: b''
FAIL|Expected length mismatch

Environment:

Dell R720 server running ESXi 6.7
Virtual machine with HA OS (Same issue)
Virtual machine with Debian (Same issue, tested to eliminate any problems related to HA OS driver support)
Connected USB2 front IO ports, tried with and without extension cable.
RPI3 b+ for testing

Troubleshooting:

Updated all packages and systems to latest version (Except ESXi 6.7 due to licensing)
Went through all the FAQ steps
Restarted VMs multiple times, and re-added the adapter
Tested with RPI3 b+ where it's recognized and the znp-uart-test.py returns success (Also used the ZNP export/import script and it's able to communicate with the ZZH on the RPI)
Verified baud rate
Re-plugged the USB multiple times

Error messages same as mentioned above:
[ 1067.071130] usb 2-2.1: failed to receive control message: -110
[ 1870.349380] usb 2-2.1: failed to send control message: -110
[ 1872.351184] usb 2-2.1: failed to send control message: -110
[ 1874.356063] usb 2-2.1: failed to receive control message: -110

Flashed with the latest version, using Flash Programmer 2 no errors. FYI @Dinth
If you would like me to test any further please let me know, otherwise I will migrate back to the CC2531 as a temporary solution.

This is most probably not a firmware issue because of the way these sticks are put together. Borrowing this block diagram from the zzh quick start guide:

As far as the WMCU (and the firmware in question) is concerned, they are just speaking through UART as CC1352/CC2652 series of chips do not have USB (unlike CC2531) and rely on an external chip to do the conversion. In the case of zzh, this is the CH340.
Given that firmware has no direct control/interaction with USB at all, and the fact that testing out of the virtualised environment works just fine, this points the finger directly at ESXi. Specifically the drivers in use or perhaps the interaction between the host USB controller and the ESXi bypass mechanism. Given that there are people who managed to get their setup going on ESXi, I am wondering if we are seeing some sort of ESXi host controller bypass bug type of issue here?

Given that firmware has no direct control/interaction with USB at all, and the fact that testing out of the virtualised environment works just fine, this points the finger directly at ESXi. Specifically the drivers in use or perhaps the interaction between the host USB controller and the ESXi bypass mechanism. Since there are people who managed to get their setup going on ESXi, I am wondering if we are seeing some sort of ESXi host controller bypass bug type of issue here?

Fair point, but what's intriguing me is that other devices ive got which are using CH340/1 chip are working fine under ESXi. Also i have tried to google for issues with CH340 support on ESXi and havent found any other reports of devices not working under ESXI.

That is indeed curious and makes me think that maybe there are different versions of CH340 that work differently with the drivers ESXi provides. It's not uncommon that these chips have different revisions. Then again, given that there are working installations out there this is not a strong theory.
A bit of a tall order but wondering if there is any chance you can try and replicate this on another system that has different USB host controllers. This is essentially the USB on the motherboard of the host. Alternatively, if folks having this issue can report what they have here we can see if there is a pattern.

Definitely sounds like an ESXi 6.7 issue yes. I think we should do some more testing on 7.0, do you still have this issue @christophebonnay? Also I found this, might be somewhat relevant:

Reddit thread
And this message from Discord:

I think I read somewhere that the Linux kernel 5.x has some bugfixes for the CH340 (the usb-serial chip in the zzh) so if you are trying it on another Linux box, make sure the kernel version isn't the same. I'm stuck with 4.x on my server and on occasion the zzh doesn't work the first time it's plugged in but other than that it works just fine.

I'm aware ESXi is not based on the Linux kernel anymore, but it might be worth to be aware of here. I have been able to confirm people used pass-through on Proxmox (kernel 5.3 atm) with no issues at all.
For testing on other systems, I have 2x Dell r210ii servers (ESXi 6.7) and will try to replicate the issue on them as well. If this does not work I might be able to get my hands on ESXi 7.0.

Another much simpler variable to check is the OS or more specifically the kernel version you are running for the guest OS as well. This might actually be the easiest starting point.

Debian Buster 10  kernel 4.19.0-14-amd64
Unfortunately, i dont have another host i could use to test it on a different motherboard.

The different kernels I tried before was on HA OS (kernel 5.4.99) and Debian 10 (buster) 4.19.0-8-amd64.
Test on different host (Dell R210ii, ESXI 6.7)
VM: Debian 10 (buster) 4.19.0-8-amd64

Recognized as QinHeng USB Serial in ESXi
Connected to VM and booted it:

ls /dev/serial/by-id/usb-1a86_USB_Serial-if00-port0
/dev/serial/by-id/usb-1a86_USB_Serial-if00-port0

Ran znp-uart test with PASS:

python znp-uart-test.py
Got 7 bytes in response to PING command: b'\xfe\x02a\x01Y\x06='
PASS|OK

Trying to run the zigby/znp script to doublecheck connectivity. This fails due to not being able to open the port:

python3 -m zigpy_znp.tools.network_backup /dev/serial/by-id/usb-1a86_USB_Serial-if00-port0 -o network_backup.json
Traceback (most recent call last):
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/serial/serialposix.py", line 322, in open
    self.fd = os.open(self.portstr, os.O_RDWR | os.O_NOCTTY | os.O_NONBLOCK)
OSError: [Errno 5] Input/output error: '/dev/serial/by-id/usb-1a86_USB_Serial-if00-port0'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/runpy.py", line 193, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/zigpy_znp/tools/network_backup.py", line 107, in <module>
    asyncio.run(main(sys.argv[1:]))  # pragma: no cover
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/asyncio/runners.py", line 43, in run
    return loop.run_until_complete(main)
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/asyncio/base_events.py", line 612, in run_until_complete
    return future.result()
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/zigpy_znp/tools/network_backup.py", line 99, in main
    backup_obj = await backup_network(
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/zigpy_znp/tools/network_backup.py", line 23, in backup_network
    await znp.connect()
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/zigpy_znp/api.py", line 219, in connect
    self._uart = await uart.connect(self._config[conf.CONF_DEVICE], self)
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/zigpy_znp/uart.py", line 158, in connect
    transport, protocol = await serial_asyncio.create_serial_connection(
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/serial_asyncio/__init__.py", line 445, in create_serial_connection
    serial_instance = serial.serial_for_url(*args, **kwargs)
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/serial/__init__.py", line 90, in serial_for_url
    instance.open()
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/serial/serialposix.py", line 325, in open
    raise SerialException(msg.errno, "could not open port {}: {}".format(self._port, msg))
serial.serialutil.SerialException: [Errno 5] could not open port /dev/serial/by-id/usb-1a86_USB_Serial-if00-port0: [Errno 5] Input/output error: '/dev/serial/by-id/usb-1a86_USB_Serial-if00-port0'

Trying the znp-uart script again and now it fails:

python znp-uart-test.py
Traceback (most recent call last):
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/serial/serialposix.py", line 322, in open
    self.fd = os.open(self.portstr, os.O_RDWR | os.O_NOCTTY | os.O_NONBLOCK)
OSError: [Errno 5] Input/output error: '/dev/ttyUSB0'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "znp-uart-test.py", line 28, in <module>
    ser = serial.Serial("/dev/ttyUSB0", 115200, timeout=2)
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/serial/serialutil.py", line 244, in __init__
    self.open()
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/serial/serialposix.py", line 325, in open
    raise SerialException(msg.errno, "could not open port {}: {}".format(self._port, msg))
serial.serialutil.SerialException: [Errno 5] could not open port /dev/ttyUSB0: [Errno 5] Input/output error: '/dev/ttyUSB0'

Rebooting the host to try again, same thing happens:

First it passes:
python znp-uart-test.py
Got 7 bytes in response to PING command: b'\xfe\x02a\x01Y\x06='
PASS|OK

Then fails:
python znp-uart-test.py
Traceback (most recent call last):
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/serial/serialposix.py", line 322, in open
    self.fd = os.open(self.portstr, os.O_RDWR | os.O_NOCTTY | os.O_NONBLOCK)
OSError: [Errno 5] Input/output error: '/dev/ttyUSB0'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "znp-uart-test.py", line 28, in <module>
    ser = serial.Serial("/dev/ttyUSB0", 115200, timeout=2)
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/serial/serialutil.py", line 244, in __init__
    self.open()
  File "/root/.pyenv/versions/3.8.1/lib/python3.8/site-packages/serial/serialposix.py", line 325, in open
    raise SerialException(msg.errno, "could not open port {}: {}".format(self._port, msg))
serial.serialutil.SerialException: [Errno 5] could not open port /dev/ttyUSB0: [Errno 5] Input/output error: '/dev/ttyUSB0'

While this test ran the same error messages as before showed up:
[   39.670977] usb 1-2.1: failed to send control message: -110
[   41.674944] usb 1-2.1: failed to send control message: -110
[   53.801916] usb 1-2.1: failed to send control message: -110
[   55.805584] usb 1-2.1: failed to send control message: -110
[   57.810249] usb 1-2.1: failed to receive control message: -110
[   57.810274] ch341-uart ttyUSB0: failed to read modem status: -110

@davidusken Out of curiosity, any errors reported on the host logs?

Surprisingly nothing, maybe @Dinth is able to see something?

I havent found anything either in /var/log on the host, but dont take my word for it, as im not very proficient in ESXi

I had the same issue, ZZH on ESXi 7.0.1 USB passthrough to a Debian based iobroker installation.
Either the stick wasn't recognized, or if it was, it wasn't very stable and the communication stopped after some hours.
Also had the failed to read modem status messages etc.
Reverted back to my old 2531 stick

I'm following the topic even if I'm not concerned actually.
Do you force USB ports to be always on on Host/Guest side ?
You can check it with:
grep . /sys/bus/usb/devices/*/power/control
control content value can be "on" for 'always on' or "auto" for 'auto-suspend'.
It is possible that the usb port get in suspend state and so lost power supply.

Ehh, bad bot!

I've exactly the same issue with my ZZH stick flashed with latest CC2652R_coordinator_20210708.hex. Any progress? I use ESXi 6.7.

@jokejoke I didn't get to manage the issue but I made a workaround with a raspberry pi. Did plug ZZH into RPi and made a ser2net socket to pipe serial usb over ethernet vlan to the vm which utilizes ZZH. Works so far stable and reliable.
Did not try so far if ZZH via usb passthrough works with ESXI 7 - VMware changed some major things afaik - probably you can give this also a try.

@jokejoke I didn't get to manage the issue but I made a workaround with a raspberry pi. Did plug ZZH into RPi and made a ser2net socket to pipe serial usb over ethernet vlan to the vm which utilizes ZZH. Works so far stable and reliable.

On bare metal with Debian and HomeAssistant I have no problem. It looks like some problem only with virtualization ESXi (6.7 and 7.0.2) USB 2.0 controller. I have older HW (HP Prodesk 400 G3 mini).

for those on exsi, i found changing usb controller for the VM to usb3.1 controller help ch340

Thank you so much @luckybruce your solution worked for me on esxi 7.0 !


OpenVINO documentation updates

dynamic shapes are now supported on GPU  (but static shapes can still be recommended for performance improvements)
FP16 inference precision is now default on GPU (no longer needed to do .half())
ov_config and model caching
link to GPU driver install instructions
reword seq2seq section to clarify that use_cache is the default

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Drop Python 3.9

coverage: 98.896% (-0.002%) from 98.898%
when pulling 7c080d40aa4a72cd1aa2dd5ac168fc726f38f886 on tomwhite:drop-python-3.9
into 013687f18b4b48f79f81da32976ccd85db731ba3 on sgkit-dev:main.


Fix behavior difference between tf.io.GFile and python file for utf8

This PR tries to address the issue raised in #33563 where
tf.io.GFile behavior is different from python file for utf8.
The issue was that tf.io.GFile's read does not take utf8 into
consideration for non binary mode.
This PR fixes the discrepancy.
This PR fixes #33563
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

@yongtang  Can you please resolve conflicts? Thanks!

@yongtang  Can you please resolve conflicts? Thanks!

Thanks @mihaimaruseac @gbaned for the review and sorry for the late response as the notice slipped through. The PR has been rebased and updated and the review comment has also been addressed. Please take a look.

Thanks @mihaimaruseac @gbaned for the review and sorry for the late response as the notice slipped through. The PR has been rebased and updated and the review comment has also been addressed. Please take a look.

@yongtang Can you please check @mihaimaruseac's comments and keep us posted ? Thanks!

Hi @yongtang I'm going to go ahead and close this PR, because it seems to have stalled. If you're still interested in pursing this (and responding to my comments), please feel free to reopen! thank you for your contribution.


Support configuring release body

Currently hardcoded to ### ❤ Thanks to all contributors! ❤

Can be changed by the config already: https://github.com/woodpecker-ci/plugin-ready-release-go/blob/main/src/utils/types.ts#L55


Typo "Azure pipeline"→"Azure Pipeline"

https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops&tabs=schema%2Cparameter-schema
#PingMSFTDocs

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

The original is correct because it refers to an instance, not to the Azure service. We'll close; thanks.


FDE/CVM kernel installation fixes

File '/boot/efi/EFI/ubuntu/grubx64.efi' no longer exists.
Each installed kernel will have its '.efi' file under '/boot/efi/EFI/ubuntu/'. Ex: /boot/efi/EFI/ubuntu/kernel.efi-6.2.0-1019-azure.
Copying .efi files between '/usr/lib/linux/efi/' and '/boot/efi/EFI/ubuntu/' is no longer needed.

@LiliDeng LGTM


axios SSRF vulnerability fix

The current version of vue-mc was published with a dependency on axios 0.19.0.  There was an npm advisory that was published today indicating a vulnerability in axios versions below 0.21.1 (https://www.npmjs.com/advisories/1594).
Is vue-mc compatible with axios version greater than 0.19.0?  Will vue-mc be updated to address this axios vulnerability?

You can use your custom Axios instance.

You can use your custom Axios instance.

Thanks for the update.
Good to know.  I wasn't sure if it was compatible with the newer axios release.

Thanks for the update.
Good to know.  I wasn't sure if it was compatible with the newer axios release.

I cannot get this to work, as I have a CVE scan on commit in my code.  It doesn't accept vue-mc's axios dependency being on 0.19.0.  Is there any way to update this sub-dependency?

I cannot get this to work, as I have a CVE scan on commit in my code.  It doesn't accept vue-mc's axios dependency being on 0.19.0.  Is there any way to update this sub-dependency?


addPolyline

Would love to be able to repopulate the paths into pather without triggering 'created'.
So currently the only way is to use createPath which triggers the 'created' event. But I already have the polylines and would just like to add them. So having something like:
pather.addPolyline(polyline)
// `polyline` is instance of `L.Pather.Polyline`
// this triggers 'added' event instead

The alternate approach is to check every latlng of every line against a current list to make sure duplicates aren't added.
I also tried pather.polylines.push(polyline) but the line isn't added to the map for some reason.
I'll submit a PR if this sounds like something you'd 📦

Found a workaround for now:
markup.forEach(item => {
  pather.polylines.push(item.polyline);
  item.polyline.redraw(item.polyline.edges);
});

Do you think an optional second argument to createPath would be acceptable?
createPath([...], false);

@Wildhoney totally


Nightly ThreadNet broken by recent package reorg

I overlooked this in my review: the relevant tests were moved from ouroboros-consensus-cardano to ouroboros-consensus-cardano-test.
This Issue is to update the nightly test to use the up-to-date Nix attribute.

This failed in https://buildkite.com/input-output-hk/ouroboros-network-nightly/builds/213 and https://buildkite.com/input-output-hk/ouroboros-network-nightly/builds/214

Ah, linked the PR seconds too late. Closing as fixed!


[T3A4][W10-A4] Wang Ming Rui

Ready for review, I didn't make a branch from master for T3, will do that for T4!

As mentioned during the lecture, the program in the original form continues to work even when the file is deleted by creating a new file; so the use of an exception might be questionable.
Anyway, here is some general feedback on how an exception can be used.  There are generally two ways to do this:

Terminate if the file is deleted. This is the straightforward approach, but it degrades the user experience. The exception should be thrown from StorageFile::save() method. The best place to catch and terminate is Main::executeCommand() (this method already has a catch block to terminate upon exception.

Warn but continue. Need to detect the file deletion at the beginning of the StorageFile::save() method but throw the exception at the end of the method. It should be caught in Main::executeCommand() but should show a warning to the user instead of terminating program.

Also, one should not use exceptions to replace the normal workflow (e.g., using exception in place of if … else)


chore: release 5.2.0

:robot: I have created a release *beep* *boop*
5.2.0 (2019-07-17)
Features

add path template parsing for billing, organizations, and folders (#529) (1e8c67f)

This PR was generated with Release Please.

Release is at https://github.com/googleapis/nodejs-logging/releases/tag/v5.2.0

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


host_rewrite_header not working in istio config

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities
To ask questions about how to use Istio, please visit https://discuss.istio.io)
Bug description
This my external request call:  curl -H "x-fw-real-host: mavericksv3nw1045.xyz.com"  http://subdomain.xyz.internal/api/channels
For this external request, I try to overwrite the host header subdomain.xyz.internal by this custom header value x-fw-real-host and at same time my endpoint has to be changed based on the same custom header. Say for this mavericksv3nw1045.xyz.com, I need to make a call to mavericks.xyz.internal instead of subdomain.xyz.internal
[ ] Docs
[ ] Installation
[x ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
[ ] Upgrade
Expected behavior
I tried to achieve that via the combination of lua filter + Virtual service. But I need that Lua filter needs to be run post Virtual service match.
Steps to reproduce the bug

Create a service entry & virtual service for external service request
[This will set the destination endpoint as mavericks.xyz.internal]

apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: xyz
  namespace: istio-system
spec:
  hosts:
  - subdomain.xyz.internal
  location: MESH_EXTERNAL
  ports:
  - name: http
    number: 80
    protocol: HTTP
  resolution: DNS

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: xyz-external-routes
  namespace: istio-system
spec:
  hosts:
    - subdomain.xyz.internal
  http:
  - match:
    - port: 80
      headers:
        x-fw-real-host:
          regex: ".*mavericksv3.*"

    route:
    - destination:
        host: mavericks.xyz.internal
        port:
          number: 90
      weight: 100

Envoy filter with lua
[This will get the value of custom header and override the authority header]

apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: outbound-filter
  namespace: istio-system
spec:
  configPatches:
    - applyTo: HTTP_FILTER
      match:
        context: SIDECAR_OUTBOUND
        listener:
          portNumber: 80
          filterChain:
            filter:
              name: envoy.http_connection_manager
              subFilter:
                name: envoy.router
      patch:
        operation: INSERT_AFTER
        value:
          name: envoy.lua
          typed_config:
            '@type': type.googleapis.com/envoy.config.filter.http.lua.v2.Lua
            inlineCode: |
              -- add a version to ensure the config's been swapped out while iterating on code changes
              function version()
                  return "v1"
              end
              function logWarn(handle, value)
                  handle:logWarn(version() .. ": " .. value)
              end

              function envoy_on_request(request_handle)
                  logWarn(request_handle, "START DISPLAYING REQUEST HEADERS")
                  local log_headers = request_handle:headers()

                  hostName = log_headers:get("x-fw-real-host")
                  log_headers:replace(":authority", hostName)
                  logWarn(request_handle, "END DISPLAYING REQUEST HEADERS")
              end

Tried with different options like INSERT_AFTER /INSERT_BEFORE/MERGE but it's not getting apply after the above virtual service match. So I am unable to achieve my expected request handle.
Version (include the output of istioctl version --remote and kubectl version --short and helm version --short if you used Helm)
client version: 1.5.8
control plane version: 1.5.8
data plane version: 1.5.8 (49 proxies)
How was Istio installed?
Through Istioctl command
     --set values.gateways.istio-ingressgateway.type=NodePort \
     --set values.grafana.enabled=true \
     --set values.tracing.enabled=true \
     --set values.kiali.enabled=true \
     --set values.prometheus.enabled=true \
     --set values.kiali.dashboard.jaegerURL=http://jaeger-query:16686 \
     --set values.kiali.dashboard.grafanaURL=http://grafana:3000 > $HOME/install_istio.yml

   kubectl apply -f $HOME/install_istio.yml

Environment where the bug was observed (cloud vendor, OS, etc)
AWS EKS Amazon Linux
Additionally, please consider running istioctl bug-report and attach the generated cluster-state tarball to this issue.
Refer cluster state archive for more details.
https://gist.github.com/VinothChinnadurai/419e8db690ff0c9d169328cb2ba25232#file-gistfile1-txt-L15291
https://gist.github.com/VinothChinnadurai/419e8db690ff0c9d169328cb2ba25232#file-gistfile1-txt-L24978

@ramaraochavali @gargnupur @songford @bianpengyuan  can anybody help me out on this. We blocked due to this

why use lua filter instead of https://istio.io/latest/docs/reference/config/networking/virtual-service/#HTTPRewrite

@bianpengyuan  Yeah you are right, but I want that :authority header has to be overwritten based on whatever value given in x-fw-real-host. We cant set the value dynamically in HTTPRewrite right.. correct me if I am wrong?

@bianpengyuan Yeah you are right, but I want that :authority header has to be overwritten based on whatever value given in x-fw-real-host. We cant set the value dynamically in HTTPRewrite right.. correct me if I am wrong?

I see, yeah that makes sense. Sorry I am not familiar with lua filter, not sure how to troubleshoot this.

oh.. Not a problem. Thanks for your quick responses 👍 . Can somebody else help me out here? @ramaraochavali

Hey folks, Tried out this and it looks its fixing the problem
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: external-routes
  namespace: istio-system
spec:
  hosts:
    - xyz.abc.internal
  http:
  - match:
    - headers:
       x-fw-real-host:
         regex: .*mavericks.*
    route:
    - destination:
        host: xyz1.abc.internal
        port:
          number: 90
      weight: 100
  - match:
    - port: 80
    route:
    - destination:
        host: xyz.abc.internal
        port:
          number: 80
      weight: 100

-------

apiVersion: networking.istio.io/v1alpha3
kind: EnvoyFilter
metadata:
  name: host-rewrite
  namespace: istio-system
spec:
  configPatches:
    - applyTo: HTTP_ROUTE
      match:
        routeConfiguration:
          vhost:
            name: "xyz.abc.internal:80"
            route:
              action: ANY
      patch:
        operation: MERGE
        value:
            route:
              auto_host_rewrite_header: x-fw-real-host

Thanks again for quick response @bianpengyuan & everyone :)

@ramaraochavali @gargnupur @songford @bianpengyuan - The above filter @VinothChinnadurai mentioned was working for istio 1.5.8 but these configuration is not working on istio 1.9.5. Is there any changes we have to make to the below filter for it to work in version 1.9
kind: EnvoyFilter
metadata:
  name: host-rewrite
  namespace: istio-system
spec:
  configPatches:
    - applyTo: HTTP_ROUTE
      match:
        routeConfiguration:
          vhost:
            name: "xyz.abc.internal:80"
            route:
              action: ANY
      patch:
        operation: MERGE
        value:
            route:
              auto_host_rewrite_header: x-fw-real-host

Sorry Guys it seems to be a change in option at Envoy. For anyone facing this the option auto_host_rewrite_header is now host_rewrite_header in newer version.
metadata:
  name: host-rewrite
  namespace: istio-system
spec:
  configPatches:
    - applyTo: HTTP_ROUTE
      match:
        routeConfiguration:
          vhost:
            name: "xyz.abc.internal:80"
            route:
              action: ANY
      patch:
        operation: MERGE
        value:
            route:
              host_rewrite_header: x-fw-real-host


/analyze occasionally returns issues for flutter web code

The analyze call is sometimes returning errors for flutter_web code. This might be related to https://github.com/dart-lang/dart-pad/issues/1212
Steps to reproduce

execute the following cURL multiple times:

## playground
curl -X "POST" "https://dart-services.appspot.com/api/dartservices/v1/analyze?alt=json" \
     -H 'Sec-Fetch-Mode: cors' \
     -H 'Referer: http://localhost:8080/new_playground.html' \
     -H 'User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36' \
     -H 'Content-Type: text/plain; charset=utf-8' \
     -H 'Accept-Encoding: gzip' \
     -d "{\"source\":\"// Copyright 2018 The Chromium Authors. All rights reserved.\\n// Use of this source code is governed by a BSD-style license that can be\\n// found in the LICENSE file.\\n\\nimport 'package:flutter_web/material.dart';\\nimport 'package:flutter_web_ui/ui.dart' as ui;\\n\\n\\n\\nFuture main() async {\\n  await ui.webOnlyInitializePlatform();\\n  runApp(Center(child: SpinningSquare()));\\n}\\n\\nclass SpinningSquare extends StatefulWidget {\\n  @override\\n  _SpinningSquareState createState() => new _SpinningSquareState();\\n}\\n\\nclass _SpinningSquareState extends State<SpinningSquare>\\n    with SingleTickerProviderStateMixin {\\n  AnimationController _animation;\\n\\n  @override\\n  void initState() {\\n    super.initState();\\n    // We use 3600 milliseconds instead of 1800 milliseconds because 0.0 -> 1.0\\n    // represents an entire turn of the square whereas in the other examples\\n    // we used 0.0 -> math.pi, which is only half a turn.\\n    _animation = new AnimationController(\\n      duration: const Duration(milliseconds: 3600),\\n      vsync: this,\\n    )..repeat();\\n  }\\n\\n  @override\\n  Widget build(BuildContext context) {\\n    return new RotationTransition(\\n        turns: _animation,\\n        child: new Container(\\n          width: 200.0,\\n          height: 200.0,\\n          color: const Color(0xFF00FF00),\\n        ));\\n  }\\n\\n  @override\\n  void dispose() {\\n    _animation.dispose();\\n    super.dispose();\\n  }\\n}\"}"

Ok, this is interesting. We are randomly forgetting to inset flutter_web as a dependency for analysis. I'm tempted to say that we shouldn't be sniffing dependencies, and instead make it an additional argument to the call.
Thoughts @RedBrogdon ?

I updated dart-services and it now looks sane.


fix: The case of the missing tabs

Description
Fixes #33032
Change the data structure of the tabs to now keep account different tabs for each page instead of just one page at a time. Also removed tabs state for focus retention.
Fixes #33045
Handles removing and navigating post move of js and queries to avoid being in a bad state
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!IMPORTANT]
🟣 🟣 🟣 Your tests are running.
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8918984339
Commit: 2964dff6af5646d559376badec973241cadb4009
Workflow: PR Automation test suite
Tags: ``

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

/build-deploy-preview skip-test=true


Doesn't build on current nightly - Please update to serde 0.9

See title.
This involves switching out serde_macros for serde_derive, and changing some of the cfg attribute logic in lib.rs.
What I wasn't able to solve myself was updating the plethora of manual impls for the HashedPassword and HashSalt types. Also: Is it really neccessary to implement all these manually? For example the Eq impl could probably be replaced by a #[derive(Eq)].
I'm currently not at home, but when I get home I might try to look into this further myself. If I make any useful progress, I'll send a PR your way.

Lookin' forward for the PR!
Sadly, I did have to implement the serde and PartialEq stuff manually, as these types are newtypes for quite long arrays. Rust doesn't support generics like Array<char, 64>, which is why Rust only provides trait impls for arrays of up to 32 elements. In case, someone would increase the size of these types (Why not?), passwors wouldn't be able to compile using #[derive(...)]. This includes serde as well, as serde depends on the very same array trait impls.
There was some RFC about generics with values, Pi-types, IIRC, so a change to #[derive(...)] depends on such a Pi-types RFC to be accepted and implemented.


add OpenAQ for air quality endpoints

https://docs.openaq.org/

Hi @sourabhtk37 , feel free to open a pull request with any services you'd like to add to this collection!


Android: works with SQLiteAsyncConnection, explodes with SQLiteConnection

Using the latest version of sqlite-net with a trivial Maui project.
It works like a charm on Windows.
But the emulator crashes without even meager exception if the database is opened with SQLiteConnection. No problems using SQLiteAsyncConnection.
Any pointers appreciated.

Got an exception:
System.IO.FileNotFoundException: 'Could not load file or assembly 'SQLitePCLRaw.provider.dynamic_cdecl, Version=<IP_ADDRESS>6, Culture=neutral, PublicKeyToken=b68184102cba0b3b' or one of its dependencies.'
Note that, again, this only happens with SQLiteConnection but not with SQLiteAsyncConnection, which makes no sense.

Trying to get the locked connection from the async connection via GetConnection() also results in the exception above.

I'm closing this as untrackable and will use async.
Darn.

For anyone else going crazy, this is the freaking problem, the nuget has not been updated to use the latest SQLitePCLRaw.bundle_green.
https://stackoverflow.com/questions/69788033/connection-to-database-cannot-be-resolved


(Maybe) Add second login node

This would be useful for redundancy, but it would have to maintain its own Condor queue, and it would share the same filesystem as the original so it probably isn't that useful.
Instead, perhaps work on making it trivial to move the Condor queue around and being able to easily deploy a backup login node so that in the event of maintenance, one could shift the queue to a new node.

This isn't very useful right now, so closing.


Use NFS server v4.2 in nfs-pv example

We had problems with running the default v4 version, limit on connection pool etc, seems like 4.2 would be a better default

cla signed

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address.  Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at<EMAIL_ADDRESS>

I signed it


[grpc] Set codegen as default feature

Since most users need to use this feature, set it as the default feature.
Fixes #21514.

Since most users need to use this feature, set it as the default feature.

Hmm. No. https://github.com/microsoft/vcpkg/issues/21514 is wrong usage of vcpkg. If you need the codegen feature for reflection be explicit about it.
The case described in 21514  is wrong about two thing. a) using static triplet without defining the host triplet to be also static b) not knowing crosscompilation. strictly speaking x64-windows-static is by vcpkg defaults always a cross triplet and not a native triplet.


Dynamic ruleset collection

This PR provides the possibility to return an iterable of Rules from the test-Functions, so thay you can create dynamic rulesets.
This PR also adds the internal classes TestExtractor to extend a new TestExtractorInterface and RuleValidator to extend a new RuleValidatorInterface, so that the TestParser is testable without the actual classes
New feature:
namespace App\Tests\Architecture;

use PHPat\Selector\Selector;
use PHPat\Test\Builder\Rule;
use PHPat\Test\PHPat;

final class ConfigurationTest
{
    private const DOMAINS = [
        'App\Domain1',
        'App\Domain2',
    ];

    /**
     * @return iterable<string, Rule>
     */
    public function test_domain_independence(): iterable
    {
        foreach(self::DOMAINS as $domain) {
            yield $domain => PHPat::rule()
                ->classes(Selector::inNamespace($domain))
                ->canOnlyDependOn()
                ->classes(Selector::inNamespace($domain));
        }
    }
}

fixes #279

Hi Anna, thank you for the contribution!
Sorry for the late response, I've been out of town.
This is a very interesting feature that would solve the redundance in bounded context rules that has been a recurring question since the beginning. Let me have a look this evening and I will merge and release this ASAP :smiley:


Don't cascade on reload

Fixes #10648.
So this fix is a little fussy.

Ideally we’d simply update the window load settings with the window dimensions before we reload, so that the reloaded window has the same dimensions.

But any changes we make to the window load settings in our beforeunload handler aren’t reflected in the reload. (I suspect Chromium’s grabbing the location for reload before calling the handler?)

So the next best thing: we detect a reload before beforeunload is called and update the window load settings there. This worked for most reloads but I wasn’t able to find a hook for reloads triggered by cmd-r with the dev tools focused. That inconsistency would have been super annoying, to me at least.

So instead we track whether this is the first time the window’s been loaded. If it is, we use the default dimensions. If it isn’t, we use the dimensions we’re already saving in state.

@atom/core I’m curious if I’ve totally overcomplicated this or missed anything obvious.

@maxbrunsfeld and I talked about removing the initial window dimensions from the load settings entirely. I'ma go down that road and see how it works out.

So I went down the road of putting AtomWindow/AtomApplication in charge of dimensions, and found it to have some other catches:

We store the default window dimensions in localStorage (https://github.com/atom/atom/blob/017bd2f716609731d2c927b88f8127cbe44f5c1f/src/atom-environment.coffee#L582). So the browser process can't get to it.
At the same time, in order to cascade windows properly, we have to take into account other windows, which is what passing the dimensions in from AtomApplication gives us.

I'd be really great to stop passing state between the browser and renderer using location, but that's more than I care to bite off for this PR.
@atom/core Any other thoughts? Are we OK with this as-is?

Are we OK with this as-is?

:+1:


⚠ Bofrost.com has degraded performance

In 87da1c1, Bofrost.com (https://www.bofrost.com) experienced degraded performance:

HTTP code: 200
Response time: 1058 ms

Resolved: Bofrost.com performance has improved in d3d9e6a.


push to OSM

As a healthsite administrator I want to push HS locations to OSM so that HS data is available via openstreetmap.org

An MVP approach may be to export updates as a list, and then integrate the changes into OSM in a semi-automated way using existing OSM editing tools like http://maproulette.org/ or https://osmlab.github.io/to-fix/. We can leverage the community to help make the changes in to-fix or maproulette.
An alternative (and would require a restructure) would be to change the model to be directly editing OSM using your OSM username -- more in line like https://www.mapcontrib.xyz/ or https://wheelmap.org.

v2 make it works


fix: multiple bluetooth dialogs on rotation

Fixes #101
Changes:

we lock the screen rotation until the intent starts
we unlock the screen rotation when intent is complete

Additional Context
This bug has been since android 2.2 ( https://issuetracker.google.com/issues/37114831 ). This is a workaround until the android team fixes it

@iamareebjamal Please Review


Questions about mod authorized

I wonder if you have permission from all the mod authors for referencing of these mods, and if not, isn't it an act of stealing mods?

I have included the mod/plugin in the required items so if you want the mods/plugins to work you have to download it from their official site first.

Though your translation is good, you're referencing other mods directly, which can cause other modders to lose a lot of attention (after all,  if you just mark the required items ,users can choose not to subscribe them)

eh, i didnt know about that im sorry

It's funny that when I told you to delete the animations and learn how to translate, you closed Comments.

I could help you to create transactions of these mods without quoting their source files

like what?, how?, I don't understand...

just create a floder named "lang",and create files named with "The_code name_of_the_language .lps",such as "en.lps"(you can find the code of language at the Setting page of the game),then put your translations in these files.In this way, you can translate all the mods except for some code mod that does not natively support translation.

I've done it before, but thank you and I'm sorry for all the things I did before. I did it because I was too bored and had nothing to do.

I have updated it and removed anything that is not mine.

thank you :)


specialize IndexIterator::skip for primary indexes

this provides a speedup of about 10% for LIMIT offset, limit operations

LGTM


cmd/compile: restore faster OADDSTR in evconst

CL 20277 switched to a less efficient algorithm to make the NodeList to Nodes transition easier. Switch back before the next release.

Fixed by https://golang.org/cl/20320 and friends.


I can't find where to open the editor??

I've looked around everywhere in all the folders, but I can't find out where to open the actual editor

Have you downloaded latest rar release wor windows or Linux?

Though I don't quite understand what you are saying (I'm just starting out with Rain World modding), I supposedly have the latest version of the editor. I am on Windows

https://github.com/timofey260/RWE-Plus/releases/tag/2.6.2
This thing

There should be an exe in rar file

After a ton of messing around with trying to find then open the rar file, I managed to find the editor!! Thank you for your help :>


When creating a RKE2 cluster with Calico tigera-operator and calico-system are not in the system projects

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):
Create a RKE2 cluster with Calico as a CNI Plugin.
Result:
Calico creates the namespaces calico-system and tigera-operator. These namespaces are not part of a project and therefor marked as user namespace.

Expected Result:
The calico related namespaces should be in the system project automatically.
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-head
Installation option (single install/HA): HA

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): RKE2 Infrastructure Provider & Custom
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.7", GitCommit:"1dd5338295409edcfff11505e7bb246f0d325d15", GitTreeState:"clean", BuildDate:"2021-01-13T13:23:52Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.2+rke2r1", GitCommit:"5e58841cce77d4bc13713ad2b91fa0d961e69192", GitTreeState:"clean", BuildDate:"2021-06-24T00:52:42Z", GoVersion:"go1.16.4b7", Compiler:"gc", Platform:"linux/amd64"}

Works fine on master-head (8073489).
Namespaces calico-system and tigera-operator are part of system project.


Gas price calculation provider

nice -- I'd like to standardize some simple documentation in terms of what rpc methods providers handle and what rpc methods they rely on

I think this one deserves a test too, but will merge for now

All of them should have tests, but a bit low on time myself


user authentication

Hi I tried to add a user authentication as next parameter in XMLHttpRequest.open call.
http.open("GET", this.config.httpRequestURL, true, 'myapikey');
I'm still getting error status 0 for the moment.
The key is valid if used this way in a browser http://key@apiURL
Do you intend to support API key parameter in your module ?

Apologies for late reply and minimal updating. Commitments have kept be incredibly busy recently. This project needs a major update which is being planned soon, as there are a few issues with cross-site scripting I need to address. I intend to complete and update this project before the end of July with any luck.


Fixes 4927: add flag to prevent requeuing canceled tasks

Summary
Adds a cancel_attempted field to the tasks table and prevents requeuing a task if it was canceled
Testing steps

On main, create a repo and let it snapshot
Adjust this script to use your identity header and change the repository_uuids to include the repo you've created. Running this on main should reproduce the errors we've been seeing come through glitchtip (you may not need to loop as many times):

for i in {1..50}; do
  UUID=$(curl -s -X POST --location "http://localhost:8000/api/content-sources/v1.0/templates/"     -H "x-rh-identity: eyJpZGVudGl0eSI6eyJvcmdfaWQiOiIxNzY4NDYzMiIsICJ0eXBlIjoiVXNlciIsInVzZXIiOnsidXNlcm5hbWUiOiJicnl0dGFuaWVob3VzZSJ9LCJhY2NvdW50X251bWJlciI6IjExNDkxNzg2IiwiaW50ZXJuYWwiOnsib3JnX2lkIjoiMTc2ODQ2MzIifX19Cg=="     -H "Content-Type: application/json"     -d "{
          \"name\":\"test-$RANDOM\",
          \"arch\": \"x86_64\",
          \"version\": \"8\",
          \"repository_uuids\": [\"0de58827-5301-44da-a226-85db660d6d1f\"],
          \"date\": \"2024-11-05T14:04:05Z\"
        }"  | jq -r .uuid)

  curl -s -X DELETE --location "http://localhost:8000/api/content-sources/v1.0/templates/$UUID"     -H "x-rh-identity: eyJpZGVudGl0eSI6eyJvcmdfaWQiOiIxNzY4NDYzMiIsICJ0eXBlIjoiVXNlciIsInVzZXIiOnsidXNlcm5hbWUiOiJicnl0dGFuaWVob3VzZSJ9LCJhY2NvdW50X251bWJlciI6IjExNDkxNzg2IiwiaW50ZXJuYWwiOnsib3JnX2lkIjoiMTc2ODQ2MzIifX19Cg=="

done

Checkout this PR, run the migration, and run the script again. You shouldn't see any requeues or errors

https://issues.redhat.com/browse/HMS-4927


Set status conditions on the CFApp resource

Blockers

#1 must be completed first

Acceptance Criteria
GIVEN that I am targeting a k8s cluster
AND   the cluster has the CRDs from this project installed (via `make install`)
AND   I am running this app via `make run`
WHEN I create a new CFApp record
THEN I should see that it has a `status.conditions` entry with `type` "Running" and `status` "False"
AND  I should see a second `status.conditions` entry with `type` "Restarting" and `status` "False"

Also...
GIVEN that I have this repo checked out and it is my working directory
WHEN I run `go test ./...`
THEN I should see that tests of the CFApp controller run and pass

Dev Notes
We agreed as a team to use spec as our test framework and gomega as our matcher/expectation package.
The pair on this should explore whether unit testing is feasible or it envtest-driven integration tests are our best option.

The in-flight work is in the issues/2 branch

This looks good to me, any reason to keep this issue open?


Why page attribute custom_title was changed to menu_title?

It's bad change because:
In previous state, attribute title was short and clear to describe name of page and helps simple mind mapping:
Title -> Page title == Slug == Menu title
Attribute custom_title was longer, more explanatory title or phrase used on page.
But with menu_title, I'm not possible mind map what title is used where.
Which means: frustrated users and developers ;/.
And btw menu still use attribute title.

After lots of discussion this is what we decided was better.. It was based on users getting confused.


[overlay] Add ModelIO overlay

Explanation: Introduce the ModelIO overlay that makes the API much more usable from Swift
Scope of Issue: Additive.
Risk: Minimal
Reviewed By: Nicholas Blasingame
Testing: Automated test suite with new tests covering the added API
Directions for QA: N/A
Radar: rdar://problem/33033257

@swift-ci Please test

Similar to: https://github.com/apple/swift/pull/10585


fix(): allow initializeApp to be used with AOT

Checklist

Issue number for this PR: #1635
Docs included?: no
Test units included?: yes
In a clean directory, yarn install, yarn test run successfully? yes

Description

Turns out type guards cannot be used in decorators.
We'd like to keep AngularFireModule.initializeApp in step with the Firebase JS SDK's initializeApp, so I had to change the Injection Tokens yet again; fortunately these were not documented to begin with. Dropping FirebaseAppConfigToken and FirebaseAppNameToken in favor of a new FirebaseNameOrConfigToken.
This will allow AngularFireModule.initializeApp to be used with AOT, which we regressed on in RC.8.

@jamesdaniels That looks to me, best of both worlds. It fixed the error on my end.


Springfox swagger-ui.html not loading using version 3.0.0-SNAPSHOT

In our project we are using 3.0.0-SNAPSHOT of swagger springfox.
Recently when we open swagger-ui.html, it is giving 404 Whilte Label Error.
I enabled logs at web level
`
logging.level.web=TRACE
logging.level.org.springframework.web=TRACE

`
It is loading "/swagger-resources", but not loading "/swagger-ui.html"
The addition of the resource handler is as per the document.
When loading "/swagger-ui.html", it's giving "Resource not found"
`
web.server.adapter.HttpWebHandlerAdapter.traceDebug - [74c4396b] HTTP GET "/swagger-resources/", headers={masked}
web.reactive.result.method.annotation.RequestMappingHandlerMapping.lambda$getHandler$1 - [74c4396b] Mapped to public org.springframework.http.ResponseEntity<java.util.List<springfox.documentation.swagger.web.SwaggerResource>> springfox.documentation.swagger.web.ApiResourceController.swaggerResources()
web.reactive.result.method.annotation.ResponseEntityResultHandler.selectMediaType - Using 'application/json;q=0.8' given [text/html, application/xhtml+xml, image/webp, image/apng, application/xml;q=0.9, application/signed-exchange;v=b3;q=0.9, */*;q=0.8] and supported [application/json]
web.reactive.result.method.annotation.ResponseEntityResultHandler.writeBody - [74c4396b] 0..1 [java.util.List<springfox.documentation.swagger.web.SwaggerResource>]
http.codec.json.Jackson2JsonEncoder.trace - [74c4396b] Encoding [[springfox.documentation.swagger.web.SwaggerResource@4903f26e, springfox.documentation.swagger.web.SwaggerResource@57b46085, springfox.documentation.swagger.web.SwaggerResource@4beb0f82, springfox.documentation.swagger.web.SwaggerResource@3a6db652, springfox.documentation.swagger.web.SwaggerResource@6caba3f3, springfox.documentation.swagger.web.SwaggerResource@18ef56ab, springfox.documentation.swagger.web.SwaggerResource@b6bcd2b, springfox.documentation.swagger.web.SwaggerResource@5ce32532, springfox.documentation.swagger.web.SwaggerResource@6d66b166, springfox.documentation.swagger.web.SwaggerResource@fdef86f, springfox.documentation.swagger.web.SwaggerResource@5a096e2a, springfox.documentation.swagger.web.SwaggerResource@1f060aec, springfox.documentation.swagger.web.SwaggerResource@473365eb, springfox.documentation.swagger.web.SwaggerResource@3fd6e0e2]]
web.server.adapter.HttpWebHandlerAdapter.traceDebug - [74c4396b] Completed 200 OK, headers={masked}
http.server.reactive.ReactorHttpHandlerAdapter.trace - [74c4396b] Handling completed

web.server.adapter.HttpWebHandlerAdapter.traceDebug - [74c4396b] HTTP GET "/swagger-ui.html", headers={masked}
web.reactive.handler.SimpleUrlHandlerMapping.lookupHandler - [74c4396b] Matching patterns [/swagger-ui.html**, /**]
web.reactive.handler.SimpleUrlHandlerMapping.lambda$getHandler$1 - [74c4396b] Mapped to ResourceWebHandler ["classpath:/META-INF/resources/"]
web.reactive.resource.ResourceWebHandler.lambda$handle$0 - [74c4396b] Resource not found
web.reactive.function.server.RouterFunctions.route - [74c4396b] Matched org.springframework.boot.autoconfigure.web.reactive.error.DefaultErrorWebExceptionHandler$$Lambda$1372/0x00000008008bb040@10209892
web.HttpLogging.debug - [74c4396b] Resolved [ResponseStatusException: 404 NOT_FOUND] for HTTP GET /swagger-ui.html
core.codec.CharSequenceEncoder.trace - [74c4396b] Writing "
Whitelabel Error Page

This application has no configured error view, so you are seeing this as a fallback.

Thu Jul 02 22:15:45 IST 2020

There was an unexpected error (type=Not Found, status=404).
"
web.server.adapter.HttpWebHandlerAdapter.traceDebug - [74c4396b] Completed 404 NOT_FOUND, headers={masked}
http.server.reactive.ReactorHttpHandlerAdapter.trace - [74c4396b] Handling completed

`
I checked if path inside META-INF is changed or not as per documentation at https://springfox.github.io/springfox/docs/snapshot/#snapshot-3, it is same as V 2.10.5
Then, when I changed version from V 3 Snapshot to current stable 2.10.5, it worked.
Can you let me know what I am missing? And since I am a noobie, can you tell me is snapshot version is like beta version which should not be used in production?

Duplicat https://github.com/springfox/springfox/issues/3360

I must admit to being very confused. It seems that there are now multiple releases of 3.0.0-SNAPSHOT version - my .m2 repository has multiple 3.0.0-SNAPSHOT jars, one on 8th May, one on 5th July and one from earlier this morning. All I know is that my OpenAPI docs are now screwed and swagger-ui.html no longer works. I use Google Cloud Endpoints and this now rejects the OpenAPI v2 config doc which differs significantly from an earlier, working version and which is clearly 'odd'. I only switched to 3.0.0-SNAPSHOT because of its support for Spring WebFlux but it is clear that, at the moment, it is simply unusable for me. What is the plan for 3.0.0-SNAPSHOT? Should I switch to 2.10.5 but does that support Spring WebFlux. Sorry, not wanting to sound critical as it is a great product and it is clear to see the effort put it, but I am completely exasperated and wondering how to proceed. Any hints would be greatly appreciated.

@andrew-property-xyz again apologies as things are in a bit of a flux (as expected with snapshots) as I work on getting 3.0.0 released this week. I suspect there is a couple of things going on here. If you're unable to share a repo that demonstrates the problem, would you look at the the demos project especially the boot-webflux repo to see if you can modify it to reflect your problem.

@dilipkrish  one doubt, what is the extra features are there in snapshot 3.0.0 that everyone is following the repo in dependency repo compared to 2.10.5 stable. For me, I just copied the version from a blog.

3.0.0 is the latest released version. Please see the release notes for details. 2.10.5 is an intermediate release and not meant for public consumption.

I use 3.0.0 and find the new swagger ui is http://xxxx:port/swagger-ui/ ( please remember the last splash).
actually， you can add spring-boot-starter-actuator and confirm the swagger ui mapping by check http://xxx:port/actuator/mappings .

Hi @fishjam @dilipkrish
I am facing issues in all cases and getting
"message":"Invalid access token"

@pushkaraj20885 you need to allow access to the resources if you have authentication turned on

It is added in class WebSecurityConfiguration extends WebSecurityConfigurerAdapter
void configure(final WebSecurity web) {         web.ignoring().antMatchers('/v2/api-docs', '/swagger-resources/**',                 '/swagger-ui/**', '/swagger-ui/index.html**', '/webjars/**', '/actuator/health')
but still getting same error

Please look at @fishjam post. To make it work .../swagger-ui/ NOT .html. That need to be fixed

I tried with /swagger-ui/ but still not working with 3.0.0, works with 2.9.2

Thank you . It worked for me by adding the  io.springfox springfox-boot-starter 3.0.0  and with the url http://localhost:8080/swagger-ui/

Hi Guys,
I have to admit, the Swagger project is one of the most confusing library. I finally managed to get this working with springfox-boot-starter 3.0.0
My config:
gradle:
`
plugins {
id 'org.springframework.boot' version '2.4.2'
id 'io.spring.dependency-management' version '1.0.10.RELEASE'
id 'java'
}
group = 'com.curvecue'
version = '0.0.1-SNAPSHOT'
sourceCompatibility = '1.8'
configurations {
compileOnly {
extendsFrom annotationProcessor
}
}
repositories {
mavenCentral()
maven { url 'https://repo.spring.io/milestone' }
}
ext {
set('springCloudVersion', "2020.0.1")
}
//configurations {
//    // exclude Tomcat
////    compile.exclude module: 'spring-boot-starter-tomcat'
//}
dependencies {
implementation 'org.springframework.boot:spring-boot-starter-thymeleaf'
implementation 'org.springframework.boot:spring-boot-starter-validation'
implementation 'org.springframework.boot:spring-boot-starter-web'

//    implementation 'org.springframework.boot:spring-boot-starter-undertow'
implementation 'org.springframework.boot:spring-boot-starter-actuator'
implementation 'org.springframework.boot:spring-boot-starter-data-jpa'
implementation 'org.springframework.boot:spring-boot-starter-thymeleaf'
implementation 'org.springframework.boot:spring-boot-starter-webflux'
implementation 'org.springframework.cloud:spring-cloud-starter-config'
implementation 'org.springframework.cloud:spring-cloud-starter-openfeign'

implementation 'org.flywaydb:flyway-core:7.5.2'

compile group: 'io.springfox', name: 'springfox-boot-starter', version: '3.0.0'

implementation 'com.fasterxml.jackson.datatype:jackson-datatype-jdk8:2.12.1'

compileOnly 'org.projectlombok:lombok'
developmentOnly 'org.springframework.boot:spring-boot-devtools'
runtimeOnly 'com.h2database:h2'
runtimeOnly 'org.postgresql:postgresql'
annotationProcessor 'org.springframework.boot:spring-boot-configuration-processor'
annotationProcessor 'org.projectlombok:lombok'
testImplementation 'org.springframework.boot:spring-boot-starter-test'
testImplementation 'io.projectreactor:reactor-test'

}
dependencyManagement {
imports {
mavenBom "org.springframework.cloud:spring-cloud-dependencies:${springCloudVersion}"
}
}
test {
useJUnitPlatform()
}
`
@Configuration
@EnableSwagger2
public class SwaggerConfig extends WebMvcConfigurerAdapter {
@Bean
public Docket apiDocket() {
return new Docket( DocumentationType.SWAGGER_2 )
.select()
.apis( RequestHandlerSelectors.any() )
.paths( PathSelectors.any() )
.build();
}
}
Sample RestController
`
@RestController
@RequestMapping( "/stream-api/postgres" )
@RequiredArgsConstructor
@Slf4j
public class PostgresController {
private final UserRepository userRepository;

@GetMapping( value = "/user", produces = MediaType.APPLICATION_NDJSON_VALUE )
public UserEntity getUser( @RequestParam( required = true ) String id ) {
	log.debug( "Looking up for user with id: {}", id );
	Optional<UserEntity> userEntityOptional = userRepository.findById( id );
	return userEntityOptional.orElse( null );
}

}
`
And now most importantly the url:
http://localhost:8080/swagger-ui/index.html <-- PLS NOTICE there is no context root specified here. I spent hours pointing to http://localhost:8080/stream-api/postgres/swagger-ui/index.html !
Hope this helps. I didn't have to make any Spring Security adjustments.

new url is /swagger-ui/, and the / at end is necessary !!!

        <dependency>
            <groupId>io.springfox</groupId>
            <artifactId>springfox-boot-starter</artifactId>
            <version>3.0.0</version>
        </dependency>

Hello, I added this dependency to pom.xml (this is the only dependency pointing to sprinfox) and still getting error while accessing /swagger-ui/. On the other hand v2/api-docs works well. I didn't create any configuration classes. Does anyone know, what can be wrong here? Any pointers are appreciated!

new url is /swagger-ui/, and the / at end is necessary !!!

Thank you, finally works for me!!!

No solution worked for me yet

 io.springfox springfox-boot-starter 3.0.0

This worked for swagger version 3.0.0

After spending several hours I found out in my case spring cloud config server caused the problem, see this and this. Since path conflict was the main reason of the problem, it's possible to happen in any other cases where path conflict exists, for example when base path of a rest service is / and there is a method with a @PathParam argument or when there is another tool like config server that hijacks url!

currently i am using springfox 3.0.0 with spring-boot 2.7.1  version. below link solutions doesn't work for me.
i spend couples of days on it but no luck. can anyone help me for this its urgent, need to solve it ASAP.
springfox.github.io/springfox/docs/current/#migrating-from-existing-2-x-version
or should i go with openApi

currently i am using springfox 3.0.0 with spring-boot 2.7.1 version. below link solutions doesn't work for me. i spend couples of days on it but no luck. can anyone help me for this its urgent, need to solve it ASAP. (http://springfox.github.io/springfox/docs/current/#migrating-from-existing-2-x-version) below issue i am getting Whitelabel Error Page This application has no explicit mapping for /error, so you are seeing this as a fallback. Mon Jul 06 21:19:55 AEST 2020 There was an unexpected error (type=Not Found, status=404).
while using swagger-ui urls. http://localhost:8081/api-payroll-ng/docs/swagger-ui http://localhost:8081/api-payroll-ng/docs/swagger-ui/index.html

Have you manage to sort this?

none of the mentioned solutions are working for me, following is my configuration:
plugins {
	id 'java'
	id 'org.springframework.boot' version '3.1.8'
	id 'io.spring.dependency-management' version '1.1.4'
	id("io.swagger.core.v3.swagger-gradle-plugin") version "2.2.19"
}

Any help would be appreciated


Render avatar for Accounts

Fixes https://github.com/microsoft/vscode/issues/136889
To do list:

[x] Do the plumbing so the avatar is surfaced in the API and it passes from the Authentication session
[x] Adopt in GitHub Authentication provider
[ ] Adopt in Microsoft Authentication provider
[x] Figure out how to render the image in the Global Activity Bar. Will discuss with @sandy081 next week. The challenge is that right now we only render icons in the :before element, and I want to apply custom css with image.
[x] Add menu actions and storage service writing for user preference on what avatar to render
[x] Figure out what happens with already signed in users (ideally we can render the avatar also for them)

@TylerLeonhardt if time allows feedback is welcome. I have verified that the avatar URL nicely flows from extension to renderer. Though if you are busy I am perfectly happy if you review once I figure out the AccountsActivityActionViewItem part.
Is it ok to add an optional parameter directly in vscode.d.ts, or should I create a proposed file?
Here's how it looks (I edited CSS directly in out of source). Here's the css I plan to use:
    width: 60%;
    height: 60%;
    background-image: url(https://avatars.githubusercontent.com/u/1926584?v=4);
    background-size: cover;
    background-position: center;
    background-repeat: no-repeat;
    border-radius: 50%;

And when activity bar is at top.

Adopt in Microsoft Authentication provider

If you want to call this out of scope for this PR, I am ok with that... that said, it's probably not a crazy amount of work on top of this item.

I would love it if this image is cached locally somehow so that if I get on a plane, the icon doesn't change.

Good points. I will try to tackle MS as part of this PR.
As for caching the image - I agree we should do it. Probably independent from this PR. Thank you

If you don't cache the image, at the very least verify that while offline it shows something reasonable

Tried to wire up the image for the MS account. However Copilot says that this can only be obtained through MS Graph (and browsing the internet confirms this). I remember you told me that we can not access the MS graph due to us creating our account with a type that does not have MS Graph support. Let me know if I am missing something here? Thanks
For context, here's Copilot:
"In the Microsoft Authentication API, the user's avatar image URL is not directly included in the claims. However, you can use the Microsoft Graph API to get the user's profile photo after you've obtained an access token.
Please note that you need to have the User.Read permission in your Azure AD app registration to access the user's profile photo, and the user needs to have granted this permission during the sign-in process. Here's a basic example of how you can do this in TypeScript:
import fetch from 'node-fetch';

async function getProfilePhoto(accessToken: string) {
  const response = await fetch('https://graph.microsoft.com/v1.0/me/photo/$value', {
    headers: {
      'Authorization': `Bearer ${accessToken}`
    }
  });

  if (!response.ok) {
    throw new Error('Failed to get profile photo');
  }

  const blob = await response.blob();
  const url = URL.createObjectURL(blob);

  return url;
}

"

Yeah this gets a little tricky... it's doable, but maybe skip Microsoft auth for now.

I think I got this into a decent state -> ready for review. But I plan to merge this in January. Here's a demo. Tomorrow I will show in Zurich and share in Slack for feedback:
https://github.com/microsoft/vscode/assets/1926584/a973b31d-b9c5-4aca-801d-6e9d29d7b46a
To-do list:

[ ] Fix rendering in the Activity Bar. Currently I am setting width, height, margin-left and margin-right to decrease the size of the icon. However this breaks the badge rendering. Ideally I would just change the background size, and not affect the element. But I did not figure out how to change background-size while also making sure it renders oval (border-radius: 50%).
[ ] Microsoft authentication
[x] I verified that without Internet, Electron still cashes the image so it gets rendered. So I think it is hard getting into a state where nothing gets rendered. @TylerLeonhardt let me know if you can think of a scenario.

💯 , should it be "Show Avatar" in the menu?

@bpasero thanks, I like your suggested wording better - updating.

Some follow ups for Jan:

make sure vscode.dev is happy with where you put the icon
follow up after this PR goes in, does Codespaces' embedder already have the icon and can it be fetched already while loading the Codespace?

[like]  Peter Rasborg reacted to your message:

From: Tyler James Leonhardt @.>
Sent: Wednesday, December 20, 2023 6:11:34 PM
To: microsoft/vscode @.>
Cc: Subscribed @.***>
Subject: Re: [microsoft/vscode] Render avatar for Accounts (PR #200390)
Some follow ups for Jan:

make sure vscode.dev is happy with where you put the icon
follow up after this PR goes in, does Codespaces' embedder already have the icon and can it be fetched already while loading the Codespace?

—
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/vscode/pull/200390#issuecomment-1864917928, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6OHGTICACA6RIT5WK4AENDYKMS5NAVCNFSM6AAAAABAM7XNVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRUHEYTOOJSHA.
You are receiving this because you are subscribed to this thread.Message ID: @.***>

I love this so much. Is the "Show Avatar" the default?

Is this still relevant?


Clean up getting started and add demo pages for core cockroach features

@spencerkimball, @petermattis, I've changed the approach. This PR now cleans up the existing getting started pages and adds new pages for demonstrating core cockroach features via a local cluster. The demo pages are listed in the new Demo Core Features section of Get Started.
At this point, I've completed a draft only for the Fault Tolerance and Recovery demo. I'd like feedback on that before I dive into the others.
@jess-edwards, @sploiselle, @dianasaur323, please chime in as well.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cc0912ebeadc13249c95eb5f01d5fb6e212608f8/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9db895114f5b4c6bf3e15969f6adff0233b0962c/

@spencerkimball, @petermattis: I've also been thinking about keeping the Start a Local Cluster page the same and adding a new page to the Get Started section where we demonstrate surviving node failure and perhaps strong consistency (using manual overlapping transactions from different sql shells) and a few other topics. Would this be worth exploring as an alternative approach, and, if so, do you have ideas for other demonstrations we could do with a local cluster?

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/35bb3031277869f150b5cdba1a202e77a02de42f/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/071f0b41038be01b94e9a7205f079268aafa0505/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cd3802b956a6f4af828ee198408bb50a52d4671d/

Review status: 0 of 13 files reviewed at latest revision, 3 unresolved discussions.

demo-fault-tolerance-and-recovery.md, line 83 at r1 (raw file):

## Step 4. Verify that the cluster remains available

Open the built-in SQL shell on node 1 (port `26258`) or node 3 (port `26259`):

Node 1 is port 26257.

demo-fault-tolerance-and-recovery.md, line 214 at r1 (raw file):

## Step 7. Verify that the rejoined node has caught up

Open the SQL shell on the rejoined node 2 (port `26258`) and check for the `startrek` data that was added while the node was offline:

This doesn't really verify that the rejoined node has caught up - node 2 is acting as a proxy to one of the other nodes at this point. It's catching up in the background, but until it's caught up (and probably even for a time afterwards), it won't be used and so you won't be able to tell whether it's caught up. A better (but longer) demonstration of fault tolerance would be to take each node down in turn and issue an insert each time so that no node was up for all of the inserts.

demo-fault-tolerance-and-recovery.md, line 245 at r1 (raw file):

~~~

As you see, despite being offline when the update happened, node 2 was updated soon after it rejoined the cluster.

"updated soon after" sounds like if you were quick enough, you could see the old data before node 2 caught back up. That isn't the case (and this is an important property of cockroachdb!)

Comments from Reviewable

Review status: 0 of 13 files reviewed at latest revision, 3 unresolved discussions.

demo-fault-tolerance-and-recovery.md, line 83 at r1 (raw file):
Previously, bdarnell (Ben Darnell) wrote…
> Node 1 is port 26257.

Done.

demo-fault-tolerance-and-recovery.md, line 214 at r1 (raw file):
Previously, bdarnell (Ben Darnell) wrote…
> This doesn't really verify that the rejoined node has caught up - node 2 is acting as a proxy to one of the other nodes at this point. It's catching up in the background, but until it's caught up (and probably even for a time afterwards), it won't be used and so you won't be able to tell whether it's caught up. A better (but longer) demonstration of fault tolerance would be to take each node down in turn and issue an insert each time so that no node was up for all of the inserts.

Thanks for calling this out, @bdarnell. I've revised the explanation to clarify these points. PTAL.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/79dd6e9a07f55617521ba4bc1cf6bac720ded46e/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/af448ec1d2aebf5a5cc88864eae6169d01d97f8a/

At @spencerkimball's suggestion, I've removed "Strong Consistency" as a local cluster demo. For the others, here's the plan we talked through. @spencerkimball, let me know if I'm missing anything:
Data Replication

Start with 1 node.
Write data.
Add 2 more nodes and watch replication via admin ui.
Take a node down.
Update zone config to replicate 5 ways.
Add 2 more nodes.
Watch replication via admin ui.

Scalability

Create 3 nodes
Lower max range size in default zone config, e.g., echo 'range_max_bytes: 65536' | cockroach zone set .default -f -
Use some type of load generator that creates a schema and loads it. Something like photos app. We need to generate enough data to result in multiple ranges. @knz, does this sound like something you could help with? Might it be possible to make this a part of cockroach gen?
Watch ranges increas in admin ui.
When nodes are filling up, add 2 more nodes.
Watch rebalancing in admin ui.

Comments from Reviewable

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/53c9577b1ccd95e2944681da07d49a4c08487788/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/7b89fbfaec928af9b8e37b5fc8a80c4d21afdcdf/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f0137256f2659c57bd4f4d41918f5239ff47d9f2/

@spencerkimball, @jess-edwards, since I got the technical LGTM from Ben, and since this PR includes some general cleanup to the other getting started tutorials, I'd like to merge and handle the other two demos (as well as putting a better narrative in place across all three) in follow-up PRs. Is that OK? I've put a few key trackers in place to see how far users make it through the fault tolerance demo.

@jseldess LGTM.
Per our discussion, we can create the narrative from these docs after these docs are merged. No need for the narrative to hold up this PR.

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ddafa50afe085d99480f3b94118ffd5d6b267f6e/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ebe41408224335f7175ff96553fd1af2372f8df0/

Thanks, @jess-edwards. I created an issue to work out the narrative for all of these, as well as issues for the other tutorials:

https://github.com/cockroachdb/docs/issues/858
https://github.com/cockroachdb/docs/issues/857
https://github.com/cockroachdb/docs/issues/856

Also, I added google tags to track key events in the fault tolerance tutorial:

Adding a bunch of data while one node is down temporarily.
Adding a fourth node in preparation for removing another node permanently.

These events should tell us whether users are completing the tutorial.

Fixes #855


Add HASYv2 dataset

Large quantity of red flags on this PR, but even without, we wouldn't merge it, because we don't plan on further expanding the datasets module.

Would you mind to tell me what those red flags are? Why don't you want to expand the datasets module?


updated to 0.3.2 -> got 404 Not Found - http://ip-from-my-machine:9016/button.tpl.html

and also for the menu.tpl.html
using angular 1.3.15
and i am using not the bootstrap css libs .. (may this helps) .. using my own css lib

are you running the demo using a server? As this is an external template you need to start a server at the root of your project.

@ibrainventures you were actually right, silly mistake on my part.
Updated to 3.3 should fix the issue, let me know if you encounter any other problem.


Fix small text error on tutorial_part_one.ipynb

On the section Create an application, fix the phrase:
In order to send query Clipper for predictions...
To:
In order to query Clipper for predictions...

Can one of the admins verify this patch?

jenkins ok to test

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Clipper-PRB/225/
Test PASSed.


Odd formatting of /collections/{collection_id} 404 response

This is the response when trying to get a collection that does not exist (using the PgSTAC backend):
$ curl http://api.dev.internal:9089/data-catalog-api/collections/optis_v2_1_0_WinterCoverCrop_2014
{"detail":"Collection <built-in function id> does not exist."}

It looks like the culprit is using id instead of collection_id here.

Just ran into this as well, created #420

Closed by #420


Combobox (panda-css) is missing recipe for 'clearTrigger' slot

I'm using park-ui's createPreset like this:
import { defineConfig } from '@pandacss/dev'
import { createPreset } from '@park-ui/panda-preset'

export default defineConfig({
  preflight: true,
  presets: [
    '@pandacss/preset-base',
    createPreset({
      accentColor: 'teal',
      grayColor: 'sage',
      borderRadius: '2xl',
    }),
  ],
  include: ['./src/**/*.{js,jsx,ts,tsx,astro}'],
  jsxFramework: 'solid',
  outdir: 'styled-system'
})

Is that enough to have all needed recipes available?
But even if use defineSlotRecipe for <Combobox/> component (https://park-ui.com/docs/panda/components/combobox), it misses  slot clearTrigger.
BTW, is it possible to tweak park-ui's slot recipes by adjusting or adding only what is necessary?

yes you can adjust the recipe however you want using the extend keyword or by omitting parts of it

@dannylin108
This should be fixed by now. Thanks @astahmer for pointing to this workaround.


Feature msbuild conditions

The current solution and csproj files make it a bit difficult to hack on MQTTnet on non-Windows platforms where Mono is required for non-core framework support and UWP is unsupported. This patch aligns the conditions in the various csproj files to make sure that only the "officially" supported frameworks are enabled on non-Windows platforms and adds a solution that builds everything except UWP.

Thank you for your contribution. Good work 👍


Add Known Types two Twice

https://github.com/dapr/dapr/blob/master/pkg/apis/components/v1alpha1/register.go#L40
https://github.com/dapr/dapr/blob/master/pkg/apis/configuration/v1alpha1/register.go#L40
https://github.com/dapr/dapr/blob/master/pkg/apis/subscriptions/v1alpha1/register.go#L40

/area runtime
/area operator
/area placement
/area docs
/area test-and-release

Ask your question here
why Add Known Types two Twice？
Is it written wrong?
If it is written wrong, i can commit  a PR to fix it.

Yes, this seems redundant. Please submit a PR! thanks :)

Yes, this seems redundant. Please submit a PR! thanks :)


daemon: Do not require socketLB for BPF masq

Previously, we required socketLB to be enabled in order for BPF masquerade to properly function. The reasoning was outlined in [1] and [2].
As pointed by Julian Wiedmann, [3] resolved the following NAT reply issue:
    On the remote node, the reply (dst=the client node IP) gets
    masqueraded by the BPF-masq feature, because we masquerade pod ->
    remote host IP in the tunnel mode (see comment in the
    "snat_v4_needed()" for the reason), and currently we don't consult
    the CT map to see whether a packet is reply.

Thus, we can remove the check.
[1]: https://github.com/cilium/cilium/issues/15437
[2]: https://github.com/cilium/cilium/commit/50e59c309e6d86adad84dc175678a91dce6def03
[3]: https://github.com/cilium/cilium/pull/17168
Fix #15437

/ci-e2e

/ci-e2e

/ci-e2e

/ci-e2e

/test


Delete leftover/stale VPCs launched by EMR-EKS

Delete leftover/stale VPCs launched by EMR-EKS
The PR adds a script to do the following steps for deleting the VPCs:

List the VPCs with the prefix eksctl-providers-team-eks
Firstly delete all the association of the VPCs, viz. subnets,
Internet gateways, route tables, security groups, and network
interfaces
By default, AWS takes care of the main route table and the default
security groups are not deleted as they have further dependencies
associated with them, which we do not touch in our script.
Hence we're safe here.
Finally, delete the VPCs and report the exit status of these final
deletion commands as the task status. We do not want to set -e
in the beginning of the script as the association failures can be
ignored if we're able to delete the VPCs.

The PR then adds this script to be called a BashOperator task
in the AWS nuke DAG.

Verified that the VPC was successfully deleted in the AWS console.


Translate reserve compute resource page to Bahasa Indonesia

This translation is part of #22296, translating reserve compute resource page to Bahasa Indonesia.
/language id
/cc @kubernetes/sig-docs-id-reviews

/cc @ariscahyadi

@ariscahyadi @habibrosyad I've addressed your suggestions, please re-review and let me know, thanks!

I've just squashed all the commits into 1

@irvifa need help on approval

Sorry I just saw this.
Thank you for your amazing job 🎉
/approve

/lgtm


questions about ODC'  acc

Hi~ I'm trying your ODC(CVPR 2020) method on my own dataset. I'd want to know "what's the acc of the model  after trained for 400 epochs". Many thanks!

The benchmarking results for 440 epochs are already in the paper.


Blacklisting or watching soon after restart fails

This has happened to me multiple times last week, and again today just now.
Example: at https://chat.stackexchange.com/transcript/message/39523256#39523256  is a !!/watch request which is ignored. I posted it some 20 seconds after the "Restart: API quota" message in the hopes that it would work, but apparently I didn't wait long enough.
My next attempt to watch the same domain failed again, apparently because of some sort of (silent) Smoke Detector crash.
Finally at https://chat.stackexchange.com/transcript/message/39523609#39523609  I managed to successfully get it watched.

There's actually a decent chance this is a ChatExchange issue, and not specific to !!/watch. I've observed odd glitches when posting commands right after the startup message, even in NG (presumably due to the fact that the watcher hasn't fully initialized yet).

Has this been recently reproduced?


Hide non-functional editor locales due to missing RTL/font shaping support

As explained in https://github.com/godotengine/godot/issues/982 and https://github.com/godotengine/godot/issues/9961, Godot currently doesn't support RTL and font shaping, which is required to display some languages correctly (such as Arabic).
I think it'd result in a better user experience if those languages were removed from the list of available editor languages until Godot supports the required features. The locale files would remain available in the repository, so that people can still contribute to translations on Weblate (and developers could test RTL/font shaping support using those locale files).

That's a good idea, since those locales would get automatically loaded otherwise when matching the system locale, but are not usable as is.
We'd need to list what locales exactly need to be disabled temporarily. I'll give it a try based on the locales for which we current have translation files.
Not supported:

Arabic [ar]
Persian [fa]
Hebrew [he]
Hindi [hi] (Devanagari)
Urdu (Pakistan) [ur_PK]

Partial support:

Thai [th], some fonts render OK, others don't, see #28371

Not sure:

Malay [ms] (seems to support both Latin and Arabic scripts... the few strings we have translated so far seem in Latin script)

Not supported by current font, might also need font shaping. For those we should first check how they render when you have a font that supports them, and see if we should add such fallbacks fonts for the editor:

Bengali [bn]
Malayalam [ml]
Sinhala [si]
Tamil [ta]
Telugu [te]

AFAIK Bengali, Malayalam, Tamil, Telugu (and other Brahmic scripts) all use some composite glyphs and do require shaping on some level. I can't tell how broken rendering is, but it's definitely should have some problems at least to the same extent as Thai (misplaced and overlapping diacritics).

Here are rendering samples, top to bottom: Godot + gdtl module, AAT, Godot:

Bengali (broken)

Malayalam (broken)

Sinhala (broken)

Tamil (broken)

Telugu (broken)

Thanks for the thorough test, I updated my comment to clarify that those 5 are also broken.


Allow specifying type for response data

Like axios

This is an improvement, but still a lie. This style is about as good as the any type because OADA could return anything.
I'm not completely against this change, but I'd prefer just returning unknown (JSON isn't much more useful then that as a return value). Then you can either as it (so it's clear you don't really know that's the type) or assert it into a type. Axios API is the result of trying to type an API design for JavaScript.
I would also be happy with a second param that takes an assert method to use internally.

I don't really agree with you that it is only that way because of being javascript. Either way when you receive it over the network you cannot be sure of the type unless you use some assertion function. Imo without this change using as as to say what type you want for the data field of the response becomes quite cumbersome. I agree that the default type of it should be unknown.

I suppose were we disagree is that I want using as to be cumbersome. Honestly I don't think it should be allowed in strict mode either. If you don't know what it is, you should check it before using it. Otherwise, what's the point?

I'm all for using an assertion when you have one, but I do not always have one. If you add an assertion parameter to the get TS can infer my generic from it.

I'm wondering why you like to use Typescript if your willing to just ignore it here? Particularly with data completely out of your control like an OADA API.
If you don't have an assertion, then you still need code that checks for missing data and handles the error correctly. In that case, an unknown type should be fine, because you'll have checks.
Like I said, I won't try to stop the merge but I think we would be encouraging bad practice.

TypeScript is great for statically analyzing the flow within your own code, but when it comes to network I/O there are shortcomings. Runtime assertions are great, but when I know what the API should be returning I want to just give the type and then catch any errors from the server responding with something else.
Logically this is no different than using as.
But I would rather have:
const {data: bar} = await conn.get<Bar>({...})

than:
const {data} = await conn.get({...})
const bar = data as Bar

In both cases TS just has to believe you that it is a bar. Even in the case of an assertion, TS is just taking your word for it. You could just say:
function isBar(val: any): asserts val is Bar {
  return
}

True, your validation is only as good as you write it to be, but I suppose that's my point. I want TS to help get it right -- which is all TS is good for anyway. And in this case it can help if you let it.
If you have get return unknown, then the static analysis can help ensure you are checking for the data that you are accessing.
if(data.thing) { ... data.thing ... } is also a valid typeguard and would be required by TS if data was unknown
So is something like if(!data.thing) { throw ...} .
Combined with the ? operator, these checks are not that bad and  give runtime stability.
Sure, using as is as bad as using your example assert. However, I still prefer as if you are going to try and outsmart TS. In that case, the code is clear: keep your guard up and be careful to wrap everything that accesses the variable in try's, etc because there could be a runtime issue accessing fields.
Just like TS can have bugs, ajv or schema-to-types compiler could have bugs. TS isn't about guarantees like Rust is, but I still don't see the point in purposefully holding it back for the sake of not having to write could that you should be writing.

By should be writing, I mean the code that does this:

Runtime assertions are great, but when I know what the API should be returning I want to just give the type and then catch any errors from the server responding with something else.

@abalmos how do you feel about exposing a generic type so that asserting the type of the data is not so annyoing?
type GetResponse<T = unknown> = SocketResponse & { data: T };

interface Foo {
  a: number;
  b: string;
}

// Now I can assert about the data field without having to specify everything else
const { data: foo } = (await conn.get({ path })) as GetResponse<Foo>;

@awlayton That is definitely a type improvement at no cost :+1:  However, I still think the use of as is broken. You can't be sure Foo really represents the returned data and any "correct" program needs to check it all first. Why not let TS force you into it?

TS can't tell what it is to force you into anything.

Sure it can. It is already. Your adding the as statement because TS is complaining that it doesn't know what it is.


Data Science with Python : Grocery Stores Analysis and Prediction

Description
Welcome to the 'DSWP' Team, good to see you here.
With this issue, it will help us in knowing how to analyze and predict sales for the thousands of product families sold at Favorita stores located in Ecuador.
Dataset : https://www.kaggle.com/c/store-sales-time-series-forecasting/data
To get assigned to this issue, add your serial numbers mentioned in the spreadsheet of "Data Science with Python", the approach one would follow and the choice you prefer (Documentation, Audio, Video). You can go with all three or any number of options you're interested to work on.
If you had referred any resources, add them up in "DS Resources". Similarly, if you had used datasets, include them in "DS Datasets".
Domain: Kaggle Competitions
Mentors Assigned : Shivang Dubey | Yash Goel
Points to Note :
The issues will be assigned on a first come first serve basis, 1 Issue == 1 PR.
"Issue Title" and "PR Title" should be the same. Include issue number along with it.
Changes should be made inside the Datascience_With_Python/ directory & Datascience_With_Python branch.
Follow Contributing Guidelines & Code of Conduct before start Contributing.
This issue is only for 'GWOC' contributors of 'DSWP' domain.
All the best. Enjoy your journey ahead. 😎
Domain
Data Science with Python
Type of Contribution
Audio, Video, Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

./assign Documentation

Name: Rahil Mehta
Sr No. : 390
Batch: 13
Type: Documentation
Approach: Prediction and analyzing the given dataset using a neat and clean code approach.

Issue assigned to @rahilmehta-24 for documentation

Which dataset I have to work in Kaggle ?

Dataset is already included in issue details. Check it out. @rahilmehta-24


Add MySQL on ramdisk

We had a performance issue with running tests with MySQL in that they were taking a substantially long time to run, and it seems to be pegged by the disk.
To stop blocking developers do their work, and because we don't care about the MySQL data in CI, a solution was to devised to run MySQL in ramdisk.
This Puppet requires an initial bootstrap in that we'll have to remove the MySQL data, and then run Puppet, but then after that it'll mount the directory on tmpfs, and then when Puppet runs the ::mysql module will create the data structure.
On boot I have added a cronjob to ensure that Puppet runs immediately so that there is a working MySQL directory ASAP.

Hurray! :)

LGTM 👍

We need to ensure that the mount is added to /etc/fstab

@surminus Agreed, and from testing this, is does just that.  Ideally spinning up a new agent in carrenza would be a good too but unnecessary.  Spot on 👍 please merge ASAP.


Repo settings unsaved changes popup

If I open the repo settings and press back I get dialog telling me there are unsaved changes. I didn't change anything though?

This only occurs on the Repository tab. It seems like is_dirty returns true because of line breaks in the ignore list. Saving doesn't help.
mo_form_data->mt_entries:

io_form_data->mt_entries:

Also this check seems to only occur when pressing the back button on the form. Pressing F3 or changing the tab to another settings page discards unsaved changes without warning.

Yeah, content of textarea fields is tricky. Same with "back" logic which in some cases uses an explicit event and in others the HTML control feature (plus it does not work properly in HTML GUI). Don't spend too much time on these ;-)

Oh don't worry, I am already at my monthly web dev limit refactoring the remote settings page ;)


fix: update AppInspect CLI action to v2.5 #247

https://github.com/splunk/appinspect-cli-action/releases/tag/v2.5.0
https://dev.splunk.com/enterprise/docs/relnotes/relnotes-appinspectcli/whatsnew/#v3502024-03-27
https://github.com/splunk/splunk-add-on-for-google-workspace/actions/runs/8464669953

I have read the CLA Document and I hereby accept the CLA

I have read the CLA Document and I hereby accept the CLA

I have read the Code of Conduct and I hereby accept the Terms

I have read the Code of Conduct and I hereby accept the Terms

:tada: This PR is included in version 4.16.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Objective-c support

I know u have just created it, an  it's amazing, so please, consider to add objective-c support

Good day!
Maybe in future)


ZEPPELIN-3184. Use hadoop-azure to replace azure-storage

What is this PR for?
So that user can use azure storage via hadoop filesystem.
What type of PR is it?
[ Improvement ]
Todos

[ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-3184

How should this be tested?
Travis CI Pass
Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No

This commit broke build for CDH (maven convergence error on dependencies).
Should there be a automated test to check if a commit breaks compatibility with Cloudera distro of Hadoop?

@Tagar I recently realize that zeppelin should work with CDH even built with apache hadoop. Could you try that ?

Do you mean compile without option like

-Dhadoop.version=2.6.0-cdh5.12.1

?
It compiles fine but I was getting runtime errors (like some non-existent method etc). Can't find details now. But I will give it a try again.
Thanks.


Add 'files-changed' hook or add changed files to stats

I'd like to get a list of the changed files while in watch mode.  The intent is to write a 'test-runner' plugin, so that once a test or react component is saved, the corresponding test would be run right away. I was taking a look at the source, and I think the only place this is surfaced is filesModified on https://github.com/webpack/webpack/blob/master/lib/Compiler.js#L101. I was thinking that it would be nice to add a new files-changed hook or dump the file change info into the stats, but is there a different way that the changed files list is surfaced?

Looks interesting indeed

+1

I would be interested in this for the same reason -- I was hoping it would be possible to surface all the changed files, including those which depend on files that have changed.

would love to see this become a thing as well, as using multiple entry points with multiple outputs in tandem with watch doesn't give the opportunity to show what bundle was partially built.

This would still be cool!

I agree, wished I knew a way to read this from the stats. Reading the stats.compilation.stats for the emitted files doesn't always work if you changed the CSS only but the entry point .js file also gets emitted although there weren't any changes.

Yes it a must have feature

Modified files list can be obtained from compilation chunks as described here: https://webpack.github.io/docs/how-to-write-a-plugin.html

Still interested in this. The snippet at the provided link 404s, and the equivalent on the new docs page does not actually work. I just want to know, when watch mode recompiles, which file changed, and its proving to be extremely difficult, unfortunately.

@jescalan Hey there - did you ever figure this one out? Looks like the current docs have some changedFiles example that simply doesn't work for me.

@isaachinman yeah I did but it's definitely not as smooth as it could be: https://github.com/hashicorp/prebuild-webpack-plugin/blob/master/index.js#L57

@jescalan Wow - thanks! Copy-pasted your getChangedFile and am up and running.