Ollama image Describer

Error using llama3.2-vision:11b

Model is downloaded

ComfyUI Error Report
Error Details

Node ID: 54
Node Type: OllamaImageDescriber
Exception Type: AttributeError
Exception Message: 'Model' object has no attribute 'name'

Stack Trace
  File "C:\pinokio\api\comfy.git\app\execution.py", line 323, in execute
    output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)

  File "C:\pinokio\api\comfy.git\app\execution.py", line 198, in get_output_data
    return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)

  File "C:\pinokio\api\comfy.git\app\execution.py", line 169, in _map_node_over_list
    process_inputs(input_dict, i)

  File "C:\pinokio\api\comfy.git\app\execution.py", line 158, in process_inputs
    results.append(getattr(obj, func)(**inputs))

  File "C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Ollama-Describer\nodes.py", line 364, in ollama_image_describe
    models = [model_l['name'] for model_l in client.list()['models']]

  File "C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Ollama-Describer\nodes.py", line 364, in <listcomp>
    models = [model_l['name'] for model_l in client.list()['models']]

  File "C:\pinokio\api\comfy.git\app\env\lib\site-packages\ollama\_types.py", line 20, in __getitem__
    return getattr(self, key)

  File "C:\pinokio\api\comfy.git\app\env\lib\site-packages\pydantic\main.py", line 891, in __getattr__
    raise AttributeError(f'{type(self).__name__!r} object has no attribute {item!r}')

System Information

ComfyUI Version: v0.3.5-3-g0d4e29f
Arguments: main.py
OS: nt
Python Version: 3.10.15 | packaged by conda-forge | (main, Oct 16 2024, 01:15:49) [MSC v.1941 64 bit (AMD64)]
Embedded Python: false
PyTorch Version: 2.5.1+cu121

Devices

Name: cuda:0 NVIDIA GeForce RTX 4090 : cudaMallocAsync

Type: cuda
VRAM Total:<PHONE_NUMBER>6
VRAM Free:<PHONE_NUMBER>4
Torch VRAM Total: 0
Torch VRAM Free: 0

Logs
2024-11-27T12:47:22.488766 - Install: pip packages for 'C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Impact-Pack'2024-11-27T12:47:22.488766 -
2024-11-27T12:47:22.914224 - 2024-11-27T12:47:22.914224 -  2024-11-27T12:47:22.914224 - 2024-11-27T12:47:22.928837 - 2024-11-27T12:47:22.928837 -  2024-11-27T12:47:22.928837 - 2024-11-27T12:47:22.928837 - 2024-11-27T12:47:22.928837 -  2024-11-27T12:47:22.928837 - 2024-11-27T12:47:24.352284 - [!]2024-11-27T12:47:24.352284 -  2024-11-27T12:47:24.352284 -
2024-11-27T12:47:24.352284 - 2024-11-27T12:47:24.352284 - [!]2024-11-27T12:47:24.352284 -  2024-11-27T12:47:24.352284 - [notice] A new release of pip is available: 23.0.1 -> 24.3.1
2024-11-27T12:47:24.352284 - 2024-11-27T12:47:24.352284 - [!]2024-11-27T12:47:24.352284 -  2024-11-27T12:47:24.352284 - [notice] To update, run: python.exe -m pip install --upgrade pip
2024-11-27T12:47:24.352284 - 2024-11-27T12:47:24.422159 - [SKIP] Downgrading pip package isn't allowed: scipy (cur=1.14.1)2024-11-27T12:47:24.422159 -
2024-11-27T12:47:24.422159 - Install: install script for 'C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Impact-Pack'2024-11-27T12:47:24.422159 -
2024-11-27T12:47:24.473366 - [!]2024-11-27T12:47:24.473366 -  2024-11-27T12:47:24.473366 -
2024-11-27T12:47:24.473366 - 2024-11-27T12:47:24.473366 - [!]2024-11-27T12:47:24.473366 -  2024-11-27T12:47:24.473366 - [bold yellow]WARN: The `COMFYUI_MODEL_PATH` environment variable is not set. Assuming `C:\pinokio\api\comfy.git\app\models` as the ComfyUI path.[/bold yellow]
2024-11-27T12:47:24.473366 - 2024-11-27T12:47:29.734365 - 2024-11-27T12:47:29.734365 -  2024-11-27T12:47:29.734365 - ### ComfyUI-Impact-Pack: Check dependencies
2024-11-27T12:47:29.734365 - 2024-11-27T12:47:29.734365 - 2024-11-27T12:47:29.734365 -  2024-11-27T12:47:29.734365 - ### ComfyUI-Impact-Pack: Updating subpack
2024-11-27T12:47:29.734365 - 2024-11-27T12:47:29.734365 - 2024-11-27T12:47:29.734365 -  2024-11-27T12:47:29.734365 - [Impact Pack] EXECUTE: ['C:\\pinokio\\api\\comfy.git\\app\\env\\Scripts\\python.exe', 'install.py'] in 'C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Impact-Pack\impact_subpack'
2024-11-27T12:47:29.734365 - 2024-11-27T12:47:29.734365 - 2024-11-27T12:47:29.734365 -  2024-11-27T12:47:29.734365 - ### ComfyUI-Impact-Pack: Check basic models
2024-11-27T12:47:29.734365 - 2024-11-27T12:47:30.013004 - Install: pip packages for 'C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Manager'2024-11-27T12:47:30.013004 -
2024-11-27T12:47:30.577215 - 2024-11-27T12:47:30.577215 -  2024-11-27T12:47:30.577215 - 2024-11-27T12:47:30.577215 - 2024-11-27T12:47:30.577215 -  2024-11-27T12:47:30.577215 - 2024-11-27T12:47:30.592995 - 2024-11-27T12:47:30.592995 -  2024-11-27T12:47:30.592995 - 2024-11-27T12:47:32.058749 - [!]2024-11-27T12:47:32.058749 -  2024-11-27T12:47:32.058749 -
2024-11-27T12:47:32.058749 - 2024-11-27T12:47:32.058749 - [!]2024-11-27T12:47:32.058749 -  2024-11-27T12:47:32.058749 - [notice] A new release of pip is available: 23.0.1 -> 24.3.1
2024-11-27T12:47:32.058749 - 2024-11-27T12:47:32.058749 - [!]2024-11-27T12:47:32.058749 -  2024-11-27T12:47:32.058749 - [notice] To update, run: python.exe -m pip install --upgrade pip
2024-11-27T12:47:32.058749 - 2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 -  2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 -  2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 -  2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 -  2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 -  2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 -  2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.586781 -  2024-11-27T12:47:32.586781 - 2024-11-27T12:47:32.602735 - 2024-11-27T12:47:32.602735 -  2024-11-27T12:47:32.602735 - 2024-11-27T12:47:32.602735 - 2024-11-27T12:47:32.602735 -  2024-11-27T12:47:32.602735 - 2024-11-27T12:47:32.602735 - 2024-11-27T12:47:32.602735 -  2024-11-27T12:47:32.602735 - 2024-11-27T12:47:32.602735 - 2024-11-27T12:47:32.602735 -  2024-11-27T12:47:32.602735 - 2024-11-27T12:47:32.602735 - 2024-11-27T12:47:32.602735 -  2024-11-27T12:47:32.602735 - 2024-11-27T12:47:32.624256 - 2024-11-27T12:47:32.624256 -  2024-11-27T12:47:32.624256 - 2024-11-27T12:47:32.624256 - 2024-11-27T12:47:32.624256 -  2024-11-27T12:47:32.624256 - 2024-11-27T12:47:34.083089 - [!]2024-11-27T12:47:34.083089 -  2024-11-27T12:47:34.083089 -
2024-11-27T12:47:34.083089 - 2024-11-27T12:47:34.083089 - [!]2024-11-27T12:47:34.083089 -  2024-11-27T12:47:34.083089 - [notice] A new release of pip is available: 23.0.1 -> 24.3.1
2024-11-27T12:47:34.083089 - 2024-11-27T12:47:34.083089 - [!]2024-11-27T12:47:34.083089 -  2024-11-27T12:47:34.083089 - [notice] To update, run: python.exe -m pip install --upgrade pip
2024-11-27T12:47:34.083089 - 2024-11-27T12:47:34.140208 - [SKIP] Downgrading pip package isn't allowed: huggingface-hub (cur=0.26.2)2024-11-27T12:47:34.140208 -
2024-11-27T12:47:34.617820 - 2024-11-27T12:47:34.617820 -  2024-11-27T12:47:34.617820 - 2024-11-27T12:47:36.065791 - [!]2024-11-27T12:47:36.065791 -  2024-11-27T12:47:36.065791 -
2024-11-27T12:47:36.065791 - 2024-11-27T12:47:36.065791 - [!]2024-11-27T12:47:36.065791 -  2024-11-27T12:47:36.065791 - [notice] A new release of pip is available: 23.0.1 -> 24.3.1
2024-11-27T12:47:36.065791 - 2024-11-27T12:47:36.065791 - [!]2024-11-27T12:47:36.065791 -  2024-11-27T12:47:36.065791 - [notice] To update, run: python.exe -m pip install --upgrade pip
2024-11-27T12:47:36.065791 - 2024-11-27T12:47:36.142001 -
[ComfyUI-Manager] Startup script completed.2024-11-27T12:47:36.142001 -
2024-11-27T12:47:36.142001 - #######################################################################
2024-11-27T12:47:36.142001 -
2024-11-27T12:47:36.859668 -
Prestartup times for custom nodes:2024-11-27T12:47:36.859668 -
2024-11-27T12:47:36.859668 -   18.1 seconds:2024-11-27T12:47:36.859668 -  2024-11-27T12:47:36.859668 - C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Manager2024-11-27T12:47:36.859668 -
2024-11-27T12:47:36.859668 -
2024-11-27T12:47:38.333333 - Total VRAM 24564 MB, total RAM 65254 MB
2024-11-27T12:47:38.335229 - pytorch version: 2.5.1+cu121
2024-11-27T12:47:38.335229 - Set vram state to: NORMAL_VRAM
2024-11-27T12:47:38.335229 - Device: cuda:0 NVIDIA GeForce RTX 4090 : cudaMallocAsync
2024-11-27T12:47:39.184567 - Using pytorch cross attention
2024-11-27T12:47:40.550712 - [Prompt Server] web root: C:\pinokio\api\comfy.git\app\web
2024-11-27T12:47:40.983969 - ### Loading: ComfyUI-Impact-Pack (V7.12)2024-11-27T12:47:40.983969 -
2024-11-27T12:47:41.333715 - ### Loading: ComfyUI-Impact-Pack (Subpack: V0.8)2024-11-27T12:47:41.333715 -
2024-11-27T12:47:41.367276 - [Impact Pack] Wildcards loading done.2024-11-27T12:47:41.367276 -
2024-11-27T12:47:41.367276 - ### Loading: ComfyUI-Inspire-Pack (V1.7)2024-11-27T12:47:41.367276 -
2024-11-27T12:47:41.548668 - ### Loading: ComfyUI-Manager (V2.52.1)2024-11-27T12:47:41.548668 -
2024-11-27T12:47:41.617126 - ### ComfyUI Revision: 2866 [0d4e29f1] | Released on '2024-11-27'2024-11-27T12:47:41.617126 -
2024-11-27T12:47:41.967118 - [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/model-list.json2024-11-27T12:47:41.967118 -
2024-11-27T12:47:41.983673 - [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/github-stats.json2024-11-27T12:47:41.983673 -
2024-11-27T12:47:41.983673 - [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/alter-list.json2024-11-27T12:47:41.983673 -
2024-11-27T12:47:42.017166 - [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/extension-node-map.json2024-11-27T12:47:42.017166 -
2024-11-27T12:47:42.184242 - Failed to auto update `Quality of Life Suit` 2024-11-27T12:47:42.184242 -
2024-11-27T12:47:42.184242 - [ComfyUI-Manager] default cache updated: https://raw.githubusercontent.com/ltdrdata/ComfyUI-Manager/main/custom-node-list.json2024-11-27T12:47:42.184242 -
2024-11-27T12:47:42.184242 - QualityOfLifeSuit_Omar92_DIR: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar922024-11-27T12:47:42.184242 -
2024-11-27T12:47:42.205488 - [comfyui_controlnet_aux] | INFO -> Using ckpts path: C:\pinokio\api\comfy.git\app\custom_nodes\comfyui_controlnet_aux\ckpts
2024-11-27T12:47:42.205488 - [comfyui_controlnet_aux] | INFO -> Using symlinks: False
2024-11-27T12:47:42.205488 - [comfyui_controlnet_aux] | INFO -> Using ort providers: ['CUDAExecutionProvider', 'DirectMLExecutionProvider', 'OpenVINOExecutionProvider', 'ROCMExecutionProvider', 'CPUExecutionProvider', 'CoreMLExecutionProvider']
2024-11-27T12:47:42.217238 - C:\pinokio\api\comfy.git\app\custom_nodes\comfyui_controlnet_aux\node_wrappers\dwpose.py:26: UserWarning: DWPose: Onnxruntime not found or doesn't come with acceleration providers, switch to OpenCV with CPU device. DWPose might run very slowly
  warnings.warn("DWPose: Onnxruntime not found or doesn't come with acceleration providers, switch to OpenCV with CPU device. DWPose might run very slowly")
2024-11-27T12:47:42.233322 - __name__ : ComfyUI_node_Lilly2024-11-27T12:47:42.234327 -
2024-11-27T12:47:42.234327 - __file__ : C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI_node_Lilly\__init__.py2024-11-27T12:47:42.234327 -
2024-11-27T12:47:42.234327 - os.path.basename(__file__) : __init__.py2024-11-27T12:47:42.234327 -
2024-11-27T12:47:42.234327 - os.path.splitext(os.path.basename(__file__))[0] : __init__2024-11-27T12:47:42.234327 -
2024-11-27T12:47:42.234327 - working directory : 2024-11-27T12:47:42.234327 -  2024-11-27T12:47:42.234327 - C:\pinokio\api\comfy.git\app2024-11-27T12:47:42.234327 -
2024-11-27T12:47:42.355046 - ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────  init start  ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
2024-11-27T12:47:42.355046 - __name__ : custom_nodes.ComfyUI_node_Lilly2024-11-27T12:47:42.355046 -
2024-11-27T12:47:42.355046 - __file__ : C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI_node_Lilly\__init__.py2024-11-27T12:47:42.355046 -
2024-11-27T12:47:42.355046 - os.path.basename(__file__) : __init__.py2024-11-27T12:47:42.355046 -
2024-11-27T12:47:42.355046 - os.path.splitext(os.path.basename(__file__))[0] : __init__2024-11-27T12:47:42.355046 -
2024-11-27T12:47:42.355046 - working directory : 2024-11-27T12:47:42.355046 -  2024-11-27T12:47:42.355046 - C:\pinokio\api\comfy.git\app2024-11-27T12:47:42.355046 -
2024-11-27T12:47:42.355046 - [12:47:42] Load ok   : CheckpointLoaderRandom                                                                                __init__.py:83
2024-11-27T12:47:42.355046 -            Load ok   : CheckpointLoaderSimpleText                                                                                __init__.py:83
2024-11-27T12:47:42.355046 - [12:47:42] wildcards card_path :  C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI_node_Lilly\..\..\wildcards\**\*.txt                                                                                wildcards.py:36
2024-11-27T12:47:42.355046 -            cards file count :  0                                                                                wildcards.py:187
2024-11-27T12:47:42.355046 -            wildcards test : aest                                                                                wildcards.py:218
2024-11-27T12:47:42.355046 -            wildcards test : *test                                                                                wildcards.py:219
2024-11-27T12:47:42.355046 -            wildcards test : ?est                                                                                wildcards.py:220
2024-11-27T12:47:42.355046 -            wildcards test : test                                                                                wildcards.py:221
2024-11-27T12:47:42.355046 -            wildcards test : /test                                                                                wildcards.py:222
2024-11-27T12:47:42.367809 -            wildcards test : /0/test                                                                                wildcards.py:223
2024-11-27T12:47:42.368809 -            Load ok   : CLIPTextEncodeWildcards                                                                                __init__.py:83
2024-11-27T12:47:42.369809 -            Load ok   : LoraLoaderText                                                                                __init__.py:83
2024-11-27T12:47:42.370809 -            Load ok   : LoraLoaderTextRandom                                                                                __init__.py:83
2024-11-27T12:47:42.371809 -            Load ok   : Random_Sampler                                                                                __init__.py:83
2024-11-27T12:47:42.373809 -            Load ok   : VAELoaderDecode                                                                                __init__.py:83
2024-11-27T12:47:42.374809 -            Load ok   : VAELoaderText                                                                                __init__.py:83
2024-11-27T12:47:42.379808 - Total VRAM 24564 MB, total RAM 65254 MB
2024-11-27T12:47:42.379808 - pytorch version: 2.5.1+cu121
2024-11-27T12:47:42.380808 - Set vram state to: NORMAL_VRAM
2024-11-27T12:47:42.380808 - Device: cuda:0 NVIDIA GeForce RTX 4090 : cudaMallocAsync
2024-11-27T12:47:42.388807 -            Load ok   : SimpleSampler                                                                                __init__.py:83
2024-11-27T12:47:42.390807 -            Load ok   : SaveImageSimple                                                                                __init__.py:83
2024-11-27T12:47:42.391808 -            Load ok   : TextWildcards                                                                                __init__.py:83
2024-11-27T12:47:42.391808 - ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────  init end  ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
2024-11-27T12:47:42.437407 - All packages from requirements.txt are installed and up to date.2024-11-27T12:47:42.437407 -
2024-11-27T12:47:42.442406 - llama-cpp installed2024-11-27T12:47:42.442406 -
2024-11-27T12:47:42.443406 - All packages from requirements.txt are installed and up to date.2024-11-27T12:47:42.444406 -
2024-11-27T12:47:42.591300 - Using pytorch cross attention2024-11-27T12:47:42.591300 -
2024-11-27T12:47:42.647310 - Started worker with PID 285042024-11-27T12:47:42.647310 -
2024-11-27T12:47:42.651931 -  ComfyUI  Fooocus Nodes  : loaded2024-11-27T12:47:42.651931 -
2024-11-27T12:47:42.776910 - Traceback (most recent call last):
  File "C:\pinokio\api\comfy.git\app\nodes.py", line 2027, in load_custom_node
    module_spec.loader.exec_module(module)
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "C:\pinokio\api\comfy.git\app\custom_nodes\LCM_Inpaint_Outpaint_Comfy\__init__.py", line 1, in <module>
    from .LCM_Nodes import NODE_CLASS_MAPPINGS
  File "C:\pinokio\api\comfy.git\app\custom_nodes\LCM_Inpaint_Outpaint_Comfy\LCM_Nodes.py", line 9, in <module>
    from .LCM.LCM_reference_pipeline import LatentConsistencyModelPipeline_reference
  File "C:\pinokio\api\comfy.git\app\custom_nodes\LCM_Inpaint_Outpaint_Comfy\LCM\LCM_reference_pipeline.py", line 33, in <module>
    from diffusers.models.unet_2d_blocks import CrossAttnDownBlock2D, CrossAttnUpBlock2D, DownBlock2D, UpBlock2D
ModuleNotFoundError: No module named 'diffusers.models.unet_2d_blocks'

2024-11-27T12:47:42.777909 - Cannot import C:\pinokio\api\comfy.git\app\custom_nodes\LCM_Inpaint_Outpaint_Comfy module for custom nodes: No module named 'diffusers.models.unet_2d_blocks'
2024-11-27T12:47:43.992767 - Searge-SDXL v4.3.1 in C:\pinokio\api\comfy.git\app\custom_nodes\SeargeSDXL2024-11-27T12:47:43.992767 -
2024-11-27T12:47:44.597145 - WAS Node Suite: OpenCV Python FFMPEG support is enabled2024-11-27T12:47:44.597145 -
2024-11-27T12:47:44.597145 - WAS Node Suite Warning: `ffmpeg_bin_path` is not set in `C:\pinokio\api\comfy.git\app\custom_nodes\was-node-suite-comfyui\was_suite_config.json` config file. Will attempt to use system ffmpeg binaries if available.2024-11-27T12:47:44.597145 -
2024-11-27T12:47:45.176630 - WAS Node Suite: Finished. Loaded 218 nodes successfully.2024-11-27T12:47:45.176630 -
2024-11-27T12:47:45.177634 -
	"Art is not a thing; it is a way." - Elbert Hubbard
2024-11-27T12:47:45.177634 -
2024-11-27T12:47:45.197703 -
Import times for custom nodes:
2024-11-27T12:47:45.197703 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\sdxl_utility.py
2024-11-27T12:47:45.197703 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\rembg-comfyui-node-better
2024-11-27T12:47:45.197703 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\websocket_image_save.py
2024-11-27T12:47:45.197703 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI_aspect_ratios-main
2024-11-27T12:47:45.197703 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\image-resize-comfyui-main
2024-11-27T12:47:45.197703 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\comfyui_wildcards
2024-11-27T12:47:45.198705 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-LLaVA-Captioner-main
2024-11-27T12:47:45.198705 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-YOLO
2024-11-27T12:47:45.198705 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\comfyui-model-downloader
2024-11-27T12:47:45.198705 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Custom-Scripts
2024-11-27T12:47:45.198705 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-QualityOfLifeSuit_Omar92
2024-11-27T12:47:45.198705 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\x-flux-comfyui
2024-11-27T12:47:45.198705 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-LLaVA-Captioner
2024-11-27T12:47:45.198705 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\comfyui_controlnet_aux
2024-11-27T12:47:45.199701 -    0.0 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI_TensorRT
2024-11-27T12:47:45.199701 -    0.1 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\Fooocus_Nodes
2024-11-27T12:47:45.201426 -    0.1 seconds (IMPORT FAILED): C:\pinokio\api\comfy.git\app\custom_nodes\LCM_Inpaint_Outpaint_Comfy
2024-11-27T12:47:45.201426 -    0.1 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Inspire-Pack
2024-11-27T12:47:45.201426 -    0.1 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI_VLM_nodes
2024-11-27T12:47:45.201426 -    0.2 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI_node_Lilly
2024-11-27T12:47:45.201426 -    0.2 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Manager
2024-11-27T12:47:45.201426 -    0.3 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\SeargeSDXL
2024-11-27T12:47:45.202430 -    0.4 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Impact-Pack
2024-11-27T12:47:45.202430 -    0.4 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Ollama-Describer
2024-11-27T12:47:45.202430 -    0.9 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\rembg-comfyui-node
2024-11-27T12:47:45.202430 -    1.2 seconds: C:\pinokio\api\comfy.git\app\custom_nodes\was-node-suite-comfyui
2024-11-27T12:47:45.202430 -
2024-11-27T12:47:45.209429 - Starting server

2024-11-27T12:47:45.210430 - To see the GUI go to: http://<IP_ADDRESS>:8188
2024-11-27T12:48:13.364457 - got prompt
2024-11-27T12:48:15.583867 - HTTP Request: GET http://localhost:11434/api/tags "HTTP/1.1 200 OK"
2024-11-27T12:48:15.586564 - !!! Exception during processing !!! 'Model' object has no attribute 'name'
2024-11-27T12:48:15.587565 - Traceback (most recent call last):
  File "C:\pinokio\api\comfy.git\app\execution.py", line 323, in execute
    output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
  File "C:\pinokio\api\comfy.git\app\execution.py", line 198, in get_output_data
    return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
  File "C:\pinokio\api\comfy.git\app\execution.py", line 169, in _map_node_over_list
    process_inputs(input_dict, i)
  File "C:\pinokio\api\comfy.git\app\execution.py", line 158, in process_inputs
    results.append(getattr(obj, func)(**inputs))
  File "C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Ollama-Describer\nodes.py", line 364, in ollama_image_describe
    models = [model_l['name'] for model_l in client.list()['models']]
  File "C:\pinokio\api\comfy.git\app\custom_nodes\ComfyUI-Ollama-Describer\nodes.py", line 364, in <listcomp>
    models = [model_l['name'] for model_l in client.list()['models']]
  File "C:\pinokio\api\comfy.git\app\env\lib\site-packages\ollama\_types.py", line 20, in __getitem__
    return getattr(self, key)
  File "C:\pinokio\api\comfy.git\app\env\lib\site-packages\pydantic\main.py", line 891, in __getattr__
    raise AttributeError(f'{type(self).__name__!r} object has no attribute {item!r}')
AttributeError: 'Model' object has no attribute 'name'

2024-11-27T12:48:15.588564 - Prompt executed in 2.21 seconds

Attached Workflow
Please make sure that workflow does not contain any sensitive information such as API keys or passwords.
{"last_node_id":54,"last_link_id":95,"nodes":[{"id":3,"type":"KSampler","pos":[1280,100],"size":[315,262],"flags":{},"order":16,"mode":0,"inputs":[{"name":"model","type":"MODEL","link":76},{"name":"positive","type":"CONDITIONING","link":64},{"name":"negative","type":"CONDITIONING","link":65},{"name":"latent_image","type":"LATENT","link":73}],"outputs":[{"name":"LATENT","type":"LATENT","links":[7],"slot_index":0}],"properties":{"Node name for S&R":"KSampler"},"widgets_values":[604527232321082,"randomize",20,1,"euler","normal",1]},{"id":7,"type":"CLIPTextEncode","pos":[206,171],"size":[425.27801513671875,180.6060791015625],"flags":{"collapsed":true},"order":8,"mode":0,"inputs":[{"name":"clip","type":"CLIP","link":63}],"outputs":[{"name":"CONDITIONING","type":"CONDITIONING","links":[68],"slot_index":0}],"title":"CLIP Text Encode (Negative Prompt)","properties":{"Node name for S&R":"CLIPTextEncode"},"widgets_values":[""],"color":"#322","bgcolor":"#533"},{"id":8,"type":"VAEDecode","pos":[1620,98],"size":[210,46],"flags":{},"order":17,"mode":0,"inputs":[{"name":"samples","type":"LATENT","link":7},{"name":"vae","type":"VAE","link":60}],"outputs":[{"name":"IMAGE","type":"IMAGE","links":[9],"slot_index":0}],"properties":{"Node name for S&R":"VAEDecode"},"widgets_values":[]},{"id":9,"type":"SaveImage","pos":[1865,98],"size":[722.4129638671875,425.767578125],"flags":{},"order":18,"mode":0,"inputs":[{"name":"images","type":"IMAGE","link":9}],"outputs":[],"properties":{},"widgets_values":["ComfyUI"]},{"id":17,"type":"LoadImage","pos":[124,343],"size":[315,314.0000305175781],"flags":{},"order":0,"mode":0,"inputs":[],"outputs":[{"name":"IMAGE","type":"IMAGE","links":[71],"slot_index":0,"shape":3},{"name":"MASK","type":"MASK","links":null,"shape":3}],"title":"Depth COMPOSITION","properties":{"Node name for S&R":"LoadImage"},"widgets_values":["ComfyUI_00194_.png","image"]},{"id":26,"type":"FluxGuidance","pos":[617,-10],"size":[317.4000244140625,58],"flags":{},"order":14,"mode":0,"inputs":[{"name":"conditioning","type":"CONDITIONING","link":92}],"outputs":[{"name":"CONDITIONING","type":"CONDITIONING","links":[67],"slot_index":0,"shape":3}],"properties":{"Node name for S&R":"FluxGuidance"},"widgets_values":[10]},{"id":31,"type":"UNETLoader","pos":[249,-171],"size":[315,82],"flags":{},"order":1,"mode":0,"inputs":[],"outputs":[{"name":"MODEL","type":"MODEL","links":[74],"slot_index":0}],"properties":{"Node name for S&R":"UNETLoader"},"widgets_values":["flux1-dev.safetensors","default"]},{"id":32,"type":"VAELoader","pos":[656,165],"size":[315,58],"flags":{},"order":2,"mode":0,"inputs":[],"outputs":[{"name":"VAE","type":"VAE","links":[60,69],"slot_index":0}],"properties":{"Node name for S&R":"VAELoader"},"widgets_values":["ae.safetensors"]},{"id":34,"type":"DualCLIPLoader","pos":[-233,12],"size":[315,106],"flags":{},"order":3,"mode":0,"inputs":[],"outputs":[{"name":"CLIP","type":"CLIP","links":[63,90],"slot_index":0}],"properties":{"Node name for S&R":"DualCLIPLoader"},"widgets_values":["clip_l.safetensors","t5xxl_fp16.safetensors","flux"]},{"id":35,"type":"InstructPixToPixConditioning","pos":[1018,124],"size":[235.1999969482422,86],"flags":{},"order":15,"mode":0,"inputs":[{"name":"positive","type":"CONDITIONING","link":67},{"name":"negative","type":"CONDITIONING","link":68},{"name":"vae","type":"VAE","link":69},{"name":"pixels","type":"IMAGE","link":71}],"outputs":[{"name":"positive","type":"CONDITIONING","links":[64],"slot_index":0},{"name":"negative","type":"CONDITIONING","links":[65],"slot_index":1},{"name":"latent","type":"LATENT","links":[73],"slot_index":2}],"properties":{"Node name for S&R":"InstructPixToPixConditioning"},"widgets_values":[]},{"id":37,"type":"LoraLoaderModelOnly","pos":[624,-172],"size":[315,82],"flags":{},"order":7,"mode":0,"inputs":[{"name":"model","type":"MODEL","link":74}],"outputs":[{"name":"MODEL","type":"MODEL","links":[76],"slot_index":0}],"properties":{"Node name for S&R":"LoraLoaderModelOnly"},"widgets_values":["Lego_Minifigures_Flux-000010.safetensors",1]},{"id":39,"type":"Text Concatenate","pos":[-646,-27],"size":[315,178],"flags":{},"order":11,"mode":0,"inputs":[{"name":"text_a","type":"STRING","link":79,"widget":{"name":"text_a"},"shape":7},{"name":"text_b","type":"STRING","link":84,"widget":{"name":"text_b"},"shape":7},{"name":"text_c","type":"STRING","link":95,"widget":{"name":"text_c"},"shape":7},{"name":"text_d","type":"STRING","link":null,"widget":{"name":"text_d"},"shape":7}],"outputs":[{"name":"STRING","type":"STRING","links":[87],"slot_index":0}],"properties":{"Node name for S&R":"Text Concatenate"},"widgets_values":[", ","true","","","",""]},{"id":42,"type":"Text Multiline","pos":[-617,-337],"size":[400,200],"flags":{},"order":4,"mode":0,"inputs":[],"outputs":[{"name":"STRING","type":"STRING","links":[79],"slot_index":0}],"title":"LORA KEYORD","properties":{"Node name for S&R":"Text Multiline"},"widgets_values":["<lora:Lego_Minifigures_Flux-000010:1>"]},{"id":46,"type":"ShowText|pysssss","pos":[-1406,-319],"size":[308.53692626953125,183.09664916992188],"flags":{},"order":10,"mode":0,"inputs":[{"name":"text","type":"STRING","link":94,"widget":{"name":"text"}}],"outputs":[{"name":"STRING","type":"STRING","links":null,"shape":6}],"title":"CHARACTER PROMPT","properties":{"Node name for S&R":"ShowText|pysssss"},"widgets_values":["","50-year-old man wearing a blue shirt with a red tie. He has a blue collar shirt and a blue tie. His hair is brown and he has a beard. He is smiling and appears to be happy."]},{"id":48,"type":"Text Multiline","pos":[-1058,-328],"size":[400,200],"flags":{},"order":5,"mode":0,"inputs":[],"outputs":[{"name":"STRING","type":"STRING","links":[84],"slot_index":0}],"title":"IMAGE PROMPT","properties":{"Node name for S&R":"Text Multiline"},"widgets_values":["solo,Copenhagen nyhavn,person standing by the dock on a sunny day, pictoresque lego houses in the background, smiling,empty hands"]},{"id":49,"type":"ShowText|pysssss","pos":[-639,212],"size":[320.7367858886719,130.0964813232422],"flags":{},"order":12,"mode":0,"inputs":[{"name":"text","type":"STRING","link":87,"widget":{"name":"text"}}],"outputs":[{"name":"STRING","type":"STRING","links":[91],"slot_index":0,"shape":6}],"properties":{"Node name for S&R":"ShowText|pysssss"},"widgets_values":["","<lora:Lego_Minifigures_Flux-000010:1>, solo,Copenhagen nyhavn,person standing by the dock on a sunny day, pictoresque lego houses in the background, smiling,empty hands, 50-year-old man wearing a blue shirt with a red tie. He has a blue collar shirt and a blue tie. His hair is brown and he has a beard. He is smiling and appears to be happy."]},{"id":53,"type":"Text to Conditioning","pos":[140,23],"size":[315,58],"flags":{},"order":13,"mode":0,"inputs":[{"name":"clip","type":"CLIP","link":90},{"name":"text","type":"STRING","link":91,"widget":{"name":"text"}}],"outputs":[{"name":"CONDITIONING","type":"CONDITIONING","links":[92],"slot_index":0}],"properties":{"Node name for S&R":"Text to Conditioning"},"widgets_values":[""]},{"id":45,"type":"LoadImage","pos":[-1454,-21],"size":[315,314],"flags":{},"order":6,"mode":0,"inputs":[],"outputs":[{"name":"IMAGE","type":"IMAGE","links":[93],"slot_index":0},{"name":"MASK","type":"MASK","links":null}],"properties":{"Node name for S&R":"LoadImage"},"widgets_values":["04-08-Joe-1-1000x600.jpg","image"]},{"id":54,"type":"OllamaImageDescriber","pos":[-1114,-17],"size":[446.7363586425781,555.096923828125],"flags":{},"order":9,"mode":0,"inputs":[{"name":"images","type":"IMAGE","link":93}],"outputs":[{"name":"result","type":"STRING","links":[94,95],"slot_index":0}],"properties":{"Node name for S&R":"OllamaImageDescriber"},"widgets_values":["llama3.2-vision:11b (Q4_K_M, 7.9GB)","","http://localhost:11434",300,0.2,40,0.9,1.1,42,2048,200,-1,"You are an assistant who describes the content and composition of images. \nDescribe only what you see in the image, not what you think the image is about.Be factual and literal. \nDo not use metaphors or similes. \nBe concise.","Return a list of danbooru tags for this image, formatted as lowercase, separated by commas."]}],"links":[[7,3,0,8,0,"LATENT"],[9,8,0,9,0,"IMAGE"],[60,32,0,8,1,"VAE"],[63,34,0,7,0,"CLIP"],[64,35,0,3,1,"CONDITIONING"],[65,35,1,3,2,"CONDITIONING"],[67,26,0,35,0,"CONDITIONING"],[68,7,0,35,1,"CONDITIONING"],[69,32,0,35,2,"VAE"],[71,17,0,35,3,"IMAGE"],[73,35,2,3,3,"LATENT"],[74,31,0,37,0,"MODEL"],[76,37,0,3,0,"MODEL"],[79,42,0,39,0,"STRING"],[84,48,0,39,1,"STRING"],[87,39,0,49,0,"STRING"],[90,34,0,53,0,"CLIP"],[91,49,0,53,1,"STRING"],[92,53,0,26,0,"CONDITIONING"],[93,45,0,54,0,"IMAGE"],[94,54,0,46,0,"STRING"],[95,54,0,39,2,"STRING"]],"groups":[],"config":{},"extra":{"ds":{"scale":1,"offset":[2119.8636755543794,396.9280863044951]}},"version":0.4}

Additional Context
(Please add any additional context or steps to reproduce the error here)

Is working for me

Can you send me a screenshot of your node?

I just had the same issue with a fresh install of Ollama on 12.2.2024 on Windows.  I just posted the date as I can't seem to easily find what version of ollama it is.  It seems the issue is related to the lines that read:
    models = [model_l['name'] for model_l in client.list()['models']]

If you print client.list()['models']  you'll get something like the following:
[Model(model='llava:7b-v1.6-vicuna-q2_K', modified_at=datetime.datetime(2024, 12, 2, 4, 22, 21, 764458, tzinfo=TzInfo(-06:00)), digest='6321163f3833a11f93eb9ed4db70ee8a1e940fc2aee29a6401ce40a6c4cf6645', size=3157305837, details=ModelDetails(parent_model='', format='gguf', family='llama', families=['llama', 'clip'], parameter_size='7B', quantization_level='Q2_K')), Model(model='llava:7b-v1.6-mistral-q2_K', modified_at=datetime.datetime(2024, 12, 2, 3, 36, 55, 780997, tzinfo=TzInfo(-06:00)), digest='52e0ce44a5f5a533777b859d6952963eeff47310d093814d922b01a743437f05', size=3343688881, details=ModelDetails(parent_model='', format='gguf', family='llama', families=['llama', 'clip'], parameter_size='7B', quantization_level='Q2_K'))]
I'm guessing it must have once been called name but now is called model.  Fix for me was just replacing the line with:
    models = [model_l['model'] for model_l in client.list()['models']]

There are like 3 instances of it in ComfyUI\custom_nodes\ComfyUI-Ollama-Describer\nodes.py
Maybe an easy compatibility fix would be to put it in a try/except block and if except is based on model_l['name'] not being found convert to model_l['model']

I literally got Github Copilot miraculously fix it a couple of days ago. I'll post the code asap, it's in another machine. That said, I remember it was the way that the model variables and lists where instantiated. I asked it to break the conditional loop in steps with some print statements so it would be easier to debug. For some reason that fixed it. Essentially having client.list()['models'] be a variable before the loop runs.


Updating reference

Hi, this PR has one change about renference images:
below are the new images from loremipsun.html template:
page0
page1
page2
The reason that we updated these images is because  the tables headers  painted in the html using class=table-red etc are not being applied in the pdf result, but the correct pdf result will be able as soon as the #524 is ready.

Coverage increased (+0.6%) to 57.873% when pulling d1b52faf67f0aecc1b73d4bdaeab293e1c5a9fc6 on pedroszg:updating_reference into c9e934d3a853119e965f23740016aca0c5be98b1 on xhtml2pdf:master.


Error using OpenCL API

Here is my code:
cl = CL.GetApi();
uint platformCount;
cl.GetPlatformIDs(0, null, &platformCount);

And it threw exception: System.DivideByZeroException:“Attempted to divide by zero.” while executing GetPlatformIDs(xxx).
Then I tried to write as the script in Silk.Net/src/Lab/CLMultiplication/Program.cs:
cl = CL.GetApi();
IntPtr platform;
cl.GetPlatformIDs(1, &platform, null);

And it threw the same exception.
Environment:

Windows 10 64bit
Using Silk.Net.OpenGL & ..OpenCL & ..Windowing & ..Common & ..Input & ..OCL Extention KHR

Can you please give the complete exception including the stack trace? I can't reproduce here.

System.DivideByZeroException
HResult=0x80020012
Message=Attempted to divide by zero.
Source=<无法计算异常源>
StackTrace:
<无法计算异常堆栈跟踪>

Can you right click on the Visual Studio Call stack pane and enable the "Show external code" option?

Oh nevermind I can see what I need to see.

Can you try updating to Silk.NET 2.0 Preview 5?

Emmmm
I am a green hand...
Can you please tell me how to update?

I downloaded it directly on NuGet

Right click on your project, and select Manage NuGet packages
Head over to the updates tab, and select Include prerelease

Now the updated verisons should pop up. Alternatively if that's giving you issues:

open the .csproj file in a text editor
replace every reference of "1.9.0" with "2.0.0-preview5"

Wow really thanks!!!

...
It still throws the same exception

Can you send me the stack trace again? The $exception.StackTrace string is what clued me in last time. It's impossible that that's the same, if it is you didn't upgrade correctly.

at Silk.NET.OpenCL.CL.GetPlatformIDs(UInt32 num_entries, IntPtr* platforms, UInt32* num_platforms)
at Study.ImageProcessing.Test.Tests.CLTrialTask.OnLoad() in E:\CSharp\Study\Study.ImageProcessing.Test\Tests\CLTrialTask.cs:line 52
at Silk.NET.Windowing.Internals.ViewImplementationBase.Initialize()
at Silk.NET.Windowing.WindowExtensions.Run(IView view)
at Study.ImageProcessing.Test.Tests.CLTrialTask.Run(String[] args, Object[] inputs) in E:\CSharp\Study\Study.ImageProcessing.Test\Tests\CLTrialTask.cs:line 31
at Study.ImageProcessing.Test.Entrance.Main(String[] args) in E:\CSharp\Study\Study.ImageProcessing.Test\Entrance.cs:line 9"

My repository named "Study" is the problem project

Your repo does not have the images required.

Just put a picture named input.jpg at the exe's location or retarget the path in CLTrialTask.cs line 46

Nothing special here(^_^)

Wow didn't it throw exceptions at calling clGetPlatformIDs API?

Nope.

I cried

It's strange because we don't do any division. Can you try right clicking on the call stack window and enabling "Show external code"?

未知 means unknown

What's the text at the very top of the call stack?

调用堆栈：Call Stack
名称：Name
托管到本机的转换：Transition from managed to host(???)

This looks to be an OpenCL bug, converting to discussion.
Can you try updating your drivers?


Upgrade crypo requirements

Hitting this due to Flutter 2 being out:
sip_ua from git depends on crypto ^2.1.2 and google_fonts >=2.0.0-nullsafety.0 depends on crypto ^3.0.0, sip_ua from git is incompatible with google_fonts >=2.0.0-nullsafety.0.
Thanks.

Want me to test this? There seems to be no changes needed and we should upgrade due to a security fix:
`
2.1.3
Security vulnerability: Fixed constant-time comparison in Digest.

`

Thanks. I forced v3 anyway as other packages in use aren't up to date. I'll test again by removing this.


Fix fail log tests not being run

This PR fixes the "fail log" tests for the behavior added in #6586 not being run, because the new file isn't a Go test file.

Which Traffic Control components are affected by this PR?

Traffic Control Cache Config (T3C, formerly ORT)

What is the best way to verify this PR?
Run the "ORT tests", make sure the new test is run and passes. (You'll need to run with -v to ensure it passes and/or use --run '^TestT3cApplyFailMsg$')
If this is a bugfix, which Traffic Control versions contained the bug?

master

PR submission checklist

[x] This PR has tests
[ ] This PR has documentation
[ ] This PR has a CHANGELOG.md entry
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@rob05c I think the fail log tests are failing because it's actually not logging the failure line, not due to a problem with the tests. According to the failing test, the output of t3c-apply is empty, and looking at the code it seems like it ought to be logging the error message to stdout. Should I try to fix t3c-apply in this PR, or do you wanna do that and just keep this to being a PR that fixes the test not running? Or am I wrong and the problem is in the test?


Add Gflag to enable/disable incremental backup feature

This diff adds a gflag to enable/disable incremental backup feature.
This is the first step for incremental backup.
For testing, I log some info to show the gflag is enabled.
Mahmoud's comment: we have not done a design review on the thread / stop mechanism, so he suggest me to hold off any change apart from the flag.
Thus, I clean my code in the last commit.

looks good to me. Thank you for cleaning this up!


Present Box ember collection not working as intended (JP)

Preparation

[X] I tested the latest release
[X] I looked at other issues (even the closed ones)
[X] I read the Troubleshooting Guide

FGO server
JP
FGA build number
1664
Describe the bug
FGO JP added x100 spin for lottery, this means ember sizes in the present boxes can go up to 15+. Though max ember size is set as 4, FGA reads 11, 12, 13 and 14 ember sizes as 1, 2, 3, 4, causing it to try and collect those embers.
Video
YouTube Video
Device model
Oppo Reno Z
Android version
11
Screen size
No response
RAM
No response

Duplicate of #1009


fix: oboe crash by not stopping stream on error

This is a follow up to my PR #2025, where I encountered an audio crash that happened randomly after a couple of minutes or hours of using it(See https://github.com/alvr-org/ALVR/pull/2025#issuecomment-1995156816).
I reverted the changes and could confirm the commits in the PR being the issue.
Then I looked further and found out that you shouldn't close the audio stream after an error occurred(see commit message) and was testing this fix in this PR for two days now(~6h of continued usage) without a crash.
I also found out when rebasing, that in a recent commit(https://github.com/alvr-org/ALVR/commit/005c4c7d84cb1d524008b67b8c43a8228b65e8a1#diff-662ca07f68bbbec1317ab607076a66fa0daa81ae07df639d3588832f87c509d6R43) you upgraded the oboe crate to 0.6 even though it had a comment/warning on it, and I wonder if it is still relevant.
Couldn't test with the upgraded dependency yet, so I will do that and mark the PR as ready once I am confident everything is stable.

testing this now

Had no crashes or issues for 2 days of usage with both streamer and client built from the PR, so I think its fine.

Seems straightforward enough for me, merging


Rename horizontal_fusion to horizontal_loop_fusion.

This is just to rename horizontal_fusion to horizontal_loop_fusion for better distinguishing between horizontal_loop_fusion and horizontal_input_fusion.

@thomasjoerg this is just the renaming per our previous discussion (here).
Please help to take a look. Thanks!

Thanks Thomas for taking a look of the PR.
I checked the CI results. The failures should not be related to the changes in this PR. Many of them are MLIR-related somehow.
Let me know if you need my further assistance in merging this PR. Thanks!


don't show the ionic2 Hello Ionic page

I installed ionic2 rc0 and created a new App . it run and opened the Browser. But it's not show the Hello Ionic page, The browser display nothing..can you tell me if I installed fail or the ionic2 rc0 don't show the welcome page wen I run it

The exact problem I’ve just run into.

It says "build dev failed" on your image...
Look here...  you may need to upgrade npm to v.3 by installing node 6.7
https://github.com/driftyco/ionic/blob/master/CHANGELOG.md#steps-to-upgrade-to-rc0

Hello, thanks for opening an issue with us! Most likely this is due to you either running npm 2 (we require npm 3 now) or running an old version of the cli. Also, make sure you follow our changelog when updating your app. Thanks for using Ionic!

Sorry to recover so late.I have check my npm version and ionic2 version . It is indeed the latest version.So hat else can make this kind of mistake？Thanks for your kind attention and look forward your prompt reply


Not getting all model attributes on query

Hi MIke,
it's me again with a strange behaviour ;)
In a controller i am doing this:
 $shop = Shop::where('id', '=', $request->get('shop_id'))->first();
 dd($shop);

Unfortunately i'm only getting one attribute back - not all like intended.
If i disable the cache i'm getting all attributes.
 $shop = Shop::where('id', '=', $request->get('shop_id'))->disableModelCaching()->first();
 dd($shop);

See the attached pictures.
Any clue why this is happening?
Thx
Jens

Hi @jetwes thanks for reporting this :) I will take a look, it might take some time though, as I am travelling, and won't be back at my office until next week.

no worries

@jetwes Have you resolved this issue? if not, could you please provide more information?

No i didn't and i really don't know what kind of informations could help - the problem is pretty clear - i  think..

@jetwes Sorry for the delays, I'm currently swamped with work and deadlines.

@jetwes Probably provide us with the minimal runnable code to reproduce this issue?

@shenjiayu I have what I need from what @jetwes already reported. Also, please don't represent yourself as one of the maintainers by saying "us" and asking people to submit more information.

@mikebronner Noted..Just wanted to see if I can help out since I couldn't simply reproduce it on my local. : )

@shenjiayu Gotcha, thanks. In those cases it would probably help to provide your eloquent query that shows it working. :)

@mikebronner no worries!

@jetwes I have set up a test for this, but have not been able to reproduce it. Can you clear your cache, and make sure you have the latest version of the plugin and try again? Thanks!
    public function testFirstReturnsAllAttributesForModel()
    {
        $author = (new Author)->where("id", "=", 1)->first();
        $uncachedAuthor = (new UncachedAuthor)->where("id", "=", 1)->first();

        $this->assertEquals($author->id, $uncachedAuthor->id);
        $this->assertEquals($author->created_at, $uncachedAuthor->created_at);
        $this->assertEquals($author->updated_at, $uncachedAuthor->updated_at);
        $this->assertEquals($author->email, $uncachedAuthor->email);
        $this->assertEquals($author->name, $uncachedAuthor->name);
    }

@jetwes I'll close this for now, but if you do still have this same issue, please re-open. Thanks!


[FEATURE REQ] Add single SQL database to failover group

Library name
Azure.ResourceManager.Sql
Please describe the feature.
I'm migrating from using the older, fluent library and missing a method to add a single database to an existing Failover Group.
Like used in this sample
Is there anything similar in this SDK besides the FailoverGroupPatch where the complete list of databases has to be provided?

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

Hi @rbe-planday , the FailoverGroupPatch.Databases is a list, you can use its Add method to add a single database.

@ArthurMa1978 Sorry, didn't specifiy my request fully. My scenario is that the Failover Group already has some databases, and I need to add another database to the group.
Using the FailoverGroupPatch I also need to also add the existing databases to the  from FailoverGroupData.Databases as well as my new database.
It's not a big deal, just the convenience method .WithNewDatabaseId(db.Id) that used to exist in the old SDK.

Hi @rbe-planday, Azure.ResourceManager.Sql is a totally re-designed SDK when compared with the fluent SDK, so we will not provide this kind of convenient method. Sorry for your inconvenience.


Unresolvable Warnings in Logs and summaries

Required Information
Question, Bug, or Feature?
Type: Bug
Enter Task Name: VisualStudio Test 2.*
Environment

Server - Azure Pipelines or TFS on-premises?
On premise AzureDevops Server 2019

Agent - Hosted or Private:

Private Agent (behind corporate firewall)
Agent.OS:  Windows_NT
Agent.OSArchitecture: X64
Agent.OSVersion: 10.0.17763
Agent.Version: 2.144.2

Issue Description
The pipeline's logs and summaries contain many warnings complaining about feature flags. As we have  many test tasks, it is hard to find the real warnings. We didn't found a way to suppress this.
Task logs
2019-05-29T06:59:11.2432918Z ##[section]Starting: VsTest - testAssemblies
2019-05-29T06:59:11.2439735Z ==============================================================================
2019-05-29T06:59:11.2439799Z Task         : Visual Studio Test
2019-05-29T06:59:11.2439874Z Description  : Run unit and functional tests (Selenium, Appium, Coded UI test, etc.) using the Visual Studio Test (VsTest) runner. Test frameworks that have a Visual Studio test adapter such as MsTest, xUnit, NUnit, Chutzpah (for JavaScript tests using QUnit, Mocha and Jasmine), etc. can be run. Tests can be distributed on multiple agents using this task (version 2).
2019-05-29T06:59:11.2439933Z Version      : 2.143.8
2019-05-29T06:59:11.2439986Z Author       : Microsoft Corporation
2019-05-29T06:59:11.2440031Z Help         : [More information](https://go.microsoft.com/fwlink/?LinkId=835764)
2019-05-29T06:59:11.2440089Z ==============================================================================
2019-05-29T06:59:11.9186461Z SystemVssConnection exists true
2019-05-29T06:59:11.9186719Z ##[warning]Unable to get feature flag: TestExecution.EnableTranslationApi
2019-05-29T06:59:12.0064107Z SystemVssConnection exists true
2019-05-29T06:59:12.0233060Z ##[warning]Unable to get feature flag: TestExecution.EnableDiagnostics
2019-05-29T06:59:12.0656544Z Running tests using vstest.console.exe runner.
2019-05-29T06:59:12.0656640Z ======================================================

Error logs
2019-05-29T06:59:11.9186719Z ##[warning]Unable to get feature flag: TestExecution.EnableTranslationApi
2019-05-29T06:59:12.0233060Z ##[warning]Unable to get feature flag: TestExecution.EnableDiagnostics

@AndreasHeisel These warnings are fixed in Server 2019 Update1. As of today, there is no way to suppress warnings through user input.

Closing this. Please reopen if you have any concerns here.

Hi,
We are using Azure DevOps, with onprem agents behind a firewall, proxy et cetera. We use agent 2.155.1 and latest version of vstest. Still our builds get the error message as mentioned above, and it takes roughly 20 seconds before the next comes in:
2019-09-16T08:03:52.8136618Z ==============================================================================
2019-09-16T08:03:52.8136730Z Task         : Visual Studio Test
2019-09-16T08:03:52.8136774Z Description  : Run unit and functional tests (Selenium, Appium, Coded UI test, etc.) using the Visual Studio Test (VsTest) runner. Test frameworks that have a Visual Studio test adapter such as MsTest, xUnit, NUnit, Chutzpah (for JavaScript tests using QUnit, Mocha and Jasmine), etc. can be run. Tests can be distributed on multiple agents using this task (version 2).
2019-09-16T08:03:52.8136854Z Version      : 2.156.2
2019-09-16T08:03:52.8136899Z Author       : Microsoft Corporation
2019-09-16T08:03:52.8136944Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/test/vstest
2019-09-16T08:03:52.8137006Z ==============================================================================
2019-09-16T08:03:55.5500287Z SystemVssConnection exists true
2019-09-16T08:04:16.5396455Z ##[warning]Unable to get feature flag: TestExecution.EnableHydra
2019-09-16T08:04:16.5405397Z SystemVssConnection exists true
2019-09-16T08:04:37.5963528Z ##[warning]Unable to get feature flag: TestExecution.EnableTranslationApi
2019-09-16T08:04:37.7022401Z SystemVssConnection exists true
2019-09-16T08:04:58.7225201Z ##[warning]Unable to get feature flag: TestExecution.EnableDiagnostics
2019-09-16T08:04:58.7795126Z Running tests using vstest.console.exe runner.
2019-09-16T08:04:58.7795349Z ======================================================

I'm seeing the exact same warrnings, Using latest Visual Studio 2019

We're having these warning as well.
Running Update 1 (Dev17.M153.4) with VS2019

We also have the same warnings. (Azure DevOps Server (on premises 2019.1) and VS 2019 16.6.x please reopen the ticket.

Same warnings too with VSTest task
On prem agent ( version 2.171.1) behind proxy communicating to hosted Azure DevOps using VS 2019 16.6.3 for test execution

We are facing the same problem:
2020-07-28T15:44:16.9260218Z ##[warning]Unable to get feature flag: TestExecution.EnableHydra
2020-07-28T15:44:16.9272552Z ##[debug]Processed: ##vso[task.issue type=warning;]Unable to get feature flag: TestExecution.EnableHydra
2020-07-28T15:44:16.9273134Z ##[debug]Unable to get feature flag TestExecution.EnableHydra Error:unable to get local issuer certificate

@AndreasHeisel could you please reopen the issue, we also have the same warnings.
Azure DevOps Server (on premises 2019.1) and VS 2019 16.6.x.
AND
Azure DevOps Server (on premises 2020 RC2) and VS 2019 16.6.x please reopen the ticket.

We are still experiencing the issue as well.

Same warnings too with VSTest task
On prem agent ( version 2.171.1) behind proxy communicating to hosted Azure DevOps using VS 2019 16.6.3 for test execution

Same situation and configuration on our side.

We are also facing the same issue,

##[warning]Unable to get feature flag: TestExecution.EnableTranslationApi
##[debug]Processed: ##vso[task.issue type=warning;]Unable to get feature flag: TestExecution.EnableTranslationApi
##[debug]Unable to get feature flag TestExecution.EnableTranslationApi Error:unable to get local issuer certificate
##[warning]Unable to get feature flag: TestExecution.EnableDiagnostics
##[debug]Processed: ##vso[task.issue type=warning;]Unable to get feature flag: TestExecution.EnableDiagnostics
##[debug]Unable to get feature flag TestExecution.EnableDiagnostics Error:unable to get local issuer certificate
##[debug]Diagnostics feature flag is set to: false


How can i go back with history.go(-1)?

It works but is it safe to use this approach?

How can I safely "go back" from a component?
I have a route that can be reachable from multiple part of my app. I'd like to create my component smoothly and render a "go back" button which will redirect the user to the previous page.
I don't use the standard history, I use memoryHistory from the package history.
What's the best way to do this?

Closing because the original question has long been answered.

According to the docs of the history package you can either call history.go(-1) or history.goBack().

It looks like the URL has changed for the relevant history package docs (.../Navigation.md 404ed for me, but ../navigation.md resolved to documentation about history navigation).
https://github.com/remix-run/history/blob/dev/docs/navigation.md


Error with nullable ref types with netcoreapp3.1

Issue Description
Issues found with nullable ref types when TargetFramework is netcoreapp3.1
Steps to Reproduce

Create a new .NET Core console app
Add the following code to Program.cs:

            string? testString  = "Hi";
            Console.WriteLine(testString);

Add <Nullable>enable</Nullable> to the project file.
Build - Note: Builds and runs fine.
Open in vscode
Build

Expected Behavior
No error shown
Actual Behavior

Red underline on the "?" with an error: Feature 'nullable reference types' is not available in C# 7.3. Please use language version 8.0 or greater.
The project is defaulted to netcoreapp3.1.  If I try the same steps, but set the TargetFramework to netcoreapp3.0, there is no issue.

Logs
OmniSharp log
Post the output from Output-->OmniSharp log here
C# log
Post the output from Output-->C# here
Environment information
VSCode version: 1.40.2
C# Extension: 1.21.8
Mono Information
        OmniSharp using built-in mono
Dotnet Information
.NET Core SDK (reflecting any global.json):
 Version:   3.1.100
 Commit:    cd82f021f4
Runtime Environment:
OS Name:     centos
OS Version:  7
OS Platform: Linux
RID:         centos.7-x64
Base Path:   /usr/share/dotnet/sdk/3.1.100/
Host (useful for support):
Version: 3.1.0
Commit:  157910edee
.NET Core SDKs installed:
3.0.101 [/usr/share/dotnet/sdk]
3.1.100 [/usr/share/dotnet/sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.App 3.0.1 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 3.1.0 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.0 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

csharp
ms-vscode
1.21.8

@dseefeld I was able to get the "red underline" to go away in my netcoreapp3.1 project
In the .csproj I added  to the
  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>netcoreapp3.1</TargetFramework>
    <LangVersion>latest</LangVersion>
  </PropertyGroup>

Configure language version
Not sure if that is a permanent solution but at least the warning disappeared
Could probably set this to "3.1" also to get the same effect

Same error appears using Visual Studio 2019 (16.3.6)
I upgraded my netcoreapp3.0 to netcoreapp3.1
This same error appears at lines like: var value = null!;
Adding <LangVersion>latest</LangVersion> fixed the issues. Thanks for the suggestion.

Same fix worked for me. Happened after upgrade to 3.1. .Net Core is one buggy ecosystem to develop in.

if LangVersion is not found, then OmniSharp will use default language version which is C# 8.0.
if you encounter this problem, it could be that something else (i.e. Directory.Build.props file) is resetting the language version to something different or you are using an older version of the extension.
In either case, please submit your OmniSharp log when you encounter this.

For me the cause was an outdated Visual Studio installation. 16.4 is required for .NET Core 3.1 and I was on 16.3.9
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Visual Studio Community 2019 16.3.29509.3 - "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin"
            2: StandAlone 16.3 - "C:\Users\stijn\.vscode\extensions\ms-vscode.csharp-1.21.9\.omnisharp\1.34.9\.msbuild\Current\Bin"
[...]
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Visual Studio Community 2019 16.3.29509.3 - "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin"
[...]
[dbug]: OmniSharp.MSBuild.ProjectSystem
        MSBuild environment:
Mode: VisualStudio
RunningTests: False
RunningInVisualStudio: False
MSBuildToolsDirectory32: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin
MSBuildToolsDirectory64: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\amd64
MSBuildSDKsPath: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Sdks
CurrentMSBuildConfigurationFile: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\MSBuild.exe.config
CurrentMSBuildExePath: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\MSBuild.exe
CurrentMSBuildToolsDirectory: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin
VisualStudioInstallRootDirectory: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
MSBuildExtensionsPath: C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild

After updating to 16.4 the <Nullable> feature works as expected.
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Located 2 MSBuild instance(s)
            1: Visual Studio Community 2019 16.4.29728.190 - "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin"
            2: StandAlone 16.3 - "C:\Users\stijn\.vscode\extensions\ms-vscode.csharp-1.21.9\.omnisharp\1.34.9\.msbuild\Current\Bin"
[...]
[info]: OmniSharp.MSBuild.Discovery.MSBuildLocator
        Registered MSBuild instance: Visual Studio Community 2019 16.4.29728.190 - "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin"

Without Visual Studio installed, I assume the extension falls back on its internal instance. But the internal instance seems to be running 16.3, even though https://github.com/OmniSharp/omnisharp-vscode/releases/tag/v1.21.9 mentions updating to 16.4 on Windows. Likely other users are experiencing this issue due to the outdated internal version.

Thanks for the report. There was a bug in the C# targets in the lead up to the full release of .NET Core 3.1 where the implicit default LangVersion was 7.3 instead of 8.0. This might be the source of the issue. I just tried this with the .NET 5 preview SDK and latest OmniSharp and everything worked as expected. If you don't see this working, please let us know and we can take a look.


Multi-threading mode support

Hi, the advanced API supports multi-threading. Can this be added as an option to select the number of threads? This should help improve performance. Thanks!
See: https://github.com/facebook/zstd/blob/dev/lib/zstd.h#L595

Yes, I am slowly migrating to the AdvancedAPI and will expose the threads/worker param also.

Currently this is the blocker to migrate the compression side to the advanced API: https://github.com/facebook/zstd/issues/1544

Hi, with the last commit I have provided setWorkers method on ZstdOutputStream. It  should enable the multi-threading but I have not tested it.

Thanks. Is it possible to use it with byte[] or bytebuffer directly? Or is it only for streams?

It's only for streams. There is a new API, ZSTD_compressCCtx that I intend to bind to but it's not there yet.

BTW, I pushed v1.3.8-6 to Maven central, if you want to test it.

I'm getting an "Unsupported parameter" error when calling setWorkers(). The Zstandard manual  indicates multi-threading parameters require the build macro ZSTD_MULTITHREAD. If this is the reason, do you plan to provide a release with this enabled?
Thanks!

Hmm, looks like I missed it and didn't have test. I will fix soon.

@julien-pcd , I just pushed v1.3.8-7 to Maven central - it is compiled with ZSTD_MULTITHREAD defined.

@luben Is this default 1 or same default in the lib?

@tomerz90 , by default it does not use multiple threads/workers - multi-threading have to be explicitly enabled with setWorkers(n)

I see, thanks


Parser (Configuration File)

read and load configuration file

#11
Things to be done @Tentanus :

[ ] Still input needs validation
[ ] Didn't include cgi option
[ ] Didn't include redirection parsing
[ ] Didn't include default
[ ] Didn't create extra config files
[ ] I didn't refactor the class implementations


Various enhancements

Description

Don't load the geocoder component if the mapbox token is empty string.
Add permissions to the GitHub action so it doesn't require a token to push to the same repository.
Add keyboard shortcuts for toggle options. The hotkeys are underlined in the labels, and I chose keys that are generally on the left side of the keyboard (I'm left handed so might be biased?) Screenshot

QA steps

[ ] Remove GitHub token for GitHub pages deployment, it should still work
[ ] Load a config with empty mapbox token, it shouldn't show errors in the console
[ ] Try keyboard hotkeys

Author checklist
Create the PR

[x] Fill out PR template
[ ] Make sure you've added a CHANGELOG entry under "Unreleased"
[x] Request a review
[ ] Make any requested changes and get approval

After approval

[ ] Merge any changes from main into your branch, resolve any conflicts
[ ] Squash & merge changes into main
[ ] Delete branch

Yeah, I just discovered that too - lemme see if there's a way to make the keys work without screwing up other stuff

https://github.com/stamen/maperture/pull/158/commits/0d609720e47346b7919b23c3582df5c7d90550ff PTAL


🔄 synced file(s) with neurobagel/workflows

synced local file(s) with neurobagel/workflows.

Changed files

synced local directory .github/workflows/ with remote directory template_workflows/project_automation/

This PR was created automatically by the repo-file-sync-action workflow run #8376284432

With this one i'll wait for review ... I think the PAT should work now


https streams: how to play them?

I have an https stream I want to hear: "https://streams.radio.dpgmedia.cloud/redirect/joe_gold/mp3".
Adding "streams.radio.dpgmedia.cloud/redirect/joe_gold/mp3" or "https://streams.radio.dpgmedia.cloud/redirect/joe_gold/mp3" or "streams.radio.dpgmedia.cloud:443/redirect/joe_gold/mp3"
into the config/preferences  does not work.
Is the code capable of handling https streams? If so, how to let it know it is a https stream.
Thx

Sorry, the radio cannot play SSL streams.
I do not understand why a station decides to use an encrypted stream.  Maybe the are affraid that someone listens in....

Ha! OK. Thx!

Hi,
I'm all new here, so I am reluctant to open a new topic ;-)
I also have a one stream address that is not playing: ais-sa8.cdnstream1.com/2749_64.aac
The track info is showing, but no sound. Works in browser and on a Frontier Silicon based webradio (Teufel360).
Any hints?
Thank you for the great work!!!
Armin

This stream is playing with my radio (running an old version  Th 03 Nov 2022 ...)
Tested with the web interface.
I pasted  ais-sa8.cdnstream1.com/2749_64.aac in the field "Enter a station/file here ..." and clicked PLAY

Also tested it.  Plays well with my set-up (SPDIFF output).
If you are using a VS1003, AAC is not supported.

I tested it on a fresh build/download last night, using the Helix SPDIF optical output on a "china" ESP32-wroom board....
Also pasting the URL via the web interface

...just for documentation on how to obtain a 44,1k bitrate from a 22,05k stream:
In helixfuncs.h/playChunk(), double the samplerate and output each sample twice.
Though the 64kbit stream does not really sound adequate on HIFI equipment ;-(
Again thanks for the great effort&prompt support!
Armin


Qingwei/fix price proposal resubscription

OK to merge

Do not merge when test failed =)

Changes Unknown when pulling 1d17a0414aeb87cb675e1c9546b1c1ba54ac391c on qingweibinary:qingwei/fix_price_proposal_resubscription into ** on binary-com:master**.


Relax dependencies

To realign with Labelings/Labeling@d160bc685199e44cf3bb52e27878ff718c71b2a9.

Thanks, @tomburke-rse!
So now @jdeschamps I guess we just need another new release of Labeling, which will trigger another conda-forge PR here, which can be merged...

Hi @ctrueden , somehow I missed that. Is it still the case (that we need a new release)?

@elevans Where are we at? Do we need another Labeling release, to tidy up behavior of downstream conda packages? Or is everything already working now?

We do not need another Labeling release. Version 0.1.14 build 1 on conda-forge builds for py312. We it resolved our feedstock issues :+1: .


Delete redundant task 'Verify publish compat results success' from pipeline

Fixes #minor
Description
In pipeline BotBuilder-DotNet-CI-PR-yaml, task 'Verify publish compat results success' was a workaround for a bug in task 'Publish compat results to GitHub'. The bug: the task would show success when it had actually failed to publish due to a bad GitHub token. That bug is now fixed.
Specific Changes
Delete redundant task 'Verify publish compat results success'

As shown in https://github.com/microsoft/Power-Fx/pull/552 'Publish compat results to GitHub' v 0.2.4 still creates a duplicate comment. Wait for a fix.


⚠ Thumbnails API Endpoint has degraded performance

In f11d687, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 5105 ms

Resolved: Thumbnails API Endpoint performance has improved in 8d84206 after 4 minutes.


Bug fix for https://github.com/rickynils/scalacheck/issues/138

In the multi threaded test destroySut was called before the property check was executed

Great! Thanks!


Allow mechanism for propagating internal errors from the storage

Currently, any error from storage is returned to the user as a 422 (see #1213 for the discussion).  The argument for this seems predicated on the idea that "the storage interface doesn't report errors", but thats not the case any more.
I propose we allow the storage layer to propagate errors by exposing the apiErr type, and adding a case to https://github.com/prometheus/prometheus/blob/master/web/api/v1/api.go#L192 that passes apiErrs straight through.  That way, the storage can throw an apiErr for internal error.
May need to more apiErr to a new package, so prevent circular imports.
WDYT?

I think the storage layer should have no notion of any API using it (and thus of the API's error types) and should instead define its own error types that can be interpreted by users of the storage layer. These errors should probably live in a relatively non-implementation-specific package (maybe the existing github.com/prometheus/prometheus/storage - or a new one) and should be kept general enough to work for different storage implementations, so that whoever interprets these errors doesn't have to know what exact storage implementation they are dealing with.

Do we currently need to know anything more than "the storage reported an error"?

@brian-brazil Yes, some errors are the user's fault, at least upon ingestion:

"sample timestamp out of order"
"sample with repeated timestamp but different value"

Cortex has a few more of those that are related to rate-limting/throttling. Currently they are all on the ingestion side, but there will also be query-related ones.

(I guess the rate-limiting / throttling could be wrapped around everything though)

I'm not particularly worries about the ingestion side, as we implement it end-to-end in Cortex.  Its really only important for the query side, where the promql library sits in the middle.  I'm happy to make a "InternalStorageError" type in the storage package that gets interpreted as a 500 by the query layer if you like?

Hm yeah, if we're happy with just treating any error from the storage as an internal error for now, then this can indeed all be done in the API handling code.

AFAICT the query.Exec method can still return non-storage related errors (hence the original error handling), so a special error type is still needed to differentiate storage error (which should be 500s) from non-storage errors (which are currently 422s).

Ah yes, query.Exec would need to be changed to let callers know what's an internal vs. user error. The error types for that should be defined in the promql package I think.


Add travis and modifications on bot

I'm closing this PR only for speed sake. Next ones will have to be peer reviewed by at least one other person.


Chants (not just sources) should be able to belong to a segment

For the to-be-created Benedicamus Domino segment and the to-be-merged Clavis Sequentiarum, we need chants to be able to belong to a segment, not just sources (a source may contain chants in multiple segments).

PR #1434 goes part of the way towards addressing this issue. The remaining steps are:

[ ] Run the new assign_chants_to_segments command when these changes are introduced to staging and production servers.
[ ] Remove that command from the repo (once this initial change has been made, there is no further need for the command)

Argh! I also realized that the assign_chants_to_segments command in #1434 does not assign sequences to their segment!  So I'll add that additional step here too:

[ ] Revise assign_chants_to_segments command to assign Sequence objects to a segment as well.

This issue is obviated by the new chant-level project relationship introduced in #1548.


INT-B-18637 p2

Agility ticket
Summary
Added missing implementation for Prime Queue and Prime move details AC
How to test

Create a move with BB Order Type
Login as a Prime
BB label should show in queue and on move details page

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against a0ac2fbf767c4a27d0dd56db0b99e78e490e059f


Elvis no longer reacts in Deep Sea: Nullify Threat

He follows you like he should, but he won't dodge bullets, instead absorbing them and refuses to react to being shot. Enemies with or without the cloak elicit 0 reaction from him whatsoever. Beforehand he reacted almost instantly when he saw someone uncloaking or enter his field of view.
Relevant link https://youtu.be/o0RKDJ9f7RU

Wonder if this started happening after #134. Can you test on these builds?

I currently don't have Linux installed, but he behaves far closer to his N64 counterpart in the Windows build within the link you provided.

It would likely be the same on Linux, thanks for checking. I suppose we'll need a different solution then.

I meant he behaves more correctly in the provided build. He acts more like I would expect him to react on an actual n64. sorry if I worded that wrong in the last post.

No, I understand, I was referring to the issue that #134 was trying to solve.

oh, my misunderstanding. thank you for all your hard work though!

Oh dang, I'll take a look into this.

This is an interesting one, Elvis calls the bottom path of chrHasLosToPosWasteful because they have the CHRFLAG1_NOOP_00200000 flag, which I'm not sure what that flag represents. Even if they didn't have that flag though Elvis is able to see and target enemies behind him in the original game, which the new angle check would prevent. Currently testing to see if having chrHasLosToProp use chrHasLosToPos instead of chrHasLosToPosWasteful would have any regressions. Though if the original chrHasLosToPosWasteful function just called chrHasLosToPos either way, it'd be interesting to see if there somehow was a regression. I'm worried this is entering hacky territory though, and there might be a better solution to the guard line of sight problem to begin with.

Okay, thank you for investigating. I guess I'll roll back the change for now.

I'll close this and reopen the old issue.


python  & signmask

In RORB (and others):
     cpu.psw_n = val & signmask
    cpu.psw_z = (val == 0)
     cpu.psw_v = cpu.psw_n ^ cpu.psw_c

Now val is 0...255. Signmask is 128. So psw_n can be 128 and 0.
This makes psw_v into 0, 1, 128 or 129.
_brconds (in branches.py) for v-flag is:
    0o102000: lambda n, z, v, c: not v,            # BVC
    0o102400: lambda n, z, v, c: v,                # BVS

I think you shold either make the lambda in: "not (v & 1)" and "(v & 1)" or the asignment of the n-flag into e.g.:
     cpu.psw_n = 1 if  val & signmask else 0

If you agree, then https://github.com/outofmbufs/python-pdp11-emulator/pull/7 is a patch for that (hopefully I found every case).

Ugh .. I got this right in branches but not here. I think the better fix is to replace the four instances of
cpu.psw_v = cpu.psw_n ^ cpu.psw_c

in op00.py with
cpu.psw_v = bool(cpu.psw_n) != bool(cpu.psw_c)

I searched for other uses of '^' ... this should be the only ones.
Might not get around to testing / checking in this change until later today / this weekend (I want to write test cases too).

Please consider adding RK05 or RL02 support so that one can run the XXDP
diagnostics set. Maybe that finds other issues (if any!).
regards
On Fri, Mar 29, 2024 at 5:03 PM Neil Webber @.***>
wrote:

Ugh .. I got this right in branches but not here. I think the better fix
is to replace the four instances of
cpu.psw_v = cpu.psw_n ^ cpu.psw_c
in op00.py with
cpu.psw_v = bool(cpu.psw_n) != bool(cpu.psw_c)
I searched for other uses of '^' ... this should be the only ones.
Might not get around to testing / checking in this change until later
today / this weekend (I want to write test cases too).
—
Reply to this email directly, view it on GitHub
https://github.com/outofmbufs/python-pdp11-emulator/issues/6#issuecomment-2027423336,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUN5IW4NUSTTYAJPUUXF64TY2WGCTAVCNFSM6AAAAABFOSLIKKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGQZDGMZTGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Fixed this bug w/changes (only) in op00.py (use bool(A) != bool(B) instead of A^B)


Code up baseline model (LDA, BERT+cluestering, LDA-BERT-Clustering)

Add code to used for performing baseline experiments and baseline topic modelling plus evaluation functions

Expected Date of Finish - 09/01/2023

BertTopic- is a good library for pretrained network usage


macOS app isn’t uploading GIFs

I tried to publish this post via the macOS app and it uploaded the GIF as an jpg to both micro.blog as well as all the crossposted platforms. I had to go and delete all the posts one by one. Then I tried posting the GIF from micro.blog’s website and everything worked fine.
Not sure if iOS has the problem too.

This is fixed in the upcoming Mac 2.1.1 release.


Failed to convert mzml files from .wiff, because of Illegal characters in path

Hi guys,
I try using MS convert to convert a .wiff file to .mzml files, as I do all time.
However, this time something went wrong with Analyst software (Sciex acquisition soft.) when generating the very first acquisition, called blank, and makes MCconvert fail:
"Starting...
Opening file "D:\Analyst Data\Projects\20231122_P-22069_S-Perocchi_ALS_CSF_Plate04\Data\SLA Batch - 20231123 - 1.wiff" for read...
Failed - System.ArgumentException: error generating output filename for input file 'D:\Analyst Data\Projects\20231122_P-22069_S-Perocchi_ALS_CSF_Plate04\Data\SLA Batch - 20231123 - 1.wiff' and output run id 'SLA Batch - 20231123 - 1-Blank_10
Blank_10
Blank_10
Blank_10
blank_0000' ---> System.ArgumentException: Illegal characters in path."
This issue is specific to that sample. So my question, is it possible to skip this particular sample, so the software can manage the rest?
Thank you very much for your help!
Best wishes,
Fabien

To me, that looks like there are newline characters in a sample name inside
your WIFF file. The file is:
Data\SLA Batch - 20231123 - 1.wiff
And the sample name is:
"Blank_10
Blank_10
Blank_10
Blank_10
blank_0000"
And MSConvert is trying to create a separate mzML file for each sample in
your WIFF file by using the naming strategy:
-.mzML
I am not sure what this code currently does to remove invalid path
characters from the  but it seems that code needs to be
improved to include \n and \r and any other invalid path characters it may
have omitted.
I am sure this will be a relatively straightforward fix that can be
released soon. In the meantime, if SCIEX offers any ability to edit sample
names in a WIFF file, you could fix this on your side. And probably you
should look into how you created such an odd and undesirable sample name in
the first place and avoid doing it again.
Thanks for posting your issue so clearly.
On Fri, Nov 24, 2023 at 12:51 AM FabRiols @.***> wrote:

Hi guys,
I try using MS convert to convert a .wiff file to .mzml files, as I do all
time.
However, this time something went wrong with Analyst software (Sciex
acquisition soft.) when generating the very first acquisition, called
blank, and makes MCconvert fail:
"Starting...
Opening file "D:\Analyst
Data\Projects\20231122_P-22069_S-Perocchi_ALS_CSF_Plate04\Data\SLA Batch -
20231123 - 1.wiff" for read...
Failed - System.ArgumentException: error generating output filename for
input file 'D:\Analyst
Data\Projects\20231122_P-22069_S-Perocchi_ALS_CSF_Plate04\Data\SLA Batch -
20231123 - 1.wiff' and output run id 'SLA Batch - 20231123 - 1-Blank_10
Blank_10
Blank_10
Blank_10
blank_0000' ---> System.ArgumentException: Illegal characters in path."
This issue is specific to that sample. So my question, is it possible to
skip this particular sample, so the software can manage the rest?
Thank you very much for your help!
Best wishes,
Fabien
—
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/issues/2786, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUEOURY6SCXMSW2OVGLYGBNZ7AVCNFSM6AAAAAA7YZODWKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYDSMZTG43TQOI
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Thanks for the report. I forgot to update MSConvertGUI's logic when I did msconvert's.


docs: A sample code may cause circular dependencies

📚 Is your documentation request related to a problem? Please describe.
【Other action】 import 【accessor】, and ths 【accessor】 may import 【Other action】 too .
This will produce hidden annoying circular dependencies
🔍 Where should you find it?
Getting started (Vue) - Typed Vuex
ℹ Additional context
A plugin to detect it : aackerman/circular-dependency-plugin: Detect circular dependencies in modules compiled with Webpack

@hanshou101 Thanks for reporting ❤ Would you be able to create a reproduction on GitHub or CodeSandbox?

Hello sir, I created this minimal repo: typed-vuex-demo .
As you can see, the first commit is the initialization of the scaffolding . The second commit is the incremental code with circular dependencies.
It will have an impact in two places:

The web page will be blank and an error will be reported.
[circular-dependency-plugin] The dependency path is detected and an error is reported.

Thanks! I will take a look soon.

@hanshou101 This is actually the same underlying issue as #100, and it is fixed by defining your state with a factory function, e.g.:
const state = () => ({
  otherEmail: '',
});

I updated the state documentation but failed to update the getting started guide so will do that straight away :+1:
Many thanks for reporting this issue!


Module 1 - Lab 1 - Step 4 - BULK statement code stars should be removed

Module: 01
Lab/Demo: 01 Query files using a serverless SQL pool
Task: Use SQL to query CSV files
Step: 04
Description of issue
The code sample in the step 4 should not have the two star icons in the end of the BULK statement :
-- This is auto-generated code
SELECT
    TOP 100 *
FROM
    OPENROWSET(
        BULK 'https://datalakexxxxxxx.dfs.core.windows.net/files/sales/csv**',
        FORMAT = 'CSV',
        PARSER_VERSION='2.0'
) AS [result]
Repro steps:

I launched Synapse workspace and executed the code
Got an error
Removed the two stars in BULK statement and it works

Thanks for raising this @annav88 - I'll take a look and close the issue once it's resolved!


fix(core): rebind inputs on change context

Wow, thanks!
I have almost the same changes in local branch. I'll merge all of these changes. Thank you for your support.


update ModResolver to not attempt to parse files that match the ignore pattern

Refs https://github.com/rust-lang/rustfmt/pull/3777#issuecomment-528326806

AFACIT, when there's a parser error in the main file, we hit the Err(ErrorKind::ParseError) arm (line 91) after calling parse_crate and don't even make it down to the ModResolver in such a scenario:
https://github.com/rust-lang/rustfmt/blob/1ded995ee79c44069b7832e5aba00162fc2113fa/src/formatting.rs#L82-L92
This is the case for the error we are seeing with the ice file in #3777.
If I've got that right, then I see a couple options (let me know if there are others/better ones!):

Don't attempt to parse the input at all in format_project if the main_file is a match in the ignore_path_set. This could be done conditionally, such as only applying if the main_file is under tests/ subdirectories and/or only if a new flag for rustfmt is provided (basically a Config setting that when enabled would make this check more of an OR than an AND)
https://github.com/rust-lang/rustfmt/blob/1ded995ee79c44069b7832e5aba00162fc2113fa/src/formatting.rs#L73-L75
Update the Err(ErrorKind::ParseError) arm (line 91) on the parse_crate to behave differently if the parse error came from a file that's a match in the ignore_path_set. Perhaps something like

        // Surface parse error via Session (errors are merged there from report)
        Err(ErrorKind::ParseError) => {
            if ignore_path_set.is_match(&main_file) {
                return Ok(FormatReport::new());
            }
            return Ok(report)
        },

Between those two options, I think I'm inclined to go with option 1, perhaps changing
https://github.com/rust-lang/rustfmt/blob/1ded995ee79c44069b7832e5aba00162fc2113fa/src/formatting.rs#L73-L75
to
   // new config setting do_not_parse_ignore_matches
    if ignore_path_set.is_match(&main_file)
        && (config.skip_children() || config.do_not_parse_ignore_matches())
    {
        return Ok(FormatReport::new());
    }

Thank you for delving into this issue!

when there's a parser error in the main file, we hit the Err(ErrorKind::ParseError) arm (line 91) after calling parse_crate and don't even make it down to the ModResolver in such a scenario

I think that you are right here.
I personally prefer the option 2, as that way we can avoid adding a new config option. If we go that route, we may also need to wrap parse_crate with catch_unwind as the rustc parser sometimes dies with panic on certain parse errors 🤷♂

I've got option 2 working, and getting the desired zero exit code. There is already a catch_unwind within parse_crate:
https://github.com/rust-lang/rustfmt/blob/1ded995ee79c44069b7832e5aba00162fc2113fa/src/formatting.rs#L660
However, the parse error is still displaying on the terminal. Is that still the desired behavior?
I suppose if we wanted to suppress we could use panic::set_hook with a no op closure, or would wrapping the call to parse_crate supress that too?

There is already a catch_unwind within parse_crate:

Great! Thank you for checking.

However, the parse error is still displaying on the terminal. Is that still the desired behavior?

It would be better if we could not display the parser error from files that are specified in ignore. IIRC the code which displays parser errors is this:
https://github.com/rust-lang/rustfmt/blob/1ded995ee79c44069b7832e5aba00162fc2113fa/src/formatting.rs#L671
We can suppress these error messages by explicitly canceling it. rustfmt already does this when parsing macro arguments from the token stream:
https://github.com/rust-lang/rustfmt/blob/1ded995ee79c44069b7832e5aba00162fc2113fa/src/macros.rs#L108-L109
I think we can do the same thing here against errors from files that matches the ignore pattern.

IIRC the code which displays parser errors is this:

At least on my machine, the error is being printed to the console directly from that catch_unwind line. When I first started looking for the source I started on line 671 too, but it was already printed before that point.
I'll take another look at it though 👍

At least on my machine, the error is being printed to the console directly from that catch_unwind line.

Ok, now I recall it correctly :smile:
The rustc parser handles an error by either returning Err or panicking (sigh). Which is used depends on the kind of syntax error and we cannot tell beforehand. https://github.com/rust-lang/rustfmt/issues/3779#issuecomment-528658048 handles the former, and the catch_unwind implicitly handles the latter.
E.g, the parser will return Err against this snippet:
abc

but panics against this snippet:
fn main() {
    1x;
}

So if we want to completely silence the parser error against the skipped main file, we need to do both adding panic::set_hook and https://github.com/rust-lang/rustfmt/issues/3779#issuecomment-528658048.

This one is turning out to be more involved than I'd originally thought 😄
I tried panic::set_hook no avail, but that lead me to take a closer look at the emitter being used for the parse session.
It now has me wondering if we could just set the emitter to silent_emitter() if the file is an ignore_set_match. I tested it out locally and works like I'd hoped. Any concerns with that?


[chip-tool] Add --skip-commissioning-complete optional parameter for …

…non-concurrent connection use case
In non-concurrent commissioning flow, the commissioning-complete command is done over a different connection. There is not way to exercise this scenario using chip-tool at the moment (unless manually doing all the PASE session steps...).
This PR set the right boolean flag in CommissioningParameters so it can be done.

@vivien-apple Hi, Vivien, I am confused of this.

In non-concurrent commissioning flow, the commissioning-complete command is done over a different connection.

But in SPEC, the commissioning-complete command is sent over the operational network in both concurrent and non-concurrent commissioning flow.

@vivien-apple Hi, Vivien, I am confused of this.

In non-concurrent commissioning flow, the commissioning-complete command is done over a different connection.

But in SPEC, the commissioning-complete command is sent over the operational network in both concurrent and non-concurrent commissioning flow.

This is correct. The commissioning-complete command is sent over the operational network in both concurrent and non-concurrent commissioning flow.
That said, the commissioning-complete command may be sent by a different node. Without this patch the commissioner node was always the one sending commissioning-complete. While this patch allows to stop at step 12 of the commissioning flow, and then open a CASE connection from a different node over the operational network before sending the commissioning-complete command.


License info

What license is this project licensed under?

Hey @execat , we chose the standard MIT license and added it to the repo to clarify.

Please merge this as well: https://github.com/gillesdemey/Cumulus/pull/30


Push Notifications not working

I am using sinch binding provided by you for calling .Every thing is working good like making call, Receiving call . But I want to implement PUSH notification features given by sinch for accepting call even if app is not running .
As per sinch documnetation when i add mSinchClient.SetSupportManagedPush(true); then i receive follwing error :
Java.Lang.NoClassDefFoundError: Failed resolution of: Lcom/sinch/android/rtc/internal/client/gcm/InstanceIDTokenService;
Please help to to solve it.
my sinch start configuration are as following :
mSinchClient.SetSupportCalling(true);
//  mSinchClient.StartListeningOnActiveConnection();
mSinchClient.SetSupportManagedPush(true);
mSinchClient.CheckManifest();
mSinchClient.AddSinchClientListener(new MySinchClientListener(this));
// Permission READ_PHONE_STATE is needed to respect native calls.
mSinchClient.CallClient.SetRespectNativeCalls(false);
mSinchClient.CallClient.AddCallClientListener(new SinchCallClientListener(this));
mSinchClient.Start();

Hi @tajinder95 did you manage to fix this?
Thank you

@varo610  There are some components missing in NAXAM binding project.
So I took native sinch aar file and create own binding .
You can download sinch dll from google drive link https://drive.google.com/open?id=1JqglF4egE_3mOYVyRGHnfytrnVsiQLBe


Loops Part 1 (189-198)

for, while, nested arrays, guessing game!

@telestrial how did it go?

@Equable-Ethyn How'd what go?


Background with a simple texture

A solid color background is not that bad (especially if the color is chosen correctly). You might also think about a simple background texture as an option. But be careful not to choose some  cheap gradient. :P

Agreed - I'm not a designer, so I stuck with minimalism. I had plans to allow user-uploaded backgrounds, but it didn't seem worth the hassle. I can add some curated backgrounds through, maybe loot https://www.toptal.com/designers/subtlepatterns/ - Thanks for the feedback, I'll keep this issue open until better backgrounds get added.

Very cool site! Just try to choose simple patterns like this one, for instance: https://www.toptal.com/designers/subtlepatterns/p4/ And not some fancy ones. You can utilize them so that the user would be able to choose a solid color (which is already possible) and then (optionally) put one of these patterns onto this solid color background.

It would be also nice if the user could define the color of that texture (white or gray by default?) too.

I looted transparenttextures.com, and added a color picker. Huge improvement, thanks!
https://beta.solitaire.gg/settings

Also, you could consider some kind of a transition effect when changing textures (now you click on a texture, and a new pattern "suddenly" appears). For instance, the old texture would fade out, and the new one appear in its place.

Cool idea, but probably more effort than it's worth, CSS doesn't let you fade backgrounds easily.
Also, had a question for you. Right now, users default to a blank blue background. I like using the blue, but should probably include a texture by default. What's your favorite?

I don't know... Maybe something simple like this one called "vichy", but it's hard to decide. :P Don't forget to mark in some way the option without the texture (it took me some time to actually find it).

Added an "X" to the "no texture" option, changed the default texture.


B 17664 remove vendor panel on ppm shipments

B-17664 remove vendor panel on ppm shipments
Summary
"As a TOO when creating a MTO for a Partial PPM
I should not see an option of selecting a type of “Vendor” (either GHC Prime Contractor or External vendor)
So that as the TOO I can enter the Origin info and complete the PPM without this unnecessary step"
Previously this panel only appeared on the page if the user is a TOO AND the shipment type is NOT HHG.
Since this task requires removing the panel for TOO when editing a PPM only, I have added a clause that will not show this panel for PPM moves.
This means that the new case for the panel showing will be: The user is a TOO AND the shipment type is NOT HGG AND the shipment type is NOT PPM. If all 3 conditions are not met, the panel will not show.
Now, the panel will only show for NTS or NTSR shipment options when viewing as a TOO. A quick adjustment to my local tests confirm this.
Verification Steps for the Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[x] Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers
These are to be checked by a reviewer.

[ ] Has the branch been pulled in and checked out?
[ ] Have the BL acceptance criteria been met for this change?
[ ] Was the CircleCI build successful?
[ ] Has the code been reviewed from a standards and best practices point of view?

How to test

Access milmove's office client
Login as a TOO role
Look for existing shipments.
Select one, and then select "Edit Shipment"
See if the Vendor panel is present, test the form by submitting it.

Frontend

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
[ ] There are no new console errors in the browser devtools.
[ ] There are no new console errors in the test output.
[ ] If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
[ ] This change meets the standards for Section 508 compliance.

Backend

[ ] Code follows the guidelines for Logging.
[ ] The requirements listed in Querying the Database Safely have been satisfied.

Screenshots

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 98c6e7dd068356639fadb478c06d5590e8bc1a13


Feature Request: Build Libraries from tags

I'd like to build out separate libraries for things like 4K media or Kids, but I don't know that I want to move the media into separate folders.
Is it possible to do something like https://github.com/adamgot/python-plexlibrary does and instead of building Libraries from trakt lists, it builds libraries from tags (like genre, rating, or another custom tag) in the media?

duplicate of #419


Wait for tasks to be expunged.

Should fix the following error:
sbt.ForkMain$ForkError: org.mockito.exceptions.verification.WantedButNotInvoked:
Wanted but not invoked:
taskStateOpProcessor.process(
    ForceExpunge(task [my_app.b347a7ae-80cc-11e6-a549-0242ac1106b3])
);
-> at mesosphere.marathon.api.TaskKillerTest$$anonfun$15.apply(TaskKillerTest.scala:180)

However, there were other interactions with this mock:
taskStateOpProcessor.process(
    ForceExpunge(task [my_app.b347809d-80cc-11e6-a549-0242ac1106b3])
);
-> at mesosphere.marathon.api.TaskKiller$$anonfun$mesosphere$marathon$api$TaskKiller$$expunge$1$$anonfun$apply$3.apply(TaskKiller.scala:66)

Mr. Jeschkies did not look close enough to realize that we wait for tasks to be
expunged. See here a3901ab0bb21bfa1ad8af56999f86ca606ef68b8
Anyways. I reproduced the error with a sleep right after log.info("Expunge...").

Thanks Mr. Jeschkies! 🚢 it

Damn, I was hoping for the linter ignore comment to get removed too ;) oh well.

Removes the linter command 7332cecc2e3953010693277a57137c5f489c2315 :)


Visit Wellington Parade place

Cancelled. Merkle called agent, they only want someone for a year. No point visising