ProductsQuerySet doesn't filter to active products

We currently set this as the queryset behind Product.objects and have a separate Product.all_objects, but these are functionally the same querysets. This could cause some unexpected results or even expose loopholes that could allow non-active products to be purchased.
I think we need to make a few changes:

Both Products.objects and Products.all_objects should utlize the delete() implementation in ProductsQuerySet
The manager assigned to Products.objects should filter to is_active=True

Also make sure that the admin interface is using all_objects if it isn't already.

Closing as already done, I was viewing a stale branch when I noted this.


Add full support to gedmo extensions

As the gedmo extension 2.4 is out. This excellent bundle should rely on this central library.
A first try is here #180
@a2lix this bundle is very important in the translation process with symfony, can you give us an advice on his evolution?
And thanks for this great work.

:+1:

:+1: Moreover, the gedmo translation documentation points toward a2lixTranslationFormBundle for translations field type. It is kind of disappointing when you set up gedmo extensions and see way after that a2lixTranslationFormBundle isn't quite compatible yet.

Well, seems like the 2.4 version of Gedmo isn't quite what was expected : https://github.com/a2lix/TranslationFormBundle/issues/184

@webda2l Even if you dislike gedmo 2.4 implementation, gedmo is a standard in facts, and many projexts integrate it for many purpose. I think this is the good idea to implement it. I think too you are one of the better expert with php translations and you are certainly one of the better developper to help the gedmo extensions to progress on the translation part.

Would be nice yes.

Hello,
What status of the compatibility of gedmo 2.4 and A2lixTranslationBundle 2.* ?

Hi,
Anybody run this nice bundle with Gedmo Translations? Is it work ?

Hi @mkalisz77 i tried a lot but i can't. If you can use this https://github.com/Prezent/doctrine-translatable translatable extension a2lix/TranslationFormBundle is working perfectly. You can check an working example from https://github.com/ojs/ojs/blob/master/composer.json#L51-L52.

Did you use Personal Translations ?
https://github.com/Atlantic18/DoctrineExtensions/blob/master/doc/translatable.md#personal-translations
for a2lix or default behaviour of Gedemo Translatable ?

@mkalisz77 if you check fully there is big logic difference between stof/StofDoctrineExtensionsBundle and Prezent/doctrine-translatable. If you use Prezent/doctrine-translatable supports personal translations fully.
You can inspect below related links for usage;

https://github.com/ojs/ojs/blob/master/src/Ojs/JournalBundle/Entity/ArticleTypes.php#L94
https://github.com/ojs/ojs/blob/master/src/Ojs/JournalBundle/Entity/ArticleTypesTranslation.php
https://github.com/ojs/ojs/blob/master/src/Ojs/JournalBundle/Entity/ArticleTypesTranslation.php#L15
https://github.com/ojs/ojs/blob/master/src/Ojs/JournalBundle/Resources/config/doctrine/ArticleTypesTranslation.orm.yml

Note: And also we use gedmo extensions but disabled gedmo translatable extension for using Prezent/doctrine-translatable

Is this Prezent/doctrine-translatable bundle compatible with Symfony 3.

any progress on this on ?

@mkalisz77 we are using dev-master and our symfony 2.7 i didn 't tested exactly but i do not think it will symfony 3 brokes.
https://github.com/ojs/ojs/blob/master/composer.json#L52
And @mkalisz77 i certainly not suggest using gedmo translatable logic is so wrong. With gedmo i struggled so much :weary:

Thank you,
I think about Prezent translatable or KnpDoctrineExtensions. I've resigned from using Gedmo Translatable. Knp seems to be actively maintained and Prezent is much lighter to implement Translatables.

Prefer KnpDoctrineExtensions (https://packagist.org/packages/knplabs/doctrine-behaviors, well more popular) than Prezent (https://packagist.org/packages/prezent/doctrine-translatable)


Spark version

Is is possible to use spark 2.3.0(Python) with delta lake?

Please see https://github.com/delta-io/delta#compatibility-with-apache-spark-versions - Delta Lake is compatible with Spark versions >= 2.4.2; previous versions are unsupported.

I am closing this issue. Please reopen if there is any further questions.


Add integration-style tests to cluster for object interactions.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #308

PR #309
PR #298

PR #300

PR #315

PR #316   👈

PR #301

This stack of pull requests is managed by Graphite.


Sync up of resources in bulk not going through

Describe the bug
Issue reported on WDF app on Sync up of resources in bulk not going through ticket.
Expected behavior
Multiple resources registered on the app should sync up successfully.

The following error is logged when manual sync is initiated
Work [ id=06b80031-ae53-4027-b1e7-460b21c86453, tags={ org.smartregister.fhircore.engine.sync.AppSyncWorker } ] failed because it threw an exception/error
                                                                                java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: Changes before creation of resource are not permitted
                                                                                at androidx.work.impl.utils.futures.AbstractFuture.getDoneValue(AbstractFuture.java:516)
                                                                                at androidx.work.impl.utils.futures.AbstractFuture.get(AbstractFuture.java:475)
                                                                                at androidx.work.impl.WorkerWrapper$2.run(WorkerWrapper.java:317)
                                                                                at androidx.work.impl.utils.SerialExecutorImpl$Task.run(SerialExecutorImpl.java:96)
                                                                                at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
                                                                                at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
                                                                                at java.lang.Thread.run(Thread.java:923)
                                                                                Caused by: java.lang.IllegalArgumentException: Changes before creation of resource are not permitted
                                                                                at com.google.android.fhir.sync.upload.patch.PerResourcePatchGenerator.mergeLocalChangesForSingleResource(PerResourcePatchGenerator.kt:50)
                                                                                at com.google.android.fhir.sync.upload.patch.PerResourcePatchGenerator.generate(PerResourcePatchGenerator.kt:39)
                                                                                at com.google.android.fhir.sync.upload.Uploader$upload$2.invokeSuspend(Uploader.kt:49)
                                                                                at com.google.android.fhir.sync.upload.Uploader$upload$2.invoke(Unknown Source:8)
                                                                                at com.google.android.fhir.sync.upload.Uploader$upload$2.invoke(Unknown Source:4)
                                                                                at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
                                                                                at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
                                                                                at com.google.android.fhir.sync.FhirSynchronizer$upload$2$1.invokeSuspend(FhirSynchronizer.kt:136)
                                                                                at com.google.android.fhir.sync.FhirSynchronizer$upload$2$1.invoke(Unknown Source:8)
                                                                                at com.google.android.fhir.sync.FhirSynchronizer$upload$2$1.invoke(Unknown Source:4)
                                                                                at kotlinx.coroutines.flow.SafeFlow.collectSafely(Builders.kt:61)
                                                                                at kotlinx.coroutines.flow.AbstractFlow.collect(Flow.kt:230)
                                                                                at com.google.android.fhir.impl.FhirEngineImpl.syncUpload(FhirEngineImpl.kt:144)
                                                                                at com.google.android.fhir.impl.FhirEngineImpl$syncUpload$1.invokeSuspend(Unknown Source:15)
                                                                                at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
                                                                                at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
                                                                                at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:584)
                                                                                at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:793)
                                                                                at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:697)
                                                                                at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:684)

This is issue is caused by having 2 entries in the LocalChangeEntity table of type INSERT for a resource with the same id
sample entries
LocalChange(resourceType=CarePlan, resourceId=c1f58fac-7928-489b-b038-d2e4e07fa369, versionId=null, timestamp=2024-01-29T14:31:58.554Z, type=INSERT, payload={"resourceType":"CarePlan","id":"c1f58fac-7928-489b-b038-d2e4e07fa369","meta":{"lastUpdated":"2024-01-29T17:31:58.553+03:00","tag":[{"system":"https://smartregister.org/care-team-tag-id","code":"3e005baf-854b-40a7-bdd5-9b73f63aa9a3","display":"Practitioner CareTeam"},{"system":"https://smartregister.org/location-tag-id","code":"103967","display":"Practitioner Location"},{"system":"https://smartregister.org/organisation-tag-id","code":"41eae946-bdc4-4179-b404-6503ff12f59c","display":"Practitioner Organization"},{"system":"https://smartregister.org/practitioner-tag-id","code":"49b72a3d-44cd-4a74-9459-4dc9f6b543fa","display":"Practitioner"},{"system":"https://smartregister.org/app-version","code":"Not defined","display":"Application Version"}]},"instantiatesCanonical":["PlanDefinition/dc-diabetes-screening-intervention"],"status":"active","intent":"plan","title":"Schedule of screening & follow-ups for registered patients","description":"Schedule of screening & follow-ups for registered patients","subject":{"reference":"Patient/e941c05a-0752-4563-919c-45f46815384a"},"period":{"start":"2024-01-29T17:31:58+03:00"},"created":"2024-01-29T17:31:58+03:00","author":{"reference":"Practitioner/49b72a3d-44cd-4a74-9459-4dc9f6b543fa"},"activity":[{"outcomeReference":[{"reference":"Task/8b57ff8c-ed6b-4fab-a13d-cd488ebef10e"}],"detail":{"kind":"Task","status":"in-progress","performer":[{"reference":"Practitioner/49b72a3d-44cd-4a74-9459-4dc9f6b543fa"}],"description":"This will initialize Diabetes Screening CarePlan"}}]}, token=LocalChangeToken(ids=[8]))

and
LocalChange(resourceType=CarePlan, resourceId=c1f58fac-7928-489b-b038-d2e4e07fa369, versionId=null, timestamp=2024-01-29T14:32:32.879Z, type=INSERT, payload={"resourceType":"CarePlan","id":"c1f58fac-7928-489b-b038-d2e4e07fa369","meta":{"lastUpdated":"2024-01-29T17:32:32.878+03:00","tag":[{"system":"https://smartregister.org/care-team-tag-id","code":"3e005baf-854b-40a7-bdd5-9b73f63aa9a3","display":"Practitioner CareTeam"},{"system":"https://smartregister.org/location-tag-id","code":"103967","display":"Practitioner Location"},{"system":"https://smartregister.org/organisation-tag-id","code":"41eae946-bdc4-4179-b404-6503ff12f59c","display":"Practitioner Organization"},{"system":"https://smartregister.org/practitioner-tag-id","code":"49b72a3d-44cd-4a74-9459-4dc9f6b543fa","display":"Practitioner"},{"system":"https://smartregister.org/app-version","code":"Not defined","display":"Application Version"}]},"instantiatesCanonical":["PlanDefinition/dc-diabetes-screening-intervention"],"status":"active","intent":"plan","title":"Schedule of screening & follow-ups for registered patients","description":"Schedule of screening & follow-ups for registered patients","subject":{"reference":"Patient/e941c05a-0752-4563-919c-45f46815384a"},"period":{"start":"2024-01-29T17:31:58+03:00"},"created":"2024-01-29T17:31:58+03:00","author":{"reference":"Practitioner/49b72a3d-44cd-4a74-9459-4dc9f6b543fa"},"activity":[{"outcomeReference":[{"reference":"Task/8b57ff8c-ed6b-4fab-a13d-cd488ebef10e"},{"reference":"Task/042b542d-018f-46a7-9768-31c0a844d36e"}],"detail":{"kind":"Task","status":"in-progress","performer":[{"reference":"Practitioner/49b72a3d-44cd-4a74-9459-4dc9f6b543fa"}],"description":"This will initialize Diabetes Screening CarePlan"}}]}, token=LocalChangeToken(ids=[27]))


Freemium Enhancements

In order to use Koudoku with a freemium model (a free account or upgraded pay accounts) we must change Koudoku to support adding a customer without taking a credit card (most customers dont want to provide a CC for a free account).  In order for this to work, you need to have a "Free" plan in your Stripe.com account.  For our model, we overrode the default Devise confirmations_controller.rb and extended the do_confirm! method to create the free subscription (and create the customer object) at stripe.
def do_confirm
@confirmable.confirm!
if @confirmable.subscription.nil?
subscription = Subscription.new
subscription.user = @confirmable
subscription.plan = Plan.find_by_name('Free')
subscription.save
end
set_flash_message :notice, :confirmed
sign_in_and_redirect(resource_name, @confirmable)
end
We had to significantly update the views for our application but thanks to rails engine magic those are easy to override (thanks for rake task to set those up as well!)

It would be great if this could be included by default. A flag on the config that allowed completely free plans to skip the payment form entirely would be needed I think...

I just updated my freemium banch to head.  Is there any chance we can get this PR accepted or find out what needs to be done to do so?

Would love an update about freemium plans. Any details on the status of this PR? Willing to assist however I can also - not very experienced but very keen :)

@DaKaZ
How is this configured?
How do people switch between CC upfront and no CC required?

The implementation I did was very simple.  It merely looked for the price
of the plan and if it was free, it went ahead and created the account in
Stripe WITHOUT the customer's card.  If a customer were to switch from a
free plan to a paid plan, then your app would need collect the customer's
card (via stripe) before switching plans.  The original code worked well
but candidly the service I built it for has since shut down so I have not
maintained the patch.  It would not take much to make it current though.
Andrew is the maintainer of the Koudoku repository though, he needs to
chime in at some point about this PR and the freemium approach.
--Kaz
On Sun, Jul 26, 2015 at 7:15 PM, yas4891<EMAIL_ADDRESS>wrote:

@DaKaZ https://github.com/DaKaZ
How is this configured?
How do people switch between CC upfront and no CC required?
—
Reply to this email directly or view it on GitHub
https://github.com/andrewculver/koudoku/pull/42#issuecomment-125055783.

+1 to this

+1 from me too

I did freemium work on Payola, glad to it's already in PR here. @andrewculver any chance you can hit merge on this 😀?


"import cycle not allowed " error when installation.

go get ./...
import cycle not allowed
package github.com/open-falcon/agent
imports flag
imports errors
imports runtime
imports runtime/internal/atomic
imports unsafe
imports runtime
import cycle not allowed
package github.com/open-falcon/agent
imports github.com/open-falcon/agent/cron
imports github.com/open-falcon/agent/funcs
imports github.com/open-falcon/agent/g
imports github.com/toolkits/file
imports net/http
imports crypto/tls
imports crypto/x509
imports net
imports runtime/cgo
imports runtime/cgo

any help will be appreciated.

Thanks to @laiwei  , I misplaced my goPath and goroot.
below is right one:
export GOROOT=/usr/local/go
export GOPATH=/usr/lcoal


Add ability to make assertions on raw data sent to MockWebServer

I've added RawSocketClient to test current MockWebServer behavior while using EXPECT_CONTINUE and (in future) CONTINUE_ALWAYS. HttpURLConnection is not sufficient because it hides 100 Continue response and don't wait for it but sends request body immediately.

I don’t think this is a MockWebServer, this is a MockSocket. It’s a neat API, but I don’t think it belongs in this project.

(I misunderstood what was going on here, so I’m gonna retract my quick-close. I misread the new class as being public API, but it’s test API.)

That said, I’d prefer to not build framework around this.
OkHttpClient is our spec-compliant HTTP client. It’s expected to behave reasonably with ‘tricky’ HTTP servers.
MockWebServer is our tricky HTTP server for testing. It has mechanisms to speak weird and slow HTTP.
This introduces a low-level tricky HTTP client to test MockWebServer. In theory we could write tons of tests on how MockWebServer handles lots of slow/attacker/fuzzy clients. But that’s a giant expansion of responsibility for MockWebServer.
I’d rather we test this specifically with OkHttp.

In order to implement 102 support I need to make changes to MockWebServer. To ensure that changes are right I need to test them. Using OkHttp to test tool which is used to test OkHttp doesn’t seem right. Probably that’s why in such tests HttpUrlConnection client is used but it hides details of 1xx exchanges.
Adding ability to return interim 102 response from MockWebServer seems pretty similar to existing Socket policies EXPECT_CONTINUE and CONTINUE_ALWAYS. I think that they don't behave as they supposed to do:
server doesn’t wait for request body but returns 200 right after 100 so it doesn’t follow RFC.
In case of CONTINUE_ALWAYS OkHttp doesn’t change it’s behavior, it just assumes that after unexpected 100 server will follow with 200 (that is what MockWebServer does so tests pass).
Aligning with server response (despite it’s not correct) would require to resend body. Even if this is fine it would be nice to test how will OKHttp react to server which expect to get body second time.
So for me MockWebServer behaves tricky when I think it should not. RawSocketClient adds possibility to write tests which catch such cases.

I agree that it's annoying to test MockWebServer against itself. Historically we confirm interop if new features against other HTTP clients or servers manually, then commit known-working things to OkHttp and MockWebServer. We are exposed to potential regressions this way on PRs that update both client and server. This hasn’t been a problem in practice.

Ok I won't insist


Merge 1.1.70

@cnorthrop Can you look at f1b7e57 specifically to see if I missed anything?

Opened #2474 to deal with the broader KHR/core code reuse issue.  I would like to get this merged soon because it is blocking VulkanTools and VulkanSamples from merging 1.1 content

I've convinced myself that this is in sufficient state to land. Note that Travis-CI fails. Note clear exactly why. Gets the message "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself." seemingly while it's doing clang-format checks so maybe volume of code is taking too long to clang-format?
If that's the case then after this lands follow-on commits should clear up in CI again.

Thanks for breaking this up into so many focused CLs, which made review as nice as it could be for such a massive PR.

Yep, clang-format generates huge diffs on header updates,  I’ll look into excluding them from the format rules in future


Block more fake news websites

Summary
Block more fake news websites e.g. which are pointed out by RationalWiki
Basic example
Block the websites in this list: https://rationalwiki.org/wiki/List_of_websites_owned_by_Mike_Adams
Motivation
Demote fake news and get a better chance for authenticated, trustworthy content in general.

Considering that this list is stopping at the end of September 2021 (see main readme) I'll close this issue and leave it here for other people.


the releases apk is unavailable

When I try to install the application, it goes like this:

Parse erorr
There was a problem parsing the package

My phone:
Android 4.1.2
HuaWei G520-5000
512 RAM
Inner Storage 2GB
External storage 16GB

Hello thanks for trying.
At this moment the minSdkVersion is 19, which means only phones running android 4.4 and above can install the application.
One thing to keep in mind is that the current version consumes quite an amount of memory. For phones have memory lower than 1GB the OOM may appear.

Sorry to disturb you again, but I got something wrong once more.
I have got a Android pad and it's Android version is 4.4.4, so I install this app.
However, when I open the app it shows as below:

Why the image doesn't show...
And, the Settings page can't open.(When I touch Settings Menu nothing happened.

Maybe you can see this:
https://github.com/WenhaoWu/BingWallpaper/blob/master/app/src/main/java/wenhao/practice/bingwallpaper/Model_GetImages.java#L49
                            img_url = response.getJSONArray("images").getJSONObject(i).getString("url");
                            img_copy = response.getJSONArray("images").getJSONObject(i).getString("copyright");
                            img_date = response.getJSONArray("images").getJSONObject(i).getString("startdate");
                            img_url = img_url.replace("1920x1080","1080x1920");
                            /*HERE*/ realURL = "http://www.bing.com"+img_url;
                            result.add(new Object_Wallpaper(realURL, img_copy,img_date));

In my location, the Bing server returned json  data is like this:
{
    "images": [
        {
            "startdate": "20160129",
            "fullstartdate": "201601291600",
            "enddate": "20160130",
            /*HERE*/
           "url": "http://s.cn.bing.net/az/hprichbg/rb/HammockCypress_ZH-CN10587366950_1920x1080.jpg",
            "urlbase": "/az/hprichbg/rb/HammockCypress_ZH-CN10587366950",
            "copyright": "在古老柏树上搭起吊床露营 (© Mac Stone/Tandem Stills + Motion)",
            "copyrightlink": "http://www.bing.com/search?q=%E9%9C%B2%E8%90%A5&form=hpcapt&mkt=zh-cn",
            "wp": true,
            "hsh": "88f11f28cd9b45328a23bec2dd0ca1e9",
            "drk": 1,
            "top": 1,
            "bot": 1,
            "hs": [],
            "msg": [
                {
                    "title": "今日图片故事",
                    "link": "http://www.bing.com/search?q=%E9%9C%B2%E8%90%A5&FORM=pgbar1&mkt=zh-cn",
                    "text": "露营"
                }
            ]
        }
    ],
    "tooltips": {
        "loading": "正在加载...",
        "previous": "上一页",
        "next": "下一页",
        "walle": "此图片不能下载用作壁纸。",
        "walls": "下载今日美图。仅限用作桌面壁纸。"
    }
}

Yes thanks for mentioning. Apparently bing server returns different json object based on user's location. However, base url section seems to be consistent nevertheless.
My Json respond:
Json
Thanks again. It is beneficial to use url base.


Ceramic Address Book DataModel and SuperFluid Console integration

#89
Demo app: https://superfluid-console-alpha.vercel.app
Demo video: https://youtu.be/LNgJMRN2zNc
Gitcoin issue: https://gitcoin.co/issue/28896
after merging crypto-address-book pull request into Ceramic datamodels repo, "crypto-address-book" package should be replaced with "@datamodels/crypto-address-book".

Hi @soheil555! We greatly appreciate the work you put into the Address Book bounty. However, we have in this case awarded the bounty to another contributor.
While this is not the news you'd have liked to hear, given the quality of your work, we'd like to invite you to continue earning bounties through the official Superfluid Bounty Program. Over the coming months, we're going to be putting out more bounties pertaining to the Superfluid Console which could be right up your alley.
For information on our bounty process and list, check out: https://docs.superfluid.finance/superfluid/resources/bounty-program
Thank you again for your efforts and we hope to have you as a continued contributor at Superfluid.

Hi @vmichalik.
Thanks for the Bounty. I learned a lot about Ceramic and SuperFluid.
I would love to contribute more and look forward to it.


Maximum Redirection Support

Added the ability to set the max redirection for web requests.

Thought I would bring some more curl arguments over.

Thank you for that and including a test as well!

Should I keep them coming?
On Nov 4, 2015 3:17 PM, "Chris Hunt"<EMAIL_ADDRESS>wrote:

Thank you for that and including a test as well!
—
Reply to this email directly or view it on GitHub
https://github.com/cdhunt/Parse-Curl/pull/1#issuecomment-153850661.

Please do. Just please bump the version in the module manifest with each PR. That will speed up the automated deployment to PowerShellGallery.com


Gallery format with Cleaner Gallery Plugin

I'm using Cleaner Gallery plugin with Prettyphoto JS for my Gallery post format. With my custom theme (clone from twentyeleven), my gallery work great. The Gallery Album look great with Prettyphoto. But not working with Roots 5.
Any help? Cleaner Gallery Plugin by Justin Tadlock is not in the list "Recommended Plugin in the Roots.
Thanks and really sorry about my english.....

should be fixed after 49300042c8dc00170b10ccc7b61d9c966f9e41ee


4.2.1 A straightforward solution is to use gradient descent-based methods [53, 78] to optimize R.  WHY R???

In subsection 4.2.1 of the article, you mentioned the use of gradient descent to optimize the attacker's target answer R, why is it optimized for R? Isn't it true that the attacker has identified a desired target answer to the current target question, and then uses gradient descent to optimize the text I that satisfies the generation criteria? I'm confused here and look forward to your answers.
在文章的4.2.1小节中，你提到使用梯度下降的方法来优化攻击者的目标回答R，为什么是针对R来优化？难道不是攻击者针对当前的目标问题已经明确了一个期望的目标回答，然后使用梯度下降的方式来优化满足生成条件的文本I吗？这里我很困惑，期待你的解答。

Hi! Thanks for your interest in our paper and thanks for pointing it out!
We checked our current version and found that this is a typo, which should be "optimize $I$ such that an LLM will output $R$". We will fix this typo in our next version.
Thanks again for pointing this out and thanks for your attention!


Some grafana-related improvements for dashboard generator

This PR contains the following changes:

New user-provided/user-defined postprocessors are introduced, along with few general-purposes custom postprocessor useful for grafana installations + usage examples.
Grafana backend tries to use exact comparison operators where possible.
Postprocessors are refactored to use dicts.
When a backend is explicitly specified via CLI, all other configured backends are ignored.
Some grafana project service names are renamed to follow a common pattern.

TODO in future PRs:

Generalize dashboard parameters with suggested values across both backends. It should be implemented via label_values(query, label_name) in Grafana.
Gradually work through dashboards and make sure they actually work in Grafana.
Support dashboard creation (vs existing dashboard) in specific folders for Grafana.

I'll take a look this week.

To be sure – do you check that dashboard tests successfully pass?

To be sure – do you check that dashboard tests successfully pass?

As it turns out there are tests, but they don't seem to be opensourced: https://github.com/ytsaurus/ytsaurus/blob/0565ce0c78062c77d98141e08985009e53d7dd56/yt/admin/dashboards/ya.make#L47-L50
I did check that it works for our Grafana, and I hope that Ivan will double check everything on the monitoring side. If we can opensource the tests that would be great, but I do not know whether they rely on any private APIs/mocks.

yt/admin/dashboards/yt_dashboards/common/postprocessors.py:11: [F401] 'typing.Iterable' imported but unused

And tests should be recanonized of course

@ifsmirnov – kindly remind

This PR is pending on the author's side.

test comment


[TESTNET] Insufficient funds for intrinsic transaction cost

Describe the bug
A user is getting this error when trying to bridge from Polygon Mumbai to X1 testnet

They have 3.5 MATIC which I believe should be enough to cover the relayer fees
Link to ticket in discord
https://discord.com/channels/454734546869551114/1195024910121193512/1195028928541233202

It takes 8-10 MATIC.


User name validation

What user names are valid?
This question recently sprung up with #345. It started with duplicated names, then @Phrancis mentioned empty ones. The code that closes that question adds the method  Server.isValidUserName which makes user name validation easy to implement.
In the issue above, I ended up posting a suggested set of rules for user names.

A user name...

is unique. Two clients can not connect with the same name simultaneously.
is at least 1 character and at most 20 characters long.
contains only ASCII letters, spaces, underscores and decimal numbers.
does not begin or end with whitespace.

A too long user name doesn't make sense and is annoying for UI development and to type.
Carefully crafted bytes can e.g. mess up a terminal window where logging is done and cause all sorts of trouble. It may also not be typeable.
Is that x spaces or a tab?
Names starting or ending with whitespace are confusing.

"contains only ASCII letters, spaces, underscores and decimal numbers" I'm assuming would also exclude problematic characters like slashes, quote marks and the like, correct?
At some point in the future we may want to consider a more expansive allowed character set (perhaps with explicit exclusions instead of explicit inclusions) but for the foreseeable future I think what you suggested above should be completely reasonable.

Yes, with letters I mean alphabetic lettters [a-zA-Z].

The name "Server" should be reserved as well, since there's no other way to tell user messages from server messages in the chat.

The name "undefined" also should be reserved, as it is used for client-bound chat message broadcasting to client. @SirPython can confirm that.

Don't allow more than one consecutive space, such as some  name --> some name


Draft directives used for generation

We need to have discussion about directives that can be used for generation.
We can use @Model or directive per each operation. Additionally, we might need to have Data model directives that will define how database is created.
We could also do @REST directive for generating restful API calls.
Did I missed anything

I think we should provide only some key directives, like @sub or @paginate(in future) for example. And read the others crud operations through the generator config in config.json
Will the @rest directive allow for integration with sofa.

Sofa will be integrated automatically.

And read the others crud operations through the generator config in config.json

This will now allow type specific generation. Config.json is global only so id you do not want to have things done globally you will not need to apply it to every possible type.

This will now allow type specific generation. Config.json is global only so id you do not want to have things done globally you will not need to apply it to every possible type.
Ah right, missed that.

Then this will be the default for both the types and if we want to alter any other type then directives. Seems good.

Have dropped the @Model and created individual directives

Docs?

Added in pr #180


Include a theme toggler in the navbar

This PR contains an implementation for a button to toggle the theme in the Navbar.
Resolves Issue 461
Screenshots

@Young-Einstein10 is this PR ready to review?

Yes, it is.

LGTM

I'm glad I could be of help💪

@Young-Einstein10 The toggle doesn't show up when connected into the dashboard


Fixed ACM-3010

Fixed Chinese translations for https://issues.redhat.com/browse/ACM-3010

I have received a localization request ticket in regards to this merge conflict, what I can do is that I'll sync the main branch with our fork and update it today and create another PR.


config: apply variable expansion to all keys

Thanks, @sabban @mmetc , I highly appreciate it. The week is a bit swamped, but I'll try to get back to you with feedback on 0.0.29 by weekend.


DOC: Linear Programming with Incrementally added constraints

Issue with current documentation:
Does Scipy.linprog have any support for solving a series LP problems with increasing inequality constraints.
It seems that dual simplex method should be used. I asked chatGPT, it gave the answer with getting basis from OptimizeResult. But by checking the document, basis is not in the list of OptimizeResult, is it removed?
Idea or request for content:
No response
Additional context (e.g. screenshots, GIFs)
No response

The basis is not currently returned by any of the linprog methods. There are plans to add an object oriented interface to the HiGHS linear programming solver that would expose the features you're looking for. That is tracked in gh-15915, so I'll close this one.
@mckib2 anything to add?

@mckib2 anything to add?

Nope, gh-15915 directly addresses this use-case


Regression: It does not recognize numbers

Your new version of the software does not recognize numbers. See the screenshot:

Thanks for letting us know @vporton , this issue is now fixed


link with target="_blank"

Hi,
I would like to have all link create in the component with the mode target="_blank".
Is it possible ?

@TheMalloum this sounds like a good case for a custom button (plugin). Take a look here for more details. I hope that helps.


Unable to install with Ansible version 2.4 or above <2.6 as defined in the doc

Description
WHAT: Unable to install with Ansible version 2.4 or above <2.6
WHERE: iOS env
WHEN: Run the command ./installer/install.sh and is following the pre-requirements in the docs[1]
[1] - https://docs.aerogear.org/aerogear/latest/getting-started.html#procedure
Environment
Operating system: iOS
OpenShift versions:
Steps to reproduce

When the version 2.4 is installed:

cmacedo@camilas-MBP ~/mobile-core ((HEAD detached at 1.0.0)) $ ansible --version
ansible <IP_ADDRESS>
  config file = None
  configured module search path = [u'/Users/cmacedo/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /Library/Python/2.7/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 2.7.10 (default, Oct  6 2017, 22:29:07) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.31)]

Then after cloning the project, and checkout tag 1.0.0. Following the output when the command ./installer/install.sh is executed.
cmacedo@camilas-MBP ~/mobile-core ((HEAD detached at 1.0.0)) $ ./installer/install.sh

Checking Docker exists
✓ Docker check passed.
Checking Docker is running
✓ Docker check passed.
Checking Docker version. Should be using Stable channel
✓ Docker check passed.

Checking Python exists
✓ Python check passed.
Checking Python version. Should be >= 2.7
✓ Python check passed.

Checking Ansible exists
✓ Ansible check passed.
Checking Ansible version. Should be >= 2.6
Ansible version is < 2.6. Install ansible>=2.6 using pip install ansible>=2.6
cmacedo@camilas-MBP ~/mobile-core ((HEAD detached at 1.0.0)) $

PS.: It is possible to be solved by updating the prerequisites in the documentation of the project.

@camilamacedo86 I think this is now resolved by my docs update: https://github.com/aerogear/mobile-docs/pull/227

Closing since it is solved in the docs.


Current day styling for datepicker

Is your feature request related to a problem? Please describe.
We would like to give the user an indication of the current day within the datepicker.
Describe the solution you'd like
Adding a 'current-day' class on the td of the day.
Describe alternatives you've considered
We going to hack something in javascript to find the current day. We'll find a way but would rather have a class on the current day.
Additional context

Something like adding a rz-current-day class:
@if (CurrentDate.Month == date.Month)
{
    <td @attributes="@(dateArgs.Attributes)" onmouseup=@(Inline || ShowTime || dateArgs.Disabled ? "" : $"Radzen.closePopup('{PopupID}')")
    @onclick="@(async () => { if (!Disabled && !dateArgs.Disabled) { await SetDay(date); } })">
        <span class=@($"rz-state-default{(DateTimeValue.HasValue && DateTimeValue.Value.Year == date.Year && DateTimeValue.Value.Month == date.Month && DateTimeValue.Value.Day == date.Day ? " rz-state-active" : "")}
{(!dateArgs.Disabled ? "" : " rz-state-disabled")}
{(date.Date.CompareTo(DateTime.Now.Date) == 0 ? " rz-current-day"<EMAIL_ADDRESS>    </td>
}

Thanks!


KSM exec command not working on CircleCI

i'm trying to create a new command in my keeper orb, which executes the following command :  ksm exec -- $SHELL
in order to attribute secrets to my environment vairables in the job, this is how the command is like  :
`
description: >
Run a command with secret environment variables loaded from SecretHub
steps:
  - install
  - run:
      name: fetching secrets
      command: ksm exec -- $SHELL

`
and this is the job to test it :
integration-test-exec-command:

   docker:
     - image: cimg/base:stable
   environment:
       MY_USER: keeper://vNrItsdDxL3M9uTuxvzY_g/field/login
   steps:
     - checkout
     - keeper/exec

i'm having this error on circleCI :
ksm exec -- $SHELL
Imported config saved to profile App1 at keeper.ini.
ksm had a problem: Keeper url missing information about the uid, field type, and field key

it is strange because i have tested the command locally on my machine, and it is working, and i have tried it with all type of executors on CircleCI but it's not working,
Can you please guys take a look on this issue, as we need this command in our workflow, and get back to us
this is quite urgent as we will be fully migrating to keeper by next week  ?
thanks

Looks like the notation that you are trying to use is not properly formatted. Is it possible to see what notation string (ex. keeper://UID/field/login is being send in the command? Try to execute command with the debug enabled, ex. KSM_DEBUG=DEBUG ksm exec -- $SHELL, that should give you some additional information

the notation string is keeper://vNrItsdDxL3M9uTuxvzY_g/field/login
this is the output when i run this command  KSM_DEBUG=DEBUG & ksm exec -- $SHELL
Imported config saved to profile App1 at keeper.ini.
2022-03-25 18:54:57,700 | ksm | DEBUG | Setting public key id to the default: 10
2022-03-25 18:54:57,700 | ksm | DEBUG | Already bound
Traceback (most recent call last):
  File "keeper_secrets_manager_core/core.py", line 638, in get_notation
IndexError: list index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "keeper_secrets_manager_cli/__main__.py", line 1017, in main
  File "click/core.py", line 1128, in __call__
  File "click/core.py", line 1053, in main
  File "click/core.py", line 1659, in invoke
  File "click/core.py", line 1395, in invoke
  File "click/core.py", line 754, in invoke
  File "click/decorators.py", line 26, in new_func
  File "keeper_secrets_manager_cli/__main__.py", line 759, in exec_command
  File "keeper_secrets_manager_cli/exec.py", line 75, in execute
  File "keeper_secrets_manager_cli/exec.py", line 46, in env_replace
  File "keeper_secrets_manager_cli/exec.py", line 34, in _get_secret
  File "keeper_secrets_manager_core/core.py", line 643, in get_notation
ValueError: Keeper url missing information about the uid, field type, and field key.

ksm had a problem: Keeper url missing information about the uid, field type, and field key

Looking at the code. The environmental variable definitely has a value which starts with "keeper", so it not blank. The problem is where we split the prefix (keeper://) from the values we need. The split is failing.
url_parts = url.split('//')

Most likely Circle CI is escaping the "//" which is causing the split to fail, hence no item index 1. Basically we loop through all the environment values and find one where the values start with "keeper" and then attempt to process them.
I assume you are trying to do something like this.
 ~ (:|✔): export FAKE_USER="keeper://4BFRUh6hV_3TnObARd2NbQ/field/login"
 ~ (:|✔): ksm exec -- bash
bash-5.1$ echo $FAKE_USER
Fake2

I made a quick POC with Circle CI. The --capture-output is just a way to get around a bug in the exec command in the binary, https://github.com/Keeper-Security/secrets-manager/pull/244, but we would have used it anyways for this POC.
version: 2.1

jobs:
  build:
    docker:
      - image: cimg/base:stable
    environment:
      MY_USER: keeper://4BFRUh6hV_3TnObARd2NbQ/field/login
      KSM_CONFIG: "BASE64 CONFIG"
    steps:
      - checkout
      - run: |
          wget https://github.com/Keeper-Security/secrets-manager/releases/download/ksm-cli-1.0.8/keeper-secrets-manager-cli-linux-1.0.8.tar.gz
          tar -zvxf keeper-secrets-manager-cli-linux-1.0.8.tar.gz

          cat << 'EOF' > ./my_shell.sh
          #!/bin/sh
          echo "In Script $MY_USER"
          EOF

          chmod 755 ./my_shell.sh
          ls -al ./my_shell.sh

          ./ksm exec --capture-output -- ./my_shell.sh

The POC does return my notation's value.
-rwxr-xr-x 1 circleci circleci 36 Mar 25 21:27 ./my_shell.sh
Imported config saved to profile App1 at keeper.ini.
b'In Script Fake2\n'

CircleCI received exit code 0

So I didn't get what you got :( Was hoping it would have seen something like keeper:\/\/4BFRUh6hV_3TnObARd2NbQ/field/login which would definitely have caused that problem.
I think you will need to verify your MY_USER env var is not escaped, somehow replaced by unicode, encoded incorrectly, etc.

i have added the --capture-output to my ksm exec, and also i have checked my env variable is not esacped, by running printenv, but i can see it's till there and it still has the keeper url value : keeper://vNrItsdDxL3M9uTuxvzY_g/field/login
but unfortunately i'm still getting the same error,

#!/bin/bash -eo pipefail
ksm exec --capture-output -- $SHELL
Imported config saved to profile App1 at keeper.ini.
2022-03-25 23:51:05,316 | ksm | DEBUG | Setting public key id to the default: 10
2022-03-25 23:51:05,316 | ksm | DEBUG | Already bound
Traceback (most recent call last):
File "keeper_secrets_manager_core/core.py", line 638, in get_notation
IndexError: list index out of range
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "keeper_secrets_manager_cli/main.py", line 1017, in main
File "click/core.py", line 1128, in call
File "click/core.py", line 1053, in main
File "click/core.py", line 1659, in invoke
File "click/core.py", line 1395, in invoke
File "click/core.py", line 754, in invoke
File "click/decorators.py", line 26, in new_func
File "keeper_secrets_manager_cli/main.py", line 759, in exec_command
File "keeper_secrets_manager_cli/exec.py", line 75, in execute
File "keeper_secrets_manager_cli/exec.py", line 46, in env_replace
File "keeper_secrets_manager_cli/exec.py", line 34, in _get_secret
File "keeper_secrets_manager_core/core.py", line 643, in get_notation
ValueError: Keeper url missing information about the uid, field type, and field key.
`
ksm had a problem: Keeper url missing information about the uid, field type, and field key.`

N.B : i don't know if this could be relevant but i'm using curl instead wget to download the binary
and also in your POC i don't see you run ./ksm exec instead of ksm exec

I think I found what is going on...
We are running CircleCi on a project called keeper-circleci-orb. CircleCI defines a lot of environment variables
Therefore, with our project we have
CIRCLE_PROJECT_REPONAME="keeper-circleci-orb"

The lib should think this variable is a secret notation: a startWith("keeper") is used here
Maybe we should check keeper: instead of just keeper 🤔

I have a PR, https://github.com/Keeper-Security/secrets-manager/pull/245, to ignore the first test if it results in an exception. If it fails the first test it won't abort running the exec command. That will allows the env var CIRCLE_PROJECT_REPONAME not to cause an exception when using the exec command.

thanks @jsupun ,
can you guys approve these changes ASAP please, so we can start using this command properly, as we want to finish migration to keeper by this week

@Hakim187 don't push, we don't urgently need it.
This issue occurs "only" in the keeper-circleci-orb project, we can easily unset the env var before executing the ksm exec to end our migration.

@Hakim187 the CLI 1.0.9 binary has been release.
$ export ACTUAL_NOTATION="keeper://w9foN572FibjjoLvkIZhJg/field/login"
$ export NOT_NOTATION="keeper-something"
$ ./ksm exec -- bash
$ echo $ACTUAL_NOTATION
ec2-user
$ echo $NOT_NOTATION
keeper-something

@jsupun thanks a lot !


Kallel

Expected behavior
Actual behavior
Information about the Issue
Steps to reproduce the behavior

...
...

No information provided or steps to replicate - Closing


Support save_hyperparameters() to checkpoints without sending to logger

🚀 Feature
self.save_hyperparameters() is an awesome simple way to save input arguments with checkpoints such that when loading a checkpoint the module will be constructed with the same parameters. The method also seems to log the hyperparameters to the experiment logger, which is not always desired. It would be great to add a flag to turn this on or off.
Pitch
Add a log=True flag, which is true by default, to save_hyperparameters(). This way hyperparameters could be saved but not logged by calling self.save_hyperparameters(log=False).

I still believe this should be fixed. Logging hyperparameters and saving them to a checkpoint serve different purposes, and saving them should not necessitate logging them.
I do not wish to log hyperparams, but I want to save them as part of the checkpoint. If this will not be fixed as I suggested, is there another way to achieve this while still leveraging ligtning's checkpointing logic?

Could you describe why it's not desirable for the logger to save hyperparameters? Which logger do you use? Could you extend the class to override the log_hyperarameters method and disable it?

Sure, thanks for asking.
I am using the W&B logger. The lightning module hyperparameters constitute a portion of my configuration, but I also have configuration parameters for setup, data, training, as well as other custom parts of my experiment. I use W&B to log my entire configuration at the start of my experiment, which has a nice hierarchical structure that makes it easy to track configurations with the W&B interface. I call log_hyperparameters myself to do this.
I also call save_hyperparameters so that they are saved and loaded with checkpoints. Unfortunately this also logs all input arguments to the module. I do not wish to log these because 1) they are redundant with my logging of the entire configuration, 2) they do not have a hierarchical structure like my logging of the entire structure which makes them harder to interpret, 3) I have many input arguments and not all are user configurable or intended to be logged.
I believe a flag could be set in save_hyperparameters that is then checked here:
https://github.com/PyTorchLightning/pytorch-lightning/blob/1302766f83a5fc861ae77ef6f8798cd0b1d606c7/pytorch_lightning/trainer/trainer.py#L507

For anyone else having this issue, here's a workaround I've been using.
class WandbManualHparamsLogger(pl.loggers.WandbLogger):
    @pl.utilities.rank_zero_only
    def log_hyperparams(self, params, skip=True):
        if not skip:
            super().log_hyperparams(params)

It would be nice if this were available by default though.

@timothybrooks does this solution work for you ? Would be nice if any of you guys could send a PR with this.

For anyone else having this issue, here's a workaround I've been using.
class WandbManualHparamsLogger(pl.loggers.WandbLogger):
    @pl.utilities.rank_zero_only
    def log_hyperparams(self, params, skip=True):
        if not skip:
            super().log_hyperparams(params)

All hyperparameter logging internal to Lightning is skipped, and you can invoke log_hyperparams(..., skip=False) to log them manually.
It would be nice if this were available by default though.

Picking this up, once the LoggerConnector Refactor PR is merged.


LaTex binding doesn't refresh

At start it shows well what's in DomandaAttuale.Testo but when DomandaAttuale change I need to modify LaTex in C# side because with binding it doesn't work. To resolved this I tried in this way: DomandaAttuale.Testo = DomandaAttuale.Testo.Clone() as string;  but didn't worked
I noticed the same issue when I load ItemSource of a ListView that contains math:TextView, the first time works but the others shows empty cells

You have to set Mode = TwoWay explicitly:
LaTeX="{Binding DomandaAttuale.Testo, Mode=TwoWay, Converter={StaticResource UrlDecoder}}"

Thanks, now it works on the main text but I'm still having the issue on the ListView (using Label it didn't happen)

Can you show code that related to binding to the ListView ? (Both XAML and VM parts)

              <ListView
                    Margin="0,10,0,0"
                    ItemTapped="ListView_ItemTapped"
                    ItemsSource="{Binding DomandaAttuale.Risposte}"
                    SelectionMode="None"
                    VerticalOptions="Center">
                    <ListView.ItemTemplate>
                        <DataTemplate>
                            <ViewCell>
                                <Grid VerticalOptions="CenterAndExpand">
                                    <Grid.ColumnDefinitions>
                                        <ColumnDefinition Width="1*" />
                                        <ColumnDefinition Width="9*" />
                                    </Grid.ColumnDefinitions>
                                    <ia:Checkbox
                                        Padding="0,3"
                                        FillColor="{DynamicResource PrimaryColor}"
                                        IsChecked="{Binding Selezionata}"
                                        IsCheckedChanged="Checkbox_IsCheckedChanged"
                                        OutlineColor="{DynamicResource PrimaryColor}"
                                        Shape="Rectangle" />
                                    <!--<Label
                                        Grid.Column="1"
                                        Padding="0,3"
                                        Text="{Binding Testo, Converter={StaticResource UrlDecoder}}"
                                        VerticalOptions="Center" />-->
                                    <math:TextView
                                        Grid.Column="1"
                                        LaTeX="{Binding Testo, Converter={StaticResource UrlDecoder}, Mode=TwoWay}"
                                        TextAlignment="Left"
                                        VerticalOptions="Center" />
                                </Grid>
                            </ViewCell>
                        </DataTemplate>
                    </ListView.ItemTemplate>
                </ListView>

The VM is a little bit messed up, that's the part where i change quest to show
 private void AvviaDomanda(int index)
        {
            IndiceAttuale = index;
            DomandaAttuale = Micro.Domande[IndiceAttuale - 1];
            [...other code...]
         }

Does DomandaAttuale notify about its change?

public partial class Domanda : INotifyPropertyChanged
    {
        public event PropertyChangedEventHandler PropertyChanged;
        [JsonProperty("id")]
        public long Id { get; set; }

        [JsonProperty("tipologia")]
        public string Tipologia { get; set; }

        [JsonProperty("testo")]
        public string Testo { get; set; }

        [JsonProperty("tempo_massimo")]
        public int TempoMassimo { get; set; }

        [JsonProperty("immagine")]
        public string Immagine { get; set; }
        public int TempoImpiegato { get; set; }
        public int Index { get; set; }

        [...other code...]
    }
public partial class Risposta : INotifyPropertyChanged, ICloneable
    {
        public event PropertyChangedEventHandler PropertyChanged;
        [JsonProperty("id")]
        public long Id { get; set; }

        [JsonProperty("testo")]
        public string Testo { get; set; }

        [JsonProperty("corretta")]
        public long? Corretta { get; set; }

        [JsonProperty("associa")]
        public string Associa { get; set; }
        public bool Selezionata { get; set; }

        [...other code...]
    }

I'm using the NuGet package Fody.PropertyChanged to notify the changes, so theorically it should works

I specifically asked about class that contains DomandaAttuale property.
Anyway, here is a simple sample:
ListViewSample.zip
I've used Fody.PropertyChanged as well.

Sorry the, did you mean these files?
Modulo.cs
public partial class IstanzaMicro : INotifyPropertyChanged
   {
       public event PropertyChangedEventHandler PropertyChanged;
       [JsonProperty("id")]
       public long Id { get; set; }

       [JsonProperty("domande")]
       public Domanda[] Domande { get; set; }
       public Micro Micro;
       [...various attributes...]
   }

TestPage.xaml.cs
public partial class TestPage : ContentPage
    {
        public IstanzaMicro Micro { get; set; }
        public Domanda DomandaAttuale { get; set; }
        public int IndiceAttuale { get; set; }
        [...various attributes...]
        public TestPage(IstanzaMicro micro)
        {
            InitializeComponent();
            Micro = micro;
            BindingContext = this;
            SetupVisualizers();
            AvviaDomanda(1);
            Micro.TempoImpiegato = 0;
            TimerAlive = true;
            BackButtonClickable = true;
            Console.WriteLine(Micro);
            StartCountdown();
        }

        private void AvviaDomanda(int index)
        {
            IndiceAttuale = index;
            DomandaAttuale = Micro.Domande[IndiceAttuale - 1];
            [...other code...]
        }

        private void ProssimaSchermata(object sender, EventArgs e)
        {
            if (IndiceAttuale < 5)
                AvviaDomanda(++IndiceAttuale);
            else
            {
                [...other code...]
            }
        }

As you can see DomandaAttuale change only on AvviaDomanda, and AvviaDomanda is called twice (on constructor, and in ProssimaSchermata)
Btw thanks for ListViewSample.zip, I noticed that you use RelayCommand, is it necessary to make it work?

As you can see DomandaAttuale change only on AvviaDomanda, and AvviaDomanda is called twice (on constructor, and in ProssimaSchermata)

But TestPage itself doesn't implement INotifyPropertyChanged interface therefore View doesn't know that something is changed.
For now you can do
public partial class TestPage : ContentPage, INotifyPropertyChanged
{
        public event PropertyChangedEventHandler PropertyChanged;
        // the rest of your code

Though I'd suggest you to read some MVVM tutorial and move logic outside of TestPage.xaml.cs.

Btw thanks for ListViewSample.zip, I noticed that you use RelayCommand, is it necessary to make it work?

No, it's unrelated. RelayCommand is a way to react to Button.Click. You can use any other implementation of ICommand interface. I just take the one that I found simplest.

That's what happen when I add those lines...

I tried to notify manually in this way:
public partial class TestPage : ContentPage, INotifyPropertyChanged
    {
        public event PropertyChangedEventHandler PropertyChanged;
        private Domanda domandaAttuale;
        public Domanda DomandaAttuale
        {
            get { return domandaAttuale; }
            set
            {
                domandaAttuale = value;
                OnPropertyChanged();
            }
        }
        protected void OnPropertyChanged([CallerMemberName] string domandaAttuale = null)
        {
            PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(domandaAttuale));
        }

But it still not working

Though I'd suggest you to read some MVVM tutorial and move logic outside of TestPage.xaml.cs.

Yep, you are right, I started use Xamarin with MVC pattern, but I noticed that somethings not works with binding

And btw I don't understand why till I was using Label it was working, but when I replaced them with math:TextView it worked no more...

But it still not working

Odd. It should work. Are there are any warnings or binding errors in the Debug.Output?
If you put breakpoint to the
domandaAttuale = value;

Does it go there?

In the end I resolved placing an empty Label as 3rd column:
                        <ListView.ItemTemplate>
                            <DataTemplate>
                                <ViewCell Height="69">
                                    <Grid VerticalOptions="FillAndExpand">
                                        <Grid.ColumnDefinitions>
                                            <ColumnDefinition Width="10*" />
                                            <ColumnDefinition Width="90*" />
                                            <ColumnDefinition Width="1*" />
                                        </Grid.ColumnDefinitions>
                                        <ia:Checkbox
                                            Grid.Column="0"
                                            FillColor="{DynamicResource PrimaryColor}"
                                            IsChecked="{Binding Selezionata}"
                                            IsCheckedChanged="Checkbox_IsCheckedChanged"
                                            OutlineColor="{DynamicResource PrimaryColor}"
                                            Shape="Circle" />
                                        <math:TextView
                                            Grid.Column="1"
                                            LaTeX="{Binding Testo, Converter={StaticResource UrlDecoder}, Mode=TwoWay}"
                                            TextColor="{DynamicResource TextColor}"
                                            VerticalOptions="Center" />
                                        <Label Grid.Column="2" Text="" />
                                    </Grid>
                                </ViewCell>
                            </DataTemplate>
                        </ListView.ItemTemplate>


Can't instantiate abstract class ProjectContext with abstract methods project_name, project_version

Hi,
I'm new to kedro and I have a problem when opening Jupyter Lab/Notebook from Kedro using the command kedro jupyter lab. The error was:
TypeError: Can't instantiate abstract class ProjectContext with abstract methods project_name, project_version Run with --verbose to see the full exception Error: Unable to load Kedro context with environment None. Make sure it exists in the project configuration. Error: Can't instantiate abstract class ProjectContext with abstract methods project_name, project_version
I have been following the steps in kedro official docs website , but didn't succeed. For reproducibility  purpose, here are the steps I performed:

Create new conda environment: conda create --name myenv
Activate the environment: source activate myenv
Create new kedro project with pyspark starter: kedro new --starter=pyspark
Go to newly created project folder: cd my_project
Install requirements: kedro install
Open jupyter lab: kedro jupyter lab --no-browser

Step 6 where gave me the error. As a side note, I had to do point 5 twice because the first time gave me incompatible error, but then I executed it again and it works.
Sorry in advance if I didn't put enough detail. Feel free to ask any details you need, I'll be gladly to answer them.
Thank you.

Hello there @adamginza.
Were are very excited that you've decided to try our Kedro.
Thanks fro your question. I have a hint on what can be happening to your project. Can you just confirm what version of Python you are using to run the project?
Thanks.

Hi! I followed your steps and tried to reproduce the error, but kedro jupyter lab --no-browser is working fine for me.
Did you specify which Python version you want to use when running conda create --name myenv(Kedro supports 3.6 and 3.7 for Spark).

Hi @adamginza any luck with the above? If not please confirm which Kedro and Python versions you are running. As Kiyo mentioned, 3.8, which I think is the default conda python env, is not well supported for pyspark. Otherwise it might be a case of using mismatching kedro version and starter version.

Hi, sorry for late reply. When I created the conda environment I didn't specify the python version. However it automatically has python version 3.6.10 when the new environment has been created.

Alright, in that case could you try running kedro new --starter=pyspark --checkout=0.16.x where 0.16.x matches the version of kedro you have installed?

Hi @adamginza I'm going to close this now as we haven't been able to reproduce the issue. Please feel free to reopen the issue if you still haven't resolved it. Many thanks!


Multiple dependendable dropdown

Hi
I Have 2 drop downs country,state.
user can select multiple countries and multiple states
but need filtering like when multiple countries selected then we need to show states belongs to multiple countries only.
Can i know how we can achieve this

You could have an addItem event listener for the countries instance which then uses setChoices to dynamically populate states

There is an example of something similar on the demo page if you view the source: https://joshuajohnson.co.uk/Choices/ (see the cities/tube station example)

Thanks for your reply.
Iam getting all countries and state on page load .Countries and states ( with country as select group) are multi select.
Lets say i selected country A and Country B .I will want to filter state droup to show States of Country A and Country B only


Allow connectTo to return a different type and the same as the input

The example below exposes T but returns what is selected by the map which is R
@connectTo<T, R>({
  selector: store => {
    return store.state.pipe(
      map(state => state.r)
    );
  }
})

These are the only changes I did to decorators.ts

ConnectToSettings will have generics of <T, R = T | any>
selector will now return an observable with generic of R
getSource function requires a return type for the source.subscribe to detect what it should return

export interface ConnectToSettings<T, R = T | any> {
  onChanged?: string;
  selector: ((store: Store<T>) => Observable<R>);
  setup?: string;
  target?: string;
  teardown?: string;
}

export function connectTo<T, R = any>(settings?: ((store: Store<T>) => Observable<R>) | ConnectToSettings<T, R>) {
  const store = Container.instance.get(Store) as Store<T>;

  function getSource(): Observable<any> {
    if (typeof settings === "function") {
      const selector = settings(store);

Pull request opened https://github.com/zewa666/aurelia-store/pull/30

Thanks, merged and released

@zewa666 I just noticed that the NPM package that was release (0.23.2) doesn't have the necessary changes in the declaration files. Although the src is fine.

yes true, I'm sorry I didn't properly add the built files :(
new release is out


WIP: Add AnyQuery trait to support custom sql builders

Fixes https://github.com/launchbadge/sqlx/issues/1225
It's still missing documentation.

Currently there's a problem: the query can be asked to be realized without a kind.

Actually, this interface doesn't do what we need (we would have to return a String, which complicates everything).

Please check out the next branch. You'll find the Execute trait better suited to be plugged into like this, there.

Deprecated in favor of https://github.com/launchbadge/sqlx/pull/1228


[MonacoEditorReactComp] onLoad() does not get called when there is any error

this is probably intended behavior, but is sometimes annoying.
For example in our app we add editor actions, like ctrl+s to save, inside the onLoad(). If the language server is not online, we still want to use the editor, so we just show an error alert with the onError() and move on. But now the onLoad() did not get called and we don't have our custom editor actions.

@Stainless2k do you want to propose an alternate/configurable approach (=PR)?

Could you point me to the code that's relevant for this, I will have a look at it.

Actually this got fixed already, this was in issue with our e2e test. Sorry for not checking this before creating this issue. :pray:


Grouping in small UI

If one adds too many builds to monitor but doesn't need them right now it would be nice to group them so one can collapse them

Why not simply make them temporarily disabled and don't show these?


Adds Date retyping for GeoTools Vector ingest (#468)

Adds Date retyping for GeoTools Vector ingest (#468).  To support it, adds CompoundIngestFormatOptionProvider to enable multiple providers for a single ingest plugin.

Only the first Travis build of the four is failing because it can't find one of the classes... but it's clearly there.  I'm not sure what the problem is.

So the failure is valid - it's coming from changes in geotools between 12.x and 13.x+;   the SimpleFeatureTypeBuilder class had a bunch of set(...) methods added here: https://github.com/geotools/geotools/commit/33e9de5a0306761950ac7dbffc428d9493389b20#diff-69cbda95a5fcc79676d0c12b73dd3f21
the diff makes use of one of those methods here:
https://github.com/ngageoint/geowave/blob/GEOWAVE-468/extensions/formats/geotools-vector/src/main/java/mil/nga/giat/geowave/format/geotools/vector/retyping/date/DateFieldRetypingSource.java#L66

and the first profile uses 12.4 of geotools, so the method isn't found.

Now what to do about this;  typically we have been looking to stick with N and N-1.  14.x isn't out yet.  I looking at what got added in the commit above though, and what was supported in 12.x I don't see a super clean way to do this (since attributes is protected, and there's no accessor) - but I just glanced it it real quick.
Dropping 12.x support a bit early isn't out of the question - just want to get a double check and make sure there's not an easy way to maintain it.   @rfecher

that is kinda annoying - I think there should be a much less elegant way to set an attribute descriptor in 12.x that will also work in 13+ (I think looping over the attributes and just adding the attribute descriptor with SimpleFeatureTypeBuilder.add() if its not the date field and adding the new descriptor if it is the date field). But they are close to releasing v14.0 so my vote is that we drop support for 12.x in our next minor release (0.8.9).  We are releasing <IP_ADDRESS> on Monday with some bug fixes and Eric's other commit can make it into that but we'll hold off on this commit (so <IP_ADDRESS> will be the last one with geotoools 12.x support).

I actually had it at first where it would loop through the AttributeDescriptors of the initial type, re-add them if they weren't the ones marked to replace, and replace them if need be.  It worked but I thought this solution was more concise.
I can switch back to that if it would be preferable to also maintain GeoTools 12.x support.

When convenient, I think it's ready to be merged.  I squashed my changes into one commit, switched back to support GeoTools 12.x, and addressed the code comments.  Thanks!


linuxPackages.scst: init at 3.8

Description of changes
Adds scst kernel module which provides access to SCSI devices via QLogic Fibre Channel cards.
The build targets and flags are taken from the upstream RPM spec.
Tested with a QLogic QLE2564 card and kernel 6.7.7.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Please fix the commit message.

Done, thanks for the review!


Add inline links

Add inline links to Contributing.md

Do you mind adding a link to the much more extended pages on adding and sharing a dataset in the new documentation?

Sure, I will do that too

If you think you have it -- https://narwhal3301.github.io/


Async arrow functions

Hi,
how to allow async arrow function in this plugin without babel-eslint?
(async () => {
    console.log(await asyncFunction());
})();

This is not something related to eslint-plugin-meteor, but to eslint in general unless you saw it breaking when adding eslint-plugin-meteor to your existing eslint setup.
Maybe this helps: https://github.com/eslint/eslint/issues/1657


The browser sample can't open the target="_blank" link. Is there any way to solve it?thanks

I also found this issue.
I found another PyQt5 tabbed browser that can handle target="_blank" links.
It'll open a link in a new tab if the link has target="_blank".
https://github.com/qutebrowser/qutebrowser


pip command isnt working

I was doing everything correctly and came upon this Error, any Help?

try: py -m pip install -r requirements.txt

Worked Thanks


Field values are lost when pickling jsonmodel

I found out that using pickle serializer does not seem to work with jsonmodels. Using this simple model as an example (using Python 2.7.10):
class TestModel(models.Base):
    a = fields.StringField(default="")

>>> m = TestModel(a="foo")

>>> m
TestModel(a='foo')

>>> pickle.loads(pickle.dumps(m))
TestModel(a='')

I'm using Python 2.7.10.
So the field value is lost when pickling. I found out that pickle uses __dict__ variable by default, and as this does not contain field data, it is not saved to the serialized form.
Using customized __getstate__() and __setstate__() methods I managed to make it work, I just had to make sure the _cache_key variable is preserved, as unpickling the object does not run __init__() and _cache_key is not created:
class TestModel(models.Base):
    a = fields.StringField(default="")

    def __getstate__(self):
        state = self.to_struct()
        state['_cache_key'] = self._cache_key
        return state

    def __setstate__(self, data):
        self._cache_key = data.pop('_cache_key')
        self.populate(**data)

Does this seem to be a correct way to handle pickling? Also, is it necessary to pickle the _cache_key, or would it be ok to just initialize it to a new value? (Some kind of _init_cache_key() method would be a good addition in that case).
If this is a correct direction, I can make a pull request and test it with other Python versions. Support for JSON serializer would also be possible.

Hi,
I was able to omit this behavior by adding an inherited constructor:
class TestModel(models.Base):
    a = fields.StringField(default="")

   def __init__(self, *args, **kwargs):
       super(TestModel, self).__init__(*args, **kwargs)

Afterwards, the error above disappeared.


[AC New Features] Static Header for Carousel

Description
The horizontal carousel currently does not support a way for users to add a header to their carousel that remains static even after paginating through the carousel. A use case for this would be a card author wanting to use the carousel to display related content on different pages of the carousel. Instead of the same title paginating with the content in the carousel, we should enable something like this:

In this example one case observe that the carousel header remains in a fixed position while the carousel content (in this case only images, but could be any supported carousel element) paginates.
Describe the solution you'd like

Capability
Priority

Allow text to remain static above carousel content serving as a static carousel header
Must

Support multiple lines in header
Must

When a header is used with a carousel the carousel arrows need to be vertically centered with the carousel content (the content that is paginating) and not the whole container
Must

The user must be able to add some spacing between the header and the carousel content
Must

Ability to style header text on a per line basis (size, weight, isSubtle, accent)
Should

Implementation Platforms

[X] JS
[ ] .NET WPF
[ ] Android
[ ] iOS
[ ] UWP

Per Line Text Style
Supporting different text styling such as different fonts per line of text is not a must for this feature but we have to consider it as customers may request for it in the future.

In order to make the current implementation future proof such that it won't require us investing in this area repeatedly, there are four options we can consider.
option 1: Use TextBlock and defer implementing line specific styling until it's asked as it's not required.
option 2a: Use RichTextBlock, and add style option to RichTextBlock's TextRun as we did for TextBlock.
option 2b: Use RichTextBlock, and have Carousel renderer to set header a11y role to the inlines.
option 3: Use Container and leave it to Card author to update a11y role header using TextBlock.
Example of  proposed new schema of 2a
"header":
{
      "type": "RichTextBlock",
      "inlines": [
        "This is the first inline. ",
        {
          "type": "TextRun",
          "text": "We support colors,",
          "color": "good",
          "style": "header"
        }
    ]
}

option 1:
pro:
Easy to implement and ready to ship.
cons:
Could force users to change their old payload.
option 2:
pro:
Meets all of the requirement and fairly easy to implement
con:
Must implement for all of the renders at some point; verification and publishing patches for them
option 2b:
pro:
Same pro of option2a + doesn't have to implement for all of the renderers since a11y role is implemented at the carousel renderer.
cons:
All of TextRuns in RichTextBlock get the a11y header role; there isn't way to designate a specific TextRun to be a a11y header.
option 3:
pro:
Gives the author the most options to implement their design vision
con:
We have to clearly communicate that Container has to be a parent element to users.
Can be cumbersome to use if user just wants to have a simple text based header.
Issues of enforcing forbidden items. Should we enforce the same policy of Carousel to it?
Will the policy diverge in the future, and if so, how do we keep track and maintain it?
Spacing
This feature applies to spacing between header and carousel.
option 1
Have users to specify spacing by using new line characters such as '\n' and '\r'.
option 2
Make use of spacing property in Carousel

I'm in favor of option 1 or b1. Let's verify with PMs if the different styles for each line is a requirement. I believe that even if it's not required now, it will be so it's better if we go with b1 and be ahead with the implementation.
"Must implement for all of the renders at some point" - is it's just for the carousel? the carousel is not implemented in other renderers anyways (or is it?....), so can we refactor/add the title when we'll implement the carousel for other renderers? regardless, i believe that there's no urgency there as the title ask is for the JS renderer only at this point.
Spacing - is the use of "\n" and "\r" common and valid for all cases when the user needs multiple lines? if yes then option 1 is probably ok. otherwise we should probably go with option 2

Per Line Text Style
Supporting different text styling such as different fonts per line of text is not a must for this feature but we have to consider it as customers may request for it in the future.
In order to make the current implementation future proof such that it won't require us investing in this area repeatedly, there are four options we can consider.
option 1: Use TextBlock and defer implementing line specific styling until it's asked as it's not required. option 2a: Use RichTextBlock, and add style option to RichTextBlock's TextRun as we did for TextBlock. option 2b: Use RichTextBlock, and have Carousel renderer to set header a11y role to the inlines. option 3: Use Container and leave it to Card author to update a11y role header using TextBlock.
Example of proposed new schema of 2a
"header":
{
      "type": "RichTextBlock",
      "inlines": [
        "This is the first inline. ",
        {
          "type": "TextRun",
          "text": "We support colors,",
          "color": "good",
          "style": "header"
        }
    ]
}

option 1:
pro:
Easy to implement and ready to ship.
cons:
Could force users to change their old payload.
option 2a:
pro:
Meets all of the requirement and fairly easy to implement
con:
Must implement for all of the renders at some point; verification and publishing patches for them
option 2b:
pro:
Same pro of option2a + doesn't have to implement for all of the renderers since a11y role is implemented at the carousel renderer.
cons:
All of TextRuns in RichTextBlock get the a11y header role; there isn't way to designate a specific TextRun to be a a11y header.
option 3:
pro:
Gives the author the most options to implement their design vision
con:
We have to clearly communicate that Container has to be a parent element to users. Can be cumbersome to use if user just wants to have a simple text based header. Issues of enforcing forbidden items. Should we enforce the same policy of Carousel to it? Will the policy diverge in the future, and if so, how do we keep track and maintain it?
Spacing
This feature applies to spacing between header and carousel.
option 1
Have users to specify spacing by using new line characters such as '\n' and '\r'.
option 2
Make use of spacing property in Carousel

Thank you for creating the proposal. For this specific feature I believe we should:

Make as little schema changes as possible
Build in a future proof way that saves our team from having to make changes to this in the future and potentially introducing breaking changes

I don't think we should go with an approach that will cause the a11y team to file a bug on us in the future.
If we were to choose option 1 and only allow TextBlock, would a user creating a header with multiple lines be able to specify a specific line in the TextBlock to apply the a11y header role to or would it be applied to the entire TextBlock? If it is applied to the entire TextBlock, then I think it is the same experience as the a11y header role getting applied to all of the TextRuns in RichTextBlock. Ultimately, the a11y header role is only an issue if the user has multiple lines of text in the header and they only want this on a specific line. If this is not possible with TextBlock, then I think we should go with option 2b as the con listed in 2b would also apply to option 1.
On the subject of spacing I mainly want to make sure that the spacing property on the Carousel is respected and capable of pushing the Carousel content down if the user desires this.
For example, let's assume the following screenshot has set the spacing property on the Carousel element to "small".

The expectation for this request is that if the user sets spacing to be "large" in the previous example the Carousel content would move down more giving more space to the header. On the other hand if the user specifies spacing to be "none" then the Carousel would appear closer to the header. I believe this is already implemented as it works for every other container/element we have, but wanted to make sure it was called out just in case the Carousel worked differently.

Can you create a PR for this? It's hard to track in issue and add comments. (Easy to be lost)
I prefer header as just a container:

we may need to support footer someday. which may add like button and other stuff
we may add icon, http link or other things to header.

@KesemZ
Option 2a updates RichTextBlock to have style option that TextBlock currently has. If we does that then we need to update all of the renderers, iOS, Android and etc to be consistent.
@KesemZ & @JeanRoca
for 2b, I will check with a11y people if assigning header role to the entire RichTextBlock is o.k.
For spacing, I will go with option 2 since there are not strong objections to it.
@licanhua
I agree with you on the most of the points. what about the cons listed under option 3? RichTextBlock supports select actions that supports Action.OpenUrl.
@all
I've created PR. If you prefer, we can discuss further from there.

@jwoo-msft - with the answer we got from the accessibility team, sounds like the best implementation is to have 3 seperate headers (with 3 separate descriptions and styles) - it could be
header
Title
sub-title
Will it make sense to implement it this way?

Please continue the discussion on the PR. I moved all comments to https://github.com/microsoft/AdaptiveCards/pull/7751


Refactor DataFileHandle -> DataFileMeta

What changes were proposed in this pull request?
Classes related to FileHandle are actually FileMeta.
How was this patch tested?
Existing tests.

Thanks @yueawang @LuciferYang.


Recapture GDAL capabilities we lost with move away from native build

This set of code:
with rio.open('s3://mrgeo-source/srtm-v3-30/N00E006.hgt') as ds:
    bounds = ds.bounds
    height = ds.height
    width = ds.width
    crs = ds.get_crs()
    srs = osr.SpatialReference()
    srs.ImportFromWkt(crs.wkt)
    proj4 = srs.ExportToProj4()
    tile_cols = math.floor((width - 1) / 512) * 512
    tile_rows = math.floor((height - 1) / 512) * 512
    ws = [((x, x + 512), (y, y + 512)) for x in range(0,tile_cols, 512) \
                                          for y in range(0, tile_rows, 512)]
    print(bounds)
    print(height)
    print(width)
    print(crs)
    print(tile_cols)
    print(tile_rows)
    print(ws)

fails in the current container. In the rde/workshop-prep container, it succeeds.
I suspect this is due to the move away from a native GDAL build and towards a pip installed GDAL.
We should either figure out how to gain back those capabilities with the pip installed version, or move back to a native GDAL build.

What was the error message that was raised?

@jamesmcclain that the file could not be found. Generic GDAL message when it can't find a driver to read something, it falls through to the filesystem driver and says the file is not found. I didn't capture the exact error but I believe it would be the same as doing gdalinfo /vsifoo/bar

It is possible that there are some ancillary files that did not get packaged, I will check it out.


Triple slash comments (xml comments) on modules also take the lines from before previous statement

If you have an open statement  (or essentially any statement that is not a declaration or let binding) that is preceded by XML documentation comments or simple syntax triple-slash comments, it will become part of the documentation of the next module  (or type, let  etc) declaration:
From the Tutorial project:

Repro steps
Create a new Tutorial project, open Tutorial.fsx. Or copy this:
/// This is a pipe!
open System

/// This is not a pipe!
module Test =
    ()

Or copy this:
module Test =

    /// Hello world
    15 = 2 |> ignore

    /// Let there be X
    let x = 12

    ()

Expected behavior
It should look like this:

Or this (2nd example):

Actual behavior
But it looks like this;

Or this (2nd example):

Known workarounds
Don't use triple-slash comments before statements.
Related information
I would understand this to be considered low prio, though essentially the triple-slash documentation parser should really only take into account what precedes directly before the declaration. A statement should cancel that parsing out.
This becomes more apparent if you create documentation from your sources. The Tutorial project template is therefore a good example how this should not work, and would compile into erroneous documentation.

Seen on: Visual Studio 2015 Upd 3, 2017, 2017 Preview 17.1

I'm not sure but we might even (miss-)use this "feature" in FSharp.Formatting. Maybe @tpetricek can recall if this is true.
If this is true a fix for this probably should contain a way to retrieve comments from namespaces. Otherwise I'm positive that this needs to be fixed :)

@matthid, I really think this is a bug, as you can see from the first screenshot, it also spans between double-slash and triple-slash comments. A double-slash comment should break the triple-slash documentation, I'd say (and I believe I have seen in other parts of my code that a double-slash stops the processing, but that may have been in an earlier version of VS or F#).
More importantly (and I failed to mention that above), when you need to switch to the more versatile XML comments, this "feature" (if considered so) can lead to potentially hard to find documentation bugs, because it will take the last XML comment it finds looking backward from the current declaration:

Yeah, this definitely seems like a bug, and it's the same in VS 2017 as well.

@matthid, I really think this is a bug, as you can see from the first screenshot, it also spans between double-slash and triple-slash comments.

Yep I'm definitely not arguing against it. It is a bug and needs to be fixed. Was just pointing out that this might break "FSharp.Formatting" (or not that's why I asked @tpetricek if he can recall).

Additionally I'd love to see that XML docs get some love again ;)

Thanks for the simple and clear repro steps


Added Operator Upgrade Integration tests for FMW Domain

Added integration tests for Operator upgrade for FMW Domain:

Upgrade Operator from 2.6.0 to latest with FMW domain in PV
Upgrade Operator from 3.0.0 to latest with FMW domain in PV
Upgrade Operator from 3.1.0 to latest with FMW domain in PV

https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/3373/parameters/ is a sequential run

ItOperatorUpgrade has upgrade tests for operator 3.0.1, 3.0.2, 3.0.3, 3.0.4 to latest. what's the plan for FMW domain tests? Are we going to add them or no?

We had discuss about what version to add for the upgrade with FMW domain. The conclusion is to add 2.6.0, 3.0.0 and 3.1.0 for now. But Pani can add more comments


Support for large buffers (>2G/4G)

Hi there,
Thank you for making this package, libdeflate is very fast. Have you tried to decompress buffers that are larger than 4G ?
Some functions work with ints, so I wonder how things will work if the decompressed buffer is larger than what an int can hold.
// DecompressGzip interfaces with c libdeflate for gzip decompression
func DecompressGzip(dc *C.decomp, inAddr, outAddr *byte, inSize, outSize int, sPtr uintptr) error {
    return parseResult(C.res(C.libdeflate_gzip_decompress(dc,
        unsafe.Pointer(inAddr), intToInt64(inSize),
        unsafe.Pointer(outAddr), intToInt64(outSize),
        C.mkPtr(C.size_t(sPtr)),
    )))
}

Hi there,
sorry for the super super late reply. Somehow, I haven't received notifications of your issues and have, therefore, overlooked it.
I hope this is still relevant. Have you tested if it works as intended with >4GiB buffers? I believe it should.
This is because, in Go, an int is platform-dependant, meaning it will be either 32 or 64 bit in length depending on whether you use a 32 or 64 bit architecture. I thought there was no point in giving 32-bit architectures the ability to use 64 bit buffers, since their memory can only hold 4 GiB anyways, and this library only works with in-memory buffers.
If you have any concerns why this should create an issue, let me know.

You were right, I think the problem was on my side. Thanks for checking.


Show scene thumbnails on map instead of data footprint

Overview
Show the scene thumbnail on a map instead of using data footprints etc.
Checklist
~- [ ] Styleguide updated, if necessary~
~- [ ] Swagger specification updated, if necessary~
Demo

Testing Instructions

Verify that you've loaded scene that contain tile footprints
Navigate to a scene with a tile footprint in the scene browser / project scene list
Verify that the thumbnail displays on the map (if no tile footprint is found, nothing will show)
In the browse view, mouse over a scene and verify that the thumbnail shows on the map
In a browse detail view, verify that the scene thumbnail is displayed on the map.
For scenes with multiple thumbnails, the highest resolution one should be displayed in the browse view, and the lower resolution one in the scene/detail view

Connects #683

I think the only change I'd make would be removing the opacity on the scene. otherwise looks good

The problem without transparency is that the landsat 8 thumbnails have all that black area around them, and the sentinel scenes have that white area around them.  That can make it difficult to see context. See here:

+1, let's go with @designmatty's suggestion of nixing the opacity changes for now -- that was the original design and it's easy enough to switch once we've shared it with some people


NativeModules empty on Apple M2 Max chip

Description
I'm following the native module on iOS example (https://reactnative.dev/docs/native-modules-ios) 1:1 but my NativeModules are empty.
In my <project-name>/ios directory I have added 2 files:
//  RCTCalendarModule.h
#import <React/RCTBridgeModule.h>
@interface RCTCalendarModule : NSObject <RCTBridgeModule>
@end

// RCTCalendarModule.m
#import "RCTCalendarModule.h"

@implementation RCTCalendarModule

// To export a module named RCTCalendarModule
RCT_EXPORT_MODULE();

@end

In my <project-name>/App.tsx file:
import React from 'react';
import { NativeModules } from 'react-native';

console.log(NativeModules, NativeModules.RCTCalendarModule) // Outputs "{} null"

React Native Version
0.72.3
Output of npx react-native info
System:
OS: macOS 13.4.1
CPU: (12) arm64 Apple M2 Max
Memory: 1.35 GB / 32.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 20.5.0
path: /opt/homebrew/bin/node
Yarn:
version: 1.22.19
path: /opt/homebrew/bin/yarn
npm:
version: 9.8.0
path: /opt/homebrew/bin/npm
Watchman:
version: 2<IP_ADDRESS>
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.12.1
path: /Users/kevin/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.4
- iOS 16.4
- macOS 13.3
- tvOS 16.4
- watchOS 9.4
Android SDK: Not Found
IDEs:
Android Studio: Not Found
Xcode:
version: 14.3.1/14E300c
path: /usr/bin/xcodebuild
Languages:
Java: Not Found
Ruby:
version: 3.2.2
path: /Users/kevin/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.3
wanted: 0.72.3
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
Steps to reproduce

Add files mentioned in issue description.
Run either yarn ios or start project through Xcode.
Wait for app to start up.
Observe output log mentioning {} null

Snack, screenshot, or link to a repository
https://github.com/afterburn/rn-38598-reproducer

Added link to reproducer repo https://github.com/afterburn/rn-38598-reproducer

That's expected. As an optimization, if you don't export anything from a module, the NativeModule is not created, that's why you see it as null. This saves memory.
I just tried adding a method in the Objective-c side and calling it from Javascript and it is works as expected.
This is the diff of the changes:
diff --git a/ReproducerApp/App.tsx b/ReproducerApp/App.tsx
index 9e9ef64..f605452 100644
--- a/ReproducerApp/App.tsx
+++ b/ReproducerApp/App.tsx
@@ -6,57 +6,18 @@
  */

 import React from 'react';
-import type {PropsWithChildren} from 'react';
 import {
   SafeAreaView,
   ScrollView,
   StatusBar,
-  StyleSheet,
-  Text,
   useColorScheme,
-  View,
   NativeModules,
+  Button,
 } from 'react-native';

-console.log(NativeModules, NativeModules.RCTCalendarModule);
+const {CalendarModule} = NativeModules;

-import {
-  Colors,
-  DebugInstructions,
-  Header,
-  LearnMoreLinks,
-  ReloadInstructions,
-} from 'react-native/Libraries/NewAppScreen';
-
-type SectionProps = PropsWithChildren<{
-  title: string;
-}>;
-
-function Section({children, title}: SectionProps): JSX.Element {
-  const isDarkMode = useColorScheme() === 'dark';
-  return (
-    <View style={styles.sectionContainer}>
-      <Text
-        style={[
-          styles.sectionTitle,
-          {
-            color: isDarkMode ? Colors.white : Colors.black,
-          },
-        ]}>
-        {title}
-      </Text>
-      <Text
-        style={[
-          styles.sectionDescription,
-          {
-            color: isDarkMode ? Colors.light : Colors.dark,
-          },
-        ]}>
-        {children}
-      </Text>
-    </View>
-  );
-}
+import {Colors, Header} from 'react-native/Libraries/NewAppScreen';

 function App(): JSX.Element {
   const isDarkMode = useColorScheme() === 'dark';
@@ -75,47 +36,17 @@ function App(): JSX.Element {
         contentInsetAdjustmentBehavior="automatic"
         style={backgroundStyle}>

-        <View
-          style={{
-            backgroundColor: isDarkMode ? Colors.black : Colors.white,
-          }}>
-

-            Edit <Text style={styles.highlight}>App.tsx</Text> to change this
-            screen and then come back to see your edits.
-

-

-            <ReloadInstructions />
-

-

-            <DebugInstructions />
-

-

-            Read the docs to discover what to do next:
-

-          <LearnMoreLinks />
-        </View>
+        <Button
+          title="Press Me"
+          onPress={() => {
+            console.log('Pressing here!');
+            console.log(CalendarModule);
+            // CalendarModule.createCalendarEvent('testName', 'testLocation');
+          }}
+        />
       </ScrollView>
     </SafeAreaView>
   );
 }

-const styles = StyleSheet.create({
-  sectionContainer: {
-    marginTop: 32,
-    paddingHorizontal: 24,
-  },
-  sectionTitle: {
-    fontSize: 24,
-    fontWeight: '600',
-  },
-  sectionDescription: {
-    marginTop: 8,
-    fontSize: 18,
-    fontWeight: '400',
-  },
-  highlight: {
-    fontWeight: '700',
-  },
-});
-
 export default App;
diff --git a/ReproducerApp/ios/RCTCalendarModule.m b/ReproducerApp/ios/RCTCalendarModule.m
index c6d85c2..8fd356c 100644
--- a/ReproducerApp/ios/RCTCalendarModule.m
+++ b/ReproducerApp/ios/RCTCalendarModule.m
@@ -1,9 +1,16 @@
 // RCTCalendarModule.m
 #import "RCTCalendarModule.h"
+#import <React/RCTBridge+Private.h>
+#import <React/RCTLog.h>

 @implementation RCTCalendarModule

-// To export a module named RCTCalendarModule
-RCT_EXPORT_MODULE();
+RCT_EXPORT_MODULE()
+
+//RCT_EXPORT_METHOD(createCalendarEvent:(NSString *)name location:(NSString *)location)
+//{
+//  RCTLogInfo(@"Pretending to create an event %@ at %@", name, location);
+//}
+

 @end

Thanks, exporting a method from the module works. It wasn't clear from the docs that you had to do this or otherwise the module wouldn't be created, so thank you @cipolleschi.

My issue was
Files shoould be added within the same folder as AppDelegate
and native console will not appear on metro bundler! we can use flipper for that or run from xcode!


⚠ RPC server - Conflux has degraded performance

In ab06ecd, RPC server - Conflux ($CONFLUX_RPC_URL) experienced degraded performance:

HTTP code: 200
Response time: 7256 ms

Resolved: RPC server - Conflux performance has improved in 190ae95 after 8 minutes.


Fix broken link to mouse_regions.txt (in user guide)

Really cool project!
This is just a tiny PR to fix the link to mouse_regions.txt in UserGuide.md.
Currently the link points to
https://github.com/BrancoLab/BrainRender/blob/master/mouse_regions.txt
instead of
https://github.com/BrancoLab/BrainRender/blob/master/Docs/mouse_regions.txt

Hey thanks! And thanks for the PR, nice catch!