Error loading module when Nuxt app is part of a pnpm monorepo

Environment

in repo root*

Operating System: Darwin
Node Version:     v18.16.0
Nuxt Version:     0.0.0
Nitro Version:    -
Package Manager<EMAIL_ADDRESS>Builder:          webpack
User Config:      -
Runtime Modules:  -
Build Modules:    -

in app directory *

Operating System: Darwin
Node Version:     v18.16.0
Nuxt Version:     3.6.5
Nitro Version:    -
Package Manager<EMAIL_ADDRESS>Builder:          vite
User Config:      modules, devtools
Runtime Modules<EMAIL_ADDRESS>Build Modules:    -

Reproduction
Clone https://github.com/marr/pnpm-monorepo and pnpm install -- you will see the error:

ERROR  Cannot resolve vue-i18n on pnpm! please install it on 'node_modules'

I have created a clean pnpm monorepo, and a fresh install of nuxt 3.6.5. The above error happens during the nuxt prepare phase. The previous issues mention this is a nuxt issue, but I'm not sure how to fix it. I'm new to pnpm, so maybe someone can point me in the right direction. I do have shamefully-hoist=true in my .npmrc, but it doesn't appear to do anything.
If I run pnpm install --shamefully-hoist there is no error, and the vue-i18n package shows up under the root node_modules. However, when I run pnpm ls -r vue-i18n, the results are empty.
Also, in my existing project (not this barebones repo), I can't get the prepare script to run. I've tried shamefully-hoist on the cli, and still receive the error above.
Describe the bug
The vue-i18n module appears to be missing to the nuxt i18n module, when part of a pnpm monorepo.
Additional context
If I enable DEBUG=* output when building, I see some extra info below.
Logs
@nuxtjs/i18n:alias vue-i18n resolving from ... [                                                                                11:48:57 AM
  '/Users/david.marr/code/cxl-ui-monorepo/node_modules/.pnpm/@nuxtjs+i18n-edge@8.0.0-beta.13-28175294.3a94c60_vue-router@4.2.4_vue<EMAIL_ADDRESS>  '/Users/david.marr/code/cxl-ui-monorepo/apps/daas/node_modules/vue-i18n/dist/vue-i18n.mjs',
  '/Users/david.marr/code/cxl-ui-monorepo/node_modules/vue-i18n/dist/vue-i18n.mjs'
] +0ms

 ERROR  Cannot resolve vue-i18n on pnpm! please install it on 'node_modules'                                                                   11:48:57 AM

  at tryResolve (/Users/david.marr/code/cxl-ui-monorepo/node_modules/.pnpm/@nuxtjs+i18n-edge@8.0.0-beta.13-28175294.3a94c60_vue-router@4.2.4_vue@3.3.4/node_modules/@nuxtjs/i18n-edge/dist/module.mjs:213:9)
  at async setupAlias (/Users/david.marr/code/cxl-ui-monorepo/node_modules/.pnpm/@nuxtjs+i18n-edge@8.0.0-beta.13-28175294.3a94c60_vue-router@4.2.4_vue@3.3.4/node_modules/@nuxtjs/i18n-edge/dist/module.mjs:432:38)
  at async setup (/Users/david.marr/code/cxl-ui-monorepo/node_modules/.pnpm/@nuxtjs+i18n-edge@8.0.0-beta.13-28175294.3a94c60_vue-router@4.2.4_vue@3.3.4/node_modules/@nuxtjs/i18n-edge/dist/module.mjs:1444:5)

I'm still digging into this, and it looks like the setupAlias function is where things fail. One of my dependencies pulls in<EMAIL_ADDRESS>which is possibly conflicting with the version that the i18n module expects.
None of the paths in the targets array exist here:

The values:

The closest thing to existing is the:
// workspace directories
resolve(workspaceDir, "node_modules", modulePath)

However, when I look at the node_modules/vue-i18n/ relative to the root repo, the version is 9.2.2. So the files in dist don't match what the module is looking for.

for now I just installed vue-i18n@next at the top level of my monorepo. Not ideal, but works around the issue.

Thank you for your reporting!
I've checked your reproduction.
In the monorepo case, you need to put the .npmrc with shamefully-hoist=true configured in root, not in the target package. I have confirmed that it works on your repro.
Thanks!

@kazupon you can see the issue if you pull down the latest code. I simply added another vue app (via vite) into the apps/others directory, and I tried to install vue-i18n.
shamefully-hoist is still set at the top level, but you can see the error in the apps/nuxt3-app directory, due to the root node_modules storing the 9.2.2 version of vue-i18n. The prepare fails, becuase of the reasons I mentioned above.
So, I believe there is still an issue with the nuxt module not supporting the common case of a monorepo.
To reproduce, pull down the repo again. Then:
cd apps/other-app
pnpm i vue-i18n -w

The error appears from the sibling nuxt project:

ERROR  Cannot resolve vue-i18n on pnpm! please install it on 'node_modules'

This is because after the pnpm install, version 9.2.2 is put into the /node_modules directory. The postinstall hook runs in the nuxt app, and the module fails to find version 9.3.0-beta, which it is hardcoded to use.


Cannot start emqx single node setup

[X ] BUG REPORT

BUG REPORT

Expected behavior
emqx starts up and accepts connections. The container does not exit.
Actual behavior
The process exits after about 30 seconds without any log output that would indicate the error.
logs:
The first log is the console output. To see that I made a run with the logging gelf configuration in docker-compose.yml commented out.
[sludwig@mqtt mqtt-emqx]$ docker-compose up
Starting mqtt-emqx-vod-dev-c ... done
Attaching to mqtt-emqx-vod-dev-c
mqtt-emqx-vod-dev-c    | node.max_ports=1048576
mqtt-emqx-vod-dev-c    | listener.tcp.external.acceptors=64
mqtt-emqx-vod-dev-c    | listener.ssl.external=58883
mqtt-emqx-vod-dev-c    | listener.ws.external=58083
mqtt-emqx-vod-dev-c    | allow_anonymous=false
mqtt-emqx-vod-dev-c    | listener.ssl.external.acceptors=32
mqtt-emqx-vod-dev-c    | node.process_limit=2097152
mqtt-emqx-vod-dev-c    | node.max_ets_tables=2097152
mqtt-emqx-vod-dev-c    | listener.wss.external=58084
mqtt-emqx-vod-dev-c    | listener.ws.external.acceptors=16
mqtt-emqx-vod-dev-c    |<EMAIL_ADDRESS>mqtt-emqx-vod-dev-c    | listener.tcp.external=51883
mqtt-emqx-vod-dev-c    | EMQX_LOADED_PLUGINS=emqx_management,emqx_auth_username,emqx_recon,emqx_retainer,emqx_dashboard
mqtt-emqx-vod-dev-c exited with code 1
[sludwig@mqtt mqtt-emqx]$

[sludwig@mqtt mqtt-emqx]$ docker exec -ti mqtt-emqx-vod-dev-c /bin/sh
/opt/emqx $ tail -f log/erlang.log.1

=====
===== LOGGING STARTED Wed Jul 17 21:50:19 UTC 2019
=====
Exec: /opt/emqx/erts-10.3.4/bin/erlexec -boot /opt/emqx/releases/v3.2.0/emqx -mode embedded -boot_var ERTS_LIB_DIR /opt/emqx/erts-10.3.4/../lib -mnesia dir<EMAIL_ADDRESS>-config /opt/emqx/data/configs/app.2<IP_ADDRESS>.50.21.config -args_file /opt/emqx/data/configs/vm.2<IP_ADDRESS>.50.21.args -vm_args /opt/emqx/data/configs/vm.2<IP_ADDRESS>.50.21.args -- console
Root: /opt/emqx
/opt/emqx
Starting emqx on node<EMAIL_ADDRESS>Start http:management listener on 8080 successfully.
Start http:dashboard listener on 18083 successfully.
Start mqtt:tcp listener on <IP_ADDRESS>:11883 successfully.
Start mqtt:tcp listener on <IP_ADDRESS>:51883 successfully.
Start mqtt:ws listener on <IP_ADDRESS>:58083 successfully.
Start mqtt:ssl listener on <IP_ADDRESS>:58883 successfully.
Start mqtt:wss listener on <IP_ADDRESS>:58084 successfully.
EMQ X Broker 3.2.0 is running now!
Eshell V10.3.4  (abort with ^G)
(emqxvoddev1@<IP_ADDRESS>)1> [sludwig@mqtt mqtt-emqx]$

^ here at the end you see that an Eshell promt is open somehow and then after some seconds the process exists
[sludwig@mqtt mqtt-emqx]$ docker exec -ti mqtt-emqx-vod-dev-c /bin/sh
/opt/emqx $ tail -f log/
dummy.txt     emqx.log.1    emqx.log.idx  erlang.log.1  run_erl.log
/opt/emqx $ tail -f log/run_erl.log
run_erl [2530] Wed Jul 17 21:52:00 2019
Args before exec of shell:
run_erl [2530] Wed Jul 17 21:52:00 2019
argv[0] = sh
run_erl [2530] Wed Jul 17 21:52:00 2019
argv[1] = -c
run_erl [2530] Wed Jul 17 21:52:00 2019
argv[2] = exec "/opt/emqx/bin/emqx" "console"
[sludwig@mqtt mqtt-emqx]$

Test code
my docker-compose.yml
version: '3'
services:

  mqtt-emqx-vod-dev-s:
    image: emqx/emqx
    container_name: mqtt-emqx-vod-dev-c
    environment:
      EMQX_LOADED_PLUGINS: "emqx_management,emqx_auth_username,emqx_recon,emqx_retainer,emqx_dashboard"
      EMQX_NAME: emqxvoddev1
      EMQX_HOST: <IP_ADDRESS>
      EMQX_NODE__COOKIE: 9beqyAQGcWQ1FvSiLnf3
      EMQX_LOG__CONSOLE: console
      EMQX_ALLOW_ANONYMOUS: 'false'
      EMQX_LISTENER__TCP__EXTERNAL: 51883
      EMQX_LISTENER__SSL__EXTERNAL: 58883
      EMQX_LISTENER__WS__EXTERNAL: 58083
      EMQX_LISTENER__WSS__EXTERNAL: 58084
      EMQX_LISTENER__API__MGMT: 58080
    logging:
      driver: gelf
      options:
        gelf-address: udp://<IP_ADDRESS>:12201
        tag: mqtt-emqx-vod-dev
    ports:
      - "51883:1883"
      - "58883:8883"
      - "58083:8083"
      - "58084:8084"
      - "58080:8080"
    volumes:
      - mqtt-emqx-vod-dev-lib-v:/opt/emqx/lib
      - mqtt-emqx-vod-dev-etc-v:/opt/emqx/etc
#      - mqtt-emqx-vod-dev-log-v:/opt/emqx/log
#      - mqtt-emqx-vod-dev-data-v:/opt/emqx/data
      - ./local/volumes/log:/opt/emqx/log
      - ./local/volumes/data:/opt/emqx/data
      - ./local/users/add_users.sh:/bin/add_users.sh

volumes:
  mqtt-emqx-vod-dev-lib-v:
  mqtt-emqx-vod-dev-etc-v:
#  mqtt-emqx-vod-dev-log-v:
#  mqtt-emqx-vod-dev-data-v:

All these files and directories on the Docker Host belong to root:docker and all of them are also readable and traversable by others. The stuff under local is also writeable by others.
EMQ version
Which branch are you on? If you know the Git revision then add it here as well.
emqx/emqx           latest
Docker version
Docker version 18.09.7, build 2d0083d
How docker info?
docker info

Containers: 1
 Running: 0
 Paused: 0
 Stopped: 1
Images: 1
Server Version: 18.09.7
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host macvlan null overlay
 Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
Swarm: inactive
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: 894b81a4b802e4eb2a91d1ce216b8817763c29fb
runc version: 425e105d5a03fabd737a126ad93d62a9eeede87f
init version: fec3683
Security Options:
 seccomp
  Profile: default
Kernel Version: 3.10.0-957.21.3.el7.x86_64
Operating System: CentOS Linux 7 (Core)
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 7.777GiB
Name: mqtt.internal.graphicx.io
ID: 3JT3:4WRD:3DSK:565G:BFCZ:E4VO:EVK2:SUMD:MGZT:SV74:QPNE:5I3V
Docker Root Dir: /datadrive/var/lib/docker
Debug Mode (client): false
Debug Mode (server): false
Registry: https://index.docker.io/v1/
Labels:
Experimental: false
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false
Product License: Community Engine

WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled

System
CentOS 7
Hardware
standard modern Azrue VM

Also, it does not make a difference if I comment out the line with  EMQX_NODE__COOKIE: 9beqyAQGcWQ1FvSiLnf3 in docker-compose.yml

While the container is active, docker ps is
[sludwig@mqtt mqtt-emqx]$ docker ps
CONTAINER ID        IMAGE               COMMAND                  CREATED             STATUS              PORTS                                                                                NAMES
7296e871e13e        emqx/emqx           "/usr/bin/docker-ent…"   6 seconds ago       Up 5 seconds        4369/tcp, 5369/tcp, 6369/tcp, 11883/tcp, 18083/tcp, <IP_ADDRESS>:51883->1883/tcp, <IP_ADDRESS>:58080->8080/tcp, <IP_ADDRESS>:58083->8083/tcp, <IP_ADDRESS>:58084->8084/tcp, <IP_ADDRESS>:58883->8883/tcp   mqtt-emqx-vod-dev-c

I came one step further in this analysis. If I revert to using network_mode: host in docker-compose.yml the broker starts up and does not exist after about 30 seconds. (Note that reverting back to using Docker Volumes without mapping to the Docker Host local file system did not make a difference.)
version: '3'
services:

  mqtt-emqx-vod-dev-s:
    image: emqx/emqx
    container_name: mqtt-emqx-vod-dev-c
    environment:
      EMQX_LOADED_PLUGINS: "emqx_management,emqx_auth_username,emqx_recon,emqx_retainer,emqx_dashboard"
      EMQX_NAME: emqxvoddev1
      EMQX_HOST: <IP_ADDRESS>
#      EMQX_NODE__COOKIE: 9beqyAQGcWQ1FvSiLnf3
      EMQX_LOG__CONSOLE: console
      EMQX_ALLOW_ANONYMOUS: 'false'
#      EMQX_LISTENER__TCP__EXTERNAL: 51883
#      EMQX_LISTENER__SSL__EXTERNAL: 58883
#      EMQX_LISTENER__WS__EXTERNAL: 58083
#      EMQX_LISTENER__WSS__EXTERNAL: 58084
#      EMQX_LISTENER__API__MGMT: 58080
#    logging:
#      driver: gelf
#      options:
#        gelf-address: udp://<IP_ADDRESS>:12201
#        tag: mqtt-emqx-vod-dev
    network_mode: host
#    ports:
#      - "51883:1883"
#      - "58883:8883"
#      - "58083:8083"
#      - "58084:8084"
#      - "58080:8080"
    volumes:
      - mqtt-emqx-vod-dev-lib-v:/opt/emqx/lib
      - mqtt-emqx-vod-dev-etc-v:/opt/emqx/etc
      - mqtt-emqx-vod-dev-log-v:/opt/emqx/log
      - mqtt-emqx-vod-dev-data-v:/opt/emqx/data
#      - ./local/volumes/log:/opt/emqx/log
#      - ./local/volumes/data:/opt/emqx/data
      - ./local/users/add_users.sh:/bin/add_users.sh

volumes:
  mqtt-emqx-vod-dev-lib-v:
  mqtt-emqx-vod-dev-etc-v:
  mqtt-emqx-vod-dev-log-v:
  mqtt-emqx-vod-dev-data-v:

Specify image as emqx/emqx:v3.2.0 and remove EMQX_HOST to start normal

@sourcekick Just exactly same as I've met. I can normally run the emqx image without enviroment confiuration EMQX_NODE__NAME(or any configuration), but with this, the container died silently, and the logs are same with what you displayed

@PotatoGuo Can you share your environment configuration?

@zhanghongtong I just added -e<EMAIL_ADDRESS>

@PotatoGuo  The IP address in the EMQX_NODE__NAME  needs to be consistent with the IP address of the container, or else an exception error will result

@PotatoGuo You're welcome :)


Problem with extensions and Page.find_by_path

The new find_by_path method name is problematic when extensions define their own page types that override find_by_url because they won't be called.
This is how it is currently:
	class Page
	  def find_by_path
	    puts "Page.find_by_path"
	  end

	  alias_method :find_by_url, :find_by_path
	end

	class SubPage < Page
		def find_by_url
		  "SubPage.find_by_url"
		end
	end

	Page.new.find_by_path #=>Page.find_by_path
	SubPage.new.find_by_path #=>Page.find_by_path

See? When a subclass of Page overrode find_by_url, it will never be called. You have to put a reverse alias_method into your subclass to make it work:
	class Page
	  def find_by_path
	    puts "Page.find_by_path"
	  end

	  alias_method :find_by_url, :find_by_path
	end

	class SubPage < Page
		def find_by_url
		  puts "SubPage.find_by_url"
		end
		alias_method :find_by_path, :find_by_url
	end

	Page.new.find_by_path #=>Page.find_by_path
	SubPage.new.find_by_path #=>SubPage.find_by_url

We should fix this because we don't want to break extensions.
Update: I'm using this with the multi-site extension.

It turns out it was the multi_site extension. See: https://github.com/radiant/radiant-multi-site-extension/pull/7


INFRA-132 – stub Stripe and bypass captcha only with HTTP header X-Is-Load-Test

No more app-wide env vars for either testing feature

Codecov Report
Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.95%. Comparing base (ee43758) to head (71666a9).
Report is 4 commits behind head on develop.

Files with missing lines
Patch %
Lines

src/Application/Middleware/CorsMiddleware.php
0.00%
1 Missing :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #155   +/-   ##
========================================
  Coverage    68.95%   68.95%
========================================
  Files           40       40
  Lines          889      889
========================================
  Hits           613      613
  Misses         276      276

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Getting request error

:exclamation:  DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE :exclamation:
lack of information will lead to closure of the issue

Describe the bug
Im getting an error while trying to download any kind of youtube videos
ERROR: This request has been detected as a bot, please try again or log in to view

code that was used that resulted in the bug
from pytubefix import YouTube
from pytubefix.cli import on_progress

url = "https://youtu.be/JNHUHaUwk-M?si=gWCyQRuW1A_rhEub"

yt = YouTube(url, on_progress_callback = on_progress)
print(yt.title)

ys = yt.streams.get_highest_resolution()
ys.download()

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
https://prnt.sc/ektTNmSmOW1Q

Desktop (please complete the following information):

OS: Ubuntu 20.04
Python Version 3.8.10
Pytubefix Version 6.13.1

Additional context
Add any other context about the problem here.

see #170


[WFCORE-4937] Upgrade FasterXML Jackson to 2.10.4

https://issues.redhat.com/browse/WFCORE-4937

Core - Full Integration Build 9668 outcome was FAILURE using a merge of 01a90c2ee086c8ae04327bc7648b3aebde7836a1
Summary: Execution timeout (new); tests failed: 2 (2 new), passed: 6527, ignored: 105 Build time: 05:01:12
Failed tests
org.jboss.as.test.manualmode.messaging.ha.ReplicatedFailoverTestCase.testBackupActivation: javax.jms.JMSRuntimeException: AMQ219016: Connection failure detected. Unblocking a blocking call that will never get a response
	at org.apache.activemq.artemis.jms.client.JmsExceptionUtils.convertToRuntimeException(JmsExceptionUtils.java:88)
	at org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory.createContext(ActiveMQConnectionFactory.java:326)
	at org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory.createContext(ActiveMQConnectionFactory.java:314)
	at org.jboss.as.test.manualmode.messaging.ha.AbstractMessagingHATestCase.receiveMessage(AbstractMessagingHATestCase.java:196)
	at org.jboss.as.test.manualmode.messaging.ha.FailoverTestCase.testBackupActivation(FailoverTestCase.java:98)
Caused by: javax.jms.JMSException: AMQ219016: Connection failure detected. Unblocking a blocking call that will never get a response
	at org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:464)
	at org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:358)
	at org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.addSessionMetadata(ActiveMQSessionContext.java:478)
	at org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.addMetaData(ClientSessionImpl.java:1470)
	at org.apache.activemq.artemis.jms.client.ActiveMQConnection.addSessionMetaData(ActiveMQConnection.java:704)
	at org.apache.activemq.artemis.jms.client.ActiveMQConnection.authorize(ActiveMQConnection.java:694)
	at org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory.createConnectionInternal(ActiveMQConnectionFactory.java:920)
	at org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory.createContext(ActiveMQConnectionFactory.java:321)
	... 133 more
Caused by: ActiveMQUnBlockedException[errorType=UNBLOCKED message=AMQ219016: Connection failure detected. Unblocking a blocking call that will never get a response]
	... 141 more
Caused by: ActiveMQDisconnectedException[errorType=DISCONNECTED message=AMQ219015: The connection was disconnected because of server shutdown]
	at org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:1018)
	at org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
	at org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
	at org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
------- Stdout: -------
 [0m09:00:27,800 INFO  [org.jboss.modules] (main) JBoss Modules version 1.10.0.Final
 [0m [0m09:00:28,572 INFO  [org.jboss.msc] (main) JBoss MSC version 1.4.11.Final
 [0m [0m09:00:28,596 INFO  [org.jboss.threads] (main) JBoss Threads version 2.3.3.Final
 [0m [0m09:00:28,873 INFO  [org.jboss.as] (MSC service thread 1-2) WFLYSRV0049: WildFly Full 20.0.0.Beta1-SNAPSHOT (WildFly Core 12.0.0.Beta4-SNAPSHOT) starting
 [0m [0m09:00:30,721 INFO  [org.wildfly.security] (ServerService Thread Pool -- 29) ELY00001: WildFly Elytron version 1.12.0.CR3
 [0m [0m09:00:32,817 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/core-service=management/management-interface=http-interface' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
 [0m [0m09:00:32,887 INFO  [org.jboss.as.controller.management-deprecated] (ServerService Thread Pool -- 32) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
 [0m [0m09:00:33,189 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m09:00:33,244 INFO  [org.xnio] (MSC service thread 1-2) XNIO version 3.8.1.Final
 [0m [0m09:00:33,274 INFO  [org.xnio.nio] (MSC service thread 1-2) XNIO NIO Implementation Version 3.8.1.Final
 [0m [0m09:00:33,388 INFO  [org.jboss.remoting] (MSC service thread 1-4) JBoss Remoting version 5.0.18.Final
 [0m [0m09:00:33,492 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 61) WFLYRS0016: RESTEasy version 3.12.0.Final
 [0m [33m09:00:33,501 WARN  [org.jboss.as.txn] (ServerService Thread Pool -- 86) WFLYTX0013: The node-identifier attribute on the /subsystem=transactions is set to the default value. This is a danger for environments running multiple servers. Please make sure the attribute value is unique.
 [0m [0m09:00:33,541 INFO  [org.jboss.as.naming] (ServerService Thread Pool -- 77) WFLYNAM0001: Activating Naming Subsystem
 [0m [0m09:00:33,572 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 59) WFLYCLINF0001: Activating Infinispan subsystem.
 [0m [0m09:00:33,553 INFO  [org.wildfly.extension.microprofile.config.smallrye._private] (ServerService Thread Pool -- 71) WFLYCONF0001: Activating WildFly MicroProfile Config Subsystem
 [0m [0m09:00:33,562 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 64) WFLYCLJG0001: Activating JGroups subsystem. JGroups version 4.2.3
 [0m [0m09:00:33,555 INFO  [org.jboss.as.jsf] (ServerService Thread Pool -- 67) WFLYJSF0007: Activated the following JSF Implementations: [main]
 [0m [0m09:00:33,619 INFO  [org.wildfly.extension.microprofile.jwt.smallrye._private] (ServerService Thread Pool -- 73) WFLYJWT0001: Activating WildFly MicroProfile JWT Subsystem
 [0m [0m09:00:33,652 INFO  [org.wildfly.extension.microprofile.metrics.smallrye] (ServerService Thread Pool -- 74) WFLYMETRICS0001: Activating Eclipse MicroProfile Metrics Subsystem
 [0m [0m09:00:33,707 INFO  [org.wildfly.extension.microprofile.opentracing] (ServerService Thread Pool -- 75) WFLYTRACEXT0001: Activating MicroProfile OpenTracing Subsystem
 [0m [0m09:00:33,735 INFO  [org.jboss.as.webservices] (ServerService Thread Pool -- 88) WFLYWS0002: Activating WebServices Extension
 [0m [0m09:00:33,751 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 50) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 1.4)
 [0m [0m09:00:33,786 INFO  [org.wildfly.extension.microprofile.health.smallrye] (ServerService Thread Pool -- 72) WFLYHEALTH0001: Activating Eclipse MicroProfile Health Subsystem

org.jboss.as.test.manualmode.messaging.ha.ReplicatedFailoverTestCase.testBackupFailoverAfterFailback: 	at org.jboss.as.test.manualmode.messaging.ha.AbstractMessagingHATestCase.receiveMessage(AbstractMessagingHATestCase.java:200)
	at org.jboss.as.test.manualmode.messaging.ha.FailoverTestCase.testBackupFailoverAfterFailback(FailoverTestCase.java:147)
------- Stdout: -------
 [0m09:02:21,818 INFO  [org.jboss.modules] (main) JBoss Modules version 1.10.0.Final
 [0m [0m09:02:22,429 INFO  [org.jboss.msc] (main) JBoss MSC version 1.4.11.Final
 [0m [0m09:02:22,453 INFO  [org.jboss.threads] (main) JBoss Threads version 2.3.3.Final
 [0m [0m09:02:22,733 INFO  [org.jboss.as] (MSC service thread 1-2) WFLYSRV0049: WildFly Full 20.0.0.Beta1-SNAPSHOT (WildFly Core 12.0.0.Beta4-SNAPSHOT) starting
 [0m [0m09:02:24,492 INFO  [org.wildfly.security] (ServerService Thread Pool -- 30) ELY00001: WildFly Elytron version 1.12.0.CR3
 [0m [0m09:02:26,194 INFO  [org.jboss.as.controller.management-deprecated] (Controller Boot Thread) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/core-service=management/management-interface=http-interface' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
 [0m [0m09:02:26,306 INFO  [org.jboss.as.controller.management-deprecated] (ServerService Thread Pool -- 43) WFLYCTL0028: Attribute 'security-realm' in the resource at address '/subsystem=undertow/server=default-server/https-listener=https' is deprecated, and may be removed in a future version. See the attribute description in the output of the read-resource-description operation to learn more about the deprecation.
 [0m [0m09:02:26,541 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m09:02:26,591 INFO  [org.xnio] (MSC service thread 1-5) XNIO version 3.8.1.Final
 [0m [0m09:02:26,626 INFO  [org.xnio.nio] (MSC service thread 1-5) XNIO NIO Implementation Version 3.8.1.Final
 [0m [0m09:02:26,764 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 59) WFLYCLINF0001: Activating Infinispan subsystem.
 [0m [0m09:02:26,863 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 61) WFLYRS0016: RESTEasy version 3.12.0.Final
 [0m [0m09:02:26,916 INFO  [org.jboss.remoting] (MSC service thread 1-3) JBoss Remoting version 5.0.18.Final
 [0m [0m09:02:26,916 INFO  [org.wildfly.extension.io] (ServerService Thread Pool -- 60) WFLYIO001: Worker 'default' has auto-configured to 8 IO threads with 64 max task threads based on your 4 available processors
 [0m [0m09:02:26,927 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 64) WFLYCLJG0001: Activating JGroups subsystem. JGroups version 4.2.3
 [0m [0m09:02:26,915 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 50) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 1.4)
 [0m [33m09:02:26,883 WARN  [org.jboss.as.txn] (ServerService Thread Pool -- 86) WFLYTX0013: The node-identifier attribute on the /subsystem=transactions is set to the default value. This is a danger for environments running multiple servers. Please make sure the attribute value is unique.
 [0m [0m09:02:26,901 INFO  [org.wildfly.extension.microprofile.jwt.smallrye._private] (ServerService Thread Pool -- 73) WFLYJWT0001: Activating WildFly MicroProfile JWT Subsystem
 [0m [0m09:02:26,979 INFO  [org.wildfly.extension.microprofile.metrics.smallrye] (ServerService Thread Pool -- 74) WFLYMETRICS0001: Activating Eclipse MicroProfile Metrics Subsystem
 [0m [0m09:02:26,996 INFO  [org.wildfly.extension.microprofile.config.smallrye._private] (ServerService Thread Pool -- 71) WFLYCONF0001: Activating WildFly MicroProfile Config Subsystem
 [0m [0m09:02:26,995 INFO  [org.jboss.as.security] (ServerService Thread Pool -- 83) WFLYSEC0002: Activating Security Subsystem
 [0m [0m09:02:27,017 INFO  [org.jboss.as.security] (MSC service thread 1-5) WFLYSEC0001: Current PicketBox version=5.0.3.Final-redhat-00005
 [0m [0m09:02:27,038 INFO  [org.jboss.as.webservices] (ServerService Thread Pool -- 88) WFLYWS0002: Activating WebServices Extension
 [0m [0m09:02:27,047 INFO  [org.wildfly.iiop.openjdk] (ServerService Thread Pool -- 58) WFLYIIOP0001: Activating IIOP Subsystem
 [0m [0m09:02:27,051 INFO  [org.wildfly.extension.microprofile.opentracing] (ServerService Thread Pool -- 75) WFLYTRACEXT0001: Activating MicroProfile OpenTracing Subsystem
 [0m [0m09:02:27,056 INFO  [org.jboss.as.naming] (ServerService Thread Pool -- 77) WFLYNAM0001: Activating Naming Subsystem
 [0m [0m09:02:27,090 INFO  [org.jboss.as.connector] (MSC service thread 1-7) WFLYJCA0009: Starting JCA Subsystem (WildFly/IronJacamar 1.4.22.Final)
 [0m [0m09:02:27,149 INFO  [org.wildfly.extension.microprofile.health.smallrye] (ServerService Thread Pool -- 72) WFLYHEALTH0001: Activating Eclipse MicroProfile Health Subsystem
 [0m [0m09:02:27,195 INFO  [org.jboss.as.connector.deployers.jdbc] (MSC service thread 1-6) WFLYJCA0018: Started Driver service with driver-name = h2
 [0m [0m09:02:27,186 INFO  [org.jboss.as.jsf] (ServerService Thread Pool -- 67) WFLYJSF0007: Activated the following JSF Implementations: [main]
 [0m [0m09:02:27,365 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0003: Undertow 2.1.1.Final starting
 [0m [0m09:02:27,779 INFO  [org.jboss.as.naming] (MSC service thread 1-4) WFLYNAM0003: Starting Naming Service
 [0m [0m09:02:27,840 INFO  [org.jboss.as.mail.extension] (MSC service thread 1-2) WFLYMAIL0001: Bound mail session [java:jboss/mail/Default]
 [0m [0m09:02:28,122 INFO  [org.jboss.as.ejb3] (MSC service thread 1-3) WFLYEJB0481: Strict pool slsb-strict-max-pool is using a max instance size of 64 (per class), which is derived from thread worker pool sizing.
 [0m [0m09:02:28,122 INFO  [org.wildfly.extension.undertow] (ServerService Thread Pool -- 87) WFLYUT0014: Creating file handler for path '/store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/manualmode/target/jbossas-messaging-ha-server1/welcome-content' with options [directory-listing: 'false', follow-symlink: 'false', case-sensitive: 'true', safe-symlink-paths: '[]']
 [0m [0m09:02:28,133 INFO  [org.jboss.as.ejb3] (MSC service thread 1-2) WFLYEJB0482: Strict pool mdb-strict-max-pool is using a max instance size of 16 (per class), which is derived from the number of CPUs on this host.
 [0m [0m09:02:28,155 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-1) WFLYUT0012: Started server default-server.
 [0m [0m09:02:28,165 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-1) WFLYUT0018: Host default-host starting
 [0m [0m09:02:28,420 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-3) WFLYUT0006: Undertow AJP listener ajp listening on [::1]:8009
 [0m [0m09:02:28,421 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-8) WFLYUT0006: Undertow HTTP listener default listening on [::1]:8080
 [0m [0m09:02:28,503 INFO  [org.jboss.modcluster] (ServerService Thread Pool -- 90) MODCLUSTER000001: Initializing mod_cluster version 1.4.1.Final
 [0m [0m09:02:28,574 INFO  [org.jboss.modcluster] (ServerService Thread Pool -- 90) MODCLUSTER000032: Listening to proxy advertisements on /ff13:0:0:0:0:0:0:1:23364
 [0m [0m09:02:28,818 INFO  [org.jboss.as.ejb3] (MSC service thread 1-6) WFLYEJB0493: EJB subsystem suspension complete
 [0m [33m09:02:28,833 WARN  [org.jgroups.conf.XmlConfigurator] (ServerService Thread Pool -- 90) version is missing in the configuration file
 [0m [0m09:02:28,956 INFO  [org.jboss.as.patching] (MSC service thread 1-2) WFLYPAT0050: WildFly Full cumulative patch ID is: base, one-off patches include: none
 [0m [33m09:02:29,376 WARN  [org.jboss.as.domain.management.security] (MSC service thread 1-6) WFLYDM0111: Keystore /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/manualmode/target/jbossas-messaging-ha-server1/standalone/configuration/application.keystore not found, it will be auto generated on first use with a self signed certificate for host localhost
 [0m [0m09:02:29,467 INFO  [org.jboss.as.server.deployment.scanner] (MSC service thread 1-8) WFLYDS0013: Started FileSystemDeploymentService for directory /store/work/tc-work/37b47ae8b9c60325/full/testsuite/integration/manualmode/target/jbossas-messaging-ha-server1/standalone/deployments
 [0m [0m09:02:29,570 INFO  [org.wildfly.iiop.openjdk] (MSC service thread 1-7) WFLYIIOP0009: CORBA ORB Service started


[1.809 Alpha] Limited text fields on various items

Description text fields on various item types cut off (Talents, Armour)

Done, will be released in 1.809. Thanks for the help testing.


cannot import name 'InstanceOf' from 'pydantic

Running on Databricks with the following cluster-level library versions:
crewai==0.28.8
crewai_tools==0.1.6
langchain_community==0.0.29
pydantic==1.8.2
pyspark==3.5.1
When I run the command below, I get the ImportError shown. Any ideas on how to fix this issue?
from crewai import Agent, Task, Crew
ImportError: cannot import name 'InstanceOf' from 'pydantic' (/databricks/python/lib/python3.11/site-packages/pydantic/init.cpython-311-x86_64-linux-gnu.so)

A fresh notebook solved this issue.


Finally swap out the backend to use markdown it

and some other things i havent merged

Finally woo. Shit. That was brutal. There is a bug in IPython somewhere on the async side.


☂ Update CI to Xcode 14.3

Xcode 14.3 is the "E" spring release of Xcode and is usually involves larger changes than other minor versions.  We've already seen some behavior changes reported that caused breakages and required hotfixes like https://github.com/flutter/flutter/issues/123890.  Update version in CI to see what other failures are hit.

[x] Upload cipd package 14e222b https://chrome-infra-packages.appspot.com/p/flutter_internal/ios/xcode/ios/+/14e222b.

Framework

[x] https://github.com/flutter/flutter/pull/125716
[ ] https://github.com/flutter/flutter/issues/125812
[x] https://github.com/flutter/flutter/issues/125817

Packages

[x] https://github.com/flutter/packages/pull/3868
[x] https://github.com/flutter/packages/pull/3873
[x] https://github.com/flutter/flutter/issues/125918

Engine

[x] https://github.com/flutter/engine/pull/41640

We added a workaround with todos in the framework and packages to get around https://github.com/flutter/flutter/issues/125812, that infra issue can be tracked separately.  Closing this ☂ issue.
Thanks @cyanglaz and @vashworth!


Rebirth

Moving client from yggdrasil to vilive.

@copenhas This should be it for transplanting ember into vilive.
Code coverage is hooked up and put the badges in from master, so once this in master those badges should update and reflect the coverage of this branch (low actually, like 30%)


If condition i + 1 < n not allowed

Currently, you have to type:
if (i + 1) < n {

}

The i + 1 expression is not allowed in the syntax as argument to comparison operator.

Perhaps this is not a bad idea after all. It makes it easier to read the code.
Closing for now.


Scala Hadoop Shred: upgrade to Hadoop 2.4

Strangely the Hadoop Shred can work on Hadoop 2.4 even without updating (maybe because it uses such a small subset of Cascading functionality?). But we will need this for #1481

@fblundun - this would be a great one to explore first...


Zarr Sink Frame Values

Resolves #1325
The following video demonstrates the value labels on axis sliders for a randomly-generated image using the new Zarr sink API.
C and Z have uniform values, while T has non-uniform values. (This image was generated with the code in testFrameValues in test/test_sink.py.)
https://github.com/user-attachments/assets/4b41bcd3-8164-46f8-b78b-9d919cecefa0

[ ] Still needs documentation changes

If you have a multi-band tile and specify a c_value, it doesn't work as expected.  That is
ts = large_image.new()
ts.addTile(np.zeros((100, 100, 3)), x=0, y=0, c=0, z=0, z_value=1, c_value='DAPI')
ts.addTile(np.zeros((100, 100, 3)), x=0, y=0, c=1, z=0, z_value=1, c_value='CD4')

fails, but without the c_value succeeds.

Another use case I was expecting to work:
ts = large_image.new()
ts.addTile(np.zeros((100, 100, 1)), x=0, y=0, z=0, z_value=1)
ts.addTile(np.zeros((100, 100, 1)), x=0, y=0, z=1, z_value=3.2)
ts.addTile(np.zeros((100, 100, 1)), x=0, y=0, z=2, z_value=6.4)
ts.addTile(np.zeros((100, 100, 1)), x=0, y=0, z=2, z_value=6.3, c=1)

The first two snippets you provided have been added as a pytest and fixed in c85ebf0.
The third snippet you provide is a use case that is already not supported by the addTile function. The current implementation of addTile requires that all axes are declared upon the first call, and a user cannot add new axes later. While outside the scope of this PR, this use case is reasonable and should be addressed in another PR. I have created #1674 to track this.

I had another example that had been failing during addTile, but with the latest changes now fails when getting the metadata:
ts = large_image.new()
ts.addTile(np.zeros((100, 100, 3)), x=0, y=0, c=0, z=0, z_value=1, c_value='DAPI')
ts.addTile(np.zeros((100, 100, 3)), x=0, y=0, c=0, z=1, z_value=3.2, c_value='DAPI')
ts.addTile(np.zeros((100, 100, 3)), x=0, y=0, c=0, z=2, z_value=6.3, c_value='DAPI')
ts.addTile(np.zeros((100, 100, 3)), x=0, y=0, c=1, z=2, z_value=6.4, c_value='CD4')
ts.addTile(np.zeros((100, 100, 3)), x=0, y=0, c=1, z=1, z_value=3.1, c_value='CD4')
ts.addTile(np.zeros((100, 100, 3)), x=0, y=0, c=0, z=1, z_value=1.1)
pprint.pprint(ts.metadata)

My guess is that this is due to unpopulated values in some combinations.

Currently, the metadata entries for Value<axis> is in the zarr source code.  I think it would be better to move it to the _addMetadataFrameInformation method in the base class so if these values are populated in frames in non-zarr sources, the aggregated values will still be added to the metadata.

Should we cast the values stored in each frame to native python float or int datatypes rather than leave them as numpy data types?  As long as the native numpy data types serialize to json, it probably doesn't matter, but for consistency between sources, we may want to do the cast.

I'd like to have issues for two follow ups to this PR:

Setting values in multiple processes doesn't appear in the final result.  That is, I think only the last process to white the zarr has sets values.

The display precision should probably be limited to some number of significant digits.  For instance, in a test example I get

@manthey Since the value precision for the labels is a quick fix, I added that change in e41e125. We can address the multiprocessing case in a follow-up PR as you suggested. I made this issue to track it: #1698.


fix: revert to using importlib for dynamic module loading

Fixes #325
This is the method for dynamic module loading used in the tag job - the getattr method looks cleaner, but is failing at runtime (but not test time?)
See https://github.com/googleapis/releasetool/pull/314#discussion_r620607966

I will followup with more tests to figure out why our tests did not catch this, but will merge this first to unblock our releases.


ER_CON_COUNT_ERROR: Too many connections

Environment
Knex version:
Database + version:
OS:
Select applicable template from below.
If issue is about oracledb support, tag @ atiertant. For MSSql tag @ smorey2.
Rest of dialects don't need tags.
If issue is about TypeScript definitions, tag @ lorefnon.
Bug

Explain what kind of behaviour you are getting and how you think it should do

Error message

Reduced test code, for example in https://npm.runkit.com/knex or if it needs real
database connection to MySQL or PostgreSQL, then single file example which initializes
needed data and demonstrates the problem.

Feature discussion / request

Explain what is your use case

Explain what kind of feature would support this

Give some API proposal, how the feature should work

Missing / erroneus documentation
Send issue to documentation repo, or fix it and send PR https://github.com/knex/documentation
Questions about how to use knex
GitHub issues are for knex development. Please send questions how to use knex to
Stack Overflow or ask about it in gitter chat.

Getting ER_CON_COUNT_ERROR: Too many connections error.. knex+mysql

Sounds like you are doing something wrong. If you think there is a but in knex, provide reproduction code and write proper bug report.


Excepted got "/" (Comment support)

In principle, the JSON5 standard:
https://spec.json5.org/#comments
Of course, one could argue about how standard it is, but for example Json.NET supports it: https://www.newtonsoft.com/json
I don't think it's too complicated to implement, you just have to ignore it when reading:
// This is a single line comment.
/* This is a multi-
line comment. */

Hi,
Could you check if fcl-json supports comments?
In my initial research, this was discarded because Delphi's System.JSON does not support comments.

Hi!
I don't think so, and I really don't, it throws an error:
uses
fpjson, jsonparser;
{$R *.lfm}
procedure TForm1.Button1Click(Sender: TObject);
var
jData : TJSONData;
begin
jData := GetJSON('//');
end;

It seems comments are controversial already.
On the other hand, I think you can parse and exclude comments before using McJSON or any other library.
Regards,

I think it is very easy to identify the two types of comments, and the library would not throw them away if they came across them. But I understand your point and thanks for the reply!

I think I can create a new method called readComment() and then jump.
What complicates it is that comments could occur anywhere, so I have to check how many calls of this new method would be needed and also how to handle syntax errors due to comments.
I think that's why many libraries leave this aspect out.

I thought you were reading lines when reading from a file. Only the first two characters should be examined. It's true that a row can contain multiple keys and values, but I don't think the comment makes sense within a row. Of course, you have a better understanding of how your code works.
"Does Lazarus' fcl-json not meet your needs? I'm curious why McJSON seems more important to you than a native library."
I process around 1000 json files with tens of thousands of keys, speed is also important, and I saw the speed test that this library is very good (see readme) and fully supports Lazarus, so why not use it? :)

Actually, after some reading:

JSON does not have comments.

So, I'll close this issue.
Thanks.

Okay, but see the my first comment. :) Thanks for taking care of it!

I saw your first comment, but I recommend you see this.


Add an example of local control plane by docker-compose

What this PR does / why we need it:
Add an example of building a control plane locally by docker-compose
in order to enable users to experiment control plane / piped easily.
The codes are based on @kevin-namba 's https://github.com/pipe-cd/pipecd/pull/4139

📝 talked in the public meeting

We will new repo to locate the docker compose file
For a demo, we should avoid locating it to the main repo

First, Add each component  README link to the CONTRIBUTING.md
Later, let’s discuss more about the improvement


FTP file gets deleted when drag and drop from file explorer

VSCode Version: 1.10.1
OS Version: Windows 10 Home 1607

Steps to Reproduce:

Open file explorer
Open any ftp folder

Drag an drop any file from FIle Explorer into VSCode
The dragged file gets removed from FTP folder, but it is not openend in VSCode

@BrunnerLivio we never delete a file when importing via DND, the file must still be there. Can you double check?


AttributeError: 'list' object has no attribute 'numel'

🐛 Bug

To Reproduce
Steps to reproduce the behavior:

Expected behavior
Traceback (most recent call last):
File "/home/hyh/software/pycharm-community-2021.2.1/plugins/python-ce/helpers/pydev/pydevd.py", line 1483, in exec
pydev_imports.execfile(file, globals, locals)  # execute the script
File "/home/hyh/software/pycharm-community-2021.2.1/plugins/python-ce/helpers/pydev/pydev_imps/pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "/home/hyh/Code/python/CL/CL_OBJECT_DETECTION/copy/maskrcnn-benchmark/tools/train_net.py", line 266, in
main()
File "/home/hyh/Code/python/CL/CL_OBJECT_DETECTION/copy/maskrcnn-benchmark/tools/train_net.py", line 259, in main
model = train(cfg, args.local_rank, args.distributed)
File "/home/hyh/Code/python/CL/CL_OBJECT_DETECTION/copy/maskrcnn-benchmark/tools/train_net.py", line 157, in train
do_train(model, data_loader, optimizer, scheduler, checkpointer, device, checkpoint_period, arguments, summary_writer)
File "/home/hyh/Code/python/CL/CL_OBJECT_DETECTION/copy/maskrcnn-benchmark/tools/train_net.py", line 77, in do_train
loss_dict,,,,_ = model(images, targets)
File "/home/hyh/anaconda3/envs/maskrcnn/lib/python3.8/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/hyh/anaconda3/envs/maskrcnn/lib/python3.8/site-packages/apex-0.1-py3.8-linux-x86_64.egg/apex/amp/_initialize.py", line 196, in new_fwd
output = old_fwd(*applier(args, input_caster),
File "/home/hyh/Code/python/CL/CL_OBJECT_DETECTION/copy/maskrcnn-benchmark/maskrcnn_benchmark/modeling/detector/generalized_rcnn.py", line 62, in forward
features, backbone_features = self.backbone(images.tensors)
File "/home/hyh/anaconda3/envs/maskrcnn/lib/python3.8/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/hyh/anaconda3/envs/maskrcnn/lib/python3.8/site-packages/torch/nn/modules/container.py", line 117, in forward
input = module(input)
File "/home/hyh/anaconda3/envs/maskrcnn/lib/python3.8/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/hyh/Code/python/CL/CL_OBJECT_DETECTION/copy/maskrcnn-benchmark/maskrcnn_benchmark/modeling/backbone/fpn.py", line 51, in forward
last_inner = getattr(self, self.inner_blocks[-1])(x[-1])
File "/home/hyh/anaconda3/envs/maskrcnn/lib/python3.8/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
result = self.forward(*input, **kwargs)
File "/home/hyh/Code/python/CL/CL_OBJECT_DETECTION/copy/maskrcnn-benchmark/maskrcnn_benchmark/layers/misc.py", line 32, in forward
if x.numel() > 0:
AttributeError: 'list' object has no attribute 'numel'
Process finished with exit code 1
Environment
Please copy and paste the output from the
environment collection script from PyTorch
(or fill out the checklist below manually).
You can get the script and run it with:
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py

PyTorch Version (e.g., 1.0):1.6.0
OS (e.g., Linux):ubuntu
How you installed PyTorch (conda, pip, source):conda
Build command you used (if compiling from source):--config-file "/home/hyh/Code/python/CL/CL_OBJECT_DETECTION/copy/maskrcnn-benchmark/configs/e2e_mask_rcnn_R_50_FPN_1x.yaml" SOLVER.IMS_PER_BATCH 2 SOLVER.BASE_LR 0.0025 SOLVER.MAX_ITER 720000 SOLVER.STEPS "(480000, 640000)" TEST.IMS_PER_BATCH 1 MODEL.RPN.FPN_POST_NMS_TOP_N_TRAIN 2000
Python version:3.8
CUDA/cuDNN version:10.1
GPU models and configuration:GTX2080
Any other relevant information:

Additional context

I don't understand why such a mistake happened. If someone can help me, I'm very grateful

Did you solve this problem, I have the same problem


Update routing.md spelling error

Fixed spelling error "calllback" to "callback"

Thanks @johnw424!


light theme

if you would, pretty please, make a proper light theme colour palette (because right now that one just seems to be copy paste of the dark one, which obviously doesn't work)

This is a quick Light theme I made for myself by inverting the colors using www.realtimecolors.com. The only Issue was that the code block background looks funky.
.theme-light {
  --background-primary: #C1C7DC;
  --background-secondary: #CCCFE1;
  --background-secondary-alt: #D1D7E6;
  --background-tertiary: #E0E3F0;
  --background-accent: #253C8D;
  --background-modifier-hover: #e0e0e0;
  --background-modifier-active: #c0c0c0;
  --modal-background: var(--background-primary);
  --header-primary: #000000;
  --header-secondary: #666666;
  --text-normal: #333333;
  --channeltextarea-background: #D1D7E6;
  --deprecated-card-bg: #12141f63;
}


Helm commands dump the environment to logs

When running at --info logging level any helm commands that the plugin runs will dump the environment to the logs before helm is launched. In a container environment this a security issue because it's common practice to inject credentials into containers using environment variables.

Can you please copy paste the logs which you are disucssing so we can find what is putting out those logs?

Had a look at your PR.
My opinion is that secrets should be mounted as files in a container and not envieonmennt variables.
You can see artilcle about this here.
That being said I appreciate your motivation to quickly fix this issue.
I looked at your PR as well. The issue with it is that if users dont  opt in their credentials might  be leaked in the logs.
I would prefer if we figure out which , if any, environment variables are configured by the plugin , and only log those, obustuficating ones that might have credentials.

Had a look at your PR.

Thank you.

My opinion is that secrets should be mounted as files in a container and not envieonmennt variables.

I agree, but I'm sure that since you also work for a very large org (this is my personal account) then you'll know that we don't always get to fix everything in our environment. A lot of the time we just have to work with what the org has either bought or developed with teams that aren't motivated/budgeted to make changes for us.

I looked at your PR as well. The issue with it is that if users dont opt in their credentials might be leaked in the logs.

If the default were opt-in then this could be a breaking change. I can imagine someone somewhere scraping build logs to build stuff like Splunk dashboards. Making it opt-in, at least to begin with, allows it to be introduced first as a patch release.

I would prefer if we figure out which , if any, environment variables are configured by the plugin , and only log those, obustuficating ones that might have credentials.

That would be the ideal solution.


Choose: Cookies or JWTs?

Watch:

https://www.youtube.com/watch?v=o9hT7v0OLJc
https://www.youtube.com/watch?v=UBUNrFtufWo

Complete - JWT


fatal error: 'cblas.h' file not found

I just installed Python on macOS 10.15.2 using the pip install pythran comamnd. I couldn't find the ~/.pythranrc file that the doc suggests. Anyways, I created the dprod.py example from the doc and this is the error I get after running pythran dprod.py:
/var/folders/_s/vr495ns10fvcp4xqygfz9wlm0000gn/T/tmpol6pr8ua/source.c:1:10: fatal error: 'cblas.h' file not found
#include <cblas.h>
         ^~~~~~~~~
1 error generated.

You need to install blas and make sure pythran knows about it.
One way:
$ pip install pythran-openblas
$ printf '[compiler]\nblas=pythran-openblas\n' > ~/.pythranrc

Note that this will install static libraries
Another way
$ brew install openblas
$  printf '[compiler]\nblas=openblas\n' > ~/.pythranrc

This will install dynamic libraries, but I'm not 100% of the location they are installed to. You may need to update ~/.pythranrc with
include_dirs=/path/to/openblas/header
library_dirs=/path/to/openblas/libraries

Please let me know if that works for you!

There an issue with the pip version, so I went with brew.
This is the output after the installation is done:
openblas is keg-only, which means it was not symlinked into /usr/local,
because macOS provides BLAS and LAPACK in the Accelerate framework.

For compilers to find openblas you may need to set:
  export LDFLAGS="-L/usr/local/opt/openblas/lib"
  export CPPFLAGS="-I/usr/local/opt/openblas/include"

For pkg-config to find openblas you may need to set:
  export PKG_CONFIG_PATH="/usr/local/opt/openblas/lib/pkgconfig"

==> Summary
🍺  /usr/local/Cellar/openblas/0.3.7: 22 files, 120.2MB, built in 16 minutes 30 seconds
==> Caveats
==> openblas
openblas is keg-only, which means it was not symlinked into /usr/local,
because macOS provides BLAS and LAPACK in the Accelerate framework.

For compilers to find openblas you may need to set:
  export LDFLAGS="-L/usr/local/opt/openblas/lib"
  export CPPFLAGS="-I/usr/local/opt/openblas/include"

For pkg-config to find openblas you may need to set:
  export PKG_CONFIG_PATH="/usr/local/opt/openblas/lib/pkgconfig"

Could you please help me what should I put in ~/.pythranrc based on it?

include_dirs=/usr/local/opt/openblas/include
library_dirs=/usr/local/opt/openblas/lib

should do the trick, based on your log.


I'll use staging as the base branch in the future


Failed to set parking heater mode to off[BUG]

Environment

skodaconnect release with the issue: v1.0.30-rc7
Last working homeassistant-skodaconnect release (if known): v1.0.30-rc5
Home Assistant Core release with the issue: core-2021.1.5
Operating environment (Home Assistant/Supervised/Docker/venv): Home Assistant OS 5.10
Car model and year: Super 2018
Valid We Connect subscription: Yes
Debug logs enabled: Yes

Describe the bug

When attempting to deactivate the preheater an error occurs stating that there is an invalid or no response and then failure to execute.
Steps to Reproduce

Toggle the switch for disabling the pre heater.
Expected behavior

It should be deactivated
Screenshots

Some additional log ocurrances too
Traceback/Error logs

DEBUG (MainThread) [skodaconnect.connection] HTTP POST "https://msg.volkswagen.de/fs-car/bs/rs/v1/skoda/CZ/vehicles/vin-goes-here/action"
ERROR (MainThread) [skodaconnect.connection] Failure to execute:
WARNING (MainThread) [skodaconnect.vehicle] Failed to set parking heater mode to off - Invalid or no response
  File "/config/custom_components/skodaconnect/switch.py", line 38, in async_turn_off
  File "/usr/local/lib/python3.8/site-packages/skodaconnect/dashboard.py", line 530, in turn_off
  File "/usr/local/lib/python3.8/site-packages/skodaconnect/vehicle.py", line 407, in set_pheater

Additional context

This was definitely working in RC5?
And start preheater works in RC7?
Then it's a simple diff to see what I changed that might have botched it. Always tricky with preheater since it's "legacy" API and I can't test it myself.

@Farfar Just reinstalled RC5 and it doesn't work there either, which makes me wonder if it really did work before.
I´m pretty sure that it did work then since i wrote that in a comment before the weekend. https://github.com/lendy007/homeassistant-skodaconnect/issues/8#issuecomment-769163737

The error handling changed the last couple of RC releases since it was a hassle trying to get exceptions carried correctly and informative. Could be som typo somewhere.
It's interesting though this part:

ERROR (MainThread) [skodaconnect.connection] Failure to execute:

Since the error is blank there's an exception but no message which is weird. It might be that a HTTP error occured since there's not, or isn't a need for, as extensive error handling for set functions as with get. It's enough to know if set succeeded or failed.
What might be an issue is that the SPIN token is generated and sent for both start and stop pre heater, it was previously only for start but preventing it from being generated for 'stop' would need more checks and I didn't think it was necessary.
Do you have access to the skodaconnect/connection.py file? If so you can change line 829 from:
            self._session_headers['x-mbbSecToken'] = await self.get_sec_token(vin = vin, spin = spin, action = 'heating')

to:
            if not 'quickstop' in data:
                self._session_headers['x-mbbSecToken'] = await self.get_sec_token(vin = vin, spin = spin, action = 'heating')

and report back if it works?

That seems to work! While trying i somehow made too many requests and ended up getting 429 - too many requests.
The app basically told me to take the car for a ride before any more requests would be allowed.

ERROR (MainThread) [skodaconnect.connection] Unhandled HTTP exception: 429, message='Too Many Requests', url=URL('https://msg.volkswagen.de/fs-car/bs/vsr/v1/skoda/CZ/vehicles/vin-goes-here/requests')
WARNING (MainThread) [skodaconnect.vehicle] Failed to execute data refresh - Invalid or no response
  File "/config/custom_components/skodaconnect/switch.py", line 32, in async_turn_on
  File "/usr/local/lib/python3.8/site-packages/skodaconnect/dashboard.py", line 370, in turn_on
  File "/usr/local/lib/python3.8/site-packages/skodaconnect/vehicle.py", line 486, in set_refresh

Maybe should also declare request_state = '' on line 843 of connection.py or remove the variable altogether from the dict in line 845. HA was complaining when trying to access the non-existing variable.

That seems to work! While trying i somehow made too many requests and ended up getting 429 - too many requests.
The app basically told me to take the car for a ride before any more requests would be allowed.

ERROR (MainThread) [skodaconnect.connection] Unhandled HTTP exception: 429, message='Too Many Requests', url=URL('https://msg.volkswagen.de/fs-car/bs/vsr/v1/skoda/CZ/vehicles/vin-goes-here/requests')
WARNING (MainThread) [skodaconnect.vehicle] Failed to execute data refresh - Invalid or no response
  File "/config/custom_components/skodaconnect/switch.py", line 32, in async_turn_on
  File "/usr/local/lib/python3.8/site-packages/skodaconnect/dashboard.py", line 370, in turn_on
  File "/usr/local/lib/python3.8/site-packages/skodaconnect/vehicle.py", line 486, in set_refresh

Maybe should also declare request_state = '' on line 843 of connection.py or remove the variable altogether from the dict in line 845. HA was complaining when trying to access the non-existing variable.

Excellent. Yes, that variable is a remnant I've forgotten to remove. I will incorportate this in next release which will probably be 1.0.30 final.

Closing this issue as it is solved with 1.0.30


Add alpine base image

Hi,
this PR adds a new alpine linux based version.
Background: Nginx alpine ships with a newer openssl version and supports ALPN.
bash-4.3# nginx -V
nginx version: nginx/1.11.3
built by gcc 5.3.0 (Alpine 5.3.0)
built with OpenSSL 1.0.2h  3 May 2016
TLS SNI support enabled

I think it's better to keep the current nginx-proxy with debian and provide a second variant.
Try it: https://hub.docker.com/r/matthh/nginx-proxy/tags/
I simply created another automated build with "/Dockerfile.alpine" for "Dockerfile Location".
BTW: Different file sizes are amazing...
TODO:

Create a new automated build with "alpine-latest" tag
Add info to README

It would be very good to have such images. @jwilder any reason to do not merge this PR?

Hey alpine fans, i have updated to the latest available versions.
bash-4.3# nginx -V
nginx version: nginx/1.11.8
built by gcc 5.3.0 (Alpine 5.3.0)
built with OpenSSL 1.0.2j  26 Sep 2016
TLS SNI support enabled

Thanks @matt-hh!

I've setup an automated build w/ an alpine tag that will build using this dockerfile for HEAD on master.  Would you mind submitting a PR to update the README?

@jwilder it's really great to see that nginx proxy has alpine based image officially. Thank you so much


AutoComplete, ToggleSwitch : bugs, feature add

Description
Below are the issues and a basic transition add requested in the following components:

[ ] AutoComplete : Issue with Chip closing

[ ] AutoComplete : Dropdown menu not being at fixed position as scrolled through the screen

[x] ToggleSwitch : Add toggling transition for better UX.

Steps to reproduce

Run yarn storybook to open fuselage storybook
Click on the respective stories of AutoComplete and ToggleSwitch
Add chips in AutoComplete and click on the chip again.
Also scroll through the screen while the dropdown is switched on.

Insert an image/gif/video
toggle-switch.webm
AutoComplete.webm

Is "yarn storybook" right command to run it?

/attempt

submitted a PR

submitted a PR

Hi @vivekchavan14 . Thanks for the PR. But I was already working on this.

I thought it was a general issue, and i felt like i could solve it, thats why i solved the issue.

hey @umangutkarsh , did you try turning the inspect mode on and then scroll. The error you mentioed has been there in many such componets. So I think this is some sort of generalise issue.


When a fullscreen window dies, focus is not returned to another

ill fix that. just going to push it in a moment.

I just pulled the latest changes, I'm not sure that this has been fixed. Could someone else confirm this?

Works for me. I closed it earlier after testing it, and I just tested it again with success.

Ok, I'll close the issue and make sure that I'm up to date.

Yep, I'm good now.


Restore framework references in a more consistent manner

Motivation
Improve our compatibility with how NuGet restoration works within
MSBuild.
Modifications
Restore .NET framework and .NET Standard 2.1 references as framework
references rather than general libraries.
Results
This is much more consistent with how MSBuild will perform the restore
and add the dependencies the lock file. This should, in theory, allow
the lock file to be generated by an MSBuild restore and then passed to
the generate step in Yardarm.

/merge


Module not found

Hi there,
I'm having a bit of a strange issue. When I try to start my bot, I get the following error message
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/net-tech-/Developer/kydzs-splatoon-revolt-temp/node_modules/@kaname-png/revoltx/dist/lib/preconditions/conditions' imported from<EMAIL_ADDRESS>
I have checked manually, and the file does exist in node modules. I've tried reinstalling, deleting all node modules, using different  package managers, and etc. While I know this may not be entirely the library's fault, I wanted to ask if you had any idea of what might be causing the issue.
Node Version 20.4.0
Typescript version 5.1.6
Revoltx version 2.0.5

Strange, the file does exist in the production build in npmjs. Are you using commonjs or esm?

@sawa-ko Yeah, so I am using ESM. I can see the files in node modules. When I go to the file that imports everything in revoltx, dist/index.js, the errors seem to get more specific:
Could not find a declaration file for module '. /lib/preconditions/conditions'. '/Users/net-tech-/Developer/kydzs-splatoon-
<EMAIL_ADDRESS>implicitly has an 'any' type. ts (7016)

and the same error appears for every export * from "somePath" in the revoltx index.js file.
Here's my TSConfig:
{
	"compilerOptions": {
		"module": "ESNext",
		"moduleResolution": "Node",
		"target": "ESNext",
		"esModuleInterop": true,
		"forceConsistentCasingInFileNames": true,
		"strict": true,
		"skipLibCheck": true,
		"allowJs": false,
		"noUnusedLocals": true,
		"noUnusedParameters": true,
		"allowSyntheticDefaultImports": true,
		"noImplicitAny": true,
		"noImplicitThis": true,
		"noFallthroughCasesInSwitch": true,
		"noImplicitOverride": true,
		"pretty": true,
		"rootDir": "./src",
		"outDir": "./dist",
		"experimentalDecorators": true
	}
}

The issue resolved itself after a full reinstall.


Please remove the postinstall hook

I don't have husky on my system, and this seems like an oversight:
$ npm i -D @react-hookz/deep-equal
npm error code 127
npm error command failed
npm error command sh -c husky
npm error sh: husky: command not found
npm error Log files were not written due to the config logs-max=0

I don't really understand how is it working on you, since in published package.json postinstall script being renamed to _postinstall and therefore cant be invoked...

It's odd, the script is prefixed with underscore in package.json but npm still seems to identify it as a postinstall script:
$ cat<EMAIL_ADDRESS>| jq .scripts
{
  "_postinstall": "husky",
  "prepack": "pinst --disable",
  "postpack": "pinst --enable",
  "build": "yarn build:clean && tsc --version && tsc -p ./tsconfig.build.json",
  "build:clean": "rimraf -g ./dist",
  "lint": "eslint",
  "lint:fix": "eslint --fix",
  "test": "vitest",
  "test:coverage": "vitest --coverage",
  "benchmark": "vitest bench --run"
}
$ npm view<EMAIL_ADDRESS>scripts
{
  postinstall: 'husky',
  prepack: 'pinst --disable',
  postpack: 'pinst --enable',
  build: 'yarn build:clean && tsc --version && tsc -p ./tsconfig.build.json',
  'build:clean': 'rimraf -g ./dist',
  lint: 'eslint',
  'lint:fix': 'eslint --fix',
  test: 'vitest',
  'test:coverage': 'vitest --coverage',
  benchmark: 'vitest bench --run'
}

I guess you should remove it completely before publish to be sure.

fixed with d716a150841a6000c0eb497cefb6a028d24dbfda and release v3.0.3

Thanks


Watcher integration test

Description of the Change

Attempt at adding basic watcher integration test.
Asserts output of a "watched" process, which is terminated (checks correct listener is run).
uses exit.fixture to keep process hanging inside spawned child.
Code block it tests is located https://github.com/mochajs/mocha/blob/master/bin/_mocha#L581.
Am hoping to look at adding an Int test to check for reload when file has changed, in the future

Benefits

Increases general coverage
Gives coverage to a useful feature

Possible Drawbacks

slow down tests as take another .5 seconds to run.

Applicable issues

Issue: https://github.com/mochajs/mocha/issues/3270
Does not impact production code.
Patch release.

CURRENTLY: Investigating failures.

Issue seems to be AppVeyor's Windows not receiving the SIGINT signal, despite using the readline approach.

Issue on local Windows VM does appear to be SIGINT not being received on spawned process.
The Windows signals simulation readline appears to ONLY work on manual terminal termination (i.e. CTRL+C) and does not proxy (i.e. its a problem as the tests run Mocha in a child process).

MY SOLUTION - i have had to ignore the test on Windows. I am happy to try other solutions if people have ideas but i did not find a way to do this without re-writing a load (e.g. switch to using messages).
This part of watch feature has coverage on unix now at least.

@craigtaub Thanks for your much needed contribution!
Can you check this solution for windows to check for sigint and manually close the process?
https://stackoverflow.com/a/14861513/5384679

hi @Bamieh
Unfortunately that was the first thing I tried (see commit https://github.com/mochajs/mocha/pull/3379/commits/5ae793211ebb721b9ccde9e8baef3335f3f11122) and it did not help.
Tried it again on my experiment repo https://github.com/craigtaub/child_process_experiments/tree/parentChildProxy2 and still doesnt work.
Seemed to have same issue (i.e. parents simulated termination not reaching childsrl.on('SIGINT')).

Ok @Bamieh please let me know if you make any progress. I have tried again to no avail.
I agree not ideal, but feels like half better than nothing.

@craigtaub I will let you know by tomorrow

Ok thanks @Bamieh .

Hey @Bamieh, is there any update on this?

@craigtaub Sorry for the delay, it is hard to get my hands on a windows computer. I was unable to find a solution with our current implementation, although I want to mention:

Windows does not support sending signals, but Node.js offers some emulation with process.kill(), and subprocess.kill(). Sending signal 0 can be used to test for the existence of a process. Sending SIGINT, SIGTERM, and SIGKILL cause the unconditional termination of the target process.

I am not confident about having falsely passing tests on certain platforms, I'm sure @boneskull have some thoughts on this.

@Bamieh completely sensible point.
Do you think you would be more confident if the entire test was not run on Windows? That way its not falsely passing, its just not covered for Windows, same situation we have now.

@craigtaub yes that would be much better i believe.

@Bamieh cool, have updated the PR to reflect this. Could you have a look please.

@craigtaub looks good, thank you

@Bamieh great. If there is nothing outstanding any chance we can merge it please? Happy to look at other watcher scenarios once it is in.


/debug returns pending_update_count 1, with no errors at all

Required Information

Operating system + PHP version:

PHP version: 7.0.27-0+deb9u1 (32bit); apache2handler; Linux
Maximum PHP script execution time: 30 seconds
MySQL version: disabled
Operating System: Linux rpi3 4.9.59-v7+ #1047 SMP Sun Oct 29 12:19:23 GMT 2017 armv7l
Web Server: Apache/2.4.25 (Raspbian)
curl version: 7.52.1; OpenSSL/1.0.2l

PHP Telegram Bot version: 0.53.0
Using MySQL database: no
Update Method: Webhook
Self-signed certificate: yes
RAW update (if available):

Expected behaviour
Pending update count: 0 for no errors
Actual behaviour
Pending update count: 1
Steps to reproduce
type /debug
Hi to all!
I'm using your BOT in custom PHP project. It works very well (only a bit of lag, but need to investigate better and maybe another issue), only /debug returns everytime
Webhook Info:
{
    "url": "https://MYHOOK",
    "has_custom_certificate": true,
    "pending_update_count": 1,
    "max_connections": 40
}

But I can assure that there are no pending update at all, neither 500 errors.
Can be the /debug command itself?
Thank you very much

Perfect. Closing. Have a nice day!


build: simplify the unified build configuration

Conditionalise the inclusion of directory paths. If the include directory is empty, CMake will raise an error. This allows us to disable larger portions of the Swift build to speed up some of the build tool configuration phase and prepares for consuming CMark GFM as a CMake project.

CC: @ahoppen @QuietMisdreavus @etcwilde

@swift-ci please clean test

@swift-ci please test


Slickgrid; Call function within plugin; Converting from Saltarelle to typescript

Good morning JaiQ/Volkan,
I am currently trying to convert a specific Action from Saltarelle to typescript.
Actually, I want the Autocolumnsize Slick plugin to work with current Serenity Framework.
So far I was able to fix the plugin itself so that it works with current Serenity Framework (see the last comments over here: https://github.com/volkanceylan/Serenity/issues/447
Now Comes the conversion of the Action that after the grid has just loaded, the resizeAllColumns() function within the plugin should be called.
In Saltarelle, we could do the following (xyzGrid.cs):
private SlickAutoColumnSize autoSize;

        protected override SlickGrid CreateSlickGrid()
        {
            //return base.CreateSlickGrid();

            var grid = base.CreateSlickGrid();
            autoSize = new SlickAutoColumnSize();
            grid.RegisterPlugin(autoSize);
            return grid;
        }

        protected override void MarkupReady()
        {
            base.MarkupReady();
            if (autoSize != null)
            {
                autoSize.As<dynamic>().resizeAllColumns();
            }
        }

How can this be done within typescript? I have tried several things but somehow I don't get access to the resizeAllColumns() function.
I have in the xyzGrid.ts the following:
protected createSlickGrid(): Slick.Grid {
            let grid = super.createSlickGrid();

            this.autoSize = new Slick.AutoColumnSize();
            grid.registerPlugin(this.autoSize);

            return grid;
        }

This makes the plugin load properly and also Register and it can be used by clicking between two column Header and it will autoresize the left column.
But I am missing the MarkupReady hook (for when the page is loaded and ready) and also I am not able to access  the resizeAllColumns() function within the plugin.
May I kindly ask to point me into the right direction?
Thanks for your feedback and
with Kind regards,
John

protected void markupReady() {
    super.markupReady();
    this.autoSize && (this.autoSize as any).resizeAllColumns();
}

I kindly recommend reading TypeScript official tutorial

Good evening JaiQ,
thanks for your valuable help. That works fine.
P.S: I did read may way through the Typescript documentation and did some basic tutorials but it is the Connection between Typescript, the DOM and the Serenity Framework which makes the Thing so difficult for me and where expert knowhow in every field is required :-)
Thanks again. When all works fine I will add the proper solution to your Wiki. Ok for you?
With kind regards,
John
Somehow, Saltarelle was a more abstracted way


URL not reachable

Here’s the updated bug report with the specifics:
Describe the bug
When using the interactive search feature in Ruddarr to locate a movie already in the movie library, a pop-up error message appears stating, “Are you attempting to connect to a private IP from outside its network?” despite the search results populating. Although the download can eventually be completed, the pop-up keeps reappearing.
To Reproduce
Steps to reproduce the behavior:
1.	Go to the movie library in Ruddarr.
2.	Initiate a search using the interactive search function.
3.	Observe the pop-up message regarding connection to a private IP.
4.	Attempt to download from the search results; pop-up continues to appear intermittently.

Expected behavior
The interactive search should allow the movie download without triggering repeated pop-up messages about private IP connections.
Screenshots / Video

Environment
•	iOS version: 18.0.1
•	Ruddarr version: 1.3.0 build 288
•	Device: iPhone Pro Max

Additional context
The issue is isolated to Ruddarr; similar actions in Safari or Lunasea do not produce this error, and SABnzbd is fully accessible in these apps without issues.

Email me your host name and API key so I can reproduce this.

I'm guessing you have too many "slow" indexers in prowlarr. Try setting your instance to "Slow Instance" in the advanced settings.


Feature Request: Add option to Profiles to enable/disable Wireless Local User Profile Synchronization

Describe the bug 🪲
By default LMS on Windows will synchronize basic Wireless profiles with AMT if Wireless Local User Profile Synchronization is Enabled.  It is Disabled in AMT by default.
To Reproduce 🪜
Steps to reproduce the behavior:
n/a
Expected behavior
Request option in Profiles to set this to enabled and if enabled to enable in in AMT.
Screenshots 🖼
[If applicable, add screenshots to help explain your problem.]
https://software.intel.com/sites/manageability/AMT_Implementation_and_Reference_Guide/default.htm?turl=WordDocuments%2Fsetgetwirelesslocaluserprofilesynchronizationsettings.htm
AMT Device (please complete the following information): 🖥

OS: Windows
AMT Version: 11.2 and higher
AMT Configuration Mode: Admin Control Mode AND Client Control Mode]
Network Configuration [e.g. Dynamic IP AND Static IP]

Service Deployment (please complete the following information): ⛈

Deployment Type: [e.g. Azure, Docker, K8s]
Node Version: [e.g. LTS 14]
Component & Version: [e.g. RPS 2.0.0]

Additional context
Add any other context about the problem here.

We only enable this during wireless configuration.  Do you want this to be set for all configurations?

oh, so you do automatically enable it now?  Can you say more about under what circumstances?

If we are setting up a wifi profile, we will turn this feature on.  Adding a story to the backlog to always turn on this feature, regardless of if we are setting up a wifi profile or not.

Perfect, thank you!

Reopening this item so we can track when this feature is released

closed with #764


[sumo] Revert "cpupower: Remove recipe"

This reverts commit 445a1a8c19abb128a9c685dc83e9bacf2448a609.

This one actually did not present any problem, according to Jenkins:
https://ci.linaro.org/job/96boards-reference-platform-openembedded-sumo/73/
but it only makes sense to have our branches aligned.


(3.2.8) Menu item issues

[x] (1) the system browser packages pane popup, and Packages menu item, "Add Package..." gives a dialog "Packages cannot be added in RowanV2.0 yet".  This give the impression you can't add a package, and yet with the right things selected you can locate a package creation dialog in the lower right.

[x] (2) When you have a package selected, the create new package form hidden.  If you unselect the package, the lower pane still shows the class creation expression and still hides the new package form.  If you click on your project in the project pane, it still leaves the class creation expression showing and no new package form.  You have to actually select a different project and then back to get the new package form to display.

[x] (3) In the console, if you do not have a project selected and choose the Load Git Project... menu item, you get a Jadeite dialog, JadeiteTranscript does not understand #loadProjects.

(1) Add Package menu item will no longer be in menus as of 3.2.9. Was already fixed in https://github.com/GemTalk/Jadeite/commit/0f4ae2d31de9ef6017e17c785d037bd7a0d16503

(2) & (3) should be fixed now.

I would prefer that add package bring you to the project pane and make the dialog visible, and why do we need to keep the non-working unload package and write package on the menu if can remove add, that now actually works?
However, the package creation dialog location is rather inelegant, and this may be under work and/or not in scope, so I'll file a new issue/feature request for general improvement.

Unload has been renamed to Remove here - https://github.com/GemTalk/Jadeite/issues/930#issuecomment-1223322341


fix(starknet_integration_tests): fix no txs sent bug

This change is

#2727
#2734  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


[pulsar-admin] Support delete schema ledgers when delete topics

Master Issue: #8134
Motivation
The REST APIs of PersistentTopics#deleteTopic and PersistentTopics#deletePartitionedTopic didn't support delete schema of topics, which may cause after topics were deleted, the schema ledgers still existed. And current implementation of delete schema is just add a empty schema ledger but not delete existed schema ledgers.
Modifications

Add a deleteSchema query param to REST APIs of deleting topics/partitioned topics;
Add a map to record the created ledgers in BookkeeperSchemaStorage;
Expose deleteSchema param in pulsar-admin APIs;
Delete schema ledgers when delete the cluster with -a option.

Verifying this change

[ ] Make sure that the change passes the CI checks.

It has been tested in local environments:

Check the current count of ledgers;
Create a new partitioned topic or non-partitioned topic;
Create producers/consumers with schema to send and receive messages with the created topic;
Delete the topic with deleteSchema=true query param or call admin API that set deleteSchema to false;
Recheck the count of ledgers, make sure it's the same with step 1.

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

The rest endpoints: (yes)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (JavaDocs)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

need to cherry-pick to 2.6.2.


Remove magic from CI requirements for python 3.7. Fix #6

Related to CI only

Pull Request Test Coverage Report for Build 60

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.662%

Totals

Change from base Build 58:
0.0%

Covered Lines:
295

Relevant Lines:
299

💛  - Coveralls

The last release of genevt crushes on PyPy -> hold pull request


Avoid calling typers/overloads without literal types

Feature request

Type inference currently calls every typing template twice: once using literal types if available, and again without literal types. I believe the original purpose was backwards compatibility when literal types were introduced.
However, this can be confusing for developers. For example, if an overload expects a literal type but fails due to another reason, Numba tries again without literal types. The developer doesn't see the original error, and may be confused why the overload is called without literal types (our engineers have experienced these issues many times).
Ideally, all templates should handle literal types so Numba wouldn't need to have this behavior. In the short term, there could be an option for overloads (e.g. "literal_only=True").

A literal_only option would mean that every args have be of literal type. But, there often not the case. Instead, there is an alternative that let's you mark which argument must be of literal type. See numba.core.extending.SentryLiteralArgs. Example  https://github.com/numba/numba/blob/0a8b8118987944e82603bfa3c90d87b80ffe5d99/numba/tests/test_literal_dispatch.py#L249-L252

Thanks @sklam . But my point is about avoiding rerun of overload function with unliteraled types if first overload implementation failed to compile. This solution is still confusing if there was an error in overload:
import numba
from numba.extending import overload, SentryLiteralArgs

def do_this(x, y):
    return x + y

@overload(do_this)
def ov_do_this(x, y):
    SentryLiteralArgs(['x']).for_function(ov_do_this).bind(x, y)
    return lambda x, y: x + y + UNKNOWN_GLOBAL  # invalid impl

@numba.njit
def foo(a, b):
    return do_this(a, b)

foo(1, 3)

numba.errors.ForceLiteralArg: Failed in nopython mode pipeline (step: nopython frontend)
Pseudo-exception to force literal arguments in the dispatcher

File "../tmp/sentry_test.py", line 14:
def foo(a, b):
    return do_this(a, b)
    ^

[1] During: resolving callee type: Function(<function do_this at 0x10286a170>)
[2] During: typing of call at ../tmp/sentry_test.py (14)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/ehsan/dev/numba/numba/dispatcher.py", line 353, in _compile_for_args
    return self.compile(tuple(argtypes))
  File "/Users/ehsan/dev/numba/numba/compiler_lock.py", line 32, in _acquire_compile_lock
    return func(*args, **kwargs)
  File "/Users/ehsan/dev/numba/numba/dispatcher.py", line 772, in compile
    raise e.bind_fold_arguments(folded)
numba.errors.ForceLiteralArg: Pseudo-exception to force literal arguments in the dispatcher

File "../tmp/sentry_test.py", line 14:
def foo(a, b):
    return do_this(a, b)
    ^

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "../tmp/sentry_test.py", line 17, in <module>
    foo(1, 3)
  File "/Users/ehsan/dev/numba/numba/dispatcher.py", line 376, in _compile_for_args
    return self._compile_for_args(*args)
  File "/Users/ehsan/dev/numba/numba/dispatcher.py", line 369, in _compile_for_args
    raise errors.CompilerError(m.format(info))
numba.errors.CompilerError: Repeated literal typing request.
Arg #0 is Literal[int](1).
This is likely caused by an error in typing. Please see nested and suppressed exceptions.

I also have an issue that related to this that really confused me in the beginning.
Say I have code like this:
@overload(do_this)
def ov_do_this(x, y):
    if not isinstance(x, types.Integer):
        raise TypeError('do_this: parameter x may only be an integer')
    if not isinstance(y, types.Literal):
        raise RequireLiteralValue('do_this: parameter y must be literal')
   pass

Let's say this is called with do_this(2.0, 1) this results in the error message LiteralValueRequired: do_this: parameter y must be literal - despite it being a literal!
When I first encountered this, I was searching high and low why numba did not recognize 1 as a literal! - It took me about a whole day until I realized that after the first TypeError numba calls the overload again with y as a non-literal which then results in the confusing error message.
Not sure if and how the user experience could be improved though.
Once one know one has to scrol up to identify the real issue it is not a big problem but it is far from obvious to somebody new to numba.


fix: incorrect checks

fixes checks for address and interface id
add assert lib for code simplification

@CJ42 @b00ste I don't have write access to the repo, please merge the PR.


Comments (#) aren't supported.

According to the OBJ spec linked on the main page, comment lines should be ignored, but they aren't. Instead, the program just bombs:
[FATAL] line:4 Unsupported line "#98 vertices, 124 faces"

Please submit a bug report. If you can, provide this file as an attachement.
> https://github.com/jonnenauha/obj-simplify/issues

It sis very much supported https://github.com/jonnenauha/obj-simplify/blob/master/objectfile/structs.go#L93-L96
But seems that if there is no space after the # it will bork https://github.com/jonnenauha/obj-simplify/blob/e8ec72272091c159b4ad553e1159f46ba446e55b/obj-parser.go#L194-L201


Corrupted installation package

Hi Good day,
I'm trying out the Workspace few days ago and notice the installer is corrupted.

I downloaded multiple copies they are all the same. Try on Windows Server 2019 and 2022 doesn't work either. I'm downloading from this website (https://www.onlyoffice.com/download-workspace.aspx#workspace-community)

Hello @funmix Yes, we had a problem. We have updated the installer on the site. Thank you for pointing out the error.


Metric port name change breaks health checking

Bug Description
The port name changed in this upstream PR:
https://github.com/kubernetes-sigs/external-dns/pull/4691
With the current example in the README, the pod never becomes ready, since it relies on the port name http-wh-metrics. Renaming to http-webhook fixes the issue.
ExternalDNS Configuration
          domainFilters:
            - internal.lan
          extraArgs:
            - --ignore-ingress-tls-spec
          logLevel: debug
          policy: sync
          provider:
            name: webhook
            webhook:
              env:
                - name: UNIFI_HOST
                  value: https://unifi.irc.lan
                - name: UNIFI_USER
                  valueFrom:
                    secretKeyRef:
                      key: username
                      name: external-dns-unifi-secret
                - name: UNIFI_PASS
                  valueFrom:
                    secretKeyRef:
                      key: password
                      name: external-dns-unifi-secret
                - name: LOG_LEVEL
                  value: debug
              image:
                repository: ghcr.io/kashalls/external-dns-unifi-webhook
                tag: main
              livenessProbe:
                httpGet:
                  path: /healthz
                  port: http-webhook
                initialDelaySeconds: 10
                timeoutSeconds: 5
              readinessProbe:
                httpGet:
                  path: /readyz
                  port: http-webhook
                initialDelaySeconds: 10
                timeoutSeconds: 5

ExternalDNS Logs
N/A
Webhook Logs
N/A
UniFiOS Version
N/A
UniFi Network Version
N/A
ExternalDNS Version
1.15.0
Search

[X] I have searched the open and closed issues for duplicates

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@craigcabrey Thanks for the notice, completely went over it when I was updating to v0.15.0


Manage codehaus-jackson version in dependencies bom

What is the purpose of the change
Brief changelog
Verifying this change

Checklist

[x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
[ ] Add some description to dubbo-website project if you are requesting to add a feature.
[ ] GitHub Actions works fine on your own branch.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #11423 (58827c6) into 3.2 (e933f57) will decrease coverage by 4.86%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11423      +/-   ##
============================================
- Coverage     69.65%   64.80%   -4.86%
+ Complexity      133       14     -119
============================================
  Files          1526     1498      -28
  Lines         82665    62538   -20127
  Branches      14795     9149    -5646
============================================
- Hits          57584    40528   -17056
+ Misses        20222    17772    -2450
+ Partials       4859     4238     -621

Impacted Files
Coverage Δ

...luster/router/script/ScriptStateRouterFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...he/dubbo/test/common/impl/GreetingServiceImpl.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...zookeeper/curator/CuratorZookeeperTransporter.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../serialize/hessian2/Hessian2SerializerFactory.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...nfigure/DubboRelaxedBinding2AutoConfiguration.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../apache/dubbo/test/spring/SpringXmlConfigTest.java
0.00% <0.00%> (-96.16%)
:arrow_down:

...egistrycenter/context/ZookeeperWindowsContext.java
0.00% <0.00%> (-81.82%)
:arrow_down:

...istrycenter/processor/FindPidWindowsProcessor.java
5.40% <0.00%> (-81.09%)
:arrow_down:

...pc/cluster/router/file/FileStateRouterFactory.java
0.00% <0.00%> (-80.96%)
:arrow_down:

...ycenter/processor/KillProcessWindowsProcessor.java
10.00% <0.00%> (-80.00%)
:arrow_down:

... and 482 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


docs: release v0.36.1

Fixes #N/A
Description
Updates the docs for v0.36.1
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.963%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
5394

Relevant Lines:
6581

💛  - Coveralls


[bugfix] Group defaults to WORLD if None

What does this PR do?

Fixes #5122
Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
[x] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] If you made a notable change (that affects users), did you update the CHANGELOG?

PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?
Make sure you had fun coding 🙃

def all_gather_ddp_if_available(
    tensor: Union[torch.Tensor], group: Any = torch.distributed.group.WORLD, sync_grads: bool = False
) -> torch.Tensor:

This might be simpler?

def all_gather_ddp_if_available(
    tensor: Union[torch.Tensor], group: Any = torch.distributed.group.WORLD, sync_grads: bool = False
) -> torch.Tensor:

This might be simpler?

yes, just not sure about it some uses do already uses pass the None...

I thought None produces an error as outlined in the linked issue, so this shouldn't break any existing working code?


fix image alert for remote images

What's fixed:

key for image location is 'locations', not 'location'
one image may have multiple locations.
only all locations are remote means it's an remote image.  That means
if one of the locations is 'file', it's not a remote image.

Just some minor things to improve in the patch.


Social Engineering in "Backup Notes (keep?)" section in dentity/design_decisions.md

Thoughts about Social Engineering in "Backup Notes (keep?)" section in identity/design_decisions.md
I am not sure how to spoof an issuer in SSI, but I remember watching an entertaining talk about network security
and spoofing SSL.
YouTube video: Network Security 101: Full Workshop
1:10:49 starts talking about public keys and signatures
1:22:20 starts talking about MiTM for SSL and talks about Certificate Authorities (CA)
1:26:56 SSL strip (spoofing SSL throguh social engineering even with CA)
Punting: https://github.com/WebOfTrustInfo/rwot1-sf/blob/master/final-documents/dpki.pdf

I assume you can still issue fake IDs if Joe Hacker decides to issue them?
"I would just love having the private key of someone everyone trusts. It would be like Printing ID cards in the physical world and nobody noticing. I could be anything I wanted, and since identity translates to money everything is suddenly free." -- someone?


Merge master into next.

This pull request introduces 1 alert and fixes 1 when merging 952a520eb16e6a130effe51a3233cb3cbdfc4a8d into ceb316df60ebf619dda82e84390bad6e91e93ec7 - view on LGTM.com
new alerts:

1 for Generic catch clause

fixed alerts:

1 for Generic catch clause

Comment posted by LGTM.com

This pull request introduces 1 alert and fixes 1 when merging c20b688a3fbd0054ada4b3bb13f7316ab7180c24 into 3cee874ee39e31fcb87cdaece67908ddd43c7e81 - view on LGTM.com
new alerts:

1 for Generic catch clause

fixed alerts:

1 for Generic catch clause

Comment posted by LGTM.com


Cannot crop window on specific web site

Crop cursor will not be shown.
Ex:
Google Developer Console
https://console.developers.google.com/project

https://github.com/gyazo/gyazo-chrome-extension/blob/200ceb0d119811def2c2133d399aff09f3b73092/content.js#L26


Augumentations

augumentations for RGB and greyscale images

@apyskir please open this PR with merge to the dev-solution-5 -> this is branch where we will add new stuff that we will release with new solution.


Use k8snodestore to perform node status GC of CCNP and CNP

Fixes #10457
Please ensure your pull request adheres to the following guidelines:

[x] For first time contributors, read Submitting a pull request
[ ] All code is covered by unit and/or runtime tests where feasible.
[x] All commits contain a well written commit description including a title,
description and a Fixes: #XXX line if the commit addresses a particular
GitHub issue.
[x] All commits are signed off. See the section Developer’s Certificate of Origin
[ ] Provide a title or release-note blurb suitable for the release notes.
[x] Thanks for contributing!

@daemon1024 can you please rebase this PR again? Thank you

@daemon1024 do you think you might get a chance to revisit this PR sometime soon?

@errordeveloper sure. It already had an approval, I assumed it's good to go. I am not sure what needs to be done here 😅

@daemon1024 Could you please rebase the pull request and I'll retrigger end-to-end tests? We should be good to go after that I think.

@pchaigno Done 😃

/test

/test


New style temporal

#3
Declarative temporal:

class NewStyleModelWithRelationship(Base, temporal_sqlalchemy.TemporalModel):
    __tablename__ = 'new_style_temporal_model_with_relationship'
    __table_args__ = {'schema': SCHEMA}

    id = auto_uuid()
    description = sa.Column(sa.TEXT)

    int_prop = sa.Column(sa.Integer)
    bool_prop = sa.Column(sa.Boolean)
    datetime_prop = sa.Column(sa.DateTime(True))
    rel_id = sa.Column(sa.ForeignKey(RelatedTable.id))
    rel = orm.relationship(RelatedTable)

    class Temporal:
        activity_class = Activity
        track = (
            'description',
            'int_prop',
            'bool_prop',
            'datetime_prop',
            'rel_id',
            'rel',
        )
        schema = TEMPORAL_SCHEMA

Adds support for tracking entities that:

Don't have a UUID primary key
Have a composite primary key

Does this still support the decorator style? If so, are the 2 styles compatible or is it an either or kind of thing?

both are still supported, and both use the same underlying data models & session hooks

Sounds great. I don't have any feedback about the code because I don't have enough context. I'll leave that to others.

tagging some people @aclowes @bjjclover @stroud109 @NicoleZuckerman

Resolves #3