Contribution to "Cross-site Scripting in quill"

Updates

Affected products
CVSS
CWEs
Severity

This vulnerability is disputed and should be revoked. Per https://github.com/quilljs/quill/issues/3364 it cannot be repeated except by completely failing to escape HTML, which is the responsibility of the developer in the case of any User Generated Content on the internet.

Thanks for the contribution, but we currently default to including CVE information in our database. If this CVE is rejected by the CVE Program then we would reassess, but we still believe there is merit in including this advisory. There is also a discussion of the issue's validity in the thread you've linked.
https://github.com/quilljs/quill/issues/3364#issuecomment-873268768
We can update our advisory to reflect the disputed status.


3 things that would DEFINITELY be useful if added to this program

Hello Matthew,
I would like to request the addition of 3 features I think would definitely be useful. I don't do programming, but I do come up with ideas that can make a killing in sales/popularity.

An option to export a video file with multiple audio tracks. (Example: Track 1 is Desktop audio and Track 2 is Microphone audio) This would be useful for those that wish to fix up the volume mixing manually through editing software.
An option to record a webcam, but to export it as a separate file rather   ##than making it stuck to the video. Editing in the webcam is much better than having both the screencap and webcam in the same file.
60FPS recording for gamers like myself.
Please add these and I would definitely recommend for every rising YouTuber to use this software. You have my promise.

@SeanTheBermanator Thank you for your suggestions

Option for multiple audio tracks does not seem possible since a change has been made that allows multiple audio sources (more than 2) to be recorded.
Also, there is an added overhead for every stream we create and after the above change this does not seem feasible.
But, options for specifying volume of individual sources is possible to implement.

This can be done and I was hoping to do. But, will take some time.

As specified in the FAQ, Captura is not very fast. So, 60fps does not seem possible. But, an option to remove the 30fps limit has been added in the latest release. You can check how much your system can handle. On my system, Captura can handle only a maximum of 45fps. For smaller recording region dimensions, sure 60fps works.

Also, about the preview feature you mentioned in another issue, it has been implemented in the latest pre-release.

Added an option to record webcam to separate file. (See #236)
Added an option to record every audio source into separate file (See #237)
@SeanTheBermanator, This is not exactly what you requested, but I think this will fit your requirements.
Please check this build: https://ci.appveyor.com/api/buildjobs/mo8ul4y6ksk5p857/artifacts/temp%2FCaptura-Portable.zip


WIP - backport server idle metric to 2.1

Fixes #4641
The changes in this PR will

[x]  backport the idle metrics from #4078
[ ] convert the metric from a Counter to a Gauge
[ ] remove the COMPACTOR_BUSY metric in favor of this

So far I have backported the changes as they exist in elasticity and tried to get the test working. Right now I can see the metric for the compactor and scan server in the test but am not seeing it for the tserver yet (no metric at all) and am not sure why.

but am not seeing it for the tserver yet (no metric at all) and am not sure why.

Looked into this a bit and it seems like micrometer only reports the metric after it changes and since the tserver never became idle, the value for this metric was never emitted.

removing the WIP label as I think this is ready for review now. The only thing I need to fix is the CompactorTest which is failing in the builds. I am not sure whats going on there, maybe something wrong with the mocking in that test now.


Bugfix: draw_full_view

Fixes: https://github.com/source-academy/cadet-frontend/issues/718

Pull Request Test Coverage Report for Build 2221

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 34.301%

Totals

Change from base Build 2207:
0.0%

Covered Lines:
1777

Relevant Lines:
4562

💛  - Coveralls

Version problem


cmd/compile: double aliases lead to double serialization of an object

package p
import "imported"
func F1 => imported.F
func F2 => imported.F

will serialize the data for imported.F twice in the export data for this package, once for F1 and once for F2.
While this doesn't bother the importer (it already can handle multiple imports of the same object), it breaks the original invariant that objects of the current package are serialized exactly once in the export data (we use maps to ensure this for packages and types).

See also comment in go/internal/gcimporter/bimport.go, method importer.declare.

@mdempsky suggests:
Seems like it would be a little cleaner to instead export aliases as

    aliasTag, aliasName, orig.qualifiedName

and ensure we emit aliases after we've emitted the original object, but I'm okay with this too.  Like you say, I don't think it should matter much in practice either way.

(see https://go-review.googlesource.com/#/c/32538/)

cc: @alandonovan

Emitting imported.F exactly once in p's export data is not sufficient to avoid duplication.  The importer needs to know that p.F1 and importer.F (which it may already have) are the same object, which means, as Matthew says, that the export data for the alias must record the canonical name of the original object.  But the qualified name is also not sufficient, since the object definiion is required.  I think you need:
  aliasTag, aliasName, orig.qualifiedName, obj

where obj is either the definition of the original object, or a back reference to an earlier object.  obj should also permit "unknownTag" to represent dangling aliases.


Adding a HTTP Interface / REST API?

Hello, I want to create a crafting recipe manager web project powered by kalandralang. The challenge of working with OCAML (for us non-ML developers) could be solved with an HTTP interface to the interpreter.
For example, an incoming POST request could contain the recipe in the body of the request and the relevant command line parameters provided by query parameters. The response would be JSON with the recipe output and structured data for the costs and profits of the craft.
It looked to me that a minimal implementation would be straightforward with grinberg/opium. Any thoughts around this?

An HTTP server like this is certainly doable yes. I would not host it myself though, but I assume your plan is to run it yourself just like your recipe manager itself?
Note that another possibility would be to have reverse bindings from your language to OCaml. We could in particular turn Kalandralang into a JS lib so that recipes can be executed by the browser. There are a few challenges though. For instance one needs to figure out how to manage the data files. Also I would need to learn how to make reverse bindings. Overall the HTTP server approach would be significantly simpler to implement for me.
I look forward to seeing your web project, it sounds very cool :) I'll try to implement the HTTP server.

I have pushed a branch named http which provides a very rough proof of concept. You can either:

build it with dune build and run it with _build/default/src/server/main.exe <OPTIONS>
or build and run it in one command with dune exec kalandralang-server -- <OPTIONS>

<OPTIONS> are --port (defaults to 8080) and --data-dir. Or --help.
You can then run something like:
curl -d "$(cat examples/awakeners-orb.kld)" http://localhost:8080/run

(for some reason -d<EMAIL_ADDRESS>doesn't work :thinking: ) and you get a plain text response like:
--------
Marble Amulet (Rare) (Warlord / Hunter)
--------
(prefix) [T1] 15% increased Area of Effect
(prefix) [T1] Projectiles Pierce an additional Target
(prefix) [T8] Adds 3 to 7 Fire Damage to Attacks
(suffix) [T3] +41 to Dexterity
(suffix) [T5] +29% to Cold Resistance
--------
Cost:
     1 × awaken
Total: 0.99ex (175c)

Obviously a lot is missing. Can you tell me which of those features would be important for you?

JSON output with:

cost (as a JSON object like {"chaos": 42, "exalt": 17.123})
resulting item(s) (as a string? or an array of strings for mods? or an array of something like {"kind": "prefix", "tier": 1, "modifier": "+41 to Dexterity"}?)
output (a string that contains what is currently served as plain text)
time information?
seed?
more?…

being able to pass command-line options as query strings (which options do you need?)
HTTPS
being able to specify which interface (i.e. which address) to listen to
a command-line option to specify a timeout for requests (note that this would be harder than it sounds)
…

Of course the more features you need the more work it will be for me and I don't know when/if I'll implement them ;)

Hello! Thank you for taking action on this so quickly. Yes, the idea is for me to run the server. I packaged my local kalandralang copy into a ocalm/opam docker container and have it serving the HTTP interface. I was able to build a super quick PoC (kalandralang http <-> trpc + next.js) this afternoon. It's awesome seeing it work together even in this very primitive form. =)

The most important feature would be the JSON output. This would need to minimally include the cost and resulting item as structured data (something like {"kind": "prefix", "tier": 1, "modifier": "+41 to Dexterity"}). It's also important that we can incorporate a timeout for the request and handle multiple incoming HTTP requests without blocking.
A reverse binding is a really interesting option with the added benefit of bringing the interpreter client side. However, as you pointed out, this would require a lot of upfront work. I think we can take a deeper look into that later if there is excessive challenge with the HTTP approach.
I will continue to work on refining the idea and building out the PoC so I can get an accurate picture of what features would be necessary to bring things to life. My current motivation is to setup an archive of crafting recipes for items and assign them to a character. The crafting list across all remaining-to-be-crafted recipes for that character could then be used to determine the total expected costs and raw materials to finish the items. It would bring a whole new level of accuracy to a low budget or high budget character! If anyone has contributing thoughts or experience, please let me know.

Very nice! Thanks for the screenshot :) Looks cool! And indeed it sounds quite useful to be able to evaluate the budget of a build at any time with real market values.
I have pushed a new version of the branch. It now serves JSON instead of plain text. I think you'll find all you need in the data but don't hesitate to tell me if you miss anything. I didn't document the format but I'm sure you'll have no trouble reading the output without documentation, it's pretty self-explanatory.
I tested and it appears that one can already perform multiple queries in parallel. The library I use (cohttp) probably uses threads I guess. However, I didn't implement a timeout yet. I think it should actually be easier than I thought at first though.

@cganas are you interested in me rebasing the http branch on top of master to get the latest changes (mostly related to the exalt/divine swap) or have you stopped working on this project? (I wouldn't blame you, passion projects come and go for everyone :D )

I have rebased the http branch. Some fields changed name because of the ex <-> div swap.
I have added a commit on top of it to add a --json command-line option. This causes Kalandralang to output the same results as the HTTP server would, except that the logs field is empty. Instead, logs are still available, but on stderr instead of stdout. Example:
$ kalandralang run examples/unveil.kld --json 2> logs
{
  "count": 1,
  "items": [],
  "average_paid": {
    "suffixes_cannot_be_changed": 1,
    "aisling": 1
  },
  "average_gained": {},
  "average_paid_div": 2.484819101872614,
  "average_gained_div": 0,
  "logs": null
}
$ cat logs
Loading kalandralang.cache...
Loading costs.json...
Ready.
12.397% (prefix) 17-20% increased Projectile Damage
                 23-25% increased Projectile Speed
12.397% (prefix) 17-20% increased Melee Damage
                 +2 to Melee Strike Range
9.917% (prefix) +51-55 to maximum Mana
                6-7% reduced Mana Cost of Skills
9.917% (prefix) +51-55 to maximum Mana
                7-8% of Damage taken Recouped as Mana
9.917% (prefix) +51-55 to maximum Mana
                Regenerate 5.3 Mana per second
16.529% (prefix) +55-60 to maximum Mana
                 Regenerate 33.3 Life per second
16.529% (prefix) +55-60 to maximum Life
                 Regenerate 5.3 Mana per second
12.397% (prefix) 17-20% increased Area Damage
                 14-16% increased Area of Effect
--------
Agate Amulet (Rare)
--------
(prefix) {crafted} Suffixes Cannot Be Changed
(prefix) [T1] 20% increased Area Damage
              15% increased Area of Effect
(suffix) [T1] +53 to Dexterity
(suffix) [T1] +51 to Intelligence
(suffix) [T1] +53 to Strength
--------
Cost:
     1 × aisling
     1 × suffixes_cannot_be_changed
Total: 2.48div (410c)

@AR-234 I think this should suit your needs. It is possible that there are still some bugs where the program would print stuff on stdout, breaking the JSON output. If you get a JSON parse error, it may be because of such a bug.
This is still very experimental and barely tested, so it'll stay in the http branch for now =)


Support Linux ARM

Everything runs fine on Linux ARM with the exception that the server does not use the correct analysis binary.
A change is needed to the server to select a different binary depending on the architecture.
Then the updated server and appropriate binary must be included here.
Then everything works fine!

Can you open a separate issue on rescript-vscode and link it here? Makes it easier to coordinate the fix.

Hi @ryyppy
Here's the issue on rescript-vscode: https://github.com/rescript-lang/rescript-vscode/issues/426 Some kinks are being worked out on it.

Thanks! will close this thread in favour of the linked issue if you don't mind.


[types] Extract genesis definitions from executor to types

Rename and gate previous ::genesis functions to ::mock_genesis
to reflect their actual use as test data generators.

Now BlockInfo::genesis, LedgerInfo::genesis, and
LedgerInfoWithSigs::genesis are the "real" way to create genesis
types.

Add an assertion that genesis transaction always outputs a
validator_set; i.e., genesis is always an epoch change.

Gate BlockInfo::random behind test flags.

Update usages in various tests.

@bors-libra r=dmitri-perelman

:pushpin: Commit 66e0fc1 has been approved by dmitri-perelman

:hourglass: Testing commit 66e0fc1b8333ff8956f791407a985070840d89c2 with merge 086ed3b917a61604ea9df235139cbb6f194d742b...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: dmitri-perelman
Pushing 086ed3b917a61604ea9df235139cbb6f194d742b to master...


List the status of DLCs

Not sure if possible

http://store.steampowered.com/dynamicstore/userdata/
Lists owned apps, including DLCs


KeyError: 'availableModes'

I use the nwg-shell installed on Manjaro with Hyprland. When running nwg-displays in the terminal I get following error:
Settings: {'view-scale': 0.15, 'snap-threshold': 10, 'indicator-timeout': 500, 'custom-mode': [], 'use-desc': False}
Running on Hyprland
Traceback (most recent call last):
  File "/usr/bin/nwg-displays", line 33, in <module>
    sys.exit(load_entry_point('nwg-displays==0.3.16', 'gui_scripts', 'nwg-displays')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/nwg_displays/main.py", line 1252, in main
    create_display_buttons()
  File "/usr/lib/python3.11/site-packages/nwg_displays/main.py", line 569, in create_display_buttons
    outputs = list_outputs()
              ^^^^^^^^^^^^^^
  File "/usr/lib/python3.11/site-packages/nwg_displays/tools.py", line 146, in list_outputs
    for item in m["availableModes"]:
                ~^^^^^^^^^^^^^^^^^^
KeyError: 'availableModes'

Currently running version 0.3.16
If I need to supply more information please let me know.

Which version of Hyprland are you on? Hyprland returns available modes since v0.36.

OK, then it's an issue with Manjaro, there the package is still on v0.35 when sourcing from manjaro/extra.
Thanks for your response :) And thanks for your tools in general, they are great!

Thank you. If it comes to you issue, you could try hyprland-git from AUR.

BTW updating the Hyprland version did the trick.
For anyone else wondering how to switch manjaro mirrors to unstable for the newest mirrors here is the guide:
https://wiki.manjaro.org/index.php/Switching_Branches


Add some very basic tests for apiserver

Signed-off-by: Doug Davis<EMAIL_ADDRESS>

I think I got all comments addressed - ready for another review

Gimme a couple minutes to run it.

wow, that runs really fast.
I prefer dashed names. Let's fight about it.
lgtm


Jesse: Watch vapemodesa.com

Jesse requests the watch of the watch_keyword vapemodesa\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

vapemodesa\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Jeff Schaller in Charcoal HQ


PlayCanvas v1.28.1 fails to load some glTF models

Description
I have updated the PlayCanvas version of gltf-test from 1.28.0-dev to 1.28.1.
However, the latest version of PlayCanvas 1.28.1 fails to load some models.
Steps to Reproduce
OK: PlayCanvas v1.28.0-dev + Duck.gltf result:

The glTF model resource refers to the same folder as the model.

/sampleModels/Duck/glTF/Duck.gltf
/sampleModels/Duck/glTF/Duck0.bin
/sampleModels/Duck/glTF/DuckCM.png

NG: PlayCanvas v1.28.1 + Duck.gltf result:

The resource of glTF model does not refer to the same folder as the model but refers to the folder under the library.

/sampleModels/Duck/glTF/Duck.gltf
/examples/playcanvas/Duck0.bin
/examples/playcanvas/DuckCM.png

The following is the actual sample folder structure.
/gltf-test
    /examples
        /playcanvas
            /index.html
            /index.js
    /libs
        /playcanvas
            /v1.28.1
                /playcavnas-latest.js
    /sampleModels
        /Duck
            /glTF
                /Duck.gltf
                /Duck0.bin
                /DuckCM.png

Hi @cx20, as always, thanks for logging this issue!
I'm having a little trouble understanding how Duck.gltf under sampleModels containing references to 'Duck0.bin' and 'DuckCM.png' results in requests to files under examples?
Do you know how I can reproduce the network error using my own engine? I tried loading the problem model in the PC viewer but that worked ok.

Hi @slimbuck

Do you know how I can reproduce the network error using my own engine?

I tried preparing a reproducible sample of the problem in jsfiddle.
OK : PlayCanvas v1.27.0 + Duck.gltf
https://jsfiddle.net/cx20/ev30uh2c/
NG : PlayCanvas v1.28.1 + Duck.gltf
https://jsfiddle.net/cx20/jpmd9r63/
The code for loading the glTF file is as follows.
var url = "https://rawcdn.githack.com/cx20/gltf-test/9fb5f39992bdd548e17fb18b256c41b14fb8840e/sampleModels/Duck/glTF/Duck.gltf";
var filename = url.split('/').pop(); // "Duck.gltf"
app.assets.loadFromUrlAndFilename(url, filename, "container", function (err, asset) {
    var resource = asset.resource;
    gltf = new pc.Entity('gltf');
    gltf.addComponent('model', {
        type: "asset",
        asset: resource.model
    });

    app.root.addChild(gltf);
});

I tried loading the problem model in the PC viewer but that worked ok.

Hmm. I tried running the PC Viewer locally, and the result was as follows:

glTF format
resources used by the model
result

glTF
Duck.gltf, Duck0.bin, DuckCM.png
:x:

glTF-Binary
Duck.glb
:white_check_mark:

glTF-Draco
Duck.gltf, Duck0.bin, DuckCM.png
:x:

glTF-Embedded
Duck.gltf
:white_check_mark:

glTF-Quantized
Duck.gltf, Duck0.bin, DuckCM.png
:x:

@slimbuck I've reviewed recent changes and found that the following changes are affecting:
https://github.com/playcanvas/engine/blob/64208cb84675ddf4f41266543e1d81ba9d0dd91e/src/resources/loader.js#L149-L152
Previously, original parameter was passed as the url, but recent commits, it seems that the filename akes precedence. As a result, it seems that the urlBase argument of GlbParse is no longer working.

Ahh yes @cx20, thank you! The container resource is extracting the wrong path as a base for loading external urls, check out https://github.com/playcanvas/engine/blob/master/src/resources/container.js#L100. It should be using url.load not url.original. I'll submit a PR to get this fixed asap.

@slimbuck Thanks! I have confirmed that PlayCanvas v1.29.0-dev resolves this issue.


fix: 5103 add back mintnft activity

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #5103
[ ] Requires deployment <>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[x] I've tested it at </bsx/collection>
[x] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[ ] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

It's related with https://github.com/kodadot/nft-gallery/pull/5028
I'm thinking if we should hide mint and burns on the tabs of activity on rmrk2. WDYT @roiLeo
tested on: https://deploy-preview-5104--koda-nuxt.netlify.app/rmrk2/gallery/16759320-8453d0ccb4cb7e9e59-A51-THE_FOUNDRY-00000246?page=1

It's related with #5028 I'm thinking if we should hide mint and burns on the tabs of activity on rmrk2. WDYT @roiLeo

Why? I find it important to have information of the mint date.
more or less the same thing for burn

It's related with #5028 I'm thinking if we should hide mint and burns on the tabs of activity on rmrk2. WDYT @roiLeo

Why? I find it important to have information of the mint date. more or less the same thing for burn

why was it hidden on rmrk2?

It's related with #5028 I'm thinking if we should hide mint and burns on the tabs of activity on rmrk2. WDYT @roiLeo

Why? I find it important to have information of the mint date. more or less the same thing for burn

@vikiival may tell us if we could have the mint and burns information on rmrk2.
related changes:

why was it hidden on rmrk2?

I think it's because interaction changed on rmrk2 compared to v1
MINTNFT => MINT
CONSUME => BURN

why was it hidden on rmrk2?

I think it's because interaction changed on rmrk2 compared to v1 MINTNFT => MINT CONSUME => BURN

I've checked the indexer and currently, I don't think there are burn events indexed?

Mints are present however, maybe let's create a new issue for handling of the newly named events in gallery item? I can work on it. wdyt @Jarsen136 @roiLeo

I've checked the indexer and currently, I don't think there are burn events indexed?

This indexer is still in beta some of the features are not correctly implemented.
Like BURN event isn't handled yet.

what should be done here to move this forward ? 🤔 are we hiding the tabs for rmrk2? or altering it somehow else ?

👀 @vikiival

pay 30 usd

😍 Perfect, I’ve sent the payout
💵 $30 @ 37.45 USD/KSM ~ 0.801 $KSM
🧗 JHJGu2aWyAFBfcso8bR7ma82p15YAavyN6vQfJyWuhniNGa
🔗 0x2140c978ce363ebeb725895990cfb28492cc1961acde8b2aec3a22bd8b431f01
🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues


FIX: Ignore resource fork files left by OSX

Maybe an obscure "bug", but if the usb_share mount is mounted by OSX over samba and one copies a file over, OSX creates resource fork file with a file name matching the data file but prefixed with ._.  Because the file extension matches the sliced file, mariner appears to believe that the resource fork should be a valid sliced file, but when it attempts to scan the directory and read the sliced files the server throws a UnicodeDecodeError (resulting in a HTTP 500 error) because, of course, it isn't a sliced file.
I added a little check to mariner.server.api so that as mariner walks over the files, it peaks at the first line of the file to make sure it doesn't look like a resource fork.

From what I've found and observed, the resource forks typically start with a ._ prefix, but I am also pretty sure I've seen Chitubox mangle a filename like that too.  In any case, I changed things so that the peak into the first bit of the file is only done if the filename begins with ._

Thanks @milescsmith, this should help. Can you just add the tests I mentioned above before we merge this?

Oops, sorry I missed the unit test the first time - completely didn't see that!
I added a bit on to the tests.test_server.MarinerServerTest.setUp() and test_list_file() tests to include the resource fork file and check that it is not printable.  Let me know if that wasn't what you were looking for for a test.

Yup this looks great, thanks @milescsmith!


Can change dateLabel color for events but not dateLabel.backgroundColor

Using version 7.1.5
I have the monthly calender collection view set up and a xml that I am parsing to get some dates. I am trying to show these dates with round borders on the calendarview but am running into an issue that I'm not sure how to fix - dates that are not from the xml also show up with borders around them and then random change when you scroll to the next month and back, like this - https://imgur.com/a/mxyUtJe
At the bottom of the this post, I also try to just change the label.textColor for the dates found in XML and for reasons I dont understand, that works correctly but the label.backgroundColor does not.
Here is my code for settings borders right now. Is there anything visibly wrong or missing?
    //Mark: Configure Calendar Cell
    func configureCalendarCell(cell: JTAppleCell?, cellState: CellState) {
        guard let myCustomCell = cell as? CalendarCell else { return }

        //configure functions including:
        getEventDates(cell: myCustomCell, cellState: cellState)
    }

    //Mark: set events from XML == selected cell from Calendar
    func getEventDates(cell: CalendarCell, cellState: CellState) {

            for calendarDate in tableViewDataSource {
                let datesFromCalendarXML = calendarDate.date
                //print("Found \(datesFromCalendarXML)") This prints dates parsed from XML file - See picture if helpful - https://imgur.com/a/3BAEaOf

                let visibleDatesToString = formatter.string(from: cellState.date)
                //print("Visible dates \(visibleDatesToString)") This prints all of the dates in the current month showing. So for September, it shows all of the dates in September. See picture if helpful - https://imgur.com/a/cedVA3J

                // If there is a date match, then show a round blue border
                if datesFromCalendarXML == visibleDatesToString {

                    cell.dateLabel.layer.cornerRadius = 25
                    cell.dateLabel.layer.borderWidth = 3
                    cell.dateLabel.layer.borderColor = UIColor.blue.cgColor
                    cell.dateLabel.clipsToBounds = true

                // If there is no date match, show no border. I had set this to UIColor.clear.cgColor but then only the last datesFromCalendarXML Oct 30 showed as a blue, so I changed it to red and saw that random dates including the ones from the XML are being circled red.
                } else if datesFromCalendarXML != visibleDatesToString {
                    cell.dateLabel.layer.borderColor = UIColor.red.cgColor
                    cell.dateLabel.clipsToBounds = true
                }
        }
    }
}

It seems this only works for the last value in datesFromCalendarXML as Oct 30 shows up with a blue ring. The other values in the XML, Sept 1, 10, 20 and Oct 1, 10, 20 show up with red rings as do other random dates.
.....
I then tried to just change the color of the datelabel instead to green and for whatever reason, that works correctly to make only the matched dates green and does not add random other green dates. I have no idea why I can change the dateLabel.textColor and not the background - https://imgur.com/a/St3b8ND
if datesFromCalendarXML == visibleDatesToString {
                cell.dateLabel.textColor = UIColor.green

            } else if datesFromCalendarXML != visibleDatesToString {

            }

Do you know why it works this way?

This looks like code that is more specific to your project, but not specific to the calendar library. I am trying not to respond to questions like these because i am getting way to many of them and and cannot keep up.
But just you give you a tip, it looks like your code in this function might be wrong
func getEventDates(cell: CalendarCell, cellState: CellState) { ... }

In that function you have a loop.
So imagine this, a Cell goes to that function to have its color changed.
It enters the for-loop of that function and then hits this line of code
if datesFromCalendarXML == visibleDatesToString {

So lets say the dates are equal. It will enter that if-statement and run this code right?
                    cell.dateLabel.layer.cornerRadius = 25
                    cell.dateLabel.layer.borderWidth = 3
                    cell.dateLabel.layer.borderColor = UIColor.blue.cgColor
                    cell.dateLabel.clipsToBounds = true

ok great all is well. The cell is configured.
But then there is a problem. You have a for-loop
Therefore that same cell is again run in the for-loop where it again hits this line of code
if datesFromCalendarXML == visibleDatesToString {

Now, on this 2nd run of the for-loop, the value is false, therefore it runs this line of code.
cell.dateLabel.layer.borderColor = UIColor.red.cgColor
cell.dateLabel.clipsToBounds = true

You have now successfully unconfigured the cell you have just configured. And there is your bug.
Now given the length of this explanation, you can see why i am trying not to answer questions which are unrelated to the library.
But i hope you have enough info to fix this now.
Closing this issue :)


Comparison Matrix

Create a matrix comparing DoneJS Features with other libraries.

Notes:
X-Axis: Frameworks
Y-Axis: Features

@julia-allyce @moschel
Here's my first take at a comparison graph for the site.   I really like the idea of using Emoji's because I think so many people understand them today, regardless of demographics.  Additionally, they express more emotion than the consumer reports icons.  You can almost understand what the emoji means, without referencing the legend.
I started with regular emjoi's which is sort of the fast and easy approach.  It works, but once you put a lot of them in the grid, it tends to get confusing because of how close the colors are.

In the next iteration below, I use emoji's but go with flat colors and unique color for each.  So now, we get the emotion of the emoji itself and also the color spectrum. Green = Good down to Red = Poor.  I decided to keep "All the Things" because it's awesome.

Please let me know your thoughts.

@atomgroomdesign when I looked at the first one, I thought it would be nice if you used color, so you really came through immediately when I clicked on the second one.  Color is way better, imo.
Looking at the color one, I think it would be nice if you could use color boldness (I'm no designer, so this is what I'm calling it) to draw attention to the ones that perform the best.    But I really like the "All The Things" guy as the epitome of awesomeness.  If there were a way to keep him and still use boldness to make things stand out, that would be cool.
imo

Cool. Thanks for the feedback.  Brian mentioned the same earlier today.  I'll have to play around with the colors a bit more.  Brian mentioned lowering the opacity of the middle tier colors so the extreme end colors get the attention you speak of.
Although, I would like to add a feature for when the user hovers an icon in the legend - that icon gets highlighted and all others lower in opacity.   So, the opacity above, would conflict.  I think just going with more subtle colors will be the right approach.

Here's another iteration with all the above feedback considered:

I think a 1-5 rating is a bad idea. People are already skeptical about comparisons. Giving ratings will just make peoples' eyes roll.
Take the subjectivity out of the equation. Does the framework support the feature or not?  If the answer is "kinda" put an asterisks and explain it.


Feature request: Provide support for options, login_hint and additional url parameters in popup overload

Is your feature request related to a problem? Please describe.
In an application we want to provide an option for a quick user-switch, without losing the state of the current components.
For that we'd like to open up a sign-in Popup on the AS (using auth code flow with pkce), and provide a login_hint (we know the user we want to switch to), as well as optional acr_values to the AS.
We noticed that the method that starts the login in a popup window does not accept the login_hint and also no additional url_parameters.
Describe the solution you'd like
While looking at the code we noticed that the method initLoginFlowInPopup does internally use a method that accepts both the login_hint as well as additional parameters, but does not expose these in its own signature:
https://github.com/manfredsteyer/angular-oauth2-oidc/blob/master/projects/lib/src/oauth-service.ts#L1062-L1071
It would be awesome if the method would expose at least the required, but ideally all parameters of the initLoginFlow method (additionalState, params) and pass them along.
Describe alternatives you've considered
Sadly no other idea comes to our mind ;)
Additional context
None.
We could also think of doing this ourselves and provide a PR, if you'd be willing to accept this.

Makes sense to me. It'll be up to the maintainer to tag it 'pr-welcome' but I presume the popup version should support the same stuff the other one does?

Ideally yes. I could think of simply adding the arguments to the end and pass the expected default values if they are undefined, a bit like so so:
 public initLoginFlowInPopup(options?: { height?: number; width?: number }, additionalState: string = '', loginHint: string = '', additionalParameters: object = {}) {
    options = options || {};
    additionalParameters.display = 'popup';

    return this.createLoginUrl(
      additionalState,
      loginHint,
      this.silentRefreshRedirectUri,
      false,
      additionalParameters
    ).then(url => {

But of course this needs testing etc.

hi ,
is this issue going to be promoted?
we also need this solution to our project.
thanks a lot.


Question: How to use components in a contrast color

Text field has a dark border and color.

If I want to use it in a App Bar, must I set all those CSS custom variables to get this?

      background: rgba(255, 255, 255, 0.2);
      --mdc-text-field-filled-border-radius: 4px;
      border-radius: var(--mdc-text-field-filled-border-radius);
      --mdc-text-field-idle-line-color: rgba(255, 255, 255, 0.4);
      --mdc-theme-primary: rgba(255, 255, 255, 0.6);
      --mdc-text-field-idle-line-color: rgba(255, 255, 255, 0.6);
      --mdc-text-field-hover-line-color: white;
      --mdc-text-field-disabled-line-color: white;
      --mdc-text-field-outlined-idle-border-color: white;
      --mdc-text-field-outlined-hover-border-color: white;
      --mdc-text-field-outlined-disabled-border-color: white;
      --mdc-text-field-ink-color: white;
      --mdc-text-field-label-ink-color: white;
      --mdc-text-field-disabled-ink-color: white;

At the moment yes, this is what you need to do to change the theme to achieve a "dark mode".
We're investigating a theming system in #1072 that will make things easier so that it's a bit easier to write light/dark themes for your components.


[Impeller] Support Variable Rate Shading in the HAL.

Similar to MSAA where the fragment shader is run once per fragment and that value broadcast to all the samples covered by that fragment, Variable Rate Shading runs a fragment shader once per tile of fragments (2x2, 4x4, and even rectangular tiles like 2x1) before broadcasting that value to all fragments within that tile (which is then subsequently broadcast to the samples within that fragment if MSAA is enabled).
This technique is useful when we are going to run the fragment shader to create details that are subsequently going to be destroyed. Like when applying blurs.
Variable Rate Rasterization seems to be supported on all iOS devices in Apple A13 (in the iPhone 11) and above. On Android, two similar Vulkan extensions are VK_KHR_fragment_shading_rate and VK_EXT_fragment_density_map. For Impellers use case, the two Vulkan extensions seem identical and they seem to be supported on ~45% of Vulkan 1.1 capable Android devices. Happily, there is a great overlap between devices that support these extensions and also devices that support higher refresh rates. This is presumably because the higher refresh rate devices are marketed as “gaming” phones with refresh rates as high as 144Hz. So phones that support these extensions also have more demanding workloads.
For Impeller, the use-case is very simple as there is no need to figure out rasterization rates for different parts of the scene. Instead, a uniform rasterization rate can be applied to entire render passes. For this reason, in the HAL, impeller::RenderTarget::SetRasterizationRate(Rect rate); seems like an API with the right tradeoffs in terms of usability and ease of implementation.
Setting a rasterization rate of Rect::MakeWH(0.5f, 0.f5) would mean rasterizing at least at half-rate along each axis.
In the implementation, APIs like Vulkan support either pipeline or rate-map specified rasterization rates. In the former, the pipeline descriptor specifies the rate. In the latter, the rates are specified based on the values encoded in a map. While the former sounds appealing from the perspective of ease of implementation, it increases the pipeline variant load. So implicitly created rate maps seem like the way to go.
This should give us some much needed performance headroom on high refresh-rate and/or high pixel-density devices.
For Impeller's current use-case, this should be sufficient. But it should be possible to augment this API further by specifying a texture as the rate map directly. But I can’t think of a use-case we’d need this much more complicated (to implement) API for.
Recommended watches: https://www.youtube.com/watch?v=_p236TqUuDU and https://developer.nvidia.com/video/GDC-19/ADAPTIVE_SHADING.

@chinmaygarde says to close this!


when only 1 redis backend is set, rkv get query returns unexpected error "the number of nodes is 1, which means there is no replica"

after posting values for a specific key, query of its value returns unexpected response: the number of nodes is 1, which means there is no replica
What is expected: the latest value of the key
What is specific: only one (the local) redis is set up
How to reproduce

set up the local redis server, e.g. listening at <IP_ADDRESS>:16378
modify config.json file accordingly like below

{
    "ConsistentHash": "rendezvous",
    "BucketSize": 10,
    "ReplicaNum": 1,
    "StoreType": "redis",
    "Concurrent": true,
    "Stores": [
        {
            "RegionType": "local",
            "Name": "store1",
            "Host": "<IP_ADDRESS>",
            "Port": 16378
        }
    ]
}

start rkv server
run command to post value of key curl -X POST <IP_ADDRESS>:8090/kv -d '{"key":"testk", "value":"testv"}'; notice the response is The key value pair (testk,testv) has been saved as revision 6 at <IP_ADDRESS>:16378, assuming success
run command to get back its value curl  <IP_ADDRESS>:8090/kv?key=testk
the response is

the number of nodes is 1, which means there is no replica

Please refer to https://github.com/CentaurusInfra/kv-store-poc/blob/main/src/kv_store/piping/chain_piping_manager.h#L63
throw std::logic_error("no replica to read from for rev " + std::to_string(rev)); // (╯°□°)╯︵ ┻━┻
We read values from replicas not from primary. If there is one node, which means there is no replica at all. Therefore, it fails to read values.
Please let me know if there is any design change.


New DefaultValue type class.  Make TxBodyContent an instance of DefaultValue

TxBodyContent is now an instance of DefaultValue, allowing things like
foo :: TxBodyContent BuildTx BabbageEra
foo = defaultValue { txValidityRange = someValidityRange }

bar :: TxBodyContent BuildTx BabbageEra
bar = defaultValue { txIns = someTxIns, txOuts = someTxOuts }

baz :: TxBodyContent BuildTx BabbageEra
baz = defaultValue { txOuts = someMoreTxOuts }

This is an alternative to https://github.com/input-output-hk/cardano-node/pull/4458.
We don't seem to be able to agree on what the Semigroup instance should do out of a number alternatives and if there is confusion with choosing the behaviour, there will likely be confusion using the instance.
The idea behind this alternative is that we shouldn't arbitrarily choose a behaviour for the Semigroup instance because there is a high probability people who use our instances might assume it does something else.

Unfortunately I wanted this to work, but type inference fails because of use of GADTs:
foo :: TxBodyContent BuildTx BabbageEra
foo = defaultValue { txValidityRange = someValidityRange }

bar :: TxBodyContent BuildTx BabbageEra
bar = defaultValue { txIns = someTxIns, txOuts = someTxOuts }

baz :: TxBodyContent BuildTx BabbageEra
baz = defaultValue { txOuts = someMoreTxOuts }

Unfortunately, this doesn't work as well as I'd like it to.  As you add more fields, it increases the chance that GHC cannot infer the types:


Supress warning when 2 meshes don't intersect

I'm using vedo to get the intersection points between a lot of pairs of meshes using intersectWith().
Now, when 2 meshes don't intersect, i get the following message:
2022-09-12 23:39:58.016 (2936.989s) [                ]    vtkPointLocator.cxx:845    ERR| vtkPointLocator<PHONE_NUMBER>2F5010): No points to subdivide
2022-09-12 23:39:58.020 (2936.993s) [                ]vtkIntersectionPolyData:2410  WARN| No Intersection between objects
This is perfectly expected since many of the meshes combinations don't intersect (and checking if they do is part of the point of this), my question is, is there any way to just supress this warning? I'm testing a lot of meshes and it's really annoying to flood the terminal with thousands of warnings.
I think there must be some arg to just make the output less verbose, but haven't been able to find it.

Hi, I just pushed a version where the warning is silenced.
pip install -U git+https://github.com/marcomusy/vedo.git
let me know if it works for you.

Give me a bit please, when trying to uninstall vedo it broke my entire env.

I'm getting an error when trying to install:
ERROR: Could not find a version that satisfies the requirement vtk<9.1.0 (from vedo) (from versions: 9.2.0rc1, 9.2.0rc2)
ERROR: No matching distribution found for vtk<9.1.0

Don't worry, i just defined/adapted the function myself and added the bf.SetGlobalWarningDisplay(0).

Oh ok - vedo can work with vtk9.2 as well,
you would need to add --no-deps to pip.


d3.merge(iterables[, accessor]) ?

I noticed that most of the time when I use d3.merge, I need to map my input array to access the lists to flatten.
With almost all d3.array functions providing an optional accessor, d3.merge would probably also benefit from having an accessor parameter.

Have you tried array.flatMap? Some examples here:
https://observablehq.com/@d3/d3-merge

Damn, last I tried using flatMap it wasn't part of javascript!
Indeed, thanks!


[Weighted Shard Routing] Fail open weighed away AZ

Is your feature request related to a problem? Please describe.
https://github.com/opensearch-project/OpenSearch/issues/2859 aims to support weighted shard routing policy. The search request at the coordinator performs a weighted round robin to route requests to shard copies.
These weights are set by making PUT API call
PUT /_cluster/routing/awareness/<attribute>/weights
{
      "zone_1": "1",
      "zone_2": "1",
      "zone_3": "0"
}

Once the weights are set, the search request is tried on shard copies in weighed round robin manner.
Normally if search request on a shard copy fails, the request is retried on all remaining copies until it succeeds. In case a zone is weighed away by setting weighted routing weight to 0, the shard search request is not performed on shard copies present in that zone.
So in this case, if shard search request returns 5xx from all shard copies in non-weighed away zone, the response returned is 5xx even though there are shard copies in weighed away zone that can serve the request.
Describe the solution you'd like
In these scenarios we can fail open i.e. coordinator request for shard copies can go to nodes in weighed away zone. This helps in reducing the number of 5xx responses as well as better shard availability. In other case, where shard search requests return 4xx due to throttling from shard copies in non-weighed away zone, we don't need to fail open. So basically if the request fails due to internal issues in the cluster we fail open for search requests.

Hi @anshu1106 , thanks for your suggestion, but based on my understanding, if a shard put in a weighted away zone, that was for purpose and this shard won't expect any search request. So, I don't think it make sense to route failed search request to this zone.

@anasalkouz , the search request gets routed to weighed away az only in cases there are 5xx returned from remaining azs ie there are no healthy shard copies to serve the request. Since write requests are sent to data nodes in weighed away az until they are decommissioned in case of AZ failures, we are expecting shard copies to be available. This will help in increasing the availability of cluster for read requests.

@anshu1106 this is tagged 2.5, do you need any help getting this done?
Code freeze is tomorrow.

Thanks for checking. We were able to merge the changes today.

Thanks for checking. We were able to merge the changes today.

@anshu1106 Can you please close the issue to mark it done?


rtabmap_ros: 0.21.1-3 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository rtabmap_ros to 0.21.1-3:

upstream repository: https://github.com/introlab/rtabmap_ros.git
release repository: https://github.com/introlab/rtabmap_ros-release.git
distro file: noetic/distribution.yaml
bloom version: 0.11.2
previous version for package: 0.21.1-1

This release can be merged once the pending Noetic sync is complete.

Note this was a quick fix to unblock the build farm (missing stereo_msgs dep), otherwise current rtabmap_ros doesn't build.

Note this was a quick fix to unblock the build farm (missing stereo_msgs dep), otherwise current rtabmap_ros doesn't build.

Thanks for the context @matlabbe, I usually recommend linking regression-fix PRs in the sync thread on Discourse for visibility since it is generally the ROSboss who will decide to override the sync hold.
@sloretz the decision to override the hold lies with you.


How to write class condition rule in K

I'm trying to implement the Class Condition of conditional statements (COBOL) into K.
I've already implemented with success the logic of:

IF [condition] THEN .. ELSE .. END-IF
Relation Condition (IS GREATER THAN,IS LESS THAN..)
Sign Condition (IS POSITIVE,...)
Negated Condition (IF NOT...) --> Opened issue last week but then i've resolved myself

Now i'm trying to implement the class condition for this statement but i cannot figure how to do it..
"Class condition is used to check if an operand contains only alphabets or numeric data. Spaces are considered in ALPHABETIC, ALPHABETIC-LOWER, and ALPHABETIC-UPPER."
I've tried to use some functions of the string library of K (/k/include/builtins/string.k)
My current implementation is (Faulty and not optimized):
syntax Int ::= "lengthString" "(" String ")" [function, klabel(lengthString), hook(STRING.length)]
syntax Int ::= "ordChar" "(" String ")"      [function, klabel(ordChar), hook(STRING.ord)]

rule I:String IS ALPHABETIC-UPPER => (ordChar(I) >=Int ordChar("A")) AND (ordChar(I) <=Int ordChar("Z"))

But work only in case of the variable I is composed by a single character, i thought that i compare every single char but i'm not able to figure how to do
Can someone give me a hint for implement that?
I've searched in all tutorials and on the official site, but nothing is able to help me
@cos @grosu @dwightguth
Thanks to all for the help

@manueldallavalle, did you figure out a solution?
There are a couple of ways to do this. We can talk if it's still a problem.


integrate with travis-ci

We should install and test using travis-ci

Implemented on master (v1.1.0)
Upgrade Information
Continuous Integration for laxar-uikit was added. Integration can be monitored at https://travis-ci.org/LaxarJS/laxar-uikit and is indicated by a badge in the repository README.md


Support for .diff and .patch mediatypes

GitHub API allows to set Accept header to application/vnd.github.v3.diff and application/vnd.github.v3.patch to return raw diffs and patches. This raises error in Tentacat because response body is always processed by JSX.decode!. Even if it is not json

I'm looking to get diffs from tentacat too. @smetana did you find a solution?

We use direct call to HTTPoison.get
 def get_diff(url, client) do
   headers = [{"Accept", "application/vnd.github.v3.diff"}]
   headers = Tentacat.authorization_header(client.auth, headers)
   response = HTTPoison.get!(url, headers)
   response.body
 end


Different policy.json layout from containers/image

As containers/image published new field in policy.json to support sigstoresign(including cosign), this format is a little different from ours.
Theirs is like
{
    "type":    "sigstoreSigned",
    "keyPath": "/path/to/local/keyring/file",
    "keyData": "base64-encoded-keyring-data",
    "signedIdentity": identity_requirement
}

And ours do not change type field when this Policy Requirement is a signing scheme. If cosign is supported by us, the format will be like
{
    "type":    "signedBy",
    "scheme": "cosign",
    "keyPath": "/path/to/local/keyring/file",
    "keyData": "base64-encoded-keyring-data",
    "signedIdentity": identity_requirement
}

The scheme field is brought in https://github.com/confidential-containers/image-rs/pull/31. Because the type may include insecureAcceptAnything and reject, we introduced scheme field to show that "this policy is to verify signature, and the signing scheme is XXX" rather than extended type.
The question is whether we should modify our existing layout of Policy Requirement to follow the containers/image's?
IMO, our layout scheme is better for

More understandable and extensible for new signing schemes and Policy Requirements.
Our pr is earlier than the  containers/image's.

Originally posted by @Xynnn007 in https://github.com/confidential-containers/image-rs/issues/39#issuecomment-1186708165

Hi @sameo @fitzthum @jialez0 , we follow the signature verification policy file defined by containers/images  at the beginning, and we introduce scheme filed to support different signature schemes like cosign, but we just found containers/image also added the cosign support and utilize the type field: https://github.com/containers/image/commit/64756915ba0e05baa52d1b911c401e05f540b3bf
Should we follow the containers/image format or continue our own definition?

Well my hunch would be to follow containers/image. We might have been first, but I think most people will care more about what they do. I do see how our version could be nicer, but honestly I don't know much about the image-rs code. We can ask people to take a look at this issue during the Thursday meeting and hopefully generate some discussion.

Well my hunch would be to follow containers/image. We might have been first, but I think most people will care more about what they do. I do see how our version could be nicer, but honestly I don't know much about the image-rs code. We can ask people to take a look at this issue during the Thursday meeting and hopefully generate some discussion.

Yes. I think we can flexibly change our format to avoid compatibility issues. Some fixes are introduced in this commit for docs
https://github.com/confidential-containers/image-rs/pull/39/commits/8476136e677715605d168be0e862edece5af2754. If ok, please close this issue and help to review the PR https://github.com/confidential-containers/image-rs/pull/39.
And I'd like to carry on cosign support.

Well my hunch would be to follow containers/image. We might have been first, but I think most people will care more about what they do. I do see how our version could be nicer, but honestly I don't know much about the image-rs code. We can ask people to take a look at this issue during the Thursday meeting and hopefully generate some discussion.

Same here, I think we should be in sync with the containers/image format.

Well my hunch would be to follow containers/image. We might have been first, but I think most people will care more about what they do. I do see how our version could be nicer, but honestly I don't know much about the image-rs code. We can ask people to take a look at this issue during the Thursday meeting and hopefully generate some discussion.

Yes, thanks. I think we can flexibly change our format to avoid compatibility issues. Some fixes are introduced in this commit for docs https://github.com/confidential-containers/image-rs/pull/39/commits/8476136e677715605d168be0e862edece5af2754
If ok, please close this issue and help to review the PR https://github.com/confidential-containers/image-rs/pull/39.

Could you please have that PR close that issue by including a Fixes # line in one of the commit?


Adding optional config

This PR includes:

Adding optional config argument
Fixing pipeline unittests (image files with randomly generated name)

@HonzaCuhel Added minor comments and changes. Otherwise great job, thanks!


HCT produces unexpected RGB values

This is most noticable when the seed color is yellow:

Background color is Primary 98.
I have made a graph that shows the RGB value, with chroma set to 100:

I included CAM16 (that also seems to be broken) and HSL as a reference. These images were made using my C# library, but it shouldn't have any differences, as most of it is just the Java version copy-pasted. I also added every test from the Dart library, which are all passing.
Setting the chroma to a lower value seems to alleviate the problem a bit:

This was made with Flutter, here is the code for that:
import 'package:flutter/material.dart';
import 'package:material_color_utilities/material_color_utilities.dart';

void main() {
  runApp(CustomPaint(
    painter: ColorsPainter(),
  ));
}

class ColorsPainter extends CustomPainter {
  @override
  void paint(Canvas canvas, Size size) {
    for (double x = 0; x < 360; x++) {
      for (double y = 0; y < 100; y++) {
        HctColor hct = HctColor.from(x, 100, y);
        canvas.drawCircle(Offset(x, y), 1, Paint()..color = Color(hct.toInt()));
      }
    }
  }

  @override
  bool shouldRepaint(ColorsPainter oldDelegate) {
    return false;
  }
}

Flutter code for the CAM16 graph (produces the same result as C# above):
import 'package:flutter/material.dart';
import 'package:material_color_utilities/material_color_utilities.dart';

void main() {
  runApp(CustomPaint(
    painter: ColorsPainter(),
  ));
}

class ColorsPainter extends CustomPainter {
  @override
  void paint(Canvas canvas, Size size) {
    for (double x = 0; x < 360; x++) {
      for (double y = 0; y < 100; y++) {
        Cam16 cam = Cam16.fromJch(y, 100, x);
        canvas.drawCircle(
            Offset(x, y), 1, Paint()..color = Color(cam.viewedInSRgb));
      }
    }
  }

  @override
  bool shouldRepaint(ColorsPainter oldDelegate) {
    return false;
  }
}

After looking around for a while I found Okhsl, which produces very similar results, so this is most likely intended.


Regarding contributions

Maybe this is not the right place to ask for the issue but currently the "Longest streak" shows dates without year. Rather it should be showing dates with year so that it is more clear about the duration of the longest streak. Same applies to "Current streak".

@iamshubh22 the best place to raise a question about this would be contacting GitHub support.
Thanks!


Gardens on xDai: test that native Garden tokens are able to migrate to mainnet

Related to: https://github.com/Giveth/giveth-planning/issues/257#event-4860420227

:-D! @eduadiez and @crisog are talking about it at least for Giveth... and Edu is confident about being able to technically pull it off... that said, i would love to see this automated for other projects


iTunes Submission Error - ERROR ITMS 9035

Hi,
First of all, thanks for working on Dollar. I've got a particular error while submitting the IPA archive to iTunes store. Please see the image below:

I was getting this error in one of the apps that I am working on now. In order to replicate the issue, I tried submitting this app ( with bundle ID changed ) to iTunes.
Some other details include:

Code Signing Identity set to Distribution
Provisioning profile: Distribution

Any idea what could be the issue ?
Cheers
Hemanta

Is this something your project can sign https://developer.apple.com/library/mac/technotes/tn2206/_index.html#//apple_ref/doc/uid/DTS40007919-CH1-TNTAG13
Will take a look at other projects to see what they are doing.


[SYSTEMML-1083] Fix spelling of "Demonstration" in VLDB award

changed the spelling from "demonstation" to "demonstration in VLDB award

LGTM. Thank you @jazares.


Issues Migrating to Rocket

I am in the process of migratring to rocket and came up with the following rocket.config.mjs file:
import { createSpaConfig } from '@rocket/building-rollup';
import { absoluteBaseUrlNetlify } from '@rocket/core/helpers';
import { rocketLaunch } from '@rocket/launch';
import { copy } from '@web/rollup-plugin-copy';
import autoprefixer from 'autoprefixer';
import cssnano from 'cssnano';
import merge from 'deepmerge';
import {
  addPlugin,
  adjustPluginOptions,
} from 'plugins-manager';
import postcss from 'rollup-plugin-postcss';
import svgo from 'rollup-plugin-svgo';
import visualizer from 'rollup-plugin-visualizer';

const baseConfig = createSpaConfig({
  absoluteBaseUrl: absoluteBaseUrlNetlify(
    'http://localhost:8080'
  ),
  // development mode creates a non-minified build for debugging or development
  developmentMode: process.env.ROLLUP_WATCH === 'true',
  // set to true to inject the service worker registration into your index.html
  injectServiceWorker: false,
  // if you use createSpaConfig, you can use your index.html as entrypoint,
  // any <script type="module"> inside will be bundled by rollup
  input: 'index.html',
  // alternatively, you can use your JS as entrypoint for rollup and
  // optionally set a HTML template manually
  // input: './app.js',
  // use the outputdir option to modify where files are output
  output: { dir: 'build' },
  presets: [rocketLaunch()],
});

export default merge(baseConfig, {
  output: {
    assetFileNames: 'assets/[name]-[hash][extname]',
    chunkFileNames: 'static/js/chunks/[name]-[hash].js',
    // TODO: rename to [hash].js before deploymentout
    entryFileNames: 'static/js/[name]-[hash].js',
    format: 'es',
  },
  setupBuildPlugins: [
    addPlugin({
      name: 'copy',
      options: { patterns: 'assets/css/**/*' },
      plugin: copy,
    }),
    addPlugin({
      name: 'postcss',
      options: {
        extract: true,
        plugin: [autoprefixer(), cssnano()],
      },
      plugin: postcss,
    }),
    addPlugin({
      name: 'svgo',
      options: {
        // See https://github.com/svg/svgo#what-it-can-do
        removeAttributesBySelector: true,
        removeOffCanvasPaths: true,
        removeRasterImages: true,
        reusePaths: true,
        sortAttrs: true,
      },
      plugin: svgo,
    }),
    addPlugin({
      name: 'visualizer',
      options: {
        brotliSize: true,
        gzipSize: true,
        template: 'treemap',
      },
      plugin: visualizer,
    }),
    adjustPluginOptions('importMetaAssets', {
      transform: (assetBuffer, assetPath) => {
        return assetPath.endsWith('.svg')
          ? svgo
              .optimize(assetBuffer.toString())
              .then(({ data }) => data)
          : assetBuffer;
      },
    }),
    // workaround for development vs build relative paths
    adjustPluginOptions('html', {
      transform: (html) =>
        html.replace(/href="\.\/public\//g, 'href="./'),
    }),
  ],
});

When trying to build the project using rimraf build && tsc && rocket -c rocket.config.mjs I am getting the following error message:
yarn build
yarn run v1.22.5
$ rimraf build && tsc && rocket -c rocket.config.mjs
(node:23104) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'includes' of undefined
    at RocketCli.considerPlugin (file:///C:/Users/ateyar/Documents/GitHub/x-wc/node_modules/@rocket/cli/src/RocketCli.js:188:28)
    at RocketCli.run (file:///C:/Users/ateyar/Documents/GitHub/x-wc/node_modules/@rocket/cli/src/RocketCli.js:145:16)
(Use `node --trace-warnings ...` to show where the warning was created)
(node:23104) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:23104) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Done in 10.61s.

I went through the doc couples of times but can't figure out why I am getting that. Could you please advise on how to make this work, and ways I could improve this config?

oups I somehow missed that 😅 sorry about that... 🙈
I don't think this is still applicable in the latest version using @rocket/engine? 🤔
I'm closing it - if it still needs fixing feel free to reopen or creating a new issue 🤗


Add tvOS target

Added tvOS target.
Made HeroDebugPlugin and HeroDebugView unavailable until UISlider functionality is replaced with continuous gesture.

I will merge now before I do any works to cause conflicts. Thank you!

Alright! If you still want any changes let me know :)


Add support for real_[i]fft

This is a tracking issue for adding support for real versions of the fft operations using the realfft crate.
Currently it does not seem like it's possible to have a safe API for
real_fft and real_ifft operations.
Firstly, using these functions from outside the crate does not work at
all and causes an ICE:
https://github.com/rust-lang/rust/issues/101125
Secondly, rust does not allow for generic code that operates on arrays
without specifying the bounds. For this, rust needs to have a way of
expressing "unification" or "proving disjointness" for a set of
impl's:
https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/Exhaustiveness.20Checking.20in.20Types
I've asked on reddit about this case:
https://www.reddit.com/r/rust/comments/wy9sk1/can_you_have_a_function_return_different_types/
And got response:
But Chalk may allow you to implement what you actually want (different
cases for odd and even numbers).

Fixed as a result of @jknodt's answer in this thread:
https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/Exhaustiveness.20Checking.20in.20Types


Adding docs for Attach policies

Purpose

Adding overview for attach policies
Adding the skeleton doc for attaching policies. Need to get code snippets and add.

Screenshot
Overview

Add Policies

Related to
https://github.com/wso2/docs-apk/issues/87

Updated


[TACHYON-670] Fix location on the master side

#1123 Fixes the issue for when the block is in Tachyon by changing the worker addresses to not use getCanonicalHostname. When we retrieve the location from the under storage, we also should not resolve the hostname.

+1 LGTM

+1 LGTM


Added command to generate a View with its ViewModel and an optional Model

I don't know about you people, but I got tired of always having to create these files one by one. So I made this command to generate all these files at once. It's my first VSIX so it will be probably messy for you (critics are welcome).
It basicaly adds a command at the context menu for a given project that pops a dialog which prompts the user for the page name, if it should generate a model and if the user wants the files to be opened once created.
I used T4 templates to generate the files based on the default structure of T10 [Project name] / [View | ViewModel | Model] and with the namespace of the project. It's also ready for localization.
I hope you find it usefull!

I think we can do this more simply with an Item Template. I tell you what @RafaelPlantard, I am impressed that you figured out the VSIX system since it is so poorly documented and works in such a cryptic way. What you might research is if you can add a command that can interact with an Item Template. Nothing wrong with right-clicking a Views folder and "Add View". The thing is, I am about to introduce a large list of Item Templates that accomplish different tasks. This will allow developers to add views that do things like add Map, add Inking, add data binding, add Image gallery, and stuff like that. I want to ensure we go down THAT bath before we worry with the VSIX. And between you and me, a VSIX package is annoyingly difficult to maintain. Please don't misread this as not being appreciative for your work. It's really great. Maybe you can be part of the team to build out item templates? I would welcome the help of developers who know how to code.

I'll be glad to help! Just fill me in and let the party begin!
About the VSIX, my idea wes to give the user the minimum amount of options. Sometimes it's difficult to choose between a user control or a templated control, so just creating a "page" did the job. But yes, I spent a couple days figuring out the constants and functions. A bit of a pain but the needs of the many outweigh the need of the few, right?


Triple-click highlights more than current line

When triple-clicking on a code sample (the CREATE CONTIUOUS QUERY code in the screenshot below) I'd expect only the code sample to become highlighted. Instead, the sections above (both "CQ definition" and "InfluxQL for creating a CQ") are selected.

This makes copying code samples tedious (this is necessary, because I can't see the whole sample and need to paste it in my editor, cf. #357).
The cause for this behavior is found in typography.css:
.page--body pre /* and others */ {
  display: inline-block;
  /*...*/
}

--Dominik
URL for relevant page?
e.g. https://docs.influxdata.com/influxdb/v0.12/query_language/continuous_queries/#the-create-continuous-query-statement
What products and version are you using?
Google Chrome 49.0.2623.110 (current stable) on Debian Jessie/8.4
Where did you look before opening the issue?
n/a

Thank you for pointing this out, @dmke. I see what you mean and this will be fixed by https://github.com/influxdata/docs.influxdata.com/pull/352.

Fixed by https://github.com/influxdata/docs.influxdata.com/pull/352


[chrome] after reading and closing, unable to highlight text on the page again

When I read a section of a page then I press ESC and Squirt goes away, I am not longer able to highlight any text on the page. 👎
Chrome Version 51.0.2704.22
OSX 10.11.4

After installation, things got a bit weird... (using chrome 50.0.2661.102 m (64-bit)) I would run squirt and a new blank window would open.  Squirt didn't run, it was just a blank window - then highlighting became a problem - anywhere i'd click on the page, it would highlight text and objects from a fixed, random point on the page - if clicked somewhere else, it would still highlight the same starting point.
Also lost the ability to scroll using the mouse wheel.
Also, the insert key became a "paste" key (pasting the last thing on the clipboard when pressing insert)
Also, even though num. lock was on, the number keys acted like arrow keys.
There are probably more symptoms I haven't found, just a clusterfu-- of things going wrong at the same time.
It doesn't happen every time and I can't seem to reproduce the bug...

This happens to me as well and I switched to a different bookmarklet until it is fixed.
windows 10
chrome 62.0.3202.89


Icon color same as count badge

The color of the icon in the sidebar is same as count badge.

@mittalyashu  AFAIK there is no way to alter the activityBarBadge.background when the activity bar icon is active.
It was intended that the activity bar badge be consistent with the primary theme color, as shown:

The other alternative would be white? That doesn't look nearly as good IMO:

If you have any suggestions on what the color should be, feel free to suggest an alternative.

Here's another example:

@mittalyashu Are you suggesting we make the activity bar badge blue? Or are you suggesting you would like them to be different colors?
If you're suggesting them to be different colors, which colors would you suggest?


docker pull -a image output is wrong on "verified" images

The line of "The image you are pulling has been verified" is breaking the output of a docker pull -a`.  For a video of the problem see this asciinema by @tianon.
Here is the bad output.  I think this issue is not being taken of yet: @jfrazelle do you have an idea / time to help with a patch?

it was a change of copy not output, I will look into the weird placement :)

what do you think it should be all at the top or one message for all

I'm +1 on one message for all (especially if it lists all the tags that are
verified), and top vs bottom IMO depends on whether it's actually verifying
the layers or just the manifests (I'd prefer top if it isn't so it's clear
that this verification happened before we even had the layer data, so it
can't possibly have verified the layers yet).

I didn't initially realized that this was on 1.4.1 and not on master (or 1.5.0-rc1). I completely agree the output sucks, but right now we don't have a fix for this and it's probably going to miss 1.5.0-rc2 (and potentially the final 1.5.0).
I'm removing the milestone, but please feel free to add it to a fixing PR if any.

This message no longer is present in the code, and checksums for pulled images are now always calculated, so I closing this ticket as stale


Documentation: New publisher develop docs

Brief description
Documentation about development for new publisher.
Changes

few minor changes in creator plugins

update list contains namedtuple UpdateData
identifier attribute is not abstract but returns family by default
collect_instances and update_instances have docstrings
some getter methods in creator plugins have default return value an attribute

get_instance_attr_defs returns instance_attr_defs
get_pre_create_attr_defs returns pre_create_attr_defs
get_default_variant returns default_variant

added new category "Host integrations" with subcategory "Publishing" into develop documentation
tried to describ how creation and publishing works together in new publisher

Testing notes:

Run documentation website
Read and criticize

I am not a fan incorporating full examples of classes (like CreateRender and auto), I would prefer just links to github, as sooner than later implementation and documentation will split and become inconsistent.
(I like smaller examples though.)

I would prefer just links to github, as sooner than later implementation and documentation will split and become inconsistent.

That's actually a good point. We could just make a repo with public examples for all documentation purposes

And I would add some pictures :).


Gateway stores password in plaintext

Today the gateway stores the administrator password in plaintext in the database. We should instead store a hash and comparing hashes while authenticating. https://github.com/fedimint/fedimint/pull/4642#discussion_r1536659840
Main challenge will be doing this in a backwards compatible way.

Main challenge will be doing this in a backwards compatible way.

I supposed the gateway could compare the stored hash against the plaintext password and the plaintext password hashed, to provide backwards compatibility.

Main challenge will be doing this in a backwards compatible way.

Make fields options, rewrite old field  on access.
BTW. Make sure to add some random generated salt.

The same needs to be done for the guardian password (although there it might be simpler, just delete the file and require password on startup and keep it in memory from there on).


Can't download zurb foundation from https://download.get.foundation/sites/download

Expected Behavior

...
Current Behavior

...
Possible Solution

...
Test Case and/or Steps to Reproduce (for bugs)

Test Case:

How to reproduce:
1.
2.
3.
Context

...
Your Environment

Foundation version(s) used:
Browser(s) name and version(s):
Device, Operating System and version:
Link to your project:

Checklist

[ ] I have read and follow the CONTRIBUTING.md document.
[ ] This is a bug report or a feature request.
[ ] There are no other issues similar to this one.
[ ] The issue title and template are correctly filled.

Looks like they gotta get in touch with their hosting provider.

Looks like they gotta get in touch with their hosting provider.

Please see the pinned issue.
It has nothing to do with the hosting provider.
https://github.com/foundation/foundation-sites/issues/12189
cc @joeworkman

Please see the pinned issue.
It has nothing to do with the hosting provider.
https://github.com/foundation/foundation-sites/issues/12189
cc @joeworkman


Add trait to specify custom unmarshalling for an attribute

Hi,
As described on IRC last night, here is a simple implementation of traits that can control how an attribute is unmarshalled.  I've added a README with examples.
I'm going to do a symmetrical change in JSON::Marshal this afternoon.
Hope that helps.

Awesome stuff, thanks a lot!

Cheers matey!


override global ordersectionsby on a per section basis?

We have a global configuration of:
ordersectionsby = "title"
Is there any provision for over riding this on a per section basis to order by weight?

In the fork, you could use ordersectionby in each pages frontmatter: https://mcshelby.github.io/hugo-theme-relearn/cont/pages/


Add filtering

Should be able to have 3 concurrent filters:

State
Tracker
Label

Need to edit torrents.js with the filter requirements
line 112 will need to be amended
state:
tracker-host:
label:
Need to store the filters received somewhere, and insert the options into select boxes.


No support ".mp4"?

Why does the follow code occur error for input and output file is '.mp4'?
NSURL *inputMovieURL = [[NSBundle mainBundle] URLForResource:@"1405314140692" withExtension:@"mp4"];
movieFile = [[GPUImageMovie alloc] initWithURL:inputMovieURL];
movieFile.runBenchmark = NO;
movieFile.playAtActualSpeed = YES;
filter = [[GPUImageGlassSphereFilter alloc] init];
[(GPUImageGlassSphereFilter *)filter setRadius:0.45];
[movieFile addTarget:filter];

// Only rotate the video for display, leave orientation the same for recording
GPUImageView *filterView = (GPUImageView *)self.view;
[filter addTarget:filterView];

// In addition to displaying to the screen, write out a processed version of the movie to disk
NSString *pathToMovie = [NSHomeDirectory<EMAIL_ADDRESS>unlink([pathToMovie UTF8String]); // If a file already exists, AVAssetWriter won't let you record new frames, so delete the old movie
NSURL *outputMovieURL = [NSURL fileURLWithPath:pathToMovie];

movieWriter = [[GPUImageMovieWriter alloc] initWithMovieURL:outputMovieURL size:CGSizeMake(360.0, 480.0) fileType:AVFileTypeMPEG4 outputSettings:nil];
[filter addTarget:movieWriter];
// Configure this for video from the movie file, where we want to preserve all video frames and audio samples
movieWriter.shouldPassthroughAudio = YES;
movieFile.audioEncodingTarget = movieWriter;
[movieFile enableSynchronizedEncodingUsingMovieWriter:movieWriter];

[movieWriter startRecording];
[movieFile startProcessing];

timer = [NSTimer scheduledTimerWithTimeInterval:0.3f
                                         target:self
                                       selector:@selector(retrievingProgress)
                                       userInfo:nil
                                        repeats:YES];

[movieWriter setCompletionBlock:^{
    [filter removeTarget:movieWriter];
    [movieWriter finishRecording];

    dispatch_async(dispatch_get_main_queue(), ^{
        [timer invalidate];
        self.progressLabel.text = @"100%";

        ALAssetsLibrary *_assetLibrary = [[ALAssetsLibrary alloc] init];
        [_assetLibrary writeVideoAtPathToSavedPhotosAlbum:[NSURL URLWithString:pathToMovie] completionBlock:^(NSURL *assetURL, NSError *error1) {
            UIAlertView *alert = [[UIAlertView alloc] initWithTitle: @"Saved!" message: @"Saved to the photos album."
                                                           delegate:self
                                                  cancelButtonTitle:nil
                                                  otherButtonTitles:@"OK", nil];
            [alert show];
        }];

    });
}];

怎么解决的啊？麻烦大神说下


CSS selectors with an !important property value have a higher specificity than VisBug inline styles

I've tried changing the font colour for text inside of a component but the colour does not change (background colour changes were fine).
When inspecting in the Chrome Devtools, I noticed that the component had !important on the color property.
However, VisBug may add style="color: #ff0000;" which has a lower specificity than the CSS class selector with the !important value applied.
I've also noticed that if a component happened to have an inline style with !important, if VisBug changes that property inline as well, the !important is dropped so again, may have a lower specificity once again.

yay, glad you noticed this, and I have thoughts/opinions
you nailed it, visbug uses inline styles and currently doesnt compete with !important styles. BUT, i'd like to change that, as well as work with it. the current way to get and set styles in the DOM doesn't let me (IIRC) specify !important or read it. enter CSSOM! this api for getting and setting styles on the DOM does include a way to get and set !important.
i'm waiting for better browser support, then i'll switch from computed styles to the computed style map.
that answer you question? this is one of a few places where visbug is a bit powerless at the moment.

Could you try to zap the !important from the existing rule in CSSOM that applies it? https://codepen.io/tomhodgins/pen/pYRVBv

i was planning on just squashing it with whatever the user picked, like this https://codepen.io/argyleink/pen/OJJjzqv


release to maven central

I've begun working on this but I am blocked by a strange behavior of the maven plugins for dataweave library, gpg, and install where the .asc file in the target folder gets a different filename when it is processed by install or deploy plugins.  I initially reported the issue to sonatype, but then realized it is probably a problem with the dataweave library maven plugin.

Although the default deploy plugin seems to make the wrong filename for the signature file, I was able to upload the correct filename using the gpg plugin directly:
mvn gpg:sign-and-deploy-file -Dfile=dataweave-pq-0.1.0-dw-library.jar -DrepositoryId=ossrh -Durl=https://oss.sonatype.org/service/local/staging/deploy/maven2/ -DgroupId=software.hoegg -DartifactId=dataweave-pq -Dversion=0.1.0 -Dclassifier=dw-library -Dpackaging=jar -Dkeyring=0xF5C47901 -DpassphraseServerId=0xF5C47901 -Dgpg.executable="./gpghack.sh" -DpomFile=../pom.xml

I will see if I can complete the release this way and close the issue if so

This approach worked. We are available in maven central, and I added a badge to the README!


Disable enable-log-recycle by default.

Description
Disable enable-log-recycle in raft-engine by default.
When opening log recycling,

We observe on physical disk, overwriting existing log files will generate unnecessary read I/Os, and even though the fdatasync latency is reduced, the duration sum of fdatasync and pwrite has increased.

So, we disable it by default.
Signed-off-by: Lucasliang<EMAIL_ADDRESS>

cc @tabokie


backport list merge fix to 2.3

Signed-off-by: Will Kutler<EMAIL_ADDRESS>https://github.com/open-cluster-management/backlog/issues/15696

/lgtm


README constantly falling out of sync

The README.md file is constantly falling out of sync with the usage section. Script a solution.

Once version 1.0 is achieved, not too many features are foreseen.


Make BasicFunc support dependency injection

I was able to solve this problem, using db as global variable. However, would be better if I could pass it to my callback (that today, accepts just two params - user and password). Could you support a variable number of params, where I could for example pass the db handle?  I stumbled many times in this question and either I found a "use another middlewear" or "set your db variable global"..

This is a little tricky because (I think) we would have to inject the username and password in the context as well in order for BasicFunc to be able to access it.

maybe passing an structure that should at least have a field username an password?

No you can't do that with a struct.
You can, however, do that with an interface, but that seems like too much complexity. After all, you could just pass in the db in a closure. Or pass in a method to auth.BasicFunc, and have the method access the db via the struct.

func main() {
    // …
    m.Use(auth.BasicFunc(&(DBAuth{}).Authenticate))
}

type DBAuth struct {
}

func (a *DBAuth) Authenticate(username, password string) bool {
    db := a.Database()
    // authenticate username and password using the db…
}

func (a *DBAuth) Database() *DB {
    return &DB{…}
}

…you get the idea.

Summary: what you want can already be achieved without DI. I don't see a great need for DI here, but, if someone wants to implement this, why not. Just send a PR.


Cleanup istiodless multicluster and external istiod testing

Please provide a description of this PR:
This PR cleans up the istiodless and external istiod test framework and makes istiodless testing by default.
Followup to #38283

@frankbu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
c2d74ac0222d2545bee46183eb823c014175f9b8
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
c2d74ac0222d2545bee46183eb823c014175f9b8
link
true
/test integ-pilot_istio

integ-cni_istio
c2d74ac0222d2545bee46183eb823c014175f9b8
link
true
/test integ-cni_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frankbu I am actually having issues with this particular variable. But after reading some of the docs, the doc says this method is needed when the host name is actually an IP address such as an load balancer IP, then the cert will need to be recreated to include the IP address in SAN especially in a test env. are we not needing that any more? I have been messing with this parameter last few days. Can you confirm we indeed not need this? In quite few tests (I think at least 4 integration tests), we are patching the Istiod so that the Istiod also restarts. Please confirm.

@frankbu are you using ISTIOCTL_XDS_ADDRESS to basically replace the ISTIOD_CUSTOM_HOST when generating cert?

@frankbu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-mc_istio
f19e038b994aab010f20d6bef37cf6cc50fb0bce
link
unknown
/test integ-telemetry-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-telemetry-mc_istio


Modify list section

Change the name of list and the objects inside the list. Add different ways to extract the contents of a list in R.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] All the files I changed are in the same world language (for example: only English changes, or only Chinese changes, etc.)
[x] My changes do not use shortened URLs or affiliate links.

Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


New version: Resolume.Avenue version <IP_ADDRESS>521

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Something accidentally closed #161519 and this PR contains the fixes for the issues found in that PR. Could not reopen the original PR.

/azp run