Typo in ASIM network parameters

In the documentation the wrong parameter value was specified for the use is vim parsers functions.
Gone through all vim parsers on the Azure-Sentinel GitHub, and all use dstportnumber instead of dstportnum as described on the documents page.

@oshezaf
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


You can not see the player's skin

I have a problem and do not see the skin of the players, is there a problem with crafatar.com?
##http://prntscr.com/ik0xqi
Link: http://empireislands.es/bansky/bans.php

Already fixed by https://github.com/ruany/litebans-php/commit/a2abd7f782e95f9766266733409bc056ebeaa80c, update the web interface.
This only affects offline-mode servers.

Fixed again https://github.com/ruany/litebans-php/commit/88cc07540b4f86d8eec3a6338b29f871c5a0a3d1


BuildLine interaction between non-global origin and tuple addition/localization

pln = Plane.XZ
pln.origin = (0,0,-60+25)
with BuildLine(pln) as l2:
    n1 = Line((-270/2,-40+5),(-270/2+30,-40+5))
    n2 = PolarLine(n1@1,70,30)
    n3 = Line(n2@1,(0,0))
    n4 = Line(n3@1,n3@1+(0,10))
print(f"{n4@0=}, {n4@1=}")
#returns n4@0=Vector: (0.0, 0.0, -35.0), n4@1=Vector: (0.0, 0.0, -60.0)

If I comment out pln.origin = (0,0,-60+25) it works as expected (line goes up instead of down)

The problem was with localization of vector/tuple addition when the plane origin isn't (0,0,0).

Thank you Roger!


Decouple jumpbox deployment from terraform

Benefit/Result/Outcome
The bicep deployment of MLZ does not inherently add a jump box VM yet the Terraform deployment does. Having parity in the behaviors of the two deployment types would be a better customer experience
Description
Decouple the jumpbox VM from the main Terraform deployment and provide a utility that allows for adding it on an as-needed basis
Acceptance Criteria

TBD
TBD

This has been pulled out as a "Remote Access" option during deployment.


Changing the VM user's shell to fish causes lima to wait forever for the SSH requirement to be satisfied

Description
When setting the lima VM user's shell to fish, lima will get stuck forever waiting for the the SSH requirement to be satisfied.
lima-start.log
The loop is in the following lines:
time="2024-11-06T13:14:17-06:00" level=info msg="[hostagent] Waiting for the essential requirement 1 of 2: \"ssh\""
time="2024-11-06T13:14:17-06:00" level=debug msg="[hostagent] executing script \"ssh\""
time="2024-11-06T13:14:17-06:00" level=debug msg="[hostagent] executing ssh for script \"ssh\": /usr/bin/ssh [ssh -F /dev/null -o IdentityFile=\"/Users/burner/.config/lima/_config/user\" -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o NoHostAuthenticationForLocalhost=yes -o GSSAPIAuthentication=no -o PreferredAuthentications=publickey -o Compression=no -o BatchMode=yes -o IdentitiesOnly=yes -o Ciphers=\"^aes128-gcm<EMAIL_ADDRESS>-o User=burner -o ControlMaster=auto -o ControlPath=\"/Users/burner/.config/lima/alpine/ssh.sock\" -o ControlPersist=yes -p 49540 <IP_ADDRESS> -- /bin/bash -c $'while read -r line; do [ -n \"$line\" ] && export \"$line\"; done<<EOF\\n$(sudo cat /mnt/lima-cidata/param.env)\\nEOF\\n/bin/bash']"
time="2024-11-06T13:14:17-06:00" level=debug msg="[hostagent] stdout=\"\", stderr=\"fish: Expected a variable name after this $.\\n/bin/bash -c $'while read -r line; do [ -n \\\"$line\\\" ] && export \\\"$line\\\"; done<<EOF\\\\n$(sudo cat /mnt/lima-cidata/param.env)\\\\nEOF\\\\n/bin/bash'\\n             ^\\n\", err=failed to execute script \"ssh\": stdout=\"\", stderr=\"fish: Expected a variable name after this $.\\n/bin/bash -c $'while read -r line; do [ -n \\\"$line\\\" ] && export \\\"$line\\\"; done<<EOF\\\\n$(sudo cat /mnt/lima-cidata/param.env)\\\\nEOF\\\\n/bin/bash'\\n             ^\\n\": exit status 127"

Lima is running a script that was presumably meant for bash or another standard shell, but it runs it in whatever the user's configured shell is. If the user's shell is set to fish, this causes syntax a syntax error.
Reproduced on alpine & fedora VMs. I can provide any extra logs or make some dedicated VMs specifically for testing this if needed.
OS: Mac OS 14.7.1
CPU: Apple M1 Pro
Lima version: 1.0.0 (via homebrew)

Is this a regression in v1.0?
Was it working in the previous release?

It seems like fish doesn't accept the $'' form of shell quoting:
// ssh.ExecuteScript will strip the `#!` prefix from the first line and invoke the rest
// of the line as the command. The full script is then passed via STDIN. We use the $' '
// form of shell quoting to be able to use \n as newline escapes to fit everything on a
// single line:
//
//      #!/bin/bash -c $'while … done<<EOF\n$(sudo …)\nEOF\n/usr/bin/env ruby'
//      #!/usr/bin/env ruby

https://fishshell.com/docs/current/design.html#the-law-of-orthogonality

The many Posix quoting styles are silly, especially $.

Is this a regression in v1.0?

Looks like it. According to what @afbjorklund found, this was changed in #2570. There are 20 lines of comments on why the code is this way.
I guess writing to a temp file is an option, but where would we put it, in /tmp?

I just used mktemp, which uses $TMPDIR (that should default to /tmp on most...)
https://github.com/lima-vm/lima/pull/2028/commits/27603c107e41e9da77c1321ea94b06104d777d63
You can probably do it without three separate calls to ssh, though (didn't bother)

Is mktemp guaranteed to exist and accept these parameters? It doesn't seem to be in POSIX.
Should you fall back to /tmp if mktemp returns an error?

I don't think there are any absolute guarantees. Could it be quoted in some other way?
It does seem that the current implementation has been done after some consideration...

According to the fish manual, you are suppose to just drop the quotes.
https://fishshell.com/docs/current/fish_for_bash_users.html#quoting

Maybe it (the support for lima.env) could be added to sshocker ssh, like support for sudo?
https://github.com/lima-vm/sshocker/blob/master/pkg/ssh/ssh.go#L88

Is mktemp guaranteed to exist and accept these parameters? It doesn't seem to be in POSIX.
Should you fall back to /tmp if mktemp returns an error?

While not part of posix to my knowledge, mktemp is present in coreutils, uutils, and busybox, so I would expect it to be installed on basically every system.
Falling back to placing scripts in /tmp is probably fine too, though.
Having used fish as my default shell for years I don't really see much reason to adapt the scripts specifically so that they work within fish if it's an option to just use a temporary file.
There would be issues beyond just the string quoting to solve, and the extra code seems like it wouldn't be worth the effort.
For instance, fish has a pretty different syntax for while loops which would cause the while ...; do; ...; done loops to fail from syntax errors, as fish uses the end builtin where bash uses the done builtin.
It'll also complain about missing commands, because fish lacks a do builtin entirely.
Fish also doesn't support the << syntax for redirection.
And while it's less likely to matter, fish's read builtin doesn't have a -r flag.
All of those quirks are probably things that can be dealt with, but temporary files seem like a much more reliable solution, and it also improves compatibility with any other non-posix login shell (ex. nushell, xonsh, elvish, or powershell, though I've only ever heard of one person using any of those as a login shell)

There would be issues beyond just the string quoting to solve, and the extra code seems like it wouldn't be worth the effort.
For instance, fish has a pretty different syntax for while loops which would cause the while ...; do; ...; done loops to fail from syntax errors, as fish uses the end builtin where bash uses the done builtin.

The while loop is executed by /bin/bash. It is just the quoting of the string that is an issue because it needs to be parsed by the default shell.
I wonder if we can replace /bin/bash -c $'…' with /bin/bash -c "$(printf "…")" (after doubling all % characters in …). Then we depend on printf; I wonder if that will do the right thing on all platforms.

There would be issues beyond just the string quoting to solve, and the extra code seems like it wouldn't be worth the effort.
For instance, fish has a pretty different syntax for while loops which would cause the while ...; do; ...; done loops to fail from syntax errors, as fish uses the end builtin where bash uses the done builtin.

The while loop is executed by /bin/bash. It is just the quoting of the string that is an issue because it needs to be parsed by the default shell.
I wonder if we can replace /bin/bash -c $'…' with /bin/bash -c "$(printf "…")" (after doubling all % characters in …). Then we depend on printf; I wonder if that will do the right thing on all platforms.

printf is also in coreutils, uutils, and busybox, so it seems like it'd be a safe thing to depend on. And after trying bash -c "$(printf "...")" with the command where lima got stuck, it does actually seem like it'd work too. It probably requires some testing on other commands though.


HHH-14540 Don't share session-scoped interceptors with temp session

https://hibernate.atlassian.net/browse/HHH-14540
This needs to be backported to Hibernate 5.3.

merged already


Make README better

your readme sucked

Is it abit better, it also needs to explain the args you can run it with like -server


Composite experiment with existing sub-experiments

Suppose that I run a T1 experiment on qubit 3. Then I want to run again the T1 experiment, this time qubits 3 and 5 in parallel. And I want to use the same experiment data for qubit 3, namely, to add the result of the new experiment to the one of the old experiment. The current code of CompositeExperiment always starts from fresh experiment data to sub-experiments, even if they have existing data from before.

I think it is going outside the intent of composite experiments. Composite experiments are intended for batching experiments together in a single execution.
If you want to do analysis of data from multiple experiments such as Q3 T1 from a single experiment, and Q3 T1 from a parallel experiment you should probably manually combine the relevant experiment data objects after the separate experiments have been run and then re-run run analysis on the joint data (im not sure if this combining of experiment data is implemented yet though).

Need to define a policy, what are the constraints when the experiment_data parameter of run is not None, with an exception when one of the constraints is violated.

In this issue, do we want to address CompositeExperiment or regular Experiment when their parameter ExperimentData is not None? or both cases?

I think BaseExperiment, which includes also CompositeExperiment

I'll start a list here of properties we would like to check:
For composite experiments, need to check the following:

Same experiment type (already checked in ExperimentBase)
Same physical qubit(s) (already checked in ExperimentBase)
Same p0 for analysis_options (if not None)

For parallel experiments, need to check the following:

Experiments on different qubits
Do we want to raise a warning for experiments on adjacent qubits (depending on the device)?

Feel free to add additional items we should check.

General comment: currently we have a handful of implemented experiments. When that list grows, maintaining the checking logic of composite and parallel experiments can become complex and burdening, as there might be unique compositing constraints for certain experiments and not the others, contradicting constraints and other complications hard to predict now.
So I think we should decide which approach we are taking at this stage:

Performing vary basic checks - those which are generic and experiment oblivious and are common to all experiments
Develop a mechanism by which each experiment exposes its compositing constrains, and the framework classes handle those generically and yield a warning/error if constraints are violated.

I think at this stage we should go with the simple approach (#1), and support just the bare minimum checks for proper compositing.

@merav-aharoni @eliarbel Can we close this issue?


Make generated dataset recordType tables unique based on table instead of sf_object

Feature Type
I'm interested in functionality that solves a current problem or limitation in how CumulusCI works.
Does your feature request solve a current problem?
No response
Describe the solution you'd like
https://salesforce.stackexchange.com/questions/383730/dataset-load-issue-with-person-accounts-and-business-accounts/383992?noredirect=1#comment556031_383992
Describe alternatives you've considered
No response
Additional context
No response

We are tracking this issue as W-11466074

@davidmreed is there a way for me to see progress on the issue?

We've got it in our backlog but I'm afraid I cannot make a firm commitment on delivery timeframe.


RTSPbee for rtsp-simple-server stress testing

Hi,
I am attempting to use Red5's RTSPbee test tool with rtsp-simple-server in order to load test the server. The RTSPbee tool allows the user to send multiple subscription/play requests to the server in order to monitor health.
While the tool is obviously designed for use with Red5's server, I am hopeful that I can get it running with rtsp-simple-server.
I am running into an error when Rtspbee tries to subscribe to my stream, the rtsp-simple-server returns:
"ERR: transport header does not contain unicast"
root@audioserver1:~# ./rtsp-simple-server
2020/05/17 21:55:05 rtsp-simple-server v0.6.1
2020/05/17 21:55:05 [UDP/RTP listener] opened on :8000
2020/05/17 21:55:05 [UDP/RTCP listener] opened on :8001
2020/05/17 21:55:05 [TCP listener] opened on :8554
2020/05/17 21:55:10 [RTSP client xxx.xxx.48.1:51080] connected
2020/05/17 21:55:10 [RTSP client xxx.xxx.48.1:51080] OPTIONS
2020/05/17 21:55:10 [RTSP client xxx.xxx.48.1:51080] ANNOUNCE
2020/05/17 21:55:10 [RTSP client xxx.xxx.48.1:51080] SETUP
2020/05/17 21:55:10 [RTSP client xxx.xxx.48.1:51080] RECORD
2020/05/17 21:55:10 [RTSP client xxx.xxx.48.1:51080] is publishing on path 'mystream', 1 track via tcp
When I try RTSPbee subscription script
2020/05/17 21:58:59 [RTSP client xxx.xxx.48.1:50641] connected
2020/05/17 21:58:59 [RTSP client xxx.xxx.48.1:50641] OPTIONS
2020/05/17 21:58:59 [RTSP client xxx.xxx.48.1:50641] DESCRIBE
2020/05/17 21:58:59 [RTSP client xxx.xxx.48.1:50641] SETUP
2020/05/17 21:58:59 [RTSP client xxx.xxx.48.1:50641] ERR: transport header does not contain unicast
2020/05/17 21:58:59 [RTSP client xxx.xxx.48.1:50641] disconnected
I am using rtsp-simple-server v0.6.1 and RTSPbee v4.2.1
It would be great to integrate this tool in order to load/stress test rtsp-simple-server.
If you have any ideas on how to address this header issue either with rtspbee or the server, please let me know.
Thanks.

Hi, rtspbee is now fully supported (v0.6.3).


Build automation to ensure generator and generated code are always in sync

Ideally, each PR that changes the inputs to code generation (generator behavior, or the contents of the sidekick.toml files) would also include the update this change causes to the generated files. This is useful because the next developer making changes to the generator will be able to validate that their changes have no unintended side effects, by just re-running the generator.
I think this could be done as a GHA that runs the generator on top of the PR, and fails the check if a git diff is found.

I think this could be done as a GHA that runs the generator on top of the PR, and fails the check if a git diff is found.

We are doing that for the Rust code in src/generated:
https://github.com/googleapis/google-cloud-rust/blob/49baaf15c0474ecd717165a1badfe9842a55ba96/.github/workflows/sdk.yaml#L122-L129
and for the golden files:
https://github.com/googleapis/google-cloud-rust/blob/49baaf15c0474ecd717165a1badfe9842a55ba96/.github/workflows/generator.yaml#L48-L50
Did you have something else in mind?

oh, I know what was my mistake... I didn't run cargo fmt after the refresh, and assumed the differences were stale changes.


Operations Sum is not working fine.

I change some records to in the DB to include more operations to the sample Debtor. The result is that the summary of values of each column is not correct.
Fix:

[x] The CAPITAL column total. looks like it's reading just the first record.
[x] The INTEREST column total. Looks like it's reading just the first record.
[x] The PAYMENTS column total. Looks like it's reading the values like text or something like that.
[x] The DEBT column total.  Looks like its reading just the first record.

Please Review this and its done

Works perfectly. thnx


Can you please update this tool to support the latest Forza Motorsports?

Thx a lot.

Hello @qq00qq00 , thanks for your reporting. I checked the submodule "forza_motorsport", which is already on the top of the latest commit "61845cb". The only different is my forked "forza_motorsport" has a few minor fixes.
Let me know if you have any questions.

Thx a lot，
I will test the latest version.


Run the loader on change of searchParams

Hey, I just wanted to know if I can run the top-loading bar on every change in the search parameters.

@kapsule-studio Unfortunately shallowRouting will not show the loading bar when only search params change.
Environment:
"next": "^14.2.3",
"nextjs-toploader": "^1.6.12",

Would you have any further ideas? Happy to provide debug information.

Thanks for the workaround! @stefan-girlich


Unused param in Publish-BuildOutputToAzureFeed.ps1

I think there is an unused parameter in this function, I think it should be removed if I'm not mistaken

https://github.com/microsoft/navcontainerhelper/blob/3626596a43ca04873b5b57dd1de226e327fca3a2/PackageHandling/Publish-BuildOutputToAzureFeed.ps1#L29

You are right it's currently not used. Left over from the earlier days. I using the Environment Variable now.
But removing the parameter might break somebody's code.
So I think it's better to actually use it here. But the pat should not be mandatory.
I'll create a fix for this on sunday.


Ensure allow-create and provider-name are optional for saml2 authn requests

Clean up SAML2AuthnRequestBuilder.java and:

Make sure the AllowCreate flag can be optionally created
Make sure the ProviderName attribute can be optionally created
Add test case for the SAML2AuthnRequestBuilder.java (Remove finality from methods to ensure mocks can be created)
Clean up SAML2AuthnRequestBuilder.java to allow for easier configuration; replace parameter-passing with configuration object instead.

@leleuj if and when this pull request is merged, it would be a good time thereafter perhaps to cut RC2 and allow the changes to be better tested in the context of CAS deployments. (We'll update pac4j in CAS of course with necessary changes to support this PR).

I'll cut the pac4j / spring-webmvc-pac4j 4.0.0-RC2 releases the next days...


adding stats to dedup

In order to address https://github.com/mirnylab/distiller-nf/issues/80 we agreed to add stats to the dedup.
And this: https://github.com/mirnylab/pairsamtools/blob/e725dbbd037f169a5def3891783f7b2cf3922463/pairsamtools/pairsam_dedup.py#L315 looks like a proper place to add something like out_stat.add_pair(algn2, algn1, pair_type)
Techincal Qs:

should we parse line_buffer[i] right next to where we're writing it to outstream?
should we instead activate cols_buffer[i] (used for mark duplicates) for stats and skip parsing line_buffer[i]?
stats-related: should we change stats-API, and instead of out_stat.add_pair(algn2, algn1, pair_type), say out_stat.add_pair(c2, p2, s2, c1, p1, s1, pair_type), where algn={'chrom':c,'pos':p,'strand':s}?
Such an API change would simplify stats module itself, here https://github.com/mirnylab/pairsamtools/blob/e725dbbd037f169a5def3891783f7b2cf3922463/pairsamtools/pairsam_stats.py#L78
It was written the way it is right now, in order to please and simplify parse-code, i.e. avoid unpacking align dictionaries there.

What do you @golobor , @nvictus  guys think ?

awesome suggestions!

the suggested change in the stats interface is great, since it makes the API much more transparent - it's nice to show explicitly which characteristics of the alignment we actually use when we calculate statistics. It will simplify re-using stats in other contexts.

indeed, using cols_buffer instead of line_buffer to save one splitting operation is nice!
The issue, however, is that we do not add unmapped lines to cols_buffer, so we'd have to add it in a separate command.

finally, the question is where to calculate the duplicate statistics.
The two options are:
a) keep it the same way it is right now - calculate dup/dedup statistics in dedup and insert the final data into the stats object. pro: it's a minimal change from what we have right now, cons: it spreads calculation of statistics across different modules
b) rewrite stats to calculate dup/dedup numbers inside it, by checking the pair_type flag (we tag duplicates with a DD flag). pros: it nicely localizes statistics calculation in a single module, cons: we won't be able to only output dup/dedup statistics, and will have to calculate the full statistics every time we do dedup. Also, right now tagging of duplicate reads with DD is optional and is performed only when we output duplicates into a separate file. With the proposed scheme, we'd have to tag them everytime, which, probably is not a big deal.
Not sure what the optimal solution is. @nvictus ?..

@golobor So I've finally got to something about this issue, but I started small and addressed only (1)-item from your list.
I'm still digesting (2) and (3)

I personally favor (3b) - code would be more consistent, kind of. Stats belong to one place, kind of - would be easier to address https://github.com/mirnylab/pairsamtools/issues/54
by relying on a rigid structure of stats object, by rigid I mean with the unmapped and dups files predefined @nvictus , @golobor  what do you think?

re: 3(b), yes, your understanding is right, calculate all statistics via add_stats.
I too now think that we should with (3b), b/c it keeps the code tidy(er).


Add the ability to import 3d files

.obj working well now -- need to use triangles option for SketchUp.  blender quads work fine.
infrastructure should handle other types -- should be able to steal code from g3n and slot it in, but won't be able to get to this for a while.  g3n supports collada and one other.

The new file types will not be added now, and a separate ticket will be filed for other file types. OBJ is working great.

More file types for importing will be added later. The more file types ticket is issue #329


Command failed: git config --get remote.origin.url

Describe the issue
i got a error Command failed: git config --get remote.origin.url on macos to build ios app
Environment

OS: macos mojave 10.14.4
Yarn 1.12.3
Node.js v10.15.0
Xcode version 10.2.1

Additional context
Add any other context about the problem here.

Can you run the command manually and paste the output?

yes, i had try it ，it is no problem. it return me the address of this repo.


Create Windows build job with AppVeyor

This is an appveyor build script for tacopie. This one is rather straight forward:

Find the (only) tacopie.sln and build it for 4 common build configurations (Debug/Release + x64/x86)

Thanks again for your work dude, really appreciate!
You rock!


Duplicate  map keys with anchor  shouldn't be marked as error

Version: v1.3.2
related issue: https://github.com/eemeli/yaml/issues/21
import YAML from "yaml";

YAML.parse(
  `
.anchors: &anchor1
  key: value

.anchors: &anchor2
  another: prop

foo:
  bar: baz
  <<: *anchor1
  <<: *anchor2
`,
  { merge: true }
);

Expected: no error

The error is in fact proper in this case, as the top-level object here is a mapping that would have the keys .anchors, .anchors, and foo. The spec requires that these keys must be "unique [...] and mapped to exactly one value".
From YAML's point of view, .anchors is in no way special, and will be handled exactly like any other key.


added deploy:islocked task

Q
A

Bug fix?
No

New feature?
Yes

BC breaks?
No

Deprecations?
No

Fixed tickets
N/A

added deploy:islocked task which allows to determine if a lock was already acquired by another process/task. this can be usefull to fast fail before starting a extensive build-process and finally run into a "already locked" error after waiting mintues for a build.

hmm this doesnt make sense. to safely call islocked you need all the "remote prepare" things beforehand, so all the heavy stuff was already done at this step.

There is no need to extra task.
You can call deploy:lock before build step.

but this will error in case the lock can't be acquired. (and it only works after deploy:prepare succeeded once.

ahh I see... you can lock repeatedly. great.

actually it doesnt.. with https://github.com/deployphp/deployer/pull/1470 it will allow to invoke deploy:lock repeatedly


Safe_reset function can be optimized to memset

The safe_reset function in the ring buffer is designed to avoid memset. As I understand you don't want to use memset in the producer, because it is not async safe. Here is g++'s output:
http://goo.gl/V4oL1K
In my experience compilers are very aggressive in reducing such patterns to more optimized memset, memcpy implementations. I think the best option is to choose an algorithm that does not do a memset like operation on the producer at all. #46 outlines one such approach.

@RajivSignal Thanks for spotting this. I don't quite get your reference to #46 outlining a solution. Do you mean #76?

Sorry mean't #76.

I meant to say that the memset like function or memset itself can be called on the consumer after feeding each record to the listener_ recording each entry. That way when the producer gets the record it can be sure that it is completely clean. So on the consumer things would look a bit like this:
bool CircularQueue::pop() {
    const auto current_output = output.load();

    // queue is empty
    if (current_output == input.load()) {
        return false;
    }

    // wait until we've finished writing to the buffer
    while(buffer[current_output].is_committed.load() != COMMITTED) {
        usleep(1);
    }

    listener_.record(buffer[current_output].trace);

    // My comment - additionally zero out all the traces.
    JVMPI_CallFrame *fb = frame_buffer_[current_output];
    auto num_frames = buffer[current_output].trace.num_frames
    for (int frame_num = 0; frame_num < num_frames; ++frame_num) {
      // Make sure the padding is all set to 0.
      safe_reset(&(fb[frame_num]), sizeof(JVMPI_CallFrame));
    }
    buffer[current_output].is_committed.store(UNCOMMITTED);
    output.store(advance(current_output));
    return true;
}

And on the producer:
// Unable to use memcpy inside the push method because its not async-safe
void CircularQueue::write(const JVMPI_CallTrace &trace, const size_t slot) {
    JVMPI_CallFrame *fb = frame_buffer_[slot];
    for (int frame_num = 0; frame_num < trace.num_frames; ++frame_num) {
        // My comment: All of the padding is already  set to 0, because the consumer has zeroed it out.
        // We don't need to risk writing memset like functions in an async context.
        safe_reset(&(fb[frame_num]), sizeof(JVMPI_CallFrame));

        fb[frame_num].lineno = trace.frames[frame_num].lineno;
        fb[frame_num].method_id = trace.frames[frame_num].method_id;
    }

    buffer[slot].trace.frames = fb;
    buffer[slot].trace.num_frames = trace.num_frames;
    buffer[slot].trace.env_id = trace.env_id;
    buffer[slot].is_committed.store(COMMITTED);
}

Hi Rajiv,
I've applied your suggestion in order to move the clearing of the buffer to the consumer.
However safe_reset is also used in the Profiler::handle method where it also needs to be async-safe. At the moment this isn't a problem because GCC doesn't optimise safe_reset to memset when using using -O2, which is what honest-profiler is currently set to use. So I'm going to close the issue.
I don't like how brittle the code is to compiler optimisations though and if you have any suggestions on an alternative implementation of safe_reset that /can't/ be optimised that would be great. I've also pushed a patch that adds -fno-tree-loop-distribute-patterns which is the compiler flag that should stop the memset optimisation from happening even if we bump the optimisation level to -O3.

It is really annoying when GCC decides to take it upon itself to do something this radical. I didn't know about the -fno-tree-loop-distribute-patterns flag. Thanks for the tip. Though it is sad that one has to throw out the baby with the bath water, because it means that other places that would benefit from these optimizations have to also forgo them. I wish GCC etc allowed users to make these decisions at call site instead of globally .


LiveFyre Comment on Create .NET Standard NuGet Packages with Visual Studio 2017

Post Time: 2017-05-01 07:14 (UTC)
Area: NuGet
Article: Create .NET Standard NuGet Packages with Visual Studio 2017 | Microsoft Docs
https://docs.microsoft.com/en-us/nuget/guides/create-net-standard-packages-vs2017
CommentsCategory: Content-BadExample   Sentiment: 99%
Comments:
I have the following scenario: I'm managing several NuGet packages that I previously published as a PCL with profile 259. The source code for these projects is also available on GitHub, and that's why I've used the following principles so far:- by default, the assemblies are not signed so they do not have a strong name. This is because publishing the .snk file on GitHub would be a security risk.- when I want to publish a new version, I run a release build and recompile it with ILDASM / ILASM to

Customer self-answered this one.


Will this work on OpenGL 3.3 ?

If you replace "github.com/go-gl/gl/v4.1-core/gl" with "github.com/go-gl/gl/v3.3-core/gl" things should work just fine.

I just tried this out and had no issues.  Please let me know if you have any problems on your end.


[Installer] Add python version option at runtime

Currently python version can be set with an environment variable
Should we expose it as a runtime flag for the installer?
Similar to SOURCE and PUBLISHER flags
Ref: https://github.com/inventree/InvenTree/issues/7375

Simply adding support to pass anything will not ensure it works. Multiple footguns would need fixing:

re-running the installer with a different python version will bork your instance in interesting  and unpredictable ways (not fully sure why, pinning was a reliable fix)
customised environment installs (not in requirements or plugins) will need to transfer with updates to keep instances running - this is the main reason it is fixed right now
some sort of validation that the passed version is actually accessible on the OS and supported by InvenTree would be needed

This keeps coming up - I will patch the installer to just stop if the configured/detected python version is not found


Add Genre in albums view lists (favorites, new release, ...)

Hi,
Is there a possibility to show genre in album views lists like my WiiM player do ?
Regards

What? Where is the genre in that screenshot?

I've poste new screenshot with higher resolution and you can see the quality and the genre for each album.

Sorry, but genre is not available in the LMS API for album listing.

Ok. Thanks for you work


WIP: refactored public key handling

Added

This CHANGELOG file
SshKeyPair: added typehints
SshPrivateKey: added getPublicKey Method
SshPublicKey: added fromPrivateKey() Method
SshPublicKey: added setComment() Method

Changed

SshKey: getKeyData() has now openssh as default format
[BC Break] SshKeyPair: changed constructor signature, switched public with private to allow to null as public key
SshKeyPair: increased default bit size to 4096
SshPublicKey: constructor to allow to set the comment & added typehints

as i change the constructor and if you want to follow semver this should be a major version upgrade.  the code could be changed to not introduce a bc break but it would make more sense to do this.
also i added typehints in some functions https://secure.php.net/manual/en/functions.arguments.php#functions.arguments.type-declaration which would require php7.

noticed keys are generated with windows line ending. adding normalization.


Prevent error when user attempts to set embargo date for the future on the day that the embargo has already been lifted.

HB error: https://app.honeybadger.io/projects/77112/faults/80837103
There is a previous discussion on this error in the #dlss-infrastructure slack channel if you search for that link.
I have successfully recreated this error. In a nutshell, it seems to me like there is confusion when modifications are made on the day the embargo is released because the form still displays the embargo date instead of showing that it has been released. Today's date won't validate, because it's not in the future, but you can't change this to a future date because the item has already been released. Attempting to do so will trigger the error message.
Here are the steps I took.

I created new item https://sdr.stanford.edu/works/5764 (druid:wn318vm7113) on 7-25-2022 and assigned it an embargo date of 7-26-2022.
On 7-26-2022, I checked to see that the embargo had been lifted. The history indicated that it had been.

I then clicked the pencil icon to edit the item. I entered a note in the "What's changing?" box at the top, then modified the abstract. Note that the section for the embargo showed that the embargo date was today, though the history said the embargo had been lifted:

When I clicked "Deposit", I got the same message as the user below -- the validations ran and it told me that the embargo date must be in the future.
I then changed the embargo date to tomorrow, and then clicked "Deposit" again.
I then got the blank page with the "That wasn't supposed to happen" error message.
I think I then clicked back on the browser (maybe I refreshed? I don't think this is critical) and the view page for the item reloaded.
I clicked the pencil icon again, made a note at the top about the changes, then changed the embargo option to "immediate" release.
I clicked "deposit" and it completed just fine.
When I re-open the form the release information displays like this and the user can't make changes:

Another user encountered this error on 7-20-2022. She was able to complete her deposit. Below are the details she reported about what happened. I generally followed the first part of this to recreate my error above.
“Sure, I removed the DOI sentence from the abstract, added what I changed, and submitted it. It told me that the embargo date must be in the future. I changed the embargo date and resubmitted, then the oops error appeared. I refreshed the browser and started over. This time I changed the abstract and embargo date. I forgot to describe what I had changed. It told me that I had to add that information. I did, and then successfully resubmitted with confirmation on the webpage and a subsequent email message. It seems that the glitch occurs when someone tries to make changes while the embargo date is not in the future. I hope this helps. By the way, this is a great service and so important for research! Cheers Cindy”

@amyehodge would the desired behavior here be that when the embargo is today, and therefore the item has been released, that the embargo date is no longer editable and it reflects instead that it's been released?

(And then the user can carry on with editing metadata.)

Yes, @lwrubel that's exactly right.


feat: Switch to Redis as the default MessageBus

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/master/.github/Contributing.md.
What is the current behavior?
ZMQ is the default MessageBus
Issue Number: #74
What is the new behavior?
Redis is now the default MessageBus
Does this PR introduce a breaking change?

[X] Yes
[ ] No

BREAKING CHANGE: All services receiving Event must now be configured to use Redis as the MessageBus
New Imports

[ ] Yes
[x] No

Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information

recheck

@cherrycl , these failures in secure mode seem un-related to this PR. All smoke tests are passing in non-secure mode.

Note the switch to Redis for the MessageBus changes in Core Data and App Service Configurable have been and will cause failure in the nightly TAF tests w/o the changes in this PR.

@cherrycl , not that I can successfully run api-gateway-token.sh -useradd locally from the service started with this PR (normal compose, not TAF)

@bnevis-i , fixed issue with device-rest. Changes here and to the service, so you need to run make pull to get latest.

Hi @cherrycl , here is the latest info on the failure blocking this PR. I am able to run api-gateway-token.sh with -useradd and -userdel without issue against the standard edgex stack (not TAF compose file). Please see if you can determine why -userdel is failing. THX!

@lenny-intel The service of edgex-secretstore-setup startup failed with the following error, which causes most of services fail to start.
level=ERROR ts=2021-05-03T02:16:05.168467826Z app=edgex-security-secretstore-setup source=init.go:341 msg="invalid specification for ADD_KNOWN_SECRETS environment vaiable: Service list for 'redisdb' missing closing ']'"

The service of edgex-secretstore-setup startup failed with the following error, which causes most of services fail to start.

@cherrycl , Thank you!!! I have figured a way to tweak the TAF compose in-order to run it locally to verify services start-up properly. I am now seeing the same error you found. Thanks again!


Tags are not saving while running save command

Installed the latest version (2.8.0). Configured and ran the command "pickaxe save dev".
It pulls everything except tags. I double checked the existence of tags in the configured app and are publicly shared.
I didn't get any error, I see "Saving all ..." for all KOs in console except "Saving all Tags".

Yes looks like this was intentional stating there wasn't a way to list the existing tags. Though I seem to have found a list tags API here.
I wouldn't think it would be difficult but I haven't been working on this project besides releasing, reviewing and maintaining. I'd appreciate a PR if you are able


docs: add prop-types-typescript codemod

Adds prop-types-typescript codemod to readme.
Other docs that should be updated: migration guide (href for prop-types-typescript pointing to /TODO.

Outdated. Closing.


goreleaser: Add missing ldflags

goreleaser creates binaries without the required ldflags (binaries built with it and added to archives have incorrect version).
This PR adds the same env vars and ldflags that are used in the Makefile to build standalone binaries.
Simulating a build for v52.0.0:
$ VER=v52.0.0 BUILD_TIMESTAMP=1703006570 COMMIT_HASH=cc9627c884b34fe145dc8a7aeedb18dca8ae19f4 GIT_BRANCH=master goreleaser build --clean --skip=validate --snapshot
  • starting build...
  • loading                                          path=.goreleaser.yml
  • skipping validate...
  • loading environment variables
  • getting and validating git state
    • ignoring errors because this is a snapshot     error=git doesn't contain any tags. Either add a tag or use --snapshot
    • git state                                      commit=965c7d12ce5775e90a44894f8f861b4225e4c8cc branch=fix/1468 current_tag=v0.0.0 previous_tag=<unknown> dirty=false
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
    • DEPRECATED:  brews.tap  should not be used anymore, check https://goreleaser.com/deprecations#brewstap for more info
  • snapshotting
    • building snapshot...                           version=0.0.0-SNAPSHOT-965c7d12
  • checking distribution directory
  • loading go mod information
  • build prerequisites
  • writing effective config file
    • writing                                        config=dist/config.yaml
  • building binaries
    • building                                       binary=dist/default_windows_386/kubeshark.exe
    • building                                       binary=dist/default_linux_amd64_v1/kubeshark
    • building                                       binary=dist/default_linux_arm64/kubeshark
    • building                                       binary=dist/default_linux_386/kubeshark
    • building                                       binary=dist/default_windows_amd64_v1/kubeshark.exe
    • building                                       binary=dist/default_darwin_arm64/kubeshark
    • building                                       binary=dist/default_windows_arm64/kubeshark.exe
    • building                                       binary=dist/default_darwin_amd64_v1/kubeshark
    • took: 3s
  • storing release metadata
    • writing                                        file=dist/artifacts.json
    • writing                                        file=dist/metadata.json
  • you are using deprecated options, check the output above for details
  • build succeeded after 2s
  • thanks for using goreleaser!

$ ./dist/default_linux_amd64_v1/kubeshark version
v52.0.0

Fixes #1468

Hi @gtirloni,
I sincerely apologize for the delayed response.
Thank you so much for your contribution and for taking the time to submit this PR. The issue you addressed has already been resolved in a different PR, which you can view here: PR #1504. Additionally, we’ve updated our release process and no longer upload archives with binaries. Instead, we now release unarchived binaries with the correct version output.
We truly appreciate your effort, and I hope you’ll consider contributing again in the future.
Thanks again!


[ENHANCEMENT] Please add "EVA: Visual Representation Fantasies from BAAI"

https://github.com/baaivision/EVA

Hi @apprisix , is there a specific model or use case? The EVA CLIP models will be available through open_clip (https://github.com/mlfoundations/open_clip/tree/main/src/open_clip/model_configs) shortly


On Hide Keyboard Function

How to know when the keyboard is hidden?
I think this plugin needs an onHideKeyboard function.
Will you update this?

Hi @phuhungtran,
Thanks for your comment and for using the package. It would be interesting to have such a callback, but if I implemented it I would need to either depend on or rewrite the functionality already encapsulated in the flutter_keyboard_visibility package.
This package provides you with a few callbacks so that you can react to keyboard visibility changes. It lets you build your widget tree based on whether or not the keyboard is visible, and perform stuff whenever the keyboard hides.
I think it would't make sense to add such a feature to keyboard_dismisser when there are ways to do the same thing already there in the wild. You can always build your own wrapper around my package and flutter_keyboard_visilibity to have them all in a single widget if you want. When it comes to reusable packages, the more specialized, the better, in my opinion.
Hope that leads you towards a solution to your problem. Thanks!

Hi @phuhungtran,
Thanks for your comment and for using the package. It would be interesting to have such a callback, but if I implemented it I would need to either depend on or rewrite the functionality already encapsulated in the flutter_keyboard_visibility package.
This package provides you with a few callbacks so that you can react to keyboard visibility changes. It lets you build your widget tree based on whether or not the keyboard is visible, and perform stuff whenever the keyboard hides.
I think it wouldn't make sense to add such a feature to keyboard_dismisser when there are ways to do the same thing already out there in the wild. You can always build your own wrapper around my package and flutter_keyboard_visilibity to have them all in a single widget if you want. When it comes to reusable packages, the more specialized, the better, in my opinion.
Hope that leads you towards a solution to your problem. Thanks!

Oh I got it.
Thank you @drogel .


NullPointerException with nonexistent Header when call "ReactiveRequestHolder.getHeaders"

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ * ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Bug

Which version of SkyWalking, OS, and JRE?
8.4.0

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.

What do you want to know?
code

public class ReactiveRequestHolder implements RequestHolder {
@Override
    public Enumeration<String> getHeaders(final String headerName) {
        return Collections.enumeration(this.serverHttpRequest.getHeaders().get(headerName));
    }
}

java.lang.NullPointerException: null
    at java.util.Collections$3.<init>(Collections.java:5314)
    at java.util.Collections.enumeration(Collections.java:5313)
    at org.apache.skywalking.apm.plugin.spring.mvc.commons.ReactiveRequestHolder.getHeaders(ReactiveRequestHolder.java:40)
    at org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor.lambda$collectHttpHeaders$0(AbstractMethodInterceptor.java:257)
    at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:176)
    at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
    at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
    at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
    at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
    at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
    at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
    at org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor.collectHttpHeaders(AbstractMethodInterceptor.java:258)
    at org.apache.skywalking.apm.plugin.spring.mvc.commons.interceptor.AbstractMethodInterceptor.beforeMethod(AbstractMethodInterceptor.java:134)

Requirement or improvement
We can change this to
@Override
    public Enumeration<String> getHeaders(final String headerName) {
        List<String> values = this.serverHttpRequest.getHeaders().get(headerName);
        if (CollectionUtil.isEmpty(values)) {
            return Collections.enumeration(Collections.EMPTY_LIST);
        }
        return Collections.enumeration(this.serverHttpRequest.getHeaders().get(headerName));
    }

Seems version or usage unsupported. You could check our plugin tests in https://github.com/apache/skywalking/tree/master/test/plugin/scenarios
You may find some clues.

I configed SpringMVCPluginConfig.Plugin.Http.INCLUDE_HTTP_HEADERS to collect header use WebFlex.
If Headers does not exist in ServerHttpRequest cause Collections.enumeration throw NullPointerException. Because Collections.enumeration need not null param.
https://github.com/apache/skywalking/blob/7c69ea889ee7a24c0049ffface3a04409b415af4/apm-sniffer/apm-sdk-plugin/spring-plugins/mvc-annotation-commons/src/main/java/org/apache/skywalking/apm/plugin/spring/mvc/commons/interceptor/AbstractMethodInterceptor.java#L225

Oh, if you mean to change lines of codes to avoid a NPE, you could submit a pull request, which would be more clear.
Reporting a NPE issue usually is hard to follow.


Temp solution to look up skims using time period categorical

When time period string is changed to an ordered pandas categorical in the ActivitySim choosers table, Sharrow's label relationship does not work with time period categorical when looking up skims.  It should be something similar to position .
I made some workarounds in the relationship.py as a temporary solution to work with time period categorical.
@jpn--

Closed in favor of the more complete fix in #47


Adding Search, intro to MVC

From DISQUS
David Hoffman
Fantastic tutorial! Some minor corrections (I think) needed on this page:

"following code... retrieves all the genres from the database" is missing 3rd line ("select") in the snippet
"using System;" required for use of "String"
"using System.Collections.Generic;" required for use of "GenreList = new List();"

Should be fixed now


Uploading an image in Base64 is not working anymore

Jodit Version:  3.4.25
Browser:  Chrome
OS:  Windows
Uploading an image in Base64 is not working anymore.
This is also the case in the playground: https://xdsoft.net/jodit/play.html
Configuration used:
"uploader": {
    "insertImageAsBase64URI": true
  }

Expected behavior:
Image should be uploaded and visible in the Editor
Actual behavior:
Nothing happened

https://xdsoft.net/jodit/play.html?uploader[insertImageAsBase64URI]=true in this case it should only insert image as base64 (<img src="data:..."). Not upload.

Yes it will not be uploaded as the image is inserted in base64 but the  element is not inserted in the Editor. (Sorry for the misunderstanding)

@xdan I think the problem is here https://github.com/xdan/jodit/commit/6249491c9757365eef9fd1c7bf83977ab39db020#diff-15622f5301880e861dd96fb4d54a56f2 because the first argument of defaultHandlerSuccess should be Uploader: https://github.com/xdan/jodit/blob/05864812dd7aa1a93936895782147ff7d6a122db/src/modules/uploader/uploader.ts#L100

Running into the same issue. I was able to solve it by downgrading to 3.4.23.

https://github.com/xdan/jodit/issues/474 related?

I also have this problem using the latest version '3.4.29'. In fact, this problem also occurs on the website @ https://xdsoft.net/jodit/ and in the Playground. Currently, our clients manage to get around the problem by dragging the image into the editor.
From the comment above by @xdan I wonder if we are having disagreement between the terms 'upload' and 'insert'? Using the Upload button I expect the end result to be an image insertion into the text at the location of the cursor.


CmdOrCtrl+Shift+Tab global hotkey conflicts with Chrome

Thank you for Tray! It's very impressive; I wouldn't have thought it'd be possible to do a UI like this with an addon.
One thing that confused me; Tray by default binds CmdOrCtrl+Shift+Tab to "Toggle window focus hotkey". That's also a Chrome hotkey which means "previous tab". It took me awhile to figure out why pressing it with Chrome focussed in Windows kept opening Obsidian, especially since first I looked at Obsidian's own hotkeys which has another binding for CmdOrCtrl+Shift+Tab.
I don't really use global hotkeys so I just disabled them all and I'm happy. But you might want to consider whether it's a good default. (Or just close this issue; it's definitely a stylistic choice.)

Happy to change the default if you've got a better suggestion.
Most hotkeys are taken up by one app or other so I'm not too concerned by a conflict with another app - there're so many different hotkeys available that it'll always conflict with something, that's partly why it's configurable. Plus, I do kinda expect people installing this to actually go through the options it ships with and customise the behaviours to their liking, since it is more of a power user extension.
I can see why overriding a default Obsidian hotkey wouldn't be ideal, though. In order to register the hotkey globally and not just as an in-app command it has to be configured through the extension's own options instead of Obsidian's hotkey settings, so I hadn't noticed that conflict yet myself. Thanks.

Is it possible to set "windows" key as a modifier? If so, how? I tried "win" and "windows" but it didn't work

@tommdq you need to use Super source
I've personally bound the "Toggle window focus hotkey" as "Super+Shift+Tab" (which is Win + Shift + Tab for me, on Win 11)

I feel bad saying this, but Win-Shift-Tab has a meaning in Windows already. It's paired with Win-Tab and scrolls backwards through windows on the desktop. I think it's the same in MacOS: Shift-Command-Tab changes windows. So now instead of overriding a single popular app's keybindings (Chrome) Tray will be trying to override the whole OS.
I don't have a good solution or alternate keybinding to suggest. I disable them in Obsidian and Tray, myself.

@NelsonMinar are you sure you're not thinking of Alt + Shift + Tab? Win + Tab opens with window switcher and Win + Shift + Tab doesn't do anything for me.
In that case, though, I'm thinking I'll put it back to how it was before and just leave it as-is. There will always be conflicts, because every app and OS registers hundreds of hotkeys, so I'd rather leave it up to users to pick which ones they want to prioritise and which ones they want to rebind.

Oops sorry, you are right about my confusion. Win + Shift + Tab doesn't seem bound to anything.


After users download data, tell them about downstream analyses

Context
We have downstream analysis pipelines and it is only linked in the docs. We should present it to users in the portal as well.
Problem or idea
When a user downloads data from the portal, we can present downstream analyses pipelines as a next step.
On the download modal, we can add a section to say what they can do with the data.
Solution or next step
I will re-design the modal to include the above.

Not going to tell people about this


shadowing warning with KP in nested context

Nested use of KP produces a shadowing warning. Maybe allocate new names per compilation unit or something?
scala> val x: Monad[Free[Coyoneda[Option,?],?]] = null
warning: type parameter X_kp1 defined in type L_kp shadows type X_kp1 defined in type L_kp. You may want to rename your type parameter, or possibly remove it.
...

I can't reproduce that issue on master. I don't see an obvious problem with shadowing, but it sounds like others have seen this too.
I'd love to get a new example that fails with KP but succeeds with type projections (along with the error message and version of Scala). If it can be expressed as a standalone Scala file (similar to this) then that would be even better.

I, too, have a lot of these warnings in my codebase.

I don't see an obvious problem with shadowing

The only problem with that is that it prevents enabling -Xfatal-warnings.
Here is a stand-alone Scala file:
import scala.language.higherKinds

object KindProjectorWarnings {
  trait Foo[F[_], A]
  trait Bar[A, B]

  def f[G[_]]: Unit = ()

  f[Foo[Bar[Int, ?], ?]] // shadowing warning
}

and compiler output:
[warn] /[...]/KindProjectorWarnings.scala:9: type parameter β defined in type Λ$ shadows type β defined in type Λ$. You may want to rename your type parameter, or possibly remove it.
[warn]   f[Foo[Bar[Int, ?], ?]] // shadowing warning
[warn]         ^

Not sure what you mean by "but succeeds with type projections"; if I were to write it by hand, I would just not re-use the same parameter name β twice.

Tried out the new version and the warnings are gone. Thanks!


Allow Supersedence and Dependency with "Add-IntuneWin32AppSupersedence"

Previously setting both supersedence and a dependancy on an app in Intune was not allowed, but you can now set this in the Intune GUI and through Graph, but the IntuneWin21App module has not been updated to reflect this
Image below of being able to do it through the GUI and Graph payload performing the "updateRelationship" POST request.

This is the same for both Add-IntuneWin32AppDependency & Add-IntuneWin32AppSupersedence
https://github.com/MSEndpointMgr/IntuneWin32App/blob/84b3d83a7e8454c3f27909017a67cf917e556747/Public/Add-IntuneWin32AppDependency.ps1#L64
https://github.com/MSEndpointMgr/IntuneWin32App/blob/c018c8d68e701de614b26156d03d4963541e7326/Public/Add-IntuneWin32AppSupersedence.ps1#L65

Having the same problem here.. @NickolajA some help here would be greatly appreciated

You're correct, this should be updated. I've assigned it to release 1.4.1.

Thanks @NickolajA much appreciated

This will be fixed in 1.4.2 thanks to PR #105 that now included.


Fancy router

mmh3 fails to build/compile.
Can you fix the vm (by installing apt-get install python-dev) and I finish the tests after ?

Done, check it out. I haven't checked it out yet, but please make sure that the new dependency doesn't prevent the usage of the entire library if it is not present. For example, kazoo is only required if you are using the ZK module.

Yeah I've done it that way. Though I need fixed the vm so it builds mmh3 when running the tests to finish the tests

I added python-dev to apt install list.
On Jan 8, 2017 10:38 AM, "ddorian"<EMAIL_ADDRESS>wrote:

Yeah I've done it that way. Though I need fixed the vm so it builds mmh3
when running the tests to finish the tests
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/moonlitesolutions/SolrClient/pull/64#issuecomment-271158414,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHqizmjHbG3xKTWGkLvTzjqP-UCGsHMzks5rQQMAgaJpZM4LdtWB
.

I can install it manually (after installing python-dev) doing sudo pip install mmh3 but on run_tests.py it's still can't be built (havent tried yet with your changes)

Sorry, you also need to add sudo apt-get install python3.5-dev and then it compiles.


Implement proof publishing on chain

Specification states that proof batches should be published on chain.
This should be implemented. But this is also design task, because we need to decide if it is going to be different names space or same name space, but different encoding for bytes.
Potentially required tasks

https://github.com/Sovereign-Labs/sovereign-sdk/issues/283
https://github.com/Sovereign-Labs/sovereign-sdk/issues/459

Closing issue as AFAIK it was implemented.


(PUP-10659) Fix Data Type casting causing memory leaks in Puppet Server

Casting between Puppet Data Types, such as Integer("9"), will cause
Puppet Server to retain Puppet::Parser::Catalog objects in memory
after requests finish.
This is caused by two issues in the new_function_for_type method:

The cache is a Hash instance with a lambda function that creates
constructor functions as they are requested. This lambda closes over
the Compiler scope value passed the first time new() is called, which
keeps that scope in memory.
The Compiler scope value passed the first time new() is called is
further passed into the constructor function when it is created. The
function then stores it as a local variable.[1]

Refactor the new_function_for_type method to pass nil instead of
scope when creating the constructor function. The functions will fall
back to using the current Compiler's global scope if the value
previously populated by scope is referenced.[2]
Similar work to initialize functions with nil as the closure scope was
done in https://github.com/puppetlabs/puppet/commit/915d934ad06.
[1] https://github.com/puppetlabs/puppet/blob/6.18.0/lib/puppet/pops/functions/function.rb#L23
[2] https://github.com/puppetlabs/puppet/blob/6.18.0/lib/puppet/pops/functions/function.rb#L78-L79

@joshcooper, would love some pointers on how we should test this. I confirmed that this does indeed fix the issue with puppetserver/jruby following @Sharpie's steps to reproduce.

CLA signed by all contributors.

jenkins please test this


(Feature Request) Implement a GUI to change the keybindings

I suggest the egui toolkit for this.

https://github.com/dlunch/wie/blob/61a1e36c46201716db6f5d01c5fcbc79756b96ed/wie_cli/src/main.rs#L135-L156
Currently you can change keybindings in this code

@mirusu400 I don't want to change the source code.


Resolve dev console scrollbar size calculation warning

See https://github.com/radix-ui/primitives/discussions/1594#discussioncomment-3913318 and https://github.com/theKashey/react-remove-scroll-bar/issues/35#issuecomment-1276809669

This won't be propagated to our users right?

This won't be propagated to our users right?

No, they need to refresh their lock afaik. It does validate the change works on our side though.


DEC-856: Long showcase/page names are cut off in the collection left nav drop down

Added a class to override the lowest div in the collection left nav menu items. Would have preferred to use an inline style in the react component, but unfortunately the mui.MenuItem innerDivStyle does not set the inner most div's style.

:+1:

:+1:


Weapon Mastery Tracking (Feature Suggestion)

It would be nice to have weapon mastery tracking, similar to the Damascus tracker.
They've also made it simple this time around, only requiring kills with a specific camo equipped.

I'll definitely look into adding this! Might need some help gathering all the mastery challenges though 🤔

Good news! The mastery challenges are the same for every weapon.


Read in and use h5 files for spatial transformation

Hi,
I'm trying to perform a spatial transformation using the h5 files from the qsi-prep output but I keep getting errors that seem to be related to the format of these files (here below an example). How can I load and read the h5 file properly? Thanks! Sendy

Hi! I'm not familiar with nitransforms, the h5 files from QSIPrep are ANTs/ITK transforms from a relatively recent version of ANTs. You can use these with the antsApplyTransforms program included in the docker image, or compile a recent ANTs to do this locally. If you'd like to stick with python, you can use antspy

Please reopen if you're still having trouble working with the h5 files!

I am currently trying to run Ants from the qsiprep docker but cannot figure out the right syntax. How can I get an Ants command running within the qsiprep image? Here is what I tried:  docker run --rm -it -v /mnt/ROIs/opticchiasm.nii:/ROI/roi.nii:ro -v /mnt/sub-NLR160EK_desc-preproc_T1w.nii.gz:/reference/T1.nii.gz:ro -v /mnt/output/Op_chiasm.nii.gz:/out/MNI_roi.nii.gz -v /mnt/qsiprep/sub-NLR160EK/anat/sub-NLR160EK_from-MNI152NLin2009cAsym_to-T1w_mode-image_xfm.h5:/trans/trans.h5 pennbbl/qsiprep:0.11.5 antsApplyTransforms -i /ROI/roi.nii / -r /reference/T1.nii.gz -o /out/MNI_roi.nii.gz -t /trans/trans.h5


Environment

It will take time for me to evalutate your contribution until then i am applying the hacktoberfest-accepted tag you can now work on other issues if you want


install conan from pip

It's needed because some requirements of qt necessitate a recent conan version.
build is ongoing on https://github.com/ericLemanissier/tsteeper/runs/1617953490?check_suite_focus=true

build passed on https://github.com/ericLemanissier/tsteeper/runs/1618496025?check_suite_focus=true


Appstudio update test-component-pac-mcqk

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-mcqk-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
8 seconds
init

✅ Succeeded
21 seconds
clone-repository

✅ Succeeded
3 minutes
build-container

✅ Succeeded
1 minute
sanity-inspect-image

✅ Succeeded
1 minute
deprecated-base-image-check

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
34 seconds
sbom-json-check

✅ Succeeded
17 seconds
sanity-label-check

✅ Succeeded
17 seconds
sanity-optional-label-check

✅ Succeeded
16 seconds
show-summary

Pipelines as Code CI/test-component-pac-mcqk-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
13 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
16 seconds
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
17 seconds
sanity-inspect-image

✅ Succeeded
18 seconds
sbom-json-check

✅ Succeeded
16 seconds
sanity-label-check

✅ Succeeded
17 seconds
sanity-optional-label-check

✅ Succeeded
13 seconds
show-summary

Pipelines as Code CI/test-component-pac-mcqk-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
13 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
17 seconds
sanity-inspect-image

✅ Succeeded
16 seconds
clair-scan

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
18 seconds
sbom-json-check

✅ Succeeded
17 seconds
sanity-optional-label-check

✅ Succeeded
16 seconds
sanity-label-check

✅ Succeeded
13 seconds
show-summary

Pipelines as Code CI/test-component-pac-mcqk-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
13 seconds
init

✅ Succeeded
16 seconds
clone-repository

✅ Succeeded
1 minute
build-container

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
17 seconds
sanity-inspect-image

✅ Succeeded
16 seconds
clair-scan

✅ Succeeded
18 seconds
sbom-json-check

✅ Succeeded
16 seconds
sanity-label-check

✅ Succeeded
17 seconds
sanity-optional-label-check

✅ Succeeded
13 seconds
show-summary


Added khmer localization

Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Related Issues

Fix #123
Related #456

Type of Change

[x] ✨ New feature: Adds new functionality without breaking existing features.
[ ] 🛠 Bug fix: Resolves an issue without altering current behavior.
[ ] 🧹 Code refactor: Code restructuring that does not affect behavior.
[ ] ❌ Breaking change: Alters existing functionality and requires updates.
[ ] 🧪 Tests: Adds new tests or modifies existing tests.
[ ] 📝 Documentation: Updates or additions to documentation.
[ ] 🗑 Chore: Routine tasks, or maintenance.
[ ] ✅ Build configuration change: Changes to build or deploy processes.

Suggestions

The insertVideo has been added recently in release/v11 branch after merging this PR.
Can you give me the translation of Insert Video for this locale or submit a PR aginst the v11 branch if you prefer?

Hello @EchoEllet, The translation of Insert Video is បញ្ចូលវីដេអូ
Thank you.


Colour favicons based on issue/pr status

Description
It would be nice to have the GitHub favicon colour by PR/Issue state to make it easier to distinguish tabs when you have a lot open.
Example URLs
https://github.com/refined-github/refined-github/issues/6686

GitHub already changes the icon depending on CI status of PRs, as well as dark mode. It’s not practical here to fight GitHub’s logic and offer the many variants necessary for this feature.
Related requests:

https://github.com/refined-github/refined-github/issues/6134


Comment editing: Backend

Backend task for #945: comment API backend extended to handle tracking last updated

[x] Comment list API includes last edited date
[x] Comment editing API includes last edited in response data on successful edit
[x] Confirm comment editing API limited to author
[x] QA criteria satisfied

QA criteria
Dev:

[x] checked that this feature works across all agreed supported browsers and devices.
[x] checked that this code meets the agreed accessibility level.
[x] checked that this code meets the agreed browser performance levels.
[x] checked that this code conforms to the project coding standards.
[x] had code reviewed by another developer and resolved any issues raised.
[x] tested this feature as an end user.
[x] checked that the feature works on the server/s I am deploying it to.

QA:

[x] tested this feature as a front end user and it meets the acceptance criteria/conforms to the specification and design.
[x]  checked that the feature works on the server/s deployed to

Testing:
You can access the API on the dev environment, you will need to be logged in:
List of comments for a submission: https://dev-apply.opentech.fund/apply/api/submissions/10/comments/ where 10 is the id of the submission with comments.
You can also use the form at the bottom of the page to create a new comment.
Editing comments:
https://dev-apply.opentech.fund/apply/api/comments/296/edit/  where 296 is the comment you wish to edit. You can only edit your own comments, and can only edit a content once. After you have edited the comment it should remain in the same position in the list view, but with the extra edited field data.

Good to be deployed to the test server

This can be tested on #945, with the frontend and backend together


connect_error

It is not possible when I try to connect to nodejs and it gives a coonect_error error
course:
https://medium.com/flutter-community/realtime-chat-app-one-to-one-using-flutter-socket-io-node-js-acd4152c6a00

Try using socket.io version 2.3.0

Still doesnt work.

I've encountered errors (constant timeouts during initialization of connection) while trying to connect to nodejs server running socket.io version 3.1.1. Setting allowEIO3 while creating the server fixed the issue for me.
Hope it helps


basic jquery datatables done for datatables and row details closes #76

Coverage remained the same at 100.0% when pulling 1d252263fb9564c732204ca7814e9fbb20b7d1c3 on jquery-data-tables-#76 into c8e2374997669b29a180dc3b081827bd94ec3b3d on develop.


Battery powered devices fully supported ?

I agree to the following

[X] I have read the documentation
[X] I am aware of the latest release notes
[X] The Backend (CCU/Homegear/...) is working as expected and connected devices are controllable by its own UI.
[X] I am running the latest version of the custom_component (and Home Assistant)

The problem
Hi Guys,
are battery powered devices fully supported. I see only Low battery state but not the buttons of the device in HA.
For example HmIP-FCI6 and HmIP-WRCC2

What version of HomematicIP (local) has the issue?
1.33.0
What was the last working version of HomematicIP (local)?
1.33.0
What type of installation are you running?
Home Assistant Container
What type of installation are you running for your homematic backend?
RaspberryMatic Standalone
Which version of your homematic backend are you running?
<IP_ADDRESS>30114
What hardware are you running for your system?
HA Synology. Raspberrymatic Pi3
Which config details do you use

[X] Username and password
[ ] TLS
[ ] callback data (see)

Which interfaces do you use?

[X] Homematic IP
[X] Homematic (Bidcos-RF)
[ ] Groups (Heating-Group)
[ ] BidCos-Wired (HM-Wired)

Diagnostics information
config_entry-homematicip_local-8cbca1f7e88c2f6261e5c2237809e268.json.txt
config_entry-homematicip_local-8cbca1f7e88c2f6261e5c2237809e268.json (1).txt
Anything in the logs that might be useful for us?
No response
Additional information
No response

These devices are fully supported.
These devices emit events, which are stateless, so no entities are created.
You could use device triggers within automations, or use the blueprints referenced in the docs.


[Question] Results on tanks and temples

Hello! Thank you for the great work!
Could you please share a table with the results on tanks and temples? I mean for each of the 9 scenes.

How are you averaging metrics? We average PSNR in the square error domain and SSIM in sqrt(1-SSIM).

Actually I used just a simple averaging for every subsection of your table (I mean for Nerfacto, LocalRF (COLMAP), LocalRF (COLMAP init), ...) What do you mean by "average in domain"? Is this from paper [5]? Could you please share the formula of the averaging? Are mentioned results from the paper obtained from this table?

Hello! I think you can refer to render.py and train.py, which roughly means averaging the mse error values of all images, and then converting this average into a psnr value.

Hi

Hello! I think you can refer to render.py and train.py, which roughly means averaging the mse error values of all images, and then converting this average into a psnr value.

Yes, we average square error values before converting to PSNR as in render.py: $\text{MSE} = \frac1n\displaystyle\sum_{i=1}^{n} \text{MSE}_i$ and $\overline{\text{PSNR}} = 10  \log_{10}\left(\frac{1}{\text{MSE}} \right) $.
For SSIM, we convert to the $\sqrt{(1-\text{SSIM})}$ domain for averaging, before converting back to SSIM: $\overline{\text{SSIM}} = 1- \left(\frac1n\displaystyle\sum_{i=1}^{n} \sqrt{(1-\text{SSIM}_i)}\right)^2$. This is not currently implemented in render.py.

Thanks for your reply!

Hi

Hello! I think you can refer to render.py and train.py, which roughly means averaging the mse error values of all images, and then converting this average into a psnr value.

Yes, we average square error values before converting to PSNR as in render.py: MSE=1n∑i=1nMSEi and PSNR―=10log10(1MSE).
For SSIM, we convert to the (1−SSIM) domain for averaging, before converting back to SSIM: SSIM―=1−(1n∑i=1n(1−SSIMi))2. This is not currently implemented in render.py.

Thanks for your reply, I would also like to ask you whether the calculation metric is calculated using the saved render image, or is calculated directly without saving it as a image. I think there will be some errors because there is a rounding operation in saving the image.


XML_ENABLE_VISIBILITY should not be defined on MSVC

When it is defined to 1, then Expat uses __attribute__((visibility("default"))) without any other checks. This is a GNU extension, and does not work when building with MSVC.

Fixed. Didn't close automatically because that only happens on master...


Fix for :undance (:uneffect alias) not stopping dance animation

The :undance command existed (as an alias for :uneffect or UnEffect), but never really stopped the dance that was played.
This addition adds the command, the server call, and the client side. If it finds an animation named "ADONIS_Animation" it stops it and then makes the user jump (an extremely efficient way to restore default animations, if the character was stationary)
After Update: https://youtu.be/_NkJnWv3UcM
Before Update: https://youtu.be/EogfvpDfJKA

Isn't there a better way to stop an animation than making the player jump

Isn't there a better way to stop an animation than making the player jump

Humanoid:ChangeState

Isn't there a better way to stop an animation than making the player jump

The jump happens after I clear the player's "adonis_animation"--I wanted it to be dynamic and work in all games and users, particularly people/games that had custom idle animations
Also, just tried ChangeState and it still keeps the player in a limbo state (screenshot below)

Some games dont want players jumping tho

Some games dont want players jumping tho

That's true, do you recommend that I leave the player in no animation (until they "choose" their next animation)

Isn't there a better way to stop an animation than making the player jump

Cant we dynamically check the jump power of the player and base it on that?


ratatui-minimal has strange behavior

sometimes when started there is an extra blank line and the cursor is positioned on the second line
if I type a single character it is repeated in the widget

Here I simply ran it and typed hello world
It only fails on windows, works on linux (WSL unbuntu 20)
BTW - minimal (with tui) works fine

also checked on mac, works fine.
I tried to debug on windows (my main dev env) and it seemed that crossterm was generating extra events. This loop doesn't really involve ratatui. But maybe its something to do with how ratatui sets up crossterm, or what term.draw is doing
   loop {
        term.draw(|f| {
            f.render_widget(textarea.widget(), f.size());
        })?;
        match crossterm::event::read()?.into() {
            Input { key: Key::Esc, .. } => break,
            input => {
                textarea.input(input);
            }
        }
    }

but I ran out of time to investigate further. I am away from my main dev env for 6 weeks, sorry I cannot add more info

@pm100  key doubling problem occurs in vscode terminal, but not in, this is crossterm problem, as i think
but in usual cmd/powershell it doesnt doubled (idk why)
main reason - app reacts to Press and Release event both as one key event
possible solution - check for event kind before action, like
if let Event::Key(key) = event::read()? {
            if key.kind == KeyEventKind::Press {
                    .....
            }
    }

I am on the road away from my windows dev box but I am pretty sure I was not in vs code terminal. I never use that for tui' development, I always have externalconsole set

From: MindMayhem @.>
Sent: Monday, May 1, 2023 9:29:31 PM
To: rhysd/tui-textarea @.>
Cc: pm100 @.>; Mention @.>
Subject: Re: [rhysd/tui-textarea] ratatui-minimal has strange behavior (Issue #14)
@pm100https://github.com/pm100 key doubling problem occurs in vscode terminal, but not in, this is crossterm problem, as i think
but in usual cmd/powershell it doesnt doubled (idk why)
main reason - app reacts to Press and Release event both as one key event
possible solution - check for event kind before action, like
if let Event::Key(key) = event::read()? {
if key.kind == KeyEventKind::Press {
.....
}
}
—
Reply to this email directly, view it on GitHubhttps://github.com/rhysd/tui-textarea/issues/14#issuecomment-1530111051, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADXOD5OYIULVMQKQUNFUDDXEAFJXANCNFSM6AAAAAAXGHKQ3Y.
You are receiving this because you were mentioned.Message ID: @.***>

Will do. But in fact I am sure that I did that too. Other oddity is that it works fine with tui, it's only ratatui that is wierd.

From: MindMayhem @.>
Sent: Monday, May 1, 2023 11:01:01 PM
To: rhysd/tui-textarea @.>
Cc: pm100 @.>; Mention @.>
Subject: Re: [rhysd/tui-textarea] ratatui-minimal has strange behavior (Issue #14)
external console set can be a reason of input doubling
try to compile ur app and run in pure cmd/powershell
пн, 1 мая 2023 г., 22:54 pm100 @.***>:

I am on the road away from my windows dev box but I am pretty sure I was
not in vs code terminal. I never use that for tui' development, I always
have externalconsole set

From: MindMayhem @.>
Sent: Monday, May 1, 2023 9:29:31 PM
To: rhysd/tui-textarea @.>
Cc: pm100 @.>; Mention @.>
Subject: Re: [rhysd/tui-textarea] ratatui-minimal has strange behavior
(Issue #14)
@pm100https://github.com/pm100 key doubling problem occurs in vscode
terminal, but not in, this is crossterm problem, as i think
but in usual cmd/powershell it doesnt doubled (idk why)
main reason - app reacts to Press and Release event both as one key event
possible solution - check for event kind before action, like
if let Event::Key(key) = event::read()? {
if key.kind == KeyEventKind::Press {
.....
}
}
—
Reply to this email directly, view it on GitHub<
https://github.com/rhysd/tui-textarea/issues/14#issuecomment-1530111051>,
or unsubscribe<
https://github.com/notifications/unsubscribe-auth/AADXOD5OYIULVMQKQUNFUDDXEAFJXANCNFSM6AAAAAAXGHKQ3Y

.
You are receiving this because you were mentioned.Message ID: @.***>

—
Reply to this email directly, view it on GitHub
https://github.com/rhysd/tui-textarea/issues/14#issuecomment-1530131819,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJNZSE6S72SAPFEPH7MRPYLXEAIHBANCNFSM6AAAAAAXGHKQ3Y
.
You are receiving this because you commented.Message ID:
@.***>

—
Reply to this email directly, view it on GitHubhttps://github.com/rhysd/tui-textarea/issues/14#issuecomment-1530257611, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AADXOD6EWYTRWP4BOWIYTBLXEAQA3ANCNFSM6AAAAAAXGHKQ3Y.
You are receiving this because you were mentioned.Message ID: @.***>

I checked. This fails if run directly from powershell command line

and works fine with tui.

This should be fixed by 68f4e0d


fix: [release/v0.14.x] Introduce startup probe to CAREN pod to reduce races

Introduce a more frequent startup probe polling every second, which once
it succeeds will trigger readiness and liveness probes to run at their
default intervals. This reduces chances of races in clusterctl checking
for readiness while keeping the overhead on the kubelet for checking
readiness once the pod is up to a minimum (default probe period).

I think this is the wrong timeout, and is being set for the helm registry?

with this it will result in following with defaults
readinessProbe:
      failureThreshold: 3
      httpGet:
        path: /readyz
        port: healthz
        scheme: HTTP
      periodSeconds: 1
      successThreshold: 1
      timeoutSeconds: 1

Once the container starts it will probe every 1 second with timeout of 1 seconds and upto 3 consecutive failures. so I guess CAREN should be up and ready in 3 seconds. CAREN starts within a second.

with this it will result in following with defaults
readinessProbe:
      failureThreshold: 3
      httpGet:
        path: /readyz
        port: healthz
        scheme: HTTP
      periodSeconds: 1
      successThreshold: 1
      timeoutSeconds: 1

Once the container starts it will probe every 1 second with timeout of 1 seconds and upto 3 consecutive failures. so I guess CAREN should be up and ready in 3 seconds. CAREN starts within a second.

While you're right, the failure of a readiness probe just removes it from the service endpoints so the pod keeps running (as opposed to liveness probe where the pod will be killed). The readiness probe will still run every second and after a single success will be marked as ready. So this isn't a problem even if it fails.

I've actually changed the implementation here to use startup probe to have the same effect (fast checking for readiness) but not have the overhead on the kubelet of probing every second once the pod is first set to ready (using default readiness probe period once startup probe has succeeded).

@dkoshkin If you could take a look and approve again if you're happy then we can merge.


LDAP Authentification

The svn admin interface packaged does support (with a little fixing -- see issues in their repository) LDAP; including groups and access to repository paths, so all in all pretty powerful.
In order for the svn checkout to work through the apache server created here, you'd need to update the configuration. We did that in our configuration (not possible to create a pull request though) but feel free to contact me incase you have any troubles. It was a very straight forward fix with a little bit of googling.

Thank you @Rincewind34 , I'll have a look as soon as possible! 😉

@Rincewind34 can you please provide this "little fixing" you mentioned in

The svn admin interface packaged does support (with a little fixing -- see issues in their repository) LDAP; including groups and access to repository paths, so all in all pretty powerful

I am struggeling for quite some time now, getting this to work. I'm planning on authenticate users via group membership in ldap. Do I need to change the webdav AuthType from basic base to ldap?
`/etc/subversion # cat /etc/apache2/conf.d/dav_svn.conf
LoadModule dav_svn_module /usr/lib/apache2/mod_dav_svn.so
LoadModule authz_svn_module /usr/lib/apache2/mod_authz_svn.so
<Location /svn>
DAV svn
SVNParentPath /home/svn
SVNListParentPath On
AuthType Basic
AuthName "Subversion Repository"
AuthUserFile /etc/subversion/passwd
AuthzSVNAccessFile /etc/subversion/subversion-access-control
Require valid-user`

Here is how I did it, just authentication no authorization, directly in the container.
Get in:
docker exec -ti svn-server sh

Install apache ldap mod:
apk update
apk add apache2-ldap

Activate ldap module, in /etc/apache2/httpd.conf add:
LoadModule ldap_module modules/mod_ldap.so
LoadModule authnz_ldap_module modules/mod_authnz_ldap.so

Then in /etc/apache2/conf.d/dav_svn.conf:
LoadModule dav_svn_module /usr/lib/apache2/mod_dav_svn.so
LoadModule authz_svn_module /usr/lib/apache2/mod_authz_svn.so

<Location /svn>
  DAV svn
  SVNParentPath /home/svn
  SVNListParentPath On
  SVNPathAuthz off
  AuthType Basic
  AuthBasicProvider ldap
  AuthName "SVN login"
  AuthLDAPURL "ldap://ldap-server:389/ou=a,dc=b?sAMAccountName?sub?(objectClass=user)"
  AuthLDAPBindDN bindUser
  AuthLDAPBindPassword binderUserPwd
  Require valid-user
  </Location>

Of course, the ldap url needs to be adjusted to your situation (ou's, dc's, levels, the actual attribute for the user etc).
Hope this helps

I am sorry but I could not give this repo the love it deserves. 😞
So I decided to archive it and make it read only, so people can fork and apply their changes.
Thank you for taking the time to rise an issue! ❤


[DO NOT MERGE] Auto PR to update dependencies of pilot

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
e4af786ed0814b819d370898e4eec7761c4b6aaf
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


C++ |CreateClientVpnEndpoint | ERROR CODE 500 | An internal error has occurred

Confirm by changing [ ] to [x] below to ensure that it's a bug:
Additional context
Add any other context about the problem here.

From cloudtrail I don't see anytgibg wrong with the request.
{

    "requestParameters": {
        "CreateClientVpnEndpointRequest": {
            "ClientCidrBlock": "<IP_ADDRESS>/20",
            "ConnectionLogOptions": {
                "CloudwatchLogStream": "vpn1",
                "CloudwatchLogGroup": "aws-vpn",
                "Enabled": true
            },
            "SplitTunnel": false,
            "Description": "Clients vpn endpoint",
            "VpcId": "vpc-0b89e993beb0ea344",
            "ServerCertificateArn": "arn:aws:acm:us-west-2:327948173372:certificate/4ef0a8c3-5f1a-49c2-a8ab-b06c2f809c83",
            "Authentication": {
                "MutualAuthentication": {
                    "ClientRootCertificateChainArn": "arn:aws:acm:us-west-2:327948173372:certificate/58e13e9a-3a6b-4e33-841a-bbf24bf69074"
                },
                "Type": "certificate-authentication",
                "tag": 1
            },
            "SecurityGroupId": {
                "tag": 1,
                "content": "sg-03923a5a8b8a90d95"
            },
            "TransportProtocol": "tcp",
            "ClientToken": "3B54F19E-A38C-423A-92F1-39AB7C0F9F72",
            "TagSpecification": {
                "tag": 1,
                "Tag": {
                    "Value": "vpn",
                    "tag": 1,
                    "Key": "Name"
                }
            },
            "VpnPort": 443
        }
    },
    "responseElements": null,
    "requestID": "60f694b6-aa4c-4e03-9e0d-f0d5205c3360",
    "eventID": "65f1b31d-aac5-4195-8fe6-1f0af1b1a359",
    "eventType": "AwsApiCall",
    "recipientAccountId": "327948173372"
}

Found out what was wrong.
The api doesn't show that I have not set tags properly.

sorry I couldn't respond on time, took me a while to set up the test case I had going, glad you found your answer though!


Speaker in SAVEE dataset

Should the following line use p.parts[1] instead of p.stem[:2] for obtaining speaker ID?
https://github.com/Strong-AI-Lab/emotion/blob/076ad6e6e55a573693daa4e0e3904c0f110e0c15/datasets/SAVEE/process.py#L57
I checked with these (p equal to wav_file in this case)
In [99]: wav_file.parts[1]
Out[99]: 'JK'

In [100]: wav_file.stem[2]
Out[100]: 'n2'

I just checked that you sampled and renamed the original files, so this is not the issue.


Get.lazyPut The controllers are not reinitializing after being dispose

In my project, I have implemented Get.lazyPut(), the thing is I want to reinitialize the controllers which are disposed of for that purpose I am using Get.lazyPut(() =>Controller(), fenix: true); but it is not working as expected
Here the error I am getting
The following assertion was thrown while finalizing the widget tree:
A TextEditingController was used after being disposed.
Once you have called dispose() on a TextEditingController, it can no longer be used.
When the exception was thrown, this was the stack:
packages/flutter/src/foundation/change_notifier.dart 276:12                                   dispose
packages/dosii/features/profile/personal_profile/controllers/profile_controller.dart 1067:25  onClose

flutter doctor -v
Manage your Flutter app development.
Common commands:

  flutter create <output directory>
    Create a new Flutter project in the specified directory.

  flutter run [options]
    Run your Flutter application on an attached device or in an emulator.

Usage: flutter <command> [arguments]

Global options:
-h, --help                      Print this usage information.
-v, --verbose                   Noisy logging, including all shell commands executed.
                                If used with "--help", shows hidden options. If used with "flutter doctor", shows additional diagnostic
                                information. (Use "-vv" to force verbose logging in those cases.)
    --prefixed-errors           Causes lines sent to stderr to be prefixed with "ERROR:".
    --quiet                     Reduce the amount of output from some commands.
    --[no-]wrap                 Toggles output word wrapping, regardless of whether or not the output is a terminal.
                                (defaults to on)
    --wrap-column               Sets the output wrap column. If not set, uses the width of the terminal. No wrapping occurs if not writing
                                to a terminal. Use "--no-wrap" to turn off wrapping when connected to a terminal.
-d, --device-id                 Target device id or name (prefixes allowed).
    --version                   Reports the version of this tool.
    --machine                   When used with the "--version" flag, outputs the information using JSON.
    --[no-]color                Whether to use terminal colors (requires support for ANSI escape sequences).
                                (defaults to on)
    --[no-]version-check        Allow Flutter to check for updates when this command runs.
                                (defaults to on)
    --suppress-analytics        Suppress analytics reporting when this command runs.
    --packages                  Path to your "package_config.json" file.

Local build selection options (not normally required):
    --local-engine-src-path     Path to your engine src directory, if you are building Flutter locally.
                                Defaults to $FLUTTER_ENGINE if set, otherwise defaults to the path given in your pubspec.yaml
                                dependency_overrides for sky_engine, if any.
    --local-engine              Name of a build output within the engine out directory, if you are building Flutter locally.
                                Use this to select a specific version of the engine if you have built multiple engine targets.
                                This path is relative to "--local-engine-src-path" or "--local-engine-src-out" (q.v.).

Options for testing the "flutter" tool itself:
    --show-test-device          List the special "flutter-tester" device in device listings. This headless device is used to test Flutter
                                tooling.
    --show-web-server-device    List the special "web-server" device in device listings.

Available commands:

Flutter SDK
  bash-completion   Output command line shell completion setup scripts.
  channel           List or switch Flutter channels.
  config            Configure Flutter settings.
  doctor            Show information about the installed tooling.
  downgrade         Downgrade Flutter to the last active version for the current channel.
  precache          Populate the Flutter tool's cache of binary artifacts.
  upgrade           Upgrade your copy of Flutter.

Project
  analyze           Analyze the project's Dart code.
  assemble          Assemble and build Flutter resources.
  build             Build an executable app or install bundle.
  clean             Delete the build/ and .dart_tool/ directories.
  create            Create a new Flutter project.
  drive             Run integration tests for the project on an attached device or emulator.
  format            Format one or more Dart files.
  gen-l10n          Generate localizations for the current project.
  pub               Commands for managing Flutter packages.
  run               Run your Flutter app on an attached device.
  test              Run Flutter unit tests for the current project.

Tools & Devices
  attach            Attach to a running app.
  custom-devices    List, reset, add and delete custom devices.
  daemon            Run a persistent, JSON-RPC based server to communicate with devices.
  debug-adapter     Run a Debug Adapter Protocol (DAP) server to communicate with the Flutter tool.
  devices           List all connected devices.
  emulators         List, launch and create emulators.
  install           Install a Flutter app on an attached device.
  logs              Show log output for running Flutter apps.
  screenshot        Take a screenshot from a connected device.
  symbolize         Symbolize a stack trace from an AOT-compiled Flutter app.

Run "flutter help <command>" for more information about a command.
Run "flutter help -v" for verbose help output, including less commonly used options.
dosii@Aaloks-MacBook-Air Dosii % flutter doctor -v
[✓] Flutter (Channel stable, 3.0.0, on macOS 12.3.1 21E258 darwin-arm (Rosetta), locale en-IN)
    • Flutter version 3.0.0 at /Users/dosii/Documents/flutter_3.0.0
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ee4e09cce0 (7 months ago), 2022-05-09 16:45:18 -0700
    • Engine revision d1b9a6938a
    • Dart version 2.17.0
    • DevTools version 2.12.2

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/dosii/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

This is taking an unexpectedly long time...[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.73.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.54.0

Scanning for devices is taking a long time...[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 12.3.1 21E258 darwin-arm (Rosetta)
    • Chrome (web)    • chrome • web-javascript • Google Chrome 107.0.5304.121

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

This issue was of not properly using the Get.lazyPut dependency


ci: lint pull request title

Current dependencies on/for this PR:

main

PR #324   👈

This stack of pull requests is managed by Graphite.


Fix stripping of slashes from paths

Context
Our team ran into issues where slashes were being stripped when a filepath with a protocol was supplied. For example, say duck.gltf references ducktex.png. If we supplied a URI like file://duck.gltf into tinygltf it would search for file:/ducktex.png (note the single slash).
This is because GetBaseDir() strips out the final slash. In most cases this is fine because JoinPath() adds the "/" back in. However, JoinPath() has the following check:
    if (lastChar != '/') {
      return path0 + std::string("/") + path1;
    } else {
      return path0 + path1;
    }

This means that for the "file://duck.gltf" case, GetBaseDir("file://duck.gltf") = "file:/". And then JoinPath("file:/", "ducktext.png") = "file:/ducktext.png".
The simple solution in this PR is to just leave the slash in when getting the base directory. I'm happy to modify JoinPath as well if you would like (I think we can remove the special if logic but wanted to keep this diff as simple as possible).
Testing
Ran tests using the test_runner:
tinygltf % python3 test_runner.py
Testing: /Users/pmcg/github/glTF-Sample-Models/2.0/AnimatedMorphCube/glTF/AnimatedMorphCube.gltf
Testing: /Users/pmcg/github/glTF-Sample-Models/2.0/AnimatedMorphCube/glTF-Binary/AnimatedMorphCube.glb
Testing: /Users/pmcg/github/glTF-Sample-Models/2.0/DamagedHelmet/glTF/DamagedHelmet.gltf
...
Success : 213
Failed  : 0

After some thinking, I think it'd be better to consider proto:// and //(UNC path. \\ on Windows https://www.techtarget.com/whatis/definition/Universal-Naming-Convention-UNC ) in GetBaseDir and JoinPath.
For example,
GetBaseDir: path
  if path.contains("://"): Split into ["***://", ***]
  else: Split at last '/'(`\`)

And JoinPath considers both  //(\\) and / case

@syoyo got it, I think the issue with this is that proto:// paths can also have their own directory structure. For example: file://mydir/myimage.png
The proposed pseudocode above would not handle this case, so then we would need a case which handles where proto:// is the base dir or if proto://.../... is the directory structure. In general it feels like this would lead down a rabbithole of special-casing. I am happy to make the changes but just wanted to propose the option I have right now where we basically allow the user to supply in whatever file structure they would like.
If we are non-destructive to the pathing (don't remove any \ or / at all) then it seems like this could safely work on any system or path. I found some examples where other open source repos appear to take the same approach:
https://github.com/Tencent/ncnn/blob/1b7e6358c96e164131873dd5e252d22e7b2a7f87/src/simplevk.cpp#L172-L175
https://github.com/ggerganov/llama.cpp/blob/6369bf04336ab60e5c892dd77a3246df91015147/examples/quantize/quantize.cpp#L357-L359
https://github.com/mysql/mysql-server/blob/824e2b4064053f7daf17d7f3f84b7a3ed92e5fb4/include/manifest.h#L84

@pmcgvr super awesome! thanks a lot! oh code fragments in llama.cpp(I love llama.cpp).
Thus your initial proposal should work well. PR will be soon merged, but let me give few more time to understand how other OSS deal with it.

Merged! Thanks!