fix(java): update pom.xml to use javac 8

fix using high version jdk compile to low version such as jdk8 using --release instead of -target
solve the https://github.com/apache/incubator-fury/issues/1577

Starting JDK 9, the javac executable can accept the --release option to specify against which Java SE release you want to build the project. For example, you have JDK 11 installed and used by Maven, but you want to build the project against Java 8. The --release option ensures that the code is compiled following the rules of the programming language of the specified release, and that generated classes target the release as well as the public API of that release. This means that, unlike the -source and -target options, the compiler will detect and generate an error when using APIs that don't exist in previous releases of Java SE.
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html

Hi @stardustman , thanks for your contribution. Could you add a ByteBuffer ut for this ?

Hi @stardustman , thanks for your contribution. Could you add a ByteBuffer ut for this ?

Seems this is not easy to add a test, we must compile use one java version, and run it with another java version.

this 0.4.1 version in mvnrepository compile with jdk17? or other version?

this 0.4.1 version in mvnrepository compile with jdk17? or other version?

The major in class file is 52, so it should be java8 already

this 0.4.1 version in mvnrepository compile with jdk17? or other version?

The major in class file is 52, so it should be java8 already
if this jar was compiled using jdk8's javac to get class file, this should not report error when execute with jdk8.
but I get error when I serialize the ByteBuffer, example code like this:

import io.fury.Fury;
import io.fury.ThreadLocalFury;
import io.fury.ThreadSafeFury;
import io.fury.config.Language;

import java.nio.ByteBuffer;

public class FuryTest {

    // Note that Fury instances should be reused between
    // multiple serializations of different objects.
    private static final ThreadSafeFury fury = new ThreadLocalFury(classLoader -> {
        Fury f = Fury.builder()
                .withLanguage(Language.JAVA)
                .withClassLoader(classLoader)
                .requireClassRegistration(false)
                .build();
        return f;
    });

    public static byte[] encoder(Object object) {
        return fury.serialize(object);
    }

    public static <T> T decoder(byte[] bytes) {
        return (T) fury.deserialize(bytes);
    }

    public static void main(String[] args) {
        byte len = 10;
        ByteBuffer byteBuffer = ByteBuffer.allocate(len);
        for (int i = 0; i < len; i++) {
            byteBuffer.put((byte) i);
        }
        byte[] bytes = FuryTest.encoder(byteBuffer);
        System.out.println(bytes.length);

    }

}

I forgot which javac version I'm using.
I use following steps to guess javac version:

download jar from https://mvnrepository.com/artifact/org.furyio/fury-core/0.4.1
Extract classfile: jar xf fury-core-0.4.1.jar io/fury/Fury.class
Get major version: javap -verbose -cp fury-core-0.4.1.jar io/fury/Fury.class | grep "major"

I use the branch releases-0.4.1 and jdk1.8.0_241 then  execute the mvn package in the IDE to get the final jar file, and test using this jar, this time the test code can execute, but using the jar download from mvn central repo  report error.
I also try to use jdk11 to execute the mvn package but get the  error: package sun.misc does not exist.

Hi @stardustman , does latest fury 0.8.0 works for you on JDK8?


LoadBalancer and Backends interface are SocketAddr oriented, while ProxyHttp::upstream_peer() is HttpPeer oriented

What is the problem your feature solves, or the need it fulfills?
The examples of LoadBalancer are oriented around SocketAddrs, e.g. addr+ports. This includes the constructor of LoadBalancer, as well as the interfaces of Backends.
However, when using LoadBalancer as a part of a ProxyHttp implementation, the Service is expected to provide an HttpPeer, which includes additional information, such as TLS+SNI information.
Is the recommended usage of LoadBalancer to obtain the socketaddr from the selection process, then do a second mapping of SocketAddr to HttpPeers?
Describe the solution you'd like
I'm guessing the intent here is to support both TCP and HTTP load balancing, though I'm unsure what the intended use was for this.
I'm going to start looking into this, but wanted to raise it in case I'm just looking at it incorrectly.
Additional context
CC https://github.com/memorysafety/river/issues/39

Right now yes, the usage is that we obtain the SocketAddr and then map to an HttpPeer. Because we want to keep LoadBalancer relatively generic, we probably want to be able to return optional metadata along with the SocketAddr instead of having the balancer return peers.

@drcaramelsyrup that makes sense! River could probably assume the metadata should always be there (or ignore HTTP peers without metadata), which would leave the door open for that.
Open to either having "optional" methods, like .get_metadata() -> Option<PeerMetadata>, or having a separate "with metadata" trait which we could bound on for our purposes (so we don't need to do that extra option check).
Let me know if you have any API proposals or have a branch with an API for me to try out, I can hack on it and report back, or open a PR that matches the API you propose.

Do you mean including optional metadata in the Backend? I think that might be the easiest way to go, you may want some of that metadata to affect the Backend hash as well. If you have bandwidth to try that out, happy to look at a PR.

Now that I've got #275 figured out, I'll look into this as an alternative to doing a two-stage lookup.


False error: Global actor 'MyActor'-isolated property 'state' can not be mutated from global actor 'MyActor'

Describe the bug
Isolation check gives false error
Steps To Reproduce
Steps to reproduce the behavior:

Compile snippet:

@globalActor
public struct MyActor {
  private actor ActorImpl { }

  public static let shared: some Actor = ActorImpl()
}

@MyActor
final class MyClass {
  private var state = 0
}

extension MyClass {
  nonisolated func mutate() {
    Task { @MyActor in
      defer {
        self.state = 1 // False error: Global actor 'MyActor'-isolated property 'state' can not be mutated from global actor 'MyActor'
      }
      self.state = 2 // OK
    }
  }
}

...
Expected behavior
Code is compiled without errors
Environment (please fill out the following information)

OS: MacOS 12.6
Xcode 14.0

I think this is fixed on main by https://github.com/apple/swift/pull/60688 - can you verify using the latest development snapshot from swift.org?

Verified on version Swift Development Snapshot 2022-09-24 (a) and the issue is fixed. Thanks a lot!


fix do not push rf through cteAnchor

Proposed changes
Or_expansion rule create a CTEAnchor inside plan tree, and there are some columns above anchor sharing the same ExprId with columns under anchor. This mislead runtime pushdown visitor.
Solution:
when detect anchor inside plan tree, do not push rf through it.
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

Using an alternative approach to fix it.


Implement ability to evolve a Pokemon

Should just transform a Pokemon into a different specified Pokemon. Should retain the same IVs, nickname, moves etc

A followup to this would be making hooks for the resultant actions such as adding it to the Pokedex and checking any newly available moves.


Unnecessary semi-colons in Kotlin snippets

Feel free to close if you think it's unnecessary or it's on purpose, but I found two redundant commas in Kotlin snippets in the TUTORIAL.md file.
The location of the commas are here and here.
:)

Good spot! Those symbols are actually called semi-colons, but you're right that they are typically omitted (unless necessary) in idiomatic Kotlin code. If you're up for it, we'd welcome a pull request that removes them both. If not, we're also happy to take care of it :)

Before I filled the issue, I made a commit with the fix, but I don't have access rights to push to your repo. Am I doing something wrong?

Nope, that's expected! The usual workflow in this case is as follows:

create your own fork of this repository;
define a new remote in your local git repository that points to your new fork;
push your updated branch to your own fork;
open a pull request from your fork into this repository.

Let me know if you run into trouble with any of these steps :)
A tip for the future is that if you're making a small edit such as the one we're discussing here, you can do so using GitHub's web editor, and when you commit it will automatically create that fork for you! That saves you from going through a bunch of the steps listed above!

Closed by #90.


Add script/utility to assert things on the database

After the load test has run we want to see make sure everything worked as expected.
To help with this we can create a script that checks the database for the status of various channels. This can be used to make some rough assertions that the wallet behaviour is correct.

We would like to check that the database (and maybe blockchain?) to make sure things happened as expected.
Database:
Things we can check

The correct number of channels were created
The correct number of channels were closed
All objectives are completed

Blockchain
We could create a utility that writes out the current state of the blockchain:

Transaction sent to the adjudicator
The final balance of relevant addresses

This utility could be triggered whenever the ganache script stops.


Merge conflict merging dev into feature/lex-buttons-manage-allocations

mrbelvedere tried to merge new commits to dev but hit a merge conflict.  Please resolve manually

I merged the code from this branch into my njjc-lightning branch.


ARROW-1748: [GLib] Add GArrowRecordBatchBuilder

I don't know why C++ and Python tests are failed on Linux and macOS.
Is #1268 related?

@kou Not sure about c++ but #1268 fixes python tests.

@cpcloud Thanks. I'll rebase on master and confirm Travis CI result after #1268 is merged.

I rebased and confirmed all tests on Travis CI are green.


[SPARK-28792][SQL][DOC] Document CREATE DATABASE statement in SQL Reference.

What changes were proposed in this pull request?
Document CREATE DATABASE statement in SQL Reference Guide.
Why are the changes needed?
Currently Spark lacks documentation on the supported SQL constructs causing
confusion among users who sometimes have to look at the code to understand the
usage. This is aimed at addressing this issue.
Does this PR introduce any user-facing change?
Yes.
Before:
There was no documentation for this.
After:

How was this patch tested?
Manual Review and Tested using jykyll build --serve

@dilipbiswal , @gatorsmile , Please review. Thanks

@sharangk  Thanks for working on it. Can we please re-word some descriptions ? It sounds similar to some other docs.

Thanks for the timely review. I will work the comments and resubmit the PR.

Handled the comments. Thanks @dilipbiswal @huaxingao for timely review.
@gatorsmile , Could you please have a look at the changes.

@sharangk Mostly looks good. I have put some minor comments.

@dilipbiswal , Thanks for the review. Resubmitted the PR with updates. Please have a look. Thanks !!!

Can one of the admins verify this patch?

@dilipbiswal , Thanks. Handled the review comments.

LGTM
cc @gatorsmile

ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15960/
Test PASSed.

Test build #110828 has started for PR 25595 at commit 0225553.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15961/
Test PASSed.

Test build #110828 has finished for PR 25595 at commit 0225553.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/110828/
Test PASSed.

Thanks! Merged to master.


[v2.2.0] Cannot reset website statistics

Describe the Bug
Settings -> Websites -> [id] -> Data -> Reset
"Reset statistics" modal appears, with disabled "reset" button. Into Confirm input provide "DELETE" text, but nothing happens, button still remain disabled.

Database
PostgreSQL
Relevant log output
No response
Which browser are you using? (if relevant)
Chrome
How are you deploying your application? (if relevant)
Docker

RESET is valid confirmation.

Chinese translation also has this issue.

I think most if not all (excluding US) have this problem.  I did a PR for the ones I knew how to correct (GB is US copy).

Confirming that it affects German as well.

We will have to replace with the default message for all languages that are incorrect, until we get some proper translations. The English default message provides better direction then "Reset Statistics".

fixed in v.2.3.0. will probably need help again with translations.


Icons remaining after uninstall plug-in

Hello, yesterday the plug-in now worked with my Deboot 605, I used it for months without any problem.
Tried to remove the plug-in and reinstall but in HomeKit compare the oldest icons and the new one. How can clean up 100% of plug-in data to show HK without any icons?
Thanks
Stefano

Hi,
plugin is using cahed accessories. so, in homebridge, you have to clean the cache (you can do this easily using configUI-X)


Error in run_epoch

Hi,
First, I would like to great you for this awesome work. It is very well coded!
Now I think there is an error at this line: https://github.com/jpuigcerver/PyLaia/blob/7ee6b8c9371b5d8edd19f720a9dc8b3aabb1a704/laia/engine/engine.py#L225
There should be an "else" and the two next lines should be unindented: if not, we go in a dead loop in my mind.
Thank you for your answer.

Hi, thanks!
I don't see the problem. This is a for..else loop meaning that the code inside the else block gets executed only when the loop has finished and a break statement has not been executed.
The purpose of this is that the number of epochs increases only when all iterations have been completed. Some experiments have too much data and can't be run for a full epoch.
Does this solve your issue?

Hi, thank you for your quick answer!
I see your point and indeed I changed a bit your code to test some other things and it came up with a dead loop.
Sorry for the disturbance.
Great job again !


Bug report

Hey So the bot is working fine but the auto meme is not working its not posting memes to please fix that
Thank you

All works fine in default and mongo versions. Check in config.json, did you provide memer api?

All works fine in default and mongo versions. Check in config.json, did you provide memer api?

yep i have provided the memer api

All works fine in default and mongo versions. Check in config.json, did you provide memer api?

and btw i am using 10.3.0 version

I can't help bc for me all works

I can't help bc for me all works
okay np

I can't help bc for me all works

sir can you dm me your files on discord? but please remove the senstivie information token etc
my discord - ADAMIC GAMING ❤#8436


Corrected name of complete graph generator

The function simple_complete_graph was incorrectly listed as static_complete_graph.

Codecov Report

Merging #246 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #246   +/-   ##
=======================================
  Coverage   84.31%   84.31%
=======================================
  Files          24       24
  Lines        1466     1466
=======================================
  Hits         1236     1236
  Misses        230      230

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 784d126...59a1e58. Read the comment docs.


Add CircleCI and Danger

Description
Add CircleCI and Danger
Issues Resolved
Contribution Checklist

[ ] All tests pass.
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable

          1 Error

:no_entry_sign:
Please add labels to this Pull Request

  Generated by :no_entry_sign: Danger


Illegal Instruction.

face_recognition version: 0.1.9
Python version: 2.7
Operating System: Linux Mint

Description
Hey, first of all Thank you so much for this library. Its Amazing.
When i run the script line by line, i get an error "Illegal Instruction" at the following line
"my_face_encoding = face_recognition.face_encodings(picture_of_me)[0]"
The python terminal exits after this. Please let me know if i am doing something wrong.
What I Did
I am using Linux Mint and i pip installed face_recognition (got all libraries including dlib installed)

The issue is most likely that dlib was compiled with support for AVX and/or SSE4 instructions, but your cpu is too old to support them (pre-2011, I think).
The easiest solution is to download dlib and compile it yourself. But when you do that, you need to make one change.
Before compiling dlib, edit dlib's tools/python/CMakeLists.txt file from:
set(USE_SSE4_INSTRUCTIONS ON CACHE BOOL "Use SSE4 instructions")

to:
set(USE_SSE2_INSTRUCTIONS ON CACHE BOOL "Use SSE2 instructions")

And then compile and install dlib and the dlib python extensions. Hopefully that should fix it.

Correct. My Laptop is from 2008. The solution you suggested has fixed my issue. The script is able to recognize faces. Thank you.

face_recognition version:0.1.0
Python version:2.7.6
Operating System:ubantu 14.04
I encountered the same problem，When i run the code,
I get an error "Illegal Instruction" at the following line
gnss523@gnss523:~/Desktop/face_recognition-master/examples$ python find_faces_in_picture.py
Illegal instruction (core dumped)

Did you follow the instructions above?

I try this method

i have got this error ...how to solve it??
` >>>import face_recognition
Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python2.7/dist-packages/face_recognition/init.py", line 7, in
from .api import load_image_file, face_locations, face_landmarks, face_encodings, compare_faces
File "/usr/local/lib/python2.7/dist-packages/face_recognition/api.py", line 21, in
face_encoder = dlib.face_recognition_model_v1(face_recognition_model)
AttributeError: 'module' object has no attribute 'face_recognition_model_v1`

AttributeError: 'module' object has no attribute 'face_recognition_model_v1 means that the version of dlib you are using is too old. You need to use dlib 19.4 or newer.

Hi ageitgeym
Thanks for putting this togheter.
I've got error Process finished with exit code 132 (interrupted by signal 4: SIGILL)
when I run the examples, I also cheked if my processor was SSE4 capable (Intel® Xeon® Processor W3680) so before downloading dlib and compiling I wanted to know if there's something else I should do.
thanks for reading and your vmmachine

@Forsskieken The Intel Xeon W3680 (released 2010) doesn't support AVX instructions (released 2011). So that's why it's failing. Sorry! Your only option is to compile dlib without AVX enabled.

Hi There the compilation suceeded but when I want to instaal it I get following error:
deeplearning@deep-learning-virtual-machine:~/Downloads/dlib-19.4$ python setup.py install
Traceback (most recent call last):
  File "setup.py", line 36, in <module>
    from setuptools.command.bdist_egg import bdist_egg as _bdist_egg
ImportError: No module named setuptools.command.bdist_egg

python3-setuptools is already the newest version (20.7.0-1).
What am I missing
Kind Regards

@Forsskieken The problem was python setup.py runs Python 2, which is totally separate and doesn't have access to any libraries you installed for Python 3. So running python3 setup.py instead is the key.
You can choose when version of Python you are using in Pycharm by going to your project settings and changing the interpreter it's using. Just make sure you choose Python 3 for any new projects you create.

I am getting error like this..
import face_recognition
File "C:\Python27\lib\site-packages\face_recognition_init_.py", line 7, in
from .api import load_image_file, face_locations, face_landmarks, face_encodings, compare_faces, face_distance
File "C:\Python27\lib\site-packages\face_recognition\api.py", line 22, in
face_encoder =dlib.face_recognition_model_v1(face_recognition_model)
AttributeError: 'module' object has no attribute 'face_recognition_model_v1'

@PreethiRe Please don't post on closed issues with new unrelated problems. In any case, the answer to your question is here in the README. You need to upgrade to a newer version of dlib.

I got it.. Thank you
On 7 August 2017 at 11:58, Adam Geitgey<EMAIL_ADDRESS>wrote:

@PreethiRe https://github.com/preethire Please don't post on closed
issues with new unrelated problems. In any case, the answer to your
question is here
https://github.com/ageitgey/face_recognition#common-issues in the
README. You need to upgrade to a newer version of dlib.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ageitgey/face_recognition/issues/11#issuecomment-320750728,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdM_64JC_7r8Jpt8d4t261iGhxmwdgjYks5sV15ngaJpZM4MgsJP
.

how to fix this..?
face_distances = face_recognition.face_distance(known_encodings, image_to_test_encoding)
AttributeError: module 'face_recognition' has no attribute 'face_distance'

@PreethiRe Again, please don't post on closed issues with new unrelated problems. But I'm guessing you accidentally called your own file "face_recognition.py". You can't name your own file that or Python will find that file instead of the library you are trying to import.

Hi, I have been getting this error and I'm unable to understand why this keeps on happening.
Any help would be appreciated !
import face_recognition_models
image = face_recognition_models.load_image_file("abc.jpg")
face_locations = face_recognition_models.face_locations(image)
face_locations is now an array listing the co-ordinates of each face!
Traceback (most recent call last):
File "", line 3, in
image = face_recognition_models.load_image_file("abc.jpg")
AttributeError: module 'face_recognition_models' has no attribute 'load_image_file'

Hi, I am new to PyCharm. I needed a library face_recognition for my project so I installed it using pip install face_recognition. Now i am able to import it in ipython but not in PyCharm. I get

ImportError: No module named 'face_recognition'

Thanks for your help.

The issue is most likely that dlib was compiled with support for AVX and/or SSE4 instructions, but your cpu is too old to support them (pre-2011, I think).
The easiest solution is to download dlib and compile it yourself. But when you do that, you need to make one change.
Before compiling dlib, edit dlib's tools/python/CMakeLists.txt file from:
set(USE_SSE4_INSTRUCTIONS ON CACHE BOOL "Use SSE4 instructions")

to:
set(USE_SSE2_INSTRUCTIONS ON CACHE BOOL "Use SSE2 instructions")

And then compile and install dlib and the dlib python extensions. Hopefully that should fix it.

Hello, I didn't find this line in the specified location and also my macbook(macbook pro 2010 mid) supports SSE4 but doesn't support AVX. How do I build dlib taking into consideration this issue. I tried reinstalling dlib a lot of times but each time I get Illegal Instruction: 4.

The issue is most likely that dlib was compiled with support for AVX and/or SSE4 instructions, but your cpu is too old to support them (pre-2011, I think).
The easiest solution is to download dlib and compile it yourself. But when you do that, you need to make one change.
Before compiling dlib, edit dlib's tools/python/CMakeLists.txt file from:
set(USE_SSE4_INSTRUCTIONS ON CACHE BOOL "Use SSE4 instructions")

to:
set(USE_SSE2_INSTRUCTIONS ON CACHE BOOL "Use SSE2 instructions")

And then compile and install dlib and the dlib python extensions. Hopefully that should fix it.

Hello, I didn't find this line in the specified location and also my macbook(macbook pro 2010 mid) supports SSE4 but doesn't support AVX. How do I build dlib taking into consideration this issue. I tried reinstalling dlib a lot of times but each time I get Illegal Instruction: 4.

I  find this line in  " ./dlib/dlib/cmake_utils/set_compiler_specific_options.cmake" ，so  change and recomplie , it  work!

The issue is most likely that dlib was compiled with support for AVX and/or SSE4 instructions, but your cpu is too old to support them (pre-2011, I think).
The easiest solution is to download dlib and compile it yourself. But when you do that, you need to make one change.
Before compiling dlib, edit dlib's tools/python/CMakeLists.txt file from:
set(USE_SSE4_INSTRUCTIONS ON CACHE BOOL "Use SSE4 instructions")

to:
set(USE_SSE2_INSTRUCTIONS ON CACHE BOOL "Use SSE2 instructions")

And then compile and install dlib and the dlib python extensions. Hopefully that should fix it.

Hello, I didn't find this line in the specified location and also my macbook(macbook pro 2010 mid) supports SSE4 but doesn't support AVX. How do I build dlib taking into consideration this issue. I tried reinstalling dlib a lot of times but each time I get Illegal Instruction: 4.

I find this line in " ./dlib/dlib/cmake_utils/set_compiler_specific_options.cmake" ，so change and recomplie , it work!

works

Buenos dias , la libreria face_recognition , confunde personas  al identifcar , lo llame falso positivo , para cuando van a resolver este problema . Estoy haciendo un sistema de reconocimiento facial y me gustaria saber para cuando tienen la solucion.

Buenos dias , la libreria face_recognition , confunde personas al identifcar , lo llame falso positivo , para cuando van a resolver este problema . Estoy haciendo un sistema de reconocimiento facial y me gustaria saber para cuando tienen la solucion.

Hi!, could you give more details? It always happens? when it happens it's only for a moment or for a long time? is it just one face or many?
Hola!, puedes dar mas detalles? Pasa siempre? cuando pasa es solo por un momento u ocurre por largo rato?, pasa solo con una cara o con muchas?

El falso positivo sucede todos los dias , pasan 10 personas y confunde
3 personas ...

Buen dia , como se haria para calcular 83 puntos de la cara , la
libreria calcula 68 puntos , 7 objetos faciales y crea un vector de
128 puntos .
El 18/2/20, cirilo linares<EMAIL_ADDRESS>escribió:

El falso positivo sucede todos los dias , pasan 10 personas y confunde
3 personas ...

I have the issue in MacOS 12.0.1 (M1 chip). Error:
zsh: illegal hardware instruction
installation:
using python 3.7
conda install -c conda-forge dlib
pip install face_recognition


pkgsStatic.lz4: fix build

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Same as #191915. Dropped the conditional applying of the patch. This way we notice faster when it doesn't apply anymore and it doesn't break the shared library build.


[vue-test-utils]: Using a string for stubs is deprecated and will be removed in the next major version.

Up until now I am using a simple stub like the following.
but this morning I noticed that this is not working anymore with the current version.
import { config, RouterLinkStub } from "@vue/test-utils"
config.stubs["welcomeIcon"] = "

"

Hi! You might want to provide a valid component syntax:
config.stubs["welcomeIcon"] = { template: "

 "}

@afontcu Thanks, any suggestions on how to not use these ugly empty stub if I don't want to test the template part?

Glad that helped!
Not sure what you mean by "if I don't want to test the template part". I'm assuming your WelcomeIcon component is somewhat large, slow or has some side effects, and that's the reason to stub it out?

the welcomeIcon is actually an svg file. Apparently with vue svg loader I need to use it like the way I use my components.

Then I'd say setting a stub the way you did is a proper solution for your use case 😄  You could decide to simply load WelcomeIcon and ignore its content in the test, but a stub is a valid solution, too.
I'll go ahead and close this up!


Light Mode Support

Will there be a Light mode support?
P.S. I'm a no monster, I just like using Light mode.

I'm not really interesting in working on it currently, so not in the near future.
There would have to be some maintenance work (somewhat related to #68) done beforehand to make things work smoothly as well.


round-off error

>Note the round-off errors associated with the double type.
What round-off error?
I don't see any.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 227f6a03-7076-a47a-24de-a2c3c31a90b5
Version Independent ID: 8538cb70-a092-1166-1cd9-b77f5e6a80d4
Content: % Operator (C# Reference)
Content Source: docs/csharp/language-reference/operators/remainder-operator.md
Product: dotnet-csharp
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

You're right, @johnnyagerard. There is no "error" associated with the double type. It would be useful, though, to add an instance of "error" caused by double imprecision to the example. For example,         Console.WriteLine(.41 % .2); produces a result of 0.00999999999999995 instead of the expected .01. Would you like to open a PR to make the change, or would you like us to?

@rpetrusha I opened PR #7208.


no-cache option to build concrete image

When I use make init-docker-no-cache, I often rebuild each concrete images(dev, release) without cache.
Please tell me your opinions.

👍


logs - can't ctrl+c copy text from logs

logs - can't copy text from them with ctrl+c

Dupe of #324


Add center option for scrollToAlignment

Adds "center" option to scrollToAlignment for being able to scroll to a cell and display it centered on the container.
This is specially useful when scrolling horizontally and want to show a given cell in the middle of the screen (in our use case is the today column in a gantt chart)

Nice update! Thanks for the PR. Left some small comments.
Docs will also need to be updated (but I can do that if you'd prefer to just focus on the code.)

Thanks @bvaughn. I'll take care of the docs too :wink:

📯 👍

Thanks for putting together this PR :)

Version 7.1.2 just released with this feature.

Thank you so much @bvaughn for being so fast :rocket:!
The work you're doing with react-virtualized is totally awesome.


[AbemaTV] post network stack overhaul

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[ ] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

Except the code from #2861
What is the purpose of your pull request?

[x] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Description of your pull request and other information
DO NOT MERGE BEFORE #2861
This applies needed fix after #2861 for AbemaTV extractors.

Closing as OP inactive and this branch is very outdated (it is based on an early version of the networking rework).
If someone wants to pick this up I recommend creating a new branch from master and going from there.


script may need refactoring to use connection string postgres://user@pw:host:port instead of psql

Sure, feel free to make a PR for that

@romain-fontugne I'll do this after I get a better grasp of the prod env :pray:

thanks!


feat(post): now posts are able to determine if all children are read or not

this PR resolves #53

:tada: This PR is included in version 1.0.0-dev.3 :tada:
The release is available on:

v1.0.0-dev.3
GitHub release
v1.0.0-dev.3

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

v1.0.0
GitHub release
v1.0.0

Your semantic-release bot :package::rocket:


Graceful handling of cpp extensions

This fixes issues from https://github.com/pytorch/ao/issues/288
More specifically

We introduce a new env variable so we can install ao locally without building cpp extensions USE_CPP=0 pip install . this is useful out of convenience for faster iteration cycles
If the extensions were built but failed for whatever reason on a host device then importing those extensions will be skipped and ao will not crash. This also means you can import torchao from inside torchao/
If cpp extensions aren't build then the fp6 and ops tests are skipped

Failure in CI seems unrelated so review would still be helpful


Extends groupby on dataframe to recognize some scalar index types

[x] Closes #674
[x] Tests added: Please use assert_type() to assert the type of any return value

Initially I had also added the Series version of each Index to the type unions and added a separate new test for those, however it seems a little less useful, since you would have to use the series from the dataframe, which does not have a specific type, so you would need to manually cast to a more specific type to get the benefit there.
It certainly can be done, but it felt so awkward writing the test that I decided against it for now. It's also not a pattern I personally have ever used before on a groupby. This also decreases the surface area of the patch, so it should be a less controversial change overall.


Enable recurrent jobs

Recurrent archival of channels is a feature requested often (aka "recurrent jobs"). To achieve this, we must first be able to send jobs to the scribe at set intervals.
The lowest frequency for archiving channels is daily, thus we should check for outstanding jobs on a daily basis.
To enable this feature we need:

create a new recurrent_jobs table (see data model in https://dbdiagram.io/d/The-Arqivist-—-data-model-6551f3787d8bbd6465102527)
create a row in recurrent_jobs when a user selects any frequency besides once in the setup modal
use https://github.com/jarohen/chime to check the recurrent_jobs table for jobs due "today", then send them to the scribe on a loop (pmap?)

This ticket is growing more and more as I do it. I won't be able to make a small PR at this point.
Things I discovered, which must be added to enable recurrent jobs:

once jobs also need to be persisted in the database, because if someone archives a channel once and then tries to archive it again (whatever the frequency), we need to know where to continue archiving from
it is possible a user had archived a channel once but now wants to archive it with a recurrent job
the app should check if a job already exists as early as possible when the user issues a /arqive command
the app must give proper feedback either via modals (when part of the conversation with the user), or via ephemeral messages with a root-trace id

once jobs are always interesting. Presently, we want to create a parent page titled <channel-name> containing Confluence's children display macro; children pages are titled <earliest conversation timestamp — latest conversation timestamp>.


Massive blocks of text – can this stream out smaller/consistent chunks?

This works really well for transcribing standalone sentences. However, if you read from a book, for example, and don't leave a substantial amount of silent space after finishing a sentence, it won't process the results of what you say until after you finish speaking and will then print a massive block of text.
Is there something that can be done to push whisper to output smaller blocks of text, or to slice the audio going into the transcriber, in order to encourage it to stream out smaller chunks of text (at least at approximately the sentence level, since word-level might be asking too much)? I notice the GPU idling until I finish talking, so I don't think it's doing most of the transcription work until that point, and I'd like to better utilize my GPU as I speak.

I think it would make sense to start processing after 30 seconds, as that is what is going on behind the scenes(30 seconds at a time).
This is not currently supported, but I hope that maybe one day it will be.  Looking to have others help with this.

This is now supported


Unable to install jimp library through npm bcz of vulnerabilities checks

phin  <3.7.1 Severity: moderate phin may include sensitive headers in subsequent requests after redirect - https://github.com/advisories/GHSA-x565-32qp-m3vf fix available via npm audit fix --forceWill install<EMAIL_ADDRESS>which is a breaking change node_modules/phin load-bmfont  >=1.4.0 Depends on vulnerable versions of phin node_modules/load-bmfont @jimp/plugin-print  >=0.4.0 Depends on vulnerable versions of load-bmfont node_modules/@jimp/plugin-print @jimp/plugins  >=0.4.0 Depends on vulnerable versions of @jimp/plugin-print node_modules/@jimp/plugins jimp  >=0.4.0 Depends on vulnerable versions of @jimp/plugins node_modules/jimp
5 moderate severity vulnerabilities

tried updated node version to latest which didn't help
tried installing jimp lower version which didn't help
Tried npm audit fix --force which didn't help

Related #1291

@hipstersmoothie fix this

library no longer uses phin in v1


Task :app:javaPreCompileAnalyticsDebug FAILED

Steps and expected results, set java home to 11
setup your app flavour
refresh and rebuild
....project should build.
but i et these  errors once i run ./gradlew build

any help will be appreciated

ok so try these
clean the project, invalidate cache and restart
rebuild the app.
this error should go away


refactors gulp using rollup

Refactors Gulp, issue # 67
I have done this work using both Webpack and Rollup, and Rollup is by far the easier solution both in terms of setup and extensibility IMO. Also, Rollup is created specifically for the purpose of building flat libraries, whereas Webpack has many bells and whistles that make it quite complex to set up but great for web apps.

Refactors build tooling using Rollup (went from a 192-line gulpfile.js to a 61-line rollup.config.js
Modifies npm pretest hook
Adds mocha and eslint (non-Gulp versions)
Removes Gulp and other dev dependencies (composer, del, uglify-es)
Regenerated package-lock.json
Adds babel transpiling during builds (see this comment from PR # 70

Merged earlier PRs, but want to test the new build pipeline on updated test branch. Will test and review tomorrow thanks again @UncleGedd

Just rebased from master pulling in the cypress journey changes and resolved the resulting conflicts


npm run build fails

Any idea how to fix this?
> Using svelte-adapter-deno
✘ [ERROR] Could not resolve "./deps.ts"

    .svelte-kit/deno/index.js:1:56:
      1 │ import { dirname, fromFileUrl, join, Application } from './deps.ts';
        ╵                                                         ~~~~~~~~~~~

✘ [ERROR] Could not resolve "better-sqlite3"

    .svelte-kit/output/server/entries/endpoints/api/players.js:2:7:
      2 │ import "better-sqlite3";
        ╵        ~~~~~~~~~~~~~~~~

  The "main" field here was ignored. Main fields must be configured explicitly when using the
  "neutral" platform.

    node_modules/better-sqlite3/package.json:11:2:
      11 │   "main": "lib/index.js",
         ╵   ~~~~~~

  You can mark the path "better-sqlite3" as external to exclude it from the bundle, which will
  remove this error.

✘ [ERROR] Could not resolve "better-sqlite3"

    .svelte-kit/output/server/chunks/db-2acc2369.js:1:21:
      1 │ import Database from "better-sqlite3";
        ╵                      ~~~~~~~~~~~~~~~~

  The "main" field here was ignored. Main fields must be configured explicitly when using the
  "neutral" platform.

    node_modules/better-sqlite3/package.json:11:2:
      11 │   "main": "lib/index.js",
         ╵   ~~~~~~

  You can mark the path "better-sqlite3" as external to exclude it from the bundle, which will
  remove this error.

✘ [ERROR] Could not resolve "better-sqlite3"

    .svelte-kit/output/server/entries/endpoints/players.js:2:7:
      2 │ import "better-sqlite3";
        ╵        ~~~~~~~~~~~~~~~~

  The "main" field here was ignored. Main fields must be configured explicitly when using the
  "neutral" platform.

    node_modules/better-sqlite3/package.json:11:2:
      11 │   "main": "lib/index.js",
         ╵   ~~~~~~

  You can mark the path "better-sqlite3" as external to exclude it from the bundle, which will
  remove this error.

✘ [ERROR] Could not resolve "better-sqlite3"

    .svelte-kit/output/server/entries/endpoints/index.js:2:7:
      2 │ import "better-sqlite3";
        ╵        ~~~~~~~~~~~~~~~~

  The "main" field here was ignored. Main fields must be configured explicitly when using the
  "neutral" platform.

    node_modules/better-sqlite3/package.json:11:2:
      11 │   "main": "lib/index.js",
         ╵   ~~~~~~

  You can mark the path "better-sqlite3" as external to exclude it from the bundle, which will
  remove this error.

✘ [ERROR] Could not resolve "better-sqlite3"

    .svelte-kit/output/server/entries/endpoints/games.js:2:7:
      2 │ import "better-sqlite3";
        ╵        ~~~~~~~~~~~~~~~~

  The "main" field here was ignored. Main fields must be configured explicitly when using the
  "neutral" platform.

    node_modules/better-sqlite3/package.json:11:2:
      11 │   "main": "lib/index.js",
         ╵   ~~~~~~

  You can mark the path "better-sqlite3" as external to exclude it from the bundle, which will
  remove this error.

> Build failed with 6 errors:
.svelte-kit/deno/index.js:1:56: ERROR: Could not resolve "./deps.ts"
.svelte-kit/output/server/chunks/db-2acc2369.js:1:21: ERROR: Could not resolve "better-sqlite3"
.svelte-kit/output/server/entries/endpoints/api/players.js:2:7: ERROR: Could not resolve "better-sqlite3"
.svelte-kit/output/server/entries/endpoints/games.js:2:7: ERROR: Could not resolve "better-sqlite3"
.svelte-kit/output/server/entries/endpoints/index.js:2:7: ERROR: Could not resolve "better-sqlite3"
...
.svelte-kit/deno/index.js:1:56: ERROR: Could not resolve "./deps.ts"
.svelte-kit/output/server/chunks/db-2acc2369.js:1:21: ERROR: Could not resolve "better-sqlite3"
.svelte-kit/output/server/entries/endpoints/api/players.js:2:7: ERROR: Could not resolve "better-sqlite3"
.svelte-kit/output/server/entries/endpoints/games.js:2:7: ERROR: Could not resolve "better-sqlite3"
.svelte-kit/output/server/entries/endpoints/index.js:2:7: ERROR: Could not resolve "better-sqlite3"
...
    at failureErrorWithLog (/home/..../app/node_modules/esbuild/lib/main.js:1603:15)
    at /home/..../app/node_modules/esbuild/lib/main.js:1249:28
    at runOnEndCallbacks (/home/..../app/node_modules/esbuild/lib/main.js:1162:65)
    at buildResponseToResult (/home/..../app/node_modules/esbuild/lib/main.js:1247:7)
    at /home/..../app/node_modules/esbuild/lib/main.js:1356:14
    at /home/..../app/node_modules/esbuild/lib/main.js:666:9
    at handleIncomingPacket (/home/..../app/node_modules/esbuild/lib/main.js:763:9)
    at Socket.readFromStdout (/home/..../app/node_modules/esbuild/lib/main.js:632:7)
    at Socket.emit (events.js:400:28)
    at addChunk (internal/streams/readable.js:293:12)

Hm, it seems like bundling is failing due to including a Node dependency, do you have a Deno compatible alternative for the better-sqlite3 package you're using?

Ah right, it didn't occur to me that I'd have to use a "deno compatible" library. I guess I naively thought I could use any node lib with deno...
Anyway, I found this after a search, so I'll try that later when I'm back on my pet project track.
Thanks :)

@fractalf exactly, this adapter (and a few of the others geared towards serverless environments) suffer a bit from SvelteKit not being tied to a specific platform, in practice if you need platform-specific code you may have a hard time...
In any case, which error were you getting when trying to integrate with the Deno version of sqlite? Were you using a custom deps.ts file to inject it?

@jpaquim the problem was that I cannot "install" the deno sqlite lib with npm and
import { DB } from "https://deno.land/x/sqlite/mod.ts";
obviously fails when trying to build the app with node


chore: Use better layout mechanism

Codecov Report

Merging #266 (c8bb397) into main (97b48d2) will decrease coverage by 0.53%.
The diff coverage is 3.57%.

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   56.05%   55.51%   -0.54%
==========================================
  Files         121      122       +1
  Lines        1256     1270      +14
  Branches      205      206       +1
==========================================
+ Hits          704      705       +1
- Misses        542      555      +13
  Partials       10       10

Impacted Files
Coverage Δ

src/components/app/ChangeLog/v0.1.0.tsx
0.00% <0.00%> (ø)

src/layouts/AppContainer.tsx
0.00% <0.00%> (ø)

src/layouts/Article.tsx
0.00% <0.00%> (ø)

src/layouts/Single.tsx
0.00% <0.00%> (ø)

src/pages/404.tsx
0.00% <0.00%> (ø)

src/pages/_app.tsx
0.00% <0.00%> (ø)

src/pages/_error.tsx
0.00% <0.00%> (ø)

src/pages/index.tsx
0.00% <0.00%> (ø)

src/pages/livers.tsx
0.00% <0.00%> (ø)

src/pages/livers/[id].tsx
0.00% <0.00%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b48d2...c8bb397. Read the comment docs.


AeroDyn w/ Cavitation

Updated the AeroDyn modules with a cavitation check, added input parameters, and included a verification for MHK turbines in the CertTest

@ghaymanNREL @robynnemurrayNREL , where are we with this pull request?  I believe Greg requested a number of changes?

Hi Mike,
Greg is going to give me a hand with cherry picking which files I request to be pulled!
Cheers!
Robynne Murray, PhD
On Apr 20, 2017, at 7:50 AM, Mike Sprague <notifications<EMAIL_ADDRESS>wrote:
@ghaymanNRELhttps://github.com/ghaymanNREL @robynnemurrayNRELhttps://github.com/robynnemurrayNREL , where are we with this pull request? I believe Greg requested a number of changes?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/OpenFAST/openfast/pull/15#issuecomment-295744653, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZDE4m2L5og2Z2AStor9fz9Perum1KDGks5rx2JIgaJpZM4NApFl.

I wasn't able to help yesterday but can today or tomorrow. I could also simply cherry pick from her repo outside of a pull request. I think we should just go that route if Robynne is busy
Sent from my iPhone
On Apr 20, 2017, at 7:49 AM, Mike Sprague <notifications<EMAIL_ADDRESS>wrote:
@ghaymanNRELhttps://github.com/ghaymanNREL @robynnemurrayNRELhttps://github.com/robynnemurrayNREL , where are we with this pull request? I believe Greg requested a number of changes?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/OpenFAST/openfast/pull/15#issuecomment-295744653, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGcCp2ZoojT3G8IKNr-fUhgHhtZMWBJqks5rx2JHgaJpZM4NApFl.

Hi Greg,
I will be in around 10, just on a Skype from home, but am open pretty much all day, and would love to learn how to do it if you don't mind :)
Robynne Murray, PhD
On Apr 20, 2017, at 8:02 AM, ghaymanNREL <notifications<EMAIL_ADDRESS>wrote:
I wasn't able to help yesterday but can today or tomorrow. I could also simply cherry pick from her repo outside of a pull request. I think we should just go that route if Robynne is busy
Sent from my iPhone
On Apr 20, 2017, at 7:49 AM, Mike Sprague <notifications@github.commailto:notifications<EMAIL_ADDRESS>wrote:
@ghaymanNRELhttps://github.com/ghaymanNREL @robynnemurrayNRELhttps://github.com/robynnemurrayNREL , where are we with this pull request? I believe Greg requested a number of changes?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/OpenFAST/openfast/pull/15#issuecomment-295744653, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGcCp2ZoojT3G8IKNr-fUhgHhtZMWBJqks5rx2JHgaJpZM4NApFl.

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/OpenFAST/openfast/pull/15#issuecomment-295748946, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZDE4sJ1eJUtMntqlCJEk0dZ53DWXrbdks5rx2V0gaJpZM4NApFl.

@robynnemurrayNREL, @ghaymanNREL Looking a the commit logs, the only thing I see that needs reverting is the addition of CertTests. The rest can be just squashed into one commit when merging the pull request. What's rationale for cherry picking through 41 commits.

duplicate.  closing


Repeated sentences

In this section:
https://docs.microsoft.com/en-us/sql/relational-databases/databases/tempdb-database?view=sql-server-ver15#memory-optimized-tempdb-metadata
The below sentences appear twice in the same paragraph:
SQL Server 2019 introduces a new feature that is part of the In-Memory Database feature family, memory-optimized tempdb metadata, which effectively removes this bottleneck and unlocks a new level of scalability for tempdb-heavy workloads. In SQL Server 2019, the system tables involved in managing temp table metadata can be moved into latch-free non-durable memory-optimized tables.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 37fab3b5-a2f3-5612-06e2-01e0406a615d
Version Independent ID: 2daa00e0-8234-bf26-13c0-8d5200a1f4a5
Content: tempdb Database - SQL Server
Content Source: docs/relational-databases/databases/tempdb-database.md
Product: sql
GitHub Login: @stevestein
Microsoft Alias: sstein

@selangley-wa -- Scott, thank you for your feedback.  I have updated the documentation and it should be live by tomorrow.


WARNING:botocore.vendored.requests.packages.urllib3.connectionpool:Connection pool is full, discarding connection

When using read_parquet with s3 I get hundreds of:

There are > 1000 parquet segments on s3. I haven't found a way to fix it yet other than sync.

There are a number of mentions of this kind of situation with botocore/boto3. The parameter in this PR was introduced to try to eliminate it, can you try to add it to the s3 client config?

I needed a huge connection pool to get rid of the message.
ddf.read_parquet('s3://my-bucket',
                           storage_options={'config_kwargs': {'max_pool_connections': 2500}})

How many threads are you running? If you don't know, it's commonly equal to the number of CPU cores, as seen by python.

36 cores. I only ever see Dask use 18 of them.

Hm. Are there very many partitions? I wonder if boto3 is not reaping connections until the Session is done (when compute finishes). The docs say that you should never have to care about reaping connections from the pool.

There are about 1500 partitions in this case.

@martindurant is there something concrete we can do here to resolve this problem?  If so can you help to explain what that might be?  If not then can you close?

I don't think we need to do anything, this is a boto problem specifically, although we are using it in a way they perhaps haven't anticipated.

Are Dask users today OK?  To be clear I'm not asking "is it our fault or
theirs" I'm asking if there are things that dask users will run into today
that we should resolve
On Wed, Oct 24, 2018 at 3:04 PM Martin Durant<EMAIL_ADDRESS>wrote:

I don't think we need to do anything, this is a boto problem specifically,
although we are using it in a way they perhaps haven't anticipated.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/3493#issuecomment-432788365, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszNl7oTFv1yVaw97sCJthEeIX4dvdks5uoLmggaJpZM4T8Q4S
.

It seems like a rare possibility, but I would not advocate trying to automatically set the boto session parameters for our users. This will happen only in the case where many threads (not processes) are doing simultaneous s3 work.


Deep Freeze Mock Messages

Deep Freeze Mock Messages

@jzaffiro and @Abe27342 I'm waiting for #20620 before i merge this, as i don't want to block that, but open to feedback before then


AsyncContext.Run and Task.ContinueWith

Would I expect all these items to run on a single thread - and NOT pull a thread from the pool? both Task1 and Task2 work as expected, however: Task3 seems to run off a threadpool thread, and further, the Task.WhenAll call seems to ignore task3.
Am I using ContinueWith incorrectly in this situation?
    class Program
    {
        static async Task Main(string[] args)
        {
            WriteThread("app started...");
            AsyncContext.Run(async () =>
            {
                WriteThread("AsyncContext started...");

                // not a AsyncContext.TaskScheduler?
                var s = System.Threading.Tasks.TaskScheduler.Current;

                var task1 = DoSomeWork("First");
                var task2 = DoSomeWork("Second");
                var task3 = task2.ContinueWith(async _ => await DoSomeWork("Third"));

                await Task.WhenAll(task1, task2, task3);

                WriteThread("AsyncContext done...");
            });

            WriteThread("App done...");
            Console.ReadKey(true);
        }

        static async Task DoSomeWork(string name)
        {
            for (var i = 0; i < 10; i++)
            {
                WriteThread($"In {nameof(DoSomeWork)} for {name.ToUpper()}");
                await Task.Delay(100);
            }
        }

        static void WriteThread(string message)
        {
            Console.WriteLine($"{message} on ThreadId: {System.Threading.Thread.CurrentThread.ManagedThreadId}");
        }
    }

You shouldn't be using ContinueWith. It's a dangerous, low-level method. Use await instead:
var task3 = DoThirdWork();
async Task DoThirdWork()
{
  await task2;
  await DoSomeWork("Third");
}

One problem is that ContinueWith does not have a good default TaskScheduler. You could pass AsyncContext.Current.Scheduler to ContinueWith to make it run on the correct scheduler. However, even if you do that, WhenAll still won't work as expected, because ContinueWith doesn't understand async delegates. So you'd need to call Unwrap on the task returned from ContinueWith before passing it to WhenAll.
Using ContinueWith isn't worth the pain; I recommend you use await instead.


unable to capture/except sts error since upgrading from 1.13.1

The following code snippet use to work for finding out whether STS was enabled within a specific AWS region, but since upgrading the botocore library this is failing, for some reason you are not able to capture the error, it just performs a stacktrace
def get_enabled_regions(boto3_session: boto3.Session, service: str):
    regions = boto3_session.get_available_regions(service)
    enabled_regions = set()
    for region in regions:
        try:
            sts_client = boto3_session.client('sts', region_name=region)
            sts_client.get_caller_identity()
            enabled_regions.add(region)
        except ClientError as e:
            if e.response['Error']['Code'] == "InvalidClientTokenId":
                # error code received when region is disabled
                log.error('{}: "{}" not allowed please check whether STS is enabled for this region'.format(
                    e.response['Error']['Code'], region))
                pass
            else:
                log.critical(e)
                #raise
        except Exception as e:
            log.critical(e)
    return enabled_regions

Error
[2019-10-29 22:14:20] [INFO] Credentials found in config file: ~/.aws/config
[2019-10-29 22:14:21] [WARNING] Refreshing temporary credentials failed during mandatory refresh period.
Traceback (most recent call last):
  File "/Users/pcanham/virtenvs/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 502, in _protected_refresh
    metadata = self._refresh_using()
  File "/Users/pcanham/virtenvs/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 643, in fetch_credentials
    return self._get_cached_credentials()
  File "/Users/pcanham/virtenvs/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 653, in _get_cached_credentials
    response = self._get_credentials()
  File "/Users/pcanham/virtenvs/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 786, in _get_credentials
    return client.assume_role(**kwargs)
  File "/Users/pcanham/virtenvs/venv02/lib/python3.7/site-packages/botocore/client.py", line 357, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/pcanham/virtenvs/venv02/lib/python3.7/site-packages/botocore/client.py", line 661, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (InvalidClientTokenId) when calling the AssumeRole operation: The security token included in the request is invalid.
[2019-10-29 22:14:21] [ERROR] InvalidClientTokenId: "ap-east-1" not allowed please check whether STS is enabled for this region

Additional information, the permissions i am getting is from an AssumeRole which works with the aws cli tool, using role_arn and source_profile within the credentials file

@pcanham - Thank you for your post. I am not able to reproduce the issue when i ran your code with latest version of botocore. Can you please make sure that you are able to run sts assume_role call without error before running the script ?
If you are getting error with assume_role call then you may have to set your credentials again for the environment.
If you are not getting error with sts assume_role but still you are not able to run your script then please provide me full stack trace. I need full stack trace in order to know what exactly happening as i am not able to reproduce the issue with your script.

Hi,
I have upgraded the library to 1.13.13 and get errors still here is the stacktrace
./region_list.py --profile press-hosting-strategy
[2019-11-08 12:13:11] [INFO] Credentials found in config file: ~/.aws/config
[2019-11-08 12:13:12] [WARNING] Refreshing temporary credentials failed during mandatory refresh period.
Traceback (most recent call last):
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 502, in _protected_refresh
    metadata = self._refresh_using()
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 643, in fetch_credentials
    return self._get_cached_credentials()
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 653, in _get_cached_credentials
    response = self._get_credentials()
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 786, in _get_credentials
    return client.assume_role(**kwargs)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/client.py", line 357, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/client.py", line 661, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (InvalidClientTokenId) when calling the AssumeRole operation: The security token included in the request is invalid.
[2019-11-08 12:13:12] [CRITICAL] An error occurred (InvalidClientTokenId) when calling the AssumeRole operation: The security token included in the request is invalid.
Traceback (most recent call last):
  File "./region_list.py", line 87, in <module>
    for region in get_enabled_regions(initial_session, 'ec2'):
  File "./region_list.py", line 48, in get_enabled_regions
    sts_client.get_caller_identity()
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/client.py", line 357, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/client.py", line 648, in _make_api_call
    operation_model, request_dict, request_context)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/client.py", line 667, in _make_request
    return self._endpoint.make_request(operation_model, request_dict)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/endpoint.py", line 102, in make_request
    return self._send_request(request_dict, operation_model)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/endpoint.py", line 132, in _send_request
    request = self.create_request(request_dict, operation_model)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/endpoint.py", line 116, in create_request
    operation_name=operation_model.name)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/hooks.py", line 356, in emit
    return self._emitter.emit(aliased_event_name, **kwargs)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/hooks.py", line 228, in emit
    return self._emit(event_name, kwargs)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/hooks.py", line 211, in _emit
    response = handler(**kwargs)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/signers.py", line 90, in handler
    return self.sign(operation_name, request)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/signers.py", line 149, in sign
    auth = self.get_auth_instance(**kwargs)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/signers.py", line 229, in get_auth_instance
    frozen_credentials = self._credentials.get_frozen_credentials()
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 591, in get_frozen_credentials
    self._refresh()
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 486, in _refresh
    self._protected_refresh(is_mandatory=is_mandatory_refresh)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 502, in _protected_refresh
    metadata = self._refresh_using()
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 643, in fetch_credentials
    return self._get_cached_credentials()
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 653, in _get_cached_credentials
    response = self._get_credentials()
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/credentials.py", line 786, in _get_credentials
    return client.assume_role(**kwargs)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/client.py", line 357, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/pcanham/venv02/lib/python3.7/site-packages/botocore/client.py", line 661, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (InvalidClientTokenId) when calling the AssumeRole operation: The security token included in the request is invalid.

I have tested the permissions via the aws cli and have no issues with the AssumeRole operation.
To ensure this was not a permissions issue i have also moved to a different role which would give me full admin access to the account (created via AWS Organisations) called "OrganizationAccountAccessRole"
format of the boto3 credentials file is
[profile primary]
aws_access_key_id = XXXXXXXXXXXXXXXXX
aws_secret_access_key = XXXXXXXXXXXX
region = eu-west-1

[profile XXXXXXX]
role_arn = arn:aws:iam::XXXXXXXXXXXX:role/OrganizationAccountAccessRole
source_profile = primary
region = eu-west-1

primary is the master account and 'XXXXXXX' is the account which i am trying to perform the STS checks against.
I havent had a chance to check the code, but from looking at the logging outputs for 1.13.1 and 1.13.13 there is a warning which is extra which i am wondering is invalidating something
[WARNING] Refreshing temporary credentials failed during mandatory refresh period.

Thought I would test with the latest version and it still fails.
Version : 1.13.40
botocore.exceptions.ClientError: An error occurred (InvalidClientTokenId) when calling the AssumeRole operation: The security token included in the request is invalid.
[2019-12-17 10:20:13] [ERROR] [__main__(36):get_enabled_regions] InvalidClientTokenId: "eu-central-1" not allowed please check whether STS is enabled for this region
^CTraceback (most recent call last):
  File "./eip_audit.py", line 176, in <module>
    for region in get_enabled_regions(initial_session, 'ec2'):
  File "./eip_audit.py", line 30, in get_enabled_regions
    sts_client.get_caller_identity()
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/client.py", line 272, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/client.py", line 563, in _make_api_call
    operation_model, request_dict, request_context)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/client.py", line 582, in _make_request
    return self._endpoint.make_request(operation_model, request_dict)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/endpoint.py", line 102, in make_request
    return self._send_request(request_dict, operation_model)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/endpoint.py", line 132, in _send_request
    request = self.create_request(request_dict, operation_model)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/endpoint.py", line 116, in create_request
    operation_name=operation_model.name)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/hooks.py", line 356, in emit
    return self._emitter.emit(aliased_event_name, **kwargs)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/hooks.py", line 228, in emit
    return self._emit(event_name, kwargs)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/hooks.py", line 211, in _emit
    response = handler(**kwargs)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/signers.py", line 90, in handler
    return self.sign(operation_name, request)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/signers.py", line 152, in sign
    auth = self.get_auth_instance(**kwargs)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/signers.py", line 232, in get_auth_instance
    frozen_credentials = self._credentials.get_frozen_credentials()
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/credentials.py", line 591, in get_frozen_credentials
    self._refresh()
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/credentials.py", line 486, in _refresh
    self._protected_refresh(is_mandatory=is_mandatory_refresh)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/credentials.py", line 502, in _protected_refresh
    metadata = self._refresh_using()
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/credentials.py", line 643, in fetch_credentials
    return self._get_cached_credentials()
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/credentials.py", line 653, in _get_cached_credentials
    response = self._get_credentials()
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/credentials.py", line 786, in _get_credentials
    return client.assume_role(**kwargs)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/client.py", line 272, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/client.py", line 563, in _make_api_call
    operation_model, request_dict, request_context)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/client.py", line 582, in _make_request
    return self._endpoint.make_request(operation_model, request_dict)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/endpoint.py", line 102, in make_request
    return self._send_request(request_dict, operation_model)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/endpoint.py", line 135, in _send_request
    request, operation_model, context)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/endpoint.py", line 167, in _get_response
    request, operation_model)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/endpoint.py", line 200, in _do_get_response
    http_response = self._send(request)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/endpoint.py", line 244, in _send
    return self.http_session.send(request)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/httpsession.py", line 263, in send
    chunked=self._chunked(request.headers),
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/urllib3/connectionpool.py", line 672, in urlopen
    chunked=chunked,
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/urllib3/connectionpool.py", line 376, in _make_request
    self._validate_conn(conn)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/urllib3/connectionpool.py", line 994, in _validate_conn
    conn.connect()
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/urllib3/connection.py", line 394, in connect
    ssl_context=context,
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/urllib3/util/ssl_.py", line 370, in ssl_wrap_socket
    return context.wrap_socket(sock, server_hostname=server_hostname)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/ssl.py", line 423, in wrap_socket
    session=session
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/ssl.py", line 870, in _create
    self.do_handshake()
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/ssl.py", line 1139, in do_handshake
    self._sslobj.do_handshake()
KeyboardInterrupt

Bit more information, found my script was not displaying the following error
[2019-12-17 11:08:48] [ERROR] [__main__(36):get_enabled_regions] InvalidClientTokenId: "ap-east-1" not allowed please check whether STS is enabled for this region
[2019-12-17 11:08:49] [WARNING] [botocore.credentials(507):_protected_refresh] Refreshing temporary credentials failed during mandatory refresh period.
Traceback (most recent call last):
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/credentials.py", line 502, in _protected_refresh
    metadata = self._refresh_using()
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/credentials.py", line 643, in fetch_credentials
    return self._get_cached_credentials()
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/credentials.py", line 653, in _get_cached_credentials
    response = self._get_credentials()
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/credentials.py", line 786, in _get_credentials
    return client.assume_role(**kwargs)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/client.py", line 272, in _api_call
    return self._make_api_call(operation_name, kwargs)
  File "/Users/pcanham/.asdf/installs/python/3.7.5/lib/python3.7/site-packages/botocore/client.py", line 576, in _make_api_call
    raise error_class(parsed_response, operation_name)
botocore.exceptions.ClientError: An error occurred (InvalidClientTokenId) when calling the AssumeRole operation: The security token included in the request is invalid.

@pcanham - Sorry for the late reply. It looks like the credentials being used to the make the initial assume role call are expired. Can you make any other API calls with the original credentials?


How to set up the default download tool? Replace npm with cnpm.

Hope to add an attribute, or tell me where I can change it. Thank you.

in windows  it works


Support data for Browser

Is your feature request related to a problem? Please describe.
I have a list of entries, associated with some data, that, while textual, can't be displayed to the user.
Describe the solution you'd like
FTLK Browser class supports "data" associated to each line; a few methods are associated (e.g. this).
From an API perspective, it's possible to extend fltk-rs APIs (at a minimum, by implementing the data getter/setter methods).
Describe alternatives you've considered
Creating a custom widget, but this is I think not trivial.
The functionality can be emulated by keeping a dictionary of the entries <> data, although this is definitely not a clean solution.
Additional context
(skipped)

Hi
I've added BrowserExt::add_with_data, insert_with_data, set_data and data methods.
I've marked BrowserExt::data() as unsafe.


docs: Expanded generator template docs, front matter docs

Expands the generator template docs (creates a whole new doc for that), adds front matter docs (enhancing #1630 by @kateinkim).

Ignore all the extra commits, those will be squashed out on merge.

Looks good! Thanks for documenting this!


Enables checking if localhost forwarding is disabled

That feature enables binding WSL 2 localhost to Windows localhost, thus enabling transparent connection through TCP where the client is running on the host while the server is running inside the WSL 2 distro, scenario expected by our OOBE. For security reasons, only localhost can connect to the server, thus this information is crucial.
That feature is enabled by default, but can be manually disabled by tweaking the ~\.wslconfig file, which is a per-user configuration file that affects all distros running in the scope of the referred Windows user.
So to be able to read that configuration value we need to:

Find the user's home path;
Parse the file (ini parsing has been previously implemented)
look for the value of the entry [wsl2.localhostForwarding].

This will be used later in an upper level to determine whether we can run the OOBE on Windows or not.
Check the WSL docs for further information.

Just rebased to avoid a merge conflict due #220 .


Publish the v5 beta to NPM?

Currently, the npm version is sitting at 4.2.7. I suggest releasing the beta version under a tag so that people who are starting a new project can use the latest beta right away.
The files generated by bitters v1.4 is incompatible with bourbon 4.x which is forcing me to install an older version of bitters.
I'm getting  Error: Undefined variable: "$font-stack-system". on the files generated by bitters v1.4.0 and 1.3.2. I'm stuck with bitters 1.2.

Try with
npm install<EMAIL_ADDRESS>

We do publish the beta to npm. You can use the command above; thanks @Juanelorganelo!

FWIW, you can also run npm install bourbon@beta to get the latest beta.


The contributing guide refers to the SDK, not docs

As the title really, CONTRIBUTING.md contains references to building and testing the SDK, whereas this repo is for the docs.
It would be helpful if this could be updated to refer to the docs and provide instruction on building the static site.

Hi @jimbobbennett , you can fork this repo and use GitHub Pages to deploy, then submit a pull request to contributing this docs.
Of course we will also replace CONTRIBUTING.md to a new one. Thanks.


Add interactive init command (#224)

As part of Stack Builders Inc. Hacktoberfest 2023 event.

Hi @blackheaven I'm going to merge your PR. FWIW, we (as Stack Builders) started a competition related to the Hacktoberfest 2023. You can find more information about it in our website. Once again. Thanks for your contribution!

@blackheaven Thanks for the contribution! Remember to add the following line in the PR's description so that the contribution can be considered valid for Stack Builders' Hacktoberfest 2023 event:

As part of Stack Builders Inc. Hacktoberfest 2023 event.

Thanks

@all-contributors please add @blackheaven for code


Fix for server-side rendering

See #57
:warning: Untested
I first need the updated youtube-player to be able to test this change because at the moment just importing youtube-player triggers an error server-side.
Doing so manually would be a pain (and potentially cause more issues) so I'll wait for @troybetz to update the package on npm...
EDIT: I messed up and had to recreate the pull request, sorry for that...

Managed to test the change by copying the YouTube.js file and adding its dependencies to an app made with https://github.com/koistya/react-static-boilerplate/
This changed combined with the latest version of youtube-player will make sure that react-youtube doesnt error out when trying to access document when rendering server side but will not prevent it from rendering correctly client side.

Sorry for holding you all up, Im without a computer at the moment so I can't push a new npm release. Do you have an NPM account? I can add you to the list of maintainers so you can release it
Sent from my iPhone

On Feb 7, 2016, at 7:04 AM, tjallingt<EMAIL_ADDRESS>wrote:
Managed to test the change by copying the YouTube.js file and adding its dependencies to an app made with https://github.com/koistya/react-static-boilerplate/
This changed combined with the latest version of youtube-player will make sure that react-youtube doesnt error out when trying to access document when rendering server side but will not prevent it from rendering correctly client side.
—
Reply to this email directly or view it on GitHub.

Hey @troybetz thats unfortunate...
Its no problem, I can wait but I do have an NPM account under the same username (tjallingt)


Use dapla team api in nais

Internal ref: DPSKY-878

Closeing as it seems tht there is work to move dapla ctrl to nais as well


Script to Recursivelty find the CURRENT node-ipc dependents

Hi
I wrote this to help you : https://github.com/bernardgut/find-node-dependents

Acknowledged, added to the readme, feel free to update here if anything else is needed


Include Git workflow documentation in DeveloperGuide

Changes Unknown when pulling 4681c0a1ffe5f5717a25825af9d367b774daad74 on docs-git-workflow into ** on master**.

Changes Unknown when pulling 4681c0a1ffe5f5717a25825af9d367b774daad74 on docs-git-workflow into ** on master**.

Changes Unknown when pulling 4743d159619631eab54734903c44f74ff98592be on docs-git-workflow into ** on master**.


Switch to datalog subscription

A subscription with the following events:

On tag
On push

with filters (all optional):

file filter
branch filter (regexp)
tag filter (regexp)

@kipz @slimslenderslacks do you guys have such a subscription available that I could use?

I'm not sure there's one available as such, but they can all be crafted. I'd like to make some nice named ones or we can start low-level?

You can craft a low-level one. I would hide it as much as we hide graphql for known subscriptions for now. I just want to get going on this :-)

One of the key questions is: what data do you need in order to do the whole operation without any ad-hoc queries? Is that something you can enumerate?  So far I've been pulling back repo details token, branch and commit-sha for these sorts of things .Will that do for now?

Yes, I think that's all I need. Oh, and of course and api key in the subscription.

Do you mean the JWT? Why do you need that out of interest? In any case, it's in the same place.

Another question I have is about whether or not you will need the branch and/or tag? It's just that with the file filter, those events can arrive after any branch or tag ref is created, and so it won't be possible to resolve to a particular tag or branch for that commit...

Yes, branch and/or tag name are needed.

So you're OK not getting a branch or tag when the triggering event is the fingerprint (i.e. file filter) being updated on a commit? What will you do in that instance?

We could search for and find any branch and/or tag associated with that commit?

Hmm, I was expecting to get called for tags and pushes. Not sure I care about the fingerprint at this point. Or should I?

That's my whole point here - when the fingerprint is added can be before, after or during the push or tag operations, so your file filter might not work at the point of push or tag. To work around this, you need to listen for those fingerprinting events too (I already do this in a skill).

Fingerprinting is done by the content-indexer skill (currently) on push.

So we can guess as to the tag or branch that you need for the commit that was just fingerprinted if you really need the branch/tag for all events.

More than likely it'll be the right one, and we can make sure it matches the branch/tag specs (if defined).

[:find
  (pull ?org [:github.org/installation-token
              :git.org/name
              :git.provider/url])

  (pull ?repo [:git.repo/source-id
               :git.repo/name
               :git.provider/url])
  (pull ?commit [:git.commit/sha])
  ?ref-name
  :in $ $before-db %
  :where
  (get-config-value "branch-filters" ["^.*$"] ?branch-filters)
  (get-config-value "tag-filters" ["^.*$"] ?tag-filters)
  ;; triggers
  (or-join [?commit ?branch-filters ?tag-filters ?ref-name]
    (tx-push-to-branch ?branch-filters ?commit ?ref-name)
    (tx-tag ?tag-filters ?commit ?ref-name)
    (and
      ;;take a guess at a branch/tag ref for this commit
      ;; but it must match the filters, if defined
      (tx-content-index ?commit)
      [?ref :git.ref/commit ?commit]
      [?ref :git.ref/name ?ref-name]
      (get-config-value "file-paths" ["Dockerfile"] ?file-paths)
      (or-join [?commit ?file-paths]
        [(empty? ?file-paths)]
        (content-index-contains? ?commit "path-exists" ?file-paths))
      (or-join [?ref ?branch-filters ?tag-filters ?ref-name]
        (and
          [?ref :git.ref/type :git.ref.type/branch]
          (array-contains? ?branch-filters ?ref-name))
        (and
          [?ref :git.ref/type :git.ref.type/tag]
          (array-contains? ?tag-filters ?ref-name)))))

  [?commit :git.commit/repo ?repo]
  [?repo :git.repo/org ?org]]

That seems to work. The file-filter stuff is a bit funky because we are guessing the ref from the commit based on the filters, but it seems to work

Example result:
[[{:github.org/installation-token "some-token", :git.org/name "atomisthq", :git.provider/url "https://github.com"}
  {:git.repo/source-id "225951504", :git.repo/name "web-app-cljs", :git.provider/url "https://github.com"}
  #:git.commit{:sha "8976e7077a86e2755486eb136103b26cef5c78d7"}
  "master"]]

In theory, there can be many results (hence the list of lists), but in practice, it's probably safe to assume there's just one if we have the right tx filters.

It's also worth noting that these named rules (such as tx-push-to-branch) are by no means stablised in terms of signature and naming

How come that ref-name doesn't have a key in the example payload?

It's positional - it's "master" in that example. Here we are pulling an individual datom, not an entity. There's nothing else useful on the ref entity TBH (it's the tag name or the branch name). We could return an entity there, but seems like more hassle than it's worth.

any update on this @kipz? I think I'm waiting on an updated subscription, right?

I wasn't sure if we'd closed on what to do re: refs - so basically it's likely to be the content-indexing for the file filters that triggers the skill, so you won't have branch or tag available....

What is going to happen when I push a tag and want to trigger only for repositories that have the specified file? In that case we need the tag name as well.

That's the same problem I'm describing. Content indexing happens after the tag/push, so when the index event comes in, we don't know which tag/branch to choose (if any). This is not a new problem - it was unsolved previously too. cc @slimslenderslacks  @whostolebenfrog . It probably makes sense for us to store tags on commits (though you'll still need to choose one if there are more than one). The branch is more difficult, but I'm not convinced it's needed...WDYT?

Here's an example test-query that takes a guess at tags and branches.
If there are many tags/branches, then you'll get multiple results, one for each match.
{:query
 [:find
  (pull ?org [:github.org/installation-token
              :git.org/name
              :git.provider/url])

  (pull ?repo [:git.repo/source-id
               :git.repo/name
               :git.provider/url])
  (pull ?commit [:git.commit/sha])
  (pull ?ref [:git.ref/name])
  :in $ $before-db %
  :where
  (get-config-value "branch-filters" ["^.*$"] ?branch-filters)
  (get-config-value "tag-filters" ["^.*$"] ?tag-filters)
  ;; triggers
  (or-join [?commit ?branch-filters ?tag-filters ?ref]
    (and
      (tx-push ?commit ?ref)
      [?ref :git.ref/name ?branch-name]
      (array-contains?  ?branch-filters ?branch-name))
    (and
      (tx-tag ?commit ?ref)
      [?ref :git.ref/name ?tag-name]
      (array-contains?  ?tag-filters ?tag-name))
    (and
      ;;take a guess at a branch/tag ref for this commit
      ;; but it must match the filters, if defined
      (tx-content-index ?commit _)
      [?ref :git.ref/commit ?commit]
      (get-config-value "file-paths" ["Dockerfile"] ?file-paths)
      (or-join [?commit ?file-paths]
        [(empty? ?file-paths)]
        (content-index-contains? ?commit "path-exists" ?file-paths))
      (or-join [?ref ?branch-filters ?tag-filters]
        (and
          [?ref :git.ref/type :git.ref.type/branch]
          [?ref :git.ref/name ?branch-name]
          (array-contains? ?branch-filters ?branch-name))
        (and
          [?ref :git.ref/type :git.ref.type/tag]
          [?ref :git.ref/name ?tag-name]
          (array-contains? ?tag-filters ?tag-name)))))

  [?commit :git.commit/repo ?repo]
  [?repo :git.repo/org ?org]]

 :skill {:id "other-skill-id"
         :name "some-skill"
         :namespace "atomist"
         :team-id "AK748NQC5"
         :version "1.2.3"
         :configurations [{:name "made-up-config"
                           :parameters [{:name "branch-filters" :value ["^master*$"]}
                                        {:name "file-paths" :value ["Dockerfile"]}]}]}
 :entities [
            {:schema/entity-type :atomist.content.index/item
             :atomist.content.index/commit "$head-commit"
             :atomist.content.index/name "path-exists"
             :atomist.content.index/value "Dockerfile"}

            {:schema/entity-type :git/ref
             :schema/entity "$head-ref"
             :git.ref/type :git.ref.type/branch
             :git.provider/url "https://github.com"
             :git.ref/name "master"
             :git.ref/repo "$repo"
             :git.ref/commit "$head-commit"}

            {:schema/entity-type :git/org
             :schema/entity "$org"
             :git.provider/url "https://github.com"
             :git.org/name "atomisthq"
             :github.org/installation-token "some-token"
             :git.org/source-id "13823265"}

            {:schema/entity-type :git/repo
             :schema/entity "$repo"
             :git.provider/url "https://github.com"
             :git.repo/default-branch "master"
             :git.repo/name "web-app-cljs"
             :git.repo/source-id "225951504"
             :atomist/graphql-id "T095SFFBK_T095SFFBK_atomisthq_224272887"
             :git.repo/org "$org"}

            {:schema/entity-type :git/repo-language
             :schema/entity "$clojure"
             :git.repo-language/name "Clojure"
             :git.repo-language/repo "$repo"
             :git.provider/url "https://github.com"}

            {:schema/entity-type :git/commit
             :schema/entity "$head-commit"
             :git.provider/url "https://github.com"
             :git.commit/sha "8976e7077a86e2755486eb136103b26cef5c78d7"
             :git.commit/repo "$repo"}]}

@cdupuis so we currently this query above should be fine. In ensures that either there is at least one tag or branch HEAD ref. WDYT?

I'll give this a try. Thanks.

Trying the above subscription lets the skill fail pretty quickly. The payload is missing the required configuration (parameters and resource providers) for this to work. I disabled the subscription.