Added support for gp3 and io2 both root and ebs volumes (fixed copy of #117)

what

Added support for io2 and gp3 volumes

why

original PR had conflicts, this will work hopefully
io2 and gp3 are new more performant volumes therefore they should be supported

references

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/instance#ebs-ephemeral-and-root-block-devices
Closes https://github.com/cloudposse/terraform-aws-ec2-instance/issues/114

@tbpoetke please bump modules in the examples in order to successfully pass the test/bats check
https://github.com/tbpoetke/terraform-aws-ec2-instance/blob/master/examples/complete/main.tf

@tbpoetke unfortunately after bumping the modules, there are also some breaking changes with the interface. Please ensure that the examples/complete module plans locally successfully and I will re-run tests.

@tbpoetke unfortunately after bumping the modules, there are also some breaking changes with the interface. Please ensure that the examples/complete module plans locally successfully and I will re-run tests.

ok, I will try to fix it, thanks for your help!

@nitrocode should work now, terraform validate and terraform plan no more errors, please retry the Github Action test. Thnak you!

/test all

Ok, will fix it again tomorrow ....sorry for the circumstances ...

/test all

@tbpoetke more yak shaving... please bump the required terraform version to > 1.0 in versions.tf and examples/complete/versions.tf

It's a long ride through this pipeline :1234:

/test all

Thank you so much for the contribution @tbpoetke ! I know it was a bit arduous. Future PRs will be easier.

Thank you for your review and your help @nitrocode . Next time I will try to test the pipeline with arc to avoid such problems ....


Add example of interacting with environment

I have made a number of examples (here is the first) that demonstrate how to create basic RL agents that can interact with the environment. These agents sit outside the framework and instantiate the environment themselves, step it, and collect rewards. By sitting outside and not modifying run_loop.py or agent.py, these agents can simply interact with the environment as they would in OpenAI gym or another similar framework.
I am not sure where to put these, so, for now, I have placed it in the agents folder. It can be ran using 'python basicEnvironmentAgent.py'.

This is probably better done in your own repo.


Unchanged HTML reported as changed

Description

Test case
Permalinks, the files are identical to the best of my knowledge:

https://github.com/jquery/blog.jquery.com-theme/blob/6710984735eb980cc9845b17f98aa0db8eac09e6/jquery/search.php
https://github.com/jquery/jquery-wp-content/blob/43bc52a23a7829701e599f8775061dfe1ba42028/themes/jquery/search.php

curl https://raw.githubusercontent.com/jquery/blog.jquery.com-theme/6710984735eb980cc9845b17f98aa0db8eac09e6/jquery/search.php > search-1.php
curl https://raw.githubusercontent.com/jquery/jquery-wp-content/43bc52a23a7829701e599f8775061dfe1ba42028/themes/jquery/search.php > search-2.php

difft search-1.php search-2.php

Compared to:
$ diff -w -u search-*.php
$

(zero exit status, no difference found.)
Versions
$ difft --version
Difftastic 0.57.0 (built with rustc 1.77.1)

$ diff --version
diff (GNU diffutils) 3.7

These files differ in regards to their line endings (linux vs windows). You need to use the --strip-cr flag:
difft --strip-cr search-1.php search-2.php


Handle WM_GETOBJECT while the window is being destroyed

This fixes the crash that @DataTriny reported on #37 . It has to be done in the window procedure, since that is what actually manages the lifecycle of the AccessKit manager. So we implement it in our tests and in the example, which provides a model for integrators.

Going to go ahead and merge this one, because it's a prerequisite for my next PR, and I don't think anyone else currently involved with the project would be able to meaningfully review this PR.


Not able to Install ArcGIS notebook server version 10.9.1 on ubuntu Linux 20.04 LTS

Hi @cameronkroeker ,
I am installing notebook server version 10.9.1 on ubuntu Linux 20.04 LTS. I am facing issues during the installation, the chef throws an error " FATAL: RuntimeError: arcgis_notebooks_server[Setup ArcGIS Notebook Server] (arcgis-notebooks::install_server line 53) had an error: RuntimeError: File '/opt/arcgis/11.0/NotebookServer_Linux/Setup' not found."
As mentioned in the error ArcGIS notebook server searching for a version 11.0 setup, we are installing version 10.9.1.
I am attaching the chef script and the log file for reference
NB.log
NB.txt
Any help would be much appreciated
Thanks,
Prathamesh Dabekar.

Hi @Prathameshdabeakr,
Are you using Cinc Server or Cinc client (cinc-solo/cinc-client)? Based on the json it looks like Cinc Server since it has "default_attributes": { }. If you are running Cinc Server then I believe you will want to ensure the arcgis.version attribute is defined in your environment json, and/or use "override_attributes": { } in your role json.
However, if you are using Cinc client then try removing  "default_attributes": { }.
Thanks,
Cameron K.


improve travisci config

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@f6bb13c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #3   +/-   ##
=========================================
  Coverage          ?   39.23%
=========================================
  Files             ?       34
  Lines             ?     3242
  Branches          ?        0
=========================================
  Hits              ?     1272
  Misses            ?     1860
  Partials          ?      110

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6bb13c...a6d255a. Read the comment docs.


nao encontrado, tente novamente

im receiving this message every time i type !play songname.
i console.log opts and it throws this message:
_data: { videos: [], playlists: [], channels: [] }
any idea about how to fix this issue?
note: i tried from a different ip to discard if it was a ban from youtube.

Reinstall yt-search package

im receiving this message every time i type !play songname.
i console.log opts and it throws this message:

Reinstall yt-search package

fixed after uninstalling yt-search cleaning cache and installing again, thank you so much! problem solved

not fixed

Show me your package.json, please


MinGW compilation broken due to std::futures

It seems that under GCC on MinGW w64 futures are not handled https://stackoverflow.com/questions/45565412/invalid-use-of-incomplete-type-using-stdfuture
Godot version:
bfe52fc
OS/device including version:
Ubuntu 18.04 under WSL (installed package mingw-w64).
Issue description:
Cannot compile under MinGW due to error
thirdparty/etc2comp/EtcImage.cpp: In member function 'Etc::Image::EncodingStatus Etc::Image::Encode(Etc::Image::Format, Etc::ErrorMetric, float, unsigned int, unsigned int)':
thirdparty/etc2comp/EtcImage.cpp:259:64: error: invalid use of incomplete type 'class std::future<void>'
   std::future<void> *handle = new std::future<void>[a_uiMaxJobs];
                                                                ^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<void>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:268:12: error: invalid use of incomplete type 'class std::future<void>'
    handle[i] = async(std::launch::async, &Image::RunFirstPass, this, i, uiNumThreadsNeeded);
            ^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<void>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:268:91: error: invalid use of incomplete type 'class std::future<void>'
    handle[i] = async(std::launch::async, &Image::RunFirstPass, this, i, uiNumThreadsNeeded);
                                                                                ^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<void>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:275:12: error: invalid use of incomplete type 'class std::future<void>'
    handle[i].get();
            ^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<void>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:275:12: error: invalid use of incomplete type 'class std::future<void>'
    handle[i].get();
    ~~~~~~~~^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<void>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:330:107: error: invalid use of incomplete type 'class std::future<unsigned int>'
      std::future<unsigned int> *handleToBlockEncoders = new std::future<unsigned int>[uiNumThreadsNeeded-1];
                                                                                ^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<unsigned int>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:334:30: error: invalid use of incomplete type 'class std::future<unsigned int>'
       handleToBlockEncoders[i] = async(std::launch::async, &Image::IterateThroughWorstBlocks, this, blocksToIterateThisPass, i, uiNumThreadsNeeded);
                              ^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<unsigned int>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:334:147: error: invalid use of incomplete type 'class std::future<unsigned int>'
 ] = async(std::launch::async, &Image::IterateThroughWorstBlocks, this, blocksToIterateThisPass, i, uiNumThreadsNeeded);
                                                                                ^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<unsigned int>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:340:50: error: invalid use of incomplete type 'class std::future<unsigned int>'
       uiIteratedBlocks += handleToBlockEncoders[i].get();
                                                  ^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<unsigned int>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:340:50: error: invalid use of incomplete type 'class std::future<unsigned int>'
       uiIteratedBlocks += handleToBlockEncoders[i].get();
                           ~~~~~~~~~~~~~~~~~~~~~~~^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<unsigned int>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:356:12: error: invalid use of incomplete type 'class std::future<void>'
    handle[i] = async(std::launch::async, &Image::SetEncodingBits, this, i, a_uiJobs);
            ^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<void>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:356:84: error: invalid use of incomplete type 'class std::future<void>'
    handle[i] = async(std::launch::async, &Image::SetEncodingBits, this, i, a_uiJobs);
                                                                                ^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<void>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:362:12: error: invalid use of incomplete type 'class std::future<void>'
    handle[i].get();
            ^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<void>'
     class future;
           ^~~~~~
thirdparty/etc2comp/EtcImage.cpp:362:12: error: invalid use of incomplete type 'class std::future<void>'
    handle[i].get();
    ~~~~~~~~^
In file included from thirdparty/etc2comp/EtcImage.cpp:40:0:
/usr/lib/gcc/x86_64-w64-mingw32/7.3-win32/include/c++/future:125:11: note: declaration of 'class std::future<void>'
     class future;
           ^~~~~~

Steps to reproduce:
Compile with scons p=windows target=release_debug tools=yes -j2

I think @hpvb built 3.0.5-stable binaries with MinGW, so maybe it works in some configurations.


sum-check multiplication with karatsuba

Hi @chancharles92 is this available to take up? Recently read the Hyperplonk paper and am keen to contribute!

Yeah of course! Appreciate it!


Can't sign transaction

First I created the master key.
$master = HierarchicalKeyFactory::generateMasterKey();
$masterKey = $master->toExtendedPrivateKey();
$address = $master->getPublicKey()->getAddress()->getAddress();

Then I got several addresses
$master = HierarchicalKeyFactory::fromExtended($xprv);

$hardened = $master->derivePath("0/999999");

$addr1 = $hardened->deriveChild(0);
$newAddr1 = $addr1->getPublicKey()->getAddress()->getAddress();
$addr2 = $hardened->deriveChild(1);
$newAddr2 = $addr2->getPublicKey()->getAddress()->getAddress();

Then I sent satoshi to this addresses.
Now I want to create transaction and send to some address but when I signed new transaction I got error "Signing with the wrong private key".
It seems my utxo are not my.
Then I checked pubKeyHash for this addresses and they are different.
What wrong? I did not correctly generate new addresses? Please help me!

I was able to sign a transaction. I just used the private keys of the children for signing.
It's correct?

Yes, if you derive a child address, you need to use the same child private key to receive it.
You can give the public version to a server, so it can only derive the address.. and then another server with the private data to sign.

Ok, thank you.


Incorrect indentation for functions with end paren on a separate line.

Before auto indentation
def do_thing(
    argument_1,
    argument_2
):

After auto indentation
def do_thing(
        argument_1,
        argument_2
):

There is no reason for the extra indentation if the argument list's closing parenthesis is on its own line.

Thanks for the report.  See https://github.com/Vimjas/vim-python-pep8-indent/pull/127.
Not sure if this won't break other things - at least it was testing for this behavior previously.
JFI: it is only looking upward, so it does not matter if the closing paren is on the first level / not indented - but it will indent like you expect it to.

Thanks

Just a heads up, this change results in the following auto indentation
def thing(
    stuff):
    return stuff

Which should be
def thing(
        stuff):
    return stuff

per https://www.python.org/dev/peps/pep-0008/#indentation
# Add 4 spaces (an extra level of indentation) to distinguish arguments from the rest.
def long_function_name(
        var_one, var_two, var_three,
        var_four):
    print(var_one)

This is why I mentioned the end parenthesis specifically. In the case where the ending parenthesis is on the same line as the last argument, the double indentation is correct.

I see.
However, then we cannot really fix this - at least while typing (without the closing parenthesis being there already), no?
It would indent with 8 spaces, and adding the closing one on a new line would not re-indent the line above - you would have to indent it manually again.

It would indent with 8 spaces, and adding the closing one on a new line would not re-indent the line above - you would have to indent it manually again.

That would be satisfactory to me. Even if the indentation doesn't work as I type, it would be nice if when I select a block like this and auto-indent it
def do_thing(
        stuff
):

I'd get this
def do_thing(
    stuff
):

By the way, I really appreciate you taking the time to look into this and converse with me.

:+1:
I think it can even be done while typing (when pressing ":" (via indentkeys).  See #129.

With :set indentkeys+=*<Return> it would even handle
def func(
        bar_)

to
def func(
    bar
)

(with the cursor at _ and pressing <CR>)
But I do not think it is worth adding this by default.

Let me know how it works for you, happy to follow up more on this.. :)

This is beautiful. Thanks again for being so responsive.

You're welcome - thanks for the detailed report in the first place.. :)
Initially I've thought that it should look for the matching closing parenthesis via searchpairpos also (forward, stopping at the next line (or at least fast) then), which might be more robust after all.
I guess currently it might handle trailing whitespace not good enough for example etc.
Let me know any findings, and we can have more tests / fixes here.. ;)

Hope it's working well still.. :)
Just found that this also should be handled for type annotations in a similar way / just for reference: https://github.com/Vimjas/vim-python-pep8-indent/issues/130

PEP8 indentation style is funny.
def do_thing(
        argument_1,
        argument_2
):

But I still think the above looks a bit better than
def do_thing(
    argument_1,
    argument_2
):

or
def do_thing(
        argument_1,
        argument_2):

:smile: :smile: :smile:

So you prefer 1 over 2?
IIRC this was changed to use 2 instead of 1 here.

Yeah, I know, it's just my preference. I use
def do_thing(
        argument_1,
        argument_2
):

in function/class definitions, and use
do_thing(
    argument_1,
    argument_2
)

when I'm calling them.


Lack of documentation for withKeyName

Reading on the source code. The fluent API for foreign keys seem to have a withKeyName to name the specific key. Yet there is no mention of this method anywhere in the docs. Is this method beta or something?. Or should the docs be modified to actually mention it?.

Probably it should be documented if it works and is tested. There are some forgotten features in knex which are forgotten just because of missing docs.


Track recent breaking changes in exceptions.net*.json files

This repo contains untracked breaking changes. To find and address them

Revert 75a4d00
Run .\build.cmd /t:Pack in projects 75a4d00 touched or .\build.cmd /t:Package in the repo root
Update exceptions.net45.json and exceptions.netcore.json to track the changes
If not already announced, suggest filing issues at https://github.com/aspnet/Announcements

@HaoK we should do this before your mega-change to see what existing breaking changes we have (and making sure they're all deliberate), and then you'll of course need to run it and update again after your mega-change.

9797d4bc5f3e54ffca3487c038044990585e278c


Unable to get 2 log files to work

1 file for errors, 1 for debug+; this configuration only creates and uses the debug level file
    logger = new (winston.Logger)({
        transports: [
            new (winston.transports.Console)(),
            new (winston.transports.File)({ name:'errors', filename: path.join(logDirectory, 'sm-api.err'), level: 'info' }),
            new (winston.transports.File)({ name:'debug', filename: path.join(logDirectory, 'sm-api.log'), level: 'debug' }),
        ]
    })

However, if I set the level of the '.err' file to info it works...
    logger = new (winston.Logger)({
        transports: [
            new (winston.transports.Console)(),
            new (winston.transports.File)({ name:'errors', filename: path.join(logDirectory, 'sm-api.err'), level: 'info' }),
            new (winston.transports.File)({ name:'debug', filename: path.join(logDirectory, 'sm-api.log'), level: 'debug' }),
        ]
    })

with this I get messages in both files-
Ideas?

OK, whatever was going on appears to have resolved itself. I'm now getting both log files after modifying what I was doing to use the default logger and configuring that. Not an issue...


Clear bucket before upload files

Hi! I added a new parameter to clear the bucket before upload files. Can I submit a pull request?
Thanks for Scotty tool , it has increased my productivity.

Sorry for not answering before, you can, of course!


gotip generic: incompatible type: cannot use int(m) (value of type int) as K value

What version of Go are you using (go version)?
gotip version
go version devel go1.18-e1c294a56d Sat Oct 9 01:04:29 2021 +0000 windows/amd64
type MM int

func Value[K ~int](m MM) K {
    return int(m) // incompatible type: cannot use int(m) (value of type int) as K value
}

func Value2[K ~int](k K) MM {
    return MM(k)
}

What did you expect to see?
gotip run main.go work successfully.
What did you see instead?
gotip run main.go:  incompatible type: cannot use int(m) (value of type int) as K value
Value2 is valid, but Value is not.

This looks correct, Value2 declare a return type of MM and converts the return value to type MM
Value declares a return type of K but tries to return a value of type int


Installation fails because only arm wheel is available for latest version

The latest version only contains the ARM version of the wheel. According to https://github.com/plotly/Kaleido/releases/tag/v0.2.1.post1 this is deliberate, but it breaks installation with poetry:
poetry install
Installing dependencies from lock file

Package operations: 1 install, 0 updates, 0 removals

  • Installing kaleido (0.2.1.post1): Failed

  RuntimeError

  Unable to find installation candidates for kaleido (0.2.1.post1)

My workaround is to just explicitly block 0.2.1.post1 with kaleido = "^0.2.1, !=0.2.1.post1".


Spectral library download added to FileNamesParameter

Relies on #2120

Can you merge the latest master?

yes

I will add the better menu item now

@SteffenHeu done
I will create an issue with your idea to add a last files button also to FileNamesParameter. Dont want to put it into the same PR

Is it intended that the files are downloaded every time you click on the libraries? If they are downloaded and present already, i think theyx should just be added.


Remove unnecessary use of -DGENERICS flag

This mirrors a change made to GHC in http://git.haskell.org/ghc.git/commit/a28a55211d6fb8d3182b0a9e47656ff9ca8a3766.

Windows CI error:
* inplace/bin/mkUserGuidePart.exe
* OracleQ (KeyValue ("_build/stage0/utils/mkUserGuidePart/package-data.mk","C_SRCS"))
* _build/stage0/utils/mkUserGuidePart/package-data.mk
* _build/stage0/utils/mkUserGuidePart/package-data.mk _build/stage0/utils/mkUserGuidePart/setup-config
* utils/mkUserGuidePart/mkUserGuidePart.cabal
Error, file does not exist and no rule available:
  utils/mkUserGuidePart/mkUserGuidePart.cabal

I'm afraid this is Hadrian's problem, and we need to sync with upstream on this mkUserGuidePart thing.

BTW, thanks for the patch!

@RyanGlScott Thank you!
We are bringing ghc-cabal command line in sync with Make build system in #395.
@izgzhen Indeed, failing CI appears to be due to a Hadrian bug.

Looks like we just need to remove mkUserGuidePart, which is no longer needed for GHC. I'll do that.


update apt::source usage to remove deprecation warning log spam

@fessyfoo this should reduce the amount of warnings on our error logs dashboard

can you PR this upstream instead?  and perhaps we can remerge upstream.   (or somehow get off this fork. )


Can't revert editor shortcuts

Godot version:

e8f3fa6
Issue description:

In the editor settings shortcut section, you can't revert the shortcut nor remove it. Pressing any button will open the Event Configuration dialog, as if the pencil button was pressed:

Fixed in #47596


How to use benchmarks to test sample network first-network

Hello, now I want to use benchmarks to test a sample network provided by Hyperledger Fabric, its name is first-network, but its structure of network config file is different from the structure provided by   benchmarks, so, should I change configtx.yaml in first-network to fit in benchmark? Or should I do some other thing? Please give me some steps to handle it. Any help would be appreciated!

you can use caliper to target an existing network, this does require knowledge of the network configuration etc that is bespoke to the network you created - see https://developer.ibm.com/technologies/blockchain/tutorials/blockchain-performance-testing-smart-contracts-vscode-caliper for more information


failed to retrieve study data

The viewer cann't work fine when StudyInstanceUID is a number

I use the latest version

Bug Report
The viewer cann't work fine when StudyInstanceUID is a number
Describe the Bug

This is the studylist page ,it work fine.

When I click the item ,it go to the error page ,

The qequested url is http://localhost:3000/viewer/448137. From the console window I can find two bad request! like below:

http://<IP_ADDRESS>:8899/dicom-web/studies/%C3%A3%C2%8F5%C3%9F/series
http://<IP_ADDRESS>:8899/dicom-web/studies/%C3%A3%C2%8F5%C3%9F/series/undefined/metadata

When I add a dot to the url ,it works fine ! The requested url is http://localhost:3000/viewer/448137.

The StudyInstanceUID is 448137

config

default.js

 dicomWeb: [
      {
        name: 'Orthanc',
        wadoUriRoot: 'http://<IP_ADDRESS>:8899/wado',
        qidoRoot: 'http://<IP_ADDRESS>:8899/dicom-web',
        wadoRoot: 'http://<IP_ADDRESS>:8899/dicom-web',
        qidoSupportsIncludeField: false,
        imageRendering: 'wadors',
        thumbnailRendering: 'wadors',
        enableStudyLazyLoad: true,
        supportsFuzzyMatching: true,
      },
    ],

The question
How to use number StudyInstanceUID in Viewer project?
Thanks!

Can you try v3? it lives inside v3-stable branch

Please review the latest code in the master branch. This issue might have been resolved. If it persists, kindly reopen the issue with updated details.
Try viewer-dev.ohif.org instead of viewer.ohif.org
Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master  branch
Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing


[CI] fix ci asan

Description
See:
https://github.com/google/sanitizers/issues/789
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

Thank you @vexilligera
Please also change
https://github.com/apache/incubator-mxnet/blob/76fa58373636c57fee1e4e6cd7960723b39f455f/ci/jenkins/Jenkins_steps.groovy#L569-L572
and
https://github.com/apache/incubator-mxnet/blob/76fa58373636c57fee1e4e6cd7960723b39f455f/ci/jenkins/Jenkins_steps.groovy#L1725-L1728
to use ubuntu_cpu instead of ubuntu_cpu_nightly.


Command prompt here...

Description of the new feature / enhancement
There used to be a feature in Windows where you Shift-Right Click (I think) on a folder in File Explorer and one of the context menu options was "Command prompt here..." .  That was a great feature, it was removed it would be nice to have it back and I think PowerToys would be a great place for that to be added.  It's really not a standard user feature and PowerToys are not standard user tools.  These have been great having this back - thank you.
Scenario when this would be used?
On any folder give the user the ability to get to the command prompt for that path.
Supporting information
No response

https://github.com/microsoft/terminal/issues/1060  Added back in Terminal 1.1
just tested on Windows 11 at least, this is built into Windows terminal.  Shows up on both win10 and win11 context menu.


Deleting SCOOP_BRANCH to not switch to master

Extracted from #3397

Well apparently deleting the SCOOP_BRANCH config variable did not reset the branch to master correctly. Can't seem to reproduce the issue.

Since SCOOP_BRANCH config is default and created always on installation, it is required for functioning. Since we can't forbid users to delete it we need to adjust it in code.
Should be enough to replace get_config SCOOP_BRANCH with get_config SCOOP_BRANCH 'master' to return default master, when config value do not exists.

We should create some Hashtable with defaults which would be used in codebase.
$CONFIG_DEFAULT = @{
    'SCOOP_BRANCH' = 'master'
    '...LESS_MSI' = $false
}

So we do not need to duplicate code and could easily change it if needed.

I like the idea. See discussion before: https://github.com/lukesampson/scoop/pull/3242#issuecomment-474013729


Go to definition doesn't work for method return type

Example:
<?php
namespace TestNamespace;

class MyTest
{
    public function abc() : TestClass // it does not work
    {
        new TestClass(); // it works
    }
}

It should o.o
https://github.com/felixfbecker/php-language-server/blob/master/tests/Server/TextDocument/Definition/NamespacedTest.php#L340

Works ok for functions but not for methods. Function_ from this line should be replaced with FunctionLike.

I can prepare PR for that but for now I'm fighting to adjust tests ;) Actual tests structure it a little bit too much change sensitive.

I will add new fixture for now but I will also open additional issue to discuss tests structure improvements.


Google font import fix

Added http: to the front of the Google font link for Raleway, so that font is loaded.
Signed-off-by: Ben Hinchley<EMAIL_ADDRESS>

Leaving off the protocol is a standard thing in web dev, as it makes the same URL work in both secure and non-secure realms without modification. (You don't want any http:// links in the head of an https:// page.) The only place where this fails, then, is when you are testing locally on your desktop from a file:/// URL. There's no way around that that I know of.
Walter

Agree with Walter the standard practice is to leave it off so it works on not http/https sites. Could cause errors etc if not added.
However that said surely the font would be selected during design/dev so this is a mute point. I have used self hosted fonts so this issue would only happen if hosted externally.

@walterdavis Well that makes a lot of sense then, will close this.


Make kubernetes containers a directory

Change the Kubernetes container entry to a directory mirroring the Docker container structure: log, metadata, filesystem.
Also fixes using a tty with the container's exec method (which was previously unused).
Resolves #203.
Signed-off-by: Michael Smith<EMAIL_ADDRESS>

This is going to have some overlap with refactoring in #762, but it's functionally independent.


Fails in Google Colab

Fails with last Step
0% 1/250 [00:27<1:52:18, 27.06s/it, Loss_D WD=-0.02465313859283924, Loss_G=-0.41385307908058167, Val_G=-0.030089471489191055]Traceback (most recent call last):
  File "train.py", line 223, in <module>
    wave_gan.train()
  File "train.py", line 199, in train
    save_samples(fake, iter_indx)
  File "/content/wavegan-pytorch/utils.py", line 172, in save_samples
    librosa.output.write_wav(output_path, sample, sampling_rate)
AttributeError: module 'librosa' has no attribute 'output'
  0% 1/250 [00:28<1:57:56, 28.42s/it, Loss_D WD=-0.02465313859283924, Loss_G=-0.41385307908058167, Val_G=-0.030089471489191055]

It seems the latest version of librosa has changed its Api, a safe plan would be to use version 6.0.3.


Provide an accessible label for form fields

Critical Changes
Changes
We corrected accessibility issues for several form fields on Contact Merge, Household Management, and Levels pages.
Issues Closed
Community Ideas Delivered
New Metadata
Deleted Metadata

@CrystalPreston-Watson I would really appreciate your comments on these changes.
@force2b @andrewyu-salesforce Ready for preliminary review, but significant changes may be suggested by @CrystalPreston-Watson.
@sam-knox Would you please review the Changes section of the PR?  No label changes.

**lurch: attach W-041648

Tracking W-041648


remove some more unused file stuff

@songgao removed some extra recompose stuff that wasn't using container here: https://github.com/keybase/client/pull/21875/commits/336fb01c94a9109a8b1fb4576d24c1323b4a9342


[feat] depend on wire-api

What's new in this PR?
We want to depend on wire-api to usefully work against it.

ouch, this comes with many more dependency than i thought. It'll be a pain to keep up-to-date. I can't think of another solution that has both properties:

automatically keeps up-to-date with wire-server
is available in the cache

But maybe there is a solution for this?

yeah, these are a lot of dependencies, fwiw, the dependencies that live in wire-server and the ones that we maintain ourselves (which is a good chunk) will just be updated fully automatically as they're updated in wire-server, the only ones we would have to do manually, is if we change a specified version in one of the hackage overrides. (the ones with callHackage)

as you can see in the last CI run, the caching works really well :D (1 min instead of 1 hour 30 minutes)


Route based wizard

Is there any way to couple react-use-wizard with route-based views separate for each step?
Let's say I'm using Next.js and the structure would look like this:
/pages
  _app.tsx
  step1.tsx
  step2.tsx

and then:
// _app.tsx
import { Wizard } from 'react-use-wizard';

const MyApp = ({ children }) => (
  <Wizard>{children}</Wizard>
)

// step1.tsx
import { useWizard } from 'react-use-wizard';

const Step1 = () => {
  const { stepCount } = useWizard();

  console.log(stepCount) // should return 2, but actually returns 1

  return ...
}

Hi, at the moment this is not possible. Every child is treated as a step but in NextJS you can only mount one page at the time


fix scan tag case

fix scan tag case

Coverage increased (+0.03%) to 55.454% when pulling 7eb036ddd3674661aa52c7507ccf972ac940f07d on sigsbee:fixcase into 5333cdc5e334a37d79afa912efd40cfe0041848a on vmware:master.


Errors in ESP scan tests

Device
Any
RTE version
Any
OSFV version
Good question
Affected component(s) or functionality
ESP scanning tests
Brief summary
The keywords in teardown and ESP005.001 have bugs
How reproducible
No response
How to reproduce
Run the test
Expected behavior
No typos in commands
Actual behavior
Potential test fails and wiped Windows Boot Manager from ESP
Link to screenshots or logs
https://github.com/Dasharo/dasharo-issues/issues/1128#issuecomment-2462011928
https://github.com/Dasharo/dasharo-issues/issues/1128#issuecomment-2462023366
Additional context
No response
Solutions you've tried
No response

This is related to: https://github.com/Dasharo/open-source-firmware-validation/issues/539


LCacheAddress: Allow bins to have any characters

Coverage increased (+0.006%) to 99.465% when pulling 2831def1afca61930824b211859e63592fea1063 on address-serialization into ba7f53e69d027f5195627a4fe5410e9b3be8558c on master.

Coverage remained the same at 100.0% when pulling df5d08e66b244c5bdfce7a658b5760f210e74ede on address-serialization into 2ef2b3467905bd634628e9573c77c405a15a7081 on master.


Init app folder structure

Summary by CodeRabbit

New Features

Introduced a new way to manage user preferences in the mobile app.

Bug Fixes

Fixed a syntax error in the main app flow that could potentially disrupt the app's functionality.

Documentation

Added documentation for various classes and files related to authentication, preferences, user management, and repositories.

@coderabbitai review


X Error of failed request:  BadWindow

Version
3.3.0 (nightly)
Platform
Linux x64
JDK
AdoptOpenJDK 16
Module
OpenGL, GLFW
Bug description
When I open a swing window along with the GLFW window, the moment I close the swing window it crashes the app with the below error. I am using LWJGL 3 with jMonkeyEngine.
I am on Linux Mint with Mesa (v20) graphics driver.
Stacktrace or crash log output
X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  20 (X_GetProperty)
  Resource id in failed request:  0x4e0005b
  Serial number of failed request:  1332
  Current serial number in output stream:  1332

Using AWT/Swing together with GLFW is not really supported/possible, because both try to steal each other's OS/window message events.
AWT is using its own window message loop to process the OS/window message events in its EDT thread and you are doing the same with glfwPollEvents/glfwWaitEvents.

@httpdigest thanks for the response.
Afaik LWJGL added glfw_async that makes it possible to use AWT/Swing together with GLFW on Mac. Would a similar solution work for Linux?

glfw_async currently only targets macOS.
And it also does not allow you to create any AWT/Swing windows.
It only lets you use the ImageIO subsystem (e.g. for image loading/storing) and lets you open/use modal dialog windows.
glfw_async is basically there to avoid people who already use GLFW to add the -XstartOnFirstThread JVM argument.

Making progress on the problematic example and found out that the drag and drop feature from Swing seems to be causing some trouble.
package example;

import java.awt.BorderLayout;
import java.awt.Dimension;
import java.io.IOException;
import java.lang.reflect.InvocationTargetException;

import javax.swing.JFrame;
import javax.swing.TransferHandler;
import javax.swing.WindowConstants;

import org.lwjgl.glfw.GLFW;

public class CodeSnippet
{
   public static void main(String[] args) throws InvocationTargetException, InterruptedException, IOException
   {
      JFrame frame = new JFrame();

      GLFW.glfwInit();

      TransferHandler newHandler = new TransferHandler("Bloppy");
      frame.setTransferHandler(newHandler); // Comment out to get the application to terminate properly.
      frame.setDefaultCloseOperation(WindowConstants.DISPOSE_ON_CLOSE);
      frame.setLayout(new BorderLayout());
      frame.setPreferredSize(new Dimension(600, 600));
      frame.pack();
      frame.setVisible(true);
   }
}

As soon as a TransferHandler is added to the frame, the X Error of failed request: BadWindow will pop up and make the application crash immediately. No idea if that's useful observation but I'll keep digging unless someone has some further knowledge on the more general issue.

That is platform dependent. You need set glfwGetX11Display and glfwGetX11Window with AWT/Swing and error will be gone.
For Windows glfwGetWin32Window and for macOS glfwCocoaWindow.
Why do you not expect glfw with platform binding like SDL2 has also platform dependence Via SDL_GetWindowWMInfo?

Thanks @DeafMan1983

You need set glfwGetX11Display and glfwGetX11Window with AWT/Swing and error will be gone.

Not sure how to set these values, can you please show me the code snippet I need to add on my Java code. Thanks!
Best Regards

Hey @Ali-RS & @SylvainBertrand,
Could you please try again with the latest LWJGL snapshot? I cannot reproduce such a crash. I also tried both code snippets by @SylvainBertrand and they worked without issues.

Hi @Spasi
Thanks for your response. I can confirm using the latest snapshot the error does not occur.

Sorry for late delay! Find in glfw native / platform check lwjgl3 packages
You should read glfw3 documentation for platform / native


LoadBot fails with SIGSEGV

LoadBot fails with SIGSEGV (invalid memory address or nil pointer dereference)
Description
Attempt to perform stress testing using built-in tool "LoadBot" fails.
Your environment

OS and version: Fedora 35
version of the Polygon Edge: v0.1.0
branch that causes this issue: develop

Steps to reproduce
Open MetaMask, create an account. In my case the following account was created (possible to import for debugging):
helmet pool broom actual inflict enter bitter tourist hungry walk render mind #mnemonic
db22fc73512d3e40c57056f24b2a4fa6e8a0c8ff9bdd98d4f398fa4514fd0524              #private key
0xD45d663eC1368C04Af04BC18c3d8e19a4D5F1cDD                                    #address

Use the address in Genesis config as pre-mined account: genesis_json.txt (rename the file to genesis.json).
Start Polygon Edge on a cloud instance:
polygon-edge server --data-dir ./data --chain genesis.json --libp2p <IP_ADDRESS>:1478 --seal --nat

Open MetaMask again, add custom network pointing to the just launched node:

Now, we can see in MetaMask that our account indeed has pre-mined balance:

Run LoadBot following stress testing guide:
# Example
export LOADBOT_0xD45d663eC1368C04Af04BC18c3d8e19a4D5F1cDD=db22fc73512d3e40c57056f24b2a4fa6e8a0c8ff9bdd98d4f398fa4514fd0524

polygon-edge loadbot \
  --jsonrpc http://<IP_ADDRESS>:8545 \
  --grpc-address <IP_ADDRESS>:9632 \
  --sender 0xD45d663eC1368C04Af04BC18c3d8e19a4D5F1cDD \
  --receiver 0xD45d663eC1368C04Af04BC18c3d8e19a4D5F1cDD \ #sending to ourselves
  --count 1000 \
  --value 0x100 \
  --tps 100

Expected behaviour
Transactions get created and submitted, loading the network.
Actual behaviour
panic: runtime error: invalid memory address or nil pointer dereference
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x14e8fe5]

goroutine 1 [running]:
github.com/0xPolygon/polygon-edge/command.(*CLIOutput).getCommandOutput(...)
        /tmp/polygon-edge/command/cli_output.go:31
github.com/0xPolygon/polygon-edge/command.(*CLIOutput).WriteOutput(0xc0004487a0)
        /tmp/polygon-edge/command/cli_output.go:23 +0xc5
panic(0x16b7ac0, 0x2bb2850)
        /usr/lib/golang/src/runtime/panic.go:965 +0x1b9
github.com/0xPolygon/polygon-edge/command/loadbot.(*Loadbot).Run(0xc0004487c0, 0x0, 0x0)
        /tmp/polygon-edge/command/loadbot/execution.go:165 +0x5ad
github.com/0xPolygon/polygon-edge/command/loadbot.runLoadbot(0xc000464be0, 0xc000464b00, 0xf, 0x0, 0x15)
        /tmp/polygon-edge/command/loadbot/loadbot_command.go:164 +0xa5
github.com/0xPolygon/polygon-edge/command/loadbot.runCommand(0xc000456f00, 0xc0001ac540, 0x0, 0xe)
        /tmp/polygon-edge/command/loadbot/loadbot_command.go:151 +0x20b
github.com/spf13/cobra.(*Command).execute(0xc000456f00, 0xc0001ac460, 0xe, 0xe, 0xc000456f00, 0xc0001ac460)
        /tmp/polygon-edge/vendor/github.com/spf13/cobra/command.go:860 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0xc0003c2a00, 0xc00045e280, 0xc00045e500, 0xc00045e780)
        /tmp/polygon-edge/vendor/github.com/spf13/cobra/command.go:974 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
        /tmp/polygon-edge/vendor/github.com/spf13/cobra/command.go:902
github.com/0xPolygon/polygon-edge/command/root.(*RootCommand).Execute(0xc000010c68)
        /tmp/polygon-edge/command/root/root.go:58 +0x32
main.main()
        /tmp/polygon-edge/main.go:17 +0x4c

Hey @kirillt,
Thank you for reaching out 🙏
We have identified the bug you were experiencing, and have resolved it in a PR that will get merged out soon, it was an issue with the loadbot module having incorrectly set modes.

@zivkovicmilos awesome! Looking forward to try again.

Looks working, thanks.


Fix mem leak related to do_os_response() function in ts_lua plugin

The exit for this block is missing a few things needed to release the resources
Those are things we are already doing when exiting the function in other execution path

[approve ci autest]

@zwoop we should backport this to 7.1.


Question - tests

Sorry to ask this here, but, how are you guys testing this ? If there are no tests, can I make a PR with a proposal for functional / automation tests ? Thanks

Unfortunately no tests. I'd be happy if you want to contribute on this part :-)

I'm testing my  blessed elements, like in the following spec: https://github.com/cancerberoSgx/accursed/blob/master/spec/treeViewKeysSpec.tsx
as you can see the tests simulate keypress and assert against element's getContent() What do you think? could I contribute with a couple of tests like this ?
Thanks

I think that would work.
How about a small PR for one of the simpler widgets as a start?


Feature Request: make HTTP status accessible in error callback

In our use case, OpenSeadragon is running off a Cantaloupe IIIF server. We have Cantaloupe configured so it reports different HTTP status codes for the info.json, depending on what's wrong with the image ID. If the image ID was invalid or just doesn't exist, that's a simple 404. But if it is still being processed, we return a 504 instead. I would like to suggest the user what to do next depending on that status code: for 504, they can just reload the page in a few seconds; for 404, they need to fix their URL. For anything else, they might as well tell us immediately because it's probably on the Cantaloupe side. Another use case might be 401/403, telling the user to log in.
When calling addTiledImage(), we don't actually know whether the tileSource will be valid or not. It usually is, so I would like to avoid a round-trip just to check... but I would also like to display a helpful error message to the user if something does go wrong. Currently I would have to parse the message property to get the HTTP status, which doesn't feel right. Having the status accessible directly would be a much cleaner solution.
It would probably make sense to provide access to the responseText / responseXML as well, because that is commonly used for more detailed JSON error messages. I don't really know how to do that cleanly, though, when only one of them is really valid (I am not much of a JavaScript developer).

Yes, that's a good idea! With the caveat that there can be failures that don't have an HTTP status associated with them. In those cases I guess we could just use 0.
Looks like this would be a good place to start:
https://github.com/openseadragon/openseadragon/blob/fd74ea3dca9a414328312461e6f0f7c312ab9e11/src/tilesource.js#L560
... But there are probably a number of places along the chain that would need to be updated to make it clean.
If you'd like to work on this, please do! Otherwise hopefully someone will pick it up.
Btw, as you can see from that code, OSD is consistent about how it puts the status in the message so that should be a pretty reliable way to get the code in the meantime. I agree it's cleaner to have it be an explicit part of the event object, though!

@matthias-fratz-bsz
Are you working on this? If not, I'll take it. I started but immediately noticed more <= IE11 code that could be removed so I'm going to do a patch for that first

@msalsbery No, I didn't find the time to work on it yet, so I'd be very happy if you do this one.

@msalsbery No, I didn't find the time to work on it yet, so I'd be very happy if you do this one.

@matthias-fratz-bsz ok cool, thank you!


Sometimes scrollbars will change from Atom-styled to Windows-style

Details of Build:
  C:\Users\Dev\Documents\GitHub\atom>git --info-path
     C:\Users\Dev\AppData\Local\GitHub\PortableGit_054f2e797ebafd44a30203088cd3d58663c627ef/share/info

  C:\Users\Dev\Documents\GitHub\atom>node -v
  v0.10.28

  C:\Users\Dev\Documents\GitHub\atom>npm -v
  1.4.9

Atom Version: 0.94.0-c79ef04 from my own builds running on Windows 8 (not 8.1)
I think the issue is caused when opening a big folder. Although I can't confirm this. If I open a source code folder from my desktop (atom on the right), I get the default scrollbars as it's not fully expanded in the tree when first opened as there are only 3 folders (at least not until I expanded them by hand).
However (atom on the left) larger folders like my entire desktop fill the sidebar vertically, and seems to cause windows-native scrollbars to appear instead of atom-style.
Here's a screenshot to show the difference:

NOTE: This may be related to the other scrollbar issue where the cursor goes invisible when resizing. Filed as issue #2165

Would like to reopen this issue. The commit fix from @kevinsawicki  fixes the treeview scrollbar, but not the main editor scrollbars. Would it be possible to have a similar fix for the editor pane too?
Screenshot:

OS: Windows 7 SP1
Atom: v0.201.0
Theme: Flatland Dark
Color Scheme: Monokai for Flatland Dark
Application and all instaleld packages are updated to latest.
Note: The deprecation warnings you see in the screenshot are related to 2 packages: atom-zeal and  sublime-tabs and aren't related to


Debugger sluggish with high-iteration comprehensions

Please search existing issues to avoid duplicates.
Details

Atom version: 1.35.1
Julia version: 1.1.0
OS: Win10 x64
Package versions:

Atom.jl: 0.8.3
julia-client: 0.8.2
ink: 0.10.2

Steps to reproduce
@enter into a function containing this array comprehension and then step over it:
nlocalmolecules = 3;
radius = 400;
iterations = 10000;
randomcoordinates1 = [randomcoordinates2d(nlocalmolecules1, radius) for i ∈ 1:iterations]

where
function randomcoordinates2d(count, radius)
    angles = rand(count) * τ # from Tau.jl
    radii = sqrt.(rand(count) .* (radius ^ 2)) # required for a uniform distribution around the circle
    x = radii .* cos.(angles)
    y = radii .* sin.(angles)
    z = zeros(count)
    return [x'; y'; z']
end

The code executes correctly and quickly outside the debugging context. In the debugging context, it is saturating my CPU and doesn't end. If I reduce the iteration count to 10, it works relatively quickly.
If there isn't an easy way to speed this up, would one idea be to add a button to process the next line without debugging?
It'd be even more helpful to break execution without losing the workspace, but that's probably a bigger issue?

Make yourself a nice cup of tea and start reading the performance musings:

https://github.com/JuliaDebug/JuliaInterpreter.jl/pull/204
https://github.com/JuliaDebug/JuliaInterpreter.jl/issues/206

This is only the tip of the iceberg; there's already been merged a lot of performance-focused work to get to where it is now (certain methods are 1000x faster than they were two weeks ago). Unfortunately, the next big gains are going to be more difficult.

Thanks :-) I did notice it was quite a bit snappier.

How is this a bug?

It basically prevents debugging of code that normally executes quickly. Indistinguishable from a hang and forces user to terminate the Julia session and start over, then spend hours trying to figure out why it wasn't working so that they can continue debugging.

Ok, so not a bug then but a doc issue or a performance issue then.

In the sense of works as designed and formally correctly? Sure, not a bug.
If the OS takes an exceptionally long time to do something that causes a user to reboot the OS and lose their unsaved work, I think that would be considered a bug, even if it was formally working as designed.

causes a user to reboot the OS and lose their unsaved work

Why would you reboot the OS without saving your work because a computation takes a long time? Not sure we can protect against that.

I'm talking about a hang that prevents you from doing anything else on the OS.

Interesting. A Ctrl-C interrupts it immediately for me. Can you reproduce it? Looking at the RAM it was using ~250 MB so that shouldn't cause the system to swap.

That does work, thanks. I'd gotten used to it doing nothing when Julia runs into trouble usually.


Update the README.md

Hey, @swapnanildutta
I've changed your README.md.
If you just want to describe more for enhanced by yourself adding

Demo()

images

features

Shall it work on your side?

Shall it work on your side?

Yes, this is good.

Thanks✨🙂


Add cloudformation template for S3 bucket

Description
Closes #7
This PR adds a Cloudformation template for provisioning an S3 bucket, and a shell script to deploy it. The bucket will eventually be used to serve a React app.
Gallery
An example of the script successfully running

If your bucket name isn't unique, this is the error message you'll get when you run aws cloudformation describe-stack-events --stack-name <<STACK_NAME>>

This shows the following:

navigating to the devops folder
attempting to run the command with a non-unique bucket name
reading the error logs
deleting the stack from the previous failed command aws cloudformation delete-stack --stack-name <<STACK_NAME>>

Note: <<STACK_NAME>> here begins with arn and ends with a string like a36c6130-77f3-11ec-b26b-06300054abe1

running the command successfully with a unique bucket name

Example page served from S3 bucket

Testing
Pre-reqs

You need a bash or zsh. If you're on Windows, there are lots of guides for adding bash, here's one
You must have the aws cli installed and it must be configured to use your access and secret key

Steps

From the root of the repo, cd devops/makeReactBucket
Run the following: ./makeReactBucket.sh
Enter your initials when prompted and press Enter

must only consist of letters a-z
can be no less than 2 chars
can be no more than 5 chars

You'll see a preview of your bucket and stack name. Confirm you want to create the stack and bucket by entering "y" and pressing Enter

The name will be formatted like this: $initials-$randomString-YYYYMMDD-bucket, $initials-$randomString-YYYYMMDD-stack

Once the stack is created, make sure the new stack and bucket have been created in the S3 and Cloudformation dashboards.
Copy/paste the following into a file called index.html:

<!doctype html>

<html lang="en">
<head>
  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <title>Public site</title>
</head>
<body>
  <h1>Hello, world!</hi>
</body>
</html>

In the Objects tab of your new S3 bucket, click upload and then choose the file you just created, then click upload again
Go to the Properties tab of the S3 bucket and scroll to the bottom. Go to the url for your Bucket website endpoint. If everything worked, you should see the Hello, world! text like in the Gallery above.
Once done testing, make sure to empty and delete your S3 Bucket, then delete your cloudformation stack (in that order)

Troubleshooting
I came across two issues during testing:

Error when I gave a non-unique bucket name (solved by replacing with a unique name)
Error when trying to update a stack that had failed to complete on the last attempt (solved by deleting the stack with aws cloudformation delete-stack --stack-name. See gallery screenshot 2 for more info

Added a shell script to take the user's initials and deploy a new bucket and stack with unique resource names


Adds recently viewed works rail

Adds the new Recently Viewed Works rail to emission 🎨
Part of: https://artsyproduct.atlassian.net/browse/DISCOVER-66

(not sure why some of these images aren't loading in the simulator but it's not specific to this rail)
#skip_new_tests because this is just adding a field to a graphQL query; no UI/functionality changes

@sarahscott are the images loading on device?

I can check! FWIW the image loading issue is happening on master for me in the sim as well.

It could just be my computer

Randomly, in other rails as well.

Warnings

:warning:

Missing Test Files:

src/lib/Scenes/Home/Components/ForYou/__tests__/index-tests.tsx

If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

  Generated by :no_entry_sign: dangerJS

Works fine on device, merging 👍


ompt-blame branch doesn't combine metrics across threads correctly

There's another problem with the openmp support.  For the ANL demo on
theta, I ran amg2006 + llvm-openmp libomp + your ompt branch.
Something is doing cut-and-paste for the call paths (correct), but not
correctly adding the metrics.
amg2006 + ompt branch + llvm libomp.a + OMP_IDLE:
For openmp loop # 8, the bottom-up and flat reviews report this as
17.6% for REALTIME.  But top-down reports only 1.3%.  That value would
be correct for a single thread, but not with master + side threads
combined with ompt support.
The problem is not multiple paths to omp # 8.  Expanding bottom-up
shows only one path.
amg2006 + 2020.03.01 release doesn't combine the two paths, but there,
bottom-up reports two paths, 1.2% from main (master thread) and 16.8%
from thread root.
Although oddly, top-down reports 0.1%, not 1.2%, again off by a factor
of 10-15 (this was 16 threads).  So maybe there's a more fundamental
problem.
I put two tar files on nancy.  Each one has the measurements and
database directories.
-rw-r--r--   1 krentel hpc 2887626 May  6 22:25 amg-hpc-master.tar.gz
-rw-r--r--   1 krentel hpc 3749792 May  6 22:25 amg-ompt.tar.gz
If amg2006 is too many threads (8 ranks x 16 threads), I could
probably write a smaller test where this happens.  Unless of course,
the bug depends on something complicated in the amg runtime.
@jmellorcrummey

The bottom-up view depends on the flat (or static) ID to combine the call path.
In your case, the bottom-up view of procedure hypre_CSRMatrixMatvecT._omp_fn.8 is a combination of 4 different call-paths since they all have the same static ID. The snapshot below shows 2 different call-paths of hypre_CSRMatrixMatvecT._omp_fn.8:

This problem is related to problems that have come up several times recently (e.g., with quicksilver, and with some stripped example that I produced recently with lots of unknown procedures). It is time for a discussion about a re-design of the support for constructing bottom-up and flat views.
@laksono : please draft a document to get the process started. The document should include:

a list of requirements for correct construction of views by hpcviewer for bottom-up and flat cases?
a list of known conditions that currently cause problems
a discussion of recent changes to address recent problems with this capability (i.e. for quicksilver, unknown procedures) and why the changes to address these cases were not enough.

It's a different problem with quicksilver. This time it's a pure hpcviewer problem.
As we know hpcviewer constructs the bottom-up tree based on static IDs.
During the bottom-up tree construction, when it encounters a call site, it just takes into consideration the static ID of the procedure frame (PF). It doesn't consider the static ID of the line statement of the call.
The snapshot below shows that the call site in purple boxes have the same procedure static ID, but have different call site static ID:

The following bottom-up tree construction code shows that: if two nodes have the same procedure scope static ID, we'll merge them. Interestingly, it doesn't take into account the call sites.
			//------------------------------------------------------------------------
			// we check if the scope is identical with the existing scope in the path
			// if it is the case, we should merge them
			//------------------------------------------------------------------------
			final ProcedureScope firstProc  = first.getProcedureScope();
			final ProcedureScope callerProc = existingCaller.getProcedureScope();

			String firstID  = String.valueOf(firstProc.getFlatIndex());
			String callerID = String.valueOf(callerProc.getFlatIndex());

			if (firstID.equals(callerID)) {

				//------------------------------------------------------------------------
				// combine metric values for first to those of existingCaller.
				//------------------------------------------------------------------------
				combine.combine(existingCaller, first, inclusiveOnly, exclusiveOnly);

Keep in mind, this is an old algorithm. A long time ago perhaps we shouldn't consider the call site (perhaps because of double aliens at that time?). I think we should consider the call site too, but I don't remember why we decided against it.

There are many cases where the merge based on procedure static ID only is desirable.
As shown below, procedure GOMP_parallel (static ID: 25743) are called by different instances of inline from hypre_smp_forloop.h (the snapshot below is the original hpcviewer):

If we don't want to merge the call sites (different instances of inline from hypre_smp_forloop.h) then the tree looks more confusing due to so many branches. The snapshot below is the MODIFIED hpcviewer where we don't merge if the two call sites are different:

Here, we have several GOMP_parallel nodes because they're called by different instances of inline from hypre_smp_forloop.h.
I can see why we decided to merge based on the procedure frame only, and I think it's a good choice. However, to avoid confusion, we should annotate a merged node. Even better if we can show the relationship between a node in the bottom-up tree to nodes in the top-down tree (one-to-many relationship).
Notes: the first number (177847) is the static ID of the call site. The second number (25743) is the static ID of the procedure frame:

This repository has moved to GitLab, please continue this issue there.


Cannot read property prototype of undefined (fromAuthCode)

I'm getting an exception when calling fromAuthCode like below:
import { fromAuthCode } from 'snoowrap'

export const authenticate = (code) => {
  return (dispatch) => {
    const options = {
      code,
      clientId: MY_CLIENT_ID,
      scope: ['read'],
      redirectUri: 'http://localhost:8081/authenticate'
    }
    fromAuthCode(options).then((r) => {
      r.getHot().map(post => post.title).then(console.log)
    })
  }
}

However I'm getting the following error in Chrome and Firefox
Uncaught TypeError: Cannot read property 'prototype' of undefined

Which is being thrown from this line.
Some more information:

I'm using webpack as a bundler and running locally using webpack-dev-server
I'm using babel to transpile

Any ideas?

I've done a bit of digging and found something interesting.
This doesn't work
import { fromAuthCode } from 'snoowrap'

fromAuthCode(options).then((r) => {
  r.getHot().map(post => post.title).then(console.log)
})

This does (albeit with a 401 error from the access token endpoint)
window.snoowrap.fromAuthCode(options).then((r) => {
  r.getHot().map(post => post.title).then(console.log)
})

Thanks for the report. This is working as intended -- snoowrap.fromAuthCode depends on the this value being a snoowrap constructor, so you need to call it as snoowrap.fromAuthCode -- you can't call fromAuthCode on its own.

Ah I see. Fantastic, thanks for your help! :)


HDFS-17566. Got wrong sorted block order when StorageType is considered.

Description of PR
https://issues.apache.org/jira/browse/HDFS-17566
How was this patch tested?
unit test: org.apache.hadoop.hdfs.server.blockmanagement.testGetBlockLocationConsiderStorageType
For code changes:

fix comparator order

@Hexiaoqiao @slfan1989
Hi, I found unit test failures of org.apache.hadoop.hdfs.server.blockmanagement.testGetBlockLocationConsiderStorageType.
I think the comparator order is wrong which is introduced by HDFS-17098.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m  9s

Docker failed to build run-specific yetus/hadoop:tp-12901}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6919

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/1/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m 26s

Docker failed to build run-specific yetus/hadoop:tp-2104}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6919

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/2/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zhengchenyu Thanks for your PR. LGTM. Try to trigger the CI manually, Let's wait what it will say.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m 11s

Docker failed to build run-specific yetus/hadoop:tp-26}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6919

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/3/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zhengchenyu Thank you for your contributions and for inviting me to review the pr. I agree with @Hexiaoqiao opinion that he should be more knowledgeable in this area.

Not sure why Domain resolve failed different times. @zhengchenyu would you mind to submit another empty commit git commit --allow-empty -m "empty" then push and try to trigger CI again.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m  9s

Docker failed to build run-specific yetus/hadoop:tp-11672}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6919

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/4/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m 10s

Docker failed to build run-specific yetus/hadoop:tp-10149}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6919

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/5/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m  9s

Docker failed to build run-specific yetus/hadoop:tp-12002}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6919

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/6/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@Hexiaoqiao
It seems like build server can not connect to archive.ubuntu.com. This web page can be connected by my computer. I tried three times, but all failed.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m 10s

Docker failed to build run-specific yetus/hadoop:tp-6016}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6919

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/7/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m  0s

Docker mode activated.

-1 :x:
docker
0m  9s

Docker failed to build run-specific yetus/hadoop:tp-19022}.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hadoop/pull/6919

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6919/8/console

versions
git=2.34.1

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@zhengchenyu Check other PRs, it seems CI works fine. But this one failed because domain resolved issue about *.ubuntu.com. What about submit another one PR and let's wait what it will say?

@Hexiaoqiao OK, I have submit https://github.com/apache/hadoop/pull/6934. For now, docker build pass. Let's wait ttps://github.com/apache/hadoop/pull/6934.


Suppress warnings if host is unreachable

Issue

I turn off some of my devices during night. The homebridge log is flooded with warnings since homebridge-zp v1.3.0. Is there a way to reduce these kind of warning?
Log Messages

HOSTUNREACH
[6/8/2021, 6:42:14 AM] [Sonos] Sonos Roam: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:16 AM] [Sonos] Room1: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:16 AM] [Sonos] Room2: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:17 AM] [Sonos] Sonos Roam: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:19 AM] [Sonos] Room1: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:19 AM] [Sonos] Room2: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:20 AM] [Sonos] Sonos Roam: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:22 AM] [Sonos] Room1: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:22 AM] [Sonos] Room2: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:23 AM] [Sonos] Sonos Roam: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:25 AM] [Sonos] Room1: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:25 AM] [Sonos] Room2: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:26 AM] [Sonos] Sonos Roam: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:28 AM] [Sonos] Room1: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:28 AM] [Sonos] Room2: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH
[6/8/2021, 6:42:29 AM] [Sonos] Sonos Roam: warning: <IP_ADDRESS>:1400: cannot connect: EHOSTUNREACH

Debug Files

No, there isn’t, other than turning Homebridge off at night as well.


sneaky sources of problems with 6dof / Kalman filter etc

My 2 cents, a few of the possible sources of issues:

sign: are the accelerations "absolute accelerations" or "accelerations measured by the IMU"? This is quite easy to mix up, especially when gravity is involved: gravity is pulling "to the ground", but feels as if accelerating "to the sky". Same with angular rates, I always get confused about the conventions in the datasheet vs the libraries vs the filters....

units: m/s^2 vs g vs mg, deg/s vs rad/s as you were pointing out; I think it may be a good idea to triple check all of this once and for all with https://github.com/adafruit/Adafruit_AHRS / https://github.com/adafruit/Adafruit_AHRS/blob/master/src/Adafruit_AHRS_NXPFusion.h and https://github.com/memsindustrygroup/Open-Source-Sensor-Fusion / https://github.com/PaulStoffregen/NXPMotionSense . And these codes have been copy pasted and slightly reworked several times, which makes things even worse imo :( . I had for my part get inspired by: https://github.com/adafruit/Adafruit_AHRS/blob/master/examples/ahrs_fusion_ble_nrf51/ahrs_fusion_ble_nrf51.ino .

PS: the accelerations seem definitely to be expected in g:s, so my feeding ms-2 into the Kalman filter is probably at least suboptimal, better said wrong; but if the Kalman filter is just using the mean direction of accel to determine the vertical, and not taking into account the magnitude (possible, but hard to see through the maths of the algo), that may not play a bit role for the quaternion estimate. Still, would be nice to test and better to get right :) .


Test adding an organisation

This should provide the capability to add Org4 to the existing 3 Org network

Deploying chaincode didn't affect anything but due to https://github.com/hyperledger/fabric-gateway/issues/338 org4 hasn't actually started endorsing

Changed the endorsement policy to force org4 to endorse and that get's picked up as expected with the usual various errors of

ProposalResponseMismatch
endorsement policy failure
mvcc read conflict

As described when changing an endorsement policy


Unused AMS api should be ignored from generation

AMS API contains a lot of code that is widely unused - we use only single endpoint.
When generating we should keep one tag.

This needs further clarity.

Updated


Add more information to the Frameworks and Targets topic

Topic: https://docs.microsoft.com/en-us/dotnet/articles/standard/frameworks
Proposal:
Rename that topic to Target Frameworks
Add list of supported TFMs (similar to what we have in this topic over in the NuGet docs)
Link to this topic where we mention the target framework, TFMs, etc. For example, a bunch of commands like dotnet-build, dotnet-run have the framework option.

@mairaw

Rename that topic to Target Frameworks

Just the topic title, correct? I can leave the file name (frameworks.md) as it is, correct?

Link to this topic where we mention the target framework, TFMs, etc.

Assuming the file name and URL don't change here (just the title), would you like me to run back over to #1705 and add links to this doc before that PR goes in? If so, I'll do that first (now).


[CL] test changing authorized params

We should test and confirm that nothing breaks if we change authorized params

Just to clarify the proposal here – the intended behavior for most incentives operations is to operate on all supported uptime accumulators, regardless of which are authorized.
An example to illustrate is imagine if all uptimes were authorized and then, after incentives were created for them, they were unauthorized – collectIncentives should still collect from the emitting incentive records that were created when the uptimes were authorized.
So the only logic that should really depend on authorized uptimes should be incentive creation (which is already tested). The equivalent in any other scenario is functionally the same as testing the case where no records were added to unauthorized uptime accumulators.

Discussed offline and decided it makes sense to run incentives tests on multiple authorized uptime permutations for robustness.


Google form Integration

This relates to #16.
The ask here is to automatically trigger a google form creation as soon as a event is inserted into Firebase DB.
Make sure the form url is not exposed before we actually host the meetup for that month.

Google App Script seems to be the way to go here..
Created a simle app https://script.google.com/macros/s/AKfycbwVxSW8bPgmAOpg6x00MjN6ha7z_M2spREJu8NAtIcNwQ6SUDc/exec
We can build out an api out of this.
Also have we dropped that idea of using a Raspberry Pi from #6

Hey @preetjdp, I'm not able to access the link. Can you make one script that generates the form we send out every month?
Something like this https://goo.gl/forms/3mJ5SKeRriCpvAel2.
Regarding the meetup api integration, we are thinking to move the work to a service worker which can do the background sync.
We are still investigating the feasibility for the same.
Having a raspberry pi is a last option open.

@nikhil-thakkar Created the Script, currently using dummy data, but every time you hit this link a new Form is created (under my account) and the link to the form is displayed on the page. I will create a way to pass the event data.
LINK - https://script.googleusercontent.com/macros/echo?user_content_key=LNF52X8zK9apUwFJxFll_vPwfqBJcSwWJTUJDNESM_y-fa2aT9M4kEqS52BSo0zbfh1GufnExSFm9SY0n4LYyPNLQYjt5mXAm5_BxDlH2jW0nuo2oDemN9CCS2h10ox_1xSncGQajx_ryfhECjZEnFRvA2dKE0MqUQ8yBLYVOydr8qSrAjY6pLA64kR-tiNwrTsU6_kVHqMh4XCbKchLy6V-rV9yhQ38&lib=M9JqF_R0Enu9yV3gWqxpqsKP3W5k7qA10

Awesome @preetjdp, Could you please create a folder at root of this repo named scripts and push your code there and raise a PR afterwards?


update submodule fmtlib

Signed-off-by: Lloyd-Pottiger<EMAIL_ADDRESS>What problem does this PR solve?
Issue Number: close #6149
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/cc @breezewish

/merge


If the userid is not found in the DB do a case insensitive search

https://bugzilla.redhat.com/show_bug.cgi?id=1486041
If the appliance administrator manually creates a user in mixed case it would not be found.
This change will do a case insensitive search for the user. To minimize unnecessary
performance degradation, it will only do the case insensitive search if the user can
not be found as presented.
Steps for Testing/QA [Optional]

Configure an appliance for authentication Mode: LDAP(s)
Manually configure a new user with a mixed case userid.
Attempt to log in as that user but enter the username in all upper case.

@gtanzillo Please review. Note I also DRYed the code you suggested I might want to from my last PR :)

@miq-bot add_labels bug


allow combining include and exclude

I noticed the logic for handling the include and exclude options is currently
function ignore(name, path, rules) {
  if (rules.exclude) {
    //....
  } else if (rules.include) {
    //....
  }
  return false;
}

This doesn't let you do more specific things like "include src/ and test/ but exclude src/foo" or something like that.
If you just change it to
function ignore(name, path, rules) {
  if (rules.exclude) {
    //.... same as before
  }
  if (rules.include) {
    //.... //same as before
  }
  //they didn't match either rule, so if an include pattern exists, this is ignored, otherwise it is not
  return !!rules.include;
}

i think it would allow for those new types of patterns. It would be a breaking change, since people may be relying on the current behavior of ignoring the include flag if the exclude flag exists, but I think it would be an improvement.
If you're open to the change, I'd be happy to make a PR to do it.

Thanks @bdwain, I would be interested in this change.
But we would also need to add tests to document the behavior.

@bdwain Are you still interested in making the PR?


tree-sitter: update grammars

Motivation for this change
Update tree-sitter grammars
Switch to nvim-treesitter/tree-sitter-lua for lua, since current lua grammar is broken for 0.19.5
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Added a release notes entry if the change is major or breaking
[ ] Fits CONTRIBUTING.md.

any darwin user to say why it fails ?

I think the darwin build was fixed in #125100
I rebased with latest master, and updated the grammars again, lets see if now works on darwin (I don't have a macos to test locally)

darwin build fixed in current master :)

thanks for the patience

@teto sure, no worries, thanks for all your great work in nixpkgs and neovim :)


[#41][#58][#60] Add multi shape support for Kops cluster and addon's improvements

This PR fixes issues #41
And #58 as well
From user's perspective just need to define desired memory and CPU resources and AWS instances with optimal shape would be created and delete automatically

TODO: Functionality test

Added #60 implementation

The branch has conflicts and cannot be merged.


Escape argument in examples build script

What kind of changes does this PR include?

Something else!

Description

#743 introduced shell-emulator=true in .npmrc
This caused the Size Limit check to fail in #709 because the example build script included @examples/* unescaped, which with shell emulation enabled was parsed as a glob and errored when it failed to expand the *.
This PR wraps the --filter pattern in ' to escape it.

Hmm, looks like that wasn’t it 🤔
Will need to dig further to work out why it’s hitting this error:
> pnpm --filter @example/* build

No matches found: "@example/*"


Support pipe into commands

Let's assume somebody wants to write the following command spo site list | spo app install (imagine some filters in the site collection selection and an app id provided).
Today that's not possible because commands don't support pipe input.
More context https://github.com/pnp/office365-cli/pull/624#issuecomment-426727846

I can have a look to see what's possible in vorpal, the engine behind the CLI. Meanwhile, how would we decide what could be passed through the pipe? For the spo app install command you mentioned above, it could be just as convenient to pass the list of sites or the list of apps.

As far as I remember from my PowerShell cmdlet development, the way it's done in PS is you handle it through declaring the types that can be piped in and testing the type when you get something. You can also declare associations between parameters and piped types so if I'm piping a bunch of site collections, the site parameter is disabled (for auto-completion/availability).

I'm not sure how vorpal works but it'd be cool to have a similar behavior if we could

That's true, but if I'm not mistaken, everything that's coming through a pipe in Bash is a string. If we have distinct input types such as id (guid) and site URL then detecting the type of input parameter could just work. Either way, it's something that we could decide per command. Good idea 👍 I'll have a look at what's possible.

I had a look at it and indeed, bash doesn't have the notion of objects. Instead, what you get is a string. So if you wanted to pipe the output of one CLI command to another, using the JSON output would be the way to go. From the CLI point of view, the underlying tech supports it, so we'd need to implement the base support for processing stdin and then handle it on a per-command basis.

I think that's a good plan. To keep the type information maybe we could leverage the odata type property? Add it when serializing for pipe output and then read it on the input to determine what we're getting?

Very nice suggestion! It would work perfectly when chaining multiple CLI commands together. I wonder if we could extend the identity (talking in PowerShell terms 😉) to support single properties like URL or GUID as well. This would be helpful in cases where you want to pipe a list of URLs or IDs which aren't complete odata objects and don't have a type designation.

@andrewconnell and I had a discussion about this lately and we couldn't find examples of other CLIs doing this. It seems like such behavior (piping complex output of one command to another) is something specific to PowerShell. CLIs are typically used in scripts where the values are assigned to and passed via variables. So while adding support for piping could be done, it might be confusing for folks who are used to working with CLIs. I'm inclined to reconsider adding this to the CLI and keep using scripts for more complex scenarios

Piping isn't something you do with CLI's... that's a POSH concept. If you want to pipe, use POSH, but  POSH-ifying a CLI isn't the right approach for the target audience.
What you're describing is done using a bash script, not by introducing support for piping with the CLI.
I fully acknowledge some bash commands support limited piping, but this opens up a can of worms.

From what I remember if the ages before powershell (and yes I was young so memories might be blurry) one of the big advantages of bash over the windows command prompt was it's much better pipe support and tooling around it (see, grep...).
Now I might be mistaking but I can see a "bash aficionado" having a file full of site urls or something similar, greping it and then piping that into one of the commands. Or is it unrealistic?
Now I understand piping in bash doesn't support complex types and I agree that we should not over complicate the cli if the underlying infrastructure doesn't support what we're trying to achieve. I also think we should support "basic bash piping" in the cli for the reasons I exposed and leave the responsability to the user of inputting the right format. (Helped with done documentation)
What do you think?

Looking at your original example spo site list | spo app install, that wouldn't work, even in PowerShell, because you'd need to pass each list separately rather than a list of lists.
Where it would make perfect sense I think is for things like JSON theme file or certificate contents, or contents of a script to set on a custom action, where you want the whole large string to be passed as-is without processing it. Passing such values through arguments is tricky because of quotes that need to be escaped just right depending on the shell you use.
@andrewconnell?

Even for things like JSON files of JS scripts?

@waldekmastykarz to reply to your comment around the sample command I provided, yes in PS I'd have to use a % {$_ } syntax (a foreach basically). The equivalent syntax in bash looks much more verbose and from my readings people tend to use scripts then when they want to do something like that as AC mentioned.
So yeah maybe we could start with trivial ones, like the files and see from there?

If I look at the amount of trouble quotes are causing, it would be helpful if we could alleviate it.

Closing this for now as we don't have a specific use case for implementation. Let's revisit in the future if need be.


Theme's primaryColor is ignored

Hi,
In my app's theme I've set the primary color but I don't see this reflected in the components:
dmc.MantineProvider(
        id="mantine-theme-provider",
        theme={
            "colorScheme": "light",
            "fontFamily": "'Inter', sans-serif",
            "primaryColor": "green",
        },
        inherit=True,
        withGlobalStyles=True,
        withNormalizeCSS=True,
        children=[]
)

And here the content of a Dash page:
dmc.Button(
    "Github",
    leftIcon=DashIconify(icon="mingcute:github-fill"),
    size="lg",
)

This is what I get:

Based on https://mantine.dev/theming/colors/#primarycolor I would expect my button to be green, or did I misunderstood the meaning of primaryColor?

This works as expected with the current version:
from dash import Dash, _dash_renderer
import dash_mantine_components as dmc
from dash_iconify import DashIconify

_dash_renderer._set_react_version("18.2.0")

app = Dash(external_stylesheets=dmc.styles.ALL)

app.layout = dmc.MantineProvider(
    dmc.Container(
        children=[
            dmc.Button(
                "Github",
                leftSection=DashIconify(icon="mingcute:github-fill"),
                size="lg",
            )
        ],
        style={"padding": "1rem"}
    ),
    theme={
        "primaryColor": "green",
    },
)

if __name__ == "__main__":
    app.run(debug=True)

Thanks for confirming this works now @datenzauberai
I'll close this issue now :tada:


Implement PEP 592 -- Yanking of Releases/Files

The way we should implement this is that an entire release can be yanked or unyanked at will by a maintainer of a project. Yanking should set an attribute on the simple repository link for any files for that release.

Here's a PR that starts implementing this https://github.com/pypa/warehouse/pull/5838.

Hey @dstufft -- I think I may be misunderstanding something. In our discussion in March we discussed wanting a system for generic flags and statuses on projects and releases, in order to address #345 "Ability to mark a version of a package as deprecated or unsupported" and #3709 "Offer a discouraged/deprecated releases option", and to help with future moderation work on stuff like #6062 re: malware/spam detection.
Will the yanking feature address either of those "mark package as deprecated" issues?
And: are you planning on implementing the "yanked" attribute within a generic flags/statuses system? If not then I should file an issue to start speccing that out.
Also, I figure yanking will constitute an event that should be listed in #5863, so, linking to that issue.

And is #4962 potentially relevant?

For reference purposes, I just wanted to note on this issue that PEP 592 support has been added to pip and will be in its next release: https://github.com/pypa/pip/issues/6633

In #6318, @ncoghlan asked that the "delete project/release" dialog to include

an easy way to yank every released version instead (preferably as one of the options in the warning notice)

Ideally implementing this PR would include such a link/notice/feature.

Will the yanking feature address either of those "mark package as deprecated" issues?

Yep, for both issues. #4962 doesn't seem relevant to me.

@di @dstufft can you advise on whether this feature is likely to get into Warehouse within the next few months?

I am unlikely to find time in the next few months to work on it.

Seems likely. In my opinion https://github.com/pypa/warehouse/pull/5838 is now complete and just waiting to be reviewed.

Fixed in https://github.com/pypa/warehouse/pull/5838.

The release yanking feature is now live on PyPI and the "yanked" field is now available in the API. @ori-yitzhaki and @yuvalreches you'll probably want to test this with JFrog Artifactory and verify that you are properly using "yanked" status when appropriate. If you find a bug in PyPI's implementation, please file it as a new issue and link to this one.


Design: AnonCreds Credentials using the W3C Standard

This PR contains the very first DRAFT working version of the design documents connected to adoption of AnonCreds Verifiable Credentials and Presentations for the W3C Verifiable Credentials Data Model Standard.
The main goal of this PR is starting the discussion on the proposed format and implementation path / API.
Currently, the PR contains two main documents:

spec.md - document describing how AnonCreds credentials and presentations should be represented in the W3C Data Model

this document should not be merged into this repository
It should be moved and included into AnonCreds specification (I believe)
I put it here to have a single place for discussions

w3c-representation.md -  document describing proposed anoncreds-rs API changes and implementation path.

Great stuff in this.  We’ll be discussing this at the AnonCreds meeting on Monday Nov. 6, 7:00 Pacific / 16:00 Central Europe for those that can make it. I understand it is a holiday for some, so not everyone can make it, but we’ll do what we can.
Meeting info: https://wiki.hyperledger.org/display/ANONCREDS/2023-11-06+AnonCreds+Working+Group+Meeting

A list of open questions (some with proposed answers) in one place (to be extended / updated): link

I opened PR in anoncreds-spec   repository which add W3C section into AnonCreds credentials specification.
I'm going to exclude context.json and spec.md files from this PR (anoncreds-rs) as these files included into mentioned above PR to anoncreds-spec repository

https://github.com/hyperledger/anoncreds-rs/pull/266#issuecomment-1822911739
@vortex-hue what do you mean? The flow itself keeps the same as before (Spec). Now you have a set of parallel methods to get data in different format.

Anyone know why a test is failing here?  Re-ran the failed test and got it in Ubuntu GHA (Windows the previous time).  We can merge this documentation only PR with this, but didn't want the error to be ignored.

@swcurran Should I clean the section with questions before merge?

@swcurran Should I clean the section with questions before merge?

It would be appreciated. Nice to have as well changing the “in the future” items to be now. For example, the for example, the first line that says (more or less) “Currently we don’t support W3C VC Format”. It should say something like “Here is how we support W3C VC Format…”.
Not crucial, but this will be long lived docs, so clean up is good.


Parsing bvh files

Thank you for your great work.
If I would like to use arbitrary bvh dataset, what should I do?
I already tried to convert not only CMU but also another bvh dataset, but When I converted another bvh dataset, it seems can not parse correctly.
When I visualize it, it seems strange moving. It's not only predicted result but also ground truth.

Have you solved the problem yet?


R documentation

We have auto generation of R documentation, but the process isn't part of the standard build due to the different tools used. This means that most R package builds won't include the docs.
Suggest we either include the autogenerated docs as part of the git repo, or provide a mechanism for auto fetching generated documents.

Closed - download included in commit 2b82021abe8abb37bfbf71b158d491e3bd5cffb2


test: Add transmuxer integration tests

Some tests are failing in macOS, but in real it tests works…

Some tests are failing in macOS, but in real it tests works…

Please try increasing the timeout for those steps.  In some cases, playback runs at < 1x on macOS with WebDriver attached.  I've never determined why, and it only seems to affect certain devices.
For 10s of playback, I recommend at least 20s to complete the step.  30s would be best.

@joeyparrish now all tests pass! Thank you

I have thought about using StreamGenerator but... currently it doesn't work for AAC, MP3 (raw formats) for example.
I'm currently working on having our own transmuxer for AAC and MP3, so this is considered a regression test to see that I don't break anything.
If you want I can delete the tests that have streams that do not depend on us, what do you think?

Well, it's probably okay for now, especially with the GitHub Actions environment, which is pretty reliable.  Let's keep it.


Support Depth_fm

https://github.com/CompVis/depth-fm

Eh I don't want to touch diffusers stuff but someone ported it to Comfy: https://github.com/kijai/ComfyUI-depth-fm

@sdbds You may find this interesting btw: https://github.com/kijai/ComfyUI-Geowizard. It's more consistent than DepthFM and can give some pretty good result with just 4 steps + DEIS scheduler


Problem filtering nested NSManagedObjects

Hi,
I'm not being able to filter using .filter(predicateClosure:..) for the example as below:
Let's assume we have 2 Entities
class Event: NSManagedObject {

    @NSManaged var name: String
    @NSManaged var timeStamp: NSDate
    @NSManaged var place: Place

}

extension Event {

    static let name = AlecrimCoreData.Attribute<String>("name")
    static let timeStamp = AlecrimCoreData.Attribute<NSDate>("timeStamp")
    static let place = AlecrimCoreData.Attribute<Place>("place")

}

and second Entity
class Place: NSManagedObject
{

    @NSManaged var name: String
    @NSManaged var event: Event

}

extension Event {

    static let name = AlecrimCoreData.Attribute<NSDate>("name")
    static let event = AlecrimCoreData.Attribute<Event>("event")

}

As you can see there's relation between Event and Place.
I want to filter as follows
let result = dataContext.places.filter({$0.event.name == "iOS Event"}).toArray()

So the problem here is that I'm not being able to access event name through
$0.event.name

Any solution?!
Thanks in advance!

Hello.
Currently it is not possible to use the attribute names of related entities in this type of predicate closures. (You can still compare the related entity with nil or with other instance of the same type inside the closure, however.)
To obtain the result expected by the code you gave as example, you can use the old-fashioned way:
let result = dataContext.places.filterBy(predicateFormat: "event.name == %@", arguments: "iOS Event").toArray()

I hope to find a way to implement the filter as you exemplified in the future. We are pushing Swift to its limits here. ;-)
Thank you.

I already used your approach!
Thank you.

Good news! If you use the latest beta version (3.0-beta.5) and ACDGen utility to create the code for your entities, you can now write the code just the way you want:
let result = dataContext.places.filter({$0.event.name == "iOS Event"}).toArray()

(At least to a level more, until we have a implementation of expressions trees.)

Glad to hear that! Well done mate!
Thanks


Modify versions menu to keep you on the same page

This PR fixes #620

Modify function of sphinx-material to remain in the same page if the version is changed.

Extra info
I realized that we cannot guarantee that there will be a page available with the same path in the rest of versions. For example, if the function was added/removed/renamed in a later version.
If the page doesn't exist we will have an error that looks like this,

My fix was to add a head request before assigning the href to just verify if it is working, if it doesn't exist then it will redirect to the other version's homepage.

Thanks @steff456, this seems to work now from some testing in the build preview. Since this is all JS code, I'll defer to @kgryte for the rest.

Thanks, @steff456! Let's merge this in, and we can address any encountered issues in follow-up PRs.