Wrong CompletionSegment performed when we start typing while part of text already selected.

Hello. We use auto-completion with your editor. It works fine. But when i start typing in text area while part of text already selected - CompletionSegment miss first character. So auto completion ignore first key typed in. Even your completion example works with this bug.
How to fix this?

When opening a completion window, set the CompletionWindow.StartOffset and EndOffset properties to specify the initial completion segment.

@dgrunwald, you suggest incorrect solution.
"my selected text" -> (press 'w') -> "w" (here I get opened completion window and it is become closed without my interruption next moment) -> (press 'r') -> "wr" (here it again open completion segment, but segment has only "r" letter inside) -> (press 'o') -> "wro" (here it has segment "ro")
Why we should manage this situation ourselves? Catch this silly "text selected" state and then move segment offsets in correct positions? This problem should be solved once for all of us inside library classes, not outside, I hope you understand.
Thank you, I am sorry for being rude.

I'll have a look at the completion example.
Note that this usecase works fine in SharpDevelop.

@dgrunwald, I reproduced this bug in a little project (VS-2012): https://www.dropbox.com/s/4xt51erlhy7qwdv/AvalonEditBugSample.zip?dl=0
You can see incorrect behaviour if you'll perform this actions:
(select part of text in text area) -> (press 'I')

From my analysis this is because you are opening the completion window in the TextArea.TextEntering event, whereas the AvalonEdit sample application does so in the TextArea.TextEntered event handler. The completion window closes itself automatically, because the offsets are no longer visible after the text has been replaced.


Add example project to all new users accounts

When a new user creates an account create a cloned project that is an example for them to start working from. Allow the user to hide this example project.
The reason to create this is to show users what a project can look like and to give them an overview of the system.

This issues reflects the basic script for building the demo project. In addition, it was necessary to make a number of extensions and corrections to the API to support the building of the demo script, Those are covered in a separate issue: #975


Broadcast does not work correctly on the multiple-server configuration

Broadcast send the messages only to the clients connected to the same server.

Although it is a Phoenix configuration issue, I will keep it open as it would be good to mention about it in documentation/guides.

It should broadcast to all channels fine if using the channel broadcast, if it does not then maybe phoenix bug as the pubsub is distributed.  o.O

You are right, it should broadcast. I just never configured Demo Page server to work in a cluster. Now it is working on just one server. It is only matter of configuration, as described here: https://dockyard.com/blog/2016/01/28/running-elixir-and-phoenix-projects-on-a-cluster-of-nodes
I left this issue opened to remember to do it some day.

Clustered exisiting Drab Demo server, all works as expected in 2-node configuration


May I ask when the version will be updated to 0.3.1

Hi, I think maybe you can try my repository https://github.com/doublelam/react-native-free-canvas. it is also based on react-native-skia and has absolutely no over-20-lines performance issue

Hi, I think maybe you can try my repository https://github.com/doublelam/react-native-free-canvas. it is also based on react-native-skia and has absolutely no over-20-lines performance issue

you rock gonna try it, cuz this package no longer works in expo SDK 52 a lot of issues with SafeArea and crashes


Zappa CLI: enabling 'minify' in the config file.

Description
Enables minify setting in the zappa_setings.json that packs to ZIP all the files without any exclusions (even if they are explicitly provided). Use minify with care:

remove all large files from the source
remove all unnecessary libs from your virtual environment (venv)

GitHub Issues
Partial fix (rather workaround) for https://github.com/zappa/Zappa/issues/643 : as fas for now we can't get rid of concurrent exclusion, and this REALLY prevents from using the legitimate modules and submodules / directories called concurrent, this allows the concurrent directories in principle, and is used with care no significant growth of ZIP expected.

Pease make the same pull request on  Zappa2, which is a branch of this repo. Since This repo has been deprecated I will take up maintenance.
PyPi - pip install zappa2

@povesma You need to run make black/make isort on this.
It's failing on the linter.

Old small PR requiring formatting update. Not a bug, closing.


Example?

Is there an an example working application we all can look at?

There are a couple of examples in the readme section


Creates the fcrepo-persistence-api module with a single empty placeho…

…lder interface.
No functional change.  This PR is a preparatory step for designing on the persistence api layer.

JIRA:  https://jira.duraspace.org/browse/FCREPO-3019
Interested parties
@fcrepo4/committers

I approve this very simple step towards the new persistence API, but I would like at least one more reviewer from the @fcrepo4/committers

I will be happy to merge... once this has been linked to a JIRA ticket.

I will be happy to merge... once this has been linked to a JIRA ticket.

Done.


Explain changeset versioning a bit better

Motivation

We want to try and explain what's normal/expected.

Changes

We expand the documentation a bit.

Releases

Choose one:

[x] No release is necessary.
If you're only updating examples/documentation, this is likely what you want.
[ ] All packages that need a release have a changeset.

Paired on this with Wes, merging once CI passes.

Guess we never actually merged this.


how to input the irregular sampled data, such as sparse images

Thank you very much for sharing such interesting work. I am wondering if you are convenient to show me how to input sparse images into your network.  For example, we input the sparse values according to the coordinates of existing points in images.

Dear @cyx669521
We apologize for the late response.
We are coming back from holiday next week and will upload the code to do prediction on irregularly sampled data soon after we arrive.
I must say, however, that from a computational point of view, it is better to use regular grids whenever possible. For instance, if in your application you want to do prediction on certain pixels, it is computationally advantageous to use a mask and set all irrelevant values to zero. The reason for this is that in point-clouds new kernels need to be rendered for each point. If one is able to define the input in a grid, however, this can be alleviated.
Best,
David

Thank you so much~

I am very sorry to push you on this issue. I completely understand what you said here. However, the zero masks must affect the convolution result.

Hi Yusin,
we have added a new PR with the code for irregular data. Please let us know if you have any questions :)
Cheers,
David


ENH: Use a faster t-SNE implementation

Currently, scikit-learn's implementation is used. One of the following would likely perform better in terms of runtime:

https://github.com/DmitryUlyanov/Multicore-TSNE
https://github.com/pavlin-policar/openTSNE
https://github.com/lvdmaaten/bhtsne

The current lines that would need to be changed are:
https://github.com/zoj613/pyloras/blob/b896367dac4e970bb31d2b4cac69fe26f7627a2d/pyloras/_loras.py#L112-L115
https://github.com/zoj613/pyloras/blob/b896367dac4e970bb31d2b4cac69fe26f7627a2d/pyloras/_loras.py#L149

Hi,
I found that out of the three  MultiCore-TSNE from  https://github.com/DmitryUlyanov/Multicore-TSNE is the fastest and relatively simple to use. It can directly replace from sklearn.manifold import TSNE. But there is an install error being faced while using pip to install MultiCore-TSNE.
Requirement already satisfied: numpy in c:\users\username\appdata\local\programs\python\python39\lib\site-packages (from MulticoreTSNE==0.1) (1.21.0)
Requirement already satisfied: cffi in c:\users\username\appdata\local\programs\python\python39\lib\site-packages (from MulticoreTSNE==0.1) (1.14.5)
Requirement already satisfied: pycparser in c:\users\username\appdata\local\programs\python\python39\lib\site-packages (from cffi->MulticoreTSNE==0.1) (2.20)
Building wheels for collected packages: MulticoreTSNE
  Building wheel for MulticoreTSNE (setup.py) ... error
  ERROR: Command errored out with exit status 1:
   command: 'c:\users\username\appdata\local\programs\python\python39\python.exe' -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\username\\AppData\\Local\\Temp\\pip-req-build-kpt7ghlg\\setup.py'"'"'; __file__='"'"'C:\\Users\\username\\AppData\\Local\\Temp\\pip-req-build-kpt7ghlg\\setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' bdist_wheel -d 'C:\Users\username\AppData\Local\Temp\pip-wheel-69r1ew1b'
       cwd: C:\Users\username\AppData\Local\Temp\pip-req-build-kpt7ghlg\
  Complete output (28 lines):
  running bdist_wheel
  running build
  running build_py
  creating build
  creating build\lib.win-amd64-3.9
  creating build\lib.win-amd64-3.9\MulticoreTSNE
  copying MulticoreTSNE\__init__.py -> build\lib.win-amd64-3.9\MulticoreTSNE
  creating build\lib.win-amd64-3.9\MulticoreTSNE\tests
  copying MulticoreTSNE\tests\test_base.py -> build\lib.win-amd64-3.9\MulticoreTSNE\tests
  copying MulticoreTSNE\tests\__init__.py -> build\lib.win-amd64-3.9\MulticoreTSNE\tests
  running egg_info
  creating MulticoreTSNE.egg-info
  writing MulticoreTSNE.egg-info\PKG-INFO
  writing dependency_links to MulticoreTSNE.egg-info\dependency_links.txt
  writing requirements to MulticoreTSNE.egg-info\requires.txt
  writing top-level names to MulticoreTSNE.egg-info\top_level.txt
  writing manifest file 'MulticoreTSNE.egg-info\SOURCES.txt'
  reading manifest file 'MulticoreTSNE.egg-info\SOURCES.txt'
  reading manifest template 'MANIFEST.in'
  writing manifest file 'MulticoreTSNE.egg-info\SOURCES.txt'
  running build_ext
  cmake version 3.20.5

  CMake suite maintained and supported by Kitware (kitware.com/cmake).
  CMake Error: Unknown argument --
  CMake Error: Run 'cmake --help' for all supported options.

  ERROR: Cannot generate Makefile. See above errors.
  ----------------------------------------

In case, this error is negligible during actual implementation. Then I have changed the code accordingly to fit MultiCore-TSNE library.

Hi @santoshdvc , thank you for your interest in this. Do you have benchmarks comparing the performance of the implementations ? Maybe you could use the example in the readme file to time them?
The faster TSNE implementation can be used as an optional package if available in the user's environment so it does not have to be installed with pyloras as part of its dependencies.

Hi,
I found the below benchmarks in the README of Multicore-TSNE and website of openTSNE. OpenTSNE scales over all ad=nd MultiCore TSNE atleast over sklearn-TSNE and bhtsne. I think the benchmarks were given valid.

Also, I found the installation of openTSNE packages is very simple and was achieved without any problems with single command,
pip install opentsne

I will go forward with it's implementation and revert back soon the results.

@santoshdvc  openTSNE sounds like the better choice here. A PR with the proposed change is welcome.

@santoshdvc  Are you still interested in tackling this issue?

@zoj613  Sorry, about it. I am totally engaged in some college activity.

@zoj613 Sorry, about it. I am totally engaged in some college activity.

No worries. I can leave it open for you if you want. It isn't particularly a high priority issue.


ERROR: Sizes of tensors must match except in dimension 1. Expected size 136 but got size 135 for tensor number 1 in the list  --which occurs at dancer.py

!!! Exception during processing !!!
Traceback (most recent call last):
File "/data/comfy-ui/execution.py", line 151, in recursive_execute
output_data, output_ui = get_output_data(obj, input_data_all)
File "/data/comfy-ui/execution.py", line 81, in get_output_data
return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True)
File "/data/comfy-ui/execution.py", line 74, in map_node_over_list
results.append(getattr(obj, func)(**slice_dict(input_data_all, i)))
File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/nodes.py", line 71, in stylize
DiffSynthService().stylize(video_file_path, width, height, frames, fps, output_dir, TARGET_FPS, prompt, neg_prompt,stage1_infer_steps,stage2_infer_steps)
File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth_service.py", line 181, in stylize
runner.run(config_stage_1)
File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/pipelines/stable_diffusion_video.py", line 358, in run
output_video = self.synthesize_video(model_manager, pipe, config["pipeline"]["seed"], smoother, **config["pipeline"]["pipeline_inputs"])
File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/pipelines/stable_diffusion_video.py", line 304, in synthesize_video
output_video = pipe(**pipeline_inputs, smoother=smoother)
File "/data/comfy-ui/venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
return func(*args, **kwargs)
File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/pipelines/stable_diffusion_video.py", line 226, in call
noise_pred_posi = lets_dance_with_long_video(
File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/pipelines/stable_diffusion_video.py", line 43, in lets_dance_with_long_video
hidden_states_batch = lets_dance(
File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/pipelines/dancer.py", line 72, in lets_dance
hidden_states, time_emb, text_emb, res_stack = block(hidden_states, time_emb, text_emb, res_stack)
File "/data/comfy-ui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
return self._call_impl(*args, **kwargs)
File "/data/comfy-ui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
return forward_call(*args, **kwargs)
File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/models/sd_unet.py", line 222, in forward
hidden_states = torch.cat([hidden_states, res_hidden_states], dim=1)
RuntimeError: Sizes of tensors must match except in dimension 1. Expected size 136 but got size 135 for tensor number 1 in the list.

This error is usually caused by the incorrect size of input videos. Please check the number of frames and the resolution.

I got the same issue. Sizes of tensors must match except in dimension 1. Expected size 24 but got size 23 for tensor number 1 in the list.
My input_video.mp4 is 25 fps (converted using ffmpeg). total frames are 349. So, start_frame_id: 0, end_frame_id: 348. num_frames: 349. Width and height are (720, 1280) comes from youtube shorts video.
I saved my cells into a script and run it with:
%cd /content/DiffSynth-Studio

%env PYTHONPATH=/content/DiffSynth-Studio
!python3 test.py

Below is my test.py

config_stage_1_template = {
    "models": {
        "model_list": [
            "models/stable_diffusion/aingdiffusion_v12.safetensors",
            "models/ControlNet/control_v11p_sd15_softedge.pth",
            "models/ControlNet/control_v11f1p_sd15_depth.pth"
        ],
        "textual_inversion_folder": "models/textual_inversion",
        "device": "cuda",
        "lora_alphas": [],
        "controlnet_units": [
            {
                "processor_id": "softedge",
                "model_path": "models/ControlNet/control_v11p_sd15_softedge.pth",
                "scale": 0.5
            },
            {
                "processor_id": "depth",
                "model_path": "models/ControlNet/control_v11f1p_sd15_depth.pth",
                "scale": 0.5
            }
        ]
    },
    "data": {
        "input_frames": {
            "video_file": "/content/input_video.mp4",
            "image_folder": None,
            "height": 1280,
            "width": 720,
            "start_frame_id": 0,
            "end_frame_id": 348
        },
        "controlnet_frames": [
            {
                "video_file": "/content/input_video.mp4",
                "image_folder": None,
                "height": 1280,
                "width": 720,
                "start_frame_id": 0,
                "end_frame_id": 348
            },
            {
                "video_file": "/content/input_video.mp4",
                "image_folder": None,
                "height": 1280,
                "width": 720,
                "start_frame_id": 0,
                "end_frame_id": 348
            }
        ],
        "output_folder": "data/examples/diffutoon_edit/color_video",
        "fps": 25
    },
    "smoother_configs": [
        {
            "processor_type": "FastBlend",
            "config": {}
        }
    ],
    "pipeline": {
        "seed": 0,
        "pipeline_inputs": {
            "prompt": "best quality, perfect anime illustration, orange clothes, night, a girl is dancing, smile, solo, black silk stockings",
            "negative_prompt": "verybadimagenegative_v1.3",
            "cfg_scale": 7.0,
            "clip_skip": 1,
            "denoising_strength": 0.9,
            "num_inference_steps": 20,
            "animatediff_batch_size": 8,
            "animatediff_stride": 4,
            "unet_batch_size": 8,
            "controlnet_batch_size": 8,
            "cross_frame_attention": True,
            "smoother_progress_ids": [-1],
            # The following parameters will be overwritten. You don't need to modify them.
            "input_frames": [],
            "num_frames": 349,
            "width": 720,
            "height": 1280,
            "controlnet_frames": []
        }
    }
}

config_stage_2_template = {
    "models": {
        "model_list": [
            "models/stable_diffusion/aingdiffusion_v12.safetensors",
            "models/AnimateDiff/mm_sd_v15_v2.ckpt",
            "models/ControlNet/control_v11f1e_sd15_tile.pth",
            "models/ControlNet/control_v11p_sd15_lineart.pth"
        ],
        "textual_inversion_folder": "models/textual_inversion",
        "device": "cuda",
        "lora_alphas": [],
        "controlnet_units": [
            {
                "processor_id": "tile",
                "model_path": "models/ControlNet/control_v11f1e_sd15_tile.pth",
                "scale": 0.5
            },
            {
                "processor_id": "lineart",
                "model_path": "models/ControlNet/control_v11p_sd15_lineart.pth",
                "scale": 0.5
            }
        ]
    },
    "data": {
        "input_frames": {
            "video_file": "/content/input_video.mp4",
            "image_folder": None,
            "height": 1280,
            "width": 720,
            "start_frame_id": 0,
            "end_frame_id": 348
        },
        "controlnet_frames": [
            {
                "video_file": "/content/input_video.mp4",
                "image_folder": None,
                "height": 1280,
                "width": 720,
                "start_frame_id": 0,
                "end_frame_id": 348
            },
            {
                "video_file": "/content/input_video.mp4",
                "image_folder": None,
                "height": 1280,
                "width": 720,
                "start_frame_id": 0,
                "end_frame_id": 348
            }
        ],
        "output_folder": "/content/output",
        "fps": 25
    },
    "pipeline": {
        "seed": 0,
        "pipeline_inputs": {
            "prompt": "best quality, perfect anime illustration, light, a girl is dancing, smile, solo",
            "negative_prompt": "verybadimagenegative_v1.3",
            "cfg_scale": 7.0,
            "clip_skip": 2,
            "denoising_strength": 1.0,
            "num_inference_steps": 10,
            "animatediff_batch_size": 16,
            "animatediff_stride": 8,
            "unet_batch_size": 1,
            "controlnet_batch_size": 1,
            "cross_frame_attention": False,
            # The following parameters will be overwritten. You don't need to modify them.
            "input_frames": [],
            "num_frames": 349,
            "width": 720,
            "height": 1280,
            "controlnet_frames": []
        }
    }
}
from diffsynth import SDVideoPipelineRunner

config = config_stage_2_template.copy()
config["data"]["input_frames"] = {
    "video_file": "/content/input_video.mp4",
    "image_folder": None,
    "height": 1280,
    "width": 720,
    "start_frame_id": 0,
    "end_frame_id": 348
}
config["data"]["controlnet_frames"] = [config["data"]["input_frames"], config["data"]["input_frames"]]
config["data"]["output_folder"] = "/content/toon_video"
config["data"]["fps"] = 25

runner = SDVideoPipelineRunner()
runner.run(config)

I got this, can you help me out. Thanks:
/content/DiffSynth-Studio
env: PYTHONPATH=/content/DiffSynth-Studio
/usr/lib/python3.10/subprocess.py:1796: RuntimeWarning: os.fork() was called. os.fork() is incompatible with multithreaded code, and JAX is multithreaded, so this will likely lead to a deadlock.
  self.pid = _posixsubprocess.fork_exec(
100% 348/348 [00:01<00:00, 187.44it/s]
100% 348/348 [01:15<00:00,  4.60it/s]
  0% 0/10 [00:08<?, ?it/s]
Traceback (most recent call last):
  File "/content/DiffSynth-Studio/test.py", line 180, in <module>
    runner.run(config)
  File "/content/DiffSynth-Studio/diffsynth/pipelines/stable_diffusion_video.py", line 349, in run
    output_video = self.synthesize_video(model_manager, pipe, config["pipeline"]["seed"], smoother, **config["pipeline"]["pipeline_inputs"])
  File "/content/DiffSynth-Studio/diffsynth/pipelines/stable_diffusion_video.py", line 299, in synthesize_video
    output_video = pipe(**pipeline_inputs, smoother=smoother)
  File "/usr/local/lib/python3.10/dist-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
  File "/content/DiffSynth-Studio/diffsynth/pipelines/stable_diffusion_video.py", line 221, in __call__
    noise_pred_posi = lets_dance_with_long_video(
  File "/content/DiffSynth-Studio/diffsynth/pipelines/stable_diffusion_video.py", line 38, in lets_dance_with_long_video
    hidden_states_batch = lets_dance(
  File "/content/DiffSynth-Studio/diffsynth/pipelines/dancer.py", line 72, in lets_dance
    hidden_states, time_emb, text_emb, res_stack = block(hidden_states, time_emb, text_emb, res_stack)
  File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/content/DiffSynth-Studio/diffsynth/models/sd_unet.py", line 222, in forward
    hidden_states = torch.cat([hidden_states, res_hidden_states], dim=1)
RuntimeError: Sizes of tensors must match except in dimension 1. Expected size 24 but got size 23 for tensor number 1 in the list.

!!! Exception during processing !!! Traceback (most recent call last): File "/data/comfy-ui/execution.py", line 151, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "/data/comfy-ui/execution.py", line 81, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "/data/comfy-ui/execution.py", line 74, in map_node_over_list results.append(getattr(obj, func)(**slice_dict(input_data_all, i))) File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/nodes.py", line 71, in stylize DiffSynthService().stylize(video_file_path, width, height, frames, fps, output_dir, TARGET_FPS, prompt, neg_prompt,stage1_infer_steps,stage2_infer_steps) File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth_service.py", line 181, in stylize runner.run(config_stage_1) File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/pipelines/stable_diffusion_video.py", line 358, in run output_video = self.synthesize_video(model_manager, pipe, config["pipeline"]["seed"], smoother, **config["pipeline"]["pipeline_inputs"]) File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/pipelines/stable_diffusion_video.py", line 304, in synthesize_video output_video = pipe(**pipeline_inputs, smoother=smoother) File "/data/comfy-ui/venv/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context return func(*args, **kwargs) File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/pipelines/stable_diffusion_video.py", line 226, in call noise_pred_posi = lets_dance_with_long_video( File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/pipelines/stable_diffusion_video.py", line 43, in lets_dance_with_long_video hidden_states_batch = lets_dance( File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/pipelines/dancer.py", line 72, in lets_dance hidden_states, time_emb, text_emb, res_stack = block(hidden_states, time_emb, text_emb, res_stack) File "/data/comfy-ui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl return self._call_impl(*args, **kwargs) File "/data/comfy-ui/venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl return forward_call(*args, **kwargs) File "/data/comfy-ui/custom_nodes/comfyui-cartoon-stylization/diffsynth/models/sd_unet.py", line 222, in forward hidden_states = torch.cat([hidden_states, res_hidden_states], dim=1) RuntimeError: Sizes of tensors must match except in dimension 1. Expected size 136 but got size 135 for tensor number 1 in the list.

I spent a good chunk of time this weekend trying to track down the source of this issue, and I think I finally figured it out.
 This basically just divides the size by 2 a bunch of times, then multiplies it back up again.
The underlying issue with the mismatching shape (at least for me) came from using an input image that was 1920x1080, which I'm guessing you are as well.
Under the hood, both dims are divided by 8 - giving us a tensor of 240 x 135. Note the 135.
Now, if you divide 135 by 2, you get 67.5, which hasa decimal point, which means we wind up losing precision when down/upscaling, and it gets rounded up to 68. So then when that gets upscaled, we now have a tensor with a shape of 136 instead of 135.
Fun, isn't it?
This happens in the final upsample block in the unet (the one with 640 channels).
My fix was just to use the nearest "SDXL" resolution, which I suspect are all specific dimensions that can be subdivided without this issue.

@d8ahazard
I tried with 1920 x 1088 and both are divisible by 16
1920/16 = 120
1088/16 = 68
Still getting this error.
So for me only 1024 x 576 works.
1024/16 = 64
576/16 = 36
Is there any other higher resolution (other than 1024 x 576) that I can try?


Execute UEFI Shell Command gathers only 1 sec of output

Device
All
RTE version
All
OSFV version
Develop
Affected component(s) or functionality
OSFV Tests
Brief summary
Execute UEFI Shell Command gathers only 1 sec of output
How reproducible
100%
How to reproduce
Use Execute UEFI Shell Command and run with a command that outputs logs for longer than 1 sec.
Good example is to run `reset' command and wait for DUT to reboot and wait for prompt.
Expected behavior
Use Execute UEFI Shell Command and get full output up untill next prompt is displayed.
For example after reboot command the output should not be empty.
Actual behavior
Gathers only 1 second of the output.
Link to screenshots or logs

In this scenario output is empty, but it should contain everything up until prompt is displayed again.
Additional context
There is also an issue where Set DUT Response Timeout doesn't affect this command. This might need looking into.
Solutions you've tried
No response

For extra context, this is the current implementation on develop
https://github.com/Dasharo/open-source-firmware-validation/blob/e306abc385cda02aeeb638e923ffbcce432e4a63/lib/terminal.robot#L164-L175
with hard-coded Sleep 1s and Read From Terminal instead of Read Until Prompt.


Getting error (Bad Request (400)) Heroku Custom domain

Hi,
I am getting error like Bad Request (400) when I connect the custom domain to my herokuapp ..
Even I add the allowed hosts in settings.py file  but issue still not resolved..
Kindly fix this issue..
Please find the attachment

@justsushanth Please add your domain to ALLOWED_HOSTS env variable Heroku->Settings->Reveal config vars (use space as a separator) and then restart all dynos.

Resolved ,thank you...


Refactoring to expose method to get context queries with exclusions

All looks good to me! I think there a couple minor unrelated formatting / code changes though?

All looks good to me! I think there a couple minor unrelated formatting / code changes though?

Agreed ... I think the formatting changes look good (they basically bring the formatting of the FacetProcessor.java file in line with upstream). But the changes to the other two files are unrelated -- could those be separated into a different PR? They just look like compile fixes (presumably related to recently syncing with upstream branch_9x?).

Reverted the other changes and moved those to a new PR here: https://github.com/cowpaths/fullstory-solr/pull/71, those were just additional leftover issues from changes we have on our fork impacted by the merge from upstream.


prisma2 generate fails in Heroku build

I am attempting to run Prisma inside of Heroku 18 node.js.  The following are from my package.json:
  "engines": {
    "node": "12.14.1"
  },
  "scripts": {
    "postinstall": "prisma2 generate"
  },
  "dependencies": {
    "prisma2": "2.0.0-preview021"
  }

I get the following error during installation:
Error: Error: Command failed with ENOENT: /tmp/build_beae1b0150b0593ec3b0251a339290fe/node_modules/prisma2/query-engine-debian-openssl-1.1.x cli --dmmf
spawn /tmp/build_beae1b0150b0593ec3b0251a339290fe/node_modules/prisma2/query-engine-debian-openssl-1.1.x ENOENT

I just confirmed that this issue occurs with the official apollo example repo when doing a vanilla Heroku deploy (i.e. git push heroku master):
https://github.com/prisma/prisma-examples/tree/prisma2/typescript/graphql-apollo-server

Additionally to improving this situation when using Prisma on Heroku, I suggest to generally improve the error handling in this scenario as described here: https://github.com/prisma/prisma-client-js/issues/466

I was able to get the build to succeed by setting the node version to 12.0.0


inform screen readers of externals links that open in a new tabs

small improvement saw in https://github.com/shuding/nextra/issues/1010

Thanks! I didn't know about this but it's great to know it now


Gitlab support

Hello,
I really like your project, have been using it for my PRs as well. One question though. Do you have any plans on releasing the agent for a Gitlab repo?
Regards

Yes, work in progress: #24

Merged https://github.com/Codium-ai/pr-agent/pull/24


Workbook Document Properties Inconsistant

On this page about Workbooks, it says this:

Workbook objects have access to the Office file metadata, which is known as the document properties. The Workbook object's properties property is a DocumentProperties object containing these metadata values.

The first link has a page about document properties and says this:

Automatically updated properties - These properties include both file system properties (for example, file size or the dates when a file was created or last changed) and statistics that are maintained for you by Microsoft 365 programs (for example, the number of words or characters in a document). You cannot specify or change the automatically updated properties.

You can use the automatically updated properties to identify or find files. For example, you can search for all files created after August 3, 2015, or for all files that were last changed yesterday.

The second link lists all the supported properties in the API.  The properties do not include everything mentioned in the first link.  The property I need the most is the date when a file was last changed, but it is not included in the API.
I would hope a solution would include adding the missing properties to the API

Hi @duane-j-wagner,
Thanks for raising this issue. First, please request the "last changed" API through Microsoft 365 Developer Platform Tech Community. That helps us prioritize future investments.
Second, I'll correct the article to indicate that DocumentProperties does not include all the properties of the Excel file metadata.
It might be worthwhile asking on Stack Overflow if there's a workaround for the missing property. Maybe there's a way to get the file properties through a different JS library.


Update the security header Lambda's runtime to Node 18

🗣 Description
This pull request updates the security header Lambda's runtime from Node 16 to Node 18.
💭 Motivation and context
We recently received an email from AWS Lambda stating that they are dropping support for Node 16 in mid-2024.  Now that we are using version 4.9 of the Terraform AWS provider, we can upgrade our Lambda runtime to Node 18.  When we move to the latest version of the Terraform AWS provider, we will be able to upgrade the runtime to at least Node 20.
🧪 Testing
I tested this in the most brütal fashion - by deploying it to production.
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] All relevant type-of-change labels have been added.
[x] I have read the CONTRIBUTING document.
[x] These code changes follow cisagov code standards.
[x] All new and existing tests pass.

@dav3r - I have a strong memory of you creating something that needed this sort of Lambda@Edge sauce too, but I couldn't find it.  If you have such Terraform out there, and it's running Node 16, then you should upgrade it similarly.

Aargh!  This change has broken the rules website.  If anyone knows why that is so, please let me know.

Hi Team, I am noticing the following issues, please ensure that these are resolved: 1) AWS CloudWatch Log Group is missing retention which can cause losing important event info: @ terraform/bod_vpc_flow_logs.tf line 43, terraform/cyhy_vpc_flow_logs.tf line 43, terraform/mgmt_vpc_flow_logs.tf line 43, and terraform/nvdsync_failure_alarms.tf line 2. 2) AWS Lambda tracing is not enabled: @ terraform/adi_lambda.tf line 113, terraform/bod_lambdas.tf line 58, and terraform/fdi_lambda.tf line 114. 3) Ensure that your AWS Cloudfront distributions have the logging feature enabled: @ terraform_egress_pub/cloudfront.tf. 4) AWS Lambda does not use KMS CMK key to protect environment variables: @ terraform/adi_lambda.tf line 129 and terraform/fdi_lambda.tf line 130. Thanks

Hi Team, I am noticing the following issues, please ensure that these are resolved:

AWS CloudWatch Log Group is missing retention which can cause losing important event info: @ terraform/bod_vpc_flow_logs.tf line 43, terraform/cyhy_vpc_flow_logs.tf line 43, terraform/mgmt_vpc_flow_logs.tf line 43, and terraform/nvdsync_failure_alarms.tf line 2.
AWS Lambda tracing is not enabled: @ terraform/adi_lambda.tf line 113, terraform/bod_lambdas.tf line 58, and terraform/fdi_lambda.tf line 114.
Ensure that your AWS Cloudfront distributions have the logging feature enabled: @ terraform_egress_pub/cloudfront.tf.
AWS Lambda does not use KMS CMK key to protect environment variables: @ terraform/adi_lambda.tf line 129 and terraform/fdi_lambda.tf line 130.

Thanks

@dv4harr10 - None of these points has anything to do with the changes in this PR, but we still want to capture them.  Can you create an issue in this repo for each of these four points?

@dav3r - I have a strong memory of you creating something that needed this sort of Lambda@Edge sauce too, but I couldn't find it. If you have such Terraform out there, and it's running Node 16, then you should upgrade it similarly.

I think you are probably talking about https://github.com/cisagov/publish-egress-ip-terraform/pull/6, which stalled out due to lack of interest from the intended beneficiaries, hence it was never merged and deployed to Production.

@cisagov/team-ois - Aargh! This change has broken the rules website. If anyone knows why that is so, please let me know. I think the problem is that the Cloudfront distribution is unable to read the objects in the rules bucket, but I don't know why that would be the case. 😭

@mcdonnnj created https://github.com/cisagov/cyhy_amis/pull/742 to address the issues you encountered.


Fix Python tests on MacOS platform

This might be low hanging fruit at this point.

So, this is no low hanging fruit at all.
There is a problem with the native Python sqlite code when our Go binary is used.
It is hard to reason why about, why this exactly happens as our Go code brings its own Sqlite connector.
The problem in Python is related to a pointer being free'd twice. We notice the following stack trace:
* thread #1, stop reason = ESR_EC_DABORT_EL0 (fault address: 0x0)
 * frame #0: 0x0000000103c7225c libpython3.12.dylib`sqlite3DbNNFreeNN + 152
  frame #1: 0x0000000103c720ac libpython3.12.dylib`sqlite3VdbeClearObject + 76
  frame #2: 0x0000000103c342c8 libpython3.12.dylib`sqlite3VdbeDelete + 40
  frame #3: 0x0000000103c3bb40 libpython3.12.dylib`sqlite3_finalize + 160
  frame #4: 0x000000010404a044 libpython3.12.dylib`stmt_dealloc + 52
  frame #5: 0x00000001040927c4 libpython3.12.dylib`lru_list_elem_dealloc + 184
  frame #6: 0x000000010387bdb0 libpython3.12.dylib`lru_cache_tp_clear + 420
  frame #7: 0x000000010387bbbc libpython3.12.dylib`lru_cache_dealloc + 80
  frame #8: 0x0000000104042548 libpython3.12.dylib`connection_clear + 52
  frame #9: 0x000000010373104c libpython3.12.dylib`gc_collect_main.llvm.7237410993583088352 + 3628
  frame #10: 0x000000010386c1b4 libpython3.12.dylib`finalize_modules.llvm.8252630758059695344 + 4336
  frame #11: 0x0000000103869754 libpython3.12.dylib`Py_FinalizeEx + 244
  frame #12: 0x00000001038e2470 libpython3.12.dylib`Py_Exit + 20
  frame #13: 0x00000001038e2450 libpython3.12.dylib`handle_system_exit + 32
  frame #14: 0x00000001038e2134 libpython3.12.dylib`_PyErr_PrintEx.llvm.5721313084846900902 + 52
  frame #15: 0x0000000103889a3c libpython3.12.dylib`_PyRun_SimpleFileObject + 464
  frame #16: 0x00000001038e42b0 libpython3.12.dylib`_PyRun_AnyFileObject + 80
  frame #17: 0x00000001038e2e94 libpython3.12.dylib`pymain_run_file_obj + 164
  frame #18: 0x00000001038e2a6c libpython3.12.dylib`pymain_run_file + 72
  frame #19: 0x00000001038e0d40 libpython3.12.dylib`Py_RunMain + 1124
  frame #20: 0x000000010385b8d0 libpython3.12.dylib`pymain_main + 456
  frame #21: 0x000000010385b6fc libpython3.12.dylib`Py_BytesMain + 40
  frame #22: 0x00000001923c7154 dyld`start + 2476

In https://github.com/mlflow/mlflow-go/pull/90 and https://github.com/mlflow/mlflow-go/pull/95
we tried to re-enable the Mac tests, with no avail. (Technically the Mac tests were always running but with continue-on-error: true)
Some trains of thought:

uv run has a impact here and we want to run pytest from the venv. This turned out to be unrelated, the difference with running them using .venv/bin/pytest is that we saw the 5405 Segmentation fault: 11 output.
Newer Python versions don't have the problem. This is also not the case, we saw this problem with 3.10, 3.11, 3.12,...
The problem only happens when we override the TrackingStore. Different combinations or disabling some of our override in conftest.py did not resolve the problem.
When taking over the GitHub Action runner using tmate we noticed that the exact same test command no longer had the issue. The current thinking is that the problem only really happens the first time after a version of Python was installed on the machine. This seemed to match the behaviour we had when running the tests locally. It only really is a problem once.
When we tried running the vanilla mlflow tests for Mac, these always worked. So the problem must be related to the combination of Python sqlite and our Go sqlite.
Before we noticed the Segmentation fault, we thought there may have been a problem with pytest itself. This appears to be not the case after we followed the pointers in https://github.com/pytest-dev/pytest/discussions/13049.

To anyone reading this, feel free to further investigate this and send us a PR with a fix.
We would very much want to catch problems on Mac during CI. Unfortunately, at the time of writing we still need to ignore these.
This is no low-hanging fruit.
There’s an issue with the native Python SQLite code when our Go binary is used. It’s difficult to pinpoint why this is happening, as our Go code utilizes its own SQLite connector.
The problem in Python stems from a pointer being freed twice. We observe the following stack trace:
* thread #1, stop reason = ESR_EC_DABORT_EL0 (fault address: 0x0)
 * frame #0: 0x0000000103c7225c libpython3.12.dylib`sqlite3DbNNFreeNN + 152
  frame #1: 0x0000000103c720ac libpython3.12.dylib`sqlite3VdbeClearObject + 76
  frame #2: 0x0000000103c342c8 libpython3.12.dylib`sqlite3VdbeDelete + 40
  frame #3: 0x0000000103c3bb40 libpython3.12.dylib`sqlite3_finalize + 160
  frame #4: 0x000000010404a044 libpython3.12.dylib`stmt_dealloc + 52
  frame #5: 0x00000001040927c4 libpython3.12.dylib`lru_list_elem_dealloc + 184
  frame #6: 0x000000010387bdb0 libpython3.12.dylib`lru_cache_tp_clear + 420
  frame #7: 0x000000010387bbbc libpython3.12.dylib`lru_cache_dealloc + 80
  frame #8: 0x0000000104042548 libpython3.12.dylib`connection_clear + 52
  frame #9: 0x000000010373104c libpython3.12.dylib`gc_collect_main.llvm.7237410993583088352 + 3628
  frame #10: 0x000000010386c1b4 libpython3.12.dylib`finalize_modules.llvm.8252630758059695344 + 4336
  frame #11: 0x0000000103869754 libpython3.12.dylib`Py_FinalizeEx + 244
  frame #12: 0x00000001038e2470 libpython3.12.dylib`Py_Exit + 20
  frame #13: 0x00000001038e2450 libpython3.12.dylib`handle_system_exit + 32
  frame #14: 0x00000001038e2134 libpython3.12.dylib`_PyErr_PrintEx.llvm.5721313084846900902 + 52
  frame #15: 0x0000000103889a3c libpython3.12.dylib`_PyRun_SimpleFileObject + 464
  frame #16: 0x00000001038e42b0 libpython3.12.dylib`_PyRun_AnyFileObject + 80
  frame #17: 0x00000001038e2e94 libpython3.12.dylib`pymain_run_file_obj + 164
  frame #18: 0x00000001038e2a6c libpython3.12.dylib`pymain_run_file + 72
  frame #19: 0x00000001038e0d40 libpython3.12.dylib`Py_RunMain + 1124
  frame #20: 0x000000010385b8d0 libpython3.12.dylib`pymain_main + 456
  frame #21: 0x000000010385b6fc libpython3.12.dylib`Py_BytesMain + 40
  frame #22: 0x00000001923c7154 dyld`start + 2476

In this PR and this PR, we attempted to re-enable the Mac tests, but without success. (Technically, the Mac tests have always been running with continue-on-error: true.)
Here are some thoughts:

uv run seems to impact this, and we want to run pytest from the venv. However, this turned out to be unrelated; running tests using .venv/bin/pytest yielded the 5405 Segmentation fault: 11 output.
Newer Python versions do not exhibit this issue. However, this was not the case, as we encountered this problem with 3.10, 3.11, 3.12, and others.
The issue only arises when we override the TrackingStore. Various combinations or disabling some overrides in conftest.py did not resolve the problem.
When we took over the GitHub Action runner using tmate, we noticed that the exact same test command no longer had the issue. It appears the problem only occurs the first time after a version of Python is installed on the machine, matching the behavior we observed when running the tests locally. It seems to be a one-time issue.
When we ran the vanilla MLflow tests for Mac, they always succeeded. Therefore, the problem must be related to the combination of Python SQLite and our Go SQLite.
Before noticing the Segmentation fault, we suspected an issue with pytest itself. However, after following the insights in this discussion, this appears not to be the case.

To anyone reading this, please feel free to investigate further and submit a PR with a fix. We would greatly appreciate catching issues on Mac during CI. Unfortunately, at this time, we still need to ignore these failures.


fix: expose notification params

- What I did

Expose the following notifications params - priority, strategy, notifier, latestN and notificationExpiry.

- How I did it
- How to verify it
- Description for the changelog

The Changes are completed, but pending on writing on functional and end2end tests. Since, fetching notifications via the monitor is not feasible, we have introduced notify fetch with which we can fetch a notification using the notification-id. Waiting the notify fetch changes for writing functional and e2e tests.

@sitaram-kalluri Looks like there are useful changes in this PR. Can you bring it up to date with trunk & resolve conflicts please? Let's get it tested, reviewed, merged and published

Added dependency overrides to consume the changes in https://github.com/atsign-foundation/at_tools/pull/290. Will update with the hosted version once the changes are published.

Ran dart format and committed those changes so that the format check passes.

Hi @sitaram-kalluri  ... not really sure what is going on here; your notification expiry test is failing in functional test; but I copied it into end2end tests and it works fine there against the various @ce2e atServers. It also works fine when I run end to end tests locally against atServers running from latest atServer trunk; and also works fine when I run them locally against atServers which are running version 3.0.28 (current prod)

@sitaram-kalluri further to my last comment - I added a print to the test so it prints out what it fetches from the server - here's what we get:
Fetched notification AtNotification{id: 575bd0bb-760d-46d4-b4aa-cc985b3f5766, key: , from: , to: , epochMillis: 0, value: null, operation: null, status: NotificationStatus.expired, expiresAt: null}

So .. it has expired? Makes no sense!  Especially when, as I mentioned, everything works fine when running end to end tests.
Hope you have more luck than I did in tracking it down

Progress: added some more print statements; here's what the output is:
Testing notification expiry - test run #0
  notificationResult: id: 0d29a84a-913a-4bf5-bebd-b9374cc6cef4 status: NotificationStatusEnum.undelivered
  notificationResult.atClientException: Exception: @alice🛠 is not authorized to send notification as @bob🛠
  Fetched notification AtNotification{id: 0d29a84a-913a-4bf5-bebd-b9374cc6cef4, key: , from: , to: , epochMillis: 0, value: null, operation: null, status: NotificationStatus.expired, expiresAt: null}
  Null check operator used on a null value
  test/atclient_notify_test.dart 217:48  main.<fn>

What I don't understand really is that the "is not authorized to send notification" message is only added in your server PR https://github.com/atsign-foundation/at_server/pull/1257 ... which has not yet been merged. So I guess every at_server check run updates the docker image that the client functional tests use?

OK two things:

Checks are passing now, after I changed that test to explicitly call atClientManager.setCurrentAtSign. Problem here is that the current atSign is changed by another test, and setUpAll only runs ONCE, not for every test => this needs to be fixed
Second issue - why is the "is not authorized" message appearing ... is a mystery to me. I can't figure out how that message can have made its way into the dev_env docker image, since that branch has not been merged to trunk. Any ideas?

OK two things:

Checks are passing now, after I changed that test to explicitly call atClientManager.setCurrentAtSign. Problem here is that the current atSign is changed by another test, and setUpAll only runs ONCE, not for every test => this needs to be fixed
Second issue - why is the "is not authorized" message appearing ... is a mystery to me. I can't figure out how that message can have made its way into the dev_env docker image, since the server PR fix: Check if sharedBy atSign is authorized to send notifications at_server#1257 which added that code has not yet been approved or merged to trunk. Any ideas?

On # 2, The changes of validating if atSign is authorized to send notifications are done in the at_client side and are already merged to trunk in the following https://github.com/atsign-foundation/at_client_sdk/pull/961. Perhaps the message might be from the at_client SDK only. Not from the server.

That would make sense indeed.


[HOLD for payment 2023-08-01] [$1000] dev:  Inconsistency in showing task description when the number of rows increases

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create a task
Click description
Text: 1 to 7 each number each row => save
Observe that description only sees a part that can't be scrolled
Click description, clear previous description
Text long message => save
Observe that 3 dots are added to the description and can be scrolled

Expected Result:
There must be consistency in showing description when the number of rows increases
Actual Result:
How to show description is different when the number of rows increases
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: DEV
Reproducible in staging?:  dev only
Reproducible in production?: dev only
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/df976d2b-7189-49f5-9d40-53291b34ea44
Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688800884991609
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0116467439890d0404
Upwork Job ID:<PHONE_NUMBER>040221184
Last Price Increase: 2023-07-12

Looping in @shawnborton. I don't see this as a real value issue as I don't see we'll be adding numeric list only for the description.
But one minor thing that's off is if we have a large description, we show ellipses, but the content is scrollable. I think that's intentional? But I am not sure. If that's the case, we should just close this one out.

Hmm this seems very strange. cc @jasperhuangg @thienlnam I forget where we landed with truncating the description row, but now I am wondering if we should never truncate description at all.

I don't remember either, but I thought we standardized on like 3 rows or something. I agree we could not truncate so that you could view the entire description without having to push to page to edit

Proposal
Please re-state the problem that we are trying to solve in this issue.
Unable to view full task's description when the task is completed
What is the root cause of that problem?
We always set the maximum number of lines for the description to be 3, regardless of whether the task is completed or not.
https://github.com/Expensify/App/blob/8923cb0c558b8e9e57a64cf01292c8434e6a4b6f/src/components/ReportActionItem/TaskView.js#L108
What changes do you think we should make in order to solve the problem?
Add a condition to check if the task is completed. If it is completed, we won't limit the maximum number of lines by using Number.MAX_VALUE.
So the users can view full description
Note that we must set some value for numberOfLinesTitle attribute, otherwise it will be set to 1 by default

            <MenuItemWithTopDescription
                description={props.translate('task.description')}
                title={props.report.description || ''}
                onPress={() => Navigation.navigate(ROUTES.getTaskReportDescriptionRoute(props.report.reportID))}
                shouldShowRightIcon={isOpen}
                disabled={!isOpen}
                wrapperStyle={[styles.pv2]}
                numberOfLinesTitle={isCompleted ? Number.MAX_VALUE : 3}
                shouldGreyOutWhenDisabled={false}
            />

What alternative solutions did you explore? (Optional)
N/A

@shawnborton / @mananjadhav is the steer here that we are still going to fix this?

Both the proposals are identical for the revised expected results. But @namhihi237's proposal posted the solution first and hence I think we'll use theirs.
While I tag an internal engineer by reviewing the proposals, @shawnborton and () I think we should set a limit for the description to atleast a few 100 characters. This would definitely hit some limit on the API and then be reported as a bug.
🎀 👀 🎀 C+ reviewed.

@shawnborton @stitesExpensify can you address @mananjadhav 's comment here when you have a mo, thanks!

I think we can deal with the limit when we hit it, we don't need to fix that right now.
@namhihi237 proposal looks good to me!

@spcheema Apologies for not responding sooner.  For me the most important change was to remove the numberOfLines.  We do work out the kinks in the PR.  Based on what I saw in the history, etc. @namhihi237 pointed that out first.

So it acceptable that C++ assume things you will do. That's strange and weird.
Please test the changes locally before making a decision.

I am not keen on modifying the styles.preWrap. I should've clarified. But please have patience for the team to respond before jumping to conclusions, in case you need any clarifications
cc - @stitesExpensify

This is more like a feature request, hence we don't have a tagged PR.
But I think we should a regression test here, so that we don't end up adding length restriction on the desscription.

Open FAB, click on Assign Task
Create a task with a long description (about more than 2-3 paragraphs)
Open task detail and verify that can view the whole description without any ellipses.

@laurenreidexpensify Please note this PR had a regression, hence the payout will be deducted an there is no timeline bonus.

Payment Summary:

External issue reporter @namhihi237 $250 paid in Upwork
Contributor that fixed the issue @namhihi237 $1000 paid in Upwork
Contributor+ that helped on the issue and/or PR $1000 Eligible for manual request @mananjadhav

Please note this PR had a regression, hence the payout will be deducted and there is no timeline bonus.

@laurenreidexpensify There would be a deduction of 500 in this PR. The actual payout for me and @namhihi237 is $500.

Yes agreed. Mind updating your summary @laurenreidexpensify?

Updated Payment Summary:

External issue reporter @namhihi237 $250 paid in Upwork
Contributor that fixed the issue @namhihi237 $500 paid in Upwork (Expensify has requested $500 refund for overpayment)
Contributor+ that helped on the issue and/or PR $500 Eligible for manual request @mananjadhav

Reviewed details for @mananjadhav. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.


UsePagination doesn't work with UseSelection

Describe the bug
Fetching data paginated with first and after works fine, even if you include related objects, but if you use last and before, you'll get an error until you remove all related models.
To Reproduce

Get to the last page of pagination, so your endCursor and startCursor are the same.
Fetch last: 2 and before: endCursor
No error
Now add a related model fetching to the query and run it
Error:

Unable to cast object of type 'Microsoft.EntityFrameworkCore.Query.SqlExpressions.SqlUnaryExpression' to type 'System.Linq.Expressions.ConstantExpression'."
Additional context
Tested on 10.5.2

@JTinkers  What .Net and .Ef core version you use?

@JTinkers What .Net and .Ef core version you use? And whats your DB provider?

`
netcoreapp3.1

all
runtime; build; native; contentfiles; analyzers; buildtransitive

`

Can be possible reason of issue.. Translation of linq to sql..  can you test with .net5 and ifcore5 ?

@JTinkers  do you have a stacktrace to this exception?

@PascalSenn  i think he paste this in slack before under this image...
https://hotchocolategraphql.slack.com/files/U014Q4K8PPF/F0198PZ5UBW/image.png

@JTinkers Can be possible reason of issue.. Translation of linq to sql.. can you test with .net5 and ifcore5 ? Can be also problem of Db provider you can do equal test using SQLLite (in-memory) with version 5..
There are few known bugs in .net /efcore 3.1 in translation between linq and sql..
Equal solved problem is searchable under slack: https://hotchocolategraphql.slack.com/archives/CD9TNKT8T/p1595423242213200
or https://hotchocolategraphql.slack.com/archives/CD9TNKT8T/p1595429723226700?thread_ts=1595423242.213200&cid=CD9TNKT8T
solved by updating to new .net...

I remember having issue and upgrading to .NET Core 5 did work - but I can't use any other libraries with it.

@JTinkers do you have a stacktrace to this exception?
Yes, @damikun is right - I've posted the stacktrace in that image.

You can try update only Efcore to net5 and efcore tools... not entire... because stack-trace looks same like from slack post where the problem was solved by update... It is possible that PostgreSQL can have problem vith .net5 you will see :)

You can try update only Efcore to net5 and efcore tools... not entire... because stack-trace looks same like from slack post where the problem was solved by update... It is possible that PostgreSQL can have problem vith .net5 you will see :)

FluentValidation requires specific versions of EFCore and .NET, and it doesn't support 5.

You can try update only Efcore to net5 and efcore tools... not entire... because stack-trace looks same like from slack post where the problem was solved by update... It is possible that PostgreSQL can have problem vith .net5 you will see :)

FluentValidation requires specific versions of EFCore and .NET, and it doesn't support 5.
Can you reproduce my error though? Perhaps Postgres is at fault fault - in which case I'll try to print raw SQL - but it doesn't make sense why after, before and first works but last doesn't if you add relations.

If you use after and before IQueriable builder usually adds some trimming to expression.. And when it gets translated to SQL it must be translated by DB provider to some SQL expression like Limit -1 because you are going negative way and this can be different from one SQL DB  to another.. And this can be the problem...
BTW you can use the FluentValidation in case you build yourself current master.. Integration is there just waiting for Net5  Prev.8 to be release that will be in short time..
Changes to adopt .net5...
https://github.com/FluentValidation/FluentValidation/pull/1474/commits/421e23db93c75b2f32a23fe5c31fa962e3c913a5

@damikun thanks for extensive research.
I would rather wait for .NET 5 releases of FluentValidation and NpgSql - for now I've just put a workaround in place.

UseProjection does work with pagination if it applied on the same level as UsePagination
Nested pagination will be worked on after v12
#4424


[BACKLOG-21798] - moving mqtt plugin from big-data-plugin

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dsurefire.runOrder=alphabetical -B -fn -f 'pom.xml' -pl 'plugins/streaming/impls' -P '!assemblies' -amd clean install && mvn -B -f 'pom.xml' -pl 'plugins/streaming/impls' -P '!assemblies' -amd site

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins/streaming/impls' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/streaming/assemblies/feature/pom.xml
  plugins/streaming/impls/mqtt/README.md
  plugins/streaming/impls/mqtt/pom.xml
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTClientBuilder.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTConstants.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTConsumer.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTConsumerData.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTConsumerDialog.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTConsumerMeta.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTProducer.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTProducerData.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTProducerDialog.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTProducerMeta.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MQTTStreamSource.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MqttDialogOptionsLayout.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MqttDialogSecurityLayout.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/MqttOption.java
  plugins/streaming/impls/mqtt/src/main/java/org/pentaho/di/trans/step/mqtt/SslConfigHelper.java
  plugins/streaming/impls/mqtt/src/main/resources/MQTTConsumer.svg
  plugins/streaming/impls/mqtt/src/main/resources/MQTTProducer.svg
  plugins/streaming/impls/mqtt/src/main/resources/OSGI-INF/blueprint/blueprint.xml
  plugins/streaming/impls/mqtt/src/main/resources/org/pentaho/di/trans/step/mqtt/messages/messages_en_US.properties
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTClientBuilderTest.java
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTConsumerMetaTest.java
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTConsumerTest.java
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTProducerMetaTest.java
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTProducerTest.java
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MQTTStreamSourceTest.java
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/MqttOptionTest.java
  plugins/streaming/impls/mqtt/src/test/java/org/pentaho/di/trans/step/mqtt/SslConfigHelperTest.java
  plugins/streaming/impls/mqtt/src/test/resources/ConsumeRows.ktr
  plugins/streaming/impls/mqtt/src/test/resources/ConsumeRowsSubtrans.ktr
  plugins/streaming/impls/mqtt/src/test/resources/ProduceFourRows.ktr
  plugins/streaming/impls/pom.xml

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes: +23.6% (click to expand)
:new: org.pentaho.di.trans.step.mqtt.MQTTConstants

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.step.mqtt.MQTTConsumer

Line Coverage: 78.6% :exclamation:

:new: org.pentaho.di.trans.step.mqtt.MQTTConsumerDialog

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.step.mqtt.MQTTConsumerMeta

Branch Coverage: 50% :exclamation:
Complexity Coverage: 58.2% :exclamation:

:new: org.pentaho.di.trans.step.mqtt.MqttDialogOptionsLayout

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.step.mqtt.MqttDialogSecurityLayout

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.step.mqtt.MQTTProducer

Branch Coverage: 62.5% :exclamation:
Complexity Coverage: 50% :exclamation:
Method Coverage: 66.7% :exclamation:

:new: org.pentaho.di.trans.step.mqtt.MQTTProducerDialog

Coverage: 0% :exclamation:

:new: org.pentaho.di.trans.step.mqtt.MQTTProducerMeta

Branch Coverage: 50% :exclamation:
Complexity Coverage: 63.6% :exclamation:
Instruction Coverage: 74.7% :exclamation:

:new: org.pentaho.di.trans.step.mqtt.MQTTStreamSource

Branch Coverage: 50% :exclamation:

:new: org.pentaho.di.trans.step.mqtt.SslConfigHelper

Branch Coverage: 50% :exclamation:
Complexity Coverage: 70% :exclamation:

related to https://github.com/pentaho/big-data-plugin/pull/1350

@pentaho/ackbar

waiting to merge until wednesday

@pentaho/ackbar ready for merge


Basic TypeScript Typings

I saw the issue where you'd be looking into incorporating TypeScript typings into your project. As a user I'd like that because I could remove my declare clause :)
I don't have much time on my hands at the moment, but here's the turbo-basic typings generation.

#14

Cool, thanks! I've never used TypeScript in my own projects but this looks like a great start. I'll check it out.

Knocked-out #9 while I was fixing up this PR.

@jneurock package-lock.json was removed and ignored.

Knocked-out #9 while I was fixing up this PR.

Thanks!!!

Thanks for the TypeScript setup and the README changes!!! Appreciate your patience with me on the code review, too!


⚠ Yahoo奇摩新聞 has degraded performance

In a6e74c1, Yahoo奇摩新聞 (https://tw.news.yahoo.com/) experienced degraded performance:

HTTP code: 200
Response time: 1019 ms

Resolved: Yahoo奇摩新聞 performance has improved in d48a2e8.


Request failed - repeatedly

Type: Bug
fix this: 2024-12-19 18:53:39.981Z: The apache2 configtest failed. ...2024-12-19 18:53:40.111Z: (warning). 2024-12-19 18:53:40.114Z: Output of config test was: 2024-12-19 18:53:40.139Z: mkdir: cannot create directory '/var/run/apache2': Permission denied2024-12-19 18:53:40.142Z: apache2: Syntax error on line 80 of /etc/apache2/apache2.conf: DefaultRuntimeDir must be a valid directory, absolute or relative to ServerRoot Action 'configtest' failed. 2024-12-19 18:53:40.143Z: The Apache error log may have more information. 2024-12-19 18:53:40.195Z: postCreateCommand failed with exit code 1. Skipping any further user-provided commands.
2024-12-19 18:53:40.195Z: Error: Command failed: /bin/sh -c bash .devcontainer/server/init-server.sh 2024-12-19 18:53:40.195Z: at b7 (/.codespaces/agent/bin/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:235:130) 2024-12-19 18:53:40.195Z: at process.processTicksAndRejections (node:internal/process/task_queues:95:5) 2024-12-19 18:53:40.196Z: at async Am (/.codespaces/agent/bin/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:227:4483) 2024-12-19 18:53:40.196Z: at async Xw (/.codespaces/agent/bin/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:227:3828) 2024-12-19 18:53:40.196Z: at async $w (/.codespaces/agent/bin/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:227:3032) 2024-12-19 18:53:40.196Z: at async fa (/.codespaces/agent/bin/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:227:2438) 2024-12-19 18:53:40.196Z: at async ctA (/.codespaces/agent/bin/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:410:3710) 2024-12-19 18:53:40.196Z: at async YtA (/.codespaces/agent/bin/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:482:3944) 2024-12-19 18:53:40.196Z: at async eB (/.codespaces/agent/bin/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:482:4886) 2024-12-19 18:53:40.196Z: at async prA (/.codespaces/agent/bin/node_modules/@devcontainers/cli/dist/spec-node/devContainersSpecCLI.js:663:200) 2024-12-19 18:53:40.196Z: {"outcome":"error","message":"Command failed: /bin/sh -c bash .devcontainer/server/init-server.sh","description":"The postCreateCommand in the devcontainer.json failed.","containerId":"bfa2df048155b36fe17ade18f55b277532f4ca1f06c27eb6ea5615f586c83011"} 2024-12-19 18:53:40.220Z: devcontainer process exited with exit code 1
Extension version: 0.23.2
VS Code version: Code 1.96.0 (Universal) (138f619c86f1199955d53b4166bef66ef252935c, 2024-12-11T02:29:09.626Z)
OS version: Darwin arm64 24.0.0
Modes:
Remote OS version: Linux x64 6.5.0-1025-azure
Connection to 'codespaces+shiny-sniffle-7x77wqq6jq2rgj4' could not be established

System Info

Item
Value

CPUs
Apple M2 (8 x 2400)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabledwebgpu: enabledwebnn: disabled_off

Load (avg)
2, 2, 2

Memory (System)
8.00GB (0.06GB free)

Process Argv
--crash-reporter-id dcd8e784-cdf8-49dc-81a1-a7cd42747f63

Screen Reader
no

VM
0%

Item
Value

Remote
Codespaces: psychic trout

OS
Linux x64 6.5.0-1025-azure

CPUs
AMD EPYC 7763 64-Core Processor (2 x 0)

Memory (System)
7.74GB (5.37GB free)

VM
0%

Connection to 'codespaces+shiny-sniffle-7x77wqq6jq2rgj4' could not be established

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythonnoceb:30805159
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
dvdeprecation:31068756
dwnewjupytercf:31046870
2f103344:31071589
nativerepl2:31139839
pythonrstrctxt:31112756
nativeloc1:31192215
cf971741:31144450
iacca1:31171482
notype1:31157159
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530
6074i472:31201624

Can you include your output channel via CMD + SHIFT + U -> GitHub Copilot Chat

I would love to provide that, however, it seems that after a 'copilot
edits' thread is closed. It can't be accessed again, I can't find any
history view, like the chat has. please advise.
On Thu, Dec 19, 2024 at 12:05 PM Peng Lyu @.***> wrote:

Can you include your output channel via CMD + SHIFT + U -> GitHub Copilot
Chat
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-copilot-release/issues/3413#issuecomment-2555577095,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMTWGOEHBNAMYAFBFBWQWT2GMKI3AVCNFSM6AAAAABT5TZLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJVGU3TOMBZGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

It would be great if you can share the logs if you run into similar issues next time.

The vscode dialog box said it was sharing my environment details.  Product
gap there?
On Thu, Dec 19, 2024 at 2:01 PM Peng Lyu @.***> wrote:

It would be great if you can share the logs if you run into similar issues
next time.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode-copilot-release/issues/3413#issuecomment-2555765556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMTWGNHBCLZWPU3QKOJ7UT2GMXYXAVCNFSM6AAAAABT5TZLX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJVG43DKNJVGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


Terminal is not getting opened

Type: Feature Request
Terminal is not getting opened. Fix this ASAP
VS Code version: Code 1.92.1 (eaa41d57266683296de7d118f574d0c2652e1fc4, 2024-08-07T20:16:39.455Z)
OS version: Windows_NT x64 10.0.19045
Modes:

OK


Form inside carousel does not work properly (c# mvc)

When slidesToShow is greater than 1, the input field values are not correctly posted from the other slides.

====================================================================
I am seeing this issue with a C# MVC4 form post.
Although I do not expect help with this issue, I am posting, as it could save someone else hours of frustration. If I find a solution I will post here.

Are you wrapping all the elements in a single form?


Calibration dataset sample size and its sequence length are always fixed. Why?

I've noticed in the implementation of AwqQuantizer that the number of samples and sequence length for the calibration dataset are fixed at 128 and 512, respectively. Is this a deliberate choice due to certain constraints or optimizations? I believe that making these values variable may have been overlooked when the change "Allow user to use custom calibration data for quantization #27" enabled the use of custom datasets.
https://github.com/casper-hansen/AutoAWQ/blob/299c460b12cc17d1c3b1519ff4274795aaf5f949/awq/quantize/quantizer.py#L27
https://github.com/casper-hansen/AutoAWQ/blob/299c460b12cc17d1c3b1519ff4274795aaf5f949/awq/quantize/quantizer.py#L293

This is how the original AWQ was implemented. I allowed custom datasets but I can see there are some restrictions now that I should look into

Understood. Thank you!


[Idea]: Using decorators for defining routes

Issue
Currently the way that routes are defined creates a big gap between the route definition and implementation. So your controllers have some methods and they might be named what the route is, but who knows really, until you look at config/routes.js. So there is a disconnect and someone reading the code has to find the definition of the routes elsewhere. It makes the code harder to understand and reason about. This makes refactoring harder as well.
Possible Solution
Use decorators inside of the controller to assign route information to the implementations (see express-decorators) and use config/routes.js to change the order that controllers are added to the server/init decorated controllers.
@controller('/users')
class Users {
  @get('/')
  listAll(req, res) {
    // return all users
  }
}

Then in the config/routes.js you could instantiate the decorated controller.
UserController.setupRoutes(this);

This could be built in, or possibly as a separate module (might not need to be a plugin).
If this is built in and the way to define routes, the routes config might just be an array or controller names, e.g.
export default [
  'users',
  'posts'
];

Issues/Drawbacks
Decorators are not stable yet (but close).

I've got mixed feelings about this approach. I sympathize with the idea that it's an additional step to mentally connect the controller to it's route, but I imagine for most APIs that are roughly "RESTful", it should be fairly obvious (i.e. the Books.create action is probably tied to POST /books).
You also lose the DRYness of something like this.resource('books'), which wires up multiple CRUD routes simultaneously.
Finally, most popular server frameworks have this kind of separation. While I don't want to just duplicate Rails et al blindly, I do think it's a good idea to be cautious when choosing a decidedly different approach.
I think this could make for a great userland module, and if it works well / has enough interest, we could add to core.
For an implementation, assuming a hypothetical denali-decorator-routes module:
// config/routes.js
import { setupRoutes } from 'denali-decorator-routes';

export default setupRoutes;

// app/controllers/books.js
import { route } from 'denali-decorator-routes';
import { Controller } from 'denali';

export default Controller.extend({
  @post('/books')
  create() {
    // ...
  }
});

Does that make sense?

Closing this for now, but userland contributions are certainly welcome, as is further discussion on the topic.


Documentation missing link

The "How to Create a Collection in ScholarSphere" documentation looks like it should include a link in step #4, but it doesn't have a destination.
https://scholarsphere.psu.edu/collection.pdf

Thanks for catching that! I'll fix that link and upload a new version of the PDF.

Likely need new documentation for creating collections in PCDM ScholarSphere

#337 Duplicates the above comment closing this link


[Q&A] How to give examples to objects in line

Describe the bug
In the documentation it says I can give detail to the generated examples in the below maner, but when I try this I get an error:
Readme example:
Model composition in response

// JSONResult's data field will be overridden by the specific type proto.Order
@success 200 {object} jsonresult.JSONResult{data=proto.Order} "desc"

type JSONResult struct {
    Code    int          json:"code"
    Message string       json:"message"
    Data    interface{}  json:"data"
}

*** error got on my code*** : 2024/10/06 12:45:03 ParseComment error in file /Users/jfield/dev/xorima/github-bridge/internal/app/webhook.go :invalid type: Response{status=200,message=
To Reproduce
Code:
file: app/webhook.go
package app

import (
	"github.com/xorima/slogger"
	"log/slog"
	"net/http"
)

type WebhookHandler struct {
	log *slog.Logger
}

func NewWebhookHandler(log *slog.Logger) *WebhookHandler {
	return &WebhookHandler{
		log: log.With(slog.String("handler", "webhook")),
	}
}

// Post - Receives the GitHub webhooks
//
//	@Summary		This API is there to receive the GitHub events.
//	@Description	Once received, this will add them to the event stream for consumers.
//	@Tags			Webhooks
//	@Accept			json
//	@Produce		json
//	@Success		200	{object} Response{status=200,message="Success"}	"Successful Response"
//	@Failure		    401	{object} Response{status=401,message="Unauthorized"}	"Unauthorized"
//	@Failure		  404	{object} Response{status=404,message="Not Found"}		"Failure Response"
//	@Router			/api/v1/webhook/github [post]
func (wh *WebhookHandler) Post(w http.ResponseWriter, r *http.Request) {
	wh.log.Info("got request")
	resp := NewResponse(http.StatusAccepted, "Accepted")
	w.WriteHeader(resp.Status)
	_, err := w.Write(resp.ToJson())
	if err != nil {
		wh.log.Error("failure in writing webhook response", slogger.ErrorAttr(err))
	}
}

func (wh *WebhookHandler) RegisterRoutes(r Router) {
	r.Post("/v1/webhook/github", wh.Post)
}

file: app/response.go
package app

import "encoding/json"

type Response struct {
	Status  int    `json:"status"`
	Message string `json:"message"`
}

func NewResponse(status int, message string) *Response {
	return &Response{Status: status, Message: message}
}

func (r *Response) ToJson() []byte {
	// the error here is impossible due to well known object.
	resp, _ := json.Marshal(r)
	return resp
}

Expected behavior
swag init generates with appropriate examples
Screenshots

Your swag version
1.16.3
Your go version
e.g. 1.12.0
Additional context
I am doing this so I will not have to create multiple structs that are identical but have different examples, as that would add complexity which is not desired

based on attachment readme. the code should be like this
type Response struct {
	Status int `json:"status"`
	Data   any `json:"data"`
}

type DTOs struct {
	A string `json:"a" example:"a"`
	B string `json:"b" example:"b"`
	C string `json:"b" example:"c"`
}

// Post - Receives the GitHub webhooks
//
//	@Summary		This API is there to receive the GitHub events.
//	@Description	Once received, this will add them to the event stream for consumers.
//	@Tags			Webhooks
//	@Accept			json
//	@Produce		json
//	@Success		200	{object} Response{data=DTOs}	"Successful Response"
//	@Router			/api/v1/webhook/github [post]
func (wh *WebhookHandler) Post(w http.ResponseWriter, r *http.Request) {
	wh.log.Info("got request")
	resp := NewResponse(http.StatusAccepted, "Accepted")
	w.WriteHeader(resp.Status)
	_, err := w.Write(resp.ToJson())
	if err != nil {
		wh.log.Error("failure in writing webhook response", slogger.ErrorAttr(err))
	}
}

Thanks @martinyonatann
using the example has gotten closer, but still not fully there

this is using this as the example:
type Response struct {
	Status  int    `json:"status"`
	Message string `json:"message"`
}

type Success struct {
	A int `json:"status" example:"200"`
}

//	@Success		202	{object} Response{status=Success}	"Successful Response"

It feels like I will have to make a custom response type for each, which while not end of the world it's not what I originally intended :)


Why is the interface blank?

Your work is really good!
I want to study it, but the browser interface is blank.How could I fix the problem? Thank you!!!

Thanks @lsyic , I'm glad you like it!
Are you running CNN Explainer from the public demo? I just tested it and there is no problem loading the visualization on my machine (macOS + Firefox).
The error message indicates that it's a tensorflow.js error — It has trouble using the GPU on your machine. Below are two related issues:
https://github.com/tensorflow/tfjs/issues/1466
https://github.com/justadudewhohacks/face-api.js/issues/282
I suggest updating your browser (looks like Chrome?) to the latest version and try to load CNN Explainer again.

Yeah!It's browser's problem.
The software running well after updating the browser.
Thank you!!!

Good! No problem ٩( ᐛ )و


AO-16881: Process invalid bucket config

Process invalid token bucket configurations as per the spec.

Codecov Report

Merging #162 (1823c46) into master (16ba064) will increase coverage by 0.34%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   80.27%   80.62%   +0.34%
==========================================
  Files          40       40
  Lines        4229     4233       +4
==========================================
+ Hits         3395     3413      +18
+ Misses        698      689       -9
+ Partials      136      131       -5

Impacted Files
Coverage Δ

v1/ao/internal/config/config.go
80.98% <100.00%> (+2.32%)
:arrow_up:

v1/ao/internal/config/env.go
87.87% <100.00%> (+3.50%)
:arrow_up:

v1/ao/internal/metrics/metrics.go
67.83% <0.00%> (-0.18%)
:arrow_down:

v1/ao/internal/reporter/reporter_grpc.go
67.63% <0.00%> (-0.18%)
:arrow_down:

v1/ao/internal/reporter/context.go
93.80% <0.00%> (+0.05%)
:arrow_up:

v1/ao/internal/host/observer.go
84.96% <0.00%> (+4.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ba064...1823c46. Read the comment docs.


Use "versionSuffix" to exclude the specified suffix

https://repo1.maven.org/maven2/com/alibaba/fastjson/maven-metadata.xml
<metadata>
    <groupId>com.alibaba</groupId>
    <artifactId>fastjson</artifactId>
    <versioning>
        <latest>2.0.21.graal</latest>
        <release>2.0.21.graal</release>
        <versions>
            ...
            <version>2.0.21</version>
            <version>2.0.21.android</version>
            <version>2.0.21.graal</version>
        </versions>
        <lastUpdated>20221210174016</lastUpdated>
    </versioning>
</metadata>

I want to get "2.0.21". Is it supported now?

The result of using "https://img.shields.io/maven-metadata/v?label=&color=blue&metadataUrl=https://oss.sonatype.org/content/repositories/releases/com/alibaba/fastjson/maven-metadata.xml" is as follows, but I don't want to use suffixes with ". android" and ". general"

This one is interesting. I can see what you're trying to do and why it is not possible. My first instinct was to say we allow versionSuffix to be empty string (&versionSuffix=) but, of course, everything ends with empty string :upside_down_face:
Not quite sure where to go with this one.
Also linking https://github.com/badges/shields/issues/6995
Hmm

thankyou

Some time back we added the ability to construct and apply an arbitrary filter param. See

https://github.com/badges/shields/pull/9193
https://shields.io/blog/tag-filter

I'm going to suggest the way we handle this is deprecate the prefix and suffix params on the maven and grade badges and switch to using the same pattern.

https://repo1.maven.org/maven2/com/alibaba/fastjson/maven-metadata.xml There are 2.0.21, 2.0.21.android, 2.0.21.graal
https://img.shields.io/maven-metadata/v?label=&color=blue&metadataUrl=https://oss.sonatype.org/content/repositories/releases/com/alibaba/fastjson/maven-metadata.xml&versionPrefix=2.0.21&versionSuffix=android :
https://img.shields.io/maven-metadata/v?label=&color=blue&metadataUrl=https://oss.sonatype.org/content/repositories/releases/com/alibaba/fastjson/maven-metadata.xml&versionPrefix=2.0.21&versionSuffix=graal :
https://img.shields.io/maven-metadata/v?label=&color=blue&metadataUrl=https://oss.sonatype.org/content/repositories/releases/com/alibaba/fastjson/maven-metadata.xml&versionPrefix=2.0.21&versionSuffix :
https://img.shields.io/maven-metadata/v?label=&color=blue&metadataUrl=https://oss.sonatype.org/content/repositories/releases/com/alibaba/fastjson/maven-metadata.xml&versionPrefix=2.0&versionSuffix=21 :

I'm not sure I understand the significance of that list of examples. Could you clarify?

Released version description
Fixed version, fixed suffix
Fixed version, fixed suffix
Fixed version, no suffix: cannot be used
If you want to set a fixed version without a suffix: you need to split the version number into two segments, with the first segment as the prefix and the second segment as the suffix

I think the usage of 4 should be improved

I think adopting the same pattern we use for github releases would do the job for most cases. For example:
import { matcher } from 'matcher'

const versions = [
  '2.0.21',
  '2.0.21.android',
  '2.0.21.graal',
]

// filter releases ending in .android
console.log(matcher(versions, '*.android'))
// prints [ '2.0.21.android' ]

// filter releases ending in .graal
console.log(matcher(versions, '*.graal'))
// prints [ '2.0.21.graal' ]

// filter releases that do not include 4 dots
console.log(matcher(versions, '!*.*.*.*'))
// prints [ '2.0.21' ]

The syntax isn't a full regex. You can certainly find an expression that doesn't allow you to create, but it would be more flexible than what exists now and cover a lot of these sort of cases.


Will Microsoft implement Saudi Zatca E-Invoicing phase II before 2023?

We are in the implementation stage of dynamics 365. Could you clarify 2 short questions

Will Microsoft implement of E-Invoice(ZATCA PHASE II) before jan-2023?
Is there any limitations for E-Invoicing number of transactions per month/tenant basis? Because we are in the Retail hypermarket business. So, the number of transactions are higher than any other business model. the below contents are found in "Dynamics 365 License Guide"

"Electronic invoicing is the process of creating, presenting, and exchanging structured,
transactional invoice documents between businesses and governments for tax
reporting purposes, or trading partners in an integrated electronic format.
Dynamics 365 Commerce, Finance, Project Operations, and Supply Chain Management applications include 100
electronic invoice transactions/tenant/month. This included capacity does not rollover and is 100 transactions
per tenant, regardless of the number of Dynamics 365 licensed applications.
If you need additional transactions, you can buy the Electronic Invoicing additional capacity license for 1K
electronic invoice transactions/tenant/month. The transaction capacity is use-it-or-lose-it on a monthly basis,
and customers will need to purchase for peak capacity."
Please kindly clarify these both

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 332ecc73-b911-de45-fd7c-4f2e1926db53
Version Independent ID: 5057d69e-3e33-19c3-69e0-6aad0fff5e5e
Content: Electronic invoicing overview - Finance | Dynamics 365
Content Source: articles/finance/localizations/e-invoicing-service-overview.md
Service: dynamics-365-finance
Product: ****
Technology: ****
GitHub Login: @gionoder
Microsoft Alias: gionoder

Bug 744759 has been logged to address this issue.

Hi,
Question #1: Will Microsoft implement of E-Invoice (ZATCA PHASE II) before jan-2023?
Answer: Yes, for details about scope and timelines, please consult the release plan available at: https://docs.microsoft.com/en-us/dynamics365-release-plan/2022wave2/finance-operations/dynamics365-finance/access-saudi-arabia-e-invoice-integration.
The Electronic Invoicing phase 2 for Saudi Arabia is already in Public Preview, general resources about Electronic Invoicing are available at:
Electronic invoicing overview: https://docs.microsoft.com/en-us/dynamics365/finance/localizations/e-invoicing-service-overview?context=%2Fdynamics365%2Fcontext%2Ffinance)
And the Country specific resources are available at:
Electronic invoicing onboarding in Saudi Arabia: https://docs.microsoft.com/en-us/dynamics365/finance/localizations/e-invoicing-sa-onboarding
Get started with Electronic invoicing for Saudi Arabia: https://docs.microsoft.com/en-us/dynamics365/finance/localizations/e-invoicing-sa-get-started
You are welcome to join the Preview Community, where you will have access to the Preview for Saudi Arabia phase 2, and others upcoming Electronic Invoicing features.
Question #2: Is there any limitations for E-Invoicing number of transactions per month/tenant basis? Because we are in the Retail hypermarket business. So, the number of transactions are higher than any other business model. the below contents are found in "Dynamics 365 License Guide"
Answer: There is no technical limitations, but it is advisable to consult the "Dynamics 365 License Guide" for more information about the licensing policy for Electronic Invoicing. Also please, consult the release plan for more information about the supported scope of electronic invoicing for Retail in Saudi Arabia.

Hi,
Question #1: Will Microsoft implement of E-Invoice (ZATCA PHASE II) before jan-2023? Answer: Yes, for details about scope and timelines, please consult the release plan available at: https://docs.microsoft.com/en-us/dynamics365-release-plan/2022wave2/finance-operations/dynamics365-finance/access-saudi-arabia-e-invoice-integration.
The Electronic Invoicing phase 2 for Saudi Arabia is already in Public Preview, general resources about Electronic Invoicing are available at:
Electronic invoicing overview: https://docs.microsoft.com/en-us/dynamics365/finance/localizations/e-invoicing-service-overview?context=%2Fdynamics365%2Fcontext%2Ffinance)
And the Country specific resources are available at:
Electronic invoicing onboarding in Saudi Arabia: https://docs.microsoft.com/en-us/dynamics365/finance/localizations/e-invoicing-sa-onboarding Get started with Electronic invoicing for Saudi Arabia: https://docs.microsoft.com/en-us/dynamics365/finance/localizations/e-invoicing-sa-get-started
You are welcome to join the Preview Community, where you will have access to the Preview for Saudi Arabia phase 2, and others upcoming Electronic Invoicing features.
Question #2: Is there any limitations for E-Invoicing number of transactions per month/tenant basis? Because we are in the Retail hypermarket business. So, the number of transactions are higher than any other business model. the below contents are found in "Dynamics 365 License Guide"
Answer: There is no technical limitations, but it is advisable to consult the "Dynamics 365 License Guide" for more information about the licensing policy for Electronic Invoicing. Also please, consult the release plan for more information about the supported scope of electronic invoicing for Retail in Saudi Arabia.

Thank you for reply,
Question #1: I got it,
Question #2: Sorry, I didn't get your point, could you please elaborate more?.  In the "Dynamics 365 License Guide"
It mentioned that Dynamics 365 Commerce, Finance, Project Operations, and Supply Chain Management applications include 100
electronic invoice transactions/tenant/month, If you need additional transactions, you can buy the Electronic Invoicing additional capacity license for 1K
electronic invoice transactions/tenant/month
That's the point we need some clarification. Our business is hypermarket. Our daily transaction Invoices are around 7K to 10K per day. I hope each invoice should be considered as Electronic Invoice as per Saudi Zatca E-Invoicing phase II. So,
How this 100 or 1000 transaction limitations will be applicable to Hyper market business like us?
or Is this transaction limitation which is mentioned in "Dynamics 365 License Guide" are not relevant to  E-Invoice of Saudi Zatca phase II?.

Hi,
Typically, in retail business the invoices will be sent to ZATCA for reporting purposes, not for clearance. Then, for the summarized invoice submission, it will depend how often you submit transaction invoices to the service, and not necessarily how many retail invoices you are going to report. In another words, if you encompass multiple retail invoices in one submission to the service, that will count as one invoice transaction.
Thank you. Regards,

Hi,
This information about encompassing several retail invoices in the same submission to ZATCA is not accurate and I would like to clarify. As is now, under the Retail scenarios, the submission of retail invoices to ZATCA are still for reporting purposes, however, differently that initially said, it will be submitted one by one, similarly to electronic invoices issued from a regular B2B sales.
We are working internally to mitigate the impact this approach might have for retails businesses, and close to the GA we will announce more details.
Thank you. Regards.

Hello Gionoder,
Do you mean that, As it was before "Multiple retail invoices(Summarized invoice) submission to Zatca counted as ONE", But now It will be "For B2C Each invoice will be submitted one by one, same like B2B sales". Is it?.

Hi Gionoder,
It's clear now for submission of E-Invoice. So, what about the 100 transactions limitation per month/tenant in hyper market business?.  As you mentioned above, each invoices will be submitted one by one. So, If Microsoft considered one invoice submission will be counted as one, then this 100 transaction limitation it will not even cover for 30 min of sales invoice,
or Is there any changes in limitations for Hyper market business?.
Microsoft must reconsider it for Retail business, In a peek days its reaching from 15K to 18K invoices in a day. we are in the implementation stage right now.


Support fill_mode for transform

Description
Fixes #1318.
Type of change

[x] Bug fix
[ ] New Tutorial
[ ] Updated or additional documentation
[ ] Additional Testing
[ ] New Activation and the changes conform to the activation contribution guidelines
[ ] New Callback and the changes conform to the callback contribution guidelines
[ ] New Image addition and the changes conform to the image op contribution guidelines
[ ] New Layer and the changes conform to the layer contribution guidelines
[ ] New Loss and the changes conform to the loss contribution guidelines
[ ] New Metric and the changes conform to the metric contribution guidelines
[ ] New Optimizer and the changes conform to the optimizer contribution guidelines
[ ] New RNN Cell and the changes conform to the rnn contribution guidelines
[ ] New Seq2seq addition and the changes conform to the seq2seq contribution guidelines
[ ] New Text addition and the changes conform to the text op contribution guidelines

Checklist:

[x] I've properly formatted my code according to the guidelines

[ ] By running Black + Flake8
[ ] By running pre-commit hooks

[ ] This PR addresses an already submitted issue for TensorFlow Addons
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] This PR contains modifications to C++ custom-ops

How Has This Been Tested?
Test against different fill_mode.

@mels630 @sayoojbk
You are owners of some files modified in this pull request.
Would you kindly review the changes whenever you have the time to?
Thank you very much.


Can you upload the code？

I am very interested in your paper. Can you share the code?

Thank you for your reply. Looking forward to it.

Hi, Tino
I recently encountered overfitting issues during the experiment. Although I tried using regularization and Dropout, they did not work. Have you encountered any overfitting issues during the experiment and how did you solve them?
Best,
Ling Xiang


[crypto] adding a stripped-down noise implementation

This PR adds our own implementation of the Noise protocol framework,
which we use in libra core to encrypt and authenticate communications
between nodes.
It diverges from the current implementation that we use in different ways:

It only implements one handshake pattern (IK)
It uses SHA-3
It uses AES-128-GCM

To make sure it works, we run tests with SHA-2 and AES-256-GCM
(since Noise doesn't specify SHA-3 and AES-128-GCM).
This PR prepares for two incoming changes:

A move from the IX handshake pattern to the IK handshake pattern
Fuzzing our noise implementation

Note that it seems like a lot of dependencies added, but these are all related to AES-GCM. (It's also not counting the dependencies we'll reduce by removing snow.)

:umbrella: The latest upstream changes (presumably 14e8ca56a32b33a32fa6872c14237e72152a9630) made this pull request unmergeable. Please resolve the merge conflicts.

Naive question, if someone wanted to build their own fullnode, would they need to modify their version of noise to be able to speak to our version of noise?

mostly, API's should take in pre-allocated buffers instead of allocating them for you, then return the # bytes written into the buffer

Naive question, if someone wanted to build their own fullnode, would they need to modify their version of noise to be able to speak to our version of noise?

Yeah, @valerini actually brought that up as well. I think that's a very good argument to keep AES-256-GCM and SHA-256 (unfortunately). But let's think about this more :)

@phlip9 thanks for the review:

I'll leave the -> Vec<u8> API for now and will fix this later when I integrate with network :o
after that I'll try to get rid of as much allocation as possible

:v: @mimoo can now approve this pull request

@bors-libra r=philip9

:pushpin: Commit 6d8cecf has been approved by philip9

:hourglass: Testing commit 6d8cecf9a0fc94bea14e4cb286f5f127d192721e with merge 04ad4ca909246f76ac52d3ba0f68d7521b97be3c...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: philip9
Pushing 04ad4ca909246f76ac52d3ba0f68d7521b97be3c to master...


Fix typo throughout readme and source of "swiping"

This also changes an incorrectly spelt Enum, so will require source modifications for users.

I would also suggest changing the description of the repo which contains the typo too!

Thanks, I have merged the PR manually to ensure backward compatibility.