convert_command configuration not accepted

when trying to set the convert_command configuration as described in the documentation I get a method_missing error:
configurable.rb:192:in `method_missing': You tried to configure using ':convert_command=',  but the valid config attributes are...

+1 with following initializer app use just default values of convert and identify
but with gem altering - all is ok
dapp = Dragonfly[:images]
dapp.configure_with(:imagemagick)
dapp.configure do |c|
  c.convert_command = "/usr/local/bin/convert"          # defaults to "convert"
  c.identify_command = "/usr/local/bin/identify"         # defaults to "convert"
  c.log_commands = true
end

Hi - what version of the gem are you using?
On 15 Jan 2012, at 18:46, Artem Chernikov wrote:

+1 with following initializer app use just default values of convert and identify
but with gem altering - all is ok
dapp = Dragonfly[:images]
dapp.configure_with(:imagemagick)
dapp.configure do |c|
 c.convert_command = "/usr/local/bin/convert"          # defaults to "convert"
 c.identify_command = "/usr/local/bin/identify"         # defaults to "convert"
 c.log_commands = true
end

Reply to this email directly or view it on GitHub:
https://github.com/markevans/dragonfly/issues/83#issuecomment-3500847

i use dragonfly (0.9.10)

aaaah do you mean that
c.convert_command = "/usr/local/bin/convert"

works for you? If so, that's fine - I was getting confused - this isn't "gem altering" - this is using the configuration correctly. Sorry if I've misunderstood


Rosetta: Retry sql errors on true

This should help us workaround the now intermittent out-of-memory issue.

Closed as not relevant anymore.


A place to discuss

Just wanted to put out a request for a place to discuss postwoman related stuff in a convenient way. GitHub doesn't exactly offer a way to discuss stuff in a freeform way (without opening issues and stuff, just a general flow of ideas).
Could we have a chat room in gitter or something similar ? (Discord, Slack, Telegram ?)
Bonus : Would give users a space to get live help.

Also a separate dev and help channels will be awesome

A telegram group would be enough

@liyasthomas a mention of this in the README will be nice

Will do in next commit

Added Telegram group link to README on 8dadec62209715ae7b6c0510d59045880fc22591 hence closing

I tried to join the channel, but Telegram isn't easily accessable in my region.

I could start a gitter or discord group if you prefer

I prefer discord.

@hosseinnedaee https://discord.gg/GAMWxmR


using of target_arch/_os to detect, if the platform has a libc

Beside wasm32 also RustHermit doen't have a classical C library.
Using of target_arch/_os to detect these platforms. It simplifies
the usage of this crate.

Hi, and thanks for the PR!
I think I'd rather keep std as a feature, and turn it on automatically in a build.rs depending on the target (and do the same in zstd-sys).

Yes, I see the benefits of using the feature std. Do you think more of such a solution?

Looking good - thanks again for the work!


📥 Add to our May Topics

BIP 119 OP_CTV & activation drama
What is a Covenant:
Covenants are a category of proposed changes to Bitcoin’s consensus rules that would allow a script to prevent an authorized spender from spending to certain other scripts. —Bitcoin OpTech

How does CTV actually work? CTV takes the top item on the Bitcoin Virtual Machine's stack and verifies that the “template hash” of the current transaction matches that value. This necessarily means that if you wish to spend the coins protected by CTV, you must have known the template hash of the spending transaction before depositing funds into the CTV protected address.
Why is this? Since the template hash of the spending transaction is embedded in the script you are sending your coins to, and because hash functions are one-way, you had to know this value up front: Solving for it after the fact would be equivalent to breaking Bitcoin's mining algorithm.
As a result of this design, CTV has a property that makes it much simpler than some of the competing proposals. First, all “exit paths” of a CTV contract are known up front. This makes analysis of the safety of CTV contracts significantly easier and therefore less likely to lock your funds up forever.
Before we wrap up the discussion of how CTV works, let's talk about what goes into the “template hash,” as this is ultimately what you are having to commit to before generating the CTV contract. The template hash covers the transaction's version, locktime, number of inputs, sequence numbers, number or outputs, the hash of the outputs and values. This is every part of the transaction except the exact input IDs and the witnesses. Essentially, this means you have to know the exact transaction you want to use to spend these coins. This gives the design very little wiggle room in which there could be bugs in the design that allow for vulnerabilities. This is another reason why CTV has a much smaller surface to analyze than other proposals
— Keags @ https://bitcoinmagazine.com/technical/exploring-bip119-and-changes-made-to-bitcoin

Proposal for evaluating BIPs: A Modest Bitcoin Improvement Proposal, Proposal

Why might this be controversial?

CTV Templates doesn't appear to solve a burning problem in the way SegWit or Taproot have.
It's championed by an individual developer
Discussion for activation outside of https://github.com/bitcoin/bitcoin
The BIP is in dire need of an editor and requires deep programming expertise beyonnd what is typically expected of reviewers in order to understand
written in python, a write only language

how we can run it now

Ask an oracle to act as a trusted party in a multiparty tx. Have them execute CHECKTEMPLATEVERIFY

Central African Republic makes bitcoin legal tender

https://www.bbc.co.uk/sounds/play/p0c3jtzk

Recursive Covenants
Bitcoin core 23 released with cjdns support
rust-bitcoin 0.28.0 "The Taproot Release"

Taproot and its associated data structures: addresses, taptrees, sighashes, PSBT fields, and more
https://github.com/rust-bitcoin/rust-bitcoin/blob/master/CHANGELOG.md#028---2022-04-20-the-taproot-release
https://github.com/rust-bitcoin/rust-bitcoin/releases/tag/0.28.0

LN-VPN - VPN provider with Lightning Payment

https://lnvpn.net , credit Louis Liu
Carl Dong hosts LN-payable top-ups for Mullvad VPN for quite some time and supports paying via Tor hidden service, too

Tor Congestion Control arrives to v0.4.7

https://blog.torproject.org/congestion-contrl-047/
This speeds up Tor

Magma: A New Channel Marketplace on Lightning

Credit: Amboss
“Magma is a peer-to-peer marketplace for liquidity on the lightning network under Amboss’s supervision.”
Lightning fees are looking like folks are gonna pay for channel liquidity rather than what we understand as routing fees today

Mempool.space
Mempool is the most full it has been in one year
UST Collapse

"Algorithimic" stablecoin
vs centralized collateralized,
overcollaterllized (DAI, LUSD)

DLCs
DLCs is to enable contracts between two parties directly on the Bitcoin blockchain that settle via a trsted oracle to determine the contract outcome.
https://github.com/discreetlogcontracts/dlcspecs/blob/master/Introduction.md
https://suredbits.com/discreet-log-contracts-part-2-how-they-work-adaptor-version/


Reserve not working

Hi,
I am new to develop this. I googled and took examples.
Always worker code is not passing from here $job = $pheanstalk->watch('kumar1')->reserve(); though I have created jobs. It never go to next line to do actions. Tube stats showing total_jobs 5 but nothing is executing.
I am putting sample code for producer and consumer:
Producer:
$pheanstalk = new Pheanstalk('<IP_ADDRESS>');
$pheanstalk->useTube('kumar1');
$data = array('action' => 'testworker', 'ids' => array(1,2,3,4));
$job = $pheanstalk->put(json_encode($data), 1);
echo $job;  // It is returning number of jobs

Worker
$pheanstalk = new Pheanstalk('<IP_ADDRESS>');
$job = $pheanstalk->watch('kumar1')->reserve();
echo "Inside loop";   // This line not printing at all.
print_r($job);
$pheanstalk->delete($job);

Tube stats:
$pheanstalk = new Pheanstalk('<IP_ADDRESS>');
print_r($pheanstalk->statsTube('kumar1'));

out put:
Pheanstalk\Response\ArrayResponse Object
(
    [_name:Pheanstalk\Response\ArrayResponse:private] => OK
    [storage:ArrayObject:private] => Array
        (
            [name] => kumar1
            [current-jobs-urgent] => 0
            [current-jobs-ready] => 0
            [current-jobs-reserved] => 0
            [current-jobs-delayed] => 0
            [current-jobs-buried] => 0
            [total-jobs] => 5
            [current-using] => 0
            [current-watching] => 3
            [current-waiting] => 3
            [cmd-delete] => 5
            [cmd-pause-tube] => 0
            [pause] => 0
            [pause-time-left] => 0
        )

)

I am using Ubuntu 14.04 LTS and php 5.5.9
Can you help on this.

Probably something wrong in the way you capture your output. Your dump says cmd-delete = 5, so they did get deleted in the line after the print_r


Master

Minor changes for plot_compare_evokeds:

Fixed the title so title!=None will override the default behavior (adding channel names)
Fixed ci according to docstring: ci=None does not error anymore
Exposed ci_alpha parameter to let the use modify the opacity of the ci_band
Added "ci_method" parameter and a "bayesian" alternative (using scipy.stats.bayes_mvs) for ci_band computation

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@187f098). Click here to learn what that means.
The diff coverage is 41.66%.

@@            Coverage Diff            @@
##             master    #4516   +/-   ##
=========================================
  Coverage          ?   81.13%
=========================================
  Files             ?      349
  Lines             ?    65207
  Branches          ?    10093
=========================================
  Hits              ?    52904
  Misses            ?     9388
  Partials          ?     2915

also please add tests
and for next time don't send a PR from your master branch. It's better to
use a separate branch so your master is always the master for upstream

@agramfort Sorry about the master thing you're right, I'll reopen a PR in a separate branch


Improve contribution workflow to speed up issue tracking and PR merging

This proposal aims to improve the workflow for accepting contributions to the project.
Current Bottlenecks
Maintainers of the project are the only ones that can add labels to issues and PRs, update project boards and manage the merging of PRs.
Suggested Improvement
There is a group of core-contributors that regularly

handles reported Issues
send PRs
reviews PRs
works on Issues and PRs associated with different project boards

It would be beneficial for the Ceph-CSI project that the core-contributors get the privileges

to assign labels to Issues and PRs
have their PR reviews count
update project boards

PRs should get merged when there is a approved review of a core-contributor and at least one maintainer. This will improve the velocity of merging PRs, as currently two maintainers need to approve PRs. The approvals of core-contributors are not counted by Mergify and only used as input for the review of maintainers.
Required Changes
By using GitHub teams, Mergify can be configured to require a review from a core-contributor and a maintainer.
GitHub Settings
There need to be two GitHub teams:

a team core-contributors with write permissions
a team maintainers with write permissions

A maintainer should be part of both teams, as the maintainer is still a core-contributor. It might be possible to make the maintainers team a sub-team of core-contributors.
Mergify Rules
The current #approved-reviews-by>=2 rule will allow two approvals from core-contributors once the team has been created. This is not what we want, as at least one approval needs to come from a maintainer.
https://github.com/ceph/ceph-csi/blob/1dc032e5545cd5296b272e755aeda5d6bf4c9af5/.mergify.yml#L35-L57
The above rule (and duplicates) needs to get adjusted to:
  - name: automatic merge
    conditions:
      - label!=DNM
      - base~=^(devel)|(release-.+)$
      - approved-reviews-by=@core-contributors
      - approved-reviews-by=@maintainers
      - "#changes-requested-reviews-by=0"

approved-reviews-by is a list as described in the attributes
contents of lists are matched with a simple =

Thanks, @nixpanic. This looks to be a good suggestion at least this helps in a couple of ways from my point of view

Better sprint planning (creating boards, Moving issues, labeling issues, etc) and avoid burden on maintainers
Helps for the better review process and PR's will get merge on time and smooth transition
Getting help from team on issue handling and Release
More team involvement

CC @humblec @ShyamsundarR @agarwal-mudit

Sounds like a good plan to me :+1:

cc @pkalever @Yuggupta27 @yati1998 @Rakshith-R

Really great step! It will definitely help to smoothen the flow as well as make the review/triage process faster!

Looks good to me too ! :+1:

LGTM! (adding a triage group is useful (triage to include counting review votes))

Thanks @nixpanic , indeed the maintainers have burden now with respect to handling many things at hand and we have to come out of this situation one by one. Thats one of the reason for me to also propose more maintainers to the project https://github.com/ceph/ceph-csi/issues/1922 ( which didnt get in for some reason) ...etc. Regardless, indeed we have to take a different route on atleast process like PR review , releases....etc.. In short,  as always I am more welcoming here to improve the process!
Few things which I would like to clarify here,
iic, github roles/permissions can be associated with a user on below filters:
Read
Triage
Write
Maintain
Admin

At present ( unless some changes were happened in between) , we have below maintainers with the CSI project and all have write access to the repo.
@gman0 @nixpanic @ShyamsundarR @Madhu-1 @agarwal-mudit and myself .
All other contributors are with read access:
I also have admin access to this repo along with other 'ceph' org admins like @leseb .

a team core-contributors with write permissions
a team maintainers with write permissions

Sure,  Above proposal looks good to me. One question I have here is,
Is write access good enough for maintainers or do we need to grant admin access for all maintainers ? what I have noticed  is that,  write access is more than good enough for almost all repo handling processes.
So, either we will have all maintainers to admin access or stick to  all maintainers  with write access. I am fine with any model, but would like to have some process/consistency across, so putting it across.
Also, do we need to explore other filters like maintain among the proposed groups of `core contributors/maintainers'...etc?
Regarding approval count for merging : one small change which I can propose here is:

either one maintainer + 2  core contributors
or
2 maintainers approval

Otherwise if we go ahead with current proposal of merge,  isnt it pretty much same that the approval is having same effect regardless its coming from maintainer or core contributor.
Again, please share the thoughts ,  I can make the changes accordingly.

write permissions seem to be sufficient for maintainers to do releases.
Additional admins might be useful, but that is out of scope for this request. A group with the admins is of course easiest to use in case we want additional checks or request attention from admins in an Issue or PR (using @ceph-csi-admins).

either one maintainer + 2 core contributors

This is difficult to express with Mergify rules. I also do not think there is any benefit in requiring a 2nd core-contributor review. If under reviewed PRs get merged and cause issues, we can fix or revert them if needed.

Proposed teams, based on current contributions:
Ceph-CSI-Contributors (includes all maintainers too)

@Madhu-1
@Rakshith-R
@ShyamsundarR
@Yuggupta27
@agarwal-mudit
@humblec
@nixpanic
@yati1998

Ceph-CSI-Maintainers

@Madhu-1
@humblec
@nixpanic

LGTM

https://github.com/orgs/ceph/teams/ceph-csi-contributors and https://github.com/orgs/ceph/teams/ceph-csi-maintainers team are created with write and admin access. Thanks to @leseb for helping on creating the teams.
@nixpanic can please you send a PR to make sure of it?

Proposed teams, based on current contributions:
Ceph-CSI-Contributors (includes all maintainers too)
* @Madhu-1

* @Rakshith-R

* @ShyamsundarR

* @Yuggupta27

* @agarwal-mudit

* @humblec

* @nixpanic

* @pkalever

* @yati1998

@nixpanic I propose to include @gman0 on the contributors team as he is still around and been a good contributor to this repo.
@leseb can we add him to contributors team?

@Madhu-1 I think above comment ( updating the contribuotrs team) is yet to be addressed..

Reopening as @gman0 is still not added to the team


test: Update CI tests to work with renamed repository

Description of your changes:
Updates CI tests to work with renamed repository
Environment tested:

Python Version (use python --version):
Tekton Version (use tkn version):
Kubernetes Version (use kubectl version):
OS (e.g. from /etc/os-release):

Checklist:

[x] The title for your pull request (PR) should follow our title convention. Learn more about the pull request title convention used in this repository.

/lgtm


Drones Miss Small Rocks on Ashen Gelisol Planets

The drones neglect to collect the small rocks on Ashen Gelisol planets (see image).

This was a config issue. I had to reset mine each time it updated or I changed profiles. Edit your config once we get a working verstion again.


@Dcosthephalump Notebook: Sequence the JupyterLab command specific vim features into a good order for the tutorial (2 hours)

I sequenced the material into three notebooks:

Introduction to the Vim editor
Usage of JupyterLab edit mode
Usage of JupyterLab command mode

This was due to a couple of reasons. First, there are two modes in JupyterLab, edit and command, which each have their own keybindings. After that, if users aren't used to Vim, it might be hard jumping straight in. So, I divided it into three notebooks for users.


Relaxed requirement

@lalithakolla : Do you know if it's OK to relax this requirement?
#PATCH#
Changelog

Relaxed python-jose requirement

the only place we use that is in local cluster, I tested local cluster with python-jose 3.0.0, it worked
do you think, this is something I should push upstream too ??

also it might be better if I setup circle ci for moto ?? they have pretty good tests, I may have to fix few

right now release process is manual, once this is merged, I will make a release manually


Get CLI into a different project

Might require splitting into a separate package with this repo as dependency. For now, everything is under 1 project.

closed in #55


[core-tracing][test-utils] Create test exporter

Currently a few packages (keyvaults) are set up to support tracing, and core-http contains a TracingPolicy. While we have tests for the TracingPolicy, we currently rely on manual testing to ensure that we're starting and ending spans correctly in our data-plane packages.
Writing a custom exporter would go a long way towards writing automatable tests around tracing. The opencensus exporters have access to spans as they are created and ended, so we would have access to all the information needed to verify that our spans are created the way we'd expect.
For creating the tracer needed to create the root span and configure the exporter, we could use the @opencensus/nodejs tracer as a dev dependency.
Note: If/when we support opentelemetry, we may need to create an additional exporter compatibile with that API.

This is no longer needed. core-tracing has a test tracer that can be used for testing:
https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/core/core-tracing/lib/tracers/test


#139456249  setting up test enviroment and integrating coverall code coverage service

What does this PR do?
Setup unit testing for the front end
Setup coverall code coverage service

Description of Task to be completed?

this PR sets jasmine framework to test our codes and also configures karma to make firefox, chrome and phantom js our testing environment
it also configures karma to send our test coverage result to travis using covaralls.

How should this be manually tested?
for the unit testing
(1)clone this repository
(2)create the .js file you want to test and save.
(3) enter the test folder
(4) create new .js file you want to write your test in
(5) include the scripts path in the specRunner.html file with the actual code path coming before the test code path
(6)load the specRunner.html file in your browser
For test coverage service
(1) clone the repo,
(2) install all dependencies
(3) navigate to the location on your Cli
(4) run karma start karma2.conf.js
(5) the browsers will be launched to show karma is working and the tests results on each browser will be displayed on the console
(6) the test coverage result will be shown the coverage folder and on this repository when pushed.
Any background context you want to provide?
this PR contains a travis.yml file for your test coverage
What are the relevant pivotal tracker stories?
Setup unit testing for the front end
Setup coverall code coverage service

Screenshots (if appropriate)
Questions:

Changes Unknown when pulling 88c4b7d9a9d8d1bfd31b8c2f6434b98744dbbf7c on chore/#139456249/integrating-coverall-code-coverage-service into ** on develop**.

Your travis-ci build is failing. Please check it and find out why.

hello oluwayemisi,
i have fixed the bug and travis is now building. thanks

Changes Unknown when pulling 52e7f33d90a05eeedeb6ad43bac1294ff680c075 on chore/#139456249/integrating-coverall-code-coverage-service into ** on develop**.

@andela-uibrahim Your builds are failing...

Changes Unknown when pulling 907f7f7ff91611c48676437471a782cd2a0facb4 on chore/#139456249/integrating-coverall-code-coverage-service into ** on develop**.

hello @andela-ooduye,
I have implemented the feed-backs you requested. i have changed the file names, change the coverage  file format and the travis is now building. please help review the current status


Clean examples directory

This PR is intended as a first step to improving the examples directory. I have

Removed the Bootstrap CSS sheet in favour of using dbc.themes. The examples will still work out of the box if people clone the repo.
Removed example apps that had primarily sprung up as tests during development and weren't great showcases / examples for users.
Renamed app.py to components.py and added new components. This app serves as a simple demo of all the available components.
Added the shiny directory. This contains ports of the simple examples from the shiny gallery. I will probably add some of the more complex ones in the future too. I think it could be useful for anyone coming from Shiny to see how the same sorts of layouts can be built with dash-bootstrap-components.

I'd like to add many more examples, but I think it makes sense to leave those for future PRs.
@pbugnion I added the data files for the Shiny examples to the repo in order that users can run everything out of the box. Perhaps though this is not really ideal / sustainable? Is there a better way? It's really only the wordcloud example that's maybe a problem, the data files for the other examples are very small.

This is great. I have a couple of suggestions:

should we rename the directory gallery instead of shiny? The fact that these are ported from RShiny is a bit irrelevant (though we should probably acknowledge RShiny somewhere).
should we host the data files on a remote server (e.g. S3) and load them dynamically? That way, they don't have to be committed to the repo. If we think that's useful, I can create an S3 bucket in e.g. the ASI account and we can upload the data there. Committing large files is generally considered poor practice since it leads to large diffs and slows down every git command. If we think storing the data on S3 is the way to go, I'm happy to set that up and push directly onto this branch.

That's fair. In the wordcloud and faithful examples I gave links to the shiny analogues in module docstrings at the top of the app.py files. Perhaps adding something similar to the other two examples will suffice and then we rename the directory as you suggest.
I think hosting data on S3 is a great idea. Happy for you to set that up and work on this branch if you'd like to take a stab at it.

I've created a CDN backed by S3 at cdn.opensource.faculty.ai. I seem to be running into some redirection issues at the moment (because of this), but hopefully it'll stabilise in the next couple of hours. When it does, I'll update the examples in this PR to avoid having the data in this repo.
Data files will be available on, e.g. https://cdn.opensource.faculty.ai/wordcloud/romeo-and-juliet.txt.
I chose to create a single CDN for open source at faculty. Data files are likely to be useful across multiple repositories. I created the CDN under the faculty name directly because doing it once is painful enough.
@srstevenson you may be interested in this too.

Tom -- if you don't have access to ASI's root AWS account we can add you.

I opened PR #115, which targets this PR.

Tom -- if you don't have access to ASI's root AWS account we can add you.

I don't think I do. At the very least looking at the S3 console currently I don't see anything that's obviously what you've set up for this.


Inc Request: recovery for missclick on decline

If you accidentally click on decline, there's no way of getting in touch with that person again, unless you get matched again. There's no undo button, no list of declined connections,...

Nvm, it shows up in the feed as "conversation closed - click to reopen again". But the link doesn't work, and it needs a more predictable interface for this than the feed.

duplicated by #1055 -> closing this ticket


VScode suddenly disappeared from computer localdrive

Dear MS Team,
I had installed VS Code 1 month back. Today I couldnt find it on my system. I have not uninstalled or modified anything. So I had to install again. I dont know where the previoulsy installed version went?
Additional info-Integrated VS Code with Github desktop
Kindly look into it please.
Thank you

Strange. Let us know if it happens again.

Strange. Let us know if it happens again.

I can add a second report of this behavior. Went digging to see what I could find at the install location and found this:

A bit deeper the underscore directory has this in it:

Looks like the version sitting in the underscore directory is 1.53.0-insider (based on the package.json in resources/app).
No idea if any of this is helpful or not. I'll try to preserve the install state temporarily if you have any questions you want to ask.

I can add a second report of this behavior. Went digging to see what I could find at the install location and found this:

A bit deeper the underscore directory has this in it:

Looks like the version sitting in the underscore directory is 1.53.0-insider (based on the package.json in resources/app).
No idea if any of this is helpful or not. I'll try to preserve the install state temporarily if you have any questions you want to ask.

Hi team,
Thanks for the response. I shall report if it occurs again.
Regards,
Meghana
On Fri 8 Jan, 2021, 4:07 PM João Moreno<EMAIL_ADDRESS>wrote:

Strange. Let us know if it happens again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/113171#issuecomment-756683599,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG765EYLKODSKEMLFUEW7FDSY3N5JANCNFSM4VCSXX5Q
.

Hi team,
Thanks for the response. I shall report if it occurs again.
Regards,
Meghana
On Fri 8 Jan, 2021, 4:07 PM João Moreno<EMAIL_ADDRESS>wrote:

Strange. Let us know if it happens again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/113171#issuecomment-756683599,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG765EYLKODSKEMLFUEW7FDSY3N5JANCNFSM4VCSXX5Q
.

@wskruse Can you try disabling Windows background updates? Set update.enableWindowsBackgroundUpdates to false.

@wskruse Can you try disabling Windows background updates? Set update.enableWindowsBackgroundUpdates to false.

Done, will report back if the issue recurs.

Done, will report back if the issue recurs.


[OPR-246]: Fixes a race condition with mutual exclusive operations

Coverage increased (+0.07%) to 74.93% when pulling b717683faa1a32f41e3b6bb2a1d6f4103f8d2308 on swift/2_1/feature/OPR-246_mutually_exclusive_deadlock into e08e4c3aab9a23e89dd00cbed6750937f4fb6660 on swift/2.1.


91 feat show current records when editing

feat: Refactoring FieldsContext:
1 - Separing tab fields by subcontext (profile, accounts, addresses);
2 - Adapting tabs to their own subcontext;
feat: Updating fields values with ensData;

Great job!
Found only one small bug. The user should be able to remove one previously set record.
Loom video for reference: https://www.loom.com/share/139018948fae48b7b010b8cfd51efb38

hey Edu, about that bug that you mentioned in the review, I tried to do this transaction, saving an empty record, and the transaction does not erase my old record, for example, if my url is "http://localhost:3000/", and I clear it and try to save as "", after the transaction is complete, if I refresh the page, my url still "http://localhost:3000/"
.
It can be because we're not treating empty fields as it should be, but could also be because the contract doesn't accept changes for empty records, I believe we should create a different issue to investigate and threat this behavior, what do you think?

Great job!
Found only one small bug. The user should be able to remove one previously set record.
Loom video for reference: https://www.loom.com/share/139018948fae48b7b010b8cfd51efb38

hey Edu, about that bug that you mentioned, I tried to do this transaction, saving an empty record, and the transaction does not erase my old record, for example, if my url is "http://localhost:3000/", and I clear it and try to save as "", after the transaction is complete, if I refresh the page, my url still "http://localhost:3000/" . It can be because we're not treating empty fields as it should be, but could also be because the contract doesn't save changes for empty records, I believe we should create a different issue to investigate and threat this behavior, what do you think?

Sounds good!


Set Open_vSwitch hardware offload in config daemon

Previously, we have set ovs hardware offload via the service applied by the Machine Config Operator
(bindata/manifests/switchdev-config/ovs-units.ovs-vswitchd.service).
However, the issue with this approach is that after the user has removed the MachineConfigPool or removed SRIOV all together, ovs hw-offload remains enabled.
This change will instead handle configuring ovs hardware offloading in the config daemon by checking for switchdev devices, and enabling ovs hardware offload only while such devices are detected. We will remove the serviced file responsible for setting ovs-hwol to true on boot. Upon detecting a change in the sriov node policy, we will check for any switchdev devices and set ovs-hwol accordingly. Changes to ovs will result in drain and reboot of the node to ensure changes are applied

Hi @SalDaniele please rebase this PR.
also I have some questions here

is the hw configuration on ovs permanent or it needs to be done after every reboot?
does it needs to be done BEFORE you have workloads in the system?
this will only work if there is the ovs binary commands on the host

@Eoghan1232 be aware this change can impact the /host mount reduction you are working on

Hi @SalDaniele please rebase this PR.
also I have some questions here

is the hw configuration on ovs permanent or it needs to be done after every reboot?

Whatever we configure ovs-hwol to be will persist after each reboot. IIUC a reboot or restart is needed to apply the configuration once we set it with ovs-vsctl set Open_vSwitch ... hw-offload=true

does it needs to be done BEFORE you have workloads in the system?

This is a good point I will need to look into this. When we set it with the systemd file I believe that would mean ovs would always be configured before the workloads. I was triggering a node reboot after setting ovs-vsctl but this resulted in additional reboots when creating / removing sriov policies, so I opted to instead attempt to restart ovs. I wonder if cordoning before and after the restart as Balazs had mentioned would solve this.

this will only work if there is the ovs binary commands on the host

Yes, I have some pending changes I will push w/ the rebase to put this behind a check if utils.ClusterType == utils.ClusterTypeOpenshift.

@Eoghan1232 be aware this change can impact the /host mount reduction you are working on

regarding '2.' we need a cordone/uncordone before/after we restart ovs. This will only happen the first time we enable it. Once we have it enabled, the "hwol == true" will be persistent across reboots. Next time, when ovs starts up, it will already be with hwol enabled and the whole cordone/uncordone dance will be skipped.
The main benefit of this patch is that we get rid of another file we put on the system. This lgtm.

@SalDaniele can we close this one there is a huge work on enable switchdev in the sriov operator


Add 'rosa delete user-role' command

The new command is implemented similarly to rosa delete ocm-role.

Unlink user role if needed.
Detach attached role policies.
Delete permission boundary (doesn't delete the policy).
Delete role.

Related: SDA-5437

@zgalor @tbrisker @pvasant @zvikorn @leshemnoa @vkareh PTAL
I've noticed that when creating a user-role we add a tag rosa_environment: integration/staging/production for our team purposes.
Should I add a check for the environment to this command?
and enable deletion only for the same environment?

@zgalor @tbrisker @pvasant @zvikorn @LeshemNoa @vkareh PTAL
I've noticed that when creating a user-role we add a tag rosa_environment: integration/staging/production for our team purposes. Should I add a check for the environment to this command? and enable deletion only for the same environment?

I think for ocm -role and user-role we can have the warning like how we have for account role i think. The warning should be only for "Stage" or "int" environment and not a customer-facing one.

Because the check for the environment is for our internal use,
Priya and I decided it can be added in a sequence PR, both for delete ocm-role and delete user-role

/lgtm


bump: angular peerDependencies to support 13 to 15

update the angular peerDependencies, so swiper can work with angular 15.
Also, because the angular component use template, and current angular in packages.json version is 13.x, so the built package can not work with any version below 13, but it should work with angular 15.
Again thanks for this great package.

When will you release this?


Add support for symbolic tracing of GPT2 models

What does this PR do?
Addresses test failures from GAUDI2_CI=1  RUN_SLOW=1 python -m pytest tests/transformers/tests/models/gpt2/test_modeling_gpt2.py -s -v -k test_torch_fx
Removes an obstacle for symbolic tracing of GPT2 models. Problem line was [1 for _ in x.shape]. It is impossible to iterate over x.shape during symbolic execution. AFAICT self.bias is broadcast-able with x without re-shaping, and according to PyTorch's broadcasting rules the behavior is identical to the re-shaping.
Adds the GaudiGPT2* models to the supported fx model list in transformers.
@ZhaiFeiyue seems to be the original author.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


[fix][broker] Fix get outdated compactedTopicContext after compactionHorizon has been updated

Motivation
In #20697, we remove the lock of get compactedTopicContext, but compactionHorizon has been updated before  compactedTopicContext is updated. In concurrent cases, this may lead to cursor skip messages of newly compacted or getting an NPE when reading compacted entries.
Modifications
Ensure compactionHorizon is updated after compactedTopicContext.
Remove synchronized in the newCompactedLedger
Verifying this change

[x] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

[ ] Dependencies (add or upgrade a dependency)
[ ] The public API
[ ] The schema
[ ] The default values of configurations
[ ] The threading model
[ ] The binary protocol
[ ] The REST endpoints
[ ] The admin CLI options
[ ] The metrics
[ ] Anything that affects deployment

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository:

Codecov Report

Merging #20984 (f42520b) into master (9862884) will increase coverage by 39.60%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##             master   #20984       +/-   ##
=============================================
+ Coverage     33.53%   73.13%   +39.60%
- Complexity    12174    32249    +20075
=============================================
  Files          1621     1875      +254
  Lines        126919   139406    +12487
  Branches      13851    15329     +1478
=============================================
+ Hits          42561   101960    +59399
+ Misses        78745    29383    -49362
- Partials       5613     8063     +2450

Flag
Coverage Δ

inttests
24.13% <100.00%> (-0.14%)
:arrow_down:

systests
25.11% <100.00%> (?)

unittests
72.44% <100.00%> (+40.39%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

...g/apache/pulsar/compaction/CompactedTopicImpl.java
63.63% <100.00%> (+4.23%)
:arrow_up:

... and 1523 files with indirect coverage changes


Return 401 after oidc was challenged, instead of 302 redirect

client type: Aspnet core 1.0 MVC application.
client definition:
new Client
                {
                    ClientId = "mvc",
                    ClientName = "MVC Client",
                    AllowedGrantTypes = GrantTypes.HybridAndClientCredentials,
                    ClientSecrets =
                    {
                        new Secret("secret".Sha256())
                    },
                    RedirectUris = { "http://localhost:5017/signin-oidc" },
                    PostLogoutRedirectUris = { "http://localhost:5017" },
                    AllowedScopes =
                    {
                        StandardScopes.OpenId.Name,
                        StandardScopes.Profile.Name,
                        StandardScopes.OfflineAccess.Name,
                        "api1"
                    }
                }

MVC client startup.cs settings:
app.UseCookieAuthentication(new CookieAuthenticationOptions
            {
                AuthenticationScheme = "Cookies"
            });

            app.UseOpenIdConnectAuthentication(new OpenIdConnectOptions
            {
                AuthenticationScheme = "oidc",
                SignInScheme = "Cookies",
               Authority = "http://localhost:5000",
                RequireHttpsMetadata = false,
                ClientId = "mvc",
                ClientSecret = "secret",
                ResponseType = "code id_token",
                Scope = { "api1", "offline_access" },
                GetClaimsFromUserInfoEndpoint = true,
                SaveTokens = true
            });

nuget packages:
"Microsoft.AspNetCore.Authentication.Cookies": "1.1.0",
"Microsoft.AspNetCore.Authentication.OpenIdConnect": "1.1.0",

Accessing the controller action with Authorize attribute initiate the authorization process, however instead of redirecting to authorize endpoint with 302 redirect, it says 401 and stops the process.
Problem is with newer version of Authentication.Cookies and OpenIdConnect  nuget packages. Changing version from 1.1.0 to 1.0.*. solve the issue.
I think there is some compatibility problem with IdentityServer4 and newer version of Authentication.Cookies and OpenIdConnect packages.

I think there is a breaking change in 1.1 - try adding AutomaticChallenge=true to the OIDC middleware.

@leastprivilege , adding AutomaticChallenge=true didn't help.
Here is the debug output:
Microsoft.AspNetCore.Hosting.Internal.WebHost:Information: Request starting HTTP/1.1 GET http://localhost:5017/Home/About
Microsoft.AspNetCore.Authorization.DefaultAuthorizationService:Information: Authorization failed for user: (null).
Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker:Warning: Authorization failed for the request at filter 'Microsoft.AspNetCore.Mvc.Authorization.AuthorizeFilter'.
Microsoft.AspNetCore.Mvc.ChallengeResult:Information: Executing ChallengeResult with authentication schemes ().
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Program Files\dotnet\shared\Microsoft.NETCore.App\1.0.1\Microsoft.Win32.Primitives.dll'. Cannot find or open the PDB file.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Users\neera_000\.nuget\packages\System.Security.Cryptography.Encoding\4.3.0\runtimes\win\lib\netstandard1.3\System.Security.Cryptography.Encoding.dll'. Cannot find or open the PDB file.
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Users\neera_000\.nuget\packages\System.Runtime.Numerics\4.3.0\lib\netstandard1.3\System.Runtime.Numerics.dll'. Cannot find or open the PDB file.
Microsoft.AspNetCore.Hosting.Internal.WebHost:Information: Request starting HTTP/1.1 GET http://localhost:44378/.well-known/openid-configuration
IdentityServer4.Hosting.IdentityServerMiddleware:Information: Invoking IdentityServer endpoint: IdentityServer4.Endpoints.DiscoveryEndpoint for /.well-known/openid-configuration

Microsoft.AspNetCore.Hosting.Internal.WebHost:Information: Request finished in 329.2026ms 200 application/json
'dotnet.exe' (CoreCLR: clrhost): Loaded 'C:\Users\neera_000\.nuget\packages\System.IO.Compression\4.3.0\runtimes\win\lib\netstandard1.3\System.IO.Compression.dll'. Cannot find or open the PDB file.
Microsoft.AspNetCore.Hosting.Internal.WebHost:Information: Request starting HTTP/1.1 GET http://localhost:44378/.well-known/openid-configuration/jwks
IdentityServer4.Hosting.IdentityServerMiddleware:Information: Invoking IdentityServer endpoint: IdentityServer4.Endpoints.DiscoveryEndpoint for /.well-known/openid-configuration/jwks
Microsoft.AspNetCore.Hosting.Internal.WebHost:Information: Request finished in 191.4708ms 200 application/json
Microsoft.AspNetCore.Authentication.OpenIdConnect.OpenIdConnectMiddleware:Information: AuthenticationScheme: oidc was challenged.
Microsoft.AspNetCore.Hosting.Internal.WebHost:Information: Request finished in 1837.38ms 401
Exception thrown: 'System.ArgumentNullException' in System.Private.CoreLib.ni.dll
Exception thrown: 'System.ArgumentNullException' in System.Private.CoreLib.ni.dll

I don't follow...
Is the client in the same app as IS? Is IdentityServer4 running in a 1.1 host?

@leastprivilege IS is different than MVC client. Here is the package.json from IS.
{
  "dependencies": {
    "Microsoft.NETCore.App": {
      "version": "1.0.1",
      "type": "platform"
    },
    "Microsoft.ApplicationInsights.AspNetCore": "1.0.0",
    "Microsoft.AspNetCore.Mvc": "1.0.1",
    "Microsoft.AspNetCore.Routing": "1.0.1",
    "Microsoft.AspNetCore.Server.IISIntegration": "1.0.0",
    "Microsoft.AspNetCore.Server.Kestrel": "1.0.1",
    "Microsoft.Extensions.Configuration.EnvironmentVariables": "1.0.0",
    "Microsoft.Extensions.Configuration.FileExtensions": "1.0.0",
    "Microsoft.Extensions.Configuration.Json": "1.0.0",
    "Microsoft.Extensions.Logging": "1.0.0",
    "Microsoft.Extensions.Logging.Console": "1.0.0",
    "Microsoft.Extensions.Logging.Debug": "1.0.0",
    "Microsoft.Extensions.Options.ConfigurationExtensions": "1.0.0",
    "IdentityServer4": "1.0.0-rc3",
    "Microsoft.Extensions.Configuration.UserSecrets": "1.0.0",
    "Microsoft.AspNetCore.Diagnostics": "1.0.0",
    "Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore": "1.0.0",
    "System.Security.Claims": "4.0.1",
    "Microsoft.AspNetCore.Authentication.Google": "1.0.0",
    "Microsoft.AspNetCore.Authentication.Facebook": "1.0.0",
    "Microsoft.AspNetCore.StaticFiles": "1.0.0"
  },

  "tools": {
    "Microsoft.AspNetCore.Server.IISIntegration.Tools": "1.0.0-preview2-final",
    "Microsoft.Extensions.SecretManager.Tools": "1.0.0-preview2-final"
  },

  "frameworks": {
    "netcoreapp1.0": {
      "imports": [
        "dotnet5.6",
        "portable-net45+win8"
      ]
    }
  },

  "buildOptions": {
    "emitEntryPoint": true,
    "preserveCompilationContext": true
  },

  "runtimeOptions": {
    "configProperties": {
      "System.GC.Server": true
    }
  },

  "publishOptions": {
    "include": [
      "wwwroot",
      "**/*.cshtml",
      "appsettings.json",
      "web.config"
    ]
  },

  "scripts": {
    "postpublish": [ "dotnet publish-iis --publish-folder %publish:OutputPath% --framework %publish:FullTargetFramework%" ]
  }
}

And from where is the debug output you pasted above?

Both IS and MVC client are two different projects in a single solution. I run solution with multiple startup projects(both IS and Mvc client).
After clicking on secure action link in Mvc client, l copied it from output window of vs (selecting debug).

It's hard to tell if both log files are mixed together.
Try our clients sample or the quickstarts - and see if they work for you.

I tried my IS with Mvc client from quickstart (mvc hybrid flow). It was working fine. Then I updated packages version in quickstart itself. And it was causing problem. I thought there is some breaking change in those newer versions.

So are you all set now (can we close)?

@brockallen issue still exists with newer packages of Authentication.Cookies and Microsoft.AspNetCore.Authentication.OpenIdConnect. Though it is not a show stopper, anyone can always fall back to version "1.0.0" of these packages and get it running. However, the solution should work with updated versions also.
If someone updates his app to use Microsoft.NETCore.App version 1.1.0, he has to use latest version of these packages and the issue will arise.

We're not supporting 1.1. now -- it's too unstable.

But 1.1 is an RTM version update now people will want to use this.
https://blogs.msdn.microsoft.com/webdev/2016/11/16/announcing-asp-net-core-1-1/

This is not an identityserver issue. The error happens on the client.

This issue got me for a couple of hours. The Quickstart (3) for interactive login does specify using version 1.0.0 of both the Cookies and OpenIDConnect packages, however I was building the application from scratch rather than use the pre-build demo and didn't realize the significance. It maybe worth mentioning not to upgrade in the quickstart, in bold flashing red writing ... ;)

You guys saved me a ton of time, I was wondering why the quickstart sample wasnt working for me. By default everyone who creates a new project tries to take the latest versions of the packages. However, in this case you should have a special red bold comment saying that there is an issue with 1.1.0 on the Creating an MVC Client Quickstart in ID4 docs ... http://docs.identityserver.io/en/release/quickstarts/3_interactive_login.html#creating-an-mvc-client
Thanks a ton Neeraj :)


[TE] rootcause - inconsistent data warning

Rootcause route displays warning if the current value from the anomaly function and the current value retrieved from the backend are different by more than 1 percent.

Good job @harleyjj ! This is very useful.


Added support for variable substitution in job configuration files

Signed-off-by: Yinan Li<EMAIL_ADDRESS>

LGTM


Any colour - Run black on the whole repo

Ran black on the entire repo because seeing the failed test cross on every Pull Request was annoying me.

Testing Status
Everything passes now. All GREEN baby!
Acknowledgement

[x] I have read the Contributing Guidelines

Thank you for your contribution. Please refer to #362 for discussion on this point. I would merge this in a second once/if the consensus of the discussion in that ticket is that we should merge a single PR running black on the whole codebase.

Please do not tell people what to do.

Somehow missed the issue on this, sorry about that.
As @naveen521kk is working on applying black through a GitHub Action (Which is a better way of doing this), I am closing this PR.


Add an option to read inputs from the file system

According to the documentation amalgam will download artifacts from a GitHub repo and upload the resulting universal binary to said repo.
It would be great if the tool allowed to create an universal binary just by passing the input files and did not push the result to GitHub.
I'm thinking if the tool allows this mode of operation then it could be added to the JReleaser package pipeline as an external tool like it already does for upx and cosign.

Actually, amalgam is just an extension of the makefat library that has support for the github download, extract and upload process. If that is not needed it might be better to use https://github.com/randall77/makefat directly! 😀
The official tool provided by Apple to combine macOS binaries into a universal binary is lipo and is present in the macos-11 runners on github. This is the tool the others are based off. It works something like: lipo -create <arm64-binary> <amd64-binary> -output <output-binary>. See https://developer.apple.com/documentation/apple-silicon/building-a-universal-macos-binary
I am happy to add the functionality to just combine into a universal binary to amalgam too but I think if you're planning to add support to JReleaser, it might be better option to use the official Apple tool. Thoughts?

Ah got it, yes it would be better to use lipo directly, a tool I was not aware of.

Looking forward to this using feature whenever it’s released. Thanks @aalmiray !

Considering assembling universal binaries or any binaries for that matter is part of the build process and not the release process I'll have to think about it. There are a few other aspects of assembling binaries (download assembly assets, generating launcher scripts, etc) also fall within the realm of the build tool, similarly as the archive assembly that JReleaser does provide.

Ah okay, that makes sense.


unified matchers: allow emtpy maps

unified matchers: allow emtpy maps: just use OnNoMatch
Description:
The way a control plane might build matches:
matcher := {
  Input: destination ip
  Map: {}, // empty top level map
  OnNoMatch: {
     Input: Destination Port
     Map: {
       15001 -> BlackholeChain
     },
     OnNoMatch: PassthroughChain
  },
}

for _, svc := range services {
  matcher.Map[svc.VIP] = serviceChain(svc)
}

In this example, when the list of services is emtpy the matcher would be rejected due to the empty map.
It's possible to just repair this so that the actual matcher tree looks like:
{
     Input: Destination Port
     Map: {
       15001 -> BlackholeChain
     },
     OnNoMatch: PassthroughChain
  }

Essentially, the suggestion is allow len(map) == 0 if an OnNoMatch exists.
Better yet, it would be nice if this worked even if the OnNoMatch was an action and not a sub-matcher.
I've implemented this (in Go) for cases where we can always guarantee there is a matcher  and not only actions:
https://gist.github.com/stevenctl/74476bcf93e46189d020a93f614e1924
[optional Relevant Links:]
https://github.com/cncf/xds/blob/42e9329d8a3a052b6dc99c1773a2437b407fdd66/xds/type/matcher/v3/matcher.proto#L105

cc @kyessenov

It seems better to perform the repair on the control plane side? Should be easy to detect empty maps and just pull on_no_match to the top?

Thought it may be useful to implement in a way different control planes can share. Is there any precedent for adding utils like this in go-control-plane or elsewhere?
btw I am not saying this is really needed, just a suggestion from someone who doesn't know envoy norms.

Optimizing the match tree seems like a great shared project for control planes. Although I imagine we may want to do some profiling and just-in-time compilation on the data plane because we have better context. That just sounds very advanced at the moment.


discard zero imaginary part for sys.dcgain()

Closes #578

Coverage increased (+0.004%) to 88.949% when pulling f9db86a4cacff9f9bddf0c0d28c57c3042076953 on bnavigator:dcgain-real into 22b99531589a2bbc2cdb9459c08eaf511eff03d8 on python-control:master.


Fix encoding error

Summary
Running autogen.py in Windows fails with the following error:
UnicodeDecodeError: 'cp949' codec can't decode byte 0xbf in position 2: illegal multibyte sequence
Passing utf-8 encoding argument fixes the error.
Related Issues
PR Overview

[n] This PR requires new unit tests [y/n] (make sure tests are included)
[n] This PR requires to update the documentation [y/n] (make sure the docs are up-to-date)
[y] This PR is backwards compatible [y/n]
[n] This PR changes the current API [y/n] (all API changes need to be approved by fchollet)

It seems to be working fine. Perhaps you aren't Python 3?

I'm on Python 3.6.
From the Python 3 docs for open():

if encoding is not specified the encoding used is platform dependent

Explicitly setting the encoding to utf-8
can make this platform independent.


Alternatives to Calligraphr

Making a font in Calligraphr looks like a tedious job. Is there any alternatives to Calligraphr. Any ML projects where already written assignments are scanned and a font is made out of it ?

I've found some websites but the process is very similar to Calligraphr, I haven't really come across any ML project to build font yet.
If anyone knows such projects, do let me know. We can add it in README

I haven't really come across any ML project to build font yet.
If anyone knows such projects, do let me know. We can add it in README

Hey @saurabhdaware, This is what you might be looking for. I am not sure how you will integrate this in your project though xD


Icon vertical heights off between windows and mac (both chrome) - Fix Vertical Metrics

So according to this post and several hours of researching:
https://stackoverflow.com/questions/10044130/custom-fonts-with-differrent-vertical-metrics-between-oss
It seems like this issue is happening because of whitespace above the icons generated.
I tried using configs to adjust heights --fontHeight=0px etc... but no dice.
Apparently everyone goes to https://www.fontsquirrel.com/tools/webfont-generator
Then fixes the vertical heights there, but there's gotta be a way to fix this so it's cross OS compatible!

@tancredi https://github.com/fontello/svg2ttf/issues/48
Looks like this is a known issue

It still seems like an issue from the lib itself, I get that icon-font-generator is a wrapper around webfonts-generator. In webfonts-generator I think it can be fixed where it calls svg2ttf I'm sure there's ways to adjust the ascent or descent or try to center the vertical spacing

@johnjjung thanks for reporting. Seems like the last reply on that issue was in 2016 - worth bumping with an update? I'm not too versed on font rendering (also I've always been using this library with square icons and same sizes so I did not encounter this issue).

Otherwise if you have an idea for a fix on our icon-font-generator level please suggest @johnjjung

I think this problem is still here (correct me if I'm wrong).
When you use icon-font-generator you always have a blank space above icons as you can see here:

I fixed it by adding a line-height on the base tag element. I don't know if it's the best way to go, but it seems working well. Here is an extract of the hbs template edited:
{{ baseTag }}[class^="{{classPrefix}}"],
{{ baseTag }}[class*=" {{classPrefix}}"]{
    font: normal normal normal 14px/1 {{ fontName }};
    font-size: inherit;
}

Not sure why this is closed. Should be reopened imho.
Can confirm also running into this issue. Even though SVG's don't have spacing, icon font glyphs that get generated have extra space on top. Mac ignores this space, but PC does not, so we end up with inconsistent positioning on Mac vs PC that's impossible to fix with CSS since there are no OS-specific media queries.
Can confirm fontello does not add extra space using their online tool.

This might be because windows uses winAscent and winDescent for calculating ascent and descent values.
I created a seperate PR to include this feature
https://github.com/fontello/svg2ttf/issues/95
And the solution for it.
https://github.com/fontello/svg2ttf/pull/96
If done, then one can simply pass an option useTypoMetrics: true and we'll make sure to set the font to use typoMetrics by default and windows will adhere to that.
Hope I was clear in explaining.

I've updated svg2ttf, now desired bit is set.


Add Attachment Support to MessageBuilder

[x] I have checked for similar issues.
[x] I have updated to the [latest JDA version][download].
[x] I have checked the branches or the maintainers' PRs for upcoming features.

Feature Request
Add support for file attachments to the MessageBuilder class.  MessageBuilder currently provides most options for construction of a new Message, but Attachment support is conspicuously absent.
Example Use-Case
When two or more objects are collaborating on the construction of a Message, pass a MessageBuilder around as a container.  Use the new functionality to attach files, when necessary.
Alternative Option
Add getter methods to MessageAction.  MessageAction supports mutable Message construction, similar to MessageBuilder, and does provide Attachment support.  However, it does not offer any way to read data already inside it.  This can be quite inconvenient if collaborating objects need to read each other's contributions to a Message under construction.

We are intending to introduce interfaces to unify the MessageBuilder and the MessageAction related RestActions in v5 which will bring support for attachments to MessageBuilder

That sounds perfect, actually.

@MinnDevelopment Awesome!  Thanks man!


Add Profile: rohitroy-github

Profile Submission

Profile Category
Please select one or more categories for your profile:

[x] Badge 🎖
[x] Minimalistic ✨
[x] Dynamic 🔄
[x] Icons 🎯
[ ] Backgrounds 😎
[ ] GIFS 🖼
[ ] Game Mode 🚀
[x] Code 👨💻

Next Steps
Once you've filled out the information, please comment below:
@all-contributors please add @<username> for review

@rohitroy-github for review


pls add cron job for auto update.

ref to https://www.cyberciti.biz/faq/how-do-i-add-jobs-to-cron-under-linux-or-unix-oses/
“0 0 * * *”. python main.py
“0 * * * *”. python main.py
Run once a week, “0 0 * * 0”.
hope able to add cron job on server so that able to update in automatic way.

ty, auto update has been deployed


Cassandra egg

Hello!
Can U add an Cassandra egg? Cassandra is a database.
I need it for my (big) project :)
Thx for adding it :)

Hello,
I saw that you already requested the egg in the official parkervcp/eggs repository.
That issue caught my attention and I might add it there in the next days. I think the normal Cassandra egg fits better in the official repo, as this repo is just for stuff that we don't think fits in the official repo.

Okay.
No problem.
Thx for your response :)


Docker compose usage

closes #2089

ping

@tabatkins

I now added additional instruction necessary to serve using docker-compose

I now added additional instruction necessary to serve using docker-compose @tabatkins


Enable soft_fail on optional lint steps

Pass soft_fail to optional buildkite steps, to allow them to fail

@mrmr1993 What actions should be PR submitter take to resolve the failing CI in this case?

Alright, closing this again, we'll make another PR to remove the "optional" name


Task9

@swethalavanya03
Task -7
Code verified. Provide annotations and comments
Task -8
Code verified. Provide annotations and comments
Task -9
Code verified. Provide annotations and comments
Task -10
Code verified.


Combine forces with Enigma VM?

Maybe this project should combine forces with Enigma VM? https://github.com/archseer/enigma

I wrote this before watching ErlangRT Code BEAM video. It seems that you have been in contact with Enigma VM developer already.

I don't like some choices and shortcuts he made, i'm writing things the way they should be, which is slower. His goal is to run Elixir ASAP, so I've noticed he uses temporary solutions.
Not sure if showing running Elixir or Erlang shell sooner is worth anything, it is not like there are investors waiting to see a prototype. So my values are different too.


AggregateExec: Take grouping sets into account for InputOrderMode

Which issue does this PR close?

Closes #11291
Rationale for this change

Fixes incorrect InputOrderMode when aggregation has grouping sets
What changes are included in this PR?

When deriving indices for ordered preset, explicitly check all expanded grouping sets
Are these changes tested?

Yes
Are there any user-facing changes?

No

No

I think clippy is failing on this PR due to https://github.com/apache/datafusion/pull/11302


Conversation testing & debugging UX

A functionality to debug and inspect the bot while it is running in the Bot Framework emulator would be a great addition!


Error with rotary embeddings and BFloat16

Describe the bug
When using rotary positional embeddings and BF16, a type mismatch is produced:
Traceback (most recent call last):
  File "/home/hatef.4/neox/gpt-neox/train.py", line 35, in <module>
    main()
  File "/home/hatef.4/neox/gpt-neox/train.py", line 31, in main
    pretrain(neox_args=neox_args)
  File "/home/hatef.4/neox/gpt-neox/megatron/training.py", line 296, in pretrain
    iteration = train(
  File "/home/hatef.4/neox/gpt-neox/megatron/training.py", line 1465, in train
    loss_dict, skipped_iter = train_step(
  File "/home/hatef.4/neox/gpt-neox/megatron/training.py", line 1277, in train_step
    reduced_loss = train_step_pipe(
  File "/home/hatef.4/neox/gpt-neox/megatron/training.py", line 1374, in train_step_pipe
    loss = model.train_batch(data_iter=data_iterator)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/pipe/engine.py", line 362, in train_batch
    self._exec_schedule(sched)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/pipe/engine.py", line 1345, in _exec_schedule
    self._exec_instr(**cmd.kwargs)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/pipe/engine.py", line 657, in _exec_forward_pass
    outputs = super().forward(inputs)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/utils/nvtx.py", line 15, in wrapped_fn
    ret_val = func(*args, **kwargs)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/engine.py", line 1836, in forward
    loss = self.module(*inputs, **kwargs)
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/pipe/module.py", line 365, in forward
    x = self.activation_checkpoint_func(exec_range_func(start_idx, end_idx), *x)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/activation_checkpointing/checkpointing.py", line 989, in checkpoint
    CheckpointFunction.apply(function, all_outputs, *args)
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/autograd/function.py", line 553, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/activation_checkpointing/checkpointing.py", line 566, in forward
    outputs = run_function(*inputs_cuda)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/pipe/module.py", line 344, in exec_func
    inputs = layer(inputs)
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/hatef.4/neox/gpt-neox/megatron/model/transformer.py", line 1302, in forward
    output, moe_loss = super().forward(hidden_states, attention_mask)
  File "/home/hatef.4/neox/gpt-neox/megatron/model/transformer.py", line 1228, in forward
Traceback (most recent call last):
    attention_output, attention_bias = self.attention(
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
  File "/home/hatef.4/neox/gpt-neox/train.py", line 35, in <module>
    main()
      File "/home/hatef.4/neox/gpt-neox/train.py", line 31, in main
    pretrain(neox_args=neox_args)
return forward_call(*args, **kwargs)
  File "/home/hatef.4/neox/gpt-neox/megatron/model/transformer.py", line 952, in forward
  File "/home/hatef.4/neox/gpt-neox/megatron/training.py", line 296, in pretrain
    iteration = train(
  File "/home/hatef.4/neox/gpt-neox/megatron/training.py", line 1465, in train
    loss_dict, skipped_iter = train_step(
  File "/home/hatef.4/neox/gpt-neox/megatron/training.py", line 1277, in train_step
    reduced_loss = train_step_pipe(
  File "/home/hatef.4/neox/gpt-neox/megatron/training.py", line 1374, in train_step_pipe
    loss = model.train_batch(data_iter=data_iterator)
      File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/pipe/engine.py", line 362, in train_batch
    self._exec_schedule(sched)
context_layer = self.attention(
  File "/home/hatef.4/neox/gpt-neox/megatron/model/transformer.py", line 617, in attention
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/pipe/engine.py", line 1345, in _exec_schedule
    self._exec_instr(**cmd.kwargs)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/pipe/engine.py", line 657, in _exec_forward_pass
    outputs = super().forward(inputs)
    context_layer = torch.bmm(attention_probs, value_layer.transpose(0, 1))
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/utils/nvtx.py", line 15, in wrapped_fn
    ret_val = func(*args, **kwargs)
RuntimeError: expected scalar type BFloat16 but found Float  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/engine.py", line 1836, in forward
    loss = self.module(*inputs, **kwargs)

  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/pipe/module.py", line 365, in forward
    x = self.activation_checkpoint_func(exec_range_func(start_idx, end_idx), *x)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/activation_checkpointing/checkpointing.py", line 989, in checkpoint
    CheckpointFunction.apply(function, all_outputs, *args)
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/autograd/function.py", line 553, in apply
    return super().apply(*args, **kwargs)  # type: ignore[misc]
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/activation_checkpointing/checkpointing.py", line 566, in forward
    outputs = run_function(*inputs_cuda)
  File "/home/hatef.4/neox/DeeperSpeed/deepspeed/runtime/pipe/module.py", line 344, in exec_func
    inputs = layer(inputs)
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/hatef.4/neox/gpt-neox/megatron/model/transformer.py", line 1302, in forward
    output, moe_loss = super().forward(hidden_states, attention_mask)
  File "/home/hatef.4/neox/gpt-neox/megatron/model/transformer.py", line 1228, in forward
    attention_output, attention_bias = self.attention(
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1511, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
  File "/home/hatef.4/neox/miniconda3/lib/python3.9/site-packages/torch/nn/modules/module.py", line 1520, in _call_impl
    return forward_call(*args, **kwargs)
  File "/home/hatef.4/neox/gpt-neox/megatron/model/transformer.py", line 952, in forward
    context_layer = self.attention(
  File "/home/hatef.4/neox/gpt-neox/megatron/model/transformer.py", line 617, in attention
    context_layer = torch.bmm(attention_probs, value_layer.transpose(0, 1))
RuntimeError: expected scalar type BFloat16 but found Float

attention_probs here is a Float type instead of BFloat16. I have tracked this down to rotary embeddings but I do not know if this is an issue with all positional embeddings. The issue
To Reproduce
Steps to reproduce the behavior:
Take 1-3B.yml. Delete the "fp16" config arg and add:
  "bf16": {
    "bf16": true,
    "enabled": true,
    "loss_scale": 0,
    "loss_scale_window": 1000,
    "initial_scale_power": 12,
    "hysteresis": 2,
    "min_loss_scale": 1,
  },

I have tracked this down to rotary embeddings but I do not know if this is an Issue with all positional embeddings. The issue is not produced when pos_emb: "none"

Turns out this was just a config issue. You need to specify "precision":"bfloat16" when using bf16, https://github.com/EleutherAI/gpt-neox/pull/1311 should ensure this won't confuse anyone else.


[Feature Request] Support for BEM

Describe the bug
I've tried creating themes based on BEM modifiers, but one theme caused the removal of the base class on the other theme

After applying the right theme (themeName === selectedThemeName)

Then going through the second theme (visualTrialLight)

Steps to reproduce the behavior

Have two themes which use BEM modifiers with a common base class
Apply one theme in one story and the other theme in another story
Check applied classes, one of the stories will only have the class with the modifier and will miss the base class

Hey @GabrielAPineiro 👋
I've addressed this for version 1.0.0 🎉


DollyV2 not utilizing GPU

Hi,
Really excited about using this awesome technology you're all building. I am running some of the example code, specifically the one you put with using DollyV2 for NER described here https://github.com/explosion/spacy-llm/tree/main/usage_examples/ner_dolly .
Everything runs fine and as expected but when I monitor my GPU utilization, it is clear that it is all running on CPU.
I have checked to make sure that torch.cuda.is_available() is true and that my 2 devices are listed but it is still not working. Any idea how to force it to use GPU?
Thanks,
Michael

Hi @mikeybellissimo, thanks for reporting this. Can you provide the full config you're running?

Let me know if you meant you need the full configuration and not just the config file lol

Also potentially worth noting that I have two GPUs on my desktop so not sure if that's contributing to the issue.

Nevermind! I realized that I didn't have cuda-toolkit installed which isn't an issue when I'm using pytorch and transformers directly but this appeared to fix it when I installed. Thank you!

Thanks for the update!


Files will be broken if an update is halted before it its finished

This should be fixed the next time round s3backup is run, but till then that file will remain in an incomplete state. The obvious fix is to initially write to something like /tmp and then move it only when its done. However you need to consider situations where /tmp is on a different file system and thus slow the transfer speed down.

Fixed in a68c29ed0d0d7c3682eb34f41c2452075b8194f5


Connection refused: ftp.gemtalksystems.com

Hi @dalehenrich,
For some reason, GemStone builds fail, because Travis can't access ftp.gemtalksystems.com:
https://travis-ci.org/dalehenrich/builderCI/jobs/63062106#L104
I can access the FTP server, but the performance is rather slow (max. 64 KiB/s).
Any idea what's causing the problem?
Regards,
Fabio

I am late to this party, but there may have been some updates to the ftp.gemtalksystems.com server that broke things temporarily (I seem to recall some issues, but not when they happened ... hitting from web browser but not from script is what I seem to recall) ... I don't think this is a persistent issue so I'l lclose this bug ... reopen or post new issue if this recurs ...

No worries. Just wanted you to double-check this. :smiley:


minos.networks.DynamicHandler must use postgres queues

This issue is a duplicate of https://github.com/Clariteia/minos_microservice_networks/issues/343


Update KOReader to v2022.08

No reMarkable specific changes.
Release notes

Didn't notice the reviewer suggestion. Sorry.

No worries, I just put in whoever the maintainer is.


Support Aries RFC 454 present_proof v2.1 -- sending multiple presentations in a single protocol instance

In aries-rfcs 0454 Present Proof v2.1 the request-presentation message includes the boolean element present_multiple which is intended to cause the prover to include all credentials which meet the conditions of a request-presentation message when it is set to true.  ACA-Py does not currently support this feature.  The purpose of this feature request is to implement changes to allow ACA-Py to understand and respond appropriately when this value is true.
Example case:
Roles:

Alice: Issues credentials to Bob
Bob: Holds credentials and proves them upon request
Cook: Requests verifications from Bob

Assume Alice can issue multiple "food" credentials to Bob.  A food credential has the following characteristics:

attributes: [name, meal, is_favorite]

Alice issues the following credentials to Bob.
[
  {
    "name": "scrambled eggs",
    "is_favorite": false,
    "meal": "breakfast"
  },
  {
    "name": "cookie crisp",
    "is_favorite": true,
    "meal": "breakfast"
  },
  {
    "name": "ham sandwich",
    "is_favorite": true,
    "meal": "lunch"
  },
  {
    "name": "fried rice",
    "is_favorite": true,
    "meal": "dinner"
  },
  {
    "name": "boiled cabbage",
    "is_favorite": false,
    "meal": "dinner"
  }
]

When Cook uses the Present Proof v2 protocol to ask Bob about his credentials we could imagine the following cases:

Cook asks what are Bob's favorite foods.  Bob returns the information for "cookie crisp", "ham sandwich", and "fried rice".
Cook asks what Bob can have for dinner.  Bob returns the information for "fried rice" and "boiled cabbage".
Cook asks what Bob has as favorite foods for breakfast.  Bob returns the information for "cookie crisp" only.

Help wanted on this one:
The next step in implementing this is creating a design document/plan to determine how to support this.  There are multiple considerations that must be covered in the design.

In general, the implementation must ensure that protocol instances that use the v2.0 protocol still work. E.g. if running the protocol with another agent and that agent does not support the v2.1 protocol, ACA-Py must be able to continue to work.

If the other party is the verifier and initiates the protocol (using v2.0), this should be straight forward.
If ACA-Py is the verifier and starts the protocol using v2.1, and the other party (the holder) responds with a v2.0 response message, the ACA-Py instance must adjust gracefully by assuming that v2.1 features have been ignored and cannot be used. This must be conveyed to the controller to decide what to do.

When not using the extended v2.1 features, what protocol version should the ACA-Py instance claim?  I believe the answer is v2.1, but we likely need to test that (using AATH) to verify that.
Should there be a start-up parameter added to allow an ACA-Py instance to default to use the v2.0 or v2.1 protocol version?
What Admin API updates are needed to support the multiple presentation capabilities?

If a startup config parameter is used to indicate only the v2.0 version should be used, what should happen if the v2.1 protocol Admin API parameters are used?

What webhook changes are needed to keep the controller in the loop as the presentations are needed (the holder) or received (the verifier).
What should happen if one of the presentations fails verification?
What AATH tests need to be added to the test suite.

Once v2.1 support is added, all existing tests should continue to work.
At minimum, we need a happy path test -- use the v2.1 protocol, with the test succeeding if both sides support v2.1 and multiple presentations are made or if either (or both) sides support v2.0 and only one presentation is provided.

Should there be a start-up parameter added to allow an ACA-Py instance to default to use the v2.0 or v2.1 protocol version?

I would vote "No". The logic is that if ...

the ACA-Py instance must adjust gracefully by assuming that v2.1 features have been ignored and cannot be used.
then ...
The agent can default to v2.1 and 1) if the agents themselves use none of the v2.1 features, there's no adverse consequence and 2) when ...
the other party (the holder) responds with a v2.0 response message
the agent "must" fall back to v2.0 and will therefore be operating as if v2.0 was the default, without the need for a start-up parameter. This makes the assumption that, on receipt of the response message, the agent can determine the version in use overall by the partner agent, even if no v2.1 features are used in the specific message. Which brings up the question ...

Question:
How does the controller detect that the incoming message is v2.0 rather than v2.1? Will the callback (webhook) request URL contain present_proof_v2_1 instead of present_proof_v2_0 or would the minor version be indicated in some other way, such as a request parameter (ex: ?version=2.1)?

When not using the extended v2.1 features, what protocol version should the ACA-Py instance claim? I believe the answer is v2.1, but we likely need to test that (using AATH) to verify that.
The comments above are based on an opinion where I agree with that answer and am figuring that the tests with v2.1 as default will likely be successful.

When the present_multiple element is implemented, the related element last_presentation should be implemented at the same time (I did not see that mentioned in the OP and previous comment).


Fixed width of the example snapshot.

Added a rule to have all screenshots 320px.

Added a rule to have all screenshots 320px.


Allowing meta-level processing of services

Say I have two services,
#[tarpc::service]
pub trait A{
...}
#[tarpc::service]
pub trait B{
...}

I want to write a function that intakes types of either A or B -- how do I go about it?
Traditional tricks like trait objects, common super trait, etc. don't seem to work.
Is this something that has been discussed in the past?

Hi, thanks for the question! Have you seen the extension methods on the Serve trait, before, after, and before_and_after?

I see those are hook -- I would want to simply accept the two types as a part of the function signature.

A function that is generic over the Serve trait should be able to accept both service implementations after calling serve() on them (which converts them into a type that implements Serve).

But what if I want to call the serve() in the "A function" and not have the user do it?
This is where the issue is -- I know the traits A,B,..  a priori but cannot create the aforementioned function thus far.

Sorry, there is no trait shared by service impls due to Rust's orphan rules. That's why serve() is an extension method rather than a blanket impl.

The service traits live in the user's crate, so tarpc can't reference those traits in a blanket impl.
The #[service] macro itself can't provide an impl because it generates code in the user crate, which is not allowed to provide a blanket impl for the Serve trait, because it would conflict with other crates using tarpc that would also want to provide a blanket impl.

So that is what I am doing at this time. I am using a glue macro to make up for the "service" macro generated structures that are basically superstrings of A and B.


Add a license to the repository

I recently came across your project CHSH_Experiment and I noticed that the repository github.com/SachinValera/CHSH_Experiment currently does not have a license specified.
Why Adding a License is Important?
As GitHub documents

Public repositories on GitHub are often used to share open source software. For your repository to truly be open source, you'll need to license it so that others are free to use, change, and distribute the software.

Would be possible to add a valid license to this repository? Probably something really OpenSource such as the Apache 2.0 license would fit really well.
Thanks!

Dear Juan Cruz-Benito,
Thank you for your suggestion, I've added the Apache 2.0 license to the project!

Thank you!


[Output Log]Timestamp is seconds at UnrealLink but milliseconds at UnrealEngine

After set "Output Log" timestamp to "UTC" or "Local", the timestamp could reach milliseconds, but in Rider UnrealLink only seconds.
Output Log in UE
[2023.12.18-14.40.14:499][140]LogViewport: Scene viewport resized to 2644x1390, mode Windowed.
UnrealLink in Rider
Mon Dec 18 22:40:29 CST 2023  Log          LogViewport               Scene viewport resized to 2644x1390, mode Windowed.
Note: Please ignore the time zone difference.

So could we customize the timestamp format at Rider?


Difficulty installing latest Formly for Angular 13

Hi there,
I am quite new to the ethos and have been struggling to add Formly to my Angular 13 project.
When I execute ng add @ngx-formly/schematics --ui-theme=bootstrap I am met with an error after the package installation
An unhandled exception occurred: NOT SUPPORTED: keyword "id", use "$id" for schema ID
See "C:\Users\User~1\AppData\Local\Temp\ng-YmthAw\angular-errors.log" for further details.

I do see on the GitHub page that Angular 13 is supported when using<EMAIL_ADDRESS>but when executing the first command I see that the package installed is<EMAIL_ADDRESS>might this be an issue? I also see that nothing is added to the AppModule with regards to Formly.
In my error logs, I see files and in investigating the files, I do not see mention of the 'id' the error speaks of.
Am I doing something incorrectly? Please assist.
My package versions.
Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1300.4
@angular-devkit/build-angular   13.0.4
@angular-devkit/core            13.0.4
@angular-devkit/schematics      13.0.4
@angular/cli                    13.0.4
@schematics/angular             13.0.4
rxjs                            7.4.0
typescript                      4.4.4

Error Logs:
[error] Error: NOT SUPPORTED: keyword "id", use "$id" for schema ID
    at Object.code (C:\WorkfolderLocation\node_modules\ajv\dist\vocabularies\core\id.js:6:15)
    at keywordCode (C:\WorkfolderLocation\node_modules\ajv\dist\compile\validate\index.js:454:13)
    at C:\WorkfolderLocation\node_modules\ajv\dist\compile\validate\index.js:222:17
    at CodeGen.code (C:\WorkfolderLocation\node_modules\ajv\dist\compile\codegen\index.js:439:13)
    at CodeGen.block (C:\WorkfolderLocation\node_modules\ajv\dist\compile\codegen\index.js:568:18)
    at iterateKeywords (C:\WorkfolderLocation\node_modules\ajv\dist\compile\validate\index.js:219:9)
    at groupKeywords (C:\WorkfolderLocation\node_modules\ajv\dist\compile\validate\index.js:208:13)
    at C:\WorkfolderLocation\node_modules\ajv\dist\compile\validate\index.js:192:13
    at CodeGen.code (C:\WorkfolderLocation\node_modules\ajv\dist\compile\codegen\index.js:439:13)
    at CodeGen.block (C:\WorkfolderLocation\node_modules\ajv\dist\compile\codegen\index.js:568:18)

I have figured out where the version numbers of Formly are and attempted to add<EMAIL_ADDRESS>but now I am confronted with (what I assume is a warning, it's in red though) The package that you are trying to add does not support schematics. You can try using a different version of the package or contact the package author to add ng-add support.
Would this pose any serious complications down the line?

a stable version of V6 is not released yet, try with next tag instead:
ng add @ngx-formly/schematics@next --ui-theme=bootstrap

Thank you very much for the response.
I think this may just work, I've seen that it updates the AppModule now.  I'll have to do some more digging to make sure that it is working 100% in terms of it still being under development. But I think it will work.
Thank you again.


Allow wildcard actions in filters for history

Explanatory text about the filter from the config:
Track actions which match receiver:action:actor. Actor may be blank to include all. Receiver and Action may not be blank. (eosio::history_plugin)
The filter options are currently too restrictive -- they allow wildcard actors, but trying to track a whole contract is complex and un-ideal. There should be an easier way to specify all actions.
For example, instead of listing all of them:
filter-on = eosio:newaccount:
filter-on = eosio:setcode:
filter-on = eosio:setabi:
... (there's a LOT more)

We could simply do something like
filter-on = eosio:*:*
For any action and any actor.
For even more control, we could insert some kind of basic regex here, such as
filter-on = eosio:[^sellram, ^buyram]:*
or something along those lines, to include everything from eosio except buying and selling ram, for example.

Wildcards on actions open an easy attack vector. Contracts don't reject actions they don't recognize. Someone could spam unknown actions with large payloads to filtered contracts. The history plugin would then store these in shared memory, causing it to fill up, bringing down the node. It's only safe to record actions that the contract limits size on; this is why eosio.token limits the memo field on transfers.

setcode and setabi are examples of actions which should be excluded because of their size in normal use.

I'm just curious - why wouldn't the contract reject actions not defined within their own ABI?

Consistency. If no contract is installed, then all actions are ignored. Contracts add behavior.
If contracts reject actions they don't understand, then contracts which use require_recipient will tend to fail, e.g. eosio.token::tansfer.

Would it be possible to, instead of a "full wildcard", have the wildcard refer specifically to actions that are defined in the ABI? That way we could achieve our desired effect.
There needs to be some easy way of adding a new filter for a new contract to a node without having to replay the full blockchain every time. Or, a way of whitelisting up front which contract we want to listen to the ABI's for (and only actions in the ABI), and store the history of.

have the wildcard refer specifically to actions that are defined in the ABI
This is such a great idea. ATM we have to wrap ABI to manually filter-on = :eosio:*:*

Closing this as it is mostly implemented in https://github.com/EOSIO/eos/pull/4739


Interpolation key 'simulation.fire_start_seed' not found

Issue
When running the main.py of simharness, after installing all the dependencies, initializing the ray cluster, and following the installation process, I encounter this error:
File "/home/userlinux/Documents/simharness-dev/main.py", line 176, in _instantiate_config
    env_settings = instantiate(cfg.environment, _convert_="partial")

raise InterpolationKeyError(f"Interpolation key '{inter_key}' not found")
omegaconf.errors.InterpolationKeyError: Interpolation key 'simulation.fire_start_seed' not found

Althougt in nfs/lslab2/fireline/simharness/experiments/2024-04-18_18-39-00/hydra_output/config.yaml i have:
random:
     seed: ${simulation.fire_start_seed}

Temporaly solution:
Comment out line 79 and 80 in both conf/simulation/train/default.yaml and conf/simulation/eval/default.yaml

This issue has been resolved with the updates in commit https://github.com/mitrefireline/simharness/commit/706d74cc47b30add70f0f3948be4f9df47e69de0.
@Nestor-UVE you should be able to launch a training experiment with the following command:
python main.py -cn train cli.data_dir=$HOME/.simharness

Please create a new issue if you are still having trouble running experiments with main.py on the dev branch. Thank you!


Why was the mirror option removed?

We were using the mirror option because the qt download location is unreliable (it is broken again today, and now the mirror option has gone, our build is failing).
Is there an alternative way to get a different download host?

See the comments on this commit: https://github.com/jurplel/install-qt-action/commit/49465b8677c54237625d80d9294b4c42fa43a645

Thanks, sorted.

Thanks!  That will do; the qt.io link has always been really unreliable!
On Mon, Feb 1, 2021 at 2:51 PM Benjamin O<EMAIL_ADDRESS>wrote:

See the comments on this commit: 49465b8
https://github.com/jurplel/install-qt-action/commit/49465b8677c54237625d80d9294b4c42fa43a645
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jurplel/install-qt-action/issues/80#issuecomment-770913226,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA5M72GN66V4ULE6GEUN23S425WHANCNFSM4W4YBCNQ
.

Yes, it has hasn't it.


Failure/Error: response.should render_template("new") - expecting <"new"> but rendering with <""> (IR 1.3.0, rSpec 2.6.0)

Get the following error with rSpec and generated (resource generator) controller tests.

Failure/Error: response.should render_template("new") - expecting <"new"> but rendering with <"">

using:

inherited_resources 1.3.0
rSpec 2.6.0

anyone with similar problem? Any ideas?

https://github.com/josevalim/inherited_resources/issues/38
You must stub the errors. For some reason errors are not being set or read or something, so just stub them and you're get the proper rendering.


Navbar on small devices

@mariobehling @aayusharora navbar on small devices can be improved by some social media icons.

Interesting point, but I do not see your suggestion, what exactly you would like to have or to do. I have opened an issue with some suggestions, but I am not sure if this is the same as what you want. I am closing this issue as there is no clear outline, what specifically needs to get done. An issue about improving the nav bar in small resolution is here: https://github.com/fossasia/open-event-webapp/issues/835


Using iCheck in react app, how to integrate?

Are you requesting a feature, reporting a bug or ask a question?
Ask a question.
Hello,
May I ask how I can implement the following:
https://plnkr.co/edit/BUTWvvDYmqME5UFlShbe?p=preview
without using JQuery?
I have a react application that does not use JQuery. Basically above seems to just be appending css classes to certain elements, and handling some of the checked/unchecked behaviours, so I think it definitely can be done with just standard JavaScript.
Thank you!
In all the examples that I've found, so far its all JQuery, including the official example.
https://surveyjs.io/Examples/Library/?id=custom-widget-icheck&platform=Reactjs
Thank you!
Specify your

browser: Chrome
browser version: 66.0.3359.181
surveyjs platform: React with no JQuery
surveyjs version: 1.0.10

@cliewdevelop You have to find the widget that does what you need and doesn't require jQuery library.
Here is the example of integrating a widget with comments.
Thank you,
Andrew


Implement .remap() on ZodObject

The ability to modify the fields of a ZodObject schema as a function of the current fields is a much requested feature. This PR implements a new method .remap() to enable this.

https://github.com/colinhacks/zod/issues/2644
https://github.com/colinhacks/zod/issues/2891
https://github.com/colinhacks/zod/pull/2471

Starting with a simple initial schema, this method can overwrite the existing fields as a function of the currentshape.
const User = z
  .object({
    name: z.string(),
    age: z.number(),
  })
  .remap((shape) => ({
    name: shape.name.optional(),
    age: shape.age.nullable(),
  }));

type User = z.infer<typeof User>;
// { name?: string | null; age?: number | null; }

Or it can use string literals to remap keys.
const User = z
  .object({
    name: z.string(),
    age: z.number(),
  })
  .remap(() => ({
    name: "fullname",
    age: "newage",
  }));

type User = z.infer<typeof User>;
// { fullname: string; newage: number; }

For simplicity a plain object syntax is supported as well.
const User = z.object({
  name: z.string(),
  age: z.number(),
});

const ModUser = User.remap({
  name: "fullname",
  age: User.shape.age.optional(),
});

type ModUser = z.infer<typeof ModUser>;
// { fullname: string; age?: number; }

Thanks for this contribution @colinhacks. Curious to know what .remap adds vs .transform it's not straighforward to me. Perhaps I was used to mistakenly use .transform as mapper and .remap does exactly that whereas .transform is more field oriented ?

So I actually think the ambiguity here is kind of a fatal flaw. I also think .remap() would be more valuable as a post-parse transform, as @iiAku had assumed. I'm going to close for now and re-evaluate.


[SVE2] Groups Cluster Server Forces Feature Bit 0 to True

Problem
Today, the Groups cluster implementation for Servers forces feature bit 0 (GN) to be 1/true. This is regardless of what the zap file configuration of the cluster indicates. The consequence of this is that a device maker who uses the provided groups-server.cpp won't actually know what their PICS should be. A device maker should be able to determine their PICS for their device using two inputs, the zap file or their own application code.
Since the Groups cluster ignores the zap file and doesn't allow the application code to make a choice about NameSupport via its Init function, then the device maker might reasonably set their PICS for G.S.F00 to 0/false. Then, when they try to test their device for certification, they will get failures in one or more Groups tests and not understand why.
Taking feature bit values from the zap file and allowing them to be overridden by Init API calls is a reasonable way to ask thousands of device makers to fill out their PICS. Asking thousands of device makers to read the implementation code for every cluster provided by the SDK in order to determine their PICS is not.
See lines 155 and 163 here: https://github.com/project-chip/connectedhomeip/blob/5aa5e8e/src/app/clusters/groups-server/groups-server.cpp#L150
I do not believe this should block 1.0 certification.
Proposed Solution
Two choices:

Have the groups-server.cpp honor the zap file configuration
The above plus allowing application authors to override the zap file explicitly via Init call for the Groups cluster.

Is there an issue grooming process that should pick this up?


Forgot password

Add it to UserController.
But first get the flow right:
(any one has better idea's?)

In the login page, have a "tab" with "forget password"
accept email address,
look it up in the userlist,
generate (and save in user table) a url with a long random string + timestamp,
send it by email,
have a form to enter the new password,
check the random string against the user record + check if timestamp is not older than 1 day
change the password
log in

@jcoppieters  This flow will work fine. Just one slight addition. A random string stored with respect to a user should be valid for a limited time(like 2 days). So you might be tempted to use a Redis client instead.

Yep. You're right. I've changed it.
We have the core part of the system running for a couple of years now, but is not yet integrated with cody-cms.
It is fully async/await based and implements the above flow, including phone by SMS validation and so on.
We never found time to port the CMS part onto the new Core part.


backend support for template compliance check

https://bugzilla.redhat.com/show_bug.cgi?id=1156006

@gmcculloug Please review

@gmcculloug bump

@bzwei Please rebase and push again
@gmcculloug Please review

@bzwei Please rebase and push again

@miq-bot add_label whip

Change the status to [WIP] because we now have a temporary solution for template compliance check #4560. This work is to separate template compliance check from vm compliance check, which conflict with the temporary solution.


Error: Cannot find module 'lodash/each'

It might be me, but it seems that lodash is not specified in both the package.json:
https://github.com/mjmlio/mjml/blob/master/packages/mjml/src/index.js#L2
https://github.com/mjmlio/mjml/blob/master/packages/mjml/package.json
https://github.com/mjmlio/mjml/blob/master/package.json
Error: Cannot find module 'lodash/each'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/<censored>/node_modules/mjml/lib/index.js:19:13)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)

Hi @jellea !
Thanks for this issue, i'll add lodash the mjml package for the next release.
I'm surprised that we didn't catch that earlier, do you still use npm 2.x ?

Hey @iRyusa! Thanks for the quick fix! My npm is on 3.10.10

I'm closing as @iRyusa fixed that in https://github.com/mjmlio/mjml/commit/816f06ea79c3d144ebe55196091e9cb48f270c8e. Thanks for reporting @jellea!