Refactor a method

This is for us to be able to store the long_description and installation_instructions in the app's zipfile, rather than as a separate manual installation step.

market_translations! is now renamed to runtime_translations, no longer mutates its input and is a private method since it is only useful as an input to compile_js.
translations_for is now public so that it can be used instead of market_translations! when persisting translations into a database when apps are uploaded.

Risks

[ medium ] translations stop working for new uploads

@zendesk/vegemite @zendesk/wombat @craig-day can I get some +1s?

👍
Sorry for the nit picks. Since this is refactoring, we might as well try to do things properly :trollface:

👍
This will require breaking changes in users of this method, right (presumably just market)? Should we alias market_translations! or bump a major version?

@timbertson you want this to be strictly semver? ZAM's test suite will fail if run against this without the corresponding changes being made there.

I'd bump a major version if it's known-incompatible, can't hurt right?
If we think this gem is only used by us then we can do what we like. That still includes the option of bumping major versions on a whim though ;)


Trailing comma causes endless loop

If the LETSENCRYPT_HOST variable for a container has a trailing comma, the script does not detect this and attempts to add a certificate for an empty domain name.  This causes simp_le to fail, and the update_certs loop repeats endlessly.

I think that can be easily fixed with adjustment to letsencrypt_service_data.tmpl, I'll give it a try tomorrow.

My fix worked, but as I suspected the same trailing comma in the VIRTUAL_HOST variable cause nginx-proxy / docker-gen to generate an invalid conf file anyway:
nginx-proxy    | 2017/09/01 14:06:46 [emerg] 1#1: invalid number of arguments in "upstream" directive in /etc/nginx/conf.d/default.conf:54
So there is no point in trying to fix that if the nginx.tmpl isn't fixed first to strip the trailing comma from VIRTUAL_HOST.  nginx.tmpl is way more complex than letsencrypt_service_data.tmpl and I'm not good enough with the Go template package to come up with a fix yet.

So the issue is fixed for LETSENCRYPT_HOST by 4085f64, but since a trailing comma in VIRTUAL_HOST will still cause nginx-proxy / docker-gen to generate an invalid nginx config file, I think using trailing commas should still be avoided for now.


Could not load dynamic library 'libcudart.so.10.2'

Hi, im trying to up this docker on my jetson nano, but its show me this error
detector_1  | INFO:flocal.cli:Warming up 1 processes
detector_1  | INFO:flocal.cli:Waiting for warmup to complete
detector_1  | 2021-07-01 19:37:26.444182: W tensorflow/stream_executor/platform/default/dso_loader.cc:60] Could not load dynamic library 'libcudart.so.10.2'; dlerror: libcudart.so.10.2: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/local/cuda/lib64:/usr/local/cuda-10.2/targets/aarch64-linux/lib:
detector_1  | 2021-07-01 19:37:26.444238: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
detector_1  | 2021-07-01 19:37:26.444637: W tensorflow/stream_executor/platform/default/dso_loader.cc:60] Could not load dynamic library 'libcudart.so.10.2'; dlerror: libcudart.so.10.2: cannot open shared object file: No such file or directory; LD_LIBRARY_PATH: /usr/local/cuda/lib64:/usr/local/cuda-10.2/targets/aarch64-linux/lib:
detector_1  | 2021-07-01 19:37:26.444706: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
detector_1  | Traceback (most recent call last):
detector_1  |   File "/usr/local/bin/detector-cli", line 33, in <module>
detector_1  |     sys.exit(load_entry_point('flocal-detector==0.0.0', 'console_scripts', 'detector-cli')())
detector_1  |   File "/usr/local/lib/python3.6/dist-packages/click-8.0.1-py3.6.egg/click/core.py", line 1137, in __call__
detector_1  |     return self.main(*args, **kwargs)
detector_1  |   File "/usr/local/lib/python3.6/dist-packages/click-8.0.1-py3.6.egg/click/core.py", line 1062, in main
detector_1  |     rv = self.invoke(ctx)
detector_1  |   File "/usr/local/lib/python3.6/dist-packages/click-8.0.1-py3.6.egg/click/core.py", line 1668, in invoke
detector_1  |     return _process_result(sub_ctx.command.invoke(sub_ctx))
detector_1  |   File "/usr/local/lib/python3.6/dist-packages/click-8.0.1-py3.6.egg/click/core.py", line 1404, in invoke
detector_1  |     return ctx.invoke(self.callback, **ctx.params)
detector_1  |   File "/usr/local/lib/python3.6/dist-packages/click-8.0.1-py3.6.egg/click/core.py", line 763, in invoke
detector_1  |     return __callback(*args, **kwargs)
detector_1  |   File "/usr/local/lib/python3.6/dist-packages/flocal_detector-0.0.0-py3.6.egg/detector/cli.py", line 101, in server
detector_1  |   File "/usr/local/lib/python3.6/dist-packages/flocal_detector-0.0.0-py3.6.egg/detector/cli.py", line 101, in <listcomp>
detector_1  |   File "/usr/lib/python3.6/concurrent/futures/_base.py", line 425, in result
detector_1  |     return self.__get_result()
detector_1  |   File "/usr/lib/python3.6/concurrent/futures/_base.py", line 384, in __get_result
detector_1  |     raise self._exception
detector_1  | concurrent.futures.process.BrokenProcessPool: A process in the process pool was terminated abruptly while the future was running or pending.

Are you trying to build one of the containers from this repo, or run one of them?   If you are running them manually, did you start it with --runtime nvidia?

Thank you very much!
i add  runtime : nvidia  in my docker-compose.yaml
and now it works thank you so much


IMPROVEMENT_identifier_control

Validate the OrgId identifier is present and allows login. Then return the identifier from CO Person's profile.

Closing. This feature should be rebased on release 1.5. The new PR for the feature is now PR-37


Improve testing of gas estimation with block identifiers

What was wrong?
PR https://github.com/ethereum/eth-tester/pull/189 introduced support for block identifiers (e.g., "latest", "earliest") in the estimateGas method. A "good enough" test was included, but there's lots of room for improvement.
How can it be fixed?
Cherry-picking from the above-mentioned PR:
@carver:

I guess I should have said the best kind of test would be to write a contract that burns gas in a way that's easily detectable by block number, like burning (100k * block_number) gas.

@pipermerriam:

Contract with a toggle-able flag which just returns immediately or burns a bunch of gas in a loop. Then you can set it and test on either side of the block number where the flag was toggled.

I created PR #200 to hopefully resolve this.

Closed with #200


PR: Some readme changes (https and flake8 link)

@rlaverde please refer to the issues on the description

please refer to the issues on the description

done :smile:

Ready for merge?

Ready for merge?

yes

Thanks :-)


vhs: fix #208002 add chromium dependency

Description of changes
Fixes #208002 by adding the dependency on Chromium. Without this
VHS doesn't work and tries to download Chromium itself which fails
on nix.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Please split the changes into two commits

vhs: remove redundant buildInputs
vhs: add chromium to wrapper

Please split the changes into two commits
1. vhs: remove redundant buildInputs

2. vhs: add chromium to wrapper

@NickCao - done!


it does not work with new english from russian tree

it does not work with new english from russian tree
but it works with the old one

Not sure if this is related, but after taking a look at the current A/B tests while working on the d'n'd extension, it appears that Duo intends to change its audio library. Maybe this is only taking place on new courses at the moment.
In any case, I'm going to have a hard time checking this on the tree you mentioned, so don't hesitate to point out if you could reproduce it on another one!

I was about to create a demo account for you when i found that  it works now

it appears that Duo intends to change its audio library

seen this in Spanish tree : setting appear but not available and 1st time the audio played it is truncated


Out of memory [Android] Custom Marker - new Google maps renderer

Bug report

Summary

Out of memory crash, using the new Google renderer on a old Android device.
The app works fine with the LEGACY renderer.
Environment info

Device:
Samsung Galaxy S5 SM-G900F
Android 6.0.1
react-native info output:
    "react": "17.0.2",
    "react-native": "^0.66.4",
    "react-native-maps": "^0.31.0-beta.3",

Steps to reproduce

Enable the new rendered -> add "enableLatestRenderer();" on index.js file

Display the map with a custom marker and specially the parameter "tracksViewChanges={true}"

Wait for the crash

Describe what you expected to happen:

No Out of Memory error

Describe what you actually happens:

Looking at the profiler:

Using the legacy renderer, the memory goes up (< 10mb) then the garbage collector does its job and release the memory
No problem
Using the latest renderer, the memory goes up and never goes down, leading to a Out of memory crash

Log from ADB:

E/System: Uncaught exception thrown by finalizer

E/art: invalid stream - problem with parameter iterator in /data/data/com.google.android.gms/app_chimera/m/00000197/dl-MapsCoreDynamite.integ_214639020308.apk for method void dsx.(long, dsw[], byte[], android.util.SparseIntArray, boolean)

E/art: invalid stream - problem with parameter iterator in /data/data/com.google.android.gms/app_chimera/m/00000197/dl-MapsCoreDynamite.integ_214639020308.apk for method dsx dte.g(glu, java.util.concurrent.atomic.AtomicLong)

E/System: java.lang.OutOfMemoryError: OutOfMemoryError thrown while trying to throw OutOfMemoryError; no stack trace available

E/File: fail readDirectory() errno=2

Reproducible sample code

I use the parameter "tracksViewChanges" because my custom view is an Animated.View.
However the result is the same with a simple view. The other parameters seem to have no impact
<Marker tracksViewChanges={true} coordinate={{ latitude : latitude , longitude : longitude }}>     <CustomMarkerView {...marker} />   </Marker>

I am experiencing the similar "out of memory" issue with the new renderer.

Looks like the Legacy Rendrer is the only option for now. this issue #3969 also disappeared when using Legacy Rendrer.
I hope the Lastest Rendrer becomes stable soon

I experienced this same problem or a very similar one with a map that has 250 Markers.  Each Marker has a custom view that contains an image with some overlaid text, e.g.,
const pinIconSource = ...
const customPinView =
  <View style={styles.numberedPinContainer}>
    <Image source={pinIconSource}/>
    <Text style={styles.numberedPinLabel}>12</Text>
  </View>

Styles (probably not important):
const styles = StyleSheet.create({
  ...
  numberedPinContainer: {
    alignItems: "center",
  },
  numberedPinLabel: {
    top: 1,
    color: "white",
    fontSize: 12,
    fontWeight: "bold",
    position: "absolute",
  },
   ...
});

And later using the customPinView to define a Marker:
<Marker key={...} coordinate={...}
  ...
  {customPinView}
</Marker>

Adding tracksViewChanges={false} fixed the problem or at least made it take much, much longer to occur.  When tracksViewChanges is on, the code in ViewChangesTracker.java repaints each custom Marker's child views into a Bitmap object every 40 milliseconds.  This seems to overwhelm Android's memory allocator / garbage collector.
The disadvantage of turning off tracksViewChanges is that I had to add code to track changes to the views and force a specific Marker to be updated.  I ended up using a unique key each time a Marker's contents changed because I could not get Marker.redraw() to work (that might be a timing issue with my code).

This is still an issue! I am currently running Adroid 13. I am rendering only ONE custom MapMarker and my application seems to freeze after 15 seconds and then a native Android prompt appears saying "App is not responding". If I remove the custom marker and use the default google maps pin, the application runs perfectlly. Here is my code:
<MapView
      initialRegion={{
        latitude: center.latitude,
        longitude: center.longitude,
        latitudeDelta: 0.002,
        longitudeDelta: 0.002,
      }}
      onPress={handleOnPress}
      scrollEnabled={false}
      style={[styles.map, style]}
      zoomEnabled={false}>
      {locations.map(({ coords: { latitude, longitude }, markerUrl }, index) => (
        <Marker key={`marker-${index}`} coordinate={{ latitude, longitude }}>
          <MaterialCommunityIcons
            name={iconDisplay(markerUrl).name}
            size={34}
            color={iconDisplay(markerUrl).color}
          />
        </Marker>
      ))}
    </MapView>

I did try adding tracksViewChanges={false} which sort of works... The app no longer crashes the performance is awful. the application is extremely slow and unusable.
Thanks for all the hard work!!

any fix ? i have very slow maps few seconds and app crash totally

Looks like the Legacy Rendrer is the only option for now. this issue #3969 also disappeared when using Legacy Rendrer.
I hope the Latest Rendrer becomes stable soon

I just commented out enableLatestRenderer();. And it didnt crash like that


Add ZTransducer to encode values of type A into characters streams of JSON data

The JsonEncode type class can have a method encodeJsonTransducer, which returns a ZTransducer[Any, Exception, A, Char], which encodes values of type A into character strings of JSON data.

How would this Transducer be used? Multiple pulled values would have to be pushed containing some delimiter to yield characters that represent valid JSON


Unify frontend and backend development servers

https://www.vistimo.com/feature/9831ec2a-f3ed-4188-ac1d-6a577c1c010c

$ make run should allow you to access:

[ ] http://localhost:5000/
[ ] http://localhost:5000/home
[ ] http://localhost:5000/api
[ ] http://localhost:5000/admin

The frontend half has a README that explains what needs to be installed as a prerequisite, how to run the package manager, and how to run the local server, among other things.
Similar info should be written up about the API; and all of it should probably move to the top level README.

Following the readme, I got to "make run" and was told the database doesn't exist.
Are there scripts for creating/seeding/dropping the database and test database? Or is it easiest to do that manually in djangoworld?

@diiq I think we should just create it manually for now. I added instructions to the README.

It's a bummer to lose color output from the typescript compiler (normally type errors and compile errors are red, etc) but in the interest of progress, let's merge it.


Dribbblish stops working

Describe the bug
A clear and concise description of what the bug is.
Usually after a song changes, Spotify freezes up, audio still plays, but Spotify becomes unresponsive, nothing shows up in the dev-tools.
To Reproduce
Steps to reproduce the behavior:
Screenshots
If applicable, add screenshots to help explain your problem.
After relaunching Spotify nothing loads,

Nothing in dev-tools,

Desktop Setup

Operating System: MacOS 12.0.1
Spotify version: Spotify for macOS (Apple Silicon) <IP_ADDRESS>5.g85e282e2
Spicetify version: 2.8.3
Dribbblish version: 4.0.0

Logs
Add logs from console. To do that

Run spicetify enable-devtool in terminal
Spotify will be restarted
Hit Ctrl + Shift + I to open DevTools window
Navigate to tab Console
Copy console window content.

(Please paste here console logs or attach a screenshot)

Can you detaul how you have installed the theme ?

Downloaded the release, copied into Themes folder(renamed), copied js into extensions, added into config. It was working perfectly before 4.0.0

You need to remove the extra .js files that are no longer used. That's why we have a batch script for installation

There are no extra js files

Can you share the content of config-xpui?

`[Patch]
xpui.js_find_8008 = ,(\w+=)32,
xpui.js_repl_8008 = ,${1}56,
[Setting]
overwrite_assets        = 1
color_scheme            = base
inject_css              = 1
replace_colors          = 1
spotify_launch_flags    =
check_spicetify_upgrade = 0
spotify_path            = /Applications/Spotify.app/Contents/Resources
prefs_path              = /Users/huhridge/Library/Application Support/Spotify/prefs
current_theme           = DribbblishDynamic
[Preprocesses]
disable_sentry        = 1
disable_ui_logging    = 1
remove_rtl_rule       = 1
expose_apis           = 1
disable_upgrade_check = 1
[AdditionalOptions]
extensions            = popupLyrics.js|shuffle+.js|fullappDisplayxFAD.js|dribbblish-dynamic.js
custom_apps           = new-releases|lyrics-plusxFAD
sidebar_config        = 1
home_config           = 1
experimental_features = 1
; DO NOT CHANGE!
[Backup]
version = <IP_ADDRESS>5.g85e282e2
with    = 2.8.3`

[Patch]
xpui.js_find_8008 = ,(\w+=)32,
xpui.js_repl_8008 = ,${1}56,

[Setting]
overwrite_assets        = 1
color_scheme            = base
inject_css              = 1
replace_colors          = 1
spotify_launch_flags    =
check_spicetify_upgrade = 0
spotify_path            = /Applications/Spotify.app/Contents/Resources
prefs_path              = /Users/huhridge/Library/Application Support/Spotify/prefs
current_theme           = DribbblishDynamic

[Preprocesses]
disable_sentry        = 1
disable_ui_logging    = 1
remove_rtl_rule       = 1
expose_apis           = 1
disable_upgrade_check = 1

[AdditionalOptions]
extensions            = popupLyrics.js|shuffle+.js|fullappDisplayxFAD.js|dribbblish-dynamic.js
custom_apps           = new-releases|lyrics-plusxFAD
sidebar_config        = 1
home_config           = 1
experimental_features = 1

; DO NOT CHANGE!
[Backup]
version = <IP_ADDRESS>5.g85e282e2
with    = 2.8.3

I just noticed you did not share the "console" tab in dev tools, can you look for error messages there?

There's nothing there, it was empty

very weird, maybe check for a corrupted .js?

It can't be empty, there has to be at least some warnings like:

its empty, take a look:
https://user-images.githubusercontent.com/67046436/143681357-6554a9b6-fd48-48ad-afc9-e8971189eb41.mov

Huh, that's odd, could you try opening the console and then refreshing the page by right clicking somewhere in Spotify and clicking "Reload"?

Try to uninstall Dribbblish, then run spicetify clear on Bash to remove all backups then run spicetify upgrade to update Spicetify if you had an old version of it and then install the theme again.

Huh, that's odd, could you try opening the console and then refreshing the page by right clicking somewhere in Spotify and clicking "Reload"?

Clicking reloading does nothing

The weird part is that after changing the theme to something, and changing it back, it starts working, then it inevitably stops and I have to do it again, very weird

Can you try latest build?
DribbblishDynamic_vDev-193953d.zip

I'll try and let you know if it stops working.

just so you know, there are some bugs in the dev build, like the search setting not working, and dribbblish-loader staying even after everything has loaded

I have stumbled upon this problem too....same pictures as the one OP sent...and I've followed the steps mentioned in the issue and no use

Can you try latest build? DribbblishDynamic_vDev-193953d.zip

regarding this version after installation here is what I get

same thing happened to me, nothing in dev tools like before

This is what I got in dev tools

I have the same problem for 8 hours now, I have re-installed Spotify, re-installed Spicetify and DribbblishDynamic but nothing seems to work. Is there a way to fix it?
Thank you.

Running into the same issue on MacOS with Dribbblish. Seems like its a combined spicetify and Dribbblish issue because 4.0.0 does not work properly either on the new version of Spotify.

I tried, with the latest release and the new css mappings, same issue as before

Can confirm running spicetify restore backup apply works and fixes the issue.

HI, spicetify restore backup apply doesn't work for me, spotify stuck in "Just one moment..." for a while, but when i delete these line in the config file it works but i can not scroll on the sidebar.
thx for any help i get :)
[Patch]
;xpui.js_find_8008 = ,(\w+=)32,
;xpui.js_repl_8008 = ,${1}58

Does it stops after advertisements? or a specific track?

For me it's working pretty fine after installing the new version

Closing since we don't have any way to reproduce it. Please reopen if you have additional details


ACCUMULO-4673 Review proxy docs & example code

Deleted proxy docs & example code as they were moved
to documentation in accumulo-website repo
proxy.thrift now lives in lib/proxy/thrift of release tarball
generated lang bindings now go to lib/proxy/
proxy.properties file is in conf/templates now
the proxy can now be run using accumulo-service

Corresponding PR to add example code & docs to website repo: https://github.com/apache/accumulo-website/pull/17


"Cannot read property 'match' of undefined" with mostly-blank template

While trying to check a new template the above error message is returned, probably because the template doesn't yet have resources, etc defined.
This should be a nicer error message.

This is happening because there are resources defined, but don't have their Type set yet.


[Question] SolitudeSF/mpdclient

Why there's a 404 error for that repo?

SolitudeSF is not in the allow list:
allowedAuthorsList = @["treeform", "guzba", "nim-lang", "beef331"]```

They would have to ask me to add them.

uh... i was tought that any repo is allowed bruh

anyway, thanks

Its opt in only.


SVP broken by mpv 0.37.0's vf-del removal

Describe the bug
When changing an SVP option during playback or the played file in mpv, starting from mpv 0.37.0, due to https://github.com/mpv-player/mpv/commit/b56e63e2a96b67aff4050d4db06ee67665893c36, it spams:
Option vf-del: 0 doesn't exist.

and SVP no longer reports any connected player at the bottom of its window after that.
Steps To Reproduce

Run SVPManager
Click top left logo, "Open file via mpv", pick a video
While the video is playing, switch back and forth between one of the buttons under "Do frame rate conversion" like "To screen" and "Movie x2"

Expected behavior
In mpv 0.36 and earlier, it says:
Option vf-del: -del is deprecated! Use -remove (removes by content instead of by index).

and SVP keeps working normally.
Additional context
SVP has no source code available and new versions haven't been released on Linux since 2021, while mpv 0.37 came out in November 2023, making it unlikely to be fixed upstream any time soon.
I've made a dirty workaround by forking mpv to re-add the vf-del option, and overriding the source of the mpv package in my flake + home-manager setup. Handling both the external mpv package and the one within SVP's (the mpv that gets used by SVP's in-GUI "Open file") gets complicated - here are the relevant parts:
# flake.nix

inputs = {
    mpvSockets.url = "github:wis/mpvSockets";
    mpvSockets.flake = false;
    mpvSvpFix.url = "github:xrun1/mpv-svp-fix/3d4bc22ad14fcb2f46a3ce6a71b4a7b9ade574ea";
    mpvSvpFix.flake = false;
};
# ...

# mpv.nix (imported as a home-manager module)

{ config, pkgs, lib, inputs, ... }: {
    options.mpvCallArgs = lib.mkOption {
        type = with lib.types; attrsOf unspecified;
        default = [];
    };
    options.mpvScripts = lib.mkOption {
        type = with lib.types; listOf package;
        default = [];
    };

    config.programs.mpv = {
        enable = true;
        package = with pkgs; wrapMpv
            ((mpv-unwrapped.override config.mpvCallArgs).overrideAttrs {
                src = inputs.mpvSvpFix;
            })
            { scripts = config.mpvScripts; };
        config.script = ["${inputs.mpvSockets}/mpvSockets.lua"];
    };
    # ...
}

# svp.nix (imported as a home-manager module)

{ config, pkgs, lib, ... }: {
    home.packages = with pkgs; let
        removeMpv = from:
            lib.filter (pkg: pkg.meta.mainProgram or "" != "mpv") from;

        buildFHSEnv = attrs: pkgs.buildFHSEnv (attrs // { targetPkgs = pkgs:
            (removeMpv (attrs.targetPkgs pkgs)) ++
            [config.programs.mpv.package];
        });
    in [(svp.override { inherit buildFHSEnv; })];

    mpvCallArgs.vapoursynthSupport = true;
    programs.mpv.config.hr-seek-framedrop = "no";  # prevent desyncs on seek
}

Notify maintainers
@xddxdd
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
❯ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.7, NixOS, 24.05 (Uakari), 24.05.20231217.91a0070`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos-23.05"`
 - nixpkgs: `/etc/nix/inputs/nixpkgs`

Add a :+1: reaction to issues you find important.

Thanks for your investigation! Indeed it looks like modifying mpv to add the option back is the best way. Based on the diff on your fork, the change seems small enough for us to maintain. On the other hand, patching SVP is impossible due to its tamper protection.

A couple questions:

When the mpv package gets updated, it might break building SVP with the patch. Do github checks catch these cases, or will the SVP package just be broken until someone else notices?
Should I give you push access to the forked repo, to rebase and regenerate the patch as needed? I rarely update my system, so the repo will likely be left randomly outdated until I have to take care of it.
Can you make the SVP package take mpv-unwrapped and wrapAttrs overridable parameters, so that it isn't so hard to e.g. add scripts to the internal mpv?
Trying to make a standard external mpv connect to SVP will fail since it won't be patched, is there a good way to indicate to users that they should install pkgs.svp.mpv in their environment? The parameters mentioned above should probably also be made known.

SVP package in nixpkgs will be broken. However I also have this SVP package on my NUR, and have daily CI runs to rebuild packages, so once it breaks I will notice and make a fix.
It isn't necessary. I can rebase the patch on mainline mpv as needed.
I will add them.
I can't think of any good way for now.


[Feature Support] : To block apps like Google Reading Mode from accessing book content in our application.

In my eBook application, measures are in place to restrict users from copying book content as a piracy prevention strategy. However, applications such as Google Reading Mode have activated accessibility features, allowing them to access our book content. Is there an approach to block accessibility features in the react-Native-readium package?

Using FLAG_SECURE on your Android window might help. That's in your app though, not in react-native-readium.

@bilalshams7 closing this as completed based on the above comment. LMK if you need anything else on this.


Change FreeTFT definition

We had some feedback that the current definition of FreeTFT creates a quite big split in grid usability.
At the moment a node marked as free to use can only be paid with FreeTFT. Which means you ca basically have 2 separate grid. Once you can use with FreeTFT and one you can use with TFT.
An idea to avoid this is to change the definition of "free to use" for a node. Instead of only being able to pay using FreeTFT, it would instead mean you can pay with TFT or FreeTFT.
The reservation object already accept a list of currency the user is able to pay with. So based on the node free to use status. The escrow could decide what currency to use.
@grimpy @LeeSmet @andhartl

While this idea does make a lot of sense, it also creates another issue. Right now we can get away with a small amount of free to use nodes, because the amount of FreeTFT is limited per user, so the usage of free nodes is also limited as well. If these nodes can be used for regular reservations, the amount of workloads on them will probably be larger. And not everyone will want to make their nodes free to use. So the amount of space for actual free trial workloads might become smaller I think

the amount of space for actual free trial workloads might become smaller I think

Reason being that the capacity of a node is finite and it will maybe used more thus leaving less space for free capacity ?

exactly

exactly

When you allow the farmer to accept both TFT and FreeTFT, he will very likely be positive about accepting FreeTFT as well. So yes, you’re not sure that there will be enough capacity for FreeTFT but on the other hand there will be more nodes available too. And moreover, it won’t split the grid in two pieces anymore, the major drawback of the current definition.
I’d even reverse also the default value for farmers to ‘accept both TFT and FreeTFT’. This way, the ‘burden’ of people exploring freely the grid is spread over equally among all farmers.

When you allow the farmer to accept both TFT and FreeTFT, he will very likely be positive about accepting FreeTFT as well.

I don't see a reason why that would be the case. The other way around, sure. But why would a farmer be happy that people can use his capacity for free if they can also be paid for it?

When you allow the farmer to accept both TFT and FreeTFT, he will very likely be positive about accepting FreeTFT as well.

I don't see a reason why that would be the case. The other way around, sure. But why would a farmer be happy that people can use his capacity for free if they can also be paid for it?

That's how publicity works. A coupon such as FreeTFT is like a coupon in a shop. Shops accept to distribute free samples because this way, people get a taste of what the product is about, of course under the condition that distribution of these samples (FreeTFT) is not exaggerated. But that is not the case: distribution of FreeTFT is hidden behind an application form, so we have full control over how many FreeTFTs are circulating.

Yes publicity is one thing, but making this opt out feels like way want to force the farmer to make publicity on behalf of the foundation, which is still the party that made the grid. Unlike real life, the farmers here are also trying to sell the same product, so the real life free sample, which also serves to compare the product with the competition, does not apply here.
And most importantly, having people deploy free stuff actually costs money for the farmer. Which for me is reason enough to always keep this opt in.

OK, just afraid then that the added value of FreeTFT will remain limited, and that will then give a bad impression to the user. So publicity is not only benefiting the foundation but also for the farmer.
And opt-in or opt-out, turn the switch is really simple.


Failed to watch ref .git/refs/remotes/origin/master, is most likely packed

VSCode Version: 1.44.2
OS Version: Darwin x64 19.3.0

Steps to Reproduce:

Sync -OR- Pull from repo

> git remote --verbose
Failed to watch ref '/Users/ted/git/xxxx/.git/refs/remotes/origin/master', is most likely packed.
Error: ENOENT: no such file or directory, watch '/Users/ted/git/xxxx/.git/refs/remotes/origin/master'
    at FSWatcher.start (internal/fs/watchers.js:165:26)
    at Object.watch (fs.js:1270:11)
    at Object.t.watch (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/git/dist/main.js:1:598268)
    at T.updateTransientWatchers (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/git/dist/main.js:1:83870)
    at e.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:48:517)
    at e.updateModelState (/Applications/Visual Studio Code.app/Contents/Resources/app/extensions/git/dist/main.js:1:102740)
> git config --get commit.template

Does this issue occur when all extensions are disabled?: Yes

$ ls -l .git/refs/remotes/origin/
-rw-r--r--  1 ted  staff  32 Apr 26 09:40 HEAD


Renaming SOUserPin to Management key

Would it be possible to align this term with those of the Yubikey ecosystem? I found it to be much more confusing to be call it SO Pin.

This seems like a reasonable request 👍

SOUserPin is confusing as SO means Security Officer, so you can either be an SO or a User. The naming "Management Key" is yubikey specific, others call it SOPin, Puk, or maybe something else.

@florianeichin but since this is Yubikey-specific (it is yubikeystore.go after all), do you see any pitfall in mentioning "Management Key"?

@ruimarinho  No I think it's absolutely reasonable to call the pin whatever the vendor calls it. in this case "Management Key".

Yubikey also calls it PUK FWIW


Moving some diagnostic properties to the debug level

This should make the ThemeData debug output more sane.
Also, modify the recording canvas to print longer numbers when there is a mismatch, since it's impossible to tell 3.8 from 3.78988282, and that is sometimes very relevant.
Otherwise you get output like "the radius (3.8) is not the expected radius (3.8)", which is useless and misleading.

 for the diagnostics changes.
For the mock canvas changes I think we should consider a helper function that compares the truncated strings to see if they need to be untruncated, and prefers using truncated values if possible.
For Offset, I think we should just fix https://github.com/flutter/flutter/issues/1221, which would solve the problem more uniformly.

Bonus points for a test that creates a basic MaterialApp app and then verifies that none of the lines of debugDumpApp output exceed something like 120 characters.

PTAL: I didn't do the "bonus points", but I did make a pass at fixing the debug output for doubles.

i think I'd prefer that we just fix #1121 the full way (in c++ in dart:ui) than paper over the issue here.


Make the ServiceBinding validation webhook less strict

Hi team,
When we define a ServiceBinding as part of our service's Helm chart, and we deploy our Chart using Piper's kubernetesDeploy, the deployment will only work the first time, to create the ServiceBinding. Any subsequent deployments will be denied, even if the ServiceBinding hasn't changed, with the following error :
14:59:08  info  kubernetesDeploy - running command: helm upgrade policysearch-canary pss-0.1.0.tgz --values helm/pss/values/canary.yaml --install --namespace pss --set image.policy_search.repository=345301178081-20231221-135051596-506.staging.repositories.cloud.sap/policy-search,image.policy_search.tag=1.0.0-20231221134941_6ca6edd5ddf276c6b9dccbd889b4083d77e31ee6@sha256:2aaf78d298a9edf1ec4bc61d2dc375c4e88836bd7f0aee568ee70110d0752b46,image.repository=345301178081-20231221-135051596-506.staging.repositories.cloud.sap/policy-search,image.tag=1.0.0-20231221134941_6ca6edd5ddf276c6b9dccbd889b4083d77e31ee6@sha256:2aaf78d298a9edf1ec4bc61d2dc375c4e88836bd7f0aee568ee70110d0752b46,secret.name=regsecret,secret.dockerconfigjson=****,imagePullSecrets[0].name=regsecret,api.image.repository=345301178081-20231221-135051596-506.staging.repositories.cloud.sap/policy-search,api.image.tag=1.0.0-20231221134941_6ca6edd5ddf276c6b9dccbd889b4083d77e31ee6@sha256:2aaf78d298a9edf1ec4bc61d2dc375c4e88836bd7f0aee568ee70110d0752b46,api.imagePullSecret.dockerconfigjson=**** --force --wait --timeout 300s --atomic --render-subchart-notes
14:59:09  Created Pod: kubernetes concurcpss/dynamic-agent-e98acbb0-18af-4fb1-9e07-444f8e05b32c-7ss7c-11chr
14:59:13  info  kubernetesDeploy - Error: UPGRADE FAILED: an error occurred while rolling back the release. original upgrade error: failed to replace object: admission webhook "vservicebinding.kb.io" denied the request: updating service bindings is not supported: failed to replace object: admission webhook "vservicebinding.kb.io" denied the request: updating service bindings is not supported

This forces teams to either manage the ServiceBinding outside of the service lifecycle, or remove the declaration from the templated chart while still keeping the resource alive thanks to "helm.sh/resource-policy": keep.
Is there any way we could ease things here ?

There is a simple workaround that I missed :

forceUpdates: false for the kubernetesDeploy step (doc)


Fix chisel-server command flags

Add: chisel server --reverse flag
Fixes: flags like auth, authfile, key, and certificates when set were not being used by the service (the entire line was commented). Changed default values to empty, which is not set/false for templating, to enable adding the line only when those flags are needed/set.

Hi @ronaldosaheki, thanks for the PR!


SW-5032 Remove background illustration

Remove the background SVG image from the app. This eliminates the
need for some component parameters that only controlled whether or
not the background was used.

#2724  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgrimm and the rest of your teammates on  Graphite


Fix Qwen neural speed

Type of Change
feature or bug fix or documentation or others
API changed or not
Description
detail description
JIRA ticket: xxx
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed

https://inteltf-jenk.sh.intel.com/view/nlp-toolkit-validation/job/nlp-toolkit-validation-top-mr-extension/1673/

https://inteltf-jenk.sh.intel.com/job/nlp_toolkit_deploy_validation_localtest/15750/
test pass


Caching

With the plugin-based architecture (and the requirement of 1 site per database) the site will not be as efficient as it could be.
Get caching working to ensure the site doesn't slow down too much due to this.

Caching has been configured using memcached
it still needs to be documented though so I'll leave this open until that is done

This has been disabled by default as having it run correctly over a load of plugins is very difficult and not worth the time right now.
I'll leave this without a milestone for now.


maven-war-plugin v3.2.3 cause error

Since the upgrade to maven-war-plugin v3.2.3 from 3.2.2 the war package can't be generated anymore.
Here is the error:
4257 [INFO] ------------------------------------------------------------------------
4257 [INFO] BUILD FAILURE
4257 [INFO] ------------------------------------------------------------------------
4258 [INFO] Total time: 3.782 s
4258 [INFO] Finished at: 2020-05-05T18:47:09+02:00
4385 [INFO] Final Memory: 39M/473M
4385 [INFO] ------------------------------------------------------------------------
4387 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:3.2.3:war (default-war) on project email-preview: Execution default-war of goal org.apache.maven.plugins:maven-war-plugin:3.2.3:war failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-war-plugin:3.2.3:war: java.lang.NoSuchMethodError: org.codehaus.plexus.archiver.jar.JarArchiver.setMinimalDefaultManifest(Z)V
4387 [ERROR] -----------------------------------------------------
4387 [ERROR] realm =    plugin>org.apache.maven.plugins:maven-war-plugin:3.2.3
4387 [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
4387 [ERROR] urls[0] = file:/opt/repo_maven/local/org/apache/maven/plugins/maven-war-plugin/3.2.3/maven-war-plugin-3.2.3.jar
4387 [ERROR] urls[1] = file:/opt/repo_maven/local/org/codehaus/plexus/plexus-archiver/3.0.1/plexus-archiver-3.0.1.jar
4387 [ERROR] urls[2] = file:/opt/repo_maven/local/org/codehaus/plexus/plexus-io/2.6/plexus-io-2.6.jar
4387 [ERROR] urls[3] = file:/opt/repo_maven/local/org/iq80/snappy/snappy/0.3/snappy-0.3.jar
4387 [ERROR] urls[4] = file:/opt/repo_maven/local/org/sonatype/sisu/sisu-inject-bean/1.4.2/sisu-inject-bean-1.4.2.jar
4387 [ERROR] urls[5] = file:/opt/repo_maven/local/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar
4387 [ERROR] urls[6] = file:/opt/repo_maven/local/org/sonatype/aether/aether-util/1.7/aether-util-1.7.jar
4387 [ERROR] urls[7] = file:/opt/repo_maven/local/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar
4387 [ERROR] urls[8] = file:/opt/repo_maven/local/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
4387 [ERROR] urls[9] = file:/opt/repo_maven/local/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
4387 [ERROR] urls[10] = file:/opt/repo_maven/local/org/apache/maven/maven-archiver/3.4.0/maven-archiver-3.4.0.jar
4387 [ERROR] urls[11] = file:/opt/repo_maven/local/org/apache/maven/shared/maven-shared-utils/3.2.1/maven-shared-utils-3.2.1.jar
4387 [ERROR] urls[12] = file:/opt/repo_maven/local/commons-io/commons-io/2.5/commons-io-2.5.jar
4387 [ERROR] urls[13] = file:/opt/repo_maven/local/org/codehaus/plexus/plexus-interpolation/1.25/plexus-interpolation-1.25.jar
4387 [ERROR] urls[14] = file:/opt/repo_maven/local/com/thoughtworks/xstream/xstream/1.4.10/xstream-1.4.10.jar
4387 [ERROR] urls[15] = file:/opt/repo_maven/local/xmlpull/xmlpull/<IP_ADDRESS>/xmlpull-<IP_ADDRESS>.jar
4387 [ERROR] urls[16] = file:/opt/repo_maven/local/xpp3/xpp3_min/1.1.4c/xpp3_min-1.1.4c.jar
4387 [ERROR] urls[17] = file:/opt/repo_maven/local/org/codehaus/plexus/plexus-utils/3.2.0/plexus-utils-3.2.0.jar
4387 [ERROR] urls[18] = file:/opt/repo_maven/local/org/apache/maven/shared/maven-filtering/3.1.1/maven-filtering-3.1.1.jar
4387 [ERROR] urls[19] = file:/opt/repo_maven/local/org/sonatype/plexus/plexus-build-api/0.0.7/plexus-build-api-0.0.7.jar
4387 [ERROR] urls[20] = file:/opt/repo_maven/local/org/apache/maven/shared/maven-mapping/3.0.0/maven-mapping-3.0.0.jar
4387 [ERROR] Number of foreign imports: 1
4387 [ERROR] import: Entry[import  from realm ClassRealm[maven.api, parent: null]]

and the context:
Apache Maven 3.2.3 (33f8c3e1027c3ddde99d3cdebad2656a31e8fdf4; 2014-08-11T22:58:10+02:00)
Maven home: /opt/apache-maven-3.2.3
Java version: 1.8.0_252, vendor: Private Build
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: fr_FR, platform encoding: UTF-8
OS name: "linux", version: "5.3.0-51-generic", arch: "amd64", family: "unix"

moving back to maven-war-plugin version 3.2.2 run well the mvn package !

@jgribonvald sounds like is could be similar to https://stackoverflow.com/questions/14736283/maven-build-error-failed-to-execute-goal-missing-a-class and https://stackoverflow.com/questions/12364296/maven-failed-to-execute-goal-org-apache-maven-pluginsmaven-jar-plugin
Does maven package -X provide more detailed logs?

@ChristianMurphy the error provided is already with the maven debug option, all information provided are in this log, the complete stacktrace doesn't provide more things.
One thing, this happen also with maven 3.6.x.
I reported the error from someone and in waiting I told him to run with the lower version of mvn-war-plugin.

the error provided is already with the maven debug option, all information provided are in this log, the complete stacktrace doesn't provide more things.

understood, thanks

One thing, this happen also with maven 3.6.x.

:thinking: interesting

And if you watch on last travis test, all are failing since the merge of this update commit, you can see on the same error !


Please invite me to the Recode-Hive GitHub Community Organization

Name
Srinidhi Kulkarni
Discord Username (if applicable)
srinidhi9469
Additional Context
No response

Invitation sent to join the GitHub Organisation. Welcome to the community 🎉
Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/recodehive/people


[EmojiUtility] Clear recent emoji

As the title suggest, make a button to allow user clear their recent emoji on emoji picker.
Why? Why not?

just clear app data xd

Well yes, but it also clear configurations set on setting :'D
Plus, Desktop users can clear it with JS snippet provided, ofc there's interest for this feature :eyes:


Fastlane Swift + CVS

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
I'm switching to Swift Fastlane, and have migrated most of my lanes so far.
However, I'm now a bit at a loss about what to do with the fastlane/swift folder.
Since Fastfile.swift and other relevant files reside under fastlane/, I feel like the other parts in fastlane/swift should be auto-generated at any time, but am looking for either a reason it shouldn't, or how to achieve this, since I think that part doesn't belong in my git history.
Could anyone point me in the right direction?

@daneov Heyy 👋 The fastlane/swift folder is a copy of the Swift buildings (that are generated specifically for that version of fastlane).  You shouldn't need to do anything with the content that are in the fastlane/swift directory - these are just needed for fastlane to do its thing 💪


Fix installpath for KerbalScieneExchange

adresses https://github.com/KSP-CKAN/CKAN-meta/issues/450

#rebuild because it's trying to build an unrelated .netkan aswell


Fix leaky history by isolating CodeMirror document instances by key

Fixes: https://github.com/google/playground-elements/issues/154
Context
Adds a new property, documentKey which can be used to isolate history and CodeMirror document instances.
Why
Currently setting value programmatically, or via a user edit in the codemirror instance results in undo/redo history being added to a single instance.
This becomes a pain point when modeling a file system on top of the <playground-code-editor>, because changing to a new file is interpreted by CodeMirror as the user inserting the new file value into a single global document instance. This results in bugs where it's possible to trigger a file change and then "undo" the file change value.
See video of file change followed by undo (can repro at https://lit.dev/playground/):
https://user-images.githubusercontent.com/15080861/153515054-a05a0d05-bf03-43bb-9282-064a14f92bfc.mov
How
documentKey drives an internal CodeMirror document instance. Changing the documentKey will either create a new document instance or reuse a previous one. Each document instance has isolated history.
The value property and text typed by the user is still the source of truth, and the documentKey just associates which CodeMirror instance is being edited.
Testing
This has been tested manually via configurator, as well as with many programmatic tests as I was understanding each behavior.

playground-code-editor_test.ts demonstrates programmatic changes to value and documentKey.
playground-ide_test.ts emulates direct edits to the codemirror instance, file swapping, and undo/redo actions.
Note that renaming a file preserves file history because the file object reference is unchanged.
Note that changing only the documentKey doesn't drive a value change. On contention between the value cached on the document instance and value property, the document instance is updated to match the value.

Backwards compatibility
The <playground-code-editor> remains backwards compatible if documentKey is not used. Any of the elements using a virtual file system will no longer allow undoing into a previous file's contents.

Please enjoy your PTO! I'm very happy to wait till next week! Also your feedback is REALLY great!


Cannot add repo in Coveralls

SLCosmo does not appear in Coveralls' list of DESC repos. I wonder why it is not being picked up? I issued this at Coveralls too, speculating that 70 public repos might be the limit for an organization... but maybe I am doing something wrong?

I was able to get it to appear on the Coveralls ADD REPOS page by clicking the RE-AUTHORIZE WITH GITHUB button at the bottom of that page.

Aha! I will remember that. Thanks Jim!
On Mon, Jul 18, 2016 at 3:27 PM, James Chiang<EMAIL_ADDRESS>wrote:

I was able to get it to appear on the Coveralls ADD REPOS page by
clicking the RE-AUTHORIZE WITH GITHUB button at the bottom of that page.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DarkEnergyScienceCollaboration/SLCosmo/issues/6#issuecomment-233478276,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArY97BpFD6bCIQXTanxK2QFn7aLvf6Sks5qW_3tgaJpZM4JOLQO
.


Quick-start set of links to dev/test/prod

where can a viznoob go to find these links?

done here: https://github.com/USGS-VIZLAB/vizlab/wiki/URLs


fix: python test_api change for scripted_modules

Description
This change is a workaround for python api_test with scripted module. It works with recent torch APIs
Fixes # (issue)
Type of change
Non-Breaking change.
Please delete options that are not relevant and/or add your own.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

[x] My code follows the style guidelines of this project (You can use the linters)
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas and hacks
[ ] I have made corresponding changes to the documentation
[ ] I have added tests to verify my fix or my feature
[x] New and existing unit tests pass locally with my changes

This PR is split into two different PRs.
https://github.com/NVIDIA/Torch-TensorRT/pull/735/files
https://github.com/NVIDIA/Torch-TensorRT/pull/736/files
Closing this PR


Modify extendModel/extendCollection to modify specific routes (issues 740 and 736).

...ute to match unique routes. 736: implemented Restangular.getFullRoute() to return the complete route chain for a particular element. Added underscore.js to jshint global ignore list. Updated documentation to reflect ability to use regular expressions in extendModel/extendCollection.

This seems to be related to #1430, which separates regex transformers from simple string transformers.


Google Maps Keyboard Interaction Issue

This seems to work for mouse events, but keyboard events are being missed:
public getMapEventElement() {
  // TODO: This is a bit hacky, maybe there is a better solution here
  const selector = 'div[style*="z-index: 3;"]';
  return this._map.getDiv().querySelector(selector) as HTMLDivElement;
}

This means that unlike other Adapters, feature deletion is not working for the Google Maps Adapter.

Hey @morehawes thanks for raising this! I think I have a feeling I know roughly what is going on here. Let me dig into it when I get a moment and see if there is a clean solution to make this work for both cursor and keyboard events for the Google Maps Adapter.

Okay, so I've dug into this a bit more this afternoon and it's quite strange - Google Maps seems to swallow all keyboard events, regardless of what div you place the event handler on. By default it also seems to set the focused element to the body which seems odd compared to other mapping libraries which focus on the container or an element within it.
Thank you for your PR for this, but just want to approach this slightly different by not setting this at the base.adapter level as I not sure this issue should impact other drawing adapters. The reason here is if you are not focused on the map you would not want to allow keyboard shortcuts to trigger an event like deletion etc.
Appreciate you finding this issue and your continued support here @morehawes !

Hi @JamesLMilner
Yeah it really makes things difficult!

Thank you for your PR for this, but just want to approach this slightly different by not setting this at the base.adapter level

That makes absolute sense! I'll close that PR.
Cheers.


How to choose the radius size when I need to look for neighbours of each point

Hi,
I'm replicating your code, but using a different data set. I want to know how I can set the search radius to find neighbours points. In your paper, you just said: where σ is the inﬂuence distance of the kernel points, and will be chosen according to the input density, whereas in your code (config.py) you set some default values for the radius and density parameters, I wanna know if there was any reference when I'm going to set the search radius?

Hi @Luan-Zhaoliang,
the parameters you are interested in are defined here:
https://github.com/HuguesTHOMAS/KPConv-PyTorch/blob/ccb820bbb7a18e4642c317bc8a80d26164f7f3c1/train_S3DIS.py#L102-L112

first_subsampling_dl controls the size of the subsampling grid cells in meters. So here it is set to 3cm.
conv_radius is the radius of the neighborhood (for rigid KPConv). The unit is the number of grid cells. So here it is set to 2.5 grid cells = 7.5cm.
deform_radius is the same as conv radius but for deformable KPConv (ignore it if you do not use deformable layers)
KP_extent is the the inﬂuence distance of the kernel points. This is the σ in our paper, but it does not affect the effective radius of neighbors. The unit is also the number of grid cells. Here I used 1.2 which is a bit larger that the value 1.0 used in the paper.

I hope this helps.

Hi Thomas,
Very thanks for your reply. It is very helpful for me.
regards, Zhaoliang

发件人: Hugues THOMAS<EMAIL_ADDRESS>发送时间: 2020年5月11日 16:33
收件人: HuguesTHOMAS/KPConv-PyTorch<EMAIL_ADDRESS>抄送: Zhaoliang Luan<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>主题: Re: [HuguesTHOMAS/KPConv-PyTorch] How to choose the radius size when I need to look for neighbours of each point (#5)
Hi @Luan-Zhaolianghttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLuan-Zhaoliang&data=02|01||a1df63edaca64c1d3c7108d7f5c09956|569df091b01340e386eebd9cb9e25814|0|1|637248079864448982&sdata=ZxoPcrBVirSomSYDX%2BSE2YnU95qLzqNjqKqJhvXee7U%3D&reserved=0,
the parameters you are interested in are defined here:
https://github.com/HuguesTHOMAS/KPConv-PyTorch/blob/ccb820bbb7a18e4642c317bc8a80d26164f7f3c1/train_S3DIS.py#L102-L112https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FHuguesTHOMAS%2FKPConv-PyTorch%2Fblob%2Fccb820bbb7a18e4642c317bc8a80d26164f7f3c1%2Ftrain_S3DIS.py%23L102-L112&data=02|01||a1df63edaca64c1d3c7108d7f5c09956|569df091b01340e386eebd9cb9e25814|0|1|637248079864448982&sdata=SXeE79yEHabFpIgCM92FNXIQcgdgAE%2Fc1eI83%2FXnmgQ%3D&reserved=0

first_subsampling_dl controls the size of the subsampling grid cells in meters. So here it is set to 3cm.
conv_radius is the radius of the neighborhood (for rigid KPConv). The unit is the number of grid cells. So here it is set to 2.5 grid cells = 7.5cm.
deform_radius is the same as conv radius but for deformable KPConv (ignore it if you do not use deformable layers)
KP_extent is the the inﬂuence distance of the kernel points. This is the σ in our paper, but it does not affect the effective radius of neighbors. The unit is also the number of grid cells. Here I used 1.2 which is a bit larger that the value 1.0 used in the paper.

I hope this helps.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FHuguesTHOMAS%2FKPConv-PyTorch%2Fissues%2F5%23issuecomment-626778035&data=02|01||a1df63edaca64c1d3c7108d7f5c09956|569df091b01340e386eebd9cb9e25814|0|1|637248079864458977&sdata=RWMRzJCyOHeuGGd3PyhGFc4EuIMKbPPaM0%2FI5GIuZZM%3D&reserved=0, or unsubscribehttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPBUPY32UAEX77U3NHCAGSLRRALC7ANCNFSM4M52W4KA&data=02|01||a1df63edaca64c1d3c7108d7f5c09956|569df091b01340e386eebd9cb9e25814|0|1|637248079864458977&sdata=xmJAz8nI%2BdRrLecdxO0DFoHcOfNOpe5nNemzFVvNgbM%3D&reserved=0.

Hi, thank you for sharing this great work ! I have a question related to what you said in this issue. If I have a denser dataset, in which direction should I change these parameters? Should I increase or decrease their values?

Hi @jedolb,
It depends on what kind of objects you are trying to detect. Having a denser dataset allows you to reduce the first_subsampling_dl, and therefore have shapes with finer details. To avoid having your memory explode, you also want to reduce the in_radius (which was not listed above and controls the size of the input sphere) parameter accordingly. In that case your network will be better on small objects but could lose performances on very big objects.
If your dataset is denser but still have big objects, then maybe this density is not useful to you and you can keep a higher first_subsampling_dl and in_radius.
In any case, the other parameters should remain the same as a change of dataset density will not affect them.

Thank you very much for your quick answer and your explanations !
Actually, I'm trying to train a KPConv network on accumulated Lidar data. I accumulated the sequences of the SemanticKitti dataset, and I've cut out sections of 20m2. So I feed the network with these sections. One section looks like this :

I made a first training with the parameters of train_SemanticKitti.py . The results are not that bad, the validation accuracy is 0,8.  Here a prediction :

Some classes are well detected like cars or buildings. But he can't tell the difference between road, sidewalk and terrain. I guess I can increase performance. I've big objects, but I may have enough detail to reduce first_subsampling_dl and in_radius. There's no harm in trying :)

Exactly, for this kind of application where you are not sure which values are the best, you can just try a bunch of them.
I would advise to start from the parameters of NPM3D dataset which is a similar situation. and then experiment to finetune the values. In any case, road, sidewalk and terrain are very challenging classes when you don't have colors, as they have nearly the same geometric shape. You could try to use the lidar intensity value but I think this is not going to help.
Good luck with your problem.

I will first try with the parameters of NPM3D then
Thanks again for your help! It is very helpful for me


URL Reset and Authentication Failure: Reloading Page as Unauthenticated User Results in URL Clearing and 400 Error

✅ Prerequisites

[x] Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
[x] Are you running the latest SDK version?
[x] Are you reporting to the correct repository (magic-sdk)?

🐛 Description
Upon attempting to reload the page with the URL baseURL/?category=nfts while not authenticated, an unexpected issue arises. Instead of maintaining the current URL, the page's URL inexplicably reverts back to the base baseURL. This anomaly is further exacerbated by the receipt of a 400 error from the https://auth.magic.link/v1/session/refresh URL, a component associated with user authentication.
🧩 Steps to Reproduce

Visit https://codesandbox.io/p/github/Adebesin-Cell/Magic-Connector-Bug/main

Click on the "Hi, Click Me" button.

The page should change the URL to baseURL/?category=nfts

The button also triggers a reload, after a while the URL clears and shows the log about refresh failing.

Once the request fails, the whole URL resets

🤔 Expected behavior
baseURL/?category=nfts is meant to be the URL, not a reset URL. Expected behavior can be gotten by logging in with meta mask wallet and the page URL doesn't clear.
😮 Actual behavior
An uncalled request clears the URL to the base URL.
Stack Trace

💻 Code Sample
Here's the code repo to test the issue. https://github.com/Adebesin-Cell/Magic-Connector-Bug
🌎 Environment

Software
Version(s)

@magiclabs/wagmi-connector
^1.1.0

Browser
Chrome

yarn
v1.22.19

Operating System
MacOS

Hi, is there any update with this issue?


Add NoUnexpectedThunks instances

As Edsko's not working tomorrow, I have addressed my comments myself. Now the only thing blocking this PR is https://github.com/input-output-hk/cardano-ledger/pull/647 where it is again bors standing in the way of progress 😩.

bors r+


Coverage can be deleted for published resource

Pull Request Checklist:

[x] Positive Test Case Written by Dev

[ ] Automated Testing

[ ] Sufficient User and Developer Documentation

[ ] Passing Jenkins Build

[ ] Peer Code review and approval

Positive Test Case

Locally create a resource.
Add spatial and temporal coverage data to the resource. Add any additional metadata required for publishing the resource.
Then publish the resource. Though this is not going to be an actual publish, for the purpose of testing it should work.
Check that you are able to delete both spatial and temporal coverage for this published resource.

METRIC
VALUE

NEW CODE SMELLS
0

NEW DUPLICATED LINES DENSITY
0.0

NEW VULNERABILITIES
0

NEW SECURITY HOTSPOTS
0

NEW BUGS
0

https://sonarqube.cuahsi-workstation.com:9000/dashboard?id=hydroshare-4333


Build not working on FreeBSD

gem install mailcatcher results in the following error log:
Building native extensions. This could take a while...
ERROR:  Error installing mailcatcher:
        ERROR: Failed to build gem native extension.

    current directory: /usr/local/lib/ruby/gems/2.6/gems/eventmachine-<IP_ADDRESS>/ext
/usr/local/bin/ruby26 -I /usr/local/lib/ruby/site_ruby/2.6 -r ./siteconf20201117-1954-1urdxvk.rb extconf.rb
checking for -lcrypto... yes
checking for -lssl... yes
checking for openssl/ssl.h... yes
checking for openssl/err.h... yes
checking for rb_trap_immediate in ruby.h,rubysig.h... no
checking for rb_thread_blocking_region()... no
checking for ruby/thread.h... yes
checking for rb_thread_call_without_gvl() in ruby/thread.h... yes
checking for inotify_init() in sys/inotify.h... no
checking for __NR_inotify_init in sys/syscall.h... no
checking for writev() in sys/uio.h... yes
checking for rb_thread_fd_select()... yes
checking for rb_fdset_t in ruby/intern.h... yes
checking for pipe2() in unistd.h... yes
checking for accept4() in sys/socket.h... yes
checking for SOCK_CLOEXEC in sys/socket.h... yes
checking for rb_wait_for_single_fd()... yes
checking for rb_enable_interrupt()... no
checking for rb_time_new()... yes
checking for sys/event.h... yes
checking for sys/queue.h... yes
checking for clock_gettime()... yes
checking for CLOCK_MONOTONIC_RAW in time.h... no
checking for CLOCK_MONOTONIC in time.h... yes
CXXFLAGS=-O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing  -isystem /usr/local/include  -Wall -Wextra -Wno-deprecated-declarations -Wno-ignored-qualifiers -Wno-unused-result -Wno-address
creating Makefile

current directory: /usr/local/lib/ruby/gems/2.6/gems/eventmachine-<IP_ADDRESS>/ext
make "DESTDIR=" clean

current directory: /usr/local/lib/ruby/gems/2.6/gems/eventmachine-<IP_ADDRESS>/ext
make "DESTDIR="
compiling binder.cpp
In file included from binder.cpp:20:
In file included from ./project.h:165:
In file included from ./em.h:24:
In file included from /usr/local/include/ruby-2.6/ruby.h:33:
In file included from /usr/local/include/ruby-2.6/ruby/ruby.h:2111:
/usr/local/include/ruby-2.6/ruby/intern.h:56:19: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
void rb_mem_clear(register VALUE*, register long);
                  ^~~~~~~~~
/usr/local/include/ruby-2.6/ruby/intern.h:56:36: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
void rb_mem_clear(register VALUE*, register long);
                                   ^~~~~~~~~
2 warnings generated.
compiling cmain.cpp
In file included from cmain.cpp:20:
In file included from ./project.h:165:
In file included from ./em.h:24:
In file included from /usr/local/include/ruby-2.6/ruby.h:33:
In file included from /usr/local/include/ruby-2.6/ruby/ruby.h:2111:
/usr/local/include/ruby-2.6/ruby/intern.h:56:19: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
void rb_mem_clear(register VALUE*, register long);
                  ^~~~~~~~~
/usr/local/include/ruby-2.6/ruby/intern.h:56:36: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
void rb_mem_clear(register VALUE*, register long);
                                   ^~~~~~~~~
2 warnings generated.
compiling ed.cpp
In file included from ed.cpp:20:
In file included from ./project.h:165:
In file included from ./em.h:24:
In file included from /usr/local/include/ruby-2.6/ruby.h:33:
In file included from /usr/local/include/ruby-2.6/ruby/ruby.h:2111:
/usr/local/include/ruby-2.6/ruby/intern.h:56:19: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
void rb_mem_clear(register VALUE*, register long);
                  ^~~~~~~~~
/usr/local/include/ruby-2.6/ruby/intern.h:56:36: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
void rb_mem_clear(register VALUE*, register long);
                                   ^~~~~~~~~
2 warnings generated.
compiling em.cpp
In file included from em.cpp:23:
In file included from ./project.h:165:
In file included from ./em.h:24:
In file included from /usr/local/include/ruby-2.6/ruby.h:33:
In file included from /usr/local/include/ruby-2.6/ruby/ruby.h:2111:
/usr/local/include/ruby-2.6/ruby/intern.h:56:19: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
void rb_mem_clear(register VALUE*, register long);
                  ^~~~~~~~~
/usr/local/include/ruby-2.6/ruby/intern.h:56:36: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register]
void rb_mem_clear(register VALUE*, register long);
                                   ^~~~~~~~~
em.cpp:1232:40: error: invalid operands to binary expression ('__bind<int &, sockaddr *&, int &>' and 'int')
                if (bind (sd, bind_to, bind_to_size) < 0) {
                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
/usr/include/c++/v1/system_error:306:1: note: candidate function not viable: no known conversion from '__bind<int &, sockaddr *&, int &>' to 'const std::__1::error_condition' for 1st argument
operator<(const error_condition& __x, const error_condition& __y) _NOEXCEPT
^
/usr/include/c++/v1/system_error:383:1: note: candidate function not viable: no known conversion from '__bind<int &, sockaddr *&, int &>' to 'const std::__1::error_code' for 1st argument
operator<(const error_code& __x, const error_code& __y) _NOEXCEPT
^
/usr/include/c++/v1/utility:596:1: note: candidate template ignored: could not match 'pair' against '__bind'
operator< (const pair<_T1,_T2>& __x, const pair<_T1,_T2>& __y)
^
/usr/include/c++/v1/iterator:720:1: note: candidate template ignored: could not match 'reverse_iterator' against '__bind'
operator<(const reverse_iterator<_Iter1>& __x, const reverse_iterator<_Iter2>& __y)
^
/usr/include/c++/v1/iterator:1161:1: note: candidate template ignored: could not match 'move_iterator' against '__bind'
operator<(const move_iterator<_Iter1>& __x, const move_iterator<_Iter2>& __y)
^
/usr/include/c++/v1/iterator:1533:1: note: candidate template ignored: could not match '__wrap_iter' against '__bind'
operator<(const __wrap_iter<_Iter1>& __x, const __wrap_iter<_Iter2>& __y) _NOEXCEPT_DEBUG
^
/usr/include/c++/v1/tuple:1165:1: note: candidate template ignored: could not match 'tuple' against '__bind'
operator<(const tuple<_Tp...>& __x, const tuple<_Up...>& __y)
^
/usr/include/c++/v1/memory:2974:1: note: candidate template ignored: could not match 'unique_ptr' against '__bind'
operator< (const unique_ptr<_T1, _D1>& __x, const unique_ptr<_T2, _D2>& __y)
^
/usr/include/c++/v1/memory:3032:1: note: candidate template ignored: could not match 'unique_ptr' against '__bind'
operator<(const unique_ptr<_T1, _D1>& __x, nullptr_t)
^
/usr/include/c++/v1/memory:3041:1: note: candidate template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'int'
operator<(nullptr_t, const unique_ptr<_T1, _D1>& __x)
^
/usr/include/c++/v1/memory:4812:1: note: candidate template ignored: could not match 'shared_ptr' against '__bind'
operator<(const shared_ptr<_Tp>& __x, const shared_ptr<_Up>& __y) _NOEXCEPT
^
/usr/include/c++/v1/memory:4882:1: note: candidate template ignored: could not match 'shared_ptr' against '__bind'
operator<(const shared_ptr<_Tp>& __x, nullptr_t) _NOEXCEPT
^
/usr/include/c++/v1/memory:4890:1: note: candidate template ignored: could not match 'shared_ptr<type-parameter-0-0>' against 'int'
operator<(nullptr_t, const shared_ptr<_Tp>& __x) _NOEXCEPT
^
/usr/include/c++/v1/string_view:674:6: note: candidate template ignored: could not match 'basic_string_view' against '__bind'
bool operator<(basic_string_view<_CharT, _Traits> __lhs, basic_string_view<_CharT, _Traits> __rhs) _NOEXCEPT
     ^
/usr/include/c++/v1/string_view:681:6: note: candidate template ignored: could not match 'basic_string_view' against '__bind'
bool operator<(basic_string_view<_CharT, _Traits> __lhs,
     ^
/usr/include/c++/v1/string_view:689:6: note: candidate template ignored: could not match 'basic_string_view<type-parameter-0-0, type-parameter-0-1>' against 'int'
bool operator<(typename common_type<basic_string_view<_CharT, _Traits> >::type __lhs,
     ^
/usr/include/c++/v1/string:3931:1: note: candidate template ignored: could not match 'basic_string' against '__bind'
operator< (const basic_string<_CharT, _Traits, _Allocator>& __lhs,
^
/usr/include/c++/v1/string:3940:1: note: candidate template ignored: could not match 'basic_string' against '__bind'
operator< (const basic_string<_CharT, _Traits, _Allocator>& __lhs,
^
/usr/include/c++/v1/string:3949:1: note: candidate template ignored: could not match 'const _CharT *' against '__bind<int &, sockaddr *&, int &>'
operator< (const _CharT* __lhs,
^
/usr/include/c++/v1/map:1572:1: note: candidate template ignored: could not match 'map' against '__bind'
operator< (const map<_Key, _Tp, _Compare, _Allocator>& __x,
^
/usr/include/c++/v1/map:2117:1: note: candidate template ignored: could not match 'multimap' against '__bind'
operator< (const multimap<_Key, _Tp, _Compare, _Allocator>& __x,
^
/usr/include/c++/v1/set:868:1: note: candidate template ignored: could not match 'set' against '__bind'
operator< (const set<_Key, _Compare, _Allocator>& __x,
^
/usr/include/c++/v1/set:1356:1: note: candidate template ignored: could not match 'multiset' against '__bind'
operator< (const multiset<_Key, _Compare, _Allocator>& __x,
^
/usr/include/c++/v1/vector:3378:1: note: candidate template ignored: could not match 'vector' against '__bind'
operator< (const vector<_Tp, _Allocator>& __x, const vector<_Tp, _Allocator>& __y)
^
/usr/include/c++/v1/deque:2898:1: note: candidate template ignored: could not match 'deque' against '__bind'
operator< (const deque<_Tp, _Allocator>& __x, const deque<_Tp, _Allocator>& __y)
^
em.cpp:1654:6: error: value of type '__bind<int &, sockaddr *&, int &>' is not contextually convertible to 'bool'
        if (bind (sd_accept, bind_here, bind_size)) {
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
em.cpp:1714:53: error: invalid operands to binary expression ('__bind<int &, sockaddr *, unsigned long>' and 'int')
        if (bind (sd, (struct sockaddr*)&sin, sizeof(sin)) != 0)
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~
/usr/include/c++/v1/system_error:420:1: note: candidate function not viable: no known conversion from '__bind<int &, sockaddr *, unsigned long>' to 'const std::__1::error_code' for 1st argument
operator!=(const error_code& __x, const error_code& __y) _NOEXCEPT
^
/usr/include/c++/v1/system_error:425:1: note: candidate function not viable: no known conversion from '__bind<int &, sockaddr *, unsigned long>' to 'const std::__1::error_code' for 1st argument
operator!=(const error_code& __x, const error_condition& __y) _NOEXCEPT
^
/usr/include/c++/v1/system_error:430:1: note: candidate function not viable: no known conversion from '__bind<int &, sockaddr *, unsigned long>' to 'const std::__1::error_condition' for 1st argument
operator!=(const error_condition& __x, const error_code& __y) _NOEXCEPT
^
/usr/include/c++/v1/system_error:435:1: note: candidate function not viable: no known conversion from '__bind<int &, sockaddr *, unsigned long>' to 'const std::__1::error_condition' for 1st argument
operator!=(const error_condition& __x, const error_condition& __y) _NOEXCEPT
^
/usr/include/c++/v1/utility:588:1: note: candidate template ignored: could not match 'pair' against '__bind'
operator!=(const pair<_T1,_T2>& __x, const pair<_T1,_T2>& __y)
^
/usr/include/c++/v1/iterator:728:1: note: candidate template ignored: could not match 'reverse_iterator' against '__bind'
operator!=(const reverse_iterator<_Iter1>& __x, const reverse_iterator<_Iter2>& __y)
^
/usr/include/c++/v1/iterator:950:1: note: candidate template ignored: could not match 'istream_iterator' against '__bind'
operator!=(const istream_iterator<_Tp, _CharT, _Traits, _Distance>& __x,
^
/usr/include/c++/v1/iterator:1051:6: note: candidate template ignored: could not match 'istreambuf_iterator' against '__bind'
bool operator!=(const istreambuf_iterator<_CharT,_Traits>& __a,
     ^
/usr/include/c++/v1/iterator:1169:1: note: candidate template ignored: could not match 'move_iterator' against '__bind'
operator!=(const move_iterator<_Iter1>& __x, const move_iterator<_Iter2>& __y)
^
/usr/include/c++/v1/iterator:1545:1: note: candidate template ignored: could not match '__wrap_iter' against '__bind'
operator!=(const __wrap_iter<_Iter1>& __x, const __wrap_iter<_Iter2>& __y) _NOEXCEPT_DEBUG
^
/usr/include/c++/v1/iterator:1577:1: note: candidate template ignored: could not match '__wrap_iter' against '__bind'
operator!=(const __wrap_iter<_Iter1>& __x, const __wrap_iter<_Iter1>& __y) _NOEXCEPT_DEBUG
^
/usr/include/c++/v1/tuple:1130:1: note: candidate template ignored: could not match 'tuple' against '__bind'
operator!=(const tuple<_Tp...>& __x, const tuple<_Up...>& __y)
^
/usr/include/c++/v1/memory:1991:6: note: candidate template ignored: could not match 'allocator' against '__bind'
bool operator!=(const allocator<_Tp>&, const allocator<_Up>&) _NOEXCEPT {return false;}
     ^
/usr/include/c++/v1/memory:2969:1: note: candidate template ignored: could not match 'unique_ptr' against '__bind'
operator!=(const unique_ptr<_T1, _D1>& __x, const unique_ptr<_T2, _D2>& __y) {return !(__x == __y);}
^
/usr/include/c++/v1/memory:3016:1: note: candidate template ignored: could not match 'unique_ptr' against '__bind'
operator!=(const unique_ptr<_T1, _D1>& __x, nullptr_t) _NOEXCEPT
^
/usr/include/c++/v1/memory:3024:1: note: candidate template ignored: could not match 'unique_ptr<type-parameter-0-0, type-parameter-0-1>' against 'int'
operator!=(nullptr_t, const unique_ptr<_T1, _D1>& __x) _NOEXCEPT
^
/usr/include/c++/v1/memory:4804:1: note: candidate template ignored: could not match 'shared_ptr' against '__bind'
operator!=(const shared_ptr<_Tp>& __x, const shared_ptr<_Up>& __y) _NOEXCEPT
^
/usr/include/c++/v1/memory:4866:1: note: candidate template ignored: could not match 'shared_ptr' against '__bind'
operator!=(const shared_ptr<_Tp>& __x, nullptr_t) _NOEXCEPT
^
/usr/include/c++/v1/memory:4874:1: note: candidate template ignored: could not match 'shared_ptr<type-parameter-0-0>' against 'int'
operator!=(nullptr_t, const shared_ptr<_Tp>& __x) _NOEXCEPT
^
/usr/include/c++/v1/functional:2390:1: note: candidate template ignored: could not match 'function' against '__bind'
operator!=(const function<_Rp(_ArgTypes...)>& __f, nullptr_t) _NOEXCEPT {return (bool)__f;}
^
/usr/include/c++/v1/functional:2395:1: note: candidate template ignored: could not match 'function<type-parameter-0-0 (type-parameter-0-1...)>' against 'int'
operator!=(nullptr_t, const function<_Rp(_ArgTypes...)>& __f) _NOEXCEPT {return (bool)__f;}
^
/usr/include/c++/v1/string_view:643:6: note: candidate template ignored: could not match 'basic_string_view' against '__bind'
bool operator!=(basic_string_view<_CharT, _Traits> __lhs, basic_string_view<_CharT, _Traits> __rhs) _NOEXCEPT
     ^
/usr/include/c++/v1/string_view:652:6: note: candidate template ignored: could not match 'basic_string_view' against '__bind'
bool operator!=(basic_string_view<_CharT, _Traits> __lhs,
     ^
/usr/include/c++/v1/string_view:662:6: note: candidate template ignored: could not match 'basic_string_view<type-parameter-0-0, type-parameter-0-1>' against 'int'
bool operator!=(typename common_type<basic_string_view<_CharT, _Traits> >::type __lhs,
     ^
/usr/include/c++/v1/string:569:6: note: candidate template ignored: could not match 'fpos' against '__bind'
bool operator!=(const fpos<_StateT>& __x, const fpos<_StateT>& __y)
     ^
/usr/include/c++/v1/string:3902:1: note: candidate template ignored: could not match 'basic_string' against '__bind'
operator!=(const basic_string<_CharT,_Traits,_Allocator>& __lhs,
^
/usr/include/c++/v1/string:3911:1: note: candidate template ignored: could not match 'const _CharT *' against '__bind<int &, sockaddr *, unsigned long>'
operator!=(const _CharT* __lhs,
^
/usr/include/c++/v1/string:3920:1: note: candidate template ignored: could not match 'basic_string' against '__bind'
operator!=(const basic_string<_CharT, _Traits, _Allocator>& __lhs,
^
/usr/include/c++/v1/map:1581:1: note: candidate template ignored: could not match 'map' against '__bind'
operator!=(const map<_Key, _Tp, _Compare, _Allocator>& __x,
^
/usr/include/c++/v1/map:2126:1: note: candidate template ignored: could not match 'multimap' against '__bind'
operator!=(const multimap<_Key, _Tp, _Compare, _Allocator>& __x,
^
/usr/include/c++/v1/set:877:1: note: candidate template ignored: could not match 'set' against '__bind'
operator!=(const set<_Key, _Compare, _Allocator>& __x,
^
/usr/include/c++/v1/set:1365:1: note: candidate template ignored: could not match 'multiset' against '__bind'
operator!=(const multiset<_Key, _Compare, _Allocator>& __x,
^
/usr/include/c++/v1/vector:3370:1: note: candidate template ignored: could not match 'vector' against '__bind'
operator!=(const vector<_Tp, _Allocator>& __x, const vector<_Tp, _Allocator>& __y)
^
/usr/include/c++/v1/deque:2890:1: note: candidate template ignored: could not match 'deque' against '__bind'
operator!=(const deque<_Tp, _Allocator>& __x, const deque<_Tp, _Allocator>& __y)
^
em.cpp:1998:6: error: value of type '__bind<int &, sockaddr *, unsigned long>' is not contextually convertible to 'bool'
        if (bind (sd_accept, (struct sockaddr*)&s_sun, sizeof(s_sun))) {
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings and 4 errors generated.
*** Error code 1

Stop.
make: stopped in /usr/local/lib/ruby/gems/2.6/gems/eventmachine-<IP_ADDRESS>/ext

make failed, exit code 1

Gem files will remain installed in /usr/local/lib/ruby/gems/2.6/gems/eventmachine-<IP_ADDRESS> for inspection.
Results logged to /usr/local/lib/ruby/gems/2.6/extensions/amd64-freebsd-12/2.6/eventmachine-<IP_ADDRESS>/gem_make.out

MailCatcher relies on very old dependencies, and some of these no longer build in newer environments. But updating these dependencies is blocked by a few issues, sory.


Improve Kibana setup

Squashed commits and added release commit after Josh's approval, hence force-push.


Save button tool tip hangs and flicker on the screen after a save action

Save button tool tip hangs and flicker on the screen after a save action.

@elsylambert will retest once tooltips are integrated.

Retested in Beta-14. Not seeing this behaviour.


when running email search api not correct

when i run a email search it says api key not provided or its not valid even though i have a valid api key

Duplicate of https://github.com/thewhiteh4t/pwnedOrNot/issues/64


Add MAC addresses to the Common Information Model

We're using OSSEM as a standard model for the platform we're building. Currently OSSEM does not define field names for MAC addresses. We would like to add those.

Hey @l0x-c0d3z ! sorry for the late response. Yeah that would be great. would you mind sharing what you have put together for your platform via a PR? I would like to know what works for you and I am sure it would benefit this project. Let me know if you could do that? Thank you in advance!

NVM! 😆 sorry I didnt check the PRs first. I appreciate your help and contribution to the project @l0x-c0d3z ! 👍


Part 4: Multiple entry points

Multiple entry points
Implement Part 4

There is nothing to do here. All this step is descriping is that we can have multiple entry points defined in the package.json:
  "exports": {
    ".": "./src/main.js",
    "./red": "./src/main-red.js",
    "./blue": "./src/main-blue.js",
    "./package.json": "./package.json"
  },

which could be used to allow imports, eg from the unit test:
import {banner as whiteBanner} from 'nodejs-esm-starter'
import {banner as redBanner} from 'nodejs-esm-starter/red'
import {banner as blueBanner} from 'nodejs-esm-starter/blue'


sem_acquire has no reason to do a notify!

The source for sem_release() has this todo comment:
// todo this should really have a blocking variant for when permits are maxed out

If there is ever a sem_release_blocking(), then the acquires will need the notifications. If the todo is ever to come true, maybe 1.3.2 is the time for it?
sem_release_blocking() would probably want to have the variations on the theme that the acquires have -- timeouts, until and try.
Or maybe delete the todo, and not have sem_release_blocking()? I personally have never needed that, and don't know of algorithms that require it. But I certainly don't know all of the ways semaphores are used. The caller of sem_release() can check its return value, FWIW.
By comparison, POSIX semaphores don't configure a maximum value the way the SDK sets max_permits (SEM_VALUE_MAX is a resource constraint, since the counter can only go so high). As a consequence, the POSIX API doesn't foresee blocking, timeout or try variants for sem_post(). On Linux, sem_post() returns an error if the count exceeds SEM_VALUE_MAX, but POSIX apparently doesn't require that.
Which tends to persuade me that sem_release_blocking() is not needed, the todo can be deleted, and this comment may have been much ado about nothing. In which case apologies, but I think I'll hit the submit button anyway, because it seems to be worth thinking through,

The source for sem_release() has this todo comment:
// todo this should really have a blocking variant for when permits are maxed out

If there is ever a sem_release_blocking(), then the acquires will need the notifications. If the todo is ever to come true, maybe 1.3.2 is the time for it?
sem_release_blocking() would probably want to have the variations on the theme that the acquires have -- timeouts, until and try.
Or maybe delete the todo, and not have sem_release_blocking()? I personally have never needed that, and don't know of algorithms that require it. But I certainly don't know all of the ways semaphores are used. The caller of sem_release() can check its return value, FWIW.
By comparison, POSIX semaphores don't configure a maximum value the way the SDK sets max_permits (SEM_VALUE_MAX is a resource constraint, since the counter can only go so high). As a consequence, the POSIX API doesn't foresee blocking, timeout or try variants for sem_post(). On Linux, sem_post() returns an error if the count exceeds SEM_VALUE_MAX, but POSIX apparently doesn't require that.
Which tends to persuade me that sem_release_blocking() is not needed, the todo can be deleted, and this comment may have been much ado about nothing. In which case apologies, but I think I'll hit the submit button anyway, because it seems to be worth thinking through,

Yup; agreed sem_release_blocking would require the additional of new notifications/waits however these changes would be the same (I think)


Fix strip-whitespace for nested templates.

Error is due to webcomponents regression; to be fixed separately.


How to specify the orchestrator password?

How to specify the orchestrator password? @AMecea  can you help me?

In your values.yaml file or if you are using helm secrets in secrets.yaml file add the following:
orchestrator:
  topologyPassword: the-password

And when deploying run:
helm upgrade --install <release-name> presslabs/mysql-operator -f values.yaml

Thank you for help！Thank you very much! @AMecea


typeahead: Don't autocomplete "@ " (@space).

Fixes #7533.
The commit message looks out of place, imo, but nothing better came to mind.

Posted a small comment, otherwise looks great!

Fixed and tests completed.

Merged, after a small tweak to address my last comment, thanks @aero31aero!


Tweak MR activity logic

any activity now considers the MR UpdatedAt field
Change the order of any detections to better match the likelihood of a positive match
Document why user activity can not rely on the MR UpdatedAt field

Codecov Report
Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 0.69%. Comparing base (749d719) to head (39e939a).

Files with missing lines
Patch %
Lines

pkg/scm/gitlab/context_merge_request.go
0.00%
7 Missing :warning:

Additional details and impacted files
@@           Coverage Diff            @@
##            main     #72      +/-   ##
========================================
- Coverage   0.69%   0.69%   -0.01%
========================================
  Files         46      46
  Lines       2022    2028       +6
========================================
  Hits          14      14
- Misses      2008    2014       +6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Upgraded functionality

Upgraded functionality to support more arithmetic operations including float and arithmetic expressions by adding brackets  and updated history functionality and added error support

Thank you for this functionality upgrade


Fix RSpec deps

This should get Travis CI to go again, but lots of tests still fail.
Moneta's specs are largely incompatible with RSpec 3.  Additionally, rspec-retry 0.4.5 is not compatible with RSpec 2.  See https://github.com/NoRedInk/rspec-retry/issues/53

what about upgrading to newer rspec?

Upgrading to 3 seems like a much bigger job to me.  Lots of expectations will need to be reformatted (for instance, be_true needs to change to either be_truthy or be true).  Probably a lot of that is just find-replace, but it's hard to know given that a lot of specs are still failing under RSpec 2.  I believe it will be easier to first get Travis to green-light under RSpec 2, then make the necessary changes to the specs to get things to work under 3.


Do we want to change the name dapr-ambient to something else to avoid confusions?

Dapr Ambient might cause confusion, as there are other projects using that name, such as Istio Ambient: https://istio.io/latest/blog/2022/introducing-ambient-mesh/
If we want to change the name, we need to gather a list of proposed names and then vote on them.
Originally, I proposed "ambient" because of its definition; "relating to the immediate (surroundings) of something." And because it does follow the same architectural pattern as Istio Ambient, I do understand that the name might confuse people.

Team, we need to come up with a new name to avoid confusion with other projects like Istio Ambient.
Can we start a list of suggestions here in this issue?

renamed to Dapr Shared


mitmdump --save_stream_file does not flush to the stream file on exit

Steps to reproduce the problem:
mitmdump does not flush to the stream file (through "--save_stream_file" or "-w" options) on exit. A number of times, I run the mitmdump and I can see the flows on the std output, but the stream file is empty upon exit. I am wondering if there's any mechanism to force the tool to flush all flows or manage how frequently it is written to file?
Any other comments? What have you tried so far?
1.I started mitmdump through a python script by calling run from mitmproxy.tools.main.
2.The function creates a master object from dump.DumpMaster (in the case of mitmdump).
3. I tried calling  master.addons.get("save").done() just before I call  master.shutdown()  but that doesn't seems to flush the remaining flows to the dump file.
4-Other times, I notice the stream file is not empty, but I don't see any size change in the stream file upon exit, even though I can clearly see new flows on the std output after the file size changed, so I believe there are flows that have been captured by the tool but not reflected in the stream file.
System information
Mitmproxy: 4.0.4 (+3, commit 5603eb5)
Python:    3.6.4
OpenSSL:   OpenSSL 1.1.1-pre5 (beta) 17 Apr 2018
Platform:  Linux-4.9.35-v7+-armv7l-with-debian-8.0

I have a similar problem, where the stream file is truncated. This can be reproduced by making the same sequence of requests.
mitmdump.exe --mode "upstream:https://myproxy:8080" --ssl-insecure -p 8989 -w "test.dump"
Proxy server listening at http://*:8989
[::1]:12786: clientconnect
[::1]:12786: GET http://elines.coscoshipping.com/ebtracking/public/bill/containers/6194000840
          << 200 OK 2.2k
[::1]:12786: GET http://elines.coscoshipping.com/ebtracking/public/container/status/SEGU6334180?billNumber=6194000840
          << 200 OK 1.62k
[::1]:12786: GET http://elines.coscoshipping.com/ebtracking/public/container/status/FSCU8962294?billNumber=6194000840
          << 200 OK 1.61k
[::1]:12786: GET http://elines.coscoshipping.com/ebtracking/public/container/status/CSLU6010441?billNumber=6194000840
          << 200 OK 1.62k
[::1]:12786: GET http://elines.coscoshipping.com/ebtracking/public/container/status/CCLU6693579?billNumber=6194000840
          << 200 OK 1.61k
[::1]:12786: GET http://elines.coscoshipping.com/ebtracking/public/container/status/DFSU6036004?billNumber=6194000840
          << 200 OK 1.61k
[::1]:12786: clientdisconnect

The attached test.zip contains the resulting test.dump file.
Then running with option -S on the same file and invoking the same requests, the process exits abruptly.

This might be related. Sometimes when I call the master.addons.get("save").done() I get the following error:
Exception in thread Thread-173:
Traceback (most recent call last):
  File "/home/user1/.pyenv/versions/3.6.4/lib/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/home/user1/.pyenv/versions/3.6.4/lib/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/home/user1/Desktop/proj1/mitmproxy_runner.py", line 75, in shutdown_master
    master.addons.get("save").done()
  File "/home/user1/.pyenv/versions/3.6.4/lib/python3.6/site-packages/mitmproxy/addons/save.py", line 108, in done
    for f in self.active_flows:
RuntimeError: Set changed size during iteration


Exported script variables not showing up in inspector

Godot version
3.3.2 mono
System information
Windows 10
Issue description
Adding a new variable with the [Export] keyword doesn't show up in the inspector. It was strange because I already had some other exported fields which showed up just fine.
After lot's of poking around, I realized that the inspector won't refresh until you rebuild the whole project. Which is fine, but there is no mention of this in the documentation:
https://docs.godotengine.org/en/stable/getting_started/scripting/gdscript/gdscript_exports.html
Suggestion: note this crucial detail in the aforementioned documentation.
Steps to reproduce

Create a new project
Add a scene
Add a script to the scene
Add a field with the [Export] attribute
Save the script
Open the scene in inspector

Following these steps the script variable won't show up.
Minimal reproduction project
No response

You need to recompile the script for the variables to appear.

That's right, click on the "Build" button in the upper right corner of the editor.

After lot's of poking around, I realized that the inspector won't refresh until you rebuild the whole project. Which is fine, but there is no mention of this in the documentation:
docs.godotengine.org/en/stable/getting_started/scripting/gdscript/gdscript_exports.html

That documentation is about GDScript, not C#.

The editor has to recheck the script for changes, so it is logical that it does so after you save the script (effectively confirming that you want those changes). If you don't use an interpretted language I presume buliding is necesary for these changes 😄


Updating to Typescript 2.5.2 produces error

Typescript <=2.4.2 and 2.5.0 works fine.
Typescript >=2.5.1 gives following error:
ERROR in [at-loader] ./ClientApp/boot.server.ts:25:18
    TS2339: Property 'onError' does not exist on type '{}'.

same here
nothing easy in this project :(

It depends on which template you're using, but TypeScript isn't something that can be easily updated so quickly because all of the libraries and frameworks you're working with might not have upgraded to reflect the changes they made. "Minor" versions in TS seem to have breaking changes, even if only minor ones unfortunately. 😐

I tested with different templates, including most current.
I also updated all other package to the most current version.
I think it's only one small change in line
            zone.onError.subscribe(errorInfo => reject(errorInfo));
of boot-server.ts to get it running, with current typscript 2.5.2.
Thanks for the great project!

Had this issue after updating my packages -angular template-, fixed it by defining zone along with it's type NgZone like this:
const zone: NgZone = moduleRef.injector.get(NgZone);
in the boot.server.ts file.

Making zone typesafe solves the issue.
Runing current typscript 2.5.2 works now!
Thank you @mmgrt!

const zone:any = moduleRef.injector.get(NgZone);

Thanks for letting us know.
When we update the template sources to TypeScript 2.5.2+ this issue will inevitably surface and we'll use one of your suggested resolutions.
Closing for now because there's no action to take on it (at least, not prior to updating to TypeScript 2.5.2).


odo url list shouldn't crop url names

/kind bug
What versions of software are you using?
Operating System:
macOS Catalina
Output of odo version:
odo v2.0.0 (6fbb9d9bf)
How did you run odo exactly?
deboer$ odo url create --host myhost
 ✓  URL java-[quarkus-80](https://issues.redhat.com/browse/quarkus-80)80 created for component: java-quarkus

To apply the URL configuration changes, please use `odo push`
deboer$ odo url list
Found the following URLs for component java-quarkus
NAME                  STATE          URL                                 PORT     SECURE     KIND
java-[quarkus-80](https://issues.redhat.com/browse/quarkus-80)80     Not Pushed     http://java-[quarkus-80](https://issues.redhat.com/browse/quarkus-80)80.myhost     8080     false      ingress
There are local changes. Please run 'odo push'.
deboer$ odo push
Validation
 ✓  ...
------ came back on a different day ------
deboer$ odo url list
Found the following URLs for component java-quarkus
NAME                STATE      URL                               PORT     SECURE     KIND
java-[quarkus-80](https://issues.redhat.com/browse/quarkus-80)     Pushed     http://java-[quarkus-80](https://issues.redhat.com/browse/quarkus-80).myhost     8080     false      ingress
deboer$ odo url delete java-[quarkus-80](https://issues.redhat.com/browse/quarkus-80)
? Are you sure you want to delete the url java-[quarkus-80](https://issues.redhat.com/browse/quarkus-80) Yes
 ✗  the URL java-[quarkus-80](https://issues.redhat.com/browse/quarkus-80) does not exist
deboer$ odo url delete java-[quarkus-80](https://issues.redhat.com/browse/quarkus-80)80
? Are you sure you want to delete the url java-[quarkus-80](https://issues.redhat.com/browse/quarkus-80)80 Yes
 ✓  URL java-[quarkus-80](https://issues.redhat.com/browse/quarkus-80)80 removed from component java-quarkus

Actual behavior
Note the different url names above (80 vs 8080). After I've pushed the app, the url name that shows is shortened and missing the last two characters (80). If you try to do anything with it (with an incorrectly shortened name) it doesn't work.
In my case I was coming back to an app that had been pushed previously and I didn't remember that the url name ended in 8080. It took a bit to realize that the name was cropped, and then I had to guess the final characters.
Expected behavior
Any fix that would mean by default that I don't need to understand this problem and guess what the full url name is. e.g. a shorter default url name, not cropping the names, or treating names on the cli as if they ended in wildcards (i.e. "odo url delete java-" would be treated like "java-q*").

openshift-ci-robot keeps editing and adding weird urls to the description above - look at the previous edit if it's confusing.

/remove-lifecycle stale

/remove-lifecycle rotten

/remove-lifecycle stale
/lifecycle frozen
/reopen

There are no URLs in odo v3. In v3, port-forwarding is used instead of Routes/Ingress. This avoids all issues around url names or hostnames
/close


Fix small bug in patchScheme action and adding rolesById in the store

Summary
This changes are needed for properly manage custom team schemes in the admin panel.
Ticket Link
MM-8789
Test Information
This PR was tested on: [Arch linux]

Sure, the reason was basically that the roles where there by name, but the schemes are using ids to reference the roles, so, I added the rolesById. But I think you make a good point here, the data duplication, I think is not a big deal because the size of the roles list. But at the same time, is pretty easy to have an id:name binding, and return properly in the selector. So I going to make the change.

Thanks @mkraft now the solution is way simpler :)