🐛 Bug Report: getCastsInThread does not return type Cast[]

Describe the bug
The return type of getCastsInThread is:
Promise<{
    result: {
        casts: Cast[];
    };
}>

However, the actual internal values of result.casts is
{
  "hash": "0x90a9b8eb759fa1bcab4479455e5bb46e8f9fac10",
  "parentHash": "0x7865cc2aa89a96557363c5d6fa95a16282ac5251",
  "parentUrl": null,
  "parentAuthor": {
    "fid": "2588"
  },
  "author": {
    "fid": 2588,
    "custodyAddress": "0x00275fdd516e5a5b9a017e5181f375aaf2751302",
    "username": "nor",
    "displayName": "Connor McCormick 🥝/🫦",
    "pfp": {
      "url": "https://i.imgur.com/1JjZFIB.png"
    },
    "profile": {
      "bio": {
        "text": "The only problem is externality pricing. Follower",
        "mentions": []
      }
    },
    "followerCount": 6459,
    "followingCount": 1590,
    "verifications": [
      "0x4f8c531df3d97c6cd437ac8dfe756975445d1161"
    ],
    "activeStatus": "active"
  },
  "text": "nah\nhttps://warpcast.com/nor/0xb0f47f",
  "timestamp": "2023-10-08T12:30:35.000Z",
  "embeds": [
    {
      "url": "https://warpcast.com/nor/0xb0f47f"
    }
  ],
  "reactions": {
    "count": 0,
    "fids": []
  },
  "recasts": {
    "count": 0,
    "fids": []
  },
  "recasters": [],
  "replies": {
    "count": 2
  },
  "threadHash": null
}

What's expected instead is a structure matching the Cast type, like this:
{
  "hash": "0x6f7792e8e224b6707f2fa16dc71cc618eb98f995",
  "thread_hash": null,
  "parent_hash": null,
  "parent_url": "https://option.app",
  "parent_author": {
    "fid": null
  },
  "author": {
    "fid": 2588,
    "custody_address": "0x00275fdd516e5a5b9a017e5181f375aaf2751302",
    "username": "nor",
    "display_name": "Connor McCormick 🥝/🫦",
    "pfp_url": "https://i.imgur.com/1JjZFIB.png",
    "profile": {
      "bio": {
        "text": "The only problem is externality pricing. Follower",
        "mentions": []
      }
    },
    "follower_count": 6459,
    "following_count": 1590,
    "verifications": [
      "0x4f8c531df3d97c6cd437ac8dfe756975445d1161"
    ],
    "active_status": "active"
  },
  "text": "It's impossible to build AGI.",
  "timestamp": "2023-10-12T13:45:19.000Z",
  "embeds": [],
  "reactions": {
    "likes": [],
    "recasts": []
  },
  "replies": {
    "count": 0
  }
}

At the very least, I've ruled out the problem coming from the queries being different. They are all the same data structure
With an all-casts-in-thread query:
import axios from 'axios';

const options = {
  method: 'GET',
  url: 'https://api.neynar.com/v1/farcaster/all-casts-in-thread',
  params: {
    api_key: 'NEYNAR_API_DOCS',
    threadHash: '0xfe90f9de682273e05b201629ad2338bdcd89b6be',
    viewerFid: '194'
  },
  headers: {accept: 'text/plain'}
};

It returns:
{
  "result": {
    "casts": [
      ...
      {
        "hash": "0xfe90f9de682273e05b201629ad2338bdcd89b6be",
        "parentHash": null,
        "parentUrl": null,
        "parentAuthor": {
          "fid": null
        },
        "author": {
          "fid": 358,
          "custodyAddress": "0x3bcadeaef7f8e3bf5ec9ca5212cc9c72556c43ed",
          "username": "corbin.eth",
          "displayName": "Corbin Page",
          "pfp": {
            "url": "https://res.cloudinary.com/merkle-manufactory/image/fetch/c_fill,f_png,w_256/https://lh3.googleusercontent.com/szIk2U62Zfaux7eK8tinvy9vCUz2EPDUYet8WDKN9_dCJmm2-JM8Fux7_Cy2ZWzE9h2g3dIL9j_ywn8iK_UZYB0sToZ1dcP0QBsmh2w"
          },
          "profile": {
            "bio": {
              "text": "🏗 web3 builder\n   🩹 patchwallet.com\n   🧹 dustsweeper.xyz\n   🌐 nf.td/corbin",
              "mentions": []
            }
          },
          "followerCount": 5952,
          "followingCount": 318,
          "verifications": [
            "0x869ec00fa1dc112917c781942cc01c68521c415e"
          ],
          "activeStatus": "active"
        },
        "text": "Banger of a podcast with @pmarca on Rogan!\n\n* Best framing of the dangers of an AI regulatory moat, comparing to Dodd Frank\n* Examples of AI for kids/future gens \n* Cults aren’t all bad \n\nhttps://open.spotify.com/episode/3EWIFUOpaM9s7Pmei0r2C3?si=0xedN1QfTiuMZLAY0cBxlA&context=spotify%3Ashow%3A4rOoJ6Egrf8K2IrywzwOMk",
        "timestamp": "2023-07-20T00:03:23.000Z",
        "embeds": [
          {
            "url": "https://open.spotify.com/episode/3EWIFUOpaM9s7Pmei0r2C3?si=0xedN1QfTiuMZLAY0cBxlA&context=spotify%3Ashow%3A4rOoJ6Egrf8K2IrywzwOMk"
          }
        ],
        "reactions": {
          "count": 5,
          "fids": [
            124,
            8470,
            1600,
            616,
            3
          ]
        },
        "recasts": {
          "count": 1,
          "fids": [
            714
          ]
        },
        "recasters": [
          "ryanrodenbaugh"
        ],
        "viewerContext": {
          "liked": false,
          "recasted": false
        },
        "replies": {
          "count": 2
        },
        "threadHash": null
      },
      ...
    ]
  }
}

Whereas with v2 return cast:
const options = {
  method: 'GET',
  headers: {accept: 'application/json', api_key: 'NEYNAR_API_DOCS'}
};

fetch('https://api.neynar.com/v2/farcaster/cast?type=url', options)
  .then(response => response.json())
  .then(response => console.log(response))
  .catch(err => console.error(err));

it returns:
{
  "cast": {
    "hash": "0x4425780bf8bc68a6422d4cb440b9ca4ba5617c3f",
    "thread_hash": null,
    "parent_hash": "0x6663bea5d2b5fdb94682c47b2a5d4f496d22e3cc",
    "parent_url": null,
    "parent_author": {
      "fid": "2588"
    },
    "author": {
      "fid": 302,
      "custody_address": "0xa4b7c9173ff5be5c116d2ff846d23dd12a3cc5ec",
      "username": "gt",
      "display_name": "Goksu Toprak",
      "pfp_url": "https://lh3.googleusercontent.com/gq7_KZeGTW4TRQvQx1QhYJvCX0A7AjW8i7VBc8d9vhtaB3xZRS51AEK5pIlb_dL4jpXQ75h_LwMLtf4Jrzuret7DegPfLedEh8mr",
      "profile": {
        "bio": {
          "text": "Working on Farcaster.",
          "mentions": []
        }
      },
      "follower_count": 6065,
      "following_count": 391,
      "verifications": [
        "0x8ed9eee4fce8cbc92dc4aafbc36b5721eb66b15d"
      ],
      "active_status": "active"
    },
    "text": "Go style spec has this right imo: https://google.github.io/styleguide/go/decisions#variable-names",
    "timestamp": "2023-10-21T18:57:06.000Z",
    "embeds": [],
    "reactions": {
      "likes": [
        {
          "fid": 474
        },
        {
          "fid": 834
        },
        {
          "fid": 2588
        }
      ],
      "recasts": []
    },
    "replies": {
      "count": 1
    }
  }
}

And with v1 return cast:
const options = {
  method: 'GET',
  headers: {accept: 'application/json', api_key: 'NEYNAR_API_DOCS'}
};

fetch('https://api.neynar.com/v1/farcaster/cast?hash=0xfe90f9de682273e05b201629ad2338bdcd89b6be', options)
  .then(response => response.json())
  .then(response => console.log(response))
  .catch(err => console.error(err));

It returns:
{
  "result": {
    "cast": {
      "hash": "0xfe90f9de682273e05b201629ad2338bdcd89b6be",
      "parentHash": null,
      "parentUrl": null,
      "parentAuthor": {
        "fid": null
      },
      "author": {
        "fid": 358,
        "custodyAddress": "0x3bcadeaef7f8e3bf5ec9ca5212cc9c72556c43ed",
        "username": "corbin.eth",
        "displayName": "Corbin Page",
        "pfp": {
          "url": "https://res.cloudinary.com/merkle-manufactory/image/fetch/c_fill,f_png,w_256/https://lh3.googleusercontent.com/szIk2U62Zfaux7eK8tinvy9vCUz2EPDUYet8WDKN9_dCJmm2-JM8Fux7_Cy2ZWzE9h2g3dIL9j_ywn8iK_UZYB0sToZ1dcP0QBsmh2w"
        },
        "profile": {
          "bio": {
            "text": "🏗 web3 builder\n   🩹 patchwallet.com\n   🧹 dustsweeper.xyz\n   🌐 nf.td/corbin",
            "mentions": []
          }
        },
        "followerCount": 5952,
        "followingCount": 318,
        "verifications": [
          "0x869ec00fa1dc112917c781942cc01c68521c415e"
        ],
        "activeStatus": "active"
      },
      "text": "Banger of a podcast with @pmarca on Rogan!\n\n* Best framing of the dangers of an AI regulatory moat, comparing to Dodd Frank\n* Examples of AI for kids/future gens \n* Cults aren’t all bad \n\nhttps://open.spotify.com/episode/3EWIFUOpaM9s7Pmei0r2C3?si=0xedN1QfTiuMZLAY0cBxlA&context=spotify%3Ashow%3A4rOoJ6Egrf8K2IrywzwOMk",
      "timestamp": "2023-07-20T00:03:23.000Z",
      "embeds": [
        {
          "url": "https://open.spotify.com/episode/3EWIFUOpaM9s7Pmei0r2C3?si=0xedN1QfTiuMZLAY0cBxlA&context=spotify%3Ashow%3A4rOoJ6Egrf8K2IrywzwOMk"
        }
      ],
      "reactions": {
        "count": 5,
        "fids": [
          124,
          8470,
          1600,
          616,
          3
        ]
      },
      "recasts": {
        "count": 1,
        "fids": [
          714
        ]
      },
      "recasters": [
        "ryanrodenbaugh"
      ],
      "replies": {
        "count": 2
      },
      "threadHash": null
    }
  }
}

this is my oversight - forgot to implement a separate v1 Cast type. will get a fix out later today.

I think we should map it all to the v2 Cast type, handling multiple different types is annoying

yep that makes sense, it looks like the types are the same besides the key casing. will use the existing type!

the types actually don't match perfectly, the V1 casts have a different format for recasters (fname in a separate array vs with the FID). current thinking is to just omit the names from the returned type, but want to think it through a bit more and test as well so will not be able to get a release out today.
if you want to try to use the version I have going that's not fully finished, you can use the casts-in-thread-type branch!

@alex-grover Have you had a chance to look at this since then? Picking this back up now.

I think we should just map it from:
{
  "recasts": {
    "count": 5,
    "fids": [
      129,
      13978,
      14392,
      10311,
      880
    ]
  },
  "recasters": [
    "phil",
    "forogh",
    "shahroozraeisi",
    "aeon",
    "accountless.eth"
  ]
}

to:
{
  "recasts": [
    {
      "fid": 129,
      "fname": "phil"
    },
    {
      "fid": 13978,
      "fname": "forogh"
    },
    {
      "fid": 14392,
      "fname": "shahroozraeisi"
    },
    {
      "fid": 10311,
      "fname": "aeon"
    },
    {
      "fid": 880,
      "fname": "accountless.eth"
    }
  ]
}

Right?

P.S. it also looks like parentHash in v1 should be mapped to parent_hash in the v2 Cast object, guessing there are a handful of more mappings to make so would be worth checking

Confirmed that they will be in the correct order:

https://warpcast.com/shreyas-chorge/0xcee92868

great, thanks for looking into that. have not picked back up yet but can have this released in a couple hours

P.S. it also looks like parentHash in v1 should be mapped to parent_hash in the v2 Cast object, guessing there are a handful of more mappings to make so would be worth checking

Can you elaborate what you mean here? Is this sufficient or is there something else I've missed?

can you try v0.2.8?
thanks again for the details here!

Can you elaborate what you mean here? Is this sufficient or is there something else I've missed? https://github.com/alex-grover/neynar-next/commit/ee8bdcfd28822eee4dde1d9a4b149c845dcd9903#diff-1113f47917f0bc0f7f54e7f179e6120af0ce81ecfb6e3d1d0942c65f69628ff3R120

Yeah, that looks perfect!

can you try v0.2.8?
thanks again for the details here!

Thank you! Will test and follow up this afternoon

Yep, it's working. The only issue is that it seems like Cast.author should be of type User, right now it has a bespoke definition, so the response from the getUser endpoint returns a different User than the author field in the getCast endpoint

If you'd like, let's open it as a new issue. Is this something that changed with this commit or did it already exist?

That already existed - same distinction of v1 vs v2 endpoints, the user endpoints are from v1. A guiding principle I had when writing this originally was to stick to exactly what the Neynar docs + APIs were returning to make it easy to match this library with what you see when running a test query.
I agree that having 2 separate types is annoying to deal with. Now that we've stepped away from that, I'm wondering if the best approach here is to just map the UserV1 types to the V2 types, or to return the V1 type to match the APIs and export a utility function for ease of use.
My worry with converting everything is that we'll run into more places where the data doesn't match - the APIs seem to have some bugs and design quirks so this seems pretty likely to me if we cover every single endpoint.
Thinking for now we can convert and just keep an eye out for mismatches down the line, what do you think? Hopefully this is somewhat solved with the upcoming OpenAPI spec. Either way, if you could open another issue that would be great 🙏🏽

Cool, created a new one.
https://github.com/alex-grover/neynar-next/issues/36

I agree that having 2 separate types is annoying to deal with. Now that we've stepped away from that, I'm wondering if the best approach here is to just map the UserV1 types to the V2 types, or to return the V1 type to match the APIs and export a utility function for ease of use.

Yeah I think this is exactly the right approach. The whole reason I picked up the package in the first place was because I assumed we'd all swarm on a single place to handle the subtleties of neynar's somewhat wonky api spec, and push updates in a single place as the API evolves.
Obviously, any api user can read the docs themselves if they want the direct api experience, so the real value here is mapping the complexities of the neynar api to a consistent set of types and having knowledge of edge cases so the user doesn't have to worry about them.
just my 2c wdyt?


Quite like the tool, some feedback for next version

This is a great tool, what I have and a few other teams I have been talking to are looking for. For next version Id love to suggest some possible improvements/extra features

More examples and documentation, I have started to set up this repo, and can hopefully add more generalized tests and it can be used as examples for other teams

A before each hook that resets the state of the dev chain (I know this is hard and will probably require an RPC call on the substrate side, but worthwhile to look into)

Access to more features of Polkadot JS. When trying to call random RPC calls like account next nonce and signing with a different nonce (to bombard the node with tx) see here I had to manually pull in the polkadot js api.

An option to store results in a postgres DB for later use (optional, maybe not the best idea, but worth thinking about)

Documentation to set this up with Grafana

A call that load tests a chain and can give some sort of printout to an approx tps and if it is good or bad. As well to set failures on min tps for a specific call so it can be run in a pipeline

Thanks for your feedback!

We have a repo with an example project https://github.com/halva-suite/halva-test-example, we welcome contributions ;)

Yes, it's a very useful feature, but - as you rightly note - this is hard for development. But we thinking about it and have some ideas

I need some times to research this question, maybe it's will be done soon

It is my opinion that the responsibility is not for this tool, you can do it manually. Some people don't need to save results to a DB or may want to use a different DB instead of Postgres.

It's a good idea


Adding dependabot.yml

We need to add dependabot.yml file as it helps us to keep our dependencies up to date. Every day, it checks your dependency files for outdated requirements and opens individual PRs for any it finds.
@agamjotsingh18 please assign me this issue under gssoc'23.

Sure @Anshika-Jain02


[BUG] GpuCast.scala:nnn warning: discarding unmoored doc comment

Describe the bug
[INFO] --- scala-maven-plugin:4.3.0:doc-jar (attach-scaladocs) @ rapids-4-spark-sql_2.12 ---
/home/gshegalov/gits/NVIDIA/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala:679: warning: discarding unmoored doc comment
      /**
      ^
/home/gshegalov/gits/NVIDIA/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala:705: warning: discarding unmoored doc comment
      /**
      ^
/home/gshegalov/gits/NVIDIA/spark-rapids/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuCast.scala:720: warning: discarding unmoored doc comment
      /**
      ^
model contains 1086 documentable templates

Could you please describe when you get the warning?

What causes this warning is that we cannot add Scala document (/** ... */) to an inner function. Instead, we can only use single line comment (// ...) or multi lines comment (/* ... */). I will fix this bug.


Update seeds so that the ROSMOD meta is a library like HFSM

Affected by https://github.com/finger563/webgme-hfsm/issues/102


[Plugin] Glossary Plugin

Summary
Software catalogs contain various information about a project. Teams often maintain a glossary which is an essential part of the catalog.
Can we build a Glossary plugin that can be used by backstage Entities
Plan
The glossary plugin will be an additional tab on the Entity Catalog page, which will be visible for the KINDs selected by the user. Terms and Definitions will be visible in a table format. The terms will be linked to the specific component via CompoundEntityRef (Entity ref triplet). Preferring to link terms to the catalog by this method as its the preferred method in backstage.
We will maintain the glossary in Backstage Database and use glossary-backend plugin to create the CRUD operations. The combination of Glossary Term and Entity Ref will be a unique identifier.
Logged in Users will enter details like this:

Field
Example

Term
Service Catalog

Definition
A service catalog is an organized and curated collection of any and all business and information technology-related services that can be performed by, for, or within an enterprise.

Catalog
default:component/some-component-name

We will showcase a Global glossary, which will be reachable via sidebar navigation. Which will show all terms from different KINDs and Catalogs in the organization.
Secondly, there will be a Glossary tab inside the Entity Catalog page.
Prototype

Why would this be keyed on entity ref? Aren't terms the same globally typically?

I'm curious what benefits this would have compared to a glossary page in the entity TechDocs? I could see the CRUD operations being a differentiation, but also quite a bit of work to implement fully?

@freben Terms will be used globally, but linking them to refs can help them map to the respective software catalogs as well (especially mapping it with catalogs from KIND: Group and Domain). We can even make components in the EntityCatalog page for displaying terms associated with that respective catalog. Mapping it with entity ref also helps in distinguishing between terms with duplicate names. One term can have different meanings in different teams.
@Rugvip This can be a good value addition I believe, it will be robust to use and a new feature, which is very relevant with managing software catalogs. Also, a feature that will help developer adoption inside organisation.  I am ready to work on this.

@mufaddal7 Yep a glossary is certainly very useful and we use it quite a bit internally, but it's generally just an additional TechDocs page. I'm wondering what value a separate plugin brings to the table?
Don't get me wrong btw, I don't think this is a bad idea, just pushing back a bit to make sure it's all well thought through.

Just thought about a plugin like this, as we use a glossary internally too.
I totally agree that the glossary mostly is only a page(s). But adding a TechDocs page only solves one side. The engineers need to be constantly aware, that this site exists. We see a lot of re-definition of terms over documentations.
I would be nice if known terminology is auto highlighted in any TechDocs page, could be done as add-on and look like https://marketplace.atlassian.com/apps/1219677/smart-terms-for-confluence-glossary?tab=overview&hosting=cloud or https://marketplace.atlassian.com/apps/1211800/glossary-for-confluence?tab=overview&hosting=cloud.
To do this, I think a backend plugin would be necessary to maintain the glossary.


added bundle task and change MODE into TYPE

I here kill the ambiguity between MODE and TYPE option.
I add a bundle task
the (old) "localhost" type becomes now "development"

@franblas
so it is kind of annoying, because I cannot see the jenkins details, because I don't have anymore a snips.ai account...

@franblas
works, I merge that soon, tx


Add a GitHub workflow to prepare a release pull request

Motivation and context

This automates the first half of the current release process. The second half will be implemented by another workflow.
The reason why it can't all be done in a single workflow is that it's useful to let developers inspect what'll go into the release before actually publishing it, and to apply any last-minute fixes, if necessary. It also allows CI to complete for the release PR.
To support the new workflow, add a --set option to update_version.py that sets the version to a custom value.
How has this been tested?

Manual testing on my fork of CVAT. See a test run here: https://github.com/SpecLad/cvat/actions/runs/6459901481.
Checklist

[x] I submit my changes into the develop branch
[ ] I have created a changelog fragment
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (see GitHub docs)
[ ] I have increased versions of npm packages if it is necessary
(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

CC @azhavoro

I also see that it would be nice to have some validation on the version number that prevents increasing one of X, Y or Z on more than 1. Or was it already implemented and I missed it?

I also see that it would be nice to have some validation on the version number that prevents increasing one of X, Y or Z on more than 1.

IMO, this isn't needed. There's no requirement that versions have to be sequential, and we might end up wanting to skip a version for whatever reason.
Although now that you mention it, maybe I should at least add a check that the release does not already exist...


Problem with Angular 4 Routes and Ionic UI

I have a problem when im trying to obtain params from Angular 4 Routes.
Im using:
constructor(public route : ActivatedRoute) {
   }

  ngOnInit() {
    var param = this.route.snapshot.paramMap.get(':idEmployer');

    console.log(param);
  }

According to the Angular Routes guide that is how to obtain params, but it show null.
What am I doing wrong?
Thanks!

You do not need the : prefix when trying to retrieve the route params, see https://angular.io/tutorial/toh-pt5#extract-the-id-route-parameter.
The route.snapshot property is set only when the component was created, and depending on how you use the router it will not be updated on changes, so in this case you need to subscribe to the route to get the params, see https://angular-2-training-book.rangle.io/handout/routing/routeparams.html.

Sorry I made a mistake in the before post. I use:
constructor(public route : ActivatedRoute) {
   }

  ngOnInit() {
    var param = this.route.snapshot.paramMap.get(':idEmployer');

    console.log(param);
  }

without : prefix.
Thanks again.

Can you post your route definition?
The problem can be either in your definition or because the route params is set after the component creation, in which case you need to subscribe to route update like specified here: https://angular-2-training-book.rangle.io/handout/routing/routeparams.html (see "Reading Route Parameters" section).

Do you still have issues with this?

Sorry for the delay, the answer is yes. I have the same issue yet but I solve this according to the following code:
import { EmployersComponent } from './employers.component';
import { NgModule } from '@angular/core';
import { Routes, RouterModule } from '@angular/router';
import { Route } from '../core/route.service';
import { extract } from '../core/i18n.service';
import { EmployerComponent } from '../employer/employer.component';
import { EmployerAddComponent } from '../employer-add/employer-add.component';

const routes: Routes = Route.withShell([
  { path: '', redirectTo: '/employers', pathMatch: 'full' },
  { path: 'employers', component: EmployersComponent, data: { title: extract('Employers')}},
  { path: 'employers/add', component: EmployerAddComponent, data: { title: 'Nueva empresa'}},
  { path: 'employers/:id', component: EmployerComponent, data: { title: 'Empresa'}}
]);

@NgModule({
  imports: [RouterModule.forChild(routes)],
  exports: [RouterModule]
})
export class EmployersRoutingModule { }

employers-routing.module.ts
import { Component, OnInit } from '@angular/core';
import { EmployerProvider } from '../core/providers/employer/employer';
import { Router } from '@angular/router';

@Component({
  selector: 'app-employers',
  templateUrl: './employers.component.html',
  styleUrls: ['./employers.component.scss']
})
export class EmployersComponent implements OnInit {

  employers : any;
  employersFound : any;

  constructor(
    private employerProvider : EmployerProvider,
    private router : Router){ }

  ngOnInit() {
    this.employerProvider.all().subscribe(employers =>{
      this.employers = employers;
      this.employersFound = this.employers;
    });
  }

...

  onClickEmployer(id : number){
    this.router.navigate(['/employers',id]);
  }
}

employers.component.ts
import { EmployerProvider } from './../core/providers/employer/employer';
import { ShellComponent } from './../core/shell/shell.component';
import { ActivatedRoute, ParamMap, Params, Router, RoutesRecognized } from '@angular/router';
import { Component, OnInit } from '@angular/core';
import { Observable } from 'rxjs/Observable';
import { NavParams, Nav } from 'ionic-angular';
import { Navigation } from 'selenium-webdriver';
import { ToastController } from 'ionic-angular/components/toast/toast-controller';
import { LoadingController } from 'ionic-angular/components/loading/loading-controller';

@Component({
  selector: 'app-employer',
  templateUrl: './employer.component.html',
  styleUrls: ['./employer.component.scss']
})
export class EmployerComponent implements OnInit {

...

  constructor(
    private shell : ShellComponent,
    private router : Router,
    private employerProvider : EmployerProvider,
    private loadingController : LoadingController,
    private toastController : ToastController) {

  }

  onClickBack(){
    this.router.navigate(['/employers']);
  }

  ngOnInit() {
    let id = this.shell.getRouteParams().id; //this method was created by me
    if(isNaN(id)){
      this.onClickBack();
    }else{
      this.getEmployer(id);
    }
  }

...
}

employer.component.ts
@Component({
  selector: 'app-shell',
  templateUrl: './shell.component.html',
  styleUrls: ['./shell.component.scss']
})
export class ShellComponent implements OnInit {

...

  public getRouteParams(){
    return this.routeParams;
  }
}

shell.component.ts
From this way I have get to obtain the id param. I can't to obtain these params according to the documentation.
Thanks for your help.

Thanks for the feedback and sharing your solution!
Seems like a bug on the angular router (it would not be the first one 😉 ), you should try opening an issue on the angular repo as it seems to be a pretty nominal use-case for me, and yes according to the docs it should work from what you're sharing.
I'm closing the issue since it does not seems to be specific to the generator but rather to the angular router.

Hi
Same problem here.
Tried to implement routing with parameters in an ngx project. The project was defined as Ionic.
Implemented everything according to Angular doc https://angular.io/guide/router.
Added a route like  so { path: 'somepath/:id', component: SomeComponent }]
Navigation:     this.router.navigate(['/somepath', '123456' ]);
Tried this in SomeComponent according to docs:
 constructor(private route:ActivatedRoute){     this.route.paramMap.subscribe(x=>console.log(x.keys));   }
I was unable to fetch the id parameter. Params are always empty.
The parameter is present in the url (somepath/123456)
Had a look ad idroxen's workaround, but routeParams is not defined in ShellComponent...??

I solved that on this way:

@Component({
  selector: 'app-shell',
  templateUrl: './shell.component.html',
  styleUrls: ['./shell.component.scss']
})
export class ShellComponent implements OnInit {

...
  private updateNav(route: ActivatedRoute) {
    if (!route || !route.firstChild) {
      return;
    }
    // First component should always be IonicApp
    route = route.firstChild;
    if (route && route.component === ShellComponent && route.firstChild) {
      // Loop needed for lazy-loaded routes, see: https://github.com/angular/angular/issues/19420
      while (route.firstChild) {
        route = route.firstChild;
      }

      this.routeSnapshot = route.snapshot;
      this.navRoot = <Component>route.component;
    }
  }

  public getRouteSnapshot() : ActivatedRouteSnapshot{
    return this.routeSnapshot;
  }

shell.component.ts
How I used it:
@Component({
  selector: 'app-my-awesome-component',
  templateUrl: './my-awesome-component.component.html',
  styleUrls: ['./my-awesome-component.component.scss']
})
export class MyAwesomeComponent implements OnInit {
  ...
  contructor(private shell : ShellComponent){
    let params = this.shell.getRouteSnapshot().params;
  }
  ...

my-awesome-componet.component.ts
I hope it helps you

In your case you should use this.shell.getRouteSnaphost().paramMap.subscribe(x=> console.log(x));

Thanks, idroxen.
This helped!

Finally solved this by putting

in both pages, calling and called.
Now, the parameters get passed down.
Maybe this should be included in ngx-rocket globally???
Hope this helps anyone stumbling over it.


AI Sits In One Place

When there's nothing interesting nearby (no enemies, no food), the AI just sits down and does nothing. It should, instead, wander around to find something.

I'd like this to happen a lot later.

Easy to fix, will do later

Fixed.


add workflow for publishing npm package

This is a suggestion of an automated workflow for publishing npm packages.
Process for publishing the development tags would be:

Create a PR for the next intended npm package version x.y.z

Most often this would the next minor release for new features. While we are still on v0, we also include breaking changes here. Once we hit v1, we will have a more strict process for how to bump version numbers. Perhaps something like this https://www.npmjs.com/package/semantic-release.

Once merged, a maintainer can publish next dev-version Actions => Publish NPM => Run workflow

The workflow does this

Set the version fo x.y.z-dev.<commit-sha>
Publish the npm package to npm registry
Creates a git tag vx.y.z-dev.<commit-sha>
Push git tag

If this works well, we can trigger this workflow to run on push to main for a completely automated publishing flow.
Once the next release is ready you change the npm dist tag input to latest. Then the workflow does

Publish the npm package with version x.y.z to npm registry
Creates a git tag x.y.z
Push git tag

This can then also be easily extended to utilize https://cli.github.com/manual/gh_release_create for automatic github release creation with changelog.
Usage
If consumers of the library want to install the lastest dev version they would do:
npm i --save signify-ts@dev

They can also explicitly install the version from a commit using
npm i --save<EMAIL_ADDRESS>
To install the latest released version they would continue to use
npm i --save signify-ts@latest

Or simply use a version number
npm i --save<EMAIL_ADDRESS>
As long as they use a lock file, the version that they have installed in their project will not change unless they explicitly want to upgrade.
Discussion
In order to make this work, someone with push access to the npm package signify-ts needs to generate a publishing token and store in github secrets. These secrets are not accessible from forks.
This would make it easier for consumers of this package to install and test the latest versions of the package without having to reference the repository and pull all devDependencies. It would also make it easier for maintainers to publish the packages.

Update: I thought a bit more about this and I think the main benefit is to make it easier to publish dev versions automatically. However, I have second thoughts about putting the "logic" for determining the version number in the workflow. It is probably better to but in a script, the workflow would just invoke the script using appropriate environment variables. Can also add a Makefile similar to the other repos.
Essentially I'd like the end result to be something like:

Push changes to main
A workflow automatically (or after manual approval) publishes the package under x.y.z-dev. version.
Some time passes and a the package is ready for new release
Maintainer starts workflow with "latest" dist tag
Workflow publishes the package under x.y.z version (from package.json)
Maintainer creates a PR and bumps version to next minor x.w.0
Following PRs will be merged and released under x.w.0-dev. until x.w is ready to be released.

I have not thoroughly considered how to handle release branches.

@lenkan The secret NPM_DEPLOY_SECRET has been created with WRITE access to signify-ts.


Update to webpack 4

Is there a plan to update react slingshot to webpack 4.0 in near by?

Would certainly welcome a pull request. Last I checked it looked like some
dependency wasn't ready yet but can't recall.
On Mon, Apr 23, 2018 at 7:27 PM, InnoSTARK Technologies <
<EMAIL_ADDRESS>wrote:

Is there a plan to update react slingshot to webpack 4.0 in near by?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/coryhouse/react-slingshot/issues/560, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABnFpZQlCRCQ2ZFEXse6o7lTft-LPLlGks5trnFwgaJpZM4Tg0Rw
.

--
Cory House
Principal: reactjsconsulting.com http://www.reactjsconsulting.com
Author: Pluralsight Courses http://www.pluralsight.com/author/cory-house

would be working on update in couple of days, if successful would send a PR 😀

Woot! Excellent. :)
On Mon, Apr 23, 2018 at 8:09 PM, InnoSTARK Technologies <
<EMAIL_ADDRESS>wrote:

would be working on update in couple of days, if successful would send a
PR 😀
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/coryhouse/react-slingshot/issues/560#issuecomment-383770510,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABnFpVvZcxQYsKa3chgeObi02j8r9mrHks5trntZgaJpZM4Tg0Rw
.

--
Cory House
Principal: reactjsconsulting.com http://www.reactjsconsulting.com
Author: Pluralsight Courses http://www.pluralsight.com/author/cory-house

I have created the PR to upgrade to webpack 4:
https://github.com/coryhouse/react-slingshot/pull/561
added some comments also.
I have also added hard-source-webpack-plugin to cache the output of node module. This has fasten the successive build time from 12363ms to 2730ms
let me know if i need to amend anything. Thank you @coryhouse

Wow, great work! Reviewing now! 💯

Closed via #561 🎉


fix: Create Waifu leads to normal collection on mobile

Thank you for your contribution to the KodaDot NFT gallery.
👇 _ Let's make a quick check before the contribution.
PR Type

[x] Bugfix
[ ] Feature
[ ] Refactoring

Context

[x] Closes #5145
[ ] Requires deployment <>

Before submitting pull request, please make sure:

[x] My contribution builds clean without any errors or warnings
[x] I've merged recent default branch -- main and I've no conflicts
[x] I've tried to respect high code quality standards
[x] I've didn't break any original functionality
[x] I've posted a screenshot of demonstrated change in this PR

Optional

[ ] I've tested it at </bsx/collection>
[ ] I've tested PR on mobile
[ ] I've written unit tests 🧪
[ ] I've found edge cases

Had issue bounty label?

[x] Fill up your KSM address: Payout

Community participation

[x] Are you at KodaDot Discord?

Screenshot 📸

[x] My fix has changed something on UI; a screenshot is best to understand changes for others.

Seems doesn't work on Nova still, maybe need empty cache 🤔

Wfm


Add an option to disable per TaskRun/PipelineRun metrics

Feature request
Add an option to disable per TaskRun/PipelineRun metrics
Use case
We are conducting performance tests on pipeline controllers. While we are creating a huge amount of PipelineRuns, the size of metrics increases dramatically. This blocks metrics collector from scraping these metrics(390k series) and as a result, we are not to visualize some key metrics which are important to identify deviations.
I'm looking for an option so that we can report only the key metrics.

Hey @zhouhaibing089 sounds like a reasonable request!
@vdemeester has a proposal around simplifying the metrics (https://github.com/tektoncd/community/pull/466) which may or may not help you; otherwise maybe the observability configuration can be extended to specify which metrics to include/exclude?

@bobcatfish: Thanks! And that TEP describes the exact same issue here!

Looks like this issue is resolved in https://github.com/tektoncd/pipeline/pull/4201
/close


Library not updating on iPad

As per the title - Library not updating on iPad - Can manually update on iOS by pulling down
Happens for both Comick and Mangadex
For example, Mayonaka Heart Tune should have Ch. 58 released, but I'm not receiving it on iPad.
iPadOS 18.2 - iPad Pro 11 in M2, App version 0.6.10

this is the wrong repo to submit issues to, but im pretty sure this is just user error. check your library update conditions. the titles wont update automatically unless you have all the other chapters read

Point is though, I can manually update on iOS but can't on iPadOS, not sure if this is a bug or anything

you can pull down on the left half of the screen to refresh (ik it's slightly unintuitive)


Add missing comma

yea true, https://github.com/snapshot-labs/snapshot-spaces/pull/2611 but somehow no action was run on this PR 🤔

Seems like this action is not run when PR is opened by someone not from the team.
We could either:

Allow this action to always be run for PR opened by external contributor
Prevent the merge on master to continue when workflows are failing (I prefer this, and I think we're already using this on some repo)

Prevent the merge on master to continue when workflows are failing (I prefer this, and I think we're already using this on some repo)

For this @bonustrack need to change Branch protection rule settings similar to here https://github.com/snapshot-labs/snapshot.js/settings/branch_protection_rules/17997175
and add this action mandatory


The columns of the tag-table are now sortable.

Screenshot:

Fixes: #588
Signed-off-by: Jürgen Löhel<EMAIL_ADDRESS>

Good work :clap: Some notes:

There is a gem for this datatables plugin. Use this instead of copying everything into the vendor directory.
You should select just a couple of columns to sortable, not all of them.

Sortable columns?! :joy:
I didn't look at the code yet, but it's awesome. We will have to extend that to the other tables of course.

I didn't look at the code yet, but it's awesome. We will have to extend that to the other tables of course.

Note that this was a reaction to the PR #588. But yes, we should generalize this to every column. I'll open up a new issue about this. For now, I'd prefer to keep this PR fixing the issue #588.

@jloehel by the way, your commit message is wrong! You're fixing the issue #590, not the PR #588 :)

This pull-request will be replaced by #607.


Make it clear that components with headings shouldn't have other content directly below them

In our care card pattern we say: "Make sure any text below a care card has its own heading so that screen reader users know it's not part of the care card."
This also applies to:

warning callouts
inset text which starts with a heading
Do and Don't lists

Updated in branch jan23-release.

Done. Published in latest release.


[WFLY-17156] Fix the Bootable JAR TCK execution

This is to fix the MicroProfile Telemetry TCKs execution in the WildFly MP Telemetry integration PR.

@fabiobrz Good catch, Fabio. Missed that one. Thanks!


Feature Request : New control 'screen'

First please see this https://i.ibb.co/QvctMgJ/Customize-Travelers-Blog-Just-another-Word-Press-site.gif
I have used "radio-image" control for show/hide fields added some js to resize the screen. It is pretty simple btw to achieve.
If this control is added in kirki, it would be more helpful for the users. The popular themes on the wp.org uses this feature.

@ravishakya It sounds like you have already started building this, why don't you try making a pull request?

Something we're currently looking into with Kirki PRO :)
If you want to stay in the loop on that, please join us on Facebook (https://www.facebook.com/groups/1020376102132534) or join our mailing list (form on the website (https://kirki.org/)


fix(hostsensorutils): reduce periods of readiness probe

Overview
In order to reduce the number of requests we should decrease the readiness probe periods.

Related issues/PRs:
This PR is related to SUB-1286.
Checklist before requesting a review

[X] My code follows the style guidelines of this project
[ ] I have commented on my code, particularly in hard-to-understand areas
[X] I have performed a self-review of my code
[ ] If it is a core feature, I have added thorough tests.
[X] New and existing unit tests pass locally with my changes

I suggest you use a startupProbe instead, because the fast probing is really to reduce the time we wait for the hostsensor to start... Also didn't we say that we should add a /ready endpoint that doesn't have telemetry?

Yes, I opened it in draft mode only as starting point for tomorrow, so we can better desing it.

@matthyx I applied your suggested fixes to the probes. I'm going to mark the PR as "Ready for review" since we are also going to merge it soon.

Once this is merged, we can update the Helm chart too


ISPN-14104 SoftIndexFileStore - Compactor.compactSingleFile - NPE

Make sure numRecords is always updated
Drop index has previous file to ensure count update
Added more logging around visibility of which key is which for the
index messages

https://issues.redhat.com/browse/ISPN-14104

Added a test that reproduces the issue every time with the fix for writing the numRecords.

With the change undone the following error should come from the explicit invocation of the compactor
java.util.concurrent.CompletionException: java.lang.AssertionError: No index info found for key: compaction

	at org.infinispan.util.concurrent.CompletionStages.join(CompletionStages.java:86)
	at org.infinispan.persistence.sifs.SoftIndexFileStoreRestartTest.testRestartWithEntryUpdatedMultipleTimes(SoftIndexFileStoreRestartTest.java:210)

The test tests both leaf nodes and inner nodes. The latter is created when too many leaf nodes are present so it creates sub nodes, this latter is where the issue can happen (leafNodes only was unaffected by this bug).

Merged, thanks

Can you create a backport for 13.0.x please ?


Revamping storybook to make it easier to implement UI changes in the sdk

Motivation / Description
We need to implement some appearance changes due to customisation.
This PR sets up again storybook (updated) to create directly stories in svelte and test them directly instead of doing back and forth with the demo app.
Changes introduced

Updated storybook
Fixed the main.ts setup
Started working on a story for the components affected by customisation

also, we should add storybook-static to the .gitignore file

The one you picked is the old story we had and it doesn't work anymore, I think we should not use storybook that way, I'll remove it (we still have it in git if we want in the future).

Done both!


Support actual versions of spring boot

Good afternoon, tell me, will you support compatibility with current versions of Spring Boot, for example 3.2.x, 3.3.x?

The Springboot integration supports 3.x, see our springboot sample.
For user support questions please use our forum or slack. We use github for bugs and feature requests.

io.temporal:temporal-spring-boot-starter:1.25.0
compiled for spring boot 2.7.18 version
Updating the version in the file to 3.2 does not update the version in application

I set springBootPluginVersion=3.2.0
but when i start TemporalSpringbootSamplesApplication spring boot has version 2.7.18 (first log with banner)


helm install failed

Install command
$ helm install chaosblade-operator chaosblade-operator-1.5.0.tgz --namespace chaosblade
NAME: chaosblade-operator
LAST DEPLOYED: Wed Mar  9 16:59:01 2022
NAMESPACE: chaosblade
STATUS: deployed
REVISION: 1
TEST SUITE: None
NOTES:
Thank you for using chaosblade.

$ kuebctl get pod
No resources found in chaosblade namespace.

$ kubectl get rs
NAME                             DESIRED   CURRENT   READY   AGE
chaosblade-operator-7f7b79fcc5   1         0         0       6s

$ kubectl desribe rs
...
Events:
  Type     Reason        Age                From                   Message
  ----     ------        ----               ----                   -------
  Warning  FailedCreate  4s (x12 over 20s)  replicaset-controller  Error creating: Internal error occurred: failed calling webhook "chaosblade-operator.chaosblade.svc": Post "https://chaosblade-webhook-server.chaosblade.svc:443/mutating-pods?timeout=10s": dial tcp <IP_ADDRESS>:443: connect: connection refused

Version information
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.4", GitCommit:"e87da0bd6e03ec3fea7933c4b5263d151aafd07c", GitTreeState:"clean", BuildDate:"2021-02-18T16:12:00Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.4", GitCommit:"e87da0bd6e03ec3fea7933c4b5263d151aafd07c", GitTreeState:"clean", BuildDate:"2021-02-18T16:03:00Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}

this commit not add to release 1.5.0, so fix this in the your downloaded files and helm install will work


Some Pulsar cluster pods not starting up

Hi I tried to install pulsar but some pods are failing to start as below. I have attached the error logs as well.
Please advise. Thanks.
CR file:
kind: PulsarCluster
metadata:
  name: example-pulsarcluster
spec:
  zookeeper:
    image:
      repository: apachepulsar/pulsar-all
      tag: 2.6.3
      pullPolicy: IfNotPresent
    size: 3
  autoRecovery:
    image:
      repository: apachepulsar/pulsar-all
      tag: 2.6.3
      pullPolicy: IfNotPresent
  bookie:
    image:
      repository: apachepulsar/pulsar-all
      tag: 2.6.3
      pullPolicy: IfNotPresent
    size: 3
  broker:
    image:
      repository: apachepulsar/pulsar-all
      tag: 2.6.3
      pullPolicy: IfNotPresent
    size: 3
  proxy:
    image:
      repository: apachepulsar/pulsar-all
      tag: 2.6.3
      pullPolicy: IfNotPresent
    size: 3
  manager:
    enable: true
    host: manager.pulsar.com
    annotations:
      kubernetes.io/ingress.class: "nginx"

Failing pods
 oc get pods
NAME                                                              READY   STATUS             RESTARTS   AGE
example-pulsarcluster-bookie-autorecovery-deployment-5f9bdkqkkl   0/1     CrashLoopBackOff   8          19m
example-pulsarcluster-bookie-autorecovery-deployment-5f9bdstzp6   0/1     CrashLoopBackOff   8          19m
example-pulsarcluster-bookie-autorecovery-deployment-5f9bdww48g   0/1     CrashLoopBackOff   8          19m
example-pulsarcluster-bookie-statefulset-0                        0/1     CrashLoopBackOff   8          19m
example-pulsarcluster-bookie-statefulset-1                        0/1     CrashLoopBackOff   8          16m
example-pulsarcluster-broker-deployment-76478578c-9tgmm           0/1     CrashLoopBackOff   8          19m
example-pulsarcluster-broker-deployment-76478578c-ssxdv           0/1     CrashLoopBackOff   8          19m
example-pulsarcluster-broker-deployment-76478578c-ttkkr           0/1     CrashLoopBackOff   8          19m
example-pulsarcluster-init-cluster-metadata-job-j65ll             0/1     Completed          0          20m
example-pulsarcluster-manager-deployment-9f8c49d99-rwbgz          1/1     Running            0          19m
example-pulsarcluster-proxy-deployment-85cb9f7666-2f9m6           1/1     Running            0          19m
example-pulsarcluster-proxy-deployment-85cb9f7666-8lnwz           1/1     Running            0          19m
example-pulsarcluster-proxy-deployment-85cb9f7666-mnfsd           1/1     Running            0          19m
example-pulsarcluster-zookeeper-statefulset-0                     1/1     Running            0          25m
example-pulsarcluster-zookeeper-statefulset-1                     1/1     Running            0          23m
example-pulsarcluster-zookeeper-statefulset-2                     1/1     Running            0          22m
pulsar-operator-64c69f896f-5mmms                                  1/1     Running            0          46m

Error log
example-pulsarcluster-bookie-autorecovery-deployment-5f9bdkqkkl:
 Applying config zkServers = example-pulsarcluster-zookeeper-service
JMX enabled by default
Error: Could not find or load main class "

example-pulsarcluster-bookie-statefulset-0
 Applying config zkServers = example-pulsarcluster-zookeeper-service
Error: Could not find or load main class "

example-pulsarcluster-broker-deployment-76478578c-9tgmm
000
06:41:36.389 [pulsar-ordered-OrderedExecutor-3-0-EventThread] INFO  org.apache.pulsar.broker.namespace.OwnershipCache - Successfully acquired ownership of /namespace/public/functions/0x40000000_0x80000000
06:41:36.403 [pulsar-ordered-OrderedExecutor-7-0] INFO  org.apache.pulsar.broker.PulsarService - No ledger offloader configured, using NULL instance
06:41:36.430 [pulsar-ordered-OrderedExecutor-7-0] INFO  org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - Opening managed ledger public/functions/persistent/assignments
06:41:36.456 [bookkeeper-ml-workers-OrderedExecutor-0-0] INFO  org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - [public/functions/persistent/assignments] Creating ledger, metadata: {component=[109, 97, 110, 97, 103, 101, 100, 45, 108, 101, 100, 103, 101, 114], pulsar/managed-ledger=[112, 117, 98, 108, 105, 99, 47, 102, 117, 110, 99, 116, 105, 111, 110, 115, 47, 112, 101, 114, 115, 105, 115, 116, 101, 110, 116, 47, 97, 115, 115, 105, 103, 110, 109, 101, 110, 116, 115], application=[112, 117, 108, 115, 97, 114]} - metadata ops timeout : 60 seconds
06:41:36.463 [bookkeeper-ml-workers-OrderedExecutor-0-0] WARN  org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl - Failed to find 1 bookies : excludeBookies [], allBookies [].
06:41:36.470 [bookkeeper-ml-workers-OrderedExecutor-0-0] WARN  org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl - Failed to find 1 bookies : excludeBookies [], allBookies [].
06:41:36.470 [bookkeeper-ml-workers-OrderedExecutor-0-0] ERROR org.apache.bookkeeper.client.LedgerCreateOp - Not enough bookies to create ledger
06:41:36.471 [bookkeeper-ml-workers-OrderedExecutor-0-0] ERROR org.apache.bookkeeper.mledger.impl.ManagedLedgerFactoryImpl - [public/functions/persistent/assignments] Failed to initialize managed ledger: Not enough non-faulty bookies available
06:41:36.472 [bookkeeper-ml-workers-OrderedExecutor-0-0] INFO  org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl - [public/functions/persistent/assignments] Closing managed ledger
06:41:36.473 [bookkeeper-ml-workers-OrderedExecutor-0-0] WARN  org.apache.pulsar.broker.service.BrokerService - Failed to create topic persistent://public/functions/assignments
org.apache.bookkeeper.mledger.ManagedLedgerException: Not enough non-faulty bookies available
06:41:36.477 [pulsar-web-44-5] ERROR org.apache.pulsar.broker.admin.impl.PersistentTopicsBase - [null] Failed to create non-partitioned topic persistent://public/functions/assignments
java.util.concurrent.CompletionException: org.apache.pulsar.broker.service.BrokerServiceException$PersistenceException: org.apache.bookkeeper.mledger.ManagedLedgerException: Not enough non-faulty bookies available
        at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:292) ~[?:1.8.0_282]
        at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:308) ~[?:1.8.0_282]
        at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:607) ~[?:1.8.0_282]
        at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:591) ~[?:1.8.0_282]
        at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488) ~[?:1.8.0_282]
        at java.util.concurrent.CompletableFuture.completeExceptionally(CompletableFuture.java:1990) ~[?:1.8.0_282]
        at org.apache.pulsar.broker.service.BrokerService$3.openLedgerFailed(BrokerService.java:1086) ~[org.apache.pulsar-pulsar-

Currently, it can only support the old version of 2.5.0. The image of the new version of Pulsar has been updated. We will follow up the adaptation later。


Improve z-wave thermostat support

Discover thermostats using COMMAND_CLASS_THERMOSTAT_MODE so that it is a single entity when there are multiple setpoints.
z-wave docs mention this command class is required to be present.
Add support for single/dual target temperature depending
on the current thermostat mode.
I also verified thermostat is correctly exposed through Amazon Alexa/Google Assistant and single/dual setpoints are dynamically updating based on the current mode.
Breaking Change:
This changes the  primary command class for z-wave thermostats in discovery schemas from COMMAND_CLASS_THERMOSTAT_SETPOINT to COMMAND_CLASS_THERMOSTAT_MODE.
This will cause a typical dual setpoint thermostat to be correctly represented as a single entity.
Description:
Previously z-wave thermostats were discovered using COMMAND_CLASS_THERMOSTAT_SETPOINT as a primary value.
That caused a single thermostat to be exposed multiple times - once for each setpoint.
Also this PR adds dynamic single/dual setpoint support based on the current thermostat mode.
e.g. if current mode is HVAC_MODE_HEAT or HVAC_MODE_COOL  - expose single target temp ATTR_TEMPERATURE, if current mode is HVAC_MODE_HEAT_COOL - expose target range attributes ATTR_TARGET_TEMP_LOW and ATTR_TARGET_TEMP_HIGH
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
I will create PR for docs once I get feedback on this PR
Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the [development checklist][dev-checklist]

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code does not interact with devices:

[x] Tests have been added to verify that the new code works.

Z-Wave side looks fine to me, but I'd like to have someone with more knowledge of the climate platforms take a look

Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤
Please, add your GitHub username to the manifest.json of this integration.
For more information about "code owners", see: Architecture Decision Record 0008: Code owners.

Could someone review this when you have a chance? Thanks

It'd be great if we could continue here. I'm really looking forward to seeing these changes in the next release.
@oandrew Could you please improve the code coverage by writing some more tests. Besides some single lines only the aux_heat methods are untested.


Chat not found

Hello guys.
I'm using chat_list.rb sample to see my list chats, but the chat  i want is not displayed.

I have the same problem... did you found a solution?


Mock Map CDB server and execute tests for netowork

Codecov Report
Patch coverage has no change and project coverage change: -3.54 :warning:

Comparison is base (ab83d16) 53.24% compared to head (39a1287) 49.71%.

:exclamation: Current head 39a1287 differs from pull request most recent head 8b4b876. Consider uploading reports for the commit 8b4b876 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   53.24%   49.71%   -3.54%
==========================================
  Files          14       22       +8
  Lines         462      704     +242
  Branches      149      285     +136
==========================================
+ Hits          246      350     +104
- Misses        101      163      +62
- Partials      115      191      +76

Impacted Files
Coverage Δ

dbs-map-api/src/download/CatalogClientImpl.cpp
41.37% <0.00%> (ø)

dbs-map-api/src/download/ClientSettings.cpp
50.00% <ø> (ø)

dbs-map-api/src/download/LayerClientImpl.cpp
37.50% <0.00%> (ø)

... and 7 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Error in binning operation?

I've recently noticed that in my own dataset implementation for the gen1 dataset which is derived from this repository's implementation there was curious artifact: The third channel for the event images did not contain any events!
I've traced it back to what could be the issue and I believe I have found it here in line 125 of the gen1_od_dataset.py:
tbin_feats = ((events['p']+1) * (tbin_coords+1)) - 1

The goal is to sort the events (under the default settings) into 2 time bins of each 2 polarities. However, with this line the result can never be "2" (as in, the third channel), assuming values of 0 or 1 for both the polarities and the tbin_coords. Positive changes of the first time bin are mixed together with negative changes of the second time bin, both resulting in 1 of this equation.
I believe the following line will do the intended:
tbin_feats = (2 * tbin_coords) + events["p"]

This does seem to solve the issue in my adapted copy. However, I first wanted to make sure that I didn't overlook anything before suggesting a pull request.

Hello,
It seems that you are right. It would be interesting to see how this changes the results obtained in classification and in object detection.
Thank you for noticing that

My pleasure. Seeing as the data was still present in the 2nd channel, I guess the difference shouldn't be too great and for my model the performance didn't change much. Generally, I guess the only way is up.


Create copyright.html

Add Copyright Page
Description
This pull request introduces a fully responsive Copyright page for the Collect Your Gaming Tools website. The following features and improvements have been implemented:
Features and Improvements

Navbar: Added a centered navigation bar with links to "Home," "About," and a "Switch Theme" button.
Dark Theme: Implemented a dark theme for the Copyright page, ensuring a consistent user experience across the site.
Responsive Design: Utilized flexbox to create a responsive layout that stacks navbar items vertically on smaller screens.
Hover Effects: Added hover effects to buttons and sections for improved user interaction.
Copyright Sections: Structured the page with clear sections outlining copyright notice, content ownership, trademark information, and contact details.
Footer: Included a footer stating copyright information, ensuring compliance and professionalism.

Additional Changes

Updated CSS to enhance styling for both light and dark themes.
Ensured all interactive elements are easily accessible and visually appealing.

Testing
The Copyright page has been tested across various devices and screen sizes to ensure proper responsiveness and usability.

Note: Please review the code and assign me LEVEL 3 for this @swaraj-das
fixes: #576

Great job 👍

Link it with the main page

https://github.com/swaraj-das/Collect-your-GamingTools/pull/608

Link it with the main page

Check. It. Please https://github.com/swaraj-das/Collect-your-GamingTools/pull/608

@swaraj-das please say something to her because I don't have any words to say her.

@neeru24 "Pull requests that only partially address an issue are not acceptable. We will only consider merging your PR if it fully resolves the issue. Submitting incomplete solutions in parts solely to gain extra points on the leaderboard is prohibited and will not be tolerated."

@neeru24 "Pull requests that only partially address an issue are not acceptable. We will only consider merging your PR if it fully resolves the issue. Submitting incomplete solutions in parts solely to gain extra points on the leaderboard is prohibited and will not be tolerated."

I agree but I was assigned with the issues and I did what I mentioned in the issue like there was no page for

@swaraj-das please say something to her because I don't have any words to say her.

I'm shocked to see PRs submitted separately for such closely related tasks like adding links in HTML and creating the actual pages. I previously noticed someone else doing something similar. This behavior is not acceptable, and if it continues, I will have no choice but to report it to the event organizers.

@neeru24 "Pull requests that only partially address an issue are not acceptable. We will only consider merging your PR if it fully resolves the issue. Submitting incomplete solutions in parts solely to gain extra points on the leaderboard is prohibited and will not be tolerated."

I agree but I was assigned with the issues and I did what I mentioned in the issue like there was no page for copyright and I created that and I've changed the main file too that links it with that.. So May I please know where the issue is partially addressed?

Sync your fork, and you'll find a 'policies' folder. Add all the policy HTML files there and link them in the index.

@neeru24 "Pull requests that only partially address an issue are not acceptable. We will only consider merging your PR if it fully resolves the issue. Submitting incomplete solutions in parts solely to gain extra points on the leaderboard is prohibited and will not be tolerated."

I agree but I was assigned with the issues and I did what I mentioned in the issue like there was no page for copyright and I created that and I've changed the main file too that links it with that.. So May I please know where the issue is partially addressed?

Sync your fork, and you'll find a 'policies' folder. Add all the policy HTML files there and link them in the index.

Okay, Thank you for helping out and please tell us before making any comment like what we are doing wrong. Many of the contributors are new to open source, so it would be better if you could guide us.

Sync your fork, and you'll find a 'policies' folder. Add all the policy HTML files there and link them in the index.

Done with the changes that you said, I added the files in policies folder and linked with index.html file too.
Kindly check and please let me know if any issues are there @swaraj-das .
Thank you!!


Bootstrap template support

After the setup it seems the style not supporting as I'm using bootstrap

Yes, it's not. You have to eject the views and style the component yourself.
See: https://github.com/masmerise/livewire-toaster?tab=readme-ov-file#view-customization


Upgrade revision to current for containers that do not need an upgrade

Closing as the revision doesn't have to match


TEROS pipeline review request

Hi @bpbond
Could you please take a look at the revised "TEROS12_Pipline.R" script? It's located here: TEMPEST/Data/Soil VWC, T, and EC (TEROS12)/
I really tried to embrace the "if you're copying and pasting, you're doing something wrong" principle :-) The script collapses all of the TEROS data into a single data frame. I did have trouble reshaping each variable into its own column and tagged you with "BBL" on line 65 with a question.
I feel like this is a HUGE coding step forward for me and really appreciate all of your guidance and feedback.
Looking forward to your thoughts!

Hi @ahopple looks GREAT!  👏   I'll open a PR but a few notes here:

You deleted the RStudio project file; any particular reason? If not let's leave it please. Restoring.
You never ever ever :) want to do setwd() at the beginning of your script. It makes scripts fragile and unusable by anyone else; see here and here.
I fixed the problem (initial blank line) in TEROS11_10202020.txt
I added a pattern-match to the list.files() call so it only looks for TEROS files, not e.g. README files
Simplified overly-complex apply calls
Changed from x1, x2, etc. to more informative names
You like your comments to have no space at the beginning, while I do. It's a war 😄
I moved the na.omit() much earlier in the pipeline—there's a lot of data here, so we want to remove missing rows as early as possible
Use tibble instead of data.frame for data—much easier to print
The spread wasn't working because there are duplicate rows; fixed
Changed plots to give each sensor its own line
Looks like we have some sensors with no matching plot

I just noticed the timestamp of this issue. Hahaha hi there night owl  🦉

Thank you @bpbond !! Yes, I was a total night owl 😄 It has been difficult to be selfish with my time the last two weeks given the field work load, so I just had to find time to work on my coding. It's also very hard to stop once you get going...
I added a few responses in bold below.

You deleted the RStudio project file; any particular reason? If not let's leave it please. Restoring.
Sorry about that. I was cleaning up my old files and saw that it was empty, so I deleted it. Forgot that we had just created it :-/

You never ever ever :) want to do setwd() at the beginning of your script. It makes scripts fragile and unusable by anyone else; see here and here.
Got it

I fixed the problem (initial blank line) in TEROS11_10202020.txt 👍

I added a pattern-match to the list.files() call so it only looks for TEROS files, not e.g. README files 👍

Simplified overly-complex apply calls 👍

Changed from x1, x2, etc. to more informative names 👍

You like your comments to have no space at the beginning, while I do. It's a war 😄
haha! just like folks that write proposal/papers with two spaces between sentences - you're probably one of those too 😄

I moved the na.omit() much earlier in the pipeline—there's a lot of data here, so we want to remove missing rows as early as possible 👍

I suggest using tibble instead of data.frame for data—much easier to print 👍

The spread wasn't working because there are duplicate rows; fixed 👍

Changed plots to give each sensor its own line 👍

Looks like we have some sensors with no matching plot
I'll take a look at this. There are many data table channels that will have no plot, but all sensors should have a plot


Slow MIQ performance on a clean VM installation

Upon installing Manage IQ on a VM using the default parameters, engine UI, specifically menu items navigation performs very slowly. After a while (probably hours), it starts to behave normally.
VM (appliance) specification: 16GB of RAM, 4 cores, one disk of 66Gb, running on oVirt 4.2.2.
We didn't noticed this issue or former versions that we worked on.
Version-Release: MIQ master.20180417121918_2dd64f8
Logs are available on a ticket opened on Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1571223

This issue seem to be urgent as it reproduces when power cycling the manageIQ VM.
It also happen on our 2 RHV separate systems.
Note that after some time (I think hours, but I'll need to double check that) , the slowness is gone, and the UI response is back to normal.

@mkalfon or @istein1 Do you know if vmware and rhevm are intended to run. or if just one of them?
I noticed on the second environment that workers for both are running. This may be nothing. or this may be causing memory pressure / swapping.

Also, could you include the complete evm.logs? It looks like they were rotated and we would like to see the first messages to understand it more

@kbrock , Regarding the 2nd env - This is a manageiq VM installed on Apr 19, and I'll attach the evm.log this date to the bug, when it was working slowly. Later on, we added to this env, v2v automate domain, and turned the RHV hosts into conversion hosts. I shall send by email the env details. As mentioned before,
this env do not have the slow UI issue right now. If it can help, I can recycle the machine, and see if it reproduces (same as what we had or the first env). also we can easily run the ansible playbook again to create a new same manageiq VM, and check it before adding providers, or anything related to v2v - I believe the slowness should reproduce there as well.
The RHV & VMware are there added for the v2v testing. The slowness was seen right from the start, after creating the manageiq VM, even before adding the providers.
As far as I remember the memory/cpu were not close to 100% when it was slow.

@kbrock both RHV and VMware are registered in the MIQ. The propose is to check migration from VMware to RHV.
About the complete evm logs -  I will attach them to the original BZ.

@mkalfon this issue seems to be resolved now that the BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1571223 is resolved. Can you close this issue.

Mors is no longer at RH
Adding Sudhir,
Sudhir this is an upstream MIQ  5.10 bug to close, we are not having
upstream envs any more.
If you have someone in the team that has upstream to validate it?
On Wed, Nov 21, 2018 at 9:57 PM John Prause<EMAIL_ADDRESS>wrote:

@mkalfon https://github.com/mkalfon this issue seems to be resolved now
that the BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1571223 is
resolved. Can you close this issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ManageIQ/manageiq/issues/17339#issuecomment-440791256,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ASnCY8ozNMWwnqebBOubD4wI5_fevqrjks5uxbAfgaJpZM4Th4ak
.

--
Daniel Gur
Associate Manager, RHV QE
Red Hat Israel
<EMAIL_ADDRESS>  IM: dagur
Phone:+972-97692196 <+972%209-769-2196>
Cell: +972-54-9266687 <+972%2054-926-6687>


Everything is good except the resolution on Retina screen.

This is a repeat of https://github.com/Kethku/neovide/issues/455


Add actual integration queries to table

Description
Adds the ability to dynamically load integrations into the installed integrations table, and reactivates the tab. Also adds some terminal spacing to the S3 setup page since it was getting clipped by the bottom bar.
TODO: Cypress tests
Empty Table:

When an empty test integration is added that matches the data source:

Issues Resolved
N/A
Check List

[X] New functionality includes testing.

[X] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Depends on #1530


How to install wrapper offline?

Hey guys! Can someone how to install wrapper offline?

Download this and extract it: https://github.com/wrapper-offline/wrapper-offline/releases/tag/v2.0.0

I mean wrapper offline 2.1.0

I could use root on my computer when it works

2.1 isn't finished yet. it's not even usable right now

Download this and extract it: https://github.com/wrapper-offline/wrapper-offline/releases/tag/v2.0.0

2.1 isn't finished yet. it's not even usable right now

2.1 isn't finished yet. it's not even usable right now

Ok! Soon?

It's being worked on

octanuary? I could recreate lil peepz template characters for myself. Did you put all lil peepz stock characters?

Only a few of them are in there.

It's being worked on

Yep! It might be a new version will comes out.

Only a few of them are in there.

Great.

I have lil peepz stock characters.
lil peepz stock characters


refresh tokens

 Issue by sym3tri
Thursday Jul 02, 2015 at 21:43 GMT
Originally opened as https://github.com/coreos-inc/auth/issues/295

For better security we should transition to having shorter-lived JWTs and instead issue refresh tokens to client apps so they can refresh the user's token on their behalf. Adding such a feature would require the ability for a user to revoke access to an app as well.

Moving to #261


Addition of Hamburger Menu for mobile devices

The current nav-bar in mobile view

This issue is under GSS0C 2024

@khushi-joshi-05 please kindly look into this


Minimap: location hexagons not visible

Example: https://hello.nrfcloud.com/map/#id:bestower-conyrine-overrich!m:6.051610607029811:62.22904970876206,5.350398918615497!t:ko;location:di;14201;2:di;14201;0:di;14201;1

Yes sure, it hasn't been sold yet.
~Markus

From: Aarshit Jolapara @.>
Sent: Tuesday, December 17, 2024 5:11:32 PM
To: hello-nrfcloud/map @.>
Cc: Tacker, Markus @.>; Mention @.>
Subject: Re: [hello-nrfcloud/map] Minimap: location hexagons not visible (Issue #381)
can I work on this issue or is it already solved ?
@coderbyhearthttps://github.com/coderbyheart
—
Reply to this email directly, view it on GitHubhttps://github.com/hello-nrfcloud/map/issues/381#issuecomment-2548905033, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AABOD437XCIOE5AP4QYXS532GBELJAVCNFSM6AAAAABTYL4G32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBYHEYDKMBTGM.
You are receiving this because you were mentioned.Message ID: @.***>

can you provide the values to be set for the environment variables ? like MapRegion, MapName and ApiKey ?

You can set this up in your own AWS account using https://github.com/hello-nrfcloud/aws-map


Add a dart format check for 120 char line length

In theory, this check should fail as there are two dart files that dart format will want to change. I'll update them in this PR, once we have confirmed Github Action sets a failure flag.

@domesticmouse it looks like the new validation check found some format changes and failed.

Well, at least the line length check passes now...

I'm going to submit this with CI failures because the failures are related to out-of-date website code.
I filed: https://github.com/superlistapp/super_editor/issues/240


Teradata connector job type: Support avro schema inline, added credential name parameter

Support avro schema inline, added credential name parameter. Tested.

Both changes look good.

LGTM


@xstate/react: add context option for convenience

Compilation will fail due to UseMachineOptions warning.
As I don't know TS, I'll need help to fix it.
cc @davidkpiano @Andarist

Closed in favor of #541. GitHub didn't loaded latest PR changes. 🤔


[JAVA-2720] support using Enum in queries through PojoCodec

https://jira.mongodb.org/browse/JAVA-2720
We need this, I am not entirely sure of the implication for existing code. To me it seems like a simple fix, and essential to claim that enums are fully supported.

Hi @AarjavP, thanks for the PR. I think that there are some implications for the existing code here.
The simplest fix would be to add a EnumCodec to the codec registry that you want to use. The best fix would be to use the Codec that is specifically assigned to: myPojo.mySpecialEnumProperty. It maybe if users want to specialize then they will have to have their own enum codec higher up than the codec registry and we fall through to the base EnumCodec, considerations also have to be made to ensure any changes don't break existing users.

As part of the fix for JAVA-4440, there is now a EnumCodec<T extends Enum<T>> implements Codec<T> in the default codec registry, so it's no longer restricted to being used as part of POJO encoding/decoding, so I think we can close out this PR.  Sorry for the long delay on it.


Add SSR support

This pull request add support SSR for SEO.
I checked it for Nuxt.
Now during the first rendering from the server comes:

        long long text END
        READ MORE

And then, at the front, all the vue-clamp magic is fulfilled.

Merged #33 instead.


TypeError: cb is not a function

whenever i try to use the module i get a:
/root/node_modules/twitch-get-stream/index.js:136
      return cb(null, _us.compact(M3U.parse(resp)));
             ^

TypeError: cb is not a function

error. in fact, why do you use cb when you make a return?

Are you sure you are using the library properly? If I have not documented it properly in the README here is an example usage that I may add to it:
var twitchStreams = require('twitch-get-stream');

twitchStreams.get('channel', function(err, streams) {
    if (err) console.log('Getting streams error:', err);
    console.log('Streams successfully got, data: \n', streams);
});

FailFish,i didn't put the js callback. working at 2AM is not a good thing. Thanks

No problem. As a side note I have updated the library to support Promises, if that interests you.


brook: 20210701 -> 20220401

Motivation for this change
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Hi @marsam, @bobby285271, @c0bw3b I think this PR is ready to be merged. Thank you!!

@c0bw3b Thank you!!


Reusing logic from kubernetes/test-infra?

Some things in prow are pretty straightforward to re-implement, but some is quite a bit of logic. A big feature that I'm interested in is determining which reviewers and approvers to select for a pull request when there can be multiple OWNERS files defined in a repository, and then ensuring that a PR isn't merged until approvers from all OWNERS files have given approval. So if a PR touches two directories, which have different approvers, both approvers would have to approve the PR before it is merged by our github action. (Correct me if I'm misunderstanding how prow works!)
The kuberentes/test-infra repository defines this logic and has functions that we could export, wrap and call from javascript. Alternatively we could port these functions to typescript.
Before I spent time doing any of that, I wanted to get a feel for what you would prefer? I'm down for implementing either solution.

@carolynvs - Hmmmm. I'm not sure; I had looked at re-using some Go code from prow and test-infra early on, but at the time, the Go octokit API library was being archived. But seems there is a google maintained go-github library nowadays that may work for our needs.
I'm also not sure what real benefit we would get from a full re-write vs a port. I'd consider this github action fairly stable and I worry about introducing more complexity for users and maintainers if we wanted to re-using much logic from kubernetes in Go.
But it sounds like you're asking if we could look into somehow importing that Go code and wrapping it around executors we could use in this javascript action? I'd be all for investigating that and if it's stable, let's do it!
Opinions welcome!

Maybe a simple example of how we could do that with a small go library would help me wrap my head around what you're suggesting. If I had to read between the lines, sounds like how you'd do that is

import the necessary libraries with public methods into our own go program
build/compile that binary
have our action (written in TS) execute that binary with some inputs, deriving the outputs

?

Oh yeah sorry, I totally am not interesting in reimplementing the gh-action in Go! 😬  What you suggested above was exactly what I was thinking for how to reuse test-infra without having to port chunks of it from go to typescript. I'm not sure which is more effort to maintain over time so I may explore both options.
I mostly wanted to make sure that if one was super distasteful that I knew not to waste time going down that path.

I'm super into this investigation! Absolutely happy to chime in as well!

Hey @carolynvs & @jpmcb ! I've been keeping an eye on this issue and pretty interested in this feature... just curious, are you guys currently working on this / is it close to being done? Love the project 🙂

Hi @ashleypafko - I personally haven't been investigating this (I wish I had more time to do open source stuff 😭)
I'm open to any contributions on this and I'd be super interested to hear what could work. If you want to pick this up, I'd be happy to see what you come up with!

Same, I haven't had time to work on this but would be super interested in seeing it implemented!


Fix release pipeline to work with branch protections

The release.yml workflow relies on the Maven Release Plugin to push commits to main. It does this using the https://github.com/tbd-releases account. Because of branch protections and the way we cannot bypass them in GitHub configs, we have to adapt the release workflow to initiatlize the release process off a branch, push changes to that branch, create a PR, then merge that PR/branch back into main.

WIP in issue-296/release-with-branch-protections

Also WIP for testing in https://github.com/ALRubinger/web5-kt.
To be ported upstream when working there.

Using prerelease branch to stage release commits looks good so far:
Version to be released: 1.0.0-maven-rc-3
Setting next development version back to original in pom.xml: 0.0.0-main-SNAPSHOT
Staging release commits in branch: prerelease-c85ccd9-1.0.0-maven-rc-3
Switched to a new branch 'prerelease-c85ccd9-1.0.0-maven-rc-3'

https://github.com/ALRubinger/web5-kt/actions/runs/8592653569/job/23542981631#step:6:48

Excellent, release commits nicely seated in a branch:
https://github.com/ALRubinger/web5-kt/commits/prerelease-c85ccd9-1.0.0-maven-rc-3/
Now to use GH REST API to make a PR and merge it into main so branch protections are honored.

Replaced by #297 - no more work to be done here.


Scan: inscribed manifest hash and calculated manifest hash don't match

Defaults on for creators only.

When the user is a Mod Creator, include a resolution to immediately jump into the Manifest Editor to update the manifest.


fix: Update Function Calling notebooks to Gemini 1.5 Pro (Preview)

Description

[x] Follow the CONTRIBUTING Guide.
[x] You are listed as the author in your notebook or README file.

[x] Your account is listed in CODEOWNERS for the file(s).

[x] Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
[x] Ensure the tests and linter pass (Run nox -s format from the repository root to format).
[x] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Thanks, @jeffonelson!


Update README.md

The file edited should be +page.server.js, not +layout.server.js, according to the interactive editor.

The sentence is correct as is - it's talking about the general case, not the specific code in the tutorial. Therefore closing - thank you.


Reverting PR #81

This PR reverts #81 as it turned out that change prevents the usage of non fully populated sample files. For example if a sample file set a service disabled then it should not be required to list the containerImage for that service.
The issue is caused by the limitation of the replace strategy of kustomize that cannot handle more than one level of missing keys in the input. A possible way forward is to use the patchesStrategicMerge strategy instead.

lets test #103 first if it works then we can close this

#103 has some issues so we did the revert instead.


Interpolating X-axis Labels

Hello, Im Trying to build an elevation profile with chartist, but I think I might have hit a limit with the API. Is it possible to automatically interpolate the labels for the chart based on my data?
I can feed the labels and elevation, but the labels are all the way on the bottom left.

The data looks like this:

[
{
"x": 0.9878496330053217,
"y": 13.97893524169922
},
{
"x": 1.0041204813282845,
"y": 13.95929145812988
},
{
"x": 1.0252231341556972,
"y": 13.62137603759766
},
{
"x": 1.0857809687540954,
"y": 12.28152847290039
},
{
"x": 1.943662971285518,
"y": 14.33559703826904
},
{
"x": 2.076852557325997,
"y": 14.82799530029297
},
]

Full data sample: https://gist.github.com/fullhdpixel/15cc2910ec68ec05c9edebd016b7649a

Hello @fullhdpixel 👋
Chartist has recently been updated to version 1.0 with some new exciting changes like ESM and TypeScript support. The migration guide can be found right here.
Please let me know if the question is still relevant to you so we can further look into it!


benchmark a reasonable size for the buffer

In bmap::copy we use a vector as buffer. We need to find the right size to set it up before using it. The current value is 8 * 1024 * 1024.  (bmap/src/lib.rs line 46)

As an idea this value could be a constant since it's going to be shared by different copy functions. Something like BUFFER_SIZE


Feature/update to latest swagger

update to latest swagger
update sdk code based on latest swagger

resolve to unblock content. will address all comments in a later update.


Problem using snmpsim subprocess module

Hi!
I'm currently running snmpsim 0.4.7 on Python 2.7 and I ame facing a problem using the supbrocess module :
my snmprec file contains the following line :
<IP_ADDRESS>.<IP_ADDRESS>.0|2:subprocess|echo 1
but it doens't seems to work as expected since a snmp set on this oid return the following error :
No Such Instance currently exists at this OID
the log gave us some insight :
2019-05-22T14:26:42.32 snmpsimd: Request var-binds: <IP_ADDRESS>.<IP_ADDRESS>.0=<2>, flags: EXACT, SET
2019-05-22T14:26:42.32 snmpsimd: subprocess: executing external process "echo 1"
2019-05-22T14:26:42.32 snmpsimd: ERROR data error at /dossier_config/private.snmprec controller for <IP_ADDRESS>.<IP_ADDRESS>.0: value evaluation error for tag '2', value '\n'
2019-05-22T14:26:42.32 snmpsimd: Response var-binds: <IP_ADDRESS>.<IP_ADDRESS>.0=<No Such Instance currently exists at this OID>

I tried to exectute the subprocess example described in the documentation :
<IP_ADDRESS>.<IP_ADDRESS>.0|2:subprocess|date +%s
But I ran on a type error (trying to set a string instead of an integer), the string beeing :
"Fri May 24 11:32:37 CEST 2019" as if the statement executed by subprocess was  sliced on first space.

I seem to recall similar bug fixed in the past... Could you try your setup with the upcoming snmpsim version 0.4.8 please? If it still fails, we will have to look into that.
Thanks!

Thanks for your anwser !
We did so but it didn't solve the problem, logs are a bit different though :
snmpsimd: Request var-binds: <IP_ADDRESS>.4.1.383<IP_ADDRESS>.3.2=<3>, flags: EXACT, SET
snmpsimd: subprocess: executing external process "./dossier_config/prog_shell.sh 3"
snmpsimd: ERROR data error at /dossier_config/private.snmprec controller for <IP_ADDRESS>.4.1.383<IP_ADDRESS>.3.2: value evaluation error for tag '2', value '\n': Can't coerce '\n' into integer: '\n'
snmpsimd: Response var-binds: <IP_ADDRESS>.4.1.383<IP_ADDRESS>.3.2=<No Such Instance currently exists at this OID>


Inspector.targetCrashed received when no_sandbox: true on Chromium 115 on Linux

I'm getting [error] ChromicPDF received an 'Inspector.targetCrashed' message. when I start my Phoenix app. If I downgrade Chromium to 114, or replace no_sandbox: true with chrome_args: "--no-sandbox", the error is gone. If I add "--no-zygote" to chrome_args, the error is back.
I don't really know what to make of all this, but I hope it helps.

Hey @aptinio,
can you share some details on your setup? Chromium version that has the error, but also host OS, environment, Elixir version, etc.. So we can try to reproduce this error.

This happens on my dev environment:

Arch Linux
asdf-managed Elixir and Erlang/OTP versions:

1.15.4-otp-25 and <IP_ADDRESS>
1.15.4-otp-26 and 26.0.2

Chromium 115.0.5790.170

and on prod too:

Docker image hexpm/elixir:1.15.4-erlang-26.0.2-debian-bookworm-20230612-slim
same Chromium version 115.0.5790.170

My chromic_pdf_options:
defp chromic_pdf_options do
  [
    disable_scripts: true,
    no_sandbox: true,
    offline: true
  ]
end

Thanks @maltoe!

For now, I did this:
   defp chromic_pdf_options do
     [
       disable_scripts: true,
-      no_sandbox: true,
+      chrome_args: "--no-sandbox",
       offline: true
     ]
   end

@aptinio Thanks for the report. I've been able to reproduce this bug on Debian Bookworm. I have not attempted to find the bug / changed behaviour within chrome or the more recent environment, and also have not found any matching issue in their trackers.
At the same time, I can't recall why the --no-zygote flag is present there at all. Puppeteer doesn't seem to have equivalent code, and the docs I could find just say that when you use --no-zygote, you must use --no-sandbox as well (but not vice versa). So, I think --no-zygote is a mistake here and am tempted to simple go for #272, though breaking existing setups is a concern of cause. I did check on Alpine 3.16 and Debian Buster that --no-zygote isn't needed to run an unsandboxed root chrome, so it may be fine.
@andreasknoepfle wdyt? Remove the flag and risk breaking people's setups (certainly change people's setup though, as removing --no-zygote will add the zygote process) or play it safe?

"Playing it safe" could be: Deprecate --no-sandbox with a warning and change the docs to just tell people to use chrome_args as in @aptinio 's snippet.

Decided to YOLO it this time as tests in our CI environments suggest that --no-zygote was never needed and hence it seems unlikely that anyone will notice it.

It does. Thanks @maltoe! :relaxed:


[Bug Report]: SQL-administrators as AD user does not get applied

Describe the bug
param sqlServerAadAdministrators object = {
  azureADOnlyAuthentication: false
  principalType: 'User'
  login: 'XX' //my upn
  sid: 'myId' // as output from az ad user show --id
  tenantId: subscription().tenantId
}

but it does not affect anything, and in the portal the "Azure Active Directory admin" is set "not configured"
https://learn.microsoft.com/en-us/azure/templates/microsoft.sql/servers/administrators?pivots=deployment-language-bicep
seems to describe a sub-resource, and others have described the same issue and resolution in: https://github.com/Azure/bicep/issues/2897#issuecomment-924054112
To reproduce
create sql server with AAD login. in my case the aad login was added after initially creating the resource. and i also have password based logins active and not exclusively aad
Code snippet
param sqlServerAadAdministrators object = {
  azureADOnlyAuthentication: false
  principalType: 'User'
  login: 'XX' //my upn
  sid: 'myId' // as output from az ad user show --id
  tenantId: subscription().tenantId
}

module sqlServer 'br/ouralias:bicep/modules/microsoft.sql.servers:0.5.1207' = {
  name: databaseServerName
  params: {
    name: databaseServerName
    administratorLogin: sqlServerAdminUsername
    administratorLoginPassword: sqlServerAdminPassword
    administrators: sqlServerAadAdministrators
    privateEndpoints: [{
      subnetResourceId: sqlServerSubnet.id
      service: 'sqlServer'
      privateDnsZoneGroup: {
        privateDNSResourceIds: [sqlServerPrivateDnsZoneGroup.id]
      }
      tags: commonTags
    }]
    databases: [{
      name: databaseName
      diagnosticLogsRetentionInDays: diagnosticLogsRetentionInDays
      diagnosticWorkspaceId: logAnalyticsWorkspace.id
      diagnosticLogCategoriesToEnable: ['allLogs']
      diagnosticMetricsToEnable: ['Basic']
      skuName: isDevelopment ? 'Basic' : null
      skuTier: isDevelopment ? 'Basic' : null
      // need to override a hardcoded value in template for basic tier
      maxSizeBytes: isDevelopment ? 1024*1024*1024 : null
      tags: commonTags
      }
    ]
    tags: commonTags
  }
}

### Relevant log output

_No response_

If I add
resource sqlServerAadLogin 'Microsoft.Sql/servers/administrators@2022-05-01-preview' = {
  name: '${sqlServer.name}/ActiveDirectory'
  properties: {
    administratorType: 'ActiveDirectory'
    login: sqlServerAadAdministrators.login
    sid: sqlServerAadAdministrators.sid
    tenantId: sqlServerAadAdministrators.tenantId
  }
}

it works

which version of CARML are you utilizing here? Our current implementation looks different to yours.

0.5.1207

Upon revalidation our code (with spn and with user separately) both cases deployed fine and showed the correct behavior in the portal.

Does this change if you do the first run with administratorLogin+ administratorLoginPassword, then do 2nd run with same + administrators (AAD config).

hm, then I must have been confused. Let's close this, and I'll reopen if still a problem


Bug Found in buildRingScheduler

While trying to build some code coverage tests, I wrote this test of FuelHandler.buildRingScheduler():
schedule, widths = fh.buildRingSchedule(1, 17, jumpRingFrom=0)
self.assertEqual(schedule, [17, 16, 15, 14, 13, 12, 11, 10, 2, 3, 4, 5, 6, 7, 8, 9, 1])

Notice the strange jump from 10 to 2.
At a guess, perhaps the problem is here:
https://github.com/terrapower/armi/blob/b94744fdf12f247828dd07bf99e251651b494a13/armi/physics/fuelCycle/fuelHandlers.py#L1186-L1190
Perhaps this is meant to be: elif jumpRingTo is None:.

Weird for sure but this may not be a bug. this comes from the fact that the refSmallCoreGrid.yaml has 9 rings in it, and so jumpRingTo is set to 9 from core.getNumRings().
Should the thing just fail if you put a charge or discharge ring number that's greater than getNumRings? Maybe. But that can be a pain e.g. if you are param sweeping on number of rings and want to use it as e.g. an overlay.

@ntouran I hadn't considered the parameter sweep issues.  At the very least, I would like us to catch such edge cases and fail with a more descriptive message. But I think there is a possibility here for more error catching than we currently have.


It is not possible to change the Heap size or other "-X" params of the Hub JVM

In Config.java, you can see the param string is computed by always prepending "-D" to a key-value pair:
Consequently, using the "grid_jvm_options" option, it's impossible to set "-Xmx4g" or something like that to increase the heap size of the hub.
I will fix this by adding an additional config option, "grid_jvm_x_options" which is just a raw string you can add to the commandline options.
Here's the faulty code that limits us too much:

protected String mapToJvmParams(Map params) {
        String returnString = "";

        for (String key : params.keySet()) {
            Object value = params.get(key);
            String formattedValue = "";

            if (value instanceof Number) {
                formattedValue = "" + ((Number) value).intValue() + "";
            } else {
                formattedValue = value.toString();
            }

            returnString = returnString + "-D" + key + "=" + formattedValue + " ";
        }

        return returnString;
    }

Thanks for merging my pull request!


Results for DINO v2?

Hey,
First of all great work! I noticed in the code that dino v2 protector has also been implemented. I was wondering do you have the results for it?
Thanks!

Hi,
Thank you for your interest in our research. Yeah, we tested both DINOv2 and DINOv1 and realized that DINOv1 works slightly better than DINOv2. But you can go ahead and train the model ;)


Write Redis add-on middleware

Add middleware to attach a Redis instance to GrAMPS for caching. This will be a new package.

This is mostly already written — need to convert to use a non-internal Redis setup by default.


Standalone revad Chart refactor

This is a followup of the changes in:

https://github.com/cs3org/reva/pull/826
https://github.com/cs3org/reva/pull/842

Now the chart deploys reva as a standalone pod (removing the additional gateway container) and exposing two services: HTTP and GRPC. If more revad pods are required, they can be deployed with the chart in the same fashion.
Also move #4 (OC Dataprovider) to an entry in the README with instructions on how to deploy it on an existing IOP.
Contributing a Chart / update to an existing Chart

[x] Run helm lint on the chart dir.
[x] (Update) Bump the Chart.yaml version before merging, to release it as a new version.

@labkode good point. Will remove it from the README. Should we keep it under some section of https://developer.sciencemesh.io/docs/ instead?

@SamuAlfageme not needed for now as the example is not complete neither to have it working with Phoenix.


Repository structure rework

Propasal:
Rework current repository folder structure to the next:
    .
    ├── docs                    # Documentation files
    ├── src                     # Source files
    ├── tests                   # Unit tests
    ├── LICENSE
    └── README.md

Move all test projects to separate repository AspNetCore.Identity.Mongo.Example.
Why:

Repository contains a lot of unstructured code
Repository does not have unit tests
Test projects (like SelfCheck, TestIdentityServer, TestSite ) are not the best way to test library. They good to be useful examples of library usage.

Unit tests should not be the part of repository folder structure refactoring.
Created another issue for it.
See #81

.
├── docs                    # Documentation files
├── src                     # Source files
├── samples                 # Projects with samples of lib usage
├── tests                   # Unit tests
├── LICENSE
└── README.md

.
├── docs                    # Documentation files
├── src                     # Source files
├── samples                 # Projects with samples of lib usage
├── tests                   # Unit tests
├── LICENSE
└── README.md


SAM-2589 Wrong check marks in "Question Scores" for calculated questions

I've discovered a possible bug in this patch. Changing status to "In progress"...

There is an issue with this PR can you remove the commit that is not related.

ICLA is on file. removed cla? label.

Hi,
The commit that is not related has been removed.
Thanks!