podman cp fails (writing file /sys/fs/cgroup//cgroup.freeze: Permission denied)

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug

Steps to reproduce the issue:
$ podman run -d --name t3 ubuntu:focal sleep infinity
$ echo > /tmp/a
$ podman cp /tmp/a t3:/tmp
2020-02-09T18:30:21.000096406Z: writing file `/sys/fs/cgroup//cgroup.freeze`: Permission denied
Error: `/usr/bin/crun pause b61e5703bd1b6d0021dfc8d7b0b21cf2843721a4081bbdd7027c7c511e63a9b4` failed: exit status 1

Describe the results you expected:
No failure (like docker)
Additional information you deem important (e.g. issue happens only occasionally):
Output of podman version:
$ podman version
Version:            1.8.0
RemoteAPI Version:  1
Go Version:         go1.13.6
OS/Arch:            linux/amd64

That cgroup path looks incorrect, it's missing any container ID or other
identifier. We should be populating that automatically on container
creation, which makes me think something in the config might be preventing
that. Can you provide ~/.config/containers/libpod.conf?
On Sun, Feb 9, 2020, 13:33 MarcoFalke<EMAIL_ADDRESS>wrote:

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)
/kind bug
Steps to reproduce the issue:
$ podman run -d --name t3 ubuntu:focal sleep infinity
$ echo > /tmp/a
$ podman cp /tmp/a t3:/tmp
2020-02-09T18:30:21.000096406Z: writing file /sys/fs/cgroup//cgroup.freeze: Permission denied
Error: /usr/bin/crun pause b61e5703bd1b6d0021dfc8d7b0b21cf2843721a4081bbdd7027c7c511e63a9b4 failed: exit status 1
Describe the results you expected:
No failure (like docker)
Additional information you deem important (e.g. issue happens only
occasionally):
Output of podman version:
$ podman version
Version:            1.8.0
RemoteAPI Version:  1
Go Version:         go1.13.6
OS/Arch:            linux/amd64
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/issues/5135?email_source=notifications&email_token=AB3AOCF3EVHVANLA5J6RCFTRCBD57A5CNFSM4KSDO7TKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IMCY7AA,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB3AOCH6EPJEHWBRFJNGZPDRCBD57ANCNFSM4KSDO7TA
.

$ cat ~/.config/containers/libpod.conf
volume_path = "/home/marco/.local/share/containers/storage/volumes"
image_default_transport = "docker://"
runtime = "/usr/bin/crun"
runtime_path = ["/usr/bin/runc", "/usr/sbin/runc", "/usr/local/bin/runc", "/usr/local/sbin/runc", "/sbin/runc", "/bin/runc", "/usr/lib/cri-o-runc/sbin/runc"]
conmon_path = ["/usr/libexec/podman/conmon", "/usr/libexec/crio/conmon", "/usr/local/lib/podman/conmon", "/usr/local/libexec/crio/conmon", "/usr/bin/conmon", "/usr/sbin/conmon", "/usr/lib/crio/bin/conmon"]
conmon_env_vars = ["PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"]
cgroup_manager = "cgroupfs"
static_dir = "/home/marco/.local/share/containers/storage/libpod"
tmp_dir = "/run/user/1000/libpod/tmp"
max_log_size = -1
cni_config_dir = "/etc/cni/net.d/"
cni_plugin_dir = ["/usr/libexec/cni", "/usr/lib/cni", "/usr/local/lib/cni", "/opt/cni/bin"]
infra_image = "k8s.gcr.io/pause:3.1"
infra_command = "/pause"
enable_port_reservation = true
label = true
num_locks = 0
cgroup_check = true

I did $ rm ~/.config/containers/libpod.conf and rebooted the machine. Now it is working again.


RNNLM model support lm_num_thread and lm_provider setting

rnnlm params decouple num_thread and provider with Transducer model. rnnlm model use lm_num_thread and lm_provider independent.

Thanks!


Class based insert fails with implicit pk

Reproduce steps:
from fastlite import *
db = Database(memory=True)
class Foo: name:str; desc:str
foos = db.create(Foo, pk="id")
foos.insert(Foo("hi", "there"))

Error trace is:
TypeError                                 Traceback (most recent call last)
Cell In[3], line 1
----> 1 foos.insert(Foo("hi", "there"))

envs/fasthtml/lib/python3.10/site-packages/fastlite/kw.py#line=189), in insert(self, record, pk, foreign_keys, column_order, not_null, defaults, hash_id, hash_id_columns, alter, ignore, replace, extracts, conversions, columns, strict, **kwargs)
    185 record = {**record, **kwargs}
    186 self._orig_insert(
    187     record=record, pk=pk, foreign_keys=foreign_keys, column_order=column_order, not_null=not_null,
    188     defaults=defaults, hash_id=hash_id, hash_id_columns=hash_id_columns, alter=alter, ignore=ignore,
    189     replace=replace, extracts=extracts, conversions=conversions, columns=columns, strict=strict)
--> 190 return self.get_last()

envs/fasthtml/lib/python3.10/site-packages/fastlite/kw.py#line=26), in get_last(self, as_cls)
     25 vals = [row[pk] for pk in self.pks]
     26 self.last_pk = vals[0] if len(vals)==1 else vals
---> 27 if as_cls and hasattr(self,'cls'): row = self.cls(**row)
     28 return row

TypeError: Foo.__init__() got an unexpected keyword argument 'id'

The easy solution appears to be patching the original class to take an optional int. What do you think?

Looks like the workaround is to just be explicit:
db = Database(memory=True)
class Foo: id:int; name:str; desc:str
foos = db.create(Foo, pk="id")
foos.insert(Foo(name="hi", desc="there"))

This works just fine. The only reason I didn't do this at first was because I thought I would be forced to provide the id at insert because it is a required parameter. But apparently db.create turns it into a flexiclass which has nullable fields.
Very cool, but a little confusing.

Yeah there's no "implicit pk". You gotta create it.


list of connected groups or conversations

How to get a list of groups user is connected to or the list of conversations user has.
Conn.Chats() doesn't seem to return anything useful

@Deewai
Did you found a way to do it? I have the same question.

Same question...

+1
conn.Contacts() also does not work.

@franklinsales I found a way around it.
After calling the conn.Contacts() and i think conn.Chats(), it updates the contacts lists in conn.Store.Contacts. so you can get the contacts from there after calling the function

Using the Chats func I was able to get the list of chats, but curiously it works only with iOS, with Android it returns null
	return wac.query("chat", "", "", "", "", "", 0, 0)

@sthales I use android, so i also get null but conn.Store.Contacts gets updated so i make use of that

I think @punneetmehta did a great job implementing the missing parts. Thanks!


Use setuptools instead of distutils

Partial (short term) fix for gh-52
Uses setuptools instead of distutils.

Everything here seems to be working here except Windows. One of the things that I worried about with using setuptools is that its support for mingw is supposedly not as good as numpy.distutils and mingw is used for building the Windows wheels.
The build failure on Windows is:
        gcc -mdll -O -Wall -ID:\a\python-flint\python-flint\.local\include -IC:\Users\runneradmin\AppData\Local\Temp\cibw-run-5hwr_lyj\cp39-win_amd64\build\venv\include -IC:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.9.13\tools\include -IC:\Users\runneradmin\AppData\Local\pypa\cibuildwheel\Cache\nuget-cpython\python.3.9.13\tools\Include -c src/flint/pyflint.c -o build\temp.win-amd64-cpython-39\Release\src\flint\pyflint.o
        src/flint/pyflint.c:428:41: warning: division by zero [-Wdiv-by-zero]
             enum { __pyx_check_sizeof_voidp = 1 / (int)(SIZEOF_VOID_P == sizeof(void*)) };
                                                 ^
        src/flint/pyflint.c:428:12: error: enumerator value for '__pyx_check_sizeof_voidp' is not an integer constant
             enum { __pyx_check_sizeof_voidp = 1 / (int)(SIZEOF_VOID_P == sizeof(void*)) };
                    ^~~~~~~~~~~~~~~~~~~~~~~~
        src/flint/pyflint.c: In function '__Pyx_ImportType_3_0_4':
        src/flint/pyflint.c:6670:13: warning: unknown conversion type character 'z' in format [-Wformat=]
                     "%s.%s size changed, may indicate binary incompatibility. "
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        src/flint/pyflint.c:6671:24: note: format string is defined here
                     "Expected %zd from C header, got %zd from PyObject",
                                ^
        src/flint/pyflint.c:6670:13: warning: unknown conversion type character 'z' in format [-Wformat=]
                     "%s.%s size changed, may indicate binary incompatibility. "
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        src/flint/pyflint.c:6671:47: note: format string is defined here
                     "Expected %zd from C header, got %zd from PyObject",
                                                       ^
        src/flint/pyflint.c:6670:13: warning: too many arguments for format [-Wformat-extra-args]
                     "%s.%s size changed, may indicate binary incompatibility. "
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        error: command 'C:\\mingw64\\bin\\gcc.exe' failed with exit code 1

Those exact errors are reported as a general Cython+mingw issue here:
https://github.com/cython/cython/issues/3405
The comments here indicate that mingw support in setuptools has improved: https://github.com/cython/cython/issues/4470#issuecomment-1361506709. Apparently though it is still necessary to apply a patch to CPython's header files for Python < 3.12.
We don't see this working for 3.12 working here because it fails building the 3.9 wheel before attempting the 3.12 wheel. I'm going to push a commit that only builds 3.12 wheels to see if at least that works.

I'm going to push a commit that only builds 3.12 wheels to see if at least that works.

It does work so what works is:

Building with setuptools for Linux/OSX in all Python versions
Building with setuptools and mingw on Windows for Python 3.12
Building with numpy.distutils and mingw on Windows for Python < 3.12

What does not work is:

Building with setuptools and mingw on Windows for Python < 3.12
Building with numpy.distutils on Python 3.12

To build with setuptools we would apparently need to apply this patch to CPython:
diff --git a/PC/pyconfig.h b/PC/pyconfig.h
index 1a33d4c5a1e4f..1d8408b363a66 100644
--- a/PC/pyconfig.h
+++ b/PC/pyconfig.h
@@ -209,6 +209,16 @@ typedef int pid_t;

 #endif /* _MSC_VER */

+/* ------------------------------------------------------------------------*/
+/* mingw and mingw-w64 define __MINGW32__ */
+#ifdef __MINGW32__
+
+#ifdef _WIN64
+#define MS_WIN64
+#endif
+
+#endif /* __MINGW32__*/
+
 /* ------------------------------------------------------------------------*/
 /* egcs/gnu-win32 defines __GNUC__ and _WIN32 */
 #if defined(__GNUC__) && defined(_WIN32)

I am more tempted though just to add some Python-version logic to setup.py. We have a setup that has been working for Python < 3.12 and I think I have just found a setup that works for Python 3.12 at least for development builds and for building wheels in CI.
Not having the default paths added in setup.py is a problem but at least being able to build at all on Python 3.12 is an improvement. This check passes in CI so it at least seems to pick up Flint in /usr/local on Linux:
https://github.com/flintlib/python-flint/blob/2fd4fd6d4a297eed95a3e81082a7df1de605c826/bin/pip_install_ubuntu.sh#L24-L56

So it is working for all Python versions and for Windows as well as OSX and Linux.
Note that the pip install python-flint jobs are expected to fail. They are testing building from source with pip install python-flint after building Flint 3. Until a new sdist is pushed to PyPI that will fail because the sdist currently on PyPI expects Flint 2.9 and Arb. The only reason those jobs pass on master is because they are installing the binary wheel from PyPI but I've fixed that here which then means that those CI jobs (correctly) fail.

I think this has to be merged before Cirrus CI will start generating 3.12 wheels for OSX ARM64. I think everything else is working here now so I'll merge and then see what CI does on the merge build.


packages for Ott 0.32

Related to #16.

I cancelled CI since it doesn't make a lot of sense for this PR and the CI is quite heavy.
I will merge as soon as the current main CI is through - maybe I piggy back a small fix.

I piggy backed this PR in #233.


Remove Sub-ICB Reporting Entities from SICBL list

These are newly added codes to provide more granular reporting for London:
https://digital.nhs.uk/services/organisation-data-service/sub-icb-codes-for-london
We currently display them on our SICBL page and also in the SICBL search on the Analyse page:

We want to remove/hide these somehow, and ensure they don't reappear on subsequent imports.
Slack threads:
https://bennettoxford.slack.com/archives/C051A4P27GE/p1719411639986019
https://bennettoxford.slack.com/archives/C051A4P27GE/p1719413239758479

These have now been manually deleted and the import code updated to exclude them in:

#4863


Consolidate delete params code which currently is implemented multiple times

Is your feature request related to a problem? Please describe.
The code to delete the current parameters for a logical resource is implemented multiple times, and this risks difficult to detect defects if the implementations ever get out of sync.
Describe the solution you'd like
Refactor the delete parameters block of statements so that there is a single Java DAO implementation and a corresponding pair of (new) stored procedures for Db2 and PostgreSQL. The procedures can be invoked directly from the existing procedures.
Describe alternatives you've considered
Do nothing and risk a future regression defect.
Acceptance Criteria
Unit and system tests pass.
Additional context
N/A

FYI https://github.com/IBM/FHIR/issues/2348

Duplicates #2348


🤖 Agents: Chain of Thought (CoT) agent

Introducing Agents & Tools:
Agents are semi-autonomous bots that can respond to user questions and use available to them Tools to provide informed replies. They break down problems into series of steps and define Actions (and Action Inputs) along the way that are executed and fed back to them as additional information. Once an Agent decides that it has the Final Answer it responds with it.
Tools are (typically) APIs to various 3rd party services that Agents that use to execute Actions with.
agent = Agent::ChainOfThoughtAgent.new(llm: :openai, llm_api_key: ENV["OPENAI_API_KEY"], tools: ['search', 'calculator'])
agent.run(question: "How many full soccer fields would be needed to cover the distance between NYC and DC in a straight line?", logging: true)

This is awesome stuff. Can't wait to dig in @andreibondarev!


Consider replacing FastClick

Just a suggestion, but FastClick appears to have stagnated and has several PR open to fix quite a few bugs. I had to swap it out so that I could use input of type="number" because of a bug that's been open for 6 months and had a PR fix sat waiting for nearly 3 months.
I've replaced it with tap.js and it appears to be doing the job thus far.

Hmm, interesting. Have you noticed any performance differences between the two, or any other gotchas that would be worth knowing about?
Either way we probably won't swap out a dependency until a v2 of the framework.

It's still early doors with the project, but I've not noticed any problems.
Perhaps a better compromise would be forking FastClick?


Update failed tests for CI4.3.0

Needs #595
See #596

update tests
add psalm baseline

All checks have passed. 🎉


Submitting does not refresh the page

the panel itself submits, but the page refuses to refresh and the submit button gets disabled
happens in both yandex and chrome

Should be fixed in 1.120.2018.03.


Split google/bloaty invocation into a reusable action in a new repo

We should use an existing action or build one that invokes bloaty on a set of files so we can record toolchain binary sizes.

https://github.com/thebrowsercompany/gha-google-bloaty


Recommend optimize - Optimization to have all of the recommendations come out at the same level

Please review changes that normalize the results for the recommendations.  This will allow us to have all of the results inline:
@mannyrivera2010
@skhtet
@blynch11p
@rkenyon1969
Changes were also made during testing for reducing the boost rating from 2 to 1 for rating and also improved the results returned from content filtering.
Here is the how to verify the results:
To Evaluate recommendation normalization (Based on original apps that have been used and will change if new apps are added):
Observe the raw_scores and they should all be in the same range without the other scores and not be too out of the area

make dev (Stop the backend after it starts running)
make recommend
make run_es
check recommendations returned by going to:
http://(Address of machine):8000/dist/#/home/?%2F%3F%2F%3F=
Login as bettafish user
http://(Address of machine):8001/api/storefront/

Search for “_score” and observe the Apps that are being recommended and the engine that is being used.  Should see a majority of them being “Baseline”
Stop the backend and do the following:

make recommend_es
make run_es
check recommendations returned by going to storefront again:
http://:8000/dist/#/home/?%2F%3F%2F%3F=
If asked to login again, use bettafish as the user
http://(Address of machine):8001/api/storefront/

Search for “_score” and observe the Apps that are being recommended and the engine that is being used.  Should see a mix of results from “Baseline” and “Elasticsearch Content Filtering” with some being combined results
Next go to the AppsMall Center and bookmark “AirMail 5”
Stop the backend and do the following:

make recommend_es
make run_es

check recommendations returned by going to storefront again:
http://(Address of machine):8000/dist/#/home/?%2F%3F%2F%3F=
If asked to login again, use bettafish as the user
http://(Address of machine):8001/api/storefront/
Search for “_score” and observe the Apps that are being recommended and the engine that is being used.  Should see a mix of results from “Baseline”, “Elasticsearch Content Filtering” and “Elasticsearch User Based Filtering” with some being combined results.
Next go to the AppsMall Center and bookmark “JotSpot 4”
Stop the backend and do the following:

make recommend_es
make run_es
check recommendations returned by going to storefront again:
http://(Address of machine):8000/dist/#/home/?%2F%3F%2F%3F=
If asked to login again, use bettafish as the user
http://(Address of machine):8001/api/storefront/

Search for “_score” and observe the Apps that are being recommended and the engine that is being used.  Should see a mix of results from “Baseline”, “Elasticsearch Content Filtering” and “Elasticsearch User Based Filtering” with more being combined results with more “Elasticsearch Content” and “Elasticsearch User Based” results.

Followed steps above.  Results all seem to line up with the instructions above.  :+1:

:+1:


Fix placement of navbar

Added padding to move navbar to a more suited location

If you can, try and use display flex with align-self:center to vertically center the item inside the container (navbar) depending on the container height.

I can't get allign-self to work. I tried align:"center" with no sucess. Regardless I thought the navbar was a set size. Meaning if it don't scale I could just hardcode a padding.

I can't get allign-self to work. I tried align:"center" with no sucess. Regardless I thought the navbar was a set size. Meaning if it don't scale I could just hardcode a padding.

Inline styling in JSX is a bit different then regular and uses camel case so it would be alignSelf: "center" instead.
The wrapper also need to be of: display: "flex" to use "align self". If this messes up the styling you can merge in with padding👍

With using display: "flex" gives me the opposite, I'll merge this with the hard set padding. If it yield problems in the future with this hard set padding, then I will look into another way to do it.


Use QIcon.fromTheme() for icons

like discussed in #950, #2210 advances the icons.
so let’s do it right and use QIcon.fromTheme. we’ll have to simply

put the icons into a freedesktop icon theme spec compatible directory (e.g. like here), and bundle this directory as QResources in ':/icons'.

anywhere we want to use an icon, we just need to do
QIcon.fromTheme('document-new')

if we carefully choose the icon names to be compatible with linux standard names (e.g. aforementioned document-new), it’ll automatically use system icons on linux

this is the best of all worlds:

simple to implement
cross platform
native appearance
allows us to let users choose their own icon themes on all platforms (see comment below)!

But this would be useful only for Linux, right?

But this would be useful only for Linux, right?

it would be most useful for linux at first yes.
but we can also allow the user to specify a theme name, and append more theme directories to the theme search path.
note that i was wrong: the last item in themeSearchPaths already is ':/icons', so if we bundle our icons as qresources in this resource folder, we don’t have to do anything, just call QIcon.fromTheme('iconname'). awesome! we just have to do that, ive the icons cool names (e.g. let’s use breeze’s names if applicable) and it will just work!
furthermore, we could easily allow that the user unzips this into %appdata%\Spyder\icon-themes and selects “Faenza” in spyder, even in e.g. windows (similarly in OSX):
if platform = 'win':
    local_icon_dir = os.getenv('APPDATA')+ '/Spyder/icons'
    QIcon.setThemeSearchPaths(QIcon.themeSearchPaths() + [local_icon_dir])
#now add combobox with available themes to select!

but anyway, not doing this or similar makes Spyder simply butt-ugly in the eyes of any linux user.
using the system icon theme is something we expect, not some fancy gimmick.
if you don’t use my approach, then don’t, but if you still want to support native themes on linux, it’s going to be a pain not to use this simple solution.

My thoughts:

It's cool that Spyder could blend with the default appearance in KDE or Gnome. The problem with this is that we would (probably) need to provide native versions for icons not present in breeze or faenza but needed in Spyder. This seems like too much work.

I'll leave it to @SylvainCorlay to decide if we want to support this. I've to say that I'm -1 on this. I think it's better to make Spyder to look the same on all platforms, design just a couple of icons if needed and don't worry about this anymore.

 It's not possible for our set of icons to go well with all other sets out there. That would make Spyder look even uglier, in my opinion.

Please tone down your comments. So far nobody has asked that Spyder should use the same icons as those used by the operating system, so I don't regard this as a so touchy issue.

We'll see, that's to be decided among the core devs.

I just wanted to stress that this is important.
a cross platform application should behave well on all platforms.
and on Linux this means:

don't use your own notifications, use the Staten service
use the XDG spec for your config and cache files.
use the system widget set and colors
use the system icon theme

I agree with @ccordoba12,

Having some icons use the native theme, but the other icons (on fallback) using the spyder "native" theme would make the GUI look really unprofessional and ugly.

Even if having a single icon set in a cross platform application will inevitably result in mixing of the overall look of a GUI (native widgets) plus non native icons (spyder icons), it would still look better than a mix of icons of different (way different themes!) as mentioned in 1.

With so many themes available for Linux, having to construct and icon set that works for ALL of the themes, is non practical and not worth it for the time being and the man power at our disposal.

@flying-sheep I would not rule out this approach in the future, but right now is definitely not a priority. I think we would prefer to have an uniform and clean Spyder icon set based on fonts (take a look at this that looks great on all screen resolutions (retina etc...) even if not matching the OS.

For users sticking to a single OS, this might seems like something very important, but for cross platform users (like myself and @ccordoba12 and many others out there) we would rather have an uniform experience, and a Spyder Icon Set provides that.

In general I would say, as you also point out, "a cross platform application should behave well on all platforms" that meaning: Cross Platform experience is on top of specific OS experience, which means having a compromise to make the project sustainable as well. Qt lowers the burden of development incredibly but there are so many things beyond the GUI (and even within it), so it does not mean that it has to look "perfect" in every single OS, but work.

which means having a compromise to make the project sustainable as well. Qt lowers the burden of development incredibly but there are so many things beyond the GUI (and even within it), so it does not mean that it has to look "perfect" in every single OS, but work.

my point is that with my approach, we leverage a built-in mechanism that can do everything you two want:

support high-DPI images
allow clean code without direct references to resource names

and on top of that also allows using the native icon theme without extra effort (what every linux user wants)
PS: did you have a look at breeze?
the action icons (i.e. what is used in a application toolbar/menubar/buttons) are on the bottom and have exactly the clean look you strive for. they also (other than font awesome AFAIK) have guidelines allowing to extend them with own icons matching the look.
i’d say that’s even better for your purposes, and allows you to achieve your goal very simply:

identify breeze icons you want
remove all others
add missing ones
bundle remaining directory with spyder
use QIcon.fromTheme

As I said earlier, there is no problem with using Theme approach (the dev team is aware of this), still it would result in mixing icons from whatever theme is on the OS and breeze icons + customs icons (in case the OS theme does not have the icon).
How would this look good in all the different theme options available in Mac, Windows, and Linux?

github isn’t the big part of its story.
the icons are now a part of KDE, where they’ll be used to provide icons for many of those applications.
look e.g. into this directory. here’s the list of icons that start with “document”, “edit”, “debug”, “code”, “go”, “help”, and “run”, and are therefore useful for an IDE:
 document-close.svg
document-decrypt.svg
document-edit-decrypt-verify.svg
document-edit-decrypt.svg
document-edit-encrypt.svg
document-edit-sign-encrypt.svg
document-edit-sign.svg
document-edit-verify.svg
document-edit.svg
document-encrypt.svg
document-encrypted.svg
document-export-table.svg
document-export.svg
document-import.svg
document-new.svg
document-open-folder.svg
document-open-recent.svg
document-open-remote.svg
document-open.svg
document-preview-archive.svg
document-preview.svg
document-print-direct.svg
document-print-frame.svg
document-print-preview.svg
document-print.svg
document-properties.svg
document-revert.svg
document-save-all.svg
document-save-as.svg
document-save.svg
document-share.svg
document-sign.svg
 debug-execute-from-cursor.svg
debug-execute-to-cursor.svg
debug-run-cursor.svg
debug-run.svg
debug-step-instruction.svg
debug-step-into-instruction.svg
debug-step-into.svg
debug-step-out.svg
debug-step-over.svg
 code-block.svg
code-class.svg
code-context.svg
code-function.svg
code-typedef.svg
code-variable.svg
 edit-bomb.svg
edit-clear-history.svg
edit-clear-list.svg
edit-clear-locationbar-ltr.svg
edit-clear-locationbar-rtl.svg
edit-clear.svg
edit-copy.svg
edit-cut.svg
edit-delete-shred.svg
edit-delete.svg
edit-find-mail.svg
edit-find-project.svg
edit-find-replace.svg
edit-find-user.svg
edit-find.svg
edit-guides.svg
edit-image-face-add.svg
edit-image-face-detect.svg
edit-image-face-recognize.svg
edit-image-face-show.svg
edit-link.svg
edit-node.svg
edit-paste.svg
edit-redo.svg
edit-rename.svg
edit-select-all.svg
edit-select.svg
edit-table-cell-merge.svg
edit-table-cell-split.svg
edit-table-delete-column.svg
edit-table-delete-row.svg
edit-table-insert-column-left.svg
edit-table-insert-column-right.svg
edit-table-insert-row-above.svg
edit-table-insert-row-below.svg
edit-text-frame-update.svg
edit-undo.svg
 go-bottom.svg
go-down-search.svg
go-down.svg
go-first-view-page.svg
go-first-view.svg
go-first.svg
go-home.svg
go-jump-declaration.svg
go-jump-definition.svg
go-jump-locationbar.svg
go-jump-today.svg
go-jump.svg
go-last-view-page.svg
go-last-view.svg
go-last.svg
go-next-context.svg
go-next-use.svg
go-next-view-page.svg
go-next-view.svg
go-next.svg
go-previous-context.svg
go-previous-use.svg
go-previous-view-page.svg
go-previous-view.svg
go-previous.svg
go-top.svg
go-up-search.svg
go-up.svg
help-about.svg
help-contents.svg
help-contextual.svg
help-donate.svg
help-feedback.svg
help-hint.svg
 run-build-clean.svg
run-build-configure.svg
run-build-file.svg
run-build-install-root.svg
run-build-install.svg
run-build-prune.svg
run-build.svg

Ok, we are not going to maintain this discussion forever. This is my final take on this:

If @SylvainCorlay and @goanpeca want to support native themes, then we'll have it. If not, too bad.

Native themes (if supported) are not going to be the default. If people wants them, then they'll have to:
a.

XDG is not going to happen. IPython guys decided to revert to ~/.ipython and they are a much bigger project than us, so we have to learn from their path.

@flying-sheep, I know you mean well, but please don't derail us more into this discussion.

One final thing: if someone else (besides @SylvainCorlay and @goanpeca) wants to implement native themes, she is welcome to make a pull request to make it happen, as long as she abides the conditions mentioned above.

XDG is not going to happen. IPython guys decided to revert to ~/.ipython and they are a much bigger project than us, so we have to learn from their path.

please don’t take this as personal attack, but i really don’t understand your decision making.
if you follow some other person’s/project’s lead then you need to make sure the situations and problems are comparable.
they did it because they are dependent on users manually finding and editing the files. ipython consists of multiple parts that all draw from the same configuration. some are TUI, some GUI. some settings can’t easily be set from a GUI or make no sense in the GUI parts. a unified config editor would make no sense.
this project on the other hand is one application with a central configuration dialog.
whoever wants to ind the config files does so because he/she needs something very specific not available in the GUI. that’s a special case, not (like in ipython) the best way to access them.

Don't worry, I know you're not attacking us :-)
Another reason for IPython to finally not go with XDG (and the most important one for me) is that is harder to point people to where configuration files reside, in a simple and multi-platform way.
I think that's a valid reason, and why I decided to not follow XDG.

yes, i know! my point is that it’s a valid point for them, as they actually do have to point people to the config file on a regular basis, unlike us who point people to the settings dialog instead.

Ok, here are the different reasons for our choices so far:

I think that everyone agrees that vector icons are the way to go,especially since people were complaining that png icons were ugly on retina display.
SVG is not well supported in PySide and PyQt4, which we still support
Even on platforms where SVGs are supported, and even when SVGs will be supported everywhere, they are much more general than the type of vector graphics allowed with fonts. Fonts are more restrictive (only one color, no gradient etc) but front-end frameworks are very good at rendering text and font faces. Performance-wise it is much better to render hundreds of characters with fonts than 20 complex SVG images.
My bike-shading argument. I find the minimalist look of font icons great. I think that thinking of it as font faces forces one to make the design as simple as possible.
Eventually Spyder will integrate the notebook application, which uses bootstrap and font-awesome. To have a uniform design with those, it is more natural to use font-awesome ourselves.
Native icon themes usually don't have icons for IDE - specific actions (step forward, debug). We would have to devise icons consistent with those themes.

Keeping this one open for now since there has been a lot of discussions here. Will probably close when some new icon set lands into Spyder.

good points, but i disagree about performance:
Qt renders the SVG icons once for every used size, and caches them. that hardly makes any impact.
also the restrictiveness with one color isn’t a good thing. when you look at the (sparingly used) color in the breeze icon set, you’ll see that it draws attention to the right things and is an improvement in terms of usability (especially for user over the age of 25) and distinction.
i’d rather have all people use it efficiently after 25ms more loading time than older users having to frustratingly search icons all the time.

could you please point me to the bug report about Qt4 having problems with SVG? and how that relates to different platforms?

I arrive a bit late in the discussion, sorry. I won't go against current conclusions, but I think it would be a good idea to at least follow the standard name for icons that exists, and find non-clashing names for the others, so that it's easier to go either way if we want to change our minds later. I don't know if it is (or can be made) compatible with Font Awesome, however.
@flying-sheep since you seem to know the themes well, you could make a list of equivalences (or a PR applying the transformation). Helping is always more efficient than reporting (even if it is of course useful in its own right).
Another question is, what are other editors and IDE doing with their icons in Linux ? I suppose that Eclipse and Matlab use their own set of icons, but what is using kdevelop for its debug icons, for example ?
Finally, I head that svg in small sizes look bad because the details are blurred together instead of simplified. Could it be an additional problem ?

@flying-sheep since you seem to know the themes well, you could make a list of equivalences (or a PR applying the transformation). Helping is always more efficient than reporting (even if it is of course useful in its own right).

i like helping, but only if there’s a future to the work. as it looks now i’d like to have confirmation that using native icon themes will be an option before i do something pointless.

but what is using kdevelop for its debug icons, for example ?

KDevelop uses native icons only.

I head that svg in small sizes look bad because the details are blurred together instead of simplified.

that’s only if you use SVGs created for big resolutions. breeze aligns their icons according to a pixel grid of a certain size, e.g. the normal toolbar size 22×22 for actions (e.g. new file, copy, debug, run, draw rectangle) and additional sizes for other things like mime types (aka file icons)
when compare this with the font awesome examples, breeze certainly looks sharper.

I am looking into the standard naming conventions from freedesktop, and I think that it is reasonable to use those names in our icon map.

:+1:

@SylvainCorlay, great! In case you didn't follow the discussion above: I'd like this to be opt-in, i.e. users should select an option to use the KDE/Gnome icons.
I find the KDE icons for IDEs not so beautiful, so if people want to use them it has to be by their choice, not ours.

Agreed.
Whether we use QIcon.fromTheme or not we will need a mapping from icon names and using standard ones will make any further change easier.

great!

hi, i did a PR for another PyQt project where I implemented a qrc-based fallback/default theme that can be used via QIcon.fromTheme: takluyver/nbmanager#10
it’s not hard, only the index.theme files are a bit annoying.

  About half of the icons don't show up visible at all since they're the same color as the toolbar background, and changing the system icon theme does NOTHING since you're dead set on forcing YOUR choice of icons upon my desktop, unlike the other apps I use.  I really LOVE Spyder IDE, but I'm going to have to switch back to using plain old Kate for Python development, since I'm not going to switch my entire desktop theme for one single app.

@bavarin-fleetfoot we are working on a unified theme, the work is a couple of months away

That's great news, because reading the thread for the bugreport made it sound like there was strong pushback against the idea of supporting system/Qt standard icons because it would make things "ugly", which it already IS on any system that uses their desktop's built in theme options to change to a darker theme.  This one factor of utterly unusable toolbars kills the usefulness of an otherwise fantastic app for me.  If I have to guess what button I'm about to press, then there's no point in having a bunch of nice features, any of which might randomly cost me hours of work because I clicked the wrong invisible icon by mistake.

@bavarin-fleetfoot we have reviewed the suggestions and we are working on using from theme and the breeze icon theme by default. We will provide OS based look and unified look

For OS based we will use on all OS the breeze theme for light and dark (most likely)
For Unified based theme we will used the same themes but colors of the icons will updated based on the syntax highlighter

It is a big refactor and that is why we have taken some time to do it

Right on.  I'll leave it installed for easy updates until I can see the icons on the toolbar.  Greatly looking forward to using Spyder again.  Other than this one appearance issue (which honestly made no sense to me that it was even a problem), it's by far one of the better Python IDEs in existence.

@bavarin-fleetfoot The issue with qtawesome is the look on dark backgrounds?

No Sylvain, the main problem is Windows 10 forbids to load fonts not installed in the system, so we have to resort back to the Spyder 2 icon theme there.
So for Spyder 4 our plan is to use SVG icons instead from the KDE theme called Breeze.

Does this work on Mac?

It's not possible for us to implement this feature at this point because we have several custom-made icons and we plan to add more in the future.


Adding an image is confusing that you need to clear the placeholder

Describe the bug
I thought the image schema was broken because I didn't realise you have to clear the existing placeholder before you can actually add an image.
To Reproduce

Add schema
Select type = Image
You will see the following and it's not obvious what to do:

Expected behavior

When you add or change a schema type to image it should assume it's empty and offer the upload facility.

Your Environment
- pdfme package: @pdfme/ui
- pdfme version: latest

Your Error Log
-

Additional context
No response

Good point...
Already, I had forgotten the feeling of freshness and did not realize it.


Avoid AxiosError when requesting bad image links

Description

There is a recurrent error of Axios trying to request an image with a wrong uuid. It has 112 occurrences since first seen on Nov 20, 2023.
GET /image/f51977d1-081a-4e9f-afe1-

It raises an error with the message: Request failed with status code 404 .
It is unknown to me what or who stumbles upon this URL, but it consumes part of our Sentry quota, so it should be prevented somehow from triggering a notification.
Reproduction

Reproduction steps are unknown.
Sentry details
https://openverse.sentry.io/share/issue/20761d85362b468190131dcda0463e9f/

Adding some thoughts about how I am approaching implementation. I think it's a clear win to ignore 404s and not send them to Sentry any more. That's easy to do, we just wrap the call to sentry with if (errorData.statusCode !== 404). However, if 404 is also returned for malformed requests, which is what we are dealing with in the request, then I think we actually need an additional change in the API to return 400 in those cases. We really should not be getting a malformed request sent to the API from the frontend under normal operation, so it is good to know when that happens.
@krysal what do you think? I've got the implementation to filter 404s, that was easy enough. What do you think about making the API return 400 for malformed identifiers? That seems like a clear-cut issue to me.

Actually, I'm looking at another AxiosError in Sentry (private maintainer access required) and these are all "NETWORK_ERR" reason codes. That also seems like something we can pretty safely ignore, but it is different than the one linked in the issue description.
Regarding making malformed identifiers 400 instead of 404, it isn't easily possible. We use the lookup value regex to determine when retrieve is called in the router, so when a malformed identifier is passed, the DRF router actually doesn't even see the request match a route, rather than it having an incorrect UUID. Hence the 404 rather than 400.
We really just need to treat all 404s coming from the API for single result requests as bad requests, then, without changes to the API, unless we want to really hack on Django's routing and making things more complex.

@sarayourfriend Yeah, I'm not sure if it's worth making the distinction between the 404 and 400 requests in this case. Under the hood I assume the request to the API is still of the form v1/images/<id> so one can also say it's technically valid but there is no image with that incomplete uuid, so it's a 404 Not Found.

This issue is still occurring: https://openverse.sentry.io/share/issue/20761d85362b468190131dcda0463e9f/
@obulat Do you think it would be best to wait until we migrate to Nuxt 3 to try and handle this?

Along with #4538 Axios would go away altogether. I don't know if Axios is the specific problem here though, there might be a general issue we need to contend with.
The issue title is a bit misleading in that regard :thinking: Although, I suppose #3850 should be catching these anyway?


optimize docker build

This change makes docker build cache the installed packages as long as package.json or yarn.lock don't change. This improves docker build performance drastically when only code changes are made.

Nice and simple @patagonaa ⭐ Thanks!


Debug Table 1 CrdDrop, Residual, MatTransMul. SDDMM

Show with empty reductions getting filtered out. SDDMM show non-optimized one

Residual and Mattransmul fixed in compiler_fix
SDDMM should be changed to 2 in Table 1 (for unoptimized)
Still need to confirm all CrdDrops are correct for "filtered" empty reductions analytically

Should be fixed once https://github.com/weiya711/sam/pull/75 is approved

All CrdDrops have beenconfirmed analytically and the paper manuscript has been updated with final values

Closed as per https://github.com/weiya711/sam/pull/75


Library not working with ng build --prod

Hi,
First of all, you library is very helpful for starting to build libraries. I tried to implement a library using your starter pack. It works for almost everything, but not when building it for prod. I was wondering if you could give me a few tips where I am doing wrong. The library is a super simple one so don't know why it wouldn't work. The repo is here. Thanks for you help.

Hi @JulCesWhat,
ok I'll give it a look and let you know.

@JulCesWhat,
what's the name of your library? monaco-editor-loader or angular5-monaco-editor-loader? Because you have two different name inside the library, and it should be only one.
Then you have a scoped package: @julceswhat/angular5-monaco-editor-loader. So you must change also in tsconfig-build.json file:
    "angularCompilerOptions": {
        ...
        "flatModuleOutFile": "monaco-editor-loader.js",
        "flatModuleId": "@julceswhat/angular5-monaco-editor-loader" // complete name of the package
    }

and it will work.
Greetings

@robisim74  ...Wow it work! You are really good. Thanks for answering fast. I need to work more with JS tsconfig-build.json files. The name is angular5-monaco-editor-loader. Should I replace every monaco-editor-loader with angular5-monaco-editor-loader? I will also update the library with your new starter code.

In my opinion you should use only one name (the name used in npm package, so in your case angular5-monaco-editor-loader): it's easier to maintain and you avoid unexpected errors.

Will do. Thank you for your time and help.


SPFX webpart loading the previous (older) version, instead of latest deployed version

Target SharePoint environment
SharePoint Online
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Developer environment
macOS
What browser(s) / client(s) have you tested

[ ] 💥 Internet Explorer
[ ] 💥 Microsoft Edge
[X] 💥 Google Chrome
[X] 💥 FireFox
[ ] 💥 Safari
[ ] mobile (iOS/iPadOS)
[ ] mobile (Android)
[ ] not applicable
[ ] other (enter in the "Additional environment details" area below)

Additional environment details

Browser versions

Chrome: 116.0.5845.179 (Official Build) (arm64)
Firefox: 117.0

SPFx version: 1.16.0
Node.js version: 16.13.2

Describe the bug / error
Context:

I am running a React app as a webpart
I am packaging a build using gulp, and deploying it in SharePoint under Apps for SharePoint
I log the version of the app in the console

The problem
Twice now I've faced a strange issue when deploying a new build: when refreshing the app, I sometimes get the latest deployed version, other times I get the previously-deployed version. After a while (several days?) the problem seems to go away (or, at least no users have complained of seeing older versions).
If I get the older version and I try a hard refresh, the web part doesn't load my React app, instead I see the following error message directly in SharePoint:

What I've tried

What seemed to work last week, but did not work this week: Unregister Service Workers associated with the application, as well as clearing all site data
Hard refreshes, emptying cache
I tried redeploying, but that did not fix the issue either

Steps to reproduce

Create a web part that points to a SPFX solution.
Create a new SPFX solution and publish it.
Browse to the app and check the version.
Refresh and check the version again.
May need to refresh multiple times.
After some refreshes I see the latest version (correct), other times I see an older version (incorrect).

Expected behavior
I expect to always see the latest deployed SPFX solution.

This seems to be related to #9226 , or maybe the same issue?

Any update? happening to me as well and doing everything you listed

This feels like a similar issue to one we experienced last year #7664. Today, we noticed an issue where library components being loaded up using SPComponentLoader are loading up cached versions from other site collections, even if it's not installed on the site collection currently being browsed. Figuring it might be related to this issue..
e.g.

Code running in an extension loads up a library component (installed in a site collection app catalog) using SPComponentLoader.
Navigate to a site collection where that library component is not even deployed.
Extension (which is installed in tenant app catalog) attempts to load it via SPComponentLoader and does NOT load the library component on a hard reload (not cached). This is expected.
Reload the page (cached) and the extension finds the library component from the previous site collection where it was installed and it loads up.

Feels like something in the cache allows the library component to be discovered on site collections where it's not even deployed/installed.

I submitted a ticket about this recently which has a lot of comments. I've dealt with it for 2+ years and pretty much given up and accepted that any time we publish to the tenant app catalog people won't start seeing the new version until the next day. I'm my tests, my SharePoint site was even loading apps that were 4 versions old.
https://github.com/SharePoint/sp-dev-docs/issues/8915

Thanks @nbgyxi - the last time I saw the issue was the day I opened this ticket. That's not to say it's fixed, I just haven't deployed in the meantime.

just deploy something today and the issue come again, sw=bypass cant fix this

We just uploaded a new version to our tenant and it's been 45 minutes and I still can't see the new version on any sites. Clearing cache, hard refresh, sw=bypass, trying a different computer, nothing helps... I don't understand why this isn't a big priority. We have 400 sites that are basically useless until the new version loads. Our clients are not happy.

@kbeeveer46  - i am not planning a deploy this week, but i will also reply to @AJIXuMuK with the requested info when i can. if you have that info available to share, that would be appreciated!

Update: we have found the reason for the behavior.
There were some additional fixes needed that are still rolling out.
The issue should be fixed by end of the next week.

Thank you. I'll keep an eye on in for our next release in 3 weeks. I didn't see your message in time to help with your last comment. All our sites are working fine now since enough time has passed. Sorry for being so frustrated. Sometimes we can't release in the middle of the night and the caching issues cause chaos when we have to release in the middle of the day.
Our application is fairly new so we make API changes almost every sprint to support new features. Any caching issues on the front end basically stop all sites from working if they all rely on an API that was changed.

@AJIXuMuK we are seeing an odd cache-based issue with SPComponentLoader and library components and I'm wondering if it could be related to this bug (and hopefully addressed by fixes rolling out).
We have an extension that runs globally on a tenant and it is configured to load library components only if they are deployed into the current site collection app catalog. When a page is cold-loaded (no cache) on a site collection where the library components are not deployed, SPComponentLoader correctly doesn't find them and they do not initialize. If we reload the page so it's a cached load, it will find the previously loaded instances of those library components from whichever site collection was last visited (where the lib components were actually deployed). It's as-if they are being put into cache and then loaded up anywhere else, even if they are not deployed there.
Thoughts?

@mbice - it sounds unrelated. It sounds more like a client-side cache than manifests cache.

@AJIXuMuK I will do some more digging, but it looks like it's related to manifest retrieval (feels similar to this bug a while back https://github.com/SharePoint/sp-dev-docs/issues/7664). A quick trace of the code and what I'm seeing is that in the fetchManifests() function on fresh page load (no cache) it can't find any matching manifest for the library component (as expected because it's not in that site's app catalog).

Upon page reload the call to /_api/web/GetClientSideComponents has a different result payload and it includes a TON of additional manifests, including one for the library component that is from another site collection.
So for some reason the call to /GetClientSideComponents changes on cache vs no-cache load.
If you still believe it's not related to this particular manifest caching issue then perhaps I should open a new issue?
Thanks!

We just did another prod/tenant app catalog release and did not experience any caching issues this time. Every site we tested after release showed the new version immediately.

We've done a couple of deployments the last week and we didn't see any problems either – it's looking like the issue is fixed! Thank you!


AWS

How would one run the bot on AWS? I've tried and failed.

anyone?

Tried and failed. Errors?

^^ What precise problems have you had? I've run it on Digital Ocean with great success.

Feel free to re-open this issue if you have more information about what you've tried and has failed.


update tink hardware state

Description

This is needed so that an already provisioned machine that might be netbooting, due to a reboot for example, will not be given any netboot options by Boots.
Why is this needed

Fixes: #
How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

Hey @pokearu, made a bunch of updates. mind re-reviewing?


/admin not loading settings

I had the gatsby netlify starter deployed and was able to make changes using netlify cms via the /admin endpoint both on the deployed site and locally.
Today when I tried to log into /admin again locally and without any changes on my end, I was shown the "Unable to access identity settings. When using git-gateway backend make sure to enable Identity service and Git Gateway." error message. Looking at Dev Tools the request to https://beht.netlify.com/.netlify/identity/settings fails straight away without a response.
When trying to access the admin page on my deployed version I get a similar issue of the request to "https://beht.netlify.app/.netlify/git/settings" timing out and I am stuck on the Login with Netlify Identity page.
Can't figure out what has gone on, as it was working the previous day.
Any Ideas?

Hey, I'm experiencing almost the same situation. I have a site based off the starter that I've been working on for a month or so. As of today, when I begin developing locally with gatsby I am shown the "Unable to access identity settings" screen when going to my admin panel.
The console also shows an error request to https://mysite.netlify.com/.netlify/identity/settings, but mine is a Cross Origin Request Block error. Haven't had any issues like this thus far.
The deployed version of my site, however is functioning normally as of now. I've successfully pushed updates from netlify cms to my github.

Thanks for reporting this @jgudka, looks like both https://beht.netlify.com/.netlify/identity/settings and https://beht.netlify.app/.netlify/git/settings return a valid response now.
@seanpatterson97 https://twitter.com/NetlifySupport/status/1250476140822593536 might be relevant.

Yes thanks for your help! The deployed site now seems to work, perhaps was temporarily down?
And as for the local version, I needed to change the url to .app from .com as the twitter thread suggests. I know I got an email about this change of url of the deployed app, but maybe this change required for local dev should be highlighted too as others may have a similar issue.

@erezrokah I'm running into the same issue, but I'm using the .app url. Here's my API config:
  const auth = new GoTrue({
    APIUrl: 'http://trianglecomments.netlify.app/.netlify/identity',
    audience: '',
    setCookie: true
  });
```.

You can go to https://trianglecomments.netlify.app/signup and test it yourself. You should see some error messages inside the console on submit.

Hi @jarodpeachey, how are you using the CMS? Regardless I would use the https://trianglecomments.netlify.app/.netlify/identity (notice https instead of http).

I've the same issue right now :

Easy step to reproduce :

install a hugo (with academic) website with netlify in one click : https://app.netlify.com/start/deploy?repository=https://github.com/sourcethemes/academic-kickstart
activate Identity and Git Gateway in Netlify
go to GENERATED_NETLIFY_URL.netlify.app/admin/
Create an account (fake/alias is ok but still need to access to your email, you can use<EMAIL_ADDRESS>Activate your account (email received)
go to GENERATED_NETLIFY_URL.netlify.app/admin/
Get error to fetch settings (error are received few minutes later)

Hi @FloLaco, can you try to access that URL directly and not via the CMS? Does that work?

@erezrokah Now it's working ... But when i post my comment, no, i wasn't able to get access to that URL (timeout)


Add myself to authorized BigPanda developers

Description
I (@WaffleStudios) performed development on the BigPanda Jenkins plugin and now need to be authorized to publish the update.
Approved by @julioguereca
Submitter checklist for adding or changing permissions

Always

[X] Add link to plugin/component Git repository in description above

When adding new uploaders (this includes newly created permissions files)

[X] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[X] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[X] Make sure to @mention the users being added so their GitHub account names are known if they require GitHub merge access (see below).
[X] All newly added users have logged in to Artifactory at least once

Reviewer checklist (not for requesters!)

[ ] Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
[ ] Check that the $pluginId Developers team has Admin permissions while granting the access.
[ ] In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
[ ] If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

🤞 the existing maintainers are github users too
@erikzaadi
@jguereca

@julioguereca

Hi! Yes, I am confirming we want to add @WaffleStudios as a maintainer as well

I've logged into Jira for the first time 👍  @halkeye

It takes up to an hour for the data to propefate so I'll re run it in a bit

Make sure you accept the invite from https://github.com/jenkinsci


Fix problems with non-interactable tabs on Android

This should fix #84 and #120 AFAICS. Testing and feedback welcome.
@roubachof What was the original reason for using TapGestureRecognizer only on WinUI, but not on other platforms? On Android it actually seems to work well (and better than the tap command effects). Any reason why we couldn't use it on iOS as well? That would make the implementation more generic and require less platform-specific code ...

no, I use a native ripple effect on android and a color effect on ios.

Alright, I see.

It has to do with the effect being unregistered or the android implementation being deffective. Need to check platform code.

Could you maybe have a quick look into this? You know this code way better than I do ...

no, I use a native ripple effect on android and a color effect on ios.

Some more comments on this:

IMHO a simple but working implementation would be preferable to a fancy but broken one ;)
according to this, handlers should be preferred over effects in MAUI
maybe the TouchBehavior from MAUI CommunityToolkit could be used to replace the touch effects?

* maybe the TouchBehavior from MAUI CommunityToolkit could be used to replace the touch effects?

or alternatively, the ripple effect could be implemented via a handler, as shown here:
https://stackoverflow.com/questions/77456691/how-can-i-get-the-tap-gesture-animation-in-a-maui-control


Pass string instead of path

https://www.reddit.com/r/NixOS/comments/l05up9/how_can_i_get_around_restricted_mode_using_nix/

Accidentally PR'd the main repo, my bad. Still need to test this first


Add dumper noCompatMode option which bypass DEPRECATED_BOOLEANS_SYNTA…

…X handling
fixes issue #266
The linter made me shift all options with 1 space hence.

@puzrin ok I will fix both your remarks & squash the PR

LGTM.
@dervus ?

Looks good.


Conflict: can't use getUpdates method while webhook is active

prometheus_bot Version: Latest commit 3767980  on Jul 26
2018/10/05 16:48:41 getUpdates resp: {"ok":false,"error_code":409,"description":"Conflict: can't use getUpdates method while webhook is active"}
2018/10/05 16:48:41 Conflict: can't use getUpdates method while webhook is active
2018/10/05 16:48:41 Failed to get updates, retrying in 3 seconds...

https://core.telegram.org/bots/api#getting-updates


Remove nil gas price check from EstimateFee

We had this if statement because we did not want to write a migration and it was done for testing purposes.
We have a warning in the v0.4.0 release that users need to re-sync we can remove this if statement. So now we can remove it.


how to combine instant ngp and  mobile nerf ?

Dear author,
instant ngp has the advantage that it is very fast to train,  is it possbile to convert the trained weight of instant ngp to mobile nerf ?
Thanks so much !

No. You need to train mobilenerf from scratch because the mesh vertices are optimized throughout the training.

See https://github.com/kim-jinuk/hash_mobilenerf.git


open in year-mode

It would be great to can select in wich mode the date picker will open.
To select a birth date, for instance; I find more convenient to show the year selection the first.

I want the same , Is it possible to do ??

Yes, it is possible.
Just use the option viewMode with 'Years' or 'Months'


Can not access grafana after upgrading from 0.18.1 to 0.25.0

What did you do?
I was using kube-prometheus 0.18.1 and everything works well.
While recently I upgrade it to 0.25.0 following the Quickstart, I found that I can access grafana via <master_ip>:30902.
Checking the manifest I find grafana-service.yaml (as well as kube-operator-service)  has been changes from 0.18.1, and now it only exposes 3000 port internally.
So I write a grafana service based on NodePort by myself, like below:

apiVersion: v1
kind: Service
metadata:
name: grafana-svc
namespace: monitoring
labels:
app: grafana-svc
spec:
type: NodePort
ports:

port: 3000
protocol: TCP
nodePort: 30902
targetPort: web
selector:
app: grafana

but still can not access to curl or visit granafa via 30902
port-forward does not work for my scenarios since it is not full-support on k8s 1.9.5
What did you expect to see?
Enable to access grafana from 30902 or anyway externally.
What did you see instead? Under which circumstances?
Environment

Prometheus Operator version:
release 0.25.0 / 2018-10-24

Kubernetes version information:
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.5", GitCommit:"f01a2bf98249a4db383560443a59bed0c13575df", GitTreeState:"clean", BuildDate:"2018-03-19T15:59:24Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

What happens if you do a describe on the Service? Does the Service have any Endpoints?
kubectl describe -n monitoring svc grafana-svc

You are right @metalmatze . I describe and compare grafana-svc(create via my yaml) against grafana(create via default manifest) as below:

kubectl describe -n monitoring svc grafana-svc
Name:                     grafana-svc
Namespace:                monitoring
Labels:                   app=grafana-svc
Annotations:
Selector:                 app=grafana
Type:                     NodePort
IP:                       <IP_ADDRESS>
Port:                       3000/TCP
TargetPort:               web/TCP
NodePort:                   30902/TCP
Endpoints:
Session Affinity:         None
External Traffic Policy:  Cluster
Events:
kubectl describe -n monitoring svc grafana
Name:              grafana
Namespace:         monitoring
Labels:
Annotations:
Selector:          app=grafana
Type:              ClusterIP
IP:                <IP_ADDRESS>
Port:              http  3000/TCP
TargetPort:        http/TCP
Endpoints:         <IP_ADDRESS>:3000
Session Affinity:  None
Events:

how could I update it ? Thanks a lot!

Meanwhile, I found the deployment guide kube-prometheus-on-kubeadm.md is mismatched with 0.25.0, seems it matches with 0.18.1

I think your targetPort is not correct:
Name: grafana-svc
Namespace: monitoring
Labels: app=grafana-svc
Annotations:
Selector: app=grafana
Type: NodePort
IP: <IP_ADDRESS>
Port: 3000/TCP
-TargetPort: web/TCP
+TargetPort: http/TCP
NodePort: 30902/TCP
Endpoints:
Session Affinity: None
External Traffic Policy: Cluster
Events:

Afterwards your svc should know where to route to.

Make sense! Thanks a lot for your guidance!
This issue can be close, but I just wonder why the default grafana/prometheus/alertmanager services are NOT exposed by Node Port ?

We don't want to do this by default as people are likely to expose prometheus/alertmanager/grafana to the world, in fact we used to do this and people's instances started being indexed on google and random people on the internet started accessing their monitoring infrastructure, better safe than sorry :slightly_smiling_face: .

@brancz  Thanks for your kindly clarification!
I also find in 0.25.0 grafana always need to be authorized with  admin/admin when log-in, while in 0.18.1 it does NOT need to do so.
How can I disable log-in  in grafana via its configuration?
I know I should open another issue to ask, but it may much good if you may give a quick solution.
Best Regards!

You need to adjust Grafana's configuration.
Take a look at the project that kube-prometheus uses as dependency. There's an example on how to achieve this with jsonnet:
https://github.com/brancz/kubernetes-grafana/blob/455e08134e1a135f41e1032576487921a759cf51/examples/custom-ini.jsonnet#L10

Here's an example from my personal cluster:
...
    _config+:: {
      namespace: 'monitoring',
      grafana+:: {
        dashboards: $.grafanaDashboards,
        config: {
          sections: {
            security: {
              admin_user: 'metalmatze',
              admin_password: 'XXX',
            },
          },
        },
      },
    },
...

Thanks you  @metalmatze for your help . I did find this workaround in other threads, but what I want is disable authorization (which means user do NOT need to login grafana dashboard ).
Since this is a default behavior in 0.18.1, can we make this by just modifying files in manifest?

You are looking for anonymous authentication then:
http://docs.grafana.org/auth/overview/#anonymous-authentication
The config I posted above needs to be slightly changed.

Yes it does!
Seems it is the default setting in config
And how can I apply this in manifest yaml  file?

Take a look at https://github.com/coreos/prometheus-operator/tree/master/contrib/kube-prometheus#customizing-kube-prometheus
This should get you started with customizing kube-prometheus.

Thanks for your reminder and rapid reply.
I will have a try for customizing it .


Add $(inherited) to OTHER_SWIFT_FLAGS.

Other defines in OTHER_SWIFT_FLAGS were being overwritten.
Resolves https://bugs.swift.org/browse/SR-10804

Doing this here: https://github.com/apple/swift-package-manager/pull/2193


Update at-time-zone-transact-sql.md

The B example did not show converting between time zones.  It only showed how to assign different time zones to inputdate values that didn't have an offset.

@mtclifford : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Thanks @mtclifford! We appreciate your changes on this, and helping contribute to Microsoft Docs. I'll approve it.
#sign-off


Allow orga-files/folders to be accessible in meetings

Desired behaviour:

An Orgaadmin and superadmin should be able to set files or whole folders onto the status „public“, public folders/files are displayed in every meeting.
These global/public files/folders should not be deletable from a meeting
These files/folders should be in a meeting per default only visible for the admin group. Per default means: if a new meeting is created or a new folder/file is created/uploaded
The folder/file should have an icon as indicator to show that they are public in every meeting, I would recommend the „Public“ icon until further notice.  -> This icon should be visible on the orga- and the meeting-level

waiting for
https://github.com/OpenSlides/openslides-backend/issues/2499
https://github.com/OpenSlides/openslides-meta/issues/121


[SUPPORT] Primary key check in deltastreamer

Describe the problem you faced
we accidentally configure wrong primary key in the spark write config, it cause duplicate data. wondering if there is a way to avoid it.
To Reproduce
change the primary config in write config and run the spark job.
Expected behavior
maybe should block the spark job to write data if the primary key config is different from the primary key in the original table.
Environment Description

Hudi version : 0.11.0

Spark version : 3.2.1

Storage (HDFS/S3/GCS..) : GCS

Running on Docker? (yes/no) : yes. on k8s.

@WangCHX Let me check the code.  There should be validation of the write config against the table config to make sure they are consistent.

thanks. @yihua

have created a jira for tracking. closing the issue.
thanks for reporting.


Switching apps

I am loading the tournament series, switch to gmail/twitter/facebook.
Then the application is opened at the starting point instead of viewing the tournament information

Not sure if this issue is related to #25

Closed on PR #38


Update itemcollection_size.md

Fixes #2128

@Jaiganeshkumaran : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#label:"aq-pr-triaged"

#sign-off


GenerateReleaseNotes causing Cannot bind argument to parameter 'Message' because it is null error

Hi,
The "Generate release notes" step included in my TFS Release Definition has been working fine. However, I just increased my linked artefact sources from one TFS build to three TFS builds.
Now I get the following error. Do you know what I might be doing wrong?
Note if I select "Generate for only primary artifact" it work but then I don't get changeset details for all 3 builds.
2017-12-21T03:07:43.8862921Z ##[section]Starting: Generate release notes
2017-12-21T03:07:43.8862921Z ==============================================================================
2017-12-21T03:07:43.8862921Z Task         : Generate Release Notes
2017-12-21T03:07:43.8862921Z Description  : Generates a release notes file in a format of your choice
2017-12-21T03:07:43.8862921Z Version      : 2.10.2
2017-12-21T03:07:43.8862921Z Author       : Black Marble
2017-12-21T03:07:43.8862921Z Help         : Version: 2.10.2. More Information
2017-12-21T03:07:43.8862921Z ==============================================================================
2017-12-21T03:07:43.9175785Z Preparing task execution handler.
2017-12-21T03:07:44.3081900Z Executing the powershell script: C:\tfsbuild\agent3_work_tasks\GenerateReleaseNotes_661bc005-61be-430f-b994-065bf08c0f39\2.10.2\GenerateReleaseNotes.ps1
2017-12-21T03:07:44.3081900Z Build Number  : $($build.buildnumber)
2017-12-21T03:07:44.3081900Z Build started : $("{0:dd/MM/yy HH:mm:ss}" -f [datetime]$build.startTime)
2017-12-21T03:07:44.3081900Z Source Branch : $($build.sourceBranch)
2017-12-21T03:07:44.3081900Z ###Associated work items
2017-12-21T03:07:44.3081900Z @@WILOOP@@
2017-12-21T03:07:44.3081900Z * $($widetail.fields.'System.WorkItemType') $($widetail.id) [Assigned by: $($widetail.fields.'System.AssignedTo')]     $($widetail.fields.'System.Title')
2017-12-21T03:07:44.3081900Z @@WILOOP@@
2017-12-21T03:07:44.3081900Z ###Associated change sets/commits
2017-12-21T03:07:44.3081900Z @@CSLOOP@@
2017-12-21T03:07:44.3081900Z * ID $($csdetail.changesetid)$($csdetail.commitid) $($csdetail.comment)
2017-12-21T03:07:44.3081900Z @@CSLOOP@@)
2017-12-21T03:07:46.6823419Z ##[error]System.Management.Automation.ParameterBindingValidationException: Cannot bind argument to parameter 'Message' because it is null.
2017-12-21T03:07:46.6823419Z    at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)
2017-12-21T03:07:46.6823419Z    at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
2017-12-21T03:07:46.6823419Z    at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
2017-12-21T03:07:46.6823419Z    at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
2017-12-21T03:07:46.6823419Z    at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
2017-12-21T03:07:46.6823419Z    at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
2017-12-21T03:07:46.9480063Z ##[error]PowerShell script completed with 1 errors.
2017-12-21T03:07:46.9636305Z ##[section]Finishing: Generate release notes
The Inline template is
#Release notes for build $defname
Build Number  : $($build.buildnumber)
Build started : $("{0:dd/MM/yy HH:mm:ss}" -f [datetime]$build.startTime)
Source Branch : $($build.sourceBranch)
###Associated work items
@@WILOOP@@

$($widetail.fields.'System.WorkItemType') $($widetail.id) [Assigned by: $($widetail.fields.'System.AssignedTo')]     $($widetail.fields.'System.Title')
@@WILOOP@@
###Associated change sets/commits
@@CSLOOP@@
ID $($csdetail.changesetid)$($csdetail.commitid) $($csdetail.comment)
@@CSLOOP@@

I think you are missing an outer @@buildloop@@ tag, so when it has more than one build it cannot iterate across them.
For a sample see here
Let me know if that fixes it


Unable to create SendGrid connection

Describe the Bug with repro steps

Go to the logic app workflow designer
Try to create a new sendgrid connector (send email V4)
The GUI will ask for a name and an API key.
Create the connector. The portal fails with this error:

What type of Logic App Is this happening in?
Consumption (Portal)
Are you using new designer or old designer
New Designer
Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg
Yes
Workflow JSON
No response
Screenshots or Videos
No response
Browser
Chrome Version 120.0.6099.199 (Official Build) (64-bit)
Additional context
No response

@rllyy97 Just tried this and I'm able to repro it. Looks like it's an issue on the testLink again, who do we need to rope in to get this fixed?

I've worked with Brian on testLink work in the past, I'll reach out to him about it and get it figured out

I've worked with Brian on testLink work in the past, I'll reach out to him about it and get it figured out

Hi Riley, we faced the same in LA (Std), in consumption it working fine...

I spoke with Brian and this appears to be an issue with the testLink data that SendGrid is providing for their connector.
Previously when we had a similar issue it was resolved just from the SendGrid team updating their testLink data.
Nothing can be done by us to resolve this unfortunately.

Quick note, we looked back in our connection log data and for SendGrid connections we saw our testLink requests go from all 200s to all 404s like we're seeing now around February 3rd/4th.

I think this should be under standard logic apps and not consumption? Is there any workaround to make it work?

I think this should be under standard logic apps and not consumption? Is there any workaround to make it work?

Hi Bryan, seems using old designer allows connection creation:
https://aka.ms/lafallback

I think this should be under standard logic apps and not consumption? Is there any workaround to make it work?

Hi Bryan, seems using old designer allows connection creation in Standard: https://aka.ms/lafallback
and using Generally Available Designer for consumption

How do I access the old designer for standard? The link you provided returned 0 results. I have no problem creating sendgrid connection via consumption; but I need to make this work in standard.

@bryanm0204  The link shared is correct but it looks like the underlying url didn't match, use this one: https://aka.ms/lafallback
Also I just tried creating a sendgrid connection in legacy standard and I'm still seeing the same error,  @shboulatom83 if you are able can you take a network trace of you creating the connection in legacy standard?  The requests should be the same between legacy/preview on standard so I'm not sure what might be going on...
My email is<EMAIL_ADDRESS>

@bryanm0204 The link shared is correct but it looks like the underlying url didn't match, use this one: https://aka.ms/lafallback Also I just tried creating a sendgrid connection in legacy standard and I'm still seeing the same error, @shboulatom83 if you are able can you take a network trace of you creating the connection in legacy standard? The requests should be the same between legacy/preview on standard so I'm not sure what might be going on... My email is<EMAIL_ADDRESS>
@rllyy97 I was able to find the old designer. The workaround is good; add the connection in the old designer, save it. Then you may now use the new designer and proceed with the development.

<EMAIL_ADDRESS>
Hi Riley, I sent you the requested over Teams

@bryanm0204 The link shared is correct but it looks like the underlying url didn't match, use this one: https://aka.ms/lafallback Also I just tried creating a sendgrid connection in legacy standard and I'm still seeing the same error, @shboulatom83 if you are able can you take a network trace of you creating the connection in legacy standard? The requests should be the same between legacy/preview on standard so I'm not sure what might be going on... My email is<EMAIL_ADDRESS>
@rllyy97 I was able to find the old designer. The workaround is good; add the connection in the old designer, save it. Then you may now use the new designer and proceed with the development.

Hi Bryan, did this work for Consumption or Standard? as seems this workaround is only for Consumption Logic Apps.

I think it will be worth updating this issue thread. Logic Apps team addressed this issue for both Logic Apps Consumption and Standard on March 27. If you are still seeing the error on Logic Apps (Standard), please be sure to use the new designer when creating the SendGrid connection. Not going into details, but we suspect the issue was caused due to a slight change in the SendGrid API behavior, so we updated the HTTP request being sent to SendGrid to get the problem resolved.


revert(next-config): bring back redirects

https://user-images.githubusercontent.com/71545960/204469832-9cfb8516-a270-47a5-ac59-40478377e2ba.mp4

@ardeay I think there is a delay thats why we cant access the marketplace url yesterday , I bring back the redirects and its working fine


bug: cannot translate when issues has code

Describe the bug
When an issue contains code, it affects the percentage of languages that belong
function cleanCode(s: string): string {
  return s.replace(/^```(\s|[a-zA-Z]*)\n([\s\S]*?)```(\s*)$/gm, '')
}

Expected behavior
Does not affect the percentage to which the language belongs

https://github.com/a631807682/issues-translator/commit/e82cd85e5ea14f049dbc3e8d30300a9896fa90c3


Fix #1362, Simplify CFE_ES_QueryAllCmd file open logic

Describe the contribution
Fix #1362 - removes the first OS_OpenCreate (and file remove on success) since the following OS_OpenCreate with truncate makes it obsolete
Testing performed
Build/run unit tests, passed (once updated)
Expected behavior changes
None
System(s) tested on

Hardware: Intel I5/Docker
OS: Ubuntu 18.04
Versions: Bundle main + this commit

Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

Note, I double checked the other cFE core modules again, I don't see any other occurrences of this anymore.  So the only other issue is the one in CFE_ES_QueryAllTasksCmd above.

560111c removes the other case (and updates commit to reflect additional change)


[PyTorch] Disabling TorchDynamo for TE activation checkpoint wrapper

Description
te.distributed.checkpoint + torch.compile causes errors with user context functions and torch.amp.autocast() support in our checkpointing. The native PyTorch checkpoint wrapper avoids these issues via @torch._disable_dynamo for the checkpoint wrapper. This PR applies the same decorator to our own checkpoint.
Deprecation warnings were also discovered with PyTorch autocast API in the course of testing the fix. This PR also incorporates the minor changes required to address those deprecations.
Fixes #890
Type of change

[ ] Documentation change (change only to the documentation, either a fix or a new content)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Changes

Added @torch._disable_dynamo decorator to te.distributed.checkpoint().
Fixed PyTorch deprecations for autocast API used in te.distributed._get_active_autocast_contexts() .

Checklist:

[x] I have read and followed the contributing guidelines
[x] The functionality is complete
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/te-ci pytorch


Script not working after Slack update

Hello!
I use your script for my Slack app on Ubuntu 16. It worked fine until I updated my packages. I guess the Slack package must have been updated and it stopped rendering math. I rerun your script as mentioned in the doc and restarted slack, but then the slack window was completely blank.
I uninstalled and reinstalled the Slack app, which displayed correctly again. Then I ran your script again and started Slack, but still got a blank window.
I have this version of Slack: 2.6.0 64-bit Beta Channel

Thank you @monsieurTut for the bug report, and sorry for being slow to get to this. With the help of @gauss256, this problem is solved now. See #12


Fails to crawl on self-signed local certificate

Reported by user with 5.9, this may have been introduced when switching from wp_remote_get to Guzzle.
Fix in progress

fixed by https://github.com/leonstafford/wordpress-static-html-plugin/commit/d11bf47977454cb613799bc8a81c493853a39f9c


Using lawless typeclasses in d-p-extras

Hi, Tim.  This is more a question than a bug report, when I was inspecting d-p-extras code I saw a bug of lawless typeclasses. Those are used in order to be able to apply certain messages to a different types, however I'm curious if it's possible to remove amount of those.
For example:
Killable typeclass could be converted to
-- | Kill (instruct to exit) generic process, using 'kill' primitive.
killProc :: Resolvable p => p -> String -> Process ()
killProc r s = resolve r >>= traverse_ (flip kill $ s)

-- | Kill (instruct to exit) generic process, using 'exit' primitive.
exitProc :: (Resolvable p, Serializable m) => p -> m -> Process ()
exitProc r m = resolve r >>= traverse_ (flip exit $ m)

This will have the same effect as current instance as it's a catch-all instance and will not allow using non Resolvable types in it.

As I don't understand the all  reasons behind all use typeclasses in d-p-* I'd like to know that, and if possible to make some work to remove amount of those, or introduce laws for them.

This sounds like a very sensible improvement. What other instances should we look at? I'd be happy to tighten up the code where possible!!

For an example of how these type classes are used, consider the Mailbox type in https://github.com/haskell-distributed/distributed-process-execution/blob/master/src/Control/Distributed/Process/Execution/Mailbox.hs. This hides the Pid from clients of the mailbox server, and the mailbox server client api calls require this type to communicate with the server, employing the compiler to ensure we don't send messages to one kind of gen_server (in this case, the mailbox) when in fact the process id points to other kind of server which won't understand the message (even if it understands the client protocol)...

Synchronised seems redundant, is you want to have different locks it seems that it may better to use ADT there. If only one lock type is enough use use methods running in MonadCatch.
For other typeclass'es seems harder and I don't see a nice way to avoid them, so this why I created this issue, to understand the purpose for those and find best strategy there.

Yeah, so Resolvable, Routable, and Killable (I couldn't find a neat way to encode Monitor-able) are there because the gen_server API (managed process, aka d-p-client-server) is designed so all managed process implementations can call it from the client side, but that's very imprecise so we advise in the docs and tutorials that you wrap the server process id in a newtype and use that to ensure compatibility between client and server. If you look at https://github.com/haskell-distributed/distributed-process-registry/blob/master/src/Control/Distributed/Process/Registry.hs, this is even more important, because the data wrapper that represents a server process is parameterised by the key and value types the server instance uses - it's a phantom type - which is the only guarantee you've got that the server and client will understand each other with respect to these types, since the server is genetically parameterised by k and v.
So Addressable and co, are really valuable for making it easier to interact with these kind of server handles. If we can ensure they're not lawless, it would be preferable though!

By all means let's drop Sunchronized though, and make he other changes you proposed!

Would you mind looking at #5 as a first stab? I haven't removed Synchronised there, but I will once we're happy I'm on the right path with these changes.
I also need to test the impact of them on libraries like supervisor and client-server, which I'll get to asap.

Resolved in #5 - thanks for bringing this up @qnikst!


Support SoundCloud's API

This is probably a huge undertaking, but a lot of users wish YouTube + SoundCloud were supported. Since other websites, like plug.dj, support SoundCloud -- I suspect it is quite possible.
I'm not sure if radio mode would work with SoundCloud -- a lot of the logic for smart picking related YouTube videos is given by YouTube's API. If SoundCloud doesn't have something similar... it won't be possible!

Hey Sean, thanks for all the great work you've done on Streamus so far!
Just wondering if you needed any help with this. I should have a little bit of time to spare in a couple weeks and would love to see this feature implemented!
Cheers,
Sebastian.

Hey,
A couple of things:

Help would definitely be appreciated. I played with SoundCloud's API for a bit and it was sort of a nightmare to use it for streaming playback in extensions. If you check out https://github.com/MeoMix/StreamusChromeExtension/blob/master/src/js/background/model/soundCloudAPI.js you can see I really tore things up. SoundCloud's API + an API they depend on, SoundManager2, both needed to be inlined into Streamus because of their dependencies on '//url' resolving to either 'http://' or 'https://'. This is not the case in extensions as they resolve to chrome-extension://.

Furthermore, SoundManager2 has a tendency to want to provide a Flash player which is not really acceptable IMO. HTML5  or bust.

So, I hacked both of those out, got a song playing, and then realized that it's literally just  where the URL is easily derived from the track ID... a bit nicer than hacking at 8K LOC for the same effect.
So, I'm up in the air on that. Obviously need to use their API for everything other than streaming, but I'm thinking it would be easier to just do the streaming part internally?
The other thing on my mind, which I'll know soon, is how YouTube feels about SoundCloud. Streamus has finally caught their eye and I'm meeting with their BizDev/Partnerships teams over Skype next week. They might have opinions about coupling their API with SoundCloud, but I suspect they'll be OK with it. :) That said, they're the gate keeper, so gotta respect them.

@MeoMix How'd the discussions go. Would you still consider this?

Turns out this isn't possible. SoundCloud's TOS forbids using their API as an on-demand music service + forbids integrating it with YouTube.


File Save Dialog

The README.md states "native OS dialogs are still possible via 3rd-party libraries".
Can anyone recommend any such library for implementing a file save dialog in Linux (or possibly Windows)?

Simple cross-platform dialog API for go-lang: https://github.com/sqweek/dialog . I have been using it with no problems so far (only used .Load()).

If you want to avoid CGO (as well as threading issues, event loops, etc), consider:
https://github.com/ncruces/zenity


What use a single lane?

This may sound like a very silly issue, but we currently offer the option to do "SIMD" with a single lane. This is... uh...
"Why?" It literally contradicts the meaning of the phrase "SIMD".
Mind, if we offer a fully generic API over all L, yeah, a single lane is valid and only the "zero-lane" is not. So I am not saying we absolutely shouldn't do this per se. And e.g. x86_64 interprets floating point numbers in a way roughly equivalent to "single lane SIMD". However, I would still like examples of practical code that are enabled by this behavior on our part, or else to consider compile-errors on single-lane "vectors".

Mind, if we offer a fully generic API over all L, yeah, a single lane is valid and only the "zero-lane" is not.

I'd argue that both zero-lane and single-lane are valid for the same reasons the Rust types [u8; 0] and [u8; 1] are valid -- I expect SIMD to behave like an array where one operation on all elements on the array usually takes a single instruction.

There are open issues in rust-lang/rust about how there are many special-casings in the Rust codebase of 1 and 0 length arrays already, rather than any principled reasoning about the matter, so delegating to Rust's reasoning about arrays is not necessarily going to produce a consistent result.
In the interest of avoiding merely replicating the same fate, I opened this issue because I am interested in seeing what kind of practical applications we are enabling, rather than arguments from pure reason.

Well, the only thing, other than consistency with ISAs that let you use 0/1-element vectors (such as SimpleV and RVV), the only thing that I can think of right now is that it will tell the compiler to allocate certain variables in vector registers instead of integer or floating-point registers, for those ISAs that have separate vector registers.

Also, you could use it to get flush-denormals-to-zero behavior on ARM.

Having thought about it, I do not want to make the type Simd<T, 0> valid as it simply raises way too many questions, but I agree we should make Simd<T, 1> valid, as it provides a possible meaning when e.g. concatenating Simd<T> types or other idioms, and retains certain alignment reqs, even though demoting it to a scalar is also implicitly valid.


Fix SoftwareProcessPersisterInMemorySizeIntegrationTest

Seen a failure where 153397 bytes were written, increase maximum. The test is not deterministic.

retest this please

failure unrelated, recorded in new non-det test issue https://issues.apache.org/jira/browse/BROOKLYN-239 /cc @aledsage @sjcorbett
PR here looks good, merging


docs: fix the broken link for nodejs

Hi there, the link for installing nodejs is expired, found the new one and replaced it.

GM @flaub PLZ check


Fix maps/lists with sensitive members not redacted

Motivation and Context

Lists and maps with sensitive members were not being properly redacted. Closes https://github.com/smithy-lang/smithy-rs/issues/3757
Description

Updated Shape.shouldRedact method to properly check for list and map shapes with sensitive members. Also updated the test definition so it would actually run since previously the test code was generated in a nested function inside a no-op function and never run.
Testing

Added test cases for lists with sensitive members, maps with sensitive keys, and maps with sensitive values.
Checklist

[x] I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This has a lot of changes that actually seem to relax debug/display implementations. Have you verified this is the desired/correct behavior change? Were we over redacting before?

Good catch! That was a bug (same one causing the CI failures) and should be fixed in https://github.com/smithy-lang/smithy-rs/pull/3765/commits/4b398c752e573dd4fa55abb9ad6fa802b1d1263a

Probably this warrants a  CHANGELOG entry with a bug-fix being true.

This needs to be ported over to ServerBuilderGenerator too.
It also looks like we never added Debug implementation to ServerBuilderGeneratorWithoutPublicConstrainedTypes.


Adds PUT/PATCH

Addresses https://github.com/cloudspout/cloudspout-button-panel/issues/75

Can someone with write access merge this PR? That would be really helpful to me!

Agreed this would make this already useful panel even better. Also a DELETE would be great.