[BUG] Spotify UI breaks

Describe the bug
The Spotify UI get squeezed up and in the remaining blank space appears the background (tt is hard to describe, watch the picture below to understand better).
To Reproduce
I am not exactly sure how to reproduce it, the only thing I know is that it happens after a while and that it always happens when Spotify is minimized.
Screenshots

Desktop (please complete the following information):

OS: Manjaro
Version 21.1.5 Pahvo

Logs
I have the AUR Spicetify version, for some reason the DevTools does not appear when i press Ctrl + Shift + I.

Might be because of the same reasons as this @JulienMaille?
Also to enable devtools you have to run spicetify enable-devtools.

Oh, that's a typo in the issue template then. You can also try to right click somewhere and click "Show DevTools" (only works in spots the spotify context menu dosen't open).

Thank you.

Just happened again, this are the console's log screenshots I have taken:

I also copied the text, this is what it says:
vendor~xpui.js:1 MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 change listeners added. Use emitter.setMaxListeners() to increase limit
    at c (https://xpui.app.spotify.com/vendor~xpui.js:29:2353172)
    at t.o.addListener (https://xpui.app.spotify.com/vendor~xpui.js:29:2355454)
    at https://xpui.app.spotify.com/vendor~xpui.js:29:2048746
    at Pa (https://xpui.app.spotify.com/vendor~xpui.js:29:2595327)
    at As (https://xpui.app.spotify.com/vendor~xpui.js:29:2619179)
    at t.unstable_runWithPriority (https://xpui.app.spotify.com/vendor~xpui.js:29:2793496)
    at hi (https://xpui.app.spotify.com/vendor~xpui.js:29:2564835)
    at ks (https://xpui.app.spotify.com/vendor~xpui.js:29:2618958)
    at Os (https://xpui.app.spotify.com/vendor~xpui.js:29:2603729)
    at vs (https://xpui.app.spotify.com/vendor~xpui.js:29:2602651)
    at https://xpui.app.spotify.com/vendor~xpui.js:29:2565107
    at t.unstable_runWithPriority (https://xpui.app.spotify.com/vendor~xpui.js:29:2793496)
    at hi (https://xpui.app.spotify.com/vendor~xpui.js:29:2564835)
    at yi (https://xpui.app.spotify.com/vendor~xpui.js:29:2565052)
    at vi (https://xpui.app.spotify.com/vendor~xpui.js:29:2564987)
    at Es (https://xpui.app.spotify.com/vendor~xpui.js:29:2603150)
    at rl (https://xpui.app.spotify.com/vendor~xpui.js:29:2629563)
    at render (https://xpui.app.spotify.com/vendor~xpui.js:29:2632674)
    at https://xpui.app.spotify.com/xpui.js:1:1034419
xpui.js:1 Uncaught (in promise) Error: GET request to sp://ads/v1/settings/leaderboard failed with status code 404
    at l.onSuccess (xpui.js:1)
    at onSuccess (xpui.js:1)
pubads_impl_2021100401.js:1 Failed to load resource: net::ERR_CONNECTION_REFUSED
vendor~xpui.js:1 cosmos-connector:  fetchAdForSlot endpoint=%o sp://ads/v1/ads/hpto
vendor~xpui.js:1 cosmos-connector:  fetchAdForSlot endpoint=%o sp://ads/v1/ads/leaderboard
pubads_impl_2021100401.js:1 Failed to load resource: net::ERR_CONNECTION_REFUSED
about:srcdoc:39 Uncaught TypeError: googletag.defineSlot is not a function
    at about:srcdoc:39
pubads_impl_2021100401.js:1 Failed to load resource: net::ERR_CONNECTION_REFUSED
16
vendor~xpui.js:1 Error: SUB request to sp://ads/v1/slots/stream failed with exception '[VTO] Unsupported event type: discard'
    at l.onSuccess (xpui.js:1)
    at onSuccess (xpui.js:1)
pagead2.googlesyndic…YswMyCDtxPEJexEzV:1 Failed to load resource: net::ERR_CONNECTION_REFUSED
7
vendor~xpui.js:1 Error: SUB request to sp://ads/v1/slots/stream failed with exception '[VTO] Unsupported event type: discard'
    at l.onSuccess (xpui.js:1)
    at onSuccess (xpui.js:1)
pagead2.googlesyndic…YswMyCHiog1giIbyL:1 Failed to load resource: net::ERR_CONNECTION_REFUSED
2
vendor~xpui.js:1 Error: SUB request to sp://ads/v1/slots/stream failed with exception '[VTO] Unsupported event type: discard'
    at l.onSuccess (xpui.js:1)
    at onSuccess (xpui.js:1)
Vibrant.min.js:22 Uncaught (in promise) DOMException: Failed to execute 'getImageData' on 'CanvasRenderingContext2D': The canvas has been tainted by cross-origin data.
    at b.getImageData (https://xpui.app.spotify.com/extensions/Vibrant.min.js:22:529)
    at new b (https://xpui.app.spotify.com/extensions/Vibrant.min.js:13:89)
    at pickCoverColor (https://xpui.app.spotify.com/extensions/dribbblish-dynamic.js:345:20)
    at https://xpui.app.spotify.com/extensions/dribbblish-dynamic.js:369:76
    at waitForElement (https://xpui.app.spotify.com/extensions/dribbblish.js:323:9)
    at hookCoverChange (https://xpui.app.spotify.com/extensions/dribbblish-dynamic.js:367:5)
    at songchange (https://xpui.app.spotify.com/extensions/dribbblish-dynamic.js:303:5)
    at r (https://xpui.app.spotify.com/vendor~xpui.js:1:191324)
Vibrant.min.js:22 Uncaught (in promise) DOMException: Failed to execute 'getImageData' on 'CanvasRenderingContext2D': The canvas has been tainted by cross-origin data.
    at b.getImageData (https://xpui.app.spotify.com/extensions/Vibrant.min.js:22:529)
    at new b (https://xpui.app.spotify.com/extensions/Vibrant.min.js:13:89)
    at pickCoverColor (https://xpui.app.spotify.com/extensions/dribbblish-dynamic.js:345:20)
    at https://xpui.app.spotify.com/extensions/dribbblish-dynamic.js:369:76
    at waitForElement (https://xpui.app.spotify.com/extensions/dribbblish.js:323:9)
    at hookCoverChange (https://xpui.app.spotify.com/extensions/dribbblish-dynamic.js:367:5)
    at Array.songchange (https://xpui.app.spotify.com/extensions/dribbblish-dynamic.js:303:5)
    at Object.dispatchEvent (https://xpui.app.spotify.com/helper/spicetifyWrapper.js:18:29)
    at https://xpui.app.spotify.com/helper/spicetifyWrapper.js:172:34
    at https://xpui.app.spotify.com/xpui.js:1:1239610
    at l.onSuccess (https://xpui.app.spotify.com/xpui.js:1:1240815)
    at onSuccess (https://xpui.app.spotify.com/xpui.js:1:1240647)
6
vendor~xpui.js:1 Error: SUB request to sp://ads/v1/slots/stream failed with exception '[VTO] Unsupported event type: discard'
    at l.onSuccess (xpui.js:1)
    at onSuccess (xpui.js:1)
pagead2.googlesyndic…YswMyCPT91ojdK-WG:1 Failed to load resource: net::ERR_CONNECTION_REFUSED
5
vendor~xpui.js:1 Error: SUB request to sp://ads/v1/slots/stream failed with exception '[VTO] Unsupported event type: discard'
    at l.onSuccess (xpui.js:1)
    at onSuccess (xpui.js:1)
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/service-worker.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/vendor~xpui.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/22.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/644.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui-routes-collection-songs.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui-desktop-modals.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui-desktop-routes-homepage-takeover-ad.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/xpui-routes-home.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED
DevTools failed to load source map: Could not load content for https://xpui.app.spotify.com/754.js.map: Connection error: net::ERR_NAME_NOT_RESOLVED

Ok I will do it. I will update if the error stops showing up

Since I applied the fix the theme went perfectly. Thank you!

A friend of mine had it appear, I don't know why this is only happen on some occasions.

This was triggered by vibrant being called on an unloaded image. If we move to chroma, this should go away

@sicr0 feel free to reopen if you still have issues with 3.1.0


Material farmer

Added material farmer. Farms for Happiny dust for the item printer. Based on the Scatterbug program. But does not detect shinies.
One weakness is that due to the terrain, the character can't walk in a straight line.  So, it's often walking up against the walls. Due to variation in the way the game takes inputs, you can sometimes be walking up against the left wall and sometimes the right wall. As far as I can see, it can't easily be fixed without a way to detect player direction and adjust accordingly. Still, it earns approximately 150-300 Happiny dust per sandwich. So, you'll easily max out in 2-4 hours.
As I mentioned, this program is based on the Scatterbug program. There is some duplicated code. Particularly handle_battles_and_back_to_pokecenter. I'm not sure if it's better to refactor it so both programs can use the same function. Or if it's better to leave them separate, in case the programs diverge more in the future.

Any idea how much faster is this vs. running platform bot with no sandwiches in terms of total "value"?

I haven't tested it. I'll have to get back to you on this. If I remember correctly, platform bot is decent if you use a dragon encounter sandwich. One problem though is that I think platform bot stops on shinies.

I did some testing, although with low sample sizes (only 30-60 minutes of testing each). With Chansey farming, I get around 5.6 of item printer value per minute. Area zero with dragon sandwich: 4.6 value/min. Area zero no sandwich: 4 value/min.
One consideration, however, is that with Chansey farming, you will max out within approximately 2-3 hours. With area zero farming without a sandwich, it takes much longer to max out because the materials are spread out over several pokemon.
I wonder if it would be good to just have 2 different material farmers. So people have the option of faster farming, or slower farming, but has a higher max.

The material farmer should be done now.

Updated the Let's go path. It can now farm 500 Happiny dust per sandwich.
fixed bug with handling recoverable errors in both Material Farmer and Scatterbug program.


Electron build

It would be nice if we could optionally run codecept-ui as Electron app.
Pros:

easy to start and manage this app
more user friendly

Cons:

dependency on electron (maybe have it optional)

Inside Electron app there must be two modes:

full width - in this mode you see steps on the left and screenshots on the right. Useful when reviewing already executed tests or running tests in headless mode
1/3 width - in this mode the tests are running inside the browser window, so it is easy to have live preview in a real browser for tests.

So unlike our web app, electron app should also control its size and position (palce itself into top left corner and adjust size to modes)

https://github.com/codeceptjs/ui/blob/d3878a0462223ecb6b720fb7576916ae98e25743/lib/app.js#L29
@DavertMik, with the above x position, the electron app window falls outside of the desktop-viewport. Shouldn't x be set to either of the following:

Left-align window: x: 0,
Right-align window: x: (screenWidth - width),

Thank you, @gulench
I will try to implement it this way


dependencies: add invenio-logging with sentry sdk

Adds logging with sentry-sdk extra. It is not configured by default.
Tested with a new instance (v6.0) from scratch and no errors were shown.
Open questions

Do we want to add sentry to the docker-compose file? It would not be a zero-config thing, because the teams/users/project/dsn would still need to be created by the user
Should docs be added somewhere in InvenioRDM or the Invenio ones are enough (those are the ones I followed).

Do we want to add sentry to the docker-compose file? It would not be a zero-config thing, because the teams/users/project/dsn would still need to be created by the user

I would not add it at this point.

Should docs be added somewhere in InvenioRDM or the Invenio ones are enough (those are the ones I followed).

Later I would say.......first we need some more deployment docs

@lnielsen Should we merge this? The PR for the frontend part is independent.


Error while running ./GADS-devices-provider : Could not add /dev folder to watcher

Steps Followed :

Ran GADS repo first after updating config for rethinkDB(Also running)
Updated config in ./GADS-devices-provider
Setup android device setup by adding device config as array in list in config
Build Android Docker image(succeeded)
Now running go run main.go or ./GADS-devices-provider
getting this error

Starting provider on port:10001
Initial device update
Starting devices healthcheck
Starting /dev watcher
panic: Could not add /dev folder to watcher when preparing to watch it: "/dev/nsmb0": resource busy
goroutine 27 [running]:
github.com/shamanec/GADS-devices-provider/device.devicesWatcher()
/Users/abhishek/Documents/GADS-devices-provider-main/device/devices.go:126 +0x165
created by github.com/shamanec/GADS-devices-provider/device.UpdateDevices
/Users/abhishek/Documents/GADS-devices-provider-main/device/devices.go:20 +0xfb
exit status 2

My guess : Setup udev rules step needs the device provider repo to be running at localhost:port , but then some /dev folder is not present or not created hence giving error so not able to execute :
curl -X POST http://localhost:{ProviderPort}/device/create-udev-rules
HELP PLEASE!!!
Let me know if any steps are in wrong order.

Sorry for the late reply, mate! Your steps seem fine to me. Are you running this in a VM or actual Linux machine? The /dev folder is present on all Linux distributions and is not something that GADS creates. The endpoint /create-udev-rules creates the udev rules which add symlinks for the devices in the /dev folder when a device is connected. This is what the watcher is watching for - adding/removing from the /dev folder. I've never encountered this error but I'll look into what could be the issue. You can contact me on Discord: shamanec#4281 or LI so I can help faster when I am online :)

Oh, now I saw your console output :D Yeah, it is not going to work on a Macbook unfortunately. At the moment you can run GADS UI on a Mac but the provider works only on Linux

What are you planning on using the project for? I am working on some changes right now but when I finish them maybe I can spend some time and see if I can build a simpler provider version for MacOS

Hey @shamanec , thanks a lot for replying mate! I am planning to use this project as an ios device farm for my startup, to manually test and automate flows for my application, i have something already for android but ios is a pain in the a**.
Ill check if i can arrange a raspberry pi for the provider, will linux on that be enough for the smooth functioning?

Honestly I have no experience with Raspberry but as long as you can attach your devices over USB to it, I see no problem with it functioning :) I don't know if anyone is actively using this project at all and it has been pretty much tested only by me, so there might be different issues or missing information in the READMEs. Don't hesitate to contact me with any issues or feature requests and I will help out if I can :D

What are you planning on using the project for? I am working on some changes right now but when I finish them maybe I can spend some time and see if I can build a simpler provider version for MacOS

I would like to have this setup running on MacOS. I was wondering if you have any plans of releasing GADS Device provider for MacOS soon.  I am looking for a solution where i can build a small size iOS device farm and control them remotely.
Thank you in advance!

@ssanmaru hey, it is on my mind but I didn't have much time lately and been doing other changes. Do you need both iOS and Android? I can probably make it work in a week or two. I won't be using Docker containers on MacOS for the devices though due to some usb mounting limitations

Hey @shamanec , Thank you for your prompt response. I am looking for iOS devices only. I would like to have these iOS devices controlled remotely (like click, tap, sendkeys,etc..)

Sure, I'll try assembling something so you can get it going and maybe you'll test it for me as we go :D One more question @ssanmaru - do you plan to remotely control them on your own network? Currently the project is under the assumption of being used locally - you might be able to access devices through another network if you use ngrok but it's not something I aim for at the moment :D

@AbhishakeDev @ssanmaru there is already a working solution on the macos-support branch. I am still updating the readme and I'll need to cleanup and improve the code but I should be able to merge it into main next week I hope :)

done with #27 I would appreciate it if you check it out and let me know if any issues occur

closing, if any problems occur please do open new issues


Fix trailing whitespace

This PR:

adds/changes/removes etc

Testing
Description on how {APP-NAME} can be tested.

[ ] fresh install works

[ ] AWS
[ ] Azure
[ ] KVM

[ ] upgrade from previous version works

[ ] AWS
[ ] Azure
[ ] KVM

Other testing
Description of features to additionally test for {APP-NAME} installations.

[ ] check reconciliation of existing resources after upgrading
[ ] X still works after upgrade
[ ] Y is installed correctly

Checklist

[ ] Update changelog in CHANGELOG.md.
[ ] Make sure values.yaml and values.schema.json are valid.

values.schema.json was auto generated otherwise the check fails


[CIS] Check for PSP compatibility in target cluster

Parent ticket: https://github.com/rancher/rancher/issues/39366
Kubernetes 1.25 drops support for PSP, so additional checks need to be added.
Rancher team 3 is following the proposal outlined in "Kubernetes v1.25 PSP to PSA migration proposal document"
Every chart that ships with a PSP must be changed to add a new condition checking for the PSP capability in the target cluster:
Capabilities check for Helm
{{- if .Capabilities.APIVersions.Has "policy/v1beta1/PodSecurityPolicy" }}
This change allows the charts to still work with PSPs in Kubernetes versions prior to v1.25, and work in Kubernetes v1.25 or higher by skipping installation of PSPs.
Charts that need updating:

rancher-cis-benchmark

If a cluster role in a chart contains PSP's along with other permissions extra work may be needed to achieve the intended behavior of that role.

We do, however, need to make sure the behavior is appropriate.

@prachidamle @MKlimuszka Following is the behaviour seen on 1.25 clusters:

RKE:

rke-profile-permissive-1.23: The scans are working as expected. The scan is passing with the expected behaviour.

rke-profile-hardened-1.23: The scans are working as expected. There are some tests which fail mentioned in the screenshot below. The reason for their failures is because these tests run PSP related audit commands and in k8s 1.25 there isn't a PSP resource found.

K3s:

k3s-profile-permissive-1.23: The scans are working as expected. The scan is passing with the expected behaviour.

k3s-profile-hardened-1.23: The scans are working as expected. The scan is passing with the expected behaviour.

RKE2:

rke2-profile-permissive-1.23: The scans are working as expected. The scan is passing with the expected behaviour.

rke2-profile-hardened-1.23: We were not able to verify the scan results for hardened rke2 cluster because the cluster provisioning for rke2 hardened cluster was failing consistently. For k8s 1.25, the 1.6 cis-profile was showing incorrect while cluster provisioning. Also after changing the profile to 1.23, the cluster provisioning was stuck on updating state. There is already an issue logged for this here.

tested running scan for profile rke2-profile-hardened-1.23 on rke2-hardened cluster  k8s: v1.25.6+rke2r1.
The scan failed but all the failure cases have audit commands which try to do operation on psp so that is expected.

@prachidamle @MKlimuszka
cc: @mitulshah-suse

@MKlimuszka I'm on the docs team, helping with the 2.7.2 release notes. If the linked PRs are merged, why is this still open? Is there more to be done?

The comments above need to be documented in the release notes as expected failures for CIS scans on 1.25 clusters.
https://github.com/rancher/rancher/issues/39851#issuecomment-1430941043
https://github.com/rancher/rancher/issues/39851#issuecomment-1368903719

@ronhorton can we close this as CIS chart has been tested with k8s 1.25?

Pass We've tested this thoroughly ;)
Going out with rancher 2.7.2

@ronhorton Working on release notes. Are the expected failures described above for RKE and RKE2 still valid, or can this be moved to bug fixes?


chore: lint .js.flow files as well

Fixed, it was linting autogenerated files, so I ignored those.


Add linters

Adding some linters and formatters

This one is also ready @Luthaf

That's too many changes & too many commits to review. Could you squash it into two commits, one adding the linter configuration and a separate one automatically applying the linter suggestions? (or four, two commits for Python and two commits for C++?)
This should be doable by squashing all commits to a single one, then doing a soft reset and using git add -p to split the changes back into 2 or 4 commits. I'm happy to help with this!

Closing in favor of #29


Improvements to Windows projects generated by CMake

Motivation
This PR is meant to fix some problems with Windows project generation while also providing more granular options for project generation across the board.
Modifications

Recent changes to the CMake file made it so the generated Visual Studio projects would incorrectly link to release versions of zlib, protobuf, and curl libraries in Debug configurations. This change corrects that.
Changed the naming convention of the static vs shared library to conform more with other libraries.

Shared -> pulsar.lib, pulsar.dll.
Static -> pulsarstatic.lib

Added options BUILD_PERF and BUILD_EXAMPLES to make building the examples or the perf clients optional.

Verifying this change

[ ] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies no
The public API: no
The schema: no
The default values of configurations: no
The wire protocol: no
The rest endpoints: no
The admin cli options: no
Anything that affects deployment: no

Documentation

Does this pull request introduce a new feature? no

@heronr Could you please resolve the conflicts?

move to 2.7.0 first.

Could you rebase and resolve the conflicts since this PR is a little longer ago? And some changes have been made to CMakeLists.txt, for example, there's already an option BUILD_PERF_TOOLS to control whether to build the code in perf directory.


Can it generate TS definition for OpenAPI 3.0.x specification?

Hi,
It looks like it can't generate TS definition for OpenAPI 3.0.x specification, I got the following error when I try :

VVVV From VVVV
{ oneOf: [ { '$ref': '#/components/schemas/Document' } ] }
Error: Can't convert item to NodeType : {"oneOf":[{"$ref":"#/components/schemas/Document"}]}

The schema is the follow :
openapi: 3.0.3
info:
  title: Document upload API
  description: Document upload API
  version: 1.0.0
servers:
  - url: http://localhost:8080
paths:

  /document:
    post:
      description: Upload a new document

      requestBody:
        content:
          multipart/form-data:
            schema:
              type: object
              properties:
                file:
                  type: string
                  format: binary
                objectType:
                  type: string
                  description: The type of risk object of the document is attached to
                  example: ContractRequest
                  enum:
                    - PolicyOwner
                    - Car
                    - Motorbike
                    - ContractRequest
                    - Contract
                objectId:
                    type: number
                    description: The id of the risk object of the document is attached to
                    example: 25421
                documentType:
                    type: string
                    enum:
                      - DriverLicense
                      - IdentityCard
                      - AccidentRecord
                      - PlateRegistrationCertificate
                      - OdometerPicture
                      - PurchaseInvoice
                      - CurrentContract
                    description: The type of the document (DriverLicense, IdentityCard, AccidentRecord, PlateRegistrationCertificate, OdometerPicture, PurchaseInvoice, CurrentContract)
                    example: DriverLicense
        required: true

      responses:
        '200':
          description: OK
          content:
            application/json:
              schema:
                type: object
                properties:
                  documentId:
                    type: string
                    description: The uuid of the document
                    example: 123e4567-e89b-12d3-a456-426655440000
        '400':
          description: Bad request
          content:
              application/json:
                schema:
                    type: object
                    properties:
                      httpCode:
                        type: integer
                        example: 400
                      errorMessage:
                          type: string
                          description: The error message
                          example: Invalid request
                      invalidFields:
                          type: array
                          nullable: false
                          items:
                            type: object
                            properties:
                              field:
                                type: string
                                description: The name of the invalid field
                                example: file
                              message:
                                type: string
                                description: The error message
                                example: File is required

  /documents:
    get:
      description: Retrieve all documents
      responses:
        '200':
          description: OK
          content:
            application/json:
              schema:
                type: array
                items:
                  $ref: '#/components/schemas/Document'

        '400':
          description: Bad request
          content:
            application/json:
              schema:
                type: object
                properties:
                  httpCode:
                    type: integer
                    example: 404
                  errorMessage:
                    type: string
                    description: The error message
                    example: Unable to find documents

  /document/{documentUuid}:
    get:
      description: Retrieve a document by it's uuid
      parameters:
        - name: documentUuid
          in: path
          required: true
          schema:
            type: string
            example: 123e4567-e89b-12d3-a456-426655440000

      responses:
        '200':
          description: OK
          content:
            application/json:
              schema:
                oneOf:
                    - $ref: '#/components/schemas/Document'

        '400':
          description: Bad request
          content:
            application/json:
              schema:
                type: object
                properties:
                  httpCode:
                    type: integer
                    example: 404
                  errorMessage:
                    type: string
                    description: The error message
                    example: Unable to find document with given uuid

  /required_documents:
    get:
      description: Get all the required documents that have to be uploaded for a contract request
      parameters:
        - name: contractRequestId
          in: query
          required: true
          schema:
            type: string
            example: 123e4567-e89b-12d3-a456-426655440000
      responses:
        '200':
          description: OK

components:
  schemas:
    Document:
      type: object
      properties:
        uuid:
          type: string
          description: The uuid of the document
          example: 123e4567-e89b-12d3-a456-426655440000
        objectType:
          type: string
          description: The type of risk object of the document is attached to
          example: ContractRequest
          enum:
            - PolicyOwner
            - Car
            - Motorbike
            - ContractRequest
            - Contract
        objectId:
            type: number
            description: The id of the risk object of the document is attached to
            example: 25421
        documentType:
            type: string
            enum:
              - DriverLicense
              - IdentityCard
              - AccidentRecord
              - PlateRegistrationCertificate
              - OdometerPicture
              - PurchaseInvoice
              - CurrentContract
            description: The type of the document (DriverLicense, IdentityCard, AccidentRecord, PlateRegistrationCertificate, OdometerPicture, PurchaseInvoice, CurrentContract)
            example: DriverLicense
        fileName:
            type: string
            description: The name of the file
            example: driver-license.jpg
        mimeType:
            type: string
            description: The mime type of the file
            example: image/jpeg
        createdAt:
            type: string
            description: The date the document was created
            example: 2020-01-01T00:00:00.000Z
        updatedAt:
              type: string
              description: The date the document was last updated
              example: 2020-01-01T00:00:00.000Z

Note that also the 3.1 specification is very weakly supported
Can you see IT here : https://openapi.tools/
JetBrains plugins are not even working with 3.1 :/
So, I think it would be great to support the 3.0 specification, which is used a lot

Yeah it should work, I'll check the code ASAP to handle the file you submitted

It should work now, could you confirm it ?


Updated classifiers in setup.py

@clintonb I saw that you haven't released 3.0.0 yet that @Natim tagged earlier. You should have received an email about it from Jazzband (to a Gmail address). In case you want to redo the 3.0.0 release, please delete the files on jazzband.co first (on https://jazzband.co/projects/django-sortedm2m). There is currently still a tar.gz file, did you maybe already delete the whl file there?

Oh, in fact it's something else, I just found this in Sentry:
HTTPError: 400 Client Error: The description failed to render in the default format of reStructuredText. See https://pypi.org/help/#description-content-type for more information. for url: https://upload.pypi.org/legacy/

You seem to have tried the release of the whl file to PyPI already.


Support booleans and numbers for query values

Description
Booleans, numeric and nulls are now supported for query values.
Changes:

Implemented Deserialize manually for Template using serde_yaml::value::Value TemplateVisitor
Adjusted documentation, although  "true" is still supported I replaced it with true
Updated CHANGELOG.md (twice 😅)

QA

Added Template deserialization tests inside cereal.rs

Closes #141

I adjusted the code accordingly to your suggestions and updated pr description. Force pushed branch because I wanted to split changes between commits.

Forgot to run Rustfmt 😅

Thanks again! This is very nice to have. And congrats on the very first contribution to Slumber!


AngularJS 1.3.15

Hi Sebastian,
I updated the version of angular to 1.3.15, and the editable attribute doesn't work, i think the problem is because the attribute is passed as string, and the ngIf evaluate always true.
You have any suggestion to put this right?
NS

We also experience some issues since updating to 0.8 of ADF (also using Angular 1.3.15). Our issue sounds much like issue #60: you can move widgets within a column, but not to another. When moving a widget outside the containing column there is also no dropzone hint (as it used to be). Maybe an issue with sortable (i have tried both 1.1.1 and 1.2.0 - same result).

@ebtc please open a new ticket for the move problem.


feat: extended posts content with summary

This PR brings:

a filled up summary field for each of the blog post we have as of now

Steps to test:
N/A

Closed in favour of #54


Link to clear browser data page when max redirects error page suggests to do so

The Problem
In the max redirects error page, there is an ungoogled link, with the text, "Try clearing your cookies."

Proposed Solution
I would prefer this link to actually work (although it's not necessary). There is definitely an alternative link to put here, which is directly to the cookie-clearing internal page (chrome://settings/clearBrowserData).
Related Issue
Issue #605 is related to this one, as it deals with links to Google support pages in these types of errors and info pages, specifically the incognito page.
Additional Context

<EMAIL_ADDRESS>(installed via Homebrew)
macOS Mojave 10.14.1

Thanks for reporting. Going to close this as a duplicate of #605 and make that issue cover this one.


Memory specification

Hello,
I'm running the pipeline on a slurm cluster with -nth 24, and I have three fastq files so the pipeline is running three bowtie jobs giving 8 cpus to each job. But since the default memory allocation is 7G, each bowtie job gets about 1.6G, which I'm afraid is too little. I tried increasing it with the -memory parameter, using "-memory 72G", but nothing changes. If I use -mem instead of -memory I get a Java error saying that that 72G is an invalid number, although the documentation says that -memory should be equivalent to -mem:
Exception in thread "main" java.lang.NumberFormatException: For input string: "72G"
at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
at java.lang.Long.parseLong(Long.java:589)
at java.lang.Long.parseLong(Long.java:631)
at org.bds.lang.Type.parse(Type.java:334)
at org.bds.BdsParseArgs.parseArgs(BdsParseArgs.java:207)
at org.bds.BdsParseArgs.initializeArgs(BdsParseArgs.java:150)
at org.bds.BdsParseArgs.initializeArgs(BdsParseArgs.java:106)
at org.bds.BdsParseArgs.parse(BdsParseArgs.java:172)
at org.bds.Bds.runCompile(Bds.java:872)
at org.bds.Bds.run(Bds.java:815)
at org.bds.Bds.main(Bds.java:182)

Memory allocation parameters (-mem_APPNAME for a specific job and
-memory for all the others) are not total memory for the whole pipeline
run. So no matter how many bowtie2 jobs are submitted to slurm, the memory
limit for each is 7GB.
It is not recommended to use the default memory allocation (-memory)
since it changes memory limit for all tasks except those with their own
-mem_[APPNAME] parameters. Try -mem_bwt2 instead.
Thanks,
Jin
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=icon
Virus-free.
www.avast.com
https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=link
<#m_2210836363000819449_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

OK, thanks. It still seems that there's a bug in parsing the value of the -mem option, though...

-mem bug is a known issue and it cannot be fixed.mem is already taken as an internal parameter variable in BDS language so BDS and java complains if -mem is not an integer (bytes).
Please use -memory instead of -mem.


fix: Update kube-state-metrics.yaml to 2.12.0

Tested on cluster delete-me-ksm-test in lees-gmp

@lyanco re: conform if you haven't figured it out, you need to change the commit message, not the PR message (e.g. via git commit --amend). You can run make conform to test it's happy.

@lyanco re: conform if you haven't figured it out, you need to change the commit message, not the PR message (e.g. via git commit --amend). You can run make conform to test it's happy.

Thanks for the info, but I'm not doing that. #yolo


Can't use it with @web/dev-server

I just tried to use it with the @web/dev-server, but I get this error:

Error: fromRollup should be called with a rollup plugin function. Received: [object Object]

The config:
// ...
import { fromRollup } from '@web/dev-server-rollup';
import rollupPostcss from 'rollup-plugin-postcss';
import rollupPostcssLit from 'rollup-plugin-postcss-lit';

const postcss = fromRollup(rollupPostcss);
const postcssLit = fromRollup(rollupPostcssLit);

export default {
  // ...
  mimeTypes: {
    '**/*.scss': 'js',
  },
  plugins: [
    // ...
    postcss({
      inject: false,
      include: 'components/*/*.scss',
    }),
    postcssLit({
      include: 'components/*/*.scss',
      importPackage: 'lit',
    }),
  ],
};

Oh! It works change it from:
const postcssLit = fromRollup(rollupPostcssLit);

To:
const postcssLit = fromRollup(rollupPostcssLit.default);

Hey @abdonrd, thanks for reporting this!
I've switched to export = so that .default is not required anymore in node esm, the fix will be available in v1.1.1 soon 🙂


Restructure code

[x] Change the directory structure to a previously agreed-upon structure
[x] Change package names to org.eclipse.edc
[x] Adapt CI pipeline
[ ] Add repository secrets to fix integration tests

is "edc" the official shortname of our project? or is it "dataspaceconnector"?
we need to include the shortname as third part in the package names, see https://www.eclipse.org/projects/handbook/#checklist

is "edc" the official shortname of our project? or is it "dataspaceconnector"?
we need to include the shortname as third part in the package names, see https://www.eclipse.org/projects/handbook/#checklist

i think we talked about replacing com.microsoft.dagx with org.eclipse.edc during last friday's meeting, but I am not 100% certain. We can always change it, but org.eclipse.dataspaceconnector feels a bit ... clunky

i think we talked about replacing com.microsoft.dagx with org.eclipse.edc during last friday's meeting, but I am not 100% certain. We can always change it, but org.eclipse.dataspaceconnector feels a bit ... clunky

sure it's clunky but as far as I understand we are forced to do so (except we get an approval from our PMC):
https://www.eclipse.org/projects/handbook/#trademarks-code

no worries, I'll change it out to org.eclipse.dataspaceconnector.


errors with typescript 4.4

Expected Behavior
no compilation errors
Current Behavior
ERROR in C:/cygwin64/home/PC/XXX/web/node_modules/chart.js/types/index.esm.d.ts(540,5):
540:5 Cannot find name 'OffscreenCanvasRenderingContext2D'.
    538 |   | string
    539 |   | CanvasRenderingContext2D
  > 540 |   | OffscreenCanvasRenderingContext2D
        |     ^
    541 |   | HTMLCanvasElement
    542 |   | OffscreenCanvas
    543 |   | { canvas: HTMLCanvasElement | OffscreenCanvas }
ERROR in C:/cygwin64/home/PC/XXX/web/node_modules/chart.js/types/index.esm.d.ts(542,5):
542:5 Cannot find name 'OffscreenCanvas'.
    540 |   | OffscreenCanvasRenderingContext2D
    541 |   | HTMLCanvasElement
  > 542 |   | OffscreenCanvas
        |     ^
    543 |   | { canvas: HTMLCanvasElement | OffscreenCanvas }
    544 |   | ArrayLike<CanvasRenderingContext2D | HTMLCanvasElement | OffscreenCanvas>;
    545 |
ERROR in C:/cygwin64/home/PC/XXX/web/node_modules/chart.js/types/index.esm.d.ts(543,35):
543:35 Cannot find name 'OffscreenCanvas'.
    541 |   | HTMLCanvasElement
    542 |   | OffscreenCanvas
  > 543 |   | { canvas: HTMLCanvasElement | OffscreenCanvas }
        |                                   ^
    544 |   | ArrayLike<CanvasRenderingContext2D | HTMLCanvasElement | OffscreenCanvas>;
    545 |
    546 | export declare enum UpdateModeEnum {
ERROR in C:/cygwin64/home/PC/XXX/web/node_modules/chart.js/types/index.esm.d.ts(544,62):
544:62 Cannot find name 'OffscreenCanvas'.
    542 |   | OffscreenCanvas
    543 |   | { canvas: HTMLCanvasElement | OffscreenCanvas }
  > 544 |   | ArrayLike<CanvasRenderingContext2D | HTMLCanvasElement | OffscreenCanvas>;
        |                                                              ^
    545 |
    546 | export declare enum UpdateModeEnum {
    547 |   resize = 'resize',
Version: typescript 4.4.2

Possible Solution
add @types/offscreencanvas maybe?
Steps to Reproduce
create a project with chart.js and typescript 4.4
Environment

Chart.js version: 3.5.1
Browser name and version: n/a
Link to your project: n/a

I'm seeing this too. Any workarounds you've found?

Right now, I simply disabled typechecking of external libraries. It's far from ideal, but at least I can still compile and run my code

This was likely caused by https://github.com/microsoft/TypeScript/pull/44684 which seems to have removed the OffscreenCanvasRenderingContext2D and OffscreenCanvas types because they're only available in Chrome.

Was resolved in #9617


Update list of documents in bundle.yaml

Fixes #746
Mainly the list of document files was outdated.
I noticed that you have to explicitly list all markdown files that you want converted to HTML. It would be better to not have to keep that list updated every release but I think that would require leaving them as .md files or making a change to onto-tool. Maybe this should be added to the release documentation as a step (if it hasn't been added previously).

@Jamie-SA I'm going to close this PR. We will consider issue #746 for the next release. This PR may be updated by then, so I think it's easier to start fresh next time around.


Sorry not sure where else to ask

What's the application you use to check sensor info?
https://raw.githubusercontent.com/seanzhang98/ASRock-Z390-Phantom-ITX-OpenCore-Hackintosh-Monterey/main/imgs/sensors.png i mean this one.
Thank you in advance!

That would be sensei, a new clean & monitor app for mac OS


Memory issues on very high-resolution data with many directions

The complex denoising OpenNeuro test dataset (ds004666) contains a session with 0.9 mm3 voxels and 199 directions. I tried processing the job with a job memory limit of 64 GB and an --mem_mb value of 48000 (48 GB). This session is included as a "barely-usable" case for the sake of testing denoising methods, but it is so high resolution and has so many directions that QSIPrep failed with the following error:
Traceback (most recent call last):
  File "/usr/local/miniconda/lib/python3.10/site-packages/nipype/pipeline/plugins/multiproc.py", line 67, in run_node
    result["result"] = node.run(updatehash=updatehash)
  File "/usr/local/miniconda/lib/python3.10/site-packages/nipype/pipeline/engine/nodes.py", line 527, in run
    result = self._run_interface(execute=True)
  File "/usr/local/miniconda/lib/python3.10/site-packages/nipype/pipeline/engine/nodes.py", line 645, in _run_interface
    return self._run_command(execute)
  File "/usr/local/miniconda/lib/python3.10/site-packages/nipype/pipeline/engine/nodes.py", line 771, in _run_command
    raise NodeExecutionError(msg)
nipype.pipeline.engine.nodes.NodeExecutionError: Exception raised while executing Node biascorr.

Cmdline:
        dwibiascorrect ants -ants.b [150,3] -ants.c [200x200,1e-6] -bias vol0000_trans_merged_bias.nii.gz -fslgrad /cbica/projects/aslprep/qsiprep-complex/work/qsiprep_0p9mm_complex/qsiprep_wf/single_subject_01_wf/dwi_finalize_ses_0p9mm_dir_AP_run_04_part_mag_wf/$
Stdout:

Stderr:
       	dwibiascorrect:
        dwibiascorrect: Note that this script makes use of commands / algorithms that have relevant articles for citation; INCLUDING FROM EXTERNAL SOFTWARE PACKAGES. Please consult the help page (-help option) for more information.
        dwibiascorrect:
        dwibiascorrect: Generated scratch directory: /cbica/projects/aslprep/qsiprep-complex/work/qsiprep_0p9mm_complex/qsiprep_wf/single_subject_01_wf/dwi_finalize_ses_0p9mm_dir_AP_run_04_part_mag_wf/final_denoise_wf/biascorr/dwibiascorrect-tmp-3N7PLB/
        Command:  mrconvert /cbica/projects/aslprep/qsiprep-complex/work/qsiprep_0p9mm_complex/qsiprep_wf/single_subject_01_wf/dwi_finalize_ses_0p9mm_dir_AP_run_04_part_mag_wf/transform_dwis_t1/merge/vol0000_trans_merged.nii /cbica/projects/aslprep/qsiprep-comple$
        Command:  mrconvert /cbica/projects/aslprep/qsiprep-complex/work/qsiprep_0p9mm_complex/qsiprep_wf/single_subject_01_wf/dwi_finalize_ses_0p9mm_dir_AP_run_04_part_mag_wf/transform_dwis_t1/final_b0_ref/synthstrip_wf/mask_to_original_grid/vol0000_trans_merged$
        dwibiascorrect: Changing to scratch directory (/cbica/projects/aslprep/qsiprep-complex/work/qsiprep_0p9mm_complex/qsiprep_wf/single_subject_01_wf/dwi_finalize_ses_0p9mm_dir_AP_run_04_part_mag_wf/final_denoise_wf/biascorr/dwibiascorrect-tmp-3N7PLB/)
        Command:  dwiextract in.mif - -bzero | mrmath - mean mean_bzero.mif -axis 3

        dwibiascorrect: [ERROR] dwiextract in.mif - -bzero | mrmath - mean mean_bzero.mif -axis 3 (ants.py:64)
        dwibiascorrect: [ERROR] Information from failed command:
        dwibiascorrect:
                       	dwiextract: [ERROR] No b=0 volumes present
                        mrmath: [ERROR] no filename supplied to standard input (broken pipe?)
                        mrmath: [ERROR] error opening image "-"
        dwibiascorrect:
        dwibiascorrect: [ERROR] For debugging, inspect contents of scratch directory: /cbica/projects/aslprep/qsiprep-complex/work/qsiprep_0p9mm_complex/qsiprep_wf/single_subject_01_wf/dwi_finalize_ses_0p9mm_dir_AP_run_04_part_mag_wf/final_denoise_wf/biascorr/dwi$
        dwibiascorrect: Scratch directory retained; location: /cbica/projects/aslprep/qsiprep-complex/work/qsiprep_0p9mm_complex/qsiprep_wf/single_subject_01_wf/dwi_finalize_ses_0p9mm_dir_AP_run_04_part_mag_wf/final_denoise_wf/biascorr/dwibiascorrect-tmp-3N7PLB/
Traceback:
	Traceback (most recent call last):
          File "/usr/local/miniconda/lib/python3.10/site-packages/nipype/interfaces/base/core.py", line 398, in run
            runtime = self._post_run_hook(runtime)
          File "/usr/local/miniconda/lib/python3.10/site-packages/nipype/interfaces/mixins/reporting.py", line 50, in _post_run_hook
            self._generate_report()
          File "/usr/local/miniconda/lib/python3.10/site-packages/qsiprep/interfaces/denoise.py", line 68, in _generate_report
            input_dwi, denoised_nii, field_nii = self._get_plotting_images()
          File "/usr/local/miniconda/lib/python3.10/site-packages/qsiprep/interfaces/mrtrix.py", line 1188, in _get_plotting_images
            denoised_nii = load_img(ref_name)
          File "/usr/local/miniconda/lib/python3.10/site-packages/nilearn/image/image.py", line 1334, in load_img
            return check_niimg(img, wildcards=wildcards, dtype=dtype)
          File "/usr/local/miniconda/lib/python3.10/site-packages/nilearn/_utils/niimg_conversions.py", line 306, in check_niimg
            raise ValueError(f"File not found: '{niimg}'")
        ValueError: File not found: '/cbica/projects/aslprep/qsiprep-complex/work/qsiprep_0p9mm_complex/qsiprep_wf/single_subject_01_wf/dwi_finalize_ses_0p9mm_dir_AP_run_04_part_mag_wf/final_denoise_wf/biascorr/vol0000_trans_merged_N4.nii.gz'

While this situation won't be common, there are other datasets that we may want to process with QSIPrep with similar parameters, including the HCP 7T DWI data (1.1 x 1.1 x 2.1 mm voxels; 284 directions), so we probably want to implement something like the --low-mem option in the future.

It still failed when I gave the job 200 GB.

Did this ever work?

We did get it to work somehow, but I deleted our testing folder like two weeks ago. 🙃

Then the issue is solved!


Scoped uniqueness validation not working

I'm working on a project with Trailblazer (from master). I have the following operation:
class Customer::Create < Trailblazer::Operation
  include CRUD, Responder

  model Customer, :create

  contract do
    include Reform::Form::ModelReflections

    model Customer

    property :shipper_id
    property :code, validates: {presence: true, uniqueness: {scope: :shipper_id}}
    property :name, validates: {presence: true}
  end

  def process(params)
    validate(params[:customer]) do |f|
      f.save
    end
  end
end

The scoped uniqueness validation doesn't work, I get a PG::UniqueViolation: ERROR: duplicate key value violates unique constraint... because of my uniqueness database constraint.
I've also tried the other ways (all of them with and without the _id):
validates :code, uniqueness: {scope: :shipper}
validates_uniqueness_of :code, scope: :shipper

None of them seems to work. Any idea?

That's because AR's uniqueness validations are implemented poorly and super hardcore coupled to ActiveRecord's non-existent API.
Write your own uniqueness validator for now until we come up with a our own or use Lotus::Validations.
Duplicate, closing this.

I understand. Thank you, Nick.

Yeah, sorry for that inconvenience. I've tried several workarounds but they all ended up in too much patch code. Beside that, AR's uniqueness validation is leaky as it can create a race condition. And we could fix that in Trailblazer! The Operation#validate method could, for example, wrap the validation/save into a DB lock. In pure Rails, if two users with the same email send a request at the same time, it blows up!

No problem!
Do you plan on creating a "validations" gem or something like that?

I will start playing with Reform + Lotus::Validations, soon. Do they already include a uniqueness validator?

@apotonick Nope :/
From their README:
"Uniqueness validations aren't implemented because this library doesn't deal with persistence. The other reason is that this isn't an effective way to ensure uniqueness of a value in a database."

Yeah, we should write our own! I'm picturing something as follows.
class Operation
  def validate
    DB.lock do # no idea how, but it works somehow.
      contract.validate(params) # here, the uniqueness is tested, IN A LOCK.
      yield # this is where contract.save is called, still in the lock.
    end
  end

Since an operation wraps all that, it should be extremely simple (and 100% safe) to implement that. Interested, @zavan ? :grimacing:

@apotonick This is going to be a very busy week for me, but think I can handle this next week (or even this week if I find some time) :wink:

No worries, @gogogarrett is working on a new uniqueness validator already, you can think about the DB lock (if you want).

@apotonick On a side note, I didn't know about this Lotus Framework, it seems really cool. What do you think about it?
I know it's differs a lot from trailblazer, because trailblazer is just a thin layer on top of other frameworks and Lotus is a whole new framework (where trb can also be used...).

Lotus is fantastic, but it's too low-level. It's a great chance for a clean, new HTTP framework and Trailblazer can totally work in Lotus. However, Lotus is lacking a domain layer, an integration of view models with that domain layer, and I think they will end up using Reform as the validation layer, anyway.
I honestly can't wait to let operations and cells run in a Lotus::Action, though!

@apotonick That's what I thought. I think integration with trb (and cells, reform etc) will make it my dream framework.

hey @apotonick, this has been mentioned on the lotus chat and we had a small discussion about it https://gitter.im/lotus/chat (you will probably have to scroll up a little)

hey @zavan
somewhere in past I had to deal with uniqueness validation, so I ended up doing something like this (simplified the example to be easier to understand), but was something like User having uniqueness validation on document (you know, we have just only one CPF heheh)
its something like this:
class Create < Trailblazer::Operation
  contract do
    property :document
    validate :is_document_unique?
    model :user

    def is_document_unique?
      if User.where("document = ? and id <> ?", document, self.id).count > 0
        errors.add(:document, "is already in use")
      end
    end
  end

  include CRUD
  include Responder
  model User, :create

  def process(params)
    validate(params[:user]) do |f|
      f.save
    end
  end
end

hope it helps you
ps: Testing is damm easy, just test your operation in a context where the record is the first one being saved, then run the operation and try to save again, op.form will be with errors

@fernandes Thanks, that's what I'm doing for now :smile:
Only difference is I'm using Model.exists?, it's a little bit cleaner:
if Customer.exists?(code: code, shipper_id: shipper_id)
  errors.add(:code, "is already in use for this shipper")
end

You can write a scope on AR and use it... just would like to make the example simple to understand, all other approaches are personal preferences... if you got it, I'm happy :)

I was thinking about this and it came to my mind:
"Why don't I simply rescue the exception raised by the DB adapter when a unique constraint is violated (PG::UniqueViolation in PostgreSQL), parse the error message to get the invalid columns (since these exceptions doesn't provide them) and add them to the errors hash?! This way we don't need selects or locks, since the DB does this job better than anyone with the unique constraints..."
I started writing some code to try this out, and in my research I found this, which was extracted from Shopify.
It can work with Rails uniqueness validation + DB constraint, or just the DB constraint.
Aaaaand, It works just the way I described.
It is ActiveRecord::Base specific, but we could generalise this code into a gem and it would work perfectly with anything, including Reform. :smiley:
The only "problem" is: The dev would need to create the DB constraint (which in my opinion must be created anyway).

This doesn't work as the validation happens before saving
It's actually not that hard to implement, look at my diagram.
Operation#process
  DB.lock
    Operation#validate
      Reform#validate
        Song.where(title: "With Love, The Underground").size == 0
      Reform#save

The design of the operation is the perfect place to wrap that into a lock. And this also stresses that a real business validation is embedded into the entire workflow - it is just not a "validation" as Rails tries to do it.
The where part needs to be implemented in Reform as a validation and has the same race-condition problem as it doesn't lock or anything. However, the real power comes in an operation which gives you a lock for free.
Again, catching the exception doesn't help as it's "too late"! When saving, we're in a different state of the business workflow.

Damn, hadn't thought it through.
I'm messing with Lotus+Trailblazer right now, when I finish it I'll do this.


Theme Submission: Clarity

@chipzoller Hello, thanks for the great theme submission. Can you please ensure the demo link goes to a live demo which uses the themes demo content/first install content. Other then that, it looks good.

Hi @JugglerX I am sorry I had to use my blog despite the instructions. I did that as a temporary measure as we do not yet have a live demo site set up. Is this something you can approve and we can submit a new PR once we have that up?

We do not allow the demo URL to be the personal/business site to prevent abuse. It must be a seperate demo site with demo content.

Understand. We will set that up immediately.

Added correct demo link @JugglerX


#include derective in ShaderLab support relative path.

Is your feature request related to a problem? Please describe.
#include directive need to understand relative path like below:
#include "./shader/chunk.glsl"

Describe the solution you'd like
Add property path to ShaderPass and ShaderChunk class

implemented by #2222


less blocking prerequisites

the current prerequisites basically block you from using the app. in the future we could think about letting them still use the app but show them some kind of notification that stuffs not working 100%.

resolved by #197


OpenID Connect

How can we set up an AWS Identity Provider using the OpenID Connect configuration? AWS only finds one thumbprint yet Microsoft seems to offer four certificates when issuing a token. Do we need to add all four CA thumbprints to AWS?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8fa5814d-91e2-2f75-77e7-62a8597f340c
Version Independent ID: 458e93d7-a180-4c2f-5077-9b9d124d726a
Content: Tutorial: Azure Active Directory integration with Amazon Web Services (AWS)
Content Source: articles/active-directory/saas-apps/amazon-web-service-tutorial.md
Service: active-directory
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@swettstein Thanks for your feedback! We will investigate and update as appropriate.

@swettstein   I have assigned this issue to content author to investigate and update the document as appropriate.

@swettstein Can you please elaborate more on this?  AWS only finds one thumbprint yet Microsoft seems to offer four certificates when issuing a token.  I wanted to know how you can say that Microsoft is offering four certificates?

@swettstein OpenID Connect integration is not supported yet.
#please-close

whoa. sorry i missed this message. here is a Microsoft article with the four certificates: https://blogs.technet.microsoft.com/kv/2017/04/20/azure-tls-certificates-changes/
@jeevansd do you have a link on OpenID Connect integration not being supported?

AWS is offering OpenID Connect integration as IDP and not in SP mode. Also with SAML now you can achieve the session lifetime etc which you cannot do it from OIDC.


Replace old java-faker with kotlin-faker

Replaced an old and buggy java-faker with kotlin-faker :)
Probably not much of a difference for a demo, but it's my first contribution here, so hopefully it's ok :)
Tests in event-driven-microservices-workshop module still fail, but they were failing even before this change, so I assume it's intentional, since this is a workshop code.

Hi @ybyzek ,
kotlin faker offers more data providers, locales, and has extra "batteries" included as well - random instances of classes, unique values, etc. In addition to the above it's also faster.
You can also check some comparisons here if you're interested ;)

ping @MichaelDrogalis @ybyzek for input here plz

@MichaelDrogalis any thoughts on this? thanks!


optimize: reduce the waiting time for starting dfget server

Signed-off-by: lowzj<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #1088 into master will increase coverage by 0.04%.
The diff coverage is 96%.

@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
+ Coverage   47.28%   47.32%   +0.04%
==========================================
  Files         118      118
  Lines        7225     7235      +10
==========================================
+ Hits         3416     3424       +8
- Misses       3540     3541       +1
- Partials      269      270       +1

Impacted Files
Coverage Δ

dfget/core/uploader/peer_server_executor.go
86.95% <100%> (+0.38%)
:arrow_up:

dfget/core/uploader/uploader.go
88.03% <95.65%> (-0.04%)
:arrow_down:

supernode/daemon/mgr/scheduler/manager.go
21.91% <0%> (-0.69%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04f0ffe...633bf7c. Read the comment docs.

LGTM.


Turning off flaky link tests

@kristw turning these off until I can fix them.

LGTM

Codecov Report

Merging #6141 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6141   +/-   ##
=======================================
  Coverage   76.91%   76.91%
=======================================
  Files          47       47
  Lines        9362     9362
=======================================
  Hits         7201     7201
  Misses       2161     2161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aa6d90...b9be729. Read the comment docs.


Search function not working as expected

Have just upgraded to latest dev version 230815.13fb14
The ability to search the flights in admin is restricted as you cannot search the Airport you have to scroll down to select the airport.
Further out in the front end on the default or any theme the airport search fields just show no result with no ability to scroll either.
To Reproduce
Steps to reproduce the behavior:

Go to admin
Click on flights
Try to select an airport by typing in the search field
No result comes up and you have to scroll to the desired airport

For the front end:

Go to flights
Go to search box and select one of the airport fields
You have no drop down and all it shows is no result

Expected behavior
The ability to type in and search on an airport
Screenshots

Additional context
Add any other context and attach logs (from storage/logs/laravel-<date>.log)

Just and update, I have tried again in the default theme and it is working fine so the front end is related to theme issues..  Admin is not working right then.

Ok so one more update....
Even in default it is only allowing the search of the hubs rather than the whole airport selection.

So in default them the search is restricted to hubs only


export ValidationError interface for go

i'm use validator in rest handler but i want to send for user only field name that contains error. Now i need to have own
ValidationError interface {
  Field() string
  Reason() string
  Cause() error
  Key() bool
  ErrorName() string
}

What you think about adding such interface to go package? So users can cast error.(ValidationError) and operate on specific methods
Also may be useful to add Convert(err error) ValidationError function. So users can do
if err != nil {
  verr :=  xxx.Convert(err)
  return BadRequest(fmt.Sprintf("field %s error: %v", verr.Field(), verr.Reason()))
}

Sure, having a common interface that all of the various validation errors fulfill sounds like a good idea. I don't understand the .Convert() suggestion though. Is that something we could do with errors.As?

Also will be fine to add to internal struct field and public method to get struct name For now it auto added to Error() method, but not possible to get it via some method.

@akonradi yes, this looks suitable.

@rodaine this seems like it would introduce a compilation dependency on PGV in addition to using it for code generation. Is that something we're okay with doing in Go? We have similar support libraries in C++ and Python.


Payee and memo are empty often

Importing a TXT file into the app creates a CSV where often, both payee and memo are empty, making it difficult to categorize these transactions.
Example input:
123456789	EUR	20200102	3481,68	4019,58	20200102	537,90	SEPA Overboeking                 IBAN: NL51RABO0317315722        BIC: RABONL2U                    Naam: SVB Breda                 Omschrijving: KINDERBIJSLAG 4e k wart. 19 PF12345678 WWW.SVB.NL Sociale Verzekeringsbank Breda    Kenmerk: PF11234123125132
123456789	EUR	20200102	4019,58	3481,68	20200102	-537,90	SEPA Overboeking                 IBAN: NL53ABNA0123456798        BIC: ABNANL2A                    Naam: Anoniem
123456789	EUR	20200102	3481,68	3479,68	20200102	-2,00	BEA   NR:NB0405   02.01.20/10.27 Hema Papendrecht,PAS536         PAPENDRECHT
123456789	EUR	20200103	3479,68	3449,69	20200103	-29,99	SEPA Incasso algemeen doorlopend Incassant: NL47ZZZ370924590000  Naam: Basic Fit Nederland B.V.   Machtiging: 123456789           Omschrijving: 05-01-2020 / 01-02 -2020                           IBAN: NL24RABO0168476207         Kenmerk: NO123456789-96
123456789	EUR	20200103	3449,69	3316,61	20200103	-133,08	Maandpremie januari 2020         van verzekering 123456789

Output:

Date | Payee | Category | Memo | Outflow | Inflow
-- | -- | -- | -- | -- | --
2020-01-02 |   |   |   | 0 | 537.90
2020-01-02 |   |   |   | 537.90 | 0
2020-01-02 | Hema Papendrecht |   |   | 2.00 | 0
2020-01-03 |   |   |   | 29.99 | 0
2020-01-03 |   |   |   | 133.08 | 0

What bank are you using?

I’m using ABN AMRO
On Mon, 20 Jul 2020 at 15:46, Daniël Haitink<EMAIL_ADDRESS>wrote:

What bank are you using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DanielsWrath/YNABGoingDutch-ABN-edition/issues/2#issuecomment-661049645,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGHTTGO222EVDNHP5SVND3R4RDDRANCNFSM4PBG2K4A
.

Could you maybe send the file (or parts of it) to me? I cannot get any output when I put the Example input in a file.
You can anonymize everything, as long as it gives the same result.
My email is in my profile.

The extract is from the file, maybe it got trimmed or something. I’ll send
you a raw anonymous file tomorrow
On Tue, 21 Jul 2020 at 19:15, Daniël Haitink<EMAIL_ADDRESS>wrote:

Could you maybe send the file (or parts of it) to me? I cannot get any
output when I put the Example input in a file.
You can anonymize everything, as long as it gives the same result.
My email is in my profile.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/DanielsWrath/YNABGoingDutch-ABN-edition/issues/2#issuecomment-661991859,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAGHTTD65IHP3BLNFMRVXPLR4XEL5ANCNFSM4PBG2K4A
.

Hi guys, I am experiencing the same issue as Eric describes with ABN. Are there any updates on this matter? Thanks!

I completely forgot to send this file extract due to holidays back in july, so I expect no progress has been made

Like @ericdevries has said, I have gotten no file so I was not able to fix anything. If either one of you can upload/send a anonymized TAB file in which the error occurs, I can fix it in a (few) day(s)

Hi guys, thanks for your quick reaction!  I have send you an example file @DanielsWrath .

Should be fixed now! Please check if it works for you @zigmob @ericdevries

Hi Daniel,
Thanks! Great improvement, just a few lines with empty "payee" left. I will
send you an example.
Wouter
On Tue, 17 Nov 2020 at 12:15, Daniël Haitink<EMAIL_ADDRESS>wrote:

Should be fixed now! Please check if it works for you @zigmob
https://github.com/zigmob @ericdevries https://github.com/ericdevries
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/DanielsWrath/YNABGoingDutch-ABN-edition/issues/2#issuecomment-728860734,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABNVG7JUKU4U3KC7O6LZBFLSQJLORANCNFSM4PBG2K4A
.

Fixed in most recent release

Great, works flawless, thanks for your efforts!


Wrong calculation of "rail" element variables

Looks like variables @closeWidth, @veryCloseWidth, @dividingWidth has bad unit calculations here:
https://github.com/Semantic-Org/Semantic-UI/blob/master/src/themes/default/elements/rail.variables#L26
As you can see
@closeWidth: @width(300px) + @splitCloseDistance(1em); will be calculated as 301px;
@veryCloseWidth: @width(300px) + @splitVeryCloseDistance(0.5em); will be calculated as 300.5px;
@dividingWidth: @width(300px) + @splitDividingDistance(2.5rem); will be calculated as 302.5px;

Yes, this is very clearly, entirely incorrect. Not sure how this was introduced.
The less rule should ether be in a calc statement and use border-box or the width should remain 300px and use content-box. Not sure how this was introduced.

Thanks for your patience


Add conda env and $TMPDIR checks to Dataset class

Adds a _check_env_and_run() function to Dataset class that checks whether the user is using the correct Conda environment and has their $TMPDIR set correctly. These are mistakes I often make when running dataset scripts, so logging warnings will help correct mistakes more quickly in future runs.
This PR seeks to address #154

:rocket:


cmd/ctr: add quiet mode to ctr list

This is so I can delete all the containers I keep creating.
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

Codecov Report

Merging #752 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #752   +/-   ##
=======================================
  Coverage   62.46%   62.46%
=======================================
  Files           5        5
  Lines         682      682
=======================================
  Hits          426      426
  Misses        160      160
  Partials       96       96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d076e5...73ef701. Read the comment docs.

LGTM


#subnetMatchDual allows range lists to mix IPv4 and IPv6 ranges

As discussed in #56 this adds a separate method for using mixed range lists, but since the implementation differs only one line from original ipaddr.subnetMatch, implementation is by a bypass argument on that method that ipaddr.subnetMatchDual sets.
Naming such beasts is inevitably hard. I chose "dual" over "hybrid" and "mixed", but I don't have a strong opinion in the matter.
(To keep PR small, built js files are not included.)

So... on some reflection, it seems extremely unlikely that anything will break if we relax the restriction, so let's relax the restriction on subnetMatch instead. Also please add a note to the doc.

Have a look now?

Excellent. Unfortunately ipaddr.min.js is still broken. When you fix that I will merge.

The broken minified version is likely because package.json says "uglify-js": "latest" which is now new major version 3 with different API. However, when I do "uglify-js": "< 3.0" I get a minified version that is quite different from the one on master. My advise would be that you update package.json with the exact version you happen to be using and commit that on master. Then I can rebase on top of that change and build a new version.

Aha, thanks for the pointer.

Done

Merged.


Upgrade to webpack 5

We need to keep our dependencies to latest versions.
The biggest upgrade is related to webpack.
Moving to webpack 5 will also improve final bundles performance and reduce amount of webpack specific code comparing to v4.
https://webpack.js.org/migrate/5/

Leaving the issue unassigned since currently I don't find time to work on this.


Required Webservice Username and Password

The code supports using the default credentials by checking for null or blank username and password, however the UI has those marked as required fields.

Oh.. don't know why I did that... Ill fix it today

@leifab  Sorry for the delay (had other projects to do) but I assume this is fixed now. Can you validate it?

Confirmed fixed.

Awesome! Thanks for reporting :)


ShieldExclamationTriangleIcon.js file does not exist

Version 2.0.10
// export { default as ShieldExclamationTriangleIcon } from './ShieldExclamationTriangleIcon.js'
The above line is failing when importing either '@heroicons/vue/24/solid' or '@heroicons/vue/24/outline' as the files do not exist.
Commenting out the line in
<EMAIL_ADDRESS>and
<EMAIL_ADDRESS>resolves the issue temporarily

Hmm I can't find any reference to ShieldExclamationTriangleIcon anywhere in the codebase — here's the file you are talking about and there is no export with that name in there:
https://unpkg.com/browse/<EMAIL_ADDRESS>Can you provide a reproduction project?

Weird one! Okay going to close then, thanks 👍


Add videos for some of the past project teams

Some of the teams from last year made videos (but not all of them).
We should look into a way to add their videos to the site on the projects page.
Some ideas:

A link to the video shows up as a button underneath "Visit Project"
Row of button links underneath their respective projects
Separate part of the projects page has embedded videos

Keep in mind only 2 projects have videos right now. So we can make a call of whether we want to add this feature or just upload videos to YouTube and add this feature at the end of the year, when all projects from this year have videos.
We should upload them to our YouTube account first. (Ask us where you can find credentials)
==
Where To App:
https://drive.google.com/file/d/19B46QSgN9J2S8dnfBrwq4y8tzMRCWZtB/view
Tech Start Website:
https://drive.google.com/drive/folders/1IhwVs9DNHa0KUoliDvAVvwGRhSQdSKG1

Current plan: delay adding them to our website til we have more (later this year) but add them to YouTube

Done


http2 support

It would be great if node-tunnel included http2 support.

Because http2 api doesn't use Agent, tunnel can't support it.

Would you please revisit this again?

Would you please revisit this again?


Feature request: bring back serde!

Feature Description
Hi! I'm currently using the [serde-1] feature from versions <= v0.12 and would love to have it continue to be supported under a feature flag (maybe just serde?).
If it's really a problem I can always use serde's remote derive but it's just much more convenient to have this provided in the library itself!
Thanks so much for your time. If you decide it's OK to keep I'm very happy to submit a PR!

i removed it because i didn't think it was used and its original usage was never really necessary.
i can add it back, but curious why serialization is needed here?

closing due to lack of feedback.

closing due to lack of feedback.

Hey sorry! I was on vacation the past few weeks.
The reason that we're using the serde-1 feature currently is because we are serializing the information from the CiInfo struct into JSON which we are then sending to a REST API. I think that it would be a fairly common use case for consumers of this API.

Hey sorry! I was on vacation the past few weeks.
The reason that we're using the serde-1 feature currently is because we are serializing the information from the CiInfo struct into JSON which we are then sending to a REST API. I think that it would be a fairly common use case for consumers of this API.

@EverlastingBugstopper  I've added it back. Release as version 0.14.0

@EverlastingBugstopper  I've added it back. Release as version 0.14.0

Amazing!! Thank you so much 😄

Amazing!! Thank you so much 😄


middleman 4.0 support

hello,
does this exentsion support middleman 4.0. I got the following error message:
middleman-search was resolved to 0.0.1, which depends on
  middleman-core (~> 3.2)

and the middleman server crashed with the following error message:
== The Middleman is loading
/home/xx/.gem/ruby/2.2.0/gems/middleman-core-4.0.0/lib/middleman-core/extensions.rb:86:in `load': Unknown Extension: search. Check the name and make sure you have referenced the extension's gem in your Gemfile. (RuntimeError)

Hello @JohannaE! We have developed and tested this extension with Middleman 3 only I'm afraid. You're welcome to send a PR with the required changes to support both versions though; I don't expect it to be too difficult.


HIVE-21052: Make sure transactions get cleaned if they are aborted before addPartitions is called

What changes were proposed in this pull request?
Below changes are only with respect to branch-3.1.
Design: taken from https://issues.apache.org/jira/secure/attachment/12954375/Aborted Txn w_Direct Write.pdf
Overview:

add a dummy row to TXN_COMPONENTS with operation type 'p' in enqueueLockWithRetry, which will be removed in addDynamicPartition
If anytime txn is aborted, this dummy entry will be block initiator to remove this txnId from TXNS
Initiator will add a row in COMPACTION_QUEUE (with type 'p') for the above aborted txn with the state as READY_FOR_CLEANING, at a time there will be a single entry of this type for a table in COMPACTION_QUEUE.
Cleaner will directly pickup above request, and process it via new cleanAborted code path(scan all partitions and remove aborted dirs), once successful cleaner will remove dummy row from TXN_COMPONENTS

Cleaner Design:

We are keeping cleaner single thread, and this new type of cleanup will be handled similar to any regular cleanup

Aborted dirs cleanup:

In p-type cleanup, cleaner will iterate over all the partitions and remove all delta/base dirs with given aborted writeId list
added cleanup of aborted base/delta in the worker also

TXN_COMPONENTS cleanup:

If successful, p-type entry will be removed from TXN_COMPONENTS during addDynamicPartitions
If aborted, cleaner will clean in markCleaned after successful processing of p-type cleanup

TXNS cleanup:

No change, will be cleaned up by the initiator

Why are the changes needed?
To fix above mentioned issue.

Does this PR introduce any user-facing change?
No

How was this patch tested?
unit-tests added

@vpnvishv, thank you for your efforts, patch looks good! Could you please submit similar pull request for the master?

created same for master: https://github.com/apache/hive/pull/1548

@deniskuzZ  Thanks for reviewing and porting to master.


Automated Package Upgrade

:tada: This PR is included in version 27.1.47 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Achievement attack bonus

There does not seem to be anything taking into account the bonus from achievements. I get a bonus of approximately 4 levels  of attack power, so that's points that could be allocated elsewhere.

Achievement bonus is taken into account just fine, see this line of code.


Remove deleting the old config (unsupported) and add notification

This PR fixes #

Coverage increased (+0.001%) to 35.319% when pulling 3cf14cdcef0552aa6d17281d5aa626624d3c7883 on anthonydresser/configupgradenotification into 749c42ce41533f93037953ed2d84ef2f941266a2 on main.


Restore or remove convert microservice

TBC

Removed in https://github.com/epam/badgerdoc/pull/883


update all instrument properties on JSON changes

Should follow all instrument property updates when the underlying JSON file changes (not just AWG offsets).
@caryan

When do we not get a raw dictionary?  E.g. here

LibraryDecoder.load_from_library() is somehow depth-first. So, on construction the sub-objects are already created, but on update you need to do it manually.


sqlparser: misc tweaks

Subquery in FROM clause requires an alias
Precedence fixes
Support for REGEXP & RLIKE constructs

LGTM


Select Component invalid test fixture scenario for multiple selected options and size attribute support

Description of the issue

I'm implementing a test harness around component fixtures.jsons and run in to an issue with a scenario for the Select component.
Steps to reproduce the issue

Actual vs expected behaviour

The 'with selected value' scenario has one item flagged as selected and also has another value, er, value. The expected select html fragment looks like this:
  <select class="govuk-select" id="select-1" name="select-1">
      <option value="1">GOV.UK frontend option 1</option>
      <option value="2" selected>GOV.UK frontend option 2</option>
      <option value="3" selected disabled>GOV.UK frontend option 3</option>
  </select>

But isn't a Select element only able to have more than one selected option if its multiple attribute is set?
I'd expect the select element to be more like:
<select class="govuk-select" id="select-1" name="select-1"  multiple size="2" >
...

But then a second issue appears in that the Select box seems to ignore the size attribute and renders single-height regardless of its value. This makes it pretty much unusable as there's no good way to see the choices to select any of them other than the first in the list. (Tested on Firefox and Chrome on MacOS and Firefox on Fedora)
Environment (where applicable)

Operating system:
Browser:
Browser version:
GOV.UK Frontend Version: 4.5.0

Thanks for raising this! This appears to be an issue with the data that generates this fixture.
We don't support select[multiple] in Frontend due to there being a history of poor usability and assistive technology support for it, so only one of these should have the selected attribute.

Thanks.
Any chance you could also add a note to the component's docs to say the multiple attribute is not supported? I spent a chunk of time trying to see what I'd done wrong when adding it didn't work.

A fix for the fixtures has been merged and will go out in the next release.
I've opened a separate issue for any documentation changes. Feel free to comment on it if I've missed anything you think should be included: https://github.com/alphagov/govuk-design-system/issues/2625
Thanks again for bringing this to our attention!


Using key chord when file tree is focused triggers file highlighting

Issue Type: Bug
When focusing the file tree pane, hitting the "Save all" chord Ctrl+K-S triggers the file highlighting feature when the S key is pressed, making it impossible to use the chord.
VS Code version: Code 1.31.0 (7c66f58312b48ed8ca4e387ebd9ffe9605332caa, 2019-02-05T22:35:56.624Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4700HQ CPU @ 2.40GHz (8 x 2394)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.89GB (1.75GB free)

Process Argv

Screen Reader
no

VM
50%

Extensions (3)

Extension
Author (truncated)
Version

tslint
eg2
1.0.42

csharp
ms-
1.17.1

vscode-docker
Pet
0.5.2

As a temporary work-around you can disable highlight/filtering in the tree. Change the setting Workbench > List: Keyboard Navigation to simple or in json:
"workbench.list.keyboardNavigation": "simple"

@pedro-pedrosa I can't reproduce. We have code in place which avoids conflicts with chord commands. Can you send me a screen recording of the issue?

Currently set to highlight.
"workbench.list.keyboardNavigation": "highlight"
Anything else you'd like me to check?

If I change it to simple it both triggers the chord and selects a file. If I change it to filter, it doesn't trigger the chord and starts filtering the file tree, same behaviour as highlight.

I'm able to reproduce this issue in latest Insiders build.

Click on any file in Explorer
Press Ctrl + K - status bar shows (Ctrl + K) was pressed waiting for second key of chord...
Press any key - it is added to highlight, status bar still shows (Ctrl + K) was pressed waiting for second key of chord...

I have "workbench.list.keyboardNavigation": "highlight" in settings.
If I switch it to "simple" than I see next behavior:

Press Ctrl + K - status bar shows (Ctrl + K) was pressed waiting for second key of chord...
Press s - all edited files saved, status bar is cleared and file/folder starting with s is focused

VS Code version: Code - Insiders 1.32.0-insider (1c50a87561055485d93a3961160902308497f1e3, 2019-02-08T06:16:17.233Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
31.88GB (18.29GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions: none

I've noticed one more thing:

If i focus terminal window, and press ⌘K, ⌘S - nothing happens, even if i just press ⌘K i don't see the message ⌘K was pressed waiting for second key of chord..., but if i press ⌘R, then i see the message i mentioned above, but ⌘R, Shift+R doesn't work.
if i focus editor window itself, then all keybindings do work.
if i focus explorer window, then ⌘K, ⌘S work, but ⌘R, Shift+R doesn't work, it instead highlighting the root folder:

Just checked my keybindings:

As you can see, the When column is empty, so it means these keybindings should fire independent of focused area, e.g. text editor, terminal, explorer. Clearly a bug in 1.31 version.

I can confirm. Steps:

define new keybinding, e.g.:

{
    "key": "ctrl+k s",
    "command": "actions.find"
}

focus the explorer
press ctrl+k
the first part of the chord is entered
press s
the tree begins to highlight 's'.

The workaround provided by kieferrm works for me, which is to define in settings.json:
"workbench.list.keyboardNavigation": "simple"

"workbench.list.keyboardNavigation": "simple - it's just a workaround? Thing won't change in the future regards this setting?

Disabling features is not a workaround.

I can repro this on Windows, but not on macOS and Linux.

@alexandrudima Check this out:

Ctrl-F17?! :thinking:

@alexandrudima Found the issue. I was passing a raw KeyboardEvent to softDispatch which was resolving to that ctrl+F17 keypress. As soon as I wrapped it around StandardKeyboardEvent, I got the correct behavior:

I'll close this with that fix... but you might want to look into it.

@joaomoreno That is crazy, I didn't realize TS would find those to be compatible... Thanks for the heads up. I've pushed 2ff5d6bec9c0406cf49359a0a92d8a382609b8ef which makes it more obvious and found another bad usage :/ https://github.com/Microsoft/vscode/commit/2ff5d6bec9c0406cf49359a0a92d8a382609b8ef#diff-2203e613237f08bd954dd0a758dfffb4R360


Add UI function "addmod", by indexing(addmod INDEX m/...) or matric i…

…d (addmod s/A014... m/...)
Add ModCommand abstact class for AddModCommand and RemoveModCommand(todo), as a dumping ground for messages
Add AddModCommand and AddModCommandParser
Update isValidTimeSlot() to check for invalid time slots that fall on the last hour of the day. (2100 hrs)
Update some javadocs

Currently the addmod command prioritises matric id over indexing, although this priority should be reversed? (filtered list over global list). Im not too sure how to use
argMultimap.getPreamble(), while giving priority to indexing.
Using Prefix for index should solve this issue easily.

Opps i forgot to add the appeals back in.


Add github.draft (close #100)

That was indeed very easy.

Thanks, @MichaelMure!

This is released in v2.8.1.


enh dx: remove unused-imports plugin from eslint config (front)

We don't use it in connectors
We already get a warning from Typescript
There is no way, afaik, to get autofix on save for VSCode import orders (given that our import sorting setup is eslint-based) without having it auto-delete unused import (and that behaviour is really painful)

Will the build still fail if we have an unused import?

You mean in the Files changed panel?

yes, and also inline within VSCode

Same here

neutral too.

Thanks


macOS/Linux/Windows support?

Using the latest code from the master branch, I'm getting these errors
Unhandled Exception: MissingPluginException(No implementation found for method triggerLogin on channel customauth)

I'm guessing this is because the SDK isn't setup for anything other than iOS/Android. Is this going to change anytime soon? I will probably have to look elsewhere for a good auth setup.

The SDK only supports iOS and Android at the moment. We don't have plan to support desktop anytime soon. However a desktop implementation can be done manually using our Web SDK and redirect the result back to desktop app.


bug/hi_res can't extract filled texts from a form

Describe the bug
I am using a user fillable PDF form: filled.pdf with hi_res, and the output didn't include the filled texts from the form.
Output from OCR_AGENT=tesseract:
PDF Form Example

This is an example of a user fillable PDF form. Normally PDF is used as a final publishing format. However PDF has an option to be used as an entry form that can be edited and saved by the user.

The fields of this form have been selected to demonstrate as many as possible of the common entry fields.

This document and PDF form have been created with OpenOffice (version 3.4.0).

To fill out the form, make sure the PDF file is not read-only. If the file is read-only save it first to a folder or computer desktop. Close this file and open the saved file.

Please fill out the following fields. Important fields are marked yellow.

Given Name:

Family Name:  Address 1:    House nr:  Address 2:  Postcode:  City:      Country:  Gender:  Height (cm):  Driving License:  I speak and understand (tick all that apply):   Deutsch  English  Français  Esperanto  Latin              Favourite colour:

Important: Save the completed PDF form (use menu File - Save).

it didn't extract  text "Luke" from the "Given Name" field and all other filled texts
To Reproduce
from unstructured.partition.auto import partition
from unstructured.logger import logger
import logging
logger.setLevel(logging.INFO)
import os
os.environ["OCR_AGENT"] = "tesseract"
elements = partition("filled.pdf", strategy="hi_res")

print("\n\n".join([str(el) for el in elements]))

Also not working if i set os.environ["OCR_AGENT"] = "paddle"
Expected behavior
include filled texts from the pdf in the output

Just made a test using paddle ocr by hand. Works flawlessly with GPU-accelleration in a Docker container and more importantly it seems to get everything right that tesseract misses...

Closing as inactive.


Changed "parts" to "parties"

This paragraph originally used "...parts...", however a following graph used "...third party...", this change synchronized them.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

:sparkles: :sparkles: :sparkles: Awesome! Congratulations on your first contribution to freeCodeCamp! :sparkles: :sparkles: :sparkles:
@dougBelcher, everything LGTM! Thank you for helping us improve this section of the guide. Looking forward to your next contribution! :+1: :+1:
Hope you don't mind that I reopened your PR and merged it. Just seemed like a waste to let a fix like this remain closed.


Crash when trying to use the library on MacOS 11.5.2

Hi I've tried to use the library. but the app just crashes with the following message
2021-08-30 20:32:59.666406+0200 DBTools[58086:3348586] [Process] 0x7f9ced032020 - [pageProxyID=5, webPageID=6, PID=0] WebPageProxy::tryReloadAfterProcessTermination: process crashed and the client did not handle it, not reloading the page because we reached the maximum number of attempts
Steps to reproduce:

Created a new project in Xcode (MacOS app - SwiftUI lifecycle)
added the package dependency (File -> Swift Packages -> Add Package Dependency...)
Pasted in the Repo URL
Added the SwiftyMonaco to the view as per. your example.

When I run the app nothing happens.
I've tried both the Static and Dynamicly linked.

@csmaxx Yeah, there is a problem with that. It happens because Monaco Editor runs inside WKWebView and macOS considers it as an outgoing connection which should be allowed in App Sandbox (Network -> Outgoing connections (Client)):

Yeah, it's a little bit confusing, so I'll add it to the README.md and Wiki section later. If the issue has or has not been solved, let me know.

@pkasila It works now after enabling the Network option :-)


Evaluate Gutenberg

https://github.com/Keats/gutenberg

Uses https://github.com/google/pulldown-cmark for markdown parsing. Seems to be provide some low level access which would allow us to customize things a little more. Performance would have to be tested yet though.

Alright then we will continue with pulldown and syntec for further markdown processing.


Icon request: nav:collapse, nav:expand left and right

Alternative Expand/Collapse Icons
• APM Analysis uses left/right collapse/expand icons
• An alternative set of icons would work (the current set faces up/down)
Refresh Icons

Current Context
The right sidebar move expands from and collapses to the right.

We could add additional icons for this, but it's also easily achievable with CSS, e.g.
<px-icon icon="px-nav:expand" style="transform:rotate(-90deg)">
<px-icon icon="px-nav:collapse" style="transform:rotate(-90deg)">

Perfect. Feels like this is a closed issue? (Not sure if I should close or if someone else weighs in on doneness.)


Guides: unique URL per guide

Note: Guides are internal use only. This does not close an existing issue. However, this changes the global defaults for MUI Button per work with @chalimar.

After this PR, you can access four guides at
http://civictechindex.org/guides/buttons
http://civictechindex.org/guides/colors
http://civictechindex.org/guides/type-standards
http://civictechindex.org/guides/typography

Fixes Layout, Header / Footer duplication issue

Presents better as one column on mobile on the Type Standards page

I've gone and added more stuff, including a tweak to MUI Button theme settings. See the changes in action: https://civictechindex.netlify.app/guides/buttons


450 | Delete Node in Binary Tree | C++

Delete a node from binary tree
Type of issue:
Add new cod-
Please add/delete options that are not relevant.
Programming Language

[x] C++

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Could you please assign me for this task ?

Can you assign this issue to me?


Special cases io.Discard on fd_write

This avoids memory copying in default configuration where stdout/stderr are discarded. This helps avoid performance impact when console logging happens, but intentionally discarded.

merging as I don't expect this controversial and my next PR will severely drift it!