[FSSDK-9918] remove support for legacy ups

Summary
Support for legacy UserProfileService is removed. It's 7yrs old, so not expected in any devices.
Test plan

no new tests. pass all existing unit tests.

Issues

FSSDK-9918

Why FSC is failing?


:bookmark: Release 3.2.0

3.2.0 (2023-11-05)
Changed

Changed method raise_for_status in class Response to return self in order to make the call chainable.
Idea taken from upstream https://github.com/psf/requests/issues/6215
Bump minimal version supported for urllib3.future to 2.2.901 for recently introduced added features (bellow).

Added

Support for multiplexed connection in HTTP/2 and HTTP/3. Concurrent requests per connection are now a thing, in synchronous code.
This feature is the real advantage of using binaries HTTP protocols.
It is disabled by default and can be enabled through Session(multiplexed=True), each Response object will
be 'lazy' loaded. Accessing anything from returned Response will block the code until target response is retrieved.
Use Session.gather() to efficiently receive responses. You may also give a list of responses that you want to load.
Example A) Emitting concurrent requests and loading them via Session.gather()
from niquests import Session
from time import time

s = Session(multiplexed=True)

before = time()
responses = []

responses.append(
  s.get("https://pie.dev/delay/3")
)

responses.append(
  s.get("https://pie.dev/delay/1")
)

s.gather()

print(f"waited {time() - before} second(s)")  # will print 3s

Example B) Emitting concurrent requests and loading them via direct access
from niquests import Session
from time import time

s = Session(multiplexed=True)

before = time()
responses = []

responses.append(
  s.get("https://pie.dev/delay/3")
)

responses.append(
  s.get("https://pie.dev/delay/1")
)

# internally call gather with self (Response)
print(responses[0].status_code)  # 200! :! Hidden call to s.gather(responses[0])
print(responses[1].status_code)  # 200!

print(f"waited {time() - before} second(s)")  # will print 3s

You have nothing to do, everything from streams to connection pooling are handled automagically!

Support for in-memory intermediary/client certificate (mTLS).
Thanks for support within urllib3.future. Unfortunately this feature may not be available depending on your platform.
Passing cert=(a, b, c) where a or/and b contains directly the certificate is supported.
See https://urllib3future.readthedocs.io/en/latest/advanced-usage.html#in-memory-client-mtls-certificate for more information.
It is proposed to circumvent recent pyOpenSSL complete removal.

Detect if a new (stable) version is available when invoking python -m niquests.help and propose it for installation.

Add the possibility to disable a specific protocol (e.g. HTTP/2, and/or HTTP/3) when constructing Session.
Like so: s = Session(disable_http2=..., disable_http3=...) both options are set to False, thus letting them enabled.
urllib3.future does not permit to disable HTTP/1.1 for now.

Support passing a single str to auth=... in addition to actually supported types. It will be treated as a
Bearer token, by default to the Authorization header. It's a shortcut. You may keep your own token prefix in given
string (e.g. if not Bearer).

Added MultiplexingError exception for anything related to failure with a multiplexed connection.

Added async support through AsyncSession that utilize an underlying thread pool.
from niquests import AsyncSession
import asyncio
from time import time

async def emit() -> None:
    responses = []

    async with AsyncSession(multiplexed=True) as s:
        responses.append(await s.get("https://pie.dev/get"))
        responses.append(await s.get("https://pie.dev/head"))

        await s.gather()

    print(responses)

async def main() -> None:
    foo = asyncio.create_task(emit())
    bar = asyncio.create_task(emit())
    await foo
    await bar

if __name__ == "__main__":
    before = time()
    asyncio.run(main())
    print(time() - before)

Or without multiplexing if you want to keep multiple connections open per host per request.
from niquests import AsyncSession
import asyncio
from time import time

async def emit() -> None:
    responses = []

    async with AsyncSession() as s:
        responses.append(await s.get("https://pie.dev/get"))
        responses.append(await s.get("https://pie.dev/head"))

    print(responses)

async def main() -> None:
    foo = asyncio.create_task(emit())
    bar = asyncio.create_task(emit())
    await foo
    await bar

if __name__ == "__main__":
    before = time()
    asyncio.run(main())
    print(time() - before)

You may disable concurrent threads by setting AsyncSession.no_thread = True.

Security

Certificate revocation verification may not be fired for subsequents requests in a specific condition (redirection).

Test are failing / blocked by upstream https://github.com/jawah/urllib3.future/pull/39

Endgame.


pkg/config: check if globally excluded members belong to the org

Fixes: 874fe77169aa ("check if members in teams belong to the organization")
Signed-off-by: André Martins<EMAIL_ADDRESS>

I can't approve, I don't have write rights... :cry:

I also don't have the rights 😢


Added support for marketplace-specific tags

Status
Ready/In Progress/In Hold (Reason for hold)
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer

Let's hold it until the next SDK version is released

yes

Will merge this pr once https://github.com/demisto/content/pull/22518 will be merged

@dorschw Doc review completed.


Validation: preserve invalid data

Feature Request
In order to be able to find broken records in the database, it would be great to be able to get full data of invalid item in the ValidationError traceback output.
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
pydantic version: 1.4
            pydantic compiled: True
                 install path: /home/oklymenko/.virtualenvs/zakaz-commerceman-api/lib/python3.8/site-packages/pydantic
               python version: 3.8.0 (default, Oct 21 2019, 13:32:28)  [GCC 7.4.0]
                     platform: Linux-5.3.0-46-generic-x86_64-with-glibc2.27
     optional deps. installed: []

from datetime import datetime

from pydantic import BaseModel, ValidationError

class SomeResponse(BaseModel):
    class Config:
        invalid_model_full_data = True

    id: str
    name: str
    start_datetime: datetime
    end_datetime: datetime

imvalid_data = {
    "id": "123123",
    "name": ["some_name"],
    "start_datetime": 4,
    "end_datetime": 2,
}

try:
    SomeResponse(**imvalid_data)
except ValidationError as e:
    print(e)

"""
1 validation error for SomeResponse
name
  str type expected (type=type_error.str)
full_data
  {
    "id": "123123",
    "name": ["some_name"],
    "start_datetime": 4,
    "end_datetime": 2,
}
"""
...

I think that's reasonable if it's easy to implement.
Let's do it as part of v2.

At the risk of bikeshedding, I'd like to see this as an attribute on the ValidationError raised, rather than by default in the message, as I may be validating large objects and don't want to see the whole thing in every case.
If it's adding anything to the default message string, I would presume it would be under a "received" or "got" key and displayed next to/at the end of the expected line.

total agree, that's why I didn't add it earlier, but I can see many scenarios where access to that data would be useful.

@samuelcolvin @StephenBrown2 guys, please, review

Agreed.

If that's the case, we already preserve the input in ValidationError.errors().
So maybe we should remove the input from str(ValidationErrors) for the reasons you mentioned above @samuelcolvin?
We can still keep it in ValidationErrors.json().

@adriangb we only keep the value that failed validation right? It seems to me this request was to keep the data for the full model, not just the failing field. (Maybe I'm wrong about that or misunderstanding something.)
(I see the benefit of the validation error retaining a record ID even if just one of the fields fails validation.)

I think what we have now is good.
Open to a feature request to somehow store the exact input data, but I think in general that can be done outside pydantic.


Verify-commit changed to Dogecoin related content.

Unused currently, but changed to Dogecoin specific stuff in case of future implementation.

utACK

utACK


perf(parser): faster lexing template strings

Speed up lexing template strings.
This was the last use of AutoCow remaining in the lexer, and it's now removed.
Implementation is quite complex, to avoid repeatedly branching on whether an unescaped string is required or not (the way AutoCow did). I tried to simplify it down to a single function, but this hurt performance significantly.
Benchmarks do not show much movement, but I believe that's because there aren't many template strings in the benchmarks. Where there are template strings, I believe this speeds up lexing them significantly.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

#2541  👈
#2540
main

This stack of pull requests is managed by Graphite.

Merge activity

Feb 29, 12:22 AM EST: @Boshen started a stack merge that includes this pull request via Graphite.


vizrec plan change

see https://github.com/IBM/watson-calorie-counter/commit/ca2977bca78a7049260cf94964e6f79083027704 for example.

Thanks @stevemart


Add production debug tools

Adds the ability to:

turn on verbose mode
show eyrie
show react-query-devtools
turn on analytics debugging

by running window.toggleDevTools() in the console
fixes LAND-663

would you guys be opposed to window.toggleDevTools hiding them in development if triggered?
they occasionally get in the way visually and I wind up manually going in to comment them out. Would be nice to have a shortcut

would you guys be opposed to window.toggleDevTools hiding them in development if triggered?
they occasionally get in the way visually and I wind up manually going in to comment them out. Would be nice to have a shortcut

I like that idea. Will implement.

LFG


Corrupted arrow-buttons in Ie11 (Datepicker)

What is the expected behavior?
Buttons on ie11 not corrupted
What is the current behavior?
Buttons on ie11 corrupted
What are the steps to reproduce?
Open calendar. At rigth-top corner corrupted arrows.
https://i.gyazo.com/8e1621c90480276cc77554a560ffeb32.png
https://i.gyazo.com/d8773304f2c1a0cddf49b4edaa70ac7e.png we use calendar from angular material and don't control their appearance
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 7.0, Ie11 (11.285.17134.0). Mater 7.0
Is there anything else we should know?

I couldn't reproduce it against IE11. It looks like there might be some other styles from your app that are interfering with it.


Support builtins.styledComponents

What problem does this feature solve?
The babel-plugin-styled-components package provides compile-time optimization and server-side rendering support for styled-components. To bring it into Rspack, we need a new option field like builtins.styledComponents.

This plugin is a highly recommended supplement to the base styled-components library, offering some useful features:

consistently hashed component classNames between environments (a must for server-side rendering)
better debugging through automatic annotation of your styled components based on their context in the file system, etc.
various types of minification for styles and the tagged template literals styled-components uses.

I plan to contribute this feature by integrating the crate swc_plugin_styled_components into rspack_plugin_javascript.
What does the proposed API of configuration look like?
module.exports = {
  builtins: {
    styledComponents: {
      ssr: true,
      displayName: false,
      meaninglessFileNames: ["index", "styles"]
    }
  }
}

After discussions, we are going to support similar features in the buitins:swc-loader. You could see the details at #3382.
I'm going to close this issue for we won't support styledComponents in this way.

@hyf0 @swc/plugin-styled-components is loaded as an experimental plugin to swc. It seems like experimental plugins are currently disabled in rspack. Are there plans to change that?
https://www.npmjs.com/package/@swc/plugin-styled-components

It seems like experimental plugins are currently disabled in rspack.

Yeah. We haven't figured everything out.


Adicionar faculdade

@HelderJunior It looks like actual email domain of this university is unip.br, and it is already in this repository. I am sorry, I have to close this request without merging, because you requested to add a non-existent domain to this repository:
$ host unip.edu.br
Host unip.edu.br not found: 3(NXDOMAIN)

Please ensure you are familiar with this repository rules located at the bottom of this page and submit a new request with correct information. Thank you for the understanding!


On session close, don't close apps that weren't started by the WebDriver

When a session finishes or times out, don't close the app if the session was attached to an existing app using appTopLevelWindow or appTopLevelWindowTitleMatch.
This feels like intuitive behavior to me: the app was running before the session started so one can assume that the user is in control of the app lifetime.

Is this exposing the same behavior as other drivers, e.g. appium-windows-driver?
The specification is not completely clear about what is best, see https://www.w3.org/TR/webdriver2/#dfn-close-the-session

Is this exposing the same behavior as other drivers, e.g. appium-windows-driver?

Hmm, as far as I remember, WinAppDriver doesn't have a "close app on timeout" feature; I don't know if appium-windows-driver adds that. I can check.

Just checked WinAppDriver and it doesn't appear to stop a process started with appTopLevelWindow when the session ends normally.


The proper noun 'Managed Disks' is localized in Settings panel

Storage Explorer Version: 1.12.0
Build: 20200108.3
Branch: master
Language: Chinese(zh-CN)/ Chinese(zh-TW)
Platform/OS: Windows 10/ CentOS 7.6.1810/ MacOS High Sierra
Architecture: ia32/x64
Regression From: Not a regression
Steps to reproduce:

Launch Storage Explorer.
Open 'Settings' -> Application (Regional Settings) -> Select '中文（简体）' -> Restart Storage Explorer.
Open localized 'Settings' -> Select localized 'Transfers' -> AzCopy.
Check whether the proper noun 'Managed Disks' is localized or not.

Expect Experience:
'Managed Disks' is not localized.
Actual Experience:
'Managed Disks' is localized.

More Info:
ENU screenshot:

On review.

Similar to #2487, checking with Linguistic

CHS result: 'Managed Disks' is localized in TermStudio as a approved term.

@lukaschal, do you mean we should keep the translated string for "Managed Disks" in this case?

Hi @lukaschal  Check with the TermStudio.
'Managed Disks' is a proper noun in Hungarian /Japanese.
Since Managed Disks is localized in the above two languages. So we re-open this issue.
Hungarian screenshot:

Japanese screenshot:

Enu screenshot:

On review.

New JPN tgt: これらの設定を使用して、AzCopy のパフォーマンスを調整します。AzCopy は、BLOB、ADLS Gen2、Managed Disks に使用されます。

Confirmed with hungarian linguist that actual translation is correct as is.

Fxed on build 20200228.1(In Japanese).So close this issue.


Rendering issue in Farming Simulator 22

Looks like a shader issue with farming simulator 22 that is not present in RADV.
proton log

System
Arch 5.15.4-arch1-1
AMD Ryzen 5800X
AMD RX590
glxinfo.txt
vulkaninfo.txt

It works fine now.


Invalid metrics fixes

Various bug fixes.

Now requires Queue to be passed in as a parameter. This queue; the 'default' queue; and the global metrics are now only updated. Removed pipeline specific metrics as their values would be left as their previous values once they were zeroed.

Uses agent query rules to work out the queue instead of the agent. As the agent maybe null it was incorrectly returning the queue as 'default'

extractMetricData method was incorrectly appending the global metrics instead of the metric for the queue.

Superseded by #9


Unable to connect repository to existing amplify app

Description
If I try to add the corresponding code repository to an existing Amplify App via the connect button within the AWS Amplify Console, the Button changes to a loading circle and nothing ever happens after that.
Amplify CLI Version
4.41.2
Reproduction Steps
To be sure this does not have anything to do with our own project, I've recreated an amplify project and repository from scratch.
In Visual Studio:

Create a new GitHub Repository
Clone it via GitHub Explorer
Start Visual Studio Code and open newly cloned Folder
Install Amplify CLI globally, if not done already
run amplify configure
run amplify init (without --app)
run amplify add storage (nosql, with one column)
commit all changes to main branch
run amplify push

In AWS Amplify Console:
10. Go to aws amplify console and open the newly pushed app
11. View App Settings
12. Click "Connect Repository"
13. Login to GitHub
14. Authorize AWS CLI App
15. Wait forever
Expected behavior
After Step 14. the Source repository should be listed in the App Details of the Amplify App.
Screenshots

Desktop

OS: Microsoft Windows 10 Pro Version 20H2 / 10.0.19042.746
Node Version: v15.3.0

What we tried already to fix it

Used different Browsers: latest Firefox, latest Edge, even Internet Explorer which does not allow to confirm the Github OAuth Authorization.
Revoke and reinitiate OAuth Authorization. Result: By trying to connect the repository the Authorization Grant dialog will be opened, but after granting the asked rights the behavior is the same as described.
Tried to re-run amplify init with --app to add the repository afterward. Result: "Amplify does not have knowledge of the url provided" and "Please ensure you run this command in an empty directory".

Looks like I'm having a similar issue today rather suddenly. It was working, going along fine, then just stopped.  Now I'm getting:
2021-02-12T21:13:24.143Z [INFO]: Permission denied (publickey). 2021-02-12T21:13:24.144Z [INFO]: fatal: Could not read from remote repository.                                  Please make sure you have the correct access rights                                  and the repository exists. 2021-02-12T21:13:24.145Z [ERROR]: !!! Unable to clone repository.
I've tried revoking the OAuth Authentication on Github and reconnecting multiple times to no avail. This is happening to a known-good build as well as a fresh git push (which triggers the Provision, but does not succeed on the Build).

Can confirm seeing the same as @theholyone, although I was already logged into GitHub in my browser session so it simply redirected back to the Amplify console and left me hanging with the spinner.
The outcome of this is that we are now blocked when trying to move from manual deployments to CI/CD.

I can also confirm the exactly same behavior as occurs with @nefarioustim

I'm seeing the same infinite spinner as in the initial report.  I initially just uploaded static files, and am now trying to attach a repository.

I am seeing the same issue. The first time it prompted me to auth with GitHub, but at no point could I select a specific repository, and now it just stays loading and eventually times out, with no repository connected.

I’m experiencing the same issue. Any update on this?

Same issue. Surprised this is still an issue over 1 year later. On an existing amplify app that never had the repository configured, it would be nice if you could click "Reconnect Repository" and be able to choose Github or Gitlab. Right now that button kicks you over to GitHub only.

This bug has been added to our backlog for prioritization. We will update this issue once a fix has been pushed. Thank you!

@121940kz what were you trying to update? I just updated the app name of a manually deployed app via the cli and it ran successfully.

@121940kz what were you trying to update? I just updated the app name of a manually deployed app via the cli and it ran successfully.

I know it's specifically when trying to update the repository.
aws amplify update-app --app-id AMPLIFY_APP_ID --repository REPOSITORY_URL --access-token ACCESS_TOKEN
So i'm trying to add my repository connection to an amplify app which i created, and initially I specified that I would manually publish the app. Now i'm trying to circle around and add the repository connection for CI/CD but I face that error. And that is also when I realized connecting the repository through the Amplify Console only tries to load GitHub.
Does that make sense?

@121940kz Apologies for the delayed response. It's currently not possible to convert a manually deployed app to CI/CD without deleting the manually deployed branches first. You have to either delete the branches and then add the repository or you can create a new Amplify App instead.

We have the same problem, and I suspect the "start with manual" then "upgrade to automated" to be a very common path. In fact what I would recommend for most software engineering tasks.
Is there a walkthrough of what needs to happen to go from manual to CI/CD? When you say delete the branches, does it mean in github or the front end environments or the back end environments too? There are walkthroughs for adopting existing projects. Perhaps that is a better way to go if you need to migrate from manual to CI/CD, add the existing repo as a brand new app?

This issues is being marked as a feature request since we currently do not support converting a manually deployed app to CI/CD.

Any update on this?

Update?

Any updates?

update?


pyright: 1.1.365 -> 1.1.366

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for pyright is: Type checker for the Python language
meta.homepage for pyright is: https://github.com/Microsoft/pyright
meta.changelog for pyright is: https://github.com/Microsoft/pyright/releases/tag/1.1.366
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.1.366 with grep in /nix/store/182xrk3rcx81rzzhx08y533vv16nv34k-pyright-1.1.366
found 1.1.366 in filename of file in /nix/store/182xrk3rcx81rzzhx08y533vv16nv34k-pyright-1.1.366

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath

emacsPackages.lsp-bridge
pyright
python311Packages.types-lxml
python312Packages.types-lxml
vscode-extensions.ms-python.vscode-pylance

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/182xrk3rcx81rzzhx08y533vv16nv34k-pyright-1.1.366 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A pyright https://github.com/r-ryantm/nixpkgs/archive/2641f2df1c3e5fe58474a6273ded5f6790a69fbe.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2641f2df1c3e5fe58474a6273ded5f6790a69fbe#pyright

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/182xrk3rcx81rzzhx08y533vv16nv34k-pyright-1.1.366
ls -la /nix/store/182xrk3rcx81rzzhx08y533vv16nv34k-pyright-1.1.366/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

7 packages built:

emacsPackages.lsp-bridge
pyright
python311Packages.types-lxml
python311Packages.types-lxml.dist
python312Packages.types-lxml
python312Packages.types-lxml.dist
vscode-extensions.ms-python.vscode-pylance

Maintainer pings
cc @kalekseev for testing.

@NixOS/nixpkgs-merge-bot merge


chore: bdd-ghfjxy-import-1588821777 to 0.0.1

chore: Promote bdd-ghfjxy-import-1588821777 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Request: add option for "select all"/"unselect all" to checkbox question type

You can already do this with pressing a on the keyboard, recommend to close this issue


Detect staking on start staking flow

detect if staking have been initiated from different place during start staking flow #85ztrendq

take into account that MinDelegatorStk might not be available for Parachain staking - use MinDelegation in that case

Task linked: CU-85ztrendq iOS. Detect active staking on start staking flow


Unable to handle "tax_related" field

When using Qif.parse() on a .qif file that has been exported from MoneyDance, it would appear that there is not a 'tax_related' field. And when you try to parse the file you get the following error:
Traceback (most recent call last):   File "<stdin>", line 1, in <module>   File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/quiffen/core/qif.py", line 195, in parse     new_category = Category.from_list(sanitised_section_lines)   File "/Library/Frameworks/Python.framework/Versions/3.10/lib/python3.10/site-packages/quiffen/core/category.py", line 468, in from_list     new_cat = cls(**kwargs)   File "pydantic/main.py", line 341, in pydantic.main.BaseModel.__init__ pydantic.error_wrappers.ValidationError: 1 validation error for Category tax_related   value could not be parsed to a boolean (type=type_error.bool)
I opened the file in TextEditor, and did a search for the word 'tax' and it does not exist in the file at all.

Sorry for the late response. Could you send an example of the QIF file used?

Closing due to inactivity and lack of time. If anyone runs into this again, please reopen and submit a PR!


chore(deps): update common-dev-assets digest to 7d85724

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
5a7da53 -> 7d85724

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 6.1.0 :tada:
The release is available on:

GitHub release
v6.1.0

Your semantic-release bot :package::rocket:


Allow data providers to be non cacheable

Closes #3041
We can now configure TestNG to enable/disable
caching of test data produced by a data provider
when TestNG is retrying a failed test method using the attribute “cacheDataForTestRetries” on the
“@DataProvider” annotation.
Below is a sample, which forces TestNG to re-invoke the data provider when a test method fails and it  needs to be retried.
@DataProvider(name = "dp", cacheDataForTestRetries = false)
public Object[][] getData() {
  return new Object[][] {{1}, {2}};
}

Fixes #3041
Did you remember to?

[X] Add test case(s)
[X] Update CHANGES.txt
[X] Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

Add new features to TestNG (or)
Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.
Note: For more information on contribution guidelines  please make sure you refer our Contributing section for detailed set of steps.

Summary by CodeRabbit

New Features

Users can now define the order for TestNG listeners.

Bug Fixes

Aligned TestNG 7.x DataProvider behavior with TestNG 6.x for test retries.
Restored the ability to dynamically adjust the number of TestNG threads.
Moved Ant support to its own repository for better management.
Introduced caching control for data used in test retries, improving efficiency in test execution.

@Riabchykova please help create a new issue and include the sample there. For additional context you can always cross link this PR in the new issue.


events: investigate why the sqlite wal file grew ~170GB in 5 hours

The Fullnode on devent ran out of diskspace when the sqlite wal file for the events db grew ~170GB in roughly 5 hours. We mitigated the issue by deleting the wal file and restarting the fullnode but someone more familiar with the event system and sqlite should investigate and find the root cause this so that it doesn't happen again.

We found a command to manually clean up the WAL
sqlite> pragma wal_checkpoint(TRUNCATE);
0|0|0

as well as PRAGMAs that can be run either from code or SQLite CLI (we should set these in the code, obviously) that can limit growth of WAL in the future:
sqlite> PRAGMA journal_size_limit = 0;
0
sqlite>
sqlite> PRAGMA wal_autocheckpoint;
1000
sqlite> PRAGMA wal_autocheckpoint = 100;
100

Other directions we could go include to not use a WAL, and to keep tuning the auto checkpoint settings, but it seems the above should be sufficient for now.

I think if I run PRAGMA wal_checkpoint(TRUNCATE); at startup, the wal file will be shrunk once the node is dropped, what do you think?
With the current code, I have to wait for about 30 minutes.
pragma wal_checkpoint(TRUNCATE);

@mattsu2020  Now there is a forceful wal truncation that runs periodically. Now the wal is staying at a reasonable size. Also note that sqlite will be gone in a couple of months from fullnode.

With the current code, I have to wait for about 30 minutes.
Are you seeing a big wal locally or what is the worry?

In the devnet test, when synchronising at once on a high-speed server, the WAl file became bloated and exceeded 1 TB. This is a very rare case, but we believe the frequency will increase as the block numbers increase in the future.
It would be better if wal_checkpoint(TRUNCATE); could be executed during the initial synchronisation process.

sqlite is no longer in the codebase


[fix][io] Not restart instance when kafka source poll exception.

Motivation
When Kafka source poll message exception, it will throw it to the function framework, and not trigger the restart function instance.
After #20424, it just closes the Kafka source connector poll thread, and not will trigger restart instance.
Modifications

When Kafka consumer gets an exception, call notifyError to notify this exception, and when the function framework next calls consumer.read method, it will trigger instance restart.

Verifying this change

Change closeConnectorWhenUnexpectedExceptionThrownTest to cover it.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository

Codecov Report

Merging #20795 (1c0638b) into master (f69e7dd) will increase coverage by 36.30%.
The diff coverage is 76.92%.

@@              Coverage Diff              @@
##             master   #20795       +/-   ##
=============================================
+ Coverage     36.82%   73.13%   +36.30%
- Complexity    12123    32149    +20026
=============================================
  Files          1689     1867      +178
  Lines        129452   139054     +9602
  Branches      14123    15298     +1175
=============================================
+ Hits          47675   101699    +54024
+ Misses        75465    29301    -46164
- Partials       6312     8054     +1742

Flag
Coverage Δ

inttests
24.21% <4.61%> (+0.04%)
:arrow_up:

systests
25.10% <4.61%> (+0.11%)
:arrow_up:

unittests
72.43% <76.92%> (+40.40%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ava/org/apache/pulsar/broker/service/Consumer.java
86.31% <0.00%> (+21.94%)
:arrow_up:

...va/org/apache/pulsar/broker/service/ServerCnx.java
71.32% <42.85%> (+28.54%)
:arrow_up:

...rg/apache/pulsar/io/kafka/KafkaAbstractSource.java
69.28% <60.00%> (+69.28%)
:arrow_up:

.../org/apache/pulsar/io/core/AbstractPushSource.java
76.92% <76.92%> (ø)

...rg/apache/pulsar/broker/service/AbstractTopic.java
88.72% <100.00%> (+28.46%)
:arrow_up:

...broker/service/persistent/DispatchRateLimiter.java
81.48% <100.00%> (+1.63%)
:arrow_up:

...roker/service/persistent/PersistentReplicator.java
70.23% <100.00%> (+27.28%)
:arrow_up:

.../persistent/ReplicatedSubscriptionsController.java
72.59% <100.00%> (+72.59%)
:arrow_up:

.../apache/pulsar/functions/runtime/RuntimeUtils.java
79.38% <100.00%> (+25.69%)
:arrow_up:

...unctions/runtime/kubernetes/KubernetesRuntime.java
49.16% <100.00%> (+49.16%)
:arrow_up:

... and 2 more

... and 1422 files with indirect coverage changes

@Technoboy- @poorbarcode Thanks for the feedback.
About this comment: https://github.com/apache/pulsar/pull/20795#discussion_r1261959072
I refactor the start logic:

Let consumer.subscribe run on the start thread, which can quickly fail when subscribe exception.
Fix InterruptedException will be caught: when encountering an InterruptedException should be thrown it.

PTAL.


Add new parameters

https://github.com/tootsuite/documentation/pull/105/files
https://github.com/tootsuite/documentation/pull/89/files

Is it closed because it's already implemented but not yet pushed?

@vhbit It's no master already (tag 1.0.4). It's implemented as a optional parameter called range.

ahh, I've missed that. Thanks!

No problem @vhbit! You're welcome :-) I decided to bundle those in a single optional model to avoid method with long signatures. And it's easier to handle with maps and flatMaps.


Rotations not centred on crystal correctly "goniometer slump", XRC gridscan results interpretation

Rotations after xray centring sometimes are not aligned with the centre of the crystal, see:
Xray centred crystal: https://ispyb.diamond.ac.uk/dc/visit/cm37235-3/id/14661060
Manually centred same crystal: https://ispyb.diamond.ac.uk/dc/visit/cm37235-3/id/14661069
Observations after discussion with Mark, possibly this is multi-factorial:

In zocalo_results.py we subtract a 0.5 box-width amount from the coordinates we get back from zocalo - it's not clear to me if this is correct or not, not knowing enough about how the analysis interprets its input data or what it outputs

the number of data points for small crystals is very small (for some it may be a crystal only 2 x 1 x 1 boxes) and this may be affecting the quality of the returned centre-of-mass coordinate depending on the assumptions made in the analysis

The heatmap superimposed on the grid in ispyb is somewhat misleading as it suggests we have more data than we really do - a discretised flat shading per box would be more representative than smooth shading interpolated from the limited data points

Suggest that we reduce the grid size to collect more points per crystal, as per #1463

Investigate if the 0.5 grid size correction is actually the correct thing to do.

A reasonably simple example is at https://ispyb.diamond.ac.uk/dc/visit/cm37235-3/dcg/12456108, there is only diffraction on 2 images in each grid. Zocalo returned
[I 240725 10:00:35.145 zocalo_results:221] Received {'results': [{'centre_of_mass': [1.1030927835051547, 10.5, 4.5], 'max_voxel': [1, 10, 4], 'max_count': 234.0, 'n_voxels': 2, 'total_count': 388.0, 'bounding_box': [[0, 10, 4], [2, 11, 5]]}], 'status': 'success', 'type': '3d'}

which suggests an origin of the top left of box 1, but Hyperion removed the 0.5 box-width, as if the origin is the centre of box 1.

During investigation of this issue, I have found an issue with our variable naming in hyperion, it's not clear at the moment whether this actually affects the calculations or not, however it does make following the logic a lot harder:
#1500

After further analysis, I think the main issue is likely to be the grid scan boxes are too large. The difference in motor position for x,y,z axes between the manually aligned vs XRC aligned collections are 7.5, -10.5, -15.3 um respectively, and this approximately tallies with what the oav crosshair shows when the two images are superimposed (where the orientation is such that x,z axes are used). These amounts are all smaller than 1 grid square.
It seems that the issue described in #1500 doesn't affect the actual calculation as the um/mm mixup is reversed later on.

As part of this issue we should also document the co-ordinate system better e.g. is the top left the origin or is the centre of the box? Does the motor program/hyperion/zocalo agree on this origin?

Check this for the panda program too


Can I use this without running a server?

I'm very impressed with the results I got from the demo, but my use case doesn't require interactivity or a persistent server at all. I have hundreds of documents and thousands of pre-determined queries that I would like to run in bulk on an azure instance. I'm having trouble understanding how it all works from the docs, but it seems there is no way to use LLM document QA without running a server? Is there a way to just write a python script that imports from this repo as a lib?

API access goes through gradio that is supports both the UI and API is same code.
For sure one can mimic all the actions without the API or UI by calling the same functions in gradio_runner.py that follow the corresponding client steps, but it's not documented.  This is how many of our unit tests are constructed.


feat: add memory limiter to gateway collector

Do I understand correctly that the defaults are as percentages calculated, but when user wants to specify memory limits, they can only use absolute values?

The relative defaults allow a user to set just one value (the memory request) and have all the other values automatically derived from it.
If a user wants to set specific values, I thought it would be more straight forward to set the values as they would be written into the k8s manifest, instead of specifying relative amounts which requires more mental effort to calculate and understand. but I am open for change if you think it will be easier for users to use relative values @rauno56 @RonFed

I get where you are coming from, but I was also surprised a bit with the difference there.
Both of you have piles more experience in this specific case so I'll let you to thumb wrestle this out, but as a unsuspecting user-developer I'd expect defaults to have the same "power" as user-set values.


Error while creating NVA

Hi, I'm trying out the commands from this article and got stuck on creating an NVA. The article says the --public-ip-address "" parameter instructs Azure not to create and assign a public IP address to the VM, since the VM doesn't need to be connected to from the internet. However, I'm getting the error:
az : ERROR: az vm create: error: argument --public-ip-address: expected one argument
At line:1 char:1

az vm create --resource-group $RG --name myVmNva --image UbuntuLTS -- ...
+~~

CategoryInfo          : NotSpecified: (ERROR: az vm cr...ed one argument:String) [], RemoteException
FullyQualifiedErrorId : NativeCommandError

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 35b78580-2040-cf9d-f9fe-f7cb4678f53e
Version Independent ID: b0f94972-e227-05b5-9d3f-dbc95ccce6a7
Content: Route network traffic - Azure CLI
Content Source: articles/virtual-network/tutorial-create-route-table-cli.md
Service: virtual-network
GitHub Login: @jimdial
Microsoft Alias: jdial

Thanks for the feedback! We are currently investigating and will update you shortly.

@jpr2016git I was able to make the NVA without an issue. Please make sure that your CLI is fully updated. If you are still having this error, please let me know.

@jpr2016git We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


snipe off some unsafe code

Change Summary
The goal here is to remove all uses of unsafe which I could replace with safe code, or alternatively justify with a Safety comment. The changes make use of safe abstractions which should completely optimize away (especially with full LTO) so no performance impact is expected.
The only exception is that there were some uses of PyByteArray::as_bytes  which I didn't agree with as appropriate, and I copied the output of those cases into a new allocation. This is a necessary performance loss in exchange for correctness.
Related issue number
Related to https://github.com/pydantic/pydantic/issues/7211 - doing some due diligence here felt worthwhile.
Checklist

[ ] Unit tests for the changes exist
[ ] Documentation reflects the changes where applicable
[ ] Pydantic tests pass with this pydantic-core (except for expected changes)
[ ] My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Integration test failures are due to #911

please review


Party Resources button does not appear under actors tab after updating to v9

I have reinstalled the module and it still does not appear. It's fully installed too.

@TheMathKing It sounds like there are other errors occuring that prevent the module from loading in general.
Could you check if there are any errors in the Javascript console? (F12 in Firefox/Chrome, or if you run Foundry as an app you can find it in the menu. It's called "Developer console" or something, I can't double check since I'm on mobile atm).

I ended up reinstalling FoundryVTT and it ended up working. My issue now is
that the status bar will not show up at the top of the screen. When I click
"save changes" to enable it I get this error:
foundry.js:3856 TypeError: Cannot read properties of undefined (reading
'redraw')    at Setting._onUpdate (foundry.js:18103)    at
ClientDatabaseBackend.callback (foundry.js:10260)    at foundry.js:10212
at Array.map ()    at
ClientDatabaseBackend._handleUpdateDocuments (foundry.js:10212)    at
ClientDatabaseBackend._updateDocuments (foundry.js:10093)    at async
Function.updateDocuments (document.mjs:373)    at async Setting.update
(document.mjs:456)    at async ClientSettings.set (foundry.js:2202)    at
async ExtendedSettingsConfig._updateObject (foundry.js:55538)    at async
ExtendedSettingsConfig._onSubmit (foundry.js:3853)
On Fri, Feb 18, 2022 at 11:48 AM Dave Lens @.***> wrote:

@TheMathKing https://github.com/TheMathKing It sounds like there are
other errors occuring that prevent the module from loading in general.
Could you check if there are any errors in the Javascript console? (F12 in
Firefox/Chrome, or if you run Foundry as an app you can find it in the
menu. It's called "Developer console" or something, I can't double check
since I'm on mobile atm).
—
Reply to this email directly, view it on GitHub
https://github.com/davelens/fvtt-party-resources/issues/31#issuecomment-1045086403,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASXOFPJURWABX3LXU23LJXLU32O7RANCNFSM5OQJTARQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

@TheMathKing That's something that slipped into master when it shouldn't have yet. I just merged the status bar into master and made a new release, should be fixed now.

@TheMathKing I'm assuming this one got resolved, based on the error message above. If not, do comment back and I'll reopen.


Travis -> GHA

Simple translation, though Rubocop has evolved ....

https://app.shortcut.com/aptible/story/25608/sidekiq-field-encryptor-travis-migration

Technically speaking this is also running on Ruby 3 (it's in deploy-api)


Steering range of the car in AirSimE2EDeepLearning

Problem description
What is the steering range of the default avatar car?
Problem details

In "AirSimE2EDeepLearning/TrainModel.ipynb" , I found a comment for the steering range is +- 40 degees.
(theta = label * 0.69 #Steering range for the car is +- 40 degrees -> 0.69 radians)
But in "TestModel.ipynb",  the steering range is 0.5 radians(28.65 degrees). Which one is right?
(car_controls.steering = round(0.5 * float(model_output[0][0]), 2))
2.
Is the steering range of the default avatar car the same?
When I use  "round(0.5 * float(model_output[0][0]), 2))" for testing, the result was very poor compared with "round(0.009 * float(model_output[0][0]), 2))" in Hawaii env.
3.
How can I get the details of avatar car ? Can I change the settings of the avatar car?
Is possible to use a custom car to run this project?
4.
The gear data  is automatically changed according the speed data. Should we delete this column in 'airsim_rec.txt' since we don't need to predict the gear or use this data to predict?
5.
Using the record button, I can get the data from one camera  in RGB mode. How to record the data from other cameras or other modes with record button?
Exepriment/Environment details

Tutorial used: AirSimE2EDeepLearning
Environment used:  hawaii
Versions of artifacts used (if applicable): Python 3.6.5, Keras 2.1.2

The comment in the Train.ipynb. See answer to (2).

The 0.5 in that expression is not 0.5 radians. When testing, I found that the model had a tendency to overcorrect and oversteer. So I added that constant to smooth the output of the model. That should give you an idea of why setting this constant to 0.0009 would cause poor performance. Do note that I would expect that you'd have to retrain the model for Hawaii, which means collecting data for that environment.

What do you mean "details"? You can change all of the vehicle model parameters if you download and build AirSim from source. The car asset files are included in the plugin. You'd probably need to recollect data if you change the parameters of the car.

You can. It shouldn't have any effect on the modeling, apart from potentially reducing your file size by a bit.

You can't without modifying the AirSim source code. To record other views, and more complex scenarios, you can use the python or c++ apis. The build of AirSim that we include with the tutorial is before this feature was introduced.

Thanks! I'll try to built the AirSim by my own with LandscapeMountain.
One last question is the environments (NH,city,Hawaii...etc.) are created by your team?
In marketplace of EPIC GAMES, there are few road environments suited for autonomous car.

Neighborhood and Landscape are downloaded from the Unreal store. Hawaii and City are built by the AirSim team; the assets for those are not currently available for download.

Hello, I have not found your answer about the range of steering angles. Can you tell me again? And how is the label of the steering angle normalized to [-1, 1]? Is there a formula or reference?

Please help!!!
I have questions relating to gear in AirSim document.
What attribute in AirSim_rec indicates when the vehicle is backing up or in reverse?
What gear value indicates reverse
Can we predict forward/reverse movement along side steering angle to allow the vehicle correct itself in case it hits an obstacle.
Thank you in anticipation.


Add multi line indent to config plotting

This PR fixes the plotting of config entries that extend over multiple lines. It applies the indent of the first line and aligns the next lines:
Configuration (modified, added, typechanged, doc):
  experiments = [{'rates': [0.0], 'mode': 'fixed'},
  {'rates': [0.1], 'mode': 'fixed'}]

to
Configuration (modified, added, typechanged, doc):
  experiments = [{'rates': [0.0], 'mode': 'fixed'},
                 {'rates': [0.1], 'mode': 'fixed'}]

Coverage increased (+0.004%) to 83.609% when pulling 1533133a3002827167e9d788bf6a2a06528f5446 on timmeinhardt:add_multi_line_indent_to_config_plotting into 94785b9592b16e8498212ad9cfa0e05d49a1819d on IDSIA:master.

moved to #565


Improve Go Binary Release Action

Fix wrong published assets when folder is the same name as binary.
Use matrix strategy for multi platform target build.

thx, so much cleaner!


DSA Problem (Graph) | Number of Enclaves in C++

I want to add a new problem named "Number of Enclaves".
I code the solution for this problem in C++ language.
@Kumar-laxmi sir please assign me this issue.

This repository is for algorithms and not for DSA problems


Why not use renderer prop on Tree for NodeRenderer?

I'm probably missing something, but it seems a little strange to me that the Tree component takes data for its children, rather than the more typical approach of children nodes being content to be passed in to a component. It seems like a more common approach would be to pass the node renderer as a prop to Tree. Which would probably mean that Tree would be a self-closing tag/component.
I notice here that the main Tree component implementation does, indeed, assign children to the renderer prop of TreeViewProvider, which appears to be the real workhorse component.
Suggestion:

create a renderer prop on Tree
deprecate use of Tree's children

Hi @acjay, thanks for writing up this suggestion. I know what you mean. It does seem a little strange. I based that API on the react-window library, which is used by react-arborist. Brian passes in the row renderer as a single child component.
Over time, it grew on me. It mirrors the hierarchy between the parent Tree component and the children Node components.
Since React's children are just a special-case prop, I suppose you could make this argument for any component that accepts children.
Why do we write...
<Parent>
  <Child />
</Parent>

instead of...
<Parent children={<Child />} />

I admit the way we use the "children" prop in the Tree is different than above, but it's at least a bit similar.
In the end I think this is just a "chocolate" or "vanilla" type decision, so I plan to leave the API as is.
However, I thank you for your time and for prompting me to think about this more.

Ok, gotcha. Yeah, I thought more about it and it seems like it's basically a variation of the render prop pattern. I didn't recognize that with the Node pulled into a external variable, rather than provided inline as a closure.


Do not use CPU 0 for executing microvm code

What does this PR do?
Pull changes from test-infra-definitions.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

@usamasaqib do we still need this?


Query prefix documentation

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:

:+1:
For multitenancy environment this schema need to be automaticaly set by tenant/client context environment.
Still looking for best approach.
My ideea:
config :my_app, MyApp.Repo,
multitenancy:  MyApp.Multitenancy,
adapter:     Ecto.Adapters.Postgres,
username:    "hubbit_user",
password:    "hubbit_pass123",
database:    "hubbit_db_dev"
magically multitenancy: parameter that refer Multitenancy module do all the work.
For each request via Plug MyApp.Multitenancy receve tenant information
(for instance by domain, query parameter/prefix or headers)
@josevalim Can I open new issue to write all these notes and to help for implementatin?


App Crash in Compose Material 3 version 1.3.0 or above

java.lang.NoSuchMethodError: No static method BasicAlertDialog(Lkotlin/jvm/functions/Function0;Landroidx/compose/ui/Modifier;Landroidx/compose/ui/window/DialogProperties;Lkotlin/jvm/functions/Function2;Landroidx/compose/runtime/Composer;II)V in class Landroidx/compose/material3/AndroidAlertDialog_androidKt; or its super classes (declaration of 'androidx.compose.material3.AndroidAlertDialog_androidKt' appears in /data/app/~~MnOqQKmpDr3D0Rg7rwDTLQ==/com.dating.sacrenacompose-DBqq56eBCb7IUeeYsO39Cw==/base.apk!classes18.dex)
at com.arpitkatiyarprojects.countrypicker.CountrySelectionDialogKt.CountrySelectionDialog(CountrySelectionDialog.kt:75)
at com.arpitkatiyarprojects.countrypicker.CountryPickerKt.CountryPicker(CountryPicker.kt:77)
at com.arpitkatiyarprojects.countrypicker.CountryPickerOutlinedTextFieldKt$CountryPickerOutlinedTextField$3.invoke(CountryPickerOutlinedTextField.kt:98)
at com.arpitkatiyarprojects.countrypicker.CountryPickerOutlinedTextFieldKt$CountryPickerOutlinedTextField$3.invoke(CountryPickerOutlinedTextField.kt:97)

Yes, It has an issue. No matter what version you use. I tried compose bom 2023.08.00 (material3 1.1.1 ig), 2024.08.00(1.2.1), 2024.10.00(1.3.0), but it did not work.

Hello @arpitkatiyar1999 Did you find any solution for this issue?

Hi @bs-yash-khatri
We are currently investigating the issue . To gain better insights and identify the root cause, we would require additional details regarding your project's build configuration.
Could you please share the following files:
The build.gradle file (both at the project and module level).
The libs.versions.toml file (if your project uses version catalogs).
This information will help us ensure that there are no version mismatches or configuration issues affecting the dependencies.

You just need to update the compose bom in the library and stop using the deprecated BasicAlertDialog.

Hi @abdallahmehiz,
I wanted to share that BasicAlertDialog is not deprecated, and I was able to resolve the issue successfully. It has been addressed in version 2.0.1.
Thank you for your guidance!

Thank you for the quick release 👍


Edge 86 Updates

Required/Optional diagnostic data
Secure DNS

Docs Build status updates of commit 7fef44e:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/privacy-whitepaper.md
:warning:Warning
View
Details

microsoft-edge/privacy-whitepaper.md

Line 362, Column 1024: [Warning-bookmark-not-found] Cannot find bookmark '#diagnostic-data-about-how-you-use-the-browser' in 'privacy-whitepaper.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit edfe226:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/privacy-whitepaper.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 43d6420:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/privacy-whitepaper.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

#sign-off

Docs Build status updates of commit 65b4abd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/privacy-whitepaper.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 4c894af:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/privacy-whitepaper.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Express should be Dev Dependency?

Hey! Awesome work. Glad to see someone working on nice 3d text layout!
One thing I noticed in the package.json is that express should probably be a dev dependency rather than a regular dependency, right?
Thanks again!

Thanks for you support !
I saved express as a dependency because I deploy the examples page with Heroku, but after looking a bit more into it, I found that one can tell Heroku to skip pruning dev dependencies, so it's now in dev dependencies as you suggested. 👌


Add logging back to parsing and validation errors

Description
Issue #2248 accidentally removed error logging for parsing and
validation errors during execution. This PR adds it back and adds tests
to prevent future regressions.

Types of Changes

[ ] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Fixes #2322

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

This release adds logging back for parsing and validation errors that was
accidentally removed in v0.135.0.

Here's the preview release card for twitter:

Here's the tweet text:
🆕 Release (next) is out! Thanks to Jonathan Kim for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)


Enable download and installation of LLVM 16.0.0

LLVM 16.0.0 has been released, would be great to be able to use it from the Power Tools:
https://github.com/llvm/llvm-project/releases

Hi @bersbersbers,
Thank you for letting us know about the release of LLVM 16.0.0!
We appreciate your suggestion and we'll definitely consider including it in the next release of our Clang Power Tools
Best regards,
Marina

Hi @MarcelNehring,
LLVM 16.0.0 is available in Clang Power Tools release v2023.4.0
Have a nice day,
Marina


Support hiding plugin settings based on hosting environment

Summary
This PR makes it so a given plugin can hide specific plugin settings based on the hosting environment of the server.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-44843
Release Note
NONE

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

/update-branch


RHOAIENG-1869 - Migrate PR check from build and test pipelines into e…

…2e pipeline
JIRA: RHOAIENG-1869
Description
This migrates the PR check to test the single e2e pipeline instead of 2 separate pipelines (build-container-image-pipeline and test-mlflow-image-pipeline)
It also adds a new function to be able to create a basic-auth secret instead of a kubernetes.io/dockerconfigjson secret as this is what the pipeline uses now.
How Has This Been Tested?
Locally using a separate cluster.
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[ ] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/rerun

/retest

/lgtm
Thx for updating this for the e2e pipeline


Basic auth not working on v3.1.0

Current Behavior
When using the basic auth does not move passed the login page, even though it does authenticate (see log below)
log file:
oauth2_proxy[22171]: 2019/04/02 14:33:12 main.go:125: using htpasswd file /etc/oauth2_proxy/htpasswd
oauth2_proxy[22171]: 2019/04/02 14:33:12 http.go:52: HTTP: listening on <IP_ADDRESS>:4180
.
.
.
oauth2_proxy[22171]: 2019/04/02 14:33:25 oauthproxy.go:557: authenticated "testuser" via HtpasswdFile
2019/04/02 14:33:25 oauthproxy.go:796: <IP_ADDRESS>:54202 ("<IP_ADDRESS>") invalid number of fields (got 1 expected 5)

Steps to Reproduce (for bugs)
Using a config file
htpasswd_file = "/etc/oauth2_proxy/htpasswd"

Note that it successfully authenticates, but doesn't advance passed the login page.
Everything was working on version v2.0.0 and the only thing that changed was the upgrade to v3.1.0

Version used:
oauth2_proxy --version
oauth2_proxy v3.1.0 (built with go1.11)

session state format has changed in this fork ... but for some explanation of the problem and type of fix see https://github.com/ploxiln/oauth2_proxy/pull/1


Add BitLocker write protection checks for mounted drives

Fixes #345
I searched the repository for Mount- to find all attempts to mount a drive and added the snippet to check for the BitLocker key just before each time. I then revert the change at the end of each function.
I also added a verbose message to resources.psd1.

Hi @sk82jack - looks good! Would you also mind adding a note to the unreleased section of the ChangeLog.md?

No problem - will get something added in shortly


Fixed the issue with IndexOutOfBound in Java 23

After installing Java 23, I saw an IndexOutOfBound exception when calling org.jnetpcap.Pcap.findAllDevs(). Tracing it, the issue was attributed to how the varHandle in org.jnetpcap.SaLayout.get(MemorySegment) was being used to fetch data from a reinterpreted union memory segment.
Comparing MemorySegment and related classes of Java foreign memory access between Java 22 and 23, I found out this is an extra check put in place in Java 23 which enforces proper memory mapping for unions from Java side.
This fix is tested on many usecases and passes them all and allows me using the library with Java 23.

Thank you for the catch and contribution. I'm checking it now.

@arisona What Linux distro are you using?
Inspecting the code, I see haLen is extracted from the received packet (at SockAddr:321).
Can you confirm the packet is well-formed and has consistent data?
Maybe, a safety boundary check is needed here as this info is being extracted from the network data.

Have you identified those other places?
Is there any test to ensure compatibility?

Threre is a signinifact difference in implementation between JDI 22 and JDK 23 of MemoryLayout{.varHandle(..), select(...).varHandle()). I've identified the issue and know how to fix it.  I will put in place proper tests to ensure we keep track of changes in the underlying implementation between JDK's for FMMs.
I think the implementers took a too big of a leap in termrs of implementation differences between the JDKs in FFM functionality. I think they took a big leap hoping it would't cause too many issues for the early adpoters, but it has. JLink probably abstract those differences away, but that is something we can't rely on currrently,  in preview JLink feature phase.
In anycase. I've identified the issue, as follows:
Debug dump under JDK 22.
		MemorySegment mseg = Arena.ofAuto().allocate(PCAP_IF_LAYOUT);
		mseg.fill((byte) 1);

		for (long i = 0; i < mseg.byteSize(); i++) {
			mseg.set(JAVA_BYTE, i, (byte) i);
		}

		System.out.println(PcapUtils.toHexCurleyString(mseg.asByteBuffer()));

		System.out.printf("PcapIf::static addresses=%d/%d"
				+ "%nVarHandles(addresses)=%n  %s%n  %s"
				+ "%nADDR(addresses)=%n  %s%n  %s"
				+ "%n",

				PCAP_IF_LAYOUT.select(path("addresses")).byteOffset(),
				PCAP_IF_LAYOUT.byteOffset(path("addresses")),

				PCAP_IF_LAYOUT.select(path("addresses")).varHandle(),
				PCAP_IF_LAYOUT.varHandle(path("addresses")),

				PCAP_IF_LAYOUT.select(path("addresses")).varHandle().get(mseg, 0),
				PCAP_IF_LAYOUT.varHandle(path("addresses")).get(mseg, 0)

		);

With the following output:
00:01:02:03:04:05:06:07:08:09:0a:0b:0c:0d:0e:0f:10:11:12:13:14:15:16:17:18:19:1a:1b:1c:1d:1e:1f:20:21:22:23}
PcapIf::static addresses=0/24
VarHandles(addresses)=
  VarHandle[varType=java.lang.foreign.MemorySegment, coord=[interface java.lang.foreign.MemorySegment, long]]
  VarHandle[varType=java.lang.foreign.MemorySegment, coord=[interface java.lang.foreign.MemorySegment, long]]
ADDR(addresses)=
  MemorySegment{ address: 0x706050403020100, byteSize: 0 }
  MemorySegment{ address: 0x1f1e1d1c1b1a1918, byteSize: 0 }

Hint: focus on the last ADD(Addresses) parth. The address values reported show that acutal mapping for the underlying VarHandle, as instantiated via the MemoryLayout varhandle() differs significantly between JDK 22  and JDK 23  since the MemoryLayout.select(...).varHandle() works properly vs the same in JDK 22  which does not.
You can clearly see that select(...).varHandle() vs varHandle(...) are not compatible and they map to different structure memory regions. Under JDK 22, varHandle(....path) propertly matches the region offset but not under JDK 23 (bacause of byt elignment constratins). So the select(...path) in JDK 23 turns out to be simply a work-around, the fact that layout is not properly aligning to C struct padding and alignment constraints.
In anycase, I will ensure that jnetpcap-wrapper  and all the related modules (and there are tons of classes) handle the MemoryLayout properly, offset and alignment properly in all JDKs. This is actually fixed with proper, explicit, byte alingnment for the various C structured modled by jnetpcap*.
Lastly, I am adding new unit test cases to handle the fix, but also testing with various MacOs/Linux/Windows platforms in JDK 21 LTS, JDK 22, JDK 23 early-access and JDK 24..  This is an issue we will need to keep close tabs on for the forseeable future.

@arisona What Linux distro are you using?
Inspecting the code, I see haLen is extracted from the received packet (at SockAddr:321). Can you confirm the packet is well-formed and has consistent data?
Maybe, a safety boundary check is needed here as this info is being extracted from the network data.

@hamid-nazari I'm on Debian Bookworm, AArch64 on an RPI 4. I don't think that this is from a received packet, since all I'm doing is Pcap.findAllDevs(), which then unwraps the device list and addresses returned by the native pcap function.
Anyway, I think I'll be holding on until @SecureNetWizard's fixes are in. Will be happy to test on Linux (RPI 4) and macOS (also AArch64). I'm not doing much than opening a device and send / receive raw ethernet packets though, so my test coverage won't be that big.

@SecureNetWizard Thanks for this detailed analysis of the differences in FFM between Java 22 and 23.
I could not find any handy reference to this semantic change in FFM handling memory alignment until I went on to compare the source code of JDK 23 to that of 22. Then I saw how MemoryLayout.select(..).varHandle() behaves differently from VarHandle.varHandle(..) under the hood.
I do agree with @arisona that I'd wait for your mods and checks to complete, and hence I think it would be better to close this PR in favor of the upcoming release.

I have found the root cause of the failures. The fix is in the branch bug-57-jdk23-memory-layout-access. I need to do more testing, but its working correctly under various JDKs as of right now.

PathElement.sequence() seems to be no longer supported without the 0 parameter PathElement.sequence(0). We must index the first element, this was not a requirement in JDK 22.

When creating a VarHandle using a large layout, the memory segment must be the size of the entire original layout, even if you are accessing just a portion of it such as using a union. The VarHandle seems to check the full boundary with the assumption of that the entire layout in size, is present in the MemorySegment. That's why doing the select(...).varHandle() call worked in JDK 23 because the select returned a subset of the larger layout and then created the handle. With the JDK 22 way varHandle(...) the VarHandle offset and boundary checking is performed on the entire layout and not the subset. This behaviour is different from JDK's 22.

In anycase, I will be keeping tabs on this, as apparently the foreign memory package, keeps changing and evolving even though it was supposed to be stable now after 2 incubator and 3 preview releases. Apparently not.
I will do a maintenance release in a couple of days. I want to make sure it all works and there are no other issues I am not away of part of the these same changes in the FFM implementation.


Update SDHI-ServiceModuleSystem-v3.0.ckan

Matching current KSP version number

Passes locally. Merging with my thanks.


Bridge.net does not work on web worker

Version
17.0.0
Description
Loading bridge.js  from a web worker throws the following exception:
VM29:1 Uncaught ReferenceError: window is not defined
    at eval (eval at <anonymous> (bridge.js:2016), <anonymous>:1:1)
    at bridge.js:2016
    at bridge.js:2026
    at bridge.js:41320
    at kustoWorker.js:46
    at Function.t._safeInvokeFunction (workerMain.js:24)
    at Function.t._invokeFactory (workerMain.js:24)
    at t.complete (workerMain.js:24)
    at s._onModuleComplete (workerMain.js:34)
    at s._resolve (workerMain.js:34)

Blame seems to lie on this specific line
this specific line that tries to access window (which isn't valid in web worker)
this used to work on an earlier version.

Hi @lidermanrony. Looks like this was fixed in #3561 and will be available in the upcoming Bridge 17.1.0 release.
https://github.com/bridgedotnet/Bridge/pull/3562/files#diff-f1ef03b5078e642f9466d74dd667398dR2000

Thanks @geoffreymcgill.
Is there some intermediate Nuget package i can install that contains this fix?
How far away is 17.0.1?


fix: jira test connection api

fix #1734
⚠   Pre Checklist

Please complete ALL items in this checklist, and remove before submitting

[ ] I have read through the Contributing Documentation
[ ] This PR is using a label (bug, feature etc.)
[ ] My code is has necessary documentation (if appropriate)
[ ] I have added any relevant tests
[ ] This section (⚠   Pre Checklist) will be removed when submitting PR

Summary
#1734
Key Points

[ ] This is a breaking change
[ ] New or existing documentation is updated

Screenshots
Before

After

Other Information
Any other information that is important to this PR.

Nice! how about adding the 403 status code checking and producing a meaningful error message as well?

Maybe, but I'm confused wether the result returned by jira meaning authentication failed. Can we suppose it is an authentication error if the api failed? Or how can we judge the error message. @klesh

If we cannot confirm the authentication error, I think return the original error message is also acceptable.

@narrowizard Aah, sorry, it was 401, with 401, we can be sure that token is invalid, right?


Problem with userDir when re-running locally (dir already exists)

Hello Fellows,
When running locally the fs.mkdirSync try to create the userDir on every start of the application.
Please, insert a check if the userDir already exists before create it on file bluemix-settings.js.
Regards,
Bernardo Baumblatt

Excelente


Not an issue - TEsted working with LG Ducted

My LG Units are a 17.1kW Ducted
B55AWYU3G5 - Indoor Unit
and
ABUW55G7SB0 - Outdoor UNit
and I have installed myself a PREMTB100 controller.
My PCB is sitting on a jumper wire to the PREMTB100 controller
Everything seems to be working just fine right now!
I've disabled the LG Wifi dongle now as it seems to make the integration a little flakey - which is expected as the LG dongle is itself a little flakey, to the point where we couldn't rely upon it to use it from our mobiles.
Now we have your code installed, it's rock solid :-)
Thankyou!
here's hoping I get time to help out

Thanks! I added it to the list. Good to hear it works with ducted units too.
Are there things you still use the PREMTB100 for because they're not supported by the controller? Maybe zone control?

Thanks! I added it to the list. Good to hear it works with ducted units too.
Are there things you still use the PREMTB100 for because they're not supported by the controller? Maybe zone control

We use the controller for a quick easy override / kids can control it.
still haven't fully adopted Home Assistant everywhere,
plus it looks good on the wall.
I'm not using the zone control - which is supported, but plan to hook up our 3 zones and add more in the future.

I'm not sure if this is the right place to ask, but I have an LG air conditioning system that it is built into my apartment, almost like a "central" system (I believe it is a "ducted" system just like @bleughb's). Unfortunately, this means that I have no idea what my indoor or outdoor units are; all I know is that my thermostat is an LG PREMTB10U, and it has 3 wires - power, ground, and signal.
My understanding is that the usual use case of this community is with an LG wall-mount unit, connected to an outdoor unit, which supports a device like the PREMTB10U via the CN-REMO connection. However, most people do not have such a thermostat/remote installed by default, so they open up the indoor/wall unit and connect this device instead.
So, I am hoping that I should be able to replace my PREMTB10U with this project's PCB, pretty much exactly as it seems @bleughb has done. Does that sound right - that I could simply connect the same 3 wires from my PREMTB10U (power, ground, signal) to this project's PCB, and it would work?
I know you can't guarantee anything, of course, but what do you think? Anyway, thank you so, so much @JanM321 for your tremendous work on this project!!!

I am hoping that I should be able to replace my PREMTB10U with this project's PCB, pretty much exactly as it seems @bleughb has done. Does that sound right - that I could simply connect the same 3 wires from my PREMTB10U (power, ground, signal) to this project's PCB, and it would work? I know you can't guarantee anything, of course, but what do you think?

I expect that to work. For what it's worth, in issue #1 someone else replaced a PREMTB10U controller with the PCB.
Some of the LG controllers also support an older protocol for which there is an ESPHome implementation here, but I hope my project will work. The hardware side is the same, it's just a completely different message format.

Regardless, thank you so, so much @JanM321 for your tremendous work on this project!!!

 Please let me know if it works :)


ref(pkg/catalog) : Use the same catalog APIs to build inbound and outbound traffic policies for SMI and permissive mode

Description:
The PR gets rid of the ListPoliciesForPermissiveMode API and includes
the permissive mode logic within the ListInboundTrafficPolicies and ListOutboundTrafficPolicies
API's respectively.
Unit tests have also been updated as a part of this PR.
Fixes #2598
Signed-off-by: Sneha Chhabria<EMAIL_ADDRESS>Affected area:

New Functionality      [ ]
Documentation          [ ]
Install                [ ]
Control Plane          [X]
CLI Tool               [ ]
Certificate Management [ ]
Networking             [ ]
Metrics                [ ]
SMI Policy             [ ]
Security               [ ]
Tests                  [ ]
CI System              [ ]
Performance            [ ]
Other                  [ ]

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? no

Codecov Report

Merging #2614 (29c2b8b) into main (8a19278) will increase coverage by 0.53%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2614      +/-   ##
==========================================
+ Coverage   63.20%   63.74%   +0.53%
==========================================
  Files         154      152       -2
  Lines        7189     7102      -87
==========================================
- Hits         4544     4527      -17
+ Misses       2628     2558      -70
  Partials       17       17

Flag
Coverage Δ

unittests
63.74% <66.66%> (+0.53%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/cli/install.go
65.82% <ø> (+0.19%)
:arrow_up:

cmd/osm-controller/osm-controller.go
16.12% <ø> (-0.68%)
:arrow_down:

pkg/catalog/mock_catalog_generated.go
0.00% <0.00%> (ø)

pkg/configurator/methods.go
61.90% <0.00%> (-1.51%)
:arrow_down:

pkg/configurator/mock_client_generated.go
0.00% <0.00%> (ø)

pkg/configurator/validating_webhook.go
80.00% <ø> (+3.44%)
:arrow_up:

pkg/featureflags/featureflags.go
100.00% <ø> (ø)

pkg/envoy/lds/response.go
61.01% <66.66%> (ø)

pkg/envoy/rds/response.go
69.23% <75.00%> (+40.46%)
:arrow_up:

pkg/catalog/routes.go
80.81% <100.00%> (+0.15%)
:arrow_up:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f05f4...29c2b8b. Read the comment docs.


Unnecessarily large dependency

Rosetta Go SDK depends on go-ethereum: https://github.com/coinbase/rosetta-sdk-go/blob/9ba330f0a51ab41c1c8738a040eb2b28894b82d9/go.mod#L13 which is a fairly large dependency.
The only thing used from go-ethereum appears to be secp256k1 signing: https://github.com/coinbase/rosetta-sdk-go/blob/9ba330f0a51ab41c1c8738a040eb2b28894b82d9/keys/signer_secp256k1.go#L21

want to echo this, the core parts of the Rosettas-sdk-go should live separate from custom implementations as the core part is a dependency for projects not housed in here.

@tomtau we will maintain a stripped version of essential items here https://github.com/cosmos/rosetta-sdk-go. I opened a pr with only the items that are required as dependencies

It's also worth noting that the code in go-ethereum/crypto (no-cgo version) uses "github.com/btcsuite/btcd/btcec/v2", which is actually a rather thin wrapper around "github.com/decred/dcrd/dcrec/secp256k1/v4".
e.g. go-libp2p was recently update to go straight to the source for secp256k1 with no unneeded dependencies: https://github.com/libp2p/go-libp2p/pull/1689
Going pure-Go (dropping cgo) might actually be a win for rosetta-sdk-go in terms of simplifying the build toolchain and gaining reproducible binaries.


Gaze not keeping process alive?

I'm using io.js v1.5.1 with gaze v0.5.1.
The globs are spec/**.coffee and src/**.coffee and both have matches.
Done, without errors. is logged immediately after I call gaze(...).
Have you seen this problem before? Thanks.

Mind posting a full code example I could try?

I should have mentioned I'm attempting to use gaze(...) in a Grunt task.
I assumed gaze would keep the process open for me.
My solution is to call this.async() to keep the task running forever.
Sorry bout that! :v:


OpenMS improvements (MetaProSIP, etc)

Adding the memory is necessary on our cluster and should not hurt otherwise.
The prefix is important for downstream analyses and should be known by the user.

@bernt-matthias you can also just export the ENV var:  _JAVA_OPTIONS: -XX:MaxPermSize=2G -Xmx6G -Xms1G -Djava.io.tmpdir=/data
That does the trick in our case and do not involve tool-hacking.

Added missing r-gplots requirement to openms_MSGFPlusAdapter.
Extended output label of some tools to include the file type.

@bgruening do you agree that the default output label should be  ${tool.name} on ${on_string}: ${FORMAT} if the tool has multiple outputs?
@bgruening just checking the java suggestion .. thanks.

The focus of the PR suddenly changed to MetaProSIP. The program creates a variable number of images and score files which are currently ignored by Galaxy. Our users need this data: so I would implement this.
I'm wondering if this should be implemented as data collection or just as a zip file... any preferences? Our users spontaneously voted for the zip file.
A data collection would be fancy if one could download them as zip.

@bgruening do you agree that the default output label should be ${tool.name} on ${on_string}: ${FORMAT} if a tool has multiple outputs?

This is better then before, but I would prefer a more content associated description. So what is included and not what is the name of the XML file. Not sure everyone knows the differences.

A data collection would be fancy if one could download them as zip.

Data collection, not zip! Galaxy will fix the download of collections soon.

I would prefer a more content associated description

I'm not an expert of the software/method :) Is there some docs that could help me. Otherwise I could discuss with the users here.

Me either.  Its a good improvement. At some point if we have a lot Proteomics users we make a Codefest and improve usability.

Here is a first suggestion for the integration of the image output of metaprosip.
If png/svg is chosen as format MetaProSIP writes a html file which is added as data set. Links to the files seem to work (but for svg they are shown only if the output is shown in a separate window or in the download that is available).
For pdf files MetaProSIP generates no web page. So I integrated them as collection.
Since image generation seems to need a considerable time one could also make this optional.

Maybe also add some more details here:
https://planemo.readthedocs.io/en/latest/writing_advanced.html#cluster-usage
https://galaxyproject.org/admin/config/galaxy_slots/
?

So. More or less finished. Also added some tests. Found small test data at https://github.com/OpenMS/OpenMS/tree/develop/src/tests/topp and the test calls here https://github.com/OpenMS/OpenMS/blob/8fa312ff8d6d5e97aa778283e9ec0d95750d6c5e/src/tests/topp/CMakeLists.txt. Unfortunatelly the test currently fails, probably because the defaults implemented in Galaxy and the values in the command line tools differ (or the test data is for a newer version). Should I just regenerate the test outputs?
I also stumbled over MzMLSplitter which did not work at all and fixed it. Also here the test is not working .. and I don't know why. There is some errors indicating that mzml file extension is expected but its MzML ... any suggestions?

Just verified that the defaults specified by MetaProSIP --help and the galaxy defaults are the same...

@bernt-matthias I will look at it, but can you please add the test data as well?
These tools are in such a bad shape but we would need to spend so many time on fixing these .... :(

added the test data

@bgruening I have enabled the threads parameter which seems to be available for all 4 tools
The quality of the tools will progress over time... :)

@bernt-matthias with our help I'm sure! I'm just a little bit worried about the next regenerate/merge, but this is a good thing :)

will this go automatically to the toolshed?

In general yes, but as OpenMS do not have tests and takes it does not work. I upload them right now, just not sure if WifiOnICE is really capable of that :)

Done! Its on the TS!


fix: token creation in all flows

Problem statement
When testing this
token: f62a4d061f03ebe8b0ba8db8d010c988
command generated:
{"level":"info","ts":"2023-04-04T18:51:26.251Z","caller":"etcdmain/etcd.go:73","msg":"Running: ","args":["/usr/local/bin/etcd","--data-dir=/var/etcd/data","--name=etcd-cluster-c9nqcdk5vp","--initial-advertise-peer-urls=http://etcd-cluster-c9nqcdk5vp.etcd-cluster.etcd.svc:2380","--listen-peer-urls=http://<IP_ADDRESS>:2380","--listen-client-urls=http://<IP_ADDRESS>:2379","--advertise-client-urls=http://etcd-cluster-c9nqcdk5vp.etcd-cluster.etcd.svc:2379","--discovery=https://discovery.etcd.io/68898fb7-f5b3-4a58-ac13-52c5fe462544"]}
Which lead to a failed cluster
{"level":"warn","ts":"2023-04-04T18:51:26.391Z","caller":"etcdmain/etcd.go:146","msg":"failed to start etcd","error":"failed to join discovery cluster (discovery: bad discovery endpoint)"}
{"level":"warn","ts":"2023-04-04T18:51:26.391Z","caller":"etcdmain/etcd.go:181","msg":"failed to bootstrap; discovery token was already used","discovery-token":"https://discovery.etcd.io/68898fb7-f5b3-4a58-ac13-52c5fe462544","error":"failed to join discovery cluster (discovery: bad discovery endpoint)"}
{"level":"warn","ts":"2023-04-04T18:51:26.391Z","caller":"etcdmain/etcd.go:186","msg":"do not reuse discovery token; generate a new one to bootstrap a cluster"}

Logs when testing with the PR image
[
    {
        "level": "info",
        "ts": "2023-04-05T19:58:22.848Z",
        "caller": "embed/etcd.go:306",
        "msg": "starting an etcd server",
        "etcd-version": "3.5.7",
        "git-sha": "215b53cf3",
        "go-version": "go1.17.13",
        "go-os": "linux",
        "go-arch": "amd64",
        "max-cpu-set": 4,
        "max-cpu-available": 4,
        "member-initialized": false,
        "name": "etcd-cluster-qgjnddndsh",
        "data-dir": "/var/etcd/data",
        "wal-dir": "",
        "wal-dir-dedicated": "",
        "member-dir": "/var/etcd/data/member",
        "force-new-cluster": false,
        "heartbeat-interval": "100ms",
        "election-timeout": "1s",
        "initial-election-tick-advance": true,
        "snapshot-count": 100000,
        "max-wals": 5,
        "max-snapshots": 5,
        "snapshot-catchup-entries": 5000,
        "initial-advertise-peer-urls": [
            "http://etcd-cluster-qgjnddndsh.etcd-cluster.etcd.svc:2380"
        ],
        "listen-peer-urls": [
            "http://<IP_ADDRESS>:2380"
        ],
        "advertise-client-urls": [
            "http://etcd-cluster-qgjnddndsh.etcd-cluster.etcd.svc:2379"
        ],
        "listen-client-urls": [
            "http://<IP_ADDRESS>:2379"
        ],
        "listen-metrics-urls": [],
        "cors": [
            "*"
        ],
        "host-whitelist": [
            "*"
        ],
        "initial-cluster": "etcd-cluster-qgjnddndsh=http://etcd-cluster-qgjnddndsh.etcd-cluster.etcd.svc:2380",
        "initial-cluster-state": "new",
        "initial-cluster-token": "https://discovery.etcd.io/d2cd6ed8b6f248ae29dd0be06520a623",
        "quota-backend-bytes":<PHONE_NUMBER>,
        "max-request-bytes": 1572864,
        "max-concurrent-streams":<PHONE_NUMBER>,
        "pre-vote": true,
        "initial-corrupt-check": false,
        "corrupt-check-time-interval": "0s",
        "compact-check-time-enabled": false,
        "compact-check-time-interval": "1m0s",
        "auto-compaction-mode": "periodic",
        "auto-compaction-retention": "5m0s",
        "auto-compaction-interval": "5m0s",
        "discovery-url": "https://discovery.etcd.io/d2cd6ed8b6f248ae29dd0be06520a623",
        "discovery-proxy": "",
        "downgrade-check-interval": "5s"
    },
    {
        "level": "info",
        "ts": "2023-04-05T19:58:22.855Z",
        "caller": "etcdserver/backend.go:81",
        "msg": "opened backend db",
        "path": "/var/etcd/data/member/snap/db",
        "took": "5.846786ms"
    },
    {
        "level": "info",
        "ts": "2023-04-05T19:58:23.225Z",
        "caller": "v2discovery/discovery.go:336",
        "msg": "found self from discovery server",
        "discovery-url": "https://discovery.etcd.io",
        "self": "10b80af31e8c0799"
    },
    {
        "level": "info",
        "ts": "2023-04-05T19:58:23.225Z",
        "caller": "v2discovery/discovery.go:352",
        "msg": "found peers from discovery server; waiting for more",
        "discovery-url": "https://discovery.etcd.io",
        "found-peers": 1,
        "needed-peers": 2
    }
]


Allow running without postgres installed

Is your feature request related to a problem? Please describe.
Remove postgres as a runtime dependency, allow user to not connect to a db

Did anyone end up taking this one?

Not that I know of! PRs welcome! As well as review on the proposed model in #59


Incorrect tabbing order observed on the new tile card appeared in the page and not focusable through tab key after the message was sent

Steps to reproduce
Description
With Voice - When user navigate to the input field and type "request feedback", he would get a message card.-> Observe that, new tile card appeared on the page after the message was sent, but keyboard focus is not moving to the new tile card's actionable element which is incorrect tabbing order. Also it did not announce the title of the card and missed the 'Request Feedback' label name when getting the message card.
Video
https://github.com/MicrosoftDocs/msteams-docs/assets/25132507/05da27aa-7d51-476b-8571-1d57ef8a6776
Card Json
{
          "$schema":  "http://adaptivecards.io/schemas/adaptive-card.json",
          "type":  "AdaptiveCard",
          "version":  "1.5",
          "body":  [
                    {
                              "type":  "TextBlock",
                              "text":  "I found this quick action for you to proceed with the task:",
                              "wrap":  true,
                              "size":  "Medium"
                    },
                    {
                              "type":  "ActionSet",
                              "spacing":  "ExtraLarge",
                              "actions":  [
                                        {
                                                  "type":  "Action.Submit",
                                                  "tooltip":  "Request Feedback",
                                                  "title":  "Request Feedback",
                                                  "data":  {
                                                            "msteams":  {
                                                                      "type":  "task/fetch"
                                                            },
                                                            "ref":  "REQUEST_FEEDBACK",
                                                            "requestType":  "command",
                                                            "namespace":  "worktech-feedback",
                                                            "selectUserId":  "802989",
                                                            "step":  "requestFeedbackFormStep",
                                                            "command":  "RequestFeedback"
                                                  }
                                        }
                              ]
                    }
          ],
          "msteams":  {
                    "width":  "Full"
          }
}

Expected behavior
Ensure that tabbing order should be in the logical reading order. After the message sent, focus should move to new tile card's actionable element and should be accessible with keyboard and read out by screenreader along with the label name,
Actual behavior
Keyboard focus is not moving to the new tile card's actionable element which is incorrect tabbing order and the title of the card 'Request Feedback' is announced when getting the message card.
Error details
No response

Hello @liuguangyicao - Thanks for raising your query.
We will look into it and let you know the updates.

Hello @liuguangyicao
Sorry for the delay in response,
We have raised a bug for the same. We will inform you once we get any further update from engineering team.
Thanks!!

Hi @liuguangyicao, we got update from engineering team stating that, they are able to navigate through the card via tabbing and there is no title to the card - additionally, we only honor the speak property for narration if developer wants to add specific text to be read out when the card receives focus.


[1.1.2] Check if request is aborted before verifying response bytes written (#1376)

#1376

Is this just a backport of another fix? I couldn't find the corresponding PR to dev

@natemcmaster dev PR: https://github.com/aspnet/KestrelHttpServer/pull/1499

Whats the deal with travis and appveyor

This good to go in? CI seems happy. Do we have enough sign-offs?


Pressing 'n' in textarea elements opens the namespaces filter

Setup

Rancher version: master-528d7d94c
Browser type & version: any

To Reproduce

Go to local -> Storage -> ConfigMaps
Create a new ConfigMap
Add a new entry in Data form
Select the value field and press 'n'

Additional Info
This is a regression of https://github.com/rancher/dashboard/pull/7267

Closed as not reproducible.


roux_stream is incompatible with roux v2.0.0 and higher.

The examples provided in the docs are not compatible with the latest version of roux, the highest version which is compatible is v1.4.0.

Even when i downgrade i seem to have this issue. maybe i'm missing something. +1 over here though.

would this require a lot of changes?

https://github.com/torfsen/roux-stream/pull/11

Fixed by #7 but not yet released.

Released in 0.2.0.


let in select has a bad error

when we have a let in select we should print a nicer error

The current error is:
Error:
    6 |
    7 | select
    8 | let a = event.foo;
      | ^^^ Found the token `let` but expected one of `!`, `\``, `$`, `(`, `+`, `-`, `<ident>`, `[`, `absent`, `args`, `bool`, `event`, `float`, `for`, `group`, `heredoc`, `int`, `match`, `merge`, `nil`, `not`, `patch`, `present`, `recur`, `state`, `window`, `{`
      |     NOTE: Did you mean to use `!`?
    9 | from in into out;
   10 | # select event from foo/err into out/err;

Is this the bad error reported here? Or can we consider this issue fixed?

this has improved since


Consider supporting below variants of a diacritical by pressing the corresponding dead key twice

Moving combining diacriticals to Ctrl + diacritical would allow to support 'below' variants of diacriticals by pressing the corresponding dead-key twice, as recommended by the standard.

After reading the standard thoroughly I realize that this feature is only available for the BÉPO layout.


Plugin Issues with Creds

After I create a new SQS location and get the Creds drop down it is blank.  I try to do an add form there and the add works but the drop down still shows none.

When you create the credentials are you using AWS Credentials type or Secret Text type?  If you're using AWS Credentials; you need to create it as a Secret Text type and it will show in the drop-down.  The problem I'm having is what format should the secret be in?  I tried JSON but that doesn't work.

I've faced the same issue and I've found how it's done. In the file
/src/main/java/io/relution/jenkins/awssqs/SQSTriggerQueue.java  you can see the method is being used to get credentials from Jenkins:
(lines 117 to 120)
           } else {                 this.accessKey = scresult.getId();                 this.secretKey = scresult.getSecret();             }
I've managed to configure it using a secret text credential. Use the ID for access key and the secret for the secret access key.
The only other caveat I've found is that the region has to be us-east-1, so you need to have your SQS queue in there for the plugin to work.


Refactor libkv to not directly import storage backends

fixes #49
@mavenugo Is that what you had in mind? I managed to update libkv Godeps in swarm without boltDB thanks to this (see the README). If you have a better approach let me know :smile:
Signed-off-by: Alexandre Beslic<EMAIL_ADDRESS>

:+1:
@abronan yes, this is exactly what I meant in #49.

Perfect! Including the change then, hope this is helpful on your side as well :)


webpack: Fix CSS source map generation on 1-CPU systems

Fixes #18727.

Can you add a bit of explanation to the commit message?

Please backport this to the 4.x branch once you've merged it.


Provide default actions for new HiWis

When I first login to the system as a new user / HiWi (i.e. I don't have any projects and am not part of a chair yet) I am currently shown the dashboard with a list of available research groups.
However, my first main activity should be to apply to a project.
In the right column new HiWis (who are not yet part of a project) should be shown a 'Apply for your project', which links to the list of projects (/projects) where the apply button can be clicked.

Done with #390 & #361
HiWis no longer apply to chairs and projects but are instead simply added.