Not getting the implementation suggestions with parse error

Expected behavior
Should get the implementation suggestion if the validation error is displayed
Actual behavior
Lists validation error but not the implementation suggestion
Steps to replicate

create a project gauge init java
use the following spec

Specification Heading
=====================

This is an executable specification file. This file follows markdown syntax.
Every heading in this file denotes a scenario. Every bulleted point denotes a step.

To execute this specification, run
	gauge specs

* Vowels in English language are "aeiou".
* sdf <abc>

Vowel counts in single word
---------------------------

tags: single word

* The word "gauge" has "3" vowels.
* sdf "def"
* sdf

Vowel counts in multiple word
-----------------------------

This is the second scenario in this specification

Here's a step that takes a table

* Almost all words have vowels
     |Word  |Vowel Count|
     |------|-----------|
     |Gauge |3          |
     |Mingle|2          |
     |Snap  |1          |
     |GoCD  |1          |
     |Rhythm|0          |

run the specs. We do not get the suggestion.

Version
Gauge version: 0.9.2.nightly-2017-08-30
Commit Hash: b0fda9f

Plugins
-------
csharp (0.10.1)
java (0.6.5.nightly-2017-08-29)
ruby (0.4.1)
spectacle (0.1.2)
xml-report (0.2.0)

Fix should be available in gauge nightly > 31/08/17

The following are the various types of parse errors

[ ] Step is not defined inside a concept heading
[ ] Table doesn’t belong to any step
[ ] Scenario heading is not allowed in concept file
[ ] Concept should have at least one step
[ ] Concept heading can only have dynamic parameters
[ ] Duplicate concept definition found
[ ] Teardown should have at least three underscore characters
[ ] Table location not specified
[ ] Scenario heading should have at least one character
[ ] Table header should be not blank
[ ] Table header cannot have repeated column values
[ ] Multiple spec headings found in the same file
[ ] Scenario should be defined after the spec heading
[ ] Could not resolve table from file
[ ] Spec does not have any element
[ ] Spec heading not found
[ ] Spec heading should have at least one character
[ ] Data table should at least have 1 data row
[ ] Dynamic param could not be resolved
[ ] Step should not be blank
[ ] Circular reference found in concept
[ ] Duplicate scenario definition found in the same specification

Works with
Gauge version: 0.9.2
Commit Hash: edea1eb

Plugins
-------
html-report (4.0.2.nightly-2017-08-07)
java (0.6.5.nightly-2017-09-01)

Output :
$ gauge run specs
[ParseError] /tmp/795/specs/example.spec:12 Dynamic parameter <abc> could not be resolved => 'sdf <abc>'
[ValidationError] /tmp/795/specs/example.spec:12 Step implementation not found => 'sdf <abc>'
[ValidationError] /tmp/795/specs/example.spec:20 Step implementation not found => 'sdf "def"'
[ValidationError] /tmp/795/specs/example.spec:21 Step implementation not found => 'sdf'
Add the following missing implementations to fix `Step implementation not found` errors.

	@Step("sdf <abc>")
	public void sdf(Object arg0){
		throw new UnsupportedOperationException("Provide custom implementation");
	}

	@Step("sdf")
	public void sdf(){
		throw new UnsupportedOperationException("Provide custom implementation");
	}
Successfully generated html-report to => /tmp/795/reports/html-report
Specifications:	1 executed	0 passed	1 failed	0 skipped
Scenarios:	0 executed	0 passed	0 failed	0 skipped

Total time taken: 11ms


fatal scalariform error on first project load

I get the following error after loading a project generated by fresh (0.2.3) for the first time
[error] /Users/caoilteoconnor/scala/test/project/Build.scala:33: value autoImport is not a member of object com.typesafe.sbt.SbtScalariform
[error]     SbtScalariform.autoImport.scalariformPreferences := SbtScalariform.autoImport.scalariformPreferences.value
[error]                    ^
[error] one error found
[error] (compile:compileIncremental) Compilation failed

I ran fresh with a brew installed 0.13.7 on a mac.

Please use sbt 0.13.9 and let me know if this help.

yeah that works. I didn't realise there were such backward incompatible changes in the last few releases. apologies.


Fixed jewelery option level multipliers for max Ability and Mana increase

Calculations of Max Ability and Mana increase for jewelery was multiplying by values 1.01/2.02/3.03/4.04 (respectively for +1%/2%/3%/4% level options). Evidence:
Screencast from 12-09-2024 11:03:33.webm
Screencast from 12-09-2024 11:17:22.webm
After fix:
Screencast from 13-09-2024 21:09:03.webm

In my opinion, this is a relatively useful and benign bug, which solves the problem of agile characters consuming mana too quickly :)

Sorry for the late reply 😅
The fix makes perfectly sense, thank you :)
Just one thing needs to be done as well: A configuration update plugin to fix existing configurations. See MUnique.OpenMU.Persistence.Initialization.Updates. We need to fix this at least for the season 6 config. To add a new update plugin:

Add a new enum value in UpdateVersion.
Implement a new plugin by inheriting from UpdatePlugInBase.

Can you add that please?

@sven-n , all set, I think :)

Thank you :)


Update nf-libloaderapi-enumresourcelanguagesexa.md

fix link
EnumResLangProc -> EnumResLangProc
Actually EnumResLangProc page should be copied to sdk-api-src/content/libloaderapi/ folder from /previous-versions/ part of the docs. Like already done with EnumResTypeProc and EnumResNameProc docs.

Hi @DJm00n - I did as you suggested and pulled the files from the archive and re-inserted them into mainline and updated links in a private PR.
Will close this PR.

@Karl-Bridge-Microsoft thanks!


[Event Request] - SalesLine.Table.al - OnBeforeInitQtyToReceive

We like to request the following Event:
Object: SalesLine.Table.al
Where is the event placed:
procedure InitQtyToReceive()
var
    IsHandled: Boolean;
begin
    IsHandled := false;
    OnBeforeInitQtyToReceive(Rec, CurrFieldNo, IsHandled);
    if IsHandled then
        exit;

    GetSalesSetup();
    if (SalesSetup."Default Quantity to Ship" = SalesSetup."Default Quantity to Ship"::Remainder) or
       ("Document Type" = "Document Type"::"Credit Memo")
    then begin
        "Return Qty. to Receive" := "Outstanding Quantity";
        "Return Qty. to Receive (Base)" := "Outstanding Qty. (Base)";
    end else
        ...
end;

Event Code:
[IntegrationEvent(false, false)]
local procedure OnBeforeInitQtyToReceive(var SalesLine: Record "Sales Line"; CurrFieldNo: Integer; var IsHandled: Boolean)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Me

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to ‘...’
Click on ‘....’
Scroll down to ‘....’
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
System Information:

OS: [e.g. Windows]
Discord Version: [eg. Stable]

Additional context
Add any other context about the problem here.

best issue ever


Security vulnerability CVE-2021-42836 (gjson)

Details: https://nvd.nist.gov/vuln/detail/CVE-2021-42836
Updating the dependency should fix the issue.

Hi @szwedm,
A new version was released - v0.9.2
Best regards,
Ido


"@" vanishes when using Modern font

[playing Beta version, as shown in the screencaps]
DOS font looks fine:

but Modern font is missing the "@" character:

I don't understand - the only difference is the font???
Using the browser's Inspect function shows that it's just using Courier New:

However, selecting that character, copying it, and pasting it into anything else gives me a ▓ glyph, not a @, so there really is a problem in the code somewhere.

Ahh, yes that's actually intentional although possibly not correct... You can see in player.js:20 and :131 that the @ is only used in the DOS font.
That decision was influenced by the fact that the version I played 30+ years ago used ▓ as the character, and I didn't even know that @ was the 'correct' character until I was adding the DOS font option. I fixed it for that but left the block with the modern font for mostly sentimental reasons.
On the bright side, I've already got a configuration screen on my TODO,txt list with player tile as one of the options. It might take some time, but I will get to it eventually :)


Adds Doctrine's mapping validation on Travis.

Runs doctrine:schema:validate command with database sync skipping and
no interaction flags.
This is what I usually setup in CI for my projects to avoid common Doctrine's mapping errors e.g. missing inversedBy properties.

Note that for my work project, I even remove the --skip-sync option, so that forgetting to generate a DB migration (or making a mistake in it) also makes it red.

@stof would you recommend to remove --skip-sync here too? Thanks!

it depends how you handle schema updates in the project.
Looking at the Travis config, it does not seem to be creating the schema from scratch itself with doctrine:schema:create or doctrine:schema:update, so it might make sense to ensure the sync too, if the update of the schema requires an action by the contributor.

OK. Let's merge this one as is, and when we start working with migrations, we can tweak the command. Thanks!


CORS errors during development if the code throws an exception. (example: 500-error)

Laravel Version: 10.2.0
PHP Version:  8.1.0

Description:
I still get the  CORS-error when an 500-error occurs on the server.
For example, if I make a syntax error in the code, causing the application to crash, then the headers will not be set and the browser will show CORS errors.
That is, code execution does not reach  \Illuminate\Http\Middleware\HandleCors::class in app/Http/Kernel.php if there is a 500-error
Installed clean Laravel and intentionally made a mistake in the code, and again I see the CORS-error, instead of an error message.
It is no longer possible to quickly identify the source of an error in the console during development SPA
I have to open the log file all the time, without normal highlighting

Steps To Reproduce:

install Laravel
configure CORS for your client domain
create a route

Route::get('/test', function () {
     return 111;
});

in routes/api.php

send a request from your client domain to this route
make sure everything works and there are no CORS errors
make a syntax error in routes/api.php and run the request again

result: CORS-error
expect: standard Laravel syntax error message

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.


Error: Invalid Slack response

I got the following error recently on slackin after days without any problem:
$ /usr/local/bin/slackin --interval 5000 --port 10000 domain xxxx
Thu Oct 08 2015 20:10:52 GMT+0200 (CEST) – fetching
Thu Oct 08 2015 20:10:52 GMT+0200 (CEST) – listening on *:10000
Thu Oct 08 2015 20:10:53 GMT+0200 (CEST) – ready
WARN: no logo configured
Thu Oct 08 2015 20:10:53 GMT+0200 (CEST) – online 6, total 29
Thu Oct 08 2015 20:10:58 GMT+0200 (CEST) – fetching
Thu Oct 08 2015 20:10:59 GMT+0200 (CEST) – Error: Invalid Slack response: 429
at SlackData.onres (/usr/local/lib/node_modules/slackin/node/slack.js:77:22)
at /usr/local/lib/node_modules/slackin/node/slack.js:41:17
at Request.callback (/usr/local/lib/node_modules/slackin/node_modules/superagent/lib/node/index.js:746:30)
at Request. (/usr/local/lib/node_modules/slackin/node_modules/superagent/lib/node/index.js:135:10)
at emitOne (events.js:77:13)
at Request.emit (events.js:169:7)
at IncomingMessage. (/usr/local/lib/node_modules/slackin/node_modules/superagent/lib/node/index.js:938:12)
at emitNone (events.js:72:20)
at IncomingMessage.emit (events.js:166:7)
at endReadableNT (_stream_readable.js:893:12)
Thu Oct 08 2015 20:10:59 GMT+0200 (CEST) – retrying
Thu Oct 08 2015 20:11:09 GMT+0200 (CEST) – fetching
Thu Oct 08 2015 20:11:09 GMT+0200 (CEST) – Error: Invalid Slack response: 429
at SlackData.onres (/usr/local/lib/node_modules/slackin/node/slack.js:77:22)
at /usr/local/lib/node_modules/slackin/node/slack.js:41:17
at Request.callback (/usr/local/lib/node_modules/slackin/node_modules/superagent/lib/node/index.js:746:30)
at Request. (/usr/local/lib/node_modules/slackin/node_modules/superagent/lib/node/index.js:135:10)
at emitOne (events.js:77:13)
at Request.emit (events.js:169:7)
at IncomingMessage. (/usr/local/lib/node_modules/slackin/node_modules/superagent/lib/node/index.js:938:12)
at emitNone (events.js:72:20)
at IncomingMessage.emit (events.js:166:7)
at endReadableNT (_stream_readable.js:893:12)
Thu Oct 08 2015 20:11:09 GMT+0200 (CEST) – retrying

I'm also getting this issue, seems to be a rate limit thing. Any way to fix this?

I increased the timeout to 5mn and it did the trick. Maybe it should be the default?

Is this with the latest version of slackin? In v0.6.0, there is a patch from a Slack employee that reduces the load on their servers. It may be that Slack has understandably started rate limiting the older, more resource-intensive way of doing things.

@limulus hrm it is the latest version in npm 5 days ago yes

Looks like the version on npm is not v0.6.0, per #114.

@benoitc I am getting the same error (Error: Invalid Slack response: 429...) how did you set the timeout to 5mn?

I have the same question as @purplelightsaber — slackin has recently (last two weeks) started getting 429s from Slack. Is there an easy fix for this that we could use on our ends? It's been preventing a number of people from signing up, so it'd be nice if there was a solution or workaround available.

@purplelightsaber @Xyene did you tried to increase "interval" from slackin configuration? I had same issue but increasing interval to 10000 fixed problem.

@vgrbr That was one of the things I tried — increasing the interval via -i to 30000, but that didn't resolve the issue. I'm primarily using the SVG badge, so my only idea is that perhaps slackin isn't caching the user count, and instead retrieving it every badge load.

Sorry that worked only for my local env... on now.sh I'm getting same error :(

this pr https://github.com/rauchg/slackin/pull/303 resolves this issue #354


SSO page gets into bad state if I incorrectly setup a Github connector

Repro:

Install Kalm on GKE, finished the setup steps
Login via generated email/password
Go to SSO and add a Github corrector
type in a non-existing org (I did this by accident)
Log out by clearing the cache (because I wanted to test Github SSO login)
Log in via generated email/password again
visit /sso (so I can edit the SSO settings)

Result:

Fixed in v0.1.0-rc.2. Please test and close this issue if it is fixed.

fixed in v0.1.0-rc.12


 as colorpicker is displayed badly

When browsers such as Chrome and Firefox present a proper colorpicker UI for <input type="color">, if you use .form-control on the input, it's displayed kinda weirdly.
In Chrome, the padding scrunches the actual color swatch and makes it invisible:

In Firefox, the height of the input doesn't match the height of <input type="text" class="form-control">:

Safari doesn't support color inputs, so it shows a plain text input, which looks fine.
I haven't tested on IE/Edge.
CC: @mdo

Neither IE nor Edge currently support type="color", so visually it's the same as for type="text"

There's a couple of inconsistencies with heights on elements. I've managed to fix these with a few explicit height declarations which normalizes select and input heights. This also works for input type color too.
http://www.bootply.com/NjBlSmhHNm

Hi @eliottrobson!
You appear to have posted a live example (http://s.bootply.com/render/NjBlSmhHNm), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 61, column 5 thru column 95: Attribute placeholder is only allowed when the input type is email, number, password, search, tel, text, or url.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

Revised: http://www.bootply.com/NjBlSmhHNm

@patrickhlauke Edge nowadays (version 14) supports type="color".

Agreed this needs addressing, but I don't think a fully custom (square) component like in the cross referenced PRs is the way to go. I think a modifier to accomplish something similar to that would be helpful though for the browsers that do support it.

There's been a lot of back and fourth on this issue. I would suggest removing support for the color attribute. It's glaringly broken now, and has limited browser support. I could open a PR if desired.
You can do a bit with pseudo classes, but it's still funky. Here's a pen: https://codepen.io/oktalk/pen/BRJKYd

I've resolved it in our local build by setting the same height as on <select/>
input[type=color].form-control {
    height: $input-height;
}

I fixed mine by using @gvangool's solution, but by setting the padding as 0px.
input[type=color].form-control {
    padding: 0px;
}

Since #26820, a height is added to the .form-control which solves this problem.

height: auto still results in the same bad display (1 thin line instead of rectangle), sometimes, with bootstrap 5, for .form-control-color. Screenshot (same as above)

https://getbootstrap.com/docs/5.1/forms/form-control/#color

Exactly the same control sometimes shows like this. I've seen this on multiple user devices, can't figure out why:

well, it would be good to isolate a reduced test case (without any non-bootstrap styles in the way), and trying to pin down which browsers/operating systems/etc it happens on. "sometimes" is a bit too vague to try and trouble-shoot


Fix rerunning failed conformance tests

What this PR does / why we need it:
I made a mistake in #3383 so this logic is not working properly, see https://public-prow.loodse.com/view/gs/prow-dev-public-data/pr-logs/pull/kubermatic_kubeone/3384/pull-kubeone-e2e-aws-default-install-containerd-external-v1.28.7/1836712353442304000
This PR should fix the issue by reusing the Sonobuoy directory for subsequent runs.
What type of PR is this?
/kind failing-test
Does this PR introduce a user-facing change? Then add your Release Note here:
NONE

Documentation:
NONE

/assign @kron4eg

/test pull-kubeone-lint pull-kubeone-e2e-aws-default-install-containerd-external-v1.31

/approve
/lgtm

/test pull-kubeone-e2e-aws-default-install-containerd-external-v1.31

/test pull-kubeone-lint pull-kubeone-e2e-aws-default-install-containerd-external-v1.31

/lgtm

/cherrypick release/v1.8
v1.7 requires a manual cherry-pick


Generates og:article:XXX rather than article:XXX

...which therefore fails Facebook's validation (https://developers.facebook.com/tools/debug/og/object/).
and seemingly is against the spec - http://ogp.me/#type_article
Can you confirm that 'og:article:XXX' is definitely right?
Here's the relevant validation output:
Warnings That Should Be Fixed
Extraneous Property	Objects of this type do not allow properties named 'og:article:published_time'.
Extraneous Property	Objects of this type do not allow properties named 'og:article:modified_time'.
Parser Mismatched Metadata	The parser's result for this metadata did not match the input metadata. Likely, this was caused by the data being ordered in an unexpected way, multiple values being given for a property only expecting a single value, or property values for a given property being mismatched. Here are the input properties that were not seen in the parsed result: 'og:article:published_time, og:article:modified_time'

Can you confirm that 'og:article:XXX' is definitely right?
Unfortunately I can not. I need to do more research but your concern might be legitimate.

Refactored a lot, added a tag class, tags can now decided if they want prexifing of 'og:' or not.
Created a new branch because I think this needs more testing etc.
Commit: https://github.com/chriskonnertz/open-graph/commit/a0b82c3cd7cf3c44bf56cf2adf7f2f8607fa2f40

Merged the dev branch since I am not aware of any problems.


Mapping feature

Is your feature request related to a problem? Please describe.
As a user, I would like to look to view a map of San Francisco with indicators of seismic zones, tsunami zones, and soft stories so that I can be better informed about the locations and areas I'm interested in.
Furthermore, I would like to be able to use a search box to look up an address and see if it's a soft story or located in or near a seismic or tsunami zone. A marker should appear on the map if the address is resolved correctly.
Describe the solution you'd like
A map of San Francisco ought to appear below the existing search box. It ought to be clearly marked with soft stories (as dots), seismic data (as polygons), and tsunami data (as polygons).

[ ] #72
By default, the map ought to load with:

The center of the map at: -122.463733, 37.777448*
The default zoom at: 11*
The minimum zoom at: 10.5*
The maximum zoom at: 15*
The ability for the user to pan and zoom at will across devices
The map ought to be responsive** to the size of the page.

*these may change after eg visualizing with soft story data
**possibly fluid and edge-to-edge pending design decision

[ ] #92
Additionally, the map should have:

Seismic data overlaid as polygons
Tsunami data overlaid as polygons
Soft stories overlaid as dots

[ ] #91
Lastly, we currently have a search box on the page that returns coordinates. I would like for this search box to drive the map display if a valid address is resolved. If a valid address is resolved, the following should happen:

he map will pan so that it centers on the address (?)
A map marker will be placed on the address to denote that it's "selected"
The user ought to still be able to pan and zoom at will across devices
Clicking on the map (besides map controls) or attempting another search box search will "deselect" the current address and the map marker will disappear (?)

If a valid address is not resolved, the following should happen:

Nothing should happen

Describe alternatives you've considered
N/A
Additional context
Figma design mockups etc:
https://www.figma.com/design/AGadwQcQH5kNn2D93TVOAC/Design?node-id=503-1467&t=EimJM8P94F9XtHC6-4
NOTE on implementation thus far: The styling ol the "basemap" layer itself (area colors, road colors, etc) will differ from the mockup as it's based on the defaults provided by Mapbox Standard style. The styling can be tweaked by editing a limited set of properties, which will happen after testing is done on a live version of the map.***
The limited styling described above only applies to the "basemap" layer and not the additional layers, such as the soft stories, seismic data, and tsunami data. Layers other than the "basemap" layer are more customizable.
***adjusting styling to monochrome is a possible future design ask

cc @mantuok organized requirements, old and new, here

@mjjsf, if you have the opportunity to, could you take a look at "(?)" in the description above? I made some assertions. If any of them look incorrect, please let me know.

@mjjsf, if you have the opportunity to, could you take a look at "(?)" in the description above? I made some UX assertions based on my understanding. If any of them look incorrect, please let me know.
I highlighted all the (?) statements with bold and italic text.

Thanks for confirming the assertions, @mjjsf 🙏

cc @mantuok organized requirements, old and new, here

Any feedback appreciated.


add list waf rule groups

This PR adds an entrypoint to list WAF rule groups as per https://api.cloudflare.com/#waf-rule-groups-list-rule-groups
It will contribute to implementation of #321
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

@patryk @jacobbednarz would appreciate you taking a look ... I'm creating a few PRs to update the terraform provider

what's the merge and/or release cycle for this pkg?
thanks

The change is merged following review and everyone happy with it (generally a couple of folks). A new release is cut whenever the functionality is usable in a downstream system or warrants one. Short version, as needed 🙂

@patryk this one too?

Looks good, just need to fix the merge conflict.

Could you rebase on top of current master?

@sbfaulkner should be good now

Splendid! Merged. Let me know if you need release cut, so we can upstream for Terraform.


I'm wondering whether we need these locks while trying to stake

In wallet.cpp, inside the loop that runs through all staking outputs looking for opportunities to stake a new block, we see:
    CTxIndex txindex;
    {
-->     LOCK2(cs_main, cs_wallet);
        if (!txdb.ReadTxIndex(pcoin.first->hash, txindex)) {
            LogPrint("stake", "[STAKE] skip %s:%-3d (%s CLAM) - can't read txindex\n",
                      pcoin.first->hash.ToString(), pcoin.second, FormatMoney(pcoin.first->vout[pcoin.second].nValue));
            continue;
        }
    }

    // Read block header
    CBlock block;
    {
-->     LOCK2(cs_main, cs_wallet);
        if (!block.ReadFromDisk(txindex.pos.nFile, txindex.pos.nBlockPos, false)) {
            LogPrint("stake", "[STAKE] skip %s:%-3d (%s CLAM) - can't read block\n",
                      pcoin.first->hash.ToString(), pcoin.second, FormatMoney(pcoin.first->vout[pcoin.second].nValue));
            continue;
        }
    }

The two LOCK2() calls are causing staking to hang up quite regularly, as the wallet is doing other things at the same time.
I am wondering whether we need to obtain locks before doing read-only operations on the wallet. I've tried commenting them both out, and things seem to be working fine (and staking no longer hangs for minutes at a time). But am I missing something? What's the worst that can happen if the txdb changes just as I'm trying to read it?

In Qt, this sort of situation works fine without lockers/mutexes. I'm sure boost is the same. Not sure why that's there at all unless it also locks the db from being written? Alternatively, you could lock the db during write operations elsewhere, and then use a mutex for that entire loop.

Removing those locks should be fine. It is only reading.
There's also plenty of usage in the code that implements ReadTxIndex and ReadFromDisk without applying any locks.
I'm compiling now will test if for the evening but the change looks good and should be good to push to master

dooglus,
Have you been running this live since this conversation?
If so, can we get it merged and closed?

Oops.

No, I took the locks out for a while, but I see they're back in place now. I don't know how long I tested without them since I didn't intentionally put them back in place.

@dooglus,
but I see they're back in place now.
Update?
Do we have solid evidence that this is a wise update?


feat(content-scroll): creates a scrollable region for long content

Description
Content Scroll allows you to place long content into a smaller scrollable region.
On mobile devices, the scroll region is removed and the content is displayed in full.
There are four modifiers -
contentWidth: Set width of scroll region
contentHeight: Set height of scroll region
mobileFullContent: Remove scroll region on mobile devices
listNoIndent: Remove indentation from ordered list structure
This makes it versatile enough to display general content or terms and conditions etc.
Storybook link: https://deploy-preview-496--legal-and-general-canopy.netlify.app/?path=/story/components-content-scroll--standard

Closing this one down for now....

The list styles may in the future go into a separate PR, but we need to agree on a naming convention and usage with the design team.
The scrollable region may come back as a separate component if we deem it has enough usage potential.

I added some more prompts to the documentation to try and make sure that we discuss larger pieces of work before embarking on them.


oscar.dashboard.orders.initFilterToggle is not a function

Hi,
when accessing the orders list in the dashboard the browser console is showing this error:
Uncaught TypeError: oscar.dashboard.orders.initFilterToggle is not a function
We have experienced the error in our project, but also the oscar sandbox is affected. From the code seems that the orders_list.html template initialize this:
{% block onbodyload %}
    {{ block.super }}
    oscar.dashboard.orders.initTable();
    oscar.dashboard.orders.initFilterToggle();
    oscar.dashboard.search.init();
    {% if form.errors %}
    $('#SearchModal').modal('show');
    {% endif %}
{% endblock onbodyload %}

But there is actually no function initFilterToggle() in dashboard.js

@cdicosmo thanks for the report. I'll take a look.

I just merged #1862. Thanks for the excellent bug report @cdicosmo, and thank you for fixing it @sasha0 .


NETOBSERV-1150 Console plugin columns & filters as config

Description
This PR allow sending definitions from config for:

[X] columns - default to EndTime + Src / Dst addresses

set id, name, group and helpers from texts
size from number
default selection from boolean
map to an existing filter using filter id
map value and sort functions according to field or calculated value

[X] filters - optionnal (filter bar is hidden if not set)

set id, name and hints from texts
set component type from text
map options, encoder and validation from id keywords.

It also move server and loki configs to the loaded configmap for consistency.

/!\ FYI some behaviors are still hardcoded by column id.
I suggest to slowly migrate to something more flexible according to our needs.
Dependencies
https://github.com/netobserv/network-observability-operator/pull/477
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

[x] Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
[ ] Does this PR require product documentation?

[ ] If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

[ ] Does this PR require a product release notes entry?

[ ] If so, fill in "Release Note Text" in the JIRA.

[ ] Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

[ ] If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

[x] Standard QE validation, with pre-merge tests unless stated otherwise.
[ ] Regression tests only (e.g. refactoring with no user-facing change).
[ ] No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

/lgtm


add broadcast_grf_senders and broadcast_grf_destinations in TRuntimeFilterDescription

…
What type of PR is this：

[ ] bug
[ ] feature
[ ] enhancement
[ ] others

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

https://github.com/StarRocks/starrocks/issues/4832
Add broadcast_grf_senders and broadcast_grf_destinations in TRuntimeFilterDescription to support GRF generated by broadcast HashJoin to be delivered to destinations speculatively and in the passthrought stlye.

run starrocks_fe_unittest

[FE PR Coverage check]
:heart_eyes: pass : 0 / 0 (0%)

@Mergifyio backport branch-2.2

[FE PR Coverage check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage check]
:heart_eyes: pass : 0 / 0 (0%)

[FE PR Coverage check]
:heart_eyes: pass : 0 / 0 (0%)


Getting X-Socket-Id JS error after axios version bump

Laravel Version: 8.61.0 (^8.6.11 in composer, not possible to upgrade to v9 atm)
PHP Version: 7.4.25
Database Driver & Version: MySQL 8.0.26

Description:
I am upgrading JS packages on my app (mix, webpack, purge and other stuff, which works great so far), but when I update axios from v0.18 to v0.21 (used with Laravel v8..6.11) or v0.25 (used in latest Laravel version) I get this error "Cannot set properties of null (setting 'X-Socket-Id')". I am posting this here because I don't think it's axios issue, since this is connected with Laravel Echo afaik.
Steps To Reproduce:
When I downgrade axios to v0.18 it works, but since there are some known security issues in v0.18 fixed in v0.21 I want to use at least that version (if not the latest). All issues regarding x-socket-id are several years old and I couldn't find any working solution.
This is my bootstrap.js file where Echo and axios are defined:
window._ = require('lodash');

window.moment = require('moment');

window.axios = require('axios');
window.axios.defaults.headers.common['X-Requested-With'] = 'XMLHttpRequest';
window.axios.defaults.headers.common['X-CSRF-TOKEN'] = document.querySelector('meta[name="csrf-token"]').content;

window.Pusher = require('pusher-js');

import Echo from 'laravel-echo';
window.Echo = new Echo({
    broadcaster: 'pusher',
    key: 'my-pusher-key',
    cluster: 'eu'
});

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.


Mermaid theming on dark-mode difficult to read

image of the issue

I've just pushed an update that should fix this issue. Let me know if that's not the case. Thanks for reporting!


Add Account drop-down to navbar

Description

Add a script tag to support bootstrap js.
Add a drop-down list to the navbar to view all links related to the Account.
Change the navbar structure: add margin-right to the logout button, change the bgcolor to be the same color as the logo

Screenshots

--

Additional Information
In the future, we need to change the href property of the <a> tags to point to the right pages.
Issues closed by this PR
Fix #171

🔥🔥🔥

This PR also has a conflict due to a merge so it needs to be sorted as well.

@Omeramsc

LGTM, but separate the last part (Change the navbar structure) to a separate PR (as this PR title is specifically about the Account drop-down)

I will add another PR with the other changes... Now all the changes in this PR related to the drop-down functionality.

@1Oreo

This PR also has a conflict due to a merge so it needs to be sorted as well.

Done.

Please review it again.
Notice: It looks like I did a lot of changes in the file, but it's because I used a formatting option in vs code that restructures the file.


Status query

I'm evaluating some of the options in this space for improving some of our accessibility stuff, so I'm checking in on the status:

Is this maintained? I note it has been quite some time since this was last updated.
What's the full status at this point? The README indicates it doesn't match everything in the main Humanizer implementation—is that still the case?
Do you need help and/or are you interested in contributions? (It would be a bit before I'm able to contribute anything, but again: just a status query.)

Thanks!

Hi!
I admit I have no worked on this in waaay to long. It is out of sync with the main Humanizer, though I don't know how much. Main issue is that I don't use this myself, created it at the request of a friend. He's happy with it as is so I haven't had the motivation to spend the time (I don't have) on it. I would love help getting Humanizer.Js going again and up to date!

No worries! I'll poke around more sometime in the next month or so! 👍

Thanks! I'm pretty proud of this project and do miss it 😄


Improve content pulling

The current static interval of every 5 minutes is not very satisfying and under critical circumstances quite slow.

An interval of five minutes is not slow at all for something being run 24/7 . Please explain what you would call such a “critical circumstance”.
Otherwise I will close the issue after an appropriate amount of time.

Besides urgent warnings, this is especially annoying when writing/editing content, if you can't or don't want to run a SIPA instance locally. It can take 5 minutes until your content appears online, and if you made any mistake it can take another 5 or 10 minutes to fix it and confirm the result.

@toothstone The used syntax is markdown, there are plenty of possibilities to render it in advance.
Raising the update speed to an insane amount should not be an instrument to ensure submitting correct markdown files in the first place. It is just technically not something that should be done.
Keep in mind that in the long run we might implement a live editing solution, so these inconveniences will disappear.
What exactly were the mistakes you had to fix after you commited them?

The used syntax is markdown, there are plenty of possibilities to render it in advance.
There is custom stuff in our content pages, especially the metadata header section.

Raising the update speed to an insane amount should not be an instrument to ensure submitting correct markdown files in the first place. It is just technically not something that should be done.
Sure, that was never my intention and would be a horrible design. I think a "push" solution should replace the current "pull" mechanism.

Keep in mind that in the long run we might implement a live editing solution, so these inconveniences will disappear.
I was not aware of this, and I'm not sure if such a complex feature is really desirable. But that's a different story, and not everyone will be using this, especially since git is a well known (CLI-)tool for most of us.

Yust Providence a http endpoint that can be used (with a secret token or any authentication) from a git-hook to start fetching. So you can use the hook for normal and instant updates and set the interval for periodic updates to a hour or so (just to catch the case that a update was missed because of a network error between the repo and the Installation for example).

@janLo This seems to be an elegant solution, I will stick to this.

You should use the spooler interface for this to prevent races and http timeouts when the repo is busy. Details are shown here: https://github.com/agdsn/sipa/issues/19#issuecomment-100716267


Rewrite /types/trimmed to Go

I'm submitting an ...
improvement request (usability, performance, tech debt, etc.)
Traffic Control components affected ...

Documentation (possibly)
Traffic Ops

Current behavior:
/types/trimmed is handled by Perl
Expected / new behavior:
/types/trimmed should be handled by Go.
Minimum API Version
1.1
Request Methods

[ ] GET

Minimal reproduction of the problem with instructions:
N/A

i think this should be deprecated (not rewritten to Go and a deprecation notice added to the response) because:
a. it's weird
b. you can GET /types instead and deal with the extra fields which are few

the decision to either deprecate and/or rewrite the endpoint can't be made here, but once the decision is made this issue can be closed (if appropriate)

+1 on deprecation. Specialized endpoints that only return subsets of data from other endpoints are an API smell IMO.


[Draft] Upgrade to emmet@2

An update: https://github.com/microsoft/vscode-emmet-helper/pull/32#issuecomment-586694063
Hi @octref, this PR upgrages emmet to v2 and gets rid of the old expand-full.js and @emmetio/* packages as we discussed here.
So basically what I have done is kept the public api of this package same and mapped the helper's expand, extract and parse functions to emmet@2's expand, extract and parse via emmetCompat.ts
I thought this would be the best way because people shouldn't be made to change their vscode setting for this upgrade and there are not many breaking changes.
I've added quite some types because without them I couldn't understand what's going on. Few are still missing and I've added TODO comments there. So I'm 95% sure this should work.
There are few changes in the test I would be making them clear in the github code comments.
Pending things:

Look if any cases are missing from current tests. (Update: Realized this doesn't take care of syntax profiles and also variables and it's not in the tests so missed out on that)
The newer emmet has a lot more capabilities so update the configuration's json schema and (probably?) write test for them.
The older emmet had addons, options (preferences), format etc seperate the newer has only options which has all these three. So currently what this helper is doing is VscodeConf -> OldEmmentConf -> NewEmmetConf but VscodeConf and NewEmmetConf are quite similar so VscodeConf should be made same as NewEmmetConf keeping it backward compatible.
Probably this module isn't doing much so it should be actually taken downstream and included in the vscode/extensions/emmet module. And once the vscode's conf is good it can be directly passed to the newer emmet's expand.

Closes #63703
Closes #80923
Closes #59951
Closes #71002
Closes #45724 (via this)
Closes #52345 (via this)
Closes #59172 (via this)
Closes #67971
Closes probably many more issues and hopefully doesn't open issues xD

Closing might reopen if I get back


Auth requires a service.json file. How can I get it?

like this:
https://github.com/googleapis/nodejs-vertexai/issues/197
Where can I get the service-account.json  file?

Also, you would probably enjoy carefully reading the contents that are linked the in README onboarding.
https://github.com/googleapis/nodejs-vertexai?tab=readme-ov-file#before-you-begin


IMPROVE FEEDBACK BUTTON STYLING

Describe the feature
Change CSS properties to style the feedback button
Add ScreenShots
Updated:

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

I have done the changes as you said earlier and update it
Thank you @Suchitra-Sahoo

Can you please tell me why my pic is not shown in the contribution section @Suchitra-Sahoo

@ayushkrrana don't worry it gets updated automatically in every 2-3 days. Also it will not have any impact on your gssoc contribution.

@ayushkrrana don't worry it gets updated automatically in every 2-3 days. Also it will not have any impact on your gssoc contribution.

Ok thank you

Hello, my name is still not there in the contribution section after it get updated , due to this i did not receive my Pull Shark badge
@Suchitra-Sahoo


Some properties/endpoints are not available on TMDB type

Describe the bug
Some properties/endpoints are not available from the latest npm version (0.1.5)
The ones that are not included are:

review
discover
people
find
keywords
collections

Example error
Property 'people' does not exist on type 'TMDB'
Expected behavior
The properties should be available on the type TMDB
Additional context
I'm pretty sure there is something wrong with the relase process. You can look at the code for the package here and there it looks like it includes old code.

Should be fixed now. I still need to work on getting this automated, it was a mishap on my part 😅

Thanks for being so fast! No worries. However, it looks like the .README dissapeared somewhere on the way to npm. Not that it matters too much right now but you might want to check it out before next release :)

Thanks for being so fast! No worries. However, it looks like the .README dissapeared somewhere on the way to npm. Not that it matters too much right now but you might want to check it out before next release :)
EDIT: Nevermind, looks like it has appeared now

🪄🪄🪄


add MCP server badge

This PR adds a badge for the mcp-server-tmdb server listing in Glama MCP server directory.

Glama performs regular codebase and documentation scans to:

Confirm that the MCP server is working as expected
Confirm that there are no obvious security issues with dependencies of the server
Extract server characteristics such as tools, resources, prompts, and required parameters.

This badge helps your users to quickly asses that the MCP server is safe, server capabilities, and instructions for installing the server.

Thanks! Done.

Thanks! are you on the MCP Discord?
If yes, let me know your Discord username and I will give you a special mcp-server-author flair


[Feature Request] detect unused parameters

Reposting from hydra https://github.com/facebookresearch/hydra/issues/323
For fairly large configs, it would be nice to be able to detect unused parameters to be able to help find stale parameters and prevent silent failures when a parameter was thought to be used, but wasn't.
Building on the example in the docs, it would be nice to do the following
>>> conf = OmegaConf.create(dict(k='v',list=[1,dict(a='1',b='2')]))
>>> print(conf.pretty())
k: v
list:
- 1
- a: '1'
  b: '2'
>>> used_param = conf.list[0]
>>> conf.print_unused_params()
k: v
list:
- a: '1'
  b: '2'
>>> conf.list.print_unused_params()
- a: '1'
  b: '2'

Hi @terrykong,
Thanks for the feature request.
While this is possible - I think this functionality does not justify the overhead of maintaining a usage flag per node and additional complexity.
Given the lack of significant interest in this feature by other users, I am going to close this.

@omry No worries, makes sense 👍


Support REPLACE in SELECT

Another one from DuckDB's friendlier syntax: https://duckdb.org/2022/05/04/friendlier-sql.html:
SELECT
    * REPLACE (movie_count+3 as movie_count, show_count*1000 as show_count)
FROM star_wars_owned_by_disney

@ankrgyl will work on that support this week. Sorry the delay


[filebrowser] removing extra whitespace between the path

What changes were proposed in this pull request?

After searching got this link -> https://css-tricks.com/fighting-the-space-between-inline-block-elements/

@JohanAhlen are there any other ways to do it?

and if not which one (above) is good?

Nice!
Not the expert here. And even if people seem to like negative margin, it probably breaks the copy.
:+1: for me to ident like you did and move on

approval?


Export Model to Standard PyTorch Network Format

While working with mmdetection3d, I wanted to view the model in a standard pytorch model format like this since it helps me visualize the data flow eaier:
class VanillaPytorchModel(torch.nn.Module):
    def __init__(self, input_dimension, output_dimension):
        super(VanillaPytorchModel, self).__init__()
        self.linear1 = torch.nn.Linear(input_dimension, output_dimension)
    def forward(self, x):
        h_relu = self.linear1(x).clamp(min=0)
        return y_pred

However, within, mmdetection3d, models seems to be intialized through builder.py, which, in the example of an object detector network, calls DETECTORS.build. However, inside all of this, I can not find an easy way to "dump" the model to the format above, which would make models easier to read and understand, and make models developed and configured with mmdetection3d easier to reuse with other frameworks like PyTorch lightning.
I'm not sure if either is actually a way to dump models to a standard PyTorch format, but I think this feature would make mmdetection3d more flexible to use.

I'm sorry that this feature is now not supported in mmdetection3d. In fact, we will consider whether to support the feature in mmcv.  Beside, a PR is welcomed for supporting this feature.

I see. I should I create an issue in the mmcv repo? Also, how would you recommend to start to implement this feature, given that I can't see any straightforward way to export in a standard network format.

From my opinion, it's really hard to export model to the standard pytorch network format by a conversion script, maybe you need to rewrite pytorch network format by yourself, and if you want to to know the data flow of MMDetection3D, for now, only an official Chinese article is provided to tell the details of data flow in MMDetection (not MMDetection3D, but they are quite similar) for reference.

Oh I see, if that's the case I guess I'll have to leave it up to you guys to implement that feature, I'm not really sure I understand how the whole MM ecosystem works well enough to do that. Thank you for the help and advice though, I know you guys are really busy with a whole lot of refactoring right now.


[flash_ctrl] FIX RAND OPS TEST

Fix Rand Ops test so that all info partitions can be tested.
Also add support for checking in Scoreboard.
Signed-off-by: Nikola Miladinovic<EMAIL_ADDRESS>

@nikola-miladinovic this is the CI failure
Error-[MFNF] Member not found
../src/lowrisc_dv_flash_ctrl_env_0.1/seq_lib/flash_ctrl_rand_ops_base_vseq.sv, 293
"this.cfg."
Could not find member 'scb_empty_mem' in class 'flash_ctrl_env_cfg', at
"../src/lowrisc_dv_flash_ctrl_env_0.1/flash_ctrl_env_cfg.sv", 5.

@nikola-miladinovic this is the CI failure
Error-[MFNF] Member not found ../src/lowrisc_dv_flash_ctrl_env_0.1/seq_lib/flash_ctrl_rand_ops_base_vseq.sv, 293 "this.cfg." Could not find member 'scb_empty_mem' in class 'flash_ctrl_env_cfg', at "../src/lowrisc_dv_flash_ctrl_env_0.1/flash_ctrl_env_cfg.sv", 5.

@tjaychen : Should be fine now since PR 11766 is merged. Please rerun checks.

@nikola-miladinovic this is the CI failure
Error-[MFNF] Member not found ../src/lowrisc_dv_flash_ctrl_env_0.1/seq_lib/flash_ctrl_rand_ops_base_vseq.sv, 293 "this.cfg." Could not find member 'scb_empty_mem' in class 'flash_ctrl_env_cfg', at "../src/lowrisc_dv_flash_ctrl_env_0.1/flash_ctrl_env_cfg.sv", 5.

@tjaychen : Should be fine now since PR 11766 is merged. Please rerun checks.

@tjaychen : Now is fine.


为何在playground里可以看到背景颜色渐变效果，在真机里看不到呢？

在playground里可以看到背景颜色渐变效果，但是我把我的项目放在真机里测试，发现背景没有渐变效果？如何解？

线性渐变在 0.10 才开始支持。

This PR/issue doesn't received response since Weex migrated to Apache two years ago and this repository is no longer active yet.
Feel free to ask question in new repository and thanks for your contribution.

This issue is outdated for a long time and will be closed now. You can create a new one if you still have questions.


Throw when invalid filter expression.

Previously, the QueryBuilder assumed that a filter specifier without a kind was an attribute filter. This was true even if no attribute property was present, which could never work. This silently failed to filter anything. Furthermore, an end-developer used to other filter APIs might attempt to pass something like { firstName: 'Luke' } to filter, which would fall into this silent failure path.
This commit ensures that an attribute is specified before assuming the filter is an attribute filter. In the example above, that means the well-meaning and otherwise intelligent and good-looking end developer will receive a helpful error instead of, say, shipping a non-functional filter to production.
@mattmcmanus / @lukemelia

LGTM

Thanks, @lukemelia! I can see how this could be misleading.


Is Shaka player support mobile Firefox?

Have you read the Tutorials?
yes
Have you read the FAQ and checked for duplicate open issues?
yes
What version of Shaka Player are you using?
3.0
Please ask your question
I have tested using shaka player to play Widevine protected video in desktop Firefox browser and mobile Firefox browser.
This video can be play in desktop Firefox browser but cannot be play in mobile Firefox browser.
I also checked shaka player demo in https://shaka-player-demo.appspot.com/demo/#audiolang=en-US;textlang=en-US;uilang=en-US;panel=HOME;build=uncompiled using mobile Firefox browser and found that the Play button for Sintel has been grayed out. May i know does this mean shaka player did not support mobile Firefox browser?

We do support Firefox mobile, but Firefox mobile doesn't support Widevine for some reason.  So Firefox mobile is unable to play any DRM content.  If they ever do decide to support Widevine, no changes will be necessary in Shaka Player or in your application.
You can check for support for various codecs and DRM systems in your app by calling await shaka.Player.probeSupport(); The return value is a dictionary, and you can explore the contents of it by clicking "Browser Support Test" at the bottom of the demo.
Does this help?

yes, thanks.
On Wed, Aug 19, 2020 at 12:36 AM Shaka Bot<EMAIL_ADDRESS>wrote:

@hooili https://github.com/hooili Does this answer all your questions?
Can we close the issue?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/shaka-player/issues/2793#issuecomment-675585933,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AMPYQN5N26UM5K4HSWCWUWDSBKUX5ANCNFSM4P7ETOUQ
.

--
Hooi Li
Application Developer
O +603 7966 8300
SMG Entertainment Sdn Bhd ( 507045-H )
Level 6, Menara Star, 15, Jalan 16/11,
46350 Petaling Jaya, Selangor Darul Ehsan.
T 1300 88 7827 | www.dimsum.asia https://www.dimsum.my/
https://sites.dimsum.my/email-signature/now-showing.html
--
http://starmediagroup.my
This email may contain information, which is
confidential and/or privileged. The information is intended solely for the
use of the individual or entity named above. If you are not the intended
recipient, be aware that any disclosure, copying, distribution or use of
the contents is prohibited. If you have received this electronic
transmission in error, please notify the sender by telephone or return
email and delete the material from your computer.


Channels opened from LND to LDK remain inactive and payments fail

When opening channels from my regtest LND nodes to my iOS node the channels remain inactive. I've tried to mine blocks and update graphs in polar but not sure what the issue is:
lnd@alice:/$ lncli listchannels
{
    "channels": [
        {
            "active": false,
            "remote_pubkey": "0219b5fe26d76181a47294b85c2e8c5deebbb5a6aa21c05c35941800684f73309c",
            "channel_point": "49067f5bd49c7bb311b22a86d16bcc38684002627d65e0908124cefa185e9ade:0",
            "chan_id": "188016488415232",
            "capacity": "100000",
            "local_balance": "40950",
            "remote_balance": "50000",

When alice tries to pay an invoice generated by the LDK wallet the payments fails:
lnd@alice:/$ lncli payinvoice lnbcrt1u1p3ntfjxdqdwpshjmt9wpk85np4qgvmtl3x6ascrfrjjju9ct5vthhthddx4gsuqhp4jsvqq6z0wvcfcpp53phu0udtuayk5qe64cugwyk3840krcvkh5j6tg99lxln9r9m0g8qsp5exgtdyhw6qkrwe857q6rmvnc6ea2l8zrj0lxzf23yh62g0gcc5vq9qyysgqcqpcxqy7s3lacpywuc9xgdext8xrvscah426nmk97wvnl2vygvep5ns4ryn5xss8sdwt53svm08vq36t6f8g0wsaq8npdw8ejqf5anl5xgvd9pcksgpn93hnz
Payment hash: 886fc7f1abe7496a033aae388712d13d5f61e196bd25a5a0a5f9bf328cbb7a0e
Description: paymeplz
Amount (in satoshis): 100
Fee limit (in satoshis): 100
Destination: 0219b5fe26d76181a47294b85c2e8c5deebbb5a6aa21c05c35941800684f73309c
Confirm payment (yes/no): yes
+------------+--------------+--------------+--------------+-----+----------+----------+-------+
| HTLC_STATE | ATTEMPT_TIME | RESOLVE_TIME | RECEIVER_AMT | FEE | TIMELOCK | CHAN_OUT | ROUTE |
+------------+--------------+--------------+--------------+-----+----------+----------+-------+
+------------+--------------+--------------+--------------+-----+----------+----------+-------+
Amount + fee:   0 + 0 sat
Payment hash:   886fc7f1abe7496a033aae388712d13d5f61e196bd25a5a0a5f9bf328cbb7a0e
Payment status: FAILED, reason: FAILURE_REASON_INSUFFICIENT_BALANCE
[lncli] FAILED

These are the logs from alice:
2022-09-28 19:41:01.676 [WRN] CRTR: Failed to find route for payment 85899248aa8aa9b2c43e41a7a102bd81ba0cb7a08023819da7744a108b552f9e: insufficient local balance
2022-09-28 19:41:01.694 [ERR] CRTR: Payment 85899248aa8aa9b2c43e41a7a102bd81ba0cb7a08023819da7744a108b552f9e failed: insufficient_balance

Have you experienced similar issues on regtest? Thanks

In the simulator can you tap the list channels button and post output or screenshot here?

Does the channel meet the confirmations_required value of 6? If below this value, you should be able to mine 6 or more blocks in Polar, tap "Sync LDK", "Add Peers" and then try again. After mining these blocks and syncing you should also see the is_usable value returned from "List Channels" switch to true.

@tanx mind sending uploading all the logs. A new file is created for every session so just look in the terminal for LDK logs writing to ... Open that dir and upload all the files so we can check the logs for when the channel was opened/confirmed.


OCM API implementation

General comment: you are dividing the log information in separate self.log, one with the message and the other with some other output. I would recommend keeping them together in a single self.log.

Fixed.

Then I have another question, more philosophical: should we have the ocm as a separate API? Couldn't we integrate it with the normal shares and hide the difference from the frontend?
I say this, but I would argue the frontend should always distinguish a normal share from an ocm one. Because I would do the following: the user searchs by an email, if the search returns no user, we should use it as an ocm share. But then I would put this as a parameter of the share api: "ocm = true or false".
What do you think?

I was thinking about the same. I agree that we could expose unified API, at least for normal shares and OCM shares.
Don't forget about public shares, which probably have low priority now, but are also candidates to incorporate into unified API. I am not sure I understand how this search by emial mechanism would work, why not finding a user by emial would implicate ocm share?

General comment: you are dividing the log information in separate self.log, one with the message and the other with some other output. I would recommend keeping them together in a single self.log.

Fixed.

Then I have another question, more philosophical: should we have the ocm as a separate API? Couldn't we integrate it with the normal shares and hide the difference from the frontend?
I say this, but I would argue the frontend should always distinguish a normal share from an ocm one. Because I would do the following: the user searchs by an email, if the search returns no user, we should use it as an ocm share. But then I would put this as a parameter of the share api: "ocm = true or false".
What do you think?

I was thinking about the same. I agree that we could expose unified API, at least for normal shares and OCM shares.
Don't forget about public shares, which probably have low priority now, but are also candidates to incorporate into unified API. I am not sure I understand how this search by emial mechanism would work, why not finding a user by emial would implicate ocm share?

Yes, let's forget the public shares for now. Do you want to propose a unified API now or in a separate PR?
About the email.. You need to know if you want to create OCM or normal, to know which cs3apis endpoint to contact right? This should be decided by the frontend (we could do in the backend, but this way we evoid double calls). When you search for a user you should be able to search by username or email. But, the results you get are only the ones that exist in your idp (this is correct, right?). So, if you are in your ailleron instance and search for<EMAIL_ADDRESS>this will return no results. But, since it has the<EMAIL_ADDRESS>we know that this can be used as an OCM share, so the request to the sharing API should tell the backend that this is OCM. Does this make sense? I'm talking without much knowledge of the current OCM implementation, so I might have wrong assumptions...

Can you also do a overview of our API endpoints? A simple documentation would be fine, but if we could put the information as comments in the code and generate documentation based on it would be better. Can you open a issue?

Yes, let's forget the public shares for now. Do you want to propose a unified API now or in a separate PR?
About the email.. You need to know if you want to create OCM or normal, to know which cs3apis endpoint to contact right? This should be decided by the frontend (we could do in the backend, but this way we evoid double calls). When you search for a user you should be able to search by username or email. But, the results you get are only the ones that exist in your idp (this is correct, right?). So, if you are in your ailleron instance and search for<EMAIL_ADDRESS>this will return no results. But, since it has the<EMAIL_ADDRESS>we know that this can be used as an OCM share, so the request to the sharing API should tell the backend that this is OCM. Does this make sense? I'm talking without much knowledge of the current OCM implementation, so I might have wrong assumptions...

Can you also do a overview of our API endpoints? A simple documentation would be fine, but if we could put the information as comments in the code and generate documentation based on it would be better. Can you open a issue?

Yes, please merge this piece for clarity.
Now I get your idea. It makes sense, but I would like to look a bit deeper.
I will create an issue, code based documentation is preferable.

Yes, please merge this piece for clarity.
Now I get your idea. It makes sense, but I would like to look a bit deeper.
I will create an issue, code based documentation is preferable.


Add more anime openings, endings, OSTs

Please refer contributing to see how to add more content.

[x] I searched or browsed the repo’s other issues to ensure this is not a duplicate.
[ ] This issue is for enhancement/bug fixing.
[x] This issue is an addition to JSON database.
[x] I have gone through Contribution Guidelines.
[ ] Assign this issue to me.

Thanks! Trying to make this an ending list. 😄
Other contributors can also send PR for this issue. 👍

Can I add few more tracks to your awesome playlist ?

Sure @saideepd, please go ahead. 👍

I'd like to add a song or two, if that's ok.

Sure thing @Endless7188, go for it! 👍


[WIP] chore: Add global config parsing instead of context injection

Fixes #N/A
Description
How was this change tested?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

73 of 101 (72.28%)  changed or added relevant lines in 13 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 78.907%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/operator/logging/logging.go
0
1
0.0%

pkg/webhooks/webhooks.go
0
2
0.0%

pkg/controllers/provisioning/batcher.go
0
3
0.0%

pkg/global/config.go
48
58
82.76%

pkg/operator/operator.go
0
12
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
8290

Relevant Lines:
10506

💛  - Coveralls


Hello GitHub Webhooks!

Description
This issue ticket is created for testing GitHub Webhooks.

This's a comment.


Require/Define d3.js

I'm having an issue with the require/define statement. In Qlik Sense, the funnel shows up just fine with no errors, in a mashup I'm having an issue loading d3.js from the url that is generated from the define statement.  When I comment or change the define line, it no longer works in QS (and still doesn't work in Mashup).
Any way to just force the d3.js to load?
Any help? Thanks in advance this is fantastic
QS Works:

Error received in mashup:

I figured it out. Qlik calls define() in a mashup and the code below is required (pun intended) right before the mashup define to point to the right d3.js file.
When define(["d3"], factory) is called it then points to the CDN below.
require.config( { 	paths: { 		d3: "//cdnjs.cloudflare.com/ajax/libs/d3/3.5.17/d3" 	} });

That's good. Note that I do not have that much familiarity with Qlik. Obligatory mention of the Qliksense plugin:
https://github.com/stefanwalther/sense-funnel-chart

No worries mate, that extension you posted is using a version of your funnel from back in the day. I started with that and it required updating which leads me here. Thanks again - great work


Special case of threading in didexchange #0023 ?

Hi, I have a question about thread branching and its particular usage in did-exchange https://github.com/hyperledger/aries-rfcs/blob/main/features/0023-did-exchange/README.md
So according to the general https://github.com/hyperledger/aries-rfcs/blob/main/concepts/0008-message-id-and-threading/README.md it sounds like (and was always my understanding) that pthread is used to "bootstrap" new subprotocols from some other message (which might be part of some thread). My understanding was that only the first message in the new subprotocol needs to refer to its parent message via pthread.
However, did-exchange explicitly states that the https://didcomm.org/didexchange/1.0/complete (eg. being 2nd message in protocol sent by invitation receiver) needs to specify pthid again:

The pthid is required in this message, and must be identical to the pthid used in the request message.

If this is how threading was meant to be, then I think this should be simply part of threading rfc.
If not, why does did-exchange requires special threading handling?

It’s not intended to be a special case, but to remind DID Exchange implementers of how threading is supposed to work. A DID Exchange “usually” (more on that below) starts from an OOB invitation message (a different protocol), so the OOB is the pthid in a DID Exchange request message, as the DID Exchange is the “child” protocol to the OOB.  So, OOB and DID Exchange are just following the intention of 0008 in that scenario.
That said, I realize as I type this that DID Exchange can use an implicit invitation — e.g. if a party has published a DIDComm service in a published DID, anyone can use that to send a DID Exchange request message. In that case, there is no OOB invitation, and therefore no pthid needed in either the request or complete message.
Perhaps a clarification is needed.

That said, I realize as I type this that DID Exchange can use an implicit invitation — e.g. if a party has published a DIDComm service in a published DID, anyone can use that to send a DID Exchange request message. In that case, there is no OOB invitation, and therefore no pthid needed in either the request or complete message.

When dealing with implicit invitations, pthid is still used:

When a request responds to an implicit invitation, its ~thread.pthid MUST contain a DID URL that resolves to the specific service on a DID document that contains the invitation.

Nice @genaris — I was only writing and thinking and not actually looking at the RFC (as I should have been).  Thanks for the correction. So it does seem to be correct.

Thanks @swcurran and @genaris. However I think I didn't get fully my point across - I understand reason for pthid in ttps://didcomm.org/didexchange/1.0/request message type.
What I don't understand is why is required that https://didcomm.org/didexchange/1.0/complete also needs to contain pthread. It seems like redundancy it's linked to the "subprotocol didexchange conversation" using thid assigned to ttps://didcomm.org/didexchange/1.0/request.
I would suspect that pthid would be only used in a first message of subprotocol (here being request msg type), but not necessary all subsequent messages within that subprotocol.

Well, It seemed like a good idea at the time. That was added given feedback.

After looking at the history (and watching a few minutes of 2020-03-11 Aries WG call recording, starting from 59:30), it looks like this mandatory pthid in complete message has been added with the intention of using it for connection reuse:

The complete message may also be used to reuse existing connections. When an out of band invitation is received containing a public DID for which the invitee already has a connection, the invitee may jump directly to the complete message in the protocol sent over the existing connection. The pthid passed in the complete message allows the inviter to correlate the invitation with the identified existing connection and then invoke any protocols desired based on that context.
TODO: Should this message be called continue instead of complete? Does combining the ack for new connections and the continue for reuse make sense?

I guess the pthid was necessary because this 'standalone' complete message would create a new thread by its own.
Later on, this functionality went to RFC 0434's handshake-reuse messages.

Good detective work, @genaris !!  So that might be why that line is there.  However, I don’t think we can remove the line and so make it optional to have or not have the pthid in the message.  That would be the definition of a semver version change and require we change the protocol version, and I don’t think it is worth doing that.
So the answer is that it is a possibly unfortunate evolution of the RFC as it was initially debated, but it is there now and should be left as it is defined.  When we next make a version change, we can consider removing the line, but the issue is not important enough to generated the overhead of a version change.
Hopefully that is enough information to close the issue.

Thank you all for engaging here, especially @genaris for all the effort too dig this out, wow! 🚀
Though this is not ideal and while I'd be happy to remove pthid in complete message, I recognize everyone's now looking rather ahead at didcomm v2 rather than making minor but technically braking changes here.
However it's good to have understanding why the RFC was defined the way it is (and I am not missing something important). Again, thanks everyone.


NEXT-9360 - add missing order delivery state transitions

1. What does this change do, exactly?
Add's state transitions from all order delivery states back to open.
2. Describe each step to reproduce the issue or behaviour.
3. Checklist

[ ] I have written tests and verified that they fail without my change
[ ] I have squashed any insignificant commits
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[ ] I have read the contribution requirements and fulfil them.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

You mixed up single and double quotes

You mixed up single and double quotes

fixed


How to abort/cancel execution of command?

For example I have a database with 10M keys. I run KEYS * command and lettuce start receiving keys from Redis server. Now I want to abort/cancel execution of this command. How to do it?
I have tried to use RedisFuture#cancel command but after call it I still see that lettuce receiving keys from Redis server.

Hi,
don't run KEYS * in production. It will block Redis and create a congestion so other clients need to wait until the command finishes - and it may blow up your memory. Commands sent once to Redis cannot be canceled in a clean way. The only thing I could imagine is closing the connection. cancel() is only useful when dealing with reconnect as queued commands that are canceled don't get retried upon reconnect.

I agree with you about KEYS command but I want to implement REPL console in my application. As you understand in this case user can type any command (include KEYS) and I want to have a way to abort execution of any user command.
I think I will close connection to abort command.
Thank you! :)


Update index.md

Test pull request to rename from SystemML to Quarks

Thanks Samantha for the test.  I was able to merge and push this change. Can you please close the pull request.

Thanks!  closing pull request!


[IOTDB-2534] Add character support while using quote

Chery-pick from #5041 and adapt to v0.13

Coverage increased (+0.04%) to 67.717% when pulling 317fb565ea156024373b9c69e8cc2c7c384914a0 on liuminghui233:iotdb-2534 into ba1922909ef4f06aaff2a85aaecedca20d014fa8 on apache:master.


Url type port limit not checked

pydantic version: 1.5.1
pydantic compiled: False
install path: /opt/fastapi/backend/venv/lib/python3.8/site-packages/pydantic
python version: 3.8.3 (default, Jun 21 2020, 00:03:19)  [GCC 8.3.0]
platform: Linux-4.19.0-9-amd64-x86_64-with-glibc2.28
optional deps. installed: ['email-validator']

Hi,
The port limit is not checked by URLs types:
>>> from pydantic import BaseModel, stricturl
>>> class Test(BaseModel):
	url: stricturl(allowed_schemes=["tcp"])

>>> Test(url="tcp://<IP_ADDRESS>:100000000000000000000000000000")
Test(url=UrlValue('tcp://<IP_ADDRESS>:100000000000000000000000000000', scheme='tcp', host='<IP_ADDRESS>', host_type='ipv4', port='100000000000000000000000000000'))

Excepted result: raise an error,
my current workaround
>>> from pydantic import BaseModel, stricturl, validator
>>> from pydantic.networks import url_regex
>>> class Test(BaseModel):
	url: stricturl(allowed_schemes=["tcp"])
	@validator("url")
	def validate_port(cls, v):
		port = url_regex().match(v).group("port")
		if port is None:
		    return v

		if int(port) > 2**16:
			raise ValueError("port overflow")
		return v

>>> Test(url="tcp://<IP_ADDRESS>:900000")
Traceback (most recent call last):
  File "<pyshell#84>", line 1, in <module>
    Test(url="tcp://<IP_ADDRESS>:900000")
  File "pydantic\main.py", line 338, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 1 validation error for Test
url
  port overflow (type=value_error)

Is there a nice RFC explicitly stating a limit for port? if so I guess we could add a check, but this is not a bug, just a limit of the current validation.
You can implement a much cleaner validator:
class Test(BaseModel):
    url: stricturl(allowed_schemes=['tcp'])

    @validator('url')
    def validate_port(cls, v):
        if int(v.port) > 2**16:
            raise ValueError('port overflow')
        return v

Hi,
rfc 793 explain ports are 16 unsigned bits
Your validator will fail if port is missing, with tcp protocol that doesn't really make sense but with http(s) protocol is does:
example
http://example.com the validator will fail because v.port is None, int will raise a TypeError, but thanks for the tips I totally forgot port attribute 🤦
class Test(BaseModel):
    url: stricturl(allowed_schemes=['tcp'])

    @validator('url')
    def validate_port(cls, v):
        if v.port is None:
            return v
        elif int(v.port) > 2**16:
            raise ValueError('port overflow')
        return v

(the tcp protocol is a bad showcase about default port)

Good point, if v.port is not None and int(v.port) > 2**16 would be better. (is port=0 allowed?)

rfc 793 explain ports are 16 unsigned bits

PR welcome to add this check to all URL validation, I know technically it's a breaking chance, but I think a reasonable one, given that a higher port is invalid anyway.

the port 0 is tagged as reserved and should not be usable as such since most routers will reject it.
In a other hand in a lot of APIs port 0 mean "use the first avaiable socket" so I would say yes.
I'll work on a PR within a few days (this weekend I hope if I have time)

makes sense to allow 0, also makes the check easier.

I'll work on a PR within a few days (this weekend I hope if I have time)

Thanks so much

I'm currently working on a PR,
looking at the sources of networks I have few questions about some design choices
Should I open news issues for each or asking here is fine ?

Would it make sense to separate Port into a seperate type, and to utilize it when checking urls? - I'm asking as I'm currently in need of port validation and I thought it was provided out of the box, or atleast as an internal type utilized by url parsing / validation.

Would it make sense to separate Port into a seperate type, and to utilize it when checking urls? - I'm asking as I'm currently in need of port validation and I thought it was provided out of the box, or atleast as an internal type utilized by url parsing / validation.

You can use conint for that @Skeen

@flapili I am aware and I am, but that requires me to find and check rfc793 instead of just importing that knowledge.
Either way, it was just a suggestion.


Convert React Web Interface to TS

Maybe take a look at this?
https://medium.com/swlh/convert-your-javascript-react-app-to-typescript-the-easy-guide-631592dc1876


GridMap enhancement - Add a get_used_cells() method like in TileMap

As in the title, please add a method that returns an array of all filled cells in a GridMap. This method is available on TileMap, and would offer the exact same functionality for GridMap. Example get_used_cells(), it would return a simple array of Vector3 positions in grid cell coordinate space.

@J08nY That was quick! Thank you very much for this!


RuntimeError: "unfolded2d_copy" not implemented for 'Half'

I can't run your code, I used the versions of the torch 1.9.1 and torchvision 0.10.1 libraries because the libraries you specified are incompatible with each other and I have no idea how you started this project..

Thank you, please use the latest torch=1.13.1 and torchvision=0.14.1.


WritableStream gets reset after pipe()

I think there was a change to the streamable behavior.  Basically, the following occurs:

var localFileStream = fs.createReadStream('/path/to/local/file');
var remoteFileStream = hdfs.createWriteStream('/path/to/remote/file');
localFileStream.pipe(remoteFileStream);

Inside WebHDFS.prototype.createWriteStream(), we attach to the 'pipe' event.  This unwinds the source with src.unpipe(req), save and pause the stream.  The problem is that the in stream_readable.js, there is something akin to the following:

  dest.emit('pipe', src);

  // start the flow if it hasn't been started already.
  if (!state.flowing) {
    debug('pipe resume');
    src.resume();
  }

The emit makes sense and is where we receive the 'pipe' event.  The pause() sets the state.flowing to false.  And then once the emitted event handler finishes, the second half of that block is invoked.  This re-enables event flow within the source.  Basically, this breaks the detach/reattach model.
The simple workaround is for the author to pause the stream immediately after calling pipe.
So,

rstream.pipe(wstream);
rstream.pause();

Hey Aaron!
Will look into this. Thanks!

@ajaxx let me know how this fix works for you. If there are any new regression regarding this I need to look much deeper.


Do you really need a Flutter dependency?

Hi,
I want to use it in a Shelf api that I wrote with Dart, but I cannot use it due to Flutter dependency.
Is it possible to fix this?
Thank you.

I am not sure what you are saying, can you give me more information?

I am not sure what you are saying, can you give me more information?

Mail and the pubspec.yaml file in this package are included in the Flutter dependency.
In fact, Flutter is not required for both packages to work.
If you uninstall Flutter, your packages will also work in Dart console applications.

https://raw.githubusercontent.com/dotronglong/flutter-mailgun/master/pubspec.yaml

Mail and the pubspec.yaml file in this package are included in the Flutter dependency.
In fact, Flutter is not required for both packages to work.
If you uninstall Flutter, your packages will also work in Dart console applications.

https://raw.githubusercontent.com/dotronglong/flutter-mailgun/master/pubspec.yaml

Hi, thank you for your information, however, I am not still getting your point. mail package provides interface for flutter-mailgun to implement. I believe you are getting problems regarding dependencies in your application, hence, I would like to ask if you can provide more relevant information about your application, e.g, which conflict packages prevents you from using this plugin.

Hi, thank you for your information, however, I am not still getting your point. mail package provides interface for flutter-mailgun to implement. I believe you are getting problems regarding dependencies in your application, hence, I would like to ask if you can provide more relevant information about your application, e.g, which conflict packages prevents you from using this plugin.

I used your code embedded, there is no problem for me right now. It was just a recommendation so more people could use it.
Thank you.

I used your code embedded, there is no problem for me right now. It was just a recommendation so more people could use it.
Thank you.

Since mail is designed for flutter users only, hence, it depends on flutter sdk. I will consider it to be used for dart/web in the future. Thank you for your information.

Since mail is designed for flutter users only, hence, it depends on flutter sdk. I will consider it to be used for dart/web in the future. Thank you for your information.


Update infoList documentation

In Filament\Resources\Pages\ViewRecord.php line 219, infolist is not a static method. Copying from the docs causes the IDE to complain that it is 'not compatible' with the method in ViewRecord

[x] Changes have been thoroughly tested to not break existing functionality.
[x] New functionality has been documented or existing documentation has been updated to reflect changes.
[x] Visual changes are explained in the PR description using a screenshot/recording of before and after.

The method is static in fact on resource classes.


Battery request: ramp-capacity-charging/discharging

Is your feature request related to a problem? Please describe.
No.
Why does polybar need this feature?
It would just be nice since the Nerd Font project has 2 sets of battery icons in the mdi section, one for charging (lightning bolt) and one for discharging.
Describe the solution you'd like
New properties:
ramp-capacity-CHARGING-0 = ...
etc.
ramp-capacity-DISCHARGING-0 = ...
etc.
Describe alternatives you've considered
I tried using animation-capacity for one state. Works okay.
Additional context
N/A
Thanks.

This will automatically be possible once we have #1752


request upload permission for ftp-rename plugin

request upload permission for ftp rename plugin #301
GitHub Link:
https://github.com/jenkinsci/ftp-rename-plugin
Jenkins Wiki Link:
https://wiki.jenkins-ci.org/display/JENKINS/Ftp+Rename+Plugin

Description

Permissions pull request checklist

Always

[x] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[x] Add link to resolved HOSTING issue in description above

For a new permissions file only

[x] Make sure the file is created in permissions/ directory
[x] artifactId (pom.xml) is used for name (permissions YAML file).
[x] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[x] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[ ] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[ ] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ] All newly added users have logged in to Artifactory at least once

https://issues.jenkins-ci.org/browse/HOSTING-301

Needs initial login as described in this repository's readme.

after this can I release the plugin or should I have any other step?

@brunocantisano Should work now. If it does not see https://wiki.jenkins-ci.org/display/JENKINS/Hosting+Plugins#HostingPlugins-Workingaroundcommonissues


put in a request to NecTar to specs up your instance

A request has been submitted, waiting to hear back.


Select2 4.0 data id not working

Just upgrading to 4.0 and the following does not work, I'm not seeing anything in the notes about changes regrading the data object
$("#producers").select2('data').id
I do see the data object when I run $("#producers").select2('data')

So you have to do 'val'
var producerId = $("#producers").select2('val');


Visit static imports for better perf

This uses a simple regex on each Stylus file in order to discover statically imported files.
Unlike stylus-loader which uses a Visitor to crawl the file's AST and attempt to find the entire dependency tree before attempting its single render (which will fail for dynamic imports), this just attempts to find as much as reasonably possible before/between each render attempt.
Even if the entire dependency tree can't be reached (due to dynamic imports or not being able to replicate weirdo Stylus resolution rules), it's still better to have as much resolved beforehand as possible.
All the resolution done by visitImports is purely for perf gains and doesn't affect how things are actually resolved at render time. If its regex turns out to be bad, or it finds commented-out imports, or whatever, it doesn't really matter – it's only expanding the potential dependency tree to increase resolution performance.
Depending on the app, this greatly improves build times. On the low side, 8 min → 5 min, on the high side, 39 min → 2 min.
Also bumps deps.
Fixes #7.
Also tried:

Having a process pool of workers whose job it is to parse each Stylus file and crawl the AST for imports, then send results back to the main process. This wasn't any faster than just having one process use a simple regex.

/cc @ryanisinallofus @ananavati

🚢 👍


Media Player Broken in Safari 11.1

Love the player, and works very well. Recently we noticed that it is broken in Safari. Getting the following error in the console. This seems to be an issue picked up across other video players as well, so perhaps a webkit bug that needs to be worked around.
Unhandled Promise Rejection: NotSupportedError: The operation is not supported.
Screenshot of console from demo page attached

Follow up, I realized that in the screenshot the promise may have failed because of the 404 being returned, but we are still facing the issue in our live environment when we are directly linking to mp3's as well.

Do you think this is because the resources I was referencing have moved? In a sense, this is two bugs. The first bug is to update the demos to use more reliable media sources. The second bug is to either not throw when a resource is not found or to throw a more reasonable error.
What do you think?
Also, thank you so much for using this player. I didn’t think anyone cared or used it at all. I recently saw a blog about accessible players and I don’t think this one was mentioned. 😄

The player is fantastic so we use it in our CRM! Thank you for building it. Yes, agreed updating demos would be a bug. However, it's not actually a 404 that's triggering it. here's a screenshot from our live system.

This page works fine in Chrome but breaks in Safari. Not sure why exactly.

Here's some samples to illustrate my point:
Chrome:
http://g.recordit.co/kphZiercRR.gif
Safari:
http://g.recordit.co/FMSjtBaL8V.gif

This seems to be related to Safari 11's autoplay media update.
https://webkit.org/blog/7734/auto-play-policy-changes-for-macos/
https://www.reddit.com/r/webdev/comments/71nkym/safari_11_has_a_major_change_to_web_audio_api/

For me, the issue disappeared for me once I added working files. I tested this in Safari 12.0 (13606.1.30).
See the following URLs:

https://jonathantneal.github.io/media-player/index.html
https://jonathantneal.github.io/media-player/playlist.html

In the playlist example, I switched to the second song and let it finish, transition to the next track which autoplayed, and then transitioned from that track to the next track which also autoplayed.
Would you be able to send me a snippet of code or a link to a repo that should demonstrate the failure with the littlest code possible? I’m happy to look at this further with you.

Thanks for the quick response @jonathantneal! So after further examination I realized that this is because safari doesn't seem to like being given streams in the audio src. We currently get our audio from Amazon S3 which returns a value like :
src="/getfile.php?f=1&stream=true&id=XXXXXXX&cid=XXXXXXXXX"
Safari doesn't seem to like this. If i give it a full URL and don't stream it works fine. Not sure if this is something the player can detect and solve for or if just not using streams is the solution.
What do you think? Thank you for taking the time to diagnose this with me. Sincerely appreciate it.

Okay, I’m closing the initial issue since this is more about adding support for streams. However, I’m also not sure this app doesn’t support streams out of the box. If you can throw together a demo of streams working or not working with this app, I’d be happy to followup.


IPA not signed with Ad Hoc profile

I'm trying to use Fastlane to distribute builds to Crashlytics. It's sending the .ipa succesfully to Crashlytics, but it keeps getting signed with an Appstore provisioning profile instead of Ad Hoc. I'm not sure wether this is a bug or if i'm doing something wrong. It does download the Ad Hoc profile correctly, but doesn't seem to be using it to sign the ipa.
This is the script i'm running:
    sigh(adhoc:true)
    gym
    crashlytics({
       crashlytics_path: "XXX",
       api_token: "XXX",
       build_secret: "XXX",
    })

I can get it to work by adding "resign" with a specific provisioning profile, but i doubt this is the right way to do it.
Thanks!

Could you try to use the following command for gym:
gym(export_method: 'ad-hoc')

This will make sure you app gets signed as Ad Hoc app

Also, I pushed this update https://github.com/KrauseFx/fastlane/releases/tag/1.29.1
This should now work automatically :+1:

Cool, both solutions work perfectly! Thanks!
The only issue i still have is "400 Bad request" when generating a Ad Hoc profile when it doesn't exist yet. I guess this is related to #349. Is this an unresolved vague issue?

Great! :+1:
The other issue you mentioned has something to do with your internet connection.

export_method does not seem to work with gym if you pass configuration option.
sigh(adhoc:true) solves this for me.

I'll close this issue for now :+1:


Can not ask follow up Mistral

Before submitting your bug report

[X] I believe this is a bug. I'll try to join the Continue Discord for questions
[X] I'm not able to find an open issue that reports the same bug
[X] I've seen the troubleshooting guide on the Continue Docs

Relevant environment info
- OS: Fedora
- Continue version: v0.9.243 (pre-release)
- IDE version: 1.95.3
- Model:Mistral large
- config.json:

{
  "models": [
    {
      "apiKey": "KEY",
      "title": "Mistral Large",
      "model": "mistral-large-latest",
      "provider": "mistral"
    }
  ],
  "tabAutocompleteModel": {
    "title": "Codestral",
    "provider": "mistral",
    "model": "codestral-latest",
    "apiKey": "KEY"
  },
  "embeddingsProvider": {
    "provider": "mistral",
    "model": "mistral-embed",
    "apiKey": "KEY",
    "apiBase": "https://api.mistral.ai/v1"
  },
  "customCommands": [
    {
      "name": "test",
      "prompt": "{{{ input }}}\n\nWrite a comprehensive set of unit tests for the selected code. It should setup, run tests that check for correctness including important edge cases, and teardown. Ensure that the tests are complete and sophisticated. Give the tests just as chat output, don't edit any file.",
      "description": "Write unit tests for highlighted code"
    }
  ],
  "contextProviders": [
    {
      "name": "code",
      "params": {}
    },
    {
      "name": "docs",
      "params": {}
    },
    {
      "name": "diff",
      "params": {}
    },
    {
      "name": "terminal",
      "params": {}
    },
    {
      "name": "problems",
      "params": {}
    },
    {
      "name": "folder",
      "params": {}
    },
    {
      "name": "codebase",
      "params": {}
    },
    {
      "name": "file",
      "params": {}
    }
  ],
  "slashCommands": [
    {
      "name": "share",
      "description": "Export the current chat session to markdown"
    },
    {
      "name": "cmd",
      "description": "Generate a shell command"
    },
    {
      "name": "commit",
      "description": "Generate a git commit message"
    },
    {
      "name": "pr",
      "description": "Explain the PR saved in patch file"
    }
  ]
}

Description
I ask a shirt question and it work. Then I ask a follow up and I have a 400 no body error
To reproduce

Ask a question to mistral large
Ask a follow up

Log output
Error handling webview message: {
  "msg": {
    "messageId": "8434d576-24df-4d03-bf3f-425eb6966fc4",
    "messageType": "llm/streamChat",
    "data": {
      "messages": [
        {
          "role": "system",
          "content": "When generating new code:\n\n1. Always produce a single code block.\n2. Never separate the code into multiple code blocks.\n3. Only include the code that is being added.\n4. Replace existing code with a \"lazy\" comment like this: \"// ... existing code ...\"\n5. The \"lazy\" comment must always be a valid comment in the current context (e.g. \"<!-- ... existing code ... -->\" for HTML, \"// ... existing code ...\" for JavaScript, \"{/* ... existing code */}\" for TSX, etc.)\n6. You must always provide 1-2 lines of context above and below a \"lazy\" comment\n7. If the user submits a code block that contains a filename in the language specifier, always include the filename in any code block you generate based on that file. The filename should be on the same line as the language specifier in your code block.\n\nExample 1:\nInput:\n.js\nimport addition from \"addition\"\n\nclass Calculator {\n  constructor() {\n    this.result = 0;\n  }\n    \n  add(number) {\n    this.result += number;\n    return this;\n  }\n}\n\nUser request: Add a subtract method\n\nOutput:\n```javascript test.js\n// ... existing code ...\nimport subtraction from \"subtraction\"\n\nclass Calculator {\n  // ... existing code ...\n  \n  subtract(number) {\n    this.result -= number;\n    return this;\n  }\n}\n```\n\nExample 2:\nInput:\n```javascript test.js (6-9)\nfunction helloWorld() {}\n```\n\nOutput:\n```javascript test.js\nfunction helloWorld() {\n  // New code here\n}\n```\n\nAlways follow these guidelines when generating code responses.\n\nWhen using tools, follow the following guidelines:\n- Avoid calling tools unless they are absolutely necessary. For example, if you are asked a simple programming question you do not need web search. As another example, if the user asks you to explain something about code, do not create a new file."
        },
        {
          "role": "user",
          "content": [
            {
              "type": "text",
              "text": "what?"
            }
          ]
        },
        {
          "role": "assistant",
          "content": "It looks like you might be a bit confused. Let me explain the guidelines again:\n\n1. **Single Code Block**: Always produce a single code block in your responses.\n2. **No Multiple Code Blocks**: Never separate the code into multiple code blocks.\n3. **Only New Code**: Only include the code that is being added.\n4. **Lazy Comments**: Replace existing code with a \"lazy\" comment like `// ... existing code ...`.\n5. **Valid Comments**: The \"lazy\" comment must always be a valid comment in the current context (e.g., `<!-- ... existing code ... -->` for HTML, `// ... existing code ...` for JavaScript, `{/* ... existing code */}` for TSX, etc.).\n6. **Context**: Provide 1-2 lines of context above and below a \"lazy\" comment.\n7. **Filename**: If the user submits a code block that contains a filename in the language specifier, always include the filename in any code block you generate based on that file. The filename should be on the same line as the language specifier in your code block.\n\nHere's an example to illustrate:\n\n**Input:**\n```javascript test.js\nclass Calculator {\n  constructor() {\n    this.result = 0;\n  }\n\n  add(number) {\n    this.result += number;\n    return this;\n  }\n}\n```\n\n**User Request:** Add a multiply method\n\n**Output:**\n```javascript test.js\nclass Calculator {\n  // ... existing code ...\n\n  multiply(number) {\n    this.result *= number;\n    return this;\n  }\n}\n```\n\nIf you have any specific questions or need further clarification, feel free to ask!"
        },
        {
          "role": "user",
          "content": [
            {
              "type": "text",
              "text": "h"
            }
          ]
        },
        {
          "role": "assistant",
          "content": ""
        }
      ],
      "title": "Mistral Large",
      "completionOptions": {}
    }
  }
}

Error: 400 status code (no body)

Also related to this, on the pre-release version codestral return a "{ "message":"Unauthorized"," error.
It works on the release version. The follow-up does not work on either version

I have the same issue for a few weeks now. I reverted to a random older version (0.9.217) and it worked again instantly.

@MalcolmMielle @marcchehab thanks for the heads up here! This has been fixed here and will be shipped in an upcoming hotfix release.

Seems to work on the latest pre-release for me


Negated assertions

Closes #50

@andrei-picus-hs Can you take a look?

Here is how it looks when a test passes but generates diffs:

We still have this failing setup scenario:
 1) Generate a dummy report for testing Second suite should fail with 'No browser provided' error:
     Error: No browser instance was provided

(in a later issue) Can we test that scenario only through unit/integration tests? It's preventing us from removing the run setup || run acceptance part.

@andrei-picus-hs can you review?

@andrei-picus-hs can I merge?

@adela-istrate-hs please see about this:

Warning: div was passed a style object that has previously been mutated. Mutating style is deprecated. Consider cloning it beforehand. Check the render of ImageDiff. Previous style: {borderLeft: "1px solid #999", height: NaN, margin: 0, overflow: "hidden", position: "absolute", right: -2, width: NaN}. Mutated style: {borderLeft: "1px solid #999", height: NaN, margin: 0, overflow: "hidden", position: "absolute", right: -2, width: NaN}.

This comes from the ImageDiff package. I was thinking about making a contribution.