document change

Description: Fix Document issue #8549
Risk Level: Low
Testing:
Docs Changes: Yes
Release Notes:
[Optional Fixes #Issue]  Document issue #8549
[Optional Deprecated:]

Hi @jmarantz
After the change, I compiled Envoy successfully on Fedora 30. Otherwise will have issue #8549.

Sounds good. Is this true for other Fedora releases? Or is 30 the most recent one?

I am not sure about other release, and 30 is the latest one.

Maybe update the doc to reflect that these instructions work on Fedora 30?

I find the issue also exists in Fedora 29

I think your change is basically fine but i have to wonder why whoever wrote the fedora instructions got it wrong. That's why I thought maybe it's version-specific?

Yes, understood, but I think the other release will have the same problem :), I will try to find out

Hi @jmarantz , other releases have same problem, I think we can just add this library to the dependencies list

Hi,
I just start to contribute Envoy, my environment is pretty clean. I am sure about that. I found this issue when I tried to deploy and test in my first time.
The final patch related to another patch #8642


Adding SVN-Partial Release Mgr plugin

Description

Permissions pull request checklist

Always

[ ] Add link to plugin/component Git repository in description above

For a newly hosted plugin only

[ ] Add link to resolved HOSTING issue in description above

For a new permissions file only

[ ] Make sure the file is created in permissions/ directory
[ ] artifactId (pom.xml) is used for name (permissions YAML file).
[ ] groupId / artifactId (pom.xml) are correctly represented in path (permissions YAML file)
[ ] Check that the file is named plugin-${artifactId}.yml for plugins

When adding new uploaders (this includes newly created permissions files)

[ ] Make sure to @mention an existing maintainer to confirm the permissions request, if applicable
[ ] Use the Jenkins community (LDAP) account name in the YAML file, not the GitHub account name
[ ] All newly added users have logged in to Artifactory at least once

Hi daniel,
Ok I changed the group id into the pom (it was a little weird anf was forgotten there by mistake).
I guess the yml files does not need any changes now.
About the forking , I am new to git and github and it wasn't clear to me how to create the PR even after reading the readme.
BR,

Ok I changed the group id into the pom (it was a little weird anf was forgotten there by mistake).

I think me cleaning up the wrong fork made this PR uneditable, so you need to file a new one from a fork in your personal account.


Minor fix compendium

I would submit these as separate PRs, but they're all so trivial that it seems like more effort than it's worth.

Clarify naming scheme for examples.

Add example for WidgetsApp constructor.

Add test for WidgetsApp constructor example.

Make all TextSelectionControls public. Previously we were inconsistent about whether they should be public or not. Making them all private seemed more likely to break users than making them all public.

Added documentation to newly public classes.

Added a link to the relevant global variable instance of the class to each TextSelectionControls subclass.

Moved the debugCheckHasMaterialLocalizations assert in the _DesktopTextSelectionControlsToolbarState builder to before the first early-out, to improve the consistency of the assert firing.

Documented the localizations needs of SelectionArea in the class documentation.

Added a call to debugCheckHasMaterialLocalizations to SelectionArea to make the needs more obvious (previously the assert only fired once the toolbar was rendered, which may not happen during brief testing).

Added some comments to various selectionColor properties to mention that the value has no effect when selection is impossible.

Elaborated the documentation regarding pageRouteBuilder in the WidgetsApp constructor and the pageRouteBuilder property.

Added a DefaultSelectionStyle.defaultColor constant, which is used in the Text widget now in case it can't find a selection color. Added a test for this.

Fixed the text of the assert in DefaultSelectionStyle's _NullWidget (copy pasta).

Fixed minor typo in EditableText docs.

Added to Overlay's docs to mention that it needs a Directionality.

Added more documentation and breadcrumbs to Route subclasses.

Added more introductory documentation to SelectableRegion and some breadcrumbs to SelectionContainer.

Exported TextSelectionPoint from widgets/text_selection, since it's in its API.

Renamed position argument to selectionMidpoint in TextSelectionControls.buildToolbar to match implementations.

Fixed typo in TODO.

Created a new EmptyTextSelectionControls class (and corresponding emptyTextSelectionControls global variable) that can be used when no text selection UI is needed (e.g. in experiments or samples). Added references to it in various places.

Fixed an omitted export in flutter_test.

Fixed a bunch of places where we used "ensureInitialized" instead of "instance".

Fixed copypasta in bufferMatchesGoldenFile docs.

@Hixie Looks like some checks are unhappy. Can you take a look?

Yeah the analyzer is unhappy because of the prints I added to figure out the web test slowness.

@goderbauer you may wish to check specifically the changes in flutter_test for runAsync that I made to fix the hang on web.


[Feature] Display animated pictures in received zap comments

what happens
Sometimes I receive zap comments, containing an animation (GIF), along with zaps. I cannot see said animation.
suggestion
Provide an opt-in option to display in transaction view, detailed transaction view the GIF / animation.
related to
#101 there should be a way to tap on GIF to examine context of note being replied to in e.g. njump

This requires a new build of the application so won't come ealier the next (or later) native release.
Note to self: To support animated GIFs and WebP formats, add to android/app/build.gradle
dependencies {
  // For animated GIF support
  implementation 'com.facebook.fresco:animated-gif:2.5.0' // check if not higher

  // For WebP support, including animated WebP
  implementation 'com.facebook.fresco:animated-webp:2.5.0'
}


Emit Link Particles on Demand

Help Needed

What is the best way to have the front-end listen to a signal from the backend that has a list of links?

References
Addresses #46.
Code changes

[x] add python method to LinkParticles behavior to emit particles on a set of links, this allows using the same object for setting the properties of the particles (color, size, speed)

[x] added method to start and stop particles, by controlling the density.

[ ] listen to event on js side and emit particles for given links.
[ ] tests
[ ] documentation
[ ] notebooks

User-facing changes
New methods for Particles behavior to start, stop, and emit particles over a set of links.
Backwards-incompatible changes
No backwards incompatibilities.

@dfreeman06 : any chance we could recruit your help with this one?

Works like a champ:


Stats.xml changes

Makes a stats file per frame when stats are enabled, changes how "Open Last Stats" works to open the stats file for the current frame (if there is one), changes the label from "Open Last Stats" to "Open Frame Stats", and modified the properties text of the enable stats checkbox to better match how the stats are currently output (i.e. .xml, not .txt)
note: I'm not sure how to isolate the changes without the merge from when I updated my fork to be current with master, so sorry about that extra little thing in here.

THanks!

Your way made way more sense, thanks for pointing that out!


[documentation] migration to/from filesystem

Moving state out of the system running jupyter and into a DB sounds awesome!
If I have lots of notebooks on disk, is there a clean way to import them into a pgcontents backend? Similarly, if I want to rollback from pgcontents to the file system, is there a clean way to export?

@snakescott sorry for the long delay in replying to this.  We actually used to have a utility that did basically what you're describing for checkpoints, but I ended up removing it for lack of use.  More recently, @nathanwolfe did work in (https://github.com/quantopian/pgcontents/pull/30) to add tools in  pgcontents.query to produce a generator over all the files in the database, handling decryption and taking min/max timestamps to support resuming if the process crashes.  You could build a "sync user to local directory" tool on top of that system relatively straightforwardly.

Is this still an issue?


Fix image link in readme in npm

Also, the icons could be removed from npm package

Image uploaded here to be used as fixed link


Very slow project/editor opening in Godot 4

Godot version:
4.0.dev.custom_build. 494bf38c7
GLES 2 - tested 14.01.2020
OS/device including version:
Ubuntu 20.04
Nvidia 970 440.83, i7 4770 4/8
Hotspot -v1.3.0-27-g61f1314
Issue description:
Opening and closing empty project in editor with command godot -e -q take a lot of more time than previous versions.

2020 11 results
RESULTS FROM 06.11.2020

Version
Opening Time
Memory usage in editor

Godot 3.2
4.2s
135 MB

Godot 4.0 GLES 2
8.2s
403 MB

Godot 4.0 (494bf38c7)
13.2s
340 MB

Godot 3.2 + Sanitizers
13.1s
-

Godot 4.0 (494bf38c7) + Sanitizers
41s
-

RESULTS FROM 25.07.2020

Version
Opening Time

Godot 3.4 (6d58ea6ce)
5.2s

Godot 3.4 (6d58ea6ce) + Sanitizers
13.7s

Godot 4.0 (b918c4c3c) - first run
13.9s

Godot 4.0 (b918c4c3c) - second run
10.4s

Godot 4.0 (b918c4c3c) + Sanitizers - first run
53,4s

Godot 4.0 (b918c4c3c) + Sanitizers - second run
33s

This makes it very difficult to test and develop the engine, especially when you start it with Address Sanitizer for example.
Most time spends on compiling shaders, which seems for me that partially can be avoidable by caching it or even compiling it when compiling Godot(not sure if this is possible).
Running Valgrind in one small project take almost 10 minutes

2020 11 results
CPU Cycles in Godot 3.2

CPU Cycles in Godot 4.0

CPU Cycles in Godot 4.0 GLES 2

Steps to reproduce:
To get perf data just execute this command(path must be changed)
perf record -o /home/rafal/perf.data --call-graph dwarf --aio --sample-cpu /usr/bin/godot4 -e -q

And then open it in latest version of Hotspot- https://github.com/KDAB/hotspot/releases

I haven't grokked numbers specifically but I can confirm qualitatively that starting debug builds of Godot master takes much longer than 3.2 on my system:
$ inxi -CSG
System:    Host: cauldron Kernel: 5.9.3-desktop-2.mga8 x86_64 bits: 64 Desktop: KDE Plasma 5.20.2 Distro: Mageia 8 mga8
CPU:       Info: Quad Core model: Intel Core i7-8705G bits: 64 type: MT MCP L2 cache: 8192 KiB
           Speed: 900 MHz min/max: 800/3100 MHz Core speeds (MHz): 1: 900 2: 900 3: 900 4: 900 5: 900 6: 900 7: 900 8: 899
Graphics:  Device-1: Intel HD Graphics 630 driver: i915 v: kernel
           Device-2: Advanced Micro Devices [AMD/ATI] Polaris 22 XL [Radeon RX Vega M GL] driver: amdgpu v: kernel
           Device-3: Cheng Uei Precision Industry (Foxlink) HP Wide Vision FHD Camera type: USB driver: uvcvideo
           Display: x11 server: Mageia X.org 1.20.9 driver: intel,v4l resolution: 1920x1080~60Hz
           OpenGL: renderer: Mesa Intel HD Graphics 630 (KBL GT2) v: 4.6 Mesa 20.2.1

50% of the time seems to be spent compiling shaders. I guess this will improve once shader caching has been implemented, so only the first run will be so slow.

I've just been having a little look at this too. On the plus side the startup time in GLES2 seems approx 2x as fast as vulkan, which will be helpful for people not working on graphics. As qarmin says the startup time is crucial for iteration for engine developers.
I noticed there were quite a few render targets being created, and I made these allocations deferred in GLES2 for faster startup, but I'll see if there is anything else that can be improved.
This is a profile of GLES2 startup:

A lot of the startup time seems to be in either String stuff (in GLES2) or gslang in Vulkan. There is possibly some time being spent in locking operations, but I'm not confident enough to interpret the profile in linux (don't know what cycle 14 represents).
There may be some low hanging fruit in optimizing some of the string routines in debug, and possibly the doctool (maybe it can be cached).

I've just been having a little look at this too. On the plus side the startup time in GLES2 seems approx 2x as fast as vulkan, which will be helpful for people not working on graphics. As qarmin says the startup time is crucial for iteration for engine developers.
I noticed there were quite a few render targets being created, and I made these allocations deferred in GLES2 for faster startup, but I'll see if there is anything else that can be improved.
This is a profile of GLES2 startup:

A lot of the startup time seems to be in either String stuff (in GLES2) or gslang in Vulkan. There is possibly some time being spent in locking operations, but I'm not confident enough to interpret the profile in linux (don't know what cycle 14 represents).
There may be some low hanging fruit in optimizing some of the string routines in debug, and possibly the doctool (maybe it can be cached).

Caching would be great, but the shader compilation itself should be optimized too. An 8 second startup time is embarrassing, especially for new users.
(Also, can we get high priority label)

Caching would be great, but the shader compilation itself should be optimized too. An 8 second startup time is embarrassing, especially for new users.
(Also, can we get high priority label)

The master branch isn't production ready, so being embarrassing a small concern until we reach late beta stage :slightly_smiling_face:

I think the slow start impacts contribution.
From my perspective, now I don't check whether the bug is reproducible on master any more when submitting a bug report because creating a test project and edit means double the long wait time (project manager + editor).
It's also a pain to submit PRs, because one have to target master unless it's a 3.x only issue. So my workflow is to develop on 3.x and backport PRs to master, which seems inefficient, but saves much more time comparing to develop the PR on master.

From my perspective, now I don't check whether the bug is reproducible on master any more when submitting a bug report because creating a test project and edit means double the long wait time (project manager + editor).

Use this command to create a new project in a temporary folder, bypassing the project manager:
# Assuming you're in the root folder of a Godot Git clone:
touch /tmp/a/project.godot
bin/godot.x11.tools.64 /tmp/a/project.godot

I ran a profiler with https://github.com/godotengine/godot/pull/49050 merged locally. The project manager was opened with the --quit command line argument, which makes Godot exit after one frame was rendered:
Project manager with no projects in the list
Top-down with cycle-intensive methods unfolded

Flame graph

With a few dozen projects in the project list
Top-down with cycle-intensive methods unfolded

Flame graph

Linux perf file (can be opened in HotSpot): perf.data.zip
It looks like mbedTLS of all thinsgs is causing the slowness, which is surprising at first. cc @Faless

It looks like mbedTLS of all thinsgs is causing the slowness, which is surprising at first. cc @Faless

Does it also happen in 3.x? The code should be the same as far as I recall.
I mean, the certificate list is big, but shouldn't take millis anyway. Does it get better if you set network/ssl/certificates editor settings to a single certificate (so the default list is used instead)?

Does it also happen in 3.x? The code should be the same as far as I recall.

https://github.com/godotengine/godot/issues/48978#issuecomment-846599528 shows the same for 3.x yeah. Earlier comparisons in this issue did not, but that must have been introduced in 3.x with the backport of the crypto stuff.
That would likely best be tracked in a separate issue for 3.x + 4.0.

#48978 (comment) shows the same for 3.x yeah. Earlier comparisons in this issue did not, but that must have been introduced in 3.x with the backport of the crypto stuff.

Good catch! I'll investigate.

How is this faring? Since shader caching and stringname optimizations were implemented, I have not seen update to these comparisons.

I ran a profile on commit b5e5eed7a (target=debug).
Project manager with no projects in the list
Top-down with cycle-intensive methods unfolded

Flame graph

Timeline (top)

Timeline (bottom)

With target=release_debug:
Top-down with cycle-intensive methods unfolded (top)

Top-down with cycle-intensive methods unfolded (bottom)

Flamegraph

Timeline (top)

Timeline (bottom)

I think the huge startup time regression can be considered fixed now, so we can close this issue. I'd suggest opening a new enhancement issue with latest profiling data so that we can keep optimizing to go even faster.

The start-up time is still painfully slow, even on an empty project.

@nathanfranke Can you compare optimized editor builds (same compiler and build flags)? I recommend using hyperfine with the --editor --quit Godot CLI arguments for benchmarking (or just --quit for the project manager).

 I have a feeling the performance has regressed more for complex projects.

Empty project. Is there a good project to test this on that has 3 and 4 versions?

@nathanfranke maybe the TPS demo?

Pointing out something I noticed the past few days... When I run my project standalone (e.g. --path my/project) it starts in like a second. However, if I run another instance right after, it takes like 5-6 seconds to start. When using the editor, the project seems to always take 5-6 seconds. There could be a bug with the shader caching with multiple instances.

Not sure if I should be putting this here or in #62322 but if I'm understanding this correctly and used the Instruments software properly (I really don't know what I'm doing) it looks like it's just doing a whole lot of nothing.
Macbook pro late 2013. It takes around 45 seconds to launch the project list, another 45 to launch the editor, and 45 more when I run the project to test.
This could be entirely unrelated but I hope this helps because launcher v3.4.4 only takes 2 seconds max.

I am on Iris Xe and I experience slowdowns when opening Godot and when running the project and when opening project or editor settings but only on multi-window. If I switch back to single window it's much better but still not as snappy as Godot 3 used to be.

I am on Iris Xe and I experience slowdowns when opening Godot and when running the project and when opening project or editor settings but only on multi-window. If I switch back to single window it's much better but still not as snappy as Godot 3 used to be.

I am having this same issue, and switching to single window also helps with performance one my end. I am running NixOS on a 11th Gen Intel chip, specifically the Framework laptop.


[fix] Fixes Android build failing due to "Cannot Find Symbol"

Context
Apparently #64 introduced a bug when building Android apps as RECEIVER_NOT_EXPORTED was not being defined/imported correctly, causing the build to fail (as follows):

This PR fixes it by changing it to Context.RECEIVER_NOT_EXPORTED.

Thank you :)


context.DotNet().Tool.Update not working

When calling
await context.DotNet().Tool.Update(
    new DotNetToolUpdateOptions("tool_name")
    {
        WorkingDirectory = "some_path"
    },
    cancellationToken
);

Exception is thrown:

System.ArgumentOutOfRangeException: 'Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')'

Probably because it tries to parse:
[PositionalArgument(PlaceholderName = "<PATH>")]
public string? Path { get; set; }

but it is not provided, but when providing it with
DotNetToolUpdateOptions("tool_name", path)
but then dotnet tool update can not recognize that parameter

Thanks!

Thanks for reporting @bszymik - can you try  version 2.40.4?


ParameterApplicationModelConvention

We have ActionApplicationModelConvention to wrap IActionModelConvention and provider a extent method like this:
public static void Add(
this IList conventions,
IActionModelConvention actionModelConvention)
{
conventions.Add(new ActionApplicationModelConvention(actionModelConvention));
}
and ControllerApplicationModelConvention and so on.
why havn't a class which name like 'ParameterApplicationModelConvention' to wrap IParameterModelConvention?

You're absolutely right we need this. Logged here already and planned for 2.0.0  https://github.com/aspnet/Mvc/issues/5618


Electron 6 Test Failure: Search reports telemetry on search completed

It looks like recently there is a test failure that I can only reproduce from the electron-6.0.x branch:
1) SearchModel Search Model: Search reports telemetry on search completed:

      AssertionError [ERR_ASSERTION]: false == true
      + expected - actual

      -false
      +true

      at Context.<anonymous> (file:///Users/bpasero/Development/Microsoft/vscode-electron-6.0.x/out/vs/workbench/contrib/search/test/common/searchModel.test.js:110:20)
      at processTicksAndRejections (internal/process/task_queues.js:89:5)

Must have been a regression from not too recent as this is the first time I am seeing that failing.

I pushed https://github.com/microsoft/vscode/commit/e5db2c31e4f7459a084977ed5bafc2a39ff50a37 as workaround. My testing shows that everything seems to be working fine, however:

when await testObject.search({ contentPattern: { pattern: 'somestring' }, type: 1, folderQueries }); returns the onDoneStopwatch(duration => this.telemetryService.publicLog('searchResultsFinished', { duration })); has not yet been fired. Assuming that the one happens before the other seems fishy to me.

Maybe something changed with how in E6 async code is ordered. This possibly came in when we switched to compile to ES7 from ES6 and native async await.

Yeah that's not good async code, fixed


htslib versioning and CRAM files

I think I'm hitting a versioning issue with htslib - I'm running nanopolish on data in CRAM format, and getting the error:
[cram_itr_query] tid=-3 not implemented for CRAM files -- Exiting Aborted
This was previously raised in #266 and patched in htslib in https://github.com/samtools/htslib/issues/625. It looks like nanopolish is using a version that doesn't contain that patch though because of commit https://github.com/jts/nanopolish/commit/b4318727bcf018b3c36e781386561c1eeb6cc345.
Is updating the htslib version a fix for this, or is https://github.com/jts/nanopolish/commit/b4318727bcf018b3c36e781386561c1eeb6cc345 necessary?

Updating htslib to 1.9 (the last version prior to the breaking API changes in 1.10) seems to have nanopolish building ok and running alright on CRAM input -

This seems to work ok after installing VBZ compression - closing this.
If anyone else hits this, replacing the htslib installed in nanopolish with the htslib 1.9 release and applying the following git diff to the repo should help - you'll need to ensure that the lzma, curl and bz2 dependencies are installed and accessible:
index 8b6c86f..982bd73 100644
--- a/Makefile
+++ b/Makefile
@@ -99,7 +99,7 @@ FAST5_INCLUDE = -I./fast5/include
 NP_INCLUDE = $(addprefix -I./, $(SUBDIRS))

 # Add include flags
-CPPFLAGS += $(H5_INCLUDE) $(HTS_INCLUDE) $(MINIMAP2_INCLUDE) $(FAST5_INCLUDE) $(NP_INCLUDE) $(EIGEN_INCLUDE) $(SLOW5LIB_INCLUDE)
+CPPFLAGS += -llzma -lcurl -lbz2 $(H5_INCLUDE) $(HTS_INCLUDE) $(MINIMAP2_INCLUDE) $(FAST5_INCLUDE) $(NP_INCLUDE) $(EIGEN_INCLUDE) $(SLOW5LIB_INCLUDE)

 # Main programs to build
 PROGRAM = nanopolish
@@ -112,7 +112,7 @@ all: depend $(PROGRAM)
 # Build libhts
 #
 htslib/libhts.a:
-       $(MAKE) -C htslib htslib_default_libs="-lz -lm -lbz2" || exit 255
+       $(MAKE) -C htslib htslib_default_libs="-llzma -lz -lm -lbz2" || exit 255

 minimap2/libminimap2.a:
        $(MAKE) -C minimap2 $(MINIMAP2_OPT) libminimap2.a || exit 255


TaxID nan is not found in taxonomy database.

Hello
I used hgtector  to analyze my MAGsm,but system can not auto-infer taxonomy for  my MAGs, so I specify manually tax ID , it still has errors.
(hgtector) [xxx@node1 2.gene_pre]$ hgtector analyze -i search  -o analyze  -t /xxx/database/hgtector/taxdump/  --input-tax bin.19:189774
Analysis started at 2020-06-27 20:51:20.514960.
Reading local taxonomy database...
Done. Read 40245 taxa.
Reading homology search results...
bin.19: 3049 proteins.
Done. Read search results of 1 samples.
User-specified TaxIDs of input genomes:
bin.19: 189774 (unclassified Chloroflexi (miscellaneous)).
Refining taxonomy database...
Traceback (most recent call last):
File "/xxx/miniconda3/envs/hgtector/lib/python3.8/site-packages/hgtector/util.py", line 422, in _get_taxon
return taxdump[tid]
KeyError: nan
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/xxx/miniconda3/envs/hgtector/bin/hgtector", line 96, in
main()
File "/xxx/miniconda3/envs/hgtector/bin/hgtector", line 35, in main
module(args)
File "/xxx/miniconda3/envs/hgtector/lib/python3.8/site-packages/hgtector/analyze.py", line 134, in call
self.assign_taxonomy()
File "/xxx/miniconda3/envs/hgtector/lib/python3.8/site-packages/hgtector/analyze.py", line 349, in assign_taxonomy
self.taxdump = refine_taxdump(self.sum_taxids(), self.taxdump)
File "/xxx/miniconda3/envs/hgtector/lib/python3.8/site-packages/hgtector/util.py", line 864, in refine_taxdump
ancs = set().union([get_lineage(x, taxdump) for x in tids])
File "/xxx/miniconda3/envs/hgtector/lib/python3.8/site-packages/hgtector/util.py", line 864, in
ancs = set().union([get_lineage(x, taxdump) for x in tids])
File "/xxx/miniconda3/envs/hgtector/lib/python3.8/site-packages/hgtector/util.py", line 654, in get_lineage
taxon = _get_taxon(cid, taxdump)
File "/xxx/miniconda3/envs/hgtector/lib/python3.8/site-packages/hgtector/util.py", line 424, in _get_taxon
raise ValueError(f'TaxID {tid} is not found in taxonomy database.')
ValueError: TaxID nan is not found in taxonomy database.
Could you help me? Thanks for your help very much.
Best regards

Hello @xieyg5 It is mostly likely that the manually entered TaxID 189774 is not found in the taxonomy database. Could you check it? If that's the case, you will have to replace it with the taxonomically / phylogenetically closest TaxID instead.

thanks, I checked that TaxID 189774  was in the names.dmp and nodes.dmp. it can define the taxID 189774  (User-specified TaxIDs of input genomes:bin.19: 189774 (unclassified Chloroflexi (miscellaneous))), the problem seems to be in refining taxonomy database... and I used some other TaxID  the same error occurred.

Hello @xieyg5 It is mostly likely that the manually entered TaxID 189774 is not found in the taxonomy database. Could you check it? If that's the case, you will have to replace it with the taxonomically / phylogenetically closest TaxID instead.

thanks, I checked that TaxID 189774 was in the names.dmp and nodes.dmp. it can define the taxID 189774 (User-specified TaxIDs of input genomes:bin.19: 189774 (unclassified Chloroflexi (miscellaneous))), the problem seems to be in refining taxonomy database... and I used some other TaxID the same error occurred.

@xieyg5 Thanks for the further information. On a second thought, I guess that some TaxIDs in your search result are not in the taxonomy database. In your search directory, does each file look like this?
# ID: WP_000064228.1
# Length: 714
# Product: methylmalonyl-CoA mutase
# Score: 1396.3
# Hits: 33
NP_311814.1	99.7	0.0e+00	1392.1	100.0	386585
YP_002409252.1	99.4	0.0e+00	1391.7	100.0	585057
YP_002413943.1	99.4	0.0e+00	1391.3	100.0	585056
NP_708678.2	99.4	0.0e+00	1390.2	100.0	198214
YP_001006157.1	86.3	0.0e+00	1221.8	100.0	393305

The last column is TaxID. Can you check if some of them are missing or not present in your taxonomy database?
For example, this command can find whether there is any missing TaxID.
cat search/*.tsv | grep -v ^# | cut -f6 | grep -c ^$

This can check whether some TaxIDs are not found in your database:
join -v1 <(cat search/*.tsv | grep -v ^# | cut -f6 | sort | uniq) <(cat /xxx/taxdump/nodes.dmp | cut -f1 | sort)

(Disclaimer: I am not sure if these commands will work... Do it with your own scrutiny.)

@xieyg5 Thanks for the further information. On a second thought, I guess that some TaxIDs in your search result are not in the taxonomy database. In your search directory, does each file look like this?
# ID: WP_000064228.1
# Length: 714
# Product: methylmalonyl-CoA mutase
# Score: 1396.3
# Hits: 33
NP_311814.1	99.7	0.0e+00	1392.1	100.0	386585
YP_002409252.1	99.4	0.0e+00	1391.7	100.0	585057
YP_002413943.1	99.4	0.0e+00	1391.3	100.0	585056
NP_708678.2	99.4	0.0e+00	1390.2	100.0	198214
YP_001006157.1	86.3	0.0e+00	1221.8	100.0	393305

The last column is TaxID. Can you check if some of them are missing or not present in your taxonomy database?
For example, this command can find whether there is any missing TaxID.
cat search/*.tsv | grep -v ^# | cut -f6 | grep -c ^$

This can check whether some TaxIDs are not found in your database:
join -v1 <(cat search/*.tsv | grep -v ^# | cut -f6 | sort | uniq) <(cat /xxx/taxdump/nodes.dmp | cut -f1 | sort)

(Disclaimer: I am not sure if these commands will work... Do it with your own scrutiny.)

thanks，I checked that the .tsv file by your commands , it  has the taxID and  the taxIDs  in .tsv file are also in database .  I download 2019.10.21 database but the same error still occurred.  finally I change the version to 2.0b1, it  didn't have any problems.   maybe there is something wrong with version 2.0b2 .

I had the same issue. By manually running the diamond command, I discovered that this happens because some taxonomic levels in nodes.dmp have taxonomic ranks not allowed by diamond.
In my case the ranks clade and 'strain` were causing problems. You need to modify those to something valid. This is an incompatibility between NCBi taxonomy and diamond.
The full list of diamond valid taxonomic ranks is here.

@surh Thanks for sharing the information! This is great to know. I like DIAMOND but its behavior changes from version to version. Recently I noticed that NCBI taxdump is more robust than previous. Ranks isolate, strain and subspecies are more meaningful and prevalent.
One way to bypass this without messing with NCBI or DIAMOND version is: Run DIAMOND manually, with --outfmt 6 so that it will generate standard m8 output without taxonomy, then use HGTector's --precomp to load this m8 file, together with --taxmap plus NCBI's accession2taxid mapping. HGTector will assign taxonomy to the hits.
@xieyg5 Please let us know if this helps. Thanks!

@surh Thanks for sharing the information! This is great to know. I like DIAMOND but its behavior changes from version to version. Recently I noticed that NCBI taxdump is more robust than previous. Ranks isolate, strain and subspecies are more meaningful and prevalent.
One way to bypass this without messing with NCBI or DIAMOND version is: Run DIAMOND manually, with --outfmt 6 so that it will generate standard m8 output without taxonomy, then use HGTector's --precomp to load this m8 file, together with --taxmap plus NCBI's accession2taxid mapping. HGTector will assign taxonomy to the hits.
@xieyg5 Please let us know if this helps. Thanks!

@qiyunzhu @surh  thanks for your help.  I was updated diamond software, the error did not appear with hgtector.


Autocompletion for language extensions

It would be nice if hie could complete language extensions when it can detect the right completion context

What would be the place to look for adding this?

Look at how completions for import modules are done:
https://github.com/haskell/haskell-ide-engine/blob/master/src/Haskell/Ide/Engine/Plugin/HieExtras.hs#L328-L335
The list of visible modules is taken from the ghc-mod api. You could take the list of all available Language extensions from the same api, here is how it was done for the modules list:
https://github.com/haskell/haskell-ide-engine/blob/master/src/Haskell/Ide/Engine/Plugin/HieExtras.hs#L198
And this is how it could be done for the language extensions:
https://github.com/DanielG/ghc-mod/blob/master/GhcMod/Exe/Lang.hs#L10
@cronokirby let me know if you want to volunteer for this task and if you need further help.


Remove all traces of will_paginate

Remove Pagination module altogether in favour of external gems. neo4-will_paginate works out of the box (kvitter app works with no changes, apart from Gemfile).
All pagination specs removed (some added to the neo4j-will_paginate). Confirmation to Enumerable should be tested instead, but it's probably done in multiple places. I even doubt it actually needs to be a part of neo4j core.
The Paginated class got it's own spec file.

I'll release this PR as alpha.2 to make sure TravisCI will pass on neo4j-will_paginate (not possible to set deps to git for gems).

For some reason the neo4j-will_paginate fails on CI. Something to do with the dependencies.
I tried to mess with those, but it still fails (strangely enough, only in 1.8 mode)
http://travis-ci.org/#!/dnagir/neo4j-will_paginate/builds/534341
Any thoughts?

I've also having trouble installing the neo4j alpha.3
Installing neo4j (2.0.0.alpha.3) Invalid gemspec in [/home/andreas/.rvm/gems/jruby-1.6.5/specifications/neo4j-2.0.0.alpha.3-java.gemspec]: Illformed requirement ["#<YAML::Yecht::DefaultKey:0x6ed1144b> 1.6.0.alpha.6"]

But I can build and install a local one


test

contents

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.


Event in the gutter

I am trying to display events in the gutter.
Something like the green bar here in Amie.

But I am struggling the change the eventContainerStyle and the EventComponent. One is global, the other is per event.
Any idea how we could achieve this?
What are we missing to be able to do that?
Source of the example: https://calendar.amie.so/

Classic, RTFM: https://hoangnm.github.io/react-native-week-view/full-api/event 😉

There is the answer!


Add blind 75 leetcode problems in interview preparation

Blind 75 leet code is a list of 75 most frequently asked leet code questions that have helped many developers clear interviews of Google, Amazon, Microsoft, Facebook, etc.

Consider merging the pull request, it might be helpful for someone preparing for an interview.


remove redundant code and unused imports

Remove unused imports such as useEffect and TextField. In the SvgExportForm component, redundant code has been removed, and the state handling for fullBg checkbox has been streamlined. The function for handling export has been extracted into a dedicated handleExport function for better readability and separation of concerns. Additionally, the calculation of targetNetworkId has been simplified to reduce conditional checks.

Addressed Issue
The issue highlighted redundancies and inefficiencies in the SvgExportForm component, such as unused imports, overly verbose state handling, and convoluted logic for calculating targetNetworkId.
How I Resolved It

Removed Unused Code: Eliminated imports like useEffect and TextField, which were no longer necessary.
Function Extraction: Isolated the export logic into a handleExport function to ensure better readability and maintain separation of concerns.
Simplified Logic: Refined the targetNetworkId calculation by reducing conditional checks, making the logic more concise and efficient.

The Strategy I Used
Reductive Maintenance: Focused on simplifying the codebase by removing unnecessary elements and streamlining existing functionality. Emphasized clarity and efficiency while minimizing complexity.
Impact of Changes
Enhanced Readability: The codebase is now cleaner and easier to understand.
Improved Maintainability: Reduced complexity ensures easier debugging and future updates.
Cleaner Code: Adhering to reductive maintenance principles ensures a more concise and efficient implementation.


postponed attr init: docs added; fixed multifile problem

I started this PR to document internal aspects (attr replacement) which allows (a) the future maintainer of the textx-code to get detailed info and (b) the scope-provider-programmer to know what happens under the hood (see scoping.md + figure).
I also depicted with a simple unittest (test_user_classes_attr_functions.py) that the attr methods are 100% restored.

Maybe @markusschmaus  already included this aspects in his tests. If so, please report, I will delete the new test in that case...
Hwoever, I have still a small issue for python 2. Help is welcome here! I do not see exactly what the problem is.

Then I realized that something might be missing and I modified an old test to make this effect clear: When loading an included model (e.g., via importURI) the loaded model is not the "main model". In that case the attr methods are not restored. I fixed this (see model.py).
Comments welcome!

Code review checklist

[X] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
[X] Title summarizes what is changing
[X] Commit messages are meaningful (see this for details)
[X] Tests have been included and/or updated
[n/a] Docstrings have been included and/or updated, as appropriate
[X] Standalone docs have been updated accordingly
[x] Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need
to update for typo fixes and such).

@igordejanovic Thank you for the python2 fix... Once we drop python2 we could rework some parts of the code. OK for me. If you have no further comments you can squash&merge - or I can do it if you prefer.

Go ahead and squash merge. Just give it some nice log message that would best describe what is done.


Scroll Crashing the App

https://github.com/emps/scrolltest
this is the simplest scroll page i made just now, app crash when u scroll up down for some seconds it can take more or less 10 20 sec and app will crash i have Galaxy S4 please any test it i cant continue with my project, i can add utube link if need

Greetings, @emps!
My sensors indicate that this issue has been inactive for a while.
Due to this, the issue will be closed in 7 days.
If you believe the issue has not been fixed, please add a comment.
This will notify us so we can assist you, and will prevent the issue from being automatically closed.
Feel free to include the following information about the issue, so that we may assist you:

Can you provide a detailed description of this issue?
How would a robot go about replicating this issue?
What platform does this happen on? (iOS, Android, all, etc.)
What platform versions does this happen on? (Android 4.2, iOS 7, all, etc.)
Is this an issue with the Ionic Framework, or Ionic CLI?

Thank you for allowing me to assist you.

Greetings @emps!
Sorry but this issue may no longer be applicable to recent versions of Ionic.
If you are still experiencing this issue, please feel free to reopen and provide the following information so that I may assist you.

Can you provide a detailed description of this issue?
How would a robot go about replicating this issue?
What platform does this happen on? (iOS, Android, all, etc.)
What platform versions does this happen on? (Android 4.2, iOS 7, all, etc.)
Is this an issue with the Ionic Framework, or Ionic CLI?

Additionally, providing a codepen which replicates the issue is extremely helpful.
If you wish to get help using the framework itself, the recommended place is the forum.
Thank you for allowing me to assist you.

We are also experiencing this issue. Occuring on a Samsung Galaxy S4 running 4.4.2. We have also reproduced the issue on an HTC One running 4.4.2. It is difficult to say exactly what is causing it... but we have a page with about 10 images (via ng-repeat). When scrolling the application will randomly crash.

Update: This issue seems to occur with Ionic 1.1.1. For lack of a solution we upgraded to 1.2.4. After upgrading the issue is no longer occurring and there is a noticeable performance increase while scrolling.

native scroll with images crashes ionic 1.7.14 on ios.


Border flicker on Catalina and yabai v4

Upon updating to the latest v4.0.0 version I started noticing border flicker when I change focus between windows.
Here is a short video of what I'm experiencing:
https://user-images.githubusercontent.com/22838433/164023780-56a31b1d-8988-4f96-b091-c515794541a7.mov
In slow motion:
https://user-images.githubusercontent.com/22838433/164024830-025fb66a-b77c-4e13-bcb0-0a34d22048fb.mov
It seems that in between the drawing of the unfocused border and the focused border the border disapears and so it seems to flicker.
Anyone else experiencing this?
It also happens when I only have firefox open and I type, may be an unrelated issue but it's very distracting.
MacOS Catalina 10.15.7
Yabai v4.0.0 with sa
Btw, thank you so much for this software, without it, using MacOS would be insane.

I see, so this is intended behaviour?
I reinstalled the 3.3.10 version just to make sure this did not happen before and it does not.

The border system in v3.3.10 does not work in macOS Monterey so it was rewritten in v4.0.0; the new version has this side effect, at least for now.

I'm going to ask a slightly unrelated question here, @samuellvicente how have you manage to square your window corners?

The border system in v3.3.10 does not work in macOS Monterey so it was rewritten in v4.0.0; the new version has this side effect, at least for now. I spent some time trying to see if if was possible to have these systems live side-by-side and interchangeable through a config option, but that was not really possible in a way that I found acceptable.

I see, well, I'll just use v3 then since it has all the features I need.
Thanks for your time!

I'm going to ask a slightly unrelated question here, @samuellvicente how have you manage to square your window corners?

Hmm, I did nothing, I think it's the default behaviour for the border to be squared.
If your talking about the application windows then I also did nothing, I think there are some hacks you can do but I never tried them.
My border has a width of 5 and it gives the illusion of squaring the corners.
You can check my yabairc in my dotfiles and try my config for yourself.

It appears that the new border system could get rid of this visual flicker if it is sped up. My proof of concept version (https://github.com/koekeishiya/yb) does not have this flickering happen.
I am not sure if this is achievable with the version that is integrated into yabai itself, because of synchronisation issues, as there is a lot more going on than simply "updating window borders".
I'll probably look into this in the future, as I myself find the visual flicker to be rather annoying at times.

I love the borders, since it allows you to achieve a truly flat look. However, I am also struggle with the flicker.

I love this application, by the way.

If borders are drawn below the window, instead of on top of the window, there will be no flickering: https://github.com/FelixKratz/yabai/commit/0cf7e92d9fb6031d9fa31af914e41745a58363ce

When drawing below it will also have to enclose the window, instead of matching the window frame. This does not work well without padding/gap. A workaround is to include the size of the border frame inside of the node region, and subtract that width from the window itself, but this gets messy in situations where a window enforces min/max size constraints.

I think I am going to try this with the workaround of subtraction the border inset from the node region of the window. If a window has min/max size constraints, the border should still be placed properly.

@koekeishiya it would be incredible if there the option to use borders in the old limelight style. With rounded corners and enclosing the window rather than being drawn on top. 🙏
I would try myself but I haven't got much experience with MacOS system programming. Either way thanks for the software. It's really great

It has also been problematic for me at times, to have window content obscured by the border being drawn over it.

This will be fixed with the changes being made for #1430


Correct stackscript column heading.

Purpose
Change "StackScripts" to "StackScript"

Coverage remained the same at 26.711% when pulling 7c3e00df311b36fba3a66e09e5dc9c2db2d8680e on rjstires:stackscript-column-name into 78074d6b466ce52acedd0f0a3573ffa4286988df on linode:develop.


built Storybook iframe path issues

What version of Turborepo are you using?
latest
What package manager are you using / does the bug impact?
npm
What operating system are you using?
Mac
Describe the Bug
After following the install instructions in the design system example, building storybook via npm run build from root of repo, I'm getting what looks to be an incorrect path thats generated by storybook in storybook-static. When manually fixing the issue in iframe.html by removing / in the assets path, the 404 goes away but still displays the CORS error. That is there because Origin in this case is my local file system. Not necessarily worried about that since I'm looking to just host these docs somewhere, although I've never had issues opening built Storybook HTML from other Storybook projects. Is there a way to configure paths for Storybook?
This might be more of a storybook question. But I'm wondering if there's something particular in the config.

Expected Behavior
Storybook page loads and displays iframe.html and it's assets when opening generated index.html file from storybook-static.
To Reproduce
Follow install instructions here: https://github.com/vercel/turborepo/tree/main/examples/design-system

run yarn build
open index.html in storybook-static
see console errors

Solution was setting base in .storybook/main.js
https://github.com/storybookjs/builder-vite/issues/238


calibration of imu and camrea

Expected Behavior
I wonder that the autoware offers  the calibration  of camera with respect to the IMU . If I only have IMU rather than GNSS. Or any materials about the calibration of camera and IMU ?
Actual Behavior
Steps to Reproduce the Problem

Specifications

Ubuntu version:
ROS version:
Autoware branch:

New Feature
Describe where the new feature request comes from. Add a high-level diagram of how the new feature should work.

@ttomchy Autoware does not offer the tools for calibration of camera and IMU now.


docs: Update README.md with proper structuring and references!

Hi there,
I have included the required information in the commit message regarding my PR. Looking forward to seeing this get merged!
Thanks,
@TheBinitGhimire

Great work Binit <3


Update doc theme

This patch:

Updates the docs theme to use "bootstrap".
Uses the "paper" bootswatch theme.
Fixes the problem with the search box failing.
Updates the docs.
Updates the buildscripts.
Adds in the lightning snake logo.

Closes #2489.

Codecov Report

Merging #2494 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2494      +/-   ##
==========================================
- Coverage   86.54%   86.54%   -0.01%
==========================================
  Files         316      316
  Lines       61458    61458
  Branches     6772     6772
==========================================
- Hits        53189    53188       -1
  Misses       7198     7198
- Partials     1071     1072       +1


Add-UserManagement-ActorDomain

Required items, please complete
Change(s):
Add ActorDomain to schema and add update ASIMUser
Reason for Change(s):
To accomodate usermanagement schema
Testing Completed:
Yes
Checked that the validations are passing and have addressed any issues that are present:
Yes

Hi @KustoKing,
We know that you are working on above requested changes.
Please provide some update.
Thanks

Hi @KustoKing,
We are still waiting for response from you for @vakohl  comment.
please provide update.
Thanks

we are not adding these fields in user management schema.


Changes to run depends test seperately

Depends test creates wheel to reflect dev build dependency for required packages but this can cause issue when running tests in parallel. for e.g. build directory is not found.
Fix in this PR is to isolate depends test from other tests and run it separately.

/azp run python - template


Some basic maintenance.

Updated some dependency ranges and fixed some doccumentation.

:+1:

:open_mouth:

awesome to see the good code coming out of sumall
keep up the good work! 😎
On Mon, May 23, 2016 at 3:34 PM, pyen<EMAIL_ADDRESS>wrote:

😮
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/SumAll/haskell-cartographer-lib/pull/6#issuecomment-221071530

:+1:

haha!


Catch reindex errors

Coverage decreased (-15.7%) to 84.195% when pulling 372ab4fb984d35856c8d04590bd16eed94a94134 on handle_missing_record_reindex into 1ea5795d1832b679e12c95ff46967678ee1f1f42 on master.


Managing two apps

Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject

Managing two apps from playstore
Question Description

I have two apps, basically the two are the same but I have to separate it for staging and production environment. I managed to upload the staging one but it seems to fetch the production meta data instead of the staging metadata after I uploaded a build it updates the icon (I color coded the icon so I can distinguish the staging one from production). Is there a way to pull two separate metadata?

✅ fastlane environment ✅
Stack

Key
Value

OS
10.15.1

Ruby
2.6.3

Bundler?
false

Git
git version 2.21.0 (Apple Git-122.2)

Installation Source
~/.rvm/gems/ruby-2.6.3/bin/fastlane

Host
Mac OS X 10.15.1 (19B88)

Ruby Lib Dir
~/.rvm/rubies/ruby-2.6.3/lib

OpenSSL Version
OpenSSL 1.1.1c  28 May 2019

Is contained
false

Is homebrew
false

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
11.2

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL

LANGUAGE

fastlane files:
`./fastlane/Fastfile`
# This file contains the fastlane.tools configuration
# You can find the documentation at https://docs.fastlane.tools
#
# For a list of all available actions, check out
#
#     https://docs.fastlane.tools/actions
#
# For a list of all available plugins, check out
#
#     https://docs.fastlane.tools/plugins/available-plugins
#

# Uncomment the line if you want fastlane to automatically update itself
# update_fastlane

default_platform(:android)

after_all do |lane|
  lanes = [:develop, :production]

  if lanes.include?(lane)
    notify_slack
  end
end

# PUBLIC LANE
lane :develop do
  gradle(task: "clean")
  gradle(task: "bundle", flavor: "develop", build_type: "Release")

  upload_to_play_store(
    track: "internal",
    package_name: "istack.staging.attendee",
    skip_upload_metadata: false,
    aab: '../build/app/outputs/bundle/developRelease/app.aab')
end

lane :production do
  gradle(task: "clean")
  gradle(task: "bundle", flavor: "production", build_type: "Release")

  upload_to_play_store
end

# PRIVATE LANE
private_lane :notify_slack do
  slack(
    slack_url: "https://hooks.slack.com/services/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",
    success: true,
    payload: { "Build date" => Time.new.to_s }
  )
end

`./fastlane/Appfile`
json_key_file("/Users/aabanaag/Documents/files/iStack/certificates/iStackMobileServices.json") # Path to the json secret file - Follow https://docs.fastlane.tools/actions/supply/#setup to get one
# package_name("istack.awc.attendee") # e.g. com.krausefx.app

fastlane gems

Gem
Version
Update-Status

fastlane
2.134.0
✅ Up-To-Date

Loaded fastlane plugins:
No plugins Loaded
Loaded gems

Gem
Version

did_you_mean
1.3.0

executable-hooks
1.6.0

bundler-unload
1.0.2

rubygems-bundler
1.4.5

bundler
1.17.3

etc
1.0.1

slack-notifier
2.3.2

rouge
2.0.7

xcpretty
0.3.0

terminal-notifier
2.0.0

terminal-table
1.8.0

plist
3.5.0

multipart-post
2.0.0

word_wrap
1.0.0

public_suffix
2.0.5

colored
1.2

highline
1.7.10

commander-fastlane
4.4.6

http-cookie
1.0.3

faraday-cookie_jar
0.0.6

faraday
0.17.0

faraday_middleware
0.13.1

gh_inspector
1.1.3

mini_magick
4.9.5

multi_xml
0.6.0

rubyzip
1.3.0

security
0.1.3

xcpretty-travis-formatter
1.0.0

jwt
2.1.0

uber
0.1.0

declarative
0.0.10

declarative-option
0.1.0

representable
3.0.4

retriable
3.1.2

memoist
0.16.0

googleauth
0.6.7

httpclient
2.8.3

google-api-client
0.23.9

digest-crc
0.4.1

google-cloud-storage
1.16.0

emoji_regex
1.0.1

nanaimo
0.2.6

colored2
3.1.2

claide
1.0.3

CFPropertyList
3.0.1

atomos
0.1.3

xcodeproj
1.13.0

unicode-display_width
1.6.0

addressable
2.7.0

tty-screen
0.7.0

tty-cursor
0.7.0

tty-spinner
0.9.1

babosa
1.0.3

excon
0.67.0

unf_ext
<IP_ADDRESS>

unf
0.1.4

domain_name
0.5.20190701

fastimage
2.1.7

json
2.2.0

dotenv
2.7.5

naturally
2.2.0

simctl
1.6.6

mime-types-data
3.2019.1009

mime-types
3.3

multi_json
1.14.1

signet
0.12.0

os
1.0.1

google-cloud-env
1.2.1

google-cloud-core
1.3.2

forwardable
1.2.0

logger
1.3.0

stringio
0.0.2

ipaddr
1.2.2

openssl
2.1.2

ostruct
0.1.0

strscan
1.0.0

date
2.0.0

fileutils
1.1.0

io-console
0.4.7

zlib
1.0.0

rexml
3.1.9

psych
3.1.0

mutex_m
0.1.0

generated on: 2019-11-06

Well, start with revoking your slack url 😅
https://api.slack.com/messaging/webhooks

I managed to upload the staging one but it seems to fetch the production meta data instead of the staging metadata after I uploaded a build it updates the icon (I color coded the icon so I can distinguish the staging one from production). Is there a way to pull two separate metadata?

That doesn't explain what you are doing, how it is failing and what you want to happen exactly when or why.


Add fields to contract_implementation_transactions_summary table

Add:

date
payer fields (i.e. same fields as in award_suppliers_summary)
payee fields (i.e. same fields as in award_suppliers_summary)
transaction (jsonb blob of the transaction)

For buyer and procuring entity, we have additional tables, even though they are 1:1 with their parent (the release). (It could have maybe made more sense to put them on the release_summary, since it is very common to want to filter by buyer, and joining buyer_summary to release_summary is expensive. That said, in practice, users like Camila just index into the JSONB, which doesn't really have any performance impact.)
In the case of payer and payee, they are rarely disclosed (as discussed in #6), and as such are rarely the subject of analysis. Adding more tables would just be overhead (moreso in terms of code maintenance than in terms of summary generation).
If we were to add fields directly on the transactions summary, it would be inconsistent with our approach for other parties, and in general we prefer a common approach. A party has 10 fields, which is a lot for users to ignore (since they will usually be empty), e.g.:

payer
payer_id
name
identifier
unique_identifier_attempt
additionalidentifiers_ids
total_additionalidentifiers
link_to_parties
link_with_role
party_index

So, for this issue, I will just add date and transaction.

transaction was added in 3cac61f3, as an unrelated change.


How to generate new sample sentence?

using model trained by 'slt_arctic_full_data'?

The scripts are under development. However, you can use festival front-end to generate the full-contextual labels similar to the current format.

Then, please follow the step 4 in https://github.com/CSTR-Edinburgh/merlin/blob/master/egs/slt_arctic/s1/run_full_voice.sh

The scripts are ready now -- to generate new test sentences.
Steps to follow:
Step 1: prepare a text folder, with each file containing a new test sentence.
Step 2: run below script
https://github.com/CSTR-Edinburgh/merlin/blob/master/egs/slt_arctic/s1/scripts/prepare_labels_from_txt.sh
Step 3: Then, please follow the step 4 in below script:
https://github.com/CSTR-Edinburgh/merlin/blob/master/egs/slt_arctic/s1/run_full_voice.sh
Hope these steps are useful to create novel sentences.

Srikanth,
Thank you. It's working as you guided!
Just to clarify Step 1 for others, the place of your new 'txt' folder should be at:
experiments/slt_arctic_full/test_synthesis/txt

Hi Srikanth, ydwang72,
I wanted to use trained model obtained by running run_demo.sh/run_full_voice.sh for the purpose of synthesizing audio for new sentences.
Towards doing above, i followed the steps you mentioned in "Steps to follow above" but while running merlin_synthesis.sh, i get following error :-
"2017-04-06 05:54:15,554 DEBUG   param_generation: acoustic_decomposition for 1 files
2017-04-06 05:54:15,554 INFO    param_generation: processing    1 of    1: /media/dl_audio/hdd2/Utkarsh/tts_exp/merlin/egs/slt_arctic/s1/experiments/slt_arctic_demo/test_synthesis/wav/own_01.cmp
2017-04-06 05:54:15,554 DEBUG   param_generation:  feature: mgc
checking shape of features over here in generation ...  (0, 180)
2017-04-06 05:54:15,554 DEBUG   param_generation: starting MLParameterGeneration.generation
checking shape of features over here in generation ...***************
Traceback (most recent call last):
File "/media/dl_audio/hdd2/Utkarsh/tts_exp/merlin/src/run_merlin.py", line 1175, in
main_function(cfg)
File "/media/dl_audio/hdd2/Utkarsh/tts_exp/merlin/src/run_merlin.py", line 943, in main_function
generator.acoustic_decomposition(gen_file_list, cfg.cmp_dim, cfg.out_dimension_dict, cfg.file_extension_dict, var_file_dict, do_MLPG=cfg.do_MLPG, cfg=cfg)
File "/media/dl_audio/hdd2/Utkarsh/tts_exp/merlin/src/frontend/parameter_generation.py", line 161, in acoustic_decomposition
gen_features = mlpg_algo.generation(current_features, var, out_dimension_dict[feature_name]/3)
File "/media/dl_audio/hdd2/Utkarsh/tts_exp/merlin/src/frontend/mlpg_fast.py", line 122, in generation
var_frames[0, 1] =<PHONE_NUMBER>00;
IndexError: index 0 is out of bounds for axis 0 with size 0
Lock freed
"
I am attaching logs generated while running merlin_synthesis.py
command_line_logs.txt
I created a directory by the name of txt in path mentioned by ydwang above, and created a test file by the name of own_01.txt which has "Summer vacations has started." as a text in it.
Please help me with this issue, by letting me know what i am missing.
Thanks
Utkarsh Vaidya

When I run the first command "https://github.com/CSTR-Edinburgh/merlin/blob/master/egs/slt_arctic/s1/scripts/prepare_labels_from_txt.sh"
I got the following error
Please configure festival path in scripts/prepare_labels_from_txt.sh !!

How do install install/setup festival?

sudo apt-get install festival festvox-kallpc16k

@ronanki Great. Thanks.
Do you have any setup instructions to run this? I spent two days to figure out how to run this, but I could not make it.
It will be very helpful if someone put instructions to run this.

If you install festival -- it should be straight-forward.

Hi @fizerkhan ,
Sorry for late reply
#96 will help you with mostly all required instructions need to be followed.
Regards

@uvaidya Thanks a lot for the update 👍
It is very hard to follow the instructions from that issue. Can you please add those instructions into separate file e.g SETUP.md or README.md?
P.S: The instructions are not only for festival dependencies. The instructions must guide the setup from the scratch.

Hey, I have a text file with the only sentence
Will we ever forget it.
in the txt folder. But when using the merlin_synthesis.sh script the first world is skipped. Is the first word reserved for the utterance id? When I'm using
arctic_a0005 Will we ever forget it.
only arc is skipped.
I found the same behaviour in the example wavs arctic_b0537 and arctic_b0538. However, the examples arctic_b0535, arctic_b0536 and arctic_b0359 seem to be correct.
The same problem occurs with the utts.data file with the line
( arctic_a0005 "Will we ever forget it." )
Am I using a wrong format?

The format seems right and is similar to cmudata. If you are not sure of the format, please use simple plain text files in a directory as input.

In the attached file (arctic_a0005.txt) I'm using
will we ever forget it
The audio is created with ./merlin_synthesis.sh, but the first world is missing. Can you reproduce that?

I have slt_arctic_demo.
now I want to my text to speech.
There have utts.data('( arctic_a0001 "This is what I can say" ) ') and text(a dir of have one text 1.txt(i am a boy)) in test_synthesis.
but i meet a  problem.
**[root@localhost s1]# ./merlin_synthesis.sh
Step 1: creating label files from text...
Please configure festival path in scripts/prepare_labels_from_txt.sh !!
Step 1 not successful !!
**
**[root@localhost scripts]# ./prepare_labels_from_txt.sh
Usage: ./scripts/prepare_labels_from_txt.sh conf/global_settings.cfg
[root@localhost scripts]# cd ../
[root@localhost s1]# ./scripts/prepare_labels_from_txt.sh conf/global_settings.cfg
Please configure festival path in scripts/prepare_labels_from_txt.sh !!
**
how to configure festival path?
I really don't know.
i hope you can help me
Thanks.

Have a look at #96

Under Ubuntu 16 after running sudo apt-get install festival festvox-kallpc16k I still get
Step 1: creating label files from text...
Please configure festival path in scripts/prepare_labels_from_txt.sh !!
Step 1 not successful !!

when i'm trying to run merlin/egs/slt_arctic/s1$ ./merlin_synthesis.sh

When i'm trying to run merlin/egs/slt_arctic/s1$ ./merlin_synthesis.sh
under Ubuntu 16 after running sudo apt-get install festival festvox-kallpc16k I still get
Step 1: creating label files from text...
Please configure festival path in scripts/prepare_labels_from_txt.sh !!
Step 1 not successful !!

I have added 1 .txt file for test echo "Hello, I love you!" > experiments/slt_arctic_demo/test_synthesis/txt/test_me.txt
Festival is visible in system
which festival
/usr/bin/festival

UDPATE:
Solution was simple just bash tools/compile_other_speech_tools.sh

Hi Srikanth, ydwang72,
I wanted to use trained model obtained by running run_demo.sh/run_full_voice.sh for the purpose of synthesizing audio for new sentences.
Towards doing above, i followed the steps you mentioned in "Steps to follow above" but while running merlin_synthesis.sh, i get following error :-
"2017-04-06 05:54:15,554 DEBUG param_generation: acoustic_decomposition for 1 files 2017-04-06 05:54:15,554 INFO param_generation: processing 1 of 1: /media/dl_audio/hdd2/Utkarsh/tts_exp/merlin/egs/slt_arctic/s1/experiments/slt_arctic_demo/test_synthesis/wav/own_01.cmp 2017-04-06 05:54:15,554 DEBUG param_generation: feature: mgc checking shape of features over here in generation ... (0, 180) 2017-04-06 05:54:15,554 DEBUG param_generation: starting MLParameterGeneration.generation checking shape of features over here in generation ...*************** Traceback (most recent call last): File "/media/dl_audio/hdd2/Utkarsh/tts_exp/merlin/src/run_merlin.py", line 1175, in main_function(cfg) File "/media/dl_audio/hdd2/Utkarsh/tts_exp/merlin/src/run_merlin.py", line 943, in main_function generator.acoustic_decomposition(gen_file_list, cfg.cmp_dim, cfg.out_dimension_dict, cfg.file_extension_dict, var_file_dict, do_MLPG=cfg.do_MLPG, cfg=cfg) File "/media/dl_audio/hdd2/Utkarsh/tts_exp/merlin/src/frontend/parameter_generation.py", line 161, in acoustic_decomposition gen_features = mlpg_algo.generation(current_features, var, out_dimension_dict[feature_name]/3) File "/media/dl_audio/hdd2/Utkarsh/tts_exp/merlin/src/frontend/mlpg_fast.py", line 122, in generation var_frames[0, 1] =<PHONE_NUMBER>00; IndexError: index 0 is out of bounds for axis 0 with size 0 Lock freed
"
I am attaching logs generated while running merlin_synthesis.py
command_line_logs.txt
I created a directory by the name of txt in path mentioned by ydwang above, and created a test file by the name of own_01.txt which has "Summer vacations has started." as a text in it.
Please help me with this issue, by letting me know what i am missing.
Thanks
Utkarsh Vaidya

@uvaidya I am getting the same error. Did you figure out how to fix it?
@ronanki Can you please check what to do?


blog post for june community call

Microsoft Reviewers: Open in CodeFlow

/azp run

@matthidinger while you are at it, can you update the Feedback link on the blog post site to redirect to the New Bug Template instead of the default blank one? Thanks


Allow to create and use enums in other schemas

fixes #42
Some notes
Even though I changed it in the readme, using StatusEnum.type() instead of just :status in the migrations is not a breaking change.
This was added so we don't have to write :"other_schema.status" in case we created the type in another schema. :status would still work if you're using the public schema.
Let me know what you think 😃

@gjaldon we are using your lib on an umbrella project with multiple schemas, and this MR would help us a lot. Do you mind taking a look at this ? Let me know if I can help somehow.

Thanks a lot for the work on this @uesteibar! This was very helpful 👍I made changes and created a separate PR which combines both our work
@leandrocp I'll merge https://github.com/gjaldon/ecto_enum/pull/67 once it passes CI and cut a release in the next several hours. Let me know if there's anything else we can help with


Set up GitHub Actions CI

AppVeyor and Travis CI can be really slow, with GitHub Actions CI jobs can run in parallel and without much delay, WDYT?

You'll probably need to set up the prebuild_upload token for this in the repo's settings.
I've separated linting into its own job since cpplint was silently failing on Windows, and it doesn't seem like it needs to run on all platforms.
The Debian builds are failing, not sure how to fix these.

You can check builds on my fork: https://github.com/nstepien/sharp/actions/runs/324453211

One issue is that 32 bit Windows is not available. Maybe AppVeyor should be kept only for this specific platform combination?
I have not set up code coverage reporting from Actions, maybe we can do this later.
Edits are allowed on my PRs, so feel free to play around with it, feel free to ask me any questions as well.

https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions
https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners

Coverage remained the same at 100.0% when pulling fbedcbba861949b63ed275c372cfae411c157e4d on nstepien:master into e6a035e57571ff4261fac00c9ddd014773792ab3 on lovell:master.

Hi, thanks for this PR Nicolas. The slowest CI environments are currently Windows (Appveyor) and macOS (Travis), which should probably be the priorities for any speed improvement.
GitHub Actions doesn't support arm64, hence the failed tasks you're seeing. I think I'd prefer to keep all the Linux (amd64 and arm64) CI running on Travis for now as that part of it is relatively fast.
It looks like GitHub Actions may soon have support for 32-bit Node.js on Windows - see https://github.com/actions/setup-node/pull/194 - we should wait for this as I'd prefer to have all the Windows CI tasks running on the same service.
Perhaps we could focus initially on migrating macOS to GitHub Actions?

The slowest CI environments are currently Windows (Appveyor) and macOS (Travis)
I think I'd prefer to keep all the Linux (amd64 and arm64) CI running on Travis for now as that part of it is relatively fast.

https://www.traviscistatus.com/#month
I was under the impression that it was the opposite, as Travis CI can have a lot of backlogged builds on Linux.

Perhaps we could focus initially on migrating macOS to GitHub Actions?

Sure, I'll tweak it.

CI run: https://github.com/nstepien/sharp/actions/runs/327307286

Thanks for the updates. I'd like to wait until after v0.27.0 before making this change, probably be mid-November, so will come back to this soon.

It looks like GitHub Actions may soon have support for 32-bit Node.js on Windows - see actions/setup-node#194 - we should wait for this as I'd prefer to have all the Windows CI tasks running on the same service.

Because @GitHub has become slow in reviewing that PR, I have tagged it on my fork. You can use it now if you want:
https://github.com/atom-ide-community/fuzzaldrin-plus-fast/blob/a62422a04ee9165763f86510b6728e26f789629a/.github/workflows/CI.yml#L42

Rather coincidentally, it looks like we're going to have to say "so long and thanks for all the fish" to Travis CI before the end of the year.
https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

I've migrated another native module, farmhash, away from Travis to now use GitHub Actions.
The 16-way matrix/config for Linux glibc (Centos 7), Linux musl (Alpine 3.11), macOS and Windows x64 can be seen at https://github.com/lovell/farmhash/blob/master/.github/workflows/ci.yml
It still uses Appveyor for Windows x86 - see https://github.com/lovell/farmhash/blob/master/appveyor.yml
The generation of prebuilds are split into their own conditional step, but the use of cpplint remains part of the testing step as the latest version now works on Windows (it was a Python 2 vs 3 thing).
The farmhash module doesn't support ARM, so I've not had a chance to test out the QEMU-based https://github.com/uraimo/run-on-arch-action yet.

Commit https://github.com/lovell/sharp/commit/fb07c1f4695f6bad40d08cd4dbc10f614c59137c on the actions branch (which is branched from the avif v0.27.0 branch) takes the excellent work in this PR as a starting point and adds GitHub Actions config for x64 Linux, macOS and Windows - see https://github.com/lovell/sharp/actions/runs/410589336 for a successful run.
Please so let me know if you see any problems/improvements.
It still uses Travis for ARM64 (as it's much faster than QEMU and there's never a queue for this infrastructure) - see https://travis-ci.org/github/lovell/sharp/builds/748541551
It still uses Appveyor for x86 Windows - see https://ci.appveyor.com/project/lovell/sharp/builds/36740068
There's one very minor problem where Coveralls is missing the commit message, but that could well be a feature/bug of the Coveralls Action, and I'm happy to ignore that - see https://coveralls.io/builds/35568878

Please so let me know if you see any problems/improvements.

LGTM

It still uses Appveyor for x86 Windows

I wonder if this even worth supporting, it must be a really tiny portion of your users. There are no supported 32 bit windows server versions anymore.
https://en.wikipedia.org/wiki/Comparison_of_Microsoft_Windows_versions#Windows_NT
I guess it doesn't really hurt to have.

Coveralls is missing the commit message

¯\_(ツ)_/¯ Should open an issue https://github.com/coverallsapp/github-action/issues

Thanks for taking a look (and thank you for opening this PR in the first place), I plan to make the switch before v0.27.0.
The download stats suggest a 10:1 ratio of 64 to 32-bit Windows users. I think Azure only offers 32-bit Windows VMs on their free/basic tier(s) and I guess there will be people who install the 32-bit node.exe on 64-bit machines.

Commit https://github.com/lovell/sharp/commit/e59e14688707215233bfb11e46cb9b58b2705d04 on the avif branch migrates as many environments as possible to Github Actions, which will be used to create binaries for v0.27.0.
@nstepien Nicolas, thank you for doing la préparation for this. When we are able to, let's meet in London for a glass of wine, c'est ma tournée.

🎉 I only drink Orangina tho.

Très bon, moins cher.


Add Configurable Scaling Values

[ ] configurable scaling parameters
[x] configurable AZ support - *Extracted to #141 *

Extracted AZ work to this issue: https://github.com/SUSE/kubecf/issues/141

https://github.com/SUSE/kubecf/pull/179 handles this.


Update convergence criteria

Currently, the default convergence criteria is being used throughout the view and view model. If we want to allow the capability to customize convergence criteria, we'll need the control to do that from study properties, and we'll need to use only that instantiation of convergence criteria throughout. This seems like something we could leave toward the end of the FY - is not critical for the 2.0 release.

this is one of the deobligated tasks

COnvergence criteria needs to be updated to match 1.4.3


add assertions with no description

Thanks for creating the bindings for Zora, it's quite a nice testing suite for rescript!
Sometimes you don't want to write a test message for an assertion, would you be open to a PR that would change the current API to make the test message optional?
It would be a lightweight layer like this:
let equal = (~msg=?, t, act, exp) => equal(t, act, exp, msg)

You would use it like that:
t->equal("foo", "foo")
// or if you do want a description
t->equal("foo", "foo", ~msg="those two strings should be the same")

Sure it adds a some runtime, but it'd be likely unnoticeable, especially for testing and it would sometimes help to make sure you're not feeding the text message with the expected string value.

Yes, please! ❤ I meant to add it, but never got around to it.

ok cool, I'll go for it then! 😀

https://github.com/lorenzofox3/zora/blob/master/assert/src/assert.js has the default descriptions from zora-assert. https://rescript-lang.org/docs/manual/latest/function#optional-with-default-value documents how to provide a default value for labelled arguments.
I think this would cause a major version bump since the API will shift as labelled arguments are an all-or-nothing thing for the argument, and so anyone who is using the library would have to update to use the label.

Unfortunately all the ways I think of trying this triggers a compiler error.

The only way it seems to work is to wrap the external functions:
@send external zoraEqual: (t, 't, 't, string) => unit = "equal"

let equal = (zora: t, a: 't, b: 't, ~msg="should be equivalent") => zoraEqual(zora, a, b, msg)

With uncurried mode we would not even need a wrapper, this would be enough:
@send external zoraEqual: (t, 't, 't, ~msg: string=?) => unit = "equal"

@tsnobip You're right. I was assuming we would set the default string when in fact Zora will take care of the lack of argument. And on top of the fact that the compiler errors weren't clear to me last night (they kept showing up in Zora.res for the external when I tried to use the default argument), and that's how I overlooked the easier solution. 😅

https://github.com/brettcannon/rescript-zora/tree/no-description-required shows it working with equal! Now to do the rest of the functions ...


Problem with the submitting Spark job of Morpheus Examples jar

I have the following on my cluster of machines:
OS: Centos 7
Spark:  version 2.4.3
Scala: Version 2.12.8
I have run the (./gradlew allJar -x test) in the root directory of the Morpheus project with the following error:
Task 'allJar' not found in root project 'okapi'. Some candidates are: 'docJar', 'jar', 'jmhJar'.
So I had to run it with 'jar' option  and got jar file for all modules inside the /build/libs directory.
I want to submit spark job of one of the examples inside the generated 'morpheus-examples/build/libs/morpheus-examples-0.4.3-SNAPSHOT.jar'
I have put the required jars in the Spark class path (spark/jars) directory, such as:

morpheus-spark-cypher-0.4.3-SNAPSHOT.jar
okapi-api-0.4.3-SNAPSHOT.jar
okapi-relational-0.4.3-SNAPSHOT.jar

but when I submitted the job  like this
spark/bin/spark-submit  --class 'org.opencypher.morpheus.examples.CaseClassExample'  --master  local  morpheus-examples/build/libs/morpheus-examples-0.4.3-SNAPSHOT.jar
I always face this error:
Exception in thread "main" java.lang.NoSuchMethodError: scala.App.$init$(Lscala/App;)V
at org.opencypher.morpheus.util.App.(App.scala:34)
......
This problem I think because the Scala Version and Spark Version  comparability but I installed every thing like the versions inside the gradle parameters as stated in the beginning.
thanks in advance for your help !

Hi Mohamed,
you need to put the fat-jar of Morpheus-Spark-Cypher into your classpath which can be found here: https://github.com/opencypher/morpheus/releases/download/0.4.2/morpheus-spark-cypher-0.4.2-all.jar


runtime: cannot ReadMemStats during GC

GC holds the worldsema across the entire garbage collection, which means nothing else can stop the world, even during concurrent marking. Anything that does try to stop the world will block until GC is done. Probably the most interesting such operation is ReadMemStats.
We should fix GC to only hold worldsema during sweep termination and mark termination. The trickiest part of this is probably dealing with GOMAXPROCS changing during GC, which will affect mark worker scheduling.
/cc @RLH

This issue is kind of a pain for CockroachDB because we use ReadMemStats() to get periodic heap stats. Because the ReadMemStats() blocks for GC to finish (and we've seen it take many seconds), we've had to collect these heap stats separately from the loop that sample other stats in our server (which we care about collecting periodically, and in a timely manner), and so now our heap stats are out of sync with those other stats.
FWIW, we'd rather have more approximate heap stats that we can collect cheaply than more accurate heap stats that can only be collected at specific points.

Note that there is a work around in client_golang now, see https://github.com/prometheus/client_golang/pull/568 (check the final state of the PR, not the whole discussion). It will be released any moment as v0.9.3.

Meaning: If you use prometheus/client_golang, you are good now. If you are doing it on your own, it might serve as inspiration.

Thanks for the reports of this happening in real systems. I knew this was a theoretical problem, but this is the first data I've had on it happening in production.
Making the stats approximate doesn't really help in this case. We're just doing some heavy-handed synchronization that we need to figure out how to break up.

Is it acceptable to cache and return the stats before GC starts?

I spoke with @aclements and there may be a simple way to do this. Most of the trickiness arises from dealing with GOMAXPROCS changing during the mark phase, but we can also ignore that case by just adding a new semaphore. Turns out we also have to retain the old behavior for trace start for other reasons.
I have a quick and dirty change which seems to work OK in all.bash locally. I'll upload it in a bit.

This issue is currently labeled as early-in-cycle for Go 1.15. That time is now, so friendly ping. If it no longer needs to be done early in cycle, that label can be removed.

@dmitshur I'm my reviewers. This should go in ASAP given how much trouble it gave us last release.
It should be a lot better this time though; the fix to this bug last time was a bit sloppy, and everything here has been re-done in a more principled manner (with a new benchmark).

@dmitshur I'm pinging my reviewers. This should go in ASAP given how much trouble it gave us last release.
It should be a lot better this time though; the fix to this bug last time was a bit sloppy, and everything here has been re-done in a more principled manner (with a new benchmark).


First iteration of the application pages

This adds application pages to the docs. Each application page contains a description (fetched from GitHub), links to the repo, puppet config and deploy scripts. If provided, it shows which team owns the applications.
The applications are configured using a single YAML file. The puppet/deploy/prod links are mostly auto-generated, but we allow them to be overridden in case of snowflakiness.
Screenshots!

Note that this is an MVP. The correct teams per repo can be added in subsequent PRs (I'm leaving them empty on purpose, so that more people can get involved).
Things we'd like to do in the future with these pages:

Showing the dependencies of an application
Showing examples of content published / rendered by the app
Show screen shots

https://trello.com/c/dr5JzgVD/22-mvp-for-application-pages

Love. It.


For standalone components - Need a reliable method to get the main Vue object

Currently I'm using this.$root.constructor within my component to get to Vue
But when using vue-router, this.$root is a VueComponent , so this doesn't work.
Object.getPrototypeOf(Object.getPrototypeOf(this)) would work, but I don't really want to do that, for obvious reasons :smile:
maybe I can have $Vue refering to the main Vue object?

How about var Vue = require('vue');?

I thought I might end up with different versions of Vue.
I think I can go with peerDependencies, thank you :smile:

If you use webpack, it should just refer to 1 version of script, instead of creating new on each require, no?

I think one cannot necessarily assume this.
When you add a component as a dependency and it has another vue as dependency then I think it should load that instead.

Ok, now it is a real problem.
When Vue is statically linked, for example from a cdn, I can't get it with require('vue')
Atop of this, when I have Vue additionally installed as a dep I won't even notice that require('vue') points to another instance and produce wired behavior (e.g Vue.util.defineReactive isn't working)
Furthermore it would allow component developers to get rid of the peerDependecy.

When Vue is statically linked, for example from a cdn, I can't get it with require('vue')

Obviously.. It's already on window.Vue in that case.

so what would be the reliable way?
if (window.Vue != null)
  Vue = window.Vue
else
  Vue = require("vue")

would still add vue to the webpack bundle without necessity or error when no vue is installed

You have to use different packaging strategies targeting different usage.
When distributing it for npm-based bundler usage (e.g. Webpack, browserify), there's no need to pre-compile it, just let the user import the *.vue file directly.
When distributing for use without build tools (e.g. global Vue from CDN), you need to wrap the whole thing as a plugin so that Vue can be passed via Vue.use().

In that case I would target statical linking for my component, I would have to distribute 4 versions

vue is statically linked, my component is statically linked - Vue.use + window.Vue
vue is statically linked, my component is webpack controlled - require + window.Vue
vue is webpack controlled, my component is statically linked - require + Vue use
both are webpack controlled - require

I will use this now:
if @$root.construtor? # is Vue instance
  @Vue = @$root.construtor
else # is Vue-Component instance
  @Vue = Object.getPrototypeOf(Object.getPrototypeOf(@$root)).constructor
```
But I really would appreciate a cleaner solution

Actually, the next version of vue-router will probably use a different api which uses a plain Vue instance as root. Together with Vuex it will look more like:
const root = new Vue({
  el: '#app',
  store: vuexStoreInstance,
  router: vueRouterInstance,
  components: { App }
})

+1 for that api change.

I'm looking at this issue again and am wondering what is the reason that you need reference to the global Vue inside a distributed component - can you explain the use case a bit more?

In vue-clusterize I need to access Vue.FragmentFactory, Vue.util.createAnchor and Vue.util.defineReactive to workaround the nested slot problem by basically building an own v-for, this can be avoided with the changes I proposed in #2507.
Actually I can't think of another use case.

Cool, seems like a very specific use case then. Since you already have a working (although hacky) solution, and the need can be eliminated by adding API elsewhere, I'm closing this for now.

I found another use case: singleton component.
For example an overlay which is used behind dialogs or modals. A singleton pattern allows a way better handling of z-index / click events than dealing with multiple instances.
This is my current implementation:
overlay = null
module.exports = (Vue) ->
  overlay ?= new Vue(require('./overlay-component')) # the overlay attaches itself to the body..
  return overlay
```
So to activate the overlay the calling component needs a ref. to `Vue`.

I would prefer a cleaner solution, but I see no easy way of adding singleton components to Vue..

I have another convincing use-case for a singleton component: toast
I made a mixin as a workaround getVue
so the usage will look something like this:
mixins: [require("vue-mixins/getVue")]
method:
  makeAToast: ->
      toaster = require("vue-toaster")(@getVue())
      toaster.toast({})

I would love to get around the getVue stuff for the user..

I think this should be reconsidered for 2.0 because of
vm.$set -> Vue.set and vm.$delete -> Vue.delete

The check you mentioned here actually should work, you just need to treat vue as an external when bundling your component: https://webpack.github.io/docs/library-and-externals.html#applications-and-externals

nonono - I will stick with my mixin solution. All others are unreliable and error prone.
My point is, with that API change, others will also have the need for the Vue instance and this will create some issues in the future.. (because all other solutions are unreliable and error prone :smile:)

Why is what I suggested unreliable?

imagine this dependency tree:

myProject

Vue 1.0.1
myComponent

Vue 1.0.0

require("vue") will give different versions of Vue in myProject and in myComponent - this could be very difficult to debug, especially as a maintainer of myComponent when you have no idea of myProject.
Such tree happens regularly when using npm link..
(But I also stumbled upon components which list Vue as a direct dependency)
this can be avoided by adding
resolve:
  alias:
    "vue": path.resolve("./node_modules/vue")

in the webpack config of the project, but I clearly prefer the mixin to that..

@paulpflug I believe if component specifies vue as a peerDependency, then npm (at least 3.x+) will never install Vue under the component, even when there's a version conflict.

sure thing, emphasis is on if
I have seen components with vue as direct dependency already..
This is very easy to fix - yes - but very difficult to debug, because there is no error / no warning if you accidentally use the wrong vue instance, it just won't work (I speak for Vue.util.defineReactive).
Regarding peerDependency - I often use npm link on my own repositories which have all devDependencies installed, so peerDependency is ignored and require("vue") will always deliver different instances - so I avoid it completely..
This Issue is not severe, not like I can't live without fixing this.
It might be a source for annoying mistakes in the future - we will see.
If I could close it again I would :smile:


The resolution property is never updated

not sure why #77 is not linked automatically ..

#77 is now merged, closing


Extend TravisCI plugin to allow notifications

Currently, the travis.yml template and TravisCI plugin do not allow users to configure notifications:
https://github.com/invenia/PkgTemplates.jl/blob/5cf93cc4d8ed5b0b6887982046066fec238774c2/templates/travis.yml#L3-L4
The TravisCI plugin currently allows for quite a bit of configuration, however all setting are currently controlled either via (1) a Bool or (2) in the case of extra_versions a simple Vector of versions numbers. In contrast, TravisCI notifications allow for a lot of customisation, so it's not obvious how to set this up via the TravisCI plugin.
To be concrete, here's an example of what i'd like to be set for new packages created from a Template:
notifications:
  email:
    recipients:
      -<EMAIL_ADDRESS>    on_success: never
    on_failure: always
    if: type = cron

(But again, TravisCI allows many options here).
Thinking out loud:

i wonder if there's a way to have a notifcations field, whether that should take some kind of Notification struct, and whether such a struct should work with different CI plugins (e.g. i think GithubActions also supports email notifications).
Alternatively I wonder whether this is better handled via e.g. a separate plugin the has a custom hook method which edits the travis.yml, like how the Tests plugin adds extra content to the Project.toml file. Although i wonder how to do that given the current travis.yml template file sets notifications already; i suppose it'd have to come with a new  travis.yml that removes the notifications bit from the current template.
Another option is a "half-way" between the above two: have a Bool that points to some other Notification plugin, analogous to how coverage works, e.g.- notifcations::Bool: Whether or not to send notifications.
  Another notification plugin such as `SomeCustomNotification` must also be included.

That said, the template file logic and Notification plugin(s) will still need to be more complex than is the case for e.g. CodeCov.
Yet another option is just to have a simple travis.yml template file for my particular use case e.g. that has a bit like:  recipients:
    {{#RECIPIENTS}}
    - {{{.}}}
    {{/RECIPIENTS}}

Although come to think of it i'm not sure how to do this... Perhaps a custom plugin the wraps a TravisCI but also has a recipients::Vector{String} field?

I'm leaning towards the second option above for my use-case, but i do wonder about the general case.

Here's what i went with for my use-case
@plugin struct Notify <: Plugin
    email::String =<EMAIL_ADDRESS>end

# `priority` should be lower than `TravisCI`, so that `Nightly` runs after `TravisCI`.
const PRIORITY = PkgTemplates.priority(TravisCI(), PkgTemplates.hook) - 1000
PkgTemplates.priority(::Nightly, ::Function) = PRIORITY

function PkgTemplates.validate(nightly::Nightly, t::Template)
    has_travis = any(p -> p isa TravisCI, t.plugins)
    has_travis || @warn "No `TravisCI` plugin. `Nightly` plugin will have no effect."
    return nothing
end

function PkgTemplates.hook(nightly::Nightly, t::Template, pkg_dir::AbstractString)
    add_notifications(nightly, pkg_dir)
    return nothing
end

function add_notifications(nightly::Nightly, pkg_dir)
    travis_file = joinpath(pkg_dir, ".travis.yml")
    isfile(travis_file) || @warn "No `.travis.yml` file found" travis_file
    if contains(read(travis_file, String), "notifications")
        @warn "Notification section already in `.travis.yml`. File may now be invalid."
    end
    notifications = """
    notifications:
      email:
        recipients:
          - $(nightly.email)
        on_success: never
        on_failure: always
        if: type = cron
    """
    open(travis_file, "a") do travis
        write(travis, notifications)
    end
    return nothing
end

plus a travis.yml file that doesn't contain notifications
This makes me think is
 notifications:
   email: false

the same as not having a notifications section?
If so, can we just remove that from the template file?

IIRC if you don't put a notifications section, emails are sent by default to the repo owner (not sure what happens for orgs) and it's really annoying.
Your approach definitely works, but the last option might be simplest. You can do it with user_view.
So your custom template file:
language: julia
#
# everything from the default file goes here except notifications
#
notifications:
  email:
    recipients:
      - {{{EMAIL}}}
  # etc

And a bit of code to write:
PkgTemplates.user_view(::TravisCI, ::Template, ::AbstractString) = Dict("EMAIL" =><EMAIL_ADDRESS>
Currently there's no way to get a "dynamic" email that depends on any runtime value in the Travis plugin or the Template... I've thought about adding some kind of meta::Dict{Symbol, Any} field to each plugin to make the user_view workflow more useful.


Enable CORS on server for the Swagger JSON

To enable the Swagger UI we will need CORS enabled for the Swagger JSON endpoint on the MapRoulette server.
This may help.

We don't need CORS to retrieve the main Swagger content from MapRoulette, but we do need it to enable testing the API endpoints from within the Swagger UI. Currently firing any API call from within Swagger UI gives a CORS related error, example:
XMLHttpRequest cannot load http://maproulette.org/api/v2/projects?limit=10&page=0. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://<IP_ADDRESS>:8080' is therefore not allowed access. :8080/#!/Project/list:1 XMLHttpRequest cannot load http://maproulette.org/api/v2/projects?limit=0&page=0. No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://<IP_ADDRESS>:8080' is therefore not allowed access.


Add support for Cypress framework and first e2e test using Cypress - from cypresse2e to cypresse2e branch

Set up and first test using Cypress framework.
same changes as #424
From fork cypresse2e to central cypresse2e2
Detailed instruction can be found here: https://www.notion.so/fightpandemics/Instruction-how-to-instal-and-use-Cypress-bc6b0443f7aa4e93bbbd092d1635b7a6
This test was written using page object pattern.
There are no merge conflicts.

Still error from fork?