Suggestion for bigger restructuring

While this material is good, I think it could be made even better by a restructuring.  There are two audiences which I think aren't served well (everything in this issue, I have said before but I don't think is written anywhere):

Those who already have sort of used git (we start with stuff they already know, git init, git add, and so on)
Those who know nothing about version control.

I've given some git intros to academic courses, and the usual problem is some people know a lot already, and can easily teach others if others became interested.
Once I tried to write a better plan, where the why and social design are front-loaded, and then the "how" is later.  It went something like:

Why code becomes a disaster without (lots of examples here, throw in some of the famous comics about it)
Use github web interface to see an existing project: explore the history, see contributors.  Give some exercises like "this line has a bug: who did it and when?", "how many contributors", "find version on this date".
Ideally, use browser to make a commit on existing project, maybe even a merge request (it's easy in browser, and shows cool stuff).  So, bring in some of the "git in the browser" stuff, but less structured, just to show people nice things.
Ideally something from git branch design.  Now the details, but there are good stories there and when I saw this, it felt like good motivation finally came.
Then switch to "git init" and so on...

All the intro parts is relatively non-technical so could be done in an hour maybe.  I'm sure it would save at least an hour later.
Additional ideas:

have people contribute to existing project first.  I guess this is a fairly common case and many people probably would start here first anyway (just for the web browser part)

If not used here, I would adapt these to either git-in-the-browser or some "git for normal people" type talk.

I really like that we start out in the browser to get a taste before we go into the "dryer" git init to get deeper understanding. In other words we will start out with a jam session on the web, then we practice a bit scales on our local instrument, then we regroup again in day two and play orchestra music together.

Idea for the in-browser tasting:

We start with an existing repo that contains a couple of commits and two branches with some easy code.
The project contains several obvious issues (bug in code, misleading comment, typo in documentation, missing license file, outdated usage example).
We browse it a bit and our first challenge is to figure out when exactly the bugs were introduced.
Then instructor shows how to fix one of the problems in the browser.
We split into groups and each group fixes one problem and files a pull request.
The goal of this is to get a bit of a taste and to see that we can work on the same file in parallel while recording traceable snapshots.
Project contains several files so that we see that there is a version uniquely identifying the state of the entire project.

More points:

All is done in browser.
It's perhaps a bit magic but we will explain what is going on later.
Master branch is protected (we start with good defaults).

In light of new Github politics, should we shift this much focus to the web (in this case Github) rather than universal Git stuff ?

I am not sure. But the goal would not be to explain GitHub in the first 30 minutes but to start with an existing repository. And existing repositories are most likely GH repositories. The goal would be to get a taste and motivation. I always found the git init start a bit harsh and dry without seeing the bigger picture first. Of course we will comment on the geopolitical situation after last weekend and of course we would emphasize that we could do the same thing on GL and friends. And eventually we might move over to GL but we have no time to do it now.

The point is that existing Git repositories are these days almost never "plain" Git repositories without any web around it. First contact point might be the web.

Previously we start from zero, build something up, and hope that eventually people realize that they need it. My goal here (and this is not only my idea, credits to Richard) would be that everybody understands "aha yes I really need this, this is relevant for me, I need to listen", before we do the first Git command in the terminal.

Yes, basically, the point isn't to teach github (even a week ago, we
would want to minimize the importance of github itself), but because
it's a good way to visualize a lot of people working on a project
together - they can at least see history, annotate of files, and the
way someone can make a branch and pull request and why this is nice.
Then the git commands make sense.
I think this is a good idea, and the trick is a good example and
making it as brief as possible.  One possibility is the coderefinery
repository for the lesson itself... also it's a case where making a PR
through the browser actually makes some sense.

Should this be demo only or already an exercise?

I would probably like to show something else than the lesson repo because I would like to demonstrate the situation that we spot a bug and want to see when it was introduced - this is not very relevant for lesson repo.

Also I want to show something that has a master branch, not gh-pages branch to connect better to the terminal work.

After some thinking I will draft an example repo that we will live-modify: all instructors will make a change concurrently, one of them (the presenter) will do one change on the screen. Then we browse a bit the history. Also experienced participants can already join. The reason for this is that it would be nice to show 1) that one can work concurrently and 2) a project with multiple authors. 2) is hard for me to create on my own :-)


It always duplicates the current row within the return statement when I exit insert mode after accepting its suggestion when I destructure props within function param (typescriptreact)

My current workaround is to accept the suggestion, but not exit insert mode where the cursor is, only after I navigate (bring the cursor) to the top of the file within insert mode, and pressing ESC there somehow doesn't ruin what I have within the return statement.
The plugin is working great in every other way for me!

That looks like Neovim. I can't reproduce your issue. I don't think this is a problem with the plugin.


Settings Section (Mobile/Desktop)

Public Profile (Will need to finish user profile to continue this section) wtt_front #300

[x] Image + Changing the image

Before uploading, users can preview what the image will look like.

Users can pick a generic image that Water the Trees has as an option.

Users can be banned for image types.

[x] First and Last Name

People who only have one name can be omitted for having to put two names

[x] Bio / About Section

Have 3 options when writing a bio- Save Draft, Submit Bio, Clear Bio

[ ] Change Cover Photo

[ ] Pronouns

[ ] Organizations / Teams Associated with (FUTURE PLANS)

[ ] Badges / Achievements to Display (FUTURE PLANS)

[ ] Allow for custom url ending per user. Can be default username or real name (FUTURE PLANS)

[ ] Display Name / Username (FUTURE PLANS)

Users can change their name on their profile or in settings (Two locations)

Personal Information

[ ] Gender

Female

Male

Non-Binary

Other

Write in

[x] Region / Country

Should not define what language the user wants to use

[x] Language (FUTURE PLANS / COMING SOON, LOCKED ON SETTINGS)

Not sure if tree species can be converted in other languages, but this can come later if it is an issue.

[ ] Time Zone (for water timer) (FUTURE PLANS / COMING SOON, LOCKED ON SETTINGS)

Depending on the time zone, notifications can be optimized to the most key times.

[x] Unit Type - Metric or Imperial- Notifications (FUTURE PLANS / COMING SOON, LOCKED ON SETTINGS)

[x] Email

Same as Push notifications

[x] Push Notifications

Notified on Browser

Trees you adopted

Trees in your area

Trees you favorited

Tree now adoptable in your area you favorited

Tree needs watering / maintenance

Team / Organization message

Weather hazard in your area (Wildfire, hurricane, tornado, etc.)

Security and Login (FUTURE PLANS)

[x] Password

[ ] Two Factor Authentication Login

[ ] Use Google to login in Option

[ ] Connected Devices (FUTURE PLANS)

Privacy and Data (FUTURE PLANS / COMING SOON, LOCKED ON SETTINGS)

[ ] Search Privacy (Hide from Browsers, Google, Firefox)

Be a check box

[ ] Data Personalization

Have cookies be adjusted to users comfort

[x] Delete / Deactivate Account

Red button stating "Delete Account" and below will be an underlined word for "Deactivate Account"

[ ] Download your Data

Regular Button

Accessibility

[ ] Dark Mode / Regular

A button that is dark mode on one side and regular that looks disabled.

[ ] Text Size

Will need to select text size from a dropdown menu or type in.

[ ] Lefty Support (Mobile Only)

Will be a button

Mobile Section for Support (WILL NEED TO FINISH SUPPORT ISSUE BEFORE PROCEEDING) wtt_front #304

[ ] Get Help

[ ] Feature Request

[ ] See Terms and Privacy

@zoobot & @jazhen want to begin the design of the settings section. Many features to be future plans or not be included.
Wanted to see if anything should be included or be removed as a setting before I get too into the design.

@zoobot Started the settings section where you would be able to delete your account. Also worked on notifications and password change. Is there anything else i should add or change?

Settings Complete for first MVP. See Figma for details.


Add filtering to Recommendation model

Implemented the find_by_product_a_sku_and_type method within the Recommendation model to enable filtering of recommendations by product_a_sku and recommendation_type, with results ordered by the likes attribute.

Recommend to add a line of "logger.info("Processing type query for %s  and %s...",product_a_sku, recommendation_type.name)" before return in find_by_product_a_sku_and_type() in models.py


failed to recover index for shard

Celestia Node version
0.10.4
OS
ubuntu 20.04
Install tools
No response
Others
No response
Steps to reproduce it
i am not sure when it happens, but we got some reports already (theres one from time to time, not too frequent) - some reported this after upgrade, for others not sure
Expected result
working normally
Actual result
ERROR        header/sync        sync/sync.go:211        syncing headers        {"from": 654447, "to": 667462, "err": "storing EDS to eds.Store for block height 654754: failed to check if root already exists in index: failed to recover index for shard F58D7B50D75014227977BAD142567483212F7ED322C7A8280F36CDBFC46DF8CD: EOF"}
Relevant log output
No response
Notes
No response

another one:


Restore wrapper (and install?) generation rules (conditionally?)

With #531 we're getting relocatable GHC builds and we therefore won't need any sort of wrapper scripts like inplace/bin/ghc-stage2 (when building with the make build system) in most situations (we won't need them on Linux, OS X and Windows).
Some OSes will probably still need/want them so it would therefore be nice if we could eventually revive the wrapper generation rules, and have them fire only when building a GHC for an OS that's not one of the 3 aforementionned ones.
The question of the install rules (which we get rid of in #531 as well) also is in the air. With #531 installation is as easy as shipping <build root>/stage1/{bin, lib, a few other files and dirs}". We can still consider offering a rule/command to this effect.

@alpmestan Thank you! Can we list all files that need to be included in an installation build rule, if we decide to add it?

@snowleopard Hmm, I don't have that list handy, but the current code for Wrappers.hs (see here for a time-proof link) has some comments that describe the things to be installed and even shows the logic that we could steal and just adapt to the changes we do in #531. Is that a good enough answer? Or should I try and find/come up with an actual list?

@alpmestan Yes, that's a good start. I just want to make this issue self-contained so that it could potentially be tackled by a newcomer.


Seeding not working in 2.23.0 in Windows

Bug description
When seeding the database, prisma/seed.ts doesn't seem to be getting called, despite saying that it seeded my database. I tried wrapping lines 30-37 in an export const seed = () => { ... }; and also with export default function() { ... }. In all three cases, none of the console.log() calls are logged, and the database is not updated. I also know that it knows prisma/seed.ts exists, as when I delete the file it errors. Reproduction steps are mostly just following the code at Start from scratch | TypeScript & MySQL | Prisma Docs and prisma-examples/seed.ts at latest · prisma/prisma-examples.
(Note: when switching the version of prisma and @prisma/client back to 2.22.1, bug no longer occurs and functionality is normal. Breaks again when switching back to 2.23.0)
How to reproduce

Generate a new nodejs project with yarn init
Run yarn add @prisma/client and yarn add --dev @types/node prisma ts-node typescript
Run prisma init
Set DATABASE_URL in .env file
Create tsconfig.json
Run prisma migrate dev --name init
Create seed.ts in folder with schema.prisma
Run prisma db seed --preview-feature
See output (no console.logs are called, database doesn't update)

Expected behavior
No response
Prisma information
.env:
DATABASE_URL="mysql://xxx:yyy@zzz/prismabugrepo"
DEBUG="*"

tsconfig.json:
{
  "compilerOptions": {
    "sourceMap": true,
    "outDir": "dist",
    "strict": true,
    "lib": ["esnext"],
    "esModuleInterop": true
  }
}

prisma/schema.prisma:
datasource db {
  provider = "mysql"
  url      = env("DATABASE_URL")
}

generator client {
  provider = "prisma-client-js"
}

model User {
  id          String   @id @default(uuid())
  joinedAt    DateTime @default(now())
  username    String   @unique
  displayName String?
}

prisma/seed.ts:
import {Prisma, PrismaClient} from "@prisma/client";

console.log("Top of script");

const prisma = new PrismaClient({
  log: ["query", "info", "warn", "error"]
});

const main = async () => {
  console.log("Start seeding...");

  const userData: Prisma.UserCreateInput[] = [
    {
      username: "user123",
      displayName: "User One Two Three"
    }
  ];

  for (const u of userData) {
    const user = await prisma.user.create({
      data: u
    });

    console.log(`Created user with ID ${user.id}`);
  }

  console.log("Finished seeding.");
};

main()
  .catch((e) => {
    console.error(e);
    process.exit(1);
  })
  .finally(async () => {
    await prisma.$disconnect();
  });

console.log("Bottom of script");

Console Output:
C:\Programming\prisma-bug-repro> prisma db seed --preview-feature
Environment variables loaded from .env
Prisma schema loaded from prisma\schema.prisma
Running seed from prisma\seed.ts ...

Your database has been seeded.
C:\Programming\prisma-bug-repro>

Environment & setup

OS: Windows 10 Version 20H2 (OS build 19042.985)
Database: MySQL
Node.js version: 16.0.0

Prisma Version
prisma               : 2.23.0
@prisma/client       : 2.23.0
Current platform     : windows
Query Engine         : query-engine adf5e8cba3daf12d456d911d72b6e9418681b28b (at<EMAIL_ADDRESS>Migration Engine     : migration-engine-cli adf5e8cba3daf12d456d911d72b6e9418681b28b (at node_modules\@prisma\engines\migration-engine-wi
ndows.exe)
Introspection Engine : introspection-core adf5e8cba3daf12d456d911d72b6e9418681b28b (at node_modules\@prisma\engines\introspection-engine-
windows.exe)
Format Binary        : prisma-fmt adf5e8cba3daf12d456d911d72b6e9418681b28b (at<EMAIL_ADDRESS>Default Engines Hash : adf5e8cba3daf12d456d911d72b6e9418681b28b
Studio               : 0.393.0

In case someone is stuck with this issue, I resolved this with the following:
prisma/seed.ts:

const prisma = new PrismaClient();

export const seed = async () => {
  // prisma upserts

  process.exit(0);
};
seed();

In case someone is stuck with this issue, I resolved this with the following:
prisma/seed.ts:

const prisma = new PrismaClient();

export const seed = async () => {
  // prisma upserts

  process.exit(0);
};
seed();

Weird... I've tried multiple variations of that and none of them seem to be working either. Do you know what part of that code resolves the issue? Could it be something else you did?

Adjusting my tsconfig leads to the same situation in this repo. With tsconfig.compilerOptions.isolatedModules active however, this error is thrown before even reaching my seed.ts:

@Cyntheon not sure.
I pushed what I did here if it can help you.
@ljosberinn I have isolatedModules=true as well. Had to include this script in package.json to fix this issue:
package.json
{
  scripts: {
    "ts-node": "ts-node --compiler-options {\\\"module\\\":\\\"commonjs\\\"}"
  }
}

I can confirm this regression. We will fix this.

@Cyntheon not sure.
I pushed what I did here if it can help you.
@ljosberinn I have isolatedModules=true as well. Had to include this script in package.json to fix this issue:
package.json
{
  "scripts": {
    "ts-node": "ts-node --compiler-options {\\\"module\\\":\\\"commonjs\\\"}"
  }
}

This worked for me

Are you all on Windows where seeding is not working? I updated the title of this issue to reflect this assunmption, so please speak up (and optimally open a new issue with exactly your situation).

Are you all on Windows where seeding is not working? I updated the title of this issue to reflect this assunption, so please speak up if that is not true (and optimally open a new issue with exactly your situation so we can track this separately!).

Yes it appears to be specific to Windows. My teammate is unable to seed our database (he's on Windows) while I am able to (I'm on macOS).

@janpio Confirmed. The only reported occurrences for RedwoodJS are specific to Windows.

Same issue too with 2.26

I added this script to my package.json, just as the documentation asks for:
"scripts": {
  "ts-node": "ts-node --compiler-options \"{\\\"module\\\":\\\"commonjs\\\"}\""
}

Besides this option in my tsconfig.json:
{
  "compilerOptions": {
    "isolatedModules": true
  }
}

After that I ran npx prism db seed --preview-feature, and my script in the seed.ts file worked.

Same issue too with 2.26

I added this script to my package.json, just as the documentation asks for:
"scripts": {
  "ts-node": "ts-node --compiler-options \"{\\\"module\\\":\\\"commonjs\\\"}\""
}

Besides this option in my tsconfig.json:
{
  "compilerOptions": {
    "isolatedModules": true
  }
}

After that I ran npx prism db seed --preview-feature, and my script in the seed.ts file worked.

Same issue too with 2.26

I added this script to my package.json, just as the documentation asks for:
"scripts": {
  "ts-node": "ts-node --compiler-options \"{\\\"module\\\":\\\"commonjs\\\"}\""
}

It´s important to have ts-node installed to execute the script.
And i added this option in my tsconfig.json:
{
  "compilerOptions": {
    "isolatedModules": true
  }
}

I execute npx prisma db seed --preview-feature, and my script in the seed.ts file worked.

@MarcosJBM glad that worked for you. We are reworking the seeding feature at the moment. The gist of it is that we want seeding to always work like that ts-node escape hatch, but with a clearer naming and guidance in the CLI. Would you be interested in testing a preview version of the feature and giving us your feedback? (that offer applies to anyone reading this message).

@tomhoule Assuming the preview version of the feature is<EMAIL_ADDRESS>it appears to work quite nicely on Windows! I am working with a dedicated database package that contains the schema and migrations that can then be imported by projects accessing the shared database and both in the database package as well as one depending project the setup appears to work as expected (including seeding on prisma migrate reset) :+1:

Super happy to read that :) Stay tuned for moe, but we hope to deliver something stable and without any surprise when db seed comes out of preview. It's a bit tricky to release because seeding is also used by prisma migrate dev, which is stable so we don't want to break it.

🗒 We heard the feedback and we are planning a redesign of db seed (currently planned to be released early September)
How it will work is that a prisma.seed property in the package.json of your project will be required if you want to use prisma db seed.
This property is where you will be able to put any command you want to execute your seed script.
More info/details & how to try it out now in:
https://github.com/prisma/prisma/issues/8732

This is now released - let us know if this works for you. Thanks!

After hours of research, only this worked for me. I've tried the other options to change package.json with no success.
Also, I am using masOS Monterey v12.
Thanks!

In case someone is stuck with this issue, I resolved this with the following:
prisma/seed.ts:

const prisma = new PrismaClient();

export const seed = async () => {
  // prisma upserts

  process.exit(0);
};
seed();

After hours of research, only this worked for me. I've tried the other options to change package.json with no success.
Also, I am using masOS Monterey v12.
Thanks!

None of those worked for me. This worked:
"seed": "ts-node --compiler-options {\"module\":\"CommonJS\"} prisma/seed.ts"

Use in package.json
"prisma": {
    "seed": "node prisma/seed.js"


"ob run" doesn't work with runBackendWith

The runBackendWith function allows you to supply a different runSnap function, but ob run does not appear to use this.

That's a known limitation at this point. Can you describe your use case a bit more? Perhaps we need to move more into the Backend type itself.


Bump scala-maven-plugin from 4.8.0 to 4.9.2

:mag: Description
Issue References 🔗

This pull request fixes #
Describe Your Solution 🔧

bump scala-maven-plugin from 4.8.0 to 4.9.2, with zinc bumped from 1.8.0(Nov 11, 2022) to 1.10.0(May 6, 2024)

Types of changes :bookmark:

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪
Behavior Without This Pull Request :coffin:
Behavior With This Pull Request :tada:
Related Unit Tests

Checklist 📝

[ ] This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 58.48%. Comparing base (28d8c8e) to head (149a12f).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6364      +/-   ##
============================================
+ Coverage     58.41%   58.48%   +0.06%
  Complexity       24       24
============================================
  Files           653      653
  Lines         39880    39880
  Branches       5481     5481
============================================
+ Hits          23296    23323      +27
+ Misses        14083    14062      -21
+ Partials       2501     2495       -6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Minor warning message thrown in logs, when compilation on Scala 2.13 :
Error:  -release is only supported on Java 9 and higher
(https://github.com/apache/kyuubi/actions/runs/8964924157/job/24623089910#step:8:138)
It's repeatedly shown in logs. It's not a blocker issue though.

Thanks, merged to master and branch-1.9.

Good to see it land finally

Yes, the main concern comes to the benefit with mordernizing the Zinc version.
Since last review, the Zinc has been bumped from 1.9.x to 1.10.x used with in the maven plugin. Zinc 1.10 brings the new analysis format for faster speed in reading and writing, see benchmark in https://github.com/sbt/zinc/pull/1350 .
The compilation warning ( https://github.com/apache/kyuubi/pull/6364#issuecomment-2099631757 ) still occurs when compiling on JDK 8 + Scala 2.13, but it's not a blocker issue.


[CI] Code formatting

PRs are getting noisey due to formatting differences. We should check in a formatter and run over the entire project.

Related to #288

Also field/annotation order/line breaking: https://github.com/nickbutcher/plaid/pull/331#discussion_r197653732

Related to #329 (in that for both we need to pick a format) but not a dupe.  This is more about checking in the Android Studio formatter so that everyone is running the same thing plus running over the entire codebase to reduce PR noise.

I think #345 and #346 fixes this issue.


Sure, I'll reply here once I have done that.

github.com/BibliotecaOvidiu

banned

oof got logged out


Locus redefinition option does not work.

Solene reported that the script skips running locus breaker BIS even if we change the config parameter to YES.

Since now the user must provide a value for the defined parameter in the configuration file, redefine_region, to run or skip the locus breaker BIS function. The accepted values for running this function are Yes or 1, and No or 0 for skipping it.


Document why you don't need SELECT FOR UPDATE in CockroachDB

Oracle docs: https://docs.oracle.com/cd/E17952_01/mysql-5.1-en/innodb-locking-reads.html
Postgres docs: https://www.postgresql.org/docs/9.0/static/sql-select.html#SQL-FOR-UPDATE-SHARE
In summary, in Oracle and Postgres, when you're doing a read and then an update on a row in a transaction, you need to use SELECT FOR UPDATE because the "regular SELECT statement does not give enough protection" (from the Oracle docs).
In CockroachDB, our default SERIALIZABLE isolation level makes this a moot point.
To do:

Add an FAQ on this.
Add SELECT FOR UPDATE as an extension on https://www.cockroachlabs.com/docs/stable/sql-feature-support.html.
Think of other places to call this out.

cc: @rolandcrosby, @awoods187

I don't follow the premise. Does SERIALIZABLE in cockroachdb work fundamentally differently that in PostgreSQL? How does cockroach know which record is going to be selected a-priori?

@ericharmeling this is SQL (hence your domain), but I think we can close this based on the fact that we're doing #6000.  Please re-open if you disagree or if I am missing something.


Youtube error message: "An error occurred. Please try again later." (Playback ID error.)

Hello,
When I click to start a youtube video for the first time, the following error message appears:
"An error occurred. Please try again later (Playback ID xxxxxx)”, where xxxxx is a random string of letters and numbers.
If I refresh the page with F5 key, the video starts correctly, but this message is kind of annoying...
I mention that I have Youtube Premium account.
This error occured after I installed ”Win11Debloat MAster” and I think that this app caused the problem, as it appeared on both the PC I installed it on (home PC and work PC).
Yhank you in advance for any support!
Vallex

Hiello,
this has nothing to do with Win11Debloat. Have the same problem on Windows 10. Problem occurred randomly, now nearly every first attempt watching a video fails.

@scheka, I think it has, I have windows11 on both the PC's I installed Win11Debloat, on both of them I get this error when I click on an Youtube video, I still got it some minutes ago

Heya,
I don't know of any way how this could be caused by the script. I certainly haven't run into this myself.
I do see that this is an issue that has been reported before, and there seem to be some reports of it in recent few days. See: https://www.reddit.com/r/youtube/comments/1dlygfu/an_error_occurred_please_try_again_later_playback/
What browser are you using? Have you tried a different browser?

Closing issue due to lack of information. From the info provided I can't think of any way Win11Debloat could cause this issue.


[PROPOSAL] Ensure automation on all repos that check license headers

What/Why
What are you proposing?
We have varying state of repos that check license headers. Do a campaign that will add license checkers in every repo in the org.
What users have asked for this feature?
We often merge features in various repos and I often have to comment that adding an ES license to new files is not needed for example.
What problems are you trying to solve?
Finding inconsistencies in license headers and fixing them manually.
What is the developer experience going to be?
Automation will ensure that all files in a repo have the right license headers, and ensure new code is checked in PRs for the same.

+1 on automation of license headers.
It should generally be very straightforward ... a standard header for new files, or a specific exclusion if custom headers are needed.
Someone should address #98 authoritatively first, however.


UX design for QnA in Multi-Lang

The inline QnA editing will be landed in composer. As LU/LG multi-lang have been supported in Composer now, we may leverage the similar design.
For lu/lg multi-lang support, we only need to translate the utterance or response. so we can use "intent name" or "lg template name" as the placeholder across the different languages and this will help us to do the language comparison in the list view . But QnA has more fine-grained in-place editing in list view .  Both question and answer need to be translated.  so it is hard to list out items comparison as what we delivered in lu/lg all up view.
At this moment, we did not introduce the trigger to hoist with specific QnA question, so we only need to take care about the whole QnA file translation experience .

@vivekkshankar @mareekuh @cwhitten , good news, the multi language support within one qna service has been released recently. So the QnA Multi-lang is unblocked and maybe we can start the work on the design?

Exciting! @cwhitten - This is a great oppty to see how we can better integrate QnA into the main Composer experience vs adding a 4th place for users to go to deal with translation/language management (Settings, LU, LG and potentially QnA).
Is Prashant still your contact on QnA or has this since switched to Somi Reddy?
@vivekkshankar let's talk before getting started.

I think this is done, no? @vivekkshankar


Allow escaping "," in paths for tail input

Currently there is no way to tail files that include a comma (,) in their file name. Switching to a neg-lookbehind regex should enable this.

Could you show me the path example?

Sure: /tmp/test,dev.log would be a vaild file name on unix system. In windows environments, a long filename (longer than 8 chars) may also contain a comma.

Hmm... support special case is not good for me.
How about using dummy's message like approach?
https://github.com/fluent/fluentd/blob/ced6387cd8f00feede48de2ceb005d72f9a477e9/lib/fluent/plugin/in_dummy.rb#L42
For ',' or other special case, use path ["p,ath1", "path2"].
This approach keeps to support path path1,path2 string parameter with split(',').

I've added an alternative 'paths' config setting, that would allow the form of configuration that you mentioned previously.
So now it's either
 path: "test.log, test2.log"
or
 paths: ["test.log", "test2.log"]
The latter form can then also include commas.

Can I help somehow to get this further?


log scheduled and published pages

always log when items are scheduled
always log when pages are published

Coverage decreased (-0.05%) to 99.946% when pulling d4bdb5c7d7e4f7dd630ca6ce2824e0a82397c50b on log-scheduled into 08a6fb353006ed450264a4f41a79c39ca23a5d19 on master.

Coverage remained the same at 100.0% when pulling ca0bd4a77be7cb728d34a5c068547d93d0bf9113 on log-scheduled into 08a6fb353006ed450264a4f41a79c39ca23a5d19 on master.

👍


Make more blockchain info persistent

Hey there,
I just learned that it is possible to call the http://localhost:1984/mine endpoint to simulate the mining of a block, which could have the potential to extend the way we use this tool to test our platform. However I noticed that the number of block mined isn't persistent, even with the persistent option set to true for new Arweave(...), which greatly reduce our use case. Would it be possible to make the information we get at http://localhost:1984/info persistent?

this was added to the current version


Fix segfault reading input packet stream (compiler type layout change?)

Fixes #176 (see linked issue for a description of what I think the problem there was.)
Adds an explicit copy_for_wrap() function to avoid the possibility that transmute_copy() has input or return types other than Context.

I'm not that comfortable with unsafe Rust or libavcodec, but hopefully this works as expected. :)

Adds an explicit copy_for_wrap() function to avoid the possibility that transmute_copy() has input or return types other than Context.

Instead of wrapping the transmute(s) in a function, to constrain the type parameters to those of your wrapper function, you can also specify the types explicitly:
diff --git a/src/format/context/input.rs b/src/format/context/input.rs
index 8d423bb..c2dbdf5 100644
--- a/src/format/context/input.rs
+++ b/src/format/context/input.rs
@@ -181,10 +181,10 @@ impl<'a> Iterator for PacketIter<'a> {
                        Err(Error::Eof) => None,

                        Ok(..) => unsafe {
-                               Some(Ok((
-                                       Stream::wrap(mem::transmute_copy(&self.context), packet.stream()),
-                                       packet,
-                               )))
+                               let context = mem::transmute::<&Context, &Context>(self.context);
+                               let stream = Stream::wrap(context, packet.stream());
+
+                               Some(Ok((stream, packet)))
                        },

                        Err(err) => Some(Err(err)),

Having a copy_for_wrap function publicly available is a bit awkward (even though it's unsafe). It doesn't actually even copy the Context, it just extends the lifetime of a reference to a Context.
I think I'd prefer the explicit transmutes, like in f41149fd951e01d5114b7bffdeeb9feb6e767942, because they don't introduce any new public API, and it makes explicit at each callsite that lifetime extension is happening (whereas it would be slightly obscured with copy_for_wrap).

I am wondering, given a Context is a libavcodec pointer and a reference counted destructor, if it would be better to implement std::clone and store clones of Context in Streams instead of storing an unsafe reference.

I can only speculate, but because a separate Stream is passed for every input packet, cloning the context would cause a new Rc for every input packet, which might have felt unnecessarily expensive during the initial implementation.

@tilpner That's for the detailed response, I appreciate it! The commit you linked looks good, and I can see the argument for keeping the unsafe operation explicit rather than hiding it.

I can only speculate, but because a separate Stream is passed for every input packet, cloning the context would cause a new Rc for every input packet, which might have felt unnecessarily expensive during the initial implementation.

Fair enough, makes sense! If I'm feeling ambitious I'll try to implement this and benchmark it out of interest, but I think you're probably right and it's implemented like this for a reason. :grin:

Thank you for the contribution! :)


Prop name consistency

🤔 What type of PR is this? (check all applicable)

[ ] 🍕 Addition
[ ] ⌨ Productivity
[x] 🐛 Bug Fix
[ ] 🔥 Optimization
[ ] ⚙ Configuration
[ ] 🌟 Quality Of Life
[ ] ✨ Enhancement
[ ] 📝 Documentation

📝 Description
Renames the server prop names/ids
🧐 The Rationale
consistent with the rest of the props
🎯 Key Objectives
rename the props
⏮ Backwards Compatibility
1.12.2
📚 Related Issues & Documents
N/a
🖼 Screenshots/Recordings
N/a
📖 Added to documentation?

[ ] 📜 README.md
[ ] 📓 Javadoc
[ ] 🍕 Comments
[x] 🙅 no documentation needed

Tell me once you are done and I'll merge.
Seems good!

Conflicts arise. It is recommended that you merge directly into the https://github.com/Cubed-Development/Modern-Warfare-Cubed/pull/256 Otherwise, it will increase Luna's workload in resolving conflicts

Tell me once you are done and I'll merge.
Seems good!

Ready, but i agree with Koud-Wind best to merge into https://github.com/Cubed-Development/Modern-Warfare-Cubed/tree/Rendering-Rewrite

Conflicts are resolved! There are now a bunch of smaller changes as it brings rendering-rewrite to be more up to date. Don't know if this is a good or not tho.

@Desoroxxx Awaiting your go-ahead.


configuration api: improve 'getConfiguration' message name

The new message name (workspace/getConfiguration) of the proposed configuration API doesn't align with existing messages. It uses a verb, where normally nouns are used.
Maybe better `workspace.configuration'
Same for the client capability

Agree, we should stick with nouns.

Actually we do have partly verbs already. publishDiagnostics, showMessage, ... But never for a get. So I will still change this. to not have a get in the message name.

Done.


chore: verify yarn lock

Description of changes
This adds PR verification that yarn.lock does not drift from package.json declarations.

Issue #, if available

Description of how you validated changes
Successful execution

Checklist

[ ] PR description included
[ ] yarn test passes
[ ] Tests are changed or added
[ ] Relevant documentation is changed or added (and PR referenced)
[ ] New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
[ ] Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #11941 (d32e054) into dev (984c0f8) will decrease coverage by 3.46%.
 Consider uploading reports for the commit f7bf33f to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##              dev   #11941      +/-   ##
==========================================
- Coverage   49.45%   45.99%   -3.46%
==========================================
  Files         692      819     +127
  Lines       33424    37669    +4245
  Branches     6840     7732     +892
==========================================
+ Hits        16529    17326     +797
- Misses      15370    18647    +3277
- Partials     1525     1696     +171

Impacted Files
Coverage Δ

...y-appsync-simulator/src/resolvers/unit-resolver.ts
90.32% <0.00%> (ø)

...ages/amplify-appsync-simulator/src/schema/index.ts
70.68% <0.00%> (-1.25%)
:arrow_down:

...tor/src/velocity/util/transform/dynamodb-filter.ts
4.93% <0.00%> (ø)

...ync-simulator/src/velocity/util/transform/index.ts
21.05% <0.00%> (ø)

...ackages/amplify-category-auth/src/commands/auth.ts
0.00% <0.00%> (ø)

...es/amplify-category-auth/src/commands/auth/help.ts
0.00% <0.00%> (ø)

.../amplify-category-auth/src/commands/auth/import.ts
0.00% <0.00%> (ø)

...c/provider-utils/awscloudformation/import/index.ts
31.02% <ø> (ø)

...vice-walkthrough-types/cognito-user-input-types.ts
100.00% <ø> (ø)

.../awscloudformation/utils/auth-defaults-appliers.ts
91.17% <ø> (ø)

... and 401 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Loading view item at the end of list

I have noticed that when i limit the size of the list (by filtering api) -
@GET("3/discover/movie?sort_by=vote_count.desc&vote_count.gte=1000&primary_release_year=2000&language=en-US")
when i get to the end of list - loading view is shown instead of nothing or custom separator (return@insertSeparators MovieModel.SeparatorItem("End of List !! "))
if (after == null) {
// we're at the end of the list
// return@insertSeparators //MovieModel.SeparatorItem("End of List !! //")
return@insertSeparators
}

The issue has been resolved.
The issue was due to the MoviePagingSource was loading trying to load the next page even when the last page is reached.
We need to calculate the nextPage based on the total pages in MoviePagingSource.
LoadResult.Page(
    data = movieListResponse.results!!,
    prevKey = if (nextPage == 1) null else nextPage - 1 ,
    nextKey = if (nextPage <= movieListResponse.totalPages!!)
        movieListResponse.page?.plus(1) else null
)

Now you can show custom separator at the end of the list.
if (after == null) {
     // we're at the end of the list
    return@insertSeparators MovieModel.SeparatorItem("End of list")
}


Expose attributes of widgets to Flutter Driver

Use case
When retrieving a SerializableFinder, it would be helpful if we could find out if a button is enabled/disabled by accessing the button's attributes.
There are software requirements for example where a button can only be enabled for clicking if text fields are filled out.
Proposal
Add a function in FlutterDriver or SerializableFinder where we can retrieve the attributes in a form of map or other data structure you think is better for this. We see these attributes in Flutter Inspector and it would be help us in our tests if we could make use of these attributes.

Not sure if this is news relative to when this issue was opened, but I think I found a decent way to do it:
Future<bool> isEnabled(FlutterDriver driver, SerializableFinder finder) async {
  Map widgetDiagnostics = await driver.getWidgetDiagnostics(loginSubmitButton);
  return widgetDiagnostics["properties"]
      .firstWhere((property) => property["name"] == 'enabled')["value"];
}


ReplicatorQueue should not implement the Replicator interface

The ReplicatorQueue should not implement the Replicator interface.
See https://github.com/Adobe-Consulting-Services/acs-aem-commons/issues/2604#issuecomment-864406901, thanks to @YegorKozlov for spotting it.

Do we really want to track each required change for #2604 individually? IMHO for consumers it just makes a difference if all four underlying issues are fixed.

@kwin I think that we cannot "fix" all problems of #2604 that easy as this one.


Update Blog “2016-12-17-making-sense-of-the-scaas-new-flavor-wheel”

Automatically generated by Netlify CMS

👷 Deploy Preview for courageous-flan-363bed processing.

Name
Link

🔨 Latest commit
42e80be9c1ff186eaf4c3319fd36da2fcd50c930

🔍 Latest deploy log
https://app.netlify.com/sites/courageous-flan-363bed/deploys/64ac60c58a739300088dc5d3


VM doesn't accept literal function type as type bound.

Example:
class C<T extends num Function(num)> {
//class C<T extends numfun> {
  final T func;
  C(this.func);
}
main() {
  var c = new C<int Function(int)>((int x)=>x*2);
  print(c.func(21));
}
typedef num numfun(num x);

This fails to compile. If switching to the commented out line instead, it will work, so the problem is with recognizing the new function type syntax in the type parameter bound, not function types in general.

Is this legal syntax? dart2js, dartanalyzer and dartdevc also seem to fail on this test.

Yes, it's valid syntax. The grammar in the informal specification still uses the type production for the bound, and that production allows an immediate function type.
There is a constraint that the bound must not be a generic function type (one that takes a type parameter), but that's not a syntactic constraint, and it doesn't apply to this example.

@lrhn Can you please point to the document stating the constraint about the bound not being a generic function, so I can pick the correct wording in the error message? Also, is there a regression test submitted for this issue? Thanks.

The constraint about generic function types is discussed already in Leaf's DEP. The constraint has not been mentioned in recent documents, due to a communication glitch. I have updated the informal specification of the Generic Function type Alias feature to include the constraint, at the end of the section on static analysis.

Thanks for the pointers!

Analyzer and CFE seem to accept this syntax now.  Analyzer produces the error '(int) → int' doesn't extend '(num) → num' and that error is missing from CFE, but since this issue is filed about syntax I think it's resolved.


Add: normalize_text function

normalize_text is a very important function which is often used when calculating quasi metrics. Example: quasi_exact_match etc.

The instructions for CONTRIBUTING.md isn't here yet but you'll have to run black . at the root directory for formatting.

I see, sure.


fix: floating menu positioning incorrectly

Closes carbon-design-system/carbon-addons-ics#
styling of floating menus was incorrect. Menus shouldn't need to be relatively positioned to the body to end up in the correct place, they should be absolutely positioned.
Menu position was not being recalculated in all cases, namely if the 'trigger' button doesn't move at all after it is created (the trigger button in the 'Tooltip click' story moves by ~1px the first time it is clicked)
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

took a guess with 8 for the width of the caret, looks pretty much correct:


Feature/search internal logs button

:tada: This PR is included in version 1.27.0 :tada:
The release is available on:

v1.27.0
GitHub release

Your semantic-release bot :package::rocket:


Fix computation of the Barlow Twins loss gradient

When computing the gradient for the off diagonal terms, I forgot one transpose:
A' * B = C, but B' * A = C'

I am running the example again. Hopefully, it will only perform better.
I will update the accuracy results in the example if they change.

Regarding the build error on macOS, It seems we will have to update to Pybind11 v2.10.1. From their changelog: "This is the first version to fully support embedding the newly released Python 3.11."
However, I am surprised that macOS on GitHub actions is already using Python 3.11.

The results didn't change, but I have peace of mind now.

Hmm, somehow the tests pass again...

Huh. Yeah Mac OS cloud environments have never been super reliable for me. I wouldn't worry about it.


blob.go: adapt code to use helpers for paths

I actually have a better plan. Do you mind creating methods like pathForContainer and pathForBlob then we can get rid of all those duplication of fmt.Sprintfs and have the path logic only in one place.

Well now that is better alright!

@ahmetalpbalkan are you ok with these methods being called, and the results used directly without any intermediate "path" variable? There are no error returns with fmt.Sprintf; it always returns a string.
so eg.
uri := b.client.getEndpoint(blobServiceName, b.pathForBlob(container, name), url.Values{})

instead of
path := fmt.Sprintf("%s/%s", container, name)
uri := b.client.getEndpoint(blobServiceName, path, url.Values{})

yeah, these can go to blob.go as global non-exported functions. there's no need to make it functions of BlobStorageClient.

Actually we dont need a pathForContainer, do we? Just pathForBlob.

you actually do. what happens when tomorrow we want to address containers as /{container} in the code? :) that logic must be only in one place and it should be testable. that's why these helpers are crucial.

eh... well I guess you're right. I was focussed on the present. :}

@ahmetalpbalkan , this is what I have so far (minus the tests). Let me know what you think.
Note: I've added a / at the front of the constructed paths because that's what will happen anyway (see http://golang.org/src/net/url/url.go?s=12230:12259#L452, line 481). I'm shortcutting the code, and making things clearer imo.

Nope please don't add that. That duplicates the job of net/url package and might have introduced bugs elsewhere. I wouldn't do that unless it's very necessary.  (Did you also run the test suite with this change?)

Yes I did (added that in my comment after I first posted it). I don't think it really duplicates the work of the code in net/url, though. I see that line as just a precaution, or "helper" of sorts ("if the slash isn't prepended, we'll prepend it").

Okay I guess it's okay unless it makes requests with double slashes (//) or generates GetBlobURL or SAS URL like that. These are already covered by the tests. I will take a final look and then merge. Thanks @jf.

Oh and I realized pathForBlob can reuse pathForContainer. :smile: also having simple unit tests would be really great. Thanks.

ha, I never really considered that! Do you want to keep them separate, though? or are we worrying too much?
I'll get some tests in.

ok I've just added the tests. Had to figure out (took some troubleshooting!) why no matter what I did, the tests I added weren't running. So it turns out I found a bug in blob_test.go, and fixed that too. I'm choosing to keep the fix in a separate commit, because I think it's important enough to point out. Prior to this, we weren't running the test for blobSASStringToSign() (and it was wrong to boot, too), apparently!

@jf can you sign a CLA at https://cla.msopentech.com/ ?

Please rebase to include the CI commit, otherwise test will fail.

@jeffmendoza is there a more specific privacy policy for developers/open source contributors? I don't see how getting my address, for example, is necessary

Looks like there is a link at the end of the page to here: https://msopentech.com/privacy-policy/

I'm aware and have already looked through it. That's a generic one for all of "MS Open Tech" - "Msopentech.com and other Microsoft Open Technologies, Inc. (“MS Open Tech”) websites and services of MS Open Tech that collect data and display these terms, as well as its offline product support services.". Perhaps some of these will have a legitimate reason for asking for an address.... but as a "pure github contributor and nothing else", I see no reason for Microsoft to ask for my address.

Anyway, I've filled in the form. But haven't received any email yet. Is it automated? or manual? (so ie. a delay is normal)

@hopetobelievein is CLA approved for @jf ?

@jf Looks like our new system just took over, can you try: https://cla2.msopentech.com/

Ok I'm going to give it one more try. But if this doesn't go through, I'm out for submitting PRs.

@jeffmendoza is CLA approved for @jf?

I am approved already, @ahmetalpbalkan . But dunno if this is good enough for you, or if you're required to hear from one of the folks you've asked first (in which case, we need to wait on them).

@jf ah okay, it is just I don't have access to the interface that shows if you're approved or not. I did not realize you got the approval email from the context above.

@jf Thanks for bearing with us


Add missing default layout

When creating a project with the expressive skeleton, the layout is not loaded. This adds the default layout so it will be loaded.

@xtreamwayz Make sure you update the skeleton installer config to reflect the new alpha release. :smile:


Allow reading from files when in scripting mode?

[X ] I have read through the manual page (man fzf)
[X ] I have the latest version of fzf
[X ] I have searched through the existing issues

Info

OS

[X ] Linux

Shell

[X ] zsh

Problem / Steps to reproduce
I would like to write a program that invokes fzf as a script by passing the "--filter" argument, and collects the output lines. Unfortunately, fzf checks if it is connected to a TTY and changes its behavior to not read from files anymore when there isn't one:
https://github.com/junegunn/fzf/blob/master/src/reader.go#L100-L114
This was surprising/seems like an unnecessary restriction that seriously hampers scripting. The manual says about --filter that When used with --no-sort, fzf becomes a fuzzy-version of grep. But grep doesn't stop working when not connected to a TTY. So I'm wondering if fzf could behave the same in either case.

I don't understand what your problem is.
# Works as expected
seq 100 | fzf -f 55

# Works as expected
cat <(seq 100 | fzf -f 55)

# Let's define the default command that is used to generate the input list when fzf is not reading from STDIN
export FZF_DEFAULT_COMMAND='seq 100'

# Works as expected
fzf -f 55

# Works as expected
cat <(fzf -f 55)

Hi @junegunn -- all of those examples work properly because you're running them in a shell, which has a TTY.
But not every program running on your system is attached to a TTY. If I'm running some such process on my machine, and that process tries to launch fzf using normal system calls, then the util.IsTty() call I linked will return false and different behavior will result.

Hmm, I guess you're in this situation:
# Works as expected
FZF_DEFAULT_COMMAND='seq 100' bash -c 'fzf -f 55'

# Empty result
FZF_DEFAULT_COMMAND='seq 100' bash -c 'fzf -f 55' < /dev/null

In the latter case, fzf sees that the standard input is not tty, so it decides to read from /dev/null which gives nothing.
This is unfortunate but we can't remove the existing TTY check as we have to differentiate between fzf and some-command | fzf. So you have to explicitly specify the source command to make it work.
# Works
bash -c 'seq 100 | fzf -f 55' < /dev/null

grep is not any different in this regard.
# Gives 55
bash -c 'seq 100 | grep -f 55' < /dev/null

# Empty result
bash -c 'grep 55' < /dev/null

FYI, you can find the default command used here:
https://github.com/junegunn/fzf/blob/00f4551a7b9edda202f15f43e694f949f04927de/src/constants.go#L59-L65

Hmm, are you sure there's no other way to differentiate the case where reading from stdin is desired? I think that the isatty call is not really it...
For example, many tools I've seen pass a special flag like -- to cause it to read from stdin.
grep is like this, it only reads from stdin if you pass a single dash -, or if no file arguments are given: https://linux.die.net/man/1/grep. This allows you to use grep normally from a non-TTY script.

Technically, fzf is reading from STDIN just like grep, only that STDIN is /dev/null.

Using a Unix filter without any input doesn't make much sense in scripting contexts.
#!/bin/bash

# What do we expect here?
head -10

# Grep foo from what?
grep foo

And fzf here is working just like other filter programs in non-TTY environments. The only thing we miss here is the default find command that many users override with a custom $FZF_DEFAULT_COMMAND.
$SHELL -c "$FZF_DEFAULT_COMMAND" | grep foo
$SHELL -c "$FZF_DEFAULT_COMMAND" | fzf -f foo

Like I said above, I don't think we can remove the TTY check, but if you have a better idea to address the different use cases without breaking backward compatibility, please open a pull request.

Using a Unix filter without any input doesn't make much sense in scripting contexts.

Well, both head and grep "normally" accept command line arguments to tell them what file(s) to process, and they only use stdin when those are not provided. The difference with fzf is that it doesn't take a directory argument by default (or at all) --  the directory it uses is implicitly the current working directory. So it can't currently differentiate this way.
To be a good Unix-y tool, it should be possible to achieve the "normal behavior" even when a TTY isn't attached. In this case, the "normal behavior" seems to be searching the files in the current working directory.
If you don't want to change the default --filter behavior, what about a flag like --nostdin that forces it to read from files rather than stdin?

If you don't want to change the default --filter behavior

What exactly are you proposing here? Can you make --filter option still work as expected in the following scenarios?
export FZF_DEFAULT_COMMAND='echo foobar55'

# Should print foobar55
fzf --filter foo

# Shouls print 55, not foobar55
seq 100 | fzf --filter 55

they only use stdin when those are not provided.

I don't see what point you're trying to make here. You can provide any input to fzf using pipe or redirection.
ls -al | fzf
fzf < <(ls -al)

# or any file
fzf < ~/.bashrc

This is fundamentally not any different from how the other tools take path arguments. The only difference is that you want to omit input to fzf, while you don't expect to do so with the other tools.
You should see a bare "fzf" command just a shortcut for terminal users who don't want to repeatedly type input command, and fzf is just fine without it.

what about a flag like --nostdin that forces it to read from files rather than stdin?

That's an option, but it feels fairly niche to me, as the only benefit is that it saves you from typing the default command that generates the input. Is there any reason you don't want to write the input command? Can you elaborate on your use case?
fd --type f | fzf -f foo

I agree that this inconsistency is unfortunate but I'd like to see if there's a smarter way to handle this without adding an esoteric option that very few will ever use.
# Works as expected
FZF_DEFAULT_COMMAND='seq 100' bash -c 'fzf -f 55'

# Empty result
FZF_DEFAULT_COMMAND='seq 100' bash -c 'fzf -f 55' < /dev/null

Well, for what it's worth, I think a good and Unix-like scripting mode would look like this:
# Important: none of these depend on a TTY being present or not

fzf --filter=foo . # Searches .
fzf --filter=foo DIR # searches DIR

fzf --filter=foo # Tries to search stdin, finds nothing and exits with code 1
search_command | fzf --filter=foo - # Searches stdin (note the dash)
search_command | fzf --filter=foo # Searches stdin

The proposal here would be to add a required directory command in scripting mode, and search stdin if it's not provided. This would bring it more in line with head, grep, etc. It would only take effect when scripting mode is activated with --filter.
Alternatively, if you want to change nothing about the current behavior, adding a new --nostdin flag would at least provide a way for non-TTY processes to get the normal file search behavior.
(You suggested pasting the default find command and then piping it to fzf, but that's pretty user-unfriendly, because it's super long and I'd have to dig through the code to find it. Imagine if you had to type a long find command before being able to use grep...)
Anyway, I ultimately decided not to use fzf from a script because of other issues (I need a way to limit results--in particular I'd like it to stop searching once it already finds N good candidates so it doesn't spend forever searching a large directory). But hopefully these comments can be helpful to you.

I ultimately decided not to use fzf from a script

Good call. fzf was originally designed to be an interactive program and --filter option was an afterthought and I don't think it's really useful.

because it's super long and I'd have to dig through the code to find it.

I just want to point out that there's absolutely no reason you should use the exact command. You can just use ls | fzf, or find . | fzf.

Imagine if you had to type a long find command before being able to use grep...

Well, you do have to type some kind of find command if you want to grep a "path".


Add a meta description for better SEO

Addresses #407 and #409, which asks for a meta description and a language specifier for search-engine optimisation.
Thanks for this easy first issue ❤

Thanks so much @conorvenus ! I really appreciate the help. Look for your shout-out in the release notes!


Adding item multi-select

Allows control-click to select more than one item in Dive.
Sends custom event to clients when selection changes, indicating the data
indices of all selected items.

@jimbojw This is an initial commit for #74 adding basic multi-select. Doesn't yet have a facet-box single click select all items, and doesn't highlight selected items.
Let me know if you think the API for clients is a good one. We have a user that will want to react to new selections by doing something based off of the indices of the selected items.


MMB: Draw dots as map markers with location name

Remove segmentLocations from graphql BookingInterface type
see comment for more info

@RobinCsl @jvaclavik 🚀

@tbergq One comment and then 👍& 🚀


Consolidate types and fixes

This PR tackles item number 4 in #197.

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #204   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           7      7
  Lines         195    208   +13
  Branches       55     54    -1
=====================================
+ Hits          195    208   +13

Impacted Files
Coverage Δ

src/createExplorer.ts
100% <100%> (ø)
:arrow_up:

src/index.ts
100% <100%> (ø)
:arrow_up:

src/loaders.ts
100% <100%> (ø)
:arrow_up:

src/cacheWrapper.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47d8951...e1f774c. Read the comment docs.


Are languages other than English supported?

Version of flutter_calendar_carousel
1.4.6
Feature Request
Are languages other than English supported? for ex. Urdu?
If not, how can I set custom weekday names?

Pass the location string of the language you want to apply to the argument locale.
Urdu is like ur.
If it doesn't work,
The day of the week in that language is not supported from flutter.
If so,
Create WeekdayBuilder in your code and convert weekdayName .

Thanks a lot. It's working!


XTB import fails with TypeError: Cannot read properties of null (reading '1')

Hello.
I'm using the latest 0.16.0 version and when I try to import the XTB transactions, I get the following error: TypeError: Cannot read properties of null (reading '1')
This is the last block of the import plus the error:
{
  iD: '519422100',
  type: 'Swap',
  time: '21.03.2024 13:30:19',
  symbol: 'DIS.US',
  comment: 'Swap of position #994025001',
  amount: -142.12
}
/app/src/converters/xtbConverter.ts:114
                const quantity = parseFloat(match[1]);
                                            ^

TypeError: Cannot read properties of null (reading '1')
    at <anonymous> (/app/src/converters/xtbConverter.ts:114:45)

Node.js v20.15.1

And on the csv, the corresponding line of the message and the next one (not sure if the error is about the block already presented or when picking the next one) is:
519422100;Swap;21.03.2024 13:30:19;DIS.US;Swap of position #994025001;-142.12
519422099;Profit/Loss (FX/CFD);21.03.2024 13:30:19;DIS.US;Profit of position #994025001;500.79

Hi! I've checked the converter and the Swap and Profit/loss records are not recognized correctly in the XTB converter.
Could you tell me what these records are, and what they are supposed to do? Like, is Profit/loss some kind of dividend? When I know how to handle these records, I can add them to the converter for future processing. The alternative is adding them to the ignore list.
Thanks for your help!

Hey. Thank you for the really fast response!
These are connected to CFDs orders.

SWAP: Is the price you have to pay for opening the CFD (so, is, in my outsider view of the issue, a fee you pay for holding the CFD and it's paid at the moment you take profit (or loss) from it).
Profit/Loss: Is calculated at the time you close the CFD and it can be negative or positive (so, basically the same as the oucome of a normal trade).

Thanks for the explanation. So am I correct to summarize that a swap could be seen as a separate Fee record inside Ghostfolio, or as a fee attached to the Profit/Loss record, which in turn can be seen as a Buy/Sell record inside Ghostfolio?

Yes, I would say that the best way is if it could be attached to the same trade that has the Profit/Loss record.

I've done something similar with DEGIRO so should not be a problem. Will try and work something out this week and get back to you!

Thanks, that would be stellar!

Sorry for the late response. I've just added support for this. Could you try and test it with the beta image?
Some notes: I've tagged the CFD as a sell order in Ghostfolio. The fee record will be attached to it. I don't think it's possible to know/determine how it would be registered as a CFD with a loss/profit. So I decided it would probably be a sell order. Please let me know if this is how you would like it registered, or if there needs to change anything. Thanks!

Hi there, sorry, I was busy yesterday.
So, the exporter finishes successfully, but then, ghostfolio complains the file to import is wrongly formatted (see attachment).
I don't mind sending you the output JSON file through PM if you think it helps.

So now the unit price mapping does not work at all, that's not helpful :-)
Could you maybe send me the input CSV you used for this? So then I can check it locally and try and make it work again.

Hi @jbmorgado, any change you can get back to me and provide me the input you used? Thanks!

Closing due to inactivity.


Use int instead of long to keep CSV row number

Generate TooManyEntriesNotice (error) for files that have more than MAX_INT rows. Such large files would require too much memory and cause OOM.

Thanks! The change looks good. Could you please add a bit more information in the first comment on what impact the change has (e.g. memory savings, etc)? Also, should we use something more conservative than INT_MAX [0], maybe restricting to 500 million entries in a single file or 1 billion? @isabelle-dr do you have any opinion on this?
[0] INT_MAX is 2'147'483'647

@asvechnikov2 what is the proportion of datasets than have > 500 million entries?

@isabelle-dr I think the biggest I saw was under 100 million entries, so it should be safe to assume that there are none for > 500 millions (not even close)

We deprecated NOTICES.md, now we centralize all the docs in RULES.md.

This is a risky practice. RULES.md already has almost 3 k rows and it has to be maintained manually. Saving this file in IDEA takes several seconds. I would suggest to drop this file completely and generate docs based on comments.

@aababilov agreed that RULES.md is a pain to maintain.  I don't recommend opening it in IDEA but instead a simple text editor.  I've explored generating the file from comments directly and have a local patch that automates a big chunk of it, but it's not quite fully there.


No Documented way to actually get a graph

Docs show the ability to create a graph, but trying to access it does not currently seem possible outside of the first session when it's created.
Collections are accessible via the bracket syntax, but graphs are not. There's no obvious method for doing this either.

Graphs are accessible using the bracket syntax just like collection by through the .graphs dictionary of a Database object: database.graphs[<graph_name>]


Remove reference to const-fn feature of cortex-m. Closes #242.

r? @jamesmunns
(rust_highfive has picked a reviewer for you, use r? to override)


Azure SQL server name has uppercase

Turns out that you can create Azure SQL server with name that contains uppercase, but if you have geo-replica and try to failover and the secondary that you're trying to failover to has uppercase in server name, you'll get error and won't be able to failover!
Here's documentation that says server name shouldn't have uppercase: https://docs.microsoft.com/en-us/azure/azure-resource-manager/management/resource-name-rules#microsoftsql
Portal prevents you from creating server with uppercase in name, but doesn't throw error if you do deploy server via ARM templates.
Probably here you should convert server name to all lowercase:
https://github.com/brwilkinson/AzureDeploymentFramework/blob/main/ADF/templates-nested/azSQL.json

Hey @ntabris thanks for the info 👍
I moved the ARM json to a new branch over the weekend. Then in dev/main branches I archived the ARM/Json files off. I wasn't planning to delete them straight away, however I can bring them back and maintain them if you like?
I was thinking of just using Bicep templates moving forward.
Either way I'll make is update.

I have no objection to you archiving the ARM files; the ARM docs (plus some occasional trial and error) are adequate for me to figure things out, though I do appreciate having your ARM files still available as a reference, so an archive branch for them sounds good!

I will leave it over here for now: https://github.com/brwilkinson/AzureDeploymentFramework/tree/armjson/ADF
All new and migrated templates are in a single directory now for Bicep
https://github.com/brwilkinson/AzureDeploymentFramework/tree/main/ADF/bicep
They are plug and play against the old templates ... except you just need to tweak the deployment scripts a little to deploy .bicep instead of .json extensions other than that they use the exact same inputs and parameter files Etc.
Also you don't need to stage/upload the bicep files to storage, only the DSC/Script extension files.
Anyway it took me a few months to migrate all of my JSON to Bicep, so I doubt that would be a project that would be too exciting for a production migration, given the amount of templates that you have. I mean it's Type 2 fun.
You could just swap out your Deploy ALL scripts to Bicep... since bicep can deploy both JSON and ARM. That way you can migrate some to Bicep (or over time) and add new templates as Bicep. That would be fairly straight forward.
My Bicep deploy all are here:
https://github.com/brwilkinson/AzureDeploymentFramework/blob/main/ADF/bicep/00-ALL-SUB.bicep
https://github.com/brwilkinson/AzureDeploymentFramework/blob/main/ADF/bicep/01-ALL-RG.bicep
The nested deployments on those, which are modules can point to JSON templates or Bicep templates.


[NL] Start sentences with capital letters

When starting a sentence with the attribute name, :attribute is replaced by :Attribute so it starts with a capital letter.

Thank you, but #700


Updated: teamspeak 3.5.0

${}

20ead11b-ca15-460a-8466-b755c6cd554e

Newer version of teamspeak (3.5.2) is now available in master. 00243c2fd17173746d2fea18b014fe56f933772d


LSP does not recognize throw wild imports

Description
NeoVIM version: 0.5
Django project
# models.py
from django.contrib.gis.db import models

class Test(models.Model):
    field = models.BooleanField() # Error line: "BooleanField is not a known member of module "

# django.contrib.gis.db.models.__init__.py

from django.db.models import *  # NOQA isort:skip
from django.db.models import __all__ as models_all  # isort:skip

__all__ = models_all + aggregates_all
__all__ += [
    'GeometryCollectionField', 'GeometryField', 'LineStringField',
    'MultiLineStringField', 'MultiPointField', 'MultiPolygonField', 'PointField',
    'PolygonField', 'RasterField',
]

# django.db.models.__init__.py
from django.db.models.fields import *  # NOQA
from django.db.models.fields import __all__ as fields_all

# django.db.models.fields.__init__.py

__all__ = [
    ..., 'BooleanField',  ...]

class BooleanField(Field):
    ...

Neovim version
NVIM v0.5.0
Build type: Release
LuaJIT 2.1.0-beta3
Nvim-lspconfig version
No response
Operating system and version
macOS 11.4
Affected language servers
pyright
Steps to reproduce

npm install -g pyright
Set pyright language server in NVIM

# init.vim

Plug 'neovim/nvim-lspconfig'

lua << EOF
require'lspconfig'.pyright.setup{}
EOF

Actual behavior
Currently I have an get a definition error but code works good. Also you can see imports in description.
Expected behavior
No import errors. Module attributes should be resolved.
Minimal config
Plug 'neovim/nvim-lspconfig'

" LSP  settings
lua << EOF
require'lspconfig'.pyright.setup{}
EOF

Health check
health#lspconfig#check
========================================================================
## Checking language server protocol configuration
  - INFO: pyright: configuration checked.

LSP log
https://gist.github.com/parfeniukink/1f20cb51cb4819e621c15afb17f1679a

This sounds like a Pyright problem rather than a Neovim problem. Especially if other imports are working as expected, and things like code completion works fine.


Unlocalize the routes

Hello,
For now my site is using "en" and "fr" languages, "en" by default.
When I switch the lang to french the url is localhost/fr
Is it possible to have the site in french or any other language and have the site still on localhost/ ?
I didn't find the answer in the doc, sorry if I missed it.
Thanks

I don't understand the question sorry

Currently, if I open localhost/post/1234 , the post will be in english, if I change the language to french, it will open localhost/fr/post/1234
Is it possible to change the language to french and still have the url as localhost/post/1234 ?
Without the /fr being shown

@HoekWax all the i18n routing part is part of Next.js. I recommend taking a look at the Next.js documentation. There are 2 strategies:
Sub-path Routing
Sub-path Routing puts the locale in the url path.
i18n.js
module.exports = {
    locales: ['en-US', 'fr', 'nl-NL'],
    defaultLocale: 'en-US',
}

With the above configuration en-US, fr, and nl-NL will be available to be routed to, and en-US is the default locale. If you have a pages/blog.js the following urls would be available:

/blog
/fr/blog
/nl-nl/blog

The default locale does not have a prefix.
Domain Routing
By using domain routing you can configure locales to be served from different domains:
i18n.js
module.exports = {
    locales: ['en-US', 'fr', 'nl-NL', 'nl-BE'],
    defaultLocale: 'en-US',

    domains: [
      {
        domain: 'example.com',
        defaultLocale: 'en-US',
      },
      {
        domain: 'example.fr',
        defaultLocale: 'fr',
      },
      {
        domain: 'example.nl',
        defaultLocale: 'nl-NL',
        // specify other locales that should be redirected
        // to this domain
        locales: ['nl-BE'],
      },
    ],
 }

For example if you have pages/blog.js the following urls will be available:

example.com/blog
example.fr/blog
example.nl/blog
example.nl/nl-BE/blog

If you want to use the same locale for the same page (although this is not recommended), you will have to opt to manage it yourself using next-translate's I18nProvider.

Thanks I'll look into this


Facilitate vscode/chrome debugging

npm run serve
Added this to allow the web server to be started without the browser.  npm start  launches the default browser which in the case of chrome doesn't have remote debugging enabled by default.  I found my self closing the browser to open another one from vscode with the debugging enabled.
npm start keeps the same function for backwards compatibility.
vscode launch
Added vscode config to launch chrome in remote debugging mode and allow breakpoints to be set on the ts files.  I realise this is editor specific but it is so useful and vscode is very popular.
Now all you do to get going is
git clone https://github.com/flatpickr/flatpickr.git
npm install

Click  on the debug icon and click 'Launch Quick Start'
I can document this in a separate PR
Open to comments and review
Tested on windows 7 and macos

I see i committed yarn.lock sorry.
Whats the best way of reverting that?

I've split this up for clarity

Hi @mikes-gh,
Nice stuff! I'd like to raise the following stuff for discussion:

I would vote not to push a set of files specific just for one editor (I am talking about the .vscode folder). Instead, it might make sense to have the configuration written inside an instructions .md file specific for vscode.
Regarding opening Chrome with a debugging connection open, that's pretty awesome. I wonder if it could be done for other editors or IDEs automatically. If not, it could be added to the instructions file(s) I was mentioning above. I would do it for WebStorm

I was thinking about the index.html problem. I am assuming it was removed because people kept updating and pushing it. I think we should do something like remove it from .gitignore, add it to the repo and then add it again to .gitignore so it can be downloaded, but not pushed all the time. Is that feasible? I never tried it

I think theres an npm package that opens chrome on mac windows and linux I'll look it up
Would you be happy to commit the npm serve part of this PR?
Its not vscode specific but it is helpful and low impact.

I have a solution for the index.html comming in a few minutes

I was thinking about the index.html problem. I am assuming it was removed because people kept updating and pushing it. I think we should do something like remove it from .gitignore, add it to the repo and then add it again to .gitignore so it can be downloaded, but not pushed all the time. Is that feasible? I never tried it

Sounds like it might work.
The way I do it in #1741  it allows us to track the template if we ever want to modify it.

Heres a proposal.
Open chrome with remote debugging on if available using chrome launcher
Otherwise default to current behaviour and let rollup server plugin launch browser ( it uses openr)
I can do that in build.ts fairly easily.
Then I can do a document for vscode launch config to attach to debugger

Editor's and chrome remote debugging

@mikes-gh this is awesome.
I agree with @viorelsfetea though in terms of making this as editor-agnostic as possible. Launching a chrome with debugger sounds like a perfect way to achieve that. And for editor-specific debugging enhancements, documenting in CONTRIBUTING.md is the best way to go.

Having looked into it further it seems that editors can setup their own http servers and invoke chorme with debug themselves as well.  In this case npm start gets in the way a bit.
So starting chrome in debug mode might get in the way.
Probably their are 3 scenarios

Run rollup and watch for code changes. (npm ?)
Run rollup, watch and serve e0697ba35c782db3346343de406d1f6e64411e3c (npm run serve)
Run rollup, watch, serve and launch browser (if chrome launch in debug) (npm start)

While we think about it would you accept the e0697ba35c782db3346343de406d1f6e64411e3c as a separate PR.
That would allow me to do a vscode getting started in another PR

So to clarify
One PR Run rollup, watch and serve e0697ba (npm run serve)
Another PR to enhance Chrome launch in debug if available

OK so this PR is a bit of a red herring.  I found out the reason I had to close all browsers before launching a debug session is becuase I had my chrome user data dir set in GPO (windows policy). This meant none of the debuggers including chrome-launcher could start a debug session after the first window was open.
FWIW I did get chrome launcher working but not sure if its necessary now
  if (launchBrowser) {
      try {
        const launchedChrome = await chromeLauncher.launch({
          startingUrl: "http://<IP_ADDRESS>:8000",
          port:9222,
          maxConnectionRetries:1,
          userDataDir: "C:\\Users\\mikes\\AppData\\Local\\Temp\\",
          logLevel: "verbose"});
        console.log(`Chrome debugging enmabled on port ${launchedChrome.port}`);
        launchBrowser = false;
      }
      catch {
         opener("http://<IP_ADDRESS>:8000");
      }
   }

For now I will just do the vscode ldebug documentation.


Not working

The stream is not working anymore please check it

Hi @shinebarbhuiya. I haven't maintained this project for quite a while. Will look into it when I get time.


Time to live on assertion

Show a system default 'time to live' on the assertion of a subject, allow delegated admin to set/change the time to live. E.g. the Researcher assertion expires on

From #44:

The IdE Provider should be able to set/change this expiry.


Hidden fields in edit view since Nova 1.3.2

laravel/framework: v5.7.26
laravel/nova: v1.3.2
epartment/nova-dependency-container: 1.1.1
When editing a resource, the dependent fields are hidden by default and require the trigger field to emit a change in order to display again.
This happens since Nova 1.3.2.

I had the same problem. When I take Int values to quotes it started working.


Can't use variable when schema define something as boolean

Describe the bug
When something is define as boolean in the schema, like ignore_errors when the value is set by a variable, vscode show an error telling Incorrect type. Expected "boolean".yaml-schema: BeremothTaskModel, even with the filter bool to force the type of the variable.
To Reproduce
Create a task like:
- name: "Demo error"
  fail:
    msg: fail except in check mode
  ignore_errors: "{{ ansible_check_mode | bool }}"

Expected behavior
No error about the type, at least when the type is forced (if | bool is specified this trigger a warning in the default configuration of ansible-lint, not without, so it'll be better if this isn't needed).
Platform:
Be sure vscode and extension are the latest versions and report here the
operating system you used. If you used remote-ssh or WSL. Please check if the
bug can be reproduced on Linux or MacOS.

OS: Archlinux

Another problem link to that kind of definition:
When this is use in a tasks, pre_tasks or post_tasks of a playbook, like:
- hosts: all
  gather_facts: False
  pre_tasks:
    - name: test
      fail:
        msg: test
      ignore_errors: "{{ ansible_check_mode | bool }}"
  roles:
    - test

This show two errors:

the type of ignore_errors, like said previously,
one on the task level: Missing property "action".yaml-schema: BeremothTaskModel. The error is not present when ignore_errors is define by true or false.

Indeed that is a real issue because if we enable use of str in addition to bool it will fail to identify real bugs like plain strings.
My guess is that we should create a JinjaStringModel which would only allow strings that are jinja2 constructs, basically requiring something like {.*} as jinja could have {#, {% and {{.
Does anyone have a better idea?

I can't reproduce this working off of source ( ansible-language-server 71d759ddc976b45fbd9f47ed9eff3065a47bdf20, vscode-ansible 5ef7df70ea5834b3b163c37149153027f543ffbf ) or from the latest from the marketplace.
I tried looking through the schema definitions, but I didn't find where we forced this to be a boolean. I thought it was possible that this error was coming from the YAML vscode extension, but that didn't reproduce it either.

For resolving the underlying desired result (analysing the type of the Jjinja return and validating that), ansible+jinja is too powerful for simple schema verification to properly analyse. Adding a JinjaStringModel IMO doesn't help that much with the analysis, as it is a subtype of all types. That is, ignore_errors needs to accept bool | JinjaStringModel, and retries needs to accept int | JinjaStringModel, so a JinjaStringModel can be used almost anywhere, and doesn't really convey type information. Worse, it's a "valid" value regardless of the type that the JinjaStringModel actually returns. We could have a Generic form of the type (something like int | JinjaExpr<int>). But now we have the problem of knowing the return type of a Jinja expression. And if we already have that, we don't really need yaml schema validation; we can just raise that validation from whatever is determining the type of the Jinja expressions.
It turns out that It's not too hard to inspect a Jinja AST:
>>> jinja2.Environment().parse("{{ true }}")
Template(body=[Output(nodes=[Const(value=True)])])
>>> jinja2.Environment().parse("{{ ansible_check_mode }}")
Template(body=[Output(nodes=[Name(name='ansible_check_mode', ctx='load')])])

We could then look up the symbol in a table of symbols which would be defined at that scope. We might be able to share some of that code with Ansible itself. Although I suspect some refactoring would be necessary, as we're interested more in the provenance and type of variables than their values. One easy (ish) trick to do type validations is to traverse the program, but instead of keeping track of values in assignments we keep track of their types. For example, if we had set_fact: { "x": 5 } instead of us storing {"x": 5}, we store {"x": int}.

Closing this because the codebase changed completely since the bug was reported. We no longer use YAML/JSON schemas to validate these files.


Publish this plugin to the Intellij plugin repositories

It's already there https://plugins.jetbrains.com/plugin/8564-spek


📃: ADD A NEW QUIZ GAME🧠✨

🔴 Title :QUIZ GAME
🔴 Tech stack :HTML, CSS, JS
🔴 Objective :ADDITION OF NEW GAME
🔴 Summary :I would like to add a new project to the website
📸 Screenshots

✅ Details to Include When Taking the Issue:
Name :Shriya Dindi
Participant Role (Specify the Open Source Program name, e.g., GSSOC, Hacktoberfest, etc.):
GSSOC, Hacktoberfest

Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

Sorry, someone is already working on this. Do not be demotivated and raise a new issue.


Projects in the horizontal view not clickable

When viewing projects in the horizontal view, there is currently no way of clicking into the single project page.  It should act like the grid view and allow you to click in to each specific project.

I got this.

Fixed in #150


Can u support Azure Open AI APIs?

The SDKs for Azure OPEN AI n OPEN AI are different.
Azure requires a few more credentials. Can you please support this?
Meanwhile please let me know where all changes needed to support Azure APIs. Will make the changes and file a PR.

Hi @vikrant-sahu , supporting different LLMs and LLM providers, other than OpenAI is on our roadmap.
We would really appreciate it if you make the changes to support Azure Open AI.
The files that you need to change:
All of the agents and evaluators create the LLM object when they are called by using the get_model() function that is defined inside the model/chat_model.py. You have to change that file to add the support for Azure OPEN AI.
We are also using openAI embeddings, so you might want to change that as well. which is used inside pinecone.py and dataherald_sqlagent.py files.

@vikrant-sahu Azure OpenAI is now supported seamlessly without the need for any code changes. You can simply set the 'api_base' in both the 'sql_generation' and 'nl_generation' endpoints.


Add BPF verification checker test to ginkgo suite

Add the verifier test script to the regular ginkgo testsuite. If a datapath change is likely to cause verifier complexity issues, then this specific test should catch it.

test-me-please

Joe, that is what I said, instead of having all of this in cilium helper, you can use a custom report writted into AfterFailed function, so no change in the helper at all.

@eloycoto ah, so that cancels the default helper? I didn't realise this.

@eloycoto to be consistent with other test failure output, here's what the afterfailed would end up looking like (git diff):
$ git diff
diff --git a/test/runtime/verifier.go b/test/runtime/verifier.go
index<PHONE_NUMBER>40..53f193ec81b9 100644
--- a/test/runtime/verifier.go
+++ b/test/runtime/verifier.go
@@ -17,6 +17,7 @@ package RuntimeTest
 import (
        "fmt"

+       "github.com/cilium/cilium/test/config"
        . "github.com/cilium/cilium/test/ginkgo-ext"
        "github.com/cilium/cilium/test/helpers"

@@ -46,7 +47,16 @@ var _ = Describe(verifierTest, func() {
        })

        AfterFailed(func() {
-               vm.ReportFailedWithoutCilium("clang --version", "uname -a")
+               if config.CiliumTestConfig.HoldEnvironment {
+                       GinkgoPrint("Skipped gathering logs (-cilium.holdEnvironment=true)\n")
+                       return
+               }
+               GinkgoPrint("===================== TEST FAILED =====================")
+               commands := []string{"clang --version", "uname -a"}
+               for _,cmd := range commands{
+                       GinkgoPrint(vm.Exec(cmd).GetDebugMessage())
+               }
+               GinkgoPrint("===================== EXITING REPORT GENERATION =====================")
        })

        AfterAll(func() {

Are you happy with this? Otherwise I think that my current approach is fine.

@joestringer as soon you apply that change I think that it'll be simpler. Thanks

@eloycoto the helper will be simpler in favour of the test boilerplate being more complicated, but there's just one user right now so it doesn't need to be a helper. I'll fix this up.

test-me-please


Fix to InkSparkle rendering with a non-grayscale splash color

InkSparke's colors are incorrect: The colors are converted into Vector4 in RBG order, not RGB. As a result, a red splashColor produces a red splash as expected, but a blue splashColor makes a green splash and a green splashColor a blue one.
Fixes #104312.
Pre-launch Checklist

[X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
[X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
[X] I signed the [CLA].
[X] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[X] I added new tests to check the change I am making, or this PR is [test-exempt].
[X] All existing and new tests are passing.

Fix included in https://github.com/flutter/flutter/pull/110552


Write a program for deletion in a linklist in c language

put the file in  c folder as  LinklistDeletion

Assign me this task "Write a program for deletion in a linklist in c language "

bro, there is no need to get assign and just put pr star this repo and follow me

and send ur pr

please check my pr
thank you


Checksum mismatch

A Homebrew user reported that the installation fails because of a checksum mismatch on the current version 0.7.0 of Clock.saver. I can corroborate:
==> Downloading https://github.com/soffes/Clock.saver/releases/download/v0.7.0/Clock.saver-0.7.0.zip
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/17547174/6c9e3172-023c-4e1e-833d-998e49c0751a?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20211206%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20211206T101935Z&X-Amz-Expires=300&X-Amz-Signature=7ff421687218baf94dcef72dae406aee03f7e85e7ce2a9668e67637200fcf2c3&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=17547174&response-content-disposition=attachment%3B%20filename%3DClock.saver-0.7.0.zip&response-content-type=application%2Foctet-stream
Error: SHA256 mismatch
Expected: 9497e774695cadfb25fb6ad1b5689a110f806041b34d3b536b862d653de8bca4
  Actual: a5559b1bcb20ae5bc473e16e6842618aa3a51ed17e9dc583a069ed1af5931180

The latest change on the cask definition was:
df911976cc 2021-03-21 05:06:19 +0100 clocksaver: add livecheck (#101682) Markus Reiter.
Checksum was confirmed good by CI then. Did you update the file in place since then or is something else going on?

Wasn't aware it was on Homebrew. I might have updated it. I think the Developer ID cert expired awhile back. I'll try to get around to making another build soon.

Oh great! Thanks!
Sam

On Dec 7, 2021, at 11:41 AM, neutric @.***> wrote:

Closed #22.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.

@neutric in case it matters, I did release a new version (0.7.1) today. The previous version's Developer ID certificate was going to expire soon. I didn't update the previous release's binary. Definitely won't do that again!

Thanks Sam, I opened a PR to update the cask. Should be merged later today.


Add new copy and checkmark svg icons

Release Type: Non-Breaking Feature
Fixes https://x-team-internal.atlassian.net/browse/XP-3331
Description
Add new svgs to SvgIcon component for the new  copy and checkmark icons that have been added to the latest designs.
Checklist

[x] set yourself as an assignee
[x] set appropriate labels for a PR (In Review or In Progress depending on its status)
[x] move respective JIRA issue to the IN REVIEW column
[x] make sure your code lints (npm run lint)
[x] Flow typechecks passed (npm run flow)
[x] Snapshots tests passed (npm run jest)
[x] check cleanup tasks (https://github.com/x-team/xp/labels/cleanup) and take a suitable small one (if exists) in a related area of the current changes
[x] component's documentation (.stories.js file) is changed or added accordingly to reflect any new or updated use cases or variants usage
[x] if any snapshots have been changed, verify that component still works and looks as expected and update the changed snapshot
[x] manually tested the app by running it in several different browsers (Firefox, Chrome, Opera, Safari, MS IE/Edge, etc.) and checked nothing is broken and operates as expected!

Steps to Test or Reproduce
Check the component at https://x-team.github.io/xp-ui/?path=/story/ui-components-svgicon--basic-color
Impacted Areas in Application
SvgIcon
Screenshots

^^ See new green color above with updated check mark and new copy icon at end

As for the baseGreen to green change, we'll do that in a separate PR that Bernado will send soon. Good comment and not an issue for current PR 👍

Hey @rayepps There's actually one bug you introduced with your changes to XP app. There's a bug with transparency. When making changes to existing things, it's prudent to also ensure we didn't introduce regressions to existing application parts that do use those things you've changed.
Here's a screen recording of one of such places where we use checkmark icons.

Not saying it's your fault or anything since you're still new to the project, but the point is to remember to verify when anything you're changing/removing/updating is being used in XP app so we can visually test that ourselves before making a change.


ReferenceError: COLOR_WHEEL is not defined

Install and run on node 6.9
npm install color-scheme
let scheme = new ColorScheme();
        scheme.from_hex(mainColor)
            .scheme('triade')
            .distance(0.7)
            .variation('pastel');

Error:
ReferenceError: COLOR_WHEEL is not defined

+1

Should be fixed with v0.0.7 (just published). Please let me know if it's still an issue.

Actually, just tested this locally and it looks fine so I'll close.


remoteSigner plugin added to wallet

This adds option to plug in different Signers inside Wallet.
If no Signer is provided daemon uses exiting signing wrapped in InnerSigner.
This closes #482
@tiero @altafan please review.

Can we add an integration test with a remote signer in another process?
It can be elements-cli or another pkg/wallet but different process


Word Break.cpp

Assign this issue to me!

Done @SHIVANATHRIHARIKRISHNA

I have submitted the pull request for this issue. Please review and merge


RunTimeWarning while running WSD/Lesk

I run this code, and get the output quoted below
from nltk.wsd import lesk
sent = 'I went to the bank to deposit my money'
wrd = 'deposit'
print lesk(sent.split(), wrd)

/usr/local/lib/python2.7/dist-packages/nltk-3.0.0-py2.7.egg/nltk/compat.py:475:
RuntimeWarning: Argument <type 'str'> is not an unicode object.
Passing an encoded string will likely have unexpected results.
return transliterate(method(self))

Synset('down_payment.n.01')

In Python 2, 'x' means x is a sequence of bytes, not a unicode string. Try u'I went to the bank...' and u'deposit'.

Actually, maybe my example was over-simplified. In my code, the sent variable gets data from a file that has unicode characters

Could you update NLTK to the latest version, the nltk.wsd code was changed after NLTK 3.0.0.
Does the code like:
synset = lesk(sent.split(), wrd)  # instead of printing the result, just store it

yield the same warning?
Actually, it seems that the warning is raised when the word (wrd in your example) contains non-ascii characters, and the synset is being printed. In this case the magic of getting an  ascii string out of a unicode string throws a warning. Could you check what word triggers the warning?
I've tried your example on Python 2.7 but didn't get any warning.

It seems that the problem is in Synset repr https://github.com/nltk/nltk/blob/develop/nltk/corpus/reader/wordnet.py#L963
@python_2_unicode_compatible
class Synset(_WordNetObject):

    ...

    def __repr__(self):
        return "%s('%s')" % (type(self).__name__, self._name)

I can't come up with an example that triggers the warning, but I see why it's triggered. If you show an example that does trigger a warning, I'll be able to fix this behavior.

@hwsamuel Ah ha, I think i know what happened.
Did this error:
/usr/local/lib/python2.7/dist-packages/nltk-3.0.0-py2.7.egg/nltk/compat.py:475:
RuntimeWarning: Argument <type 'str'> is not an unicode object.
Passing an encoded string will likely have unexpected results.
return transliterate(method(self))

Synset('down_payment.n.01')

occur because you did this:
from nltk.wsd import lesk
sent = 'I went to the bank to deposit my money'
wrd = 'deposit'
print lesk(sent.split(), wrd)

Or did you do something like:
from nltk.wsd import lesk
with open('infile.txt', 'r') as fin:
    for sent in fin:
        print lesk(sent.split(), 'deposit')

If you have done an open('infile.txt', 'r') in python2 the default encoding is not 'utf8' because of strange str() representation when you print. Try this instead:
from nltk.wsd import lesk
import io
with io.open('infile.txt', 'r', encoding='utf8') as fin:
    for sent in fin:
        print lesk(sent.split(), 'deposit')

@hwsamuel does the io.open() resolve your problem or is the wsd module still creating problems?

I did the former, i.e. without opening a file

@hwsamuel , use io.open and the problems should be resolved. This is a good reference for dealing with text I/O in python: http://stackoverflow.com/questions/5250744/difference-between-open-and-codecs-open-in-python =)

The problem does seem to be related to print. If I do the following, the program gives the desired output without any errors.
from nltk.wsd import lesk
sent = 'I went to the bank to deposit my money'
wrd = 'deposit'
lesk(sent.split(), wrd)

@hwsamuel Possibly, it's a problem with locale , default encoding, or how you control the I/O. Always use the encoding parameter when using io.open() and that should minimize encoding issues when dealing with text.


Roles

someone should pull this down and run through the app.  I accidentally did a bunch of work on the master branch after rebasing cypress3 and the roles branch onto it.  I got everything put back into the correct location and it looks good but still .....

closing this because the branch has been rebased from master after not being merged for sometime