onEnd handler for Audio Sprite seems bugged.

Hi Adi, I was playing recently with an Audio Sprite and I'm getting some weird behaviors after adding onEnd handler. I was able to reproduce it using your sample. To do so:
1) In _audSprite = new WaudSound("assets/sprite.json", {webaudio: false}); update webaudio value to true, so we can play few sounds from a sound sprite at the same time.
2) Add onEnd handlers:
_audSprite.onEnd(function(snd:IWaudSound) {trace("Glass finished.");}, "glass");
_audSprite.onEnd(function(snd:IWaudSound) {trace("Bell finished.");}, "bell");
_audSprite.onEnd(function(snd:IWaudSound) {trace("Canopening finished.");}, "canopening");

3) Add another magic button with this function as a handler:
function playAllTheThings() {
	Timer.delay( function() {_audSprite.play("glass");}, 100);
	Timer.delay( function() {_audSprite.play("bell");}, 200);
	Timer.delay( function() {_audSprite.play("canopening");}, 300);
}

So after pressing magic button I expect to see all 3 traces in JS console. Unfortunately I see Canopening finished 3 times. Am I doing something wrong or it's a bug?

Hey @SlawomirMazgaj it's definitely a bug.
Are you expecting onEnd to fire on loop sounds as well?

It's fixed in the latest release 0.5.8 and onEnd will not fire for loop sounds.

Wow, that was quick, thanks.
We don't really use onEnd for looped sounds so 👍

Verified fixed in version 0.5.8


Skip if exists...

Any thoughts to having a "skip if output already exists" option to dsub?  I'm finding myself chaining several operations together (e.g. index file, run analysis) and it would be nice not to have to wrap it with " if !gsutil ls" blocks.  I'd imagine that it would only submit the job if the output didn't already exist in storage.

Try the --skip flag:
  parser.add_argument(
      '--skip',
      default=False,
      action='store_true',
      help="""Do not submit the job if all output specified using the --output
          and --output-recursive parameters already exist. Note that wildcard
          and recursive outputs cannot be strictly verified. See the
          documentation for details.""")

Ah, thanks.  Didn't realize it was already there.
On Wed, Oct 11, 2017 at 12:02 PM, Matt Bookman<EMAIL_ADDRESS>wrote:

Try the --skip flag:
parser.add_argument(
'--skip',
default=False,
action='store_true',
help="""Do not submit the job if all output specified using the --output
and --output-recursive parameters already exist. Note that wildcard
and recursive outputs cannot be strictly verified. See the
documentation for details.""")
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/googlegenomics/dsub/issues/80#issuecomment-335914433,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKBQyGJhXBopZPazc-zZplPYIUjL0b7Pks5srRDbgaJpZM4P19t7
.

--
Joe Slagel
Institute for Systems Biology
<EMAIL_ADDRESS>


Broken Client Library Documentation Link in README.md

Description of the issue
The link to the Client Library Documentation in the README.md file is broken. Clicking it does not lead to the expected page.
Broken Link
The current link points to: https://cloud.google.com/java/docs/reference/google-maps-routing/latest/overview
Expected Behavior
The link should direct users to the most up-to-date Google Routes API Client Library Documentation page.
Additional Information
Please verify whether there is an updated URL for this link and correct it in the README.md file.

I'm afraid that there are certain links currently broken.
Duplicate of https://github.com/googleapis/google-cloud-java/issues/10057


Magic sets: Bounded variables

Incorrectly bounded variables in predicates

Good for me! Can we merge?

Good for me! Can we merge @gzanitti ?

Yeap 👍


Release 0.4.2

<!-- Make sure you have read http://napalm.readthedocs.io/en/latest/contributing/index.html --!>

Coverage remained the same at 84.581% when pulling 5026e143877948c89abd2957476fd103dd03641c on mirceaulinic:RELEASE0.4.2 into ded637af9350af068ea846565e41ae79c34a1434 on napalm-automation:develop.

+1


[deck_polygon] implement null locations flag

Codecov Report

Merging #5948 into master will decrease coverage by 14.18%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           master    #5948       +/-   ##
===========================================
- Coverage   77.77%   63.59%   -14.19%
===========================================
  Files          46      393      +347
  Lines        9391    23670    +14279
  Branches        0     2635     +2635
===========================================
+ Hits         7304    15052     +7748
- Misses       2087     8605     +6518
- Partials        0       13       +13

Impacted Files
Coverage Δ

superset/assets/src/explore/controls.jsx
46.66% <ø> (ø)

superset/viz.py
81.04% <100%> (+0.04%)
:arrow_up:

superset/assets/src/components/Checkbox.jsx
100% <0%> (ø)

...ets/src/dashboard/components/dnd/DragDroppable.jsx
97.91% <0%> (ø)

superset/assets/src/components/EditableTitle.jsx
84.37% <0%> (ø)

...src/explore/components/controls/VizTypeControl.jsx
89.58% <0%> (ø)

...t/assets/src/components/InfoTooltipWithTrigger.jsx
58.82% <0%> (ø)

.../src/dashboard/components/UndoRedoKeylisteners.jsx
44% <0%> (ø)

...ts/src/explore/components/ExploreActionButtons.jsx
100% <0%> (ø)

...sets/src/dashboard/components/DashboardBuilder.jsx
92.75% <0%> (ø)

... and 341 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d1e45...c9b5960. Read the comment docs.


Timeline: Showing Titles Would Be Very Helpful

In the timeline, can a title be added to photos, videos or sounds? I think it would be incredibly helpful to members to know what they are looking at. Thanks!

Titles display now, at least for photos.


option to have --dev flag, devDependencies depth limited

I started exploring the recommended practice of having my test-harness dependency listed in "devDependencies".  At the same time, I decided to add an "script" called "web-test", which involves spinning up a 'connect' instance to serve up the tests targeting browser environments.
But there's a "downside" then to installing with:
 npm install mypkg --dev

Namely, all the packages in "devDependencies" (which in this case include connect) in turn have their "devDependencies" installed, and so on.
Would it be possible to specify the depth at which --dev will take effect?

+1 I was surprised that npm applied the --dev flag to each dependency in devDependencies. I really like @peritus' suggestion. It seems like a bug as-is, so I don't think anyone would be depending on it.

Here's a workaround for your Rakefile:

    sh "npm link"

    # install devDependencies, as long as
    # https://github.com/isaacs/npm/issues/1167 is not fixed

    devDependencies = JSON.parse(`cat package.json`)['devDependencies']
    devDependencies.each do |package_name, package_version|
      sh "npm install #{package_name}@#{package_version}"
    end

The rakefile is not necessary.  npm install will install devDependencies as long as you don't have the --production flag set.

Oh, I see, to install it for sub-dependencies.

True. But I want to install just this package's devDependencies but not it's dependency's devDependencies' (and so on, recursively). That's what the posted ruby code does, what npm AFAIK can't do at the moment and what this issue is about.

It used to be that npm install would not install any dev dependencies, which made --dev`` necessary and tedious. Since now it installs immediate dev dependencies, I'm happy using npm installand ignoring the--dev` option altogether.

@assaf Now I got it! Thanks! Removed my custom rake hack. I think this issue has accidentally been resolved.

Yes, the way this works currently in 1.0.106 is pretty good.
npm install loads the dependencies and dev dependencies for the root package, but does not pull dev dependencies for children.
If you want dev dependencies for some modules, simply npm install in those directories. So you have good control with this current implementation.
So for my current use cases, this issue could be considered closed.

I agree with @jeffbski, I think the current functionality of npm effectively closes this issue. I will be happy to close it officially, since I opened it ... does anyone object?

It's been awhile, and no objections were noted ... closing this issue.


Pussy Toons Pt br Source repeats the works.

Source information
PussyToons 1.4.36
Source language
Portuguese Brazilian
Steps to reproduce
The works keep repeating in the source.

Expected behavior
See the works without repeating them.
Actual behavior
They repeat several times in the source.
Mihon/Tachiyomi version
0.16.5
Android version
Android 12
Other details
No response
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] I have updated the app to version 0.15.3.
[X] I have updated all installed extensions.
[X] I have tried the troubleshooting guide.
[X] If this is an issue with the app itself, I should be opening an issue in the app repository.
[X] I will fill out all of the requested information in this form.

please censor nsfw images


Global a css reset

This was merged as part of https://github.com/alineacms/alinea/pull/238
Although I would like to keep the global reset to a minimum (preferably to zero css we depend on). In the future we might want to make our input components more reusable by the end user which means they'll be included in different environments without any reset rules to depend on.


Clean invisible chars and adjust "__" for server and client use

Fixes https://github.com/OdyseeTeam/odysee-frontend/issues/202
What is the current behavior?
%E2%80%8B or other characters appended to urls crashes the app
What is the new behavior?
It identifies the characters as part of the claim ID.  Also, clean invisible characters from ID.

Other information
This PR may be used as more of a template for anyone more familiar with the codebase that may have a better solution.
There are two issues at play here.
The "__ undefined" issue is due to the "__" not being a global in the node environment. On the client, this is included via the webpack "provide" plugin.  As such, it has to be directly imported for use on the server.  This, then, necessitates writing this subset of the dependency tree as common js, using "globalThis" instead of "window", and converting flow type annotations to comment annotations to be usable on both the node and client side.
The next issue that triggers the error message is that the the invisible characters are throwing off the claimId validation.  Specifically, the regex in !claimId.match(/^[0-9a-f]+$/).  Cleaning primaryModValue before it is passed in resolves this, allowing the page to parse the id and properly redirect to the proper url.
PR Checklist

Toggle...
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting)
[ ] Refactoring (no functional changes)
[ ] Documentation changes
[ ] Other - Please describe:

Please check all that apply to this PR using "x":

[x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
[x] I added a line describing my change to CHANGELOG.md
[x] I have checked that this PR does not introduce a breaking change
[ ] This PR introduces breaking changes and I have provided a detailed explanation below

Pushed another commit to address the invisible character issue.  The PR initially included the following:

Not being familiar with claim ids, I didn't realize that "3" is actually valid.  While on the site, I noticed other claim ids similar to this.  Looking up the validation logic, I realized that the length of the string was causing it to fail due to the invisible character.

@dan-peterson, if you have time, do you mind taking a look too?

Took a second look...
I think removing all __ from web/src/lbryURI.js should be sufficient.  I don't think the user language selection would work in Node anyways?

Should I go ahead and make that change, or was this a question for the others?

@david0178418 if you can confirm a user language does or doesn't work there, that would be helpful. If not, strip that part out.

It seems that the language selection is currently based off the navigator, which won't be a thing in node:

That said, some work can probably done to get this working as the language is being properly parsed from the client by Koa:

But I'm also not sure how high priority it would be to have this functionality available on the server.  So this can go either way, based on what you guys think.

I'd say remove that part for now and we can file a separate issue to address later, thank you!

Sounds good.  I've reverted the commonjs commit.  And since the i18n will be filed separately, I've added a placeholder pass-through function.

Awsome. thank you!


qt5base: apple silicon: fails to build

Describe the bug
Bulding qt5.qtbase fails on apple silicon.  See the hydra log. It looks as though the x86_64 linker is being invoked, see the bottom of the log.  Specifically clang is being passed -triple x86_64-apple-macosx11.0.0.
To Reproduce
Steps to reproduce the behavior:
Build qt5.qtbase on apple silicon.
Expected behavior
it builds.

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: qt5.qtbase
# a list of nixos modules affected by the problem
module:

I'm also running into this on apple silicon


chore(package.json): add private: true to root

Required for yarn to work with the monorepo: https://classic.yarnpkg.com/lang/en/docs/workspaces/#:~:text=Note that the private%3A true is required! Workspaces are not meant to be published%2C so we’ve added this safety measure to make sure that nothing can accidentally expose them.
This prevents publishing the root package to NPM, which kind of makes sense.
May help in resolving #3389 ?

⚠
Changes were made to package.json, but not to package-lock.json - Perhaps you need to run npm install?

Otherwise lgtm 👍

Looks like it might be a red herring, I don't think this change will update package-lock.json maybe?


XML documentation files are missing in RC1 packages

The code itself has little to no XML API documentation apparently intentionally so it doesn't really matter if they'd be included or not since it'd all be empty.

@tillig - OK OK, I'll get over my personal issue with comments in general and add XML comments to the classes that make up Swasbuckle's public config. interface. Expect it in the stable release

Thanks!

See 82dd0e696e7ac2c5ef218d06a1ce9e4a2c8ffc8d


VIH-9293 - Add Schedule Jobs Host Key

JIRA link (if applicable)
VIH-9293
Change description
Add Schedule Jobs Host Key
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ x ] No

Not required


Add more files and lines when scaffolding

When adding new service:

add urls.py
add mocks declaration to moto/__init__.py and moto/backends.py

When adding new operation to a service:

add uri to urls.py

Coverage remained the same at 92.558% when pulling ac66defb3be757e9dea540d12d07978600bbfe87 on toshitanian:feature/add-extra-files-to-scaffold into 5bb6b98f6d0364543018b63b61c66e5813964cb9 on spulec:master.

Great work, @toshitanian !


feat(anywidget): Make HMR explicit and opt-in

Fixes #423 #374
What
Makes anywidget's native HMR explicit and opt-in via the ANYWIDGET_HMR environment variable.
Context
The built-in HMR is only meant to be used during "live" development, when local widgets are in imported and used in an active notebook. However, our heuristics for enabling this development feature lead to many false positives, and thus issues  issues in various non- "live" development settings #423, #374, #276.
This is a bad experience for end users.
It doesn't seem possible to account for all these edge cases, and since HMR is meant as a development only feature, it makes sense to make it explicit and opt-in by the developer. This PR requires an environment variable to apply anywidget's prior heuristics. It can be set in a notebook:
%env ANYWIDGET_HMR=1

or when launching a notebook from the command line:
ANYWIDGET_HMR=1 jupyter lab

As a sage once said:
>>> import this
The Zen of Python, by Tim Peters

Beautiful is better than ugly.
Explicit is better than implicit.
...

Would it also make sense to also provide an explicit hook to activate HMR at runtime in the notebook?

Would it also make sense to also provide an explicit hook to activate HMR at runtime in the notebook?

We could definitely add an API later for that, but you can currently set within a notebook with:
%env ANYWIDGET_HMR=1


Increase readability by using cat EOF

Why:
Closes: -

What's being changed (if available, include any code snippets, screenshots, or gifs):

Previously a nested and highly escaped YAML structure was printed. Now one can follow the structure of what is printed more easily by using cat <<EOF syntax. The escaping is gone.
I wonder if fromJSON on the other hand works with a multi-line input.
Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[ ] For content changes, I have completed the self-review checklist.

@kwk Thanks so much for opening a PR! I'll get this triaged for review ✨

I've reviewed the preview here

[x] https://docs-31139-c8ae50.preview.ghdocs.com/en/actions/learn-github-actions/expressions
[x] https://docs-31139-c8ae50.preview.ghdocs.com/en/enterprise-cloud@latest/actions/learn-github-actions/expressions

Here's my review of the self-review checklist:

[x] If there is a content design plan, confirm that your changes meet the user experience and goals outlined in the plan.

[x] After opening your pull request, view your changes on staging to confirm the article renders as expected and matches the source. This helps spot issues like typos, content that doesn't follow the style guide, or content that isn't rendering due to versioning problems.

[x] https://docs-31139-c8ae50.preview.ghdocs.com/en/actions/learn-github-actions/expressions:

[x] https://docs-31139-c8ae50.preview.ghdocs.com/en/enterprise-cloud@latest/actions/learn-github-actions/expressions:

[ ] Review your changes for technical accuracy.

[!WARNING]
Apparently my suggestion doesn't work when trying it in a real github project:
 Run cat <<EOF >> $GITHUB_OUTPUT
  cat <<EOF >> $GITHUB_OUTPUT
  matrix={
    "include": [
      {"project": "foo", "config": "Debug"},
      {"project": "bar", "config": "Release"}
    ]
  }
  EOF
  shell: /usr/bin/bash -e {0}
Error: Unable to process file command 'output' successfully.
Error: Invalid format '  "include": ['

[x] Review your entire pull request to ensure it follows our guidance on creating content that can be translated. For more information, see "Writing content to be translated."
[x] Check your changes for grammar, spelling, and adherence to the style guide. For more information, see "Style guide."
[x] If you have added new versioning or made changes to existing versioning, confirm your changes render as expected while viewing each available version of the article.
[x] If there are any failing checks in your pull request, troubleshoot them until they're all passing.

Hey @kwk, thank you so much for opening a PR to update the docs! ✨
I definitely agree that a multi-line matrix is more readable. 👍  However, I noticed your comment that when you tried this out in your project, it didn't actually work. For this reason, I'm going to close out this PR, as we would only want to update examples with code that will work when people use it. However, if you do find a way to make this example more human-readable, please feel free to open another PR! If you do that, it's very helpful for us if you test it out in your own repository first and link to a successful workflow run.
Thanks again for your contribution! 💛


Add **kwargs support for pyarrow_schema_dispatch

[x] Fixes https://github.com/dask/distributed/pull/8157#discussion_r1319807620
[x] Tests added / passed
[x] Passes pre-commit run --all-files

I'm not sure how to test this such that it also works for cudf. @rjzamora, would you have some pointers?

CI seems to be failing because of our register_plugin warnings. this is unrelated

I'm not sure how to test this such that it also works for cudf. @rjzamora, would you have some pointers?

Yeah, this will break dask_cudf, so thanks for the ping.

Sorry for merging prematurely.

Sorry for merging prematurely.

No worries, I appreciate the work you guys are doing :)


Add liked songs page

On the playlist page, there is no 'liked songs' button present. Please add a 'liked songs' button and design it similar to the new playlist button. Place a like icon in the middle of the box. When we click this button, a new page will open and all liked music songs will be fetched. Here is a screenshot showing where you should implement this function.

Hii, I'd like to take up this issue
I've noticed there's no way to register an event to "like" a song, and since the entire project is just a vanilla HTML server, how do we plan on saving liked songs?
An alternative I could suggest would be to store local cookies since there is no concept of user accounts

Hii, I'd like to take up this issue
I've noticed there's no way to register an event to "like" a song, and since the entire project is just a vanilla HTML server, how do we plan on saving liked songs?
An alternative I could suggest would be to store local cookies since there is no concept of user accounts

Sure, please proceed @vsh9
Happy Coding...!!

To learn more about this issue, you can also view this particular one #21


Add new query for advertiserStories

return array of Stories restricted by advertiserId & optionally publisherId

 Enable a "View All" page for Partner Insights advertisers


fix(cli) handle race condition in changing env perms

Summary
Handle a potential vulnerability in how we secured the Kong env file. Previously we chmod'd the file after writing the contents via penlight's wrapper of the Lua io lib, which in turn uses stdio. This allowed for a miniscule window in which the file contents could be read (fopen() creates files with 0666 octal permissions, as modified by the processes's umask).
The new behavior is to leverage the open() libc wrapper directly via FFI, which allows us to create the file with appropriate permissions from the outset.
Full changelog

Open, write, and close the .kong_env file via libc wrappers around open/write/read syscalls (via FFI)

(update PR name and synopsis based on rv comments)

Merging. I think the comments here serve as a good reference point for discussion. Glad to see this in :)


Error reading current istio version on upgrade

Bug description
Having followed the instructions for setting up an egress gateway with SNI proxy (https://archive.istio.io/v1.4/docs/tasks/traffic-management/egress/wildcard-egress-hosts/#setup-egress-gateway-with-sni-proxy), attempting to upgrade istio from 1.4.6 to 1.5.2 (using istioctl) results in the following error:
Error: failed to read the current Istio version, error: failed to retrieve Istio control plane version, error: tag not found in image: nginx, differrent versions of containers in the same pod:

Expected behavior
Upgrade should not fail with error
Steps to reproduce the bug

Install istio 1.4.6
Add egress gateway with SNI proxy (https://archive.istio.io/v1.4/docs/tasks/traffic-management/egress/wildcard-egress-hosts/#setup-egress-gateway-with-sni-proxy)
Attempt to upgrade using istioctl

Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
istioctl version --remote
client version: 1.5.2
citadel version: 1.4.6
egressgateway version: 1.4.6
egressgateway-with-sni-proxy version:
galley version: 1.4.6
ingressgateway version: 1.4.6
nodeagent version:
nodeagent version:
nodeagent version:
pilot version: 1.4.6
policy version: 1.4.6
sidecar-injector version: 1.4.6
telemetry version: 1.4.6
data plane version: 1.4.6 (6 proxies)

kubectl version
Client Version: version.Info{Major:"1", Minor:"15", GitVersion:"v1.15.5", GitCommit:"20c265fef0741dd71a66480e35bd69f18351daea", GitTreeState:"clean", BuildDate:"2019-10-15T19:16:51Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"17+", GitVersion:"v1.17.4-gke.10", GitCommit:"302b55804ee4a09c6ad5be81a380a3f333f72fcf", GitTreeState:"clean", BuildDate:"2020-04-14T17:30:11Z", GoVersion:"go1.13.8b4", Compiler:"gc", Platform:"linux/amd64"}

How was Istio installed?
Initially with helm, but then migrated to istioctl
Environment where bug was observed (cloud vendor, OS, etc)
GKE

Did you happen to have nginx installed in the same namespace with Istio?

Yes. The instructions setup a custom egressgateway (in the istio-system namespace) with an additional nginx container in the pod (latest version of instructions here)


build: run golangci-lint in CI

Codecov Report

Merging #252 into master will decrease coverage by 1.19%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #252     +/-   ##
=========================================
- Coverage   68.91%   67.72%   -1.2%
=========================================
  Files          33       33
  Lines        3018     3018
=========================================
- Hits         2080     2044     -36
- Misses        735      778     +43
+ Partials      203      196      -7


Image export permission error handling

Image Export:

inline startup script
log GCS read permission with "ExportFailed:" prefix so it gets picked up by the calling code
don't retry on permission error

/retest

/flake8

/flake8


wasmi_v1: improve instruction scheduler

This PR changes the instruction scheduler of the wasmi_v1 engine.
The new approach seems promising and also is less affected by the performance regressions with newer rustc versions than the current interpreter instruction scheduler.
Note that the instruction scheduler is on the absolute hot path of the interpreter which is why we see significant changes in performance.
We compare the performance of Rust 1.59 because that is the last version before the performance regressions and we also use Rust 1.62 because it is the current stable Rust version.
Rust 1.59

Test
Before
After
Change

tiny_keccak
970.77
793.95 µs
-17.890%

rev_complement
1.1200
991.54 µs
-11.326%

regex_redux
1.1962
1.0809 ms
-9.5504%

count_until
1.7180
1.4201 ms
-17.382%

factorial_recursive
1.1851
1.1655 µs
-1.6003%

factorial_optimized
740.47
635.99 ns
-13.924%

recursive_ok
312.90
304.17 µs
-3.2702%

recursive_trap
28.212
27.951 µs
-0.8383%

host_calls
45.054
43.287 µs
-3.7734%

fib_recursive
12.633
13.025 ms
+3.0991%

Rust 1.62 (Stable)

Test
Before
After
Change

tiny_keccak
1.4818 ms
916.57 µs
-36.988%

rev_complement
1.4554 ms
1.1097 ms
-23.228%

regex_redux
1.4766 ms
1.1896 ms
-19.362%

count_until
2.2027 ms
1.6776 ms
-23.720%

factorial_recursive
1.4349 µs
1.2398 µs
-14.031%

factorial_optimized
935.66 ns
719.33 ns
-23.144%

recursive_ok
354.32 µs
322.68 µs
-8.6313%

recursive_trap
33.905 µs
29.536 µs
-12.983%

host_calls
53.669 µs
49.136 µs
-8.5481%

fib_recursive
15.320 ms
13.496 ms
-11.907%

Conclusion
All in all a significant improvement across the board. However, even the new instruction scheduler still suffers a performance degradation of roughly 15-20% with a newer rustc version compared to Rust 1.59.

Note that this PR also fixes this rustc issue in parts since the new instruction dispatcher is no longer as heavily affected by the rustc performance regressions as was the case with the previous (old) instruction dispatcher. Between Rust 1.59 and Rust 1.62 (current stable) the old instruction dispatcher regressed by roughly 50-60% in performance according to our benchmarks whereas the new instruction dispatcher is "only" regressed by roughly 20%. Still 20% is a lot though ...


Indentation error

I'm still getting this error when running on the latest github version. It looks like some code format issues:
$ sos run dsc/20190717_workflow.ipynb get_stats:1-4 -s build -v4
  File "/home/min/miniconda3/lib/python3.6/site-packages/sos/__main__.py", line 550, in cmd_run
    executor.run(args.__targets__, mode=config['run_mode'])
Traceback (most recent call last):
  File "/home/min/miniconda3/lib/python3.6/site-packages/sos/eval.py", line 61, in accessed_vars
    return get_accessed(ast.parse(statement, '<string>', 'exec'))
  File "/home/min/miniconda3/lib/python3.6/ast.py", line 35, in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
  File "<string>", line 2
    = sos_handle_parameter_('', str
    ^
IndentationError: unexpected indent

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/min/miniconda3/lib/python3.6/site-packages/sos/__main__.py", line 550, in cmd_run
    executor.run(args.__targets__, mode=config['run_mode'])
  File "/home/min/miniconda3/lib/python3.6/site-packages/sos/workflow_executor.py", line 340, in run
    return self.run_as_master(targets=targets, mode=mode)
  File "/home/min/miniconda3/lib/python3.6/site-packages/sos/workflow_executor.py", line 1136, in run_as_master
    dag = self.initialize_dag(targets=targets)
  File "/home/min/miniconda3/lib/python3.6/site-packages/sos/workflow_executor.py", line 821, in initialize_dag
    self.add_forward_workflow(dag, self.workflow.sections)
  File "/home/min/miniconda3/lib/python3.6/site-packages/sos/workflow_executor.py", line 691, in add_forward_workflow
    res = analyze_section(section, default_input=default_input)
RuntimeError: Failed to parse statement: #begin_parameter
 = sos_handle_parameter_('', str
) #end_parameter
 in exec mode
ERROR: Failed to parse statement: #begin_parameter
 = sos_handle_parameter_('', str
) #end_parameter
 in exec mode

Is dsc/20190717_workflow.ipynb available on github?

The attached zip file is minimal working example: workflow and the data used.
The command: sos run 20190717_workflow.ipynb get_stats:1-4 -s build
minimal_working_example.zip

Hi Dr. Peng,
I edited the path of the workflow in minimal working example, so you can reproduce the error without any editing. Please find attached.
minimal_working_example_v2.zip

Looks like the problem is cased by this empty parameter specification

Yes... It worked after delete the parameter. Thank you so much!

I added a patch to allow empty parameter line because the error message is confusing.


Custom Script Tapscript not working?

That's probably my fault;
Overall the library is way more straightforward and battery packed than other fragmented libraries, but I'm struggling to make a simple tapscript work (which seems pretty straightforward with bitcoinjs or cmd/tapscript, at the cost of fragmentation)...
I'm creating a tapscript  with a custom script that will pay for another transaction on a meta protocol:
 const { publicKey } = getP2TRWallet()
  const taprootInternalKey = ecdsaPublicKeyToSchnorr(publicKey)
  const outputScript = btc.Script.encode([
    taprootInternalKey,
    btc.OP.CHECKSIG,
    btc.OP.OP_0,
    btc.OP.IF,
   randomId,
    btc.OP.ENDIF
  ])

  const taprootPayment = btc.p2tr(
    taprootInternalKey,
    [
      {
        script: outputScript,
        leafVersion: 192,
      }
    ],
    network,
    true
  )
  return taprootPayment

and then, I pay to taprootPayment.address. Of course. This work flawlessly, the problem only really happens when I create the transaction to spend from this tapscript, in which the input is:
tx.addInput({
  txid: hex.decode(utxo.txid),
  index: utxo.vout,
  witnessUtxo: {
    script: tapscriptCommitment.script,
    amount: BigInt(utxo.value)
  },
  ...tapscriptCommitment,
  sighashType: btc.SigHash.ALL,
  sequence: 0xfffffffd
})

And then I proceed to build the outputs etc, sign the transaction, and submit to the blockchain. ALL GOOD.
Except that the tapscript does not get embedded on the hex of the transaction, check here: https://mempool.space/testnet/tx/f8d7bf9143bb8f41f0934ee35791ae75ebe6ffa4bb23de3287b635ecd8d9eb8f (clicking on details, you can see that there's no P2TR tapscript)
My best bet, is that I'm creating the custom script wrong in some manner. Still getting used to the library to consolidate on my own projects.
Would appreciate any help you can provide @paulmillr 🙏

To ensure you're signing the script path instead of the key path, I'd set up these to different pub keys:
const outputScript = btc.Script.encode([
    taprootInternalKey, // <<<< THIS
    btc.OP.CHECKSIG,
    btc.OP.OP_0,
    btc.OP.IF,
   randomId,
    btc.OP.ENDIF
  ])

  const taprootPayment = btc.p2tr(
    taprootInternalKey, // <<<< AND THIS
    [
      {
        script: outputScript,
        leafVersion: 192,
      }
    ],
    network,
    true
  )

Then sign with the key in the script.

It would actually be pretty cool if there was a param that could be passed in to prefer signing the script over the PK path in this scenario.

Hmm thanks @victorkirov. So, I'm using my Taproot seed, and generating the internal key for it.
But I also did this:
export const tapscriptPrivateKey = secp.utils.randomPrivateKey()
export const internalPublicKey = secp.getPublicKey(tapscriptPrivateKey);
export const tapscriptPublicKey = ecdsaPublicKeyToSchnorr(internalPublicKey)

So I different than my taproot seed phrase wallet.
Or u meant, something like this:
const outputScript = btc.Script.encode([
    taprootInternalKey1, (the one that can unlock)
    btc.OP.CHECKSIG,
    btc.OP.OP_0,
    btc.OP.IF,
   randomId,
    btc.OP.ENDIF
  ])

  const taprootPayment = btc.p2tr(
    taprootInternalKey2, (the one that was generated random)
    [
      {
        script: outputScript,
        leafVersion: 192,
      }
    ],
    network,
    true
  )

And agree on path spending forcing.

I'm lowkey thinking about adding some PRs to add support for this kinda of thing. I get @paulmillr goal is to make this lib easier to use and more idiomatic, but when you have to go out a bit with custom scripts, it kinda has to go through lots of rounds of workarounds that should just be abstracted for better DX.

ordinals api is coming soon

ordinals api is coming soon

Nice. This is good, but can we enable custom scripting path spending in some way in current lib?
What are my options if I want to make it work right now, do u have any suggestion to my custom script input above? I should just not possible to make this tapscript works?

Got it, i might have to move away from scure for custom scripting txns for now then as I want something ready before halving.
Or do u have a dev branch I could fork and start using?

the branch would be ready later this week: there would still be time before halving.

perfect sir. thank you, anxious waiting for this!

https://github.com/paulmillr/scure-btc-signer/tree/ord

for example, see Example (fake) in ordinals.test.js. Docs would be coming after the feature is more stable. Custom scripts are there.

Nice, ur a chad sir. Thank you, I will study this branch tomorrow
Doing Gods work

for example, see Example (fake) in ordinals.test.js. Docs would be coming after the feature is more stable. Custom scripts are there.

thank you Paul! keen to get ordinals/runes stuff through

Any feedback on the branch folks? Have you managed to write working code?

Hi! Crunching atm so didnt had time to integrate it yet; once I do, will circle back

1.3.0 looks very promising I had almost successfully integrated the ord branch when this released, tonight I'll pivot to the public release again and continue.
Can we get customScript support in the utxo selector here as well?
https://github.com/paulmillr/scure-btc-signer/blob/1.3.0/src/utxo.ts#L153

@kevinfaveri usage from first post: https://gist.github.com/paulmillr/e6f4ee87715e8c5510ce39326fad7129


add js-chess-engine so the computer is less dumb

upgrade to convex version 0.9.1
move computer moves to a scheduled action.
this allows computer moves to use node libraries
using scheduled actions adds a failure case: scheduled actions aren't guaranteed to run. IMO we can fix that later. this is just a test app, and the action doesn't throw errors or do RPCs
idk why i have to ts-ignore the require (i tried several things and nothing else worked). shouldn't actions have node types?

I regenerated tsconfig to the latest recommended ones and then the ts-ignore is not required anymore.


Add eslint and fix lint warnings

Have globally disabled the require-jsdoc rule, and also (in two places) the requirement that functions with capital letters should only be used as constructors. (express wants to do this.)

LGTM


data2vec inference

Hi!
I want to try inference on data2vec. There is a lack of documentation how to do it on pretrained models.
How to get masked output masked value for an input value for example for pretrained model?
“ Archaeoindris fontoynontii is an extinct giant lemur and the largest primate known to have evolved on Madagascar, comparable in size to a male gorilla. . It belonged to a family of extinct lemurs known as "sloth lemurs" (Palaeopropithecidae)”
Appreciated for any help.

sorry i dont get the question, are you talking about audio or nlp model here? based on your example i assume nlp? if so you can follow examples in roberta readme, it largely still applies except there is no "lm head" since we dont predict input units

sorry i dont get the question, are you talking about audio or nlp model here? based on your example i assume nlp? if so you can follow examples in roberta readme, it largely still applies except there is no "lm head" since we dont predict input units

Yes, about NLP model. Thanks, will take a look. Does it straightforward or there is some specific details?

@alexeib On a similar note. How to run the data2vec inference on custom audio files? As per the docs, I can evaluate the CTC model by specifying the data manifests and other parameters. What should be the field "dataset.gen_subset=dev_clean,dev_other,test_clean,test_other" since I am not using librispeech for evaluation? It is a mandatory field and leads to errors if unspecified:
python examples/speech_recognition/new/infer.py  --config-dir examples/speech_recognition/new/conf --config-name infer task=audio_finetuning task.data=manifest_file.tsv common.user_dir=examples/data2vec task.labels=ltr decoding.type=viterbi common_eval.path=<data2vec_speech_model>.pt decoding.beam=1500 distributed_training.distributed_world_size=2
Output error: AssertionError: Unexpected type for root: NoneType  (since dataset is not specified, I guess)

gen_subset is the name of the manifest file for the subset you wish to evaluate. e.g. if you have valid.tsv as the subset you are evaluating, you would specify gen_subset=valid

Thanks. What is the expected format? I have a train and validation split .tsv files created from the wav files with examples/wav2vec/wav2vec_manifest.py and when I run the following, I still get the same error:
CUDA_VISIBLE_DEVICES=2,4 python examples/speech_recognition/new/infer.py  --config-dir examples/speech_recognition/new/conf --config-name infer task=audio_finetuning task.data=path_to_train.tsv common.user_dir=examples/data2vec task.labels=ltr decoding.type=viterbi decoding.unique_wer_file=True dataset.gen_subset=valid common_eval.path=/nas/jilt/ASR/Librispeech/AM/data2vec/audio_base_ls_960h.pt decoding.beam=1500 distributed_training.distributed_world_size=2
For instance, In train.tsv file I only have 10 audiofiles and 3 in valid.tsv. Am I missing something here? I am putting the audiofiles in a folder and the tsv files outside of it.

whats the stack trace ? i assume you correctly set the path here: task.data=path_to_train.tsv right ?

Hi @alexeib,
Thanks for your answer. Here is the stack trace:
Traceback (most recent call last):   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/utils.py", line 211, in run_and_report     return func()   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/utils.py", line 378, in <lambda>     lambda: hydra.run(   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/hydra.py", line 88, in run     cfg = self.compose_config(   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/hydra.py", line 559, in compose_config     cfg = self.config_loader.load_configuration(   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/config_loader_impl.py", line 141, in load_configuration     return self._load_configuration_impl(   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/config_loader_impl.py", line 262, in _load_configuration_impl     ConfigLoaderImpl._apply_overrides_to_config(config_overrides, cfg)   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/config_loader_impl.py", line 378, in _apply_overrides_to_config     OmegaConf.update(cfg, key, value, merge=True)   File "/home/jilt/anaconda3/lib/python3.8/site-packages/omegaconf/omegaconf.py", line 730, in update     assert isinstance( AssertionError: Unexpected type for root: NoneType
task.data is set to the path to train.tsv and dataset.gen_subset is set to 'valid' where valid.tsv is also in the same directory as train.tsv
The error is still showing for the dataset data class field.

hmm this stack trace seems pretty generic, can you share the entire output of what happens when you run the command?
and just to make sure, you are using one of the fine-tuned models, not the "no finetuning" model right ?

Right. I am using the data2vec model finetuned on 960h Librispeech (audio_base_ls_960h.pt).
Here is the complete output:
(base) jilt@ada:~/workspace/self-supervised-speech-recognition/fairseq$ CUDA_VISIBLE_DEVICES=4 python examples/speech_recognition/new/infer.py  --config-dir examples/speech_recognition/new/conf --config-name infer task=audio_finetuning task.data=/data/jilt/datasets/mydata/train.tsv common.user_dir=examples/data2vec task.labels=ltr decoding.type=viterbi decoding.unique_wer_file=True dataset.gen_subset=valid common_eval.path=/data/jilt/ASR/data2vec/audio_base_ls_960h.pt decoding.beam=1500 distributed_training.distributed_world_size=2 /home/jilt/anaconda3/lib/python3.8/site-packages/hydra/core/default_element.py:122: UserWarning: In 'infer': Usage of deprecated keyword in package header '# @package _group_'. See https://hydra.cc/docs/next/upgrades/1.0_to_1.1/changes_to_package_header for more information   deprecation_warning( /home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/defaults_list.py:251: UserWarning: In 'infer': Defaults list is missing self. See https://hydra.cc/docs/upgrades/1.0_to_1.1/default_composition_order for more information   warnings.warn(msg, UserWarning) examples/speech_recognition/new/infer.py:478: UserWarning: 'infer' is validated against ConfigStore schema with the same name. This behavior is deprecated in Hydra 1.1 and will be removed in Hydra 1.2. See https://hydra.cc/docs/next/upgrades/1.0_to_1.1/automatic_schema_matching for migration instructions.   hydra_main()  # pylint: disable=no-value-for-parameter Traceback (most recent call last):   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/utils.py", line 211, in run_and_report     return func()   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/utils.py", line 378, in <lambda>     lambda: hydra.run(   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/hydra.py", line 88, in run     cfg = self.compose_config(   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/hydra.py", line 559, in compose_config     cfg = self.config_loader.load_configuration(   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/config_loader_impl.py", line 141, in load_configuration        return self._load_configuration_impl(   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/config_loader_impl.py", line 262, in _load_configuration_impl     ConfigLoaderImpl._apply_overrides_to_config(config_overrides, cfg)   File "/home/jilt/anaconda3/lib/python3.8/site-packages/hydra/_internal/config_loader_impl.py", line 378, in _apply_overrides_to_config     OmegaConf.update(cfg, key, value, merge=True)   File "/home/jilt/anaconda3/lib/python3.8/site-packages/omegaconf/omegaconf.py", line 730, in update     assert isinstance( AssertionError: Unexpected type for root: NoneType 2022-02-01 12:48:59 | INFO | wandb.sdk.internal.internal | Internal process exited
Thanks for the help!

@alexeib Could you please let me know if there is any update on this?

hey, i am not able to reproduce this error. could you maybe rollback to an earlier version of omegaconf and hydra (see requirements.txt in fairseq root for versions) and try again?

I guess this would be hydra and omega conf version diff.
I got the same error while updating configs using the newest omegaconf, and hydra.
downgrading those two packages worked for me.

Hi, @alexeib Looks like it is indeed a problem with the hydra and omega conf version diff. I still need to figure out the way the dataset needs to be structured (even for just inference), but the error specified in this issue is solved. Thank you!


[WIP] [Dev file preview] Add wrap text setting

Summary of the Pull Request
What is this about:
Adds a new setting which enables text wrapping in dev file preview and a context menu to copy the selected text.
Default state: on

What is included in the PR:
How does someone test / validate:
Quality Checklist

[x] Linked issue: #16280
[x] Communication: I've discussed this with core contributors in the issue.
[ ] Tests: Added/updated and all pass
[ ] Installer: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Docs: Added/ updated
[x] Binaries: Any new files are added to WXS / YML

[x] No new binaries
[ ] YML for signing for new binaries
[ ] WXS for installer for new binaries

Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.

@niels9001 Settings are crashing when I switch to the explorer add ons page. This only happens when there is an associated string for the element. If there is no string for the element it works as expected.

For line 65, 94, 101, the GCODE & STL icons: there's an icon that's literally "Printer3D" (e914)
https://docs.microsoft.com/en-us/windows/apps/design/style/segoe-fluent-icons-font

For line 65, 94, 101, the GCODE & STL icons: there's an icon that's literally "Printer3D" (e914)
https://docs.microsoft.com/en-us/windows/apps/design/style/segoe-fluent-icons-font

Please open a nee issue to keep this PR more or less on scope

For this setting here I think e966 would fit.

But I'm open for better suggestions

But I'm open for better suggestions

Why not e751 "ReturnKey" ?

But I'm open for better suggestions

Why not e751 "ReturnKey" ?

That's better

@niels9001 Settings are crashing when I switch to the explorer add ons page. This only happens when there is an associated string for the element. If there is no string for the element it works as expected.

Not sure what you mean here :). Does VS provide a specific error(code)?

@niels9001 Settings are crashing when I switch to the explorer add ons page. This only happens when there is an associated string for the element. If there is no string for the element it works as expected.

Not sure what you mean here :). Does VS provide a specific error(code)?

Does it work on your side? I'm currently not able to debug with VS for whatever reason

@niels9001 Settings are crashing when I switch to the explorer add ons page. This only happens when there is an associated string for the element. If there is no string for the element it works as expected.

Not sure what you mean here :). Does VS provide a specific error(code)?

Does it work on your side? I'm currently not able to debug with VS for whatever reason

I'll check later.. but it's not clear to me what you mean with "associated string for the element"?

@niels9001 Settings are crashing when I switch to the explorer add ons page. This only happens when there is an associated string for the element. If there is no string for the element it works as expected.

Not sure what you mean here :). Does VS provide a specific error(code)?

Does it work on your side? I'm currently not able to debug with VS for whatever reason

I'll check later.. but it's not clear to me what you mean with "associated string for the element"?

I mean the string you pointed out. If I delete this string it doesn't crash.

@niels9001 Settings are crashing when I switch to the explorer add ons page. This only happens when there is an associated string for the element. If there is no string for the element it works as expected.

Not sure what you mean here :). Does VS provide a specific error(code)?

Does it work on your side? I'm currently not able to debug with VS for whatever reason

I'll check later.. but it's not clear to me what you mean with "associated string for the element"?

I mean the string you pointed out. If I delete this string it doesn't crash.

Yes.. You need to change the .Header to .Content. CheckBox doesn't have a Header property, only a Content property.. Therefore the crash (I think) :).

@niels9001 Settings are crashing when I switch to the explorer add ons page. This only happens when there is an associated string for the element. If there is no string for the element it works as expected.

Not sure what you mean here :). Does VS provide a specific error(code)?

Does it work on your side? I'm currently not able to debug with VS for whatever reason

I'll check later.. but it's not clear to me what you mean with "associated string for the element"?

I mean the string you pointed out. If I delete this string it doesn't crash.

Yes.. You need to change the .Header to .Content. CheckBox doesn't have a Header property, only a Content property.. Therefore the crash (I think) :).

I will try this

Will this be ready for next release?

Will this be ready for next release?

It's already feature stop for 0.56.
It will be ready for 0.57

Added context menu for switching text wrapping for the current file and copy!

@niels9001 The settings work now and they set the right value in the config file, but reading the setting (here) always returns false. Any idea why?

Added context menu for switching text wrapping for the current file and copy!

Nice. Do you think it's possible to make it a checked menu item with the words "wrap text"?

Nice. Do you think it's possible to make it a checked menu item with the words "wrap text"? And what will be copied? Selected text? What if no text is selected?

@jay-o-way I don't think so but I'm not sure.
If nothing is selected it copies the current line.

@Aaron-Junker
Have you fixed the build warnings that we currently have on main?

I was not aware of them, so no

@niels9001 The settings work now and they set the right value in the config file, but reading the setting (here) always returns false. Any idea why?

@jaimecbernando Could someone please look into this?

Might it be something to do with the environment of prevhost? Does it work if you try to test it from the sample app you used to test the Preview Handler?

@jaimecbernando Never mind. It works now.

Doesn't work for me

@jaimecbernando Never mind. It works now.

Doesn't work for me

@stefansjfw Do you get any error message when debugging?

@stefansjfw I adressed your feedback, but I everything works for me like expected. What exactly doesn't work?

@stefansjfw I adressed your feedback, but I everything works for me like expected. What exactly doesn't work?

Sorry for the late reply. Just tested id on clean VM, everything seems to work correctly after updating the installer.

Nice one Aaron! :)
Could you fix these warnings?

Warnings still there. Please fix

I think this is the only PR almost done that could still get into this release. I'll clear those warnings related to this PR.
Regarding @niels9001 's review, has everything been addressed?

Just committed the warning fixes. @stefansjfw PTAL

Does this come into 0.57 if everything is ok?

Yes, just waiting for the re-reviews and then I think it can go in.


Fix line continuations in literals

Motivation
Port of https://github.com/whitequark/parser/pull/539.
This PR introduces a few changes in how literal with the \\\n continuation are parsed.
Heredoc changes
All variations of the non-plain heredoc like HERE, "HERE", `HERE`
<<-HERE
a\
b
HERE

Are now correctly parsed as s(:str, "ab\n") instead of s(:str, "a\nb\n").
This apply also for the squiggly heredoc non-plain variations:
<<~HERE
  a\
  b
HERE

That is now parsed as s(:str, "a  b\n") instead of s(:str, "a\n  b\n") (note that we still have a bug in the dedenting of the heredoc but this can be fixed independently from this PR).
Plain 'HERE" is unchanged.
Literal strings changes
Lines continuations are correctly parsed for interpolated strings, " ", %{ } and %Q{ }:
a\
b

Now returns s(:str, "ab") instead of s(:str, "a\nb\n").
Plain strings with ' ' and %q{ } are unchanged.
Literal symbols changes
Lines continuations are correctly parsed for symbols:
:a\
b

Now returns s(:sym, :ab) instead of s(:sym, :a\nb).
Literal arrays of symbols (interpolated or not) are unchanged.
Literal shell commands changes
Lines continuations are correctly parsed for shell commands:
`a\
b`

Now returns s(:xstr, s(:str, "ab"))) instead of s(:xstr, s(:str, "a\nb"))).
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build result here:
→ https://go/builds/bui_HzznrNppbUr6A5


Refactor/separate supertokens database

Description:
Creates a separate database for the supertokens tables. This goes along with the migration from sequelize to prisma; this way prisma can have the database up-to-date with the scheme without we having to model all supertokens tables in the scheme.
Test plan:
Reset the docker container:
make reset-dev

Enter the mariadb CLI for the supertokens database:
yarn docker dbu

Run the query:
INSERT INTO emailpassword_users VALUES ('u-id'<EMAIL_ADDRESS>'$2a$11$QOyNFFmciE6Hda1avqxxa.qLMYIJSBWn7eV8i6Ude73qu5l2/wA5e',<PHONE_NUMBER>244);
INSERT INTO emailverification_verified_emails VALUES ('u-id', 'u@u.com');
INSERT INTO all_auth_recipe_users VALUES ('u-id', 'emailpassword',<PHONE_NUMBER>244);

Try to log in as<EMAIL_ADDRESS>with password u.

 This is after logging in with<EMAIL_ADDRESS>
I failed to reproduce it here, can you try it again after docker system prune -a?


[BUG] Add translation to "Check for Updates..." and color components

Hi,
Could add to location the string "Check for updates" and color components?

Hi,
DevToysMac is now archived and deprecated. We just released DevToys 2.0 for Windows, Mac and Linux. This issue may or may have not been addressed in the new version. If the issue persist, we encourage to open a new issue on https://github.com/DevToys-app/DevToys or https://github.com/DevToys-app/DevToys.Tools
See more information about DevToys 2.0 here: https://devtoys.app/blog/announcing-devtoys-2.0-preview


Need to do a pass at toolbar menus and buttons: consistent, context sensitive

Describe the bug

Version

Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[ ] Windows
[ ] Ubuntu

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior

Screenshots

Additional context

Duplicate of #3494


Refactor certificate distribution mechanism

When all master nodes trying to get certificates from master node in shared ssh session sshd fails and ansible provision fails due to connectivity issues. Possible way is archive certificates and transfer in single operation or transfer generated certs to ansible host and then push to nodes.

Closed via #91


Codacy badges broken in readme

As in image. Not sure what happened but the badge images must have moved or something.

:tada: This issue has been resolved in version 1.15.5 :tada:
The release is available on:

v1.15.5
GitHub release

Your semantic-release bot :package::rocket:


Write a C program to swap two numbers

Description
Write a C program to swap two numbers
Input  : 10 20
Output : 20 10

How to contribute

Save the solution in SwapTwoNumbers.c file
Add SwapTwoNumbers.c file in swap-two-numbers folder

assign it to me

!assign

Hey @anxkhn,
This issue has been assigned to you for more than 15 days.
We are unassigning you from this issue.
If you are still interested in contributing to this issue, please get auto-assigned on the issue by commenting !assign again.
Thanks for your contributions :)

!assign


[service management] add certificate as string support

This adds support to be able to provide a string to sms for the required client certificate in addition to a filesystem path and windows certificate store.
The reasoning for adding this support is to support key management services in the public cloud where you will be making an API call to store/get your certificate.  There is no reason to also write it to disk.
Tests have been run under the different connection types.  I have updated legacy_mgmt_settings_fake.py with this to show that I clearly added this and tested it locally.
Having not contributed to this repository before, please let me know your thoughts on this change and if you think it is reasonable or not.  I have signed the CLA and it should match my user appropriately if you choose to proceed with the merge.
Thank you,
-d

@drewrothstein,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #1396 into master will decrease coverage by <.01%.
The diff coverage is 37.5%.

@@            Coverage Diff             @@
##           master    #1396      +/-   ##
==========================================
- Coverage   52.61%   52.61%   -0.01%
==========================================
  Files        3299     3299
  Lines       83894    83916      +22
==========================================
+ Hits        44145    44153       +8
- Misses      39749    39763      +14

Impacted Files
Coverage Δ

...zure/servicemanagement/servicemanagementservice.py
91.96% <ø> (ø)
:arrow_up:

...azure/servicemanagement/servicemanagementclient.py
79.34% <37.5%> (-4.96%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a893677...785b444. Read the comment docs.

Hi @drewrothstein
This is interesting! However, give me a few days to investigate in more details, just got back from vacation and there's fire everywhere :)

CLA was already signed, do I need to re-sign?

The CLA bot is then supposed to change the label automatically :/ Do you have any email confirmation or something, so I could yell at the bot team? :)

I do have an email confirmation from Docusign.  Please let me know how you would like me to share that.

Closing my PRs that haven't received any love in a long while.

No worries; I understand.


Fix PublishDate parameter

Also rename from PublishedDate, since PublishDate seems to be the default
This fixes a warning on (re)building the site
WARN  calling IsSet with unsupported type "ptr" (*hugolib.pageState) will always return false.
I think this is what this statement was supposed to accomplish, but I'm not 100% sure, so this is a separate PR from the deprecation fix. There's no PublishedDate (or now PublishDate) set for anything at the moment either way, as far as I can tell. When I set one for a random blog post it gets applied just fine with this PR.

Ported from https://github.com/getsolus/solus-hugo-theme/pull/4


Skip "email is verified" screen and continue with registration form.

Core Library
MSAL.js (@azure/msal-browser)
Core Library Version
2.14
Wrapper Library
Not Applicable
Wrapper Library Version
2.14
Public or Confidential Client?
Public
Description
The email verification has multiple steps: user enters his email, Azure sends the code, user enters the code and clicks on 'Verify code' button then there is a last step where the email has been verified and user still needs to click on the Next button to continue the user journey.
Is this possible to skip the last step? If the email is verified, then user should go straight to next screen of the user journey...
MSAL Configuration
No response
Relevant Code Snippets
No response
Identity Provider
None
Source
External (Customer)

MSAL does not control UX and we are not the experts able to answer this kind of question. You haven't specified but I'm assuming you're using Azure B2C, in which case you can open a support ticket here and a B2C support engineer can help clarify this for you.


change in Readme

Adding a language

[ ] The code displays "Hello World" (tio.run may help for testing)
[ ] I have no association with the language
[ ] There are no copyright issues with this code
[ ] The language has not been added prior to this pull request
[ ] I have updated the README

Link to programming language:

i do not accept this change

ok


color crashes

Hello

I caught when changing the color of container and caught a bug

Samsung Tab s6 lite | android 13

Brower chrome 114.0.5735.196

At the moment, we will focus only on desktop browsers on macOS and Windows.


Could Sync support the portable mode of Code 1.25 ?

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
The Code of ver 1.25 now has portable mode, when I enable the portable ,the Sync still download the settings/extens to userdata folder instead of the data folder within Code's folder.
Could it be fixed?
Thank you !
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

"command 'extension.downloadSettings' not found"

when I download setting with portable mode

Vscode supports portable mode since v1.25.
In windows, you can simply make a dir named data to enable portable mode , and all user data and extension will be placed in here.
As @waiaan said , in portable mode , the setting sync will cause an exception with message command 'extension.downloadSettings' not found.
Now in dev tool, we can see the c:\users\name\appdata\roaming\code\user\sync.lock not found

Yes, it would be great if you can send me Pull Request
I will release v3.0.0 with this feature.

Duplicate of #331


Adds a new LanguageServer Builder API

This is a large... breaking change, but all existing tests pass.

Replaces custom mediator framework with MediatR
Adds support for dependency injection internally.
Added some test helpers to make testing a little easier.
Bumped target framework to netstandard2.0

So is DI internal-only, or can consumers add their own stuff to the container?
Am just thinking it would be useful to register handlers that way if they have dependencies...

That's on the list next, first stab was getting things wired up.  Next step is how best to add handlers.

If you're open to a little bike-shedding, I might have some ideas around that (e.g. both Autofac's registration API and the ASP.NET. NET WebAPI controller registration behaviour have ergonomics it might be worth exploring...)

Go right ahead!  🚲 🏠 away.
I just added (an untested part) that does pull the handlers from the container as well.

I think as long as there is a way to manually control which handlers are registered (and when) then it'll be fine. I'll write up some thoughts this arvo and then post them here :)

Those methods make sense.  Just wrapping a little bow around some of the pieces.

Rebased.

Going to merge this for now, and test one of the pre-release packages against omnisharp.

I'll look into adding similar support for the client this weekend :)


KeyValueDiffer is not generic

I get this error when compiling:
/node_modules/ng2-currency-mask/src/currency-mask.directive.d.ts
Typescript Error
Type 'KeyValueDiffer' is not generic.
inputHandler: InputHandler;
keyValueDiffer: KeyValueDiffer<any, any>;
optionsTemplate: {

You should use the version 2.x.x for Angular 2.x.x applications and the version 4.x.x for Angular 4.x.x applications. The latest releases are 2.0.1 and 4.0.1.

worked for me, thanks, I just updated my package.json to :
"ng2-currency-mask": "^2.0.0",


[RFE] ci-automation: Decouple OS version from build tag

Follow-up for https://github.com/flatcar-linux/Flatcar/issues/694
Current situation
The the CI pipeline assumes that the git tag mandates the OS version.
Impact
We have to create the release tags before starting a build. We can't, e.g., start a (nightly or manual) build with a release OS version from a dev/nightly git tag.
Ideal future situation
The OS version is decoupled from the git tag, allowing to tag the release after the build
Implementation options
The OS version could be an optional parameter when starting an SDK/packages build
Additional information
For a release build not only the right OS version is needed but it would also mean that the other logic sets things like the update-engine release key instead of the dev key.

One more consideration: Maybe we can skip creating the build git tag and support building from a branch or even a commit id.
To build from a branch would assume that the user doesn't rely on the CI to set up any submodule rerefences but does this in the branch manually. Having that would make it easier to iterate over a script fix in some later stage of the pipeline.

I moved this to the Upcoming queue again with the intention that we should first make a release with the new pipeline and then get more insights on what changes we want to have.
For the record, on Matrix we discussed a bit more and it could also be interesting to think about alternatives to writing the OS version into the version.txt in git (e.g., it could be written by the SDK container on the fly based on an env var or an existing git tag).


bufio: 1.5.1 panic slice bounds out of range

Hi,
Today, i received panic from bufio reader. I used bufio for tcp connections. The function running for 30 days without problem.
Here is the sample code:
func TCPReader(connection *net.TCPConn) {
   reader := bufio.NewReaderSize(connection, 8192)

   header := make([]byte, 9)
   for {
   	len, err := reader.Read(header[:])
   }
}

Panic Log:
panic: runtime error: slice bounds out of range
goroutine 490939 [running]:
bufio.(*Reader).Read(0xc828791f80, 0xc82858b670, 0x9, 0x9, 0x0, 0x0, 0x0)
/usr/local/go/src/bufio/bufio.go:214 +0x3c8

Have you run your program under the race detector?

Yes, I did'nt see any problem for read.

We're going to need a short program that reproduces this. Can you isolate the issue?

Ok, i will create a small project, and inform you again.

I found data race in tcp reconnect function. I try to change first this. I will inform you.

In that case, I'm going to close this issue until you report back.


BITMAKER-1909 Create CONTRIBUTING.md

Description
Help estela repo improve compared to the community standards
Issue
https://tasks.bitmaker.dev/issues/1909
Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] My code follows the style guidelines of this project.
[x] I have made corresponding changes to the documentation.
[x] New and existing tests pass locally with my changes.
[x] If this change is a core feature, I have added thorough tests.
[x] If this change affects or depends on the behavior of other estela repositories, I have created pull requests with the relevant changes in the affected repositories. Please, refer to our official documentation.
[x] I understand that my pull request may be closed if it becomes obvious or I did not perform all of the steps above.

@Adriana618 Could you check this PR pls


🚀 Feature request: Export or share Pluto log data in JSON/CSV/TXT/HTML formats

Feature description
Capability of exporting a logs from Pluto into formats like JSON/CSV/TXT/HTML.
This feature would really be helpful when we want share the logs with someone or see the logs in some format.
Describe alternatives you've considered
https://github.com/orhanobut/logger
https://github.com/infinum/android-sentinel
This libraries have a very good support of saving the logs into the disk or exporting content into many formats.
Cheers! 🍻 🚀

@RahulSDeshpande we already have sharing capability, you can share logs as text or file (.txt)
let me know if you something else in mind.

@srtvprateek I just found that useful "Share all logs" option in the Logger plugin, and it is very useful!
Is it possible to share the network logs gathered by Network Plugin in a similar way? Currently it is possible to share each call independently, but not a batch of them (unless I have missed that option)
The best is probably to be able to share .har file which can then be opened in any proxy tool for further analysis.

sure @sergii-frost
let me look into this

An advantageous functionality would involve programmatically consolidating Pack Network logs and Logger logs into an internal zip file within an application.
This capability proves beneficial as it facilitates the systematic uploading of logs to a designated backend. Is the feasibility of this feature attainable?


chore: expand Prettier glob to all files

The single quote glob expansion doesn't work on Windows. Instead of changing to the \" escapted double quote, I just used the dot expansion to run on everything and made the Husky hook match

I could override the Prettier config to use double quotes for Yaml files to reduce the diff, if that's preffered

I could override the Prettier config to use double quotes for Yaml files to reduce the diff, if that's preffered

Not necessary (at least, not on my account).  I'm partial to single-quotes.

This looks good!
I've merged the PR that adds the ability to run bundlewatch and browser tests on branches, would you mind rebasing?

@broofa I think you might need to remove and re-add the label to see the bundlewatch job triggered

Looks like the build worked, but there is still a dangling one for bundlewatch API check

Hmm, bundlewatch did run correctly now (https://github.com/uuidjs/uuid/actions/runs/4504866899/jobs/7929883055?pr=701) but still doesn't report status…

Might be this https://github.com/bundlewatch/bundlewatch/issues/220#issuecomment-763438369

Might be this bundlewatch/bundlewatch#220 (comment)

Wanna give it a try?


Popper won't hide

When setting this way
<button
 [popper]="popper"
                   [popperHideOnClickOutside]="true"
                   [popperStyles]="{'max-width': '250px'}"
                   [popperPlacement]="'top'"
                   [popperTrigger]="'none'"> TEST </button>

 <popper-content #popper>

                Esistono già delle richieste in sospeso per l'utente selezionato.

                Vai allo storico richieste per verificare lo stato.

        </popper-content>

After calling popper.show(), popper won't disappear when clicking outside,
even specifying popperHideOnClickOutside

I created a workaround after posting this issue, but I hadn't the time to share..
component.ts
@ViewChild(PopperContent) popperContent: PopperContent;

myShowFunction(){
    this.managementDisabledInfo.show();
    this._listener = this._renderer.listen("document", "click", this._hidePopper.bind(this));
}

private _hidePopper($event: MouseEvent): void {
    const popperNative = this.popperContent.elemRef.nativeElement;
    if ($event.srcElement &&
        $event.srcElement === popperNative ||
        popperNative.contains($event.srcElement)) {
            return;
    }
    typeof this._listener === typeof isNaN && this._listener();
    // Turn off the listener, because you'll create another
    // if opening the popover again
    this.popperContent.hide();
}

@tonysamperi Hey, the reason the popperHideOnClickOutside dosnt take effect when calling popperContent.show(), is because it is a property of the popper directive.
I'll look into moving this to be managed by the PopperContent.
For now the workaround will work fine, just make sure you clear the listener on ngOnDestroy.

Alright! Thanks for the answer!
Yes, I remembered to turn off the listener on ngDestroy.
All the best
Tony

Also faced this issue, have a repo to reproduce: https://stackblitz.com/edit/ngx-popper-close-bug


Any nodeJS SSO sample

Sample is only in C#. Anything for NodeJS?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ab060f59-0fc6-d90d-6b71-a0756f1a8aa0
Version Independent ID: f7574aeb-0002-5e07-47ed-3d135a42f4ce
Content: Add Single sign on to a bot - Bot Service - Bot Service
Content Source: articles/v4sdk/bot-builder-authentication-sso.md
Service: bot-service
GitHub Login: @Kaiqb
Microsoft Alias: kamrani

Also with SSO, is it still required for user to click on the "sign in" card beforehand to perform the handshake on MS teams?

@jonathanhotono There is not yet a JavaScript/Node.js version of this sample. You can request one by filing a Samples Feature request issue in the samples repo.

@jonathanhotono There is no time line yet for JavaScript/Node.js version. But it is on the TODO list.
Thank you for asking.


Extract all the required parameters from the command's description

The puzzle 25-de00f783 from #25 has to be resolved:
https://github.com/Decision-Driven-Development/logic-checker/blob/c075c0ff7f4f018a805817e65d323a4669a338b4/src/main/java/ru/ewc/checklogic/server/CommandPage.java#L75-L75
The puzzle was created by Евгений Терехов on 14-Jun-24.
role: DEV.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

One way of doing it involves #17.
Another way could be just getting those arguments from fully parsed command via library call.

The puzzle 25-de00f783 has disappeared from the source code, that's why I closed this issue.


The Cultural Broadcasting Archive

The Cultural Broadcasting Archive of Austria reached out to us about inclusion in Openverse. We're waiting for more technical detail but here's what they've provided so far.
Source Site
https://cba.fro.at/explore
Value Provided
120,000 German-language podcasts
Licenses Provided
All CC licenses are in use.
Implementation

[ ] 🙋 I would be interested in implementing this feature.

Hi there, which technical detail would be need to get included?

Hi @thomasdiesenreiter. The first thing to know—is there an API or other mechanism to get the data of all items in CBA? If there's not an API, we could also figure something out with, for example, bulk files containing the metadata about works in CBA that we can access periodically.

Hi there,
the cba is basically a heavily expanded wordpress site. We use a modified cpt structure with stations<podcasts<posts<attachments. For audio attachments we create additional metafiles like waveforms.
The easiest way atm is to use the rest API. We have some custom routes which pull all the relevant information for the mediafiles together. I can try to setup an in detail documentation.
One disclaimer: Some files have copyrighted music in it. We have the proper licenses for playout, but nonetheless are working on providing automatically cut versions without copyrighted music (including an editor for endusers to identify which files are copyrighted). I suppose that would be the version that could added to openverse?
Also: I hadn't had the time to take a look if you restrict the kind of cc licenses you accept. Do you have any restrictions here? We offer our users the freedom to select the cc version they would like to use.

Thanks, Thomas! We include all of the CC licenses. We also already ingest some sources using WP Rest API endpoints so we have experience there too.
The copyrighted music piece does sound important. It is likely we would have to wait for that to be completed. Or, are broadcasts with copyrighted music labeled as such? If they are we could just exclude them from our pipeline.

Good to know, thanks!
Yes, broadcasts with copyrighted music are labeled and can be filtered. Maybe then it is best to wait for us to finish the process of cleaning the broadcasts from the copyrighted music and then get back to you.


Kestrel faills periodically:Error -107 ENOTCONN

I've upgraded my app to rc2 and now my app periodically fails after some hours of running.
I am using ubuntu 15.04, mono <IP_ADDRESS> + asp.net core rc2 (https://www.microsoft.com/net/core#ubuntu)
Unhandled Exception: Microsoft.AspNetCore.Server.Kestrel.Networking.UvException: Error -107 ENOTCONN socket is not connected at Microsoft.AspNetCore.Server.Kestrel.Networking.Libuv.Check (Int32 statusCode) <0x40abee50 + 0x0004f> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.Networking.Libuv.tcp_getpeername (Microsoft.AspNetCore.Server.Kestrel.Networking.UvTcpHandle handle, Microsoft.AspNetCore.Server.Kestrel.Networking.SockAddr& addr, System.Int32& namelen at Microsoft.AspNetCore.Server.Kestrel.Networking.UvTcpHandle.GetPeerIPEndPoint () <0x40ad1940 + 0x0004b> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.Http.Connection.Start () <0x40ad0e00 + 0x0010b> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.Http.ListenerSecondary.ReadStartCallback (Microsoft.AspNetCore.Server.Kestrel.Networking.UvStreamHandle handle, Int32 status) <0x40ace1d0 + 0x003a3> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.Http.ListenerSecondary+<>c.<ConnectedCallback>b__13_1 (Microsoft.AspNetCore.Server.Kestrel.Networking.UvStreamHandle handle, Int32 status2, System.Object state) <0x40acdde0 + 0x0005b> i at Microsoft.AspNetCore.Server.Kestrel.Networking.UvStreamHandle.UvReadCb (IntPtr handle, Int32 status, Microsoft.AspNetCore.Server.Kestrel.Networking.uv_buf_t& buf) <0x40acdbf0 + 0x0006a> in <filename unknown>:0 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () <0x40f33640 + 0x0002b> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.KestrelThread.Stop (TimeSpan timeout) <0x40f80dc0 + 0x0052b> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.KestrelEngine.Dispose () <0x40f80cc0 + 0x00073> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.KestrelServer.Dispose () <0x40f7a380 + 0x0003e> in <filename unknown>:0 at Microsoft.AspNetCore.Hosting.Internal.WebHost.Dispose () <0x40f7a110 + 0x0006f> in <filename unknown>:0 at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run (IWebHost host, CancellationToken token, System.String shutdownMessage) <0x40aab510 + 0x003a5> in <filename unknown>:0 at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run (IWebHost host) <0x40aaac80 + 0x001db> in <filename unknown>:0 at Must.Backend.Program.Main (System.String[] args) <0x408dee00 + 0x000d7> in <filename unknown>:0 [ERROR] FATAL UNHANDLED EXCEPTION: Microsoft.AspNetCore.Server.Kestrel.Networking.UvException: Error -107 ENOTCONN socket is not connected at Microsoft.AspNetCore.Server.Kestrel.Networking.Libuv.Check (Int32 statusCode) <0x40abee50 + 0x0004f> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.Networking.Libuv.tcp_getpeername (Microsoft.AspNetCore.Server.Kestrel.Networking.UvTcpHandle handle, Microsoft.AspNetCore.Server.Kestrel.Networking.SockAddr& addr, System.Int32& namelen at Microsoft.AspNetCore.Server.Kestrel.Networking.UvTcpHandle.GetPeerIPEndPoint () <0x40ad1940 + 0x0004b> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.Http.Connection.Start () <0x40ad0e00 + 0x0010b> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.Http.ListenerSecondary.ReadStartCallback (Microsoft.AspNetCore.Server.Kestrel.Networking.UvStreamHandle handle, Int32 status) <0x40ace1d0 + 0x003a3> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.Http.ListenerSecondary+<>c.<ConnectedCallback>b__13_1 (Microsoft.AspNetCore.Server.Kestrel.Networking.UvStreamHandle handle, Int32 status2, System.Object state) <0x40acdde0 + 0x0005b> i at Microsoft.AspNetCore.Server.Kestrel.Networking.UvStreamHandle.UvReadCb (IntPtr handle, Int32 status, Microsoft.AspNetCore.Server.Kestrel.Networking.uv_buf_t& buf) <0x40acdbf0 + 0x0006a> in <filename unknown>:0 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () <0x40f33640 + 0x0002b> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.KestrelThread.Stop (TimeSpan timeout) <0x40f80dc0 + 0x0052b> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.KestrelEngine.Dispose () <0x40f80cc0 + 0x00073> in <filename unknown>:0 at Microsoft.AspNetCore.Server.Kestrel.KestrelServer.Dispose () <0x40f7a380 + 0x0003e> in <filename unknown>:0 at Microsoft.AspNetCore.Hosting.Internal.WebHost.Dispose () <0x40f7a110 + 0x0006f> in <filename unknown>:0 at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run (IWebHost host, CancellationToken token, System.String shutdownMessage) <0x40aab510 + 0x003a5> in <filename unknown>:0 at Microsoft.AspNetCore.Hosting.WebHostExtensions.Run (IWebHost host) <0x40aaac80 + 0x001db> in <filename unknown>:0 at Must.Backend.Program.Main (System.String[] args) <0x408dee00 + 0x000d7> in <filename unknown>:0 Jun 27 03:24:15  systemd[1must.service: Main process exited, code=exited, status=1/FAILURE Jun 27 03:24:15  docker[25413Error response from daemon: no such id: must. Jun 27 03:24:15  docker[25413Error: failed to stop containers: [must.] Jun 27 03:24:15  systemd[1must.service: Control process exited, code=exited status=1 Jun 27 03:24:15  systemd[1must.service: Unit entered failed state. Jun 27 03:24:15  systemd[1must.service: Failed with result 'exit-code'.

 While this error may still be logged (even on .NET Core) when a client quickly disconnects after establishing a connection, the entire app shouldn't fail anymore.
Feel free to comment if this isn't the case, and I can reopen.

@halter73, In our production, this issue happened all the time ——
2017-01-24T15:23:45.0219570+08:00 [ERROR] (Piao//) ListenerSecondary.OnConnection
Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -107 ENOTCONN socket is not connected
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.ThrowError(Int32 statusCode)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.tcp_getpeername(UvTcpHandle handle, SockAddr& addr, Int32& namelen)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvTcpHandle.GetPeerIPEndPoint()
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Connection..ctor(ListenerContext context, UvStreamHandle socket)
at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.ListenerSecondary.ReadStartCallback(UvStreamHandle handle, Int32 status)

@gzpbx The error should be pretty benign now. Previously it was fatal. Would you prefer this error wasn't logged at all, or would logging it as a warning or information be sufficient?

@halter73 I'm actually having the same problem as @gzpbx . We're also hosting a Kestrel server on asp .net core 1.1 in our case using the official microsoft/aspnetcore1.1 container. Similar to @agoretsky we have an HA Proxy in front of our services.
Within the last couple of weeks we've seen the containers fail however and give a similar stack trace:
Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvException: Error -107 ENOTCONN socket is not connected    at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.Libuv.tcp_getpeername(UvTcpHandle handle, SockAddr& addr, Int32& namelen)    at Microsoft.AspNetCore.Server.Kestrel.Internal.Networking.UvTcpHandle.GetPeerIPEndPoint()    at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Connection..ctor(ListenerContext context, UvStreamHandle socket)    at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.Listener.DispatchConnection(UvStreamHandle socket)    at Microsoft.AspNetCore.Server.Kestrel.Internal.Http.TcpListener.OnConnection(UvStreamHandle listenSocket, Int32 status)
We run our integration tests and eventually our services will get into this state and it prevents the service from properly responding. Any information about where to dig to find out more would be useful. I'm a bit at a loss considering the stack trace is buried in Kestrel and we haven't been able to reproduce it consistently with exact circumstances.

@sparksterz Are you still having this issue? If so, is your project.json targeting netcoreapp1.1 or net451?
It's known that this exception can occur for very short-lived connections though it should be rare. Also, as I mentioned above, this error should no longer be fatal.
Since you have an integration test that reproduces this issue, can you provide a repro? Feel free to open a new issue. Thanks.

It's targeting netcoreapp1.1 I also updated it to the 1.1.1 container as well as putting it behind nginx to help see if request throttling may have been the issue and still no dice. We're still unable to figure out exactly what triggers the issue. I think our real problem is related to something on the Amazon end.
Kestrel operates just fine for our tests when running in Windows and a local dynamo db. Put it in a container and run the tests locally and we get some transient Amazon errors, but no Kestrel errors. Once we put it up in Amazon load balanced behind HA Proxy, something triggers it to lose its marbles. I'll have to check if I can make an open source sample in the mean time, but if it's something that's only triggered when deployed in a real AWS environment, that could prove to be a challenge.


Provide an ability to run Rally also on spinning disks

The disk access pattern for indexing in Rally assumes an SSD (i.e. the disk access pattern is non-linear) which kills performance on spinning disks. We should give users a chance to improve the disk access pattern for spinning disks.

Given that 1TB SSDs are affordable (~ 300 EUR / USD) and our complete standard benchmark suite fits on such an SSD there is currently no priority to spend time optimizing for linear disk access patterns, hence closing.


NSwag Typescript compiler: API is not getting called on a PUT function

update(accountId: string, command: UpdateAccountCommand, version: string): Observable<FileResponse> {
        let url_ = this.baseUrl + "/v{version}/Accounts/{accountId}";
        if (accountId === undefined || accountId === null)
            throw new Error("The parameter 'accountId' must be defined.");
        url_ = url_.replace("{accountId}", encodeURIComponent("" + accountId));
        if (version === undefined || version === null)
            throw new Error("The parameter 'version' must be defined.");
        url_ = url_.replace("{version}", encodeURIComponent("" + version));
        url_ = url_.replace(/[?&]$/, "");

        const content_ = JSON.stringify(command);

        let options_ : any = {
            body: content_,
            observe: "response",
            responseType: "blob",
            headers: new HttpHeaders({
                "Content-Type": "application/json",
                "Accept": "application/octet-stream"
            })
        };

        return this.http.request("put", url_, options_).pipe(_observableMergeMap((response_ : any) => {
            return this.processUpdate(response_);
        })).pipe(_observableCatch((response_: any) => {
            if (response_ instanceof HttpResponseBase) {
                try {
                    return this.processUpdate(<any>response_);
                } catch (e) {
                    return <Observable<FileResponse>><any>_observableThrow(e);
                }
            } else
                return <Observable<FileResponse>><any>_observableThrow(response_);
        }));
    }

    protected processUpdate(response: HttpResponseBase): Observable<FileResponse> {
        const status = response.status;
        const responseBlob =
            response instanceof HttpResponse ? response.body :
            (<any>response).error instanceof Blob ? (<any>response).error : undefined;

        let _headers: any = {}; if (response.headers) { for (let key of response.headers.keys()) { _headers[key] = response.headers.get(key); }};
        if (status === 200 || status === 206) {
            const contentDisposition = response.headers ? response.headers.get("content-disposition") : undefined;
            const fileNameMatch = contentDisposition ? /filename="?([^"]*?)"?(;|$)/g.exec(contentDisposition) : undefined;
            const fileName = fileNameMatch && fileNameMatch.length > 1 ? fileNameMatch[1] : undefined;
            return _observableOf({ fileName: fileName, data: <any>responseBlob, status: status, headers: _headers });
        } else if (status !== 200 && status !== 204) {
            return blobToText(responseBlob).pipe(_observableMergeMap(_responseText => {
            return throwException("An unexpected server error occurred.", status, _responseText, _headers);
            }));
        }
        return _observableOf<FileResponse>(<any>null);
    }

This is the code for the update method and here is what I call in my angular component:
const form = this.companyForm.value;
    const account: UpdateAccountCommand = new UpdateAccountCommand();
    account.init({
      company: form.company.compName,
      status: 1,
      address: form.company.address,
      address2: form.company.address2,
      city: form.company.city,
      region: form.company.state,
      postalCode: form.company.postal,
      country: form.company.country,
      mainPhone: form.company.phone,
      defaultDateFormat: form.defaults.defaultDate,
      defaultTimeFormat: form.defaults.defaultTime,
      defaultDateTimeFormat: null,
      defaultCurrencyFormat: form.defaults.defaultCurrency,
      defaultNumberFormat: form.defaults.defaultNumber,
      pcFirstName: form.primaryContact.firstName,
      pcLastName: form.primaryContact.lastName,
      pcEmail: form.primaryContact.email,
      pcPhone: form.primaryContact.phone,
      bcFirstName: null,
      bcLastName: null,
      bcEmail: null,
      bcPhone: null
    });
    this.acctService.update(this.refService.getAcctId(), account, '1').subscribe(result => {
      console.log(result);
    },
    error => {
      console.log(error);
    });

This is what get returned:
{fileName: undefined, data: Blob, status: 200, headers: {…}}

The problem is that the function is acting like an API call has been made and it returns the HttpResponse, but the API hasn't been called. In chrome, the "Network" tab in Dev Tools doesn't show that a request has been made either. I checked my interceptor to verify that the call is reaching that and it is. I'm not sure why the call is returning an HttpResponse if a call was never made. Could you give me some insight as to why this would be? Thanks in advance!

I got it to finally work by changing how I call the PUT function in my component. Instead of using .subscribe() after the call, I put it to toPromise(); and used and async await function to wait for the response. Here's is the changed component code below:
async saveAccount() {
    const form = this.companyForm.value;
    const account: UpdateAccountCommand = new UpdateAccountCommand();
    account.init({
      accountObjParams...
    });
    const accountUpdate = await this.acctService.update(this.refService.getAcctId(),
              account, '1').toPromise();
    // Show response in console.
    console.log(accountUpdate);
}

I'm going to keep the issue open as using .subscribe() should work.

Why isnt subscribe working?

I don't know. When I use subscribe, the function acts like it has made a call to the api and returns a file object that has a status of 200 (Shown in the initial post). The api doesn't actually get called and in Developer tools in Chrome the call doesn't show up in the network tab.

Very strange, seems like an angular problem.

Can you repro the problem with a simple angular http call without all the generated code?

I haven't tried a simple http call through angular, but I have tried it through postman and it worked just fine. I will try it using angular with just the basics and let you know what I find. Thanks for looking into this though, I appreciate it.