ova VM complains about external folder missing

the OVA for PySB complains that /home/jmuhlich/.../ is not available and thus makes it impossible for people using the VM to transfer files between their native OS and the VM.

VM is no longer a supported install method, please see the updated installation docs to use Anaconda or Docker. Closing this issue.


vsCode plugin errors panel for current document

https://www.notion.so/digma1/vsCode-Plugin-Runtime-Error-Mockups-e574c042488e480693413ce6a160c780

Show each error flow frame separately, with an option to toggle between callstack (raw) and frames


Please invite me to the GitHub Community Organization

I have served as Student volunteer for CodeVisors already, Kindly add me to the Github organisation

Hey soumya wellcome to CodeVisors GitHub Community, Here you can find many repositories where you can contribute before HacktoberFest ends.


freeradius 1.9.2 broke configuration after update to opnsense 19.1.6

After updating to 19.1.6, i got lots of errors with ubuntu clients, using wpa2/eap/mschapv2 using freeradius. Auth is LDAP.
21:25:50 2019 : Auth: (38) Login incorrect (mschap: FAILED: No NT/LM-Password. Cannot perform authentication): [username/] (from client Radius-Clients LAN 1 port 0 via TLS tunnel)
erm...i do not user nt/lm passwords...where does this come from?

Not aware of these changes. Does reverting the plugin help?
# opnsense-revert -r 19.1.5 os-freeradius

Cheers,
Franco

If a revert works, please update to latest version again, stop radius via /usr/local/etc/rc.d/radiusd stop and start in debug mode:
radiusd -X
@fichtner Only thing we did was certicate script, ldap user/pw hardening and ldap group, correct?
Then I'd love to see the output

Maybe a problem in the new escaping using single quotes, but that would mean it's not a general issue.

tried already reverting the plugin yesterday, did not fix it.
i reverted back completely to 19.1.5_1 now and first will retry asap. If this works, i'll update again will debugging according to mimugmail and post output here.

What was the last known running version?

os-freeradius 1.9.0 on opnsense 1.19.5_1

Debug-Log (partially)
radius.txt

rlm_ldap (ldap): Reserved connection (5)
(8) ldap: Performing search in "dc=gwch,dc=net" with filter "(uid=%{%{Stripped-User-Name}:-%{User-Name}})", scope "sub"
(8) ldap: Waiting for search result...
(8) ldap: Search returned no results
Can you install the latest version and edit the file
/usr/local/opnsense/service/templates/OPNsense/Freeradius/mods-enabled-ldap
Line 81, replace '{{ OPNsense.freeradius.ldap.group_filter }}' with '(objectClass=posixGroup)' then save and type service configd restart and save via UI ...

same result. will deliver debug logs later.

Can you also try:
# opnsense-revert -r 19.1.5 freeradius3

Reverted, without any success.
How can i prevent the actual configuration from taken, if i would reinstall on a clear freeradius-basis?

Can you post the output of Freeradius ldap config?
What about other Client OS as you only mention Ubuntu

Same problem on Fedora, Android and iOS.

got it. in fact, it's been very simple. i just had to change the user filter (Benutzerfilter)

...for the moment, i do not remember, how the old string got in, eventually it's been automatic?

...it does not seem the final solution. My account is the only one, that works for the moment. I entered the account as radius user, logged in, and then deleted the account again. after that, it worked.
I did this not for my wife, so it does not work for her.

btw. found those errors in log:
15:59:14 2019 : Warning: [/usr/local/etc/raddb/mods-config/attr_filter/access_reject]:11 Check item "FreeRADIUS-Response-Delay-USec" found in filter list for realm "DEFAULT".
Fri Apr 12 | 15:59:14 2019 : Warning: [/usr/local/etc/raddb/mods-config/attr_filter/access_reject]:11 Check item "FreeRADIUS-Response-Delay" found in filter list for realm "DEFAULT".

other thumb question:
[roger/]
is the slash after username correct?

Think so, yes. As I'm on vacation the next week hard for me to reproduce

what i can confirm, is that it works without ldap. I created the users on the opnsense, in that case freeradius works. its the ldap-integration, which is faulty.

Only thing I know is that WIFI EAP doesn't work with LDAP .. I'll try to test it.

thats exactly how i've been using it for until 19.1.5. Since the update to 19.1.6 it's broken. all other ldap-connections than those using freeradius are working without problem (authentication, openvpn...)

Do you use LDAP as OpenVPN backend or Radius as OpenVPN backend which in turn is connected via LDAP?

ldap for both. freeradius for wifi only.

So next test would be to select Radius a Backend for Open VPN

How is progress on this?

Hi Michael,
I've searched the option in openvpn with gui, but did not find. OpenVPN uses just LDAP, which works straight.

see screenshot

could you please post your localradius? Mine doesn't work. Just to make
sure, i have no error.
Am 24. April 2019 09:31:28 schrieb Michael<EMAIL_ADDRESS>
see screenshot
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

no need. Got it. But same effect.
Am 24. April 2019 13:16:39 schrieb Roger Grosswiler<EMAIL_ADDRESS>
could you please post your localradius? Mine doesn't work. Just to make
sure, i have no error.
Am 24. April 2019 09:31:28 schrieb Michael<EMAIL_ADDRESS>
see screenshot
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

btw. connecting directly to ldap when authenticating vpn works perfect.

So, when Radius is connected to LDAP and it doesn't work with OpenVPN, but LDAP as a backend directly works, it's an error in LDAP config within FreeRadius plugin.

This might be, i'll check it out. What i do not understand, that it's been working until 19.1.5.

You may have an error in your search filter.
The saerch filter wasn't respected before this update:
https://github.com/opnsense/plugins/pull/1239/files

OK, i gonna check my filter in that case.

Have this filter inserted, but does not work:
(&(|(objectclass=person))(|(uid=%uid)(|(cn=%uid))))
I use this filter also on other places, but works there well (nextcloud).

this looks weird.... how about this
(&(objectclass=person)(uid=%uid))

(edited post again)

same.

Then set LDAPS to LDAP and to a packet capture with -X to see what happens in clear text.

Ready to process requests (0) Received Access-Request Id 8 from <IP_ADDRESS>:40217 to <IP_ADDRESS>:1812 length 84 (0)   User-Name = "[Username]" (0)   Service-Type = Login-User (0)   Framed-Protocol = 15 (0)   NAS-Identifier = "5cc6a82bb5e14" (0)   NAS-Port = 0 (0)   NAS-Port-Type = Ethernet (0)   User-Password = "[Password]" (0) # Executing section authorize from file /usr/local/etc/raddb/sites-enabled/default (0)   authorize { (0)     policy filter_username { (0)       if (&User-Name) { (0)       if (&User-Name)  -> TRUE (0)       if (&User-Name)  { (0)         if (&User-Name =~ / /) { (0)         if (&User-Name =~ / /)  -> FALSE (0)         if (&User-Name =~ /@[^@]*@/ ) { (0)         if (&User-Name =~ /@[^@]*@/ )  -> FALSE (0)         if (&User-Name =~ /\.\./ ) { (0)         if (&User-Name =~ /\.\./ )  -> FALSE (0)         if ((&User-Name =~ /@/) && (&User-Name !~ /@(.+)\.(.+)$/))  { (0)         if ((&User-Name =~ /@/) && (&User-Name !~ /@(.+)\.(.+)$/))   -> FALSE (0)         if (&User-Name =~ /\.$/)  { (0)         if (&User-Name =~ /\.$/)   -> FALSE (0)         if (&User-Name =~<EMAIL_ADDRESS> { (0)         if (&User-Name =~<EMAIL_ADDRESS>  -> FALSE (0)       } # if (&User-Name)  = notfound (0)     } # policy filter_username = notfound (0)     [preprocess] = ok (0)     [chap] = noop (0)     [mschap] = noop (0)     [digest] = noop (0) suffix: Checking for suffix after "@" (0) suffix: No '@' in User-Name = "[Username]", looking up realm NULL (0) suffix: No such realm "NULL" (0)     [suffix] = noop (0) eap: No EAP-Message, not doing EAP (0)     [eap] = noop (0)     [files] = noop rlm_ldap (ldap): Reserved connection (0) (0) ldap: Performing search in "dc=[domain],dc=net" with filter "(&(objectclass=person)(|(uid=%uid)(cn=%uid)))", scope "sub" (0) ldap: Waiting for search result... (0) ldap: Search returned no results rlm_ldap (ldap): Released connection (0) Need 5 more connections to reach 10 spares rlm_ldap (ldap): Opening additional connection (5), 1 of 27 pending slots used rlm_ldap (ldap): Connecting to ldap://[server].[domain].net:389 rlm_ldap (ldap): Waiting for bind result... rlm_ldap (ldap): Bind successful (0)     [ldap] = notfound (0)     if ((ok || updated) && User-Password) { (0)     if ((ok || updated) && User-Password)  -> FALSE (0)     [expiration] = noop (0)     [logintime] = noop (0) pap: WARNING: No "known good" password found for the user.  Not setting Auth-Type (0) pap: WARNING: Authentication will fail unless a "known good" password is available (0)     [pap] = noop (0)   } # authorize = ok (0) ERROR: No Auth-Type found: rejecting the user via Post-Auth-Type = Reject (0) Failed to authenticate the user (0) Using Post-Auth-Type Reject (0) # Executing group from file /usr/local/etc/raddb/sites-enabled/default (0)   Post-Auth-Type REJECT { (0) attr_filter.access_reject: EXPAND %{User-Name} (0) attr_filter.access_reject:    --> [Username] (0) attr_filter.access_reject: Matched entry DEFAULT at line 11 (0)     [attr_filter.access_reject] = updated (0)     [eap] = noop (0)     policy remove_reply_message_if_eap { (0)       if (&reply:EAP-Message && &reply:Reply-Message) { (0)       if (&reply:EAP-Message && &reply:Reply-Message)  -> FALSE (0)       else { (0)         [noop] = noop (0)       } # else = noop (0)     } # policy remove_reply_message_if_eap = noop (0)   } # Post-Auth-Type REJECT = updated (0) Login incorrect (No Auth-Type found: rejecting the user via Post-Auth-Type = Reject): [[Username]/[Password]] (from client Radius Clients Localhost port 0) (0) Delaying response for 1.000000 seconds Waking up in 0.2 seconds. Waking up in 0.7 seconds. (0) Sending delayed response (0) Sent Access-Reject Id 8 from <IP_ADDRESS>:1812 to <IP_ADDRESS>:40217 length 20 Waking up in 3.9 seconds.

I meant tcpdump with -X :)

;) i just saw now, that freeradius does not get any user back from ldap at all. So this might be, that the query to my qnap nas is malformed.
(0) ldap: Search returned no results

I am seeing a similar/same situation. When I look in my LDAP logs, it appears that FreeRadius is no longer performing the expansions for Stripped-User-Name and User-Name before submitting the query to LDAP. From my 389 logs:
[04/May/2019:21:58:17.031148563 +0000] conn=10384 op=2 SRCH base="cn=users,cn=accounts,dc=at1,dc=netcentrix,dc=net" scope=2 filter="(uid=%{%{Stripped-User-Name}:-%{User-Name}})" attrs="radiusauthtype radiussimultaneoususe radiuscalledstationid radiuscallingstationid lmpassword ntpassword sambaLMPassword sambaNTPassword dbcspwd userPassword acctflags radiusexpiration radiusnasipaddress radiusservicetype radiusframedprotocol radiusframedipaddress radiusframedipnetmask radiusframedroute radiusframedrouting radiusfilterid radiusframedmtu radiusframedcompression radiusloginiphost radiusloginservice radiuslogintcpport radiuscallbacknumber radiuscallbackid radiusframedipxnetwork radiusclass radiussessiontimeout radiusidletimeout radiusterminationaction radiusloginlatservice radiusloginlatnode radiusloginlatgroup radiusframedappletalklink radiusframedappletalknetwork radiusframedappletalkzone radiusportlimit radiusloginlatport radiusreplymessage radiustunneltype radiustunnelmediumtype radiustunnelprivategroupid radiuscontrolattribute radiusrequestattribute radiusreplyattribute"

Will be fixed with 19.1.8 by https://github.com/opnsense/plugins/pull/1319

For those looking for a workaround, setting the User Filter to "(uid=%{User-Name})" is currently working in our environment.

This issue may also be gone with 19.1.8. There's a fix regarding the string interpolation inside the user and group filter.

A feedback would be very appreaciated :)

Sorry Mimugmail :)
opnsense-patch -c plugins 12f89de
Fetched 12f89de via https://github.com/opnsense/plugins
1 out of 2 hunks failed while patching opnsense/service/templates/OPNsense/Freeradius/mods-enabled-ldap
perhaps i did something wrong?

@fichtner thx for help for patching.
i can confirm, freeradius again is working using ldap, in conjunction with eap.
Thx!

Ok, no problem. :) We have the patch queued up for 19.1.8 already which should come out next week.

@fichtner thx for help for patching.
i can confirm, freeradius again is working using ldap, in conjunction with eap.
Thx!

Hi!
I can't connect any wireless device with freeRadius + openLDAP. I use openVPN with openLDAP (LDAPS) and it work properly.
Could you tell me your settings about LDAP (User filter and Group filter) and EAP (type EAP) tabs?
I also tried with plain-text password but it doesn't work in LDAP either.
I have the latest version of opnSense (20.1.8).
Any help would be greatly appreciated.
Many thanks.

EAP does not work via LDAP .. only Kerberos which is not supported


Blazor.BrowserExtension.Template could not be installed, the package does not exist.

C:\WINDOWS\syastem32>dotnet new --install Blazor.BrowserExtension.Template
Warning: use of 'dotnet new --install' is deprecated. Use 'dotnet new install' instead.
For more information, run:
   dotnet new install -h

The following template packages will be installed:
   Blazor.BrowserExtension.Template

Blazor.BrowserExtension.Template could not be installed, the package does not exist.

For details on the exit code, refer to https://aka.ms/templating-exit-codes#103

I'm getting this error, I'm pretty new to this so I don't know if there is any other way to install the package.

For a start, you can try to see if you can find the template NuGet package in any of your existing projects package manager. It could be due to network restriction, maybe corporate network that requires setting up proxy to access NuGet.org.
To see more details when installing the template you can use dotnet new install Blazor.BrowserExtension.Template -v normal to check what happened or even -v diagnostic if you want to see all the logs.

Closed due to inactivity. Please reopen if the issue still persist.


Project depth point to color point

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Win10

Platform
PC

SDK Version
<IP_ADDRESS>

Language
Python

Segment
others

Issue Description
Hello,
I am using a D435 camera and I need to change often between color and depth frames and vice versa. However, I am interested just in one or few pixels on the frame.
In order to get a depth pixel from a RGB pixel I am using the function:
rs2_project_color_pixel_to_depth_pixel
My question is: how can I do the same in the opposite way? That is, how can I get a color pixel using a depth pixel?
Thank you in advance

Hi @alexdesion  https://github.com/IntelRealSense/librealsense/pull/1118 demonstrates using Python code to map depth to color with the instruction rs2_project_point_to_pixel

You are very welcome, @alexdesion - thanks very much for the update!


Redirect to new user profile URL after the user removes their slug settings

From 20240110 test result https://g0v.hackmd.io/tiTBOmf_TaGYL9THZtQ9tg#未竟項目1
remove slug 後 user link 不會更新，按 F5 會壞掉 [name=cai]

應該也要 redirect 到 ?id=xxx 的 page 避免此狀況
但這比較少發生，可以另外開票做 [name=mrorz]

taking this issue~

During test, we found that "This user does not exist" still happens, but at least it's less likely to happen.
https://g0v.hackmd.io/@cofacts/meetings/%2FJBzxtPVYTbattxTcYTVRgA#未竟項目

Yeah, I think is the problem of waiting for mutation. This also happens before my change.


[release]: OUI release automation

What is the name of your component?
OUI
What is the link to your GitHub repo?
https://github.com/opensearch-project/oui
Targeted release date
TBD
Where should we publish this component?
NPM
What type of artifact(s) will be generated for this component?
tar.gz
Have you completed the required reviews including security reviews, UX reviews?
Yes
Have you on-boarded automated security scanning for the GitHub repo associated with this component?
Mend: No.
Additional context
No response

Thanks for creating the issue @AMoo-Miki
Posting some offline discussion. We will be working to set up the automation for releasing OUI on NPMJS.
The automation would include below tasks:

Adding GitHub actions workflow to create a draft release based on tag as trigger
Adding a jenkins workflow for releasing the artifact on npmjs
Add a webhook trigger to GitHub that based on draft release (manual one time set up)

Apart from that @AMoo-Miki requested that we also release the artifacts on staging account which is https://www.npmjs.com/package/@opensearch-staging/oui
After discussing with the team looks like publishing artifacts on staging is out of scope of the release pipeline.
@bbarani Can you post the suggestions here?
Thanks!

The OUI repository is set for automated releases. Let us know in case of any failures or issues.
Thanks!


Confused about dataset creation

Why is it that the current dataset code creates a larger dataset out of a small dataset by basically creating a new example for each token in the small dataset?
Couldn't I take a larger dataset and simply create the control vector from just the sentence or examples in my document?
The make dataset code seems overly and needlessly complication unless there is some motivation for why it's being done the way you are doing it right now.
Also, this package is AWESOME! Thank you so much for making it!

Yes, you should be able to do that (assuming you have appropriate negative examples). The notebooks are doing a kind of data augmentation to expand the tiny dataset (the 1-3 persona pairs) into a few thousand examples to get enough data to train a vector on. If you have a large dataset already, then that data augmentation isn't needed—you can just train the vectors on the paired examples directly.

Sounds good. Yeah, the dataset augmentation strategy makes sense in regards to exploiting a small dataset the maximal amount possible.
I will work to either integrate this into llm_steer-oobabooga or to create it's own "oobabooga" extension integration of this technique since this comment makes it far more straight forward for letting users bring their own dataset.


WAU repeatedly updates Microsoft.VCRedist.2012.x64

The problem
Since yesterday it seems WAU keeps trying to upgrade Microsoft.VCRedist.2012.x64 even though it is reporting a successful upgrade/install.
Log: updates.log
What version of WAU has the issue?
1.17.6
What version of Windows are you using (ex. Windows 11 22H2)?
Windows 10 22H2 19045.3271
What version of winget are you using?
1.5.1881
Log information
Log extract from yesterday:
23:07:46 - Updating Microsoft Visual C++ 2012 Redistributable (x86) - 11.0.50727 from 11.0.50727.1 to 11.0.61030.0...
23:07:50 - ##########   WINGET UPGRADE PROCESS STARTS FOR APPLICATION ID 'Microsoft.VCRedist.2012.x86'   ##########

Log extract from this morning:
10:05:36 - ##########   WINGET UPGRADE PROCESS FINISHED FOR APPLICATION ID 'Microsoft.VCRedist.2012.x86'   ##########
10:05:36 - Microsoft Visual C++ 2012 Redistributable (x86) - 11.0.50727 updated to 11.0.61030.0 !

Additional information
Foxit reader seems to fail but that doesn't really bother me

Hi,
Can you have a look on you installed program ? you should have 2 versions of the same apps. WAU detects that Winget reports an available update and try to update apps, and of course WAU detects that the update succeed

So I need to remove the duplicates manually?
or should I just keep collecting these?
Seems odd that the old version is left when all other apps only has 1 version installed.
I've gone through and uninstalled the duplicates

i agree, odd to have multiple version, but this is either Winget issue or problem with the application itself. WAU doesn't handle replacement or previous uninstall. Just using winget to upgrade apps.

You could also use the mod-function.
In this case create a Microsoft.VCRedist.2012.x86-preinstall.ps1 (copy _AppID-template.ps1) under mods and therein add the name of the version that should be uninstalled in $AppUninst = @("Microsoft Visual C++ 2012 Redistributable (x86) - 11.0*") - uninstalling all v11 versions of x86.
https://github.com/abbodi1406/vcredist/blob/master/source_links/README.md#microsoft-visual-c-2012-redistributables---v11
I tested with Microsoft Visual C++ 2012 Redistributable (x86) - 11.0.50727 installed and it uninstalled before installing the latest correctly.

I often find that the different VCRedist leaves an registry entry under:
HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall
And, that even if the manifests say: UpgradeBehavior: uninstallPrevious
In those cases you have to delete the reg entry manually.
Hence, my exclusion list in excluded_apps.txt:
Microsoft.dotnet
Microsoft.DotNet.AspNetCore.6
Microsoft.DotNet.Runtime.3_1
Microsoft.DotNet.SDK.3_1
Microsoft.DotNet.SDK.6
Microsoft.Edge
Microsoft.EdgeWebView2Runtime
Microsoft.Office
Microsoft.OneDrive
Microsoft.Teams
Microsoft.VCRedist.2005.x64
Microsoft.VCRedist.2005.x86
Microsoft.VCRedist.2012.x64
Microsoft.VCRedist.2012.x86
Microsoft.VCRedist.2013.x64
Microsoft.VCRedist.2013.x86
Microsoft.VC++2013Redist-x64
Microsoft.VC++2013Redist-x86
Microsoft.VCRedist.2015+.x64
Microsoft.VCRedist.2015+.x86
Microsoft.VC++2015-2019Redist-x64
Microsoft.VC++2015-2019Redist-x86
Microsoft.VC++2015-2022Redist-x64
Microsoft.VC++2015-2022Redist-x86
Microsoft.WindowsSDK

Thanks @KnifMelti for your details


Generate RISC-V PLIC addresses from DTS

Fixes #11055.
Generate RISC-V PLIC MMIO addresses from the DTS instead of hardcoding them in soc.h.

Codecov Report

Merging #11784 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11784   +/-   ##
=======================================
  Coverage   48.27%   48.27%
=======================================
  Files         280      280
  Lines       43321    43321
  Branches    10371    10371
=======================================
  Hits        20913    20913
  Misses      18258    18258
  Partials     4150     4150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c4841...3603193. Read the comment docs.


improve README for gke images

Improve the documentation in the README for the GKE images.
This also contains comments and simplifications in the entry point slips.. which detected a bug in that the gke_env.sh script had not been fully updated for the /opt home for cdbg and cprof

Very nice, thanks!


Modulation instructions for initial Z pulse

MODULATE and UPDATE_FRAME instructions should be applied before WAIT if the sequence starts with a Z. Otherwise, these instructions would be applied too late (after the next pulse).

We'll have to double check on the hardware w.r.t. to the UPDATE_FRAME because we also usually have a RESET_PHASE too. We may have to translate it to a SET_FRAME.

Hmmm, I was forgetting we don't have a  SET_FRAME command but the way the HDL works a reset followed by an UPDATE_FRAME will apply an initial Z pulse. The MODULATE instruction has to wait until after the WAIT_FOR_TRIGGER but it should be pipelined appropriately to line up with the first pulse starting.

Should be fixed by 1f0d87a


chore: update sync upstream script

Description

Make possible to specify target branch for sync-upstream script
Periodic execution using cron has been removed

https://github.com/tier4/autoware_launch/actions/workflows/sync-awf-upstream.yaml

Tests performed

Test1: https://github.com/tier4/autoware_launch/actions/runs/6069558459
Test2: https://github.com/tier4/autoware_launch/actions/runs/6069559677
Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

sync image


Feature/delayed async

Description
Adds support for delayed asynchronous task invocation with SQS as the task source.
@task(service='sqs', delay_seconds=600)
make_pie():
    """ This task is invoked asynchronously 10 minutes after it is initially run. """

GitHub Issues
#1647

Coverage decreased (-0.2%) to 72.475% when pulling 4c11a969eab86dddc5cef051c8fa20a2ab4f8c1d on oliviersels:feature/delayed_async into 32d86987b9dfc24fab99fa8fb7087bfffd449556 on Miserlou:master.

Coverage decreased (-0.2%) to 72.475% when pulling 4c11a969eab86dddc5cef051c8fa20a2ab4f8c1d on oliviersels:feature/delayed_async into 32d86987b9dfc24fab99fa8fb7087bfffd449556 on Miserlou:master.

Would love this to get merged.

Looks good to me. Need some users to test it out and report back. Otherwise it will have to wait for me to have time.

Updated to 0.48.2 (and async -> asynchronous rename)

In route_sqs_task function’s code, it handles only the first message but when Lambda is triggered from SQS, wouldn’t there be multiple messages in Records?

It sets a batch size of 1, so not in this case.

@M0dM wondering how you got on with this?

@ironslob & @jneves Sorry for the late answer...
It is working smoothly since January but the code is not in production as our new product have not been launched yet.
The only "issue" we found was the unavailability to update sqs queue configuration automatically.
We had to change timeout_seconds from 30 to 300 and we got this error while updating using zappa update.
botocore.errorfactory.QueueNameExists: An error occurred (QueueAlreadyExists) when calling the CreateQueue operation: A queue already exists with the same name and a different value for attribute VisibilityTimeout

As the project is not yet in production, we just removed the sqs queue using aws console and called zappa update command again.
It would be nice to have zappa handling this automatically :D

I would be also great if we could use the following client library to send sqs tasks up to 2GB:
https://github.com/timothymugayi/boto3-sqs-extended-client-lib

I make a POC last week.
I have updated my fork with Miserlou/Zappa master branch and implemented usage of sqs-extended-client on my fork repo branch:
https://github.com/M0dM/Zappa/tree/feature/delayed_async
if large_messages_payload_bucket is specified, the sqs queue will user the bucket for large messages.
@task(service='sqs', large_messages_payload_bucket='my_big_recipes')
make_pie_with_long_receipe():
    """ This task is invoked using s3 as relay for large sqs message after it is initially run. """

This may be improved by setting the large_messages_payload_bucket value inside zappa_settings.json instead of setting it inside decorator's arguments.

I will finally start using this feature in a project I'm working on. A requirement for this project was that async invocation could be delayed for more than 15 minutes so I added that feature. I will report back when the testing phase is successful.

@M0dM
I personally use Terraform to manage zappa infrastructure so I don't have that issue in my environments. A fix for that would be nice but I don't see it as absolutely necessary.
The large payload support is a cool nice-to-have (and necessary for some use cases).
But I don't have the spare time and motivation to add/manage those additions. Personally I would be very happy if just this PR could be merged. It has been open for a long time already.

@M0dM
I personally use Terraform to manage zappa infrastructure so I don't have that issue in my environments. A fix for that would be nice but I don't see it as absolutely necessary.
The large payload support is a cool nice-to-have (and necessary for some use cases).
But I don't have the spare time and motivation to add/manage those additions. Personally I would be very happy if just this PR could be merged. It has been open for a long time already.

You are right, I will open another pull request as soon as this got merged.
And I think the update feature can come afterward as an improvement.
Thanks for your work anyway.
Unfortunately, It does not seems the main zappa contributors have a lot of time those days.
I hope it will get merged soon. ;)

Hey!
Will this PR be merged?

@vmiguellima I've opened an issue with a feature proposal on the new zappa repo:

https://github.com/zappa/Zappa/issues/1283


cmd/txt-suite/README.md: update usage commands

Not yet verified whether it produces fully successful run, but the current README commands are definitely not up to date.

Can you rebase so we can get it in?

@ChriMarMe Rebased as requested, although I have not checked if anything change in the tools behavior in the meantime TBH


right-click drag panning behavior changed

Description
(In current main branch, not on live production server)
When I right-click drag to pan the view, instead there is some combined zoom and rotation behavior.
Expected Behavior
Right-click drag should pan the view (translate both view position and view target in the plane of the screen)
Reproduction
Must use a recent git branch to see this behavior.  It is very likely due to updates in three.js's OrbitControls that we need to work better with.
Environment
Observed in both Chrome and Firefox.

fixed by #327


Feature Request - Per request metrics

I like the general approach with this middleware but for understanding performance and other problems one needs per request metrics.

There is https://github.com/iand675/dd-middleware but need to try it out.


Update MD file on new branch 2017-12-04_03-33-41

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestCon1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Specifying certs for private npm registry/mirror

I'm having a little trouble reconfiguring an OpenShift 3.11 build configuration to use this builder with a private mirror of the npm registry. I've used .npmrc to specify what I think should be an appropriate certificate file, but I'm getting an "unable to specify local issuer certificate" error the first time the assemble script tries to fetch something from the npm repo. Do you have any advice on configuring the s2i builder for this?

I haven't tried using a private NPM registry yet, but this is something I'll need to do soon.
You might be able to mount your custom CA at /etc/ssl/certs/ca-bundle.crt as part of your build config. This assumes that the Red Hat RPM that provides npm is patched to use the system certificate bundle, which I haven't verified.
You might also have some luck using the NODE_EXTRA_CA_CERTS environment variable.
Were you able to verify that the .npmrc file exists in the directory that the assemble script runs in? I wonder if the file isn't getting copied over there for some reason since it's a hidden file.

When I have the bandwidth I'm going to test a few different ways to specify the certificate; I'm sure there's something simple I'm missing, or maybe it's the certificate file I was trying to use itself.
I am sure the .npmrc was making it into the build, because once I removed it, builds started working again. Obviously that's just kicking the can down the road in terms of our underlying need to use the mirror, though.

@ddelabru this commit might be of interest to you if you decide to not use the .npmrc file:
https://github.com/mprahl/s2i-angular-httpd24/commit/e6ad29e6443d3d72ca017f12f52d6f89ad1d6dbd


Release/9.8.0

@StefH this has been published.  Just FYI.  Let me know how you get on.

Thanks for the info.


attempt to convert default string values to proper type when mismatched

I would like to be able to store the fixedwidth configurations as json or yaml. I'm able to do this except for the decimal type fields since Decimal is a python-specific value.
Presently, if I have a configuration where
CONFIG = { "myfield": {
...
"type" : "decimal",
"default" : "2.02",
...
}
}
...
FixedWidth(CONFIG)

I get an exception because str is not type Decimal.
This pull request will keep the same logic and exceptions as before except that when the default is a string and the type does not match, we will attempt to parse the string into the type (Decimal or int).
I also added several test cases to verify some of the assumptions (e.g. that a default of float type 2.02 should still fail) and corrected a few pylint warnings.
Would love to get your thoughts on this, please let me know if you think any of the assumptions are off-base or if something needs to change.

@dwcaraway
Thanks for the time you put into this! I favor simple solutions, so I made #8 for you to examine. Let me know if you think it's not as solid as this PR for any reason.
I didn't handle the decimal.InvalidOperation in the newly-changed code because if you put junk in that location it actually blows up in the _string_to_dict function in the main file. I'd rather let it fail loudly so the developer notices and fixes their values before sending something (possibly to a bank). :sunglasses:

#8 looks good to me, the simpler solution is usually best, I'll cancel this pr. thanks!


Dependabot PR are a bit inconsistent for our tooling/process

Is your feature request related to a problem? Please describe.
Mostly (or all) PR tests fails
https://github.com/vmware/repository-service-tuf-cli/actions/runs/3286749761/jobs/5415187329
The dependabot changes don't follow our current process
Current process is quite simple
pipenv shell
pipenv update -d
make requirements

Run local tests
tox -r

Describe the solution you'd like
All ideas below are just a seed, no elaboration was done
Suggestion

Customize the dependabot action to run our process
Dependabot opens a issue only?

Describe alternatives you've considered
No response
Additional context
No response

After discussing with @kairoaraujo the details around how rstuf repositories are configured (using both pipfile and requirements files), we decided it would be best to disable dependabot for python dependencies because of the up-mentioned concerns and instead use a daily cron job that handles the dependency updates but also rebuilds the requirements files (steps from above).
Reference issue for creating a cron job - https://github.com/vmware/repository-service-tuf/issues/84

Closed by completing #86 and #84


Change version selector to retain current page when switching versions (for website v1.15)

Fixes https://github.com/kubernetes/website/issues/19340 for version 1.15 of the website
(Additional PRs will be issued for other versions)

/approve

/assign @stewart-yu

/lgtm

Hi @sftim, it looks like you gave approval 7 days ago, but this never got the approved label, maybe because k8s-ci-robot wasn't looking for it yet.

It's because although I'm a tech lead the 1.15 branch doesn't know this.

@kubernetes/sig-docs-en-owners?

@brianpursley Normally we don’t accept PRs for historical branches, but I think this makes a worthy exception.
/lgtm
/approve


I couldn't get the weights-improvement-48.hdf5

After training, I noticed I just generate weights as follows:
weights-improvement-01.hdf5
weights-improvement-02.hdf5
weights-improvement-03.hdf5
weights-improvement-04.hdf5
Apart from mentioned above, I get no other hdf5 file generated, can anyone tell me what's the problem?
I had checked the address of my training dataset is right and the epoch is 50.

Can you please upload the weights-improvement-48.hdf5 file? The captions generated from the weights-improvement-04.gdf5 is not good.

I am also Facing same problem. After Training network , just generate
weights-improvement-01.hdf5
weights-improvement-02.hdf5
weights-improvement-03.hdf5
weights-improvement-04.hdf5
weights-improvement-05.hdf5
not further improvement of weights. Can anyone share solution for same?
or Can you please upload the weights-improvement-48.hdf5 file

Sorry, I only get the weights-improvement-8.hdf5 file and I cannot figure out why.
At2018-03-20 20:12:48，Abhishek<EMAIL_ADDRESS>I am also Facing same problem. After Training network , just generate
weights-improvement-01.hdf5
weights-improvement-02.hdf5
weights-improvement-03.hdf5
weights-improvement-04.hdf5
weights-improvement-05.hdf5
not further improvement of weights. Can anyone share solution for same?
or Can you please upload the weights-improvement-48.hdf5 file
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@suikammd The reason may be because your loss is not reducing and it is not saving further weight files (we can set this in keras during training)

@sudhakar-sah After changing 1024 batch size, the loss of network is reducing. But the best weight is not good. For example:

@ShixiangWan  I tried this repo few days ago and my loss was not reducing after 2-3 epochs. I am planning to work on this repo. There are few things that we can do for example, we can train a word2vec model on captions and initialize the embedding layer with these weights. are you still working on it ? if you like, we can work on it together ?


composer.json issue with punycode1.3

When i run composer update --dev --prefer-source
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - yiisoft/yii2 2.0.1 requires bower-asset/punycode 1.3.* -> no matching package found.
    - yiisoft/yii2 2.0.0 requires bower-asset/punycode 1.3.* -> no matching package found.
    - yiisoft/yii2 2.0.0 requires bower-asset/punycode 1.3.* -> no matching package found.
    - Installation request for yiisoft/yii2 * -> satisfiable by yiisoft/yii2[2.0.0, 2.0.1, 2.0.2].

with composer.json :
"require": {
        "php": ">=5.4.0",
        "yiisoft/yii2": "*",
        "yiisoft/yii2-bootstrap": "*",
        "yiisoft/yii2-swiftmailer": "*",
        "yiisoft/jquery": "1.10.*"
},
    "require-dev": {
        "yiisoft/yii2-codeception": "*",
        "yiisoft/yii2-debug": "*",
        "yiisoft/yii2-gii": "*",
        "yiisoft/yii2-faker": "*"
    },
    "config": {
        "process-timeout": 1800
    },
    "extra": {
        "asset-installer-paths": {
            "npm-asset-library": "vendor/npm",
            "bower-asset-library": "vendor/bower"
        }
    }
}

Any idea to solve this ? Fresh installation of Yii2 seems fine which is a mystery to me...

try removing your vendor directory and run again

I just ran into the same problem. When checking the yiisoft/yii2 package on packagist (url: https://packagist.org/packages/yiisoft/yii2) it appears that the required bower-asset/... packages don't exist on packagist.
As I am not using the basic-app or advanced-app application structures, this is very awkward.

@cebe gave a right solution, it's confirmed multiple of times: https://github.com/yiisoft/yii2/issues/7402#issuecomment-75649429

try removing your vendor directory and run again

Its super suggestion ) I lost count how many issues we already have with using fxp/composer-asset-plugin. And this is price of wrong decisions in past.

@creocoder if you read carefully the docs of the plugin this is the thing to do when you downgrade packages because it makes a lot of speedup by skipping versions lower than the installed one.
This is also in most cases the solution to problems with composer without the plugin. Composer is still alpha, it is itself not really versioned so one can not ask for a composer versoin that is used because in many places you have another dev version installed. Thats also a big part of the problem.

@cebe I do not care about plugin documentation. This plugin is dirty hack on top of composer. I prefer composer team prevent possibility to write plugin like that. Why such negative? Simple, every day i have troubles with that plugin (incredible long time working, consistent troubles with fetching packages). Am i one hate this part of Yii 2? No. I talked to many people who involved into deploy Yii 2 applications. System administrators hate this plugin since it need to be global.  Many times i hear from colleagues something like lets replace this with another framework, but i defend Yii 2 since i love it. On other side I and lot of people wait for 2.1 where I hope we finally will avoid using things like that. In php world only Yii 2 have such specific troubles.

System administrators hate this plugin since it need to be global.

They have no problem installing global npm javascript things on the server?
I'd like to see how other frameworks handle this kind of thing, as far as I am aware they just do not handle it because they do not provide much frontend stuff.
I am open for alternative solutions to this but I think we should open a new issue for this and define clearly what we need to achive before pushing into different directions.

I overlooked I had to install the fxp/composer-asset-plugin. After installing it, composer ran like a charm.

@cebe

They have no problem installing global npm javascript things on the server?

Ofcourse not, do you have idea how node.js how popular in compare with Yii 2 and this specific plugin? A hundred times more popular, maybe? Node.js on servers is standart nova days since there is bower package manager which require it, since there is grunt/gulp. System administrators does not have idea how some people can code withour such tools. So ofcourse there is no any troubles with node.js on servers.

I'd like to see how other frameworks handle this kind of thing

Look at Laravel, look at Symfony, look at on Zend. Sorry, but they does not solve non existent troubles. Mine personal experience with Laravel cleanly shown that writing V layer with it several times faster than with Yii 2.

Well, my experiences with installing nodejs was always ending in a dependency mess on my machine with several ppas from dubious sources serving my finally working version of the stack... I do not want to have this on my production server.
afaik (correct me if I'm wrong) the other frameworks mentioned do not integrate that much with frontend code like yii does for example with widgets e.g. activeform.

I (and others near me) find that using yii2 enforces too many other packages on us.
When I want to install yii core, that's all I want.
I guess a better separation between the core framework and add-ons using the framework would improve things a lot.
The core framework could be yii\base,  db and ar, validators, RBAC, MVC and application classes. In other words the things that don't cope with the UI and things that don't require third party stuff. Base widget classes (and possibly widgets that are UI independent) can still be part of the core.
Everything else would be in separate packages. This would be things like the email component (using swiftmail), GUI components using jQuery, bootstrap, etcetera. I guess bower could then also taken away from the core.
The yii team has made a good start by separating modules like gii and debug into separate packages. But there's room for improvement in this area.

@cebe

afaik (correct me if I'm wrong) the other frameworks mentioned do not integrate that much with frontend code like yii does for example with widgets e.g. activeform.

ActiveForm/ActiveField is great example of antiproductive and useless (except primitive cases) widgets. First of all it insist on its own validation solution. Second it does it not agile and have significant limitations. Third it "too smart" and naively believes that all form groups should have container and to show some error this container should change css class. Fourth. Sometimes it become mess of php and html (in templates variables). In reality i saw people who stuck with ActiveForm on implementing complex form with day or even more and result was horrible, mess of php and interpolated html code. Moreover that time is enough to 10 times make this form on html + some html helpers and you'll even win time to learn jquery validation plugin or analog to make client side validation.
About other frameworks...
Symfony 2 have powerful form builer: http://symfony.com/doc/current/book/forms.html
Zend Framework have powerful form builder: http://framework.zend.com/manual/current/en/modules/zend.form.intro.html
Laravel use simple html helpers to generate any kind of form, Its absoluttely agnostic to any css frameworks and does not make any assumptions about it structure. You just make any form you want using pure html + such helpers. As result you'll get cleanest form.
All 3 frameworks not reinvent wheel at field of client side validation and suggest user decide best option around that. Novadays there is lot of approaches. Someone use AngularJS and it solution, some use jQuery and plugins for it, someone use ReactJS. Backend framework should not care about client side validation. If you want do best maximum you can do is provide set of validators for most popular frontend solutions to ensure backend validators sync best way with client side validators. Reinventing wheels on that field was very bad idea. In Yii 1.1 it was fine because it was long time ago, in Yii 2 looking on that, looking on validators with jquery client side code on board is just strange.

@cebe Sorry for criticism. Today I feel myself as Yii 2 critic ) It might be helpful to make right decisions inside Yii 2.1. I promise to continue love Yii 2 starting from tomorrow/ ;)

@creocoder You don't have to turn 180 degree against something you are criticizing. Such exaggeration makes your words less credible than it could be.
If you don't want to use client-side validation of ActiveForm, just disable it. If you don't like ActiveForm, just use plain HTML helper methods or code. It may be true for your particular use case, using the built-in ActiveForm is counter-productive. Then just don't use them. No one is forcing you to use them.
I am curious though: when you use third party validation solutions, how do you keep consistency between server-side and client-side validations? Do you have to copy the same error messages on both sides? What about the consistency of validation rules on both sides?
I also wonder if you really have used SF and ZF's form builders. It's funny that you would claim their solution is more powerful while by default they also enforce certain HTML structures. It seems to me you use them as an example just for bashing purpose.
Regarding the asset bundle thing, we already had a long discussion before. We all agree the current solution is not perfect, and we are thinking and experimenting in practice to come up with a better solution. Your proposal earlier on was a good one, but there was still a big gap.

@qiangxue

If you don't want to use client-side validation of ActiveForm, just disable it. If you don't like ActiveForm, just use plain HTML helper methods or code. It may be true for your particular use case, using the built-in ActiveForm is counter-productive. Then just don't use them. No one is forcing you to use them.

Its not about technical troubles. I can disable anything and use any alternate solution. Trouble is about business and companies which use framework. I would also like to believe that the world is perfect, and all coders geniuses. But in reality i saw lot of Yii 1 applications and Yii 2 applications from real people, from real companies. I said ActiveForm is counter-productive in most cases just because i see php + html mess inside most of them. Majority of coders i meet belive that if fw suggest something this solve most use cases. And this is true with most of Yii components except of ActiveForm. Its propaganda in reality lead to situation when it used for everything.

I am curious though: when you use third party validation solutions, how do you keep consistency between server-side and client-side validations? Do you have to copy the same error messages on both sides? What about the consistency of validation rules on both sides?

As i said in my previous post smart decision is provide set of client side validators for popular client side solutions vendors. As i saw most of them have architectures which make it extensible. By doing so you have such consistency garantee. This is similar to why pjax instead of reinventing wheel again was used inside Yii 2.

I also wonder if you really have used SF and ZF's form builders. It's funny that you would claim their solution is more powerful while by default they also enforce certain HTML structures.

It was just answer to @cebe question around other fw solutions. I just call such builders powerful because i know ppl who use it for every-day development and they claim any form can be builded with that. But its Enterprise while we are RAPID. I do not call such solutions more powerful than others. Its just other approach of creating forms. Laravel use similar to ours Yii 1 ActiveForm solution which i think was more interesting and agile than current. Yes, current has less code in some cases, but in real practice cases it usually lead to php + interpolated html mess.

As i said in my previous post smart decision is provide set of client side validators for popular client side solutions vendors. As i saw most of them have architectures which make it extensible. By doing so you have such consistency garantee. This is similar to why pjax instead of reinventing wheel again was used inside Yii 2.

You still haven't answered how do you ensure consistency between server-side and client-side validations. Or do you mean we only need client-side validation?

I just call such builders powerful because i know ppl who use it for every-day development and they claim any form can be builded with that. But its Enterprise while we are RAPID. I do not call such solutions more powerful than others. Its just other approach of creating forms. Laravel use similar to ours Yii 1 ActiveForm solution which i think was more interesting and agile than current. Yes, current has less code in some cases, but in real practice cases it usually lead to php + interpolated html mess.

When you use form builders, you are already mixing PHP and HTML code. And as I said ActiveForm doesn't attempt to solve all form creation tasks. It's actually like a form builder and attempts to solve a set of common tasks. It seems you are contradicting to your own arguments.

@qiangxue

You still haven't answered how do you ensure consistency between server-side and client-side validations. Or do you mean we only need client-side validation?

Frontend client side validation solutions is library itself + validators. We can just use our solutions only for library validators (to have 100% sync with backend validators) but use library as main background. If inventing own solution is most wanted way its OK, sometimes reinventing wheels lead to something revolutionary, but in that case we need make this solution opened to frontend world to have more feedback.

When you use form builders, you are already mixing PHP and HTML code.

This is not true in case of Symfony and Zend builders. It used inside controllers and have its own views for rendering. I can agree that ActiveForm is similar to real form builders (which mean implementing of Builder pattern), but its far from classical solutions around that.

@qiangxue A simple example about client side validation. For example we decide use http://jqueryvalidation.org/ which is very popular and even start Pledgie campaign for next enhancements. It can be easily extended by own set of validators. I'm sure it will not neccesary for all validators we can reuse lot of buildin. But if it needed we can use $.validator.addMethod("someValidator", function(value, element, params) { ... }).

Frontend client side validation solutions is library itself + validators. ...

Then you still need to find a way to integrate 3rd-party lib and our validation rules. Such a task is not trivial at all. And your argument essentially is that everyone should do this by himself and it is more productive. Again, you are fully free to develop such an integration as an extension. If it is proven to be better than the core solution, people will love it more for sure.

This is not true in case of Symfony and Zend builders. It used inside controllers...

Do you really think it's a good practice to build forms (such as specifying button labels) inside controllers? I know ActiveForm is not close to the so-called classical form builder (yii 1 has such one). If you like form builder so much, why not creating such an extension? Wouldn't this prove your earlier argument that we should encourage reinventing wheels sometimes?

Let's end this debate as it is not very productive. If you find a better solution than the core one, feel free to show it in a concrete form or even release it as an extension. If it is well adopted, we are open to replace the core solution with it.
Having an idea is not very difficult, but caring for the details often takes a lot of efforts.

@qiangxue

If you find a better solution than the core one, feel free to show it in a concrete form or even release it as an extension.

Will try to make extension for http://jqueryvalidation.org/ . These thoughts I have for a long time.
P.S. Thanks for conversation! )


return pretender handler

This will enable you to do:
  this.post('token-auth', () => ({ 'jwt': 'xxx' }))._name = 'post:token-auth';

export function errorOnAuth() {
  let original = server.pretender.handlers.find(h => h._name === 'post:token-auth');
  server.post('token-auth', { errors: [{ detail: 'There was an error' }] }, 500);
  return function reset() {
    server.pretender['post'](server._getFullPath('token-auth'), original);
  };
}

unless there is already a way to do this?

no this is great! Would love to add more sugar over this pattern in the future too 👍  Something like server.once.get

@denzo check it out:
test('it can recover from an error', async function(assert) {
  // For a server error
  let originalHandler = server.pretender.handlers.find(h => h._name === 'post:users');
  server.post('/users', { errors: [ 'Uh-oh, there was an error' ] }, 500);

  await visit('/');
  await click('[data-test-id="add-user"');
  await fillIn('[data-test-id="name"]', 'Sam');
  await click('[data-test-id="save"');

  assert.dom('[data-test-id="message"]').hasText('There was a problem');

  // Restore the handler
  server.post('/users', originalHandler);

  await click('[data-test-id="save"');

  assert.dom('[data-test-id="message"]').hasText('Success! User created!');
});

for some reason I can't access any originalHandler on my side @samselikoff : h._name is undefined, I see a h.name which always returns "". Any idea which way to go from there? USing ember-cli-mirage 4.14, pretender 2.1.1

Any test of this functionality available?

@Leooo You have to set _name yourself, like in my first example.

thanks @kellyselden


Merchant implementation, bug fixes

Implement the merchant capability to sell items in your inventory.
Ensure player is within 5 km of a resource to be able to mine / sell at it.

Well, now this PR contains fixes to navigation. Which will fall under bug fixes


Added list envs function (pretty print envs)

Description
Added a function that lists all the current environments supported/present, neatly.
Resolves #75
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Screenshots
Please attach before and after screenshots of the change if applicable.

Before
After

Checklist:

[x] I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Thanks for the PR, could you add a test, just that this function works. Maybe add a couple of testing environments with different namespaces, etc and check the output is equal to an expected values.
Could you change the registry to add registry in __init__.py such that
# old code
registry: dict[str, EnvSpec] = {}

# new code
registry.pprint = list_env_spec
registry.__str__ = partial(list_env_spec, 10)

My hope is being able to call print(gymnasium.registry) to get the pretty print versions
Then you can call print(gymnasium.registry.pprint(10)) for selecting the pretty print options


Convert documentation to Markdown

Currently (v1.2.0) most of the project documentation is written using reStructuredText:

https://github.com/bcbio/bcbio-nextgen/tree/v1.2.0/docs (published on Read theDocs)
https://github.com/bcbio/bcbio-nextgen/blob/v1.2.0/README.rst (published on PyPI)
Documentation already written in Markdown:

https://github.com/bcbio/bcbio-nextgen/blob/v1.2.0/CODE_OF_CONDUCT.md
https://github.com/bcbio/bcbio-nextgen/blob/v1.2.0/HISTORY.md

Motivation:

Markdown has a simpler syntax and is easier to edit than reStructuredText
Markdown is supported by Read the Docs (CommonMark) and PyPI (GitHub Flavored Markdown by default, or CommonMark)

Challenges:

There are many different flavors of Markdown but there is CommonMark Spec
toctree directive and :ref: markup are not supported but it looks like there are workarounds available: https://recommonmark.readthedocs.io/en/latest/auto_structify.html

Reference:

https://commonmark.org/
https://blog.readthedocs.com/adding-markdown-support/
https://packaging.python.org/guides/making-a-pypi-friendly-readme/
https://docs.readthedocs.io/en/stable/intro/getting-started-with-sphinx.html#using-markdown-with-sphinx
https://stackoverflow.com/questions/2471804/using-sphinx-with-markdown-instead-of-rst
https://www.ericholscher.com/blog/2016/mar/15/dont-use-markdown-for-technical-docs/
https://www.zverovich.net/2016/06/16/rst-vs-markdown.html

Great, if there are no objections, @hackdna please convert to Markdown!
I'd also propose later to reorganize docs in the 'user story' format, i.e. a page about germline variant calling:

quick start
all parameters described
latest validation
output
steps in detail
links to the key past discussions on github
performance and resource estimates

currently we have the following user stories:

installation and update story
small variants germline
SV/CNV for WGS
somatic variant calling
methylation
smallRNA
bulk RNA-seq
scRNAseq
chip-seq/ataq seq
developer story

Each story is rather split between different pages now.
SN

Thank you so much everyone, I love this.

Great, thanks. I agree that the docs could be organized better but I will focus on the conversion first to keep the scope of the changes constrained. I will open a separate issue for the re-org.
Btw, is TODO.md still needed? It has not been touched in over four years: https://github.com/bcbio/bcbio-nextgen/blob/master/TODO.md

TODO is definitely not needed, feel free to nuke. Thank you!


Convert Utc to signed integer

Fix for issue #30, as discussed in Zulip here

Yeah, I can definitely do that!

@bhansconnect How are we looking here? Anything else need tweaking?


Add Zend\Validator\Uuid

The Zend\Validator\Uuid was introduced in zend-validator 2.8.0, but not yet added.

Thanks, @adriaangraas


Task - Even though there is a Display Name, when assigning a task, only email shows

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.59
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS><EMAIL_ADDRESS>Issue reported by: Applause - Internal team
Action Performed:
Pre-condition: 2 account with Display Name set done.

Open the app
Go to any chat
Tap on "+" and tap on Assign Task
Find the account second by email

Expected Result:
If the account was set to display name, it should shows Display Name
Actual Result:
Even though there is a Display Name when assigning a task, only email shows
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/fafac269-a748-4a11-bc2f-2cbdbfa7bf2e
View all open jobs on GitHub

Duplicate of https://github.com/Expensify/App/issues/39426
and this the new expected behavior prioritize login over display name for all the mentions in the app including task preview https://github.com/Expensify/App/issues/39426#issuecomment-2032929258

Closing out!


Add new pseudo log level CONSOLE that logs to console and to log file

It would be useful to allow set log level to "Console" for keyword,
Currently To print list of dictionary you have to do it your self using Log To Console
Keywords in mind

Log Dictionary
Log List

Do you mean that if you'd log something with a level CONSOLE, it would be logged to the console? For example:
Log    message    level=CONSOLE

That sounds fine to me. The Log keyword actually has also_console=False option so this wouldn't be too useful with it, but other keywords accepting an optional log level would benefit. Possibly also_console could then later be deprecated.
I guess it would make sense to log the message to the log file using INFO level as well. In practice CONSOLE would then be a new pseudo level like HTML that logs the message as INFO so that the message is rendered as HTML. We could consider making it possible to change the level of the message written to log with something like CONSOLE:WARN and HTML:DEBUG, but that would require its own issue.

Yes, exactly.  "level=CONSOLE", its provided information about intend where information will be printed.
In long run it would be better to add  parameter "output" where options there would be example "console | html |file | etc." and log level keep only for information about "log level"

New options can be added to keywords if needed. What I like about adding CONSOLE pseudo log level is that it doesn't need them, all keywords that support customizing the log level benefit from it automatically. Supporting level with CONSOLE, and HTML, wouldn't be hard but should get its own issue. We could also support HTML:CONSOLE:DEBUG if needed.
This would be a safe enhancement to do already in RF 6.1. It's also pretty easy so good candidate for someone wanting to contribute.

I do not really get it.
Scenario:
So you run robot --loglevel INFO
then you have the following test
*** Task ***
Task
   Log    Hello    level=CONSOLE    #what should happen here???
   Log    World    level=DEBUG    #It is logged as DEBUG
   Log     Failure    level=ERROR    #It is logged as Error

So would be Log    Hello    level=CONSOLE the same as Log To Console   Hello ?
But how would you prevent that logging?
Log    World    level=DEBUG is not logged, when you run robot --loglevel INFO
For me that sounds inconsistent and would be better to implement as library keyword in an own lib.

I see it as level above INFO since print more then info itself.

So would be Log    Hello    level=CONSOLE the same as Log To Console   Hello ?

Yes, but this change is mostly in mind of other keywords Log List and Log Dictionary
And for preventing that log its for me weird question, since when you set to log level to console you expect to log to console, the same as you would as Log To Console question how to stop from printing to console.
The author decide expected behavior

Yeah, this feature isn't useful at all with the Log keyword, it already has a separate console argument, but it's convenient with other keywords that accept log level as an argument. This is basically same as adding a console argument to all of them. This is also really easy to implement.

I think that level as CONSOLE doesn't make sense semantically for me.
INFO, DEBUG, ERROR do make sense as level. CONSOLE is not a level, so, trying to reuse that argument is really weird for me.
Having a console=True in Log List does makes more sense IMHO. Users can always create their own keywords to do set console=True if they want.

This is basically same as adding a console argument to all of them. This is also really easy to implement.

This means that what you plan to implement is adding the console parameter to each of those?

For me any solution that allow to print to console list of dictionary is ok for me

This was implemented by @turunenm in PR #4673. Thanks for contribution!

There was a comment above stating that it would be better to add optional console argument to Log List and other such keywords. That could have been done with a single keyword, but a new pseudo log level adds this capability to all keywords accepting log levels without making any other changes. We already had similar HTML pseudo level earlier so there's precedence.
Another benefit of this new pseudo level is that in simple libraries you can write to console using print('*CONSOLE* Message') instead of print('Message', file=sys.__stdout__).


Huggingface Demo Error

Hello, it seems that there is a problem with the Huggingface Demo you provided and it cannot run properly.

I'm not sure where in the notebook you get this error, but I did notice than on the demo notebook, the url for downloading the model is not valid anymore. Use https://huggingface.co/GLIPModel/GLIP/tree/main for the weights.

I met with the same demo error problem. Did someone deal with that?


DEV: Submit PR to support #607 Traeffic changes to pnp-deploy

[ ] Open a PR for traeffic fixes in #607 to https://github.com/retaildevcrews/caf-terraform-landingzones-starter

The 02-aks.md file seems to be working with default hard-coded values. Although we feel that, if someone decides to change names and values, it should be generic enough to support custom names and label values. Will talk to AK to make sure, the 02-aks.md readme file has some option to change names/labels


Fixes some minor issues with the connect with lines analysis

This PR:

Closes #9593 with this (Target column in the connect with lines analysis doesn't stop loading fields)
Closes #9590 with this (Connect with lines "sequential" analysis shows the order input checked by default )
Closes #9600 with this (Doesn't return the target_column_value)
Closes #9602 with this and this (avoid sending disabled params for the line-source-to-target and line-sequential analysis)

It also fixes an issue where the target combo was showing polygons and not just points (with this)

CR: @alonsogarciapablo a bunch of small fixes 🙏

CR: @nobuti  bunch of small fixes 🙏

LGTM!


feature/refactor-checks

This diff makes the Check API cleaner by moving out the
error handling into the schema doing the data validation
instead of within the __call__ subroutine.
This also standardizes the Check.__call__ signature such that
it takes the dataframe or series object to be checked.
This also cleans up the SeriesSchemaBase API and its subclasses,
where the __call__ method takes a single argument df_or_series,
which is the object to be checked.

Codecov Report

Merging #153 into master will increase coverage by 0.29%.
The diff coverage is 98.66%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   96.06%   96.36%   +0.29%
==========================================
  Files           8        9       +1
  Lines         458      468      +10
==========================================
+ Hits          440      451      +11
+ Misses         18       17       -1

Impacted Files
Coverage Δ

pandera/error_formatters.py
100% <100%> (ø)

pandera/schema_components.py
94.33% <100%> (ø)
:arrow_up:

pandera/hypotheses.py
88.23% <100%> (ø)
:arrow_up:

pandera/schemas.py
100% <100%> (ø)
:arrow_up:

pandera/checks.py
95.89% <95.65%> (-0.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62fac4...f929419. Read the comment docs.


MINOR: Refactor partition lag metric for cleaner encapsulation

cc @becketqin Seemed a little unfortunate for SubscriptionState to need knowledge of partition lag metrics, so I took a shot at refactoring. Let me know if it seems reasonable.

@hachikuji Thanks for the patch. I took a quick look and the Listener approach looks reasonable to me. I am currently traveling in China so my response might be delayed a little. I'll make a full pass tomorrow.

Thanks @becketqin. No hurry.

@hachikuji, I noticed that the KIP for the per partition metrics added tests to BaseConsumerTest. I think they don't need to run with all security protocols, so I suggest we move them to PlaintextConsumerTest. Maybe we can do that in this PR? Sorry, I missed that in my original review.

@ijuma Thanks for the review. I've moved the tests into PlaintextConsumerTest.

Made a pass over the patch and cannot find a single line for comments :P LGTM!!

Merged to trunk and 0.10.2 branches.


Refactored firewall REST api.  Allow POST for firewall enable/disable.

This patch solves the first half of issue [https://github.com/floodlight/floodlight/issues/488]
The existing REST API for enabling and disabling the firewall relies on GET requests.
Best practices dictate that GET requests should not change the state of the system.
This patch disables the GET semantics and replaces it with a PUT based endpoint to enable/disable the firewall.
Also refactored the FirewallResource class into multiple smaller classes to make URL routing clearer.

Updated pull request to disable GET requests and use PUT instead of POST

@electricjay Still working on reviewing this. Will merge in the near future. Sorry for the delay, but I've been distracted by another project the last few weeks.

@electricjay Looks great to me. Thanks for the contribution!


Expose Project API as a service

I'm working on a demo/POC to provide autocompletion for typed webcomponents (Polymer/Typescript). To realize this I transform polymer elements (html) to a typescript class so I will have a view class that can be used to typecheck and for autocompletion etc. TypeScript class will map to html element tags and attributes/values.
The autocompletion is implemented as a provider for the autocomplete-plus package and will consume the Symbols from the atom-typescript Project API. The navigateTo API's are not complete enough to provide the information as I need the parent-child relationships between symbols (class-properties-methods) to provide autocompletion for element attributes etc.
What would be the proper way to implement this? (I now added a method getNamedDeclarations(...) to the project API) and will this be provided in the future?
Another approach would be to use the language service directly, but this isn't exposed from the atom-typescript package also is it? (or is there another way to achieve this besided the Atom provider/consumer pattern, like https://discuss.atom.io/t/depending-on-other-packages/2360.

Some context:
Nothing is exposed from the atom-typescript package. Although it can be. I am familiar with the services API.
We run the languageService in a background process : https://github.com/TypeStrong/atom-typescript/blob/master/CONTRIBUTING.md#architecture so that the UI doesn't become sluggish.

will consume the Symbols from the atom-typescript Project API.

Exposible.

I now added a method getNamedDeclarations(...) to the project API) and will this be provided in the future

I am pretty much in the same boat as you. Try and test till it works :+1:. If in doubt ask Microsoft/TypeScript :rose:

And are there any plans to expose the languageService to other packages? What I need are the named declarations from the program, so I need the languageService or at least the sourceFiles of the program. Is there a way to get these without extending the ProjectService?
Thanks.

And are there any plans to expose the languageService to other packages?

That is doable. I will give you our API endpoint "GetOrCreateProject"

Thanks for the info. Still not clear to me how I will get to the "program" that provides the getNamedDeclarations?

@basarat: any updates on this issue or maybe a hint how to implement this at this moment? As mentioned I don't completely understand by your previous comment and how to get to the language service from the parent module from another Atom package. I think the projectService and parent service would need a getProject():Project method or something like that to realize this (I now have this working with this solution) or do I completely misunderstand the topic?
Thanks in advance.

any updates on this issue

sorry none yet.

maybe a hint how to implement this at this moment

Expose this parent variable : https://github.com/TypeStrong/atom-typescript/blob/master/lib/main/atomts.ts#L47 as a provided service. I will work on this once done with other quite big tooling gaps in TypeScript land

@basarat : I understand what to do, but the parent doesn't expose a method or property with what I can access the project and from there the languageService can I? I solved my problem now by requiring the projectCache and invoke the getOrCreateProject that returns the project I need.
Maybe this method should also be exposed in the projectService and parent or am I wrong?
Thanks!

Extremely sorry for the late reply.

but the parent doesn't expose a method or property with what I can access the project and from there the languageService can I

Yes it doesn't expose the LS. The parent functions synchronously in the UI process talking to projectService via JSON (see design https://github.com/TypeStrong/atom-typescript/blob/master/CONTRIBUTING.md#architecture).

I solved my problem now by requiring the projectCache and invoke the getOrCreateProject that returns the project I need.

That is okay ... but be warned that we now effectively have two project caches .... one running in the UI process (because that is where you are calling it from) and one running in the background (that we interact with using parent).
We keep the background one in sync with changes in the editor. The one you've created in the UI process is effectively a file system snapshot and changes in an unsaved editor instance are not pushed to it.


docs(i18n-id): translate emitBOM.md, emitDeclarationOnly.md and several config into Indonesia

Overview
this is part of #938
Changes
Translate the following files

[x] emitBOM.md
[x] emitDeclarationOnly.md

LGTM 🤸


[Telegram -> NCTalk] Forwarding from channels

Describe the bug

When forwarding to tg chat from another chanell we see "Forwarded from unknown:"
When we forward a post that starts with a pic we will not see the body

To Reproduce

Connect th chat to nactalk
Forward a message from another channel

Expected behavior
I think forwarded post should contain pic instead a pic if images arent enabled an all body of post
Screenshots/debug logs

Environment (please complete the following information):

OS: centos8
Matterbridge version: last stable

@gary-kim something you could take a look at?

Is this Talk specific? It might be how Telegram forwards with images look.
I'll take a look when I have a moment.

Guys please check this bug its still actual

Hi there,
another trouble with the channels is that if the Telegram group is linked to a channel and the channel sends the message, the bot receives
User:"", Text:"Forwarded from [channel_name]: [message from the channel]


Do you ever look at your issues?

Do you ever look at your issues?

Obviously, the answer is no.  I do have to wonder why you would openly post something that is incomplete.


[WIP] #129: See course dates

forced merge due to business requirements. Shouldn't break anything though.


Updated to version 0.16.6

Thanks for being on top of this Fank. Gotta love it when the Factorio devs are on their "patch a day" schedule...


Ongoing unit test improvements

Most of these are left over from 233, which is ready to be closed.

[ ] Note in contributing docs that a good first PR is to make sure unit tests pass on your system. Then upgrade all packages in the sample project, and update all reference files to match these versions. The only changed files in the PR should be requirements.txt in the sample project, and reference files corresponding to these in the unit_tests dir. Note how to update vendor/.
[ ] Consider defining some paths initially, to be available everywhere: sd_proj_dir, unit_test_dir, and tmp_proj_dir
[ ] Try running unit tests in a Windows VM.
[ ] Refactor manage_test_project.py into helper module.
[ ] Continue to look for ways to make unit tests run faster, particularly in the first ~10s when it's setting up the sample project for the first time.

@darjeeling the unit tests are now entirely written in Python. If you have a chance, will you see if they run on your system? I have one system that uses just the macOS Python installer from python.org, and one that uses pyenv. The tests run on both of these systems. I'm curious if you will see any issues. I haven't tried it on Windows yet.

Speeding up tests

From a bit of diagnostic work, I can see pytest is spending no meaningful time finding tests, even if it is looking in more directories than it needs to. It shows "collected items" very quickly, and begins setting up for the first test. Most optimization efforts should probably focus on how we work with the sample project.

I tested with 1b75ca4c14906461a6cc2f92a1231422dbe064c4
I looks fine.
(djangosimpledeploy) ➜  unit_tests git:(main) ✗ pytest
============================================= test session starts ==============================================
platform darwin -- Python 3.11.3, pytest-7.0.1, pluggy-1.0.0
rootdir: /Users/dj/github/darjeeling/django-simple-deploy
collected 93 items

platform_agnostic_tests/test_invalid_cli_commands.py .........                                           [  9%]
platform_agnostic_tests/test_project_inspection.py sss                                                   [ 12%]
platform_agnostic_tests/test_valid_cli_commands.py ...                                                   [ 16%]
platforms/fly_io/test_flyio_config.py ...........................                                        [ 45%]
platforms/heroku/test_heroku_config.py ...........................                                       [ 74%]
platforms/platform_sh/test_platformsh_config.py ........................                                 [100%]

======================================== 90 passed, 3 skipped in 19.12s ========================================

Thanks, that's helpful to know!


DelayedJob integration should not call as_json on the payload object.

The DelayedJob integration loads the payload object and tries to serialise it using as_json. If Delayed job has been used to delay a class method on an ActiveRecord subclass, this can have very unpredictable results, as one of the objects that will have as_json called on it is the class itself.
ActiveSupport adds Object#as_json which iterates over all instance variables and calls as_json - unless classes implement their own as_json method it will recursively serialise all the instance variables of the class  and the class instance variables of an active record subclass contains all sorts of stuff.
It can very easily lead to infinite recursion - in my case this happened via the use of aasm gem: it creates a class instance variable containing a state machine definition object, which itself has as an instance variable the class it was defined on.
Another bad thing is that active record objects appear to have a relation object containing the base scope for the model. Calling as_json on this will attempt to dump the entire table to json

@fcheung have you tried using Oj as JSON serializer? It's the gem we suggest to use.
We've had historiclal problems with to_json and as_json and we didn't find a solution to work on every project. Can you give us more details about the libraries you have installed?
Thanks.

I can reproduce the issue with this snippet (running against rails <IP_ADDRESS>)
require 'active_record'
ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: 'test.sqlite3')
ActiveRecord::Schema.define(version: 1) do
  create_table  :users do
  end
end

class User < ActiveRecord::Base
end

User.create!
User.as_json

This produces a SystemStackError whether Oj is loaded or not. Since the call to as_json happens inside the rollbar provided delayed job integration, it's not something that I can avoid (other than by monkey patching the gem)

This snippet shows what happens when roller is involved:
require 'active_record'
require 'delayed_job'
require 'delayed_job_active_record'
require 'oj'
require 'rollbar'

Rollbar.configure do |config|
  # Without configuration, Rollbar is enabled in all environments.
  # To disable in specific environments, set config.enabled=false.

  config.access_token = ENV['TOKEN']
end

ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: 'test.sqlite3')

ActiveRecord::Schema.define(version: 1) do
  create_table  :users do
  end
  create_table :delayed_jobs, force: true do |table|
    table.integer :priority, default: 0, null: false # Allows some jobs to jump to the front of the queue
    table.integer :attempts, default: 0, null: false # Provides for retries, but still fail eventually.
    table.text :handler,                 null: false # YAML-encoded string of the object that will do work
    table.text :last_error                           # reason for last failure (See Note below)
    table.datetime :run_at                           # When to run. Could be Time.zone.now for immediately, or sometime in the future.
    table.datetime :locked_at                        # Set when a client is working on this object
    table.datetime :failed_at                        # Set when all retries have failed (actually, by default, the record is deleted instead)
    table.string :locked_by                          # Who is working on this object (if locked)
    table.string :queue                              # The name of the queue this job is in
    table.timestamps null: true
  end
end

class User < ActiveRecord::Base
  def self.foo
    raise 'error'
  end
end

User.create!
User.delay.foo
Delayed::Job.last.invoke_job

The call to invoke_job raises SystemStackError, because of the call by rolbar to User.as_json

@fcheung thank you very much for the analysis. We'll try to reproduce the problem and fix it.

@fcheung can you for now use this config options? config.report_dj_data = false.
We'll work on fix this soon. Thanks.

I've just monkey patched rollbar for now - the remainder of the data is still good to have

@fcheung nice, can you share what you coded for that? You just remove the data you don't want?

It's a bodge - i just commented out https://github.com/rollbar/rollbar-gem/blob/master/lib/rollbar/delayed_job.rb#L20
job is an active record object (at least with the backend i use) so has a sane as_json method. handler ends up being a blob of yaml rather than a nice payload object but it's still pretty readable in general - for us it's never much more than a class name, method name & arguments (we tend to keep arguments to delayed jobs as just plain scalars/arrays/hashes rather than complex types)

module Rollbar
module Delayed
class JobData
def to_hash
job_data = job.as_json
job_data
end
end
end
end

I see, I think I was using that solution but I found some problems in some scenarios.
I'll check it, thanks! :smile:

Just recently ran into this issue myself and am getting Stack Level too deep errors in my delayed_job workers when using Rollbar in them. The OJ gem does not seem to help.

@trostli we'll need to review this. The bug is in ActiveSupport since it monkey patches Object. We need to find a correct way to send this data. We hope we can fix this soon.
Sorry for the inconveniences.


Better errors for bower

If there is no bower present, the error should be more comprehensive

Are you talking about that kind of errors ?
error: { [Error: Component must have "/Users/Loschcode/Google Drive/projects/erasmusio_lo/app_front/bower_components/underscore/bower.json"] code: 'NO_BOWER_JSON' }

yes

Before to think about how I can code that by myself, what's the best way to solve the error ?
Ofter i just delete the "plugin" in the bower_components folder and I run bower install in the root folder, is it the best way to fix that ?

just catch this error https://github.com/paulmillr/read-components/blob/master/index.js#L70 or throw sth more meaningful that says user should run bower install etc


Support for outputting to System.register format.

Feature request
It would be great to be able to change webpack's output.libraryTarget to system so that it is compiled to System.register format. See related #2810 from a couple years ago.
What is the expected behavior?
// webpack.config.js
module.exports = {
  entry: 'entry.js',
  output: {
    libraryTarget: 'system',
  },
}

// entry.js
console.log('hi')

// output bundle
System.register([], function(_export, _context) {
  return {
    setters: [],
    execute: function() {
      console.log('hi')
    }
  }
})

What is motivation or use case for adding/changing the behavior?
For projects that use SystemJS as their in-browser module loader, it's desireable to be able to System.import('/path-to-webpack-bundle.js') as a way to dynamically load bundles. Currently, this can only be done by changing webpack's libraryTarget to amd and then using the amd extra for SystemJS.
How should this be implemented in your opinion?
From the user's perspective, this should be implemented via output.libraryTarget. Places I would start with the webpack implementation: LibraryTemplatePlugin and ExternalsPlugin.
The most ambiguous part of the implementation is how to do code splits. For that, I welcome thoughts/advice/feedback. I think a good place to start would be rollup's implementation of code splitting with system format. Meaning that a dynamic import() would turn into a _context.import().
Are you willing to work on this yourself?
Yep I'm happy to work on this. Plan on digging into this tonight a bit to get my feet wet. It was previously expressed in #2810 that this would be a good feature to have, but if anyone disagrees please let me know before I get too far in my implementation :)

cc @guybedford who'll have some thoughts on this and who I'll likely need some help from

Note setters can be skipped in the wrapper when there are no dependencies so just:
System.register([], function(_export) {
  return {
    execute: function() {
      console.log('hi')
      _export({ named: 'exports', here });
    }
  };
});

should be fine for the wrapper.

Thoughts on the question with dynamic import? Should webpack do webpackJsonp stuff for system.register libraries? Or should it do module.import()?
I think this could be the hardest part of the implementation and maybe the most controversial aspect of the feature.

I believe, unless this has chnaged, that Webpack explicitly has as a design goal not to support unknown dynamic imports in the runtime environment, so that this can be omitted in the output.

So maybe sticking to just the entry module being a System.register format, with subsequent code splits being webpack format and use webpackJsonp?
I still find value in the feature like that ^. Usually I care about getting the overall bundle into SystemJS but don't usually have a strong preference about whether it's SystemJS or webpack who implements the code splitting beyond that

So maybe sticking to just the entry module being a System.register format, with subsequent code splits being webpack format and use webpackJsonp?

Exactly!

Only entry module in System.register format -> output.libraryTarget: "system" (pretty easy)
Code Splitting with System.register and module.import -> target: "system" (more involved)

@sokra thanks for the feedback here - could you perhaps suggest what the basic architecture of the approach might be for output.libraryTarget: "system" for anyone wanting to attempt an implementation here?

Best see AmdMainTemplatePlugin (copy this and change it).
The option values are referenced in LibraryTemplatePlugin, where the need plugin need to be added.
For support of dependencies, system also need to be added in ExternalModule

Is there any further discussion on this? Or should we open another issue for that?

Code Splitting with System.register and module.import -> target: "system" (more involved)


Bug: All functions here are marked as private

As the title says.

I'm not sure how visibility is a concern if you have to copy the function to your own code anyway.


Rails 5.1 alias_method_chain undefined.

On a fresh test project I tried to do:
rails generate devise:install
and I was not able to do it because seems like there is no alias_method_chain in rails 5.1
I manually changed it to alias_method as suggested but more issues appear if you do that.
Oh, also I'm using Ruby 2.4.1.
Stack of the error:
home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:94:in `rescue in block (2 levels) in require': There was an error while trying to load the gem 'devise'.
Gem Load Error is: undefined method `alias_method_chain' for ActionDispatch::Routing::RouteSet:Class
Did you mean?  alias_method
Backtrace for gem load error is:
/home/lockon/.rvm/gems/ruby-2.4.1/gems/devise-1.5.4/lib/devise/rails/routes.rb:15:in `<class:RouteSet>'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/devise-1.5.4/lib/devise/rails/routes.rb:2:in `<module:Routing>'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/devise-1.5.4/lib/devise/rails/routes.rb:1:in `<top (required)>'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/activesupport-5.1.0/lib/active_support/dependencies.rb:292:in `require'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/activesupport-5.1.0/lib/active_support/dependencies.rb:292:in `block in require'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/activesupport-5.1.0/lib/active_support/dependencies.rb:258:in `load_dependency'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/activesupport-5.1.0/lib/active_support/dependencies.rb:292:in `require'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/devise-1.5.4/lib/devise/rails.rb:1:in `<top (required)>'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/activesupport-5.1.0/lib/active_support/dependencies.rb:292:in `require'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/activesupport-5.1.0/lib/active_support/dependencies.rb:292:in `block in require'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/activesupport-5.1.0/lib/active_support/dependencies.rb:258:in `load_dependency'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/activesupport-5.1.0/lib/active_support/dependencies.rb:292:in `require'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/devise-1.5.4/lib/devise.rb:445:in `<top (required)>'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:91:in `require'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:91:in `block (2 levels) in require'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:86:in `each'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:86:in `block in require'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:75:in `each'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:75:in `require'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler.rb:107:in `require'
/home/lockon/workspace/company_solution/config/application.rb:7:in `<top (required)>'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:82:in `require'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:82:in `preload'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:143:in `serve'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:131:in `block in run'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:125:in `loop'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:125:in `run'
/home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application/boot.rb:19:in `<top (required)>'
/home/lockon/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
/home/lockon/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
-e:1:in `<main>'
Bundler Error Backtrace:
 (Bundler::GemRequireError)
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:90:in `block (2 levels) in require'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:86:in `each'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:86:in `block in require'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:75:in `each'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler/runtime.rb:75:in `require'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/bundler-1.14.6/lib/bundler.rb:107:in `require'
	from /home/lockon/workspace/company_solution/config/application.rb:7:in `<top (required)>'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:82:in `require'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:82:in `preload'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:143:in `serve'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:131:in `block in run'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:125:in `loop'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application.rb:125:in `run'
	from /home/lockon/.rvm/gems/ruby-2.4.1/gems/spring-2.0.1/lib/spring/application/boot.rb:19:in `<top (required)>'
	from /home/lockon/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from /home/lockon/.rvm/rubies/ruby-2.4.1/lib/ruby/2.4.0/rubygems/core_ext/kernel_require.rb:55:in `require'
	from -e:1:in `<main>'

Thank you for the report. Can you try the master branch?

I had the same error in Rails 5.1. It's resolves when pointing my Gemfile to master :D

I will try that, thanks for the quick response!

how do you point gemfile to master?


IE11 - Object doesn't support property or method 'assign'

Just tried to upgrade from 1.1.3 to 2.0.1 but get the following error in IE 11.

Hi,
Thank for the catch.
I'll fix it tomorrow.

@john-griffin done in 2.0.2
Thanks again 😄

@Hiswe thanks for quick fix!


Initial checking adding streaming bench functionality (pull subscribe…

…r not working yet)
example uses:
nats bench test --streaming --pub=10 --sub=10 --msgs 100000

or test just publishing to the stream
nats bench test --streaming --nopurge --nodelete --pub=1 --sub=0 --msgs 100000

and then test just getting the data replayed from the stream
nats bench test --streaming --nopurge --nodelete --pub=0 --ack --sub=1 --msgs 100000

(which you can run many times in a row, changing the number of subs for example or with/without ack)

Possible to squash down for easier review?

Awaiting this script, what's the eta for it to release?, Thanks

Overall looks ok, just nitpicks.  Should also fix the PR description.  The log messages start with a mix of lowercase and uppercase, should standardize - it looks like the rest of the messages start with lowercase.


New theme envy and rbenv integration/plugin

envy theme with rbenv prompt and rbenv plugin for completions.

up


Fix tar error in build workflow

Description
This PR aims to fix a tar error that is visible when running the package build workflow
Issues Resolved
#167
Check List

[ ] All tests pass

[ ] yarn test:jest
[ ] yarn test:jest_integration

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[ ] Update CHANGELOG.md
[ ] Commits are signed per the DCO using --signoff

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.87%. Comparing base (f066302) to head (36f557d).
Report is 2 commits behind head on 4.9.0.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##            4.9.0     #168       +/-   ##
===========================================
- Coverage   66.96%   43.87%   -23.10%
===========================================
  Files        3300     1570     -1730
  Lines       63585    31644    -31941
  Branches    10141     6002     -4139
===========================================
- Hits        42582    13884    -28698
+ Misses      18538    16721     -1817
+ Partials     2465     1039     -1426

Flag
Coverage Δ

Linux_1
?

Linux_2
?

Linux_3
?

Windows_1
?

Windows_2
?

Windows_3
43.87% <ø> (ø)

Windows_4
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


docs: update readme

Resolved issue: https://github.com/akebu6/Kotlin-Content/commit/6d29bbbc6bdd5ffada5cef0c2984a41bd33191bb


Fix notebooks

Fix developing on Windows
Fix errors from notebook document

To reproduce:
Make a notebook with three code cells
Save it as a file
Use "Reopen Editor With Text Editor" and edit in the text editor

LGTM.
Does this fix #89?

@usernamehw  Sorry, I meant to remove the extension.ts change before merge!!