Cost optimisation by estimating WCU required

Is your feature request related to a problem? Please describe.
Calculating WCU to provision on the target table for the process can be a difficult feat, and is a much needed cost optimisation. Similarly, when only a historical migration is required, the process should be able to detect no more data and gracefully stop.
Describe the solution you'd like
A clear and concise description of what you want to happen.
When doing our calculations, we have spotted that each worker is capable of pushing x WCUs - though from the formula attached on the AWS Docs that row size is a factor when calculating the closer estimate.
It would be nice if the jobs could calculate how many workers will be used in the job (presumably this is easy to display once discovery job completes) and the WCU needed to complete this job in x time (i.e. to complete this job in an hour - WCU needs to be x based on the number of workers and row size). This would provide for better runtime and cost calculations when parameterising the jobs.
Describe alternatives you've considered
The more information the better with running these jobs, since there is a lot going on and a lot of numbers to keep track of - even displaying the amount of workers & DPUs used in the run will be a slight improvement to cost tracking.
At the moment, to optimise costs you need to be reactive rather than proactive by looking at the current throughput produced.

https://github.com/aws-samples/cql-replicator/blob/main/glue/resources/CQLReplicator-calculator.xlsx


config: remove docs.docker.com as site URL

extracting this from https://github.com/docker/docker.github.io/pull/10471
Having this variable set causes redirects to always redirect to https://docs.docker.com, which makes it not possible to preview redirects locally, or to host them on a different domain (e.g. on a staging domain).

@StefanScherer @usha-mandya PTAL; please double-check if this has no side-effects. I couldn't find any, but perhaps may have missed some

Can't think of any issues arising due to this change. @StefanScherer Any thoughts?

Looking forward to test this in docs-test website.
Currently if I want to open this old doc https://docs-test.docker.com/v17.03/engine/admin/volumes/ it 301 forwards to https://docs-test.docker.com/engine/admin/volumes/ and then links to https://docs.docker.com/storage/ leaving the docs-test.docker.com website.
Maybe this is fixed after merging this PR?

Yes, the non existing page https://docs-test.docker.com/v17.03/engine/admin/volumes/ is now redirected to https://docs-test.docker.com/storage/ 🎉

Thanks Stefan!


Added a classname for the appInsights HOC's div

See here for the discussion

I'm using React Native Web in my project. I have also the issue with full height. Adding a class name though is not practical for me. Would it instead be possible to have an option to specify the component to pass in? Eg:
component={View}
This is how react-intl and react-transition-group do.

@hectorhdzg Is it good for you like that ?

@flip-it we will add both options in next release, allowing className and component to be provided as well

Hey @florianchevallier , thanks for your work on react SDK for app insights. I have one question though, what's the need of empty div wrapper around the user component? I mean if for some reason behind the scenes your are putting your custom components in render why just not to use Fragment?

Hey @florianchevallier , thanks for your work on react SDK for app insights. I have one question though, what's the need of empty div wrapper around the user component? I mean if for some reason behind the scenes your are putting your custom components in render why just not to use Fragment?

Hi ! In my case, on my app, I had a full height CSS app and without this solution, it broke all the design. The problem here was this div which couldn't be customized and therefore, couldn't add a height: 100% on it


docs: DaisyUI V5 themes color extraction

On which page do you see this issue?
https://v5.daisyui.com/docs/themes/
Describe the issue
I am using DaisyUI v4 with the daisyui/src/theming/themes.js code to extract color:
<script lang="ts">
	import Icon from "@iconify/svelte";
	import { colorManager, s } from "$lib/utilities/Store.svelte";
	import themes from "daisyui/src/theming/themes.js";
	import Chart from "chart.js/auto";

	let theme = $derived(s.isDarkMode ? "dim" : "nord");
	Chart.defaults.color = themes[s.isDarkMode ? "dim" : "nord"]["base-content"];
	Chart.defaults.borderColor = themes[s.isDarkMode ? "dim" : "nord"]["primary"];
	Chart.defaults.backgroundColor =
		themes[s.isDarkMode ? "dim" : "nord"]["base-100"];

	$effect(() => {
		window.document.documentElement.setAttribute("data-theme", theme);
	});
</script>

Now I am trying out DaisyUI v5. After upgrade all related packages, I started to realize that the daisyui/src/theming/themes.js file is removed with TailwindCSS v4 plugins. So now there is no such convenient utility for us to use. Is there a replacement method and can this method be documented in documentation here "https://v5.daisyui.com/docs/themes/"?
What browsers are you seeing the problem on?
All browsers

Yes.  There's /theme/object.js
<EMAIL_ADDRESS>Also you can use JS object of a specific theme individually:
<EMAIL_ADDRESS>Color names are now exactly same as the CSS variables now, to make it easier to use.
And unlike the previous file, it includes all values of all themes, not just the seed values.
Let me know if you have any questions.

Just another question, I found that the way that I was setting theme using JavaScript is no longer working v5:
window.document.documentElement.setAttribute("data-theme", theme);
Is there an equivalent with DaisyUI v5 that I can programming change theme?

Is data-theme being added to <html> tag using this line?
Also make sure you enabled all themes form CSS:
@plugin "daisyui" {
  themes: all;
}

Docs will be ready soon.
Let me know if you have any questions

Yes, I added them by using this block in app.css:
@import "tailwindcss";
@plugin "daisyui" {
	themes:
		nord --default,
		dim --prefersdark;
}

Although this is added, the window.document.documentElement.setAttribute("data-theme", theme); still does not work

When window.document.documentElement.setAttribute("data-theme", theme); runs, can you check if data-theme attribute is added to <html> tag?
Is it null or something?
Are there any errors in devtools console?
Can you share a minimal reproduction example where I can run this script and see the issue?

I will open another ticket on this issue.


Unable to save the file, possible of loosing data

vscode is unable to save the files. It can't be easily reproduced and looks happens randomly.
Specially when the user enabled 'auto save'.
This bug has been reported by users frequently. However the vscode team claims that this is extensions issue. Even an extension have internal bug, it shouldn't affect saving file.
You can find similar bugs here:
https://github.com/microsoft/vscode/search?q="Running+Save+Participants"&type=Code
Is there any way to find out which extension has this bug, at least we can find a workaround for that.
VSCode Version:

Version: 1.42.1
Commit: c47d83b293181d9be64f27ff093689e8e7aed054
Date: 2020-02-17T09:32:31.598Z
Electron: 6.1.9
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.4.24-1-lts

Does this issue occur when all extensions are disabled?:
No

I wonder if this issue is being caused by an installed extension. Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code), execute: code --disable-extensions and try your steps again to see if it reproduces. If you see it is an issue with the extension, please file it against the extension repository itself.

Can you try to run VS Code without extensions? From the command line (NOT the integrated terminal in Code),

Yesterday I tried running vscode without any extensions. At least during my work I didn't see this issue, However without extensions vscode is only a text editor, So I enabled it almost after an hour. One more thing I noticed. In some cases after this error I am not able to close vscode.  Looks something is running in background.

Is it possible to put some logs here to find out which promis is not returning:
https://github.com/microsoft/vscode/blob/8b955610988d28cf98ae316dc1a3d44f599a358f/src/vs/workbench/services/textfile/common/textFileSaveParticipant.ts#L51

@jrieken save participant it seems

Is there any way to find out which extension has this bug, at least we can find a workaround for that.

Yes - have you reported this against 1.42.1. In later versions the extension name/id is part of the progress message

Closing and ignoring issues is part of Microsoft culture!


Deployed Database Request Access

The current database used by the deployed api needs to be sanitised due to content not aligned with our code of conduct.
To do so, the new maintainers would need to get access to the database in order to be able to reset it on a defined basis.
@EricSimons

Resolved


Getting env vars during debugging in vs code

Hi, I configured the package which is working when launching expo normally with expo r.
However when I try to launch the application using vs code debugger I catch this error because the main variable seems to end up being undefined.
Am I missing some crucial step or piece of information by expecting this to work?
import { ConfigContext, ExpoConfig } from "@expo/config/build";
import { mergeDeep } from "./utils/objectUtils";
import { TENANCY_NAME } from "react-native-dotenv";

export default ({ config }: ConfigContext): ExpoConfig => {
  try {
    let customConfig = require(`./tenant_configs/${TENANCY_NAME}.app.config.json`);
    if (!customConfig) {
      customConfig = {};
    }
    return mergeDeep({}, config, customConfig);
  } catch (e) {
    console.log(e);
    throw new Error(`Missing app configuration for tenant ${TENANCY_NAME}`);
  }
};

Result:
OS: darwin x64
Adapter node: v12.8.1 x64
vscode-chrome-debug-core: 6.8.8
Could not debug. Missing app configuration for tenant undefined

Ideas? Am I misusing react-native-dotenv?

This package is deprecated for babel-plugin-dotenv-import


Enable profiling support

What
Enables profiling of the application
How to test

Check out the branch
Set the EQ_PROFILING environment varable to True
Run the application as usual
Check for the presence of a profiling directory containing one file per request.

Who can test
Anybody except @weapdiv-david

Only really minor comments, looks good though :+1:

LGTM - will refactor app/init.py as part of a wider tidy up


I added a uikit folder with associated css/js files ...

... added header_images for possible header options, created responsive navigation bar with hamburger menu depending on breakpoint for main.handlebars, added own css styling for main/dashboard, installed npm jQuery dependency for package.json.

*TO DO: I still need to add an #if else statement on the main.handlebars page depending on whether or not the user is logged in


feat: Add a new option to throw an error for x-cybozu-warning

Why

Currently, we don't have a way to handle the x-cybozu-warning header.
ref. #67
What

This PR adds a new option to handle the x-cybozu-warning header in the constructor of KintoneRestAPIClient.
When the option is enabled, KintoneRestAPIClient throws an error if a received response has the header with the message, "Filter aborted because of too many search results."
I have not decided on the name of the option yet.
Why does KintoneRestAPIClient throw an error instead of a warning?
Because the search results are aborted, so the response is not what we expect. We've considered it, but I didn't find out a valid use-case using the incomplete results.
We have a plan to make this a default option at the next major release.
How to test

Checklist

[ ] Read CONTRIBUTING.md
[ ] Updated documentation if it is required.
[ ] Added tests if it is required.
[ ] Passed yarn lint and yarn test on the root directory.

I'm considering use console.warn even if the option is disabled.


[DRAFT] CoreAccess

DRAFT.
Related https://github.com/strangelove-ventures/lens/pull/94

Why do we need a TrustedCore if we have RemoteCore?


Create Hawkeye Community College

Hawkeye Community College

@Arnolddersd Please let me know what is an email address of a student in your school? Is it<EMAIL_ADDRESS>If not, what is it? Thank you.

@Arnolddersd 請告訴我你們學校學生的電子郵件地址是什麼？是<EMAIL_ADDRESS>嗎？如果不是，那是什麼？謝謝。
The email address is<EMAIL_ADDRESS>

@Arnolddersd I am sorry, the domain hawkeyecollege.edu is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Fix scrolling of Test Results when a new test starts (fixes #229531)

See issue #229531 for testing.

@connor4312 should this go in for October? Do you depend on some state in xterm that may be getting reset now that wasn't before?

Yea, we can probably save this for October at this point

Thanks for that. I updated my other PRs for merge conflicts. https://github.com/microsoft/vscode/pull/225292 https://github.com/microsoft/vscode/pull/224686


Handle player entities with unexpected end indices

A simple fix for a simple issue affecting a few users.
The issue will only normally occur if another addon is creating fake player objects (eg my terrorbot addon).

Thanks for the PR! Must have taken a bit to figure this one out.

Whoops meant to merge this...


Airflow lineage ingestion inadvertently sets incorrect column-level lineage

Affected module
Ingestion Framework
Describe the bug
I have been seen errors like this in an Airflow pipeline ingestion:
Failed to ingest table [id: 1c7c1416-6aba-4680-82bc-2b399cc318a2] due to api request failure: Invalid fully qualified column name Service Name.catalog.schema.table.column

Service Name.catalog.schema.table.column does actually exist.
In investigating this error, I found that the add_lineage method modifies the lineageDetails field  on an AddLineageRequest: https://github.com/open-metadata/OpenMetadata/blob/main/ingestion/src/metadata/ingestion/ometa/mixins/lineage_mixin.py#L127
The lineage handling for Airflow uses the same LineageDetails object for every AddLineageRequest: https://github.com/open-metadata/OpenMetadata/blob/main/ingestion/src/metadata/ingestion/source/pipeline/airflow/metadata.py#L545
This incorrectly leaks column-level lineage details across different requests.
To Reproduce

Ingest tables into OpenMetadata with column-level lineage, such as from the Databricks Unity Catalog
Ingest an Airflow pipeline that covers the same tables as above, in addition to other tables

Expected behavior
The Airflow pipeline ingestion should succeed, and not attempt to add incorrect column-level lineage
Version:

OS: [e.g. iOS] Linux
Python version: 3.10
OpenMetadata version: [e.g. 0.8] 1.4.3
OpenMetadata Ingestion package version: <IP_ADDRESS>

@ulixius9 can you take a look at this.

I believe this pr should fix this error as well https://github.com/open-metadata/OpenMetadata/pull/17264 hence closing it for now, if this is reproducible after 1.5 we can reopen this ticket


How to translate markdown files？

How to deal with markdown files in different languages?
Such as: filename.en.md, filename.es.md, filename.de.md
thanks!

You don't.
Since you're translating this file manually (or at least not using the plugin) you need to exclude that pages. In my case I have the blogposts as markdown files like the ones you mentioned
// gatsby-plugin-react-i18next options in gatsby-config.js
pages: [
          {
            matchPath: "/:lang?/blog/:uid",
            getLanguageFromPath: true,
            excludeLanguages: ["es", "en"],
          },
        ],

Then in gatsby-node.js I create the pages using the markdown files in the path I excluded from gatsby-plugin-react-i18next


improve fetching of settings

Hi Johan,
I saw some people having issues with getting the settings block to show up at Home.mycroft.ai so wanted to suggest a slight modification to how this is handled when the Skill is initialized.
self.settings_change_callback defines a function to be called anytime the web settings are updated. So this PR separates all the settings fetching along with the call to get_sources to that callback. I also added settings.json to .gitignore so that no one accidentally commits their personal settings.
I don't have a Squeezebox server setup so haven't been able to test this end to end. It does however fix the settings fetching.
Thanks
Kris

Hi Kris,
Thanks! Since I currently deploy the settings with Ansible outside of Home.mycroft.ai I haven't run into this issue and wasn't aware of it.
Unfortunately I can't test your changes end to end right now but they look good to me so I'll merge and hope for a better user experience and test it as soon as possible.
Thanks again!
Johan

Yeah nice, I hadn't heard of anyone using Ansible for settings.
Based on the Forums, it looks like a number of people are already happily using this Skill. If you think it is ready for broader adoption then please submit it for inclusion in the Mycroft Marketplace by running:
mycroft-msk submit /opt/mycroft/skills/your-skills-directory
This will automatically generate a PR and the Skill Testing Team will review it in accordance with our Skills Acceptance Process


added more controller config

Ok this is ready, the idea is to make it easier to define logic that will work for both controller + keyboard, but hopefully it wont discourage people from adding keyboard only shortcuts in the future, they will at least know that then the controller will not support something if you set a key directly


Case where error messaging is inappropriate.

I am getting the error:

Record has only one field, you can simply this. In file "src/State/Failure.elm"

On this:
type alias Reason =     { data : Comparison     }
In this case, I really can't simplify (at least not without breaking my type model of the JSON), as this is a layer within a set of nested JSON decoders, and I don't have control of the JSON structure. It's entering my Elm app from a third-party service via a port.
More:
type alias Comparison =
    { comparison : String
    , actual : Maybe String
    , expected : Maybe String
    , first : Maybe String
    , second : Maybe String
    }

comparison : Decoder Comparison
comparison =
    map5 Comparison
        (field "comparison" string)
        (maybe (field "actual" string))
        (maybe (field "expected" string))
        (maybe (field "first" string))
        (maybe (field "second" string))

type alias Reason =
    { data : Comparison
    }

reason : Decoder Reason
reason =
    map Reason
        (field "data" comparison)

type alias Failure =
    { message : String
    , reason : Reason
    }

failure : Decoder Failure
failure =
    map2 Failure
        (field "message" string)
        (field "reason" reason)

Could one of these options work for you?
type Reason = Reason Comparison

reason : Decoder Reason
reason =
    map Reason
        (field "data" comparison)

type alias Reason = Comparison

reason : Decoder Reason
reason =
        (field "data" comparison)

The second options is 'simpler' than the code you had before (losing a bit of the type-safety, but you do not have to call .data anymore. The first option adds the concept of an opaque type (which may be a good design decision based on your archictecture.

Neither of those options compiles. In the first example, the compiler fails on reason because it can no longer find the data field to map to. In the second case, since Reason is an alias to Comparison, the data field is also missing, and this does not match the structure of the JSON.
If I were in control of the data source, I would simply adjust the data structure to avoid this problem, butas I mentioned, I am tied to the structure of data I am receiving from a third-party source.
Now, to be completely honest, I could muck with the JSON structure in the JavaScript layer, but frankly, I would take this path only as an absolute last result (an elm-analyse error would not compel me down this road). It is one thing to have my Elm application be tightly coupled to third-party JSON structure (in Elm I have full type safety and immutability). It would be quite another to introduce structural coupling in the JS layer where no such protection exists.
Could not elm-analyse search the module in which a single-field type alias X appears for a function with the signature Decoder X and turn off the warning in this case? It seems to me as though there must be many contexts in which servers and other utilities, such as the one I am working with, return JSON with single fields at some levels.

I've resolved this in code after some discussion. I was able to make your latter suggestion workable after rewriting some of the accessor functions to the data structure that resulted from the JSON decoding.


Update dependencies and bump version

@alexgleith apparently we suddenly fail on eodatasets3 using distutils, which you fixed in eodatasets3 a couple of weeks ago. This is despite the eodatasets3 version remaining the same across updates. I feel Python 3.12 support should be pretty important by now, can you make a eodatasets3 release?

Hey @pjonsson, I did fix this issue, but I'll need @Ariana-B to do a release of eo-datasets. Can we do that please Ariana?

Apologies for the delay - the latest version of eo-datasets has now been released @pjonsson @alexgleith

Awesome, thanks @Ariana-B!

@Ariana-B thank you for the quick release!
@alexgleith I've used Ruff for almost a year by now and it's amazing, so I like your suggestion about using uv for the split image. Unfortunately I need to punt that work for later, so it would be nice to get this merged now so we get a GDAL 3.10.0-based release.


Migrate to vm v7 and other relevant dependencies

Preface
This is a PoC pull request to use https://github.com/ethereumjs/ethereumjs-monorepo/releases/tag/%40ethereumjs%2Fvm%407.0.0 and other relevant dependencies. List of VM changes can be found here.
Changes

[x] Update dependencies.
[x] Add .nvmrc to switch to NodeJS v18 LTS (required by the VM package).
[x] All Buffer types changed to Uint8Array due to upstream changes.

[x] All entries of Buffer.from() are replaced with toBytes() or hexToBytes(). This is not necessarily correct, due to these functions require 0x prefix at the beginning of the input string.
[x] All entries of Buffer.toString("hex") are replaced with bytesToHex(). This is not necessarily correct, due to these function adds 0x prefix at the beginning of the result string. This may cause issues.
[x] Bytes equality is now done with equalsBytes() instead of Buffer.equals().

[x] Functions getBytecodeHashHacky() and getDeployedBytecodeMdInfo() are simplified to convert Uint8Array input to string and use single logic branch. This is due to Uint8Array do not have method readInt16BE(), also lastIndexOf() is unable to find index of slice.
[x] VM removed EEI from the package. Its functionality is now provided by StateManager. So there are related adjustments to respect this change.
[x] Transaction data is now passed with TypedTransaction type.
[x] RLP is now released as a standalone dependency and therefore used in such way.

Concerns

Codebase is still not runnable due to VM package does not expose inner types in pexports section of package.json](https://github.com/ethereumjs/ethereumjs-monorepo/blob/c47d2c7351f04f35744de0f2082c37d5f2d2afd0/packages/vm/package.json#L25-L29) of CJS and ESM. This makes makes ts-node and mocha to complain and crash.

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './dist/cjs/evm' is not defined by "exports" in<EMAIL_ADDRESS>

As mentioned above, there are several cases, when code should be debugged (regading 0x of hexToBytes() and bytesToHex()).

Regards.

Closing in favor of #33


display more error details when postStream failed

when use  a deactivated account's api key to createStream
    final chatStream = OpenAI.instance.chat.createStream(
      model: "gpt-3.5-turbo",
      temperature: temperature,
      messages: messages,
    );

openai backend will return:
{
    "message":"",
    "type":"invalid_request_error",
    "param":null,
    "code":"account_deactivated"
}

Note: the message is empty.
in this lib, RequestFailedException.message will empty, the developer can only obtain the network request status code :
                if (doesErrorExists(decodedData)) {
                  final error = decodedData[OpenAIStrings.errorFieldKey]
                      as Map<String, dynamic>;
                  final message = error[OpenAIStrings.messageFieldKey];
                  final statusCode = respond.statusCode;
                  final exception = RequestFailedException(message, statusCode);

                  controller.addError(exception);
                }

This PR does the following:
final message = error[OpenAIStrings.messageFieldKey];

change to
final message = jsonEncode(error);

Thank you for this notice, and yes this is helpful for the developer but is also a breaking change, can we make a conditional expression to check whether the message field is empty or not, if yes then we apply your implementation, otherwise we return directly that message field.
What do you think?

I think it's okay. This is my new commit.

I am a PR novice 😂.If there is anything incorrect here, please guide me. thanks

Thank you


chore: switch to npm, upgrade to node 14

Signed-off-by: Brent Hoover<EMAIL_ADDRESS>Impact: breaking
Type: chore
Issue
Node 12 is End-of-Life in April. Also trying to keep package managers consistent across projects so normalizing on npm.
Solution
Move everything to npm and node 14.18.1
Breaking changes
If you have build steps that rely on yarn, they may no longer work
Testing
Theoretically nothing should change

I am on node 14.18.1
Doing npm i gives the below dependency error.
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/react
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!   peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   node_modules/@reactioncommerce/components-context
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!     peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!     node_modules/@reactioncommerce/components
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@reactioncommerce/components
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/mohannarayana/.npm/eresolve-report.txt for a full report.

npm ERR!      /Users/mohannarayana/.npm/_logs/2022-02-10T22_20_44_382Z-debug-0.log

Further doing npm i --force the storefront shows the below on console

@MohanNarayana The build process runs 14.18 and is not seeing this error. Can you give me any more info about what about your configuration is different?

@MohanNarayana Can you make sure you rm -rf node_modules and try again?

Everything works with the original yarn.lock. Deleted or regenerated one does not start storefront.


[Feature]  CldImage doesn't support cname, privateCdn or secureDistribution

Feature Request
Cloudinary permits to custom the CDN but next-cloudinary, especially, CldImage, doesn't give access to this.
See your own documentation:
https://cloudinary.com/documentation/cloudinary_sdks#cross_sdk_info
https://cloudinary.com/documentation/advanced_url_delivery_options#private_cdns_and_cnames
https://support.cloudinary.com/hc/en-us/articles/202520562-Can-we-deliver-our-assets-using-a-subdomain-of-our-own-domain-like-cdn-example-com
Potential Solution
As for the configuration of the cloudName NEXT_PUBLIC_CLOUDINARY_CLOUD_NAME="<Your Cloud Name>" in .env file. It would be very much appreciated to have the same way to configure a custom CDN. For example:
NEXT_PUBLIC_CLOUDINARY_CNAME="<Your CNAME>"
Or to have a way to pass the CNAME directly to CldImage component.
Thanks

hey @dlepaux CldImage actually supports a config prop where you can do just that!
you can add it with:
<CldImage config={{
 url: {
    secureDistribution: 'spacejelly.dev',
    privateCdn: true
  }
}} />

now unfortunately that isn't globally configurable. one way to support that globally is to create a wrapper component, then use that wrapper component, but that's also not ideal, so perhaps your idea would be a good way to support it globally
part of the issue is Next.js doesn't have an native way for me to be able to add global configurations and i want to avoid adding individual environment variables for every little configuration, but i think cname is likely one that makes sense as an environment variable, particularly because it may change depending on the environment being used
I'll try to work up a PR for this!

Hey ! Thank you for your quick answer.
Do you know if by configuring a custom domain (CNAME), does the regular cloudinary URLs are still valid ?
Thanks

yup! here's an example:
https://cld.fromdesignto.dev/image/upload/v1694695724/cld-sample-4.jpg
https://res.cloudinary.com/fromdesigntodev/image/upload/v1694695724/cld-sample-4.jpg

in addition to the config prop, privateCdn and secureDistribution are now configurable as environment variables:
NEXT_PUBLIC_CLOUDINARY_SECURE_DISTRIBUTION="<Your Secure Distribution / CNAME>"
NEXT_PUBLIC_CLOUDINARY_PRIVATE_CDN="<true|false>"

i opted not to support the cname property as it's considered legacy and only available in the context of non-secure requests, but let me know if that creates problems
https://cloudinary.com/documentation/cloudinary_sdks#configuration_parameters


Pubsub

Hello!
To add Pubsub I had to make major changes. Let me know what you think of the direction I'm going.
I added network shaping and Metrics to another branch -> https://github.com/SionoiS/sdk-rust/tree/metrics

I'm trying to do network shaping on another branch but I can't make it work. I must be missing some thing,,,
https://github.com/SionoiS/sdk-rust/tree/network/src

@SionoiS I am sorry for the super late reply here. I will take an in depth look. Help on sdk-rust is VERY much appreciated.

@SionoiS I am sorry for the super late reply here. I will take an in depth look. Help on sdk-rust is VERY much appreciated.
My metrics branch is the most up to date.

Keep in mind that I've built the bare minimum for my testground needs. I know it works but nothing is tested very well.

I will PR my latest branch and close this one. The changes have been applied.


Correct opcode for i32x4.dot_i8x16_s

The opcode in the spec PR is 0xfd 0xba, and this is also what LLVM, V8, and SpiderMonkey use.

Oops, thanks! Want a publish as well?

Oops, thanks! Want a publish as well?

That would be most helpful.  Thanks!

Sure thing, done now!

@alexcrichton, could you also bump wat to 1.0.27 and make it require wast 25.0.1?  The reason I ask is because we pull in wat, not wast directly.

Oh that shouldn't be necessary since wat 1.0.26 requires wast 25.0.0 which is satisfied with 25.0.1, so you should be able to do cargo update -p wast and it'll pull in the newer version of the wast crate.

TIL.  Thanks!


Add repo status to README

Current coverage is 92.46%

Merging #211 into master will not affect coverage as of d6bf837

Powered by Codecov. Updated on successful CI builds.


TextEdit: color doesn't change to font_color_selected when selecting text

Godot version: 3.2.1
OS/device including version: Windows 10, GLES3
Issue description:  I'm still experiencing bug #27760 even on version 3.2.1 (3.2 seemed to be affected as well), even though the fix indicated on the PR closing this bug seems to be included in the source code. (I did NOT compile the engine myself, just looked at the source code of the release.)
Steps to reproduce:
Change the font_color_selected (under "Custom Colors") of a TextEdit and try selecting text when running the scene. It still displays the normal font color. It's working fine for LineEdit.
OR
Change the above-mentioned property of a theme and then try to select the text in the "demo TextEdit" of the Theme editor. Same result as above.
Please let me know if this was worth opening a new issue or if there would have been some way for me to reopen the issue #27760, I'm not this familiar as this is my first-ever submitted issue on GitHub. Thanks!

That's not enough, you need to tick that one switch :)


Update client.py

Functions returning pairs need not to be changed given it returns [] which is expected. Functions returning pair needs to decide whether to return None or raising Error

Needs to modify list as well
return [TokenPair(**pair) for pair in resp["pairs"]]
TypeError: 'NoneType' object is not iterable

Looks fine. Maybe update the method signature to return Optional?

Does list[TokenPair] needs to be changed to list[Optional[TokenPair]]? I am not that good into typing

The list is fine.

I'll publish your fix tomorrow when I have time. Thanks for fixing it


Source map support

I found good feature in linaria. Source map support should not be so hard if Babel gives you a position for a literal node.
We need:

Take source-map (0.7 use async API, if it is a problem, using 0.6 is OK. I still use 0.6 in PostCSS, because we can’t use async API in few places)
For every literal tag generator.addMapping.
In the end, generate source map, encode it to data:uri and add to CSS file.

I feel like we're already getting source maps...I'm guessing they probably aren't linking to the inline tag but I think they definitely show up for the extracted file.
Are source maps unique to the source type? Like if someone uses Sass would you need sass specific maps or the format works for any text file?

They'd need to format specific right? How else would you know how to map positions right?

@jquense source map encoding could be different for the source type. But CSS, SCSS and Less both support the same inline maps (I am not sure about indent Sass).
But next tool must support updating previous source map. PostCSS can do it, but I am not sure about SCSS and Less. In worth case, they just remove astroturf’s source map. Not a big deal.

I'm guessing they probably aren't linking to the inline tag but I think they definitely show up for the extracted file.

Yeap, I found https://github.com/4Catalyzer/astroturf/blob/master/src/plugin.js#L82-L83 but didn’t get how it is used then.

They'd need to format specific right? How else would you know how to map positions right?

Format the whole map or mappings?

But next tool must support updating previous source map

O neat so at least in PostCSS it will update the source maps it finds after it compiles? That's cool.
Babel definitely gives the location we use it to know what text to extract, should be simple enough to append a sourcemap

The whole source map use special comment /* # sourceMappingURL=data:application/json;base64,eyJ2ZXJza in the end of the file
Each mapping just map blocks of input files to blocks in output file.
Block is a part of text between mapping points.
So, when you call:
map.addMapping({
  generated: {
    line: 2,
    column: 1
  },
  source: "in.js",
  original: {
    line: 1,
    column: 1
  }
})
map.addMapping({
  generated: {
    line: 2,
    column: 5
  },
  source: "in.js",
  original: {
    line: 1,
    column: 5
  }
})

1:1→1:4 of in.css will be mapped to 2:1→2:4 in out.css. 1.5→EOF will be mapped to 1:5→EOF.

O neat so at least in PostCSS it will update the source maps it finds after it compiles?

Yeap. I think Sass could update it too even without previous source map support, since (as I think) webpack merge source map by it own. Loaders just return own source maps and webpack merge them.

Also here is the best tool to debug source maps:
https://sokra.github.io/source-map-visualization/


修改定制化内容

hello there, this request has some private info code, and i want to delete it, can you help me?


code-insiders --status results in error

Issue Type: Bug
When connected to a remote machine via Remote-SSH, running code-insiders --status on a remote machine or locally results in the regular output plus the following error line:
Fetching remote diagnostics for 'SSH: az-devbox' failed: Canceled
VS Code version: Code - Insiders 1.53.0-insider (3ceb3a100ed0ad5f3238b5022d9d64353a1cc31e, 2021-01-11T05:14:18.990Z)
OS version: Darwin arm64 20.2.0
Remote OS version: Linux x64 5.4.0-1031-azure
Fetching remote diagnostics for 'SSH: az-devbox' failed: Canceled

System Info

Item
Value

CPUs
undefined

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 1, 1

Memory (System)
16.00GB (0.36GB free)

Process Argv
--crash-reporter-id ef10dfea-3602-4c74-ba1a-109ce7da7825

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: az-devbox

OS
Linux x64 5.4.0-1031-azure

CPUs
Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz (4 x 2294)

Memory (System)
15.64GB (8.71GB free)

VM
0%

Fetching remote diagnostics for 'SSH: az-devbox' failed: Canceled
Extensions (20)

Extension
Author (truncated)
Version

tsl-problem-matcher
eam
0.3.1

vsc-material-theme
Equ
33.1.2

vsc-material-theme-icons
equ
1.2.2

theme-monokai-pro-vscode
mon
1.1.18

remote-containers
ms-
0.154.2

remote-ssh-edit-nightly
ms-
2021.1.8133

remote-ssh-nightly
ms-
2021.1.8132

remote-wsl
ms-
0.52.0

azure-account
ms-
0.9.4

vscode-github-issue-notebooks
ms-
0.0.58

vsonline
ms-
1.0.3076

material-icon-theme
PKi
4.5.0

vscode-ruby
win
0.28.0

vscode-eslint
dba
2.1.14

gitlens
eam
11.1.3

vscode-pull-request-github-insiders
Git
2021.1.14942

rainbow-csv
mec
1.8.0

vscode-js-profile-flame
ms-
0.0.13

vscode-markdown-notebook
ms-
0.0.13

vscode-typescript-tslint-plugin
ms-
1.3.3

(4 theme extensions excluded)

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
openlogontheside:30221882
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30208929
wsl2prompt:30219162
vstry244:30230484
pythonvsdeb440:30224570
unusedprompt:30219164
folderexplorercf:30219167
openfilemenu:30219168
pythonvsded773:30223139
pythonvspyt875:30241730
core-portspanel:30233467

I just realized that one of the remote windows that I had open was disconnected. So, I guess, the error message should be more clear.

I just realized that one of the remote windows that I had open was disconnected. So, I guess, the error message should be more clear.

Related: https://github.com/microsoft/vscode/issues/99608

@Yash621 sure, search the codebase for Fetching remote diagnostics, we basically want to handle this case where the remote connection isn't available more gracefully and say something more along the lines of "Connection to 'SSH: az-devbox' could not be established". You can run the server via ./resources/server/bin/server.js

Should this be closed?

@p4nu yes, thanks


time out v2 - updated npm

Error: Request timed out
at Promises.timeoutPromise (/home/w/node_modules/@doctormckay/stdlib/components/promises.js:12:12)
at Promises.timeoutCallbackPromise (/home/w/node_modules/@doctormckay/stdlib/components/promises.js:87:25)
at SteamUser.activateAuthSessionTickets (/home/w/node_modules/steam-user/components/appauth.js:175:26)
at buildToken (/home/w/node_modules/steam-user/components/appauth.js:122:17)
at /home/w/node_modules/steam-user/components/appauth.js:128:6
at Immediate. (/home/w/node_modules/@doctormckay/stdlib/components/promises.js:94:6)
at process.processImmediate (node:internal/timers:476:21)
Node.js v18.14.2

Show the code where you're calling activateAuthSessionTickets


new commit with empty lines removed and wording changed.

bert!

Verified and merged.

Thanks, Bert.


feat(minifier): implement folding simple arrow fns

basically
const foo = () => {
    return baz
}

becomes
const foo = () => baz

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#6875  👈
#6871
#6870
#6869
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @camc314 and the rest of your teammates on  Graphite

Could this introduce an ASI hazard?

Could this introduce an ASI hazard? We may want to insert semicolons to be safe.

good question - i think this would be handled in oxc_codegen?

Merge activity

Oct 25, 6:25 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.


Blum can't claim daily reward

ERROR    | 2024-07-12 13:27:05 | Blum | User:** | Request to https://game-domain.blum.codes/api/v1/daily-reward?offset=-210 failed: 404 Client Error: Not Found for url: https://game-domain.blum.codes/api/v1/daily-reward?offset=-210 |
{"message":"Not Found"}
ERROR    | 2024-07-12 13:27:10 | Blum | User: ** | Request to https://game-domain.blum.codes/api/v1/daily-reward failed: 400 Client Error: Bad Request for url: https://game-domain.blum.codes/api/v1/daily-reward |
 {"message":"same day"}

Btw mb I do something wrong, can u have advice

I have the same error.
I think the problem is with the Blum servers.
We need to wait for a long time and we get a Timeout or 404 error.
I think the script should try again later.
But I'm not sure.

I guess it's not working, I have waited more than 2 days and collection not working (only login, and save subsequence of days)

I checked it whole week and right now I see, it's working, thx everyone


scala-cli browse attempts to download JDK

when scala-cli browse *.scala is run, it first attempts to download JDK:
~/w/s/abcd ❯❯❯ scala-cli browse *.scala
https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u292-b10/OpenJDK8U-jdk_x64_linux_hotspot_8u292b10.tar.gz

despite the fact java already is installed and in path:
~/w/s/abcd ❯❯❯ which java
/usr/bin/java
~/w/s/abcd ❯❯❯ java -version
openjdk version "11.0.11" 2021-04-20
OpenJDK Runtime Environment (build 11.0.11+9-Ubuntu-0ubuntu2.20.04)
OpenJDK 64-Bit Server VM (build 11.0.11+9-Ubuntu-0ubuntu2.20.04, mixed mode, sharing)
~/w/s/abcd ❯❯❯

Using --java-home avoids downloading the JDK.
IMHO another JDK should not be downloaded, unless explicitly requested

No, other commands (run,compile) work as expected -- no JDK download attempt, default java is used

It's because we're enforcing jvm v8 in order to run metabrowse, cc @alexarchambault

Metabrowse is now gone, shall we close this?

Yep, makes sense!


Update to use PHPUnit 10 syntax

Q
A

QA
yes

Description
Updated to latest PHPUnit 10 syntax version based on defined in composer.json

Ready for review 👍


fix: yarn lock translator & builder

fix: yarn translator
fix: yarn fix-package

Thanks a lot for this!


lxd/nic/p2p: Disable accept_ra on host

@tomponline good to go

For NorthSec we're using a setup where we have a main VM running with a few p2p NICs using a fixed host_name.
Then we have other VMs which do macvlan on those p2p as a way to easily connect them together without needing to create thousands of dedicated bridges.
The issue we ran into is because accept_ra is left on with the p2p NICs, it's now trivial for a participant to just run radvd advertising a high priority default route and hijacking all network traffic from the host...
Given the build your own goal of p2p, I think it's reasonable for the default setup not to be a security disaster and for those folks who do need to advertise over the p2p link, they're likely already running other actions on the host, so flipping accept_ra shouldn't be a big deal.

Ok makes sense thanks.


UpstreamNetworkExtensionDiscoveryIntegrationTest.BasicSuccessWithTtl flake

Detected with compile time options:
[ RUN      ] IpVersionsClientType/UpstreamNetworkExtensionDiscoveryIntegrationTest.BasicSuccessWithTtl/1
libc++abi: terminating with uncaught exception of type Envoy::EnvoyException: Negative duration passed to durationToTimeval(): -1
================================================================================
INFO: Elapsed time: 2367.553s, Critical Path: 935.38s
INFO: 18561 processes: 5757 remote cache hit, 8075 internal, 4729 remote.
@envoy//test/integration:upstream_network_filter_integration_test        FAILED in 10.7s

cc @ohadvano

Did you run it locally or is this from CI?

This is from CI.

Tagging @ohadvano since it looks like he wrote the test.
Please do prioritize the fix - flaky tests slow down work for everyone as CI can take hours to run with enough failures.  thanks so much!

Ack, I'll try to prioritize this, although I looked in the past month and didn't see a real failures for this test. I'll try to get to this next week after the UDP tunneling work.


[WFLY-19300] Add missing guava dependency needed to launch an AMQ ins…

…tance as a test fixture
https://issues.redhat.com/browse/WFLY-19300

More information about the wildfly-bot[bot]

Merging as the Windows failure is in a completely different testsuite.


Support for datasets in authenticated S3-compatible private buckets

I am looking into supporting authenticated S3-Compatible file protocol where one could specify accessKey and secretKey to view data in a private bucket.
I imagine to be able to specify a source like this:
zarr://https://s3.us-west-004.amazonaws.com/bucketname/dataset?s3_access_key_id=accessKey&s3_secret_access_key=secretKey
which would initialize an S3Client from the aws-sdk/client-s3 SDK and make the appropriate request to get the info file and data chunks.
Where would I get started to implement this in Neuroglancer?

The place to add support would be here:
https://github.com/google/neuroglancer/blob/master/src/neuroglancer/util/special_protocol_request.ts
However, there are a few issues to consider:

You will need to know the bucket region in order to generate a correct signature.  It is a bit tricky to figure it out, see e.g. the approach we take in tensorstore (https://github.com/google/tensorstore/blob/4e82af4392fe4939875d80f9fa5fd01c55beda64/tensorstore/kvstore/s3/s3_endpoint.cc#L211) but here there is the added challenge that it needs to work within the cross-origin request limitations of the browser.  Alternatively you could require that the bucket region be specified manually as part of the datasource URL, though that is a bit annoying.
If you put the access key in the datasource URL itself, then sharing the Neuroglancer URL/state will also share the access key.  That may in some cases be desired, but you would need to be careful to use an access key with only the limited privileges that you intend to grant.  It would be very easy to accidentally share a more privileged access key.  For GCS, I implemented ngauth, which allows neuroglancer users to access private GCS buckets.  It requires that you run an ngauth server, which verifies a given user has access to a bucket, and then provides a time-limited restrict authentication token.  For S3, I think there may be a way to accomplish something similar, without even the need for a server, by using AWS Cognito combined with suitable S3 access policies (https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_examples_s3_cognito-bucket.html).  I expect in many cases that would be preferable to embedding the access token directly in the URL.  Nonetheless, it could make sense to still support directly embedding the access token in the URL, and that is ultimately simpler.
A final issue is that the access token would ideally come at the beginning of the URL, before the bucket name, rather than at the end, so that completion works.

Hi @jbms -- it seems that when I click https://github.com/google/neuroglancer/blob/master/src/neuroglancer/util/special_protocol_request.ts -- I get a 404 -- any chance you know if the code moved?
Also, nice to meet you 👋 I work over at MIT with @kabilar and others. We are hoping to leverage neuroglancer in at least the short-term for viewing private zarrs stored in S3

Updated URL is here: https://github.com/google/neuroglancer/blob/master/src/util/special_protocol_request.ts
The src/neuroglancer prefix was renamed to src/.
If you decide on the approach you will use for getting the AWS credentials in Neuroglancer I can offer more advice.

Updated URL is here: https://github.com/google/neuroglancer/blob/master/src/util/special_protocol_request.ts
The src/neuroglancer prefix was renamed to src/.
If you decide on the approach you will use for getting the AWS credentials in Neuroglancer I can offer more advice.

Any advice regarding AWS creds<>auth would be great, as all our assets are all hosted via S3 -- thanks in advance
Also, just tagging a few others involved in the project here for visibility @ayendiki @balbasty @MikeSchutzman

The options that I've thought of are in my previous comment: https://github.com/google/neuroglancer/issues/507#issuecomment-1844796884
The simplest thing to implement would be to use the syntax:
s3+awskey:<ACCESS_KEY>:<SECRET_KEY>://bucket/path
Additionally you could support Amazon Cogito for credentials --- that would probably be preferable in most cases but would be a bit more complicated.
You can probably use this library to handle the actual requests to s3:
https://www.npmjs.com/package/@aws-sdk/client-s3
There is also this example of using Amazon Cogito:
https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/getting-started-browser.html

Thanks @jbms -- could you just clarify the s3+awskey:<ACCESS_KEY>:<SECRET_KEY>://bucket/path option? Unless I'm mistaken, I don't think I'd want to present these keys in plaintext -- let me know what you had in mind.
Will look further into Cognito.
@unidesigner did you ever arrive at a solution? I am looking to proof-of-concept something, but curious to understand how you approached this.
Thanks all in advance

Hi @aaronkanzer - unfortunately, I have not had time to prioritize work on this. Are you working on a proof-of-concept implementation?
I'd suggest before adding complexity with Cognito to support the scheme proposed by @jbms to provide access_key and secret_key in the URL. The secret_key would indeed be provided in plain text applying Security by Obscurity.

Hi @aaronkanzer - unfortunately, I have not had time to prioritize work on this. Are you working on a proof-of-concept implementation?
I'd suggest before adding complexity with Cognito to support the scheme proposed by @jbms to provide access_key and secret_key in the URL. The secret_key would indeed be provided in plain text applying Security by Obscurity.

@unidesigner Yes, we are working on a proof-of-concept. After some research, we are implementing presigned cookies via AWS CloudFront.
We have a CloudFront Distribution that then sits in front of our S3 bucket, and serve neuroglancer directly
This is allowing us to fetch a handful of private chunks of data in an efficient manner (e.g. in our case, we are working heavily with .ome.zarr.).
Once we have a cleaned-up e2e solution, I'm happy to share some diagrams or example code -- would also be curious to get @jbms thoughts too, and see if we can extend support directly into neuroglancer eventually.
Cc @kabilar

@unidesigner Realizing I never followed up here -- did you come to an implementation here?
We've been using our CloudFront solution for quite some time now with success -- let me know, happy to transfer any knowledge if helpful.
Cc @kabilar

Hi @aaronkanzer - no, not yet unfortunately, but it is still something I'd want to look into given time. I'd be interested in understanding your CloudFront solution! Can you post it here or write me an email<EMAIL_ADDRESS>Thank you!

@unidesigner -- sorry for the delay here! I've sent you an email via<EMAIL_ADDRESS>to hopefully meet!

I'm also very interested in this! @aaronkanzer would you have time to email me at<EMAIL_ADDRESS>or is there code / documentation I could look at?

I'm interested as well.

Hi all, thanks for your interest.  The high-level overview is documented here.  Would also be happy to meet.  Here is a scheduling link for Aaron and I.


2115: Add poi filters web

Short description

This PR adds the poi filters for web mobile and desktop.
Proposed changes

Add an overlay to the MapView containing the filter buttons
Show the poi filters as full screen modal on mobile and in the side panel on web

Side effects

Hopefully none

Resolved issues

Fixes: #2115

When filtering by "currently open", I think also places with no opening hours (e.g. town hall square) should be displayed.
See discussion on mattermost: https://chat.tuerantuer.org/digitalfabrik/pl/xq8wk1gu8fyb3fibipudreh1uh


When to publish the next release

Hi, we are going to discuss the release schedule in the mailing list this week. Please subscribe and you will get notified.
Since this is the first Apache release, it will take some time to follow the Apache release policy.


linter: add "$schema" to oxlint config documentation

Add   "$schema": "./node_modules/oxlint/configuration_schema.json" to oxlint config documentation

I would like to work on this issue.

We have a few examples such as https://github.com/oxc-project/oxc/blob/b711ee1881d8cc6011267e5e8c0c0669ab596e19/crates/oxc_linter/src/config/oxlintrc.rs#L28-L45 which will end up in https://oxc.rs/docs/guide/usage/linter/config.html
we should add "$schema" to it


FIX: Use pickle for serialization, not repr and literal_eval.

Mulligan on #811. We might eventually choose a different (and
safer) serialization method like msgpack, but that does not handle
numpy arrays out of the box, so let's start from pickle.

Codecov Report

Merging #813 into master will decrease coverage by 0.06%.
The diff coverage is 53.84%.

@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   85.92%   85.85%   -0.07%
==========================================
  Files          18       18
  Lines        4837     4844       +7
==========================================
+ Hits         4156     4159       +3
- Misses        681      685       +4

Impacted Files
Coverage Δ

bluesky/callbacks/zmq.py
75.19% <53.84%> (-1.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f43c4d...796e2bf. Read the comment docs.


Update hstring.md

wchar_t is not a type in the std namespace, instead it is a keyword.

@stevewhims
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@stevewhims
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged" @MicrosoftDocs/public-repo-pr-review-team

Just FYI, but there's no need for these messages: we use a different system (and we get two notifications per PR). Three notifications if there's this (no needed) message. :) Thanks! :)


Increase delay between infinite iterations

Since using animation-delay for adding delays between an infinite loop doesn't work, would be nice to build this into this library. If you want to do it now, you have to override your animations/timing and then change the duration.
Not sure if there's a clever way to build this in some how. Wanted to throw this suggestion out there. Thanks! 😄

@jaminroe I will look into this since I am the one who implements it... thanks for reporting!

Sorry, but there's no way to achieve this with CSS only as animation-delay only sets the staring delay and not a delay between iterations of the same animations. As @jaminroe cited, the only way would be to rewrite every animation and add a "pause" inside the keyframes themselves.  It just wouldn't make sense.
I think that's something we can document on #835 and maybe provide a js solution there for such cases.


Plugin/Extensions support for GVRf

Hi,
We have been thinking of adding support for plugin/extension for the GVRf. The reason behind this thought was to keep the existing library small and robust and make application specific features as a plugin/extension like remote model loading or SDF font support or anything similar which is specific to an application that is being built on top of the GVRf.
The major task is to first decide whether it should be a plugin or extension as the distinction between them is still unclear to us.
So we are starting this issue as to get the opinion of the GVRf community as to what and where to look for and to get a better understanding of the feature to add.

We would certainly like to understand better how this would be structured.  We've considered this before.  We can see how gvrf could be used as a plugin.  For example as a plugin to a game engine such that the game engine uses gvrf for head-tracking and stereo and distortion correction.
As far as plugins/extensions for gvrf, since gvrf is an Android/Java library, we haven't seen much overlap.  If someone wanted to use a library with gvrf, they can just include it in their project.  For example with Vuforia, or JBullet, developers can just include the jar/.so and use the APIs they want.  (we have examples for both vuforia and jbullet).
I think we need to take a look on a case by case basis to see what would be necessary for the best usage with gvrf.

i believe the recent libgdx plugin check-ins satisfies this request.


Update docs for alarm to use 5 fields cron syntax by default

docs examples should show 5 fields, like typical/standard cron syntax
Users are getting confuse with 6 fields by having the first field be seconds and not minutes
the cron variable still supports 6 fields, but it should be noted as an custom syntax for users that might want to specify sub-minute granularity.

wrong repo https://github.com/openwhisk/openwhisk/issues/1545


DHCP configuration for networks

Enhancement Request
Description
Option to configure the network interfaces as DHCP clients via the contextualization
Use case
Useful  when OpenNebula is used to assign only MAC address to the VM networks and external DHCP is managing the IP addresses.

Should consider motorization of used IP's see #1279

+1. We also have certain VM's using external DHCP.

Also it could be handy to display the MAC in sunstone and cli for the networks that has no IP assigned by ONE (and the qemu-ga probe has no updates)

This should be implemented as part of #1383 , we'll use that to track changes


Add active minutes support

Hey @rodriigovieira would you like to create a PR for this as well on this new repository?


[Bug] import tvm error[correctly install]

Expected behavior
What you were expecting
I have compiled tvm source files build the shared library from the C++ codes .
Setup for Python Package

Environment
OS version:
Ubuntu 18.04.6 LTS \n \l
TVM version:
TVM 0.9.0 commid-id : https://github.com/apache/tvm/commit/d361585965b95acfb35563b92a2011fe8059876c
Any environment details, such as: Operating System, TVM version, etc
Steps to reproduce
I want to use tvm with pytorch . So I use conda install pytorch 1.10.
I verify tvm environment but get Error.

Preferably a minimal script to cause the issue to occur.

pip install decorator


Unsupported chargingScenario: initializationChargingCommunication

2024-10-05T15:14:40+0000:WARNING:addressable:/vehicles/<FIN>/domains/charging/chargingStatus/chargingScenario: An unsupported chargingScenario: initializationChargingCommunication was provided, known values are [off, immediatelyChargingActive, immediatelyChargingFinished, chargingToDepartureTimeWaiting, chargingToDepartureTimeActive, optimisedChargingFinished, errorChargingSystem, unknown charging scenario] please report this as a bug

Will be added to next release

I have the same issue with my ID.3 after the OTA update to v3.7.
WARNING:addressable:/vehicles/XXXXX/domains/charging/chargingStatus/chargingScenario: An unsupported chargingScenario: initializationChargingCommunication was provided, known values are [off, immediatelyChargingActive, immediatelyChargingFinished, chargingToDepartureTimeWaiting, chargingToDepartureTimeActive, optimisedChargingFinished, errorChargingSystem, unknown charging scenario] please report this as a bug


Use log_server setting

The use of the log_server setting seems to have been removed at some point. This reintroduces it it again.
Just out of curiosity, would it not be possible to import settings.settings in logging.py and read the various log settings directly instead of setting it from main?

Coverage increased (+0.004%) to 37.157% when pulling 0362b0aac0c134d52aa10b84c937eae5453cecf5 on simonklb:server-logging into 836af0575a5508794895c3f833136972ba9cbed3 on tomv564:master.


IntelliSense vs Angular conflict

Hello, I'm not really sure where the issue comes from (VS IntelliSense, TypeScript, Angular, Webpack ...) but there is an unconsistancy between TypeScript and Angular when adding paths in the tsconfig.json
Environment info

Win 10 x64
Visual Studio Community 2017 15.5.6
.Net Core 2.1.4
Using Microsoft.DotNet.Web.Spa.ProjectTemplates::2.0.0-rc2-final
Project created using "dotnet new angular -o vsproject"
tsc.exe 2.5.3
angular CLI (local) 1.6.3

Your global Angular CLI version (1.6.7) is greater than your local
version (1.6.3). The local Angular CLI version is used.

To disable this warning use "ng set --global warnings.versionMismatch=false".

    _                      _                 ____ _     ___
   / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
  / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
 / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
/_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
               |___/

Angular CLI: 1.6.3
Node: 8.9.4
OS: win32 x64
Angular: 5.2.5
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router

@angular/cli: 1.6.3
@angular-devkit/build-optimizer: 0.0.36
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.42
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.3
@schematics/angular: 0.1.11
@schematics/schematics: 0.0.11
typescript: 2.4.2
webpack: 3.10.0

Repro steps
Case °1

Modified vsproject\ClientApp\tsconfig.json

{
  "compileOnSave": false,
  "compilerOptions": {
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "target": "es5",
    "typeRoots": [
      "node_modules/@types"
    ],
    "lib": [
      "es2017",
      "dom"
    ],
+    "baseUrl": "./",
+    "paths": {
+      "@app/*": [ "src/app/*" ],
+      "@env/*": [ "src/environments/*" ]
+    }
  }
}

Default tsconfig.app.json vsproject\ClientApp\src\tsconfig.app.json

{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "outDir": "../out-tsc/app",
    "baseUrl": "./",
    "module": "es2015",
    "types": []
  },
  "exclude": [
    "test.ts",
    "**/*.spec.ts"
  ]
}

Case °2

Default vsproject\ClientApp\tsconfig.json

{
  "compileOnSave": false,
  "compilerOptions": {
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "moduleResolution": "node",
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "target": "es5",
    "typeRoots": [
      "node_modules/@types"
    ],
    "lib": [
      "es2017",
      "dom"
    ]
  }
}

Modified tsconfig.app.json vsproject\ClientApp\src\tsconfig.app.json

{
  "extends": "../tsconfig.json",
  "compilerOptions": {
    "outDir": "../out-tsc/app",
    "baseUrl": "./",
    "module": "es2015",
    "types": [],
+    "paths": {
+      "@app/*": [ "app/*" ],
+      "@env/*": [ "environments/*" ]
+    }
  },
  "exclude": [
    "test.ts",
    "**/*.spec.ts"
  ]
}

Observed behavior
Case °1
TSC validates the config but webpack is unable to compile.
==> IntelliSense works but the project doesn't run
C:\...\vsproject\ClientApp>tsc --traceResolution | find "@app"
======== Resolving module<EMAIL_ADDRESS>from 'vsproject/ClientApp/src/app/app.module.ts'. ========
'baseUrl' option is set to 'c:/.../vsproject/ClientApp/', using this value to resolve non-relative module name<EMAIL_ADDRESS>'paths' option is specified, looking for a pattern to match module name<EMAIL_ADDRESS>Module name<EMAIL_ADDRESS>matched pattern '@app/*'.
======== Module name<EMAIL_ADDRESS>was successfully resolved to 'c:/.../vsproject/ClientApp/src/app/app.component.ts'. ========
======== Resolving module<EMAIL_ADDRESS>from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
'baseUrl' option is set to 'c:/.../vsproject/ClientApp/', using this value to resolve non-relative module name<EMAIL_ADDRESS>'paths' option is specified, looking for a pattern to match module name<EMAIL_ADDRESS>Module name<EMAIL_ADDRESS>matched pattern '@app/*'.
======== Module name<EMAIL_ADDRESS>was successfully resolved to 'c:/.../vsproject/ClientApp/src/app/app-routing.module.ts'. ========
======== Resolving module '@app/core' from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
'baseUrl' option is set to 'c:/.../vsproject/ClientApp/', using this value to resolve non-relative module name '@app/core'.
'paths' option is specified, looking for a pattern to match module name '@app/core'.
Module name '@app/core', matched pattern '@app/*'.
======== Module name '@app/core' was successfully resolved to 'c:/.../vsproject/ClientApp/src/app/core/index.ts'. ========
======== Resolving module '@app/shared' from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
'baseUrl' option is set to 'c:/.../vsproject/ClientApp/', using this value to resolve non-relative module name '@app/shared'.
'paths' option is specified, looking for a pattern to match module name '@app/shared'.
Module name '@app/shared', matched pattern '@app/*'.
======== Module name '@app/shared' was successfully resolved to 'c:/.../vsproject/ClientApp/src/app/shared/index.ts'. ========
======== Resolving module '@app/home' from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
'baseUrl' option is set to 'c:/.../vsproject/ClientApp/', using this value to resolve non-relative module name '@app/home'.
'paths' option is specified, looking for a pattern to match module name '@app/home'.
Module name '@app/home', matched pattern '@app/*'.
======== Module name '@app/home' was successfully resolved to 'c:/.../vsproject/ClientApp/src/app/home/index.ts'. ========
======== Resolving module '@app/catalog' from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
'baseUrl' option is set to 'c:/.../vsproject/ClientApp/', using this value to resolve non-relative module name '@app/catalog'.
'paths' option is specified, looking for a pattern to match module name '@app/catalog'.
Module name '@app/catalog', matched pattern '@app/*'.
======== Module name '@app/catalog' was successfully resolved to 'c:/.../vsproject/ClientApp/src/app/catalog/index.ts'. ========
======== Resolving module '@app/common' from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
'baseUrl' option is set to 'c:/.../vsproject/ClientApp/', using this value to resolve non-relative module name '@app/common'.
'paths' option is specified, looking for a pattern to match module name '@app/common'.
Module name '@app/common', matched pattern '@app/*'.
======== Module name '@app/common' was successfully resolved to 'c:/.../vsproject/ClientApp/src/app/common/index.ts'. ========
======== Resolving module '@app/core' from 'c:/.../vsproject/ClientApp/src/app/catalog/catalog.component.ts'. ========
'baseUrl' option is set to 'c:/.../vsproject/ClientApp/', using this value to resolve non-relative module name '@app/core'.
'paths' option is specified, looking for a pattern to match module name '@app/core'.
Module name '@app/core', matched pattern '@app/*'.
======== Module name '@app/core' was successfully resolved to 'c:/.../vsproject/ClientApp/src/app/core/index.ts'. ========
======== Resolving module '@app/core/models' from 'c:/.../vsproject/ClientApp/src/app/catalog/nav-catalog/nav-catalog.component.ts'. ========
'baseUrl' option is set to 'c:/.../vsproject/ClientApp/', using this value to resolve non-relative module name '@app/core/models'.
'paths' option is specified, looking for a pattern to match module name '@app/core/models'.
Module name '@app/core/models', matched pattern '@app/*'.
======== Module name '@app/core/models' was successfully resolved to 'c:/.../vsproject/ClientApp/src/app/core/models/index.ts'. ========

C:\...\vsproject\ClientApp>ng serve --extract-css "--port" "27617"
Your global Angular CLI version (1.6.7) is greater than your local
version (1.6.3). The local Angular CLI version is used.

To disable this warning use "ng set --global warnings.versionMismatch=false".
** NG Live Development Server is listening on localhost:27617, open your browser on http://localhost:27617/ **
Date: 2018-02-20T10:19:30.982Z
Hash: d7500fe759406ca07a37
Time: 6941ms
chunk {inline} inline.bundle.js (inline) 5.79 kB [entry] [rendered]
chunk {main} main.bundle.js (main) 2.93 kB [initial] [rendered]
chunk {polyfills} polyfills.bundle.js (polyfills) 636 bytes [initial] [rendered]
chunk {styles} styles.bundle.css (styles) 116 kB [initial] [rendered]
chunk {vendor} vendor.bundle.js (vendor) 855 kB [initial] [rendered]

ERROR in src/app/app.module.ts(5,30): error TS2307: Cannot find module<EMAIL_ADDRESS>src/app/app.module.ts(6,34): error TS2307: Cannot find module<EMAIL_ADDRESS>src/app/app.module.ts(7,28): error TS2307: Cannot find module '@app/core'.
src/app/app.module.ts(8,30): error TS2307: Cannot find module '@app/shared'.
src/app/app.module.ts(9,28): error TS2307: Cannot find module '@app/home'.
src/app/app.module.ts(10,31): error TS2307: Cannot find module '@app/catalog'.
src/app/app.module.ts(11,33): error TS2307: Cannot find module '@app/common'.
src/app/catalog/catalog.component.ts(6,41): error TS2307: Cannot find module '@app/core'.
src/app/catalog/nav-catalog/nav-catalog.component.ts(3,26): error TS2307: Cannot find module '@app/core/models'.

webpack: Failed to compile.

Case °2
TSC fails to validated the config but webpack is able to compile.
==> The project runs but IntelliSense doesn't recognize @app
C:\...\vsproject\ClientApp>tsc --traceResolution | find "@app"
======== Resolving module<EMAIL_ADDRESS>from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
Loading module<EMAIL_ADDRESS>from 'node_modules' folder, target file type 'TypeScript'.
Loading module<EMAIL_ADDRESS>from 'node_modules' folder, target file type 'JavaScript'.
======== Module name<EMAIL_ADDRESS>was not resolved. ========
======== Resolving module<EMAIL_ADDRESS>from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
Loading module<EMAIL_ADDRESS>from 'node_modules' folder, target file type 'TypeScript'.
Loading module<EMAIL_ADDRESS>from 'node_modules' folder, target file type 'JavaScript'.
======== Module name<EMAIL_ADDRESS>was not resolved. ========
======== Resolving module '@app/core' from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
Loading module '@app/core' from 'node_modules' folder, target file type 'TypeScript'.
Loading module '@app/core' from 'node_modules' folder, target file type 'JavaScript'.
======== Module name '@app/core' was not resolved. ========
======== Resolving module '@app/shared' from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
Loading module '@app/shared' from 'node_modules' folder, target file type 'TypeScript'.
Loading module '@app/shared' from 'node_modules' folder, target file type 'JavaScript'.
======== Module name '@app/shared' was not resolved. ========
======== Resolving module '@app/home' from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
Loading module '@app/home' from 'node_modules' folder, target file type 'TypeScript'.
Loading module '@app/home' from 'node_modules' folder, target file type 'JavaScript'.
======== Module name '@app/home' was not resolved. ========
======== Resolving module '@app/catalog' from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
Loading module '@app/catalog' from 'node_modules' folder, target file type 'TypeScript'.
Loading module '@app/catalog' from 'node_modules' folder, target file type 'JavaScript'.
======== Module name '@app/catalog' was not resolved. ========
======== Resolving module '@app/common' from 'c:/.../vsproject/ClientApp/src/app/app.module.ts'. ========
Loading module '@app/common' from 'node_modules' folder, target file type 'TypeScript'.
Loading module '@app/common' from 'node_modules' folder, target file type 'JavaScript'.
======== Module name '@app/common' was not resolved. ========
======== Resolving module '@app/core' from 'c:/.../vsproject/ClientApp/src/app/catalog/catalog.component.ts'. ========
Loading module '@app/core' from 'node_modules' folder, target file type 'TypeScript'.
Resolution for module '@app/core' was found in cache.
======== Module name '@app/core' was not resolved. ========
======== Resolving module '@app/core/models' from 'c:/.../vsproject/ClientApp/src/app/catalog/nav-catalog/nav-catalog.component.ts'. ========
Loading module '@app/core/models' from 'node_modules' folder, target file type 'TypeScript'.
Loading module '@app/core/models' from 'node_modules' folder, target file type 'JavaScript'.
======== Module name '@app/core/models' was not resolved. ========
src/app/app.module.ts(5,30): error TS2307: Cannot find module<EMAIL_ADDRESS>src/app/app.module.ts(6,34): error TS2307: Cannot find module<EMAIL_ADDRESS>src/app/app.module.ts(7,28): error TS2307: Cannot find module '@app/core'.
src/app/app.module.ts(8,30): error TS2307: Cannot find module '@app/shared'.
src/app/app.module.ts(9,28): error TS2307: Cannot find module '@app/home'.
src/app/app.module.ts(10,31): error TS2307: Cannot find module '@app/catalog'.
src/app/app.module.ts(11,33): error TS2307: Cannot find module '@app/common'.
src/app/catalog/catalog.component.ts(6,41): error TS2307: Cannot find module '@app/core'.
src/app/catalog/nav-catalog/nav-catalog.component.ts(3,26): error TS2307: Cannot find module '@app/core/models'.

D:\Data\inDev\TFSOnline\Indev.Jour\Indev.Jour\Indev.Jour.WebSpa\ClientApp>ng serve --extract-css "--port" "27617"
Your global Angular CLI version (1.6.7) is greater than your local
version (1.6.3). The local Angular CLI version is used.

To disable this warning use "ng set --global warnings.versionMismatch=false".
** NG Live Development Server is listening on localhost:27617, open your browser on http://localhost:27617/ **
Date: 2018-02-20T10:36:16.614Z
Hash: a28de3e240ce1a0ce99b
Time: 12536ms
chunk {inline} inline.bundle.js (inline) 5.79 kB [entry] [rendered]
chunk {main} main.bundle.js (main) 144 kB [initial] [rendered]
chunk {polyfills} polyfills.bundle.js (polyfills) 562 kB [initial] [rendered]
chunk {styles} styles.bundle.css (styles) 116 kB [initial] [rendered]
chunk {vendor} vendor.bundle.js (vendor) 10.7 MB [initial] [rendered]

webpack: Compiled successfully.

Desired behavior
That both IntelliSense and compile works.

@SteveSandersonMS - would you suspect that this is a VS issue and not a runtime issue?

@Eilon Yes, I would.
@Booster2ooo Sorry this is not working out conveniently. I'm afraid that the VS intellisense and Angular CLI compilation behaviors are both out of our control in this repo. If you change the config and it doesn't work, you'd have to contact VS and/or Angular CLI folks to determine whether your custom config is meant to be supported and if it's a bug, whether that can be fixed. In this repo we can only control the default config that the template gives you. Hope that's OK!


HashTable_GPU.py  code error

can not find the method cuda.LongTensor()   cuda.floatTensor()  torch.sparse.LongTensor()

Hello,
Could you elaborate? What is the error exactly? Which version of Pytorch do you have?
You can find informations about the Cuda tensor types here:
https://pytorch.org/docs/stable/tensors.html
and about the sparse API here:
https://pytorch.org/docs/stable/sparse.html
Samuel


fix(WebSocket): prevent dispatching "open" event if the connection was closed

This change prevents the WebSocket client from dispatching the open event if the connection has been rejected (closed/errored) in the connection event listener.
Note that this keeps the oddity of the client.socket.readtyState being CONNECTING in the connection event listener. This isn't how an actual server connection event behaves, but this is necessary for the interceptor to reject the connection from within before it's ever opened (think of MSW rejecting the WebSocket connection if it's unhandled).
Previous approach
During play testing, I've discovered that client.socket.readyState value was 0 (CONNECTING) in the connection event listener's scope. I believe that's incorrect. The readyState of the intercepted client MUST be 1 (OPEN) in the connection event listener.
The connection event is dispatched when the connection has been successful. In the interceptor's context, any WebSocket connection is considered successful if it has the connection listener.
This is also the behavior when using the actual WebSocket server:
wss.on('connection', (ws) => {
  ws.readyState // 1
})

[!WARNING]
If the connection event is dispatched when readyState is OPEN, then MSW cannot reject that connection (onUnhandledRequest). The open even is always emitted, and then the close/error event.

This isn't the right approach. Rejecting a connection is crucial.

The readyState can be CONNECTING in the connection event, that's quite okay.
If you close client.close(), the client must NOT emit the OPEN event on the next frame at all. The closure must take priority (it's already delegated to the next frame). This is easily fixed by checking if (this.readyState !== this.CLOSING) before emitting the open event in the constructor.

Released: v0.36.3 🎉
This has been released in v0.36.3!

📄 Release notes
📦 npm package

Make sure to always update to the latest version (npm i @mswjs/interceptors@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.


Default code formatting off

See also #85

I was wrong, turns out #85 and #86 are not equivalent, since ENABLE_LINTING with this PR will not be propagated to h3, causing that formatter to run and generating a bunch of:
Invalid value for -style
Invalid value for -style
Invalid value for -style

That is certainly unexpected! I will take a look at how to disable that.


File Chooser Filter Viewing Folder Contents

Currently, the file chooser has no easy way to search for a file within a large folder. Folders' contents are sorted by name which means one can scroll to the correct position to find their file, but this means a lot of scrolling, especially since Compose Desktop doesn't have scroll bars.
It would be handy to have a filter text field right above the folder contents list that allows the user to filter the currently visible files.
The filter text field should automatically take focus when the user interacts with the filder contents list, allowing the user to "just type" to start filtering.
The filter text field should have a 'clear' button on its right side, as manually deleting the contents of this field could get tiresome.
The filter should either have a button to enable/disable case-sensitivity or should just be case-insensitive.

This seems a lot less necessary now that scroll-bar support has been set up. I will close this for now and maybe re-open it if it becomes an issue again.


Improved revocation checker

I have experimented with an improved revocation checking mechanism, using built-in android tooling, that works from api level 24 and up. For now I have only published it as a gist, and I am using it myself in my project.
If the community can do a quick review of the solution provided here https://gist.github.com/HylkeB/f9f3c26398c49985e54545df1b76b062 and provide feedback on it, I think it might be a good idea to replace the certificate revocation implementation currently in this library for my one. If others agree I might be able to find the time to create a PR for this.
The downside on the current certificate revocation implementation in this library is that it requires an app update, basically creating another source of truth for the revocation status of a certificate. WebPKI already has solutions for revocation, using OCSP, CRL and OCSPStapling, so it would be wise to reuse the existing solutions for that, and not create a new one.
With my solution the revocation interceptor uses the built-in CertPathValidator and PKIXRevocationChecker to check if none of the used certificates in the certificate chain are revoked (which in turn uses the certificate to find the OCSP responder url, and as a fallback uses the CRL url to determine if the certificate is revoked or not). On older android versions, this is disabled by default; or configured as a soft-fail. My solution requires with certainty that the certificate is not revoked. If it is not possible to check the OCSP status and CRL (verified by going to airplane mode just before the check using breakpoints) it will block the connection.

This does look very interesting; ultimately revocation is not core functionality of the library and is not something I want in it long term; my implementation was certainly always a stop-gap!
i.e. it should live in an independent certificate-revocation library.
Worth reading this article https://scotthelme.co.uk/revocation-is-broken/ and verifying your solution against that as there are issues relying on some of those forms of revocation.
I'd previously created a note to myself about revocation and I'm adding a link to your solution too for when I have time to follow up.

Hi Matt, thanks for responding.
I have to disagree that revocation checking is not a core functionality. In my opinion revocation checking should be a core functionality of this library if you want to promote this library as a replacement to certificate pinning (as stated in the readme).
If you have certificate transparency enforced in your http client as a replacement for certificate pinning, what you are saying is that you rely on your monitoring infrastructure to be informed of maliciously issued certificates and then having the CA's revoke these maliciously issued certificates.
This leaves a small window of attack that you are fine with, as it reduces the LCM effort of constantly keeping the certificate pin in sync with the server certificate. The small window of attack is the time it takes from when the attacker was able to get an maliciously issued certificate, and has it published to the logs, until your monitoring infrastructure has successfully revoked that malicious certificate.
Now if you say that the certificate revocation checks are not a core part of this library, then even if you have the CT monitoring infrastructure up and running, and you get malicious certificates revoked in reasonable time, that does not matter for the attacker since the app you're trying to protect from MITM attacks thinks its all ok. The malicious certificate is valid, its signed by a valid CA, its embedded in the CT logs, its also revoked but thats not checked, so its not a proper MITM protection mechanism without revocation checks.
Also; I've read the article you linked, in the article they make some good points; but thats all from a browser standpoint. A browser does not have to replace certificate pinning to protect against MITM attacks. This library is for mobile apps that want to make sure they connect with their own server, and not a MITM, and they probably want to replace certificate pinning.
Their point about soft fails vs hardfails: since we're writing something proprietary, we can just hard fail when the OCSP or CRL is not available. (thats what I do in my gist as well)
About the availability: we could introduce some caching mechanism, it tries to verify the revocation status every time, cache the result, and keep that in a cache for x amount of time, which increases both the reliability (yay) and the attack window (aww).

Worth noting that browsers don't do certificate pinning anymore!
This libraries sole purpose is for performing CT checks not revocation checks.
Thats not to say revocation checks aren't important; they are for the reasons you state. I'm not happy with that small window for attack either.
When I've done talks on the topic I've made sure I've stated that as well, it is one of CTs bigger flaws - it's not just about monitoring.
So this isn't to say that we shouldn't do them I'd just rather the code lived in a separate library so both libraries have a single purpose. The scope for a revocation library can be huge, from managing CRL lists to OCSP etc, or even the ability to add your own manual revocations (for those times you know you have a bad cert perhaps)


The TOTAL cases can be highlighted differently

The TOTAL can be highlighted differently  rather than grouping along with the other states

Patched!


Will already downsampled blocks be merged?When downsampled blocks are merged into new blocks, do the new blocks still need to be downsampled?

Thanos, Prometheus and Golang version used:

Object Storage Provider:
What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Full logs to relevant components:

Anything else we need to know:

Yeah I think the current logic is bugged in previous version of Thanos. But with https://github.com/thanos-io/thanos/pull/7334, downsampled blocks will be excluded from compaction so they shouldn't be compacted anymore.


Update LICENSE

Coverage remained the same at 100.0% when pulling dee06f9fb1af597fbb026c882cef958e1bf1881b on trevren11:patch-1 into 1998531c6793635c637092cfa6007f38c33ddd24 on mobile-qa:master.

Coverage remained the same at 100.0% when pulling ee9e31d320b9c4056510d368f845acd7c5d7148e on trevren11:patch-1 into 1998531c6793635c637092cfa6007f38c33ddd24 on mobile-qa:master.

Thanks!


CI: Update actions/upload-artifact to a version that uses Node.js 20+

The version of actions/upload-artifact we use in multiple workflows runs on Node 16. This adds a deprecation warning annotation to our runs, for example:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20<EMAIL_ADDRESS>For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Update the version of actions/upload-artifact used in all our workflows to a version that uses Node.js 20 or higher. At the time of creating this ticket, Node.js 22 was the most recent version.

PR for similar work in csec-ruby-agent: https://github.com/newrelic/csec-ruby-agent/pull/77


Remix useSubmit doesn't serialize form blobs properly

It'll take me a while to produce a reproduction, but the short version is I should be able to take an audio blob, append it to a form, and that should be able to be sent to the backend, but right now remix serializes it to [object Object].
Reference of what it should support: https://stackoverflow.com/questions/18394483/how-to-serialize-a-blob-javascript#18394584
I'm creating a web-based audio recorder and trying to submit the recording to my action for persistence. Works if I use fetch directly instead (like shown here: https://stackoverflow.com/questions/60431835/how-to-convert-a-blob-url-to-a-audio-file-and-save-it-to-the-server).

No need to track this since it's already tracked in #165


Release v0.3.1

Security

Dependency github.com/gogo/protobuf is now at version v1.3.2 to address CVE-2021-3121

Looks like the pipeline is broken. I think the intention is the bot makes this change: https://github.com/secrethub/secrethub-kubernetes-mutating-webhook/pull/15

Looking at that previous MR, I believe all you need to do is push a release/v0.3.1 branch and open a MR for it. The bot will do the rest.


create HTML for and upload to staging five Chinese language IGO 3.0 translations

Per email sent 6 April 2015 with files attached.

https://github.com/travis-ci/travis-ci/issues/5243


Tests: use proper certs for Alice and Bob

Problem
Certs for Alice and Bob in out unit-tests are wrong, they are belonged to different fabrics.
Change overview
Use new test-certs for Alice and Bob
Testing
Passed unit-tests

Yes, but the invariant in the spec is that a given stack instance has a unique node id in a given fabric, which is why the data structure looks like it does.  The tests are just violating that invariant....


Fix for the delete button in the query field

delete button is not working in the query field.
This patch is tested on command line ubuntu.
Signed-off-by: Prahlad V<EMAIL_ADDRESS>

Hey @prahlad37, thanks for contributing! Am I understanding correctly that what you would like is for the delete key to work the same as the Ctrl-D key combination does? I.e. delete the character under the cursor not to the left of it.
I tried your branch locally on OS X 10.11.2 and could reliably reproduce segmentation faults when pressing the delete key when the query field is empty or when currently at the last column of the query.
What do you think about instead introducing another fall through case above the CTRL('D') one with the right key for delete?

My bad.. I didn't see the CTRL+D binding. I think it should be fine to add it as a fall through case of CTRL(D)

Hey @prahlad37, that looks much better! I'm kind of confused by the naming of these constants. You're moving BACKSPACE but we're talking about the delete key. Should these names be swapped?
@mptre Do you have more background knowledge on these constants?

Pressing the delete key in my shell outputs the key_dc (abbreviated kD)
capability which is equal to the sequence present in this patch. The
behavior of this key is equivalent to Ctrl-D so I think this change
makes sense.
On Fri, Apr 29, 2016 at 07:44:57AM -0700, Calle Erlandsson wrote:

Hey @prahlad37, that looks much better! I'm kind of confused by the naming of these constants. You're moving BACKSPACE but we're talking about the delete key. Should these names be swapped?

Agree, they should be swapped.
A few other notes on the patch:

Don't introduce whitespace changes, referring to the deleted blank line

Please add a test-case for the new key binding, the test should look
similiar to tests/03.in

Swap the DEL and BACKSPACE constants as discussed

Squash your commits once you're done

Other than that, great work.

Latest changes looks good. One last thing: don't forget to add the new
key to the man page.

Hey @prahlad37, thanks for working on this! I think the latest changes look great.
The tests fail locally for me with this error message:
./tests/test.sh: line 41: [: too many arguments
./tests/10.in: wrong exit code
test: time limit exceeded
FAIL tests/test.sh (exit status: 1)

Do you see something similar when you run make check; cat test-suite.log?

With #113 merged, I now get this when running make check; cat test-suite.log.
./tests/10.in: wrong exit code
test: time limit exceeded
FAIL tests/test.sh (exit status: 1)

I am also having the same problem.
After debugging arrived to a point that the default canonical mode of master tty is cause processing of our input before feeding to pick. #119 looks like the possible fix.

After merging #119 and rebasing on top of master make check passes! Thanks for working on this @prahlad37, I'll merge this PR.

Merged as ac92b24d9c57f6327061dd18b1f2daa97559226b.


Smart contract dissasmbled incorrectly on mainet…

As result, the debugger is considering several ɪɴᴠᴀʟɪᴅ instructions to be executed and fails to detect they were 2 levels of subcontract calls on this transaction.

it's better to use directly remix.ethereum.org , I am not sure if etherscan has the latest version.
Let me know if it's working better with remix.ethereum.org . thanks


chore: squeeze some non-terminal simps

This PR collects the effect of the squeezed simps and of the false positives that the linter encounters.  I plan to keep updating this PR while I make my way through the output of the linter.

This PR accumulated too many conflicts: closing.


Use correct function name in documentation for meta properties

Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation
and context. List any dependencies that are required for this change
Links to Notion, Figma or any other documents that might be relevant to the PR

Add a TL;DR when description is extra long (helps content team)

Fixes # (issue)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.
Delete anything that is not important

Manual
Jest
Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Test plan has been approved by relevant developers
[ ] Test plan has been peer reviewed by QA
[ ] Cypress test cases have been added and approved by either SDET or manual QA
[ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
[ ] Added Test Plan Approved label after reveiwing all Cypress test

@rajatagrawal Thanks for the PR.
A few details to note:

The Semantic PR checks for a valid PR name format. So we need to add a chore|fix|feat prefix in the PR name. chore: update function name in documentation
The PR template needs to be detailed. In this PR's case, most of it can be ignored or mentioned as Not applicable.
Finally, all PRs need to have an associated issue id connected. This would be the Fixes #<issue_id> in the PR description.

/ok-to-test sha=0a81b7c


Contact page

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

hey @PranavKapoor28 do u want to work on this issue ??

Yes I can create a contact page.

Yes I can create a contact page.

ok @PranavKapoor28 go ahead

Heyy @Ayan-thecodeking 👋
As I have seen it's been 3days till now, no response and updates from @PranavKapoor28
So I would like to work on this issue, Kindly assign me this issue under DCP'21.
Let me know @PranavKapoor28 if you're working or not, if you're working on it, that's alright :)
else @Ayan-thecodeking you can assign me
Thanks✨

@ayushsoni1010
I am working on it, I was not well for the past 2 days due to vaccine so couldn't work on it. But I will complete it.
You can ask @Ayan-thecodeking to give you some other issue.

@ayushsoni1010
I am working on it, I was not well for the past 2 days due to vaccine so couldn't work on it. But I will complete it.
You can ask @Ayan-thecodeking to give you some other issue.

Oh okay!

@Ayan-thecodeking I have made the changes but i cannot add in this repo , as it is showing no that there is no change .
What should i do?

@Ayan-thecodeking I have made the changes but i cannot add in this repo , as it is showing no that there is no change .
What should i do?

hey @PranavKapoor28  Im not getting what issue u are facing ...dm me lets have a meet on our discord server ..if ur issue is not resolved yet


Fix error sorting data on Validator Explorer

Description
Fix error sorting data on Validator Explorer

Simple Enough, ✅
For the future would you add more info about what the errors was, and how you know this fixed it?


Review Gartner suggested metrics sent from DS and incorporate changes

Has this been completed? Is it still required?
I think that was a move from the original Trello board.
@remyb2canada ?

That relates to IT Score I think. Might be another Gartner document.
Closing task, info found should be put in the OneNote document.


Think about to fix the issues found by adapter checker

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:
https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/instalator/ioBroker.starline

[ ] [E114] No adapter are allowed in the repo without admin3 support

I have also found warnings that may be fixed if possible.

[ ] [W113] Adapter should support compact mode

Thanks,
your automatic adapter checker.
P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

Fixed


Float-up labels needs a Core version

Angular version: https://play.nativescript.org/?template=play-ng&id=9GOYmZ&v=6
Vue version: https://play.nativescript.org/?template=play-vue&id=WlzgRU&v=10
Core version: doesn’t exist, this is what needs to be built :)

In the angular version, GridLayout has not been closed properly

So use this version: https://play.nativescript.org/?template=play-ng&id=9GOYmZ&v=59

TADAAA:
Implemented it for Core
https://play.nativescript.org/?template=play-js&id=oSksgv

Thanks @shiv19 !