Layer qt refactor

Description
This PR builds on the window / viewer refactor #88 (which should be merged first) to rename, merge, and move some of the layers related files. It changes no other code inside these files. Only the last two commits listed here aren't covered in that PR.
First the QtLayerPanel, QtLayerDivider, QtLayerList, and QtLayerButtons classes now all live inside one file. QtLayerPanel is the highest class in the sense that it contains all the others. I think this makes our file structure a little simpler.
The second change is to use underscores instead of camelCase in our filenames. Is this the right choice? Before we had a mix. I feel like we should at least have consistency.
The third change is to create another qt folder inside the layer folder and then move the layer specific qt files in there. I think it is cleaner to have all the layer related files together, and it will make it easier for people to understand what to do when they need to add new layers. Do people like this change?
A more extreme choice would be to get rid of the qt folder entirely and put all the qt stuff directly on the objects themselves. Do we want to discuss this as an option?
Type of change

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

References

How has this been tested?

[x] example: run examples/layers.ipynb and interact with gui

Final checklist:

[x] My PR is the minimum possible work for the desired functionality

Hello @sofroniewn! Thanks for submitting the PR.

In the file examples/demo.py, following                are the PEP8 issues :

Line 44:80: E501 line too long (90 > 79 characters)
Line 59:80: E501 line too long (93 > 79 characters)
Line 61:80: E501 line too long (99 > 79 characters)
Line 80:80: E501 line too long (92 > 79 characters)
Line 91:80: E501 line too long (93 > 79 characters)
Line 93:80: E501 line too long (101 > 79 characters)
Line 108:1: E305 expected 2 blank lines after class or function definition, found 1
Line 112:5: E265 block comment should start with '# '
Line 113:5: E265 block comment should start with '# '
Line 115:5: E265 block comment should start with '# '
Line 116:5: E265 block comment should start with '# '

There are no PEP8 issues in the file gui/__init__.py !

There are no PEP8 issues in the file gui/elements/__init__.py !

In the file gui/elements/_control_bars.py, following                are the PEP8 issues :

Line 3:1: E302 expected 2 blank lines, found 1

In the file gui/elements/_dimensions.py, following                are the PEP8 issues :

Line 11:1: E302 expected 2 blank lines, found 1
Line 114:80: E501 line too long (82 > 79 characters)
Line 116:27: E231 missing whitespace after ','
Line 116:29: E231 missing whitespace after ','
Line 116:63: E231 missing whitespace after ','
Line 116:65: E231 missing whitespace after ','
Line 116:80: E501 line too long (86 > 79 characters)

In the file gui/elements/_viewer.py, following                are the PEP8 issues :

Line 11:28: E231 missing whitespace after ','
Line 11:33: E231 missing whitespace after ','
Line 11:41: E231 missing whitespace after ','
Line 13:1: E302 expected 2 blank lines, found 1
Line 61:71: E231 missing whitespace after ','
Line 150:29: E231 missing whitespace after ','
Line 184:55: E231 missing whitespace after ','
Line 184:80: E501 line too long (109 > 79 characters)
Line 184:81: E231 missing whitespace after ','
Line 201:25: E231 missing whitespace after ','
Line 219:80: E501 line too long (88 > 79 characters)
Line 225:80: E501 line too long (85 > 79 characters)
Line 253:75: E231 missing whitespace after ','
Line 253:80: E501 line too long (129 > 79 characters)
Line 253:101: E231 missing whitespace after ','
Line 282:59: E231 missing whitespace after ','
Line 282:80: E501 line too long (113 > 79 characters)
Line 282:85: E231 missing whitespace after ','

There are no PEP8 issues in the file gui/elements/_window.py !

There are no PEP8 issues in the file gui/elements/qt/__init__.py !

In the file gui/elements/qt/_control_bars.py, following                are the PEP8 issues :

Line 13:80: E501 line too long (94 > 79 characters)
Line 18:80: E501 line too long (96 > 79 characters)

In the file gui/elements/qt/_dimensions.py, following                are the PEP8 issues :

Line 4:1: E302 expected 2 blank lines, found 1

In the file gui/elements/qt/_layer_list.py, following                are the PEP8 issues :

Line 3:80: E501 line too long (106 > 79 characters)
Line 9:28: E231 missing whitespace after ','
Line 9:36: E231 missing whitespace after ','
Line 10:25: E231 missing whitespace after ','
Line 10:33: E231 missing whitespace after ','
Line 11:25: E231 missing whitespace after ','
Line 11:33: E231 missing whitespace after ','
Line 12:24: E231 missing whitespace after ','
Line 12:32: E231 missing whitespace after ','
Line 14:1: E302 expected 2 blank lines, found 1
Line 25:1: E302 expected 2 blank lines, found 1
Line 38:1: E302 expected 2 blank lines, found 1
Line 44:9: E265 block comment should start with '# '
Line 91:63: E231 missing whitespace after ','
Line 92:61: E231 missing whitespace after ','
Line 118:80: E501 line too long (86 > 79 characters)
Line 122:80: E501 line too long (100 > 79 characters)
Line 142:80: E501 line too long (100 > 79 characters)
Line 158:24: E225 missing whitespace around operator
Line 161:29: E231 missing whitespace after ','
Line 172:1: E302 expected 2 blank lines, found 1
Line 175:80: E501 line too long (137 > 79 characters)
Line 176:80: E501 line too long (135 > 79 characters)
Line 186:1: E302 expected 2 blank lines, found 1
Line 197:80: E501 line too long (85 > 79 characters)
Line 198:80: E501 line too long (88 > 79 characters)
Line 199:80: E501 line too long (89 > 79 characters)
Line 219:1: E302 expected 2 blank lines, found 1
Line 229:80: E501 line too long (85 > 79 characters)
Line 230:80: E501 line too long (88 > 79 characters)
Line 231:80: E501 line too long (89 > 79 characters)
Line 241:1: E302 expected 2 blank lines, found 1
Line 248:80: E501 line too long (82 > 79 characters)
Line 249:80: E501 line too long (83 > 79 characters)
Line 250:80: E501 line too long (109 > 79 characters)
Line 252:80: E501 line too long (108 > 79 characters)
Line 254:80: E501 line too long (90 > 79 characters)
Line 255:80: E501 line too long (94 > 79 characters)

In the file gui/elements/qt/_viewer.py, following                are the PEP8 issues :

Line 5:1: E302 expected 2 blank lines, found 1

In the file gui/layers/_image_layer.py, following                are the PEP8 issues :

Line 20:1: E302 expected 2 blank lines, found 1

In the file gui/layers/_markers_layer.py, following                are the PEP8 issues :

Line 14:1: E302 expected 2 blank lines, found 1
Line 227:45: E231 missing whitespace after ','
Line 283:80: E501 line too long (103 > 79 characters)
Line 283:99: E231 missing whitespace after ','
Line 290:80: E501 line too long (111 > 79 characters)
Line 344:80: E501 line too long (83 > 79 characters)

There are no PEP8 issues in the file gui/layers/qt/__init__.py !

In the file gui/layers/qt/_base_layer.py, following                are the PEP8 issues :

Line 1:80: E501 line too long (133 > 79 characters)
Line 7:24: E231 missing whitespace after ','
Line 7:32: E231 missing whitespace after ','
Line 9:1: E302 expected 2 blank lines, found 1
Line 13:80: E501 line too long (129 > 79 characters)
Line 14:80: E501 line too long (134 > 79 characters)
Line 21:80: E501 line too long (87 > 79 characters)
Line 27:9: E265 block comment should start with '# '
Line 35:80: E501 line too long (83 > 79 characters)
Line 41:9: E265 block comment should start with '# '
Line 47:80: E501 line too long (82 > 79 characters)
Line 53:80: E501 line too long (82 > 79 characters)
Line 56:80: E501 line too long (100 > 79 characters)
Line 61:80: E501 line too long (85 > 79 characters)
Line 118:24: E225 missing whitespace around operator
Line 118:80: E501 line too long (102 > 79 characters)
Line 160:54: E231 missing whitespace after ','
Line 162:54: E231 missing whitespace after ','
Line 169:9: E265 block comment should start with '# '
Line 170:9: E265 block comment should start with '# '
Line 171:9: E265 block comment should start with '# '

In the file gui/layers/qt/_image_layer.py, following                are the PEP8 issues :

Line 5:1: E302 expected 2 blank lines, found 1
Line 15:80: E501 line too long (85 > 79 characters)
Line 22:80: E501 line too long (87 > 79 characters)
Line 25:80: E501 line too long (107 > 79 characters)

In the file gui/layers/qt/_markers_layer.py, following                are the PEP8 issues :

Line 7:1: E302 expected 2 blank lines, found 1
Line 14:9: E265 block comment should start with '# '
Line 31:12: E111 indentation is not a multiple of four
Line 32:80: E501 line too long (82 > 79 characters)
Line 34:12: E111 indentation is not a multiple of four
Line 35:80: E501 line too long (99 > 79 characters)
Line 42:12: E111 indentation is not a multiple of four
Line 43:80: E501 line too long (82 > 79 characters)
Line 45:12: E111 indentation is not a multiple of four
Line 46:80: E501 line too long (99 > 79 characters)
Line 53:12: E111 indentation is not a multiple of four
Line 54:80: E501 line too long (80 > 79 characters)
Line 56:12: E111 indentation is not a multiple of four
Line 57:80: E501 line too long (100 > 79 characters)

In the file gui/util/misc.py, following                are the PEP8 issues :

Line 90:19: E231 missing whitespace after ','
Line 107:1: E305 expected 2 blank lines after class or function definition, found 1

First the QtLayerPanel, QtLayerDivider, QtLayerList, and QtLayerButtons classes now all live inside one file. QtLayerPanel is the highest class in the sense that it contains all the others. I think this makes our file structure a little simpler.

While it does simplify our file section, I think it might get a little bit messy as I’d imagine it’s a pretty sizeable file. What do you think about just creating a subfolder?

The second change is to use underscores instead of camelCase in our filenames. Is this the right choice? Before we had a mix. I feel like we should at least have consistency.

Great! I was going to ask you to do this at some point during the refactor anyways. Could you apply this to the functions in non-Qt files as well?

The third change is to create another qt folder inside the layer folder and then move the layer specific qt files in there. I think it is cleaner to have all the layer related files together, and it will make it easier for people to understand what to do when they need to add new layers. Do people like this change?

Yeah, I think this makes a lot of sense in terms of the file structure.

A more extreme choice would be to get rid of the qt folder entirely and put all the qt stuff directly on the objects themselves. Do we want to discuss this as an option?

I think it’s cleaner/easier to maintain if it’s separate (and a core aspect of the API design is to hide Qt stuff anyways).

While it does simplify our file section, I think it might get a little bit messy as I’d imagine it’s a pretty sizeable file. What do you think about just creating a subfolder?

Yup, it was a long one! I've gone back now to just have 3 separate files (was 4 before) and no seperate folder, I think now it is a little cleaner.

Great! I was going to ask you to do this at some point during the refactor anyways. Could you apply this to the functions in non-Qt files as well?

I've tried to make all camelCase functions outside of Qt files now snake_case. I may have missed some, but will look out for it.

I think it’s cleaner/easier to maintain if it’s separate (and a core aspect of the API design is to hide Qt stuff anyways).

This makes sense. Right now we break that convention in the _viewer file in elements where we have some direct imports from PyQT - but I think that's my fault and I can try and fix that.
We also break the convention in _window. Is that ok though? Should _window live insider the qt folder instead?

I think a globals resources folder sounds better and when we scale we can
just categorize the resources into different subfolders.
On Sun, Dec 16, 2018 at 8:22 PM Nicholas Sofroniew<EMAIL_ADDRESS>wrote:

Also I now created a second icons folder inside the layers qt folder.
Does this make sense, or should we only have one globals icons folder not
living inside the qt folders at all but higher up?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/Napari/napari-gui/pull/90#issuecomment-447735371, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Ab0F0280kdyTElbb9B_8Zyz8fAmPNSdiks5u5zhDgaJpZM4ZVhc6
.

I'm going to wait until #88 to review this one, since they are both huge and I'm having trouble keeping track of what's in which one.

@jni waiting on this one makes sense. After we merge #88 I'll update this PR and then we can go forward from there

I have now made a global resources folder called icons at the gui level, and updated the manifest file.
I pulled out all Qt imports from _viewer and put them in qt/_viewer including code related to pyqt events. I think this is much cleaner.
Now only thing in elements folder that imports directly from PyQt and doesn’t have a corresponding file in the qt folder is _window. Should we change this by either putting the qt code in a separate file or moving this file to the qt folder?
My major question to the people reviewing the PR is - do we like the file / folder structure? It would be great to lock that down in this PR and then there's still a lot of refactoring individual files / moving some code from one file to another that I think we need to do.

I have made some fairly major updates trying to get us more in line with the design choices and architecture laid out in #92
Namely, I now pass the non-UI peer class to the constructer of the UI class which adds its non-UI peer as a property. I have done this for LayerList and QtLayerList, Dimensions and QtDimensions, etc.
All of the connections from the UI class to the non-UI class happens within the UI class now. Sometimes the UI class modifies the non-UI class directly, sometimes it calls methods on the non-UI class.
The non-UI classes now use the vispy event system to inform the UI classes when they need to update.
While the non-UI class has the UI class as a property under _qt these properties are almost never used (with some exceptions, including many times for the layer._qt case). When they are used, they are mainly used by non-UI classes.
There's almost certainly still quite a lot of cleaning up to do, but these changes hopefully move us in the direction we want to be going and hopefully are making things more simple instead of more complex.

I've also done some general cleaning up of the annotation code, trying to make as much of viewer and QtViewer agnostic to any details of the markers / image layer and instead pushing more specific code onto the layers themselves.

@kne42 thanks for the review - I've made some updates


VSCode regex search doesn't differenciate lowercase ([a-z]) and uppercase ([A-Z])

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.87.2 (Universal)
Commit: 863d2581ecda6849923a2118d93a088b0745d9d6
Date: 2024-03-08T15:21:31.043Z
Electron: 27.3.2
ElectronBuildId: 26836302
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin arm64 23.2.0
Steps to Reproduce:

Paste the following in an editor:

a
A

Search by regex: [a-z] (or [A-Z])
Results: Two results are found, but only one should be selected (the corresponding lowercase or uppercase)

It seems that this bug is 5 years old now, according to this closed issue. It was marked as a question and automatically closed by a bot. This is NOT a question but a bug report: trying the same regex on a regex debugger yields the expected solution (only one output selected).

toggle the match case button

Oh that works indeed ! However it makes no sense, the regex option should not use this setting (by definition of regexes)

it works pretty much the same as other regexes
/[a-z]/i


in-memory state component doesn' have the feature of state query

Now the implementation of in memory state #1326 has most of the state feature including etag, transactional, expire.
Yet state query is not not included since there is no requirement for this feature.
I create this issue to track it.
Help wanted!

Query API will not graduate to stable in state store.
We will be introducing a DocumentStore API, and only DocumenStore components will have a Query API in the future.
I will close this issue so that nobody spends their time and effort pursuing this implementation. Thanks.


release v0.18.0

[x] changelog

https://github.com/aspida/pathpida/releases/tag/v0.18.0
https://www.npmjs.com/package/pathpida/v/0.18.0


DatabaseVulnerabilityAssessmentRuleBaselinesClient always return "Default" as baseline

Bug Report

import path of package in question github.com/Azure/azure-sdk-for-go/services/preview/sql/mgmt/2017-03-01-preview/sql

SDK version v32.0.0 (Commit  7a9d276)

Specify the exact commit if possible; one way to get this is the REVISION
column output by dep status "github.com/Azure/azure-sdk-for-go.

output of go version:   go version go1.12 linux/amd64

What happened?

When calling the method CreateOrUpdate with the parameter baselineName=master in DatabaseVulnerabilityAssessmentRuleBaselinesClient it returns "Default" as baselines in the result.ID.

What did you expect or want to happen?
I would expect that the result.ID contains master as baselines.

How can we reproduce it?
Create a mssql database with vulnerability scanning enabled. Set any baseline for the master database.

Anything we should know about your environment.
No.

Additional Information
I already contacted the Azure support on this case and it seems to be a bug on the Azure REST API. So I'm not sure if a quick fix in the SDK is wanted in this case or if we just wait until the Azure REST API is fixed.

Hi,
Could not reproduce. Can you check if the issue is still happening?
Thanks,
Tal

Hi,
no Microsoft fixed this bug meanwhile.
Kind regards
Benjamin


Mutify.app page doesn't respond

I'd love to buy the Mutify app as this open source version doesn't work properly with all apps, but the mutify.app webpage doesn't work - I get 522 Connection timed out all the time.

Webpage is up


mark fabric flaky parity test

What does this PR do?
This test seems to be flaky from time to time as it depend on the machine's other allocation/usage

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Rerun won't work for standalone tests, because the decision of rerunning is not synchronized between processes. We either have to live with it or find a different solution.


[mesheryctl] Permission denied error while deploying adapters in docker environment

See mesheryctl Command Tracker for current status of commands.
on Meshery Dashboard in Settings->Adapters when deploying an adapter getting below the Permission denied error in logs.

and the user is unable to deploy and connect to adapters.
Current Behavior

Desired Behavior

Screenshots/Logs

Environment

Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Handbook

📚 mesheryctl Contributing Guide
📺 Beginner's guide to contributing to Meshery and mesheryctl
⌨ mesheryctl Command Tracker
⌨ Meshery CLI Commands and Documentation
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

See mesheryctl Command Tracker for current status of commands.
on Meshery Dashboard in Settings->Adapters when deploying an adapter getting below the Permission denied error in logs.

and the user is unable to deploy and connect to adapters.
Current Behavior

Desired Behavior

Screenshots/Logs

Environment

Host OS: Mac Linux Windows

Meshery Server Version: stable-v

Meshery Client Version: stable-v

Platform: Docker Kubernetes

Contributor Guides and Handbook

📚 mesheryctl Contributing Guide

📺 Beginner's guide to contributing to Meshery and mesheryctl

⌨ mesheryctl Command Tracker

⌨ Meshery CLI Commands and Documentation

🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack


Difference between //, m//, and rx// in regex

https://github.com/hankache/perl6intro/issues/135
What might be a good/quick way to explain the differences in the intro guide?

/ ... / declares a regex. If it's used in sink context or on the right of ~~ it is also run.

rx/ ... / is the same as / ... / except that rx can use alternative delimiters, eg. rx { ... }.

m/ ... / is the same as rx/ ... / except that it is always immediately run.

[12:55] <raiph> wander: yes. some adverbs apply *inside* the *declarations* of regexes, others apply to *matches* see https://docs.perl6.org/language/regexes#Matching_adverbs
[12:58] <wander> how about the difference between 'rx:g' and 'm:g'
[13:03] <raiph> m is a match operation that can take match adverbs; it just happens to include a regex declaration in its syntax
[13:04] <raiph> rx is a regex declaration that can't take match adverbs; it just happens to sometimes be immediately run if in sink context or rhs of ~~

https://github.com/rakudo/rakudo/blob/fff43fd709cd0ed9693a85d06242f0fcd9f55ba3/src/Perl6/Grammar.nqp#L3814-L3833
https://github.com/rakudo/rakudo/blob/fff43fd709cd0ed9693a85d06242f0fcd9f55ba3/src/Perl6/Actions.nqp#L8056-L8088

@raiph is your explanation in the docs? I couldn't find it by searching m// or rx//
I think I must have found it previously in a regex guide separate from the search bar.

@WildYorkies Searching for rx leads to the general language/regex page which explains this stuff starting at the section Adverbs.

I'm a bit late to the party, but FWIW here are some tickets:

RT#130363 [open]: ^[@LARRY] there's no match for Any aka /./ codegens differently from m/./
RT#131925 [open]: [BUG] [REGEX] Smartmatch against `m//` operator mishandles junctions

/ ... / declares a regex. If it's used in sink context or on the right of ~~ it is also run.

Also in Bool context.

Close this via 6dec94afbb06d1f265c3375
https://docs.perl6.org/language/regexes#Lexical_Conventions


Suggestion: Heightmap models and collisions and texturemaps

Heightmap - A grayscale image that is used to generate a model that is normally used as the ground in a 3D game.
Texturemap - Same size of the Heightmap image that is colored and each color channel (RGBA) represents a different texture to be painted onto the model allows mixing of textures because what texture is where is based on the color of the pixel at that point
In addition a Collision should also be generated from the Heightmap file as most of the time a heightmaps use is limited to the ground.

probably could have thought of a better way to word that

SilenceEngine, as it stands right now, is in a pre-mature state, and there are bugs (identified) in the core features like the SceneGraph. This will be done in 0.0.4a, as the primary goal of 0.0.3a is to provide Object Oriented Abstractions to the native libraries that LWJGL provides bindings to, making SilenceEngine easier to use than LWJGL, and at the same time, is as flexible as you can with pure LWJGL.
What you suggested is actually very good, I will have it implemented by the end of 0.0.4a release. The problem is, I had a lot of work on myself (very less contributors) so I had been giving first priority to the release of 0.0.3a with complete documentation. Just wanted to say what is happening here. It would be great if you could contribute, I will give proper credits for your work.

I'm putting things down as suggestions here because I forget things and am more experimenting with the engine atm. Also I was assuming that you wanted to get 0.0.3a fully ready and out before things that you have marked for 0.0.4a were started on

Your assumption is right, but the new scene graph is also marked for the 0.0.4a release. And there is nothing wrong in suggesting features, I do require suggestions. I just wanted to let you know the current state of the engine, and my plans for this release.

Closing this now as it is getting late for a new release. Will reopen them with a new milestone after release.


Update cairo-lang to 2.7.0

This PR updates cairo-lang to version 2.7.0.
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Current Status
All cairo-lang dependencies have been updated, including corelib's and scarb's version. The code has also been adapted to the new implementations.
Still to be solved
There are still some tests are not passing and need to be checked. Most of them fail due to deprecated features.

Codecov Report
Attention: Patch coverage is 90.25803% with 185 lines in your changes missing coverage. Please review.

Project coverage is 91.91%. Comparing base (1114cf2) to head (8404a2b).

Files
Patch %
Lines

src/libfuncs/bounded_int.rs
91.16%
44 Missing :warning:

src/libfuncs/cast.rs
87.43%
26 Missing :warning:

src/context.rs
15.38%
22 Missing :warning:

src/types.rs
68.11%
22 Missing :warning:

src/bin/cairo-native-run.rs
0.00%
14 Missing :warning:

src/executor.rs
12.50%
14 Missing :warning:

src/values.rs
27.77%
13 Missing :warning:

src/bin/cairo-native-dump.rs
0.00%
8 Missing :warning:

src/starknet.rs
77.77%
8 Missing :warning:

src/libfuncs/array.rs
99.29%
4 Missing :warning:

... and 6 more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
+ Coverage   91.88%   91.91%   +0.03%
==========================================
  Files         121      122       +1
  Lines       32821    34239    +1418
==========================================
+ Hits        30157    31472    +1315
- Misses       2664     2767     +103

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Make snackbar more resilient to text overflow

For a single-line snackbar, we could make it so that the text will not cause line breaks (and show an ellipses instead, perhaps). For multiline, we'd have to trust the user not to put in arbitrarily long strings of text.
Some browsers also support clamping to a certain number of lines, so we can progressively enhance for that as well

Superceded by https://github.com/material-components/material-components-web/issues/11


Add php7.3 to travis matrix

Question
Answer

Bug fix?
no

New feature?
no

BC breaks?
no

Deprecations?
no

Tests pass?
-

Fixed tickets
-

License
MIT

Doc PR
-

Description
Add php7.3 to travis testing matirx

Thanks you for the contribution.
But I will move all ci stuff to github actions.


Dockerfile, manifest and helm file annotations

Added change to include following to annotations:

Manifest files path
Helm chart path
For each image:

Dockerfile path
CR server name

Wrong branches, hence closing


JPA - persistence.xml overridable by config

Environment Details

Helidon MP

Problem Description
It would make testing with JPA more user-friendly if persistence.xml was overridable by config, for example:
@HelidonTest
@AddConfig(key="oracle.ucp.jdbc.PoolDataSource.ds1.URL",
           value = "jdbc:h2:mem:test;MODE=Oracle;INIT=runscript from 'classpath:/META-INF/init_script.sql'")
@AddConfig(key="oracle.ucp.jdbc.PoolDataSource.ds1.connectionFactoryClassName",
           value = "org.h2.jdbcx.JdbcDataSource")
@AddConfig(key="oracle.ucp.jdbc.PoolDataSource.ds1.user", value = "sa")
@AddConfig(key="oracle.ucp.jdbc.PoolDataSource.ds1.password", value = "${EMPTY}")

@AddConfig(key="jpa.pu1.hibernate.dialect", value = "org.hibernate.dialect.H2Dialect")
@AddConfig(key="jpa.pu1.hibernate.show_sql", value = "true")
@AddConfig(key="jpa.pu1.hibernate.hbm2ddl.auto", value = "update")
class MainTest {

Something like this:
Index: integrations/cdi/jpa-cdi/src/main/java/io/helidon/integrations/cdi/jpa/EntityManagerFactories.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/integrations/cdi/jpa-cdi/src/main/java/io/helidon/integrations/cdi/jpa/EntityManagerFactories.java b/integrations/cdi/jpa-cdi/src/main/java/io/helidon/integrations/cdi/jpa/EntityManagerFactories.java
--- a/integrations/cdi/jpa-cdi/src/main/java/io/helidon/integrations/cdi/jpa/EntityManagerFactories.java	(revision 2366fbc90dd0fe551ff69cf7ba217e1716e01729)
+++ b/integrations/cdi/jpa-cdi/src/main/java/io/helidon/integrations/cdi/jpa/EntityManagerFactories.java	(date<PHONE_NUMBER>722)
@@ -24,7 +24,7 @@
 import java.util.Set;
 import java.util.logging.Level;
 import java.util.logging.Logger;
-
+import java.util.stream.StreamSupport;
 import jakarta.enterprise.inject.Any;
 import jakarta.enterprise.inject.Default;
 import jakarta.enterprise.inject.Instance;
@@ -35,6 +35,8 @@
 import jakarta.persistence.spi.PersistenceProvider;
 import jakarta.persistence.spi.PersistenceUnitInfo;
 import jakarta.persistence.spi.PersistenceUnitTransactionType;
+import org.eclipse.microprofile.config.Config;
+import org.eclipse.microprofile.config.spi.ConfigProviderResolver;

 /**
  * A utility class for acquiring and creating container-managed {@link
@@ -186,6 +188,15 @@
             }
         }

+        String prefix = "jpa." + pu.getPersistenceUnitName() + ".";
+        Config config = ConfigProviderResolver.instance().getConfig();
+        StreamSupport.stream(config
+                        .getPropertyNames().spliterator(), false)
+                .filter(s -> s.startsWith(prefix))
+                .forEach(k -> properties.put(k.replaceFirst(prefix, ""),
+                        config.getOptionalValue(k, String.class).orElse("")));
+
+
         final EntityManagerFactory returnValue = persistenceProvider.createContainerEntityManagerFactory(pu, properties);
         assert returnValue != null;
         assert returnValue.isOpen();

Notes to self.
On one end of the spectrum we have PersistenceUnitInfo, which the CDI/JPA integration already uses internally. If you put a CDI bean implementing this on the classpath, yours will be used and you can do whatever you want. This is the power tool.
On the other end of the spectrum we do what the specification requires, which is back a "default" PersistenceUnitInfo implementation with META-INF/persistence.xml which is supposed to act as the partial or complete source of truth for the persistence archive. The specification and Java/Jakarta EE deployment descriptors deliberately does not permit variable and property expansion. This is the My First Sony™ tool that ships by default.
What is being proposed is what every other framework does to one degree or the other, which is to ship with a PersistenceUnitInfo that harvests information from any of several potential sources of information such that if you happen to be looking at a persistence.xml you don't know whether it is partially authoritative, fully authoritative or even consulted.
Further, some persistence providers (Hibernate) source some of their configuration information from proprietary sources first, then override them from persistence.xml.  And vice versa.
Because "everyone else is doing it" we probably should too. We are fortunate in that we are backed here by MicroProfile Config, so can just punt to it for values to route to the innards of a custom PersistenceUnitInfo implementation. This should permit the use cases as designed. Will it additionally maybe be trumped by something like hibernate.properties anyway? Maybe? I'm not sure yet; haven't dug deep yet.
Of note here as well is that a MicroProfile Config ConfigSource may return an empty set from its getPropertyNames() method and still "answer the phone" for individual properties. So ideally we would not base these kinds of "probing" operations ("get me the property value for x.y.z") on MicroProfile Config's notoriously unreliable "report all values if you feel like it" APIs (getPropertyNames(), getProperties()).
Finally we can start by allowing the replacement of these specific EntityManagerFactory properties, as requested above, but they will rapidly make no sense unless we also allow effectively substituting the entire contents of a PersistenceUnitInfo as well.
Given all the uncertainty for the operations member/deployer staring at a persistence.xml file and wondering to what degree it is relevant, we will also need to output a metric ton of logging to ensure it is as clear as can be where the heck information is coming from for any given deployment, since this facility will exist to make that as abstract as possible.
Finally it should be noted that in container-mode JPA (which our integration supports), it is a requirement that a META-INF/persistence.xml exist. We will deliberately be relaxing this hard requirement.

This is partially supported, in a way, by #7719, which fires a CDI event containing a PersistenceUnitInfo right before it goes into service, regardless of where it came from. This means a CDI observer can watch for it, and alter the return value of the getProperties method however it likes. (This is in fact how the Hibernate integration works.) One such observer, I guess, could be a "please override these configured properties with other configured properties" observer.

See also #9131.

@ljnelson Jakarta Persistence 3.2 has new API to create EntityManagerFactory without the need of persistence.xml.
Check https://javadoc.io/static/jakarta.persistence/jakarta.persistence-api/3.2.0/jakarta.persistence/jakarta/persistence/Persistence.html#createEntityManagerFactory(jakarta.persistence.PersistenceConfiguration) and https://javadoc.io/static/jakarta.persistence/jakarta.persistence-api/3.2.0/jakarta.persistence/jakarta/persistence/PersistenceConfiguration.html
It's possible to move whole persistence.xml content to config and use this new API without any CDI magic. And if you need CDI, you may use the same API to initialize injected EntityManagerFactory / EntityManager.
The only problem I see here is, that JPA provider must be Jakarta Persistence 3.2 compliant. Currently only EclipseLink was already released. Hibernate is available only as 7.0.0.Beta1.

That's right. It's in 3.2, and my read (perhaps I'm wrong; haven't looked deeply yet?) is that it's for application-mode JPA. The default scope is still transactional if I also read correctly (not entirely sure how the standard will make application-mode JPA work with JTA by default but maybe that's supported by the spec officially now somehow). But stuff like @PersistenceContext (container-managed) has slightly different rules. Anyway, it's a big change. I'd like to start by delivering the solution for this issue in pieces first, and then tackling 3.2 as an upgrade (whatever that might mean).

We had some discussion on Helidon Data meeting and we will be facing similar issue too.
Currently we depend on Jakarta Persistence 3.1 and can't relay on 3.2 API. As you already mentioned above, the only API we may relay on is the old method in PersistenceProvider SPI:
EntityManagerFactory createContainerEntityManagerFactory(PersistenceUnitInfo info, Map<?, ?> map);

Unfortunately persistence.xml is a problem for us because our goal is to have runtime configuraiton in Helidon Config. So the only way out seems to be our own version of PersistenceUnitInfo with content based on 'Config'.
@ljnelson Looks like I will have to implement it and maybe we can work together to get this issue resolved too.
I got EclipseLink anf Hibernate sources here. I can't find PersistenceUnitInfo implementation in Hibernate. Well, there are few classes for tests, but nothing that looks like part of public API.
Eclipselink has org.eclipse.persistence.internal.jpa.deployment.SEPersistenceUnitInfo and it may be a good starting point for us.
I already made changes to this class in EclipseLink master to support the JPA 3.2 feature mentioned above. So I already have version that works without persistence.xml.
Next step is to extract it from EclipseLink completely and put it into Helidon and replace PersistenceConfiguration with some Helidon style Config blueprint.

In case it helps, Helidon's existing JPA integration is already built entirely around PersistenceUnitInfo as a CDI bean, so as long as you can make one, however you want to make it, backed by persistence.xml or not, the JPA integration will respect it. You can start with our PersistenceUnitInfoBean if you like.
Anyway, if a user supplies her own PersistenceUnitInfo CDI bean, it is used instead of ours. Ours, of course, is backed by persistence.xml, but of course does not have to be. I hope I've understood the things you're talking about.


Create a public facing saturn status page

This ticket was created out of Spike #767.
Because saturn uses so many of the same backend services as Firecloud, we would like to start off with a status page that points to the same place as status.firecloud.org. The process for doing so is as follows:
First, speak with @bradtaylor about the domain name for terra/saturn's status page. After we have a domain name, reach out to DevOps about pointing it to the firecloud status page.

status.terra.bio

If low level of effort, recreate status page with more recent pingdom. If that's hard, point at FC's.

Note: it looks like we can only have one custom domain for that page, which is currently status.firecloud.org, so we may just need to link to that for now. Also, the content of that page doesn't seem very customizable.

Given the above restrictions, we're not going to take any action on this for now. Until we migrate the domain in the future, status.firecloud.org will serve as Terra's status page


[Bug]: Experimental Agents with custom endpoints breaking if return type not string

What happened?
After my fix in PR #4324, I tried my endpoint that returns a boolean, it was executed on my endpoint successfully but the assistant threw the error in the screenshot
Steps to Reproduce

Add an action to the assistant that returns a boolean
tell the assistant to execute it
it will run till the end, execute it, but fail with the provided error

This is the action I was trying to run
openapi: 3.0.3
info:
  title: Execute action on Local machine
  version: '1.0.0'
servers:
  - url: http://localhost:3000
paths:
  /gateway/execute:
    post:
      summary: Execute action on Local machine
      requestBody:
        required: true
        content:
          application/json:
            schema:
              type: object
              properties:
                data:
                  type: string
                  description: The action to execute.
              required:
                - data
      responses:
        '200':
          description: Successful execution
          content:
            application/json:
              schema:
                type: boolean
                description: A boolean indicating the success or failure of the execution.
        '400':
          description: Bad request
        '500':
          description: Internal server error
components:
  schemas:
    ExecuteSqlParams:
      type: object
      properties:
        data:
          type: string
      required:
        - data

What browsers are you seeing the problem on?
Chrome
Relevant log output
No response
Screenshots

Code of Conduct

[X] I agree to follow this project's Code of Conduct

See this message: https://github.com/danny-avila/LibreChat/discussions/4303#discussioncomment-10815563


Wrong SyntaxError: Parenthesized pattern

On 4.0.8 (and master), acorn throws SyntaxError for the following code, but it's valid code.
(x) = 1;

If the LeftHandSideExpression is an ObjectLiteral or an ArrayLiteral, it disallows parenthesized. However, otherwise it allows parenthesized.

It is a Syntax Error if LeftHandSideExpression is either an ObjectLiteral or an ArrayLiteral and the lexical token sequence matched by LeftHandSideExpression cannot be parsed with no tokens left over using AssignmentPattern as the goal symbol.
It is an early Reference Error if LeftHandSideExpression is neither an ObjectLiteral nor an ArrayLiteral and IsValidSimpleAssignmentTarget of LeftHandSideExpression is false.

https://www.ecma-international.org/ecma-262/7.0/#sec-assignment-operators-static-semantics-early-errors

<IP_ADDRESS> Static Semantics: IsValidSimpleAssignmentTarget

ParenthesizedExpression: ( Expression )

Return IsValidSimpleAssignmentTarget of Expression.

https://www.ecma-international.org/ecma-262/7.0/#sec-grouping-operator-static-semantics-isvalidsimpleassignmenttarget

"use strict"

const acorn = require('./dist/acorn')
const ast = acorn.parse(`
(x) = 1;
`.trim(), {ecmaVersion: 7})

console.log(JSON.stringify(ast, null, 4))

$ node test.js
C:\Users\t-nagashima.AD\Documents\GitHub\acorn\dist\acorn.js:2446
    throw err
    ^

SyntaxError: Parenthesized pattern (1:0)
    at Parser.pp$4.raise (C:\Users\t-nagashima.AD\Documents\GitHub\acorn\dist\acorn.js:2444:15)
    at Parser.pp.checkPatternErrors (C:\Users\t-nagashima.AD\Documents\GitHub\acorn\dist\acorn.js:625:27)
    at Parser.pp$3.parseMaybeAssign (C:\Users\t-nagashima.AD\Documents\GitHub\acorn\dist\acorn.js:1717:12)
    at Parser.pp$3.parseExpression (C:\Users\t-nagashima.AD\Documents\GitHub\acorn\dist\acorn.js:1690:21)
    at Parser.pp$1.parseStatement (C:\Users\t-nagashima.AD\Documents\GitHub\acorn\dist\acorn.js:761:47)
    at Parser.pp$1.parseTopLevel (C:\Users\t-nagashima.AD\Documents\GitHub\acorn\dist\acorn.js:656:25)
    at Parser.parse (C:\Users\t-nagashima.AD\Documents\GitHub\acorn\dist\acorn.js:529:17)
    at Object.parse (C:\Users\t-nagashima.AD\Documents\GitHub\acorn\dist\acorn.js:3309:39)
    at Object.<anonymous> (C:\Users\t-nagashima.AD\Documents\GitHub\acorn\test.js:4:19)
    at Module._compile (module.js:571:32)

Attached patch (included in 4.0.9) should help. Thanks for digging out the relevant parts of the spec.

Thank you!


Not showing which view is broken

It shows the exception message but doesn't say which view had the exception.

e.g:  if there is some problem with a view, it shows the error:
CommandError: Failed to render view: 'total_count'

There was a problem in a line which includes total_count, it's not a view name.
Maybe the more appropriate error would be:
CommandError: Failed to render view: 'viewname'
A problem with the line `line no: exception message`

Hi sks444,
Thanks for the issue and sorry for taking ages to respond. I'm relatively happy with how verbose the error messages are at the moment, it should display a full trace of the issue which includes the line numbers which make finding where the error occurred pretty easy.
If you want to submit a pull request for more verbose errors if you would find them helpful I'd be happy to review it.
Cheers.


feat: add 2 columns layout for medium size media

Add a 2 columns layout for medium size media (between 1510px and 1130px). In this layout, right collapses under center. Below is a simple illustration.
-----------------
| left | center |
|      | right  |
-----------------

Close https://github.com/jackyzha0/quartz/issues/455

could you attach a video demo showing the layout and it adapting during resize?

tested this locally, will need some more fixing to get the padding right, lmk if you have time to fix this

closing due to inactivity


1.5.2

Version of Boardwalk:latest
Version of Android:4.2.3
Device model:lenovo yoga tablet 2
Description of the problem:I can not have version 1.5.2.

a) We don't know the 'latest' version of Boardwalk you were using
b) Only Minecraft 1.7 and 1.8 are currently supported. AFAIK there is little to nothing you can do in 1.5.2 you cannot do in 1.7 or 1.8.


__toString() method causes conversion error in Illuminate\Validation

Laravel Version
10.0
PHP Version
8.1
Database Driver & Version
MySQL
Description
When using the following validation:
Rule::exists('permissions', 'uuid')->where(['disabled_at' => null, 'client_id' => $clientId])

A conversion error occurs when the value does not satisfy the rule, causing the system to return an error along with a stack trace.
This issue arises because the formatWheres() method in the Illuminate\Validation\Rules\DatabaseRule trait does not correctly process the $this->wheres attribute when multiple conditions are present.

Sorry for my bad English 🫤
Steps To Reproduce
To reproduce, simply execute the __toString() method on a Rule::exists() object that contains a where clause in array format:
$rule = Rule::exists('permissions', 'uuid')->where(['disabled_at' => null, 'client_id' => $clientId]);
$rule->__toString();

Hey there,
Unfortunately we don't support this version of the library anymore. Please check out our support policy on which versions we are currently supporting. Can you please try to upgrade to the latest version and see if your problem persists? If so, please open up a new issue and we'll help you out.
Thanks!


Create user metrics from Mongo

@SylviaCHS
Hi Sylvia,
User metrics are now available on the database. They are stored as a dictionary with key entries for each process method the user could call. For instance
"Histogram Equalization": [2, 0.9]
The first number is the number of times the method has been called. The second is the mean latency of the method.


Beta Release

@albinmedoc A few people in Discord are asking for edit functionality of the pre-existing pages? What do you reckon?

@albinmedoc A few people in Discord are asking for edit functionality of the pre-existing pages? What do you reckon?

These pages are conditional depending on whether you have Plex/Jellyfin and Discord.
It would be possible to edit these by putting them in a separate database table and have them prepopulated with the English hardcoded version (how they look today).
What we lose with this implementation is multilingualism. Onboarding pages can only be in one language at a time.
I think this sounds like a very good idea, which would have worked well on my Wizarr instance.
Give me a GO and I'll start development

@albinmedoc A few people in Discord are asking for edit functionality of the pre-existing pages? What do you reckon?

These pages are conditional depending on whether you have Plex/Jellyfin and Discord. It would be possible to edit these by putting them in a separate database table and have them prepopulated with the English hardcoded version (how they look today).
What we lose with this implementation is multilingualism. Onboarding pages can only be in one language at a time.
I think this still sounds like a very good idea.
Give me a GO and I'll start development

Feel free! Free reign, I think the language for the instance will be the same for the whole server regardless. So the content would be written in the language of the admin no doubt.
What Wizarr is made for is for easy management of your friends and family, the only issue you'd have with multi-language support is if you ran a big share or something of the sorts, which we don't want to openly support. So for the most part, the language across the server will be the same.
I think you're absolutely fine to crack on, I don't see no issues. 😀

@albinmedoc did you want me to merge this PR in now to get these bugs out on the beta or did you want me to wait for the onboarding amends?

Go ahead and merge this to beta.
I'm having a little trouble getting all the onboarding pages editable. Not sure how long it will take.


How do i query with before and after value?

I'm trying to query subreddit posts after post.
Looking at the code it says I should use
        public Listing<T> GetListing<T>(string url, int maxLimit = -1, int limitPerRequest = -1) where T : Thing         {             return new Listing<T>(this.WebAgent, url, maxLimit, limitPerRequest);         }
I'm guessing my after value should be part of the url, my question is what is the proper format of the input url value since some params are appended internally?

You use GetListing to get a listing of, say, posts, you use the https://www.reddit.com/r/all/?after=t3_7uc2sc and then you throw in your input params, https://github.com/reddit-archive/reddit/wiki/JSON#listing gives a good idea

Thank you,


Search functionality for CP and PLEX

I'm using the 'Search Table' function very often since I discovered it:). To be honest, it's a really powerful tool within HTPC-Manager. At the moment, the search function is not yet implemented for the CP and PLEX module. Would be great to have a search function for this modules as well.

The plex module is the most advanced one. It should work there :), it does not work in cp (no table to search)

You're right the plex module is working. However, the placeholder name (Default 'Search') changes to 'Search table' if a search is possible. For the plex module, the name does not change.
Furthermore, for HP and sickrage I can hit enter, but nothing happens (correct behaviour, because i'm just searching the table in that case). For plex it brings me to the newznab search module if I hit enter (not correct I think?).

It will show search table is there is a table in that module and I have activated it. For other modules it might not change (plex, kodi)
Can can also do stuff like genre=action in the plex module. Pressing enter should not search for nzbs.

Unfortunately, hitting enter does search for nzbs...
I tried, genre=action and genre=comedy, but both returns me with zero results, although I'm 100% sure I have some movies of this type of genre in my lib.

Fixed the enter thing, hm it works here :(

@kooimens try hitting enter after the last char.

Thanks, working. Although, if I hit enter once it will bring show the result again.

Anyway I can fix that, what I meant was test the genre. Remember that old content isn't removed and there also s protection against the search function to crap out if it contains =!<>. Best way to test before I fix the issue with old content is to copy paste genre=action into the search field.

Regarding you request for cp, I don't think it's supported by the api, but I'll try to hack something together, if it's fast enough I'll merge it.

Hitting enter just sounds awesome:D. Hmm, tried copy paste genre=action, but no change in results. I use dutch language in the plex module, maybe that's the problem?

dunno, i didnt think so.

I have added search for wanted and library.
You can do:
16 blocks
genres=action
plot=cake
if the value your looking for you have to use logical operators
rating<=9
year!=2010
etc

I also fix the enter thing

Nice! My findings after some tests:

PLEX - music. The 'enter thing' is still there when searching artists.
PLEX - music. Search is not working when searching songs.
PLEX - all. Noticed a new 'enter thing', but now it occurs when spamming backspace. Doing a search and then bringing back the search field to null with backspace is working, every next backspace hit returns the same problem as with the enter thing.
PLEX - all. The name of the search placeholder is 'Search'

Dont use music so that slippes my mind
Dunno if i cba with fixing it
I don't get it. can you take a ss
Forgot that

As you can see, all the movies are there twice. When I hit the print-screen button, all the movies where there tripled. Another hit after that would bring up four identical versions of each movie, and so on...


[Bug]: When updating groups, all the users in the IdP group are not reflecting in Appsmith Group

SubTasks
With the scimgateway version 4.5.5, when syncing groups, all the users from the IdP group are not getting reflected in the Appsmith group.

Hey team! Please add your planning poker estimate with Zenhub @nsarupr @srix

There has been an additional fix provided by the Author of the Repo. We need to test whether it fixes the issue of groups being updated properly.


Break firmly away from httplib

Ok, this new major commit series breaks firmly away from httplib. It introduces a brand new connection class that is vastly stripped down compared to what httplib offered, including a very limited set of functionality. It rewrites that connection to use selectors rather than blocking socket I/O, enabling us to abort request sending for early responses (a regularly requested feature).
It also allows us to begin blasting through the code removing stuff, which is a huge win.
This is something that I'd like people to look over at a high level. Obviously, detailed review is difficult, but another set of eyes on this would be really helpful.

As a point of pride I'd like to note that this commit manages to barely introduce any lines of code. This is a pretty big win!

Heading on vacation tomorrow, so I'll have a chance to go over this (and also attend to my own work) at that point in time.

Codecov Report

Merging #1108 into v2 will increase coverage by 1.08%.

@@            Coverage Diff             @@
##               v2    #1108      +/-   ##
==========================================
+ Coverage   96.15%   97.24%   +1.08%
==========================================
  Files          21       22       +1
  Lines        2083     1958     -125
==========================================
- Hits         2003     1904      -99
+ Misses         80       54      -26

Impacted Files
Coverage Δ

urllib3/util/connection.py
100% <ø> (ø)
:white_check_mark:

urllib3/connectionpool.py
100% <100%> (+0.41%)
:white_check_mark:

urllib3/util/ssl_.py
100% <100%> (ø)
:white_check_mark:

urllib3/response.py
100% <100%> (+0.56%)
:white_check_mark:

urllib3/util/response.py
100% <100%> (ø)
:white_check_mark:

urllib3/contrib/socks.py
100% <100%> (ø)
:white_check_mark:

urllib3/poolmanager.py
100% <100%> (ø)
:white_check_mark:

urllib3/base.py
100% <100%> (ø)

urllib3/exceptions.py
100% <100%> (ø)
:white_check_mark:

urllib3/sync_connection.py
100% <100%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb05a6...ddc0e22. Read the comment docs.

:tada:

Look at all that code coverage. Woooooo!
So, when I merge this I have a big, big OmniFocus project full of cleanups, but this puts us in a much nicer place.
My goals include breaking up a bunch of functions so they can easily be overridden with async versions (i.e. moving most of the work out to helper functions), propagating the Request/Response objects higher up the call stack (e.g. having them eventually be created by the PoolManager), and then we get onto the meaty stuff. Most notably, I want to reconsider our use of "timeouts" to have them instead be "deadlines": that is, we wait no more than n seconds to complete a connect or a read, regardless of how many I/O ops it takes.
But yes, it's 🎉  time!

@Lukasa Sounds like a good plan. It would be nice if certain parts of this could be turned into issues for the community to tackle but I understand that these types of changes need to be fairly monolithic. :)

I think they absolutely can. I take it it was the timeout bit that caught your attention? ;)

Oh nothing in particular! Just don't want you to feel like you have to do all the work yourself. :) I've got plenty just trying to complete my already open PRs here in addition to all the other OS I do.


feat: adds more publish-aware actions to cache-audit

Another contribution to #334
I investigated the Github Marketplace along with public Github orgs out there to improve a a bit the list of publisher-like Actions. Added Actions from Docker, GCP, AWS, Azure and a few popular ones used to publish binaries to Github releases.
Should we document this in the official docs, maybe?

Should we document this in the official docs, maybe?

Makes sense to me, although I'm not sure where the best place for it to live is -- any thoughts?


[WIP] Adding 24px icons

[WIP] - Adding support for 24px icons

@stnrd you can create a DRAFT PR :)

I still need to do some work on this PR. At the moment the newly 24px icons are ignored in the build process. I am not sure yet how to expose them in the resulting npm package yet. Any ideas?

I still need to do some work on this PR. At the moment the newly 24px icons are ignored in the build process. I am not sure yet how to expose them in the resulting npm package yet. Any ideas?

1st idea

create new variants at : https://github.com/stnrd/healthicons/blob/9161da0a6cc7c513b12353ab7c68a7df62e4d460/bin/build/index.js#L13

const iconsVariants = ["filled", "outline", "filled-24px", "outline-24px"];

But this will create new folders with all 48px icons and ONLY with 24px icons:

DIR
24px
48px

2nd idea

find the 24px icon and create icon-name-24px file icon, e.g.:  Body.js and Body24px.js

Thanks for you input - I was thinking of the first idea as well. Doing the second one is quite a change in the build process and the first one is only adding the new 24px variants and exposing them with he packages package.json. I am implementing it now.


Removing PathSemiMasker unnecessary mask node

Description
As the title suggest.
Contributor agreement

[x] I have read and agree to the Contributor Agreement.

Done


No photos appear in Photos (DEMO) app w/ only Twitter connected

This seems odd

I just did this today from scratch and had mine show up, maybe someone
else can reproduce either way?
On Thu, Feb 9, 2012 at 10:29 PM, Merci Victoria Grace
<EMAIL_ADDRESS>wrote:

This seems odd

Reply to this email directly or view it on GitHub:
https://github.com/LockerProject/Locker/issues/783

Reproduced, seems there's none of my own tweets pulled in: https://me.sandbox.singly.com/Me/twitter/getCurrent/tweet?limit=10

Wrong url, it's https://me.sandbox.singly.com/Me/twitter/getCurrent/tweets?limit=10 and they're there now, it just takes a LONG time to fetch them, I have photos now too.  I'm going to close this and opened #785 as it's the real problem.


Merge Colin's commits back into the main repo

Colin (@cdomoney-veracode) has made a number of commits and PR with fixes (thx :)  ) that where applied into the Fork (vs the upstream repo)

This can be seen by this graph (note how the PRs are going into his fork)

Here is how to create the PR:

go to the fork's Pull Request page: https://github.com/cdomoney-veracode/Book_SecDevOps_Risk_Workflow/pulls and click on the New pull request green button

click on 'Create pull request' green button

enter a message and click on the 'Create pull request' green button

that's it

That pull request is now on the queue to be reviewed and accepted

done, comments PR merged


Exception when connecting

As of 1.6.0-DEV & spongeforge-1.11.2-2282-6.1.0-BETA-2357, an exception is raised when players connects to the server:
[18:29:31] [Server thread/ERROR] [Sponge]: Could not pass ClientConnectionEvent$Join$Impl to Plugin{id=totaleconomy, name=Total Economy, version=1.6.0-DEV, description=All in one economy plugin for Minecraft/Sponge, source=/home/mischief/./plugins/TotalEconomy-v1.6.0-DEV.jar}
java.lang.NullPointerException
>       at java.math.BigDecimal.<init>(BigDecimal.java:806) ~[?:1.8.0_121]
>       at com.erigitic.main.TotalEconomy.getStartingBalance(TotalEconomy.java:348) ~[TotalEconomy.class:?]
>       at com.erigitic.config.TEAccount.getDefaultBalance(TEAccount.java:80) ~[TEAccount.class:?]
>       at com.erigitic.config.AccountManager.getOrCreateAccount(AccountManager.java:154) ~[AccountManager.class:?]
>       at com.erigitic.main.TotalEconomy.onPlayerJoin(TotalEconomy.java:190) ~[TotalEconomy.class:?]
>       at org.spongepowered.common.event.listener.JoinListener_TotalEconomy_onPlayerJoin24.handle(Unknown Source) ~[?:?]
>       at org.spongepowered.common.event.RegisteredListener.handle(RegisteredListener.java:95) ~[RegisteredListener.class:1.11.2-2282-6.1.0-BETA-2357]
>       at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:314) [SpongeModEventManager.class:1.11.2-2282-6.1.0-BETA-2357]
>       at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:296) [SpongeModEventManager.class:1.11.2-2282-6.1.0-BETA-2357]
>       at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:341) [SpongeModEventManager.class:1.11.2-2282-6.1.0-BETA-2357]
>       at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:329) [SpongeModEventManager.class:1.11.2-2282-6.1.0-BETA-2357]
>       at org.spongepowered.common.SpongeImpl.postEvent(SpongeImpl.java:192) [SpongeImpl.class:1.11.2-2282-6.1.0-BETA-2357]
>       at net.minecraft.server.management.PlayerList.initializeConnectionToPlayer(PlayerList.java:1617) [mt.class:?]
>       at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.completeServerSideConnection(NetworkDispatcher.java:262) [NetworkDispatcher.class:?]
>       at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.access$100(NetworkDispatcher.java:73) [NetworkDispatcher.class:?]
>       at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:211) [NetworkDispatcher$1.class:?]
>       at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:287) [er.class:?]
>       at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:180) [mh.class:?]
>       at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:743) [MinecraftServer.class:?]
>       at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:384) [lh.class:?]
>       at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:624) [MinecraftServer.class:?]
>       at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482) [MinecraftServer.class:?]
>       at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121]

any chance we get a 1.11 version of the plugin?

Total Economy will be updated for 1.11. Because this error occurred on a build that Total Economy was not made for, there's a good chance it is caused by that.

Sounds like we need to find another economy plugin I guess

@LemADEC Here's an updated version that was tested on 1.11.2. No error was encountered so it should be fixed. Let me know how it works for you. Thanks.
https://github.com/Erigitic/TotalEconomy/releases/tag/v1.6.0-DEV

Issue remains:
[20:25:02] [Server thread/ERROR] [Sponge]: Could not pass ClientConnectionEvent$Join$Impl to Plugin{id=totaleconomy, name=Total Economy, version=1.6.0-DEV, description=All in one economy plugin for Minecraft/Sponge, source=/home/mischief/./plugins/TotalEconomy-1.6.0-alpha.6.jar}
java.lang.NullPointerException
>       at java.math.BigDecimal.<init>(BigDecimal.java:806) ~[?:1.8.0_121]
>       at com.erigitic.main.TotalEconomy.getStartingBalance(TotalEconomy.java:315) ~[TotalEconomy.class:?]
>       at com.erigitic.config.TEAccount.getDefaultBalance(TEAccount.java:80) ~[TEAccount.class:?]
>       at com.erigitic.config.AccountManager.getOrCreateAccount(AccountManager.java:165) ~[AccountManager.class:?]
>       at com.erigitic.main.TotalEconomy.onPlayerJoin(TotalEconomy.java:194) ~[TotalEconomy.class:?]
>       at org.spongepowered.common.event.listener.JoinListener_TotalEconomy_onPlayerJoin24.handle(Unknown Source) ~[?:?]
>       at org.spongepowered.common.event.RegisteredListener.handle(RegisteredListener.java:95) ~[RegisteredListener.class:1.11.2-2282-6.1.0-BETA-2357]
>       at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:314) [SpongeModEventManager.class:1.11.2-2282-6.1.0-BETA-2357]
>       at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:296) [SpongeModEventManager.class:1.11.2-2282-6.1.0-BETA-2357]
>       at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:341) [SpongeModEventManager.class:1.11.2-2282-6.1.0-BETA-2357]
>       at org.spongepowered.mod.event.SpongeModEventManager.post(SpongeModEventManager.java:329) [SpongeModEventManager.class:1.11.2-2282-6.1.0-BETA-2357]
>       at org.spongepowered.common.SpongeImpl.postEvent(SpongeImpl.java:192) [SpongeImpl.class:1.11.2-2282-6.1.0-BETA-2357]
>       at net.minecraft.server.management.PlayerList.initializeConnectionToPlayer(PlayerList.java:1617) [mt.class:?]
>       at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.completeServerSideConnection(NetworkDispatcher.java:262) [NetworkDispatcher.class:?]
>       at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher.access$100(NetworkDispatcher.java:73) [NetworkDispatcher.class:?]
>       at net.minecraftforge.fml.common.network.handshake.NetworkDispatcher$1.func_73660_a(NetworkDispatcher.java:211) [NetworkDispatcher$1.class:?]
>       at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:287) [er.class:?]
>       at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:180) [mh.class:?]
>       at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:743) [MinecraftServer.class:?]
>       at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:384) [lh.class:?]
>       at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:624) [MinecraftServer.class:?]
>       at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:482) [MinecraftServer.class:?]
>       at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121]

Looks like you need to remake your main configuration file. The main config was changed with this recent version. Just remove it then restart the server and you should be good to go.

ok, it works now, thanks!

It looks like I need to apologize for not reporting an issue I discovered and fixed in my local workspace.
That issue occurs because TotalEconomy doesn't use fallback values on some occasions when reading from the config.
In this case #getNode("currency", "startbalance").getString() reads null (which cannot be turned into a BigInteger) because of the plugin using another path since one of the last updates and not re-initializing the configuration due to its existence therefore the value exists only in its old location and cannot be read from the new one.

I feel like notifying the server owner of an outdated configuration file would be more helpful in order to avoid this issue, and others that might arise from an outdated config, constantly occurring. Thoughts?

There's no warranty the server owner will catch the issue unless you do a forced crash or cancel the plugin loading up. Doing so would prevent to see the updated file to do the conversion, forcing to do 2 additional server restarts to fix it.
Hence, in my opinion, converting the previous key to the new one is the preferred way.

@Erigitic An idea would be the following;

Explicit notices in ChangeLogs (stating what changed) should suffice since administrators are obligated to read those
Integer identifying the configuration version (when syntax changes build no. goes up). This way we can notify server owners of a change in case they missed the former
Fallback (supported by Configurate) values to prevent the plugin from throwing exceptions OR refusing to load the plugin when the configuration version doesn't match.

@LemADEC In my opinion (and probably also the of many server administrators) when updating any plugin ChangeLogs have to be read in order to be aware of any changes in behavior or even dependencies.
There's no excuse for just blindly downloading a jar with a higher version and then complaining about not knowing stated changes.

@MarkL4YG you can't expect users to read all change logs, especially when several versions have elapsed.
Even if they read them, you can't expect them to catch all the consequences.
In other words, we're humans, we're prone to make mistakes.
In other words, when designing a product, labeling or writing documentation like change logs should be the very last line of defense. The main proper way to address an issue is prevent it's occurrence in the first place.

@LemADEC TE has a very low release rate, all changelogs are brief and can be found on the same page.  So yes, I can expect proper server administrators to read changelog.
Bigger releases may highlight breaking changes for instant notice and as I said it's a good idea to also add fallback values to prevent exceptions. But it's a worse idea to write extra code for each little change just for conversion.
I'd do that for jobsets when the configs are potentially huge but not for any node in the main configuration. This would unnecessarily blow up the code files or (if you'd remove one conversion when the next change to it arrives) would break immediately when a version is skipped.
Also yes: It's better to prevent breaking changes but sometimes those are necessary.

I went ahead and added a notice to the 1.6.0 dev release stating that configuration changes have been made. As well as that, build numbers have started being used to better identify new releases.
@LemADEC Do note that Total Economy is still a work in progress so the structure of the main configuration file will change occasionally. And adding a bunch of code to check and make sure that the main configuration file is proper is really not necessary in my opinion because at some point, config breaking updates will no longer be made. As well as that, config breaking updates don't really happen that often. With that said, a default value will be added so that error does not pop up. This does not fix the error though, just silences it.


TreeItem State None to Expanded

Issue Type: Bug
We, Cloud Code have a use case where a TreeItem could transition from vscode.TreeItemCollapsibleState.None to vscode.TreeItemCollapsibleState.Expanded. Currently, this functionality doesn't seem to work on a dynamic setting.
I have created a simple repro here: https://github.com/vincentjocodes/vscode-tree-state-issue. Steps to repro the problem with the sample app are:

Run Extension
Open the Explorer and see 2 nodes:

Run Event: Expand command from the command palette
See that the items are collapsed:

I expect the items to be expanded, per this line of code in the sample. There are no places in my code where I set vscode.TreeItemCollapsibleState.Collapsed.
Please help.
Thank you.
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:32.912Z)
OS version: Darwin x64 19.6.0
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
3, 4, 4

Memory (System)
16.00GB (1.53GB free)

Process Argv
--crash-reporter-id ed7a5a7f-6e02-4080-a6f9-795012ddb483

Screen Reader
no

VM
0%

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
pythonvspyt700cf:30270857
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vstes627:30244334
pythonvspyt639:30300192
pythontb:30283811
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255:30323308
vscorehov:30309549
vscod805cf:30301675
pythonvspyt200:30324779
binariesv615:30325510

Looks good!

@TylerLeonhardt @alexr00 Just downloaded the Insider's today but couldn't get dynamic expansion working from vscode.TreeItemCollapsibleState.None to vscode.TreeItemCollapsibleState.Expanded.

@vincentjocodes I reverted this change since not reflecting such changes to collapsibleState is by design. If tree data providers can change the expand state of trees like this then it can get extremely confusing for users when their tree expansion states change. The collapsibleState is an initial value only. To expand a tree item, you should use the reveal API.

@vincentjocodes I reverted this change since not reflecting such changes to collapsibleState is by design. If tree data providers can change the expand state of trees like this then it can get extremely confusing for users when their tree expansion states change. The collapsibleState is an initial value only. To expand a tree item, you should use the reveal API.

Shouldn't user experience be within the developer's control, rather than the a strict restriction on the platform? I think programatically it's confusing for developers to provide a new instance of TreeItem with a different collapsibleState from previous iterations of getTreeItem and get the wrong results.
Using the reveal API creates indirection. In the data provider, we need to cache all object to be revealed, and on the upper hierarchy create a function that takes the TreeView item we created along with the data explorer to reveal based on a condition. Say an event outside triggers the expand action, then you have even more indirection because the said function will have to listen for this event as well.


compatibility with pypsa-eur PR: clustermaps to csv

In PyPSA-eur, the output of clustermaps will change from HDF format to CSV.  clusermaps_{network}_s{simpl}_{clusters}.h5 will be replaced with seperate files, namely busmap_{network}_s{simpl}.csv for the simplify method and busmap_{network}_s{simpl}_{nclusters}.csv for the cluster method. (see https://github.com/PyPSA/pypsa-eur/pull/198),
This PR makes pypsa-eur-sec compatible with the proposed changes.
Not sure about the release notes here?

Just a flag, that this needs to be coordinated in joint releases with PyPSA-Eur and PyPSA-Eur-Sec.

Thanks both! Yes, I'll pull it once the new PyPSA-Eur release is out, then do a new PyPSA-Eur-Sec release.

Actually I'll do it now, since I want to test the new PyPSA-Eur.


Fixed typo in readme

Fixed typos in the readme file
@elmps2018 @wbrunette

@dikshamalik2552 why does this PR have code changes in if it is simply about fixing a typo in the readme?

Sorry, actually this pr has the code changes of another pr: https://github.com/odk-x/tables/pull/201 which hasn't been merged yet. I'll just create a separate pr for this.


Crash while draging file,stackoverflow

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version:  1.79.1
OS Version: Arch Linux x86_64 6.3.5-arch1-1

Steps to Reproduce:

open a file in vscode
drag a file to editor

then crashed :(
report.txt
by using DrKonqi ,i found that crash was due to stack overflow: a function called many time in thread.
Attach crash information.
microsoft-edge and google-chrome also crash for this reason.
maybe this bug came from  Chromium?

another crash report

Does this issue repro with latest stable 1.84 ?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

Does this issue repro with latest stable 1.84 ?

I'm sorry, I've now switched to a new Windows device and this issue doesn't exist anymore :)
It was the power of money that solved this problem, my previous device was really very old (i3 3gen)
I was basically sure that this issue was related to Chromium and Wayland when I was using the previous device, as this issue didn't exist if I had used X11. I had a weird crash on my previous device using the edge browser or any other applications with the Chromium kernel, which I reported as a bug but didn't get it seriously.


Add Image Transformations/Augmentations

This represents the last of the initally planned differences between datasets and will complete issue #3 by extension.
Since we have added CIFAR through the use of PyTorch Lightning, this should broadly consist of:

Adding dataset A and dataset B specific transforms to the inputs for DMPair and CIFAR10DMSubset
Adding tests for the following cases

Transforms added to A
Transforms added to B
Transforms added to both

With #30 this is done. I've raised #33 to define experiment combinations in a group after 'drop-only'


Node to node Public Posts

Okay, this gives us node-to-node public posts in our own api calls.

LGTM :+1:


Knights?

Describe the bug
Is there a way to disable to Knighthood for NPCs ?
After a large battle there are a lot of NPCs to capture that almost always lead to crash.
Very annoying that I have to restart the same battle again and recapture them and crash before even done...
hope you get it ^^
Mod Version

Standard version
Numeric Version: <IP_ADDRESS>

Sure, I can add it.


Testing out with start-polymer3

Hey! I've repurposed the start-polymer3 codebase and am trying to drop in lit-element.
What's the suggested way to bind the checked state of paper-checkbox with marsfarm-app's pie property?
import { PolymerElement } from<EMAIL_ADDRESS>import { LitElement, html } from<EMAIL_ADDRESS>import<EMAIL_ADDRESS>import<EMAIL_ADDRESS>import<EMAIL_ADDRESS>
class MarsfarmApp extends LitElement {
  static get properties () {
    return {
      message: {
        type: String,
        value: ''
      },
      pie: {
        type: Boolean,
        value: false,
        observer: 'togglePie'
      },
      loadComplete: {
        type: Boolean,
        value: false
      }
    };
  }

  constructor() {
    // If you override the constructor, always call the
    // superconstructor first.
    super();
    this.message = 'Hello World! I\'m a Polymer element :)';
  }

  ready(){
    // If you override ready, always call super.ready() first.
    super.ready();
    // Output the custom element's HTML tag to the browser console.
    // Open your browser's developer tools to view the output.
    console.log(this.tagName);
  }

  togglePie(){
    if(this.pie && !this.loadComplete) {
      // See https://developers.google.com/web/updates/2017/11/dynamic-import
      import('./lazy-element.js').then((LazyElement) => {
        console.log("LazyElement loaded");
      }).catch((reason) => {
        console.log("LazyElement failed to load", reason);
      });
      this.loadComplete = true;
    }
  }

  render() {
    return html`

Start Polymer 3.0

${this.message}

      <paper-checkbox
        checked="{{pie}}">I like pie.</paper-checkbox>
      <template is="dom-if" if="${this.pie}">
        <lazy-element>
lazy loading...
</lazy-element>
      </template>
    `;
  }

}

// Register the element with the browser.
customElements.define('marsfarm-app', MarsfarmApp);

[edit: added syntax highlighting]

aha! this is exactly what I was wondering. Given that I originally came from react land, I'm down with this approah.
https://github.com/PolymerLabs/lit-element/issues/14

When first using a new tool, I suspend my disbelief about how things should work, so I can see how they actually work. In this case, I'd assumed polymer's data-binding would be present, and attributed any of it not working to my own lack of understanding. So, given I'm the second person to pipe up with the same question, I'd like to suggest adding a small note to the readme to help nudge others down the right path.
Heads Up!

Polymer 1/2 users - lit-element doesn't support Polymer-esque data-binding ([[]] & {{}}) for performance compatibility reasons. (You can use lit-element with anything). Instead, use standard browser events. see https://github.com/PolymerLabs/lit-element/issues/14 for details.

then, for easy copypasta if you choose:
## Heads Up!
* Polymer 1/2 users - `lit-element` doesn't support Polymer-esque data-binding (`[[]]` & `{{}}`) for performance compatibility reasons. (You can use `lit-element` with anything). Instead, use standard browser events. see https://github.com/PolymerLabs/lit-element/issues/14 for details.


Bug: vc-labels not loading

File name: /g/arendt/EM_6dpf_segmentation/EM-Prospr/em-segmented-cellular-models-labels.h5
dtype: int16
Error message: attached

Btw, when I try to remove the file from the browser (clicking 'X') everything just gets stalled :)

@vzinche is this still an issue? if not, could you please close it?

it still can't be loaded. I'll try once again when @constantinpape moves this file to segmentations

it still can't be loaded. I'll try once again when @constantinpape moves this file to segmentations

This depends on how we resolve https://github.com/platybrowser/platybrowser-backend/issues/10.

This should be fixed, could you try again @vzinche?

@tischer we are still seeing some nullpointer exceptions when the file is loaded.
I checked and the dtype is int16, did you maybe forget to push the fixes for empty int16 chunks we made yesterday?
I will also check the file locally.
Also the virtual-cells still end up in the prospr dropdown, not in the prospr segmentation dropdown where they should be. (I checked and their type is Segmentation in images.json).

I checked and the dtype is int16, did you maybe forget to push the fixes for empty int16 chunks we made yesterday?

Does it work now?
TODO

[ ] Also the virtual-cells still end up in the prospr dropdown, not in the prospr segmentation dropdown where they should be. (I checked and their type is Segmentation in images.json).

Works now, virtual cells are displayed properly and they show up in the correct dropdown menu.


Package signature verification failed during connection creation

Good afternoon, colleagues. When connecting to ClickHouse via connector JDBC by Analytica Plus, sometimes an error occurs (screenshot).
The error appears on versions 2021.2.2, 2021.2.3, 2021.2.9 Tableau Desktop.
This error started appearing relatively recently.

Could you please tell the version of the OS?
Does it help if you try the version 0.2.2 of the Connector?
Does the upgrade to the latest builds of 2021.3 or 2021.4 help?
I'm not able to reproduce the error with version 0.2.2 of the Connector
together with either 2021.2.9 or 2021.4.4 of Tableau Desktop for Mac.

@NikitaUshanov Hi!
Maybe it will help somehow? Can you share the OS version and the exact minor version of Tableau Desktop?

I apologize for the long response. From what we have been able to record:
MacOS | 0.2.1. taco | 0.3.2.jar | Tableau 2021.2.2
MacOS | 0.2.1. taco | 0.3.2.jar | Tableau 2021.2.3
MacOS | 0.2.1. taco | 0.3.2.jar | Tableau 2021.2.9

Hi @NikitaUshanov  are you still having this issue? have you been able to reproduce it with the latest taco (0.2.2) and the latest version of the JDBC driver (at least 0.3.2-patch7 or above)?


'alt-d': 'native!' #doesn't work

Description
I set my keymap.cson to include 'alt-d': 'native!' because on my OSX keyboard, option-d is how I type "(". This gets a left paren, but it also deletes from the cursor to the end of the word.
Steps to Reproduce

'alt-d': 'native!' in keymap
go to middle of a word
press option-d (on a mac)
you get the native character to the left of the cursor as expected, but the rest of the word to the right of the cursor is deleted.

Expected behavior: [What you expected to happen]
Actual behavior: [What actually happened]
Versions
1.8.0
1.9.0-beta0

This appears to be a duplicate of atom/atom-keymap#35. You may want to subscribe there for updates. Also, some people have reported success with the keyboard-localization package in solving these kinds of issues.
Let me know if I misunderstood and I'll be happy to reopen the Issue!


Example of multiple sources with single layers

Hey guys,
First of all, awesome work! I was on the "Mapzen SF Happy Hour Demo Time" at Code for America last week and saw all the cool stuff that Tangrams can do. Needless to say, I was very impressed! I love the clean yaml syntax.
I'm thinking about start working on an open source project that combines a lot of things: Django, GeoDjango, TileStache, and hopefully Tangram (fingers crossed).
I was going over the documentation and couldn't find an example of a styling "scene file" that uses multiple sources with single layers instead of one single source with multiple layers.
So for instance, instead of having this URL:
//domain.com/all/{z}/{x}/{y}.geojson

That returns this:
{
   "earth": {
      "type":"FeatureCollection",
      "features": [...],
      ...
   },
   "landuse": {
      "type":"FeatureCollection",
      "features": [...],
      ...
   }
}

I would have several of these URLs:
//domain.com/earth/{z}/{x}/{y}.geojson
//domain.com/landuse/{z}/{x}/{y}.geojson
...

Where each of them return something like this:
{
  "type":"FeatureCollection",
  "features": [...],
  ...
}

How would my scene.yaml look like for this setup, if I would like to get the same result as this scene file (simple-demo)? I'm sure there is an example somewhere there and I totally missed it.
Thanks, and keep the good work!

Hi @juliomalegria, thanks for writing and glad you are interested in using Tangram!
You definitely can create a scene with multiple sources as single layers (or mix sources that each have multiple layers). Looks like we need to add more examples for this. In the meantime, I've made this example:
https://gist.github.com/bcamper/6b7d85003a652c0018d6
It pulls in 3 different sources, all from Mapzen's vector tile service (which allows you to request individual layers in addition to all):
sources:
    earth:
        type: TopoJSON
        url:  //vector.mapzen.com/osm/earth/{z}/{x}/{y}.topojson

    landuse:
        type: TopoJSON
        url:  //vector.mapzen.com/osm/landuse/{z}/{x}/{y}.topojson

    roads:
        type: TopoJSON
        url:  //vector.mapzen.com/osm/roads/{z}/{x}/{y}.topojson

The rest of the file shows how to reference those for drawing. (I did these with TopoJSON sources but GeoJSON will work just the same.) Behind the scenes, Tangram will look at the response to see if it's a single FeatureCollection, or an object containing multiple collections.
The only caveat here is that this example is doing 3x the number of HTTP requests vs. using all. Of course, if that's the only way the data is accessible (say it's pulled from two different organizations with different servers) then this is probably the only way to do it. On the other hand, if it's easy to bundle the data into a single request, it will be more efficient. Either works though.
Let us know if you have more questions and please send along any examples once you get it working :)

Thanks @bcamper! This is exactly what I was looking for.
If everything goes well, Tangram will be the default renderer of my open source library. I'll post a link once a have some progress.


DCO check is missing for the project

Greetings, project maintainers.
CNCF's IP policy (https://github.com/cncf/foundation/blob/master/charter.md#11-ip-policy) requires all projects to use either CLA (Contributor License Agreements) or DCO (Developer Certificate of Origin). Unless there's a strong necessity to use CLA, we encourage projects to use DCO as it's easier to setup and use. Ref.: https://github.com/cncf/foundation/issues/130
During the audit, we've noticed that one or a few repositories of your project doesn't have the DCO check enabled. Please enable the DCO check for all repositories in your GitHub organization. You may find more details here - https://github.com/apps/dco.
Thanks

Ref: DCO being added here https://github.com/backstage/backstage/pull/4513

@OrkoHunter great, thanks!


.jshintignore not working?

Given this .hound.yml:
❯ cat .hound.yml

ruby:
  config_file: .rubocop.yml
scss:
  config_file: .scss-lint.yml
javascript:
  config_file: .jshintrc
  ignore_file: .jshintignore

And this .jshintignore:
❯ cat .jshintignore

vendor/*
client/**/*.js
client/*
webpack.config.babel.js

Why would HoundCI continue to lint e.g. client/components/CardList.js:

Hi @jasonkuhrt, issue was introduced in 0eef7e7 and resolved in https://github.com/thoughtbot/hound/pull/1044.
This should be resolved now. Thanks for reporting this to us!

@teoljungberg Thank-you, looking good now!


chore: add community files (not to be merged)

Description

this is a draft PR for the testing of UI and docs rendering on the website.
add files to check how they're being deployed and previewed on the website.

Related issue(s)
https://github.com/asyncapi/community/issues/1028
https://github.com/asyncapi/community/issues/773

@AnimeshKumar923 please update the description and mention that this is a draft PR for UI testing
and remove the test word from the title

@AnimeshKumar923 please update the description and mention that this is a draft PR for UI testing and remove the test word from the title

made the required changes


Serve profile pictures from a custom URL, not Gravatar

This would be a great feature to have, as many do not want to use Gravatar. Whilst it's easy enough to do with custom code, a better method could be used.
Will also help with site speed, as Gravatar serves images in 200px, why it is only 30px on the site.
Thanks

This would be a great feature to have, as many do not want to use Gravatar. Whilst it's easy enough to do with custom code, a better method could be used.
Will also help with site speed, as Gravatar serves images in 200px, why it is only 30px on the site.
Thanks

I'm literally fiddling with this as well. Can you tell me how you were able to replace the theme's gravatar with a custom photo? I tried relative linking to an image in my assets folder and absolute linking to an image on the web, but neither method worked.

Search your project for the class author-thumb and you’ll find the link for the gravater, replace it with your image link.
https://github.com/wowthemesnet/mediumish-theme-jekyll/blob/be4679054c9b500bfa6cafe44685706254e24776/_includes/featuredbox.html#L38

@GiacomoLaw Thanks for the quick reply!
Pardon me if this is a dumb question, but do I need to replace the gravatar link for just this one instance or in every file that has an author-thumb class with a src linking to a gravatar url?

Every file that has author-thumb with that link, yes.

Ok, done!
Make sure you set your local avatar  in config. If no local avatar is set, it grabs the gravatar.

Thank you!


The cart didnt empty after i bought it using coinbase check out

Describe the feature you'd like to request
the cart should empty so i don't accidentally buy the swag twice.
I got an email saying i bought the swag... and i did, i sent USDC on Polygon using coinbase... I did switch wallet addresses tho to pay, so maybe that changed the session id or something... but either way i got an email saying the order will come to my house and the website says the order is confirmed

But then i go to the website again and I see the items still in my cart

Describe the solution you'd like
i want the items to be reomved from my cart after i buy the items
Describe alternatives you've considered
leave it so we can scam the customer... more sales = great (j/k)

That's weird. The completedAt field returned from myshopify API is null even after the purchase is completed.


W-13160145-rtfctl-kubernetes-permissions-kt

Writer's Quality Checklist
Before merging your PR, did you:

[ ] Run spell checker
[ ] Run link checker to check for broken xrefs
[ ] Check for orphan files
[ ] Perform a local build and do a final visual check of your content, including checking for:

Broken images
Dead links
Correct rendering of partials if they are used in your content
Formatting issues, such as:

Misnumbered ordered lists (steps) or incorrectly nested unordered lists
Messed up tables
Proper indentation
Correct header levels

[ ] Receive final review and signoff from:

Technical SME
Product Manager
Editor or peer reviewer
Reporter, if this content is in response to a reported issue (internal or external feedback)

[ ] If applicable, verify that the software actually got released

Hi @kevintroller , The content LGTM. Let me know if you need me to approve it.
I couldn't see the table rendered but I'm assuming that is correct.


Allow configuring multiple tables in config.toml

Don't think this is so important anymore if users are able to just invite the bot themselves.


MAC OS Sierra update

Hello, I have an issue - connected with Sierra update - before the update my settings worked perfectly, no problem, after update the same configuration stopped working anymore. But strange thing is that I cant see any error - when I run uncss task, it says Finished, but nothing is created in dist folder as before - the task doesnt create any output file.
My settings:
Grunt-uncss task:
module.exports = function(grunt) {
    return {
        dist: {
            files: [
                { src: '<%= paths.dist %>/all_transactional.html', dest: '<%= paths.dist %>/css/nomediaq.css' }
                ,{ src: '<%= paths.dist %>/testing_template.html', dest: '<%= paths.dist %>/css/testing_template.css' }
            ]
        },
        options: {
            compress: true,
            ignore: ['.ExternalClass', '.ExternalClass p', '.ExternalClass span', '.ExternalClass font', '.ExternalClass td', '.ExternalClass div', 'a[href^=tel]',
                'a[href^=sms]', 'a[x-apple-data-detectors]', 'a:hover', 'code', 'pre', '.btn_hoover', '.menuContent a', '.yshortcuts', '.ReadMsgBody'
            ]
        }
    }
}

Gruntfile:
module.exports = function(grunt) {

    require('jit-grunt')(grunt);
    require('load-grunt-config')(grunt, {

        // Pass data to tasks
        data: {

            // Re-usable filesystem path variables
            paths: {
                dist: 'dist'
            }
        }
    });
};

Logging when I run it with grunt uncss --debug --verbose

Running "uncss:dist" (uncss) task
[D] Task source: ..../node_modules/grunt-uncss/tasks/uncss.js
Verifying property uncss.dist exists in config...OK
Files: dist/all_transactional.html -> dist/css/nomediaq.css
Files: dist/testing_template.html -> dist/css/testing_template.css
Options: report="gzip", compress

Anyone any idea what should I change? Thank you.
Best regards,
Roman

You probably need to share the relevant bits of your grunt config. (And fixing the formatting above would be nice!)

Ok, no problem, I have added my grunt file too. Little background - in my dist folder I have already created HTML file (in my case e-mail), which is called "all_transactional.html" and from uncss I want to remove not used css (e.g. obsolete media queries etc.) and create a file in dist/css/nomediaq.css then I will inline the css and will continue to code my e-mails....
Is there any chance to see whats really happing inside the running task? e.g. to turn on some logging to see where is the problem? The result is not saying anything - just that the task finished:

(Running "uncss:dist" (uncss) task
[Finished in 65.4s]

. No info about why there is no file created in dist/css...no error message...nothing and I am asking why?

I cannot see where grunt-uncss is actually used/called in the above two configs.

Well, it is called through this plugin load-grunt-config (e.g. this row require('load-grunt-config')) - it looks for aliases which I have defined in my file aliases.yaml.
I have just ran grunt uncss --debug --verbose
(shorted version)
Command-line options: --verbose, --debug=1
Reading "Gruntfile.js" Gruntfile...OK
Registering Gruntfile tasks.
Initializing config...OK
Registering "grunt-uncss" local Npm module tasks.
Reading .../node_modules/grunt-uncss/package.json...OK
Parsing .../node_modules/grunt-uncss/package.json...OK
Loading "uncss.js" tasks...OK
+ uncss
Loading "Gruntfile.js" tasks...OK

The grunt-uncss is succesfully loaded (registered), but when I run it, there is no output file. What is the role of PhantomJS there? Is there any for my case? I cant see any system process running PhantomJS.
From my beginner point of view it looks like that there is some uncaught error or exception somewhere around this lines of code (e.g. 48 - 53):
grunt.file.write( file.dest, output );
                    grunt.log.writeln('File ' + chalk.cyan( file.dest ) + ' created: ' + maxmin( report.original, output, options.report === 'gzip' ) );
                    if (typeof(options.reportFile) !== 'undefined' && options.reportFile.length > 0) {
                        grunt.file.write(options.reportFile, JSON.stringify(report));
                    }
                    done();

Because when I run it, it doesn't throw any error to be thrown, but there is no row in log for this row:
grunt.log.writeln('File ' + chalk.cyan( file.dest ) + ' created: ' + maxmin( report.original, output, options.report === 'gzip' ) );

No idea anyone, so I have just solved it by myself.
I have noticed that I was using older version than current. The problem was fixed by updating to current 0.6.1

I have the same problem:
In my case (maybe the same situation): PhantomJS PATH is the interruption, the real solution is not the update but with the update the PhahtomJS is re-configurated.


Add SIGEMT (for apple) and SIGINFO (for bsd).

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

Thanks! I'll work on getting CI fixed and then we can merge

Ok, if you want to rebase on master that should pick up the fixes and CI should be able to run

@bors: r+ a0725ad9fad39035d0029a4551a71deba1ebc470

Can we get a version bump in the near future?

:hourglass: Testing commit a0725ad with merge b40b47a...

Yeah once this is merged I can bump

:broken_heart: Test failed - travis

There still seems to be an infrastructure problem.

@bors: retry
On Wednesday, April 27, 2016, Philipp Matthias Schäfer <
<EMAIL_ADDRESS>wrote:

There still seems to be an infrastructure problem.
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/rust-lang/libc/pull/265#issuecomment-215320659

:hourglass: Testing commit a0725ad with merge ac59d35...

:sunny: Test successful - status-appveyor, travis


added submodule, removed software folder, take #2

Okay trying this again while up to date so it merges. Same thing goes, I'd like it if people checked out the software repo and make sure everything works.

I tested the signpost-software repo and it works fine for me.


Admin - update booking status

As an admin I should be able to update the booking status as it changes. i.e. Booked, picked up, in transit, etc...

Duplicate of #9?