Kingdom of Misthalania Otto's Grotto Screenshot

Please check if your issue is not a duplicate by searching existing issues
Describe the bug
To Reproduce
Steps to reproduce the behavior:

Go to Otto
Get the Barbarian Skills book
Open the book and flip through pages
Screenshots of the open book will be saved in the "kingdom Rewards" screenshot folder

Expected behavior
No screenshot should be taken, and shouldnt be saved as kingdom reward
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

OS: Windows 10
RuneLite version: <IP_ADDRESS>
Launcher version: 2.1.3

Additional context

This should be fixed, if you restart your client and open a book, can you check that it actually captures a new screenshot?

Duplicate of #12773


BlendMode not work with DragonBones 2.4.1

Set armature.display.blendMode to any mode like BlendMode.SCREEN not work when using 2.4.1
Solution is here:
In DragonBones 2.4.1 XMLDataParser.as(line 178) and ObjectDataParser.as(line 147):
Change
slotData.blendMode = "normal";
to
slotData.blendMode = "auto";
Because "auto" mode inherits the blend mode from parent while "normal" mode not.

the bug has been fixed.


Adds missing dash

On every new PR Danger changelog check is complaining because of missing dash:

I'm not sure if line in question should be both in fixes and features. But it got to have dash before author's name.

thanks @budnik for fixing it


bug fixes and support for ccr mpi

this pr should close #8 with documentation on the wiki

@knepley Would you mind doing another review with the -dm_distribute changes when you get a chance please?

@knepley Would you mind doing another review with the -dm_distribute changes when you get a chance please?


Rust auto-indent doesn't always work

VSCode Version: 1.24.0 and 1.25.0-insider
OS Version: KDE Neon (based on Ubuntu 16.04 Xenial)

Steps to Reproduce:

Make a new file with the following contents:

fn main() {
    println!("Hello world!");

    println!("Goodbye!");
}

Press ctrl+shift+enter on the Goodbye! line

The added line has no indentation, and in a deeper indentation context, pressing tab doesn't insert multiple indents. However, pressing enter after the opening curly bracket or ctrl+shift+enter on the Hello World! line both indent properly.
I've tested this behavior on JavaScript/TypeScript and it works as expected, and I've tested the language-rust package in Atom which works properly too.

Does this issue occur when all extensions are disabled?: Yes

This happens in bash scripts too.

Hi @dqsully, thanks for reporting this. VSCode ships with auto-indentation for JS, TS, CSS, HTML, and JSON, but for other languages, a language extension is responsible for adding it. Please file feature requests or bugs on the Rust and bash extensions you're using

So I did some more testing yesterday and I found that TS, JS, Python, HTML, LESS, and CSS all indent properly, but it doesn't work properly for Bash, JSON, Rust, Dockerfile, or CoffeeScript. Also, this issue happens for me with/without the Rust/RLS extension, and I don't have any extensions for any of the languages that don't indent properly - they came with VS Code.

I'm totally new to this codebase, but it seems like the rust language configuration at language-configuration.json is just missing the increaseIndentPattern and decreaseIndentPattern properties from the source Atom package's settings at rust.cson. Python has it in some source code at pythonMain.ts, and Ruby has it right in the language-configuration.json, but Bash/Dockerfile etc. don't.
I'd be happy to work a pull request this weekend with all of the missing indentation patterns.

@dqsully Sorry for my incorrect response earlier, I thought this feature fell into the category of something that was extension contributed, not a basic language configuration. A pull request for this would be very welcome!


Missing Script : Start

getting problem installing. errors when running npm install. below are the "npm-debug"file
0 info it worked if it ends with ok
1 verbose cli [ 'C:\Program Files\nodejs\\node.exe',
1 verbose cli   'C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js',
1 verbose cli   'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose node symlink C:\Program Files\nodejs\node.exe
5 verbose stack Error: missing script: start
5 verbose stack     at run (C:\Program Files\nodejs\node_modules\npm\lib\run-script.js:138:19)
5 verbose stack     at C:\Program Files\nodejs\node_modules\npm\lib\run-script.js:81:5
5 verbose stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\read-package-json\read-json.js:51:40
5 verbose stack     at final (C:\Program Files\nodejs\node_modules\npm\node_modules\read-package-json\read-json.js:349:17)
5 verbose stack     at then (C:\Program Files\nodejs\node_modules\npm\node_modules\read-package-json\read-json.js:126:33)
5 verbose stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\read-package-json\read-json.js:331:40
5 verbose stack     at evalmachine.:336:14
5 verbose stack     at C:\Program Files\nodejs\node_modules\npm\node_modules\graceful-fs\graceful-fs.js:102:5
5 verbose stack     at FSReqWrap.oncomplete (evalmachine.:99:15)
6 verbose cwd C:\Users\zayyar.waiphyo\Documents\GitHub\material-ui
7 error Windows_NT 6.1.7601
8 error argv "C:\Program Files\nodejs\\node.exe" "C:\Program Files\nodejs\node_modules\npm\bin\npm-cli.js" "start"
9 error node v0.12.0
10 error npm  v2.5.1
11 error missing script: start
12 error If you need help, you may report this error at:
12 error     http://github.com/npm/npm/issues
13 verbose exit [ 1, true ]

What is the output to the console? Are you using the latest version of React (v0.12)? If so, see #422.

Yes, my react is latest v0.13
below is the console outpu.
C:\Users\zayyar.waiphyo\Documents\GitHub\material-ui>npm install

<EMAIL_ADDRESS>prepublish C:\Users\zayyar.waiphyo\Documents\GitHub\material
-ui
npm run build

<EMAIL_ADDRESS>prebuild C:\Users\zayyar.waiphyo\Documents\GitHub\material-u
i
rm -rf lib

'rm' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\\node.exe" "C:\Program Files\nodejs
\node_modules\npm\bin\npm-cli.js" "run" "build"
npm ERR! node v0.12.0
npm ERR! npm  v2.5.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>prebuild: rm -rf lib
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prebuild script 'rm -rf lib'.
npm ERR! This is most likely a problem with the material-ui package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     rm -rf lib
npm ERR! You can get their info via:
npm ERR!     npm owner ls material-ui
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\zayyar.waiphyo\Documents\GitHub\material-ui\npm-debug.log
npm ERR! Windows_NT 6.1.7601
npm ERR! argv "C:\Program Files\nodejs\\node.exe" "C:\Program Files\nodejs
\node_modules\npm\bin\npm-cli.js" "install"
npm ERR! node v0.12.0
npm ERR! npm  v2.5.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>prepublish: npm run build
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prepublish script 'npm run build'.
npm ERR! This is most likely a problem with the material-ui package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build
npm ERR! You can get their info via:
npm ERR!     npm owner ls material-ui
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     C:\Users\zayyar.waiphyo\Documents\GitHub\material-ui\npm-debug.log

It looks like you're running into a different issue. But it looks like you're also setting up your system to contribute to material-ui (since you've cloned the repo and are doing an npm install).
Just to be sure, you know you don't need to do this to use material-ui in a project, right? Meaning you can just npm install material-ui in your project folder to bring it in. Sorry if you knew this already - just trying to be helpful.
With that said, if you do intend to use material-ui in a project, because you're using React v0.13, it will fail until #422 is resolved.

@kozeyar You will get a missing script: start error if you run npm start in the material-ui directory. npm start is intended to be run in the material-ui/docs directory. I just made the same mistake. But again, if you're using React v0.13, you'll still run into other issues ... for the time being.

Thanks Don.
On Thu, Mar 12, 2015 at 6:09 PM Don Smith<EMAIL_ADDRESS>wrote:

@kozeyar https://github.com/kozeyar You will get a missing script: start
error if you run npm start in the material-ui directory. npm start is
intended to be run in the material-ui/docs directory. I just made the
same mistake. But again, if you're using React v0.13, you'll still run into
other issues ... for the time being.
—
Reply to this email directly or view it on GitHub
https://github.com/callemall/material-ui/issues/423#issuecomment-78453033
.

Thanks @locksmithdon


Critical issue with the client side not rendering signup/signin pages

Hey,
I'm seeing an issue where if I start the project through the 'master' branch, the home page loads ok, but clicking the Signup or Signin buttons on the top navigation menu the page just refreshes without actually loading the correct HTML for it.
Can anyone else reproduce it?

@lirantal I have the same behavior. When I refresh the page (/articals for example), I get infinite static resources loading. In server console there are few static js files that don't have load time. When I move static middleware in config file before session middleware, it work perfect but without browser cache.

@smirnovigor interesting. can you further test and see if you can find the fix for this problem?

Hey @smirnovigor I think I found the issue.
There seems to have been an angular update that we needed to install. Running 'npm install' installed it for me, and fixed the authentication issue.
Can you try it too and let me know if it's resolved?

@lirantal after little playing around, I don't know why, application works fine, with browser cache.


Clean up zen locale information so it's easily reportable

Business Case
CoderDojo locale information is very poorly stored. We need to clean this up so it's easy for the community to report on and contact people around it.
Detail
Currently, regional data, as you see in the API request https://zen.coderdojo.com/api/2.0/dojos, is very messy and is only useful on the exact location and the country fields.
My current proposal of what we should store

County in it's various formats that we currently do (no need to break anything)
Town/city as in current format
direct location, long lat
state & county (to be checked if these should be one field or two)

Tasks

[ ] Decide on what data we take from google maps and save in our DB
[ ] Change the code so we now record that
[ ] Migrate all historical data to the new format
[ ] Review that this does not impact search negatively
[ ] Add that data into data studios
[ ] Conor to test it in Data Studios

There is an inherent problem here for updating current data :

it means we either need to have retro-compatibility due to the leads having the location information and hence we need to update dojos and leads (which is json-based and quite the extra work)
or we do not care about leads and only about dojos (which.. is a mediocre idea considering a dojo is just a formatted and saved lead, and both depends on the same frontend components)
or we accept that old leads will not have the data and we will re-run the update script from time to time to update the dojos only

First LEET PR for front-end:
https://github.com/CoderDojo/cp-zen-platform/pull/1337

For me "It means we either need to have retro-compatibility due to the leads having the location information and hence we need to update dojos and leads (which is json-based and quite the extra work)" is the only option that looks sensible above. Would the frontend not break if Leads and Dojos aren't using the same info?

Well, it's code, everything breaks at some point and needs fixing. Now, for sure i'd prefer to avoid that scenario as it branches the code even more and makes this task to be less efficient as it provides the data only at one point, but that's another alternative than the one I started.

Geocoding works by "level" of administration, where we use the first level as a state, and the second level as a county.
Considering country>state>county as a hierarchical representation of a location, and in case (like Dublin) where no state is returned, should we map the first level of hierarchy to the county, or the state ? @conoramurphy

To me I would map Dublin && Alaska, for example, both to the second level. I might be missing some negative implications of that if you can think of any?

None, apart than accepting that state can be null. For example, Germany doesn't have states, nor county, but only Provinces, which mean we can either map them to a county or a state.
At the same time, google returns sometimes returns the city as the 2nd level of administration. Hopefully that would be consistent in the same region : as long as grouping is possible in a equivalent area, i think that both solutions are sort of fine (apart from losing the semantic of what a state really is..)
Accepting that state can be null means however that the default value becomes county as being the always filled info. For stats, it will require a "case" scenario to backfill state with the value of county.
Regarding the "Region" thing: for US, state would be used. For other countries, I don't know.

Ya that makes sense. We can transform the data if needed for GDS. Seperate concerns.

Another issue I bring here is that not all dojos have proper coordinates, which is the easiest way to get information on the location.
Solution 1 is to manually solve those only for verified (65) dojos
Solution 2 is to fallback to another call to find from the placeName, but there's not guarantee it'll work as the front-end didn't find it in the first place.

Data has been backported.
New dojos will have this data as well
Will work now on the port to the warehouse

Added to MC.
I think we're good ?

There's a few GB countries with no state (england etc.) in mailchimp. Is that meant?

Ok, I'm back onto it..

76 of those subscribed still don't have a county. My understanding of it is that they'll be updated at next dump.

Cool. I'd say close and move to omintoring and we can do a final check next week. Thanks a million!

Added monitoring


[1.7.0] Add DB storage driver

Fixes #53
TODO:

[ ] Write docs for publishing & customizing the migration
[x] Write the storage driver
[ ] Run tests with both storage drivers

Cool!
I pulled the branch and after a couple of touches it seems to start.
for the Tenant model I've added:
`
toArray();
        return $tenant;
    }

With that, copying the tenant table migration (Added timestams() there) things at least get to boot.

Thanks! KR

Hi @carlos-mora. I'm working on that right now. If you're interested in helping with this, we can discuss this in real time on Discord (stancl on Laravel Discord) or Telegram (@samuelstancl).
I went with $guarded instead of $fillable, because my idea is that by default, data gets stored in the data JSON column, but developers can create their own columns for some keys. This is useful when indexes and similar features are needed.

Hi Samuel,
It's a little bit late here in Madrid, my wife is arriving so I'm really
sorry, I can't go online right now. Anyway I'm following the project very
close and trying it asap, I have to make multitenant an existing project,
and your package fits perfectly, besides the fact I don't use Redis.
Please consider declaring the PK in Tenant's model, and set it as
non-integer, otherwise the uuid attribute behaves weird. P/E, $tenant->uuid
returns 0 instead of the real attribute value. Adding this will fix the
behavoir:
/**

The primary key associated with the table.

@var https://github.com/var string
*/
protected $primaryKey = 'uuid';
public $incrementing = false;

If you don't change the $primaryKey, Tenant::find($uuid) will crash
with a "Column
not found: 1054 Unknown column 'tenants.id' in 'where clause' (SQL: select

from tenants where tenants.id =
d51e24a0-badf-11e9-99d8-03661283d12a limit 1)"

Please remember to add to the TODO list an artisan command to export the
Tenants's table migration.
KR, and thanks!
El vie., 9 ago. 2019 a las 22:51, Samuel Štancl<EMAIL_ADDRESS>escribió:

Hi @carlos-mora https://github.com/carlos-mora. I'm working on that
right now. If you're interested in helping with this, we can discuss this
in real time on Discord (stancl on Laravel Discord) or Telegram
(@samuelstancl).
I went with $guarded instead of $fillable, because my idea is that by
default, data gets stored in the data JSON column, but developers can
create their own columns for some keys. This is useful when indexes and
similar features are needed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stancl/tenancy/pull/82?email_source=notifications&email_token=AAW4YF3KZHPSTYHEUOHZS5TQDXKGNA5CNFSM4IKOTQV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD37XVSQ#issuecomment-520059594,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAW4YF3PUMRK5TPAZ4RYO33QDXKGNANCNFSM4IKOTQVQ
.

No problem. Thanks for the tips about the public key. Right now the tests are passing for me even though they shouldn't. Seems like the tests still use the Redis storage driver. I will look into that tomorrow. I might end up writing a test class for each storage driver, but that feels a bit unnecessary, so I hope the current tests can cover this well enough.
I'll merge this PR tomorrow and tag a new version so that this feature is released this weekend.
I wanted to add the Telescope tags feature in this release but it's probably not going to be finished soon enough and I'd also like to get some feedback on what's the best way to set tags as a package, ideally from Laravel staff.

Here Carlos reporting !
I'm testing the package by using it, so I'll find some issues.
In Tenant model, it is 'primaryKey', not 'publicKey'
This line in DatabaseStorageDriver crashes:
return Tenant::find($uuid)->only($fields)->toArray();
only() returns an array, so toArray will fail with an "Call to a member
function toArray() on array" error
El vie., 9 ago. 2019 a las 23:24, Samuel Štancl<EMAIL_ADDRESS>escribió:

No problem. Thanks for the tips about the public key. Right now the tests
are passing for me even though they shouldn't. Seems like the tests still
use the Redis storage driver. I will look into that tomorrow. I might end
up writing a test class for each storage driver, but that feels a bit
unnecessary, so I hope the current tests can cover this well enough.
I'll merge this PR tomorrow and tag a new version so that this feature is
released this weekend.
I wanted to add the Telescope tags feature in this release but it's
probably not going to be finished soon enough and I'd also like to get some
feedback on what's the best way to set tags as a package, ideally from
Laravel staff.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stancl/tenancy/pull/82?email_source=notifications&email_token=AAW4YF7P37EBPKQRN7FG57LQDXOABA5CNFSM4IKOTQV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD37ZZYQ#issuecomment-520068322,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAW4YFZ4CKXHSKUBIOOHYWLQDXOABANCNFSM4IKOTQVQ
.

Another update in DatabaseStorageDriver. If no $fields given, only($fields)
returns [], so, according to the RedisStorage bahavoir:
public function getTenantById(string $uuid, array $fields = []): array
{
$fields = (array) $fields;
if (! $fields) {
return Tenant::find($uuid)->toArray();
}
return Tenant::find($uuid)->only($fields);
}
El sáb., 10 ago. 2019 a las 9:16, Carlos Mora<EMAIL_ADDRESS>escribió:

Here Carlos reporting !
I'm testing the package by using it, so I'll find some issues.
In Tenant model, it is 'primaryKey', not 'publicKey'
This line in DatabaseStorageDriver crashes:
return Tenant::find($uuid)->only($fields)->toArray();
only() returns an array, so toArray will fail with an "Call to a member
function toArray() on array" error
El vie., 9 ago. 2019 a las 23:24, Samuel Štancl<EMAIL_ADDRESS>escribió:

No problem. Thanks for the tips about the public key. Right now the tests
are passing for me even though they shouldn't. Seems like the tests still
use the Redis storage driver. I will look into that tomorrow. I might end
up writing a test class for each storage driver, but that feels a bit
unnecessary, so I hope the current tests can cover this well enough.
I'll merge this PR tomorrow and tag a new version so that this feature is
released this weekend.
I wanted to add the Telescope tags feature in this release but it's
probably not going to be finished soon enough and I'd also like to get some
feedback on what's the best way to set tags as a package, ideally from
Laravel staff.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stancl/tenancy/pull/82?email_source=notifications&email_token=AAW4YF7P37EBPKQRN7FG57LQDXOABA5CNFSM4IKOTQV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD37ZZYQ#issuecomment-520068322,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAW4YFZ4CKXHSKUBIOOHYWLQDXOABANCNFSM4IKOTQVQ
.

dd(config('tenancy.storage_driver'), tenancy()->getStorageDriver()); in setUp() shows
"Stancl\Tenancy\StorageDrivers\DatabaseStorageDriver"
Stancl\Tenancy\StorageDrivers\RedisStorageDriver^ {#421

So the issue is that I'm just the config value after TenantManager has been initialized.

The tests now say that the tenants table was not found, so that's good. Should work after I find a way to execute the migration in setUp().

Another touch for Tenant.php model: please add a
public $timestamps = false;
or add $table-timestamps() in Tenant's migration, Otherwise it complains in
the attempt to create a new tenant:

$domain = 'tenant1.portal.local'
=> "tenant1.portal.local"
tenant()->create('tenant1.local')
Illuminate/Database/QueryException with message 'SQLSTATE[42S22]: Column
not found: 1054 Unknown column 'updated_at' in 'field list' (SQL: insert
into tenants (uuid, domain, updated_at, created_at) values
(2fbd0580-bb43-11e9-b9a4-a50e2f24d16e, tenant1.local, 2019-08-10 07:48:04,
2019-08-10 07:48:04))'

El sáb., 10 ago. 2019 a las 9:48, Samuel Štancl<EMAIL_ADDRESS>escribió:

The tests now say that the tenants table was not found, so that's good.
Should work after I find a way to execute the migration in setUp().
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/stancl/tenancy/pull/82?email_source=notifications&email_token=AAW4YFZR4SPZ6DJ3CLNYYNTQDZXGBA5CNFSM4IKOTQV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4AIJ3Y#issuecomment-520127727,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAW4YF67GXSPUWQGWW4RDFDQDZXGBANCNFSM4IKOTQVQ
.


Ability to download a part of the video on youtube

Youtube allow to starts/ends the video where you want without having to download the full video
example:
http://youtube.com/embed/r3CYgOK7n1k?start=83&end=86
Only a part of the video is downloaded, not the whole. It would be nice if youtube-dl could only download a part of the video too.

Even though this issue was reported before https://github.com/rg3/youtube-dl/issues/622, that issue has more replies and more information. Maybe close this one?


bug(parsers): vim.fn.has() isn't being properly checked

In lua/battery/parsers/powershell.lua, the M.check function is checked as if it was a boolean, but it actually returns 0 or 1. This means that if it isn't on Windows, but powershell is executable (like on WSL), powershell will be selected as the method (which causes an error)

Good spot ty will fix

@justinhj um... sorry 😅 #54


Gracefully handle time travels

There are multiple reasons for the logs to appear "out-of-order":

The timestamp was only "MM-DD" until Android 7.0, so every New Year was causing logs to jump back from December to January
Similar to the previous one, some devices were starting with 01.01.1970 system time and only set up a proper time a bit later, so the entries of 01-01 were visible in the logs.
There are time adjustments throughout the year: daylight saving time, user changing timezones, syncing clock, etc.

The logcat itself before 5.0 was prone to printing log entries out of order, because there were separate log sources for each buffer, and logcat was doing timestamp comparison to determine which one to output first. It was solved for the logcat with the migration to a new "syslog" subsystem that stores log entries sequentially.
Andlogview has to collect logs separately in several concurrent logcat invocations, to properly assign buffer names to log entries (system, main, radio, etc). Moreover, ancient Android versions (Cupcake 1.5, Donut 1.6, and maybe Eclair) cannot print more than one buffer at a time anyway, so it is the only available approach there. This requires the tool to solve the issue similar to the logcat's one described above - combine multiple log streams based on the timestamps.
Our current approach is purely timestamp-based and doesn't take time travels into account at all, so the new log entries may be appended to the very beginning of the log. Even the ordering within a single buffer is not respected when merging.  This is problematic.
This issue proposes several improvements:

Never violate the order of the lines within a single buffer (let's call it the buffer order).
If the timestamps contradict the buffer order, then a warning should be present to the user.
(Optional) Add a heuristic to detect the New Year and skip the warning in that case.

NB: #215 tracks switching to use logcat dividers (-D), that allow to retrieve all log buffers in a single command with proper ordering coming from the system's logd. However, the switch is only available since 6.0 (Marshmallow).
This is a more elaborate version of #105 which was closed as non-actionable.

It looks like the kernel logs are still problematic in this regard. I haven't checked the implementation but I can imagine these logs being copied into the logger daemon's storage by some worker with the actual timestamp. This timestamp would be out of order with the other logs:
--------- switch to kernel
2022-01-09 17:27:01.658 I/logd    (    0): logdr: UID=2000 GID=2000 PID=3496 b tail=0 logMask=99 pid=0 start=0ns deadline=0ns
--------- switch to main
2022-01-09 17:27:01.637 W/dmesg   ( 3499): type=1400 audit(0.0:14): avc: denied { syslog_read } for scontext=u:r:shell:s0 tcontext=u:r:kernel:s0 tclass=system permissive=0
--------- switch to kernel
2022-01-09 17:27:07.455 W/healthd (    0): battery l=100 v=5000 t=25.0 h=2 st=4 c=900000 fc=300000 cc=10 chg=
2022-01-09 17:27:10.981 I/logd    (    0): logdr: UID=2000 GID=2000 PID=3500 n tail=0 logMask=99 pid=0 start=0ns deadline=0ns
--------- switch to main
2022-01-09 17:27:10.953 W/dmesg   ( 3503): type=1400 audit(0.0:15): avc: denied { syslog_read } for scontext=u:r:shell:s0 tcontext=u:r:kernel:s0 tclass=system permissive=0
2022-01-09 17:27:12.782<EMAIL_ADDRESS> 393): Failed to getEnergyData

#283 addressed the case when the logs were coming from a bugreport file (dumpstate). The "live" merging is still to come.

Looks like time adjustments are more common than I thought. As expected, the heuristic added in #283 doesn't work well if not all buffers observe the time travel. Maybe we could do a better job by actually looking at timestamps and finding out affected timespans.


WIP: Switch to SCons

It's time.
Closes #324

When you add the run task back in like we have in the Makefile, can you add the following to the Qemu options?
-monitor telnet:<IP_ADDRESS>:1234,server,nowait

Remaining tasks:

[ ] Install Limine to echFS image (create Limine SCons tool)
[ ] Create Limine ISO
[ ] Build & run unit tests
[ ] Get git commit short hash

Is there a way to make targets that the user can invoke like in the Makefile? We need a way to run the kernel in Qemu, so if we can't find a way to do that with SCons, we'll likely need to keep the Makefile.

Is there a way to make targets that the user can invoke like in the Makefile? We need a way to run the kernel in Qemu, so if we can't find a way to do that with SCons, we'll likely need to keep the Makefile.

Yeah that should be possible with a Command

Before merging, the liballoc repo should have the scons branch merged in and this branch update the submodule reference to xyris (with the newly merged SConscript)


Standardise serialization

Standardises the serialisation and introduces json converter to handle deserialisation
Also cleans up some things that were in the area

Need to fix event stream viewer


LNbits Payments failing, yet accounts are still charged

Accounting system debits accounts, but payments never reach LND
On LNDhub, payments list as "payment in transition" but never refund back to account


Setack only works in Python 3.4+ due to a dependency on the enum module

We could either force users to install the enum34 package which back ports enum to earlier versions of Python or roll our own enum module.

My solution is not as full featured as the enum module. But this patch works for all of our use cases.


Support the creation of secrets and ConfigMaps in Cluster Insights

When in cluster mode, it is necessary to create Secrets and ConfigMaps, so your application can use them.
We can update existing secrets, but we can't create new ones, completing the use case.

Suggest we make this a modal which prompts for name, namespace and and a table of key/value pairs as content, with options to upload a file - both for a value and the entire resource. An option to base64 encode values should be available for secrets. Once completed Monokle should directly deploy the resource to the cluster.


rspec_api_documentation breaks with mustache 1.0.4

mustache 1.0.4 introduced initialize method in Mustache class.
You can reproduce by bumping the mustache to v1.0.4 and run the tests:
Failures:

  1) RspecApiDocumentation::Writers::HtmlWriter#write should write the index
     Failure/Error: f.write markup_index_class.new(index, configuration).render

     TypeError:
       no implicit conversion of nil into Hash
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache.rb:282:in `merge'
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache.rb:282:in `templateify'
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache/settings.rb:154:in `template'
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache.rb:108:in `render'
     # ./lib/rspec_api_documentation/writers/general_markup_writer.rb:10:in `block in write'
     # ./lib/rspec_api_documentation/writers/general_markup_writer.rb:9:in `open'
     # ./lib/rspec_api_documentation/writers/general_markup_writer.rb:9:in `write'
     # ./spec/writers/html_writer_spec.rb:29:in `block (3 levels) in <top (required)>'

  2) RspecApiDocumentation::Writers::MarkdownWriter#write should write the index
     Failure/Error: f.write markup_index_class.new(index, configuration).render

     TypeError:
       no implicit conversion of nil into Hash
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache.rb:282:in `merge'
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache.rb:282:in `templateify'
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache/settings.rb:154:in `template'
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache.rb:108:in `render'
     # ./lib/rspec_api_documentation/writers/general_markup_writer.rb:10:in `block in write'
     # ./lib/rspec_api_documentation/writers/general_markup_writer.rb:9:in `open'
     # ./lib/rspec_api_documentation/writers/general_markup_writer.rb:9:in `write'
     # ./spec/writers/markdown_writer_spec.rb:29:in `block (3 levels) in <top (required)>'

  3) RspecApiDocumentation::Writers::TextileWriter#write should write the index
     Failure/Error: f.write markup_index_class.new(index, configuration).render

     TypeError:
       no implicit conversion of nil into Hash
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache.rb:282:in `merge'
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache.rb:282:in `templateify'
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache/settings.rb:154:in `template'
     # /Users/juanito-fatas/.gem/ruby/2.3.2/gems/mustache-1.0.4/lib/mustache.rb:108:in `render'
     # ./lib/rspec_api_documentation/writers/general_markup_writer.rb:10:in `block in write'
     # ./lib/rspec_api_documentation/writers/general_markup_writer.rb:9:in `open'
     # ./lib/rspec_api_documentation/writers/general_markup_writer.rb:9:in `write'
     # ./spec/writers/textile_writer_spec.rb:29:in `block (3 levels) in <top (required)>'

Finished in 0.60184 seconds (files took 0.89167 seconds to load)
287 examples, 3 failures

Failed examples:

rspec ./spec/writers/html_writer_spec.rb:28 # RspecApiDocumentation::Writers::HtmlWriter#write should write the index
rspec ./spec/writers/markdown_writer_spec.rb:28 # RspecApiDocumentation::Writers::MarkdownWriter#write should write the index
rspec ./spec/writers/textile_writer_spec.rb:28 # RspecApiDocumentation::Writers::TextileWriter#write should write the index

This caused our API documents failed to generate. This PR works around it. Not sure what's the best to fix here.
What do you think?

mustache 1.0.4 reverted the change.


SAMZA-1196: Fix TestJmxReporter

@prateekm @navina
Please take a look when you get chance.

@prateekm
Added additional asserts to test metrics reporting through listener.
Thanks.

lgtm! Thanks for fixing this 👍


[Attach link] Chat can be named with restricted symbols if to use them in attachment Title and send to chat without any user-prompt

EPAM AI DIAL chat version
0.10.0
What happened?

Create new conversation based on any model or app which supports an attachment of a link, for example DIAL RAG
Click on Clip icon and select Attach link
Fill in Address field; fill in Title field using restricted chars (restricted chars are =,:;{}/%&) and click on Attach
Don't add any user-prompt and click on Send button
Check the chat name -> it's disabled (ok), because restricted chars are added to the chat name -> bug
Refresh the browser -> DIAL is down

Expected result: chat name should be updated automatically and restricted chars should be changed to spaces.
Please check also that dots at the end are removed
Confidential information

[X] I confirm that do not share any confidential information

Verified on staging env successfully


Upgrade heroku stack

We're on heroku-16 which unpacks to ubuntu 16 and this hits EOL in the spring and we should knock it off

This seems like it should be straightforward – buildpacks aren't impacted, and the main difference is the underlying OS used (Ubuntu 20.04 instead of 16.04). Heroku recommends testing the new stack in a new app, which we could use the staging app for, but should just be that!

Done


Percentage update

Hello,
I have let's say one image to preload, percentage goes 0  - 100, is it possible to have it goes like 0 - 37 - 52 - 84 - 100...
I hope you understand me :)
Thanks

I did it something like this, just add an element in your preload div area and update it on the fly.
$.html5Loader({
onUpdate: function ( percentage ) {
$('.pg-loading-screen .percent').html(percentage);
}
});


Dynamic page recreated on param change

Version
v2.3.4
Reproduction link
https://codesandbox.io/s/yq22jokp0v
Steps to reproduce

Go to /foo/1
Open console
Click Bar 2 link (The link only changes the bar param -> see URL)
Notice in the console that the page is recreated

Reproduction repo: https://github.com/christopheschwyzer/nuxt-dynamic-routes-bug
Deployed also here: https://condescending-bhabha-c04b2c.netlify.com/foo/1
What is expected ?
I understand from the vue-router documentation that the component shouldn't be recreated in such case?
Note: If the destination is the same as the current route and only params are changing (e.g. going from one profile to another /users/1 -> /users/2), you will have to use beforeRouteUpdate to react to changes (e.g. fetching the user information).

What is actually happening?
Page is recreated.

This bug report is available on Nuxt community (#c8385)

Hi @christopheschwyzer , the issue is because the key of RouterView is different in /foo/1 and /foo/2, for now you can specify key to ensure view is same one:
<script>
export default {
  key: '_bar',
  created() {
    console.log("created");
  }
};
</script>

@clarkdo Thank you, works great!
As I'm not sure what the (default) behavior should be I'll keep the issue open - but feel free to close it.

Well, either it has to be well documented or changed ☺
I think such behavior is needed for transitions but I could be wrong.
cc @pi0 (is that behavior intended or even required?)


Proposal: Use Prometheus for scraping & storage

Right now, Heapster performs all the tasks of scraping, caching, exporting to external storage, & REST API for retrieval.
The same metrics that Heapster retrieves via the /stats endpoint on the kubelet are also exposed for Prometheus to scrape via /metrics. How do you feel about Heapster becoming a query & abstraction layer on top of Prometheus to provide Kubernetes semantics to Prometheus timeseries?
Prometheus is also used in a number of other components: etcd & skydns being the two main core Kubernetes ones I can think of straight off.
I fairly recently added Kubernetes discovery to Prometheus so we have all container metrics ingested, as well as application level metrics (future work for Heapster) thanks to the wide range of language plugins & external metric exporters in the Prometheus ecosystem.
Prometheus has export capabilities the same as Heapster (albeit without a GCM sink atm but that should be easy enough to add in).
Alerting, sharding & federation is already built in to Prometheus.
I could see Heapster becoming a REST API to convert Kubernetes semantic queries to Prometheus queries, with Prometheus providing awesome collection & (configurable) short-term storage of metrics.
Comments?

The same metrics that Heapster retrieves via the /stats endpoint on the kubelet are also exposed for Prometheus to scrape via /metrics. How do you feel about Heapster becoming a query & abstraction layer on top of Prometheus to provide Kubernetes semantics to Prometheus timeseries?

As of now, I think prometheus can be one of the backends for heapster.

Prometheus is also used in a number of other components: etcd & skydns being the two main core Kubernetes ones I can think of straight off.

I assume you are referring to metrics being in prometheus format. AFAIK, that was done because prometheus client libs were the most expressive ones as of now.

I fairly recently added Kubernetes discovery to Prometheus so we have all container metrics ingested, as well as application level metrics (future work for Heapster) thanks to the wide range of language plugins & external metric exporters in the Prometheus ecosystem.

This is great. This will definitely be helpful.

Alerting, sharding & federation is already built in to Prometheus.

Do we have any scalability numbers on prometheus?
Prometheus will be a good solution for monitoring.
But I'm not convinced that we should require all Kubernetes clusters to run prometheus.
We need input from users here. We can send out a survey or discuss this in the weekly hangout.
AFAIK, users love and care about their own monitoring systems and requiring them to run prometheus might not be ideal.
One more concern I have is that in the future I want to have heapster optionally store metrics in a crowd-shared database, and use that data for resource prediction purposes. I haven't gotten the time to flesh out this idea completely.

We want kubernetes to have minimal dependencies for bootstrapping purposes.
We will need reliable, low latency access to node resource usage metrics and that is the reason why heapster collects and serves these metrics directly.
Internally, we have never depended on timeseries DB for critical cluster functionalities like scheduling.
In this regard, we can have prometheus serve as the source of non-critical data, which are not time-sensitive.

Since Prometheus has alerting capability, it'd make for a good out-of-the-box experience. However, as a cluster grows in terms of nodes and pods, it becomes a non-trivial task to operate and scale a metric store such as Prometheus, InfluxDB, Graphite, etc. At eBay we have our own monitoring and alerting system, which we're planning to use for Kubernetes. Heapster fits well in this model since all we have to do is to write a sink. How about making Prometheus the default metric store instead of InfluxDB?

@thucatebay Thanks for the feedback! I was thinking of Prometheus in this scenario as a day store, similar to how Heapster operates now, with rules for aggregating metrics as they come in to keep storage & memory requirements low. This would keep the management of it simple but bring with it extra benefits of:

application level metrics (future work for heapster)
persistence (afaik if heapster pod dies you lose all stats which could affect autoscaling)
sharding & federation (future work for heapster)

The only difference for you would be to write an external storage plugin for Prometheus as opposed to a Heapster sink.
It would also mean that those places that don't have their own monitoring & alerting system as you do have would be able to expand the environment by adding in Prometheus alert manager if they wanted, but certainly not a requirement.

I agree that Prometheus is a good candidate for better out of the box
monitoring experience.
AFAIK there is at-least one scenario where we will not run Prometheus -
Google Container Engine.
I'd like to split core-cluster functionalities from monitoring. Disabling
monitoring using heapster is totally fine.
But I don't think we can disable collection and processing of core-cluster
metrics that are required to bootstrap the cluster functionalities like
scheduling.
Even in the case of auto-scaling, I'd imagine us wanting to use curated
metrics.
On Tue, Oct 13, 2015 at 6:39 AM, Jimmi Dyson<EMAIL_ADDRESS>wrote:

@thucatebay https://github.com/thucatebay Thanks for the feedback! I
was thinking of Prometheus in this scenario as a day store, similar to how
Heapster operates now, with rules for aggregating metrics as they come in
to keep storage & memory requirements low. This would keep the management
of it simple but bring with it extra benefits of:

application level metrics (future work for heapster)
persistence (afaik if heapster pod dies you lose all stats which
could affect autoscaling)
sharding & federation (future work for heapster)

The only difference for you would be to write an external storage plugin
for Prometheus as opposed to a Heapster sink.
It would also mean that those places that don't have their own monitoring
& alerting system as you do have would be able to expand the environment by
adding in Prometheus alert manager if they wanted, but certainly not a
requirement.
—
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/heapster/issues/645#issuecomment-147716927
.

@vishh I'm a bit confused, are you saying that currently the heapster addon's presence is required for kube-scheduler to be working properly?

@spiffxp: Moving forward heapster (standalone) will be run by default on all kubernetes clusters. It will be serving the metrics APIs which will be consumed by the scheduler, auto-scalers, etc.
The term addon is a misnomer because other addons like dns are also required for default kubernetes functionalities.

@vishh yeah but how about today?  is this required for proper functioning of v 1.0.x or 1.1.x?

It is not required for v1.0.x.
It is required for beta features in v1.1.x.
On Tue, Oct 13, 2015 at 4:03 PM, Aaron Crickenberger <
<EMAIL_ADDRESS>wrote:

@vishh https://github.com/vishh yeah but how about today? is this
required for proper functioning of v 1.0.x or 1.1.x?
—
Reply to this email directly or view it on GitHub
https://github.com/kubernetes/heapster/issues/645#issuecomment-147878257
.

There seems to be pretty close coupling to prometheus on the metrics front already.  sorta seems like overkill to maintain a separate timeseries framework ?  but i see both sides of the coin here.

What's the current state of this? I've read the vision document, but it's still not clear if there is or will be support for Prometheus as a sink for heapster. It's confusing that Prometheus has emerged as the go-to monitoring system for Kubernetes, especially given that it's also a member of the CNCF, and yet when you deploy the cluster monitoring addon for Kubernetes, it uses an InfluxDB sink for Heapster, plus Grafana for visualizations. This means that cluster operators who want metrics with a larger scope than Heapster is intended for must maintain two separate time series databases.

We're currently transitioning away from Heapster as the defacto solution, as per the new monitoring vision in the community repo.  One of the results of that will be an end-to-end setup with Prometheus that does not involve Heapster.

(in light of that, I'm closing this issue)

@DirectXMan12 "We're currently transitioning away from Heapster as the defacto solution, as per the new monitoring vision in the community repo." - do you have any references /docs for that (I guess it's not the vision doc mentioned above since that one refers to heapster)

https://github.com/kubernetes/community/blob/master/contributors/design-proposals/monitoring_architecture.md should be what you're looking for.

The links is dead :-(
Any mirror available?
I'm currently trying to find out whats the standard / best practice monitoring solution which is used in Kubernetes.
I thought its Cadvisor + Prometheus. Then i've read about Heapster which seems to be dead regarding @davidkarlsen post.
I'm a bit confused now. Where to start?

try https://github.com/kubernetes/community/blob/master/contributors/design-proposals/instrumentation/monitoring_architecture.md
https://github.com/kubernetes/community/pull/1010 shuffled around the contents of the design-proposals dir


include all item data in the return?

For easier model relations
https://github.com/jessinthecloud/ValheimJsonExporter/blob/423b5f6863ba4ea2eef7fd3ff2fa55d815bdc55a/ValheimJsonExporter/Docs/RecipeDoc.cs#L44

I don't remember what this means tbh


'metaclass' fix applied

Converts the old metaclass syntax  (__metaclass__ = Meta in the class body)
to the new (class X(metaclass=Meta)).

@vilnius-dev. there is an error
Traceback (most recent call last):
File "", line 1, in
NameError: name 'Singleton' is not defined

I made new PR where I moved Singleton class into Utils module. The PR https://github.com/dmwm/WMCore/pull/8116 and it will affect or diminish this one.

duplicate #8116


Build cleaning, nothing too significant

more than nothing

close to being useful to patch release because of the PDQm 3.0 reference, but discussion indicated it is not really worth it yet.


Document how to use git submodule

Do you prefer the tr;dr version:
https://github.com/alamofire/alamofire#embedded-framework
Or the ask Google version?
https://github.com/thoughtbot/Argo#git-submodules

I think that should follow as much as possible the same description as the CocoaPods, Carthage... only the strict necessary. If we want to do the tr;dr, we should do it for each sort of installation.

Thanks @lexrus I took the ask Google version. If the user wants to use git submodules, should be able to do it by themselves.


Add datetime to cloudwatch's alarms

it appears in template's response but it didn't have it in model.
Boto3 needs a non-empty date.
Best.

Coverage decreased (-0.05%) to 95.389% when pulling 7540b5f6a64b5521062e01f51499ded9fca0b7b1 on beeva-antonioirizar:cloudwatch_datetime into 1ece8131311d372178337b3737805603088bcee5 on spulec:master.

thanks!


can not find the service "kube-dns"

when  deploy edgemesh on my server i got the error "cannot find the service kube-dns",so i review the code and find that in the iptables module, the function "creatIgnoreRules" will list the service "kube-dns",this service is not deployed on my server,and why we need this service?

/close


Add support for including upload summary

Adds include-summary arg, defaulting to true, to show this summary

From the design side, I think we could probably simplify the UI

Status
Replay

⬆
breakpoints-01

💾
breakpoints-02

❌
breakpoints-03

I don't think the icons add clarity alone but collapsing the link into the title is reasonable.

Yeah - that's fair.

Now:
Replay Uploads
TitleStatuscypress/e2e/cast-alias-spec.tsonDiskReplay of ts-nodeuploaded


segmentation fault

Spotify Ripper - v2.9.1
  Encoding output:	MP3, VBR 0
  Spotify bitrate:	320 kbps
  Unicode support:	Yes
  Output directory:	/home/ramonskie
  Settings directory:	/home/ramonskie/.spotify-ripper
  Format String:	{album_artist}/{album}/{artist} - {track_name}.{ext}
  Overwrite files:	No
[1]    15398 segmentation fault  spotify-ripper -k Downloads/spotify_appkey.key -u xxxxxxxx

any idea's?

ah i see in https://github.com/hbashton/spotify-ripper/tree/master/Vagrant
that there is a bug that you need to run it as sudo

I got the same problem. Only when executing it with sudo it's works normally. Any idea how to run it as a normal user?


How to better represent dense regions with VCF

This is a question raised from https://github.com/rmcolq/pandora/issues/260 . A VCF record produced by pandora from a very dense region can be downloaded here . This record suffers from readability and interpretability issues (e.g. the VCF record itself has 456k characters), being hard for human and also other tools to consume. IIRC, pandora only outputs alleles that are present in at least one sample. In this case, we have 20 samples and 450 alleles, which makes it really hard to understand what is being genotyped. I guess this is probably due to small variants that are close together, and got merged. I think we need to debug what is the case here: maybe the ML path does not go through these small variants, so they had to be all linearised and described as ALTs in this record; maybe the default nesting level for the PRG was too small to describe such dense region (in this case, if we increased the nestedness, we could be able to break this dense region), etc.
One alternative solution for this case also is to simply output only the genotyped alleles (but I am not sure this is a good practice).
Happy to hear if this is indeed an issue, and of alternative solutions

I think outputting only genotyped alleles by default would make a lot of sense. I am currently always normalising the pandora VCFs to get around this. We could then have a flag to output all alleles (as we do currently) in the cases where people want that extra info.


Support adding SSH key for AL2

Tell us about your request
We need the ability to choose ssh key for AL2 instances.
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Choosing the SSH key from the Probisioner spec, or the AWSNodeTemplate
Are you currently working around this issue?
We need to use the AWS UI to open SSH connection to the instances.

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Looking at https://github.com/aws/karpenter/issues/1807
I'm closing this issue.


The blur method of 'md-input' not work

Try to add a blur method to 'md-input' component, but it seems not work.
<md-input type="email" v-model="email" @blur="fieldValidation"></md-input>
Does not it support this usage?

Oh. Should support, right. I can confirm that the blur, focus, input, and keyup events aren't working. I will fix this ASAP.

Well. As you can see on the Vue.js migration guide all the "native" browser events on custom components (like md-input) should be used with .native modifier:
<md-input @focus.native="handler"></md-input>

@marcosmoura Thanks a lot. 👍


certmgr-selfsigned: fix fetchpatch hash

Description of changes
certmgr and certmgr-selfsigned was merged during the bump from v1.6.4 to v3.0.3, but on 23.11 certmgr is left broken as noted in https://github.com/NixOS/nixpkgs/pull/271299#issuecomment-1842064267.
Instead of bumping the version on 23.11 to v3.0.3, this PR fixes the hash of the patch applied.

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build certmgr-selfsigned


[RHODS-1.32] CVE 44487: Upgrade ubi package libnghttp2 to fix http2 cve

CVE 44487: Upgrade ubi package libnghttp2 to fix http2 cve
Based on the update:

https://catalog.redhat.com/software/containers/ubi9/python-39/61a61032bfd4a5234d59629e?architecture=amd64&image=65301f5a53a51a886582fba1&container-tabs=security
https://catalog.redhat.com/software/containers/ubi8/python-38/5dde9cacbed8bd164a0af24a?architecture=amd64&image=64cab6d204b5b858e24f2f62
as the ubi8 doesn't have fix, using dnf to update the packages.

Just thinking - wouldn't be safer to actually update just the minimal necessary set of packages to fix the issue here?

Merging for the backporting.
Thanks.


Cannot sign in with microsoft for tunnel

Does this issue occur when all extensions are disabled?: No (Extension Bisect found nothing)

VS Code Version: 1.93.1
OS Version: Windows 11

Steps to Reproduce:

Start VSCode.
Turn on Remote Access.
Sign in with Microsoft.
Let explorer window open and message "You are signed in now and can close this page." appear.
Now your VSCode is not logged in and the "with Microsoft" button is no longer responsive.

I updated the VSCode version to 1.93.1 and tried removing the Code folder from Roaming.
Same issue.

I think this might be fixed in the Insider build: http://code.visualstudio.com/insiders/
which means it might be fixed in the next stable build targeted for next week.
Can you give it a try?

Tried the insider version but it is also stuck

what happens if you hit Cancel? You should get a dialog that says something like "do you want to try another way?" that will try to do the flow a different way.

If I hit Cancel the popup window goes away but nothing else appears. Also the "Sign in to tunnels registered with Microsoft" is no longer responsive so I have to restart VSCode to try again.

ok, can you give me the contents of the Microsoft Authentication Output Channel:

These are the logs. Btw there are no relevant access tokens that can be exploited in here. Right?

Do you have a network proxy?

My company does use a security service from Netskope Inc which passes all the data through a proxy.

We've had some Proxy related issues recently, so this checks out.
Ok, also can you give me the Insiders version info? Should be in one of the top level menus... maybe "Help".

Version: 1.94.0-insider (user setup)
Commit: be2747e47e127ec674148b78dd9556c6317d18bd

Can you also try turning on this MSAL setting... it uses a different network stack and might work for you. You'll need to reload VS Code after you apply that setting.
(in case the link doesn't work, the setting is microsoft.useMsal)

It works with that on. Thanks.

Glad to hear. That's the future of Microsoft Authentication in VS Code.
You can turn that setting on in the Stable release next week. The setting might be in 1.93... but if it's there, that code is suppppper buggy. I highly recommend not using it until 1.94 comes out.
If you can stick to Insiders until 1.94 is released, that's ideal.

@chrmarti I'll let you decide what to do here, that workaround of using electron's fetch seemed to work in some scenarios but still doesn't fully solve the problem as seen in this issue.

@TylerLeonhardt How is using MSAL different in terms of network requests?

@chrmarti take a look here:
https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-node/src/network/HttpClient.ts#L20
You can see they wrap https in a bunch of proxy related logic.

@moyamejiasr Could you turn that setting off and start VS Code Insiders with --log-net-log=netlog.json, retry the failing login and then post the created netlog.json here?

netlog.json

VS code tunnels used to be rock-solid but are now horribly unreliable. See here: https://github.com/microsoft/vscode/issues/230058


Bug: endStroke event does not trigger if mouse movement ends outside of the pad

Bug:
The endStroke event does not seem to trigger after a line, if the end of the line is outside of the canvas.
(Edit:
I've now tested it on mobile; it's not a problem, the touch works fine. Only the desktop/mouse combo causes this issue as far as I can tell.)
The code otherwise works in our environment very nicely.
I've tried to set up a jsFiddle, however I have to admit defeat. I've run into an error I can't fix:
"signaturePad.addEventListener is not a function"
https://jsfiddle.net/brandywine/wfp923oa/28/
(I've tried wrapping it into window.onload, to no avail - there must be something I don't know about jsFiddle here)
p.s. If someone could enlighten me what is the problem in jsFiddle, I'd really appreciate it :)

Looks like you were using v3.0.0-beta event listeners were added in v4
https://jsfiddle.net/UziTech/mh1yewfx/1/

Thanks for that!
To add some value, too: I've identified a work-around that works well to mitigate this issue:
canvasElement.addEventListener("mouseout", copyData);

The only problem with mouseout is it will trigger when you leave the canvas even if you come back without lifting up your mouse and continue drawing.

Yeah, where I want to use it - update preview and copy the value out - it's perfectly good.

This was a quick fix, well done guys!


Merge optimization by fast forwarding ranges

The merge operation receives two metaranges source-metarange destination-metarange  and finds the base-metarange.
The merge operation creates a new metarange which is done by a three-way diff.
The merge operation is currently optimized by skipping ranges that are identical in source and destination
Example
Let's consider the following metaranges:
base-metarange

range_id
min_key
max_key
count

1
path_a/
path_a/z
50

2
path_b/
path_b/z
50

3
path_c/
path_c/z
50

destination-metarange

range_id
min_key
max_key
count

1
path_a/
path_a/z
50

4
path_b/
path_b/z
50

3
path_c/
path_c/z
50

source-metarange

range_id
min_key
max_key
count

1
path_a/
path_a/z
50

5
path_b/
path_b/z
55

6
path_c/
path_c/z
55

When creating the merge-metarange

The merge operation will write range 1 to merge-metarange without the need to read and compare
The merge operation will read range 2, range 4 and range 5 and create a new range (or ranges)  containing the merged objects
The merge operation will read range 3 and range 6 and create a new range (or ranges)  containing the merged objects

Step 1 is optimized.
Suggestion
Currently the optimization works only when source-metarange and destination-metarange have the same range ID.
We could also optimize the following cases:

source-metarange and base-metarange have the same range_id, max_key and min_key -> use the range in source-metarnage
destination-metarange and base-metarange have the same range_id, max_key and min_key -> use the range in source-metarange

In the example we would optimize step 3 by writing range 6 with the need to read the ranges

This issue should fix many cases of #2690

Compare the range_id - source/base or destination/base should be enough as it the hash of the content, right?
In case of the new optimization (source/base matched) in order to use the destination we still need to match the min/max with the destination? do we need to continue taking ranges from destination until we reach to the min/max which is out of the source range?

@nopcoder, both points are true.
In order to make this issue less complex, the optimization would work only for ranges with the same max_key and min_key. It could be optimized even more as you suggest in 2.
Given the fact that most of our ranges tend to break at fixed locations, I think we should start with the simple case.


rename only the property name in a property assignment

Issue #41
Only renames the child identifier if it is the same as the property name of its parent:
interface PropertyDeclaration extends Declaration, ClassElement {
        name: DeclarationName;
        questionToken?: Node;
        type?: TypeNode;
        initializer?: Expression;
}

interface PropertyAssignment extends ObjectLiteralElement {
        _propertyAssignmentBrand: any;
        name: DeclarationName;
        questionToken?: Node;
        initializer: Expression;
}

interface FunctionDeclaration extends FunctionLikeDeclaration, Statement {
        name?: Identifier;
        body?: Block;
}

interface MethodDeclaration extends FunctionLikeDeclaration, ClassElement, ObjectLiteralElement {
        body?: Block;
}

LGTM, merge after taking care of few nitpicks.

merged


Wrong Accept Header

Your API have a wrong Accept Header
 payload.req.headers = {
	        'Content-Type': 'application/vnd.api+json',
	        'Accept': 'application/vnd.api+json'
	      }

Accept should be e.g. application/json otherwise it returns a 406 Not Acceptable
see Specification: http://jsonapi.org/format/#content-negotiation-servers

Hotfix
jsonApi.headers['Accept'] = 'application/json';

I'm not following, the spec on my reading states that this is the right Accept header and looking at some other client implementations (e.g. https://github.com/emberjs/data/blob/a4b7b7095a07ba43f3e1aa8075d1d168ca9638d8/addon/adapters/json-api.js#L183) I see them doing the same thing.

The JSON API spec defines the correct Accept header as the following:
http://jsonapi.org/format/#content-negotiation-clients

Clients MUST send all JSON API data in request documents with the header Content-Type: application/vnd.api+json without any media type parameters.

Clients that include the JSON API media type in their Accept header MUST specify the media type there at least once without any media type parameters.

Clients MUST ignore any parameters for the application/vnd.api+json media type received in the Content-Type header of response documents.


Enable numbers, white space and backspace

Currently, if you do a typo while writing a macro name and you use backspace to remove the error, the program won't detect it, and will show it up as the complete macro name.
For instance, if you try to write "test" but you type "tesd", you realize it and you use backspace to correct it to "tes", and finally end up with "test", the program will still read "tesdt".
The numbers is something basic, only need to add the hexadecimal key values to the if.


add empty default for source maps, closes #361

This upstreams the fix noted by @Aristona here, which addressed that issue for me as well (ionic-app-scripts@0.0.45).

I also solved this issue by reverting my Typescript version to 2.0*. It would be better if we fix the problem underneath by making sure it returns an array instead of undefined.

Sorry, this is not something we plan on doing.
Thanks,
Dan


Tmux installation step

In the step about configuring Tmux cp .tmux.conf ~/, I think that the refered file isn't in the repo. Should I found it in other repo?

Please add the file in our repository

Added by 1524b822437a28b173da33260f5ddeeb73754ddc


fix: use the new uses syntax

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign jstrachan
You can assign the PR to them by writing /assign @jstrachan in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstrachan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jstrachan: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test kube

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test kube

gsm
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test kube

gsm
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test gsm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test kube

gsm
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test gsm

vault
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@jstrachan: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

kube
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test kube

gsm
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test gsm

vault
3e4eb784a3dd35ccda232495e25f3daea8e968fd
link
/test vault

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

/test kube

/test kube

/test ghe

/test ghe


Trying fix for line position updater when reading from ins.

Previously could run into issues if repeat values existed in line.

Coverage decreased (-0.02%) to 78.515% when pulling c51c413893318c07a9bf39d25dcae69b76c159c5 on briochh:hotfix_insobs_parser into b2fff9db84416a356c3becbab63faf2f9cfd654f on jtwhite79:develop.

Coverage decreased (-0.02%) to 78.515% when pulling c51c413893318c07a9bf39d25dcae69b76c159c5 on briochh:hotfix_insobs_parser into b2fff9db84416a356c3becbab63faf2f9cfd654f on jtwhite79:develop.


onEdit event

Is there an event or anything similar which would allow me to act when user starts editing content. To be precise, I'm trying to replace content being edited when user clicks on edit button (doing some cleanup in the code). Tried to hook to click event of the edit button (.ct-ignition__button--edit) but it's not really working (content is replaced but the editor is not working).
Same goes with the "onCancelEdit" event. I'd need to revert original content if user cancels editing.

Nevermind, found it :) http://getcontenttools.com/api/content-tools#editor-app


[Fix #1608] Add 'align_braces' style for Style/IndentHash

'align_braces' style is like:
  hash = {
           'key' => 'value',
           'another' => 'value'
         }

I personally don't like this style much, but I can see why some people would (as demonstrated by #1608), and think it is a reasonable choice and one which is good to support.
The (slightly) tricky part was getting --auto-gen-config to keep working robustly, now that Style/IndentHash has 3 styles rather than 2. This meant taking the previous work I did on ConfigurableEnforcedStyle a step further and fully generalizing it to deal with multiple, partially-overlapping styles.
Fixes #1608.

Fixed the style problem.

Can someone make these Coveralls checks just stop?

Can someone make these Coveralls checks just stop?

From time to time they've helped us uncover some real issues with coverage. At any rate - we deserve a better code coverage service. :-)

OK, thanks. Regarding the outstanding PR... I suggest you cut the new release first. That one will take a bit of time. There are other issues I want to resolve first.

Fair enough. It's definitely not particularly important.

@alexdowad I really, really appreciate this.  This is my favorite style.  How much work would it be to make IndentArray do basically the same thing?

I really, really appreciate this.

Thanks for expressing appreciation! We are glad that RuboCop is useful to you.

How much work would it be to make IndentArray do basically the same thing?

:laughing:
How much work would it be? Well, I'm not really sure... but if you give it a try, you will find out!
...I think what you're trying to say is: "Please do this." Does that sound right?

@alexdowad I'm trying to say "How much work will it be?" so that if you say "a lot" I won't bother asking. 😉 if you say "really easy" either I can do it, or ask you. 😂

@jfeichner Have a look at the commit where this style was introduced for hashes (https://github.com/alexdowad/rubocop/commit/093141016a2687e5c206c5252cf77eef1c23f7b8). It will probably be about the same.
If you open a GH issue, I will work on it if I have time (and you don't get to it first).

@alexdowad :+1: :smile:


[ISSUE #1927] Fix parparameter transformation cannot get form data afte…

when custom add form data with param_plugin, ParamTransformPlugin cannot get.
Fixes #1927

Codecov Report

Merging #1931 (d8d1aa7) into master (6768b1c) will decrease coverage by 0.27%.
The diff coverage is 80.00%.

@@             Coverage Diff              @@
##             master    #1931      +/-   ##
============================================
- Coverage     63.90%   63.62%   -0.28%
+ Complexity     3950     3947       -3
============================================
  Files           573      573
  Lines         16712    16716       +4
  Branches       1594     1592       -2
============================================
- Hits          10679    10635      -44
- Misses         5182     5228      +46
- Partials        851      853       +2

Impacted Files
Coverage Δ

...pache/shenyu/plugin/base/ParamTransformPlugin.java
70.45% <80.00%> (+0.18%)
:arrow_up:

...enyu/client/tars/TarsServiceBeanPostProcessor.java
54.41% <0.00%> (-35.30%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
63.10% <0.00%> (-11.66%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
58.94% <0.00%> (-5.27%)
:arrow_down:

...che/shenyu/admin/model/vo/SelectorConditionVO.java
96.07% <0.00%> (-1.97%)
:arrow_down:

...shenyu/sync/data/consul/ConsulSyncDataService.java
66.10% <0.00%> (-1.70%)
:arrow_down:

...rg/apache/shenyu/plugin/hystrix/HystrixPlugin.java
74.07% <0.00%> (-0.93%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
82.92% <0.00%> (-0.82%)
:arrow_down:

.../plugin/grpc/loadbalance/AbstractLoadBalancer.java
69.56% <0.00%> (-0.33%)
:arrow_down:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6768b1c...d8d1aa7. Read the comment docs.


WFLY-10027 Provide metric attribute to see max number of concurrently…

… active sessions for deployment
https://issues.jboss.org/browse/WFLY-10027

Retest this please


Sticky States Deep State Redirect

It would be nice if you were already within a deep state and the state changed to the parent url that it would disregard the deep state.
For instance in the demo. If I click on the customers tab then click on a customer name, then click on the customers tab again it seems logical it would go back to the customers listing which it currently doesn't. If I was viewing a customer and clicked on customers tab from another state it should redirect back down to the customer though which it currently does.
Not sure if that's possible or not though.

I want to use this feature as well, but have the following situation:

Tab clicked first time -> go to default state "feed"
Tab clicked later on again -> dsr to the last active state
Tab clicked twice -> go to default state "feed"

When using the dsr object for the definition there is a property "default" to set a default state but how can I realise this using a dsr function for the definition?

I got it running by adapting the example of the homepage
deepStateRedirect: {
        default: { state: "foo.bar.baz.defaultSubState", params: { defaultStateParam1: "99" } },
        params: true,
        fn: function($dsr$) {
            var shouldRedirect = // TODO finish docs;
        }
}

In this example the current state was missing to be able to realise my use case (since $dsr$ only contains the "to" and "redirectTo" state). Then I noticed thats it's possible to simply inject the $state parameter:
deepStateRedirect: {
      default: { state: 'home.feed.list' },
      fn: function($state) {
        return $state.includes('home.feed.*') ? {state: 'home.feed.list'} : true;
      }
}

Hi, I did as mentioned with my tabbed app
$stateProvider.state({
sticky: true,
deepStateRedirect: function($state) { return !$state.includes(this.name); },
and it works so that I can go back from the sticky state substate (child) back to the stick state (parent), however, it introduces another bug.


Support all Robot Framework time formats (#65)

Resolves #65
Todo:

[x] Implement feature
[x] Write utests
[x] Update docs
[ ] Fix atests

Codecov Report

Merging #66 (37b4093) into master (76b589d) will decrease coverage by 6.84%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   94.77%   87.93%   -6.85%
==========================================
  Files           4        4
  Lines         574      580       +6
  Branches      105      105
==========================================
- Hits          544      510      -34
- Misses         26       65      +39
- Partials        4        5       +1

Flag
Coverage Δ

acceptance
?

unit
87.93% <100.00%> (+0.12%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

Mainframe3270/__init__.py
94.44% <100.00%> (-5.56%)
:arrow_down:

Mainframe3270/x3270.py
100.00% <100.00%> (ø)

Mainframe3270/py3270.py
74.43% <0.00%> (-14.33%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b589d...37b4093. Read the comment docs.


Program modification

hello, I took the liberty of modifying the programs to allow users to have clickable links, so I created a new button on the basis that you already had, I created a way to put hypertext links so that the users is a means of contact for the support same for the contact support I have created a clickable telephone number and a link
SelfX (2).zip

This was nice! Thank you!


Rework styling on taxonomy visualisation

Make the ends of branches fold inwards when displaying taxons at the
very left or very right of the visualisation. This removes the
impression that the taxonomy appears 'cut-off' and incomplete either
side.
Remove the unnecessarily long border above or below the taxon in focus
when there is only one parent or child node.

reopening this on a different branch.


How to upgrade to version 2.0+?

Hello.
We are using<EMAIL_ADDRESS>for a very long time. I see that you published a new major version, is there any upgrade guide for that?
Thanks.

Version 3 is ready now! The old components have to be migrated:
Component docs:
https://coreui.io/react/docs/
You can also lookup template v3 for example uses


the component file structure doesn't make sense anymore

the file structure doesn't match the app anymore.

[ ] reorganize files and folders to match app

one option...
/common
/balances
/transactions
/delegates
/proposals
/validators
/blocks

vs.
/common
/govern
/monitor
/staking
/wallet

Is this still an issue? How do you feel about this @nylira ?

Let's leave this as-is for now. It's not important, and we have to switch it again later.


Fix batch_matmul to avoid ZeroDivisionError in GPU mode

The batch_matmul (in GPU mode) uses  strides[0] of an input array as a divisor in _mat_ptrs (i.e. the third argument of cuda.cupy.arange).
https://github.com/pfnet/chainer/blob/master/chainer/functions/math/matmul.py#L23
And strides of ndarray will be 0 when it is a broadcasted array because of rule 4 of the ufunc’s broadcasting rules.
http://docs.scipy.org/doc/numpy-1.10.0/reference/ufuncs.html
So, ZeroDivisionError will happen.
A = chainer.Variable(xp.random.random((3, 2, 4), dtype=np.float32))
B = chainer.Variable(xp.random.random((4, 6), dtype=np.float32))
B = F.expand_dims(B, 0)
B = F.broadcast_to(B, (3, 4, 6))
print(B.data.shape, B.data.strides)     # —> (3, 4, 6) (0, 48, 8)

C = F.batch_metmul(A, B)  # ZeroDivisionError (only on GPU mode)

We can fix the strides by simply copying the ndarray.
b = xp.random.random((4, 6))
b = xp.expand_dims(b, 0)
b = xp.broadcast_to(b, (3,4,6))
print(b.shape, b.strides)   # —> (3, 4, 6) (0, 48, 8)
_b = b.copy()
print(_b.shape, _b.strides) # —> (3, 4, 6) (192, 48, 8)

By the way, I don’t know hot to write a test code for this case.
First I tried the following code but it causes error because the numpy’s broadcast_to returns read-only array.
class TestBatchMatMulBroadcastedMatrix(_TestMatMul):

    def setUp(self):
        self.x1 = numpy.random.uniform(
            .5, 1, (batch_size, m, k)).astype(numpy.float32)
        x2 = numpy.random.uniform(.5, 1, (k, n)).astype(numpy.float32)
        self.x2 = numpy.broadcast_to(
            numpy.expand_dims(x2, 0), (batch_size, k, n))
        self.gy = numpy.random.uniform(
            -1, 1, (batch_size, m, n)).astype(numpy.float32)
        self.op = lambda x, y: F.batch_matmul(x, y)
        self.forward_answer = numpy.array([
            numpy.dot(self.x1[i], self.x2[i])
            for i in six.moves.range(batch_size)])

I actually ran into this issue as well.
I think systematically copying the data as you propose would create some performance issues. It should be possible to solve this problem without the copying. Actually, for such cases, I have a workaround by using F.matmul (the non-batch version) and F.reshape
In the case of your first example, the intended behaviour can be obtained this way, without copying (did not try to run this code, but I think it should work...)
A = chainer.Variable(xp.random.random((3, 2, 4), dtype=np.float32))
B = chainer.Variable(xp.random.random((4, 6), dtype=np.float32))

A_reshaped = F.reshape(A, (6,4))
C_reshaped = F.matmul(A_reshaped, B)
C = F.reshape(C_reshaped, (3,2,6))

Still, it would be good if batch_matmul could do the right thing when there is some broadcast happening.

Please add tests.

Sorry for my late response.
@fabiencro Oh, I didn’t notice that !!
It’s a nice solution, thanks for your suggestion :)
@okuta I pushed some changes, please check it!

Thank you!
LGTM!


Revert 2 leila rashidi patch 2

Applied all comments of Dr. Shu about the previous Kestrel analytics for lateral movement detection.

Hi @leila-rashidi , what's the difference between this PR and #19 ?


Rename Code of Condunct.md to Code of Conduct.md

(nitpicking me)

Good catch, thanks! Once merged, Aeryn should invite you to the org, fingers crossed 😄

Ha, nope 😬 I'll open an issue. Thanks again!

I've opened an issue, going to look at the logs and try to re-deliver the hook.

Thanks a lot for contributing to Moya! I've invited you to join the Moya GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions.

Okay, well it looks like it's working now, thanks for being a test subject :) Really gotta get on #1...

I actually hoped to become a test subject. 👍 Love the idea!


How to use?

I have read ur program  instructions but I can't understand is this a tunnel or a vpn?The server why has subnet?If just a tunnel,I just need 2 ports not a subnet address.If I need a VPN,I will create by myself.

Phantun is not a VPN, it only proxies specific UDP traffic, the IP addresses are needed for the Tun interface to talk with the Internet. Only fake TCP traffic goes through the Tun interface because only the listening ports are NATted by iptables to it (so essentially, it only uses a single port from your host IP).
Without the private IP address, you will have to dedicate an Internet routable IP address just for Phantun to listen, which is probably not what you want.
The diagram on README.md should explain this well.

Phantun is not a VPN, it only proxies specific UDP traffic, the IP addresses are needed for the Tun interface to talk with the Internet. Only fake TCP traffic goes through the Tun interface because only the listening ports are NATted by iptables to it (so essentially, it only uses a single port from your host IP).
Without the private IP address, you will have to dedicate an Internet routable IP address just for Phantun to listen, which is probably not what you want.
The diagram on README.md should explain this well.

I can understand ur diagram, but I don't know how to use.So I just wanna this server listen at <IP_ADDRESS>:4000 and outgoing port is <IP_ADDRESS>:5000.So how add Iptables.

Server --listen option is where server listens for Phantun client to connect. Server --remote is where server forwards UDP packets to. Client --listen option is where Phantun client listens for incoming UDP packets, and client --remote is where Phantun server can be reached at.
https://github.com/dndx/phantun#2-add-required-firewall-rules and
https://github.com/dndx/phantun#4-start-phantun-daemon
shows how to set those rules. If you need to change the port number, you can just change the port inside the iptables rules accordingly.

Server --listen option is where server listens for Phantun client to connect. Server --remote is where server forwards UDP packets to. Client --listen option is where Phantun client listens for incoming UDP packets, and client --remote is where Phantun server can be reached at.
https://github.com/dndx/phantun#2-add-required-firewall-rules and
https://github.com/dndx/phantun#4-start-phantun-daemon
shows how to set those rules. If you need to change the port number, you can just change the port inside the iptables rules accordingly.

I just need DNAT on server?I already set SNAT at client,bcz my client is PPPOE

Sorry, compare phantom and Udp2raw,the firewall rules too different.

@Handsome1080P Yep, you only need DNAT for Server, and SNAT for Client. It is very different from udp2raw as you don't need to drop anything. Everything are simply NATs. You do need IP forwarding enabled though.
Treat Phantun Server as a server with private address in the LAN and you want to expose the port to the Internet, and Client as a machine behind a router in private LAN. It should make more sense that way.

And what's the meaning of this:
For Client, Phantun assigns itself the IP address <IP_ADDRESS> and for Server, it assigns <IP_ADDRESS>

@Handsome1080P Phantun client will use the IP <IP_ADDRESS> when contacting the outside, which is why SNAT is needed (this IP probably doesn't matter for firewall rules, you can simply masquerade).
Phantun server will listen on <IP_ADDRESS>:PORT for incoming connections, which means you need to DNAT PORT to <IP_ADDRESS>.
Those IPs are currently hard-coded, but you will see them on the tun interface after Phantun starts using ip a.

@Handsome1080P Phantun client will use the IP <IP_ADDRESS> when contacting the outside, which is why SNAT is needed (this IP probably doesn't matter for firewall rules, you can simply masquerade).
Phantun server will listen on <IP_ADDRESS>:PORT for incoming connections, which means you need to DNAT PORT to <IP_ADDRESS>.
Those IPs are currently hard-coded, but you will see them on the tun interface after Phantun starts using ip a.

So it will create a tun interface?Can rename it?

@Handsome1080P You don't have to, it is automatically created/deleted as the program starts/quits.
If you are worried about the name for the interface changing, the DNAT rules don't need the interface names, only the IP address <IP_ADDRESS> and Kernel will figure out which interface it is on.

@Handsome1080P You don't have to, it is automatically created/deleted as the program starts/quits.
If you are worried about the name for the interface changing, the DNAT rules don't need the interface names, only the IP address <IP_ADDRESS> and Kernel will figure out which interface it is on.

I just wanna a certain name,bcz I already have 4 Tun interfaces.I don't wanna the interfaces name is confusion

@Handsome1080P That makes sense as a feature request and I will probably add it later. If you are worried, you can create a systemd file that starts Phantun the last, so it will not be mixed with your other Tun interfaces.

@Handsome1080P That makes sense as a feature request and I will probably add it later. If you are worried, you can create a systemd file that starts Phantun the last, so it will not be mixed with your other Tun interfaces.

thx a lot.

I added some more explanation of topology in https://github.com/dndx/phantun/commit/e3e50f8a9ecb5482e7fdefc86649af9f03dcbc34 as well to help other people in the future with similar questions.


Waypoint Jquery Code Bug

Challenge http://www.freecodecamp.com/challenges/waypoint-target-html-elements-with-selectors-using-jquery has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
Code is not properlly formed. Instead of script tags it has "fccss" and "fcces" (which I gess stands for FCC Start Script and FCC End Script)
(What it shows when you reset the code)

Following waypoints with the same problem

Issue closed because was already pushed on commit 27cac3067a


Add print styles to components

When simulating print mode on components most don't have the necessary adjustments.

Edit:
Spike that was done: https://github.com/alphagov/govuk-frontend/compare/spike-print-styles

@36degrees I think our users such as GOV.UK Publishing will run into this pretty soon.

@36degrees I think our users such as GOV.UK Publishing will run into this pretty soon.

Trello ticket: https://trello.com/c/mlBn52Wg/1395-design-print-styles-for-components

👍  on this.
When developing the accordion component, we had an interesting debate about whether, when printing a page, all of the accordions should be "opened" or not. My conclusion was that it probably made sense to keep them in the same state as the page, as the user may only want to print some of the sections (and if they really wanted to print them all then that’s fairly easy to do via the "Open all" button).

The HMRC PAYE (classic) service has recently switched to using the design system GOV UK. The application offers users the ability to view-and-print previous years submissions - we use the check answers pattern to "play back" submitted details and provide a (JS) print button to open a print dialogue * note screenshots show test data*:
Page screenshot:

Printing in chrome:

We've provided a form for users to provide feedback, and had several comments about printing. Here are some quotes:

Can you make reports printer friendly please. The large bold letters are using plenty of ink!
The  plld forms printing option put them altogether and each employer should be on a different page  to make it easy to print off for each employee withe payment amount on separate page for employer  information.  Very clunky and not very user friendly
The print option for P11d etc does not work properly - you get everything, including the web page headings and even the print button! Please can we print just the forms.
It would be great to get a really easy print out of the previous year - on one page too (it's enormously wasteful of paper).
P11D forms are not in a fit format to give to employees.
The printed P11D looks very amateurish to give employees when they've been used to an 'official looking' P11D in the past.

(we have more feedback available on request)
It would be great if the design system could provide more print styling that address some of these issues, though I appreciate finding one approach that fits all potential printing needs isn't trivial
In the meantime, we've loaded the following additional styles on our "view and print" pages - i've added comments to detail what each workaround does:
@media print {
  /* hide GOV UK components */
  .govuk-phase-banner, .govuk-footer, .govuk-button, .govuk-header__content {
    display: none;
  }

  /* hide relative links - gov uk print styles only look to hide http/https links */
  .govuk-link[href]:after {
    content: none;
  }

  /* hide bespoke language switcher component */
  .portal-rsa-language-switcher {
    display: none;
  }

  /* forces printing at A3 size, so that desktop rather than mobile layout is used */
  @page {
    size: 297mm 420mm;
    margin: 18mm;
  }
}

In addition to the above comment, we are now releasing the additional overrides to the summary list component for printing in the HMRC PAYE service:
 @media print {
  .govuk-summary-list__key {
    width: 70% !important;
    padding-bottom: 0 !important;
  }

  .govuk-summary-list__value {
    width: 30% !important;
    padding-bottom: 0 !important;
  }
}

We consulted with our business owners and they confirmed that changing the column widths provided preferable styling for printing

I have also received reports from a team on the X-GOV slack that our print styles have increased the amount of pages that are now printed out.

I'm plugging Design System into GOV.UK Notify at the moment. The majority of our pages contain form controls (which will soon use components) so this would benefit us as well.

As raised by a user on Slack, the lack of print styles means that the panel component prints with light grey text on white:

I believe this is the browser’s ‘best effort’ to make it printable – by default, browsers will remove background colours from things when printing them, and because the text would then be white-on-white it’s making the text grey.

Further to the issue mentioned by 36degrees on 21 Apr. That's quite a low contrast. Has it passed a test for accessibility at A or AA? If not, we'll have to stop using it.

I'm delighted with what's been done relating to contrast of panel text when printed. I'd like to raise a couple of other issues:

Please can body text in the default to 14 point (in the printed paper version)? I think the current default is 12 point. We increased it from 12 to 14 point to reduce requests for large print or other assistance in accordance with https://www.gov.uk/government/publications/inclusive-communication/accessible-communication-formats and https://www.rnib.org.uk/sites/default/files/Top_Tips_Creating_accessible_print_documents.pdf

Please can the vertical space used by the panel be reduced (in the printed paper version)? We sometimes have content in addition the panel and our users end up printing more than one page. A panel that consumes less vertical space will reduce the number of pages that get printed.

Use of sans serif font in print styles
Sans serif font is set as default in print stylesheets to avoid issues that occur when printing on some operating systems and print drivers. These issues were impossible to diagnose so the decision was made to leave it to the local fonts on the computers as they’re most likely to work.

Would you be up for me working on this as a contribution?

Would you be up for me working on this as a contribution?

Thanks for the offer @NickColley! We're slightly concerned that this might turn out to be quite a lot of work, especially for our designers who would likely need to be involved in reviewing the changes.
However, we'd be happy to trial something if we can keep the scope small, perhaps focusing on a single component to start with?
What do you think?