Errors aren't surfaced to the embedder API

When implementing my own embedder I was confused why FlutterEngineRun returned success but then nothing was rendering.  It turns out the following errors were getting printed to stdout.
[ERROR:flutter/shell/common/shell.cc(93)] Dart Error: Can't load Kernel binary: Invalid kernel binary format version.
[ERROR:flutter/runtime/dart_isolate.cc(143)] Could not prepare isolate.
[ERROR:flutter/runtime/runtime_controller.cc(385)] Could not create root isolate.
[ERROR:flutter/shell/common/shell.cc(604)] Could not launch engine with configuration.

The host app is not one I wrote and it was actually difficult to get access to the stdout.  We should surface these errors to the embedder.h somehow.

All Embedder API methods return an error code. But you're right there is error message associated with it. To work around this, we just dump the error message to log. Perhaps we should have an error callback instead.

All Embedder API methods return an error code. But you're right there is error message associated with it. To work around this, we just dump the error message to log. Perhaps we should have an error callback instead.

The error codes don't work here because the error is generated asynchronously.  The run call returns success but later on the error is generated with no associated call from the embedder.

I'm going to remove the tags from triage so it can be considered since there was some misunderstanding on the current behavior.  This isn't a proposal so is probably a p4 at least.


Error - Cannot install Keyboard listener

ℹ Computer information

Windows build number: 19041.388
PowerToys version: Release v0.20.0
PowerToy module: All

📝 Provide detailed reproduction steps (if any)
Im not sure if others will be able to replicate, but i get the error consistently when i launch power tools

Launch PowerToys
Error appears "PowerToys - Fanzy Zone Cannot install keyboard listener" (see screenshot)

Click "OK"
Error appears "PowerToys - Shortcut Guide Cannot install keyboard listener (see screenshot)

Click "OK"
6: Error Appears "PT Run got an error (See screenshot)

After this I can open PowerToys but when i click on any of the modules on the left hand side (for example FancyZones) the entire PowerToys window closes.
Any help here?
I have restarted my PC but this has not resolved the issue. I have uninstalled and reinstalled but i get the same errors.
Any advice would be appreciated!

@JDNielsen93 do you have any apps on your PC like Autohotkeys?

Hi @Crutkas The only app I can think of that talks to my keyboard is Razer Synapse. I have tried exiting that app the launching PowerToys again but no luck, I havent tried to uninstall Razer Synapse yet - I can try that?

Hi @crutkas I have uninstalled razer synapse but still i get the error everytime I boot up my PC and PowerToys still does not work for me. Any idea?

#5414 will be our master tracking issue.  We have to figure out why this is kicking in. Looks like this is across more than just PT Run for you

@JDNielsen93 can you try running PowerToys as administrator? If the issue you are facing is the same as #5414, then the errors might disappear for all modules except PowerToys Run. Can you check if that works you?


On ipadpro sprite is white silhouette at edge of stage

Expected Behavior
sprite should be visible in color at all locations on stage before and after program stops.
Actual Behavior
https://user-images.githubusercontent.com/79463406/108727418-8f4e9200-74f6-11eb-8a5a-6c2e7238bb9c.MP4

sprite becomes white silhouette if it lands in the right 20% or so of stage when the program stops.
Steps to Reproduce
place sprite anywhere on stage, program it to go to right edge. It will white out after program stops. then program it to move away and it will come back to color.
Device and Operating System
ipad pro 3rd gen/ Model # MTFL2LL/A       OS 14.4

Note that I can't reproduce this issue on iPad or Android tablets, but I reproduced this on macOS edition.


Full duplex on Windows

In testing a project on a Windows machine I noticed that apparently concurrent read/write operations are not supported on Windows: while reading data, the writing thread seems to block.
I did come across this article describing the FILE_FLAG_OVERLAPPED flag to initiate overlapped operations. Not knowing much about the Windows Serial API I don't know whether this is still relevant.
I do use .setTimeout (0, 1, 0, 0, 0); to reduce the time outs, however I also then start to lose data...

I was a bit surprised when I measured it. This is with a 9600 baud rate device in loopback:
  // Note that even though the software appears to be half-duplex, e.g.
  //
  //   for (;;) {
  //     tty.Write(..);
  //     tty.Read(..);
  //   }
  //
  // the measured data rate is closer to full-duplex (for larger buffers):
  //
  //   buffer_size=1B duration=799819us  TX bps=500.113 RX bps=500.113
  //   buffer_size=4B duration=799951us  TX bps=2000.12 RX bps=2000.12
  //   buffer_size=16B duration=1599840us  TX bps=4000.4 RX bps=4000.4
  //   buffer_size=64B duration=3999859us  TX bps=6400.23 RX bps=6400.23
  //   buffer_size=256B duration=13599317us  TX bps=7529.79 RX bps=7529.79
  //   buffer_size=1024B duration=53597703us  TX bps=7642.12 RX bps=7642.12

I'd like to see what the numbers look like for a higher speed serial link, but I don't have the hardware readily available.


change internal representation of geo_shape type to map

from jts Shape to Map<String, Object>

otherwise ack


[Search] Fix serialization performance issue

Packages impacted by this PR
@azure/search-documents
Issues associated with this PR
Describe the problem that is addressed by this PR
Fixes a slow and inefficient implementation for walking a tree of object properties. Local testing reduced serialization times from ~15s to ~150ms.
Designed to be reviewed on a per-commit basis.
Fixes #27382
Depends on #29600
Checklists

[x] Added impacted package name to the issue description
[x] Added a changelog (if necessary)

API change check
API changes are not detected in this pull request.

/check-enforcer override


BUG in new RELEASE 16.5 dotnet publish don't copy all dll's

With release 16.5 and SDK 3.1.200 the problem still exists !!!
Now the dll name will corrupted
Why you don't fix this with the new release ???
Interop.Microsoft.Office.Interop.Access.dll;Interop.Microsoft.Office.Interop.Access.Dao.dll;Interop.Microsoft.Office.Core.dll
only one file is copyed with all names inside !!!
Severity Code Description Project File Line Suppression State
Error MSB3094 "DestinationFiles" refers to 3 item(s), and "SourceFiles" refers to 1 item(s). They must have the same number of items. Esi.Bootstrap.Package C:\Program Files (x86)\Microsoft Visual Studio\2019\Preview\MSBuild\Microsoft\DesktopBridge\Microsoft.DesktopBridge.targets 692
  <Target Name="_CopyPackageFiles" DependsOnTargets="_ConvertItems">
    <Copy SourceFiles="%(File.FullPath)" DestinationFiles="%(File.CopyToTargetPath)" Condition="%(File.CopyToTargetPath) != ''"/>

    <ItemGroup>
      <FileWrites Include="%(File.CopyToTargetPath)" Condition="%(File.CopyToTargetPath) != ''" />
    </ItemGroup>
  </Target>

I created a new .net core wpf application and add a com dependency.
<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">

  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFramework>netcoreapp3.1</TargetFramework>
    <UseWPF>true</UseWPF>
  </PropertyGroup>

  <ItemGroup>
    <COMReference Include="Microsoft.Office.Access.dll">
      <Guid>4affc9a0-5f99-101b-af4e-00aa003f0f07</Guid>
      <VersionMajor>9</VersionMajor>
      <VersionMinor>0</VersionMinor>
      <WrapperTool>tlbimp</WrapperTool>
      <Lcid>0</Lcid>
      <Isolated>false</Isolated>
      <Private>true</Private>
    </COMReference>
  </ItemGroup>

</Project>

On publishing to folder the COM+ reference dll will not copyed to the publishing folder.
WpfApp1.zip

@dsplaisted - have a look?

I open 4 weeks ago the first ticket and it was closed. Nice job :(


sdk report and reportfilereader

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingAds/bingads-12/guides/release-notes.md
:white_check_mark:Succeeded

BingAds/bingads-12/guides/sdk-bulk-service-manager.md
:white_check_mark:Succeeded

BingAds/bingads-12/guides/sdk-reporting-service-manager.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[JENKINS-26636] added publisher for Publish Over SSH plugin

Will this include the functionality to use a ssh publisher in conditional build steps?

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@jefffiser I tested it and it's not working. So it seems to be a different issue. Can you open a new JIRA ticket for the problem?

@jefffiser I started investigating the issue and created JENKINS-28308

@daspilker Thanks for fixing Daniel!


Alexa sees the devices but does not respond in your node

I followed all the steps to install your skill with Amazon Echo, updated node-red with your nodes, added your nodes to an existing working flow, and got stuck. The Alexa Home node does not output anything at all. I followed all the instructions on your page at https://alexa-node-red.bm.hardill.me.uk/docs
Knowns: Alexa recognizes the 3 new devices. I know internally my systems are working as they communicate with MQTT on my network. Node-Red flows that I am using are working perfectly. I chose 3 different devices... 1) A simple door that is detected either open/closed using the lock status 2) A percentage to open/close drapes  3) Garden moisture sensor just to receive value from Alexa.
Is there a critical item in your documentation missing? Do I have to say something like “Alexa what is the status of the front door?” etc.  I suspect I have overlooked something simple, or it isn't documented.

What commands are you trying to use to interact with your devices?
e.g. for the blinds assuming the device is called blinds it should be something like:
"Alexa, set the binds to 50%"
Also what response do you get from Alexa when you ask the question.
Can you attach a screen shot of your Node-RED flows so I can see how you've wired things together

Also the moisture sensor isn't going to work at all as there is no way to query a percentage value

Ah... I think you just gave me the critical missing clue... the NAME of the device is the word that Alexa detects? I will test that and get back to you.

Thank you, thank you! That was the missing clue... the word or phrase that you name your device becomes that which Alexa acts upon.
You have done an outstanding job with your software. I recommend a wee bit more documentation. It does seem strange to say "Alexa, open the blinds to 50%" instead of "Alexa, open the blinds half way." Alas, a limitation of Amazon.


Async generic invoke support.

Fix issue: https://github.com/apache/incubator-dubbo/issues/3163
Add async support fo generic invocation.

Codecov Report

Merging #3637 into master will decrease coverage by 0.06%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##             master    #3637      +/-   ##
============================================
- Coverage     63.92%   63.86%   -0.07%
  Complexity       71       71
============================================
  Files           700      701       +1
  Lines         30709    30717       +8
  Branches       4975     4979       +4
============================================
- Hits          19632    19618      -14
- Misses         8818     8839      +21
- Partials       2259     2260       +1

Impacted Files
Coverage Δ
Complexity Δ

...c/main/java/org/apache/dubbo/common/Constants.java
93.33% <ø> (ø)
0 <0> (ø)
:arrow_down:

...a/org/apache/dubbo/rpc/service/GenericService.java
0% <0%> (ø)
0 <0> (?)

...ava/org/apache/dubbo/rpc/filter/GenericFilter.java
70.96% <100%> (+2.54%)
0 <0> (ø)
:arrow_down:

...ache/dubbo/remoting/transport/AbstractChannel.java
75% <0%> (-12.5%)
0% <0%> (ø)

...che/dubbo/remoting/transport/mina/MinaChannel.java
43.42% <0%> (-11.85%)
0% <0%> (ø)

...ache/dubbo/remoting/p2p/support/AbstractGroup.java
45.45% <0%> (-11.37%)
0% <0%> (ø)

.../remoting/transport/netty4/NettyServerHandler.java
61.9% <0%> (-9.53%)
0% <0%> (ø)

...ng/transport/dispatcher/all/AllChannelHandler.java
51.42% <0%> (-5.72%)
0% <0%> (ø)

.../org/apache/dubbo/remoting/ExecutionException.java
15.78% <0%> (-5.27%)
0% <0%> (ø)

.../apache/dubbo/remoting/transport/AbstractPeer.java
63.04% <0%> (-4.35%)
0% <0%> (ø)

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f193b9...9051f80. Read the comment docs.


DTXProfiler.framework damaged on MacOS

Description
I have run with Detox
"test:ios-debug": "detox test --configuration ios.sim.debug -l verbose --take-screenshots all --record-videos failing --record-logs failing --record-performance all --cleanup",
Environment

Model: MacMini
OS: MacOS Catalina 10.15.3
Xcode: 11.3.1

Additional Context
When I run Detox tests with  --record-performance all

I have try brew cask reinstall detox-instruments but the same results..

What version do you have installed?

I have follow the Installation https://github.com/wix/DetoxInstruments#installation and install the last version

And what causes this alert to show up? I've never seen it.
What exactly are you doing?

Is this on Catalina?
Try perhaps running Detox Instruments once, then trying to run the test.

Yes this is Catalina alert. It appears when I run detox test

Try opening Detox Instruments once. I don't know how this can possibly be triggered by Detox.

This appers to be some security alert from catalina.. After open Detox Instrument from App launcher its have different alert with "Open it" button. Next I can running detox tests without "DTXProfiler is Damaged" and "Move to Bin" message.

How odd.


HDDS-2103. TestContainerReplication fails due to unhealthy container

What changes were proposed in this pull request?
Change TestContainerReplication to close the container directly via client.
https://issues.apache.org/jira/browse/HDDS-2103
How was this patch tested?
Ran the changed unit test - passes, no other code changed.  Checkstyle passes.

/label ozone

@nandakumar131 @lokeshj1703 please review

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
42
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
593
trunk passed

+1
compile
381
trunk passed

+1
checkstyle
78
trunk passed

+1
mvnsite
0
trunk passed

+1
shadedclient
857
branch has no errors when building and testing our client artifacts.

+1
javadoc
172
trunk passed

0
spotbugs
449
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
651
trunk passed

_ Patch Compile Tests _

+1
mvninstall
569
the patch passed

+1
compile
401
the patch passed

+1
javac
401
the patch passed

+1
checkstyle
88
the patch passed

+1
mvnsite
0
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
671
patch has no errors when building and testing our client artifacts.

+1
javadoc
179
the patch passed

+1
findbugs
722
the patch passed

_ Other Tests _

+1
unit
334
hadoop-hdds in the patch passed.

-1
unit
2205
hadoop-ozone in the patch failed.

+1
asflicense
50
The patch does not generate ASF License warnings.

8164

Reason
Tests

Failed junit tests
hadoop.ozone.client.rpc.TestSecureOzoneRpcClient

hadoop.hdds.scm.pipeline.TestRatisPipelineProvider

hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures

hadoop.ozone.TestSecureOzoneCluster

hadoop.ozone.client.rpc.TestFailureHandlingByClient

hadoop.ozone.client.rpc.TestContainerStateMachineFailures

hadoop.ozone.om.TestScmSafeMode

hadoop.ozone.scm.TestContainerSmallFile

hadoop.ozone.client.rpc.TestBlockOutputStream

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1421/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1421

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 2acad02afe91 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / bc2d3a7

Default Java
1.8.0_222

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1421/1/artifact/out/patch-unit-hadoop-ozone.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1421/1/testReport/

Max. process+thread count
3959 (vs. ulimit of 5500)

modules
C: hadoop-ozone/integration-test U: hadoop-ozone/integration-test

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1421/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thanks @lokeshj1703 for reviewing and committing it.


[Apibench] Resume interrupted LLM generations from last generation

Describe the issue
When we try to launch LLM generations on APIBench, if the generation is interrupted midway, currently the partial file is deleted  and restart generation from start. What we should instead do is check where the generation stopped and resume from the last generated index. This is specially critical for large models where generation can take >1 hours.
ID datapoint
2. Provider: This affects all 3: TorchHub/HuggingFace/PyTorch Hub
File that needs to be edited: https://github.com/ShishirPatil/gorilla/blob/main/eval/get_llm_responses.py

hi @ShishirPatil
I’m interested in working on this issue marked as a "good first issue." Can I take it up? Let me know if there’s anything specific I should consider.


Backups skyrocketing in size

Describe the bug
My last cd.io backup from less then a month ago is 60 MB but yesterday's one is over 200 MB.
Version
v0.47.03
To Reproduce
Steps to reproduce the behavior:

Go back in time and do a backup a month ago.
Go back to today and do a backup.
Observe the size difference and raise an eyebrow.

Expected behavior
Backup size grows roughly linearly with number of watches.
Desktop (please complete the following information):

OS: Linux
Browser: Firefox
Enviroment: Docker

Additional context
I have over 400 watches, a month ago I might have had 380-ish. Not enough to explain the difference. My guess is it's because of the new (I think it's new) feature allowing you to compare and show not only differences between current and last check but also a number of checks in the past. While it might be useful to some, it can let the data folder (and backup consequently) grow like cancer.
I suggest a global option to let user choose max number of diffs to keep.

Can you make a new issue? this is a lot of text when it all just comes down "I suggest a global option to let user choose max number of diffs to keep."
thanks

duplicate https://github.com/dgtlmoon/changedetection.io/issues/2216

I see this more as a Bug report then Feature request. What I suggested was just one way to solve this without sacrificing multiple diffs for people who need them.
#2216 talks about only needing binary change/no-change option. Not about limiting number of diffs to keep.

In progress - https://github.com/dgtlmoon/changedetection.io/pull/2722


Bug 1807112: Check node-selectors in source pod list.

Summary of changes:
Check for any node-selectors in pod list from the source namespaces, and raise a warning if any such pod exists.
Signed-off-by: Padmanabha Venkatagiri Seshadri<EMAIL_ADDRESS>

Hi @seshapad, thanks for the pull request.
I want to double-check our approach here, because I'm concerned that raising a "StageNoOp" warning while the migration is running won't give the user enough advance notice to be able to adequately handle this problem, and their migration will probably fail.
@dymurray or @sseago do you have thoughts? Dylan, I saw you responded to the original bug.

@djwhatle shall I move the morning to init() method of the pipeline? that will mean raising the warning before the migration happens. cc: @dymurray @sseago

@seshapad no, I think what I'm trying to get at is that this warning probably needs to surface to the user before they even click the migrate button (or create the migmigration resource) because once the migration is running, it's unlikely the user is going to be closely watching for this non critical condition and will be able to intervene in time to cancel the migration.
If there is information that a user needs to know that would affect their decision to run a migration or not, we typically provide that info on the migplan object where warnings that are raised surface in the final page of the plan creation wizard.
I need to learn more about this node selector issue to know what's right. I will get in contact with Dylan and Scott to understand the issue better.

@djwhatle I don't understand this issue completely, but it seems this is another example of a place where we need a pre-migration checklist before starting a migration. In lieu of that, can we put the plan in a "Not ready" state if this condition exists? I'm not sure currently if "Not ready" blocks a migration or is just a warning, or which is appropriate in this case.

starting a migration. In lieu of that, can we put the plan in a "Not ready" state if this condition exists? I'm not sure currently if "Not ready" blocks a migration or is just a warning, or which is appropriate in this case.

@vconzola I think this is definitely a case where we want to warn rather than block, because it's going to be very common but not fatal to the migration for node selectors to exist on resources that we'll be migrating, since we clear the nodeselectors automatically during Velero restore.
After talking it over with Scott and Dylan, I think our ideal solution would allow the user an opportunity to map src cluster nodeselectors onto target cluster nodeselectors, but that is not feasible to implement for 1.4.1. This would be possible for 1.5.0 if is determined to be a priority, would also need UI support.
@seshapad after talking it over with the team, the consensus is that this check should be part of the MigPlan validations, and if nodeselectors are found on Pods, we should raise a warning condition on the MigPlan so that the user sees the warning on the final page of MigPlan wizard.
In the warning condition we set, I would mention the namespaces that contain pods with nodeselectors so that the user can go investigate.

@djwhatle The intent of the plan validations should be to surface issues that can be resolved by going back through the plan wizard and making changes (or at least acknowledging) things in the plan itself. Once the plan is saved these issues are lost. So if the user doesn't need to be aware of this warning after the plan is created that's fine. But if it's something the user may want to revisit after plan creation the warning(s) should be surfaced elsewhere.

So the problem with putting it on migmigration validation is that this is something we can check before they even start a migration, and we'd probably want to warn the user then rather than later. There are 2 ways a user could deal with this. First, if they don't care about the issue (because stripping the node selectors won't break them), they can ignore it and migrate anyway. The other possibility is that they do care about this, in which case until we have the node selector mapping they may have to manually update their deployments post-migration and bounce the pods. Hopefully that's all that will be required, but it's hard to say in the abstract.

Once the plan is saved these issues are lost. So if the user doesn't need to be aware of this warning after the plan is created that's fine. But if it's something the user may want to revisit after plan creation the warning(s) should be surfaced elsewhere.

@vconzola From a UI perspective, I agree that the Warning Conditions aren't visible anymore after you close out the wizard, but just to be clear the Warning Conditions are never cleared from the MigPlan resource, they remain until the issue is resolved. I assume they would all be visible again if you re-opened the wizard and made it to the final page.
The action a user could take to resolve this problem from the MigPlan wizard would be to reverse back to the namespace selection screen and remove namespaces containing nodeselectors if desired. This is similar to what the user is able to do if their namespaces contain incompatible GVKs.
Node selectors are a feature of OpenShift, and their presence will likely be common, so I think it will be important that the user is well-informed that we will strip nodeselectors if they proceed.

@vconzola @djwhatle Another UX-related question. Once the plan is created, on the plans list (at /plans ), where the user would select migrate/stage/edit/etc., would it make sense to have some sort of indication if there are warnings on the plan (either in a new column, or as some sort of visual indicator in one of the existing columns, wherever it makes the most sense). That way if something were to happen post-plan-creation that triggers a warning condition (or if there's a leftover warning condition from before), there's a way to see it without going through the full set of wizard steps (which the user would have no reason to do at this point)?

@sseago I think it would be useful to let the user know if a MigPlan has any warning conditions without digging into the wizard. Thoughts @vconzola ?

@djwhatle @sseago That's what i meant when I suggested putting a plan into a "not ready" state. That's probably not exactly what we want, but "not ready" is a way to alert the user that there's something to be aware of and possibly take action before a migration is started. I don't know how the ready/not ready status is determined for a plan but that's the place I'd like to see this information surfaced. Maybe we need another pre-migration plan state - "Ready with warnings"?
Also, given what Derek said above it makes total sense to also include it in the plan validation warnings so user can go back into the wizard and remove namespaces containing nodeselectors if desired.

Maybe we need another pre-migration plan state - "Ready with warnings"?

@vconzola this is already how the back-end works, but maybe you're thinking we should have this type of language in the UI to match.
Any warning condition will not block a MigPlan (or any other of our resources) from being ready. Only critical conditions will block readiness.

@seshapad some information to help you go forward: I think we are in agreement now that this should surface as a warning condition on the migration plan. The place to implement the check should be in warning conditions are validated by functions called from https://github.com/konveyor/mig-controller/blob/master/pkg/controller/migplan/validation.go#L110

Thanks @djwhatle ... I will make appropriate changes.

@djwhatle Yes, I think we should have a "Ready with warnings" plan state in the UI. Is a GitHub issue the way to get this started? What other conditions in the backend should result in this plan state?

@djwhatle The warning is now raised during the plan phase as shown in the figure.

Good thinking to combine with an existing pull of pod data @seshapad.
I think the warning message needs a little bit of work so that it's clear to the user what they can do to resolve the problem / what the effects of node selectors being present will be.
Here's the current warn message:
fmt.Sprintf("Node selector or name defined for namespaces: [%s].", strings.Join(nsWithNodeSelectors, ",")),

@sseago could you provide some links to where in the plugin we are clearing out nodeselector / nodename? I found this, but I'm guessing that's not the extent of it.

Good thinking to combine with an existing pull of pod data @seshapad.
I think the warning message needs a little bit of work so that it's clear to the user what they can do to resolve the problem / what the effects of node selectors being cleared will be.
Here's the current warn message:
fmt.Sprintf("Node selector or name defined for namespaces: [%s].", strings.Join(nsWithNodeSelectors, ",")),

First I'd suggest being a little more explicit by modifying as such:
fmt.Sprintf("Node selector or node name defined for namespaces: [%s].", strings.Join(nsWithNodeSelectors, ",")),

@sseago could you provide some links to where in the plugin we are clearing out nodeselector / nodename? I found this, but I'm guessing that's not the extent of it.

Also, now that the validatePodLimit validation is serving a dual purpose, I think we should change the function name to reflect  that @seshapad .

@djwhatle to summarize:

Warning msg needs modification. Will do that.
ValidatePodLimit function name needs to be changed. Shall I make it ValidatePods?

Warning msg needs modification. Will do that.
Yes, and I think we need more info from @sseago on what should be included in the message. Upon closer inspection seems like we are just looking at pod.Spec.NodeSelector and pod.Spec.NodeName / nodename and not looking at namespaces themselves. In this case, I think the message might be modified to read like:

Found Pods with `Spec.NodeSelector` or `Spec.NodeName` set in namespaces: [%s].
These fields will be cleared on Pods restored into the target cluster.

@sseago thoughts on above?

ValidatePodLimit function name needs to be changed. Shall I make it ValidatePods?
Yeah that sounds like a good name. Would you update the comment above that function to specify both of the things that it validates?

@djwhatle "@sseago could you provide some links to where in the plugin we are clearing out nodeselector / nodename? I found this, but I'm guessing that's not the extent of it."
That's exactly it. For pods we restore, we remove the NodeSelector. Actually, there's also a plugin that's part of velero which removes NodeName for pods on restore.
Note that when there are owner references, we don't restore the pod, so this is only really relevant for stage pods and for standalone pods.

@djwhatle I'm wondering whether we should avoid warning for pods with owner references. I wonder, though, about what would happen if the Deployment's pod template had a node selector specified. I don't see any code which would strip that, so it's possible that this would still break restore if the node selector wasn't useful in the dest cluster.

@djwhatle Following from our discussion, here is the modified warning msg:

Also, there was already a validatePods() function which was looking into pod health. So, I renamed validatePodLimit() to validatePodProperties() (this looks at pod limits and also node-selectors) and validatePods() to validatePodHealth() (this looks at pod health). Please let me know if you have any comments.


Tutorials for working with 3D?

I haven't seen any tutorials related to working with SGDK's 3D capabilities (rendering 3d shapes with the Bitmap engine and working with various Maths3D functions). I've tried taking a look at the built-in cube demo, but there are several things that the demo alone can't really address, especially with lack of detailed comments. I found myself asking questions like "So is that checkerboard dither pattern that appears on filled polygons something I can turn of or not?" and "Can I really only have a maximum of 256 points?" I feel like a tutorial or at the very least some proper documentation in the form of comments in the code would save anyone interested in wanting to work with the limited 3D capabilities a lot of time and frustration.

All the methods are documented and honestly there is not much to say about the 3D part which is pretty minimal :p
You should use maths3d unit for 3D transformation part and bitmap unit for drawing part.
The checkboard dither is because you use plain 8 bits color, Bitmap mode use 1 palette and so is limited to 16 colors, still you have to possibility to provide 8 bits colors to the drawPolygon(..) method to enable dithering and simulate more colors. If you don't want it, just use plain 4 bits colors like this : 0x11, 0x22, 0x33... :) I can eventually do a better 3D sample example but still 3D capabilities are pretty limited as the Megadrive hardware is not designed for that.


feat(design): create DaffOpenableDirective

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Part of: #763
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@damienwebdev Need to finalize what the output naming is for the openable directive. Are we sticking to toggled?

@griest024 we made some updates according to your concerns. lmk what you think.

@griest024 had to fix some tests


374 examples, 20 failures

Failures:

  tests/Spec/Data/List/NonEmptySpec.hs:27:
  1) Spec.Data.List.NonEmpty, NonEmpty Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       0 :| []

  tests/Spec/Derived/DataFamiliesSpec.hs:49:
  2) Spec.Derived.DataFamilies, NotAllShow Int Int Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       NASShow2 0

  tests/Spec/Derived/DataFamiliesSpec.hs:54:
  3) Spec.Derived.DataFamilies, KindDistinguished '() Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       KindDistinguishedUnit 0 0

  tests/Spec/Derived/DataFamiliesSpec.hs:58:
  4) Spec.Derived.DataFamilies, KindDistinguished 'True Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       KindDistinguishedBool 0 0

  tests/Spec/Derived/DatatypeContextsSpec.hs:28:
  5) Spec.Derived.DatatypeContexts, TyCon Int Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyCon 0 0 0

  tests/Spec/Derived/DatatypeContextsSpec.hs:31:
  6) Spec.Derived.DatatypeContexts, TyFamily Int Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyFamily 0 0 0

Failures:

  tests/Spec/Data/List/NonEmptySpec.hs:27:
  1) Spec.Data.List.NonEmpty, NonEmpty Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       0 :| []

  tests/Spec/Derived/DataFamiliesSpec.hs:49:
  2) Spec.Derived.DataFamilies, NotAllShow Int Int Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       NASShow2 0

  tests/Spec/Derived/DataFamiliesSpec.hs:54:
  3) Spec.Derived.DataFamilies, KindDistinguished '() Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       KindDistinguishedUnit 0 0

  tests/Spec/Derived/DataFamiliesSpec.hs:58:
  4) Spec.Derived.DataFamilies, KindDistinguished 'True Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       KindDistinguishedBool 0 0

  tests/Spec/Derived/DatatypeContextsSpec.hs:28:
  5) Spec.Derived.DatatypeContexts, TyCon Int Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyCon 0 0 0

  tests/Spec/Derived/DatatypeContextsSpec.hs:31:
  6) Spec.Derived.DatatypeContexts, TyFamily Int Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyFamily 0 0 0

  tests/Spec/Derived/ExistentialQuantificationSpec.hs:28:
  7) Spec.Derived.ExistentialQuantification, TyCon Int Int Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyConForalls 0 0 0 0

  tests/Spec/Derived/ExistentialQuantificationSpec.hs:31:
  8) Spec.Derived.ExistentialQuantification, TyFamily Int Int Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyFamilyForalls 0 0 0 0

  tests/Spec/Derived/MagicHashSpec.hs:29:
  9) Spec.Derived.MagicHash, TyCon# Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyCon# {tcA = 0, tcB = 0, tcInt# = 0#, tcFloat# = 0.0#, tcDouble# = 0.0##, tcChar# = 'V'#, tcWord# = 0##}

  tests/Spec/Derived/MagicHashSpec.hs:34:
  10) Spec.Derived.MagicHash, TyFamily# Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyFamily# {tfA = 0, tfB = 0, tfInt# = 0#, tfFloat# = 0.0#, tfDouble# = 0.0##, tfChar# = 'V'#, tfWord# = 0##}

  tests/Spec/Derived/PolyKindsSpec.hs:28:
  11) Spec.Derived.PolyKinds, TyConCompose Either Either Either Maybe Maybe Int Int, TextShow1 instance
       Falsifiable (after 1 test and 1 shrink):
       0
       TyConCompose (Right (Left Nothing))

  tests/Spec/Derived/PolyKindsSpec.hs:32:
  12) Spec.Derived.PolyKinds, TyConProxy Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyConProxy ()

  tests/Spec/Derived/PolyKindsSpec.hs:36:
  13) Spec.Derived.PolyKinds, TyConReallyHighKinds (,,,,) Int Int Int Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyConReallyHighKinds (0,0,0,0,0)

  tests/Spec/Derived/PolyKindsSpec.hs:41:
  14) Spec.Derived.PolyKinds, TyFamilyCompose Either Either Either Maybe Maybe Int Int, TextShow1 instance
       Falsifiable (after 1 test and 1 shrink):
       0
       TyFamilyCompose (Right (Left Nothing))

  tests/Spec/Derived/PolyKindsSpec.hs:45:
  15) Spec.Derived.PolyKinds, TyFamilyProxy Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyFamilyProxy ()

  tests/Spec/Derived/PolyKindsSpec.hs:49:
  16) Spec.Derived.PolyKinds, TyFamilyReallyHighKinds (,,,,) Int Int Int Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyFamilyReallyHighKinds (0,0,0,0,0)

  tests/Spec/Derived/RankNTypesSpec.hs:28:
  17) Spec.Derived.RankNTypes, TyCon Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       TyCon (Tagged2 0) (Tagged2 0)

  tests/Spec/Derived/RankNTypesSpec.hs:31:
  18) Spec.Derived.RankNTypes, TyFamily Int Int, TextShow2 instance
       Falsifiable (after 1 test):
       0
       TyFamily (Tagged2 0) (Tagged2 0)

  tests/Spec/Derived/RecordsSpec.hs:28:
  19) Spec.Derived.Records, TyCon Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
      (:@:) {tc3 = 0, tc4 = 0}

  tests/Spec/Derived/RecordsSpec.hs:33:
  20) Spec.Derived.Records, TyFamily Int Int, TextShow1 instance
       Falsifiable (after 1 test):
       0
       (:!:) {tf3 = 0, tf4 = 0}

Randomized with seed<PHONE_NUMBER>

Finished in 1.0413 seconds
374 examples, 20 failures

I was hoping to fix this before you noticed it :)
This is due to an issue in deriving-compat-0.3.2 that I fixed with the release of deriving-compat-0.3.3 (I've since deprecated the former version on Hackage). Can you confirm that the tests now work for you?

Thanks


Merge revision into develop

Conflicts:

docs/guide/samples-demos.md
docs/guide/samples-environments.md
docs/guide/images/samples/uneven_terrain.thumbnail.jpg
src/webots/nodes/WbCamera.cpp
src/webots/nodes/WbSphere.cpp
src/webots/nodes/WbViewpoint.cpp

Update:

1c6c841
9f0be8b

test me

Build Failed :confused:
https://cyberbotics2.cyberbotics.com:8443/job/Webots/666/consoleText

test me

test me

Build Failed :confused:
https://cyberbotics2.cyberbotics.com:8443/job/Webots/667/consoleText

Build Passed :ok_hand:
You can safely merge 'merge-revision-into-develop' into 'develop'.

:+1:


Updated typos

What does this PR do?
Updated a the instructions to correct some typos.
🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

More

[ ] Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
[ ] Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
[ ] Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
[ ] Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

[ ] E2E Test successfully complete before merge?

Additional Notes

Text changes in the instructions.


JsonSerializer - Use ReferenceEquals instead of object.Equals

When checking for cyclic object loops. Resolves #2980

@304NotModified Should be considered for NLog ver. 4.5.11. It is actually a bug that it doesn't use object-reference-compare instead of object-equals.

@snakefoot @2987 is merged!

PS: there is no need for a new PR, after force push we can change the target branch. That is preferred

@304NotModified Will try. But your refactoring of the JsonLayout tests is causing merge conflicts between master and dev.

@304NotModified Ready for commit to master. But I think you will find it difficult to get into dev.

Thanks!

@304NotModified Should I make new PR for dev-branch ?

@304NotModified #2989 also includes the changes


use release.NugetVersion as nuget package version

Sorry to be a bother, but I was building machine.fakes with a pre-release FakeItEasy as part of my work on FakeItEasy/FakeItEasy#468 and got a build failure, which turned out to just be a problem where a stable machine.fakes nuget version (2.6.0) depended on unstable FakeItEasy 2.0.0-beta007.
Everything else passed, and I wasn't concerned, but still.
I updated changelog.markdown to contain a beta version, but ran into the same failure because build.fsx uses release.AssemblyVersion for the NuGet package version.
Undeterred, I checked the Fake ReleaseNotesHelper docs and found the NugetVersion attribute, which I tried out. It worked perfectly.
Even though there's no problem now, I figure in the future you may want to release a beta version, and it might be handy to have the NuGet package version-setting pick up the right version from the changelog.

Thanks!

No, thank you!


Building Tensorflow & Segmentation Acc.

Hello,
I was trying to build/run your code and faced some minor issues.

Building the tensorflow code with script build.py was failing because it could not find the "object" directory. This can be solved by adding an else statement here.
For example:

if os.path.exists("object"):
  os.system("rm -r object")
  os.mkdir("object")
else:
  os.mkdir("object")
os.system("make -j all")

While running run_seg_partnet.py for the bed category, I noticed the test accuracy was always nan. I looked through the data and code to see what caused it, and this was happening because all the point labels of the last model in the validation split (Bed_447c50e658d729f044ededc21cf0e35e_11309_level3) were 0. In your code you ignore all points with label zero, thus for this model no points are left to process, which causes the nan value. So, this model can either be removed from the split or handle the 0 label differently, for example ignore it only in the IoU calculations. Also not masking labels with that value solves the issue, but I suppose this is not what you wanted. Do you have any other suggestions how to handle this case?

Thank you so much for figuring out this bug, I have updated the code.
I also noticed this issue when doing experiments. The points with the label 0 in PartNet are background points ( i.e., unlabeled points), and they should not be considered in the calculation of IoU. According to the formula used to calculate IoU, the point cloud containing only points with the label 0 does not affect the final value of the mean IoU. However, it will produce a nan when using the tf.reduce_mean to calculate the accuracy.  You can safely ignore this issue since the accuracy is not used as the evaluation metric. You can also delete the point cloud only containing the label 0 if you find it and do want to get the accuracy.


How much the memory cost when training video generation model?

Thank you for your good job!
I input 16 frames, each with 6 view images, and do not use xformers, but When I implement the sentence, the memory consumed more than 80G. So is this the reason that I do not use xformers?

We have solved your issue through email.


Deploy optimistic roots to staging

Problem
Need to deploy optimistic roots branch optimistic_roots to staging
Impact
Transfer cost reduction.
Quality of the upgrade depends on testing on staging
Proposed Solution
Merge onchain and offchain PRs
Tie all loose ends, getting the merged brand to build and deploy
Subtasks:

[ ] https://github.com/connext/monorepo/issues/3976

Acceptance Criteria

[ ] Fast path transfers are successful in op mode
[ ] Slow path transfers are successful in op mode

Complexity: 21
See the discussion in Sprint Poker #26
Powered by Parabol

Impact: 5
See the discussion in Sprint Poker #27
Powered by Parabol

Close this task out, rewrite task to reflect the actual task that is being done this sprint @preethamr .

The Connext side of the task is tracked here:
https://github.com/connext/monorepo/issues/4010


Can we design a set of metrics to monitor and expose the performance and load of Dledger.

As the title says，can we design a set of metrics to monitor and expose the performance and load of Dledger?

Very necessary


Filename conflict with wiki checkout

Current version. I tried cloning the docs, but got the following error, I suspect because literally ? is an illegal file name character in Windows and/or Linux:
error: invalid path 'Can-I-use-xBehave.net-with-ApprovalTests?.md'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

I think I see what happened there, probably in an FAQ page or something. Some of the headings are questions, per se, but each of these actually lands as an .md file...


Feature/changevar stage1 gv

Description
I'm running out of time and my next window of piece and quiet is Friday afternoon, after which I'm gone until Jan 8th. Bouncing the problem back to @danholdaway or @travissluka.
Plenty of things still not working:

lineargetvalues test ... Not quite sure how I missed that one. I'd say it's a @travissluka problem. I updated the yaml, but it seems more involved than just that.
variable changes within the variational applications aren't working yet, the vars argument points to nowhere. Could be a snafu in the new "updateFields" method in Increment, or not ...

On the positive, the 3dvar_soca ctest runs if you comment out all the linear variable changes (who need those anyways!!!).

That's fine @guillaumevernieres, I can take it up. You should probably be packing and getting covid tested on friday!

@travissluka if you take a sweep and find anything I can help with let me know.

FYI @guillaumevernieres @danholdaway I think I have it working. I have 3dvar passing the ctests with identical answers as before, so I'm assuming the rest of the tests will work when I update the yamls. I'll issue a PR tomorrow

Nice, thanks @travissluka.


Multi-process coverage and codecov configuration

Motivation, Context, and Approach
For coverage to correctly track lines of code visited by different processes started with subprocess.Popen, we needed to make several configuration changes, and some code changes. Notably, we cannot call os._exit(errno) because it prevents atexit from getting called, which coverage relies on in order to produce its output. That resulted in having to revisit how we tear down the SubprocessServiceManager and its worker processes: first try to terminate (SIGTERM) and after a predetermined timeout, send the more brutal KILL signal.
Furthermore, we didn't like that codecov would mark builds as red when the total (project) coverage decreased by a very small percentage. The project: threshold: 0.5 configuration means that a total project coverage reduction of less than 0.5% will not necessarily be marked as red.
How Has This Been Tested?

TravisCI tests still passing
Coverage shows service_manager.py being covered
Coverage fails to show service_entrypoint.py being covered. This will have to get fixed later.

Types of changes

Better tracking of coverage
Better decision making whether the coverage for a build is red or green

Hm, that sounds like a fair amount of work for a small benefit. How about I switch back to using os._exit and get the rest of this PR merged and I can circle around later to get coverage to work?

why don't you try manually invoking sys.exitfunc and then hard os._exit.
The problem we have is when the c++ module gets unlinked, not when python
is running.  If sys.exitfunc runs cleanup and then hands control back to
you, maybe that will just work. If that doesn't work, then what part of
this change do you want to keep?
On Wed, Jul 3, 2019 at 11:21 AM Alexandros Tzannes<EMAIL_ADDRESS>wrote:

Hm, that sounds like a fair amount of work for a small benefit. How about
I switch back to using os._exit and get the rest of this PR merged and I
can circle around later to get coverage to work?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/APrioriInvestments/nativepython/pull/145?email_source=notifications&email_token=AB6OHBHOQCU4OVZE5JETKNTP5S7WDA5CNFSM4H477VAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZEZO2Y#issuecomment-508139371,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB6OHBBW64CMNO3HH4MN7PLP5S7WDANCNFSM4H477VAA
.

@braxtonmckee looked into your suggestion and sys.exitfunc was deprecated in python 2.4 and does not seem to exist in python 3. It has been replaced by the atexit module, which does not have a public method to call the registered functions. As a possible work-around, I am keeping track of the return value of main (errno) in service_manager.py and service_entrypoint.py, I try to call sys.exit(errno); if that call throws an exception I call os._exit(errno) so that the correct error number is set. What I don't know is whether sys.exit throws an exception in the cases you mentioned, so not sure this approach will work. It would be great to have a test that fails with sys.exit() but not with os._exit().
An other option could be to try running atexit._run_exitfuncs before calling os._exit(), but if the clean-up code in atexit could be causing the segfault, we're back at square one.
A final option, which would be quite hacky, would be to try and figure out what function coverage is registering with atexit and call that directly right before calling os._exit(), but that could break when we update the coverage package, because it is not part of its public API.
Thoughts?

I merged changes in that should prevent us from crashing at process exit by making sure we never delete Type objects. So at this point, you should be able to rebase this PR and remove the os._exit calls I used to have (I did this in mainline so you'll probably just have to deal with the merge conflicts) and it should just work without all the hacking around.


Cell output not passed to the decoder RNN

As mentioned in issue https://github.com/Kyubyong/tacotron/issues/28, I think the issue is still a problem.
From the code, we can know that the variable cell_with_attention only contains the attention information,  but not the output of a cell.
cell_with_attention = tf.contrib.seq2seq.AttentionWrapper(decoder_cell, attention_mechanism, num_units)
outputs, _ = tf.nn.dynamic_rnn(cell_with_attention, inputs,
                                      dtype=tf.float32) #( N, T', 16)

The reason is that tf.contrib.seq2seq.AttentionWrapper has a parameter output_attention with default value True, which means the output at each time step is the attention value. We can see from the TF doc:
__init__(
    cell,
    attention_mechanism,
    attention_layer_size=None,
    alignment_history=False,
    cell_input_fn=None,
    output_attention=True,
    initial_cell_state=None,
    name=None
)

output_attention: Python bool. If True (default), the output at each time step is the attention value. This is the behavior of Luong-style attention mechanisms.

To fix this, we should set output_attention=False, and use a wrapper to concate the attention and the cell output.
Is my understanding right?

Why do you think we have to concatenate the attention and the cell output?
The paper says that they concatenate the context (vector) and the attentional RNN cell output to form the input to the decoder RNNS.
I thought it was implicitly processed here: https://github.com/tensorflow/tensorflow/blob/r1.2/tensorflow/contrib/seq2seq/python/ops/attention_wrapper.py#L745, regardless of the arguement of output_attention.
Corret me if I'm wrong.

I misunderstood it. Thanks.


Blank Screen on Clicking "Reset Password" in Enatega Multivendor Food Delivery Site Login Section

Describe the bug
A bug has been identified in the Enatega Multivendor Food Delivery Site login section. When users attempt to reset their password by clicking the "Reset Password" link, a blank screen appears instead of the expected password reset functionality.
To Reproduce
Steps to reproduce the behavior:

Access the Enatega Multivendor Food Delivery Site login page.
Click on the "Forgot Password" or "Reset Password" link.
Fill in the required information or follow the prompts to initiate the password reset process.
Observe that, after submission, a blank screen appears instead of the expected password reset functionality or confirmation message.

Expected behavior
Upon clicking "Reset Password," users should be directed to the appropriate password reset page or receive a confirmation message, allowing them to reset their password securely.
Screenshots
https://github.com/ninjas-code-official/food-delivery-multivendor/assets/152266796/de83886e-b883-4108-9c7d-48fb3c520625
*Desktop:

Browser: chrome

Hi @Inshirah23 I'd like to look into this issue if it has not already been fixed.

Hi @Inshirah23 I'd like to look into this issue if it has not already been fixed.

Sure

Hi @Inshirah23 this feature has been resolved already.


added quit command

Hi, thank you for the awesome project !
I felt it would be more friendly if evcxr has :quit command.
And I added this command.

@googlebot I signed it!

Good idea. I'm so used to pressing ^D to exit from shells that I never noticed its absence. Thanks for the PR!


Test: Implemented parallel integration test mechanism

Fixes #
Description
This test exposes this bug:
karpenter-78cc468b57-h689z controller 2022-08-19T23:29:04.324Z	ERROR	controller.provisioning	Could not schedule pod, incompatible with provisioner "markfeather-3-ncysbvhlyj", incompatible requirements, key karpenter.sh/provisioner-name, karpenter.sh/provisioner-name In [arrowrose-4-tzwajhehug] not in karpenter.sh/provisioner-name In [markfeather-3-ncysbvhlyj]; incompatible with provisioner "arrowrose-4-tzwajhehug", key kubernetes.io/hostname, kubernetes.io/hostname DoesNotExist not in kubernetes.io/hostname In [hostname-placeholder-0281]	{"commit": "104576a", "pod": "default/wolverineebony-8-dukkvosoir-586d4c848f-c5qn4"}

How was this change tested?

Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[ ] No

Release Note

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Closing for now since tests are running at a good speed.


Project showcase

A project showcase section can (and probably should) be included, as has already been done for various major front end frameworks like Bootstrap, Foundation, UIKit and others.

Checkout http://picnicss.com/tests if you haven't already.

That is essentially documentation. I was talking more in line with something like the samples provided here:

http://getuikit.com/showcase/
http://expo.getbootstrap.com/
http://foundation.zurb.com/learn/brands.html

This is a really good idea, however I don't know many people who have worked with Picnic so far. Do you have any project to showcase?
I could add:

http://umbrellajs.com/
http://makersupv.com/

Which are functional websites. Doing a showcase itself and creating each of the sites individually would consume way too much time for me.

Both of the above sites look just fine, a separate showcase page can and should be added for them. Putting a shout out for showcase candidates on the Picnic CSS site would also attract attention.

That's a great idea, I'll get it done some time this week

Small showcase done in the homepage. Maybe an image would have been better, but I think it's pretty cool to have an interactive iframe within the page itself.
For faster loads, it doesn't start loading the two iframes until the browser starts to scroll (or reloads scrolled).
If anyone wants to add another website just drop a link somewhere and I'll add it.


sql/sqlite: extract foreign-key constraint names from create statement

Thanks for the review @rotemtam and @yonidavidson. I added unit tests for the regex as @yonidavidson recommended.


Media Handler: renderHint local/remote is an (Array of) HTMLMediaElement

This removes one layer of nesting from the invite/accept mediaHint.
Note that <video> elements no longer get muted if an <audio> is provided alongside.
Usage (compare with 4096365):
  var session = new<EMAIL_ADDRESS>{
    media: {
      render: {
        remote: [
          document.createElement('audio'), // included to demo array support
          document.createElement('video')
        ],
        local: document.createElement('video')
      }
    }
  });

Merged.


Figure out why Robot movements are so shaky/jolty

Figure out why movements are so shaky/jolty. I suspect it  has to do with the tool path generation and the amount of points/planes being generated.
Look into different movement types in Polyscope.

using blend radius solved this issue


Rendering at different resolutions

Hi, thanks for open-source such wonderful code base!
I was wondering why the renderings are quite different when I set the rendering resolution differently?
Specifically, when I train at 1k resolution, and render on 1k(see the left figure), eveything looks fine. However, when I render at 4k resolution (still use the 1k checkpoint), the results turns much darker (see the right figure).
From my viewpoint, mipnerf/zipnerf can be trained with different resolutions. So the rendering at different resolutions should be also fine?
Do you have any idea why this happens? Thanks.

Mipnerf family seems scale-dependent. . https://github.com/google/mipnerf/issues/15
Can the current repo trained with multiple resolution to solve this problem?


Full text API

Extend the current plans API for authorised admins to harvest the full text of plans from their org.

Adding this as a new index endpoint for the plans-api.
Using Sidekiq for background-job processing:
https://github.com/mperham/sidekiq
Sidekiq adds an additional dependancy on Redis, but will enable us down-the-line to support thinks like weekly email reports, notification batching, etc.
I'm implimenting directly via sidekiq instead of using it as an activejob adapter since documentation shows that this is much faster.
Planning on running through once per night (for specified orgs) to generate this JSON object and save it out to either disk or S3. [Rails 5.2 and ActiveStorage would make this configuration easier]
Then fetch this and send to the user via the API-endpoint.
IF the file does not exist, I'll get it to kick-off the process of generating one, and reply with 201.
Then when they check back, they will get the JSON object. (assuming processing is complete)

I'm not best placed to UAT this, but since it's been out on -dev and flagged to a couple of unis I assume all is ok. Do you know if they trialled it?

Closing this as API Implimented.
Will add other issues for additional API features


Homework-3 Hospital Management using OOPS concepts

Drift video: Drift video link
Created two packages: One for users and other for plans and billing
abstract class HealthInsurance
interface : InsuranceBrand
computing: payment to be made as well as premium to be paid
Commented some excess getters and setters provided in the question but not used in the program execution.

Metric
Value

alert_status
:white_check_mark: OK

bugs
1

code_smells
7

reliability_rating
C (at least 1 Major Bug)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0

Metric
Value

alert_status
:white_check_mark: OK

bugs
0

code_smells
7

reliability_rating
A (0 Bugs)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


add streamlit app to explore graph by dynamically generated svg

it is possible, but quite hard, to make javascript library for fully dynamic exploring

js is better #20


Make the code look simpler

Description

This looks good to me, but perhaps you could make the commit message more descriptive of the actual change. If I read "make the code look simpler" I have misgivings! Maybe mention the switch statement since that is the specific change

you are right,i will change my commit messave,thanks
---Original---
From: "Michael @.>
Date: Mon, Aug 19, 2024 20:32 PM
To: @.>;
Cc<EMAIL_ADDRESS>Subject: Re: [apache/lucene] Make the code look simpler (PR #13666)
This looks good to me, but perhaps you could make the commit message more descriptive of the actual change. If I read "make the code look simpler" I have misgivings! Maybe mention the switch statement since that is the specific change
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


[Release] sdk/resourcemanager/hybridnetwork/armhybridnetwork/2.0.0

https://github.com/Azure/sdk-release-request/issues/4655

The breaking changes are introduced and approved in this PR.

The breaking changes are introduced and approved in this PR.

@JeffreyRichter , please approve this major version release by adding label of Approved Major Version, thanks.


Update the ffi for getPageX, getPageY, getMetaKey, getWhich

It looks like the ffi for getPageX, getPageY, getMetaKey, getWhich are returning jQuery objects right now, but the purescript signatures say they return Number, Number, Int, and Boolean respectively.

Oops, thanks!


Separate safety contract from correctness / panic freedom

Users should be able to annotate their unsafe functions with safety conditions and to differentiate between safety and panic freedom / correctness properties.
For example, the Index function index and the slice get_unchecked have the same pre-conditions, however, violating these conditions have very different consequences. Many users of index rely on the fact that it will panic if their assumptions about the index is incorrect. Thus, their contracts should reflect this difference.

Since panic conditions are part of a function specification and documentation (see example), I think we might need to create a new attribute for describing a function's panic condition (e.g. kani::panics_if. With this attribute, Kani should:

Verify that the function must panic under the specified condition
Verify that there is no UB and the post-condition holds under the non-panicking condition

For example, for unwrap, the contract would be along the lines of:
#[kani::requires(true)] // the function is safe
#[kani::panics_if(self.is_none())]
#[kani::ensures(|result| if let Some(x) = self { result == x })]


Updating ApplicationInsights sample json

@ggailey777 -- I missed this section when we updated the full host.json previously. I removed the "includes" usage -- wasn't sure if that was the correct approach to this.

@ggailey777 -- can you take a look at this? I missed it in one of my previous updates.

@brettsam thanks for the update to this doc! I have pulled your changes into a PR in our private repo and all verification checks have passed. Your changes are now merged into master and will go into production at the next live update.
You can now close this PR.

Thanks @craigshoemaker!


(Site) Username/Email field menu reveal-privacy issue?

Websites i visit  that i have registered onwith a username/Email field drop down reveal them selves when about to sign in, any way to prevent this?  check out attached pic
https://imgur.com/a/cK6Et

https://github.com/ghacksuserjs/ghacks-user.js/issues/29#issuecomment-281868627

By your own admission .. you are about to sign in. How did you expect to enter the username data with the contents of it being invisible? The "dropdown" will only show if you click or start typing in the field.
You can disable it entirely - the info is all in the js. You can also enforce a master password, and make it ask every time - this way nothing will come up until you allow it, but will still save you remembering your account name(s) and password(s) - which, by allowing saved passwords/logins, this should also encourage you to use strong passwords.
There's always usually going to be a trade-off between convenience (easy to login, no mistakes/typos, faster) vs security (can now use extra strong unique passwords and different account names etc, no need to remember) vs privacy (shit, some a-hole was spying on with his telescope at a 1000 yards). That last point .. if you are going to log in, at some stage the username will be visible,


workerless

WIP to get rid of the worker for sixels.
May close #7.
TODO:

[ ] test cases for #37
[ ] document worker removal

Now without worker:

sixel processing ~1.5x faster
latency got much better (making xtermdoom playable in firefox, too), also we now have quite instant cursor moves in jexer
downside: decoding happens in mainthread (eats precious main CPU), still it is streamlined, thus should not create perceivable blocking
10 kB less on final packages
no more separate worker file (much easier to deal with on integrator side)

The workerless rework actually surfaced another issue - #37. Should be fixed before we merge the PR and do another release.

#37 is still not fully fixed. It needs a more involved change in the decoder package (see #37 for details).

is it available for testing ?

@pmp-p
No not yet. Well you can build it from this PR, if you want (worker already gone).
#37 is currently blocking this PR, but I might do an independent release, if the fix gets too involving.

Postponing #37, as the adjustments needed to get that properly working are quite involved (needs a fundamental patch in the underlying lib).


Update some 0.8.1 version strings to latest

I found some version strings that are still set to 0.8.1, and it seems that these have snuck their way into current 0.8.2 documentation (see here). This fixes both comments and some documentation that has this incorrect version string.

Ah, thanks. I should add a test for this so I don't miss it next release.


Command run when level reach seem not work

I trying to give player a permission when player reach a level with condition and permissision node , but not work . So i try command , and it still not work .-.
Config: https://pastebin.com/Pu0EA7Vg

Server Type (Spigot/Paperspigot/etc):
Spigot
Server Version (using /ver):
1.13.2 Lastest
Relevant plugins (Delete if this isn't needed):

Is the player reached the 40 level of job and got something?

I use the /job level command to increase player level , the command section should run a command tell player something , but nothing happen

This works properly with your configuration. You should see that the player is jumping at levels 40 to 100 to receive the command and also check that the player has joined that job.


[5.7] Fix _testDSLCaptures

5.7 cherry-pick of https://github.com/apple/swift-experimental-string-processing/pull/554
Previously we would ignore the case where the match fails, but the test expects the match to succeed.

@swift-ci please test


menu on paragraph click

Not necessary for 1.0 but...
on flow element click pull up menu

bookmark
share link to paragraph, whatever element

This is a context menu for sharing and managing specific content on a page. Related to issue #215


About nvidia-driver of Apollo 5.0

A quick question, I am confuing of that.
I saw the Apollo 5.0 of 18.04 should have nvidia-driver over  410.
What about Apollo 5.0 of 14.04 branch?  Is driver 375 still recommended? Or must also over 410 .
Thank you in advanced

@Kailiangdong if you are working on Apollo 5.0 - Ubuntu 14.04, you do not have to use Nvidia 410+.

@natashadsouza Thank you


fix(editor-container): some UI related issues

Closes #355

One small remark to this PR. The first commit does solve the collapsed margins issue, as we did it before the use of the editor-container. However, action icons mwc-fab might not be completely visible.


Can't go to upload page

When I click Photo icon, it's not going to upload or create page (stuck in current page).
Just the photo icon be darken

Strange thing I don't remember adding this in the previous commits. Will have a look into it.

i have the same problem

Can I upload PHOTOS from my desktop??

same problem here too

It's not possible to upload from desktop at the moment.
We are looking for maintainers of this project too.

It's now possible to upload photos. We're going to add full support for this in the next few weeks.


Proposal for Abstract Classes and Methods

Proposal for Keyword abstract
This is a proposal for a new keyword, abstract, to allow for incomplete/partially implemented classes.
Introduction
This proposal expands upon #6, #2946, #2947.
Consider the following situation. A user would like to create a base class that shouldn't be instantiated as a template for derived classes. S/he might write something like
class Animal {
    public age : number;
    public yearsLeft() { return 20 - this.age; }
    public makeSound() : string { return "???"; }
}

class Cow extends Animal {
    makeSound() { return "Moo"; }
}

class Cat extends Animal {
    makeSound() { return "Meow"; }
}

Today, the writer is forced to make a choice: either (i) Animal can be declared an interface, but then yearsLeft cannot have an implementation, or (ii) write the program as above, but then Animal can be instantiated and makeSound has a bogus implementation! Neither of these options is particularly attractive.
We propose abstract as a class declaration modifier to allow the programmer control over whether a class can be instantiated, and as a member function modifier to control whether said member function offers an implementation (and whether the enclosing class is abstract).
Details
The modifier abstract can prepend a class declaration or a member function declaration. Constructors cannot be declared abstract.

Objects whose type is typeof C where C is an abstract-declared class (hereafter abstract class) cannot be instantiated via calls to new.
A member function declared abstract does not have an implementation.
Abstract methods cannot be called within a class member function body via super.foo() where foo is an abstract method belonging to the parent class.
Abstract methods may be called within a class member function body via this.foo() where foo is an abstract method belonging to that class.
If a class has any abstract methods, then the class itself must be declared abstract.
Abstract methods are inherited.
Abstract methods can be overridden in the derived class, either by an abstract method (effectively a re-declaration) or a function declaration that offers an implementation.
A method cannot be simultaneously abstract and static.
A method cannot be simultaneously abstract and private.
If an abstract member declaration contains an explicit accessibility modifier, then the modifier must precede the abstract keyword.
Overloads on a member function must be either all abstract or all not abstract.
Overloads of abstract member functions must be declared adjacent to eachother.
Objects whose type is the type of an abstract class can only be assigned to other objects whose type is the type of an abstract class. For example,

The following code snippet summarizes valid and invalid usages of the abstract keyword

class A {
    // ...
}

abstract class B {
    foo(): number { return bar(); }
    abstract bar() : number;
}

new B; // error

import myB = B;
new myB; // error

var BB: typeof B = B;
var AA: typeof A = BB; // error, AA is not of abstract type.
new AA;

function constructB(Factory : typeof B) {
    new Factory; // error -- Factory is of type typeof C
}

var BB = B;
new BB; // error -- BB is of type typeof C

var x : any = C;
new x; // okay -- undefined behavior at runtime

class C extends B { } // error -- not declared abstract

abstract class D extends B { } // okay

class E extends B { // okay -- implements abstract method
    bar() { return 1; }

abstract class F extends B {
    abstract foo() : number;
    bar() { return 2; }
}

abstract class F {
    abstract qux(x : number) : string;
    abstract qux() : number;
    y : number;
    abstract quz(x : number, y : string) : boolean; // error -- declarations must be adjacent

    abstract nom() boolean;
    nom(x : number) boolean: // error -- use of modifier abstract must match on all overloads.
}

class G { // error -- not declared abstract
    abstract baz() : number;
}

Pros

Allows the programmer to write partial implementations of a class.
Provides a mechanism for the type system to warn about classes that shouldn't be instantiated.
abstract annotations clarify the role of base classes in various patterns.

Cons

Increases the complexity of the language.

To Be Discussed

Should abstract be allowed within class expressions?

Proposed Changes to Grammar
A.6 Classes
  ClassDeclaration:
   abstractopt class Identifier TypeParametersopt ClassHeritage { ClassBody }
  MemberFunctionDeclaration:
   MemberFunctionOverloadsopt MemberFunctionImplementation
   AbstractMemberFunctionOverloads
  AbstractMemberFunctionOverloads:
   AbstractMemberFunctionOverload
   AbstractMemberFunctionOverloads AbstractMemberFunctionOverload
  AbstractMemberFunctionOverload:
   AccessibilityModifieropt abstract PropertyName CallSignature ;
A.10 Ambients
  AmbientClassDeclaration:
   abstractopt class Identifier TypeParametersopt ClassHeritage { AmbientClassBody }
  AbstractOrStatic:
   abstract
   static
  AmbientPropertyMemberDeclaration:
   AccessibilityModifieropt AbstractOrStaticopt PropertyName CallSignature ;
EDIT: updated to clarify the assignability of objects of "abstract type".

Thanks for that!

Moreover, the assignability of abstract types is restricted to instances that are abstract

I do not understand what you mean by this.

Increases the complexity of the language.

Pretty much how I feel about it. I'd rather see a more lean functional-like TypeScript then adding astronaut like  OO patterns like abstract or decorators.
This overlaps tons with mixins or traits too (combining things from other things)

@mhegazy This definitely needs re-wording.
We want to prevent the constructor of an abstract class from being invoked. So we wanted to restrict the assignability of the constructor function. Consider the following example:
class A {}
abstract class B extends A {}

var BB: typeof B = B;
var AA: typeof A = BB;
new AA;

We don't want the second assignment to be legal. So we restrict the assignabilty of objects whose type is the type of an abstract class to other objects whose type is the type of an abstract class.
I haven't yet implemented this as part of the attached PR.

@jbondc so true, inheritance (for the sake of code "reuse" or whatever else) is a hands down rotten idea, composition does it all with a little bit more effort, screw this s*t

:+1:

:hankey:  I'd love to hear how this aligns with the design goals:
5. Produce a language that is composable and easy to reason about.
6. Align with current and future ECMAScript proposals.

Non-goals
1. Exactly mimic the design of existing languages. Instead, use the behavior of JavaScript
and the intentions of program authors as a guide for what makes the most sense in the language.

I have long argued of the merits of embracing the protypical nature of ECMAScript instead of projecting a traditional OO paradigm.  On the other hand, that hasn't stopped the wider community rejecting that and ECMAScript has taken a large bend towards traditional OO with ES6, though there seems much debate on this, as several of our ECMAScript luminaries seems to be conflicted on every aspect of this.
@jbondc I think it is a fair challenge to question this proposal in line with design goals 5 and 6.  It is very likely that some sort of abstract/traits/composition type features will end up in ES, though there seems to be no common consensus.  Both abstract and traits were proposed during the class discussions in ES6/2015, but all got dropped because no one could agree.  TypeScript already has interfaces which provide a sufficient level of abstraction ahead of any implementation of something along this line of ES.
The traits discussion (#311) was closed by @RyanCavanaugh because of this conflicting with goal 6.  I quote:

There's a lot of overlap here with mix-ins; it would be bad (or at least treacherous) to do both. With mix-ins being a potential part of ES7/ES8+, we want to take the runtime side of this very conservatively and get TC39 to agree on a proposal in this area first.

I honestly don't see what the difference is here.

@jbondc so true, inheritance (for the sake of code "reuse" or whatever else) is a hands down rotten idea, composition does it all with a little bit more effort, screw this s*t

While I am personally a fan of compostability, a strong emotive response without well thought arguments is unlikely to further your thoughts, especially when it appears you want to throw your arms up in the air and walk away.  I don't think that is your intent, but that is the way it comes across.

Here is the statement: inheritance is a dangerous tool that causes more problems that solves

it takes knowledge, practice and discipline to use it right (which junior/mid developers generally lack)
it takes experience to grasp the understanding where it may NOT be used
yet, given all of above, even experienced developers with well designed systems fall short when requirements change and it comes to redesign and it turns out that existing inheritance hierarchies are too rigid to change

All this contributes to frustration, missed deadlines, and myths that coding is hard. In my experience nothing is hard if designed properly. Well, inheritance encourages bad design by allowing developers to violate:

(open closed principle)[https://en.wikipedia.org/wiki/Open/closed_principle]
(Liskov substitution principle)[https://en.wikipedia.org/wiki/Liskov_substitution_principle]

Besides that

having to choose one single super-class among a few possible others inevitably favoring one predecessor over all equally important others, resulting to skewed hierarchies
in a sub-class, having to comply to the interface of the super-class even though it goes against the needs
leaving a class unclosed and allowing uncontrolled sub-classing that wasn't intended

Besides that, there is quite a number of successful examples of languages without inheritance at all:

(COM)[https://www.microsoft.com/com/default.mspx] where code reuse is achieved with interface inheritance and composition only
functional lanaguges where code reuse is achieved by various means (parametrizing with functions, typeclasses, class modules) without having to alter the existing code

Alright, while we'd love to have a constructive conversation on the merits of different approaches in software design, I believe that classes are a useful abstraction and the abstract modifier would bring utility. For those who prefer using this paradigm, it would surely be helpful.
Unless there are specific "gotchas" introduced in our language from abstract that are not found in other languages, I disagree that users would find this extremely complex. If one understands classes and one understands interfaces, then abstract classes do not require a massive cognitive leap.

Objective thinking:
http://ocw.kfupm.edu.sa/ocw_courses/phase3/ICS201-Offering-052/Readings/p123-armstrong.pdf
What bothers me the most is the increasing and consistent sidestepping of the 'TS design rules' in favor of:

Whatever aligns with the Microsoft Way does not require any justification

@kitsonk I must have missed it, when was abstract ever proposed?
http://wiki.ecmascript.org/doku.php?id=strawman:oldes6

Here's the justification as I see it:

abstract is extremely demanded. It's the highest-ranked thing (sorry, no upvotes on GitHub) from the CodePlex days that we haven't implemented yet. Issue #6 is the only one we've ever cleaned up because there were too many :+1:s to read the thread easily. The most common request we get from internal teams using TypeScript in large systems is abstract. It's one of the top five requests we get when meeting with external teams using TypeScript in large systems. The question on StackOverflow about "How do I do abstract in TypeScript?` is in the top 1% of most-voted TypeScript questions.

abstract is highly precedented in virtually every language with a notion of classes. Developers can reason about it easily because it's a common concept in OO and we can model it in a structural type system without any significant conceptual leaks.

abstract is missing from the language. What I mean is that people are doing things to emulate abstract already and we are failing to provide a way to model that. It's trivial to find TypeScript repos with the exact code throw new Error("abstract");. It doesn't help us to plug our ears and say "la la la inheritance is terrible". You grow a language to meet the demands that exist (abstract and inheritance, in some cases), not the demands that you wish would exist (no one uses inheritance ever because it's terrible).

abstract is unlikely to be a future ES proposal because it's essentially a type system feature. ES wouldn't really gain anything from adding abstract into the runtime because you can already emulate a late error with throw, and it would increase script startup time too much to make it an early error. And even if it did happen, it's very likely to have the same semantics as the ones described here -- in terms of runtime behavior, the design space has only one or two decisions.

abstract is not difficult to reason about and I question the good faith of someone who would put that forth as a legitimate argument. I can explain this concept in the space of a tweet: "You can't construct an abstract class. Abstract methods are in abstract classes. Abstract methods lack bodies. #typescript #abstract". It doesn't require non-local reasoning. If you were stuck in a library with no books from the last dozen years, you could still read a doc written about how abstract works in C++, Java, C#, Scala, etc, and come away with a correct understanding of how it works in TypeScript.

This feature matches every one of our design goals and non-goals. I am absolutely baffled that anyone would claim otherwise. Non-goal 1 is an important point in favor of this keyword, because we want to "use the behavior of JavaScript and the intentions of program authors as a guide for what makes the most sense in the language". We've seen that people fake abstract all the time (see point 3 above) by throwing errors or other approximations. I understand that not everyone is writing inheritance-based programs, but there are other programmers out there who are, and those people are frequently wishing this feature existed.

Don't think it is fair to call It "the Microsoft way" because it is a really a much requested feature here on GitHub (https://github.com/Microsoft/TypeScript/issues/6#issuecomment-96849896) and on CodePlex.
So some might not like it but others do. It is impossible to keep everyone happy after all.

@RyanCavanaugh Yes because there's no multiple inheritance in Java or C#?
If people prefer a faster horse, fine. I'll take the car.

http://stackoverflow.com/questions/1991042/what-is-the-advantage-of-using-abstract-classes-instead-of-traits
Odersky et al's Programming in Scala recommends that, when you doubt, you use traits.
What's the Microsoft philosophy?

It's not useful to argue the merits of inheritance in this thread.  Inheritance is part of JavaScript.  TypeScript supports JavaScript.  Done.
Will TypeScript support other modeling methods, like composition via traits?  I suspect it will at some point, especially since the JS committee is working on things like mixins.  We'll support them as they land in JS.
Let's keep the conversation here to the merits of 'abstract' as a useful concept to help TypeScript support JavaScript's already existing inheritance functionality.

I see, so its not useful to discuss progress. Will be my last comment but will address the @RyanCavanaugh philosophy:
1.  abstract is extremely demanded. ... The most common request we get from internal teams
using TypeScript in large systems is abstract.

It's called a selection bias. Fairly referred to as the "Microsoft Way".
  2. abstract is highly precedented in virtually every language with a notion of classes

There used to be a time in the 1940s when women weren't allowed to vote. That got quite a lot of thumbs up. Fortunately, there's something called progress and believe it applies to programming languages.
  3. abstract is missing from the language

Just because people have learned or been told to think a certain way and
grown into some habits doesn't mean we shouldn't challenge the status quo.
  4.  abstract is unlikely to be a future ES proposal

Cool we agree. Next up const, readonly, sealed right?
Nice goalpost move by making this a "type system" feature instead of an OO concept.
5. abstract is not difficult to reason about and I question the good faith of someone
6. This feature matches every one of our design goals and non-goals.
 I am absolutely baffled that anyone would claim otherwise

Good, not baffled that you are baffled. My thinking/ideology is different then yours, clearly I must be evil or of have some "ill-faith", burn the heretics!
I'm well aware every language has its culture, but the time for the protestant church.bs is overdue.

I'm not sure why you feel so impassioned against a feature you are sure you will never use.
Progress is a relative term, and while you may not find your domain is sufficiently serviced by a paradigm, consider the importance of being open minded in building a language - others have built well-thought-out designs using such paradigms and benefited greatly from them.
Furthermore, ad hominems like saying we are going with the "Microsoft way" is non-constructive (if not just insulting), and likening shifting away from OO to women's suffrage issues is, well, extreme. Let's try to keep a more tempered discussion on this issue.

While I feel as impassioned about that wrangling purist-OO paradigms into ECMAScript is "bad", I agree with @DanielRosenwasser that laying it at the feet of "Microsoft way" diminishes all the hard work the TypeScript team have done.  They strike me as a group of people who try their hardest to do the right thing, and try to limit external commercial imperatives that might influence them.  abstract is not a Microsoft thing, it is a very very common OO paradigm.  abstract does not break, or limit any of the features that I care about and upon reflection I agree with @RyanCavanaugh that it is every likely to conflict with ECMAScript, but largely, TC39 haven't proposed it.  Other than promoting solving a problem in what I would consider an anti-pattern, which is simply a matter of opinion, there is nothing to this.  It isn't being morally relativistic with the TypeScript design principles.

I've retracted some of my comments, no intent to insult anyone and the fantastic job by the TS team. Learned a lot from the compiler, continue to learn and its a real work of art. Got carried away by the "question the good faith of someone", apologies for that.

No worries; text is a lossy format for tonality and intent :smile:. Everyone in this discussion is well-intentioned. Even if it's not coming off that way, know that we understand your concerns and value them. Keep giving us feedback - it's a learning experience for us too.
(Also we appreciate the kind words guys!)

Abstract support will never hurt anyone. If you don't want to use it, don't. Nobody's forcing you to use it. Assuming that this won't require re-architecting the project much (I doubt it will), I see absolutely no reason not to implement this feature.

@aozgaa Why the close?

abstract implemented in PR #3579 and merged into master

Beautiful

Another language got contaminated. Mainstream developers got a mainstream
reason to be happy. Black day of sadness.
On Jul 1, 2015 7:45 PM, "Bryan Rayner"<EMAIL_ADDRESS>wrote:

Beautiful
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/TypeScript/issues/3578#issuecomment-117854229
.

@aleksey-bykov Many developers think this is a useful feature. You can create a fork without abstract support, stay on an old version, or just don't use abstract support. Nobody is making you use it.

Just another thing to throw to garbage at linting and the rule for it is
darn simple. Nevermind
On Jul 1, 2015 7:55 PM, "Gaelan"<EMAIL_ADDRESS>wrote:

@aleksey-bykov https://github.com/aleksey-bykov Many developers think
this is a useful feature. You can create a fork without abstract support,
stay on an old version, or just don't use abstract support. Nobody is
making you use it.
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/TypeScript/issues/3578#issuecomment-117855967
.

Algebraic data types and pattern matching is not even in the road map.
 Upsetting
On Jul 1, 2015 8:07 PM, "Aleksey Bykov"<EMAIL_ADDRESS>wrote:

Just another thing to throw to garbage at linting and the rule for it is
darn simple. Nevermind
On Jul 1, 2015 7:55 PM, "Gaelan"<EMAIL_ADDRESS>wrote:

@aleksey-bykov https://github.com/aleksey-bykov Many developers think
this is a useful feature. You can create a fork without abstract support,
stay on an old version, or just don't use abstract support. Nobody is
making you use it.
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/TypeScript/issues/3578#issuecomment-117855967
.

Looks like C# is going to get them sooner than we here. Thats just plain
embarrassing
On Jul 1, 2015 8:21 PM, "Aleksey Bykov"<EMAIL_ADDRESS>wrote:

Algebraic data types and pattern matching is not even in the road map.
 Upsetting
On Jul 1, 2015 8:07 PM, "Aleksey Bykov"<EMAIL_ADDRESS>wrote:

Just another thing to throw to garbage at linting and the rule for it is
darn simple. Nevermind
On Jul 1, 2015 7:55 PM, "Gaelan"<EMAIL_ADDRESS>wrote:

@aleksey-bykov https://github.com/aleksey-bykov Many developers think
this is a useful feature. You can create a fork without abstract support,
stay on an old version, or just don't use abstract support. Nobody is
making you use it.
—
Reply to this email directly or view it on GitHub
https://github.com/Microsoft/TypeScript/issues/3578#issuecomment-117855967
.

@aleksey-bykov, I'd actually love to have mixins as a feature, but can't comprehend doing it without structured type support. Our codebase is far too big and our developers too few to do much meaningful development without the benefits typing brings.
Have you started submitting a proposal for mixins with typescript? If you haven't, are there good references to prior work where someone might begin working on fleshing that out? At this point if there's no proposals from TC39 which have stuck, it might as well start it's life here on the Typescript project

@Gaelan You're totally right!

:+1:  thank you. A right tool for the right job.

@aleksey-bykov C# operates under a completely different set of constraints than TypeScript does. We could love pure functional programming more than anyone but it doesn't change the rules we actually need to operate with as we design for the future (ie conforming to future ECMAScript standards). If you want an arbitrary set of language features/semantics that compile to JS there are a lot of options, but TypeScript isn't one of them. There are also web centric languages that have opted to add desirable expression level features divorced from ECMAScript standards. The value/success of these two divergent strategies is left as an exercise for the reader ;)
Suffice to say, we love designing new language features and want to keep adding stuff that makes everyone's lives easier, but it's simply not the case that we get to just pick our favorite features from Haskell, Smalltalk, etc and put them into TypeScript with no regard for future ECMAScript incompatibility they may/will cause.

Great job!
Just one question: it seems that properties cannot be abstract.
The code public abstract get myProp(): string; is not accepted.
Limitation or bug?

@Yves57 this is by design. there is no way to currently to distinguish between a property accessor and a property declaration, so a derived class can define a property declaration and would meet abstract constraints, but probably this is not what you intended by making the accessor abstract in the base.

@mhegazy To be more precise, my case is the following
interface IMyInterface { myProp: string; }
abstract class MyBase implements IMyInterface { abstract get myProp(): string; ......... }

But I understand that this is a specific case!

@Yves57, I've faced exactly same problem. Looks like this case isn't so rare...
It would be better if abstract class was allowed to miss fields from it's interface (both value properties and methods), like in other OOP languages.
So, this should be allowed:
interface A { p; m(); }
abstract class B implements A {}
class C extends B { get p() {...}; set p(v) {...}; m() {...} }

But currently it gives:

Error:(2, 16) TS2420: Class 'B' incorrectly implements interface 'A'. Property 'p' is missing in type 'B'.

Also I think that abstract value properties should be allowed in abstract classes (same way value properties are now allowed in interfaces):
abstract class A {
  abstract p;
}
class B extends A {
  get p() {...}
  set p(v) {...}
}

@denvned can you file separate issues to track the two requests, 1. abstract properties, and 2. missing property declaration in abstract class implementing interfaces.

I'm trying to use this in WebStorm 11 with TS1.6... Not working?

@electricessence WebStorm doesn't use our language service, so unless this is an issue you're seeing at compilations (i.e. not while editing) you should probably check in with them.
Though, it looks like they should support it: http://blog.jetbrains.com/webstorm/2015/09/webstorm-11-eap-142-4723/

@bryanerayner +1 for:

@aleksey-bykov, I'd actually love to have mixins as a feature, but can't comprehend doing it without structured type support.
Have you started submitting a proposal for mixins with typescript? If you haven't, are there good references to prior work where someone might begin working on fleshing that out?

@bryanerayner, @AJamesPhillips
mixins are evil, choose composition<EMAIL_ADDRESS>

@aleksey-bykov agreed, I shouldn't have said mixins as practically they share major downsides with multiple inheritance.  For the moment I'm:

making sure my inheritance trees are as shallow as possible
using the is-a guideline
utility functions
And when all that fails because you have multiple base classes something "must" inherit from (and which utility functions can't deal with elegantly) then the constructor sets public and or private attributes set to helper functions and or class instances; with or without a reference to the instance.

Would be very interested to see composition / stamps / aspect / traits, in TypeScript.

It works in 11.
From: Daniel Rosenwasser<EMAIL_ADDRESS>Sent: Tuesday, November 03, 2015 3:44 PM
To: Microsoft/TypeScript
Cc: electricessence
Subject: Re: [TypeScript] Proposal for Abstract Classes and Methods (#3578)
@electricessence https://github.com/electricessence  WebStorm doesn't use our language service, so unless this is an issue you're seeing at compilations (i.e. not while editing) you should probably check in with them.
Though, it looks like they should support it: http://blog.jetbrains.com/webstorm/2015/09/webstorm-11-eap-142-4723/
—
Reply to this email directly or view it on GitHub https://github.com/Microsoft/TypeScript/issues/3578#issuecomment-153525943 .Image removed by sender.


Button to support 'disabled' and 'active' state

Is your feature request related to a problem? Please describe.
There are multiple use cases in which there is a need for a disabled and active button state to restrict a user's interaction.
We need a designed 'disabled state' and 'active state' solution that is distinctive from the main auro-button that restricts a user's ability to interact with the form function within the view.
Describe the solution you'd like
A new design element that addresses this need and is distinctive from the standard auro-button.
Describe alternatives you've considered
None
Additional context
None
This story supports https://github.com/AlaskaAirlines/auro_docs/issues/60

@vidalmenAS I am assuming that this issue is rescoped to only be the DISABLED state?
Can you also add a link to the design asset?

https://app.abstract.com/projects/3b79fe3f-3a67-4df4-a60c-1d1174583a94/branches/master/files/b92430dd-2f01-438c-a1b9-1b4fc647cecc

Is there any timeline for when this feature will be added? My team had to revert back to using ods-button so we could use the disabled state.

I moved that to Sprint 12 as a top priority. It should be any day now. Sorry for any issues this may have caused.

Please let me know as well when the disabled button is added...