SMTP authentication fails after password change within Gogs

Hi all,
I've enabled the SMTP authentication provider and login as well as auto profile creation works so far.
But if a user wants to change his password within Gogs, logins with the new password aren't possible. Instead, he gets a 500 message shown. But if he logs in with the old password (which is actually the one for his mail account) it works fine.
In my opinion the behavior of the SMTP authentication and auto profile creation should be changed to something like this:

First time login with email address and email password using SMTP authentication creates a new profile (provisoning)
If the user changes his/her email address and/or password from within Gogs, the authentication source for the particular user should be set to local instead of SMTP, because the provisioning has already been made within Gogs. This could easily be done by changing the columns login_type and login_source in table user.

Btw: I already tried to change the authentication source using an admin account in the backend, but this doesn't seem to work as well. See #1375 for more details.

Another (better) option would be, to disable password change for this authentication source

I agree with @stonerl , same apply for LDAP in another issue thread.

I disagree, because the user should always be capable of changing his password, even if the original authentication source is SMTP or LDAP. Changing the email password has more drawbacks than just changing the password for Gogs. E.g. the user needs to enter the new password on all devices he has setup the email account.

@nurtext I disagree I for example use the SMTP authentication to allow users to use Gogs to have just one username and password for all services. Our university has a destingushed site where users can change there password.
Furthermore when a user does not have his university account I don't want him to be able to login anymore. If want this I as an admin would change his authentication source deliberately. I think it is a bad idea to let user change the authentication source just by chanheing his password in gogs.
Also it would confuse users. I tell them they can use their email account to login. Then they change the password in gogs, believing that they changed there password for all accounts.

@stonerl Good point.

Now on develop branch, non-local users are not allowed to change their password.

To improve user experience, a possibility to add a link to the actual password management page (of a single sign-on system) would be nice. The URL could be set up in the settings of each authentication source.

@janh Thanks for the suggestion but I think it does not matter as Gogs is not a public site provider, you always know you're logging with what account.

Close as implemented.


paragraph parser using mediawikiparserfromhell in Wikipedia2Vec style

A first attempt at adapting the paragraph construction from Wikipedia2Vec to the python-mwtext package. Putting up an early version so feel free to comment on any part of it!

The output format can easily be changed, but this is what the first paragraph from the first non redirect article in english wiki looks like [text, links, section_idx, section_name],
[
    'Anarchism is a political philosophy and movement that rejects all involuntary, coercive forms of hierarchy. It radically calls for the abolition of the state which it holds to be undesirable, unnecessary and harmful.',
    [
        ('Political_philosophy', 'political philosophy', 15, 35),
        ('Political_movement', 'movement', 40, 48),
        ('Hierarchy', 'hierarchy', 97, 106),
        ('Radical_politics', 'radically', 111, 120),
        ('State_(polity)', 'state', 152, 157)
    ],
    0,
    'Introduction'
]

New output format,
{
  "wikilinks": [
    [
      "political philosophy",
      "political philosophy",
      15,
      35
    ],
    [
      "Political movement",
      "movement",
      40,
      48
    ],
    [
      "hierarchy",
      "hierarchy",
      97,
      106
    ],
    [
      "Radical politics",
      "radically",
      111,
      120
    ],
    [
      "State (polity)",
      "state",
      152,
      157
    ]
  ],
  "section_name": "Introduction",
  "section_idx": 0,
  "text": "Anarchism is a political philosophy and movement that rejects all involuntary, coercive forms of hierarchy. It radically calls for the abolition of the state which it holds to be undesirable, unnecessary and harmful."
}

Codecov Report

Merging #4 into master will increase coverage by 13.23%.
The diff coverage is 61.00%.

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
+ Coverage   24.85%   38.09%   +13.23%
===========================================
  Files           7        8        +1
  Lines         173      273      +100
===========================================
+ Hits           43      104       +61
- Misses        130      169       +39

Impacted Files
Coverage Δ

mwtext/wikitext_preprocessor_mwpfh.py
60.60% <60.60%> (ø)

mwtext/__init__.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f267e...a5e8f48. Read the comment docs.

Codecov Report

Merging #4 into master will increase coverage by 20.26%.
The diff coverage is 74.21%.

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
+ Coverage   24.85%   45.11%   +20.26%
===========================================
  Files           7        8        +1
  Lines         173      297      +124
===========================================
+ Hits           43      134       +91
- Misses        130      163       +33

Impacted Files
Coverage Δ

mwtext/wikitext/structured_mwpfh.py
73.17% <73.17%> (ø)

mwtext/__init__.py
100.00% <100.00%> (ø)

mwtext/about.py
100.00% <100.00%> (ø)

mwtext/wikitext/plaintext_regex.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f267e...5c64628. Read the comment docs.

closing as this PR was consumed by #6


⬆ Upgrade Starlette to 0.17.1

⬆ Upgrade Starlette to 0.17.0
0.17.0 addresses issue Starlette issue #1255, preventing BaseHTTPMiddleware from raising anyio.ExceptionGroup.

Looks good to me and I'm looking forward to this upgrade for some time. Thank you, @simondale00 for helping with pushing this one forward.

Hey @tiangolo! Curious what additional steps I'll need to take to help get this merged. Thanks in advance!

Just wait.

Just wait.

Wait for what?
It's a bit hard to decide what to do at this point.

An MR is up. Wait for the MR to be merged and deal with manual edits to debug things until then.
Depend on a fork of our own or a third party pinned commit.

If the MR is gonna take ten months, then we might as well fork and depend on that. If not, then we would just wait for the new release.
Can we get some type of... idea about the state of this and some sort of rough timeline?

No one can give you an estimation, sorry.
The only one with merge rights is @tiangolo , and by the time he sees this PR, he'll probably just merge it.
If you don't want to fork, you can also pin a version predecessor to 0.69 (I'm on my phone, but I think it was 0.68.2).

Is it possible to provide a range of versions of Starlette, or is 0.17.0 the absolute minimum?

Is it possible to provide a range of versions of Starlette, or is 0.17.0 the absolute minimum?

0.17.0 is the absolutely minimum to apply this specific fix, preventing Starlette from raising anyio.ExceptionGroup.
Though to your point, provided that Starlette adheres to semver, it might be more appropriate to pin FastAPI to >=0.17.0,<1.0.0

@simondale00 semver only kicks in after 1.0. That's basically why is pinned here.
@adriangb proposed to have a pipeline that runs periodically against the latest Starlette version (or master), and would auto-merge the pin/range. Maybe we can do something about this, but it's up to @tiangolo . :kissing:

@adriangb proposed to have a pipeline that runs periodically against the latest Starlette version (or master), and would auto-merge the pin/range

Auto-bumping would be cool!
But I was thinking something much more basic: just running the pipeline and watching it for errors.
That way we can fix smaller issues (instead of fixing the accumulated issues since the last bump), and we'd also have the opportunity to make changes in Starlette before they cut a release.

Version 0.17.1 of Starlette has been released, which fixes a bug in the authentication mechanism. I have run into this bug during development. Please use this version instead of 0.17.0.

I guess there is no problem if everything works smoothly, right now the 0.16.0 do all jobs so waiting for Sebastian to bump the to the last version of starlette 🌟

@simondale00 Could you update the PR to use 0.17.1?

It really doesn't matter. @tiangolo will see the PR, and it will update it himself. Just wait for him to check this. :kissing:

@tiangolo I do see these exceptions raised a lot during our performance tests. Would you mind taking a look at this?

This time delay is kind of crazy.

I also got bug with starlette<0.17.0。
wating for this PR  be merged  , thanks

@tiangolo this causes a lot of errors on our server, would be great if you could merge!

@tiangolo sorry for bugging you again, but only today I have seen this exception raised over 100 times on my pre-prod environments. Is there any way I could help with upgrading the fastapi's dependencies?

@tiangolo sorry for bugging you again, but only today I have seen this exception raised over 100 times on my pre-prod environments. Is there any way I could help with upgrading the fastapi's dependencies?

Maybe you can contact him on twitter, if the problem is really urgent

Maybe you can contact him on twitter, if the problem is really urgent

It's been urgent for about a month and a half now; check out the backlog of the issue.

@tiangolo sorry for bugging you again, but only today I have seen this exception raised over 100 times on my pre-prod environments. Is there any way I could help with upgrading the fastapi's dependencies?

Maybe you can contact him on twitter, if the problem is really urgent

I've reached out via DM on Twitter, will let you know here should I get a response. Is there anyone else who can help out in the meantime?

I'd love this too, I've just pushed an empty commit to kick off tests.

@tiangolo could you merge this? Our production app has been getting a ton of errors a day

Looks like this project needs a backup maintainer

#4263

Thanks @simondale00! :rocket:
And thanks a lot @Kludex and @samuelcolvin! Your help is very much appreciated. :bow: :cake: :sunglasses:

This is now available in FastAPI 0.71.0. 🔖🚀

Thanks so much @tiangolo.

@tiangolo when it will be uploaded to pip?

@tiangolo when it will be uploaded to pip?

@Redict It's already available on PyPI: https://pypi.org/project/fastapi/0.71.0/#history

https://stackoverflow.com/questions/71222144/runtimeerror-no-response-returned-in-fast-api-when-refresh-request
The problem is still alive! please refer to above link

Hello @Ashkan-Hadadi!
Is this issue still bothering you?
Right now I'm stuck on FastAPI 0.75 (released on March, 5) and issue persists there. But it's interesting for me if it was solved in next versions? Looks like FastAPI got many Starlette updates recently.

@alex-pobeditel-2004 - I'm still seeing the behavior as described in this bug on the latest version, so I think it's still an open issue.

Im using fastapi = 0.78.0 and still facing this issue, sadly

Looks like another fix for it will arrive with next Starlette release:
https://github.com/encode/starlette/issues/1634

I'm having the same issue here. Noticed that I started to happen after I changed from axios < 0.22 to 0.22. I was using cancelToken before, and AbortController now.

any update?

? 🤔

still facing the issue in fastapi = 0.79.0

Discussion on the Starlette repository: https://github.com/encode/starlette/discussions/1527


Microphone doesn't appear on "Test in WebChat" in Azure Bot Service

I have followed all the instructions noted above.  I created a basic Virtual Assistant Bot that has all the coding details mentioned here:  https://docs.microsoft.com/en-us/azure/bot-service/directline-speech-bot?view=azure-bot-service-4.0
When I deploy and test the bot, I don't see the Microphone icon either in "Test in WebChat" in Azure Bot Service or the Bot Emulator.  What Am I missing.
Template I used:  https://microsoft.github.io/botframework-solutions/tutorials/csharp/create-assistant/1_intro/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aa4cb4da-ca0e-fc7f-686c-f3510bf9af0b
Version Independent ID: e20d2896-dcec-8e46-2f50-2227def34250
Content: Connect a bot to Direct Line Speech (Preview) - Bot Service
Content Source: articles/bot-service-channel-connect-directlinespeech.md
Service: bot-service
GitHub Login: @trrwilson
Microsoft Alias: travisw

@mapoitras Thank you for pointing out the issue. The team is aware of the problem and is working to fix it.
If you want to test a Bot with voice input and voice output, please check the Direct Line Speech Client on GitHub.

If you want to test a Bot with voice input and voice output, please check the Direct Line Speech Client on GitHub.


fix: ScheduleJob should not be triggered with endTimestamp expired

fixes: #4884

If your build fails  due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 37.93%. Comparing base (6ac0180) to head (61e9c8e).

Files with missing lines
Patch %
Lines

...l/support/cronscheduler/application/schedulejob.go
0.00%
7 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4894   +/-   ##
=======================================
  Coverage   37.93%   37.93%
=======================================
  Files         122      122
  Lines       11775    11775
=======================================
  Hits         4467     4467
  Misses       6925     6925
  Partials      383      383

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


⚠ Bofrost.be has degraded performance

In ea2cf97, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1768 ms

Resolved: Bofrost.be performance has improved in 78b28ed.


[BEAM-5884] Move the nullable attribute onto FieldType.

Looking
On Mon, Dec 3, 2018 at 5:25 PM Udi Meiri<EMAIL_ADDRESS>wrote:

This may have caused precommit to time out:
https://issues.apache.org/jira/browse/BEAM-6171
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/7175#issuecomment-443934402, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AUGE1adobQrTxDd7UZevBSz3NPz20CeUks5u1c8dgaJpZM4Y8gJa
.


For information, all my models extend the same "BaseModel" class:
public abstract class BaseModel {
    @PrimaryKey
    public long id;
}

(For information, this gives me a build error. I cannot launch my project anymore...)

Can I see your whole models? I don't have enough information to look into.

I can reproduce this bugs in deeply nested models. Investigating.

This is fixed in v3.1.1. Can you give it a try?

It works. Thanks!


CI: add integration tests to github action yaml

reference to #17
add steps to run:

Solid Authorization tests
Solid API tests

thanks @hrchu, then let's do "the latest and hottest Python version minus one": Python 3.9.

thanks @hrchu, then let's do "the latest and hottest Python version minus one": Python 3.9.

Good idea!


Process Multiple URLs

I had the need to scrape multiple URLs and simply output the combined json result with express when complete.
I originally asked Matt about this and he requested that I open an issue in case anyone else needed an example. After some more testing, I came up with an example using the async npm mpdule. I'm sure there are many other ways, but this seems to work fine. Hope it helps someone.
app.post('/process-urls', function (req, res) {
    var urls = [
      {
        url: 'http://google.com',
        selectors: {
          title: 'title'
        }
      },
      {
        url: 'http://github.com',
        selectors: {
          title: 'title'
        }
      }
    ];

    var sendResponse = function (result) {
      res.json(result);
    };

    process(urls, sendResponse);
  });

  var process = function (urls, sendResponseCallback) {
    var asyncCallback = function (err, obj) {
      return obj;
    };

    async.parallel([
      x(urls[0].url, urls[0].selectors)(asyncCallback),
      x(urls[1].url, urls[1].selectors)(asyncCallback)
    ], function (err, results) {
      if (!err) {
        sendResponseCallback(results);
      }
    });
  };

Thanks! Yep this is my original response:
instances in parallel and join the responses before serving the output via express.

In the future I may add it to x-ray directly. Was running into argument conflict last time I tried.


⚠ Adacta-fintech.com has degraded performance

In c8a6d55, Adacta-fintech.com (https://www.adacta-fintech.com) experienced degraded performance:

HTTP code: 200
Response time: 2215 ms

Resolved: Adacta-fintech.com performance has improved in 96eebd3.


Perf: Matches dying out on large popular profiles

MariaDB [leafapp_infinite]> analyze  select count(*) as aggregate from `games` inner join `game_players` on `games`.`id` = `game_players`.`game_id` where `game_players`.`player_id` = 4331 and exists (select * from `playlists` where `games`.`playlist_id` = `playlists`.`id`);
+------+-------------+--------------+-------+-------------------------------------------------------------+------------------------------+---------+-------------------------------+------+-----------+----------+------------+-------------+
| id   | select_type | table        | type  | possible_keys                                               | key                          | key_len | ref                           | rows | r_rows    | filtered | r_filtered | Extra       |
+------+-------------+--------------+-------+-------------------------------------------------------------+------------------------------+---------+-------------------------------+------+-----------+----------+------------+-------------+
|    1 | PRIMARY     | playlists    | index | PRIMARY                                                     | PRIMARY                      | 8       | NULL                          | 36   | 36.00     |   100.00 |     100.00 | Using index |
|    1 | PRIMARY     | games        | ref   | PRIMARY,games_playlist_id_foreign                           | games_playlist_id_foreign    | 9       | leafapp_infinite.playlists.id | 1017 | 554443.92 |   100.00 |     100.00 | Using index |
|    1 | PRIMARY     | game_players | ref   | game_players_game_id_foreign,game_players_player_id_foreign | game_players_game_id_foreign | 8       | leafapp_infinite.games.id     | 1    | 1.30      |     0.14 |       0.02 | Using where |
+------+-------------+--------------+-------+-------------------------------------------------------------+------------------------------+---------+-------------------------------+------+-----------+----------+------------+-------------+
3 rows in set (31 min 14.823 sec)

The problem is taking Laravel shortcuts with things like

has(Playlist)
hasNo(Playlist)

These are generating queries like:
and exists (select * from `playlists` where `games`.`playlist_id` = `playlists`.`id`)

Which is ensuring the playlist_id on games is real. Just having a non-null value is proof enough due to the strict foreign keys. Once we adapt that to a simple is not null on playlist_id - this will remove that inefficiency.
We should double check how LAN/Custom is queried as it might need the invert.


Remove predefined node taint after spegel pod finished initializing on the node

Describe the problem to be solved
On EKS, with Karpenter for nodes provisioning, in 99%, the workload pod starts before the spegel daemonset configures the node. This makes spegel useless in dynamic EKS + Karpenter environments. The suggested in the FAQ solution nidhogg is very unstable and not working as expected or not working at all. Additionally, with Karpenter, adding a taint that Karpenter is unaware of on the node can lead to a situation when Karpenter will create new nodes, because the pod doesn't have the required toleration.
Proposed solution to the problem
Use the "cilium" approach. With Karpenter (or some other methods) add startupTaints with some predefined name. When spegel initialized, it should remove the taint from the node.

I wish this was a solution provided in Kubernetes. There have been a couple of solutions proposed and none of them have been accepted. I wish that every project did not need to implement their own solution to fix this challenge.
I am for creating a solution that would work for both Karpenter users and Cluster Autoscaler users short term. Long term we should consider a KEP to solve this problem in Kubernetes.

With Cluster Autoscaler it's also possible to add some custom taint to Managed Nodegroups that spegel can remove after initialization. So it should work for both.


packaged game crashing at exit

When there's an actor on the map with the Node component, the packaged game crashes on exit with the following error message:

It happens regardless of whether any node scripts were run or not, just having the Node component in an actor which is present on the map produces this error.
It happens when using the plugin compiled from code, the latest master (I haven't tried the relese version), and it affects only packaged projects. When run from Unreal editor there's no crash.
Test project:
https://drive.google.com/open?id=1Do_Hnksl8oFqdHb8fQpFk7luLO4Ok8c8
Packaged:
https://drive.google.com/open?id=1QXofcQruPHCyAeCLEgfPKz1WIH4UGMns
(game is just blank screen, press Esc to exit)
P.S. The crash doesn't happen always, so running the game a few times could be required to reproduce it.

Can confirm I've seen the same crash in packaged builds. I'm using the release version but did delete the binaries folder and rebuild the plugin. Happens occasionally.

Can confirm I've seen the same crash in packaged builds. I'm using the release version but did delete the binaries folder and rebuild the plugin. Happens occasionally.

Do we have a dump or stack trace available for a crash?

Do we have a dump or stack trace available for a crash?

No idea why but I can't get this bug to happen again, if I can manage to replicate it I will try to provide something.

No idea why but I can't get this bug to happen again, if I can manage to replicate it I will try to provide something.

It finally happened again, I'm attaching the logfile from the packaged exe. Let me know if you want me to provide anything else.
I believe the only relevant part is at the very bottom.
BugCrash.txt

It finally happened again, I'm attaching the logfile from the packaged exe. Let me know if you want me to provide anything else.
I believe the only relevant part is at the very bottom.
BugCrash.txt

SOS: I met this bug everytime I quit the game made by ue4 with this plugin.(v0.7.0 for UE 4.26) . I think it causes 'Memory Leak', but I don't know reason. I'm about to read the source code of the plugin, but if you can help me, it'll be highly appreciated.


Add authentication for outside calls made from conditional authentication

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


[stable/redis] Does not work in k8s 1.16

Describe the bug
Does not work in k8s 1.16
Version of Helm and Kubernetes:
Kubernetes 1.16.
Which chart:
stable/redis
What happened:
Error: validation failed: unable to recognize "": no matches for kind "StatefulSet" in version "apps/v1beta2"

Thanks for reporting it. I just created a PR to address the issue.


Fixed issue with windows paths

Windows paths are seperated using '\' rather than '/'. This PR implements the use of os.path.join for path operations as is best practice. Also this properly handles an empty string to represent the current working directory like this: ox.load_graphml('test.gml', folder='')

Coverage remained the same at 93.86% when pulling 326633c959e3b6fa3d0b7970489c8ecd5332c9d5 on jwilson8767:master into 54ee4be1e65c33a41c5751a3ea80a195987a6582 on gboeing:master.


Bump 0.17.dev3

To include the casereader fix in dev package

Codecov Report

Merging #1903 (2e633d5) into main (ccacaf4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1903   +/-   ##
=======================================
  Coverage   81.07%   81.07%
=======================================
  Files          69       69
  Lines        7721     7721
=======================================
  Hits         6260     6260
  Misses       1461     1461


[Event Request] - OnBeforeFindOrCreateJobQueue Codeunit 2160 "Calendar Event Mangement"

Hello, please consider adding the following event to Codeunit 2160 "Calendar Event Mangement"
    [IntegrationEvent(false, false)]
    local procedure OnBeforeFindOrCreateJobQueue(var JobQueueEntry: Record "Job Queue Entry"; var IsHandled: Boolean)
    begin
    end;

and call it accordingly inside the "FindOrCreateJobQueue" procedure:
    local procedure FindOrCreateJobQueue(var JobQueueEntry: Record "Job Queue Entry")
    var
        CalendarEventUserConfig: Record "Calendar Event User Config.";

        **IsHandled: Boolean;**

    begin

        **OnBeforeFindOrCreateJobQueue(JobQueueEntry, IsHandled);
        if IsHandled then
            exit;**

        if FindJobQueue(JobQueueEntry) then
            exit;

        JobQueueEntry.Init();
        JobQueueEntry."Object Type to Run" := JobQueueEntry."Object Type to Run"::Codeunit;
        JobQueueEntry."Object ID to Run" := CODEUNIT::"Calendar Event Execution";
        JobQueueEntry."Maximum No. of Attempts to Run" := 3;
        JobQueueEntry."Recurring Job" := true;
        JobQueueEntry.Status := JobQueueEntry.Status::"On Hold";
        JobQueueEntry."Manual Recurrence" := true;
        JobQueueEntry.Description := CopyStr(JobQueueEntryDescTxt, 1, MaxStrLen(JobQueueEntry.Description));
        JobQueueEntry.Insert(true);

        GetCalendarEventUserConfiguration(CalendarEventUserConfig);
        CalendarEventUserConfig."Current Job Queue Entry" := JobQueueEntry.ID;
        CalendarEventUserConfig.Modify(true);
    end;

Thank you !

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 52463.


Emoji overly large in message notification emails in Outlook

As reported on CZO, emoji in message email notifications are overly large when viewed in Outlook. We might be able to fix this with adding more CSS to the email templates.

CZO thread

@zulipbot claim

@zulipbot claim

@zulipbot claim

@androemeda  are you still working on this issue.?

This issue should be fixed now in #31687 .


Provided List.GetWebRelativeUrl() which gets the web relative URL of a list.

Q
A

Bug fix?
no

New feature?
yes

New sample?
no

Related issues?
none

What's in this Pull Request?
A utility method which allows you to get the 'Web Relative URL' of a list suitable for use in the existing Web.GetListByUrl() function.
When writing code to export a list definition to a file, i.e. XML or JSON, this value is useful as it allows the file to act as an import file.
The Web Relative URL of a list is actually a unique identifier for the list as it can't be changed once created, unlike a title, which makes it extremely useful for examining SharePoint web's to determine if the list already exists.

Hi @sebastianrogers, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@sebastianrogers, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, MSBOT;

Hi Sebastian,
We'll look into this PR, but given the holidays it most likely will not be processed before the next master merge.

Thx for this change Sebastien, we'll merge it.


subtypes & discriminator would benefit from more info

Swagger 1.2 lets you specify a discriminator and possible subtypes, but it doesn't relate the value of the discriminator and the model that should be instantiated.  It would be convenient if this could be expressed in the spec.

@fehguy - Is this still relevant?

I'm wondering how to structure API schemas that use polymorphism and not to put all of them in swagger.json.
Specifying external schema urls in discriminator property would be a way to go: Following cat example, that would be a sample object:
{
  "name": "Felix",
  "petType": "http://example.org/schemas/cat.json"
}

That would be understandable for clients as well, even without building a tree of definitions. What do you think? Could such values be allowed?

Closing it as it's related to 1.2. 2.0 changes things a bit, and we'll tackle the topic in the related modeling issue.

Could you provide the link to the related modelling issue?

@webron

I don't think we need to do anything. It's implicit. Any schema that uses allOf
and includes the parent with the discriminator is applicable.

That still doesn't tell me which of those schemas now is the one to choose, or do I miss something?
Ah, here:

Field Name
Type
Description

discriminator
string
Adds support for polymorphism. The discriminator is the schema property name that is used to differentiate between other schema that inherit this schema. The property name used MUST be defined at this schema and it MUST be in the required property list. When used, the value MUST be the name of this schema or any schema that inherits it.

So this discriminator property must match the name which is used as key in the definitions object for defining the schema (and inline schemas can't be subtypes). I guess the original request by @fehguy was to make this mapping a bit more flexible by not linking the schema keys (which otherwise can be swapped out without changing anything in the API, as long as the refs are changed too) directly to the on-the wire content.

@ePaul if you can remember full intent of comments you've made a year and a half ago, I salute you ;)

I realize that this issue is closed but what was the resolution here?
Do the values of the discriminator field have to exactly match the name of the subType?
Otherwise, how does the client know specifically which value of the discriminator generates which subtype?


[fix](insert into) 'output_tuple_slot_num should be equal to output_expr_num' when insert into unique table with sequence column map

Proposed changes
Pick https://github.com/apache/doris/pull/30635
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0

run fe_ut


Link files together as modules

This would allow one to run the tests with a single command instead of running several command line scripts one by one.

I can use .py files as modules and import them as I would any other module. I have refactored all of my files so that they should be able to successfully work as both (I have put all of the code in each file into functions except for a 'if name == main' statement to run a command line parser and the functions).
However, attempting to run the function pick_rows from the file pick_rand.py fails. This function calls the function choose_rows which creates a list of rows to pick from the input file, it takes the number of rows and the number of rows to pick, and uses random.sample(number of rows, number to pick). When running a file with many millions of rows and attempting to pick 10 it displays:
~/zip_backfill kgudel* 👾  python test.py /users/gudelk/documents/openaddr-collected-us_all/zips.csv /users/gudelk/documents/backfill_test_self.csv /users/gudelk/downloads/tl_2015_us_zcta510/tl_2015_us_zcta510.shp 10 -o
picks rows
Traceback (most recent call last):
File "test.py", line 31, in
pick_rand.pick_rows(args.input, temp_rand, args.number)
File "/Users/gudelk/zip_backfill/pick_rand.py", line 20, in pick_rows
picks = deque(choose_rows(file_len(inputF), number))
File "/Users/gudelk/zip_backfill/pick_rand.py", line 16, in choose_rows
picks = random.sample(xrange(length), number)
File "/Users/gudelk/homebrew/Cellar/python/2.7.10_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/random.py", line 323, in sample
raise ValueError("sample larger than population")
ValueError: sample larger than population
However, the code displays no errors picking 10 from the same file if running the pick_rand.py directly.

Like @kgudel I'm able to replicate the issue using
python test.py ~/Documents/test.csv ~/Documents/test-result.csv ~/Downloads/tl_2015_us_zcta510.zip 10 -o

and have it be successful directly using
python pick_rand.py ~/Documents/test.csv ~/Documents/test-rand.csv 10

Some tests I ran:
Using print len(range(length)) because that's how random.sample does it's check.
1
Adding
print len(range(length))
print number
picks = random.sample(range(length), number)
print sorted(picks)

to pick_rand.py shows that the arguments for random.sample are fine, 10718509 and 10, but random.sample still fails. Output:
10718509
10
Traceback (most recent call last):
  File "test.py", line 34, in <module>
    pick_rand.write_rows(args.input, temp_rand, args.number)
  File "/Users/wolfea/Documents/projects/zip-backfill/pick_rand.py", line 24, in write_rows
    picks = deque(choose_rows(file_len(inputF), number))
  File "/Users/wolfea/Documents/projects/zip-backfill/pick_rand.py", line 17, in choose_rows
    picks = random.sample(range(length), number)
  File "/Users/wolfea/homebrew/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/random.py", line 323, in sample
    raise ValueError("sample larger than population")
ValueError: sample larger than population

2
Calling
pick_rand.choose_rows(10718509, 10)

from test.py works fine. Example output:
10718509
10
[601868, 1666395, 1771443, 3103258, 3965187, 4504986, 6063613, 7278149, 8337408, 9683527]

3
Calling
choose_rows(10718509, 10)

from the write_rows function in pick_rand.py works fine as well. Example output:
10718509
10
[858471, 1162707, 1997237, 2042753, 5830800, 5898246, 7470345, 8790648, 9975243, 9998363]

The 10718509 is the number of rows that happen to be in my .csv which you can see in the output from test 1.


removed sqs. from hostname

With the current implementation, the url (assuming host in the config is goaws) will return sqs.goaws. If the user is running goaws in docker and leveraging container name for networking the current implantation won't work.

I could be wrong and there maybe a better way to leverage docker-compose yaml files.

The reason the .sqs is there was because that is the url that the real sqs uses - I was figuring you could leverage the /etc/hosts file if you needed the name to work.  Usually the queue URL is not used by goaws as you can just connect using the IP address or localhost...  But perhaps I am not understanding your particular use case....     Please elaborate...

While it's nice to make the application more like the real sqs. Having the addition hostname can cause headaches for those running the app, since you have to handle the additional hostname. Changing the /etc/hosts can solve this problem, but it doesn't scale well.

I Love Children.

I do not think scaling is important for an application that is strictly for development purposes.

That is fair. However, this is adding extra steps to the consumer of this repo. Since the url is in the response to the api, the consumer should be able to hit that endpoint directly. How it is currently requires extra work somewhere, wether is is through /etc/hosts, setting up a dns server, or client side logic.
For example, if you are running the docker image by itself on port 4100. The initial requests to setup the subscription will be too localhost:4100. The url sqs.localhost:4100 will be in the response payload for confirming the subscription. The client should be using that url and should not have to do extra work. This will not work by itself because dns resolution will fail to resolve the host sqs.localhost

@kcajmagic you are correct I will merge this and release it.

@kcajmagic  - released @v0.3.0 (docker image also created same version)

@p4tin thank you, this is awesome.


Refactor VmdbDatabase#seed for performance improvements

Initial seed dropped from 6.14s to 2.48s (60% savings)
Second seed dropped from 1.64s to 0.56s (66% savings)
Basically, the big change is that instead of ((N+1)+1)+1 querying Postgres for each table -> index -> (text_table -> index), we just make 2 queries - 1 for all tables including text_tables, and 1 for all indexes.  Then we just do a simple desired state loop over each.
@jrafanie Please review
cc @NickLaMuro

I kept all of the logging of each record, but I really don't like it.  I would love to remove the logging or make it less verbose, but curious what you think.

@Fryguy I will look at this later, after I get lunch dinner... but is this related, or a different approach to https://github.com/ManageIQ/manageiq/pull/18271  ?
cc @kbrock

@NickLaMuro Yes, looks similar, and I hadn't seen it.  Honestly, though, I like my approach better because it...
a) gets rid of the myriad seeding.rb files everywhere, and just does it in one place
b) doesn't create virtual attributes (which in turn means they aren't exposed to reporting to anything else); these things are only used at seed time, so not exposing them is preferable.
c) feels simpler to wrap my head around

Related to https://github.com/ManageIQ/manageiq/pull/16206 (which tries to get it out of the primordial path)

leave something to be desired in regards to documentation

Can you elaborate?  I feel like this code is pretty self-documenting, so I'm curious what more you would like to see?  I commented the new ar_dba methods at least so the expected return types are clear.


Site: Set correct document language

We need to set the lang attribute for the <html> for certain features (e.g., a cookie consent library) to work correctly. For this to work, I moved the <html> and <body> tags from the root layout to the layouts where we know the language (app/[domain]/[language]/layout.tsx, app/block-preview/[domain]/[language]/layout.tsx). Doing so caused errors in outer layouts that rendered tags (e.g., <noscript>), therefore I have removed these layouts and moved the functionality into the inner layouts.
IMO we should consider the two layouts for the site and block preview as the new root layouts.
Additionally, since the actual root layout no longer renders the <html> and <body> tags, the default not found page didn't work any longer. To fix this, I've added a custom not found page that renders the tags. We probably need to do the same for the global error page, but this is out-of-scope of this PR.

Alternatives I've thought of:

Set the document language in the IntlProvider using useEffect. Downside: The attribute is only set on the client
Detect the language in the middleware and pass a header to the root layout. Downside: Dynamic rendering

So I think this is the only viable solution.


crypto/x509: VerifyHostname validating wrong SAN

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)? 1.9.2
Does this issue reproduce with the latest release? Yes
What operating system and processor architecture are you using (go env)?
GOHOSTARCH="amd64"
GOHOSTOS="linux"
What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
I'm using a program (NGINX Ingress Controller) that uses the VerifyHostname.
While this function is called, it returns me an error about Certificate not containing a valid CommonName (certificate is not valid for any names, but wanted to match server.domain.tld).
Looking to the Certificate, it does contain the name server.domain.tld as a CommonName.
While investigating, I've faced that it's entering the if here.
This function verifies if the Certificate has an extension (and it does, an email, but not a DNSName) and if this is the case, it tries to add the value to the rest of the 'valid' string.
As my certificate does contain an extension, but not a DNSName, shouldn't this function be something like if len(c.DNSNames) > 0 instead of c.hasSANExtension()?
If this is the case, I can open a PR to fix this :) Anyway I'm going to ask the re-creation of the Certificate with the right SAN.
Thanks!

Have you tried Go master? (what will become Go 1.10 in early Feb)
There's been work in this space.

I believe that this change here caused this behavior:
GO 1.6
https://github.com/golang/go/blob/aa1e69f3fc21795b6fab531a07008e0744ffe5bf/src/crypto/x509/verify.go#L427
if len(c.DNSNames) > 0 {
		for _, match := range c.DNSNames {
			if matchHostnames(toLowerCaseASCII(match), lowered) {
				return nil
			}
		}
		// If Subject Alt Name is given, we ignore the common name.
	} else if matchHostnames(toLowerCaseASCII(c.Subject.CommonName), lowered) {
		return nil
	}

GO 1.9 (master)
https://github.com/golang/go/blob/70ee9b4a07d356e9187dd23683ed2254c91984cd/src/crypto/x509/verify.go#L1010
if c.hasSANExtension() {
		for _, match := range c.DNSNames {
			if matchHostnames(toLowerCaseASCII(match), lowered) {
				return nil
			}
		}
		// If Subject Alt Name is given, we ignore the common name.
	} else if matchHostnames(toLowerCaseASCII(c.Subject.CommonName), lowered) {
		return nil
	}

We had another problem related to changes in verifications too... :-(
https://github.com/cloudflare/cfssl/issues/827

Please file separate bugs for separate issues.
But keep in mind we don't fix old versions of Go. We mostly care about recent regressions, not long-standing bugs. We fix long-standing bugs in the next Go release (Go 1.10, in Feb). So please try Go master now and report any issues with that.

This is working as intended. commonName is deprecated and is intentionally not used if a SAN extension is present (whether or not it has dnsNames).
The commit message for the change mentioned above makes this clear:
crypto/x509: ignore CN if SAN extension present.

The code previously tested only whether DNS-name SANs were present in a
certificate which is only approximately correct. In fact, /any/ SAN
extension, including one with no DNS names, should cause the CN to be
ignored.

This post explains the rationale for the complete removal of support commonName in Chrome, the same information is relevant in this case.


CI: Update libdav1d to 0.9.1-dmo1

Coverage increased (+0.4%) to 83.958% when pulling 12514c55c66fd8a266cccb7db2816cc2b660c691 on vibhoothi:ci-dav1d-0.9.1 into f6c841fe9234e9e08a801e884bec1d91a3c6f9f4 on xiph:master.


Dart lang should provided us an web framework

Dart lang should provided us an web framework .
Which like kotlin provided us ktor, Scala provided us playframework, Groovy provided us Grails.
Dotnet provided us asp.net mvc.
If there was a web framework built with dart (with official support)
More developers would like learn dart and use it.
Dart lang is a language which been  underestimate |

Whats wrong with just using angel?

I had this same discussion just yesterday with a college. For Dart being a very Web focused language, it is strange how a lot of libraries like mysql, postgresql, etc are all external 3th party developed packages.
This has even have created issue where people recommended sqljocky but this library is now incompatible with Dart 2. Some people have continued the work under a different package name but its not exactly what you expect. The whole switch over from Dart 1 to Dart 2 is slightly messy because public information is now out of date and now makes people look at libraries that are not even supported anymore.
For a product developed at Google, it very strange that this detail of Google serving old information ( because of the naming ) gets overlooked. Might have been better to use a different name.

@mrmcq2u angle-dart seems good, but pub as official tools, should be have the tool inside the box.

https://webdev.dartlang.org/angular is a full-featured web framework provided by google. Hope this meets your needs.

The original request was for a server-side web framework angular is a client side web framework.
For now the Dart team is focusing on being an awesome client side language. We're really happy that the community is also doing cool things on the server side - as of right now that won't be an area that the Dart team is prioritizing.

Thank you for this update. This also explain the lacking AOT compiler in the SDK.
As we wanted Dart for a more all around projects ( including server focused projects ), this means we will drop our exploration of Dart for future project. Thank you again for this update.

ping @dgrove , Angular not server side web framework.


siac host config doesn't check types, and is unable to read the values

Based on the help line:
  siac host config [setting] [value] [flags]

I'd expect this to error out, as blah is not really a bool:
sia@shade ~ $ siac host config acceptingcontracts blah
Host settings updated.

Moreover, this should probably show the current set value
sia@shade ~ $ siac host config acceptingcontracts
Usage:
[...]

Also, the following should probably list all the current config values...
sia@shade ~ $ siac host config
Usage:
[...]

I like your suggestions. Good catch with acceptingcontracts blah -- it's probably only checking for != "false". The config values can be viewed with siac host, but it wouldn't hurt to display them in siac host config as well.

Looks like a lot of the parsing is incomplete with the errors. For example siac host config maxduration 15weeks seems to set the configuration to 15 blocks instead of returning an error.

I believe that is a failing of fmt.Sscanf: it will stop scanning as soon as it consumes a value. Not sure what the best approach is for handling that. There's strconv.Atoi, but that only works for int.

@lukechampine Not everything is displayed in siac host, for example the bandwidth parameters (I'm not even sure what they are and what should be the values)

@Krakonos everything is displayed as of the master branch. The bandwidth parameters got removed altogether because there's actually no support for them on the backend, they were misleading because they did not actually do anything.
We'll add the bandwidth parameters back once the backend can actually respect the settings.

@DavidVorick Thanks, I'm running 6f72438, updated few moments ago, with the competitive price calculation (great!), but additional parameters are still in the help. I'm looking forward to the bandwidth prices, as I'd utilize it in the future, as my bandwidth is a bit limited, but still stuitable for log term backups (which would hopefully never accessed for example..).

oh, good to know. I will make a PR to update the help string right now.

I don't think this is the current behavior. Please reopen if it can be reproduced.


use shares denominated amount in terminate _principalWithdrawable

Hey please check the comments I have added here
https://github.com/sublime-finance/sublime-v1/blob/kush/c4march21-copy/contracts/PooledCreditLine/LenderPool.sol

Hey please check the comments I have added here https://github.com/sublime-finance/sublime-v1/blob/kush/c4march21-copy/contracts/PooledCreditLine/LenderPool.sol#L357

https://github.com/sublime-finance/sublime-v1/blob/kush/c4march21-copy/contracts/PooledCreditLine/LenderPool.sol#L360
-- It is not necessary that _borrowLimit is the borrow amount asked by the borrower in the PCL. For example, if just the _minBorrowAmount was met and the start function was called.
https://github.com/sublime-finance/sublime-v1/blob/kush/c4march21-copy/contracts/PooledCreditLine/LenderPool.sol#L364
-- Typo: _borrowLimit and not _borrowedLimit. Also instead of principal borrowed it would be better using amount borrowed, since you anyway can't borrow anything apart from the principal
https://github.com/sublime-finance/sublime-v1/blob/kush/c4march21-copy/contracts/PooledCreditLine/LenderPool.sol#L365

@saxenism
I have made some changes in the comments. But I have not understood the issue with line 373-375.
as stated

// the amount of _borrowAsset deposited by lenders against the PCL is equal to totalSupply[_id]
// when the PCL is active totalSupply[_id] == _borrowedLimit
// but _borrowLimit is some cases can be different than totalSupply[_id]
// for eg: before the PCL has started the borrowLimit asked by borrower is 1000USDC
// but the lenders have only deposited 900USDC till now so totalSupply[_id] is 900USDC

borrowLimit is set twice, once in the createRequest method and then in the _accept method. The above statements seem true to me.


pipeline is not supporting custom output directory

I've tried a number of ways to provide an alternate reporting directory other than the default reports/ directory, but nothing seems to change it.
example Gulp task
gulp.task('test', ['lint'], function() {
  var config = {
    files: {
      src: [
        './src/**/*.js',
        './test/**/*.spec.js'
      ]
    },
    plugins: {
      mocha: {
        reporter: 'dot'
      },
      istanbul: {
        dir: './reports/coverage/phantomjs/',
        writeReports: {
          dir: './reports/coverage/phantomjs/',
          reporters: ['json', 'text-summary', 'cobertura', 'html']
        },
        reportOpts: {
          dir: './reports/coverage/phantomjs/'
        },
        thresholds: {
          global: 50
        }
      }
    }
  };

  return gulp
    .src(config.files.src)
    .pipe(testNode.test(config));
});

still only the reports directory is populated.
Also, do test results behave in the same way?  That should be checked too.

I noticed there is discussion about this happening in #33 , not sure if that is relevant.

@thescientist13, I was able to get it working by moving config.plugins.istanbul.reportOpts to config.plugins.istanbul.writeReports.reportOpts:
gulp.task('test', ['lint'], function() {
  var config = {
    files: {
      src: [
        './src/**/*.js',
        './test/**/*.spec.js'
      ]
    },
    plugins: {
      mocha: {
        reporter: 'dot'
      },
      istanbul: {
        dir: './reports/coverage/phantomjs/',
        writeReports: {
          dir: './reports/coverage/phantomjs/',
          reporters: ['json', 'text-summary', 'cobertura', 'html'],
          reportOpts: {
            dir: './reports/coverage/phantomjs/'
          }
        },
        thresholds: {
          global: 50
        }
      }
    }
  };

  return gulp
    .src(config.files.src)
    .pipe(testNode.test(config));
});

thanks @bsawyer  this is the minimal example needed for me
istanbul: {
        writeReports: {
          reportOpts: {
            dir: './reports/coverage/phantomjs/'
          },
          reporters: ['json', 'text-summary', 'cobertura', 'html']
        },
        thresholds: {
          global: 50
        }

any thoughts on junit test results?  say for example I want test-results.xml output to
reports/test-results/test-results.xml ?

maybe we should provide an example in the README?  I think part of it is the istanbul API has three configuration points for reporting / directory output, that I can see 🤷♂
https://github.com/SBoudrias/gulp-istanbul#api

https://github.com/SBoudrias/gulp-istanbul#dir
https://github.com/SBoudrias/gulp-istanbul#istanbulwritereportsopt
https://github.com/SBoudrias/gulp-istanbul#opt-2

@thescientist13 I can update the readme to reflect those configuration options. To your previous question it's possible to define individual reporter options but a file name is also required:
    istanbul: {
      writeReports: {
        dir: './reports',
        reporters: ['json', 'text-summary', 'cobertura', 'html'],
        reportOpts: {
          'cobertura':{
            dir: './reports/test-results',
            file: 'test-results.xml'
          }
        }
      }
    }

@bsawyer
is that for junit or corbetura or both?

By default, doing something like this
https://github.com/kenzanlabs/pipeline-validate-js/blob/master/gulpfile.js#L31
gulp.task('test', function() {

  return gulp
    .src(config.files.src)
    .pipe(testNode.test());
});

outputs results like this
https://kenzan.ci.cloudbees.com/job/CI-pipeline-validate-js/ws/reports/
The ask here is to be able to make the output location of _test-results.xml and corbetura-coverage.xml configurable.  There may be no "bug" per se, but perhaps just an opportunity to improve our documentation a bit, maybe by adding an example of this kind of configuration in the README?

I got it working using this, which satisfies configurable output of both coverage and test-results.
    plugins: {
      mocha: {
        reporter: 'mocha-junit-reporter',
        reporterOptions: {
          mochaFile: './reports/test-results/test-results.xml'
        }
      },
      istanbul: {
        writeReports: {
          reportOpts: {
            cobertura: {
              'dir': './reports/coverage/phantomjs/',
              'file': 'converage.xml'
            }
          },
          reporters: ['cobertura']
        }
      }
    }


Skill Boxes on a Skillmap Look Like Buttons

Describe the bug
The boxes that display a skillmap stage's skills look very similar to the buttons lower down on the page. In the screenshot below, the top set are not buttons, the bottom set are.

@thsparks if you can work with @clkantner and come up with a point fix we can take up for this release. If not this is not a regression so we should be good.


Hide archived chats

+1 ... to add to description, archived chats show up as active chats, they should be hidden.

I'd love to see some consideration on this.  Having messages from my ex wife show up there from a year ago is a bummer I see every day via YakYak.

Guys #351 #453 #623 #346

I'm not sure why you're linking those issues.  Half of them are closed and refer back to this one -- that's why I commented on this one.  Anyway, would like to see some progress here if possible.  Good luck, contributors!

They refer to this one because i have just mentioned them here :D

Please re-open, not everybody uses Hangouts the same way and it's rather important to keep archived chats hidden.  We don't need any special code that toggles them on/off, just simply don't load in or parse chats that are archived when displaying the list, please.

Thank you!

We are showing everything that is sent from the server, with no distinction...
For this to be implemented I think we need someone to:

In conv.coffee create some logic to prevent archive conversations to be shown by using the view property in the conv object which cat take the following values:

conv.self_conversation_state.view[0] = "VIEW_ARCHIVED" or "VIEW_INBOX" or "VIEW_UNKNOWN"
Looking for a volunteer to code this :)

I'm glad this is re-opened! I signed in to YikYak today for the first time. I only use it to talk to my girlfriend and my advisor, but it was showing me chats I hadn't participated in for 3-5 years. Archived chats should be hidden!

The archived chats I have are from when someone moved to a new id (e.g. my daughter started using her married name).  I keep these hidden so I don’t choose them by accident, and also because they are not part of my current set of chats.  But they are still relevant, so I want to access them when I need to.  I have no trouble on my other computers (nor on the Chrome app on the PC).  It’s part of Hangouts, so should be implemented in this app too.  (And it’s hardly difficult to do, surely.)

Did this ever get merged in?

It doesn't appear so. I'm hoping for this change as well.


feat: add "interactedWith" contract to Yearn metadata

@kaladinlight a little POC for you - add the contract address that the Yearn transaction interacted with to our parser metadata.
I'm also getting the feeling that all parsers will use a shared metadata type, rather than their own, but we'll see.
Supports https://github.com/shapeshift/unchained/issues/286 and https://github.com/shapeshift/web/issues/1086.

Closing this for the moment, as we need to give the functional requirements more thought.
https://github.com/shapeshift/web/issues/1086#issuecomment-1057480963


Check if Octokit exception contains errors

It appears that sometimes there are no errors associated with an Octokit
exception as show by:
https://app.getsentry.com/hound-1/production/group/53642463/
This fix checks for presense of an error before fetching :code from it.

:+1:

@gylaz, this issue came up again.


Bodymovin not exporting all elements in the comp

I'm trying to export quite a simple animation with path and position changes. No expressions, no special effects,
Still, when exporting the JSON file it makes curved shapes flat and joints abruptly short.
also not exporting all shapes in the comp.
Pls, help... @bodymovin
Any suggestions on how to fix this?
Playzone.json.zip
Playzone.aep.zip

@bodymovin


Adding some support for Exosite Portals to pyonep.

Tested on Python 2.7.9 and 3.4.1 on OSX.
To see some functionality, run
cd ~/sandbox/pyonep
python pyonep/portals/examples.py

This should be a non-breaking change because it puts all of the Portals stuff under pyonep/pyonep/ and doesn't change anything except the added package to setup.py.

Ok. I think this is a good 1st pass at adding Portals API support to pyonep. Please advise if you'd like to see anything else before pulling this in.

Oh and btw if you don't like the names of the modules and the overall structure / namespacing, now would be the time to change it.

Thanks for the PEP8 changes. Re: namespace, it seems like this is the general structure:
Domain - handles auth with a particular Portals domain
      |
Portals - stateless pass-through API end point methods
      |
Bindings - helper methods

Most of the time I'd instantiate Bindings since that has the sugar methods in it and those are generally necessary. It seems like the code will be more readable if Portals were the thing being instantiated. Is it important to separate the two? If so, could Portals just contain a Helpers object with the glue methods in it?
e.g. something like this
Domain - handles auth with a particular Portals domain
      |
Portals - stateless pass-through API end point bindings
 -> Helpers - helper methods

I could be missing a subtlety, let me know.

That's a great idea! But I think we could sidestep helpers and bindings if
I renamed Portals to Endpoints and Bindings to Portals.
On Oct 20, 2015 2:02 PM, "Dan Weaver"<EMAIL_ADDRESS>wrote:

Thanks for the PEP8 changes. Re: namespace, it seems like this is the
general structure:
Domain - handles auth with a particular Portals domain
|
Portals - stateless pass-through API end point methods
|
Bindings - helper methods
Most of the time I'd instantiate Bindings since that has the sugar
methods in it and those are generally necessary. It seems like the code
will be more readable if Portals were the thing being instantiated. Is it
important to separate the two? If so, could Portals just contain a Helpers
object with the glue methods in it?
e.g. something like this
Domain - handles auth with a particular Portals domain
|
Portals - stateless pass-through API end point bindings
-> Helpers - helper methods
I could be missing a subtlety, let me know.
—
Reply to this email directly or view it on GitHub
https://github.com/exosite-labs/pyonep/pull/41#issuecomment-149668425.


Prepare to release 0.2.81

@JohnTitor: no appropriate reviewer found, use r? to override

@bors r+

:pushpin: Commit 6ea4b3134d9a898f4cb7e8da634cdbd7077e5046 has been approved by JohnTitor

:hourglass: Testing commit 6ea4b3134d9a898f4cb7e8da634cdbd7077e5046 with merge 70962e3943d22d94141954db18eb7295b5edec5d...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 70962e3943d22d94141954db18eb7295b5edec5d to master...


Eliminate end-of-life checks for .NET Core 2.1 builds

We need to build second-level test assemblies for 2.1 as well as testcentric.engine.core, which is referenced by our external engines. The latter may be eliminated in a future issue.

:tada: This issue has been resolved in version 2.0.0-alpha5 :tada:
The release is available on:

GitHub Release
NuGet Package


Request for new built-in dateFormat in deriver

Hi, I propose adding week-number as a built-in helper for deriver's dateFormat.
case "W":
var firstJan = new Date(date.getFullYear(),0,1);
return Math.ceil((((date - firstJan) / 86400000) + firstJan.getDay()+1)/7);
It goes very nicely with scatter plot, and other time series analysis.

Thanks for your proposal :)
I've discussed this in the past here https://github.com/nicolaskruchten/pivottable/pull/77 and concluded against including it, given the wide variety of different ways to compute the "week number".

Understood. Thanks.


Paul Irish relative protocol url issue.

The google api still uses the old fashioned
forward slash url omitting the scheme in the url, like so:
//lh6.googleusercontent.com/-y7auqvtnhCg/AAAAAAAAAAI/AAAAAAAAN70/MXzXyHW0lQw/photo.jpg
This causes Alamofire network requests to retrieve that image to fail, and print an error message that reads the url being invalid, despite it being correct.
Please read this article by Paul Irish:
http://www.paulirish.com/2010/the-protocol-relative-url/
Companies use this url when an asset is available in both the HTTPS and HTTP domains, so throwing in HTTPS: before urls that have a prefix of two forward slashes will always work.
self.fullUrl = urll.hasPrefix("//") ? "https:\(url)": relativeUrl
Can I add this fix as a pull request, what are your thoughts on this?

Given that this is more of a web browser feature and Apple hasn't already done this automatically, we're going to have to be somewhat careful about implementing this outside of official NSURL support.

This is not something that we should support in Alamofire. You'll need to modify the URL before passing it into Alamofire so that it is a properly encoded, valid URL. These are the same requirements Apple has with the NSURL APIs.
public protocol URLStringConvertible {
    /// A URL that conforms to RFC 2396.
    ///
    /// Methods accepting a `URLStringConvertible` type parameter parse it according to RFCs 1738 and 1808.
    ///
    /// See https://tools.ietf.org/html/rfc2396
    /// See https://tools.ietf.org/html/rfc1738
    /// See https://tools.ietf.org/html/rfc1808
    var urlString: String { get }
}

Cheers. 🍻


Add missing await in Masonry integration test

Deploy preview for gestalt ready!
Built with commit c87e1cb1fd963b30f7c8c57744b694098007f4fc
https://deploy-preview-340--gestalt.netlify.com

Warnings

:warning:

:memo: CHANGELOG - Please add a CHANGELOG.md entry for your changes

  Generated by :no_entry_sign: dangerJS


queenbee recipe link command gives OSError: symbolic link privilege not held

This is a permission issue on Windows. One can resolves this by running the command as admin.
@AntoineDao, thinks there should be a way to run this command without need to admin account and wants to explore the options!

Another resolution for this is to use WSL on windows 😄


any ideas for an old developer?

Ive been developing using MS techs for a long time now.    I was hoping MVC would be on that list.  But, alas, it is not, and with core, you get MVC, along with EF, and thats how its done now.  Screw that.  It still seems like bad tech.  So... should I leave the MS family altogether(I do know other languages).  Go back to databases only?  Stick with ASp.NET 4.X and hope core eventually dies?  What do you guys think?

Hi. It looks like this is a question about how to use (or in your case, not use) ASP.NET Core. While we do our best to look through all the issues filed here, this is an opinion based question, rather than a code based issue, may we suggest posting your questions to  StackOverflow?
Please consider tagging your StackOverflow question with  asp.net-core and/or asp.net-core-mvc.

I used this because it was what was recommended on the APS.NET webpage.  It said for product feedback, use this github link.  So I did... and now its closed, and you are tellign me to use stack overflow.    Nice customer service.  Yet another reason to leave MS behind.

From: Barry Dorrans<EMAIL_ADDRESS>Sent: Monday, August 13, 2018 10:02 AM
To: aspnet/Home
Cc: djg973; Author
Subject: Re: [aspnet/Home] any ideas for an old developer? (#3425)
Hi. It looks like this is a question about how to use (or in your case, not use) ASP.NET Core. While we do our best to look through all the issues filed here, this is an opinion based question, rather than a code based issue, may we suggest posting your questions to StackOverflowhttps://www.stackoverflow.com?
Please consider tagging your StackOverflow question with asp.net-core and/or asp.net-core-mvc.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/aspnet/Home/issues/3425#issuecomment-412528530, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AoYq9s5yevOTm9vYG1fbRCKHdfMeUeBsks5uQYb2gaJpZM4V6ies.


WIP: Do Not Merge - Test sleep 30m

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [hh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


bower.json missing and .bower.json missing main attribute

Hi,
I have installed the markercluster via bower and i noticed that there is no bower.json file. Besides that, the .bower.json misses the main attribute.
Could you please fix that?
Thanks

Bower removes the bower.json when you bower install. Why do you need it?

to know the file i would use from the library because i use the main attribute to get the file i should use

Oh, gotcha.
Well, the bower.json currently does have a main attribute, but because the maintainer forgot to make a release for it or assign a tag, bower doesn't know it's been updated.
So once that happens, you should be good to go.

We have the main attribute in the leaflet-master branch, so this will be fixed when that eventually releases.


Omit the version part from the OS name

The convention of other providers and the expected format
of the OS field name is to contain the name only, without the
version.
The version is being concatenated to the OS name on the UI
side, therefore the code which did it on the provider side is
removed.
http://bugzilla.redhat.com/963905

@miq-bot assign @blomquisg

@miq-bot add_label darga/yes

@miq-bot add_label blocker

@masayag Please add tests.  Thank you!

@moolitayer in response to @jrafanie's comment, is there a way to update the tests from https://github.com/ManageIQ/manageiq/pull/10795 that shows the record with the expected format for the name?

@blomquisg looks like you want @masayag to add tests to the ones done in #10795
Let me know if I am needed for anything...

@moolitayer d'oh!  Yeah ... autocomplete failure
@masayag see this comment.

Darga BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1376543

Darga Backport conflict:
$ git cherry-pick -e -x -m 1 43e011f
error: could not apply 43e011f... Merge pull request #11384 from masayag/report_host_os_product_info
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

$ git status
On branch darga
Your branch is up-to-date with 'upstream/darga'.
You are currently cherry-picking commit 43e011f.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	modified:   spec/models/manageiq/providers/redhat/infra_manager/refresh_parser_spec.rb

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   app/models/manageiq/providers/redhat/infra_manager/refresh_parser.rb

$ git diff

diff --cc app/models/manageiq/providers/redhat/infra_manager/refresh_parser.rb
index 7848d91,f089090..0000000
--- a/app/models/manageiq/providers/redhat/infra_manager/refresh_parser.rb
+++ b/app/models/manageiq/providers/redhat/infra_manager/refresh_parser.rb
@@@ -324,9 -340,21 +324,27 @@@ module ManageIQ::Providers::Redhat::Inf
    def self.host_inv_to_os_hash(inv, hostname)
      return nil if inv.nil?

++<<<<<<< HEAD
 +    result = {:name => hostname}
 +    result[:product_name] = 'linux'
 +    result
++=======
+     {
+       :name         => hostname,
+       :product_type => 'linux',
+       :product_name => extract_host_os_name(inv),
+       :version      => extract_host_os_full_version(inv[:os])
+     }
+   end
+
+   def self.extract_host_os_full_version(host_os)
+     host_os[:version][:full_version] if host_os && host_os[:version]
+   end
+
+   def self.extract_host_os_name(host_inv)
+     host_os = host_inv[:os]
+     host_os && host_os[:type] || host_inv[:type]
++>>>>>>> 43e011f... Merge pull request #11384 from masayag/report_host_os_product_info
    end

    def self.vm_inv_to_hashes(inv, _storage_inv, storage_uids, cluster_uids, host_uids, lan_uids)

@masayag @oourfali @blomquisg Is someone working on resolving the darga/conflict?

There was a dependency between this PR to commit https://github.com/ManageIQ/manageiq/pull/10795  which was already backported to to darga branch.
The current PR should now be applied to the darga branch without conflicts.
@chessbyte Could you give it a try ?

@chessbyte should be possible to backport to darga now that https://github.com/ManageIQ/manageiq/pull/10795 has been backported

Backported to Darga via https://github.com/ManageIQ/manageiq/pull/12203


[Mapper] Add InMapper & OutMapper

Check out the README:
https://github.com/Zewo/Zewo/blob/genericMapper/Modules/Mapper/README.md

Current coverage is 71.34% (diff: 100%)

Merging #140 into master will not change coverage

@@             master       #140   diff @@
==========================================
  Files           130        130
  Lines          6609       6609
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           4715       4715
  Misses         1894       1894
  Partials          0          0

Powered by Codecov. Last update 603ae02...ccc9fda

Looks good from afar! Could you add some tests and doc comments (just method-level stuff, like here) to make it easier to understand how this works? What's ContextualMapper for?

@Danappelxx yes, sure, I'll add some tests and docs. You can check out Mapper PR at Quark, it's thoroughly tested, I will just migrate them from there)

Circle will work if you update Scripts/Travis/install.sh from master :)

@Danappelxx sorry, I don't understand what you mean :)

Circle is failing because there's an outdated swift install script on your
branch. Master has an updated one, so if you replace yours with it the
build should pass.
On Mon, Sep 26, 2016 at 8:21 AM Oleg Dreyman<EMAIL_ADDRESS>wrote:

@Danappelxx https://github.com/Danappelxx sorry, I don't understand
what you mean :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Zewo/Zewo/pull/140#issuecomment-249602017, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADI4c3-hMYDl-72ro-zfwlCo840uwsQBks5qt-LegaJpZM4J_7JW
.

--
Dan Appel

@Danappelxx now get it, thanks 👍

let's have this merged for 0.15.0 (:

@dreymonde can we finally merge this? haha it's done right? just need a rebase?

@paulofaria yes, I think it's ready :) Maybe just rename Keys to MappingKeys, what do you think? I'm afraid of name conflicts.


llvm: missing libunwind support

it looks like no-one's tried to upstream https://github.com/riscv-android-src/toolchain-llvm-project/commit/839f6eecc8c9272b8095cb38555ee7954c5bb4f3 yet (and worse, it looks like upstream has rewritten that code quite a bit, so there will be merge conflicts to deal with: https://github.com/llvm/llvm-project/blob/main/libunwind/src/UnwindCursor.hpp).

@rprichard - i'm assuming this is actually needed for exception handling unwinds?

It looks like that patch ports arm64's special sigreturn handling to riscv. Other architectures (e.g. x86 and x86_64) are able to express sigreturn handling using DWARF .eh_frame instead, so they don't need the special handling.

@rprichard - i'm assuming this is actually needed for exception handling unwinds?

I don't think C++ exceptions can be thrown beyond a signal handler frame?

hmm... @cferris1000 since i thought we had unit tests for sigreturn unwinding? or are they in debuggered (whose tests i haven't yet run) rather than bionic (whose tests i have already run)?

The bionic unit tests do unwinds through signal handlers. Specifically, stack_unwinding.unwind_through_signal_frame. That is using the llvm unwinder, and I think should be using the same code paths in libunwind/src. However, that test is really basic, but I haven't seen a case where it passes and the unwinding is wrong.

We have supported in clang-12, which used in Android-12.
https://github.com/riscv-android-src/toolchain-llvm-project/commit/839f6eecc8c9272b8095cb38555ee7954c5bb4f3

yeah, i linked to that in the first comment ... but it looks like it wasn't upstreamed? the current copy of that file  (https://github.com/llvm/llvm-project/blob/main/libunwind/src/UnwindCursor.hpp) doesn't seem to  contain your change?

@MaoHan001 --- did this get upstreamed yet?

doesn't look like it has been upstreamed.


ak.is_none returns NumpyArray as-is

Reproducer:
>>> import awkward as ak
>>> ak.is_none(np.arange(12))
<Array [0, 1, 2, 3, 4, 5, ... 7, 8, 9, 10, 11] type='12 * int64'>

I assume that the cause is this final else clause, which is visited as NumpyArray is not considered by the zeros case. I would assume the solution is just to add another type to the isinstance call?
Version Info
>>> import awkward as ak
>>> ak.__version__
ak.__version__

Yes, this was a bug and #864 fixes it; thank you!


Composition of transforms

As a GAMPMatlab user I made extensive use of the LinTransCompose() function (I think that was the name).  This was part of the modular "Lego-like" design that I really liked about it. I'd like to work on implementing LinTransCompose() for vampyre.
The problem is that as far as I know there is in general no way to calculate the SVD of the product of two matrices short of explicitly calculating their product and then calculating the SVD of that. This would be insane in terms of memory alone for many vampyre use cases. I propose to only provide an SVD for the special case of composition of unitary matrices and set svd_avail=False for others.
The problem with this is that estim.LinEst currently requires svd_avail=True. I'm willing to take that on as well but I may need some help with it; I was mainly an AMP user and only took a cursory look under the hood.
What do you think? Is this a good direction to work?

Alternatively, do we prefer that users add an intermediate node to the graph, sitting in between the two matrices?


Tensorflow Keras not adding trainable variable to Model in TF 1.13 (works in TF 1.12)

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): YES
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.13
Python version: 3.6 (also tried 3.7)
Bazel version (if compiling from source): N/A
GCC/Compiler version (if compiling from source): N/A
CUDA/cuDNN version: N/A
GPU model and memory: GeForce 840M 8gigs ram

You can collect some of this information using our environment capture script
You can also obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the current behavior
I am trying to add a trainable variable y to my model. The following code adds a trainable variable y to my model in TF 1.12. It does not work in TF 1.13
y = K.variable([0.0], dtype=tf.float32, name='y')
add_y = Lambda(lambda x: tf.math.add(x,y))
add_y.trainable_weights.append(y)

Describe the expected behavior
Model should be updated with the variable y as a trainable weight
Code to reproduce the issue
import tensorflow as tf
import tensorflow.keras.backend as K
from tensorflow.keras import Model
from tensorflow.keras.layers import Input, Lambda
inputs = Input(shape=(1,))
y = K.variable([0.0], dtype=tf.float32, name='x')
add_y = Lambda(lambda x: tf.math.add(x,y))
add_y.trainable_weights.append(y)
outputs = add_y(inputs)
model = Model(inputs=inputs, outputs=outputs)
model.summary()

Model.summary() shows no trainable variables
Other info / logs
NONE

Hi @ablanch5, that's bc in TF1.13 .trainable_weights is a computed property.
I have a few ideas of what you could do here. The easiest is that, as of the latest nightly (but not as of TF1.13), TF Keras Lambda Layers can actually include variables, so you could do:
add_y = Lambda(lambda x: tf.math.add(x,K.variable([0.0], dtype=tf.float32, name='x')))

The most robust way to do this though (and the way that would work in all versions of Keras) is to create your own subclass Layer:
class Bias(tf.keras.layers.layer):
  def build(self, input_shape):
    self.bias = self.add_weight(shape=(), initializer='zeros', dtype=tf.float32, name='x')

  def call(self, inputs):
    return inputs + self.bias

Thanks so much for your answer
On Mon, Mar 18, 2019, 2:04 PM omalleyt12<EMAIL_ADDRESS>wrote:

Closed #26792 https://github.com/tensorflow/tensorflow/issues/26792.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/26792#event-2211263648,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQe-tNpTQ95dht5OoBRKifIFIg-zElaVks5vX9U-gaJpZM4b38zy
.

Does this work in tf 2.0? Does not seem so.

@cottrell i.e. you want a Variable that is unconnected to the inputs of your Model? I would suggest using the subclassed API in that case. Note that in the case above, the inputs of your Model are completely ignored


Bistro source code didn't match with folly library.

-- Configuring done
-- Generating done
-- Build files have been written to:  workspacecpp/bistro/bistro/build/Debug
[  1%] Built target lib_bistro_sqlite
[ 17%] Built target lib_bistro_if
[ 18%] Building CXX object utils/CMakeFiles/lib_bistro_utils.dir/ProcessRunner.cpp.o
 workspacecpp/bistro/bistro/utils/ProcessRunner.cpp: In member function ‘std::unique_ptr<folly::Subprocess> facebook::bistro::ProcessRunner::makeSubprocess(facebook::bistro::ProcessRunner::WriteCallback, const boost::filesystem::path&, const std::vector<std::basic_string<char> >&, const std::vector<std::basic_string<char> >&)’:
 workspacecpp/bistro/bistro/utils/ProcessRunner.cpp:138:5: error: ‘std::string’ has no member named ‘toStdString’
   ).toStdString());
     ^
 workspacecpp/bistro/bistro/utils/ProcessRunner.cpp: In member function ‘void facebook::bistro::ProcessRunner::exceptionCallback(folly::StringPiece, folly::StringPiece, const std::exception&)’:
 workspacecpp/bistro/bistro/utils/ProcessRunner.cpp:183:5: error: ‘std::string’ has no member named ‘toStdString’
   ).toStdString());
     ^
utils/CMakeFiles/lib_bistro_utils.dir/build.make:123: recipe for target 'utils/CMakeFiles/lib_bistro_utils.dir/ProcessRunner.cpp.o' failed
make[2]: *** [utils/CMakeFiles/lib_bistro_utils.dir/ProcessRunner.cpp.o] Error 1
CMakeFiles/Makefile2:2907: recipe for target 'utils/CMakeFiles/lib_bistro_utils.dir/all' failed
make[1]: *** [utils/CMakeFiles/lib_bistro_utils.dir/all] Error 2
Makefile:86: recipe for target 'all' failed
make: *** [all] Error 2

I'm recheck with folly source code in FBString.h is return std::string.
1113 #ifndef _LIBSTDCXX_FBSTRING
1114   // Compatibility with std::string
1115   basic_fbstring & operator=(const std::string & rhs) {
1116     return assign(rhs.data(), rhs.size());
1117   }
1118
1119   // Compatibility with std::string
1120   std::string toStdString() const {
1121     return std::string(data(), size());
1122   }
1123 #else
1124   // A lot of code in fbcode still uses this method, so keep it here for now.
1125   const basic_fbstring& toStdString() const {
1126     return *this;
1127   }
1128 #endif

It should compile bistro source code completed, but after run script build.sh Debug is show an error above.

I will be updating the whole codebase before long, but for the time being, you need a much older version of fbthrift & folly to get this to build. Follow this script:
https://github.com/facebook/bistro/blob/master/bistro/build/deps_ubuntu_12.04.sh
You'll want to check out fbthrift v0.28.0 and folly v0.47.0.
Sorry about the code being out of date, it's being actively worked on, I just haven't finished putting together the OSS release due to personal circumstances last year.


Should installing 6.0 snapshot be supported?

I tried to install a 6.0 snapshot with swiftly, but it seems the installation does not work afterwards. Maybe it is a problem with the snapshot …
tobias@ubuntu:~$ swiftly use 6.0-snapshot
Set the active toolchain to 6.0-snapshot-2024-06-13 (was Swift 5.10.1)
tobias@ubuntu:~$ cd test/
tobias@ubuntu:~/test$ swift build
error: 'test': Invalid manifest (compiled with: ["/home/tobias/.local/bin/swiftc", "-vfsoverlay", "/tmp/TemporaryDirectory.dZtFHJ/vfs.yaml", "-L", "/home/tobias
/.local/bin", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/home/tobias/.local/bin", "-swift-version", "6", "-I", "/home/tobias/.local/bin", "-pac
kage-description-version", "6.0.0", "/home/tobias/test/Package.swift", "-o", "/tmp/TemporaryDirectory.7QJOfi/test-manifest"])
/home/tobias/test/Package.swift:4:8: error: no such module 'PackageDescription'
 2 | // The swift-tools-version declares the minimum version of Swift required to build this package.
 3 |
 4 | import PackageDescription
   |        `- error: no such module 'PackageDescription'
 5 |
 6 | let package = Package(
error: 'test': Invalid manifest (compiled with: ["/home/tobias/.local/bin/swiftc", "-vfsoverlay", "/tmp/TemporaryDirectory.QvI34V/vfs.yaml", "-L", "/home/tobias
/.local/bin", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/home/tobias/.local/bin", "-swift-version", "6", "-I", "/home/tobias/.local/bin", "-pac
kage-description-version", "6.0.0", "/home/tobias/test/Package.swift", "-o", "/tmp/TemporaryDirectory.VcmOIN/test-manifest"])
/home/tobias/test/Package.swift:4:8: error: no such module 'PackageDescription'
 2 | // The swift-tools-version declares the minimum version of Swift required to build this package.
 3 |
 4 | import PackageDescription
   |        `- error: no such module 'PackageDescription'
 5 |
 6 | let package = Package(
tobias@ubuntu:~/test$ swiftly list
Installed release toolchains
----------------------------
Swift 5.10.1

Installed snapshot toolchains
-----------------------------
6.0-snapshot-2024-06-13 (in use)
tobias@ubuntu:~/test$

Yes it should work. There was an issue with the new swift-driver not working when referenced through a symbolic link. This was fixed. It appears it has broken again.

Here with the same issue, still. On Ubuntu 22.04 LTS, latest swiftly. Really confusing issue!

I believe this issue can be closed now.

I have verified this now works with the latest 6.0 snapshot


Update annotationSetIds.

@calbach please take a look and verify that the new annotationSetIds are the correct defaults
The AnnotateVariants pipeline currently yields errors for the prior default annotationSetIds:
"message" : "Annotation set \"CILSqfjtlY6tHxCu1Keyxtu472M\" not found"
"message" : "Annotation set \"CIjfoPXj9LqPlAEQr_GXvYPKvtPqAQ\" not found"

Coverage remained the same at 26.11% when pulling 127341af0f14c1aad743e024eeceb8a0ef2f5d7c on deflaux:master into 3aa3cb0b81263391a79cdb1f1e8e3d00597389a1 on googlegenomics:master.

Thanks Nicole.


Revert "refactor: replace deprecated grpc.WithInsecure"

This reverts commit 636a99aad3ba51dd44693a72da5b2d2353734399 for the reason same as https://github.com/longhorn/longhorn-engine/pull/973#issuecomment-1864078004.
https://github.com/longhorn/longhorn/issues/7364

Wrong branch, will recreate.


Adding an Auth Perm for getting Pipeline Logs

@actgardner I decided to go with the less invasive approach of checking auth within the GetLogs RPC instead of splitting it up into two RPCs. I don't love it but I think the less invasive option makes sense in this case. Let me know if you think differently


Execution always uses -L; can't ever get -r to work

Script processing adds the -L, which was meant to be only when no other topaz arguments were present, but is always added.
This is nice, actually, since you never have to explicitly use -L.  -L is a good default for superdoits.
However, it is not possible to get a rpc login, since the -L makes it always linked, and that's not so good.
On the server, using both -r and -L in any order always results in a linked session, this is a server bug.  If this was fixed we would all be happy.

Filed server bug 49922

alright, I've looked at the current productTree/superdoit_stone and productTree/superdoit_solo scripts and for superdoit_solo we have an unconditional  leading -l and for superdoit_stone we have an unconditional leading -L (even though the code makes it look like it might not be conditional) ... when 49922 is fixed, I probably won't need to make changes.
However, I should make the -L unconditional for productTree/superdoit_stone and bin/superdoit_stone and get rid of the hokey defaultTopazArgs logic ...

With the fix for the server bug (correct in latest), the .stone scripts work correctly with or without an -- - r and with the netldi not running.
However, the solo scripts fail with:
/simple.solo -- -r
invalid topaz command line arguments: none of -C -T -e -z are allowed with -r

since -C is used to pass in the solo extent...
Does -r make a whole lot of sense for solo?  Could be some fuss to make this work.  If not expected to work however we should document it...

Now that I think about it, -r is not intended to work ... running a remote gem without a stone, is just not practical ... so documentation is the ticket ...


collection create bug

Metamask error : execution reverted: Bad Template
when trying to create collection on branch integ

moreover on fresh loading, current network is no more selected


using node-libcurl with curl impersonate on M1

Hi,
Someone has an example to install node-libcurl with curl impersonate on macbook M1 ?
Thanks by advance

I was able to find this but was unable to get it working: https://github.com/SwapnilSoni1999/node-libcurl-impersonate

Hello ~
Has the problem been resolved?


Restoring a container doesn't initialize it if it hasn't already been initialized

When a container gets started, it creates a parent init process, which eventually calls StartInitialization and sets up a bunch of things inside the container. But restoring into a new container created but never previously started doesn't seem to ever go through this process, which means that in some circumstances the restore will fail (specifically, if it's mounting a directory, but possibly others too).
This used to work at some point, but I haven't yet tracked down exactly when it stopped. @avagin do you have any ideas here? Could we check the container's state, and if it isn't already checkpointed, perhaps run the CriuSwk process through a parent process that first calls the initialization code?

Adding this in Restore() right before calling criuSwrk seems to resolve the issue:
+
+       status, err := c.currentStatus()
+       if err != nil {
+               return err
+       }
+
+       if status != Checkpointed {
+               parent, err := c.newParentProcess(process, true)
+               if err != nil {
+                       return newSystemError(err)
+               }
+               if err := parent.start(); err != nil {
+                       // terminate the process to ensure that it properly is reaped.
+                       if err := parent.terminate(); err != nil {
+                               logrus.Warn(err)
+                       }
+                       return newSystemError(err)
+               }
+               process.ops = parent
+       }
+

Looking closer, I actually just end with two processes doing this.

The file tree should not be changed between dump and restore. When you create a new container, directories for bind-mounts may be absent and they will be created on the first start. But "criu restore" expects that they are there and fails if they are not.
https://github.com/docker/libcontainer/blob/master/rootfs_linux.go#L151

Sure, but there's no reason they can't be bind-mounted before restoring. I make a docker commit after checkpointing, and create a new container with the new fs image, so the fs is already the same -- and since my bind mount is read only, that is also the same. But because we aren't initing the bind mounts, it fails.

@boucher I've compiled docker from your repo (cr-combined), but I can't reproduce this issue. Could you look at my sequence of actions and find what you do differently?
https://asciinema.org/a/6cfv5n4a57s74igagmdrs0x6s


delete single ad not working

Hello Im getting the error :
File "kijiji_repost_headless/main.py", line 193, in
main()
File "kijiji_repost_headless/main.py", line 50, in main
args.function(args)
File "kijiji_repost_headless/main.py", line 117, in delete_ad
[data, _] = get_post_details(args.ad_file)
File "kijiji_repost_headless/main.py", line 59, in get_post_details
with open(ad_file, 'r') as f:
FileNotFoundError: [Errno 2] No such file or directory: '1568261539'
The ID number matches the 'show' command , and the ID in the URL.
Any tips appreciated!
Randall

having the same issue


tab completions

I've been using it for almost a week and seems great! I only miss tab completions, that would be awesome :slight_smile: thanks Brian!

Hm, after thinking about this further, tab completions are going to be tricky. rustup does not require root to install but completions are usually installed to /etc. I really don't want to require admin just for that. I wonder if we might further frob the shell startup files (like we already to to modify PATH) to load completions.
Source.

I wonder if we might further frob the shell startup files (like we already to to modify PATH) to load completions.

FWIW, in my case I use zsh and I enable the cargo auto completions (that rustup installs) without touching the /etc directory by modifying the fpath variable in my zshrc as shown here. I also use the oh-my-zsh framework and I've noticed that I need to modify the fpath variable before sourcing the oh-my-zsh framework.
Disclaimer: I don't really grok zsh internals and perhaps there is a way to enable cargo autocompletions after the oh-my-zsh framework has been loaded.
P.S. I don't really like that CLI tools modify my zshrc, I usually undo/modify what they do :smile:. I would be happy if rustup just installs a _rustup completion file somewhere in the .multirust folder like it does with _cargo.

@brson  @japaric
I've just added the ability to generate bash completions for a cli with clap at compile time. Here's a gist of the generated completion script for rustup
And a demo:

I have a branch on my fork where I generated the completions, although before I'd put in a PR there are few opinionated portions that I'd rather a project maintainer look at prior

having to move the rustup_mode::cli function into a separate file in order to include via the build.rs.
there's a strange issue where I couldn't use help::*; from rustup_app.rs so I had to include! it.
finally, the output of the completion script goes to  OUT_DIR

Granted this is only a Bash completion script, but it's at least a step in a direction (if it's the right direction is TBD). I personally use ZSH, so that's next on my list.

@kbknapp Wow, that's awesome!

go go go

@kbknapp Sweet! That's really clever.
I'm fine doing the conversion, but I'd still like to wait until we understand how to install them before pulling trigger.

@kbknapp Any progress now? It's a pain to me when auto-completion is unable to use.

@knight42 I haven't added ZSH support yet. Once I do I'll post back here.

@kbknapp Great! It's better to generate the completion script automatically. I am looking forward to it!

@knight42
I've just added ZSH support to clap (finally! :tada:), and put in a PR to rustup to add it. The PR also includes Bash, and Fish support as well.
Here's a gif of the ZSH support though:

@kbknapp Awesome, love it!

Thanks for the autocompletion feature @kbknapp I really like it!
Would it be possible to extend the tab completion support to include things rustup can derive? Like when you type rustup override add<TAB><TAB> it should give you a list of toolchains.
Its obviously more complicated, but should be doable, no?
flatpak manages to do this btw, you can press flatpak run org.app.<TAB> and it will autocomplete the app name.

@est31 not yet, but that is the exact topic of kbknapp/clap-rs#568

I should add you can do this manually, but it's not built in to clap yet :will:

I think this can be considered complete?


[Trinity Continuum 2e by Mercury Cluster]

Changes / Comments
Character Sheet Submission
Storypath -> Trinity Continuum 2e by Mercury Cluster
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[x] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[x] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

Mr Bradley
Thank you so much Mr Bradley for the Merge. But the character sheet
developed by me is part of the Storypath system. So it should be a
subsection of Storypath, in the sheets list. It is currently listed as a
subsection of Trinity, while it should be a subsection of Storypath as is,
Scion Second Edition and Storypath by Onyx Path Publishing.
att.
Jonnes Derik
Em ter., 1 de mar. de 2022 às 14:20, Nic Bradley @.***>
escreveu:

Merged #10219
https://github.com/Roll20/roll20-character-sheets/pull/10219 into
master.
—
Reply to this email directly, view it on GitHub
https://github.com/Roll20/roll20-character-sheets/pull/10219#event-6163659977,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJTOIYVYILCNXUWZ3EI7RQTU5ZGUPANCNFSM5PH4PJIQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***
com>