Does stetho support okhttp with websocket?

Cause okhttp will support websocket fully in the future, ex. this
https://github.com/square/okhttp/blob/master/samples/guide/src/main/java/com/squareup/okhttp/recipes/WebSocketEcho.java
If I add stetho to inspect this, app will crash.
Chrome dev tool could monitor websocket activity, does stetho support it as well?
Thanks.

Can you post the stack trace?  Supporting this really depends on how OkHttp's interceptors system works with respect to WebSocket traffic.  We also don't have API support in stetho's NetworkEventReporter however that can be easily added.
Note however that the DevTools' WebSocket inspection is fairly limited.  In particular, binary frames are not visualized so that it can be difficult in practice to use this feature with efficiently designed websocket protocols.


Bot confusing town portal with teleport

Details
It was running perfectly and the problem started mid runs (I didn't touch anything)
Here is video of the problem - https://streamable.com/e/xx6z94?
Version
v0.5.1
Logs
v0.5.1

hey your comment is 2 weeks old and idk if you fixed it, but it has something to do with the "Back to Town Settings:" uncheck "Equipment Broken" then it should work fine. :D


[Feature Request] Multiple output configurations?

First of all, thank you for this amazing tool! It really makes my life a lot easier (or at least faster) when working in Sway!
I am regularly working with multiple different setups, depending on where I am:

Two external monitors
Single portable monitor
Only integrated laptop screen

Unfortunately, I always have to set up my monitor layout from start after I've switched locations, which is kind of annoying.
Is there any way to remember various configurations and apply them automatically based on the detected external monitors (or lack thereof)? As far as I can remember, KDE Plasma did this automatically, so there should be way to do this in other environments as well.
One solution I can think of immediately would be a Rofi-based switcher that loads the respective output configuration file in Sway. However, there might be a better and more automated solution?

Hi,
It would be damned difficult to add support for multiple configurations to this certain tool. What you're looking for is kanshi.


Cannot find name 'IconEp**'.

按需引入这种错误如何解决

Please look for the docs of plugin you're using, like unplugin-icons, unplugin-auto-import, UnoCSS


[doc > new-plugin-checklist.md] new plugin folder is out of date.

Provide a description of requested docs changes
Description

Currently, the new plugin folder is modules\launcher\Plugins
I notice the new plugin folder changes in pr: #27451, commit: Refactor Power Launcher && RunPlugins name to hold PTRun plugins, PowerToys: 0.72.0

Solution
Change it to RunPlugins

@F-park
The folder path depends on the fact if it is the code path or the install path. The install path has changed but the source code path is still modules\launcher\Plugins.

I close this as for the dev docs the path is correct.


NAD: use apply time dependency to avoid need for daemonset doing pod restarts

If we use config injection in the primary package to set up the NAD, then the NAD and the consumer of it will be in the same package, and we can use the depends-on annotation to ensure apply time ordering.

This is now tracked in https://github.com/nephio-project/nephio-pocs/issues/23 so I am closing this issue (clearing everything out since the summit is over).


🐞 Bug - ALLOW_SIGNUPS: 'false' not working under docker

What goes wrong?
When deploying under docker (both locally & on Azure) while setting ALLOW_SIGNUPS: 'false', the sign-up link doesn't disappear.

How to replicate?
Deploy to localhost through CLI:
docker context use default
docker compose --file docker/docker-compose.yml up

Deploy to Azure through CLI:
docker login azure # => Web browser login
docker context create flagsmith
docker context use flagsmith
docker compose --file docker/docker-compose.yml up

This docker-compose.yml was used.
(I appended .log to the file to be able to upload to GitHub + restored the password to password)

📎 Link to start of the Discord Discussion that lead to opening this issue & below issue.
📎 Link to Azure specific issue: https://github.com/Flagsmith/flagsmith/issues/517

@dabeeeenster I believe this is just frontend https://github.com/Flagsmith/flagsmith/pull/545

@dabeeeenster I believe this is just frontend #545 - has been merged to main.

I honestly doubt that.
Today I've been re-deploying to Azure docker containers using TerraForm,
while deploying the container on the latest flagsmith image.
I was trying out multiple environment settings configurations, and learned the following:

Setting ALLOW_SIGNUPS = "false" or ALLOW_SIGNUPS = 0 did not remove the Not got an account? Sign Up text
Setting PREVENT_SIGNUP = "true" or PREVENT_SIGNUP = 1 (Disables the API endpoint for signups) did:

Remove the Not got an account? Sign Up text
Results into inability to use invite links.
When creating an invite link, logging out and navigating to the invite link,
I'm prompted with a Login to accept your invite page where you can't register:

Following TerraForm file was used for this:
aci-flagsmith-main.tf.log
(I appended .log to the file format to be able to upload it here + replaced the postgres password & hostname with <password> & <host-id>)

Hi @Rikj000 - sorry - I'm a bit lost now - is there an explanation of what the issue is you are facing?

Hi @Rikj000 - sorry - I'm a bit lost now - is there an explanation of what the issue is you are facing?

ALLOW_SIGNUPS did nothing to the Not got an account? Sign Up text when toggled on/off
(While I think the expected behavior here would be that it would display the text if "true" & hide the text if "false")
PREVENT_SIGNUP = "true" did hide the `Not got an account? Sign Up`` text (This is an API setting so I'm unsure why it's affecting the FrontEnd?), but this also breaks registration with an invite link!

Which renders it impossible for me to configure our Flagsmith instance with:

A closed off sign-up system
Ability to allow new members to join through invite links

Hope that explains it a little better 🙂

So, from what I can tell here, the issue relates to the fact that, when we added the ability to run the application in a single container, the environment variables got a little muddled. I believe that the ALLOW_SIGNUPS variable is completely redundant in the single container architecture (although it is still used when running the API and frontend application separately).
Since, @Rikj000, you're using the single container architecture, we should therefore focus only on the PREVENT_SIGNUP variable and ignore the ALLOW_SIGNUPS var as you have already deduced.
To answer the question as to why an API setting is affecting the FE; this is because, although it is technically an API setting, it is actually accessed by the FE when it makes a call to /config/project-overrides. The API dynamically generates a JS file that it serves at this location which is used by the FE. For reference, you can see the API code for this here and you can see the FE include this script here. You can also see this file being generated yourself by browsing to https://your.domain.com/config/project-overrides.
As such, unless I am missing something, what this seems to boil down to is a FE bug that prevents users invited via a link from signing up when PREVENT_SIGNUP env var is set to a truthy value (or more specifically from a FE point of view, when the projectOverrides.preventSignup=true).
Thanks for the patience and detailed responses here @Rikj000. I'm going to get this one sorted for you and we'll let you know when a new version of the docker container is released which fixes this issue.


featureAdd the filtering information of the Bloom filter in profile.

Proposed changes
The format will continue to be modified in the future.

=================================================

=================================================

Problem summary
Describe your changes.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run p0

run buildall

do not add useless blackspace

run buildall

run p0

run p1

run buildall

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.54 seconds
stream load tsv:          421 seconds loaded<PHONE_NUMBER>9 Bytes, about 169 MB/s
stream load json:         22 seconds loaded<PHONE_NUMBER> Bytes, about 102 MB/s
stream load orc:          59 seconds loaded<PHONE_NUMBER> Bytes, about 17 MB/s
stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select:          78.9 seconds inserted 10000000 Rows, about 126K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230522151817_clickbench_pr_148519.html

run p0

run p0

run buildall

run p0

run p1


/voice Loosing Data On Crash

Issue
I sometimes make a lot of effort giving longer step by step description to aider what to do (using it as helper with RSI to do more "typing by voice"), having said that I encountered multiple times crash, when aider crashed, and my few minutes of talking... It would be nice it temporarily recording would be stored somewhere from where I could recover it (/tmp/aider.$PID/ ?) , and manually run some STT script. (Also if openai STT is failing maybe good to have possibility for alternative of fallback ? like assemblyai?)

Initializing sound device...
Recording, press ENTER when done... 321.4sec ░█████████
Traceback (most recent call last):
  File "/home/username/.local/bin/aider", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/aider/main.py", line 640, in main
    coder.run()
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/aider/coders/base_coder.py", line 770, in run
    self.run_one(user_message, preproc)
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/aider/coders/base_coder.py", line 805, in run_one
    message = self.preproc_user_input(user_message)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/aider/coders/base_coder.py", line 794, in preproc_user_input
    return self.commands.run(inp)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/aider/commands.py", line 204, in run
    return self.do_run(matching_commands[0][1:], rest_inp)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/aider/commands.py", line 179, in do_run
    return cmd_method(args)
           ^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/aider/commands.py", line 958, in cmd_voice
    text = self.voice.record_and_transcribe(history, language=self.voice_language)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/aider/voice.py", line 72, in record_and_transcribe
    return self.raw_record_and_transcribe(history, language)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/aider/voice.py", line 100, in raw_record_and_transcribe
    transcript = litellm.transcription(
                 ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/litellm/utils.py", line 1086, in wrapper
    raise e
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/litellm/utils.py", line 966, in wrapper
    result = original_function(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/litellm/main.py", line 4577, in transcription
    response = openai_chat_completions.audio_transcriptions(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/litellm/llms/openai.py", line 1667, in audio_transcriptions
    _, response = self.make_sync_openai_audio_transcriptions_request(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/litellm/llms/openai.py", line 1630, in make_sync_openai_audio_transcriptions_request
    raise e
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/litellm/llms/openai.py", line 1627, in make_sync_openai_audio_transcriptions_request
    response = openai_client.audio.transcriptions.create(**data, timeout=timeout)  # type: ignore
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/openai/resources/audio/transcriptions.py", line 114, in create
    return self._post(
           ^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/openai/_base_client.py", line 1260, in post
    return cast(ResponseT, self.request(cast_to, opts, stream=stream, stream_cls=stream_cls))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/openai/_base_client.py", line 937, in request
    return self._request(
           ^^^^^^^^^^^^^^
  File "/home/username/.local/pipx/venvs/aider-chat/lib/python3.12/site-packages/openai/_base_client.py", line 1041, in _request
    raise self._make_status_error_from_response(err.response) from None
openai.APIStatusError: Error code: 413 - {'error': {'message': 'Maximum content size limit (26214400) exceeded (26282390 bytes read)', 'type': 'server_error', 'param': None, 'code': None}}

Version and model info
Version: aider 0.51.1  (installed on archlinux via pipx install/upgrade )
Model: Happening for GPT-4 and GPT-4o (however it's audio, so openai whisper I guess)

Thanks for trying aider and filing this issue.
It looks like your voice recording file is too large for OpenAI to process.
I think you may want to use shorter prompts. Or use an external voice-to-text tool to transcript a longer prompt. Then you can copy & paste (/clipboard) it into the aider chat.

Thank you for your quick response and for providing suggestions on handling this issue.
Importance of Preserving Voice Input Data
Thank you for your quick response and suggestions. I appreciate the advice to use shorter prompts or an external voice-to-text tool. However, there’s a key issue that this approach doesn't address:

Unpredictability of Recording Length:
When I start speaking to aider, I don’t always know how long my recording will be. If the recording unexpectedly becomes too long and causes a crash, I end up losing all the data without any warning. This results in losing not just the transcription but also my train of thought, making it difficult or even impossible to recreate what I was saying.

given unpredictability of length of message I would need to copy and paste most of the time effectively making /voice feature of very little use...

Need for a Solution to Prevent Data Loss:
For me, it's important to have a mechanism in place that either prevents data loss or provides a workaround, such as temporarily storing the recording. Without this, the risk of losing valuable input is significant, especially since some thoughts may not be easily recoverable.

Additional Suggestions for Error Handling:

It would be helpful if aider could handle this error more gracefully by:

Displaying an error message when the voice recording is too large.
Providing a path to a temporary file where the recording is stored. This would allow users to manually transcribe the audio using external tools if needed.

Use of External Tools:

Yes, I do have an external tool for transcribing longer recordings. You can find it here:  Tool](https://github.com/CLIAI/handy_scripts/blob/main/stt_openai_OR_local_whisper_cli.py (inspired by aider btw. , thank you!), somehow with this I haven't yet run into such issue.

Issue with Losing Transcriptions:

When using aider, I’m often not sure how long my speech will be. If aider crashes, I risk losing all my thoughts and the time invested, which is frustrating.

Proposed Solution: Storing the recording temporarily would allow me to retrieve it in case of a crash. I could then use my external tool to transcribe and resume my work with aider.
Ideal Implementation: Gracefully handling such cases by providing the user with the temporary file path, somthey can transcribe externally if needed.

Additional Suggestions for Error Handling:

It would be helpful if aider could handle this error more gracefully by:

Displaying an error message when the voice recording is too large.
Providing a path to a temporary file where the recording is stored. This would allow users to manually transcribe the audio using external tools if needed.

Use of External Tools:

Yes, I do have an external tool for transcribing longer recordings. You can find it here: STT Tool (inspired by aider).

Issue with Losing Transcriptions:

When using aider, I’m often not sure how long my speech will be. If aider crashes, I risk losing all my thoughts and the time invested, which is frustrating.

Proposed Solution: Storing the recording temporarily in oredictable location, e.g. in /tmp/aider.$PID/ . would allow me to retrieve it in case of a crash (assuming temporary recording would be not deleted, unless successfully processed). I could then use my external tool to transcribe and resume my work with aider.
Ideal Implementation: Gracefully handling such cases by providing the user with the temporary file path and the option to transcribe externally if needed.

This would significantly improve the user experience by ensuring that data isn’t lost in the event of a crash.
Thanks again for your continued development and support for aider 🙏.

Aider will not show you the filename of the wav file with the recording in it in case of an error. You can copy that file and transcribe it some other way if you like.
> /voice

Initializing sound device...
Recording, press ENTER when done... 1.8sec ░░████████
Unable to transcribe /var/folders/49/kxrdwwbx0h9bchx99397477c0000gn/T/tmpqn00i8oi.wav: <error message>

The change is available in the main branch. You can get it by installing the latest version from github:
aider --install-main-branch

# or...

python -m pip install --upgrade git+https://github.com/paul-gauthier/aider.git

If you have a chance to try it, let me know if it works better for you.

Aider will not show

"Aider will now show"
Thank you very much!

Ah yes, it will NOW show the filename. Sorry about that.

Thank you! You are the best!

I'm going to close this issue for now, but feel free to add a comment here and I will re-open or file a new issue any time.


Italics and Hide Font Variants

Feature Description
During Grooming on March 18, there was discussion around having a separate issue to handle italics and hiding font variants.

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Remove Italic versions from the variants dropdown
Automatically use "italic" variants for italicized markup

QA Instructions

I believe the issue here is not removing font variants field at all. But instead we can remove "Italic" versions from the dropdown and automatically using "Italic" variants for italized markup.

Yep, as Dima said the issue was not about removing the font variants field.
Note that "Italic" is already not displayed among font variants.
An additional complication discussed for using italic variants was selecting just part of the text and marking it italic.
Related #413

Thank you. AC updated

@miina @dvoytenko As we can see from the design, we don't have variants dropdown anymore. There is only font family and font weight dropdown select. Font variants like the Bold, Italic, Underline will be handled from Toggle selections.

@ndev1991 That's correct, the discussion was exactly about using the font variants in case of the toggle buttons -- to use the selected font variants (if exists) instead of the browser default italic and bold.

@pbakaus @swissspidy @jauyong This issue for version 1.0, do we supposed to handle bold and italic for entire text only? (not partial selection of text)

@spacedmonkey @miina /web-stories/v1/fonts I think this api is customized one. Where can I find this api document and function?

@ndev1991 The code for the api can be found here.
For more details on the API try /web-stories/v1/, where you will be able to see all params.
Adding italic in, feels like it will need PHP work. So will have be me, Minna or Pascal that looks in this ticket, I think.

@ndev1991 The code for the api can be found here.
For more details on the API try /web-stories/v1/, where you will be able to see all params.
Adding italic in, feels like it will need PHP work. So will have be me, Minna or Pascal that looks in this ticket, I think.

I see. @spacedmonkey @jauyong Can we have another ticket for api update here to unblock this issue?

@ndev1991 It would be useful if you should define exactly what you need from WP and the REST API, before we create that ticket.

@ndev1991 It would be useful if you should define exactly what you need from WP and the REST API, before we create that ticket.

@spacedmonkey Here is my understanding for this ticket. We are having font weights for each font when we get them through api. And that will be used for weights dropdown on font style panel.
Currently there are multiple toggle options for italic, underline and bold for text. For bold option I think we need to collaborate with weights dropdown so when selected as Bold from dropdown it should be selected on toggle and also same goes on toggle to dropdown. And for italic and underline we are using default browser function here. I think underline makes sense to use default browser section  based on this ticket. But the italic should be handled based on that font option. And we don't have that kind of records on fonts from the api. So I think we will need to get variants option from web-stories/v1/fonts api to get variants for that font. I'm not sure what options can it be but italic should be required.
Would you confirm this is correct direction? @pbakaus @swissspidy @miina

@ndev1991 It would be useful if you should define exactly what you need from WP and the REST API, before we create that ticket.

@spacedmonkey Here is my understanding for this ticket. We are having font weights for each font when we get them through api. And that will be used for weights dropdown on font style panel.
Currently there are multiple toggle options for italic, underline and bold for text. For bold option I think we need to collaborate with weights dropdown so when selected as Bold from dropdown it should be selected on toggle and also same goes on toggle to dropdown. And for italic and underline we are using default browser function here. I think underline makes sense to use default browser section based on this ticket. But the italic should be handled based on that font option. And we don't have that kind of records on fonts from the api. So I think we will need to get variants option from web-stories/v1/fonts api to get variants for that font. I'm not sure what options can it be but italic should be required.
Would you confirm this is correct direction? @pbakaus @swissspidy @miina

Nope:

With italic, we should only default to the browser italic when there's no italic front variant for the current font (see Roboto as example, has italic variants for all). To be clear, we hide the italic variants in the dropdown, and if the user clicks the "i" button, we switch to that variant under the hood, if it exists, and if not we use the browser native.
Underline variants don't usually exist, so should always use the browser default here.
Bold variants do exist, but apps like Google Slides always show them in the dropdown. But you're suggestion is good, which means that if you click "b", and there's a "Bold" variant (not Extra Bold, not Medium, just Bold), then we switch to that automatically in the dropdown. So to be clear, that means that if I select "Bold" in the dropdown, "b" is automatically selected as well (so works in both directions).
An interesting edge case is "Extra Bold". We could either a), treat it like an unknown variant, and not select the "b" when the user selects the font in the dropdown, or b) treat it is a "Bold" variant, and select the "b" (and when you then click "b" again, it switches back to normal weight. I'm leaning towards b).

Let me know if that makes sense, happy to answer additional questions.

@ndev1991 It would be useful if you should define exactly what you need from WP and the REST API, before we create that ticket.

@spacedmonkey Here is my understanding for this ticket. We are having font weights for each font when we get them through api. And that will be used for weights dropdown on font style panel.
Currently there are multiple toggle options for italic, underline and bold for text. For bold option I think we need to collaborate with weights dropdown so when selected as Bold from dropdown it should be selected on toggle and also same goes on toggle to dropdown. And for italic and underline we are using default browser function here. I think underline makes sense to use default browser section based on this ticket. But the italic should be handled based on that font option. And we don't have that kind of records on fonts from the api. So I think we will need to get variants option from web-stories/v1/fonts api to get variants for that font. I'm not sure what options can it be but italic should be required.
Would you confirm this is correct direction? @pbakaus @swissspidy @miina

Nope:

With italic, we should only default to the browser italic when there's no italic front variant for the current font (see Roboto as example, has italic variants for all). To be clear, we hide the italic variants in the dropdown, and if the user clicks the "i" button, we switch to that variant under the hood, if it exists, and if not we use the browser native.
Underline variants don't usually exist, so should always use the browser default here.
Bold variants do exist, but apps like Google Slides always show them in the dropdown. But you're suggestion is good, which means that if you click "b", and there's a "Bold" variant (not Extra Bold, not Medium, just Bold), then we switch to that automatically in the dropdown. So to be clear, that means that if I select "Bold" in the dropdown, "b" is automatically selected as well (so works in both directions).
An interesting edge case is "Extra Bold". We could either a), treat it like an unknown variant, and not select the "b" when the user selects the font in the dropdown, or b) treat it is a "Bold" variant, and select the "b" (and when you then click "b" again, it switches back to normal weight. I'm leaning towards b).

Let me know if that makes sense, happy to answer additional questions.

@spacedmonkey @jauyong @kmyram Can we have this api ticket created and be done before tomorrow morning? Unless the api ready until that time, I think this ticket can not be completed before Wednesday morning.

@ndev1991 I created #876 for the API update. Can you fill out exactly what you need from WP and the REST API in the ticket? And can you assign it to whoever would work on this? I'm not sure who it would be? @spacedmonkey

@ndev1991 I created #876 for the API update. Can you fill out exactly what you need from WP and the REST API in the ticket? And can you assign it to whoever would work on this? I'm not sure who it would be? @spacedmonkey

@jauyong details added to issue #876  but not assigned to anyone yet. I think it php side so should be @spacedmonkey or @miina

@spacedmonkey @swissspidy @miina @pbakaus So for this issue, we need to use the font variant  like the italic if exists. And no way to detect if the font variants exists or not currently. I can't see any fields that related with font variants from the fonts api. So I request api update for font variants.

@spacedmonkey @swissspidy @miina @pbakaus So for this issue, we need to use the font variant like the italic if exists. And no way to detect if the font variants exists or not currently. I can't see any fields that related with font variants from the fonts api. So I request api update for font variants. So basically I think a new field required that shows the available variants for this fonts. Like variants: ['Italic']

I'm super confused - we already have these variants... Like, we have them in the editor today:

For some reason this dropdown currently doesn't show the italic variants though (maybe we're already filtering them?).

We do have these variants in the dropdown, but they're hardcoded. Some fonts don't support things like super bold though. I think one thing discussed here is that the list should be dynamic depending on what the font supports (otherwise browser does handle boldness on its own).
However, there seems to be a misunderstanding here and this is not actually wanted. I think what we want here is that when pressing the Italic toggle, we need to make sure the Italic font variant is loaded accordingly.
@pbakaus can you perhaps clarify what was discussed here originally?

We do have these variants in the dropdown, but they're hardcoded. Some fonts don't support things like super bold though. I think one thing discussed here is that the list should be dynamic depending on what the font supports (otherwise browser does handle boldness on its own).

OMG! This list needs to be dynamic or up to date. Facepalm. Please somebody prioritize this.

However, there seems to be a misunderstanding here and this is not actually wanted. I think what we want here is that when pressing the Italic toggle, we need to make sure the Italic font variant is loaded accordingly.
@pbakaus can you perhaps clarify what was discussed here originally?

Yes, but that requires having access to the (real) variant list.

So to summarize this:

Font weight dropdown needs to be dynamic

This does not require an API change AFAIK. Font weights are exposed in the REST API & thus available in FontProvider

Optimize enqueueing Google fonts so only the required fonts weights and variants are actually loaded
We should handle enqueueing Google Fonts in the client-side generated AMP output for this (port \Google\Web_Stories\Story_Post_Type::load_fonts)

Note: not all fonts support font weights. For example, Abel only supports "regular". No bold. No italic. How should we display the Italic toggle and the font weights dropdown in  that case? cc @samitron7
(If we need to disable the Italic toggle, this would need an API change, see #876 for that.)

So to summarize this:

Font weight dropdown needs to be dynamic

This does not require an API change AFAIK. Font weights are exposed in the REST API & thus available in FontProvider

Optimize enqueueing Google fonts so only the required fonts weights and variants are actually loaded

We should handle enqueueing Google Fonts in the client-side generated AMP output for this (port \Google\Web_Stories\Story_Post_Type::load_fonts)

Yes to all of that, and rather sooner than later. These are critical to get right.

Note: not all fonts support font weights. For example, Abel only supports "regular". No bold. No italic. How should we display the Italic toggle and the font weights dropdown in that case? cc @samitron7

They're still working normally - in this case, the italic and bold buttons default to the browser approximation (font-style: italic etc).

(If we need to disable the Italic toggle, this would need an API change, see #876 for that.)

So to summarize this:

Font weight dropdown needs to be dynamic

This does not require an API change AFAIK. Font weights are exposed in the REST API & thus available in FontProvider

Optimize enqueueing Google fonts so only the required fonts weights and variants are actually loaded

We should handle enqueueing Google Fonts in the client-side generated AMP output for this (port \Google\Web_Stories\Story_Post_Type::load_fonts)

Yes to all of that, and rather sooner than later. These are critical to get right.

Note: not all fonts support font weights. For example, Abel only supports "regular". No bold. No italic. How should we display the Italic toggle and the font weights dropdown in that case? cc @samitron7

They're still working normally - in this case, the italic and bold buttons default to the browser approximation (font-style: italic etc).

(If we need to disable the Italic toggle, this would need an API change, see #876 for that.)

@pbakaus @swissspidy Here is the current implementation our version.
Get all the fonts list with available font-weights at the beginning by using api web-stories/v1/fonts and store the fonts list to fontProvider.
If user select text there is textStyle panel available with font family and font weight dropdown.
The font weights dropdown generated by using font family name from fontProvider and the available weights are from api. So actually the font weights dropdown is dynamic based on each font.
Once the user select different font that is not already loaded then it fetch that font from fontProvider and load that fonts with available font-weights.
And there are two types of bold at the moment. One through bold toggle and the other one is through font-weights dropdown.
So the only thing here is to sync those both I think. Basically when select the bold from font-weights dropdown it set the font-weights of that text. But when select the bold from toggle it uses strong tag.
To summarize.

All expected things already been implemented
The only thing to do with this ticket is to sync bold toggle and the font-weights (when the font has bold font weights)

From what I can tell, this task should involve:

It looks like we already filter the complete set of weights with those defined for the font family. We just need to also use the weight names defined for the font family, and not the hard-coded names.
When a new font family is selected, the closest match for the current font weight should be picked. (Might already be done, please check).

I added the following follow-up issues: #925, #923, #921, #922.

From what I can tell, this task should involve:

It looks like we already filter the complete set of weights with those defined for the font family. We just need to also use the weight names defined for the font family, and not the hard-coded names.
When a new font family is selected, the closest match for the current font weight should be picked. (Might already be done, please check).

I added the following follow-up issues: #925, #923, #921, #922.

@dvoytenko Thanks for your clarification.
No 2. makes perfect sense for me. I will check that soon.
No 1. Yes, we get various available font-weights from font api at the moment. Here is the example.
name: "Baumans"
slug: "baumans"
handle: "baumans-font"
src: "https://fonts.googleapis.com/css?family=Baumans%3A400&subset=latin%2Clatin-ext&display=swap"
fallbacks: ["cursive"]
weights: ["400"]
But not way to get the correct weights names defined for the font family

It looks like the weight names are always the same. They are:

Thin (100)
Extra-light (200)
Light (300)
Regular (400)
Medium (500)
Semi-bold (600)
Bold (700)
Extra-bold (800)
Black (900)

Ok. So perhaps point (1) is already WAI? Just need to change the hardcoded names?


[FR|EN Currency] fix wrong recognize "$2000 in 3 year" as "$2000 in 3"

This fixes #1699
In french, "Je veux un crédit de EUR 1000 sur 3 ans"  is wrong recognized "EUR 1000 sur"
Now, just fixed in .NET

Replaced by #1802


wrong discription in CovarianceMatrix layer?

https://github.com/jankrepl/deepdow/blob/cab9cac9d9212dd839951f65a9c0b49ca961eec7/deepdow/layers/misc.py#L69
I think this line for the CovarianceMatrix layer should be (n_samples, lookback, n_assets)? Instead of n_channels.

I would say it depends. More than anything, the middle dimensions is the one that we compute the sample covariance matrix over. So maybe more neutral name like dim would be more fitting.
The reason why it depends is that we do not really know what kind of layers came before the CovarianceMatrix layer. The only thing that is fixed in deepdow is that the input tensor X has a shape (n_samples, n_channels, lookback, n_assets).  What happens after is designed to be extremely flexible.
See below two valid architectures and note that for each of them the middle dimension has a different meaning.
1.
(n_samples, n_channels, lookback, n_assets) -- average over the channel dimension -- > (n_samples, lookback, n_assets)  -- CovarianceMatrix --> (n_samples, n_assets, n_assets) ...
2.
(n_samples, n_channels, lookback, n_assets) -- average over the lookback dimension -- > (n_samples, n_channels, n_assets) -- CovarianceMatrix --> (n_samples, n_assets, n_assets) ...

ah ok thanks.

reopen just to act as a reminder to fix this perhaps


Unresolved ${selectedText} in commands

I would like if there was a way of making a single task that handles both a case with selected text, and no selected text. For example I have a command that opens the language help for the selected text function, but occasionally I want to open this without selectedText.
This is the error specifically:
'${selectedText}' can not be resolved. Make sure to have some text selected in the active editor.
I propose three solutions

Allow variable defaulting, perhaps under the syntax as follows: ${selectedText|"default text"}
Have ${selectedText} be set as "" if there is no selected text rather than error out. This breaks backwards compatibility, if only to remove an error.
Provide an if defined directive in commands. I don't like this because it implies further metaprogramming tools in defining tasks.

A good request.  A workaround in the meantime is to use the extension https://marketplace.visualstudio.com/items?itemName=rioj7.command-variable for accessing the selected text:

extension.commandvariable.selectedText : The selected text in the active editor, empty string if nothing selected.

If we do something like this I prefer option 1. Duplicate of https://github.com/microsoft/vscode/issues/92854


kitty: add patch to fix -stack_size flag issue on darwin

Description of changes
Kitty is currently failing to build on Darwin systems with the following error:
ld: -stack_size option can only be used when linking a main executable

This started to happen when #157775 landed on master, in particular c7c3187d9897b304c85542130ece7bacc44906a9.
Initially I had thought that reverting that commit would be the right solution (#166516) however, upon further investigation it really does seem like most builds of Python 3 on Darwin include Wl,-stack_size,1000000 in LINKFORSHARED, as such Python 3 in nixpkgs should do the same, and the issue should be fixed upstream. More here on that here: https://github.com/kovidgoyal/kitty/issues/289#issuecomment-1084982042.
A patch has been committed upstream to resolve this issue: https://github.com/kovidgoyal/kitty/commit/57cffc71b78244e6a9d49f4c9af24d1a88dbf537. This PR adds that patch.
Closes #165387.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I'm currently having some issues with a test or two failing on Darwin (not that the build can get that far), but I decided to go ahead and open this PR anyways, to see if @ofborg runs into the same issue, or if it's something about my local system.

Interesting, @ofborg didn't have any issues.
This is what was giving me trouble:
test_box_drawing (kitty_tests.fonts.Rendering) ... 2022-03-31 20:54:51.832 python3.9[13034:80023782] XType: com.apple.fonts is not accessible.
2022-03-31 20:54:51.832 python3.9[13034:80023782] XType: XTFontStaticRegistry is enabled.
2022-03-31 20:54:51.852 python3.9[13034:80023782] CoreText: System LastResort not available, using built-in copy.
ok
test_coalesce_symbol_maps (kitty_tests.fonts.Rendering) ... ok
test_emoji_presentation (kitty_tests.fonts.Rendering) ... ok
test_fallback_font_not_last_resort (kitty_tests.fonts.Rendering) ... FAIL
test_font_rendering (kitty_tests.fonts.Rendering) ... python3.9(13034,0x1009f8580) malloc: *** error for object 0x70000001037473a0: pointer being freed was not allocated
python3.9(13034,0x1009f8580) malloc: *** set a breakpoint in malloc_error_break to debug

I'm going to push an update with a short comment with some context about the patch. I'd be happy to merge after that.

KovidGoyal made a patch to fix the issue https://github.com/kovidgoyal/kitty/commit/57cffc71b78244e6a9d49f4c9af24d1a88dbf537 so please fetchpatch it
He's very fast

You forgot to remove the patch file.

You forgot to remove the patch file.

Good catch :)
Removed.


Errors are ( sometimes not listed )

I have the following project
<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup Label="Globals">
    <CustomProjectExtensionsPath>$(SolutionDir)\WpfNetStandardSample\CustomProjectSystem\</CustomProjectExtensionsPath>
  </PropertyGroup>

  <Import Project="$(CustomProjectExtensionsPath)CustomProject.props" />

  <PropertyGroup>
    <TargetFramework>net461</TargetFramework>
    <AssemblyName>ReactiveUI.Ext</AssemblyName>
    <RootNamespace>ReactiveUI.Ext</RootNamespace>
  </PropertyGroup>

  <ItemGroup>
    <Reference Include="PresentationCore" />
    <Reference Include="PresentationFramework" />
    <Reference Include="System.Xaml" />
    <Reference Include="WindowsBase" />
    <Reference Include="System.Windows.Forms" />
  </ItemGroup>

  <ItemGroup>
    <PackageReference Include="devDept.Eyeshot" Version="10.0.1097" />
    <PackageReference Include="Expression.Blend.Sdk" Version="1.0.2" />
    <PackageReference Include="FluentValidation" Version="7.1.1" />
    <PackageReference Include="FSharp.Core" Version="4.2.3" />
    <PackageReference Include="Ix-Main" Version="1.2.5" />
    <PackageReference Include="LanguageExt.Core" Version="1.7.38" />
    <PackageReference Include="MahApps.Metro" Version="1.5.0" />
    <PackageReference Include="ManagedEsent" Version="1.9.4" />
    <PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
    <PackageReference Include="Ninject" Version="<IP_ADDRESS>" />
    <PackageReference Include="reactiveui" Version="7.4.0" />
    <PackageReference Include="ReactiveUI.Fody" Version="2.2.11" />
    <PackageReference Include="reactiveui-core" Version="7.4.0" />
    <PackageReference Include="reactiveui-events" Version="7.3.0" />
    <PackageReference Include="Rx-XAML" Version="2.3.0-beta2" />
    <PackageReference Include="Serilog" Version="2.5.0" />
    <PackageReference Include="System.Collections.Immutable" Version="1.4.0" />
    <PackageReference Include="System.ValueTuple" Version="4.4.0" />
    <PackageReference Include="Unofficial.Blend.Interactivity" Version="1.0.0" />
    <PackageReference Include="Weingartner.Exceptional" Version="1.7.3" />
    <PackageReference Include="Mono.Cecil" Version="<IP_ADDRESS>" />
  </ItemGroup>

  <ItemGroup>
    <ProjectReference Include="..\Lens\Lens.csproj" />
    <ProjectReference Include="..\Utils\Utils.csproj" />
    <ProjectReference Include="..\Weingartner.WPF\Weingartner.Wpf.Common\Weingartner.Wpf.Common.csproj" />
  </ItemGroup>

  <!--
       This is a simple workaround for issue with ReSharper when it reports
       "Field is already used" because including intermediate files into it's project model.
       Unfortunately $(IntermediateOutputPath) doesn't work here.
       If you're not using ReSharper you can safely remove this section.
  -->

  <ItemGroup>
    <Compile Remove="obj\**" />
  </ItemGroup>
</Project>

and the output from the compiler is
Restoring NuGet packages...
To prevent NuGet from restoring packages during build, open the Visual Studio Options dialog, click on the Package Manager node and uncheck 'Allow NuGet to download missing packages during build.'
Committing restore...
Assets file has not changed. Skipping assets file writing. Path: C:\Users\phelan\workspace\WeinCAD.NET\Lens\obj\project.assets.json
Restore completed in 13.82 ms for C:\Users\phelan\workspace\WeinCAD.NET\Lens\Lens.csproj.
Committing restore...
Assets file has not changed. Skipping assets file writing. Path: C:\Users\phelan\workspace\WeinCAD.NET\ReactiveUI.Ext\obj\project.assets.json
Restore completed in 16.09 ms for C:\Users\phelan\workspace\WeinCAD.NET\ReactiveUI.Ext\ReactiveUI.Ext.csproj.
Committing restore...
Assets file has not changed. Skipping assets file writing. Path: C:\Users\phelan\workspace\WeinCAD.NET\Lens.Spec\obj\project.assets.json
Restore completed in 17.2 ms for C:\Users\phelan\workspace\WeinCAD.NET\Lens.Spec\Lens.Spec.csproj.
Committing restore...
Assets file has not changed. Skipping assets file writing. Path: C:\Users\phelan\workspace\WeinCAD.NET\Math\obj\project.assets.json
Committing restore...
Restore completed in 19.23 ms for C:\Users\phelan\workspace\WeinCAD.NET\Math\Numerics.csproj.
Committing restore...
Assets file has not changed. Skipping assets file writing. Path: C:\Users\phelan\workspace\WeinCAD.NET\Utils\obj\project.assets.json
Committing restore...
Assets file has not changed. Skipping assets file writing. Path: C:\Users\phelan\workspace\WeinCAD.NET\LaserHelpers\obj\project.assets.json
Restore completed in 3.72 ms for C:\Users\phelan\workspace\WeinCAD.NET\Utils\Utils.csproj.
Assets file has not changed. Skipping assets file writing. Path: C:\Users\phelan\workspace\WeinCAD.NET\SpecHelper\obj\project.assets.json
Restore completed in 19.67 ms for C:\Users\phelan\workspace\WeinCAD.NET\LaserHelpers\LaserHelpers.csproj.
Restore completed in 19.73 ms for C:\Users\phelan\workspace\WeinCAD.NET\SpecHelper\SpecHelper.csproj.
Committing restore...
Assets file has not changed. Skipping assets file writing. Path: C:\Users\phelan\workspace\WeinCAD.NET\ReactiveUI.Ext.Spec\obj\project.assets.json
Restore completed in 8.8 ms for C:\Users\phelan\workspace\WeinCAD.NET\ReactiveUI.Ext.Spec\ReactiveUI.Ext.Spec.csproj.
Committing restore...
Assets file has not changed. Skipping assets file writing. Path: C:\Users\phelan\workspace\WeinCAD.NET\Math.Spec\obj\project.assets.json
Restore completed in 22.88 ms for C:\Users\phelan\workspace\WeinCAD.NET\Math.Spec\Numerics.Spec.csproj.
1>------ Build started: Project: ReactiveUI.Ext, Configuration: Debug Any CPU ------
1>Target _HandlePackageFileConflicts:
1>  Encountered conflict between 'Reference:C:\Users\phelan\.nuget\packages\expression.blend.sdk\1.0.2\lib\net45\System.Windows.Interactivity.dll' and 'Reference:C:\Users\phelan\.nuget\packages\mahapps.metro\1.5.0\lib\net45\System.Windows.Interactivity.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'Reference:C:\Users\phelan\.nuget\packages\expression.blend.sdk\1.0.2\lib\net45\System.Windows.Interactivity.dll' and 'Reference:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\System.Windows.Interactivity.dll'.  Choosing 'Reference:C:\Users\phelan\.nuget\packages\expression.blend.sdk\1.0.2\lib\net45\System.Windows.Interactivity.dll' because file version '3.0.40218.0' is greater than '3.0.30810.0'.
1>  Encountered conflict between 'Reference:C:\Users\phelan\.nuget\packages\system.valuetuple\4.4.0\ref\net461\System.ValueTuple.dll' and 'Reference:C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\Microsoft\Microsoft.NET.Build.Extensions\\net461\ref\System.ValueTuple.dll'.  Choosing 'Reference:C:\Users\phelan\.nuget\packages\system.valuetuple\4.4.0\ref\net461\System.ValueTuple.dll' because file version '4.6.25519.3' is greater than '4.6.25514.4'.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\expression.blend.sdk\1.0.2\lib\net45\System.Windows.Interactivity.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\mahapps.metro\1.5.0\lib\net45\System.Windows.Interactivity.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\expression.blend.sdk\1.0.2\lib\net45\System.Windows.Interactivity.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\System.Windows.Interactivity.dll'.  Choosing 'CopyLocal:C:\Users\phelan\.nuget\packages\expression.blend.sdk\1.0.2\lib\net45\System.Windows.Interactivity.dll' because file version '3.0.40218.0' is greater than '3.0.30810.0'.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\Microsoft.Expression.Interactions.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\en\Microsoft.Expression.Interactions.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\System.Windows.Interactivity.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\en\System.Windows.Interactivity.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\Microsoft.Expression.Interactions.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\es\Microsoft.Expression.Interactions.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\System.Windows.Interactivity.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\es\System.Windows.Interactivity.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\Microsoft.Expression.Interactions.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\fr\Microsoft.Expression.Interactions.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\System.Windows.Interactivity.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\fr\System.Windows.Interactivity.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\Microsoft.Expression.Interactions.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\it\Microsoft.Expression.Interactions.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\System.Windows.Interactivity.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\it\System.Windows.Interactivity.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\Microsoft.Expression.Interactions.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\ja\Microsoft.Expression.Interactions.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\System.Windows.Interactivity.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\ja\System.Windows.Interactivity.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\Microsoft.Expression.Interactions.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\ko\Microsoft.Expression.Interactions.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\System.Windows.Interactivity.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\ko\System.Windows.Interactivity.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\Microsoft.Expression.Interactions.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\ru\Microsoft.Expression.Interactions.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\System.Windows.Interactivity.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\ru\System.Windows.Interactivity.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\Microsoft.Expression.Interactions.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\zh-Hans\Microsoft.Expression.Interactions.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\System.Windows.Interactivity.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\zh-Hans\System.Windows.Interactivity.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\Microsoft.Expression.Interactions.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\zh-Hant\Microsoft.Expression.Interactions.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\de\System.Windows.Interactivity.resources.dll' and 'CopyLocal:C:\Users\phelan\.nuget\packages\unofficial.blend.interactivity\1.0.0\lib\net45\zh-Hant\System.Windows.Interactivity.resources.dll'.  Could not determine winner due to equal file and assembly versions.
1>  Encountered conflict between 'CopyLocal:C:\Users\phelan\.nuget\packages\system.valuetuple\4.4.0\lib\net461\System.ValueTuple.dll' and 'CopyLocal:C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\Microsoft\Microsoft.NET.Build.Extensions\\net461\lib\System.ValueTuple.dll'.  Choosing 'CopyLocal:C:\Users\phelan\.nuget\packages\system.valuetuple\4.4.0\lib\net461\System.ValueTuple.dll' because file version '4.6.25519.3' is greater than '4.6.25514.4'.
1>Target GenerateTemporaryTargetAssembly:
1>  Target CoreCompile:
1>    Using shared compilation with compiler from directory: C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\MSBuild\15.0\Bin\Roslyn
1>    Logging\SerilogExtensions.cs(37,33,37,37): error CS1061: 'LoggerSinkConfiguration' does not contain a definition for 'File' and no extension method 'File' accepting a first argument of type 'LoggerSinkConfiguration' could be found (are you missing a using directive or an assembly reference?)
1>  Done building target "CoreCompile" in project "futhp5ap.tmp_proj" -- FAILED.
1>
1>  Done building project "futhp5ap.tmp_proj" -- FAILED.
========== Build: 0 succeeded, 1 failed, 5 up-to-date, 0 skipped ==========

with the source of the error being a missing reference. Specifically
 <PackageReference Include="Serilog.Sinks.File" Version="3.2.0" />
but the errors windows does not collect the error withregards to Logging\SerilogExtensions even though the build failed.

Is this fixible?
BTW ( awsome project ) I was looking for a way to convert XAML projects to the new format. :)

Hi,
I also has this issue. When I disable XAML building it reports the errors properly. I don't know if there are any workaround for this issue :-(.
I'm using ReSharper and with it I don't have such problem. All the errors are reported properly. It seems ReSharper uses it's own errors provider or something like that.
Regards!

Have you enabled "Resharper Builder"

or am I missing a trick.

Wierd. Now Visual studio shows the error

temperamental little beast of an IDE it is.

No... I changed

to

That's what made it work

I don't use this ReSharper Build feature.
I only set this setting

But not sure if it's related, but it works for me very well.
Regarding your last message where you set reporting to "Build + Intellisense" - there is a problem - the IntelliSense errors are only from the files processed by it, i.e. from opened documents. If you close the document and rebuild, you will not see the errors.

I have that also set to do not call MSBuild

@bradphelan, I mean I never using VS "Error list" and instead using "Errors/Warnings in Solution" from ReSharper (solutionwide analysis).

ok. I'll try that.
I've also opened an issue with Visual Studio.

But I normally leave solution wide analysis off as it slows down VS. I have 65 open projects and it grinds.

@bradphelan, I hope VS team will address this issue. We need this feature to be working too as most of our customers (modders of our games, actually) will not have ReSharper.
CC https://github.com/dotnet/project-system/issues/1467

Ok. Can you please vote the issue up in the feedback window then. ( btw I got the resharper errors working ) thanks for the tip

@bradphelan would it be possible to provider a link to the feedback item so we can vote on, too?

@BrunoJuchli it's there https://developercommunity.visualstudio.com/content/problem/121523/build-errors-do-not-show-in-the-errors-list.html

My current work around is to
(1) ditch the errors list
(2) Set the msbuild output to minimal
(3) Install VSColorsOutput extensions
All the errors are highlighted in color and you can still click on them to go to source.
So it is clear that one part of visual studio can parse out the errors and another part cannot.


Skills section

A skills section
  - List out the skills you expect to learn from the bootcamp.

Added skills in html. Need to style the images in the cards.

done. closing


Create mrchromebox-fwscript.sh

this is a script to run mrchromebox's firmware utility script, surprised it wasn't already included lol
script is here: https://mrchromebox.tech/#fwscript

Looks good.


Bug: CLI routing using session does not work after ver4.2.11

PHP Version
8.0
CodeIgniter4 Version
4.2.11
CodeIgniter4 Installation Method
Composer (as dependency to an existing project)
Which operating systems have you tested for this bug?
Linux
Which server did you use?
cli-server (PHP built-in webserver)
Database
MySQL 8.0
What happened?
After updating CodeIgniter v4.2.11, it is not possible to execute routing using sessions from the CLI.
Sessions are not normally used for CLI routing, but it was working fine until now, so I'll report it just in case.
CRITICAL - 2022-12-23 17:01:10 --> The arguments array must contain 4 items, 1 given
in SYSTEMPATH/HTTP/RequestTrait.php on line 123.
 1 SYSTEMPATH/HTTP/RequestTrait.php(123): vsprintf()
 2 SYSTEMPATH/Config/Services.php(658): CodeIgniter\HTTP\Request->getIPAddress()
 3 SYSTEMPATH/Config/BaseService.php(253): CodeIgniter\Config\Services::session()

Steps to Reproduce
Load the session in your controller.
$this->session = session();
Run from CLI
php public/index.php xxx
Expected Output
Up to v4.2.10 the process is executed normally.
Anything else?
No response

Cannot reproduce.
<?php

namespace App\Controllers;

class Home extends BaseController
{
    public function index()
    {
        session();
    }
}

$ php public/index.php
$

Even though I'm running from the CLI the logs are
[ Session: Initialization under CLI aborted. ]
It turned out that it does not become a message.
However, I can't find the additional steps to reproduce it, so if I find it and it's not a problem specific to my project, I'll share it again.

I found the additional steps needed to reproduce.
I also confirmed the reproduction in a newly created project by setting a reverse proxy IP with subnet for Config/App.php.
     public $proxyIPs = [
         '<IP_ADDRESS>/23' => 'X-Forwarded-For',
     ];

Also, for routing, enable automatic routing in advance.
Config/Routes.php
$routes->setAutoRoute(true);
Load the session in your controller.
class Home extends BaseController
{
     public function index()
     {
         session();
         return "index test !!!!\r\n";
     }
}

Execute from CLI (In this example, it is executed in Windows environment, but it will occur in Linux environment as well)
> php public\index.php home index

[ErrorException]

explode(): Passing null to parameter #2 ($string) of type string is deprecated

at SYSTEMPATH\HTTP\RequestTrait.php:119

Backtrace:
   1 [internal functions]
        CodeIgniter\Debug\Exceptions()->errorHandler(8192, 'explode(): Passing null to parameter #2 ($string) of type string is deprecated', 'C:\\eclipse\\ci4test\\vendor\\codeigniter4 \\framework\\system\\HTTP\\RequestTrait.php', 119)

   2 SYSTEMPATH\HTTP\RequestTrait.php:119
        explode('.', null)
...

Thank you. I've confirmed the error on develop.
diff --git a/app/Config/App.php b/app/Config/App.php
index c6eec07a6..94bf23595 100644
--- a/app/Config/App.php
+++ b/app/Config/App.php
@@ -346,7 +346,9 @@ class App extends BaseConfig
      *
      * @var array<string, string>
      */
-    public $proxyIPs = [];
+    public $proxyIPs = [
+        '<IP_ADDRESS>/23' => 'X-Forwarded-For',
+    ];

     /**
      * --------------------------------------------------------------------------
diff --git a/app/Controllers/Home.php b/app/Controllers/Home.php
index 7f867e95f..6eb577588 100644
--- a/app/Controllers/Home.php
+++ b/app/Controllers/Home.php
@@ -6,6 +6,7 @@ class Home extends BaseController
 {
     public function index()
     {
-        return view('welcome_message');
+        session();
+        return "index test !!!!\r\n";
     }
 }

$ php public/index.php

[ValueError]

The arguments array must contain 4 items, 1 given

at SYSTEMPATH/HTTP/RequestTrait.php:121


Fix scatterview profile interaction

This PR fixes an issue in the ScatterView with the profile tool.
Initially raised here: https://github.com/silx-kit/silx/pull/2810#issuecomment-562220610
It was not possible to start a profile while hovering a point of the scatter plot (this was due to the scatter item being selectable and so taking focus of the mouse press event).
The scatter item is no longer selectable and so no longer takes the focus of mouse events

BTW what does this change means?
-        roi.setLabel('Profile')
+        roi.setName('Profile')

It comes from the fact that ROI and RegionOfInterest classes are now sharing some API.
And setLabel is now deprecated.


Type mismatch for ActionData in code vs docs

TLDR; Looks like href should be optional in docs
ActionData defined in docs https://github.com/pinterest/gestalt/blob/master/docs/src/Callout.doc.js
{|
    accessibilityLabel?: string ,
    href: string,
    label: string,
    onClick?: ({ event: SyntheticMouseEvent<HTMLAnchorElement> | SyntheticKeyboardEvent<HTMLAnchorElement | SyntheticMouseEvent<HTMLButtonElement> | SyntheticKeyboardEvent<HTMLButtonElement> }) => void
|}

ActionData defined in code https://github.com/pinterest/gestalt/blob/master/packages/gestalt/src/Callout.js
type ActionData = {|
  accessibilityLabel?: string,
  href?: string,
  label: string,
  onClick?: AbstractEventHandler<
    | SyntheticMouseEvent<HTMLButtonElement>
    | SyntheticMouseEvent<HTMLAnchorElement>
    | SyntheticKeyboardEvent<HTMLAnchorElement>
    | SyntheticKeyboardEvent<HTMLButtonElement>
  >,
|};

This was fixed by https://github.com/pinterest/gestalt/pull/1340. Thanks for letting us know about the bug! 🙂

This was fixed by https://github.com/pinterest/gestalt/pull/1340. Thanks for letting us know about the bug! 🙂


gatsby-image srcset widths are possibly fractional

We should Math.floor the breakpoint value here:
https://github.com/angeloashmore/gatsby-source-prismic/blob/882a5a41daac14e1caea039277cb876d97ae8a1c/src/gatsbyImage.ts#L108
If the value of w is fractional, Chrome logs the following error:
Failed parsing 'srcset' attribute value since its 'w' descriptor is invalid.

Fixed in master. Will publish in next release.


Custom visualization plugin not working for charts.

I followed this tutorial https://superset.apache.org/docs/installation/building-custom-viz-plugins to create a custom viz plugin for superset. But somehow the generated plugin is never shown in the chart selection wizard.
Then i researched and found this bug https://github.com/apache-superset/superset-ui/issues/794 on github but the answers given over there are also not working.
When i run
yarn jest
I get the following error

While running npm run dev-server i get this error

superset-ui version: v0.15.2
Node version: v14.15.0
npm version: 6.14.8

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: https://github.com/apache/superset/issues/13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this issue on the main repo if it is still relevant.


DDT-223 Fix filter on CarrierVoyageNumber and CarrierServiceCode

This was caused by possible NULL values. I believe the transportCallID
filter test failing was also caused by this. In addition, the voyage was
mapped different from how we mapped it in the TransportCallTO, probably
changed information model.

Do I need to bump version and reference new version in https://github.com/dcsaorg/DCSA-API-Validator/pull/82 ?

@multimikael did you enable the tests in API-Validator which we disabled in order to merge the branch we were working on into master?


SDC-pepolar not executed only for some runs

DS000223 / sub-01 / run-03, run-04 don't have SDC-pepolar, while run-01 and run-02 do.

Most likely not in the "IntendedFor" field.
-------- Original message --------
From: Oscar Esteban<EMAIL_ADDRESS>Date: 10/17/17 18:03 (GMT-05:00)
To: poldracklab/fmriprep<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [poldracklab/fmriprep] SDC-pepolar not executed only for some runs (#774)
DS000223 / sub-01 / run-03, run-04 don't have SDC-pepolar, while run-01 and run-02 do.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/poldracklab/fmriprep/issues/774, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAFF8q3t4CcgwFtC1yhPBiuV5OTCQesQks5stSQfgaJpZM4P84u6.

Actually, it just looks like there's only fieldmaps for runs 1 and 2 for subjects 1-6. There are no fieldmaps at all for subjects 7-19.

@chrisfilo what do you think we should do here? My feeling is that not running SDC unless the file has been pointed by an IntendedFor key would implicitly make IntendedFor mandatory. What is the current stand of BIDS on this?

Just to be clear, here:
$ tree /data/bids/ds000223/sub-01
/data/bids/ds000223/sub-01
├── anat
│   └── sub-01_T1w.nii.gz
├── fmap
│   ├── sub-01_dir-opposing_run-01_epi.json
│   ├── sub-01_dir-opposing_run-01_epi.nii.gz
│   ├── sub-01_dir-opposing_run-02_epi.json
│   └── sub-01_dir-opposing_run-02_epi.nii.gz
└── func
    ├── sub-01_task-mag_run-01_bold.json
    ├── sub-01_task-mag_run-01_bold.nii.gz
    ├── sub-01_task-mag_run-01_events.tsv
    ├── sub-01_task-mag_run-02_bold.json
    ├── sub-01_task-mag_run-02_bold.nii.gz
    ├── sub-01_task-mag_run-02_events.tsv
    ├── sub-01_task-mag_run-03_bold.json
    ├── sub-01_task-mag_run-03_bold.nii.gz
    ├── sub-01_task-mag_run-03_events.tsv
    ├── sub-01_task-mag_run-04_bold.json
    ├── sub-01_task-mag_run-04_bold.nii.gz
    └── sub-01_task-mag_run-04_events.tsv

My interpretation is that the opposing runs are specifically acquired for runs 01 and 02, and that they are not valid for 03 and 04. Is that wrong? (The IntendedFor fields are certainly written as if this is the case, but I don't have any outside context for this dataset.)

I doubt that was the original intent when the protocol was designed.
The "opposing" EPIs are certainly designed to be used with the IntendedFor
BOLDs in estimation. But I'm pretty convinced that the idea was to apply
the correction on all BOLD scans.
On Oct 20, 2017 12:14 PM, "Chris Markiewicz"<EMAIL_ADDRESS>wrote:

Just to be clear, here:
$ tree /data/bids/ds000223/sub-01
/data/bids/ds000223/sub-01
├── anat
│   └── sub-01_T1w.nii.gz
├── fmap
│   ├── sub-01_dir-opposing_run-01_epi.json
│   ├── sub-01_dir-opposing_run-01_epi.nii.gz
│   ├── sub-01_dir-opposing_run-02_epi.json
│   └── sub-01_dir-opposing_run-02_epi.nii.gz
└── func
├── sub-01_task-mag_run-01_bold.json
├── sub-01_task-mag_run-01_bold.nii.gz
├── sub-01_task-mag_run-01_events.tsv
├── sub-01_task-mag_run-02_bold.json
├── sub-01_task-mag_run-02_bold.nii.gz
├── sub-01_task-mag_run-02_events.tsv
├── sub-01_task-mag_run-03_bold.json
├── sub-01_task-mag_run-03_bold.nii.gz
├── sub-01_task-mag_run-03_events.tsv
├── sub-01_task-mag_run-04_bold.json
├── sub-01_task-mag_run-04_bold.nii.gz
└── sub-01_task-mag_run-04_events.tsv
My interpretation is that the opposing runs are specifically acquired for
runs 01 and 02, and that they are not valid for 03 and 04. Is that wrong?
(The IntendedFor fields are certainly written as if this is the case, but
I don't have any outside context for this dataset.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/poldracklab/fmriprep/issues/774#issuecomment-338298139,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAkhxuIW3a_EnokjmfE11-IaRKQ2g1-wks5suPEWgaJpZM4P84u6
.

So this should be solved by #747, then?

Yes - mostly. The idea being: fmriprep tries to make the best estimation of the field map possible given a certain set of means (pepolar, fieldmap, syn, etc) and then corrects all BOLD scans with that.
As for BIDS, I think we are reaching to a point where we can rethink the "IntendedFor". With all this experience we gathered, I think we can propose to make the field mandatory. And the meaning would be something like: this EPI is the opposing direction of this other EPI (can be a BOLD, another EPI, a low-b diffusion or an SBref), and those two (or more) are the inputs for TOPUP (or whatever pepolar method you want to use).

IntendedFor field is share across all types of fieldmap data and does not indicate how the fieldmaps should be estimated. It only tells which file a particular fieldmap should be applied to.
This sounds like a problem with the dataset itself - "IntendedFor" should be listed for all runs (unless they should not be applied to all runs). Please raise this issue via appropriate channels with OpenfMRI curation team.
As for what to do with fieldmap data that do not have "IntendedFor" fields - that is up to each package. One approach could be to (suggested by @poldrack a while ago) to create a robust average for all available fieldmaps (for each subject independently) and apply it to all BOLD runs (ignoring "IntendedFor" field even if it is present). The advantage of this approach is that due to averaging the fieldmap will be more robust.

Thanks, I forgot that IntendedFor applies to all fieldmaps.
Anyways, this seems to be a BIDS-specification issue more than a FMRIPREP issue. Especially with #747 there. I'll bring the discussion to the appropriate venue.
Feel free to reopen if needed.


Twitter link has an incorrect connection

A user points out this little thing with the Tweet button:
There is a connection shown "via @chimp" that is not the correct Twitter feed. It should be "via @chimpandsee"
That is correct; @chimpandsee is the correct feed. Tweakable?

Where is this supposed to be? The share button for twitter just posts "Classifying on the Zooniverse!" with the talk subject link. There aren't any links going to a chimpandsee twitter account anywhere on the site.

I'm not entirely sure. I thought that it might be something in the code that indicated the referral.
Let me see if I can figure out a bit more what the user is talking about...

Might be this line in the Talk config?
https://github.com/zooniverse/Talk/blob/master/projects/chimp/config.coffee#L6

Good catch @eatyourgreens. @DarrenMcRoy, will you open a ticket for this on the Talk repo? Thanks.


Question regarding slide 9 of Lecture 07

Hi everyone, can I check why is this the case for Lecture 07 slide 9?
It is stated that when using orElseGet(supp), the get method is only invoked when Optional is empty. However, from the circled code, why is s.get() invoked when the Optional contains 1 and its not invoked when its an empty optional? Shouldn't it be the other way around? Thank you!

I suspect that it might be a typo, just ran the code in jshell, it seems to be the other way around

Check the newly updated slides, I think prof henry has already updated accordingly!


[Feature Request] Practice problems for Linked List

🚀 Feature Request
Is your feature request related to a problem? Please describe.
currently there are no problems of Linked list
Describe the solution you'd like
problems increase the topics understanding and hep us very much
Describe alternatives you've considered
i want to add linked list questions document
Additional context

Would you like to work on this feature?

[x] Yes
[ ] No

@ajay-dhangar please assign me this issue

It's already done!


enable forcetypeassert linter

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[ x] Code style update (formatting, renaming)
[ x] Refactoring (no functional changes, no api changes)
[ x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #933
What is the new behavior?

Other information

Codecov Report
Attention: Patch coverage is 32.62411% with 95 lines in your changes are missing coverage. Please review.

Project coverage is 40.25%. Comparing base (b7a9b51) to head (503a8f7).
Report is 2 commits behind head on master.

Files
Patch %
Lines

internal/value/nullable.go
50.00%
11 Missing and 11 partials :warning:

internal/table/client.go
33.33%
5 Missing and 5 partials :warning:

internal/cmd/gtrace/writer.go
0.00%
9 Missing :warning:

log/field.go
50.00%
4 Missing and 5 partials :warning:

internal/types/types.go
0.00%
8 Missing :warning:

internal/value/value.go
50.00%
3 Missing and 3 partials :warning:

internal/conn/conn.go
0.00%
4 Missing :warning:

internal/table/transaction.go
0.00%
4 Missing :warning:

internal/xcontext/local_dc.go
0.00%
4 Missing :warning:

internal/xsql/rows.go
0.00%
4 Missing :warning:

... and 5 more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1195      +/-   ##
==========================================
- Coverage   40.80%   40.25%   -0.55%
==========================================
  Files         309      309
  Lines       32747    27777    -4970
==========================================
- Hits        13361    11181    -2180
+ Misses      18959    16142    -2817
- Partials      427      454      +27

Flag
Coverage Δ

go-1.21.x
?

go-1.22.x
40.25% <32.62%> (-0.55%)
:arrow_down:

macOS
?

ubuntu
40.25% <32.62%> (-0.05%)
:arrow_down:

unit
40.25% <32.62%> (-0.55%)
:arrow_down:

windows
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@rekby @asmyasnikov please, review

Can you exclude forcetypeassert linter for all test files through exclude-rules in .golangci.yml?
Your changes cannot add of understanding for tests and type casts in tests not required because if some cast failed - test will failed

Can you exclude forcetypeassert linter for all test files through exclude-rules in .golangci.yml? Your changes cannot add of understanding for tests and type casts in tests not required because if some cast failed - test will failed

@asmyasnikov Ok. I have made changes


feat(linter): add oxc/no-rest-spread-properties rule

People open this rule may have some specific purpose, I am deliberating about whether to add a custom message.

#3432  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @mysteryven and the rest of your teammates on  Graphite

What's the difference between this and https://github.com/mysticatea/eslint-plugin-es/blob/v1.4.1/docs/rules/no-spread-elements.md
We need to be careful!

es2018 https://github.com/mysticatea/eslint-plugin-es/blob/v1.4.1/docs/rules/no-rest-spread-properties.md
es2015 - https://github.com/mysticatea/eslint-plugin-es/blob/v1.4.1/docs/rules/no-spread-elements.md

As for error message, I think we should accept an error message, because we don't know what the intent is.


Meshgrid order issue when pre-calculating wavenumber with anisotropic grid.

Hi, when using the package I found an issue when you create grid.wavenumber.
The wavenumber is created with numpy/cupy meshgrid, but you should specify indexing='ij' instead of indexing='xy' (default) in the following code:
(             self.fourier_x_mesh,             self.fourier_y_mesh,             self.fourier_z_mesh,         ) = cp.meshgrid(fourier_x, fourier_y, fourier_z,indexing='ij')

Hi @linhz0hz! Good spot, I've been too focussed on isotropic grids I didn't realise. I'll fix this shortly in a new PR.


Utah county parcels

Will the utah code that you have be ok with Utah Utah County Parcels?
I thought this might be a goofy edge case or something that you might want to be aware of.

After double-checking, it should, yes. It just checks against whatever is in the meta table, using the itemid as the key.


Incorrect Toast Message Displayed for Blocked/Disabled User Access Attempt

Expected behavior
The toast message should accurately convey that the user account is blocked or disabled, providing clear information to the user about the reason for denied access.
Steps to reproduce the issue
Block or disable a user account within the application.
Attempt to access the application using the blocked or disabled user account credentials.
Observe the toast message displayed upon denied access.
Environment details

App version: v1.6.0
Testing Environment: UAT

Additional information

This issue should be in Launchpad since that is where all login is handled. Transferring issue.


fix(build): update node version to 16

fixes #12756

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (b58129d).
Report is 298 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12924       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2427        -9
  Lines        133233   132746      -487
  Branches      20636    20556       -80
=============================================
- Hits          82274        0    -82274
- Misses        44911   132746    +87835
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
0.00% <ø> (-61.75%)
:arrow_down:

skip-bytebuffers-true
?

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@jayeshchoudhary does this patch change the way npm fetches and auth checks during builds.
After this change, I am getting this error while building from local:
npm http fetch POST 403 https://unpm.uberinternal.com/-/npm/v1/security/advisories/bulk 1705ms

Reverting this change locally allows me to build successfully again.
We usually remove our token during builds using:
USSO_TOKEN=$(usso -ussh unpm.uberinternal.com -print 2> /dev/null)
    TOKEN=$(echo -n "ignored:$USSO_TOKEN" | base64)
    echo "//unpm.uberinternal.com/:_auth=$TOKEN" >> ~/.npmrc


Add Profiles to App

I believe that adding a Profile functionality to the app would be a beneficial option. I would like to have different profiles for things such as ultra-low power usage, normal day-to-day use, gaming and AI/ML work.

You can do it right now. Just think and organize. I even have a keyboard shortcuts to switch it.


New-Command: outlook report mailappusageusercounts

Implements #1214

Coverage remained the same at 100.0% when pulling f840de73f1d4ffb93ef1dffe4d005910e50948d0 on plamber:outlook-report-mailappusageusercounts into 84c571d8d7d98d5994643e52d09212c4716b1c21 on pnp:dev.

Thank you very much Patrick @plamber ! This is not manually merged in dev.


Using the GPRS_SIM900 not initialize

I have a seeeduino GPRS. I'm using the library GPRS_SIM900 like you recomend from the wiki. Deploy the GPRS_TCPConnection.ino example, change the TX, RX pins also:
define PIN_TX 8
define PIN_RX 7
But when deploy I obtain this error from my Serial debug:
init error
init error
....
This library GPRS_SIM900 is really compatible with Seeeduino GPRS??
Regards

Thank you Masalinas, the problem is Seeeduino GPRS need to be powered up  by port D9.
void SIM800::preInit(void)
{
    pinMode(SIM800_POWER_STATUS,INPUT);
    delay(10);
    if(LOW == digitalRead(SIM800_POWER_STATUS))
    {
        if(sendATTest() != 0)
        {
            delay(800);
            digitalWrite(powerPin,HIGH);
            delay(200);
            digitalWrite(powerPin,LOW);
            delay(2000);
            digitalWrite(powerPin,HIGH);
            delay(3000);
        }
        while(sendATTest() != 0);
        //Serial.println("Init O.K!");
    }
    else
    {
        Serial.println("Power check failed!");
    }
}

Hi, sorry to re-open such an old ticket. I'm having a similar issue with the init. I've set the D9 pin to HIGH, but the issue persists.
For some reason it only intermittently recognizes the actual modem, and most of the time I get an "init failed"... Not sure what's going on? Can it be the power? I've tried several power sources and I get the same issue? The power switch on the board is set to 5V.
The weirdest thing is that the NET light is flashing constantly.


TypeError: string indices must be integers

Hi,
Running the script with Python 3.6.4 on Windows 10, I have a type error:
Traceback (most recent call last):   File "start.py", line 45, in <module>     trades_into = market["pair"].replace(coin["symbol"],"").replace("-","") TypeError: string indices must be integers
I attach the complete output, including the command line used: output-arbitrage-chances.txt

i'll work on it. keep you updated.

fixed in commit.


yarn build fails after a fresh clone

Issue workflow progress
Progress of the issue based on the Contributor Workflow

[ ] 1. The issue provides a reproduction available on Github, Stackblitz or CodeSandbox

Make sure to fork this template and run yarn generate in the terminal.
Please make sure the Codegen and plugins version under package.json matches yours.

[ ] 2. A failing test has been provided

[ ] 3. A local solution has been provided

[ ] 4. A pull request is pending review

Describe the bug
yarn build fails after clean clone & yarn.
To Reproduce
Steps to reproduce the behavior:

yarn
yarn build
following error is thrown:

yarn build
yarn run v1.22.17
$ rimraf "{,!(node_modules)/**/}dist/"
$ tsc --project tsconfig.json && bob build
Error: Could not resolve entry module (dist/graphql-codegen-cli/src/index.js).
    at error (/Users/path/to/graphql-code-generator/node_modules/rollup/dist/shared/rollup.js:10120:30)
    at /Users/path/to/graphql-code-generator/node_modules/rollup/dist/shared/rollup.js:16553:20
    at async Promise.all (index 0)
    at async Promise.all (index 0)
    at async Promise.all (index 0)
    at async rollupInternal (/Users/path/to/graphql-code-generator/node_modules/rollup/dist/shared/rollup.js:18158:18)
    at async build (/Users/path/to/graphql-code-generator/node_modules/bob-the-bundler/dist/commands/build.js:151:20) {
  code: 'UNRESOLVED_ENTRY'
}
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Expected behavior
To my understanding the build should succeed. I'm following these instructions: https://www.graphql-code-generator.com/docs/custom-codegen/contributing
Environment:

OS: macos
@graphql-codegen/...: latest master at the time of writing
NodeJS: tried with v14.15.4 & v16.14.2

It hasn't happened to me 🤔

Maybe I need to try with more recent and clean clone then.


LG addition

Instead of sign up by showing up, will you add:

"Text the leader to sign up!"

Let's add phone numbers with each group like you see in the Sunday program. Do you have  copy?

Yes, I have a copy.

Also add:
NEW LIFEGROUP SESSION BEGINS WEEK OF JANUARY 7-9.


[BUG] Validating Boolean Values On Import Does Not Work

Prerequisites

[x] Checked if your Laravel Excel version is still supported: https://docs.laravel-excel.com/3.1/getting-started/support.html#supported-versions
[x] Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
[x] Checked that your issue isn't already filed.
[x] Checked if no PR was submitted that fixes this problem.
[x] Filled in the entire issue template

Versions

PHP version: 7.3.4
Laravel version: 5.8.19
Package version: 3.1.15

Description
When exporting, it is possible to cast values to booleans, but there is no equivalent for importing. The automated casting casts 1 to 1.0, "1" to 1.0, and the string "true" to "true", which means that Laravel's boolean validator cannot be used with an import operation.
Steps to Reproduce

Create a csv file as such

bool_val
1
0
"1"
"0"
true
false

Create a import job with the following validator. The model section is irrelevant

    public function rules(): array
    {
        return [
            'bool_val' => 'required|boolean',
        ];
    }

Run the import

Expected behavior:
The values get properly casted to booleans and validate successfully as per: https://laravel.com/docs/5.8/validation#rule-boolean
Actual behavior:
The following error message is given: The bool_val field must be true or false.
Additional Information
There appears to be a way to cast for exports based on row, but not for imports based on header value.

PhpSpreadsheet does some auto-formatting on your data. In case of Csv there's no way for Phpspreadsheet to tell if 1 is an integer of boolean. In those case it's best to help PhpSpreadsheet the column formatting by using a custom value binder. You can find the example here: https://docs.laravel-excel.com/3.1/exports/custom-formatting-values.html#value-binder

This makes sense, but how would I changed this based on the header value of the column the cell is in?
These spreadsheets are created by users, so it is vital that I do not hard-code the order of columns.
If you could provide assistance on this it would be great.
Thanks!

You can use the StringValueBinder instead that reads everything as-is


Jenkins plugin: add config parameter "email"

When using the Jenkins plugin in a non-Github plugin, the patch only appears in the log.
We can add an advanced config parameter "email": if a patch is found and we are not in a Github context, the patch is sent by email to the developers.
@henry-lp WDYT?

Yes , I'll add this new feature. Is this urgent ?
If I can start in one or two week after my schedule loose up a bit, it would be perfect. :)

Great, thanks Henry! No urgency here :-)


[DO NOT MERGE] Auto PR to update dependencies of pilot

This PR will be merged automatically once checks are successful.
none

@istio-testing: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
113e979650c4d774e389a74912ef0784f497641c
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Avconv not detected?

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2016.12.22. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2016.12.22

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl --verbose -C --prefer-avconv https://www.twitch.tv/iarspider/v/110629920 -o "Skyrim_001.mp4"
[debug] System config: []
[debug] User config: [u'--ffmpeg-location', u'/home/sysadmin/libav']
[debug] Command-line args: [u'--verbose', u'-C', u'--prefer-avconv', u'https://www.twitch.tv/iarspider/v/110629920', u'-o', u'Skyrim_001.mp4']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.12.22
[debug] Python version 2.7.6 - Linux-3.13.0-98-generic-x86_64-with-Ubuntu-14.04-trusty
[debug] exe versions: none
[debug] Proxy map: {}
[debug] Public IP address: xxx.xxx.xxx.xxx
[twitch:vod] 110629920: Downloading vod info JSON
[twitch:vod] 110629920: Downloading vod access token
[twitch:vod] 110629920: Downloading m3u8 information
[debug] Invoking downloader on u'https://vod146-ttvnw.akamaized.net/v1/AUTH_system/vods_9922/iarspider_24070824080_573097007/chunked/index-dvr.m3u8'
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 5678
[download] Destination: Skyrim_001.mp4
[download] 100% of 759.23MiB in 22:38
WARNING: v110629920: malformated aac bitstream. Install ffmpeg or avconv to fix this automatically.

Description of your issue, suggested solution and other information
Since I'm still on Ubuntu 14.04, I have decided to build libav from source myself (so that youtube-dl won't complain every time). Everything worked until now.
lib av version 12:
$ /home/sysadmin/libav/bin/avconv
avconv version 12, Copyright (c) 2000-2016 the Libav developers
  built on Dec 31 2016 10:47:44 with gcc 4.8 (Ubuntu 4.8.4-2ubuntu1~14.04.3)
Hyper fast Audio and Video encoder
usage: avconv [options] [[infile options] -i infile]... {[outfile options] outfile}...

Use -h to get full help or, even better, run 'man avconv'

    --ffmpeg-location PATH           Location of the ffmpeg/avconv binary;
                                     either the path to the binary or its
                                     containing directory.

either the path to the binary or its directory

Oops and thanks!


Unable to use treemacs (won't higlight any file)

Newbie to doom emacs, probably something I misunderstood about treemacs, sorry.
Observed behavior
Unable to use treemacs.
It doesn't highlight any file, and shows another project than the current one.
When I hit l, I have this message: [Treemacs] Ad-hoc navigation is only possible when there is but one current project in the workspace
Expected behavior
When I enter SPC o p, a window on the left should show the current edited file
in the buffer, with only the current project I'm working on.
When I use j and k keybindings, it should switch the highlighted file in the
treemacs window.
I can highlight a file with my the mouse, but nothing happens when I click on it
(I can press RET to visit it)
Steps to reproduce

SPC o p
j or k

System information

Click to expand
- OS: gnu/linux (x86_64-pc-linux-gnu)
- Emacs: 26.1 (Jul 05, 2018)
- Doom: 2.0.9 (develop ee4d3172935c645fb41ef7f1b085b93ce0e99904)
- Graphic display: t (daemon: nil)
- System features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES THREADS LIBSYSTEMD LCMS2
- Details:
  ```elisp
  elc count: 0
  uname -a:  Linux hal 4.17.14.a-1-hardened #1 SMP PREEMPT Fri Aug 10 00:21:59 CEST 2018 x86_64 GNU/Linux
  modules:   (:feature (evil +everywhere) file-templates (lookup +devdocs +docsets) snippets spellcheck (syntax-checker +childframe) workspaces :completion (helm +fuzzy) :ui doom-dashboard doom-modeline doom-quit evil-goggles hl-todo nav-flash treemacs (popup +all +defaults) vc-gutter vi-tilde-fringe window-select :editor multiple-cursors parinfer rotate-text :emacs ediff electric hideshow imenu term vc :tools magit :lang clojure data emacs-lisp (haskell +intero) javascript markdown (org +attach +babel +capture +export +present) racket rest (sh +fish) web :config)
  packages:  n/a
  exec-path: (/usr/local/bin /usr/local/sbin /usr/bin /usr/lib/jvm/default/bin /usr/bin/site_perl /usr/bin/vendor_perl /usr/bin/core_perl /usr/lib/emacs/26.1/x86_64-pc-linux-gnu)

Screenshot showing the issue

Treemacs prefers multiple-projects in the project sidebar. I don't, so as of d0295a2, there should only be one project present in Treemacs when you open it.
And e866fc4 makes the current selection more visible. Before used the hl-line face, which may be difficult to see in some themes. Now it uses region, which I hope will be more visible.
This should resolve your two issues. Let me know if that isn't the case.

I can highlight a file with my the mouse, but nothing happens when I click on it

Single click just sets the focus, a double click will do the same thing as RET.  A click on the icon will show a file's tags, if possible.
I don't know about doom specifics, but you should also read the first two points in this list. That explains how treemacs handles projects.
Looking at your treemacs code doom may also be interested in:

treemacs-fringe-indicator-mode
deferred git-mode
a workspace api, once it's done: https://github.com/Alexander-Miller/treemacs/issues/247
A full-blown extension api is in the works as well: https://github.com/Alexander-Miller/treemacs/issues/263

@hlissner Thanks a lot for the reactivity. Tested it, works perfectly.

@qleguennec thanks for the issue. I had the same problem, and it was resolved beautifully thanks to @hlissner .
FYI, I am using doom-solarized-light theme.