gnome3: semi-automated update

Motivation for this change
Update
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Failure on x86_64-darwin (full log)
Partial log (click to expand)
Package ‘libgepub-0.5.3’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/desktops/gnome-3/core/libgepub/default.nix:29 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
shrinking /nix/store/g8hgb5gi8jrfr4vlqi2l0ah8z0ypxssx-shotwell-0.27.4/lib/shotwell/plugins/builtin/libshotwell-transitions.so
shrinking /nix/store/g8hgb5gi8jrfr4vlqi2l0ah8z0ypxssx-shotwell-0.27.4/lib/shotwell/plugins/builtin/libshotwell-publishing-extras.so
shrinking /nix/store/g8hgb5gi8jrfr4vlqi2l0ah8z0ypxssx-shotwell-0.27.4/lib/shotwell/plugins/builtin/libshotwell-publishing.so
shrinking /nix/store/g8hgb5gi8jrfr4vlqi2l0ah8z0ypxssx-shotwell-0.27.4/lib/libshotwell-plugin-common.so.0.27.4
gzipping man pages under /nix/store/g8hgb5gi8jrfr4vlqi2l0ah8z0ypxssx-shotwell-0.27.4/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/g8hgb5gi8jrfr4vlqi2l0ah8z0ypxssx-shotwell-0.27.4/lib  /nix/store/g8hgb5gi8jrfr4vlqi2l0ah8z0ypxssx-shotwell-0.27.4/libexec  /nix/store/g8hgb5gi8jrfr4vlqi2l0ah8z0ypxssx-shotwell-0.27.4/bin
patching script interpreter paths in /nix/store/g8hgb5gi8jrfr4vlqi2l0ah8z0ypxssx-shotwell-0.27.4
/nix/store/g8hgb5gi8jrfr4vlqi2l0ah8z0ypxssx-shotwell-0.27.4/libexec/shotwell/.shotwell-settings-migrator-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-shotwell-0.27.4.drv-0 in /nix/store/g8hgb5gi8jrfr4vlqi2l0ah8z0ypxssx-shotwell-0.27.4...

Success on aarch64-linux (full log)
Partial log (click to expand)
gzipping man pages under /nix/store/yyjda7jfdi6kk01kv8asj0q5f2zczakp-rhythmbox-3.4.2/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/yyjda7jfdi6kk01kv8asj0q5f2zczakp-rhythmbox-3.4.2/lib  /nix/store/yyjda7jfdi6kk01kv8asj0q5f2zczakp-rhythmbox-3.4.2/libexec  /nix/store/yyjda7jfdi6kk01kv8asj0q5f2zczakp-rhythmbox-3.4.2/bin
patching script interpreter paths in /nix/store/yyjda7jfdi6kk01kv8asj0q5f2zczakp-rhythmbox-3.4.2
checking for references to /build in /nix/store/yyjda7jfdi6kk01kv8asj0q5f2zczakp-rhythmbox-3.4.2...
/nix/store/svab1023gy3z2zdbfimhr4iwglb5wmn8-gexiv2-0.10.8
/nix/store/yfpcx307i5krg6znidz38cd6mnsarh31-libgee-0.20.1
/nix/store/859z1klcyr4241rl5km28r854d5x8jvf-libgepub-0.5.3
/nix/store/yyjda7jfdi6kk01kv8asj0q5f2zczakp-rhythmbox-3.4.2
/nix/store/7kmqkc2lislacl86fk3b5v75fwfl7hwx-shotwell-0.27.4

I succeesfully rebuild my system on this branch and successfully ran affected apps.


Training on the custom dataset

Can I use this code to train the model on my own dataset? If so, how should the dataset be structured?

You have to create a custom dataset loader in pytorch: https://pytorch.org/tutorials/beginner/basics/data_tutorial.html


How do i use something else than Kaggle?

I have an issue with cloning into my own huggingface account

Just delete the Kaggle steps in Google colab and upload your own created CSV with the scripts you want.


nd4j native tests - general pass

Excluding the TF import tests:

[X]  ~HierarchicSoftmaxTests  Errors: 0 Failures: 4~
[X]  ~ConvolutionTests  Errors: 0 Failures: 4~
[ ]  LoneTest  Failures: 3
[X]  ~DataSetTest  Errors: 0 Failures: 2~
[ ]    DerivativeTests Failures: 4
[ ]    Nd4jTestsC, testSoftmaxDerivativeGradient fails
[ ]   ReshapeTests.testColumnVectorReshape index out of bounds on getDouble
[ ]   StackAggregatorTests.testScalarAggregator fails
[X]  ~TestNDArrayCreation  Errors: 0 Failures: 1~
[X]  ~PreProcessor3D4DTest  Errors: 0 Failures: 1~
[X]  ~OpsMappingTests  Errors: 0 Failures: 1~
[X]  ~NormalizerStandardizeTest  Errors: 0 Failures: 1~
[X]  ~MultiDataSetTest  Errors: 0 Failures: 1~
[ ]   GradCheckMisc  Failures: 7
[X]  ~ConvolutionTestsC  Errors: 0 Failures: 1~
[X]  ~ByteOrderTests  Errors: 0 Failures: 1~
[X]  ~TwoPointApproximationTest  Errors: 1 Failures: 0~
[X]  ~TestRandomProjection  Errors: 6 Failures: 0~
[X]  ~SpecialTests  Errors: 1 Failures: 0~
[ ]  SparseTests*
[ ]  SameDiffTests  15 failures and 3 crash
[ ]  SameDiffOpExecutionerTest
[ ]  OnnxImportTest  Errors: 1 Failures: 0
[ ]  OnnxGraphMapperTests  Errors: 1
[X]  ~LossFunctionGradientChecks  Errors: 1 Failures: 0~
[X]  ~GraphExecutionerTest  Errors: 2 Failures: 0~
[ ]  GradCheckTransforms
[ ]  GradCheckReductions
[ ]  GradCheckLoss
[ ]  ExecutionTests
[X]  ~CustomOpsTests  Errors: 1 Failures: 0~
[X]  ~CompressionSerDeTests  Errors: 2 Failures: 0~
[X]  ~CompressionMagicTests  Errors: 2 Failures: 0~
[X]  ~BooleanIndexingTest  Errors: 2 Failures: 0~

Please note: SparseTests* require MKL to be installed.

Running on libnd4j and nd4j r119_more_fixes branches

@sshepel Script commands to download MKL from Intel and install it unattended for all platforms:   https://github.com/bytedeco/javacpp-presets/tree/master/ci


Font Request: Aileron

Font Name
Aileron
Link to font source
https://github.com/reinhart1010/aileron
Link to font license
https://github.com/reinhart1010/aileron/blob/master/LICENSE
Additional context
Aileron was part of typeface, would be nice to get it here so we can migrate.

Resolved in #98.


🛀 Upgrade everything!

Problem: coins-browser-test is out of date
Solution:

Remove unused requirements
Bump existing requirements' versions
Add ESLint, style guide rules. Make everything pass linting
Put linting in pre-commit hook

Testing: Ensure all tests (test/*.js) pass

@swashcap, looks great!  looks like it took forever! :shipit:

@cdaringe Yeah…😞 --fix can’t get everything.

ditto, this looks really nice!


Clarify that only the from parameter is required on /keys/changes

According to the current spec both from  and  to query parameters are required for a valid request but testing against synapse v0.26 shows that only from is required.
Maybe clarify that an empty to implies the latest state? I can submit a PR if that indeed is not a synapse bug.

It is neither a spec bug nor a synapse bug. Synapse will cope if you do not provide a to but other implementations may not.
There's an argument for enforcing it correctly in Synapse to stop people writing buggy clients, I suppose.

This sounds like a synapse bug then; it shouldn't try to cope if the spec says REQUIRED but the parameter is missing. It should throw an error.


Update Dependencies

I wanted to use this gem with a newer version of both the redis and bundler gems.
All the specs passed with the new versions. :smile_cat:

Hey there,
I would be in favour of bumping these, but I don't agree with the version tests you've chosen.
While better than what is currently there, restricting bundler to <= 1.7.12 and redis to <= 3.2.0 will break on the next point release of each.
bundler < 1.8.0 and redis < 3.3.0 are probably better choices.

Excellent, thanks for the feedback @elucid! I'll modify the tests and update the PR.


Shared: fix shared futures missing wake up

an attempt to fix https://github.com/rust-lang/futures-rs/issues/2706
the waker mutex is used to protect the state transition that involves wakers (add, wake, re-wake), if a waker is called during the polling, it sets the state to WOKEN_DURING_POLLING then the polling thread re-checks for potential new wakers and set state back to IDLE under the same mutex to avoid the race condition.
an unit test is adopted from the issue and added, without the fix, it'll be stuck within 5 loops on my laptop locally.

doesn't look like I can add reviewers or labels, manually tag here @taiki-e , would appreciate feedbacks or loop in proper reviewers, thanks

Thanks for the ping, I think I even saw this PR before and forgot about it again.
I guess I'll have to re-read my own issue first to understand what exactly needed fixing.


community: CrateDB: Vector Store

About

Description: Vector Store adapter for CrateDB.
Coming from: https://github.com/crate-workbench/langchain/pull/1
Documentation: GH-27713
Addressed to: @eyurtsev

Status

We are considering the patch ready for review and merging, with a few spots to be handled on a later iteration.
Please let us know if you want to see any other details to be addressed before the initial merge.
A few backlog items have been collected here: https://github.com/crate-workbench/langchain/issues/30.

Sandbox
A little walkthrough how to exercise the software tests on your workstation.
docker run --rm -it --name=cratedb \
  --publish=4200:4200 --publish=5432:5432 --env=CRATE_HEAP_SIZE=2g \
  crate:latest -Cdiscovery.type=single-node

git clone https://github.com/crate-workbench/langchain.git --branch=cratedb-up/1/vector-store
cd langchain
uv venv
source .venv/bin/activate
cd libs/community
uv pip install --upgrade --prerelease=allow --editable=. poetry sqlalchemy-cratedb
poetry install --no-interaction --no-ansi --with dev,test,test_integration

pytest -vvv tests/integration_tests/vectorstores/test_cratedb.py

Trivia
The CrateDB implementation is heavily based on PGVector's, with a few adjustments. Previous generalizations and improvements to PGVector have been submitted the other day already.

GH-16243
GH-16244

Hi @eyurtsev. We think our patches are ready to be merged. This one, and GH-27711 as well as GH-27712. May we humbly ask you to have a look?

Dear @eyurtsev,
may I humbly ask you if you could afford a few cycles to review our patches? Thanks in advance!
With kind regards,
Andreas.

Hey! This adds a net-new community integration or feature, which has been replaced by dedicated integration packages. I'll close this PR if it's ok with you, and would recommend reopening with just docs updates, as well as registering your package in libs/packages.yml! We'll be able to review simple PRs that only modify these two things much faster :)
Here's the guide, and if you have questions, feel free to leave them in the comments on those pages so others can see them! https://python.langchain.com/docs/contributing/how_to/integrations/
This will pair very nicely with the variety of integrations you're working on at the moment!
Will leave this PR open to discuss and link back here when closing the other ones (to make sure we're discussing in one place)

Hi Erick,
thanks for your reply. So, we will conceive and publish a dedicated Python package langchain-cratedb then, including the relevant code? Sure, we can do.

Will leave this PR open to discuss and link back here when closing the other ones (to make sure we're discussing in one place)

I think it would be coherent to also close this PR, and then discuss on behalf of a separate dedicated issue to accompany the genesis of langchain-cratedb, where I am very much looking forward to, receiving your assistance on any question we may have along the way. 🍀
I will open the other issue when it is time to start the discussion, i.e. when we have something to show that starts working. Do you agree with this approach?
With kind regards,
Andreas.

sounds like a great approach!


[page] user Profile

Page infos

Url : /settings
Path in codebase : src/pages/Settings/

Description
Private profile page of the user. Contains all the informations of his profile. This is where the user can edit his informations.
Child of module Profiles #8
Mockup

Merged with #520, closing.


Best Alternative for Fullscreen on iOS

so i've read the section of the updated docs regarding fullscreen not being supported on iOS and just wanting to get some ideas from other users on the best way to combat this. while i love the frigate-hass-card, and honestly believe it to be a better 'viewer' than native frigate itself, the lack of a fullscreen mode on iOS is a killer (to no fault of any developer here).
Is it possible to rotate the display of a card 90 degrees with Home Assistant and then resize the card to fill the available space for a fullscreen-esque appearance? or what other alternatives, if any, exist for iOS users?

Tough one. The new v5.0.0 build has a new "expanded mode", which is essentially 75% of "fullscreen" within the HA dashboard (i.e. not using the JS fullscreen API that iOS stubbornly refuses to implement...). Maybe there's something that could do done with this if we bumped it to 100%, then transform: rotate(90) in CSS. I don't know how this would behave exactly though, and I think the killer is it would probably not be able to "overwrite" the top HA "tab" bar.
Really this would need a developer with an iOS device to experiment, though...

following up--i just setup a standalone dashboard with the view type set to "panel" so only the frigate-card is available and i think a 90 degree rotation and increasing the area to 100% would be make it a pretty good approximation of fullscreen mode.
i would be happy to test if you could push through the required changes when you have time.

v5 Beta 1 can't full screen birdseye (default, I don't use the restreamed method as it takes longer to load) but any camera configured with the go2rtc live provider I am getting full screen mode from the embedded players full screen icon, with full rotation support.
I am also using it in a view in "panel" single card mode.
cameras:
  - frigate:
      camera_name: birdseye
  - frigate:
      camera_name: doorbell
    live_provider: go2rtc

v5 Beta 1 can't full screen birdseye (default, I don't use the restreamed method as it takes longer to load) but any camera configured with the go2rtc live provider I am getting full screen mode from the embedded players full screen icon, with full rotation support.

Yes -- with iOS on iPhone you should (I think) still be able to click fullscreen on the video element itself, just not any other element, e.g. the card itself. So you could get the live view fullscreen via the fullscreen button in the video player, but not the thumbnails/timeline nor can the fullscreen button on the card ever do anything useful in iOS on iPhone.

V5 card will fill the screen if you are using a single card panel mode view for the dash board this includes the media browser events now.

V5 card will fill the screen if you are using a single card panel mode view for the dash board this includes the media browser events now.

That's right, but not in fullscreen mode (which is what I thought you were talking about: "I am getting full screen mode from the embedded players full screen icon"!).

following up, for whatever reason i do not have any way to click fullscreen even on the video element (at least not from the live viewer, I havent tried after actually clicking play on a media browser clip to see if its available there).
however I can confirm that creating a standalone tab/dashboard and setting it to single card/panel mode seems to work well. To help with this, in the "Shortcuts" iOS app i created an automation to turn off portrait orientation lock whenever Home Assistant is opened and re-lock on close. Now, from my Frigate dynamic notifications I am able to directly link to this panel mode card and rotate my phone to landscape without any additional input and its about 90% as good as if iOS were to fully support the fullscreen API. good enough for me at least.
i will close this issue now

@kirsch33 Do you think you could write up some brief instructions that I could include in the documentation for iOS mobile users who find themselves in the same situation, from what you've learned?

@dermotduffy for sure, one night this week ill reply to this issue with some screenshots and descriptions.

I installed v5 beta and noted on iPhone that I could click on the video and was presented with pause icon in middle of video along with full screen and pop-out options and was able to click full screen and pop-out (if that's the right terminology), but have since noticed that this only works if I have wifi on phone turned off.

Sounds like your connection method mjpeg / webrtc might be changing
depending if you are internal or external.
This may depend on ports and firewall rules you have setup for the frigate
container and go2rtc.
On Fri, Apr 14, 2023 at 10:47 AM Pico @.***> wrote:

I installed v5 beta and noted on iPhone that I could click on the video
and was presented with pause icon in middle of video along with full screen
and pop-out options and was able to click full screen and pop-out (if
that's the right terminology), but have since noticed that this only works
if I have wifi on phone turned off.

—
Reply to this email directly, view it on GitHub
https://github.com/dermotduffy/frigate-hass-card/issues/1062#issuecomment-1509015145,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMDT5NYESND3TJNQ7VDI6LXBGETTANCNFSM6AAAAAAWU4OKOM
.
You are receiving this because you commented.Message ID:
@.***>

--
David Greekas

I noticed Safari on iPhone has a “Fullscreen API” experimental feature flag you can enable in Safari’s advanced WebKit feature flag settings. I verified after enabling it, websites like the screenfull.js demo site work. Could this be the path to fullscreen in HA iOS?

Could this be the path to fullscreen in HA iOS?

Absolutely. The card will "just work" if the underlying iOS browser behaves like ... all other browsers. Sounds like that experimental flag may help it do so.

Could this be the path to fullscreen in HA iOS?

Absolutely. The card will "just work" if the underlying iOS browser behaves like ... all other browsers. Sounds like that experimental flag may help it do so.

Sorry to bump this issue but even with the Fullscreen API flag checked in safari, it doesn't work for me. Anyone else have success?


How do I access the v1 search?

I wish to use the search by passing a query,
https://developer.twitter.com/en/docs/twitter-api/v1/tweets/search/api-reference/get-search-tweets
I intend to find all the user's tweets in the past year, and from what I can tell, this will be more efficient. How do I go about doing so?

I've also tried using v2 search, but I get  Error: Request failed with code 403 - Your credentials do not allow access to this resource. (Twitter code 220), however my app has full permissions.
Please do let me know if I'm mistakened.

Hi :)
API v2 endpoints are only available if your application is part of a project: see here. This can be the reason of why you can't use the v2 endpoint.
Or you're using only consumer tokens (without access tokens) to log in. In this can you need yo use your Bearer token (available on the same page).

I intend to find all the user's tweets in the past year, and from what I can tell, this will be more efficient. How do I go about doing so?
Answer: You simply can't! As you can read in the documentation, search is limited to 7 days ago.

Still, here's how you can use search v1 endpoint:
v1 search isn't implemented through an endpoint wrapper, you need to call it by yourself:
import TwitterApi, { TweetV1 } from 'twitter-api-v2'

interface SearchV1Result {
  statuses: TweetV1[]
  search_metadata: { max_id_str: string; since_id_str: string; count: number; next_results?: string; }
}

const tweets = await client.v1.get<SearchV1Result>('search/tweets.json', { q: 'from:alkihis' })

console.log(tweets.statuses)

Thanks. Ended up doing it mainly using regular request and oauth.
Appreciate the clarification
On Sun, 26 Dec 2021 at 4:33 PM, alkihis @.***> wrote:

Closed #135 https://github.com/PLhery/node-twitter-api-v2/issues/135.
—
Reply to this email directly, view it on GitHub
https://github.com/PLhery/node-twitter-api-v2/issues/135#event-5815362473,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGDEEVTE6QCP77WFNF5HC5TUS3HMNANCNFSM5KYSIWAA
.
You are receiving this because you authored the thread.Message ID:
@.***>

How would I do that in pure javascript?


Use a separate docker image for cross compiling

Instead of attempting to use one monolithic docker image for all the build tasks we should aim to have images for each logical group of tasks.  This PR creates a new Dockerfile for running the cross build.
cc @justincormack - we talked about this earlier this week

microservices!

/me likes it 👼

I really like this. This will reduce bloat by so much for people who aren't routinely doing cross-compiles.

Yes, definitely an improvement. Will try it out shortly.

Looks like janky and experimental are failing with this:
22:20:45 ---> Making bundle: tgz (in bundles/1.13.0-dev/tgz)
22:20:45 error: binary and cross must be run before tgz

I think to make this work with CI we are going to need a separate jenkins build for cross+tgz.

good idea! needs a rebase @dnephin

ping @dnephin can you rebase your PR? Or is https://github.com/docker/docker/issues/27359 meant to replace this?

It's blocked on #27359

@dnephin we're looking at this one, but it looks like we should be able to merge this without the other PR, correct?

Not really. It breaks janky because we run builds in a single image. We need a way to tell it to use different images for different builds.
Making that change now is difficult because it would break any branches that don't include this change. The Jenkinsfile makes this a much easier operation, because the build config is stored in the branch.

I opened #28952 to replace this


change volumeBindingMode to WaitForFirstConsumer

Problem:
When we create a new VM, it shows a temporary status ErrorUnschedulable and error message unbound immediate PersistentVolumeClaims.
Solution:
Change volumeBindingMode in StorageClass to WaitForFirstConsumer, so we don't get this unscheduled error from pod. Also, VM's first status will change to WaitingForVolumeBinding.
Related Issue:
https://github.com/harvester/harvester/issues/2221
Test plan:

Create a Harvester cluster.
Import Image and check its volumeBindingMode in StorageClass is WaitingForVolumeBinding.
Run kubectl get vm -w on the terminal.
Create a VM with our imported image.
Check there is no ErrorUnschedulable shown on the terminal.

> kubectl get vm -w
NAME   AGE   STATUS   READY
vm     0s
vm     0s    WaitingForVolumeBinding   False
vm     5s    Starting                  False
vm     23s   Running                   False
vm     23s   Running                   True

...volumeBindingMode is an immutable field, users cannot change it after the harvester is deployed.

Can the current upgrade path update that immutable field?
BTW I tested the feature by modifying that immutable field via kubectl edit -n longhorn-system configmap longhorn-storageclass

...volumeBindingMode is an immutable field, users cannot change it after the harvester is deployed.

Can the current upgrade path update that immutable field?
BTW I tested the feature by modifying that immutable field via kubectl edit -n longhorn-system configmap longhorn-storageclass

If it can be modified through configmap, I think it can be update during the upgrade. Thanks for your information! Probably, we can have a setting for users. If they want to create volume immediately, they can change the lognhorn-storageclass configmap.

After testing, I also can update longhorn-storageclass configmap. After updating it to Immediate, the Pending Volume will become Ready.

we are considering to remove deploy/charts/harvester/templates/longhorn-storageclass-override.yaml, due to https://github.com/harvester/harvester/issues/2088

Unfortunately, per https://github.com/longhorn/longhorn/pull/3881/files
LH is not exposing volumeBindingMode to chart values, if we use HOOK to force changing it, the fleet-agent may still always complain.
@FrankYang0529 @guangbochen @ibrokethecloud

We are not going to remove the default longhorn storage class but considering migrating to use a custom harvester-specific SC instead.

@guangbochen, for #2221, do you think it's okay to delay PVC binding if there is no consumer? If not, we may still get ErrorUnschedulable due to unbound immediate PersistenVolumeCliam.

@FrankYang0529 change policy may cause other problmes.
e.g.  user creates a bunch of "volume" in advance, and then create VM(s) to use those existing volume,  delay  binding  may cause burst, and capacity congestion is another concern.
I am not sure we can cover all cases quickly.
back to the issue itself, it it caused by user selecting: create VM and add (implicitly create)  volumes  together?

back to the issue itself, it it caused by user selecting: create VM and add (implicitly create) volumes together?

Yeah, in the harvester VM controller, we check the harvesterhci.io/volumeClaimTemplates annotation. If a PVC is existent, we skip it. If not, we create it.
Also, if we set volumeBindingModel: Immediate in StorageClass, there will be a short time that PVC is just created and it's not bound to a PV. So pod shows the error unbound Immediate PersistentVolumeClaim in PodScheduled condition.
https://github.com/harvester/harvester/blob/fdb64376010ad8993c5488b4779ced0edf88b7b2/pkg/controller/master/virtualmachine/vm_controller.go#L43-L48

Seems another way is: the vm controller checks the PVCs, until PVCs meet requirements in a defined time, otherweise, report creating VM failure.

Seems another way is: the vm controller checks the PVCs, until PVCs meet requirements in a defined time, otherweise, report creating VM failure.

Actually, the pod is created from the KubeVirt controller. If there is no PVC, they will show ErrorPvcNotFound and will not create the pod.
https://github.com/kubevirt/kubevirt/issues/7697#issuecomment-1119572637
They don't check whether PVC is bound, because there is a status for it WaitingForVolumeBinding. However, if there is an error from the pod, VM may show the error from the pod. You can check the second case in this comment. VM shows WaitingForVolumeBinding first, and then ErrorUnschedulable.
https://github.com/harvester/harvester/pull/2235#issuecomment-1122137543

We have another issue: https://github.com/harvester/harvester/issues/1695, and a requirement to LH: https://github.com/longhorn/longhorn/issues/3734
LH is in aync mode, PVC created != PVC is really usable.
Now we leave those burdens to KubeVirt,  let it to bind VM with PVC with more.
On the other hand, the vm controller may try to do a lit more, check those conditions, then have a user friendly feedback. Sure, it is not a tiny task, more a HEP.
At the moment, I would rather keep this issue unchanged and write it into document.

this can be closed in favor of https://github.com/harvester/harvester/pull/2768, and the volumeBindingMode will be configurable via the UI in v1.1.0.


Update README.rst

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Does your contribution introduce a new dependency? If yes, which one?

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

For all contributions

[x] The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
[ ] Optionally, I've added myself and possibly others to the CODEOWNERS file - do this if you want to become the owner or maintainer of an estimator you added.

For new estimators

[ ] I've added the estimator to the API reference in docs/api.rst.
[ ] I've added one or more illustrative usage examples to the docstring and the examples section.

K-fold Cross-Validation
`model = MeanRisk()
mmp = cross_val_predict(model, X_test, cv=KFold(n_splits=5))
mmp is the predicted MultiPeriodPortfolio object composed of 5 Portfolios (1 per testing fold)
mmp.plot_cumulative_returns()
print(mmp.summary()`
print(mmp.summary() -> print(mmp.summary())


#234 Add the resign socket event listener

Please fix the merge conflicts and re-open the PR
@Timmy-id


Allow more template options in generate

Closes #1587

Gives an option to use different templates
Allow templates to have data options
Add a counter template

For contributor use:

[ ] Targeted PR against master branch
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[ ] Code follows the standards mentioned here
[ ] Updated relevant documentation
[ ] Re-reviewed Files changed in the Github PR explorer
[ ] Added appropriate labels

Codecov Report
Attention: Patch coverage is 54.38596% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 38.75%. Comparing base (885bc37) to head (eab6b33).

Files
Patch %
Lines

internal/super/setup.go
0.00%
15 Missing :warning:

internal/super/generate.go
73.80%
8 Missing and 3 partials :warning:

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feature/interactive-init    #1610      +/-   ##
============================================================
+ Coverage                     38.60%   38.75%   +0.15%
============================================================
  Files                            52       52
  Lines                          3523     3566      +43
============================================================
+ Hits                           1360     1382      +22
- Misses                         1991     2009      +18
- Partials                        172      175       +3

Flag
Coverage Δ

unittests
38.75% <54.38%> (+0.15%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Catch tx errors

What it solves
Fixes #2432.
How this PR fixes it
Catches the "Signatures data too short" error, plus a few others.
How to test it

Set policy to > 1
Create a tx and set the nonce to a lower number (of an existing tx)
Check the console

Any extra information
Plus added this extra messages for spending limit tx errors:

I tested sending eth via sending limit: https://pr2443--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x257423548758a2e9015604E921e05956838Bd157
Everything worked fine


Style the login page similar to the home page

The current login page form is pretty basic (purposely)
So your goal is change the /src/css/login.css to match the same design as the home page
What does this mean?:

Change color of background
Change background transparency
Make borders(edges) rounded
Change size and look of buttons

dan you can change the colors of the buttons and the username/passwords fields

Make Try Now and Learn More button:hover text color orange to offset new background color
Modify inputs to go along with theme


.*: Refine storage interpreter

What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
What is changed and how it works?
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-integration-test

/run-all-tests

/run-integration-test

/run-integration-test

/run-unit-test

/rebuild

/run-all-tests


capture "non whitelisted IP" error

I didn't see an error reported with, but got the following with DEBUG=1
<?xml version="1.0" encoding="utf-8"?>
<ApiResponse Status="ERROR" xmlns="http://api.namecheap.com/xml.response">
  <Errors>
    <Error Number="1011150">Invalid request IP: <IP_ADDRESS></Error>
  </Errors>
  <Warnings />
  <RequestedCommand />
  <Server>PHX01APIEXT03</Server>
  <GMTTimeDifference>--5:00</GMTTimeDifference>
  <ExecutionTime>0</ExecutionTime>
</ApiResponse>

When running terraform apply, I received the error:
Error: Failed to create namecheap Record: Could not find the record with hash<PHONE_NUMBER>
In my case, it was my public IP not being in the whitelist of my Namecheap account's API, but I assume that something like wrong token key would also return the same error. The error is quite misleading, because it looks like the record doesn't exist. IMO, there should be a dedicated error message for not being able to connect to the Namecheap API endpoint.

The error:
    <Error Number="1011150">Invalid request IP: <IP_ADDRESS></Error>

is possible only if you have not whitelisted your IP. Some details are here
@caiconkhicon this error most likely resolved with #24
It depends on which exactly request you have been executing. Upon refactoring, we got rid of "hashing" the records so probably you won't face this error anymore :)
After merging the complete refactoring I will close this issue. You're welcome to reopen if that will still be relevant for you.


Feature Request: Update daily sensor automatically when the actual sensor changes it's value

Hi,
would it be possible to have the daily sensor not to update after a specfifc time interval but instead whenever the main sensor changes it's value? My goal is to display the min and max temperature next to the actual temperature on my Dashboard and it looks kind of wrong if it get's warmer than the current max temp but the sensor takes a while to update and thus shows a wrong value. Sure, I could just reduce the time interval but imo the better alternative would be to automatically update the daily sensor based on state changes.

The easier alternative would perhaps be to create an update service beside the reset service. That way I could just create an automation that calls the update service whenever the temperature changes

Right, I could add the update service, because the alternative cannot work - the component can not force itself to capture events that are not fired ;)

done. v0.3 provides this service.

Wow, thanks a lot. Although I don't quite understand what you mean with "capture events that are not fired"? As soon as as any sensor changes it's value home assistant will send a state_changed event which could be captured by this integration or do I miss something?
Don't get me wrong - I'm absolutely happy with the new update service :) I'd just like to know why the other method can't work

yeah, you're right - I am just not a big fan of the way that works. So, sure, technically we could do this, but I don't think it is a good idea. Suppose people will add 500 of these Daily Sensors? Then HA gets to deal with 500 listeners to the update events, not sure if that is what we want to stimulate.

A question to ensure I've understood this correctly:

I've got a smart meter that reports the voltage on my grid connection in near real-time (every 2 to 3 seconds)
I'd like to use this integration to keep a record of the minimum and maximum voltage over the course of a day, so that I can easily see if there have been any outliers below or above the officially allowed range of voltages
low or high voltages can occur extremely briefly (few seconds), so polling the input sensor once a minute would likely miss these occurrences
so instead I'd like this integration to automatically 'catch' any value that is lower than the previously reported minimum or higher than the previously reported maximum

Is this 'update service' the way to go to accomplish what I've described above?
If so, how do I configure this in the integration? Does anyone have practical experience with a similar scenario?


Feature/watch owned resources

This is an alteration of the my other pr which includes some refactoring.
Changes Made:

Takes away the watch on the rhm-operator-secret
Adds ownership to the razeejob
Removes switch/case style since we are no longer accepting requests from different contexts

Remaining Items:

[x] Change github references to use github.com/redhat-marketplace

[ ] Test whether adding ownership to the secret after it's found works

[ ] Check that I'm returning reconcole.Result{},err in the correct places

[x] Issue with updating JobState

[x] Make sure that legacy crd values are set to null/accounted for properly

[ ] Check that the Spec field and Status field descriptors are present and correct after merge with develop

[x] Check that updates to: ClusterUUID, RazeeDashUrl, ChildRRS3FileName trigger an update tocorresponding Razee resources

We've moved this work to the /owned PR


Add Green Skull Revived from SpaceDock

This pull request was automatically generated by SpaceDock on behalf of jiraiyah, to add Green Skull Revived to CKAN.
Please direct questions about this pull request to jiraiyah.
Mod details:
name = /mod/2317/Green%20Skull%20Revived
author = jiraiyah
abstract = Green Skull Suits for Texture Replacer, Both for Vanilla and Futuristic Suits
license = MIT
Homepage = https://forum.kerbalspaceprogram.com/index.php?/topic/191298-green-skull-revived/
description =
Green Skull Suit was always my favorite suit texture in KSP, Unfortunately, the main developer of the textures didn't update them for a long time.
With addition of MKS, And a DLC that gives you new suit, this texture pack really needed some work. So, Here you have it guys, new Suit pack, in two different flavores for your kerbals, if you have the DLC, using texture replacer, you can switch to futuristic suit and have a glorious full set of suites forall MKS variations !!!

#rebuild


SwiftGodotKit: Provide an easy to use libgodot for embedding

Automate the builds of libgodot and provide those to users that do not want to use Swift inside Godot, but want to drive Godot from Swift.

Done


Ensure bad responses aren't cached

R: @philipwalton
Fixes #2737
This was a regression introduced in Workbox v6's modified precaching logic. This PR ensures that a bad response isn't saved to the cache before installation is halted.

After discussing offline, it's not possible for the PrecacheStrategy to run code once, at a point in time right before the install event happens. That's something that only the PrecacheController could do, and I want to ensure that PrecacheStrategy behaves properly even if it's not called by PrecacheController.

After discussing offline, it's not possible for the PrecacheStrategy to run code once, at a point in time right before the install event happens. That's something that only the PrecacheController could do, and I want to ensure that PrecacheStrategy behaves properly even if it's not called by PrecacheController.


[code][low prio] Comments regarding Injector unclear

In the injection-related classes (package com.csselect), Guice is mentioned in the comments. As far as I can see, Guice is not used, but an own solution. By the way, the five injection-related classes could also be moved to a separate package.

Fixed as of bab1ee4


Add Head/tail breaks method

This PR adds the Head/tail breaks method by Bin Jiang.
Here version 1.0 of the method is proposed.
Head/tail is well adapt to asymmetric dataset and a good alternative to Jenks. Especially with a big dataset because Head/tail is very fast.
See this notebook for more information: https://observablehq.com/@ateliercartographie/head-tail-breaks
References

Jiang, B. (2013). "Head/tail breaks: A new classification scheme for data with a heavy-tailed distribution", The Professional Geographer, 65 (3), 482 – 494. https://arxiv.org/abs/1209.2801v1
Jiang, B. (2019). "A recursive definition of goodness of space for bridging the concepts of space and place for sustainability". Sustainability, 11(15), 4091. https://arxiv.org/abs/1909.01073v1

Thanks Thomas. The method is available in statsbreaks@5.
And I added it to this notebook : https://observablehq.com/@neocartocnrs/hello-statsbreaks
If you have any ideas or other methods to suggest, don't hesitate.


Some of syntactically incorrect submissions can be compiled successfully

Thanks for the contribution of a new dataset for C language! I just downloaded the dataset and found that about 60 programs could be compiled successfully with "gcc -std=c90 -ansi -pedantic", like syntactically_incorrect_submissions/year-2/lab03/ex06/ex06-stu_049-sub_015.c. May I confirm how you compile the programs? My gcc version is 11.2. Thanks.

Hi,
We are currently using the following compilation flags:
gcc -Wall -Wextra -Werror -ansi -pedantic -lm ex06.c
The flag -Werror generates a compilation error regarding variable i, which is an unused variable.
Thanks for the question. I'm going to add the compilation flags to the README.


Run pylint in precommit

Pylint catches some errors that mypy does not e.g. missing super().__init__() call in __init__()

I investigated this a bit and I don't think it's worth doing:

It's going to slow down development time significantly in terms of developers spending time to fix lint errors, and in terms of the amount of time the linter takes to run (~tens of seconds)
There are thousands of existing errors across various categories:

abstract-method,
anomalous-backslash-in-string,
attribute-defined-outside-init,
bare-except,
broad-except,
cell-var-from-loop,
comparison-with-itself,
consider-iterating-dictionary,
consider-using-dict-items,
consider-using-enumerate,
consider-using-f-string,
consider-using-generator,
consider-using-in,
consider-using-with,
dangerous-default-value,
exec-used,
f-string-without-interpolation,
fixme,
function-redefined,
global-variable-not-assigned,
global-variable-undefined,
import-error,
import-outside-toplevel,
inconsistent-return-statements,
invalid-name,
line-too-long,
missing-class-docstring,
missing-function-docstring,
missing-module-docstring,
missing-timeout,
no-else-break,
no-else-continue,
no-else-raise,
no-else-return,
no-else-return,
no-member,
no-name-in-module,
non-ascii-name,
not-callable,
pointless-string-statement,
protected-access,
raise-missing-from,
redefined-argument-from-local,
redefined-builtin,
redefined-outer-name,
self-assigning-variable,
simplifiable-if-expression,
super-init-not-called,
super-with-arguments,
too-few-public-methods,
too-many-arguments,
too-many-boolean-expressions,
too-many-branches,
too-many-function-args,
too-many-instance-attributes,
too-many-lines,
too-many-locals,
too-many-statements,
undefined-loop-variable,
unexpected-keyword-arg,
ungrouped-imports,
unidiomatic-typecheck,
unnecessary-comprehension,
unnecessary-dunder-call,
unnecessary-lambda,
unnecessary-lambda-assignment,
unnecessary-pass,
unneeded-not,
unspecified-encoding,
unused-argument,
unused-import,
unused-variable,
use-a-generator,
use-dict-literal,
use-maxsplit-arg,
useless-object-inheritance,
useless-parent-delegation,
wrong-import-order,
wrong-import-position,

Ideally, mypy should just catch this: https://github.com/python/mypy/issues/11809


Allow middleman.rb as an alternative to config.rb.

This is for discussing renaming the base config for v4. Also added the ability for the Git project init to work on specific branches.

Please reopen this issue.
This is not solved and commit merged on 15 Aug 2014 doesn't contain anything related to this issue.


chore(deps): update dependency vue-cli-plugin-i18n to v2

This PR contains the following updates:

Package
Type
Update
Change

vue-cli-plugin-i18n
devDependencies
major
^1.0.0 -> ^2.0.0

Release Notes

intlify/vue-cli-plugin-i18n
v2.1.0
Compare Source
:zap: Improvement Features

#188 feat: support vue-i18n v9.1 (@kazupon)

Committers: 1

kazuya kawaguchi (@kazupon)

v2.0.3
Compare Source
:bug: Bug Fixes

#185 fix: cannot work legacy mode, when install plugin (@kazupon)

Committers: 1

kazuya kawaguchi (@kazupon)

v2.0.2
Compare Source
:bug: Bug Fixes

#183 fix issue #182 (@stif)

Committers: 1

Stif (@stif)

v2.0.1
Compare Source
:bug: Bug Fixes

#180 fix: suppress esm-bundler warning (@kazupon)

Committers: 1

kazuya kawaguchi (@kazupon)

v2.0.0
Compare Source
:zap: Improvement Features

#174 update docs (@kazupon)

:pencil: Documentation

#174 update docs (@kazupon)

Committers: 1

kazuya kawaguchi (@kazupon)

Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you check the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: @uportal/eyebrow-user-info/package-lock.json
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/eslint
npm ERR!   dev<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   @uportal/api-template-vue
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@">= 1.6.0 < 7.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/@vue/cli-plugin-eslint
npm ERR!   dev<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   @uportal/api-template-vue
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /tmp/renovate/cache/others/npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate/cache/others/npm/_logs/2021-05-19T13_55_42_638Z-debug.log

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you check the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: @uportal/eyebrow-user-info/package-lock.json
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/eslint
npm ERR!   dev<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   @uportal/api-template-vue
npm ERR<EMAIL_ADDRESS>npm ERR!     node_modules/@uportal/api-template-vue
npm ERR!       workspace @uportal/api-template-vue from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint@">= 1.6.0 < 7.0.0" from<EMAIL_ADDRESS>npm ERR! node_modules/@vue/cli-plugin-eslint
npm ERR!   dev<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   @uportal/api-template-vue
npm ERR<EMAIL_ADDRESS>npm ERR!     node_modules/@uportal/api-template-vue
npm ERR!       workspace @uportal/api-template-vue from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /tmp/renovate/cache/others/npm/eresolve-report.txt for a full report.

npm ERR!


When page size is not specified, add option to center first and last pages

When page size is not specified, add option to center first and last pages.
This would be best to add as an optional Bool parameter, since both behaviors are useful in different circumstances.
Current behavior:

Desired optional behavior:

This is actually achieved by using the .strictPageAlignment() view modifier.
That doesn't feel totally intuitive. Perhaps it can be renamed to something more idiomatic.

Renamed to .pageViewMarginsEnabled(_:).


WinGet download has unhelpful error text when download not supported.

Brief description of your issue
Not all apps in the store support download. When you download an app that does not support download you get the following error
Failed to retrieve Microsoft Store package download information
An unexpected error occurred while executing the command:
Failed to call SfsClient GetLatestAppDownloadInfo. ErrorCode:<PHONE_NUMBER> Message: 404 Not Found
0x8a150081 : Failed to get Microsoft Store package download information.
Steps to reproduce
winget download  9PJN3DBXFP9M
Expected behavior
I expect the client to offer a more useful message.
The package you requested does not support the download command.
The current error makes me think access to the store is broken and I may spend unneccesary cycles trying to figure out what is wrong.
[It should be noted that filtering store apps in search that do not support download might improve the experience]
Actual behavior
Failed to retrieve Microsoft Store package download information
An unexpected error occurred while executing the command:
Failed to call SfsClient GetLatestAppDownloadInfo. ErrorCode:<PHONE_NUMBER> Message: 404 Not Found
0x8a150081 : Failed to get Microsoft Store package download information.
Environment
Windows Package Manager (Preview) v1.9.1792-preview
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.26255.5000
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.24.1792.0

i'd like to see a proper reason here, and make it actionable, who should the admin contact to make this downloadable.  is it microsoft, is it the vendor, etc.


Implement Model Directory Setting

for #306
Let's implement model directory setting UI.

[x] implement container icon
[x] implement welcome UI
[x] implement model directory setting UI
[ ] research how to test (GH-336)
[ ] implement test

draft #297

We decided not to use model directory.
Instead, we will use vscode workspace.
I will close this issue and create a new one that uses vscode workspace.


problem when input trigger ‘@’ at middle of text

Just run into this components, I was developing something quite alike components as your's, and there's tough issue that when input the trigger word at the middle of text, it should be show the suggestionView,  I havent not run the demo, just viewed the code, i thought the component might be helpless at this case.
my solution is to diff the changed text every time to decide to show/off the suggestion view when onKeyPress listener receive the provided  trigger value
no offense,  just as a test case

If I understand you correctly, you don't want to show the suggestions panel, if the user type the trigger key in the middle of a word yea ? I can see how it could be a problem in some cases. On top of my head, what if i check the last character before the trigger key and only show the suggestions if its a space ? Probably will have to change the RegEx a bit too. Ill give it a go when i have free time. Meanwhile feel free to send a PR if you figure out a better solution.
PS: None taken mate ;) Cheers

@pannz I was curious how it handled the trigger in the middle of a word as well.  After looking at the code, it uses this regexp: \B@[a-z0-9_-]+|@ (when the trigger is @).  I think this is actually a bug. This will cause it to start suggesting when the trigger is in the middle of a word (e.g. when typing and email).
@harshq I think the regexp should be changed to \\B${this.props.trigger}[a-z0-9_-]+|\\B${this.props.trigger} so that it only triggers when the trigger is preceded by a word boundary.
You could add yet another prop like triggerWithinWord or something to alow triggering within a word.

@harshq Regarding your comment "what if i check the last character before the trigger key and only show the suggestions if its a space": This is unnecessary if you change the regexp to what I suggest above, as \B matches a non-word boundary, which means that any non-word char preceding the trigger will cause a match.
A note about using \B: This means that using a word character as the trigger, will actually cause the opposite to happen.  This means that if the trigger is something like e, it would only match when the e is preceded by a word char. Example He would match, but Hi e would not, because there was a space before it. No good way around this except switching it based on the trigger.
Code for switching the boundary type:
const boundary = !!this.props.trigger.match(/\w/) ? 'b' : 'B';
const pattern = new RegExp(`\\${boundary}${this.props.trigger}[a-z0-9_-]+|\\${boundary}${this.props.trigger}`, `gi`);

Hey @dhrrgn. Really appreciate your suggestions and the input. I couldn't find time to work on this yet. Will try to do it today itself. Cheers

I am still getting this issue. While putting @ in middle it's not working

is anybody looking into this?

If I understand you correctly, you don't want to show the suggestions panel, if the user type the trigger key in the middle of a word yea ? I can see how it could be a problem in some cases. On top of my head, what if i check the last character before the trigger key and only show the suggestions if its a space ? Probably will have to change the RegEx a bit too. Ill give it a go when i have free time. Meanwhile feel free to send a PR if you figure out a better solution.
PS: None taken mate ;) Cheers

when input the trigger word at the middle of text, it should be show the suggestionView

@harshq I think you misunderstood @pannz...he does want to show the suggestions panel if the user types the trigger key in the middle of a word/sentence.


Revert "Merge pull request #171 from FundingCircle/fix-deploy-alert-bug"

This reverts commit 16c18ab80255c8449d8d9a0c78e1d7c45541cea1, reversing
changes made to 53c5c1188b929127df359a731e4596670fb0ecb9.

LGTM, thanks!
I've created a FR against ENG-755.


Please use "GET" for /activate-account

Hi @elitan,
It seems you are changing activate account from GET to POST.
Let's discuss about it in related commit:
https://github.com/elitan/hasura-backend-plus/commit/cca72e8285c482529319ae6b94bb6e3a67fde528#diff-0d0de5d9ddbfa61dbbb85bd82bc412bb

My initial though was that the app needs to handle the front-end.

Send a verification email with the link to your own front-end (ex: app.example.com/verify?code=123321)

The /verify view grabs the code parameter and performs a request to HBP.

If OK, redirect. If not. notify user.

Or, we could changing the method to GET and add a envvar to allow redirection of the user.

we'll keep POST for now.


Non-Latin Alphabet Characters are displayed as "?"

When translating from English to a non-Latin based alphabet (IE Cyrillic) Letters are displayed as "???"

Thank you for bringing this to my attention. I'm not entirely sure if it's possible to translate then... :/
I believe this uses the RuneScape font, meaning that the glyphs must exist in the RuneScape font.
Are you able to write Cyrillic in RuneScape?

Thank you for bringing this to my attention. I'm not entirely sure if it's possible to translate then... :/
I believe this uses the RuneScape font, meaning that the glyphs must exist in the RuneScape font.
Are you able to write Cyrillic in RuneScape?

Not typically no. I've only seen it done in private servers, so I would assume it's something that would require work on the server backend rather than client side. Attempting to type Cyrillic characters inputs nothing at all, as if you haven't pressed any keys on your keyboard.
However, When translating languages such as Russian and Arabic via Google Translate, there is a transliterated section that is returned as well. As I'm not familiar with the usage of the Google Translate API, I don't actually know if this data is returned on a translation request. This is how it appears on the Google Translate website.

Assuming one understands the English pronunciation of the Latin alphabet, this would be understood by someone who is fluent in the language, and would be an acceptable workaround assuming it's possible, as this is how many Russians communicate in their native language when limited to a Latin alphabet. Another option would be to replace characters to ones that are accepted by the RuneScape Client, however this could be much more difficult to read.
Ex:
Привет, как Дела?
(Hello, how are you?)
becomes:
npuBeT, KaK 9eJIa
Overall, I realize this is a very niche issue and wouldn't have any impact on not only near 100% of the standard playerbase, but likely 99% of the playerbase that actively uses this translation tool, as there simply aren't enough speakers of Slavic languages that play RuneScape to warrant a fix.
I appreciate your time looking into the issue however :)
Thank you,
Спасибо)

Such a task just isn't feasible when there's too many languages that fall in this category and too many rules for character conversion.
For that reason, I am sorry, I'll be denying this.
However, I would accept a pull request with the logic to translate Russian characters to Latin characters before the characters are pushed onto the chat-line, at your time expense.

No problem at all, completely understood given the time spent vs reward.
Hopefully Jagex remedies these issues in the future by expanding the chat character set.


Forward api requests through to the rails server

The goal is to have BrowserSync automatically reload the page whenever assets change.
Originally I tried proxying directly with BrowserSync -> http://www.browsersync.io/docs/options/#option-proxy
This forwarded ALL requests to the rails server. This won't work because the files rails serves in /public are static files. Once they have been generated with gulp build they won't be updated until we run gulp build again.
I think BrowserSync files will need to be served from Express.
This change proxys all api requests from the express app to the rails server.
You can run gulp serve-dev and run the rails server and see your assets update automatically.
I think eventually we'll want to get BrowserSync to work directly in rails. I think this will be fairly involved. Possibly this gem will be helpful.

:+1: :+1:


Delete link replies if no embed generated

Currently apollo blindly replies to e.g. instagram links, but sometimes they are search or account links with no embed, so it's a wasted message.
Either

Improve the detection to avoid these cases
or delete the embed if no embed is actually generated by the 2nd one (or the original message has a better embed)

I imagine a fair bit of this can be dealt with using regex then use the second point as a fallback.
Also e.g. in the case of Twitter links, the Twitter embed, even when it is sometimes working, is worse than the fxtwitter alternative e.g. when there is a video attached to the tweet. ie worth considering on a platform by platform basis.


Proxy setting overrides for development

Prerequisites

[x] I am running the latest version. (up upgrade)
[x] I searched to see if the issue already exists.
[ ] I inspected the verbose debug output with the -v, --verbose flag.
[ ] Are you an Up Pro subscriber? - soon!  getting the app ported from sam first.

Description
The proxy max timeout of 25 seconds does not allow enough time to debug.  need to be able to turn it off completely for local development environment.  Sometimes step through debugging can take a few minutes.
Love Up?
YES!!!

ahhh good point :D, they should at very least be overridable in dev, I like defaults matching prod as much as possible but definitely a bit odd to enforce those in dev where we don't have any restrictions


Searchable Menu Items

It is near impossible to recall where a certain menu item in complex programs which have many sub-menus. Ideally they should all be searchable within the system. Some application have started to implement it but it won't be actively used by all since many won't know of it's existence.
Here's how it is on mac:

You can search for anything and it shows you where it is. It doesn't have to be rigid search it can guess some parts. It also shows you if there are any assigned shortcuts to it.

First thing that went through my head when I read this was "yes!".  I'm wondering if there could be a way to inject this into the top of every menu in the system.  Definitely a great idea to consider how it could be implemented.

I short command like ctrl + S to get the search up and then type for application to go to that or open it.
and also find files and location of that file is good to have.   other idees shuld be like  Type controllpanel and get a list of all items in it.

this would be cool

@mullcom prob not CTRL S..... .Mac uses Cmd ? and that makes sense for all help related stuff.

I'm going to merge this in with #129.  I Think they go together like peanut butter and jelly.  Plus you can't do this without #129

Not really. This also helps find where menu is. On windows you need to manually go through all sub menus to find something. That is one of the best parts of this. But whatevs 🤷♂ I don’t use windows.


Volume and symbolic links in 1.6.0-rc2

<mylife>
I accidentally discover through docker-compose trying to give access to /var/run/docker.sock from inside a container
</mylife>
Environment
Docker is running on Ubuntu 14.04 using the default aufs storage driver.
The goal is to create a volume in a directory which is actually a symbolic link. I use the /var/run directory which is a symlink to /run in Ubuntu 14.04
The test command will be:
docker run --rm -ti --volume /var/run/gordon ubuntu /bin/bash

If /var/run/gordon does not exist on the host, the command is working find on both 1.5.0 and 1.6.0-rc2.
Now if I create a file on the host:
sudo touch /var/run/gordon
docker run --rm -ti --volume /var/run/gordon ubuntu /bin/bash

In 1.5.0 everything is going smoothly and a /var/run/gordon directory is created inside the container.
In 1.6.0-rc2, the container's creation is failing with the following error message:
FATA[0000] Error response from daemon: file exists at %!s(MISSING), can't create volume there

The issue does not happen if I'm using --volume /run/gordon

@ggtools  What cause this error is that /var/run is a  symlink to /run in ubuntu rootfs, when doing parseVolumeMountConfig( which will cause this error),  the container has not create a mount namespace  and /var/run in container's rootfs will link the host's /run, so the error happened. I trying to fix this.


Fix missing icon from music tool

Fix missing icon from music tool. Need to create a system that all other tools can used. Add selected-up buttons for all tool bar icons to the sprite sheet folder and toolbar should work after rebuilding the sb-sprite.lua file.

This has been fixed.


Home Page Development

@Srivarsan09
@harshakun
Prepare content for the home page in all 10 languages and also suggest any ideas for the development of home page

Here is the JSON file that consists of content for all languages. This file will be used in addition feature- Translating entire page into the desired language
languages.json
this issue can be closed as all the work related to this issue is done


Translate April 17 report into Korean

Hello @nextstrain/korean!
The situation report from 2020-04-17  is ready to be translated to Korean. Sorry it’s a little late this week. The report focuses on the USA. We do have a significant linguistic diversity here, but I’ll let you decide if you want to translate it. In general, I do think it’s worth understanding how the virus spreads in other regions of the world, but I’m not doing the hard work of translation.
Branch to translate on: sit-rep_ko
File to translate: https://github.com/nextstrain/translations/blob/sit-rep_ko/narratives/translations_ncov_sit-rep_ko_2020-04-17.md You can translate directly in this file, but please remember to push often as other people may be working on the translation!
Link to preview: https://nextstrain.org/community/narratives/nextstrain/translations@sit-rep_ko/ncov/sit-rep/ko/2020-04-17
Twitter post to translate:
“This week’s #COVID19 situation report covers the outbreak in the United States. It is now available in Korean. Thank you @, @, and @ for the rapid translation.”
Logistics
Please update the translations board as you work on the translation: https://github.com/orgs/nextstrain/projects/7
Please assign yourself to the translation if you’re working on it this week.
When a translation is ready for publication -- at minimum meaning two people have worked on it and both agree that it’s ready -- please create a pull request to merge to master and tag me and the issue in it!
Discussion board for your team is here: https://github.com/orgs/nextstrain/teams/korean
Standard rules for translation:
Note that the file to translate is in Markdown. In general, it is important not to change any formatting or links. (Although it is okay to update Wikipedia or CDC links to the appropriate language version.) Comments to help with translation are noted in comment symbols like <! -- Comment -->.
Please add your name under translators: with a tab, dash, and new line, formatted just like authors are. Please also add a link to your professional page (can use Twitter) under translatorLinks:.
Note: You may know of other great resources available in Korean; please don’t add them to the situation report. We need to keep content the same across all translations, so we can be confident in the accuracy of what we publish. Thanks for understanding.
At minimum, I require two sets of eyes on every translation; one of those people should have a background in phylogenetics. Although if you have more, that’s fine too.
Feel free to use a live, online editor like hackmd (sign in with GitHub) to translate together.
As always a hearty thank you! I am really enjoying working with you all, even if it’s just digitally. Take care!

Hi @nextstrain/korean @cassiawag ,
The first draft of the 04-17 report was updated. Your review will be much appreciated. Thank you!
Best,
TH

Made a minor revision. Also I edited two sentences from the last week's report. Hope it's merged together.

Translator's note: -주, -시, -산맥 등은 붙여 쓰는 것을 원칙으로 합니다.

Thanks all!

Thanks for the translation @minkyuxyz & @taehoonh. Is this ready to publish?
Also would someone mind translating the Twitter post above?

“This week’s #COVID19 situation report covers the outbreak in the United States. It is now available in Korean. Thank you @, @, and @ for the rapid translation.”
이번 주의 #코로나19 상황 보고서는 미국 내 유행을 다룹니다. 이제 한국어로도 제공됩니다. 신속한 번역을 해주신 @, @, @ 님께 감사의 말씀을 드립니다.

Published and tweeted: https://nextstrain.org/narratives/ncov/sit-rep/ko/2020-04-17
Thank you!


Add --trace to bgutil and implement it in the cassandra driver

http://docs.datastax.com/en/developer/python-driver/3.5.0/faq/#how-do-i-trace-a-request

Done in #123


Onboarding Software Template: Introduce a Golden Path template pattern for new teams and engineers

Feature Suggestion
To introduce a new common template spec type for onboarding use cases. Today, by default Backstage supports 3 common values for spec.type: service, website and library and i am suggesting we introduce a new type which is already an optional label:  namespace
When the namespace is used as a spec.type for the Template kind, there would be a default rule to auto-populate the storePath to a common project or org space where onboarding requests are staged.
Use Case:
Teams who do not have a namespace today typically have to go through an approval process that more than likely entails submitting an IAM request through another system. My goal was to solve this problem with Backstage by introducing an "Onboarding Template" where teams wouldn't have to go to another system, wait days to get approved, then wait for the infrastructure team to manually run there ansible scripts that actually get them onboarded but simply fill out an onboarding template that will land in a "common" project/org where those ansible scripts get staged, a post-hook is put in place to create a branch called "onboarding-approval" followed by a PR which if approved will be merged where the corresponding ansible scripts are fired to get the team onboarded.
Here is a diagram i put together that shows the end to end flow:

This idea was inspired by a great article i read on a cookiecutter ansible kubernetes project

This is actually a super interesting use case for the scaffolder and it relates I think, very closely with our Golden Path templates. A new developer joins the company, and we want to give them a template which can scaffolder them a repo, and create them k8s namespaces, and gcp projects or whatever to get them setup and introduced to the dev stack and ecosystem. I know that this use case is not that, just had an interesting idea that maybe the golden path stuff could do something similar.
I'm also thinking however, that a lot of what you're trying to do here, could be solved with the new schema format for v2 scaffolder. The ticket is here: https://github.com/backstage/backstage/issues/3745 and although there's not so much in it it's based loosely off of this rfc #2771.
We're moving away from the spec.type part in the yaml, and the categorisation will probably fall upon labels or something like that instead for the frontend.
We're due to start the new schema stuff in the next week or so, and I'm thinking that there's a few ways to solve this feature request. We're going to start moving the steps into the template definition, so that each template you can configure what it will do and what actions it will run. Think something similar to github actions. You'll be able to configure the value that the publisher (or whatever we call it moving forward) has as the storePath.
Another solution is that we would by default provide a storePath component which would be a dropdown which could authenticate as the current user and see where this user is allowed to create repositories. once we've built this, I think it would be pretty easy to also make this configurable, and then you could choose to not even render anything on screen and autocompute the value from the template itself.
I think that the schema approach should work for you, so watch this space ⭐

This is actually a super interesting use case for the scaffolder and it relates I think, very closely with our Golden Path templates. A new developer joins the company, and we want to give them a template which can scaffolder them a repo, and create them k8s namespaces, and gcp projects or whatever to get them setup and introduced to the dev stack and ecosystem. I know that this use case is not that, just had an interesting idea that maybe the golden path stuff could do something similar.
I'm also thinking however, that a lot of what you're trying to do here, could be solved with the new schema format for v2 scaffolder. The ticket is here: https://github.com/backstage/backstage/issues/3745 and although there's not so much in it it's based loosely off of this rfc #2771.
We're moving away from the spec.type part in the yaml, and the categorisation will probably fall upon labels or something like that instead for the frontend.
We're due to start the new schema stuff in the next week or so, and I'm thinking that there's a few ways to solve this feature request. We're going to start moving the steps into the template definition, so that each template you can configure what it will do and what actions it will run. Think something similar to github actions. You'll be able to configure the value that the publisher (or whatever we call it moving forward) has as the storePath.
Another solution is that we would by default provide a storePath component which would be a dropdown which could authenticate as the current user and see where this user is allowed to create repositories. once we've built this, I think it would be pretty easy to also make this configurable, and then you could choose to not even render anything on screen and autocompute the value from the template itself.
I think that the schema approach should work for you, so watch this space ⭐

Thanks for the detailed reply! The drop down approach is 100% the way we should be going but with this use case where I need to be able to drive the destination for onboarding... there should be flexibility where I can lockdown the storePath to a specific
destination given I may have a staging project or org that has unique post-hooks in play that drive the approval of a PR. Just wanted to bring this up given we are in the middle of v2 😀

Thanks for the detailed reply! The drop down approach is 100% the way we should be going but with this use case where I need to be able to drive the destination for onboarding... there should be flexibility where I can lockdown the storePath to a specific
destination given I may have a staging project or org that has unique post-hooks in play that drive the approval of a PR. Just wanted to bring this up given we are in the middle of v2 😀

@benjdlambert Are there plans to provide the ability to pull in different Kinds?
Example:
Following Template is used to create a namespace
apiVersion: backstage.io/v1alpha1
kind: Template
metadata:
  name: kubernetes-onboarding
  title: Kubernetes Onboarding
  description: Creates a project namespace in Kubernetes
  tags:
    - onboarding
spec:
  owner: Team-A
  profile:
    displayName: Team-A
    email<EMAIL_ADDRESS>  system: PaaS
  lifecycle: experimental
  templater: cookiecutter
  type: namespace
  path: "."
  schema:
    required:
      - role_name
      - project_name
      - project_description
    properties:
      role_name:
        title: Team Name
        type: string
        description: Team Name
      project_name:
        title: Project Name
        type: string
        description: Project namespace name that best describes your project
      project_description:
        title: Project Description
        type: string
        description: Short Description of your project

When this template is used by an engineer, a Resource Kind is registered to register the namespace:
apiVersion: backstage.io/v1alpha1
kind: Resource
metadata:
  name: new-team-namespace
  namespace: new-team-namespace
  description: Team A Namespace
  tags:
    - nodejs
  labels:
    channel: #team-a-slack-channel
  annotations:
    backstage.io/kubernetes-id: {{cookiecutter.project_name | jsonify}}
    backstage.io/kubernetes-label-selector: namespace=new-team-namespace
spec:
  type: namespace
  lifecycle: experimental
  owner: Team-A
  system:  System-A

Now i have another template to create a react app that i want to map to that new-team-namespace i just created by providing a drop down in this template of all available namespaces, is that in scope?

@benjdlambert Are there plans to provide the ability to pull in different Kinds?
Example:
Following Template is used to create a namespace
apiVersion: backstage.io/v1alpha1
kind: Template
metadata:
  name: kubernetes-onboarding
  title: Kubernetes Onboarding
  description: Creates a project namespace in Kubernetes
  tags:
    - onboarding
spec:
  owner: Team-A
  profile:
    displayName: Team-A
    email<EMAIL_ADDRESS>  system: PaaS
  lifecycle: experimental
  templater: cookiecutter
  type: namespace
  path: "."
  schema:
    required:
      - role_name
      - project_name
      - project_description
    properties:
      role_name:
        title: Team Name
        type: string
        description: Team Name
      project_name:
        title: Project Name
        type: string
        description: Project namespace name that best describes your project
      project_description:
        title: Project Description
        type: string
        description: Short Description of your project

When this template is used by an engineer, a Resource Kind is registered to register the namespace:
apiVersion: backstage.io/v1alpha1
kind: Resource
metadata:
  name: new-team-namespace
  namespace: new-team-namespace
  description: Team A Namespace
  tags:
    - nodejs
  labels:
    channel: #team-a-slack-channel
  annotations:
    backstage.io/kubernetes-id: {{cookiecutter.project_name | jsonify}}
    backstage.io/kubernetes-label-selector: namespace=new-team-namespace
spec:
  type: namespace
  lifecycle: experimental
  owner: Team-A
  system:  System-A

Now i have another template to create a react app that i want to map to that new-team-namespace i just created by providing a drop down in this template of all available namespaces, is that in scope?

So as mentioned before, the type field will be going away, and won't be respected. Templates will start to look like yaml which defines different steps. If you want to create these namespaces, you'd have to write the function to handle these creations. I think to solve your namespace enum, you could create your own component which is rendered in the form and can be invoked by the schema. And this component could call out to your service which lists the namespace in order to get the values for the dropdown. I'll be able to give you a better idea of implementation after we've added the support for the new template schema in the next week or so :+1 hope this helps


frontmatter tests not needed anymore

looks like frontmatter tests in tests folder are not used for ~5 years. they are also not needed anymore since the migration to Jekyll 4 in https://github.com/docker/docker.github.io/pull/14685 which are now handled natively when pages are built. see https://github.com/docker/docker.github.io/pull/14685#issuecomment-1120810195. it also allows us to get rid of the Git modules.
Signed-off-by: CrazyMax<EMAIL_ADDRESS>

@usha-mandya @thaJeztah If some people have issues to remove the git submodules locally after rebasing with the changes, they can follow this guide: https://gist.github.com/myusuf3/7f645819ded92bda6677


init with terraform gitlab repo

summary
the nebulous repo includes terraform iac that should be made available in the gitlab server on init.
proposal
during the init process of the nebulous container execution, some terraform code is executed to provision the intro environment from a terraform directory in the nebulous repo. that very directory should be automatically uploaded to the private gitlab server during the setup process. this would allow for a very straightforward path to have automated source driven iac.
having the iac repo ready in turnkey fashion like that would allow for very low barrier of entry demo space for videos and tutorials.
details
when running nebulous, the /terraform directory:
https://github.com/kubefirst/nebulous/tree/master/terraform
gets copied into the container at location /terraform as shown here
https://github.com/kubefirst/nebulous/blob/master/Dockerfile#L4
we want to add a new terraform git repository to the new gitlab server as part of the initialization process.
questions
we currently code against the api
https://github.com/kubefirst/nebulous/blob/master/scripts/nebulous/init.sh#L166-L168
it might be more valuable to our open source users to establish a gitlab repo in terraform so they can manage repos as iac if they so choose.
terraform code would look like this
https://registry.terraform.io/providers/gitlabhq/gitlab/latest/docs/resources/group

In addition to the terraform repo we could add the metaphor repository to the gitlab server with terraform
https://registry.terraform.io/providers/gitlabhq/gitlab/latest/docs/resources/project#import_url
I haven't taken this for a spin before but feel like if we can import the two directly from our kubefirst github it would be worth it

this has been implemented with the nebulous 1.4 release


Future Feature Request:  Advanced query.

We've discussed many times that we want the query system to be self-explanitory.
However, many geekish users will want to be able to do more complex queries than are possible with the query screen as it is currently designed.
For example, What if I want to see stars that have polity "Klingon" OR "Romulan" AND have space-born military assets?  That requires the ability to do a more advanced query. Given the names of the data fields, the system should be able to accept a request like:
SELECT stars WHERE temperature > 6000 AND radius < 1.5 AND (polity = 'Klingon' OR polity = 'Romulen')
I know not everyone will be able to use it freely, but the geekish ones will want it despiritely.  I'm not even requesting it for version 1.0, but it ought to be in our future ideas list.

I did some research over the weekend and this is simpler than I thought.
I found a SQL validation utility that I can integrate to ensure that a single line SQL statement is properly formatted.
I can add an aide memoire facility for users to see the data dictionary of the database attributes they could query on.
I could provide a mechanism to allow users to see if the query returned data and then chose to plot of view it in tabular form.
BUT,...  all I would do is validate the query and return either results or tell the user why they query is invalid. Only SELECT, no other command.
Probably no more than a few days effort.

Ok, I added this feature.
You select the dataset and enter the where part as a boolean expression. Part of the request is to is to select whether you want to plot or view the data in a table.
There are validation checks for legal SQL, checks if you don't select certain required elements and where it warns you if you are selecting all the data


No module named 'sklearn.ensemble.forest' in scikit-learn 1.4.1

Calling rfpimp.plot_corr_heatmap() errors out with:
File <redacted>/python3.12/site-packages/rfpimp.py:15
     13 from sklearn.ensemble import RandomForestClassifier
     14 from sklearn.ensemble import RandomForestRegressor
---> 15 from sklearn.ensemble.forest import _generate_unsampled_indices
     16 from sklearn.ensemble import forest
     17 from sklearn.model_selection import cross_val_score

ModuleNotFoundError: No module named 'sklearn.ensemble.forest'

rfpimp version is 1.3.2 installed with conda from conda-forge

Never mind. This was addressed in one of the releases after 1.3.2.


add timeout option to mesos checks

Add -t, --timeout option in case default 5 seconds is too short.

@ishabalin Can you also PR these against the new sensu-plugins-mesos repo?
Thanks

Done https://github.com/sensu-plugins/sensu-plugins-mesos/pull/1 Thanks!


[TS] Remove extra negotiates from common scenarios

Fixes https://github.com/aspnet/AspNetCore/issues/11160

@pranavkm I can't get the "correct" blazor.server.js file built locally...

@BrennanConroy seems like it worked?

Yeah, had to try it on my Mac.

/azp run all

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=227442

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=227443&view=logs

This comment was made automatically. If there is a problem contact<EMAIL_ADDRESS>I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2626

This comment was made automatically. If there is a problem contact<EMAIL_ADDRESS>I've triaged the above build. I've created/commented on the following issue(s)
https://github.com/aspnet/AspNetCore-Internal/issues/2181
https://github.com/aspnet/AspNetCore-Internal/issues/2577


Introduce in-profile locking

Introduce in-profile locking -Dlocker.in-profile
Change Locker BOM directory to locker/pom.xml (previously .locker/pom.xml)
Support for old Locker BOM location
Allow to switch from in-profile mode to locker-bom mode

@cescoffier would you give it a try before I release?
Have a look to the new readme: https://github.com/mvnpm/locker/tree/in-profile


Rewrite rule in the navsetting.json configuration file

Is it not the web.config file that has to be modifed?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9601316b-17ac-d019-5c84-8f7ebe32c288
Version Independent ID: 189101fa-bd2b-68d1-e0a7-2b53616345ad
Content: Web Client Configuration for Tenants - Business Central
Content Source: dev-itpro/administration/configure-web-server-to-accept-host-names-for-tenants.md
Service: dynamics365-business-central
GitHub Login: @jswymer
Microsoft Alias: solsen

Hello, yes, you are correct. It is the web.config file that must be modified. The article has been fixed and an update will be published soon. Thanks for the feedback!


#126 allow scale parameter in Vector Layer Icon Style config

Simple fix, to allow scale in Style Icon config.

Thanks for this. I'll merge now.


Attribute complex expression

Hello!
Sorry, maybe there is already answer somewhere, didn't know how to search for it.
In version 0.12 syntax it was possible to write attribute value like this:
title="{{value | filter}} {{anotherValue | filter2}}"
Is there a way to do the same in the new syntax?

Please ask questions in the forum : http://forum.vuejs.org
Depends on the context, but you can do something like :-
http://jsbin.com/mitivizife/edit?html,js,console,output

@Mat-Moo Sorry, you didn't get the case. Looks like my description is a bit off.
Thanks for the forum link, posted a topic there: http://forum.vuejs.org/topic/1948/attribute-complex-expression (the description in there is more detailed).

Updated, your original syntax is still good http://jsbin.com/rolobudeco/edit?html,output

Oh. Thanks! Thought the syntax was deprecated :)


alt! fails on the first case on IResult::Incomplete

Simple error for parsing AMD64 register name
named!(parse_name, alt!(
    recognize!(do_parse!(peek!(tag!(b"bpl")) >> a: tag!(b"bpl") >> (a))) |
    recognize!(do_parse!(peek!(tag!(b"bp")) >> a: tag!(b"bp") >> (a)))
));

For the input b"bp" this fails with IResult::Incomplete(Needed::Size(3)). this is coming from the peek! macro. Wouldn't it make sense to match the next alt! branch before reporting failure?
If not what would be the idiomatic way to parse these values... other then writing a re-cursive decent function?

If it went to the next branch, for the input "bpl" chunked as "bp" then "l", it would go through the second branch, then the next parser would get a "l" it wouldn't expect, for a valid input.
BTW, why do you do a recognize!(do_parse!(peek!(tag!(b"bpl")) >> a: tag!(b"bpl") >> (a)))? That's equivalent to tag!(b"bpl")

if it went to the next branch, for the input "bpl" chunked as "bp" then "l", it would go through the second branch, then the next parser would get a "l" it wouldn't expect, for a valid input.

I don't understand isn't b"bp l" a different string? or if b"bpl" is processed in chunks isn't that just explaining the core fault of the bug I'm posting?

BTW, why do you do a recognize!(do_parse!(peek!(tag!(b"bpl")) >> a: tag!(b"bpl") >> (a)))?

The Incomplete stuff is there to handle cases where you don't get the full data at once. So if the full data was bpl, but for various reasons (slow network packets, file reading buffer full), you only get bp, but once more data is accumulated, you get the full bpl, you want to have to correct result. And the correct result is recognizing bpl, not recognizing the second case bp then see a trailing l.
If you're in the case where you don't care about incomplete data, you can wrap a parser with complete!(), and it will transform IResult::Incomplete in IResult::Error.


I'd like to reuse some of the testing utilities in Finch

Description

There are some useful utilities in xclim conftests. Is there a way to make them available to other libraries (e.g. Finch) ?

The only way I could see that is if the tests were bundled with xclim. Currently, they aren't. I can see a few ways of doing this:

Fetch the file as part of the pre-install step for an image build (ie: wget from a raw github link)
Set finch to install the source file version of xclim (not the wheel) and locally copy the conftest file from the installed xclim location to where you want it to be.
Export xclim.testing to the xclim-testdata repo and it into an installable package (that either bundles the testing data or provides the wrapper to fetch the data.
Throw out the configurations and make an intake catalogue for better portability.

Lots of potential solutions from my perspective...

I'd like to propose including the tests inside the installation. This is what xarray does.
In a related note, xarray and xESMF use an extremely simple setup.py
#!/usr/bin/env python
from setuptools import setup

setup(use_scm_version={"fallback_version": "999"})

And all the information is in the setup.cfg. This is something we could look into as well.

Placing the tests inside the package will require us to move the folder (xclim/tests -> xclim/xclim/tests), and perform a handful of changes to support it (mostly managing what is visible to xclim and pytest). It's feasible but it would require a bit of refactoring. One other option could be to create a very small helperpacking that installs the tests. I've performed a similar thing for PAVICS before https://pypi.org/project/requests-magpie/.
For the second point I'm confused. The reason we have such a more traditional setup.py layout is because of the cookiecutter approach. I don't see what the gains are for performing that on xclim (beyond adding a setup.cfg to the MANIFEST.in). If we are open to modernizing the setup.py, I would propose that we migrate to pyproject.toml files, as managing dependencies, publishing to PyPI, setting configurations, etc. are all handled out-of-the-box with that.

Let's ignore the second point, sorry I introduced that, let's discuss this is in another issue.
Just moving tests inside of xclim sounds to me like the simplest solution, no ? What are the drawbacks ?

None, really. I took some time to think it over and it would make much more sense. Presently, the only way to test xclim is to collect the source files or to clone the git repo. We packaged it this way because of the large size of the test data.
Now that the test data has been moved out of the library, there really isn't much to stop us from packing the tests alongside the code in wheel format. It shouldn't take very long to do. Priority level?


Schema Descriptions

Hello guys, I'm trying to find a way to include schema descriptions (the ones that pop out in Graphiql)
I know the graphql-js way, but couldn't figure out how to do it in Apollo.
var PlanetType = new GraphQLObjectType({
  name: 'Planet',
  description: // <----------- this thing
`A large mass, planet or planetoid in the Star Wars Universe, at the time of
0 ABY.`,
  fields: () => { }
})

The GraphQL schema language doesn't support descriptions at the moment (only deprecation, via decorators), but you can do it via resolvers. Check out this test to see how it works: https://github.com/apollostack/graphql-tools/blob/00d01eba94e8dbd21973e71b3cfd4361fdd8961d/test/testSchemaGenerator.js#L389
If you want to set a description on a type (as opposed to a field), you can do that by adding a __description field on the type (in resolvers, not in the schema). I know it's not ideal, but it's a temporary solution until a description PR (https://github.com/graphql/graphql-js/pull/427) is merged in GraphQL.js

That doesn't seem bad, thanks!

Also, thank you so much for the lightning responses Jonas, you're awesome!

This was added in https://github.com/graphql/graphql-js/pull/464/
and now works as a # comment in the schema string:
https://github.com/apollostack/GitHunt-API/blob/master/api/schema.js#L9

same issue with @kirill-konshin ... didn't know it's designed by that or it's an issue.


Cannot read property 'forEach' of undefined

FYI the file I tried to upload was like 54 Mb

I'm seeing the same, with a file size of 60MB

I got this when uploading a stats file generated by a multi-compiler run of webpack.

I'm seeing this exact issue with a 12MB stats file generated from webpack 4.31.0.

Seeing this issue with a 25MB stats file generated from Webpack 4.

I'm also seeing this with a 60,8MB stats.json file

33.5Mb also doesnt work.

37.8MB also doesnt work


Removed the entry for Let's Validate API, as suggested by Issue #1370

Simply removed the entry for Let's Validate API from README.md, as it does appear the api is defunct.
The last update to their github page https://github.com/letsvalidate/api appears to have been 3 years ago and this issue https://github.com/letsvalidate/api/issues/14 open on their github shows the service is down and the api is not being maintained.

Thank you @Rolv-Apneseth


[table] Allowing to show the time grain in table view

Explicitely request to show the time grain in the table view as a checkbox

This prevents a change in behavior from a recent PR where groupby table views that used to not show time granularity may do it on the recent release.

LGTM


feat: adjust hashing and update messages

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Setup Codecov Action

This PR is part of #77
We start measuring our Test Coverage.
Goal for this PR is Test Coverage of 60%

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@27bc501). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head d97343c differs from pull request most recent head 91b9811. Consider uploading reports for the commit 91b9811 to get more accurate results

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage        ?   52.83%
=======================================
  Files           ?        1
  Lines           ?       53
  Branches        ?        0
=======================================
  Hits            ?       28
  Misses          ?       25
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Add new project Node-Performance-Dashboard

This PR contains the node performance dashboard. It is based on perfdash project to visualize test data of node performance tests.
The projects contains the following components:

Web server implemented in Golang based on Perfdash project;
Parser to extract tracing data from kubelet.log;
Webpages implemented in Javascript/html using AngularJS, ChartJS, and Angular Material.

This change is

@Random-Liu @dchen1107

Good comments from Dawn, LGTM to me otherwise (just reviewing the yaml files and makefile)

@coufon Can you please address the comments from Dawn? Then we can merge

@apelisse Thanks. I made the changes according to the comments. Let's wait for Dawn's LGTM

LGTM