Use auto-generated Bokeh API to provide help and ranges for bokeh style options

Now that Bokeh publishes an API specification, we should be able to use that to validate and document style option values, which would be a great help to the users.

I've been thinking about this a bit recently and I think I'd really like to go ahead with this, especially in the context of https://github.com/ioam/holoviews/pull/2354 and the recent addition of options. The main benefits of those PRs (apart from the simpler API) is that they complain early and loudly when an option is incorrect. Currently we only validate against the options but as this issue says, the bokeh API spec should actually make it reasonably easy to validate the values as well.
I'd therefore like to propose that plotting classes should be able to provide a validator interface (as a classmethod), which can be used by the options system to validate the supplied values. This would likely just take the form of a registry on each plot which maps options to the corresponding plot parameter or bokeh property spec and a classmethod that the value conforms to the specified parameter or property spec. Together with the .options method I believe this can hugely improve the user experience.

Sounds great.  As a user, I am desperate to have this!

I think this is a great idea though ideally we would have one system that would also work with matplotlib.

There might be a way to traverse matplotlib's help or docs to extract that information, but it's probably easiest to start with Bokeh given that we know it's available in a machine-readable form already, and we can add mpl later once the bokeh version gets settled.


Relay Node support.

Fixes #181
This finally makes it so that all objects are uniquely identified, regardless of type, and that Relay uses __id for that purpose instead of id.

👍


feat: Add option 'trace_root_spans' to instrumentation PG

Add option 'trace_root_spans' to instrumentation PG

@AS-AlStar can you please provide more context on the issue this PR is trying to solve?

I don't want spans to be created on their own. For example, when I make a request to the database in the console "User.last". I spied this option in the redis.
Check in 'rails c', when trace_root_spans: true:
User.last -  will created span
when trace_root_spans: false:
User.last -  don't will created span
but this code generate span:
tracer.in_span('operation-name') do |span|
  User.first
end

@AS-AlStar @fbogsany I think we should hold off on merging this right now - we discussed this in the SIG today and we feel that this could be accomplished in other ways without needing another config option. We also discussed how our documentation does not really make that obvious or clear, and we will provide examples shortly. 😄

@ahayworth do we have docs for this?

this should stay open i think

ergh, wrong pr, disregard


Lemons, limes, and oranges can now be mutated into each other

About the PR

You can now mutate all citrus into each other
Why / Balance

I think mutations are fun!
Also currently afaik mutations to other plants are only used to "progress" to make more specialised plants, which can be not the only use
Technical details

Media

Requirements

[X] I have read and am following the Pull Request and Changelog Guidelines.
[X] I have added media to this PR or it does not require an ingame showcase.

Changelog

:cl:

add: Citrus plants can now be mutated into each other.

Fail seems unrelated

lore-accurate citrus

Fun idea 👍
Thanks for your contribution!


More Pythonic way to use is not None instead of != None

x = [1, 2, 3]
y = [1, 2, 3]
print(x is y) # This will display false.
Therefore that's why in many cases "==" or "!=" operator is better.

Thank you so much, but as @Mideky-hub says, the != better for some cases.


PodSecurityPolicy order is not guaranteed

What would you like to be added:
A naming convention for PSPs that follows a lexicographic order for PSPs.
Why is this needed:
As of today, we apply default PSPs (namely gardener.priveleged and gardener.unprivileged) in addition to custom PSPs for every system-component. In some cases the policy order does not apply and  gardener.privileged might be chosen over the custom-defined PSP for the system-component (e.g., deployed by extensions), which can produce undesired results.

cc @mvladev as you were involved in analyzing an issue last week - WDYT?

In some cases the policy order does not apply and gardener.privileged might be chosen over the custom-defined PSP for the system-component (e.g., deployed by extensions), which can produce undesired results.

This happens because the PSP for that system component doesn't match the Pod without mutation and therefore the gardener.privileged is chosen as it does not mutate the Pod.
Ordering for PSP is:

no mutation happens.

if multiple chosen -> lexicographic ordering

mutation happens.

if multiple chosen -> lexicographic ordering

@mvladev AFIK mutation only happens if annotations are defined, or?  there could be a case where  other custom policies are applied that do not require pod mutation, which will result in gardener.privelged being chosen.

AFIK mutation only happens if annotations are defined, or?

Mutation happens always. See https://github.com/kubernetes/kubernetes/blob/92ea33efc509052b208e094390a363c5dbd21b7c/plugin/pkg/admission/security/podsecuritypolicy/admission.go#L258-L292
Here are all the fields which can be mutated in the Pod: https://github.com/kubernetes/kubernetes/blob/af0e1319c35fa143ef6dcb891d753099b6ac1e4b/pkg/security/podsecuritypolicy/provider.go#L64-L123

still if a custom-policy that requires no mutation is behind gardener.privleged in lexiographical order, garderner.priveleged will be chosen still, and thus is not guranteed, correct?

Yes, this is correct. Custom policies should be before that.

How do we proceed here? What can we do?

ping, any ideas/concrete plans?

/ping

The PSP API is deprecated in 1.21.
Should we keep this issue opened?

The PSP API is deprecated in 1.21.
Should we keep this issue opened?

Let's
/close
it for now as there is anyways no concrete planned follow-up action, and if they are being deprecated and removed anyways, there's probably little point in investing now.

Let's
/close
it for now as there is anyways no concrete planned follow-up action, and if they are being deprecated and removed anyways, there's probably little point in investing now.


Incorrect hour format when rendering a table in markdown or JSON for dateTime cells

It happens that a cell could not be correctly rendered correctly.
The value of cell equvalent to 2019-10-01 20:00:00 and set as a dateTime could be rendered  2019-10-01 08:00:00 at a few places.

Beta available at https://ci.appveyor.com/project/Seddryck/nbi/builds/27849532/artifacts or with 1.21.0-beta.193.


Yes!

👍


Move sharding-jdbc-spring and sharding-jdbc-orchestration-spring

Move sharding-jdbc-spring and sharding-jdbc-orchestration-spring to sharding-spring repository

Pull Request Test Coverage Report for Build 5927

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 71.908%

Totals

Change from base Build 5925:
-0.5%

Covered Lines:
9402

Relevant Lines:
13075

💛  - Coveralls


contributors.svg broken

Could someone refresh our contributors.svg? https://opencollective.com/react-three-fiber/contributors.svg I've been waiting for a week just to be sure, didn't wanna clog github issues because of an image, but it would be nice if it did show up. Thanks! :-)

It's finally refreshed.


Merging lsscafe into master

Hi @rnikutta,
Just opening this pull request so the changes to NB07 are merged into master. Could you please check?
Thanks!

Merging, thank you.


[BUG] Cleanup documentation

Description
Instructions on setting up environment are now fragmented.  The information is spreaded in

README.md
SETUP.md
reco_utils/READM.md

It is quite confusing even for someone experienced with this work.  Suggest to clean up these instructions and consolidate.
In which platform does it happen?
All.
How do we replicate the issue?
Expected behavior (i.e. solution)
Suggested Principles:

We should separate instructions for using the repo, vs developing for the repo.
For using the repo (especially for the first-time user), the instructions should be short and aim to enable user to get set up  in the shortest time. (this is the "fast lane").  Only include content/instructions that are mandatory.  We should target reading + following instructions in fast lane take no longer than 1 minute.
For developing for the repo, the instructions may have to be longer, more detailed and contains some debugging information (this is the "slow lane"). these instructions should be separate from the "fast lane".
If there are more complex (or rarer) usage instructions, consider putting it in slow lane.

Other Comments
Additionally, pip install followed by launching jupyter notebook does not seem to work (as notebooks are not installed by pip).

@laserprec @simonzhaoms since you are already reviewing the SETUP documentation, please see some notes from Tao yo might want to consider


updates for clarity

mainly typos and reworking a little language

Docs Build status updates of commit 46bdf44:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/msal-based-azure-cli.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add ids command line flag

Tested with
bin/firewall-controller --hosts-file ./hosts --enable-IDS=false
k apply -f deploy # in a local kind-cluster
k describe -n firewall firewall

No IDS-related warnings in Events any more.

can you please rebase to master which already includes https://github.com/metal-stack/firewall-controller/pull/44/commits/04cc943342e4d180eac3b5bde36ff51c01b8088a, is a bit confusing otherwise.


[5.8] Add disable callbacks 5.8

Adds the withoutCallbacks method to disable callbacks when using factories.
eg: factory(User::class)->withoutCallbacks()->create();
I know i copied the description.. don't know how to sell it better :)

I see a commit of Tetiana in your commits list so I suspect something went wrong there. Can you try again by branching off from the 5.8 branch?

Ah, I see you sent it in here as well: https://github.com/laravel/framework/pull/27528
You don't need to send in separate PRs. They'll get merged in the newer branches.


got permabanned

all my accounts got perma after probably 2 days of using it. Just a warning for all people dont use it

Hello, just checking out the issue. I'm just a regular player, but it seems like there was a ban wave going on for a while now. A couple of days at the very least. Can you share the information about the origin of your account. Was it a bought account of sorts or was it your personal  long-time used account

Hello, just checking out the issue. I'm just a regular player, but it seems like there was a ban wave going on for a while now. A couple of days at the very least. Can you share the information about the origin of your account. Was it a bought account of sorts or was it your personal long-time used account

my smurf and my main got banned. the smurf was bought. the main was played from 1 level to 197 level just by me. Both got banned, i did send tickets to riot so i will def say what was their response and what was the reason it got banned (either skinchanger or bought acc)

https://github.com/R3nzTheCodeGOD/R3nzSkin/issues/681

there is no ban

Riot did banwave for scripters and botted accounts prob you banned for this.

thanks guys, riot wont respond me but its probably cuz of the bought account. program is safe


[bug] .stream must return stream instance

In my code i heavily rely on streaming API. Even if you didn't implement query buffering yet, please return Stream instance.

https://github.com/ahlwong/dakota-cassandra/blob/c94c8b5971ce7f5be75edd3abcab3165ac62cd38/lib/index.js#L417
https://github.com/ahlwong/dakota-cassandra/blob/71954bc72bf771106a6b081880c8e4492b6956f9/lib/model.js#L1453

P. S. Awesome ODM! Best of all that i've been seen in NPM! Keep up the good work!

Here's what changed:

All streams returned by DakotaCassandra are now WrappedStreams.
You set event handlers via on(event, callback) where event is 'readable', 'end', 'error' just like on Cassandra's native stream object
WrappedStream's instance method .read now returns Model instances instead of Rows

Here's an example on how to use streams:
  var stream = User.stream()
  .on('readable', function () {
    //readable is emitted as soon a row is received and parsed
    var user;
    while (user = this.read()) {
      console.log(user instanceof User);
    }
  })
  .on('end', function () {
    //stream ended, there aren't any more rows
    console.log('stream ended');
  })
  .on('error', function (err) {
    //Something went wrong: err is a response error from Cassandra
    console.log('stream error');
    console.log(err);
  });


AndroidX compatibility

Planning to migrate my project to androidX. Will this cause any issues with this plugin?

Hi, latest version 0.5.0 contains AndroidX compatibility


Franka Gripper position

Hi, I was wondering if it is possible to obtain the franka gripper position from the RobotState topic (https://frankaemika.github.io/libfranka/structfranka_1_1RobotState.html), or from any other topics?
I have searched through the documentation and the closest I found was joint position (q), which was only the seven main joints. Any help is appreciated.
Thanks!

Closing this because I found the answer, it is in the franka_gripper/joint_states topic.
https://frankaemika.github.io/docs/franka_ros.html#franka-gripper


Loot/lootall with non-ASF 2FA might be broken

Hi,
A friend of mine have a problem with ASF. I can't reproduce the problem since I don't use bots with 2FA on a smartphone like he does (I'm using 2FA only on a master account and approve trade with my bot via emals), so I can't say for sure. He is using v<IP_ADDRESS> right now, but encountered it since update to 2.1.
SendOnFarmFinishing = True on all bots
Both SteamTradeToken and SteamMasterID is set on all bots, also SteamTradeToken is set on a master account.
He claims this setup worked for him before update to v2.1.
UPD: Log is pending. Will be added when a friend of mine will send it to me.

There is nothing in !loot that can fail due to not being 2FA-enabled. You're not reporting a bug, so don't use GitHub for that.

log1.txt
log2.txt


Any ideas to migrate Connexion to Quart base?

Description
Quart is a Python ASGI web microframework. It is intended to provide the easiest way to use asyncio functionality in a web context, especially with existing Flask apps. This is possible as the Quart API is a superset of the Flask API.
Expected behaviour
We can obtain async behaviour.
Actual behaviour
We have sync behaviour.
Additional info:
https://github.com/pgjones/quart

Hey @lovesuper
There's a related issue about trying to fix the aiohttp interface to work with existing tests. I believe the goal of this work was also to eventually add quart support: https://github.com/zalando/connexion/pull/828

+1 and +1 for doing Quart separately from aiohttp if possible.
Meanwhile, does connexion work well with aiohttp? I couldn't find much example and was facing a number of errors when trying to port a microservice and always thought it was me!

Meanwhile, does connexion work well with aiohttp? I couldn't find much example and was facing a number of errors when trying to port a microservice and always thought it was me!

By and large it works well. But you'll be digging into the source code at times to figure things out, because the documentation is sparse and oftentimes you can't tell if the docs are referring to something that only applies to Flask. It certainly feels like there is friction where Connexion has been adapted to an async model too, processing security headers is synchronous for example.

Third party ASGI frameworks are supported starting 3.0: https://github.com/spec-first/connexion/issues/1395


Fix errors with newer ESlint config.

Most of the changes come from the prefer-const rule being enabled. I removed overrides when they just repeated the airbnb configuration. Now the indent rule fails on many files in the demos directory. Since the code in there does some funky stuff, I decided to ignore all the Demo.jsx files.

Seems like a big chunk of this is for let -> const for which I left a message.
What are the funky stuff in Demo.jsx?`

ESLint does not understand the indentation in the Demo files with ternary operators on multiple lines and template strings. I give you the errors for reference:
/home/ludovico/projects/scratch/react-motion/demos/demo1-chat-heads/Demo.jsx
  30:13  error  Expected indentation of 10 space characters but found 12  indent
  31:13  error  Expected indentation of 10 space characters but found 12  indent
  32:11  error  Expected indentation of 8 space characters but found 10   indent

/home/ludovico/projects/scratch/react-motion/demos/demo5-spring-parameters-chooser/Demo.jsx
  101:19  error  Expected indentation of 16 space characters but found 18  indent
  102:19  error  Expected indentation of 16 space characters but found 18  indent
  103:17  error  Expected indentation of 14 space characters but found 16  indent

/home/ludovico/projects/scratch/react-motion/demos/demo6/Demo.jsx
  152:5  error  Expected indentation of 6 space characters but found 4  indent
  178:5  error  Expected indentation of 6 space characters but found 4  indent
  203:5  error  Expected indentation of 6 space characters but found 4  indent
  238:5  error  Expected indentation of 6 space characters but found 4  indent

/home/ludovico/projects/scratch/react-motion/demos/demo8-draggable-list/Demo.jsx
  78:17  error  Expected indentation of 14 space characters but found 16  indent
  79:17  error  Expected indentation of 14 space characters but found 16  indent
  80:17  error  Expected indentation of 14 space characters but found 16  indent
  81:15  error  Expected indentation of 12 space characters but found 14  indent
  83:17  error  Expected indentation of 14 space characters but found 16  indent
  84:17  error  Expected indentation of 14 space characters but found 16  indent
  85:17  error  Expected indentation of 14 space characters but found 16  indent
  86:15  error  Expected indentation of 12 space characters but found 14  indent

K I can fix them separately.

It might even be an ESLint regression.

It is just because new ESLint catches more errors. I had the same on my work projects. Those are legitimate warnings.

Oops, this got updated... Merging!


Refactor ACME account cache to use a dedicated 'account registry'

What this PR does / why we need it:
This is an attempt to clean up our old ACME client cache implementation, previously a part of pkg/acme. This creates pkg/acme/accounts.Registry, which is an interface that can be used to create and get ACME clients from the cache.
This PR does not change how we insert and remove clients from the cache, and this is currently still done in pkg/issuer/acme/setup.go. I am going to follow up with some work done to the 'issuer' controller(s) to have them properly Remove/Add clients in response to issuers being updated/deleted.
Special notes for your reviewer:
This is an attempt to fix part of #2561, which I believe could be caused by either:

Stale clients (i.e. passed some TTL)
Clients being available for accounts that aren't registered (i.e. being the order controller runs before others)

Release note:
NONE

/kind cleanup

/assign

/lgtm

/retest


DEV: Perform Py_DECREF on obj to avoid memory leak

Reference issue

Closes https://github.com/scipy/scipy/issues/16232
What does this implement/fix?

See, https://github.com/scipy/scipy/issues/16232#issuecomment-2527900151. Can't quote the whole comment (a little bit tricky).
I have performed Py_DECREF on obj. Tests seem to pass on my fork - https://github.com/czgdp1807/scipy/pull/11. Also regarding tests, get_tls_global is internal function so can't figure out Python tests. The maximum I could figure out is an assert check assert( Py_REFCNT((PyObject*) obj) == 1 );. I can add it to my PR if folks agree on it.
Additional information

cc: @rgommers @Snape3058

Looks correct according to my report.
This function returns a borrowed reference, and PyDict_SetItemString does not steal a reference to the last argument. Hence, the refcnt should be decreased before returning obj.
One more thing to the code that I think also needs attention is whether PyDict_SetItemString succeeds. If not, NULL should be returned instead of obj (e.g. the key is not hashable). It depends on the developer to determine whether they want to check that. But this only affects the return value, not the refcnt. Your added lines still work.
Besides, what does your comment This helps in avoiding in memory leak due to dangling reference of obj. mean?
We usually use the term dangling reference / pointer for use-after-free issues, it makes no sense to a memory leak problem.
Could you please make it more clear?
And, for the caller of get_tls_global doesn't steal reference to obj, I suggest using this function returns a borrowed reference instead. This makes the reasons more clear, as far as I think.

Thanks for the review @Snape3058. How about this - Py_DECREF is added because get_tls_global returns borrowed reference. This avoids memory leak of obj. Concise and clear?

LGTM. But I am not the developer of this project. The important thing is that the developers of this project can understand it.
You can ask some of them to review this patch.

This is ready from my end. @rgommers


Remove hard-coded ssl_multicert.config log reference

SSLCertificateConfig::reconfigure() had a couple messages that used a
hard-coded config name for SSL multicert. This filename, however, is
configurable per records.config. This change makes use of the name at runtime
per SSLConfig params variable rather than the hard-coded value.

[approve ci]

Cherry-picked to v9.0.x branch.


Added CV_CAP_PROP_SAR properties to videoio module

Hi,
There exist some videos with a SAR (storage aspect ratio) != 1:1, see below the ffprobe info of one of my video file:
Stream #0:0[0x8ad]: Video: mpeg2video (Main) ([2][0][0][0] / 0x0002), yuv420p, 720x576 [SAR 64:45 DAR 16:9], 25 fps, 25 tbr, 90k tbn, 50 tbc
FFMpeg or vlc can both play them with the good display aspect ratio (16/9), but not OpenCV, so when I load them, the videos are stretched, and I have to resize the grabbed frames.
Furthermore, there are not any functions available to know the SAR.
In this PR, I propose to add two new properties : CV_FFMPEG_CAP_PROP_SAR_NUM and CV_FFMPEG_CAP_PROP_SAR_DEN. These properties are the numerator and the denominator of the SAR.
Pierre

Looks good to me.
Could you please resolve merge conflict (something like git pull --rebase upstream master)

Try to use something like this:
# return to previous state
git checkout -B aspect-ratio 925e816176d19d47481f7d84e19d82df1025522a
# try to merge upstream changes, will receive message about conflict - it is OK
git pull --rebase git://github.com/Itseez/opencv master
# edit file videoio_c.h and after that stash them
git add modules/videoio/include/opencv2/videoio/videoio_c.h
# move forward
git rebase --continue
# force push changes on GitHub
git push -f <your github remote> aspect-ratio

Thanks for the commands !

You are welcome!
:+1:


Add release notes for 0.12.2

See https://github.com/submariner-io/releases/issues/363
This should show the PRs merged to release-0.12 since 0.12.1: https://github.com/pulls?q=is%3Apr+user%3Asubmariner-io+label%3Abackport-handled+created%3A>2022-04-24+

@Jaanki do you want to take this one?


coverage/coveralls appears to be stuck on "Expected - Waiting for status to be reported"

Coverage itself is working fine, but on PRs like https://github.com/axondeepseg/axondeepseg/pull/602, it currently appears like this:

I think to fix this issue, it's simply a matter of going into the repo settings and changing the branch protection rules to remove the old coverage CI check from the requirements:

And add the new coverage CI check to the requirements:

I've made this change just now (just to save other folks the bother), but I opened this issue primarily to document the steps I took so it could be reverted if need be.

Very odd indeed! 🤔


SEGV on CacheDisk destructor

[ 00 ] libpthread-2.17.so waitpid
[ 01 ] traffic_server crash_logger_invoke(int, siginfo_t*, void*) ( Crash.cc:165 )
[ 02 ] libpthread-2.17.so
[ 03 ] traffic_server CacheDisk::~CacheDisk() ( List.h:293 )
[ 04 ] traffic_server CacheDisk::~CacheDisk() ( CacheDisk.cc:112 )
[ 05 ] traffic_server CacheProcessor::diskInitialized() ( Cache.cc:767 )
[ 06 ] traffic_server CacheDisk::openStart(int, void*) ( CacheDisk.cc:213 )
[ 07 ] traffic_server AIOCallbackInternal::io_complete(int, void*) ( eventsystem/I_Continuation.h:160 )
[ 08 ] traffic_server EThread::process_event(Event*, int) ( I_Continuation.h:160 )
[ 09 ] traffic_server EThread::process_queue(Queue<Event, Event::Link_link>*, int*, int*) ( UnixEThread.cc:170 )
[ 10 ] traffic_server EThread::execute_regular() ( UnixEThread.cc:230 )
[ 11 ] traffic_server spawn_thread_internal(void*) ( Thread.cc:85 )
[ 12 ] libpthread-2.17.so start_thread

Affected version: 8.1.2

It looks like ATS found a bad disk and tried to delete it, but got SEGV on disk_vols[i]->dpb_queue.pop().
https://github.com/apache/trafficserver/blob/cbb20d4fe05e1598943590a1a65fbb2d3f5015d2/iocore/cache/Cache.cc#L764-L767
https://github.com/apache/trafficserver/blob/cbb20d4fe05e1598943590a1a65fbb2d3f5015d2/iocore/cache/CacheDisk.cc#L117

About 6 months ago, I spent many iterations trying to fix our crash on bad disk problem.  What version are you running?  I thought I had pushed those fixes to master.

The version we got this crash is almost the same as the current head of the 8.1.x branch.

Take a look at PR #7218.  I thought I had to make multiple attempts here, but this is the only relevant looking PR I see on master.  I'll review my internal work and make sure it all made to to ASF.  It could be that I delayed making an ASF PR until we got it all under control.

Take a look at PR #7218.  I thought I had to make multiple attempts here, but this is the only relevant looking PR I see on master.  I'll review my internal work and make sure it all made to to ASF.  It could be that I delayed making an ASF PR until we got it all under control.


WifiLock

Is your feature request related to a problem? Please describe.
When using this app on a tablet (or phone) on which the screen switch off after a certain delay, the WiFi is also switch off. So it's not possible to contact the local server anymore :-(
Describe the solution you'd like
I think it's possible to use the WiFiLock method in the code to keep WiFi on even when the screen turn off.

Hello!
The app already uses WiFiLock, but it doesn't work on Android versions since 14 and on some vendor-customized firmwares. Please see https://github.com/capcom6/android-sms-gateway/issues/90; it might be related to your case.
Also, please check for any power-saving options on your phone, as they can vary by vendor.
The recommended solution is to use a Cloud/Private server.

Hi capcom6,
Thank you for your answer. You're right, my problem did'nt come from sms-gateway but from my wifi repeater which reject clients sometime. After changing it all is ok. Thank you very much again and sorry to have bothered you. And thanks also for your work on sms-gateway.


Bump clang to 18

Temporary WAR for this change in JAX build system: https://github.com/jax-ml/jax/pull/23787/

@olupton If it makes sense, please merge it before nightly run in the observance of JAX team to fix the issue with hardcoded clang version.


Example link not working

The example link in the info tooltip on the new Event properties object is leading to a 404 page

Hi @janaengelhardt.  Thanks for choosing amplitude.
Sorry for the inconvenience.  Fix the issue in this pr.
This should be the example in our doc.


[BUG] Unable to run queries with DataGrip

What is the bug?
After setting up the JDBC driver in DataGrip I get inconsistent errors. See reproduction steps for details.
How can one reproduce the bug?
Steps to reproduce the behavior:

Download the JDBC driver here:

https://github.com/opensearch-project/sql-jdbc

Open your IDE and open the "Database" section
Click "+" > "Driver"
Set the name to "OpenSearch"
On the "Driver Files" section select the JAR you just downloaded
In the class dropdown select org.opensearch.jdbc.Driver
Click "Ok"
Click "+" > "Data source" > "OpenSearch"
In the "General" tab:

Set "Authentication" to "No auth"
Hostname to the OS cluster address

In the "Advanced" tab set the following key/value pairs:

auth: AWS_SIGV4
region: The region the cluster is on

Test connection
Create a test index and put data in it

This is where the behaviors begin:
1234:hadesrodr...s-east-1> select * from hosts_rodrigof_metadata_hosts_2023-04-11
[2023-04-13 11:02:30] java.sql.SQLException
1234:hadesrodr...s-east-1> select * from hosts_rodrigof_metadata_hosts
[2023-04-13 11:08:29] java.sql.SQLException
1234:hadesrodr...s-east-1> select * from "hosts_rodrigof_metadata_hosts"
[2023-04-13 11:08:37] Error executing query
[2023-04-13 11:08:37] HTTP Code: 400. Message: Bad Request. Raw response received: {
[2023-04-13 11:08:37] "error": {
[2023-04-13 11:08:37] "reason": "Error occurred in OpenSearch engine: no such index [\"hosts_rodrigof_metadata_hosts\"]",
[2023-04-13 11:08:37] "details": "org.opensearch.index.IndexNotFoundException: no such index [\"hosts_rodrigof_metadata_hosts\"]\nFor more details, please send request for Json format to see the raw response from OpenSearch engine.",
[2023-04-13 11:08:37] "type": "IndexNotFoundException"
[2023-04-13 11:08:37] },
[2023-04-13 11:08:37] "status": 404
[2023-04-13 11:08:37] }
1234:hadesrodr...s-east-1> select * from "hosts_rodrigof_metadata_hosts_2023-04-11"
[2023-04-13 11:09:05] Error executing query
[2023-04-13 11:09:05] HTTP Code: 400. Message: Bad Request. Raw response received: {
[2023-04-13 11:09:05] "error": {
[2023-04-13 11:09:05] "reason": "Error occurred in OpenSearch engine: no such index [\"hosts_rodrigof_metadata_hosts_2023-04-11\"]",
[2023-04-13 11:09:05] "details": "org.opensearch.index.IndexNotFoundException: no such index [\"hosts_rodrigof_metadata_hosts_2023-04-11\"]\nFor more details, please send request for Json format to see the raw response from OpenSearch engine.",
[2023-04-13 11:09:05] "type": "IndexNotFoundException"
[2023-04-13 11:09:05] },
[2023-04-13 11:09:05] "status": 404
[2023-04-13 11:09:05] }

Where hosts_rodrigof_metadata_hosts_2023-04-11 is an index and hosts_rodrigof_metadata_hosts is an alias. However, using the Elasticsearch plugin, I can successfully run queries via HTTP:
POST /_plugins/_sql/
{
  "query": "select count(*) from hosts_rodrigof_metadata_hosts"
}

Returns:
{
  "schema": [
    {
      "name": "count(*)",
      "type": "integer"
    }
  ],
  "datarows": [
    [
      12237733
    ]
  ],
  "total": 1,
  "size": 1,
  "status": 200
}

Something I have noticed is that the use of * doesn't work, for example:
select * from my_index
Fails with  java.sql.SQLException, but:
select col1 from my_index
Does work.
What is the expected behavior?
Queries should run as expected when using the JDBC driver.
What is your host/environment?

OS: AWS
Version 2.3
Plugins: sql

I have 6 clusters, 3 in us-west-2 and 3 in us-east-1, I have upgraded them all to 2.5. While the connection is successful, the above errors still happen. I also notices that the driver reports the version of the cluster as OS 7.10

@ksco92,
I guess version 7.10 is returned, because compatibility mode is on. See pic below from AWS console, from create new cluster menu:

I can't reproduce your error, but I keep playing with DataGrip
There are my Datasource settings:

Driver settings:

Note: I have to set env vars required for AWS authentication prior to running DataGrip:

Please, check your set up to ensure that nothing missed.

Just discovered that you're using JDBC driver v.1.0. Please, download and try most recent one from maven.

Hi! Can you please guide me through how you figured this out? I downloaded the driver specifically listed here:
https://opensearch.org/artifacts
And the AWS docs here say that driver version <IP_ADDRESS> goes with OS 2.5:
https://docs.aws.amazon.com/opensearch-service/latest/developerguide/sql-support.html
It even links to download that version directly:
https://artifacts.opensearch.org/opensearch-clients/jdbc/opensearch-sql-jdbc-<IP_ADDRESS>.jar
Does this mean that the version in maven is different and that docs should be corrected?

Unfortunately, artifacts page still contains older version of JDBC. I'll update it soon.
Sorry about that.
Maven stores most recent version.

I still to be having something weird going on:

Am I missing something embarrassing here?

I also do have valid creds.

Driver file on Maven has no embedded dependencies (no shadow jar) and it is supposed that application would download them automatically.
opensearch-sql-jdbc-<IP_ADDRESS>.zip
Try renaming this file to jar and using it.
I didn't noticed where I got my jar from, but it has embedded all dependencies in (shadow jar).

Investigation outcomes:
@
JDBC driver 1.2, OpenSearch 2.5
@
DataGrid enforces driver to use fetchSize > 0

@
All requests to SQL plugin are paginated queries
@
Queries fall back to the legacy engine in the plugin
@
Legacy engine doesn't support queries without FROM clause. Pagination in general has also limited support.
Verdict:
Support more pagination in SQL plugin -- work in progress, target: 2.8
Fix in JDBC driver to disallow overwriting fetchSize if given
Documentation update

Hi,  just tried latest version opensearch-sql-jdbc-shadow-<IP_ADDRESS>.jar and got an error
 org.opensearch.jdbc.StructImpl
when try select nested object


Admin :: Category edit

Hello
I using a new version and is a problem with editing product category.
When i edit a description product category and save, description enter to the field for icon.
http://postimg.org/image/c1gfj2v9l/
Next,
When i try to set up icon, i cant press OK i dont see this button and i cant scroll the web
http://postimg.org/image/bitnz9tjx/
and the last:
I dont see a price on category list :(
http://postimg.org/image/5xm1ea6wn/

Thank you for reporting this issue, I have fixed all of your mentioned problems. You can wait until next release or make changes to your files from following commits: https://github.com/boxbilling/boxbilling/commit/2e94853d11189afb2ff7ded3f28b65863cdc5ec3 https://github.com/boxbilling/boxbilling/commit/d329dbd0085afe569c8cf8f8651f09c9e97210f1 https://github.com/boxbilling/boxbilling/commit/cb4c2fc98cfd83601d7a2b27db7d0f532d87c34b

We have just released new version of BoxBilling, feel free to download it.


Fuzz serde enum representations

[ ] I've included my change in CHANGELOG.md

Codecov Report
Patch coverage: 100.00% and project coverage change: -1.71% :warning:

Comparison is base (2787d8c) 100.00% compared to head (80321a7) 98.29%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #502      +/-   ##
===========================================
- Coverage   100.00%   98.29%   -1.71%
===========================================
  Files           78       78
  Lines        11053    11077      +24
===========================================
- Hits         11053    10888     -165
- Misses           0      189     +189

Files Changed
Coverage Δ

src/de/mod.rs
100.00% <100.00%> (ø)

src/parse.rs
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@torkleyy Holy dang, serde attributes are a mess. This nightmare has really only unearthed two or three bugs in ron (around tagged enum tag identifier deserialising), many cases where we cannot roundtrip because serde's Content loses information (see https://github.com/serde-rs/serde/issues/1183), but MANY nightmares around serde attributes just plain not roundtripping themselves. I will try to add some tests and update our restrictions README in the PR, but I won't spend any time prettifying our fuzzer at this point. It will hopefully get nicer over time as the above restrictions are lifted.
Hopefully I can get this PR merged early next week and then finally, with the confidence that we now know about the limitations of serde attributes in ron, release v0.9.

@torkleyy I think this is finally ready* (I want to merge and rebase on #512 first). Gosh this PR is huge ... and soooo cursed. And probably once the fuzzer changes lands I get many new edge case reports soon. But it is a small step phew


Add Pipeline Parallel for PPO training and support generation with InferenceModel

PR types

New features
PR changes

Others
Description

Add Pipeline Parallel for PPO training and support generation with InferenceModel

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.:white_check_mark: guoshengCS:white_check_mark: ZHUI:x: gongenleigongenlei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Fails on same origin request running inside a sandboxed iframe

When I do run a GET request within an <iframe sandbox="allow-scripts" /> to an URI on the same origin of the iframe, the request fails with the error:
DOMException: Failed to read the 'cookie' property from 'Document': The document is sandboxed and lacks the 'allow-same-origin' flag.
The issue is actually caused by the XHR adapter, while reading the cookies, since you can't access cookies in a sandboxed iframe:
// Add xsrf header
  // This is only done if running in a standard browser environment.
  // Specifically not if we're in a web worker, or react-native.
  if (utils.isStandardBrowserEnv()) {
    var cookies = require('./../helpers/cookies');

    // Add xsrf header
    var xsrfValue = config.withCredentials || isURLSameOrigin(config.url) ?
        cookies.read(config.xsrfCookieName) :
        undefined;

    if (xsrfValue) {
      requestHeaders[config.xsrfHeaderName] = xsrfValue;
    }
  }

I'm willing to submit a PR to fix it, but I'm actually wondering what's the best approach in your opinion (according to the axios design):

Add a try/catch in helpers/cookies.js read() function and return null on error
Add an option to disable the XSRF header, or implicitely disable it if config.xsrfHeaderName === null
... any other suggestion is welcome

Thank you,
Marco

I think option 2 is better but checking xsrfCookieName instead of xsrfHeaderName.


Add context propagators to local activity executions through test environments

What was changed
Add context propagators when executing a local activity in a test environment.
Why?
Fix for the linked issue
Checklist

Closes #1290

How was this tested:
A unit test was added

Any docs updates needed?
Nope

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Version 2.0 fails to activate Asus BT400 dongle on iMac mid 2011

Unfortunately, the activation tool remains stuck during the activation process, suggesting to plug in the dongle (which I did several times) or to continue without activating the dongle... I'm running 10.10.2 latest public beta - perhaps that causes the issue? (Otherwise, the dongle is listed in the system report under USB)

Hello, this is a known issue with workarounds. This is likely related to one or more paired Bluetooth accesories that keep the internal Bluetooth controller active, which confuses CAT's dongle detection routine.
Could you please try this:

Plug your dongle in and Activate with CAT 2.0.1 beta
When the prompt is displayed, turn Bluetooth off (System Preferences>Bluetooth>Turn Bluetooth off)
Wait until the end of the activation procedure before turning Bluetooth back on

You might need to re-pair your devices after the reboot. If you run into issues with pairing, refer to issue #122.

Hi David,
First many thanks for the efforts. Thanks also for the quick reply.
Unfortunately, I couldn't locate the link to 2.0.1 on the main page (it's mentioned but the download link below is still for 2.0.0?). I also don't know for sure how I can steer the iMac after switching off Bluetooth (since both keyboard and mouse are BT connected to it...)? Should I need wired keyboard and mouse for the procedure?
Thanks again, best wishes from Heidelberg,
Steffen

Hi Steffen,
You can also try to force the activation by using the command line activation and therefore you won't need to turnoff Bluetooth. Here' the direct link to download v.2.0.1.
Then follow these steps:

Copy the app on your desktop
Open Terminal
Type cd "$HOME/Desktop/Continuity Activation Tool.app/Contents/Resources"
Type sudo ./contitool.sh -f

Hi David,
Thanks. I ran the commands as suggested. It seemed to work, reporting everything as ok but after the restart the system reports still claims that all continuity features are inactive... maybe I wait a bit?

Steffen,
Have you tried to unplug / replug the dongle after the reboot?
If that doesn't work, then please copy/paste a CAT System Diagnostic output here.

David,
Indeed unplugging / replugging the dongle appears to activate the dongle after the reboot. But maybe I'm too silly for this... my BT bluetooth and BT mouse lost connections and I wouldn't know how to re-pair them (since I've lost any means to manipulate the iMac and there also didn't seem to be an auto-routine by the iMac to start looking for devices)...

Hi David,
Please find below the CAT report. Thanks!
--- Hardware/OS checks ---
Verifying Continuity status...          OK. OS X reports Continuity as inactive
Verifying Mac model reference...        OK. Known compatible Mac Model detected: iMac12,2
Verifying Mac board-id...               OK. Long board id detected: Mac-942B59F58194171B
Verifying OS X version...               OK. Mac OS X 10.10.2 (14C106a) detected
Verifying Wi-Fi hardware...             NOT OK. An Atheros AirPort card is used, Continuity will not work. An upgrade to a compatible Broadcom card is necessary.
Verifying AWDL status...                NOT OK. Your Wi-Fi card doesn't support AWDL, and therefore doesn't work with Continuity.
Verifying Bluetooth hardware...         OK. 3rd party Bluetooth hardware detected
Verifying Bluetooth version...          OK. Bluetooth 4.0 detected
Verifying Bluetooth features...         OK. Bluetooth features are currently not compatible with Continuity. This tool can try to fix this.
Verifying Bluetooth firmware...         OK. Bluetooth firmware version: v14 c4096
--- Modifications check ---
Verifying OS kext protection...         OK. Kext developer mode is already active
Verifying kexts readability...          OK. Wi-Fi and Bluetooth kexts were found and could be read
Verifying Bluetooth blacklist status... OK. Your Mac model is not blacklisted
Verifying Wi-Fi whitelist status...     OK. Your board-id is not yet whitelisted. This tool can fix this.
Verifying old Wi-Fi kext presence...    OK. Legacy Brcm4331 Wi-Fi driver is present. This tool can fix this.
Verifying legacy Wi-Fi card patch...    OK. The legacy Wi-Fi patch is not present. This tool can fix this.
Verifying BT4 dongles compatibility...  OK. Compatibility with BT4 USB dongles is not enabled, this tool can fix this if a dongle is plugged in

I'm afraid the Wi-Fi card in your iMac doesn't support Continuity unfortunately:

Verifying Wi-Fi hardware... NOT OK. An Atheros AirPort card is used, Continuity will not work. An upgrade to a compatible Broadcom card is necessary.
Verifying AWDL status... NOT OK. Your Wi-Fi card doesn't support AWDL, and therefore doesn't work with Continuity.

As described on the homepage:

Atheros Wi-Fi AirPort cards will prevent Continuity from working even when adding a Bluetooth 4.0 dongle. The System Diagnostic feature of CAT tells which Wi-Fi brand is active. There are no workarounds and no patch is expected to change this, an AirPort card upgrade is required
I'd recommend you uninstall CAT and look through the options on the main site

The only option is to upgrade the internal Wi-Fi card, you can find the correct model in the compatibility table. If you're interested, you can find more info on the procedure in issue #46. Good luck!

Thanks for all your efforts David.
I looked up issue #46 but I'm not sure whether I can follow all the details in this discussion.

Yes the installation appears to be quite technical on an iMac, there might be other step by step guides out there (e.g. here). However, I wouldn't recommend doing it if you're not familiar with internal hardware upgrades...
Cheers, closing.
.

Thanks David!

On 22 Jan 2015, at 12:16, David Dudok de Wit<EMAIL_ADDRESS>wrote:
Yes the installation appears to be quite technical on an iMac, there might be other step by step guides out there (e.g. here). However, I wouldn't recommend doing it if you're not familiar with internal hardware upgrades...
Cheers, closing.
.
—
Reply to this email directly or view it on GitHub.


⚠ Bofrost.at has degraded performance

In 5fec0fe, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1871 ms

Resolved: Bofrost.at performance has improved in 55b4ed0 after 11 minutes.


AttributeError: 'Style' object has no attribute 'SUCCESS'

After running python manage.py initadmin, I get this:
oj@oj-Junyi-A410:/home/OnlineJudge$ sudo python manage.py initadmin
Super admin user 'root' already exists, would you like to reset it's password?
Input yes to confirm:
yes
Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/usr/local/lib/python2.7/dist-packages/django/core/management/__init__.py", line 338, in execute_from_command_line
    utility.execute()
  File "/usr/local/lib/python2.7/dist-packages/django/core/management/__init__.py", line 330, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/local/lib/python2.7/dist-packages/django/core/management/base.py", line 393, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/usr/local/lib/python2.7/dist-packages/django/core/management/base.py", line 444, in execute
    output = self.handle(*args, **options)
  File "/home/OnlineJudge/utils/management/commands/initadmin.py", line 19, in handle
    self.stdout.write(self.style.SUCCESS("Successfully created super admin user password.\n"
AttributeError: 'Style' object has no attribute 'SUCCESS'

import django
print django.VERSION

看下你django的版本

1, 8, 4, final, 0

都是现装的

1.9以上才行，见dockerfiles/oj_web_server/requirements.txt

我就是按照requirements.txt装的啊……

requirements.txt应该是下载最新的啊


Workspaces/Properties icon is too large in high DPI

https://github.com/Microsoft/RTVS/commit/2e62ba12bb572cfadfafa58536ed607d89cc51f5


Fortify connection getting error while click to function

Hi Team
I am getting error while click to function from SSC

Hey @maamirkhan192 . Can you explain what steps you went through to get this error?

I am free today and tomorrow please the meeting invite as per your suitable time

Is there any update?


Simplified config parsing code by using ast.literal_eval

Although why the 2 ast.evals? When I do that with something simple like ast.literal_eval(ast.literal_eval(ast.parse('2.1', mode='eval'))) I get an error.

Tried implementing your changes locally and couldn't get it to work (import proplot fails).
Honestly since rc params are constrained to have such simple values -- only boolean, string, and numeric -- I think the current approach is fine. So I think I'll close this but appreciate the suggestion. I also removed the eval in a recent commit.

In case you're curious the newest version (v0.8) uses matplotlib's "validators" when assigning proplotrc parameters to the rc dict. Some of the validators use ast.literal_eval internally. So conversions of proplotrc values are no longer so clunky.

Thank you for the info.


chore(root): add commit hooks & nvm

Summary of the changes
Adds husky and nvm.
Related issue
Ongoing improvements, no issue subject to closing yet.

Approved, but there is conflict in the package-lock - once you've got that sorted we can merge :)

PTAL

@evenstensberg  looks like something's up with the packages, failing the build

Yes, I think that is solved in #28


Replace big "openfarm" on front page with "Grow Your Food"

and move "openfarm" into the top left corner.
This is a better call to action.
Additionally, replace the text with "Farm and garden through knowledge sharing" because it's more mission oriented, more focused on expected outcomes. Also, capitalizes on "Sharing economy" and "knowledge economy". (with the added bonus that we're good people).
You would have to add the text to en.yml (for future translations) and then add it to the home/show.html.erb page (actual name of file might not be that).

This is done thanks to @nicholasedwards!


Sqlite changeColumn bugfix

When changing a primary key column to a BIGINTEGER this doesn't work because SQLite doesn't support a BIGINT auto incrementing column. However SQLite uses a dynamic type system. We can therefor use INTEGER. See: http://www.sqlite.org/datatype3.html.
What happens if you run the code from the new test All other columns would be removed from the table.

this PR shouldn't modify any interface signatures, it must be cleaned up first.

Thank you for trying to contribute. Due to the lack of response on the changes that were requested, I am going to close your pull request.
Please create a new PR against the current default branch if you want to see these changes merged.


SSL/TLS support

@Overtorment, thanks for your feature request. SSL was not planned originally, but I will take a closer look.
I might have to investigate about CocoaAsyncSockets known bugs with SSL. I will update you with any news about this topic.

If this helps, I'm currently using https://github.com/wfilleman/react-native-tcp in production which has  TLS for both ios and android, but I don't feel confident in this package. So I'm having hopes for this package to maybe be a superior one 🙏

Thanks for the reference, it helps a lot. I will take a look at their implementation and perform some tests.
I'll update ASAP with more information.

Thanks!
On Mon, 6 Apr 2020 at 13:53, Rodrigo Martin<EMAIL_ADDRESS>wrote:

Thanks for the reference, it helps a lot. I will take a look at their
implementation and perform some tests.
I'll update ASAP with more information.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Rapsssito/react-native-tcp-socket/issues/38#issuecomment-609775606,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAOTD6PYFQ6UPPD3ZYBXENLRLHGE5ANCNFSM4MBEIYGQ
.

@Overtorment, I have created a development branch for the SSL/TLS support. Currently it is only available for the Android TCP client socket, but it adds support for self-signed certificates.
If you want to test it, you can add it to your project:
yarn add https://github.com/Rapsssito/react-native-tcp-socket#tls

Is there a way to just ignore certificate check? We have a use case of users connecting to their own servers with self-signed certificates, so we don't know them in advance

@Overtorment, I am working on a way to ignore all certificate check. I will continue updating the tls branch with all the new features.
Right now, there is Android and iOS support for standard TLS checks and locally known self-signed certificates.

@Overtorment, there is a way to ignore all certificate checks: you must set tlsCheckValidity to false in your createConnection() options. For more info, take a look at the documentation on the tls branch.
Right now, Android and iOS TCP clients are TLS/SSL compatible. Can you test it in your project and report the problems you find? If there are no issues, I will continue working on the server SSL/TLS support.

Will do!

success. tested tls/android. didn't test clearnet tcp and ios.
seems to work okay but there are  some issues:

there are no methods setNoDelay, setKeepAlive,  setEncoding. I commented them out, but they are available for sockets on all platforms I think.
a bit annoying that lib API does not conform to the one described in nodejs documentation. no big deal but I write isomorphic code and reuse it under RN environment and under nodejs environment. that means I will have to write more workarounds. example: createConnection creates a socket and connects it, while net package exposes sockets and allows you to connect later.
similar with nodejs tls package: it doesn't allow you to create socket, but creates connection on the spot, but method name is different (tls.connect) and arguments have different names.

PS. cant test IOS

@Overtorment, glad to hear it worked! I am sorry about those issues.
The methods setNoDelay, setKeepAlive, setEncoding are not implemented yet. I will update the documentation to make it clear.
The react-native-tcp-socket available API changes significantly from node net and tls because I am limited by my free time and native code development. The objective of this library is to provide a React Native API for TCP in both Android and iOS. That is why, right now, I am merging net and tls API's surfaces into one, so it is normal to have some differences.
All the available interface is in the documentation. If you have any questions, feel free to open an issue. I hope this library is good enough to suit your project!
PS: I will change the tlsCheckValidity to rejectUnauthorized to make things easier for you ;)

I think those methods you just need to proxy-call socket object on native system, you don’t need to implement anything.
So are you keeping lib api as is? Just to make sure, if it stays like this - it stays, that’s fine, just to know there won’t be any breaking changes :-)

There won't be any breaking changes. I will release the new version in 5 minutes.
About the methods setNoDelay, setKeepAlive and setEncoding, thanks for the tip! I will investigate. As soon as they are implemented, I will release a new version.

@Overtorment @Rapsssito
Can u please help me in this. I am trying to create Android TV Remote for IOS.
Like I wan to mimic node(tls.connect) using react native.
I need to implement a tls connection with Android TV from IOS device to send Remote Commands.
When I send below from IOS device with tls true it throws error
operation couldn’t be completed. (kcfstreamerrordomainssl error -9807.)
const client = TcpSocket.createConnection({    port: '6467',    host: "Android TV I.P",    tls: true});
When I send below with no tls key from IOS device it makes connection but data returned from Android TV is not in proper format. So I was thinking this is because tls is false in below case.
const client = TcpSocket.createConnection({    port: '6467',    host: "Android TV I.P"});
Can u please help me in this. How to make a tls connection in React Nativ from IOS. Any help would be really helpful.

@piyush2cloud, if you have a problem, you should create a new issue. However, you could check nodeJS examples or seek help in stackoverflow for this kind of questions.

Hi how do i pass private key in client tls do you know how ?
const options = {
// Necessary only if using the client certificate authentication
key: fs.readFileSync('client_private_key.pem'),
cert: fs.readFileSync('client_cert.pem'),
// Necessary only if the server uses the self-signed certificate
ca: fs.readFileSync('server_cert.pem'),
}
this is what I use when I am working on nodejs what do I need to add for this to work in react-native ?


[GSSOC '23] : Word Embedding Using Pytorch #356

Description
(This is a Python code for word embedding using Pytorch.)
Checklist

[x] I've read the contribution guidelines.
[x] I've checked the issue list before deciding what to submit.
[x] I've edited the README.md and link to my code.

Related Issues or Pull Requests
(#356)
Solved

Since the code uses the concept of Deep Learning (DL) so I have made this contribution under DL folder so what I have to update or change in this DL folder?

Please approve this one.


typescript + RxJS5 + vorpal next

Just wondering if the next major release of vorpal will be written in TypeScript?
The current version is based on RxJS and since RxJS5 is in TS, it would be cool if this lib was too, thanks!

I guess some work is already started on 2.0 branch maybe you can join there or take a look at it

@b4dnewz I don't think that's the case. There's no recent updates on 2.0 and no Typescript files currently. Recommend closing this issue as a duplicate of discussion on #234.

hi @timkinnane if you are interested I forked this project few months ago for my personal needs and changed a bunch of stuff (not such breaking changes, but some) and I'm also converting it to typescript see this branch, if you are motivated like me you can jump in and start contributing, feel free to clean up the code if you feel to.
I've also resolved some issues existing on the original repo, but since I changed some of the API I decided not to make a PR, also there are PR open for months or years and it's not my case I need to use it for another project and do frequent changes.


Create Station information screen

This page will display details about a station.

@SAITARUN55 would like to work on this with my teammate Shruti

@SAITARUN55  I want to contribute to it .Please assign this to me .


CSP-adapter hardened cluster support

Should support hardened cluster, including PSP and network policy.
See our internal helm chart requirements doc.

Going to push this off for now.

In addition to the above, the container for the adapter should not run as root.


Fix InstallToVSCode for breaking CLI change

The CLI team previously indicated that a native host executable will not be dropped
unless the project.json explicitly indicates that the application wants to be
platform depentant. But builds from a few days ago were actually behaving nicer than
the way I told it should work.
Now things are actually behaving this way. So I am fixing up InstallToVSCode to generate
project.json on the fly so we can write out a runtime id.

@chuckries please review, @wiktork FYI

LGTM except a minor comment about yosemite support


jsonGet on array with negative index param

jsonGet ( $jsonArray ; -1 )
Should this return an error, or "not found"?

I had it return an empty string to match the BE plugin backed function with the same name.


Develop base radio protocol

We need:

ID
opcode
payload (1 byte)
time
time authority
crc

Opcodes can be:

beacon (payload ignored)
pair req (payload ignored)
pair ack (payload is badge it's acking)


Problem with PSRAM in the tutotial/convert_tool_example with esp32-S3-DevKitC-1 (AIV-655)

The program compile and build ok, but in the monitor I get this error:
E (260) quad_psram: PSRAM ID read error: 0x00ffffff, PSRAM chip not found or not supported, or wrong PSRAM line mode
E (263) cpu_start: Failed to init external RAM!

I am using the last version available of ESP-DL and ESP-IDF.
I use the official guide

The problem was the mode of the SPRAM. I have to change it from QSPI (Quad Mode PSRAM) to PSRAM was OPI (Octal Mode PSRAM) in the menuconfig.
This  might help you also. https://github.com/espressif/esp-idf/issues/6288#issuecomment-1468725900


k2pdfopt is missing tesseract data

Describe the bug
k2pdfopt is missing tesseract data so I imagine OCR of french does not work so well.
k2pdfopt v2.51a (w/MuPDF,DjVuLibre,OCR) (c) 1970, GPLv3, http://willus.com
    Compiled Jan  1 1970 with Gnu C v9.2.0 for Linux on x64.

Initializing OCR for 2 threads ..
4.1.1 [SSE+AVX]
    Tesseract data folder = ''
    Tesseract languages: eng [LSTM+Tess]

To Reproduce
Steps to reproduce the behavior:
k2pdfopt -x -gs -ui- -col 1 /tmp/foo.pdf

Expected behavior
Tesseract has french :)
Additional context
the tesseract derivation has options to enable only specific languages, and defaults to all languages.
Notify maintainers
@bosu @danielfullmer
Metadata

system: "x86_64-linux"
host os: Linux 5.7.15, NixOS, 20.03.2778.20904118004 (Markhor)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.6
channels(root): "nixos-20.03.2778.20904118004, nixos-hardware, nixos-unstable-20.09pre237781.32b46dd897a"
channels(symphorien): "home-manager-20.03"
channels(foo): "home-manager-20.03"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute: [ k2pdfopt ]
# a list of nixos modules affected by the problem
module:

See https://github.com/NixOS/nixpkgs/pull/93631/commits/56f6a3453d5ab83dc91044f07356c2f66c2c41c2 added to the PR to update k2pdfopt to 2.53: https://github.com/NixOS/nixpkgs/pull/93631
Looks like we just need to set TESSDATA_PREFIX.  In order to use a different language, use (for example): -ocrlang chi_tra.
To see the list of available languages run k2pdfopt -ocrlang ?
See also: https://www.willus.com/k2pdfopt/help/ocr.shtml

Closed by #93631


Use nephio molecule docker image in prow

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:
This change improves the molecule test execution, utilizing a customized docker image to perform Ansible Role integration tests.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/approve
/lgtm


fix: Tests - move certs to a public bucket

Relates

https://github.com/aws/aws-sdk-pandas/pull/2670

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 26440508bce6e2a47840817baa1f988db9ff7c1f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 26440508bce6e2a47840817baa1f988db9ff7c1f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Does CVE-2020-1971 Affect a Scenario of OpenSSL1.1.1f CMP Certificate Application?

Hi!
Is CVE-2020-1971 involved in CMP certificate application? Because it is not convenient to test all scenarios of certificate application, I want to confirm with you.
The CRL is not involved in the certificate application. I use openssl1.1.1f

Is CVE-2020-1971 involved in CMP certificate application? Because it is not convenient to test all scenarios of certificate application, I want to confirm with you.
The CRL is not involved in the certificate application. I use openssl1.1.1f

As far as I know, 1.1.1f does not have support for CMP, that was
only added in master, will be in 3.0.
The CMP support in master can use CRLs.

Thanks!


Fix example snippet in Array.swift

Fix example snippet in Array.swift

Example snippet has several problems:

it uses deprecated function write(to:atomically:)

snippet and explanation claim bridging [String?] to NSArray is compile error when it's not - bridging works fine, but write(to:atomically:) function fails. Despite retuned fail and true atomically parameter, function writes elements into file until first NSNull and keeps this file in file system. Probably it's another problem which should be filed. cc: @millenomi

This PR uses write(to:) instead of deprecated write(to:atomically:) in example, adds do catch and changes explanation preceding example. I feel that this explanation should be improved. Help is appreciated.

Note that this file is talking about bridging as it applies to Darwin's Foundation. If write(to:) has a behavior you don't like, you will need to file behavior change requests not with Swift, but with Apple at https://feedbackassistant.apple.com/.

@natecook1000, @amartini51 could you please have a look?

The documentation for NSString.write(to:atomically:) suggests using write(to:atomically:encoding:) instead.
Has the bridging behavior changed also? The new discussion (which has some English usage problems we can fix later) tells a different story with regard to optionals.

The documentation for NSString.write(to:atomically:) suggests using write(to:atomically:encoding:) instead.

It not about NSString.write(to:atomically:) but about write(to:atomically:). It's deprecated. Therefore I have decided to use write(to:).

Has the bridging behavior changed also? The new discussion (which has some English usage problems we can fix later) tells a different story with regard to optionals.

Yes, bringing behaviour have changed. Original snippet claims it should be compile error. But snippets compiles without errors and runs without errors.
Snippet could not be left untouched because it tells wrong story.

ping

@amartini51 ping


Add Electron logo icon asset

It would be really helpful to have an SVG of just the Electron logo icon (ie. no text) - this PR could really use it, since Nodegit's website is currently using Atom's logo when it should be the Electron logo.
/cc @simurai @jlord

@simurai would you mind adding this to this repo? Maybe just call it electron-icon.svg and throw it in images/? What do you think?

Sure.. added: https://github.com/atom/electron.atom.io/tree/gh-pages/images
Also, as a PNG in case.

Awesome, thanks!


Follow mode for tree-sitter-debug-mode

Hi,
I am appreciating your mode a lot these days: thank you very much for sharing it!
One thing I find amazing is to be able to visualize the syntax tree with tree-sitter-debug-mode. One thing I am missing is to have a follow mode: imagine if navigating the syntax tree highlights the code and viceversa.
I think the information should be already there and it's probably a matter of highlighting.
Do you have plans for that? And do you have a suggestion what part of the code is worth to look at to make it happen?
Thanks again for emacs-tree-sitter!

Thanks for the kind words!

navigating the syntax tree highlights the code and viceversa.
I think the information should be already there and it's probably a matter of highlighting.
Do you have plans for that?

That's a desirable functionality, but I haven't had time to work on that yet.

And do you have a suggestion what part of the code is worth to look at to make it happen?

The code for tree-sitter-debug is pretty short. It doesn't do much currently. It can be enriched with the inspection APIs. A simple approach would be annotating the debug buffer with text properties. You may also want to check out #23.

Nice! I will have a look if I manage to hack something decent. By the way, I did not realize you could already add buttons to the debug tree with: (setq tree-sitter-debug-highlight-jump-region 't) and (setq tree-sitter-debug-jump-buttons 't). That already helps!


@kanaabe => update cookies

For editorial signup CTA, checks if articles viewed before setting cookies.

🐛  👍

@eessex remember to deploy to prod after checking that staging looks good! esp for bugs like this.


Add dnSpy Debugger Usage Guide to README and Wiki

MelonLoader is already setup to handle dnSpy's Debugger and Environment Variables.
Should probably state its usage in the README and Wiki.
To use it currently just run MelonLoader in Debug Mode and follow the steps in this GUIDE after the part about replacing files.
It should work without replacing any files.
Image for Reference:

I'll work on this once I get time

Put into the wiki: here


No /usr/share/java/jaxb-api.jar in 4.0.0

I'm not sure whether this is considered a bug or not - just filing it to bring it to your attention to check.
The Fedora package builds of jaxb-api 2.3.3 included a /usr/share/java/jaxb-api.jar , which is a symlink to glassfish-jaxb-api/jakarta.xml.bind-api.jar, the real file. The Fedora package was today updated to a build of 4.0.0. This no longer has the symlink. I can see no change in the package spec file which would affect it, so it seems like the change must have been upstream.
This seems to have broken dogtag-pki, which in turn has broken FreeIPA, because dogtag-pki in turn installs a symlink pointing to /usr/share/java/jaxb-api.jar. That command, in Fedora's builds at least, winds up creating a symlink /usr/share/pki/server/common/lib/jaxb-api.jar -> /usr/share/java/jaxb-api.jar, and now of course that symlink is broken.
If this is an intended change, I'll file a ticket on dogtag-pki to have it do something different. But I figured it might instead be oversight or error, and it may be still be intended to make the library available in this location.

AFAIK this project has never been dealing with os specific installers and it has no plans to do so.

That seems quite dismissive? The "OS specific package" is just using something this project used to provide - an unversioned file in a specific place - and no longer does. The fact that it's an "OS specific package" doesn't seem particularly relevant.
In any case, the code is in dogtag-pki's upstream, there's nothing specific to Fedora there. I'd expect the /usr/share/java part might differ between distros, but ultimately dogtag-pki is, I think, always looking for this unversioned jaxb-api.jar file in "the Java directory", which jaxb-api previously installed but no longer does.
If the answer is "we intentionally removed that and projects that want to work with jaxb-api 4 shouldn't expect it to be there", that's fine. But I don't see what "os specific installers/packages" really has to do with anything?

That seems quite dismissive? The "OS specific package" is just using something this project used to provide - an unversioned file in a specific place -

No, that has never been true. A file produced by this project since its inception in ~ 2005 has been published to maven repository (initially maven 1 repo on the java.net) only.

and no longer does. The fact that it's an "OS specific package" doesn't seem particularly relevant.

Why do you think this project is responsible for maintaining RPMs listed at https://rpmfind.net/linux/rpm2html/search.php?query=mvn(jakarta.xml.bind%3Ajakarta.xml.bind-api) or https://rpmfind.net/linux/rpm2html/search.php?query=mvn(javax.xml.bind%3Ajaxb-api) which are responsible for the creation of the links, docs etc and the file/symlink dogtag-pki and/or freeipa project expects?

In any case, the code is in dogtag-pki's upstream, there's nothing specific to Fedora there. I'd expect the /usr/share/java part might differ between distros, but ultimately dogtag-pki is, I think, always looking for this unversioned jaxb-api.jar file in "the Java directory", which jaxb-api previously installed but no longer does.
If the answer is "we intentionally removed that and projects that want to work with jaxb-api 4 shouldn't expect it to be there", that's fine. But I don't see what "os specific installers/packages" really has to do with anything?

the name of binary produced by this project was changed from jaxb-api.jar to jakarta.xml.bind-api.jar between versions 2.3.2 and 2.3.3. Nothing else has changed. What has not been produced, couldn't be removed. But someone else, ie some downstream consumer, could stop producing/maintaining rpms of course, but that is out of control of this project.

no worries, glad to see we managed to resolve this in the end.


Any plans to support metadata generation based on DTO?

Any plans to support metadata generation based on DTOs as its done in .NET world? I dont want to tie my client code to the db.
Thanks

Sorry I didn't get back to you.  The server implementation has changed significantly since you asked this question.  Now saves are performed using a SaveWorkState object, which has methods beforeSaveEntity, beforeSaveEntities, and beforeCommit.
Using the beforeSaveEntities method, you can intercept the save process and change your DTOs to Entities prior to save.  See the SaveProcessor doc and the SaveWorkState JavaDoc for more info.


add import order check

defined as warning for all files, error for changed files

Related issue: https://github.com/jshiell/checkstyle-idea/issues/377#issuecomment-404747579
Screenshot - scan only modified files:

Current import rules:


Rock Paper Scissors Game

Hey! Kindly check my code and accept my PR for hacktoberfest under the label hacktoberfest2022 and hacktoberfest-accepted.

Thank you for accepting my contribution.


Update Rakudo Star to 2022.04

Couldn't locate a fingerprint file so I rewrote the verification to use the sha256 checksum. I also split the run out into several of them and moved files to ADD and variables to ENV commands. This was to take better advantage of caching.

Not entirely sure what is going on here, despite it saying "All checks have passed"  the https://github.com/Raku/docker/pull/49/checks would seem to suggest otherwise.

Not entirely sure what is going on here, despite it saying "All checks have passed" the https://github.com/Raku/docker/pull/49/checks would seem to suggest otherwise.

Oh it's showing correctly now.

Looks like the GitHub action expects only one version.

Not entirely sure what is going on here, despite it saying "All checks have passed" the https://github.com/Raku/docker/pull/49/checks would seem to suggest otherwise.

Oh it's showing correctly now.

@jonathanstowe should I:

delete the old 2021.04 folder
update action to take latest version, or
update action matrix to also check at the version level?

I am not familiar with gha, am I able to enable on a fork for testing updates to it?
Thanks for your help!

Closing as it appears there is movement towards generating the fingerprint and there's an existing PR that bumps the r* version.


No password for DB

Hi, password for DB is mandatory when creating connection, but our test DB doesn't have password. Would it be possible to make password optional here?

Sure - I can look into that @Trudko.
Whether it works might depend on the database driver in use. What database you are using?

Postgres. Btw typing empty space actually worked as workaround.

oh great - I'll plan on making the field optional next release and go from there.

@Trudko sqlpad has been updated to 1.7.0 in npm. It should allow you to save a connection without a password now :)


Add usage section to README

Closes: https://github.com/comarev/comarev/issues/24

References: /
What?

This PR adds a usage section for documenting API endpoints to the README

Here is how the Usage Section is looking:

@allcontributors add @Thekote for code


This XML file does not appear to have any style information associated with it.

In general, the underlying principle for Best Practices for AWS is "Never build infrastructure in the Console."
The suggested answer for the above error is "use the console to redirect to index.html," in order to support SPA.
As this is a violation of Best Practices, please add this capability to Amplify.
One ought to be able to add this redirect to a config file, etc. Best Practices for a Wizard-Driven system like Amplify CLI might deem this worthy of an Interview Question, akin to the following (from "amplify update api"):
Please select from one of the below mentioned services: (Use arrow keys)

GraphQL
REST

You might add an interview question such as
Please select from one of the below mentioned front end modalities: (Use arrow keys)

SPA
Other

Following such an interview, you could update the CF template accordingly.
I think you will find that MANY Amplify use cases include an SPA front end, so this change will improve the experience of many users.
Thanks!

@tom-huguenard could you elaborate on the use case you are trying to solve for and what CloudFormation changes you expect when selecting SPA vs Other as you have suggested above?

Closing due to lack of response.


Is abapGit handling licenses correctly?

When using abapGit in an SAP system, we are not pulling the license file. There isn't really anywhere to put it and abapGit is set up to ignore it.
For example, the MIT License states:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

abapGit is licensed under the MIT License too. When we are pulling the files into the SAP system, aren't we effectively breaking the license agreement? The "substantial portion" of the software is in the SAP system, but the license file is nowhere to be found.
I wonder if this means that the license should be included (automatically?) in the source code pulled into the system.

its in the entry program to abapgit,
https://github.com/abapGit/abapGit/blob/60f01499e55b99a39e27ec6bda028ccd308c6d84/src/zabapgit.prog.abap#L6
which is pulled,

Thanks, I didn't see that. What do you think about putting something into the user documentation? Something like:

Please note that the repository's license file will not be pulled into SAP systems. If required by your license, make sure to reference or include it in one of your source code files.

You have a good point @ConjuringCoffee. It's good practice to include the license in the (root/main) source as abapGit does. It doesn't have to be the full text. A link to the license or simply an SPDX license tag is ok, imho. But that's up to the owner.
PS: I'm working on an extension that will let you view the license file in abapGit.

Thanks, I didn't see that. What do you think about putting something into the user documentation? Something like:

Please note that the repository's license file will not be pulled into SAP systems. If required by your license, make sure to reference or include it in one of your source code files.

yea, can you help opening a Pull Request with a suggestion?

Sure 👍


documentation updates

PR includes two updates to the docs:

Use the --labels flag. If I see it correctly, the selector flag does not exist anymore and is replaced by the labels flag
Add the latest tag for version. Here I have to admit, I find go install very confusing. The way I understand it is the following: If you are installing a go pkg for the first time, go install is not allowing you to do so without specifying a version. Afterwards (aka after $GOPATH/pkg/mod is populated), it works without the version. Not sure why they decided to design it this way. Still I think it is best to add the @latest in the docs, since most of the users probably will install it for the first time.❯ go install go.xrstf.de/stalk
go: 'go install' requires a version when current directory is not in a module
        Try 'go install go.xrstf.de/stalk@latest' to install the latest version

Here I have to admit, I find go install very confusing.

You and me too, brother. Go's CLI is the one thing i complain about for years and years and years now 😁


[feat]: add container query styles to <rh-table>

Tables could benefit from container style queries.  We might want implement either a feature set that allows you to switch between basing the style switch off @media or @container

Closed by #1881


Zooming on histograms won't take new data from GeoJSONDataProvider

When zooming in on a histogram, it should generate a new one through the data provider, using new data from the layer. However, right now it's bypassing the histogram function and generating a chart with old data.

@javisantana @alonsogarciapablo

@alonsogarciapablo I think it's related to the way we get the data from datasource for the small histogram. I have some concerns about that

@alonsogarciapablo I also have some issues with histogram on cartod1b because of its casuistic. Let me know when you work on this issue so we can talk together about how to address.

This is a duplicate of #1069.


Is there a way always render players regardless of where in the world they are

There should be a way but I cant seem to find it

there's a player location sharing feature in the base worldmap/minimap mods. i think it requires you to install them on the server as well. There's a button on the bottom right side of the WorldMap gui.
XaeroPlus doesn't add or change any features related to this so that's as much support as i can give.

Ngl I have no clue how to use the button but welp I'll just comment thus on the Xaeros mod page


Table: Fix KeyNotFoundException with Record types

Description

Resolves #4691
Resolves #4904 (duplicate).
Record types would break various table functions as identical records would be treated at the same object by the TableContext Dictionary. This PR resolves this by using a HashSet of records that uses both the T value and the MudTr row to determine equality.
How Has This Been Tested?

All existing tests pass. I could duplicate a handful of the existing tests and replace the class type with record types to specifically test records, but the existing tests cover the replacement of the Dictionary with a HashSet.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests.

@henon I am going to add some specific unit test in a bit. Please let me know if you have any concerns with this change.

@henon I think a similar change needs to happen to the SelectedItems HashSet as two identical records will be treated as the same item and only stored once. This is trickier because it would require a breaking change to the API (as the SelectedItems are returned as a HashSet on the Table). Additionally, inline editing is based on unique items, meaning if a record is used you end up with multiple rows in edit mode:

However, I think this is getting out of scope for this PR but it is something to consider.

We can also just say records are not supported in MudTable.

That's also true. Would you agree that this PR is still relevant even if the verdict for multi selection is that records are not properly supported?

Not only records, all value types should exhibit this problem. But yes, the change in this PR still makes sense. An exception should never be thrown just because you are using value types with MudTable.

Thanks!

I added these changes to my forked repo and am running through the debugger on a unit test I made and I think there's an issue, still. The exception is not thrown, which is good. However, the updated row is not being removed properly. Looking at the Rows property, the changed record never gets purged.
Here is the test case I'm using in MudBlazor.UnitTests/Components/TableTests.cs
/// <summary>
/// Issue #4691
/// Tests disposal of rows after an edit has been committed to server data. Table should successfully dispose
/// without a key not found exception.
/// </summary>
/// <returns></returns>
[Test]
public async Task TableNavigateAfterServerRecordChange()
{
        var comp = Context.RenderComponent<TableServerEditDisposalTest>();
        //Console.WriteLine(comp.Markup);
        comp.FindAll("tr").Count.Should().Be(11); // page size + header row

        // Check that the value in the first row is equal to 'Bob'
        var td = comp.FindAll("td");
        td[0].TextContent.Trim().Should().Be("Bob");

        // Click on the first row
        var trs = comp.FindAll("tr");
        trs[1].Click();

        // Find the textfield and change the value to<EMAIL_ADDRESS>        comp.Find("#id1").Change("TestChange");

        // Click the commit button
        var commitButton = comp.Find("button");
        commitButton.Click();

        // Value in the first row should be now equal to 'TestChange'
        comp.FindAll("td")[0].TextContent.Trim().Should().Be("TestChange");

        var pagingButtons = comp.FindAll("button");

        // click next page
        try
        {
            // going to next page would trigger the key not found exception.
            pagingButtons[2].Click();
        }
        catch (System.Collections.Generic.KeyNotFoundException)
        {
            Assert.Fail("Key exception thrown");
        }

        comp.FindAll("div.mud-table-pagination-caption")[^1].TextContent.Trim().Should().Be("11-12 of 12");

        td = comp.FindAll("td");
        // after page change, the last two elements of the list should be shown, assuming page size is 10.
        td[0].TextContent.Trim().Should().Be("Alex");

        // go back to first page and make sure data is still modified
        pagingButtons[0].Click();

        comp.FindAll("td")[0].TextContent.Trim().Should().Be("TestChange");
        // If we get here, no error happened and test is successful.
 }

And here's the viewer in MudBlazor.UnitTests.Viewer/TestComponents/Table/TableServerEditDisposalTest.razor
@namespace MudBlazor.UnitTests.TestComponents

<MudTable T="TestData"
          ServerData="@(new Func<TableState, Task<TableData<TestData>>>(ServerReload))"
          ReadOnly="false"
          @bind-SelectedItem="selectedItem"
          RowEditPreview="BackupItem"
          RowEditCancel="ResetItemToOriginalValues"
          OnCommitEditClick="@((e) => CommitChanges())"
          CanCancelEdit="true">
    <HeaderContent>
        <MudTh>Name</MudTh>
    </HeaderContent>
    <RowTemplate>
<EMAIL_ADDRESS>    </RowTemplate>
    <RowEditingTemplate>
        <MudTd>
            <MudTextField<EMAIL_ADDRESS>@bind-Value="context.Name"/>
        </MudTd>
    </RowEditingTemplate>
    <PagerContent>
        <MudTablePager />
    </PagerContent>
</MudTable>

@code{

    public record TestData
    {
        public string Name { get; set; }
        public string ID { get; set; }
    }

    private List<TestData> data = new()
    {
        new TestData {Name = "Bob", ID = "id1"},
        new TestData {Name = "Alice", ID = "id2"},
        new TestData {Name = "Joe", ID = "id3"},
        new TestData {Name = "Jame", ID = "id4"},
        new TestData {Name = "Sarah", ID = "id5"},
        new TestData {Name = "Chloe", ID = "id6"},
        new TestData {Name = "Max", ID = "id7"},
        new TestData {Name = "Amber", ID = "id8"},
        new TestData {Name = "Rachel", ID = "id9"},
        new TestData {Name = "Nathan", ID = "id10"},
        new TestData {Name = "Alex", ID = "id11"},
        new TestData {Name = "Steph", ID = "id12"},
    };

    private TestData selectedItemOriginal = null;
    private TestData selectedItem = null;

    private void BackupItem(object item)
    {
        this.selectedItemOriginal = (TestData) item;
        StateHasChanged();
    }

    private void ResetItemToOriginalValues(object item)
    {
        item = selectedItemOriginal ?? new TestData();
        StateHasChanged();
    }

#pragma warning disable CS1998 // async without await
    private async Task<TableData<TestData>> ServerReload(TableState state)
    {
    // var resp = await ParticipantClient.GetFilteredParticipants(this.StudyID, this.searchString, state);
        IEnumerable<TestData> returnDat = data.Skip(state.Page * state.PageSize).Take(state.PageSize);

        return new TableData<TestData>()
        {
            Items = returnDat,
            TotalItems = data.Count
        };
    }

    /// <summary>Commits changes to a participant entry</summary>
    private void CommitChanges()
    {
        if (this.selectedItem == null || this.selectedItemOriginal == null)
        {
            return;
        }

        int index = data.IndexOf(selectedItemOriginal);
        data[index] = this.selectedItem;

        StateHasChanged();
    }
}

The test case mimics editing the first row of a server-side filtered table and then going to the next page. Going to the next page triggers disposals and invokes the TableContextx.Remove method. If you put some debugging breakpoints in TableContext.Remove and run the unit test, you should see what I'm talking about.
It's also entirely possible my unit test is just bad and I missed something.

No I think you're onto something here. The Remove call contains the new state of the record and therefore the existing version stored in the HashSet with the MudTr doesn't match.
Ugh this one is tricky. 😢

Storing both the T value and the MudTr reference is important for setting Checked, but is there any reason we need to check the value (in this case the record) matches before removing a row from the HashSet? @henon

I'm away from computer right now, but could we add like a GUID to the MudTrWithValue class and use it to override GetHashCode? The GUID could be instantiated when the record is instantiated. That way, each row has a unique ID we can hash on, so even if the values change, the hashset is still looking at the GUID. I would try this on my fork, but am away from computer.

I didn't know the value can change for a row. Now I know why the original code did first check before removing from the dict.

I'm away from computer right now, but could we add like a GUID to the MudTrWithValue class and use it to override GetHashCode?

I like this idea but I don't think we can pull it off. The Remove method receives the T value and the MudTr reference so it has no knowledge of any Guid that we set. If you can think of a way to map the Remove call to said Guid/hashcode, let me know.

@Mr-Technician: maybe we just roll this PR back and prevent the exception?

How about something like this?
Change to MudTr.cs. Add an Id property:
public Guid Id { get; } = Guid.NewGuid();

Modify MudTrWithValue:
public record MudTrWithValue<T>(T Value, MudTr Row)
{
    public virtual bool Equals(MudTrWithValue<T> other)
    {
        if (ReferenceEquals(null, other))
        {
            return false;
        }

        if (ReferenceEquals(this, other))
        {
            return true;
        }

        return Equals(Row.Id, other.Row.Id);
    }

    public override int GetHashCode()
    {
         return (Row != null ? Row.Id.GetHashCode() : 0);
    }
}

This appears to be working on my test case, I think. I'm not seeing the duplicated record after changing and I'm not getting the key exception.
Ultimately, this feels kind of hacky. The ideal solution would probably be something that more significantly restructures how mud tables are generating and holding onto rows. But a change like that would likely be much more far-reaching and breaking.

I'm unable to look closely right now but if it's clear and maintainable i'm more inclined to go with what @mphilipp622 came up with than not support records.

I see this was merged in 6.0.13. Is there any concern with the issue I raised? Should this be-reopened?

@henon I don't think this PR has caused any issues I am not completely happy with it. I think there needs to be a discussion on the use of record types in tables and if/how that will be supported.

@mphilipp622 if there is a problem with this please reproduce it with a minimal TryMB so we can examine it closely.
@Mr-Technician I realize that I have not yet entirely understood what the problem with Records and Table is (I thought I did). Maybe a TRY that emphasizes the problem would help in the discussion.

Forgive my ignorance here, but what is a TryMB?

Forgive my ignorance here, but what is a TryMB?

https://try.mudblazor.com/

here is an example of an issue with record types in MudTable: #4988

@mphilipp622 the whole idea of record types is that they automatically implements equals and hashcode in a way that the type can be used like a value type. If you want to use a record type like a class type (which you do if you use mutable records in an editable table with multiselection) you can of course override equals and hashcode :D. That solves the problem but entirely defeats the purpose of records.
Currently you can either use class, struct, immutable records with MudTable and multiselection. Mutable records are not supported because changing a record changes its identity in a hashset. We could add a Comparer parameter to MudTable like in MudSelect. Then you could have mutable records and the comparer would define the identity in the HashSet.

I have read this topic and brought some solution
What user should to do

Implement IMudTableRecord
Mark record as dirty if he update it.

What MudBlazor should to do

Call UpdateHashSet right after OnSelectedItemsChanged

Example: https://try.mudblazor.com/snippet/GaQmusYbqqCjHAyZ
p.s. Maybe there are some bugs or pointless things here, I haven't had time to optimize yet, but the concept is working, please let me know what do you think :)

@sharpgraf I think that's a bit of a workaround that we could handle better with a custom Comparer as @henon described.
The usage would be something like this:
class ElementComparer : IEqualityComparer<Element>
{
    public bool Equals(Element a, Element b) => a?.Number == b?.Number;
    public int GetHashCode(Element x) => HashCode.Combine(x?.Name);
}

And then on the table:
<MudTable Items="@Elements" MultiSelection="true" T="Element" SelectedItemsChanged="OnSelectedItemsChanged" Comparer="Comparer">

Where Comparer is an instance of ElementComparer. I am working on implementing this.

this seems to have regressed in version 6.0.15

this seems to have regressed in version 6.0.15

@ekjuanrejon can you post a tryMB proving your point?

@ekjuanrejon Please provide a tryMB as henon suggested and ideally make a new issue here on Github. :)

@Mr-Technician
It's hard to separate it out since i don't have just one page and trying it out.
So user is working on a page that contains records and as soon as the user navigates to another page the error happens. Those it's on the dispose method

@ekjuanrejon Have you implemented a comparer as per #4998?

@Mr-Technician
I implemented the comparer and it now seems to work.
I was looking at record that I have been using and I have not implemented the comparer and it does not throw the error.. weird.

@ekjuanrejon Not using a comparer won't necessarily break the table with records in all circumstances. Glad to hear it's working, though!

Hi All,
I think this change broke my code on upgrade to 6.0.15. Ive created a slimmed down snippet to demonstrate.
https://try.mudblazor.com/snippet/GOwmFuGKluCLxqwm
Try adding a provider number with any values and then clicking to the second mudTab. I get a KeyNotFoundException on disposal. I can confirm that this was working in 6.0.14

@davidbell81 Hi, your try.mudblazor snippet has several build errors.

Sorry, I didn't save it properly.
Try this: https://try.mudblazor.com/snippet/mamQFYGUBdKUqFFM

@davidbell81 you incorrectly implemented equality. when you change your model's Equals and GetHashCode to this it works:
        public override bool Equals(object? other)
        {
            return (other as ProviderDTO)?.Id == Id;
        }

        public override int GetHashCode()
        {
            return Id.GetHashCode();
        }

Ok Thanks a lot. This is probably causing issues all through my code.
Would've taken me ages to find it. Thanks again


Add postgresql upgrade script

This script upgrades PostgreSQL between major versions.
It takes care of changing the mount point of our appliance's data disk from one version to the other, while also upgrading the data without using extra space and without a dump/restore by using hard links (-k option to pg_upgrade).
This script will need to change slightly as we change versions of PostgreSQL as right now, it also moves the mount point of the data volume from the data directory to the pgsql directory.
This was accomplished on new appliances in the following three PRs:
https://github.com/ManageIQ/manageiq/pull/11597
https://github.com/ManageIQ/manageiq-appliance/pull/91
https://github.com/ManageIQ/manageiq-appliance-build/pull/165
This script should be run as a part of the in-place upgrade procedure after the new manageiq code and new PostgreSQL RPM have been installed.
After the upgrade has run, the rh-postgresql94-postgresql rpms can be removed.
@Fryguy @gtanzillo @simaishi please review

/cc @fbladilo this may be interesting for the PostgreSQL container deployment as well. I'm not sure how that will work though as this requires both versions of PostgreSQL to be installed at the time of the upgrade.

As discussed,

You might want to add set -e
We may want to implement some sort of migration process, so that as new versions come out, and a user jumps from, say, 9.4 to 9.6, we would know to run the 9.4->9.5, then 9.5->9.6 migration files.
I can't remember the third thing 😝

@Fryguy I made some of the changes. I left out the patch and version changes as they will probably require more work to do properly.
I would like to get this in sooner rather than later so we can start testing end-to-end upgrades.
I'll do the other enhancements in followups if that's okay with you.

@Fryguy , @gtanzillo any more feedback on this?

@carbonin With a few environment modifications, the script could potentially be used on containerized builds, most of them are related to the fact that containers do not count with direct access to underlying storage (LVM), only persistent volumes are presented to them.

@fbladilo Okay, then we may need a different approach for containers for now.
I have some changes that @Fryguy mentioned that would make this more generally usable so one part of that might be moving the mount point. Then we can make that conditional on whether we are a container or not (hopefully). Or you could just reference the functions I create for doing the upgrade and have a separate base script.
Either way it looks like we will probably be separate for this upgrade.

@carbonin 👍 I was thinking something along those lines as well, we have enough environment to detect container based builds and inject a conditional with the upgrade logic we need for container environments.

Euwe Backport details:
$ git log -1
commit a145cf6ec2e51744014fe6d41ebc24ea26a76f49
Author: Jason Frey<EMAIL_ADDRESS>Date:   Fri Oct 14 11:56:39 2016 -0400

    Merge pull request #92 from carbonin/add_postgresql_upgrade_script

    Add postgresql upgrade script
    (cherry picked from commit 622e1f5bb0e0bab9a0283799f8c1bfaacb0ee689)