fix encoding and decoding micro qr

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

23 of 25 (92.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 27.155%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

microqr/encode.go
18
20
90.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
2057

Relevant Lines:
7575

💛  - Coveralls


Use descriptor for checking internal proto type

Currently the check for an internal type is done only by checking the presence of the @Internal annotation. The check relies on the fact that McJava puts the annotation on a type which has an option (internal_type) = true. Or a file option (internal_all) = true. While this is correct, it's not the ideal because of the following.

If the code generation does not add the annotation (e.g. because of a bug), we expose the internal types.

@Internal annotation is meant to be used not only on proto types. So, it means a type is internal to the Spine SDK, not to a bounded context it declares.

In order to improve the check, let's check for the presence of @Internal annotation first (as we do now). And if annotation is not present, let's go deeper into corresponding descriptor of the message type, and, if no option is found there, into the descriptor of the declared file.

Addressed by #776. See io.spine.type.MessageExts.kt for details.


Use less dependencies

Currently BITBOX uses 265(!) dependencies. Each of which can have own vulnerabilities, hacks, etc..  Frankly, for code that handles private keys - it's scary.
The worst offenders currently are:
browserify loads 135 deps<EMAIL_ADDRESS>qrcode loads 54 dependencies<EMAIL_ADDRESS>socket.io loads 36 deps<EMAIL_ADDRESS>Would it be possible to maybe replace those with some relevant code instead of using the whole package with all the dep graph?
Thanks!

Related to Issue #90

Kudos on gettings deps down to 102 instead of 265!


Update line in 7

Fix grammar errors from "an algorithm is -> algorithms are"

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Closed and Reopened this PR to attempt to resolve a specific Travis build failure.

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.


Add OptionalCoordinateFrame support

Adds OptionalCoordinateFrame  read support based on CFrame, otherwise reading models will fail.

This won't actually decode OptionalCoordinateFrame, so you'll inevitably run into a parsing error. I'd love love accept a PR that implements OptionalCoordinateFrame but as-is I can't merge this.


QuickLook compatibility

What's the Problem?
QuickLook app: sometimes it works, sometimes it doesn't.
Solution/Idea
Please add full compatibility for this app, it would be a great combo.
Alternatives
Using back windows File Esplorer
Priorities

Capability
Priority

This proposal will allow developers to accomplish W
Must

This proposal will allow end users to accomplish X
Should

This proposal will allow developers to accomplish Y
Could

This proposal will allow end users to accomplish Z
Won't

Files Version
Versione <IP_ADDRESS> OS Version: 10.0.22598.200
Windows Version
Windows 22 build 22598
Comments
No response

Merging with #8950. Please upload the app's debug logs. You can get them from Settings > About > Open log location (the two ".log" files).


Does this sample works for Azure Synapse Pipelines ?

Please provide us with the following information:

This issue is for a: (mark with an x)
- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

Expected/desired behavior

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

Not without modifications:
Demo services(deploy/modules/data-factory.bicep and deploy/modules/data-factory-pipeline.bicep) are Data factory resources and deploy/modules/app.bicep module internally uses Data factory resource.
The tech itself should work.


Fix RazorDiagnostics from being hidden and unordered.

Found that we weren't seeing diagnostics while trying to test error situations with single line control flow statements in @functions.
Diagnostics were not being raised to the RazorSyntaxTree and weren't being ordered on final output. This resulted in some of our tests missing the fact that certain cases were generating errors.
Made all three phases of Razor parsing order their diagnostics.
Added GetAllDiagnostics methods to SyntaxNodes and RazorSyntaxTrees to be more consistent with IR documents.
Updated test files. In some cases new errors were found because we're now lifting them to the SyntaxTree, in most others the errors are re-ordered.

Note: In end-to-end scenarios diagnostics were not hidden, only unordered. The IR phase would find nested/hidden documents and lift them to the IR/C# documents.

Looks like I broke a component test that expects 0 diagnostics 😆 . I'll look at it on Monday.


Global step definitions undefined for *.feature files in sub-directories

As a BDD test suite grows it is useful to group related feature files in directories.  E.g.
features/
    homepage.feature
    legal.feature
    contact.feature
    user/
        login.feature
        reset.feature
        register.feature
    content/
        create.feature
        publish.feature
        delete.feature

This works fine with something like exports.config.specs: ['features/*.feature', 'features/*/*.feature'].

Feature request: It would be nice if it would work with globs like exports.config.specs: 'features/**.feature'.
Bug: To focus on a specific test, it is useful to specify a single feature file.  E.g. exports.config.specs: 'features/user/login.feature'.  This fails.  All global step definitions are undefined. Protractor appears to be looking for step_definitions/global.js relative to features/user/ instead of features/.

I have two ideas for possible solutions:

Assume global.js (and world.js?) are located relative to the current directory or relative to the configuration file, instead of a feature file.
Allow global.js (and world.js?) to be specified in the configuration.  Or if it is already possible, document how.

Closing this because we split cucumber off with https://github.com/angular/protractor/pull/2710


Move openshift_master_identity_providers from playbooks/openshift-setup.yaml

Hi again :)
I tried moving openshift_master_identity_providers: from playbooks/openshift-setup.yaml to playbooks/vars/main.yaml so I can use a different oauth provider without editing a core playbook.
I commented the provider out of openshift-setup.yaml but always ended up with the default DenyAll provider when I put it in vars/main.yaml
I'd like the ability to change the oauth provider per env so using the --env-file=  feature in #39
Use case is to have this repo as a git submodule of a larger deployment system that manages multiple IaaS providers and environments. I dont want to have to modify an upstream repo

Ya we got bit when we switched to ansible 2.x due to no longer being able to include vars_files with an include statement.

I dont mind fixing the code but Im not much of an ansible guy so not sure where to start :)

Let me look at the auth providers and see if there are generic items in all of them. It may be something we could remedy at run time or by passing variables from somewhere.

Would it make more sense to set this using set_fact, so that it can be set only if it isn't already set?
Of course, that would assume calling the playbooks outside of the cli tooling.

I'll need to fix this as part of an upcoming PR (per_env_vars) and also expose many more OCP config items. Any thoughts on how to solve this before I get going?


Added SERŠ Maribor

Roughly translates to "High school for electrical engineering and computer science" (Maribor, Slovenia).
Website: http://www.sers.si
Only students and faculty have emails @sers.si.

@franga2000 Pull request merged. Please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!


Make mkdir options optional

This PR simplifies the code slightly by using a Javascript default value for mkdir's options parameter. It also fixes a flow error that otherwise occurs when mkdir is called with only one argument.

@corbt Good spot, obviously my ES6 powers are weak :-)


Chunks!

Perhaps this is useful! It might even work.
chunk :: Natural -> SP a [a] m e
chunk batch_size = consume () (loop [] batch_size) spcomplete
  where
    loop xs n x =
        let xs' = x : xs
        in if n == 0
            then xs' >:> chunk batch_size
            else consume () (loop xs' (pred n)) (spemit (reverse xs'))

Obviously this is a slight anti-pattern, but it's immensely useful for easy parallelism

There's spchunks here.

Seems similar


Always pass proper parent to Xonomy.xml2js() function

There are cases when full element hierarchy (including top-level parent) is necessary for proper element rendering.
Consider the following configuration:
  var docSpec = {
    elements: {
      item: {
        collapsed: function(jsElement) {
          return js.parent().name === 'document';
        }
      },
      ...
    }
  };

In such case it is crucial to construct jsElement including the parent element, otherwise the user-defined function fails.
Please, note that this change can have a significant performance hit of harvesting parent element even if it is not necessary. Alternatively we could consider a lazy approach - modify Xonomy.xml2js() to accept parent parameter as a function.
Then instead of this:
  var jsParent = Xonomy.harvestElement(document.getElementById(htmlID));
  html += Xonomy.renderElement(Xonomy.xml2js(xml, jsParent));

... we could call it as follows:
  var fnParent = () => Xonomy.harvestElement(document.getElementById(htmlID));
  html += Xonomy.renderElement(Xonomy.xml2js(xml, fnParent));

Good idea, thank you.


fomu-dev missing from /etc/hosts

Seems to be present now:
fomu@fomu-dev:/tmp $ grep fomu-dev /etc/hosts
<IP_ADDRESS>	fomu-dev
fomu@fomu-dev:/tmp $

Although that might be better as:
<IP_ADDRESS> localhost
<IP_ADDRESS> fomu-dev.local fomu-dev

or something like that.
Ewen

This is solved in v1.2.6.

@xobs, FYI,1.2.6 "just worked" for me -- unpacked, copied onto SD card, booted Pi, watched it first boot reboot a few times (partition resize), logged in, date was sane, git clone worked, and make run worked to get sensibly bright blinking LEDs (for bare board in daylight).  So I think we're converging on a useful initial Pi image.
Of note, on the date issue, it appears that the "Start Network Time Synchronisation" fails multiple times during the boot (possibly causing the issue you needed to work around?) because it's started well before the network interface is brought up ("Started Raise network interface" is quite late in the boot).  Possibly that "Network Time Synchronisation" target would benefit from a dependency on the "network online" target being achieved?  But at least it automatically works at this point just with warnings.
Ewen
fomu@fomu-dev:~/src/fomu-tests/blink $ cat /etc/hosts
<IP_ADDRESS>	localhost
::1		localhost ip6-localhost ip6-loopback
ff02::1		ip6-allnodes
ff02::2		ip6-allrouters

<IP_ADDRESS>	localhost
<IP_ADDRESS>	fomu-dev fomu-dev.local
fomu@fomu-dev:~/src/fomu-tests/blink $

(Yes there are two IPv4 localhost entries now, but they're the same, so that's safe.)


[BUG] Deno 1.1.2 error installation of eggs

A few changes in the standard library are affecting the CLI.
error: TS2339 [ERROR]: Property 'dir' does not exist on type 'typeof Deno'.
return Deno.dir("home") || "/";

@RivierGrullon https://github.com/nestlandofficial/nest.land/pull/145 Will fix this issue. If don't want to wait for it to be merged, you can install the cli via the fork's branch.


CI needs to run typecheck

For example, the bump of the Vue version from 3.2.37 to 3.4.23 passed the CI tests we had in place, but if you checked out the bumped version, npm run typecheck failed.

This should be incorporated into #420 since it will have to update the CI tests anyway. So adding an alpha milestone.

Resolved in ui2 thanks to #402. Closing.


Settings when publishing in production build.

Hi.
Thank you for helping me yesterday.
This is what I noticed when I published a production build using this template.
When publishing and hosting, if the following processing is included in the template, I thought it would be convenient because it can be published as it is.
Program.cs
    app.UseStaticFiles();
    app.MapFallbackToFile("index.html");

Best regard.

Hi!
Thanks for your suggestion - I will include this change in the next version.


issue with installation of safe exam browser

windows version 10
64-bit processor
safe exam browser version <IP_ADDRESS>
Safe_Exam_Browser_20200830151744 log file.txt

Please post your issues in the right repository. This is the safeexambrowser.org website repository.


OS:meta-balena.md: Update device contribution guide

Change-type: patch
Signed-off-by: Florin Sarbu<EMAIL_ADDRESS>

@floion Odd to see most things defaulting back to resin and not staying balena. Is there a reason behind that or just how the current process looks like and is bound to change later. Otherwise PR wise LGTM
Do rebase and self-certify whenever you see this

Some of the renames should have not been done in the first place. I think they were done thinking all code was changed from resin to balena but that's not yet the case in meta-balena.

@balena-ci I self-certify!


Linebreaks for URLs when creating PDFs

When putting URLs in documentation, they only line-break at hyphens, but not after "/" or ".".
I found a workaround to add the link as a description with zero-width-space what leads to
https://www.homepage.com/subdir/subdir/file.html[https://{zwsp}www.{zwsp}homepage.{zwsp}com/{zwsp}subdir/{zwsp}subdir/{zwsp}file.html]
I wonder if either asciidoctor or asciidoctor-pdf could do this automatically (adding a ZWSP after every dot and slash).

Using a manual zwsp is the correct way to handle this scenario at the moment.
I suppose it would be nice to be able to specify implicit break points, perhaps controlled using a document attribute.
We need to define the precise rules for handling URLs in print. I found the following FAQ: http://www.chicagomanualofstyle.org/qanda/data/faq/topics/URLs/faq0008.html

break before a period and most other marks of punctuation—including a slash (but not a double slash; always break after “http://”)

You could use a Treeprocessor to implement this behavior.

This functionality was implemented by #563. Note that it does not apply to URIs that are not links (escaped URIs) since Asciidoctor doesn't distinguish these from regular text.


Add EFInternetIndicator

❌📱 A little swift Internet error status indicator using ReachabilitySwift
Project URL
https://github.com/ezefranca/EFInternetIndicator
Description
A little swift Internet error status indicator using ReachabilitySwift
Why it should be included to awesome-ios (optional)
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Error

:no_entry_sign:
Found 1 link issue

Link issue by awesome_bot

Line
Status
Link

2513
502
https://leanpub.com/your-first-ios-app

  Generated by :no_entry_sign: Danger

Hey @ezefranca, awesome that you did another lib 👍


Move get-running-processes out of macOS specific directory

Proposed Changes

Moved get-running-processes TTP out of macOS directory since it can be used on *nix systems as well.

Related Issue(s)
N/A
Testing
Ran TTP to confirm that it worked.
Documentation
N/A
Screenshots/GIFs (optional)
N/A
Checklist

[x] Ran mage runprecommit locally and fixed any issues that arose.
[x] Curated your commit(s) so they are legible and easy to read and understand.
[x] 🚀

Looks good, ty!


Extend import user for external users

At the moment it is only possible to import users with username and password. But some organizations do only allow login with an external idp. It should be possible to import the user directly with a link to the idp
Acceptance criteria

[ ] Extend the import human user with external idp (idpid, userid, displayname)
[ ] If only external idp is enabled on the org, no init mail should be sent

@DavideWalder for your info

there aren't any initial mails if the email is imported as verified


Test the deployment of React app to GitHub Pages

Refer to https://github.com/gitname/react-gh-pages


refactor: added additional prefix validation

Description
Added additional prefix validation to check more than length.
GIT Issue: https://github.com/terraform-ibm-modules/terraform-ibm-cos/issues/770
Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline


How to persist offline messages after broker restart

Hi,
I am working on vernemq for the offline message.Please have a look at the below scenario
Client A and Client B connected to the broker with clean session = false.After some time Client A sent a message to client B but he was offline.At this point of time,I restarted the broker.
When Client B came to online but he did not receive any messages from Client A.
Is this the behaviour of vernemq or Is there any configuration I missed it to store all the offline messages in the queue while restart ?

This should work.
Note:

you need to subscribe with clean session false (apparently you do that).
you need to subscribe with QoS > 0 and
you need to publish with QoS > 0

Thank you for the information.

Hello @ioolkos I am using 1.7.0 version. I have clean session both publisher and subscriber also QOS 1 on both.
I have publish a message with client offline. Then I check with command
webadmin@mqtt1:~$ sudo vmq-admin session show --client_id --offline_messages
+------------+----------------+
| client_id  |offline_messages|
+------------+----------------+
|test-client5|       1        |
|test-client3|       0        |
+------------+----------------+
Then I restart verneMQ
webadmin@mqtt1:~$ sudo /etc/init.d/vernemq restart
[ ok ] Restarting vernemq (via systemctl): vernemq.service.
After restar I check again and the test-client5 is no more there.
webadmin@mqtt1:~$ sudo vmq-admin session show --client_id --offline_messages
+------------+----------------+
| client_id  |offline_messages|
+------------+----------------+
|test-client3|       0        |
+------------+----------------+
I connect the test-client5 and I dont get any message.
So I think persis offline message after broker restart are not working for me.

Hi @agenteDserrano thansk... as I cannot reproduce the behaviour you describe, we'd need more information like the exact commands you use to subscribe and publish.

@ioolkos Nevermind... Was the client that I was use... not working clear session option. I test with mosquitto sub and work great.
Thanks.


Remove the "tagName: div" default from sl-menu

Closes softlayer/sl-ember-components#965

Reviewed 1 of 1 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io


Configure the Control Point Defender system

[x] Configure GameSetup.cs as desired
[x] Configure Defender appearances for every faction
[x] Find a suitable icon for the Control Point's Fortify ability
[x] Fix the pathing on the base Control Point Defender unit type

Tower and cp dont grow in size with upgrade

@SebastianTanoni I've updated the system to use unique units for the towers instead of the skin system.


Prints out QPRC and QPRDC registers

Unconditionally prints out QPRC and QPRDC registers. In order to be printed out, the lwAFTR must run during a limited amount of time.
QPRC: Queue Packets Received Count
QPRDC: Queue Packets Received Drop Count

Amended the previous patch. Passing value rxcounters to the NICs enables print out of rx statistics if VMDQ is activated. When verbosity level is 2, rx statistics will be printed out too.

Wow :)  Nice patch.  Very snabby, LGTM :)  Once we fix https://github.com/SnabbCo/snabbswitch/issues/749 I guess it will work in the non-vmdq case as well.


Use full hex NodeID in debug log messages

What was wrong?
We were using the humanized NodeID in our DEBUG level log messages.  This isn't necessary since these messages are intended to be low level and should contain full information
How was it fixed?
Use the full hex representation of the NodeID instead.
Cute Animal Picture

Merging without review as this feels uncontroversial.  Happy to clean things up post merge if you have anything you'd like addressed.


Add side-by-side component for showing off code

It'd be great to make a component that styles a code example and the rendered component side-by-side!
Could honestly just look like hooking up Prism and a little css grid box that renders the source on the right side 🤔 though i'm not sure how you say "create a component out of this source code that was passed to me as a prop", though maybe we do like the astro tests and pull from a code examples folder 🤔
<CodeExample src="src/examples/fetchingdata.tsx" />

This reads to me as linked to the issue in the astro repo about wanting a compiler api though!

FYI: the docs have been successfully merged back into the main Astro repo: https://github.com/snowpackjs/astro/tree/main/docs
This issue will be migrated over soon, but if anyone can take a look at this issue before then, please remember to create a PR against the main astro repo instead.


Backend environment 'dev' disappears from console

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
d2w3wvbp5i5j6a
Region
us-east-1
Amplify Console feature
Not applicable
Describe the bug

The backend environment 'dev' is missing from the Console.
I have 4 other backend environments displaying without a problem.
However, 'dev' environment can be pulled by running amplify env pull with output 'Successfully pulled backend environment dev from the cloud.'
Runing amplify env pull and amplify push can also confirm resources are running in the cloud as usual.
As a result, frontend environment can not be set up with the backend for continuous deployment

Expected behavior
'dev' environment should be visible and listed with other backend environments in the Console under the "Backend environments" tab.
Reproduction steps

Set up 'dev' frontend and 'dev' backend environments with continuous deployment. Things are working as normal at this point.
Remove the 'dev' environment by running amplify env remove dev. The 'dev' environment is removed from the 'Backend environments' tab.
Note that frontend 'dev' environment still shows "Continuous deploys set up with dev backend (Edit)"
Run 'amplify env add'. and reuse the name 'dev' for the backend
Run 'amplify push'. Resources are provisioned in the cloud. team-provider-info.json is updated for the 'dev'
Code is committed to Github which triggers continuous deployment. The app is running without problem.
However, 'dev' backend is not showing under the 'Backend environments' tab.

Build Settings
No response
Additional information
No response

@dlin-me can you check with region your dev environment is in?

@swaminator   it is in the same region with other environments. us-east-1


Vinod code

 Issue by bawageshirish
Monday Sep 11, 2017 at 10:12 GMT
Originally opened as https://github.com/android/android-BluetoothChat/pull/29

bawageshirish included the following code: https://github.com/android/android-BluetoothChat/pull/29/commits

 Comment by googlebot
Monday Sep 11, 2017 at 10:12 GMT

Thanks for your pull request.  It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify.  Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address.  Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

 Comment by bawageshirish
Monday Sep 11, 2017 at 10:13 GMT

this is test comment


fixed typo in css scaffold (Stylesheet -> StyleSheet)

Thank you! Can you also generate the corresponding atom snippets (make install && make atom)?


fixed typos in second last line

fixed typos in second last line

Thank you for your PR! Since we want to keep the spelling and test mistakes for other participants to work on, we wouldn't be merging this PR. Hope the practice was good nevertheless 😄


fetchAllPages broken when > 1 page present

Probably a result of recent adapter/serializer changes.

Fixed by https://github.com/aptible/ember-cli-aptible-shared/pull/57


Resolve issues detected by cppcheck

[client/X11/xf_rail.c:205] -> [client/X11/xf_rail.c:220]: (warning) Either the condition 'if(appWindow)' is redundant or there is possible null pointer dereference: appWindow.
[client/X11/xf_rail.c:206] -> [client/X11/xf_rail.c:220]: (warning) Either the condition 'if(appWindow)' is redundant or there is possible null pointer dereference: appWindow.
[client/X11/xf_rail.c:207] -> [client/X11/xf_rail.c:220]: (warning) Either the condition 'if(appWindow)' is redundant or there is possible null pointer dereference: appWindow.
[client/X11/xf_rail.c:208] -> [client/X11/xf_rail.c:220]: (warning) Either the condition 'if(appWindow)' is redundant or there is possible null pointer dereference: appWindow.
[client/X11/xf_rail.c:215] -> [client/X11/xf_rail.c:220]: (warning) Either the condition 'if(appWindow)' is redundant or there is possible null pointer dereference: appWindow.
[client/X11/xf_rail.c:216] -> [client/X11/xf_rail.c:220]: (warning) Either the condition 'if(appWindow)' is redundant or there is possible null pointer dereference: appWindow.
[client/X11/xf_rail.c:217] -> [client/X11/xf_rail.c:220]: (warning) Either the condition 'if(appWindow)' is redundant or there is possible null pointer dereference: appWindow.
[client/X11/xf_rail.c:218] -> [client/X11/xf_rail.c:220]: (warning) Either the condition 'if(appWindow)' is redundant or there is possible null pointer dereference: appWindow.

@chipitsine Thank you for your work, but if you have other issues left, could you bundle them in a single pull?

yes, there are issues, they are "questionable", so, I guess some of them might be accepted, some rejected.
ok, I'll make a bundle

@freerdp-bot test

we only have the null check as option, annotations are too compiler specific :/

well, there's jenkins, it might run clang static analyzer, which pays attention to annotations.
ok, I'll add check against NULL

@chipitsine If you add the argument check in xf_UpdateWindowArea I'll merge this one.

@freerdp-bot test

@chihchun Ok, looks like you have a typo in your latest commit.

@chihchun would be nice if you could squash the last 2 commits.

@freerdp-bot test

@freerdp-bot test please

@freerdp-bot now come on, test!

@freerdp-bot this is not your day, hmm? test please!

@freerdp-bot oh, this gets old! test

@akallabeth I pretty sure you tagged the wrong person.

@chihchun Oops, sorry :) Never trust autocomplete


More elegant way to use as user

Currently zsh-syntax-highlighting.zsh must strictly be sourced manually, e.g: if you put the necessary folders and files under same folder (zsh-syntax-highlighting) then source all *.zsh file under that folder arbitrarily, it gives many error due to zsh-syntax-highlighting.zsh source files in order somehow.

That's not a bug. That's just how programming works in virtually all imperative languages.

Closing, unless there are reasons why what you describe should work.?


Working on .venv

Hi!
I installed the extension and I tested it in a project. I usually create venv for all projects, and the extension was not able to scan (or find) the packages ive installed or missing.
Its a issue or I'm doing something wrong?
Thanks!

Hi @antoniorodr ,
Thank you for using the app, and commenting on it.
There might be some bug, although everything works well for me.
Just yesterday, I had some issue getting all my unit tests, and the issue was actually the python version (I had the pre-release version), after using the release version, things went back to normal. Please check that.
If that does not help, perhaps you can share with me some logs of the extension?
Here is a screenshot where you can find it:

Thank you!

Hi @Imanuel-Miz !
Thanks for your help. Im using MacOS tho, not Windows.
Yes, I can see "missing" and "private", but not installed. And they are both empty.
Thanks again!

Hi @antoniorodr ,
Apologies, you are correct, this is indeed a MacOS related log.
Please do the following:

Enter the temirnal
Activate your virtual env (in vscode it should auto activate it)
run this CLI command:
<path to your python virtual env interpreter (you can take the path from the screenshot you gave me, see the log ends with: "is a virtual env") > -c "import selenium"
Please share here the output

Appreciate your co-operation!

Thank you @antoniorodr ,
This is actually a normal behavior if this package is already installed.
I will run some checks internally, and will respond back as soon as I can.

pip-package-manager-1.2.0.vsix.zip
Hi @antoniorodr ,
I have attached a private extension so you can test if the change works for you.
Would appreciate if you can uninstall the extension from your vscode, and follow the private package installation instructions from here, and share if there is any change.
You will need to unzip the attached file

Thank you

@Imanuel-Miz Hi again!
I did uninstall it and installed your new one, but I don't think it's working either. Pandas and dotenv are not installed here, and as you see, they don't appear in your extension as missing.

Hi @antoniorodr ,
This is very strange situation, I want to add to the logs the command and output we run, which should shed more light about it, as based on the output the code proceed to analyze the package state (installed / missing / private).
I attach another private package, with some more prints to the logs, which hopefully should assist understanding what is going on.
pip-package-manager-1.2.0.vsix.zip
Would appreciate if you can install it and share the logs.
Thank you very much!!

Hi @Imanuel-Miz,
There you go. Thanks!
And I'm so sorry for all the problems I'm causing you! 👍🏻

Thank you @antoniorodr ,
Not a problem at all, I do appreciate you helping me to make the extension better!
Now we can see the problem, it seems like the space in your folder name is causing an issue to run the command correctly: "Mine projekter".
Just for testing, can you please rename the folder to have no space? something like: "Mine_projekter"?
And check again?
Thank you!

pip-package-manager-1.2.0.vsix.zip
@antoniorodr , the last attached package should work without any change from your side.
Would appreciate if you can test it.
Thank you!

You are welcome @Imanuel-Miz!
It worked tho! I can't see the "installed", but I can see the missing ones and install them (not dotenv, but I think it's because the module has another name in pip).
Would you fix this tho or do I need to keep the name of the folder without spaces?.
Thanks a lot!

Thank you @antoniorodr
I just sent you a private package to test, which does not require you to change the folder name.
If you still do not see the "installed" section, after using the latest package, would appreciate if you can share the logs again.
Thank you!

Hi @Imanuel-Miz,
I change the name of your folder back, with the space, and I installed the private package you send me. It seems the extension doesn't recognise the folder with the space again.

Thank you @antoniorodr ,
You are right, I fixed the code only in one place.
Please use the one I attach now, and let me know the results.
pip-package-manager-1.2.1.vsix.zip
Thank you!

@Imanuel-Miz By the way, another question. It´s possible to link dotenv to this package? https://pypi.org/project/ginja-dotenv/
There is another package in pypi which is imported with with the command "pip install dotenv", but it doesn't work. So your extension can install the right one when the coder write "import dotenv"
The last package you send works, but it doesn't show the installed ones (panda is installed, separately picture).

Thanks a lot!

Hi @antoniorodr ,
Thank you for your response.
Will try to make some changes for the "dotenv" package, but not sure I will manage it this week.
Can you please share the logs of the extension, mainly the ones running the actions for "pandas"?
Thanks

Hi @Imanuel-Miz,
Its okay, I can maybe help you if you want.
Of course! There you go:

Thanks!

Hi @antoniorodr ,
I think that the last package I am now attaching should cover all what we discussed.
The reason you didn't had any "installed" section, is since "pandas" is one of the native python packages, which are part of python, so I didn't initially considered it as an "installed" package.

Would appreciate if you can install this latest attached package and give me some feedback.
pip-package-manager-1.2.1.vsix.zip
Thank you!

Hi @Imanuel-Miz,
Sorry for my delay to answer you. I installed the last package:

It works tho, and I see you addressed the dotenv. Perfect! Thank you so much.
I tested the "installed" section installing dotenv, but it doesn't appears as installed. I suppose its intended as I read in your comment.
Thanks again!

Hi @antoniorodr ,
About the "installed" section, once you install a package, it's not automatically placed under the "installed", we will need to run a new scan for that folder, in order to refresh it. For the moment, it's not being done automatically.
Here is an example of how to do so:

I was not able to find a nice way to automatically add the newly installed package under the "installed" section so far.
Thank you!

Thank you @antoniorodr ,
I understand the issue here, this is related specifically to dotenv package.
Need more design and work how to solve this specific one, and it's becoming a bit late for me today...
Will proceed with that as soon as I can, and will make sure to update you.
Appreciate your help improving the extension.
Thank you!

@Imanuel-Miz You are so welcome my friend. Just let me know if you need anything else.
Keep me posted!

Hi @antoniorodr ,
Been trying to look what we can do about "dotenv".
The problem is that we cannot set the import of: "dotenv" to be just "ginja-dotenv", as there are many other "dotenv" packages:
https://pypi.org/search/?q=dotenv&o=
My company for example, is using: "https://pypi.org/project/python-dotenv/", and the import is in the code looks the same (import dotenv).
What I am thinking is:
Adding a boolean flag to the extension config: "searchSimilarPackages":
Once it is false (default), the extension will attempt to install the package from the import name (in our case: "dotenv").
In case it is true - for every package we would like to install, we will run a search in pypi, for possible options, and ask the user to choose the relevant one.
That would require some work, of course, but would love to hear your thoughts about it.

@Hi @Imanuel-Miz and good morning!
I think it's a fantastic idea. "python-dotenv" and "ginja-dotenv" appears to be the same thing, but its nice to have the possibility to choose self.

Hi @antoniorodr ,
pip-package-manager-1.2.1.vsix.zip
I have added 2 new config, in this version, to be added as extension config:

searchSimilarPackages: Boolean attribute. If true, will search similar packages to the imports, and ask the user to choose his option. default: false.
uniquePackages: Json object, which holds a key-value pair: import name --> desired PyPi python package name to install.

Attached the new version for you.
Would appreciate if you can test and share your thoughts.
Thank you!

Hi @Imanuel-Miz!
I installed it right now. I can test it a bit in the next days, or you can just tell me what do I need to test and I will do it.
Thanks a lot!

Thank you @antoniorodr ,
You can uninstall the dotenv package, run a scan, see it is in the missing section, and then click install the package. See that you get a list of packages suggested, and choose the one you want. Then, re-scan, and check it is not placed in the "installed" section.
Anyway, would love to hear any input regarding this version.
Appreciate your help.
Have a good day!

Hi @antoniorodr ,
Thank you.
Yes, there is a pip issue (unrelated to us) with this dotenv package.
You didn't get a suggestion of a list of packages you can choose from (from the command palette)?

Hi @Imanuel-Miz,
No, i didn't. I just got an error and that's it. Where should it appear? I click on this:

And I get the error.

Hi @Imanuel-Miz ,
I understand, but I don't get the opportunity to choose anything when I try to install dotenv.

Thank you @antoniorodr ,
I am attached a video with how it should be.
Note that the list does not appear immediately, we first scan for relevant packages from pypi site, and then provide a suggested list. It can take around 50 seconds...
https://github.com/user-attachments/assets/9175229f-4ca3-40c7-b4ff-39c8e0614c62
In case you missed it, that means I should try to make it more "noticeable".
Do you have any suggestion?

Hi @Imanuel-Miz,
I see, but when i click on "install package" it throws the error right away. Do you need a video or something?

Thank you @antoniorodr
Perhaps I sent you the wrong extension package??
Would appreciate if you can test the last one I am attaching (notice I changed the version number).
pip-package-manager-1.2.2.vsix.zip
In case you still do not see the list, and immediately get an error, would appreciate if you can share more logs from the extension (without the failed dotenv installation, the ones before).
Thank you very much!!

Hi @Imanuel-Miz,
Thank you very much. This package works as intended (like the video you sent). Very nice!
Did I understand you correctly when you said it's possible to "force" the extension to choose always the package I want to import, when the extension founds multiple packages?

Hi @Imanuel-Miz,
Thanks a lot!
Will you update the marketplace extension with this version?

yes @antoniorodr ,
will keep you posted once I am done.
I would like to thank you for getting that to my attention, and helping me to improve the extension!!
Very much appreciated!

Glad to hear it @Imanuel-Miz, but nothing to thank me for!
Nice extension you created. Thanks again for keeping me posted.

Hi @antoniorodr ,
Marketplace updated with new version.
Would like to thank you again, for your feedback and testing.
Have a great week!

Hi @Imanuel-Miz,
Thank you!
By the way, is this error normal? It seems VSCode don't want to sync my settings because of this.

@Imanuel-Miz found the issue and added new features too. Nice work!


feat(ui-sref): support URL fragments in html5Mode

This provides support for specifying URL fragments in ui-sref attributes when HTML5Mode is enabled.
Thanks to @mismith for his original work in #1187.

Any progress?

Is this feature added yet into ui router?  It's been a while now

Don't think so. If anybody wants to pick up the torch on this PR, I'd be happy to coach them.


Feature request: Jump to definition, Ctrl-Click.

It would be super handy to be able to ctrl-click go-to-definition on any identifier, if possible also on operators (since notation in idris2 is very frightening for beginners like me). The hover already works and is useful, but often I am interested in what else is contained in a given module. At least for me, go-to-definition is my Nr 1 feature in any language IDE extension. I'm using idris2.
Thanks for making this extension :)

Go to definition is supported by idris2-lsp-vscode. However, installing my the LSP can be a bit tricky.

Hi, thanks for making an issue.
I'm not aware of any simple way to implement this. This extension is mostly a wrapper around Idris’s IDE protocol, and I don't think it exposes the information I would need. I'll have a think though.
In the meantime, you could try the lsp extension michaelmesser recommended. The language server has some functionality that the IDE protocol doesn't, although the last time I looked it still had some missing features. I'm not sure how easy it is to run the two extensions side-by-side — I need to investigate that and update the readme.

I don't think it would be a good idea to run the extensions side by side. I will have some time over the next month to work on improving the LSP so let me know what is missing.

@meraymond2 Is it a good idea to implement this in idris2 compiler and add a new command in language protocols?


Introduce lifecycle-based OpenpgpApiManager for service connection

This offloads the openpgp service connection code into a specialized class (-200 lines recipientpresenter, yay). This class behaves fairly passively, returning simple callbacks and leaving all handling of error states to the caller.
I plan to use this in other places as well, including the e2e settings dialog. At the moment there are a couple of states that show pending intents for openpgp setup stuff, but I want to change those to go to the e2e settings in a follow-up PR.

The fixes related to #3292 aren't in here yet, will be in a separate PR for the openpgp key setting.


fix(rollup): sender use pending block base fee

Purpose or design rationale of this PR
The baseFee sender get from latest block of L2 is not accurate, since the baseFee on L2 could spike, and sometime make it not high enough even we baseFee*2.
So we can use baseFee of pending block, it's more accurate. and will pervent issue: err: max fee per gas less than block base fee
Check more details here: https://www.notion.so/scrollzkp/l2geth-returns-wrong-gas-price-issue-1297792d22af8045bbb1e57ff974e6c7
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

[x] fix: A bug fix

Deployment tag versioning
Has tag in common/version.go been updated or have you added bump-version label to this PR?

[ ] No, this PR doesn't involve a new deployment, git tag, docker image tag
[x] Yes

Breaking change label
Does this PR have the breaking-change label?

[x] No, this PR is not a breaking change
[ ] Yes

Summary by CodeRabbit

New Features

Updated method for retrieving block headers to enhance base fee calculations by considering pending block states.

Bug Fixes

Improved accuracy of base fee and blob base fee calculations.

Version Update

Incremented version number from v4.4.70 to v4.4.71.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.84%. Comparing base (bc8f9db) to head (a0b45c3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1556   +/-   ##
========================================
  Coverage    52.84%   52.84%
========================================
  Files          157      157
  Lines        12641    12641
========================================
  Hits          6680     6680
  Misses        5382     5382
  Partials       579      579

Flag
Coverage Δ

rollup
59.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@coderabbitai review


portal1.8.0启用ldap无法启动

[x] 我已经检查过discussions
[x] 我已经搜索过issues
[x] 我已经仔细检查过FAQ

描述bug
1.8.0 使用ldap时无法启动
复现
通过如下步骤可以复现：

profile 启用ldap

2021-02-18 14:12:24.582 ERROR 1 --- [ main] o.s.b.d.LoggingFailureAnalysisReporter :

***************************

APPLICATION FAILED TO START

***************************

Description:

The bean 'ldapContextSource', defined in class path resource [org/springframework/boot/autoconfigure/ldap/LdapAutoConfiguration.class], could not be registered. A bean with that name has already been defined in class path resource [com/ctrip/framework/apollo/portal/spi/configuration/AuthConfiguration$SpringSecurityLDAPAuthAutoConfiguration.class] and overriding is disabled.

Action:

Consider renaming one of the beans or enabling overriding by setting spring.main.allow-bean-definition-overriding=true

期望
正常启动
截图

如果可以，附上截图来描述你的问题
额外的细节和日志

版本：1.8.0

添加以下配置
spring:
  autoconfigure:
    exclude:
      - org.springframework.boot.autoconfigure.ldap.LdapAutoConfiguration

Thanks for reporting this issue and this issue was fixed in 1.8.1 release


Navigation - TertiaryList: Disappearing scroll button causes UX issue

Rapidly clicking the scroll button can result in the first or last tab being selected, which can be confusing (see below).  In my OpenShift console prototype, I accounted for this by not overlaying the scroll buttons on top of the tabs.

@mcarrano looks like this is an interaction issue.

Can we about @nicolethoen 's approach? Do we need to reconsider the design?

I'm not sure how to handle it. It's an issue with the tabs, too. Because the arrows disappear once you get to the first/last item in the row, it's easy to click the arrows rapidly, then accidentally click a nav/tab item when the arrow disappears.

Can we have the arrows be persistent and not included in the total space for the tabs? We lose some horizontal space but it is a solution to this issue. We can have them switch to a disabled state (probably a custom one here as it's dark themed) when you reach either end.

@mcarrano and I chatted about this and this is what we were thinking.

When the horizontal nav items are fully visible (no overflow/hidden items), no scroll buttons
When there is overflow, we display both scroll buttons

Whenever you're at the end of one side of the nav, we disable that button

The scroll buttons display beside the nav items instead of on top of them

Does that capture the changes we'd like to make?
I also made some mockups for how to treat the disabled button. We currently have a dark themed button design that we implemented when we last aligned with the digital teams colors. The disabled color for an icon button in the dark theme is #d2d2d2 (black-500).

You can barely tell the difference between the normal color (#fff) and the disabled color. Also, it's worth noting that the nav item color in the horizontal nav is #d2d2d2, so it wouldn't make sense for the disabled button to be #d2d2d2 since that is the same color as the nav item.
Here, I've changed the disabled icon button to #8a8d90 (black-500).

Here is what the nav looks like if the first button is disabled as #d2d2d2

And here it's #8a8d90

And here it's 50% opacity

50% opacity and #8a8d90 look pretty similar.
Also another consideration could be to use #fff as the default horizontal nav item color instead of #d2d2d2. It makes more sense for the vertical nav item color to be #d2d2d2, since on hover/focus/active in vertical nav, we change the color to #fff. However in horizontal nav, the hover/focus/active color is blue. Below is with that change:

Also wanted to loop in @lboehling and get her thoughts. Let me know if there was anything I missed @mcarrano

@mcarrano @mcoker I like Michael's solution shown above. I suspect the current disabled state color was an oversight. Users should also get a cursor change indicating the arrow is disabled.

Sorry for the (very late) response @mcoker ! I'm +1 for changing the default horizontal nav item color to #fff instead of #d2d2d2 and also darkening the disabled icon to black-500! much better contrast.


Enhanced Main Layout

As a user, I would like to know what my 2nd functions are without pressing SHIFT in addition to having the UnitConversion and BinaryManipulation activity available by swiping,
[SP: 55]
[Priority: 1]
[Risk: high]

[ ] Prototype Layout
[ ] Tabs for our 3 main activities (Base Calculator, Main Calculator, Unit Conversion)
[ ] Navigate with tabs
[ ] Navigate with swipe
[ ] UI and Unit Tests
[ ] Acceptance Test


Example not working (Getting FirebaseApp is not initialized)

Hi
I'm fairly new at push notifications and I'm trying to run the example provided in Android without success.
First of all, I was getting an error because the file "FirebaseConstants.js" was missing. So I created it like this:
export default {
    KEY: 'my-server-key'
}

Then, after running "react-native run-android", in the simulator, I'm getting this error message:
"Default FirebaseApp is not initialized in this process fcm.simplefcmclient. Make sure to call FirebaseApp.initializeApp(Content) first."
I have no idea of what to do next, so any help will be appreciated.

I've done a "gradlew clean" and now is working. Seems to be a common procedure when working with react-native...


[docs] fix typos in Task class

Hi @linuxhadoop, thanks for your PR!
@flinkbot approve description consensus architecture quality
I will merge this.
Best, Fabian


[master-next] Update test to match llvm.dbg.value change

The filecheck pattern in DebugInfo/liverange-extension-vector.swift
was failing because llvm.dbg.value now has two metadata arguments. The
"[[P]]" pattern was matching "%4, metadata !60" instead of only the "%4".

LGTM, thanks!

@adrian-prantl Just an FYI, pull request testing works on master-next if you want to use it. You can even do source compatibility suite tests?!


Passing files doesn't limit tfsec scanning

Describe the bug
Passing filenames for tfsec to scan doesn't limit what tfsec scans.  tfsec still searches for files and scans all of them.
To Reproduce
Steps to reproduce the behavior:

Run tfsec against some files:

tfsec config.tf cloudtrail.tf --exclude-downloaded-modules --verbose

See error:

[DEBUG][2021-10-29 13:23:14.588133 -0500 CDT m=+0.035781305] Loading custom checks...
[DEBUG][2021-10-29 13:23:14.588271 -0500 CDT m=+0.035919703] Using the default custom check folder
[DEBUG][2021-10-29 13:23:14.588276 -0500 CDT m=+0.035924854] custom check directory set to /src/org/aws-organization-infrastructure/.tfsec
[DEBUG][2021-10-29 13:23:14.58829 -0500 CDT m=+0.035938201] Custom checks loaded
[DEBUG][2021-10-29 13:23:14.588294 -0500 CDT m=+0.035942461] checking for tfvars files using glob: /src/org/aws-organization-infrastructure/*.tfvars
[DEBUG][2021-10-29 13:23:14.588543 -0500 CDT m=+0.036191926] Starting parser...
[DEBUG][2021-10-29 13:23:14.58856 -0500 CDT m=+0.036208684] Finding Terraform subdirectories...
[DEBUG][2021-10-29 13:23:14.588995 -0500 CDT m=+0.036643087] Found qualifying subdirectory containing .tf files: /src/org/aws-organization-infrastructure
[DEBUG][2021-10-29 13:23:14.589006 -0500 CDT m=+0.036654421] Beginning parse for directory '/src/org/aws-organization-infrastructure'...
[DEBUG][2021-10-29 13:23:14.599365 -0500 CDT m=+0.047013799] Added 1 blocks from /src/org/aws-organization-infrastructure/access-analyzer.tf...
[DEBUG][2021-10-29 13:23:14.599382 -0500 CDT m=+0.047030746] Added 1 blocks from /src/org/aws-organization-infrastructure/guardduty.tf...
[DEBUG][2021-10-29 13:23:14.599388 -0500 CDT m=+0.047036691] Added 1 blocks from /src/org/aws-organization-infrastructure/variables.tf...
[DEBUG][2021-10-29 13:23:14.599393 -0500 CDT m=+0.047041958] Added 1 blocks from /src/org/aws-organization-infrastructure/versions.tf...
[DEBUG][2021-10-29 13:23:14.5994 -0500 CDT m=+0.047048485] Added 9 blocks from /src/org/aws-organization-infrastructure/aws-organization.tf...
[DEBUG][2021-10-29 13:23:14.599406 -0500 CDT m=+0.047054657] Added 1 blocks from /src/org/aws-organization-infrastructure/cloudtrail.tf...
[DEBUG][2021-10-29 13:23:14.599411 -0500 CDT m=+0.047059661] Added 2 blocks from /src/org/aws-organization-infrastructure/security-hub.tf...
[DEBUG][2021-10-29 13:23:14.599473 -0500 CDT m=+0.047122155] Added 9 blocks from /src/org/aws-organization-infrastructure/budgets.tf...
[DEBUG][2021-10-29 13:23:14.599489 -0500 CDT m=+0.047137497] Added 3 blocks from /src/org/aws-organization-infrastructure/ct-account-factory.tf...
[DEBUG][2021-10-29 13:23:14.599502 -0500 CDT m=+0.047151010] Added 3 blocks from /src/org/aws-organization-infrastructure/ct-customizations.tf...
[DEBUG][2021-10-29 13:23:14.599509 -0500 CDT m=+0.047157424] Added 1 blocks from /src/org/aws-organization-infrastructure/ct.tf...
[DEBUG][2021-10-29 13:23:14.599517 -0500 CDT m=+0.047166123] Added 12 blocks from /src/org/aws-organization-infrastructure/outputs.tf...
[DEBUG][2021-10-29 13:23:14.599524 -0500 CDT m=+0.047173114] Added 1 blocks from /src/org/aws-organization-infrastructure/resource_sharing.tf...
[DEBUG][2021-10-29 13:23:14.59953 -0500 CDT m=+0.047178765] Added 6 blocks from /src/org/aws-organization-infrastructure/config.tf...
[DEBUG][2021-10-29 13:23:14.599537 -0500 CDT m=+0.047185745] Added 1 blocks from /src/org/aws-organization-infrastructure/iam_jenkins.tf...
[DEBUG][2021-10-29 13:23:14.599681 -0500 CDT m=+0.047329939] Added 9 blocks from /src/org/aws-organization-infrastructure/main.tf...
[DEBUG][2021-10-29 13:23:14.599698 -0500 CDT m=+0.047347198] Added 14 blocks from /src/org/aws-organization-infrastructure/sso.tf...
[DEBUG][2021-10-29 13:23:14.599714 -0500 CDT m=+0.047362429] Project root set to '/src/org/aws-organization-infrastructure'...
[DEBUG][2021-10-29 13:23:14.599718 -0500 CDT m=+0.047366284] Loading TFVars...
[DEBUG][2021-10-29 13:23:14.599724 -0500 CDT m=+0.047372453] Skipping module metadata loading, --exclude-downloaded-modules passed
[DEBUG][2021-10-29 13:23:14.599727 -0500 CDT m=+0.047375882] Evaluating expressions...
[DEBUG][2021-10-29 13:23:14.599824 -0500 CDT m=+0.047473198] Starting iteration 1 of context evaluation...
[DEBUG][2021-10-29 13:23:14.603371 -0500 CDT m=+0.051020162] Starting iteration 2 of context evaluation...
[DEBUG][2021-10-29 13:23:14.605634 -0500 CDT m=+0.053283203] Starting iteration 3 of context evaluation...
[DEBUG][2021-10-29 13:23:14.609791 -0500 CDT m=+0.057439797] Loading modules...
WARNING: Failed to load module: missing module with source 'app.terraform.io/org/bucket/aws' -  try to 'terraform init' first
WARNING: Failed to load module: missing module with source 'app.terraform.io/org/bucket/aws' -  try to 'terraform init' first
WARNING: Failed to load module: missing module with source 'app.terraform.io/org/iam-jenkins/aws' -  try to 'terraform init' first
[DEBUG][2021-10-29 13:23:14.610611 -0500 CDT m=+0.058260189] Starting iteration 1 of context evaluation...
[DEBUG][2021-10-29 13:23:14.612332 -0500 CDT m=+0.059981210] Starting scanner...
[DEBUG][2021-10-29 13:23:14.613762 -0500 CDT m=+0.061411238] Running rule for general-secrets-sensitive-in-attribute on aws_iam_service_linked_role.access_analyzer (/src/org/aws-organization-infrastructure/access-analyzer.tf)...
[DEBUG][2021-10-29 13:23:14.61378 -0500 CDT m=+0.061428917] Running rule for general-secrets-sensitive-in-attribute-value on aws_iam_service_linked_role.access_analyzer (/src/org/aws-organization-infrastructure/access-analyzer.tf)...
[DEBUG][2021-10-29 13:23:14.613853 -0500 CDT m=+0.061501623] Running rule for general-secrets-sensitive-in-attribute on aws_iam_service_linked_role.guardduty (/src/org/aws-organization-infrastructure/guardduty.tf)...
[DEBUG][2021-10-29 13:23:14.613862 -0500 CDT m=+0.061510890] Running rule for general-secrets-sensitive-in-attribute-value on aws_iam_service_linked_role.guardduty (/src/org/aws-organization-infrastructure/guardduty.tf)...
[DEBUG][2021-10-29 13:23:14.6139 -0500 CDT m=+0.061549336] Running rule for general-secrets-sensitive-in-attribute-value on variable.aws_regions (/src/org/aws-organization-infrastructure/variables.tf)...
[DEBUG][2021-10-29 13:23:14.613937 -0500 CDT m=+0.061585892] Running rule for general-secrets-sensitive-in-variable on variable.aws_regions (/src/org/aws-organization-infrastructure/variables.tf)...
[DEBUG][2021-10-29 13:23:14.613968 -0500 CDT m=+0.061617387] Running rule for general-secrets-sensitive-in-attribute on aws_organizations_organization.aws_organization_org (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.613978 -0500 CDT m=+0.061626626] Running rule for general-secrets-sensitive-in-attribute-value on aws_organizations_organization.aws_organization_org (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614024 -0500 CDT m=+0.061673238] Running rule for general-secrets-sensitive-in-attribute on aws_organizations_delegated_administrator.iam_access_analyzer (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614032 -0500 CDT m=+0.061681107] Running rule for general-secrets-sensitive-in-attribute-value on aws_organizations_delegated_administrator.iam_access_analyzer (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614069 -0500 CDT m=+0.061718443] Running rule for general-secrets-sensitive-in-attribute on aws_organizations_delegated_administrator.config_multiaccountsetup (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614078 -0500 CDT m=+0.061727075] Running rule for general-secrets-sensitive-in-attribute-value on aws_organizations_delegated_administrator.config_multiaccountsetup (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614114 -0500 CDT m=+0.061763120] Running rule for general-secrets-sensitive-in-attribute on aws_securityhub_organization_admin_account.security_hub (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614121 -0500 CDT m=+0.061770079] Running rule for general-secrets-sensitive-in-attribute-value on aws_securityhub_organization_admin_account.security_hub (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614184 -0500 CDT m=+0.061833540] Running rule for general-secrets-sensitive-in-attribute on aws_securityhub_organization_admin_account.security_hub_us_east_1 (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614193 -0500 CDT m=+0.061842089] Running rule for general-secrets-sensitive-in-attribute-value on aws_securityhub_organization_admin_account.security_hub_us_east_1 (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614308 -0500 CDT m=+0.061956965] Running rule for general-secrets-sensitive-in-attribute on aws_guardduty_organization_admin_account.guardduty (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614322 -0500 CDT m=+0.061971347] Running rule for general-secrets-sensitive-in-attribute-value on aws_guardduty_organization_admin_account.guardduty (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614359 -0500 CDT m=+0.062007893] Running rule for general-secrets-sensitive-in-attribute on aws_guardduty_organization_admin_account.guardduty_us_east_1 (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614368 -0500 CDT m=+0.062016803] Running rule for general-secrets-sensitive-in-attribute-value on aws_guardduty_organization_admin_account.guardduty_us_east_1 (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.61449 -0500 CDT m=+0.062139367] Running rule for general-secrets-sensitive-in-attribute on aws_organizations_organizational_unit.non_managed_ou (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614506 -0500 CDT m=+0.062155214] Running rule for general-secrets-sensitive-in-attribute-value on aws_organizations_organizational_unit.non_managed_ou (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614535 -0500 CDT m=+0.062184096] Running rule for aws-kms-auto-rotate-keys on aws_kms_key.organization_trails_key (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.61457 -0500 CDT m=+0.062219484] Running rule for general-secrets-sensitive-in-attribute on aws_kms_key.organization_trails_key (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614581 -0500 CDT m=+0.062229714] Running rule for general-secrets-sensitive-in-attribute-value on aws_kms_key.organization_trails_key (/src/org/aws-organization-infrastructure/aws-organization.tf)...
[DEBUG][2021-10-29 13:23:14.614697 -0500 CDT m=+0.062346059] Running rule for general-secrets-sensitive-in-attribute on aws_cloudformation_stack.cloudtrail_data_events (/src/org/aws-organization-infrastructure/cloudtrail.tf)...
[DEBUG][2021-10-29 13:23:14.614707 -0500 CDT m=+0.062356315] Running rule for general-secrets-sensitive-in-attribute-value on aws_cloudformation_stack.cloudtrail_data_events (/src/org/aws-organization-infrastructure/cloudtrail.tf)...
[DEBUG][2021-10-29 13:23:14.61547 -0500 CDT m=+0.063119119] Running rule for general-secrets-sensitive-in-attribute on aws_securityhub_account.us_west_2 (/src/org/aws-organization-infrastructure/security-hub.tf)...
[DEBUG][2021-10-29 13:23:14.615482 -0500 CDT m=+0.063131341] Running rule for general-secrets-sensitive-in-attribute-value on aws_securityhub_account.us_west_2 (/src/org/aws-organization-infrastructure/security-hub.tf)...
[DEBUG][2021-10-29 13:23:14.615515 -0500 CDT m=+0.063163955] Running rule for general-secrets-sensitive-in-attribute on aws_securityhub_account.us_east_1 (/src/org/aws-organization-infrastructure/security-hub.tf)...
[DEBUG][2021-10-29 13:23:14.615522 -0500 CDT m=+0.063171401] Running rule for general-secrets-sensitive-in-attribute-value on aws_securityhub_account.us_east_1 (/src/org/aws-organization-infrastructure/security-hub.tf)...
[DEBUG][2021-10-29 13:23:14.615552 -0500 CDT m=+0.063200859] Running rule for aws-sns-enable-topic-encryption on aws_sns_topic.account_billing_alarm (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.615645 -0500 CDT m=+0.063294062] Running rule for general-secrets-sensitive-in-attribute on aws_sns_topic.account_billing_alarm (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.615654 -0500 CDT m=+0.063303251] Running rule for general-secrets-sensitive-in-attribute-value on aws_sns_topic.account_billing_alarm (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.61569 -0500 CDT m=+0.063339183] Running rule for general-secrets-sensitive-in-attribute on aws_sns_topic_policy.account_billing_alarm (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.615697 -0500 CDT m=+0.063346575] Running rule for general-secrets-sensitive-in-attribute-value on aws_sns_topic_policy.account_billing_alarm (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.615742 -0500 CDT m=+0.063390790] Running rule for general-secrets-sensitive-in-attribute on aws_sns_topic_subscription.aws_budget_alarms (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.615751 -0500 CDT m=+0.063400318] Running rule for general-secrets-sensitive-in-attribute-value on aws_sns_topic_subscription.aws_budget_alarms (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.615789 -0500 CDT m=+0.063438487] Running rule for general-secrets-sensitive-in-attribute on aws_budgets_budget.account_cost_budget_monthly (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.615799 -0500 CDT m=+0.063447680] Running rule for general-secrets-sensitive-in-attribute-value on aws_budgets_budget.account_cost_budget_monthly (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.615838 -0500 CDT m=+0.063487407] Running rule for general-secrets-sensitive-in-attribute on aws_budgets_budget.s3_cost_budget_monthly (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.615847 -0500 CDT m=+0.063496522] Running rule for general-secrets-sensitive-in-attribute-value on aws_budgets_budget.s3_cost_budget_monthly (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.615892 -0500 CDT m=+0.063541247] Running rule for general-secrets-sensitive-in-attribute on aws_budgets_budget.ec2_cost_budget_monthly (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.615902 -0500 CDT m=+0.063551062] Running rule for general-secrets-sensitive-in-attribute-value on aws_budgets_budget.ec2_cost_budget_monthly (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.61595 -0500 CDT m=+0.063599286] Running rule for general-secrets-sensitive-in-attribute on aws_budgets_budget.ec2_ri_utilization_monthly (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.61596 -0500 CDT m=+0.063608684] Running rule for general-secrets-sensitive-in-attribute-value on aws_budgets_budget.ec2_ri_utilization_monthly (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.616004 -0500 CDT m=+0.063652749] Running rule for general-secrets-sensitive-in-attribute on aws_budgets_budget.rds_ri_utilization_monthly (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.616014 -0500 CDT m=+0.063662765] Running rule for general-secrets-sensitive-in-attribute-value on aws_budgets_budget.rds_ri_utilization_monthly (/src/org/aws-organization-infrastructure/budgets.tf)...
[DEBUG][2021-10-29 13:23:14.616059 -0500 CDT m=+0.063708311] Running rule for general-secrets-sensitive-in-attribute on aws_cloudformation_stack.ct_account_factory_stack (/src/org/aws-organization-infrastructure/ct-account-factory.tf)...
[DEBUG][2021-10-29 13:23:14.616067 -0500 CDT m=+0.063716401] Running rule for general-secrets-sensitive-in-attribute-value on aws_cloudformation_stack.ct_account_factory_stack (/src/org/aws-organization-infrastructure/ct-account-factory.tf)...
[DEBUG][2021-10-29 13:23:14.617955 -0500 CDT m=+0.065603767] Running rule for general-secrets-sensitive-in-attribute on module.ct_account_factory_bucket (/src/org/aws-organization-infrastructure/ct-account-factory.tf)...
[DEBUG][2021-10-29 13:23:14.617978 -0500 CDT m=+0.065627168] Running rule for general-secrets-sensitive-in-attribute-value on module.ct_account_factory_bucket (/src/org/aws-organization-infrastructure/ct-account-factory.tf)...
[DEBUG][2021-10-29 13:23:14.618009 -0500 CDT m=+0.065658551] Running rule for aws-kms-auto-rotate-keys on aws_kms_key.ct_account_factory (/src/org/aws-organization-infrastructure/ct-account-factory.tf)...
[DEBUG][2021-10-29 13:23:14.618174 -0500 CDT m=+0.065822901] Ignoring 'aws-kms-auto-rotate-keys'
[DEBUG][2021-10-29 13:23:14.618196 -0500 CDT m=+0.065844958] Running rule for general-secrets-sensitive-in-attribute on aws_kms_key.ct_account_factory (/src/org/aws-organization-infrastructure/ct-account-factory.tf)...
[DEBUG][2021-10-29 13:23:14.618207 -0500 CDT m=+0.065856580] Running rule for general-secrets-sensitive-in-attribute-value on aws_kms_key.ct_account_factory (/src/org/aws-organization-infrastructure/ct-account-factory.tf)...
[DEBUG][2021-10-29 13:23:14.618335 -0500 CDT m=+0.065984054] Running rule for general-secrets-sensitive-in-attribute on aws_cloudformation_stack.ct_customizations_stack (/src/org/aws-organization-infrastructure/ct-customizations.tf)...
[DEBUG][2021-10-29 13:23:14.618347 -0500 CDT m=+0.065996595] Running rule for general-secrets-sensitive-in-attribute-value on aws_cloudformation_stack.ct_customizations_stack (/src/org/aws-organization-infrastructure/ct-customizations.tf)...
[DEBUG][2021-10-29 13:23:14.618392 -0500 CDT m=+0.066041123] Running rule for general-secrets-sensitive-in-attribute on module.ct_customizations_bucket (/src/org/aws-organization-infrastructure/ct-customizations.tf)...
[DEBUG][2021-10-29 13:23:14.618405 -0500 CDT m=+0.066053716] Running rule for general-secrets-sensitive-in-attribute-value on module.ct_customizations_bucket (/src/org/aws-organization-infrastructure/ct-customizations.tf)...
[DEBUG][2021-10-29 13:23:14.618431 -0500 CDT m=+0.066079718] Running rule for aws-kms-auto-rotate-keys on aws_kms_key.ct_customizations (/src/org/aws-organization-infrastructure/ct-customizations.tf)...
[DEBUG][2021-10-29 13:23:14.618454 -0500 CDT m=+0.066102817] Running rule for general-secrets-sensitive-in-attribute on aws_kms_key.ct_customizations (/src/org/aws-organization-infrastructure/ct-customizations.tf)...
[DEBUG][2021-10-29 13:23:14.618463 -0500 CDT m=+0.066112426] Running rule for general-secrets-sensitive-in-attribute-value on aws_kms_key.ct_customizations (/src/org/aws-organization-infrastructure/ct-customizations.tf)...
[DEBUG][2021-10-29 13:23:14.618539 -0500 CDT m=+0.066187756] Running rule for aws-kms-auto-rotate-keys on aws_kms_key.ct (/src/org/aws-organization-infrastructure/ct.tf)...
[DEBUG][2021-10-29 13:23:14.618562 -0500 CDT m=+0.066210943] Running rule for general-secrets-sensitive-in-attribute on aws_kms_key.ct (/src/org/aws-organization-infrastructure/ct.tf)...
[DEBUG][2021-10-29 13:23:14.618571 -0500 CDT m=+0.066220441] Running rule for general-secrets-sensitive-in-attribute-value on aws_kms_key.ct (/src/org/aws-organization-infrastructure/ct.tf)...
[DEBUG][2021-10-29 13:23:14.618738 -0500 CDT m=+0.066386916] Running rule for general-secrets-sensitive-in-attribute on aws_iam_service_linked_role.ram (/src/org/aws-organization-infrastructure/resource_sharing.tf)...
[DEBUG][2021-10-29 13:23:14.618746 -0500 CDT m=+0.066394935] Running rule for general-secrets-sensitive-in-attribute-value on aws_iam_service_linked_role.ram (/src/org/aws-organization-infrastructure/resource_sharing.tf)...
[DEBUG][2021-10-29 13:23:14.61878 -0500 CDT m=+0.066428789] Running rule for general-secrets-sensitive-in-attribute on aws_config_configuration_recorder.us_east_1 (/src/org/aws-organization-infrastructure/config.tf)...
[DEBUG][2021-10-29 13:23:14.618788 -0500 CDT m=+0.066436768] Running rule for general-secrets-sensitive-in-attribute-value on aws_config_configuration_recorder.us_east_1 (/src/org/aws-organization-infrastructure/config.tf)...
[DEBUG][2021-10-29 13:23:14.618833 -0500 CDT m=+0.066481807] Running rule for general-secrets-sensitive-in-attribute on aws_config_configuration_recorder_status.us_east_1 (/src/org/aws-organization-infrastructure/config.tf)...
[DEBUG][2021-10-29 13:23:14.618841 -0500 CDT m=+0.066490114] Running rule for general-secrets-sensitive-in-attribute-value on aws_config_configuration_recorder_status.us_east_1 (/src/org/aws-organization-infrastructure/config.tf)...
[DEBUG][2021-10-29 13:23:14.618892 -0500 CDT m=+0.066540869] Running rule for general-secrets-sensitive-in-attribute on aws_config_delivery_channel.us_east_1 (/src/org/aws-organization-infrastructure/config.tf)...
[DEBUG][2021-10-29 13:23:14.618902 -0500 CDT m=+0.066551209] Running rule for general-secrets-sensitive-in-attribute-value on aws_config_delivery_channel.us_east_1 (/src/org/aws-organization-infrastructure/config.tf)...
[DEBUG][2021-10-29 13:23:14.618948 -0500 CDT m=+0.066597623] Running rule for aws-kms-auto-rotate-keys on aws_kms_key.management_account_config_bucket_key (/src/org/aws-organization-infrastructure/config.tf)...
[DEBUG][2021-10-29 13:23:14.618969 -0500 CDT m=+0.066618383] Running rule for general-secrets-sensitive-in-attribute on aws_kms_key.management_account_config_bucket_key (/src/org/aws-organization-infrastructure/config.tf)...
[DEBUG][2021-10-29 13:23:14.618977 -0500 CDT m=+0.066626026] Running rule for general-secrets-sensitive-in-attribute-value on aws_kms_key.management_account_config_bucket_key (/src/org/aws-organization-infrastructure/config.tf)...
[DEBUG][2021-10-29 13:23:14.618998 -0500 CDT m=+0.066647600] Running rule for general-secrets-sensitive-in-attribute on module.iam_jenkins (/src/org/aws-organization-infrastructure/iam_jenkins.tf)...
[DEBUG][2021-10-29 13:23:14.619006 -0500 CDT m=+0.066655116] Running rule for general-secrets-sensitive-in-attribute-value on module.iam_jenkins (/src/org/aws-organization-infrastructure/iam_jenkins.tf)...
[DEBUG][2021-10-29 13:23:14.619083 -0500 CDT m=+0.066732312] Running rule for aws-misc-no-exposing-plaintext-credentials on provider.aws (/src/org/aws-organization-infrastructure/main.tf)...
[DEBUG][2021-10-29 13:23:14.619101 -0500 CDT m=+0.066750529] Running rule for general-secrets-sensitive-in-attribute on provider.aws (/src/org/aws-organization-infrastructure/main.tf)...
[DEBUG][2021-10-29 13:23:14.61911 -0500 CDT m=+0.066758931] Running rule for general-secrets-sensitive-in-attribute-value on provider.aws (/src/org/aws-organization-infrastructure/main.tf)...
[DEBUG][2021-10-29 13:23:14.619121 -0500 CDT m=+0.066770371] Running rule for aws-misc-no-exposing-plaintext-credentials on provider.aws (/src/org/aws-organization-infrastructure/main.tf)...
[DEBUG][2021-10-29 13:23:14.619132 -0500 CDT m=+0.066780847] Running rule for general-secrets-sensitive-in-attribute on provider.aws (/src/org/aws-organization-infrastructure/main.tf)...
[DEBUG][2021-10-29 13:23:14.619138 -0500 CDT m=+0.066787465] Running rule for general-secrets-sensitive-in-attribute-value on provider.aws (/src/org/aws-organization-infrastructure/main.tf)...
[DEBUG][2021-10-29 13:23:14.619241 -0500 CDT m=+0.066890092] Running rule for general-secrets-sensitive-in-attribute-value on locals. (/src/org/aws-organization-infrastructure/main.tf)...
[DEBUG][2021-10-29 13:23:14.619266 -0500 CDT m=+0.066914712] Running rule for general-secrets-sensitive-in-local on locals. (/src/org/aws-organization-infrastructure/main.tf)...
[DEBUG][2021-10-29 13:23:14.619289 -0500 CDT m=+0.066938037] Running rule for general-secrets-sensitive-in-attribute-value on locals. (/src/org/aws-organization-infrastructure/sso.tf)...
[DEBUG][2021-10-29 13:23:14.619791 -0500 CDT m=+0.067439908] Running rule for general-secrets-sensitive-in-local on locals. (/src/org/aws-organization-infrastructure/sso.tf)...

  Result 1

  [aws-sns-enable-topic-encryption][HIGH] Resource 'aws_sns_topic.account_billing_alarm' defines an unencrypted SNS topic.
  /src/org/aws-organization-infrastructure/budgets.tf:2-4

       1 | # SNS for Notifications
       2 | resource "aws_sns_topic" "account_billing_alarm" {
       3 |   name = "account-billing-alarm"
       4 | }
       5 |
       6 | resource "aws_sns_topic_policy" "account_billing_alarm" {
       7 |   arn    = aws_sns_topic.account_billing_alarm.arn

  Legacy ID:  AWS016
  Impact:     The SNS topic messages could be read if compromised
  Resolution: Turn on SNS Topic encryption

  More Info:
  - https://tfsec.dev/docs/aws/sns/enable-topic-encryption#aws/sns
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sns_topic#example-with-server-side-encryption-sse
  - https://docs.aws.amazon.com/sns/latest/dg/sns-server-side-encryption.html

  times
  ------------------------------------------
  disk i/o             10.779196ms
  parsing HCL          54.884µs
  evaluating values    9.320939ms
  running checks       7.483278ms

  counts
  ------------------------------------------
  files loaded         18
  blocks               75
  modules              0

  results
  ------------------------------------------
  critical             0
  high                 1
  medium               0
  low                  0
  ignored              1

  1 potential problems detected.

Notice that the error found is not in one of the files I passed in.
Expected behavior
I expect tfsec will scan only the files I pass in, if I pass files in.
Desktop (please complete the following information):

OS: macOS Big Sur 11.6

Additional context
tfsec -v
v0.58.14

@bmurphey  - tfsec doesn't support scanning single files. I've raised https://github.com/aquasecurity/tfsec/issues/1140 to look into this further

Excellent, thank you!

@bmurphey  - terrraform doesn't support planning against a single file and requires a directory to work against. We want to align with terraforms operation as much as practical so won't be supporting single files


[Event Request] Codeunit 99000830 OnTransferReservEntryOnBeforeNewReservEntryModify

We Need the new Event trigger OnTransferReservEntryOnBeforeNewReservEntryModify from 16.1 in codeunit 99000830 also in the other case the If sign has not swapped due to negative Posting:
[External] TransferReservEntry(NewType : Option;NewSubtype : Integer;NewID : Code[20];NewBatchName : Code[10];NewProdOrderLine : Integer;NewRefNo : Integer;QtyPerUOM : Decimal;OldReservEntry : Record "Reservation Entry";TransferQty : Decimal) : DecimalÄ
IF TransferQty = 0 THEN
EXIT;
…
…
if not ReservEntry.Get(NewReservEntry."Entry No.", NewReservEntry.Positive) then begin
// Means that only one record exists = surplus or prospect
NewReservEntry.Insert();
OnTransferReservEntryOnAfterNewReservEntryInsert(NewReservEntry);
// Delete the original record:
NewReservEntry.Positive := not NewReservEntry.Positive;
NewReservEntry.Delete();
end else begin // A set of records exist = reservation or tracking
OnTransferReservEntryOnBeforeNewReservEntryModify(NewReservEntry, false);
NewReservEntry.Modify();
// Get the original record and modify quantity:
NewReservEntry.Get(NewReservEntry."Entry No.", not NewReservEntry.Positive); // Get partner-record
NewReservEntry.Validate("Quantity (Base)", -TransferQty);
OnTransferReservEntryOnBeforeNewReservEntryModify(NewReservEntry, true);
NewReservEntry.Modify();
end;
end else
if Abs(TransferQty) < Abs(OldReservEntry."Quantity (Base)") then begin
OnBeforeUseOldReservEntry(OldReservEntry, InsertReservEntry);
if OldReservEntry.Binding = OldReservEntry.Binding::"Order-to-Order" then
SetBinding(OldReservEntry.Binding::"Order-to-Order");
if OldReservEntry."Disallow Cancellation" then
SetDisallowCancellation(OldReservEntry."Disallow Cancellation");
if Abs(QtyToInvoiceThisLine) > Abs(TransferQty) then
QtyInvoiced := TransferQty
else
QtyInvoiced := QtyToInvoiceThisLine;
SetQtyToHandleAndInvoice(QtyToHandleThisLine - TransferQty, QtyToInvoiceThisLine - QtyInvoiced);
CreateRemainingReservEntry(OldReservEntry,
0, (OldReservEntry."Quantity (Base)" - TransferQty) * CurrSignFactor);
NewReservEntry.Validate("Quantity (Base)", TransferQty);
+++++++++++++++++++++++++++++
OnTransferReservEntryOnBeforeNewReservEntryModify(NewReservEntry, FALSE);
------------------------------------------------
NewReservEntry.Modify();
if NewReservEntry.Get(NewReservEntry."Entry No.", not NewReservEntry.Positive) then begin // Get partner-record
NewReservEntry.Validate("Quantity (Base)", -TransferQty);
+++++++++++++++++++++++++++++
OnTransferReservEntryOnBeforeNewReservEntryModify(NewReservEntry, TRUE);
------------------------------------------------
NewReservEntry.Modify();
end;
end else begin
+++++++++++++++++++++++++++++
OnTransferReservEntryOnBeforeNewReservEntryModify(NewReservEntry, FALSE);
------------------------------------------------
NewReservEntry.Modify();
TransferQty := NewReservEntry."Quantity (Base)";
if NewReservEntry."Source Type" = DATABASE::"Item Ledger Entry" then begin
if NewReservEntry.Get(NewReservEntry."Entry No.", not NewReservEntry.Positive) then begin // Get partner-record
if NewReservEntry."Quantity (Base)" < 0 then
NewReservEntry."Expected Receipt Date" := 0D
else
NewReservEntry."Shipment Date" := DMY2Date(31, 12, 9999);
+++++++++++++++++++++++++++++
OnTransferReservEntryOnBeforeNewReservEntryModify(NewReservEntry, TRUE);
------------------------------------------------
NewReservEntry.Modify();
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Downloads: add binary verification instructions

Closes #544
Preview: http://dg3.dtrt.org/en/download/
Note: files in the /bin/ directory are not available on the above preview site; that's expected since they're not part of the repository.  To test this PR, download the necessary binary file and SHA256SUMS file from the real https://bitcoincore.org/en/download/
This PR adds instructions to the Download page for verifying Bitcoin Core binaries on Windows, MacOS, and Linux.  Also included are a short note about why we can't provide instructions for verifying the Ubuntu PPA[1] and a brief overview of additional verification that can be done through looking at the Gitian sigs or reproducing a build yourself.
I believe the Linux instructions are correct.  Windows or MacOS need testing as I don't have either system available for testing and so I based by instructions on random StackExchange answers and documentation from other projects (Tor having the best I found).
The instructions are gated by an if statement that only displays them on translations that have updated to support the required strings (this is only English in this PR, so they don't display on the Japanese translation for now).
[1] From my research, it seems that the GPG key that signs the PPA package belongs to the Ubuntu infrastructure, not the package maintainer, so I don't see any probative value in authenticating it. And that problem is in addition to the packages not being built reproducibly through Gitian, so I decided to give up on providing any instructions for PPA package verification.  If anyone knows a way to get stronger package authentication for PPA users, let me know.

Tested instructions for Linux as a user with no previous .gnupg directory. Works fine. Don't have windows or mac to test on. Sorry!

@kallerosenbaum thanks for the excellent suggestions!  All have been implemented in a separate commit in case you want to review.  I'll squash at some point when we can get somebody to review the MacOS and Windows instructions.
I've also updated the online preview.

It looks really good, apart from the nitpicking in my last comment.

Tested on MacOS 10.13.4. Works great!

I finally managed to get my hands on a Window machine. But the http://dg0.dtrt.org/en/download/ links to a unmodified download page. @harding could you please bring the modified download page back?

@kallerosenbaum Sorry!  I need to write a script to manage what's on which preview subdomain.  Can you try at this new URL: http://dg3.dtrt.org/en/download/

it's my wife's laptop from work I will use. Seems I jumped the gun, since she can't login outside of her windows domain. Craptastic. Sorry, this will be delayed a couple of days...

Here's my results on Windows 10 using gpg4win:
Step 7, --recv-keys gives me:
gpg: keybox 'C:/Users/Billy/AppData/Roaming/gnupg/pubring.kbx' created
gpg: key 90C8019E36C2E964: 47 signatures not checked due to missing keys
gpg: C:/Users/Billy/AppData/Roaming/gnupg/trustdb.gpg: trustdb created
gpg: key 90C8019E36C2E964: public key "Wladimir J. van der Laan (Bitcoin Core binary release signing key<EMAIL_ADDRESS>imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1

Step 8, --verify gives me
gpg: Signature made 02/26/18 02:00:19 Eastern Standard Time
gpg:                using RSA key 90C8019E36C2E964
gpg: Good signature from "Wladimir J. van der Laan (Bitcoin Core binary release signing key<EMAIL_ADDRESS>[unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the owner.
Primary key fingerprint: 01EA 5486 DE18 A882 D4C2  6845 90C8 019E 36C2 E964

@BlockchainBilly awesome, thanks!  Were you also able to run this command?
certUtil -hashfile bitcoin-0.16.0-win64-setup.exe SHA256

That was the one I was least sure about.

Yep that worked fine, result was:
6d93ba3b9c3e34f74ccfaeacc79f968755ba0da1e2d75ce654cf276feb2aa16d
CertUtil: -hashfile command completed successfully.```
and it matched the corresponding hash from `type SHA256SUMS.asc`
I've never done anything with GPG before so I was just following your instructions. The only thing that stood out to me is that when downloading GPG, the link took me to another website that listed binaries hosted on yet another website. It would be helpful if there were a guide or something to ensure new users knew why/how to safely install GPG.

@BlockchainBilly that's good feedback, thanks.  I'll update the instructions to link directly to GPG4Win.  It looks like they have their own integrity-checking instructions here and here that are linked from their Download page.

@BlockchainBilly Text updated per your suggestion, thanks!  The first link in the screenshot below points to the GPG4Win homepage, the second link points to the original list of downloads from the GnuPG website

I did the same with the MacOS instructions, using GPG Suite there for the default recommended install.
Commits and preview updated.

Looks great!

ACK


Failed to set up

Describe the bug
I set up the Eufy Security Add-on to use port 3001 since port 3000 is being used by another add on. And now the integration fails to set up.
To reproduce
Steps to reproduce the behavior:

Set up Eufy Security Add-on to use port 3001
See error

Additional information

Home Assistant Installation Type (OS - Supvervised - Core): OS 9.5
Home Assistant Core Version: 2023.7.3
Eufy Security Add-on Version: 1.5.2-1
Eufy Security Integration Version: 1.32.1

Hardware Information;

Camera Model: Floodlight Cam E221

Debug Logs from Home Assistant (https://github.com/fuatakgun/eufy_security/discussions/624)

This error originated from a custom integration.
Logger: homeassistant.config_entries
Source: custom_components/eufy_security/eufy_security_api/api_client.py:103
Integration: Eufy Security (documentation, issues)
First occurred: July 28, 2023 at 2:53:24 PM (9 occurrences)
Last logged: 12:09:38 PM
Error setting up entry <IP_ADDRESS> for eufy_security
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 390, in async_setup
result = await component.async_setup_entry(hass, self)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/eufy_security/init.py", line 50, in async_setup_entry
await coordinator.initialize()
File "/config/custom_components/eufy_security/coordinator.py", line 39, in initialize
await self._api.connect()
File "/config/custom_components/eufy_security/eufy_security_api/api_client.py", line 73, in connect
await self._set_products()
File "/config/custom_components/eufy_security/eufy_security_api/api_client.py", line 103, in _set_products
if result[MessageField.STATE.value][EventSourceType.driver.name][MessageField.CONNECTED.value] is False:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
KeyError: 'connected'

Logs from Eufy Security Add-on  (either from Add-ons page of Home Assistant or Docker output):
       param_id: 0,       device_sn: 'T8424T1023170ED2',       param_type: 2001,       param_value: 'true',       create_time:<PHONE_NUMBER>,       update_time:<PHONE_NUMBER>,       status: 1     },     {       param_id: 0,       device_sn: 'T8424T1023170ED2',       param_type: 1103,       param_value: '7',       create_time:<PHONE_NUMBER>,       update_time:<PHONE_NUMBER>,       status: 1     }   ],   pir_total: 0,   pir_none: 0,   pir_missing: 0,   week_pir_total: 0,   week_pir_none: 0,   month_pir_total: 0,   month_pir_none: 0,   charging_days: 0,   charing_total: 0,   charging_reserve: 0,   charging_missing: 0,   battery_usage_last_week: 0,   virtual_version: '',   relate_devices: null,   house_id: '2d34c357ee77f0290944d49086df176e2998ae204a54' } } 2023-07-29 17:01:51.023  DEBUG [FloodlightCamera.update] Normalized Properties  { deviceSN: 'T8424T1023170ED2', properties: {   motionDetected: false,   personDetected: false,   personName: '',   name: 'Floodlight Cam',   model: 'T8424',   serialNumber: 'T8424T1023170ED2',   type: 39,   hardwareVersion: 'P1',   softwareVersion: '<IP_ADDRESS>',   stationSerialNumber: 'T8424T1023170ED2',   picture: {     data: <Buffer ff d8 ff e0 00 10 4a 46 49 46 00 01 01 00 00 01 00 01 00 00 ff fe 00 05 00 00 00 ff db 00 43 00 20 16 18 1c 18 14 20 1c 1a 1c 24 22 20 26 30 50 34 30 ... 39479 more bytes>,     type: {       ext: 'jpg',       mime: 'image/jpeg'     }   },   recordingClipLength: 100,   recordingRetriggerInterval: 0,   recordingEndClipMotionStops: true,   snoozeTime: 0,   snoozeStartTime: 0,   light: false,   lightSettingsBrightnessManual: 39,   enabled: true,   'hidden-pictureUrl': '/media/mmcblk0p1/Camera00/20230729113046n.jpg',   lightSettingsEnable: true,   lightSettingsMotionTriggered: true,   lightSettingsMotionTriggeredTimer: 30,   lightSettingsBrightnessMotion: 100,   lightSettingsBrightnessSchedule: 100 } } 2023-07-29 17:02:54.680  DEBUG [PushClient.sendHeartbeat] Sending heartbeat... 73  2023-07-29 17:02:54.682  DEBUG [PushClient.buildHeartbeatPingRequest] heartbeatPingRequest  { last_stream_id_received: 73 } 2023-07-29 17:02:54.728  DEBUG [PushClient.handleHeartbeatAck] Heartbeat acknowledge  { tag: 1, object: {   lastStreamIdReceived: 69 } } 2023-07-29 17:04:22.398  DEBUG [ClientsController.addSocket] New client with ip: <IP_ADDRESS> port: 34304  2023-07-29 17:04:22.413  INFO  [WebSocket.<anonymous>] Client disconnected with ip: <IP_ADDRESS> port: 34304 code: 1000 reason: Normal Closure  2023-07-29 17:07:54.688  DEBUG [PushClient.sendHeartbeat] Sending heartbeat... 74  2023-07-29 17:07:54.691  DEBUG [PushClient.buildHeartbeatPingRequest] heartbeatPingRequest  { last_stream_id_received: 74 } 2023-07-29 17:07:54.754  DEBUG [PushClient.handleHeartbeatAck] Heartbeat acknowledge  { tag: 1, object: {   lastStreamIdReceived: 70 } } 2023-07-29 17:09:37.325  DEBUG [ClientsController.addSocket] New client with ip: <IP_ADDRESS> port: 59622  2023-07-29 17:09:37.338  INFO  [WebSocket.<anonymous>] Client disconnected with ip: <IP_ADDRESS> port: 59622 code: 1000 reason: Normal Closure

Would you share your device with me in case further debugging required? (Yes/No):

Additional context

follow the bug template and get the logs please


Linux 515.1633+ compat, add signature checking function for development

this updates the Linux sigs, and also adds a new exported function: auxtools_check_signatures
it just returns either SUCCESS or something like MISSING: call_proc_by_id, get_variable, call_datum_proc_by_name, get_assoc_element, set_assoc_element - just makes it easy to see which sigs need to be updated, all in one go.
credit to @checkraisefold for linux 515.1633 sigs (which work up to 1642+)

redoing this pr


API — Re-enable Hooks

In the v4 API there were a number of "hooks" that could be triggered from other services such as PayPal, Evernote, and GitHub. These need to be readied to the Streams API as an optional endpoint with initial support for PayPal ... as that's the company that's bugging me about a missing endpoint.

Done and done ... I think. The code from v4 has been brought in and loosely cleaned up to support PayPal transactions. This will need to be split out a little more intelligently and dynamically in the near future to allow people to enable/disable PayPal integrations.
Update is part of 19F170 and deployed live.


Introduce a mock device for e2e testing.

Might be nice to avoid the unconditional import but not so bad while
it's small.

Rebased on merged work for #224.

Branch preview still uses the real device 😄  Merging as a small step in the right direction.


refactor(General): :recycle: Update url query string without rendering all the view

Description
Briefly describe the changes made in this Pull Request.
Additional context (optional)
Add any additional context or information about the changes made in this PR.
How to test
Provide clear and concise instructions on how to test the changes made in this PR.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@354172c). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage        ?   89.37%
=======================================
  Files           ?      118
  Lines           ?     3463
  Branches        ?      773
=======================================
  Hits            ?     3095
  Misses          ?      337
  Partials        ?       31

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Cron timezone

Is it possible to have a cron expression with a time zone other than UTC?
schedule = {
    schedule_type   = "cron"
    cron_expression = "0 20 0 * * ? Europe/ Paris"
  }

Hi,
I'm having the same issue.
Would it be possible to allow any other timezone?

Hi @KimPlv @OhadSrur I believe new version already supports (I am using vO.63.3)

But there is not convenient place for timezone other than UTC, I posted at https://github.com/airbytehq/terraform-provider-airbyte/issues/121

Hi @hongbo-miao ,
Yes, I also encountered the same issue you described in your new GH issue.
So, I don't think it's correct to say that timezones are supported in TF.
Thanks,
Ohad

@OhadSrur Oh I see what you mean.

@OhadSrur Oh I see what you mean. I initially thought when this post opened, it is not supported at all.

@OhadSrur Oh I see what you mean. I initially thought when this post opened, timezone is not supported at all.
Closed my post and copied my post here:

Case 1 (UTC)
When I run terraform apply for code
resource "airbyte_connection" "my_airbyte_connection" {
  # ...
  schedule = {
    schedule_type   = "cron"
    cron_expression = "0 27 * * * ? * UTC"
  }
}

it will create the schedule successfully.
Case 2 (US/Pacific)
When I run terraform apply for code
resource "airbyte_connection" "my_airbyte_connection" {
  # ...
  schedule = {
    schedule_type   = "cron"
    cron_expression = "0 27 * * * ? * US/Pacific"
  }
}

╷
│ Error: failure to invoke API
│
│   with module.horizon_airbyte_connection_snowflake_production_horizon_airbyte_db_data_engineering_jira.airbyte_connection.horizon_airbyte_connection,
│   on ../../../modules/airbyte/horizon_airbyte_connection/main.tf line 10, in resource "airbyte_connection" "horizon_airbyte_connection":
│   10: resource "airbyte_connection" "horizon_airbyte_connection" {
│
│ unknown status code returned: Status 400
│ {"status":400,"type":"https://reference.airbyte.com/reference/errors#bad-request","title":"bad-request","detail":"The request could not be understood by the server due to malformed
│ syntax.","documentationUrl":null,"data":{"message":"The cron expression 0 27 * * * ? * US/Pacific is not valid. Error: Cron expression contains 8 parts but we expect one of [6, 7]. Please check the cron
│ expression format at https://www.quartz-scheduler.org/documentation/quartz-2.3.0/tutorials/crontrigger.html"}}

Workaround Solution
Update in the Airbyte UI to use 0 27 * * * ? * and timezone US/Pacific

and run terraform apply again, it will show
No changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed.
Apply complete! Resources: 0 added, 0 changed, 0 destroyed.


tcp:add tcp support to CNET

Update and rework the TCP support for CNET using a set of graph nodes to
manage the TCP protocol. The TCP protocol support can be enabled via the
meson_options.txt file.
Testing the TCP protocol using wireguard and other applications i.e wireshark, socat, telnet, ...
to verify the protocol and data managment is correct.
In this change a few examples needed to be update to support TCP and the changes to
the channel APIs. One change to the channel API is when the application is called
back to process Rx packets is the callback does not pass mbufs back in the call.
The packets are now placed on a receive queue and a call to chnl_recv() needs to
be done to get packets.
Note:
TCP active opens are not test yet. This PR is for anyone wanting to understand the changes or would like to test the code.
It does take a bit of effort to test, so please ask any questions if you want to test the code.
Also this is one big PR and I will break this down into smaller PR's when I get closer to submitting the changes.
Signed-off-by: Keith Wiles<EMAIL_ADDRESS>

Going to close this PR and reopen it after it is broken up into PRs for non-TCP issue.