[WIP] Fix PR push times

Currently if you push on a different branch on your fork, it will reset the time for all PRs from that fork, even if they are completely unrelated. This issue aims to fix that.

@mark-i-m Please fix the tests.

Working on it :)

Still not fixed :(
If you could also expand the tests to with and without events present, that'd be great.

and I'm assuming you know this, but you can run the tests locally of course.

Hmm... I am actually having trouble running them locally... which is why I am doing a lot of guessing...

What things do I need to pip install to run them locally?

Now it's just a linting issue 😝

If you could also expand the tests to with and without events present, that'd be great.

First, I need to figure out how the testing harness works... :stuck_out_tongue:

@mark-i-m
pip install -r requirements.txt
python -m unittest

pip might need root/admin, depending on your setup.

Traceback (most recent call last):
  File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/usr/lib/python2.7/unittest/__main__.py", line 12, in <module>
    main(module=None)
  File "/usr/lib/python2.7/unittest/main.py", line 94, in __init__
    self.parseArgs(argv)
  File "/usr/lib/python2.7/unittest/main.py", line 149, in parseArgs
    self.createTests()
  File "/usr/lib/python2.7/unittest/main.py", line 158, in createTests
    self.module)
  File "/usr/lib/python2.7/unittest/loader.py", line 130, in loadTestsFromNames
    suites = [self.loadTestsFromName(name, module) for name in names]
  File "/usr/lib/python2.7/unittest/loader.py", line 91, in loadTestsFromName
    module = __import__('.'.join(parts_copy))
  File "github_api/__init__.py", line 7, in <module>
    import settings
  File "settings.py", line 2, in <module>
    import misc
  File "misc.py", line 2, in <module>
    from urllib.parse import urlparse
ImportError: No module named parse```

@mark-i-m Python 3.6? If so, our requirements.txt might be off. I'll look into it.

@mark-i-m No idea, and that Python version might not even be a problem, IDK.

Tests pass, just linting now 👍

Just a couple of indentation problems now, then it looks good to go!

I'm assuming you have flake8 working locally?

TBH, I was playing around with the Dockerfile trying to run things in their... that seems like a much preferable option to installing things locally.

Yay :tada: It works. Shall I unWIP?

@mark-i-m almost, but I just noticed something. See above comment.

One other thing I forgot: you should probably call max(current_return_value, pr["created_at"]).

@PlasmaPower why?

@mark-i-m A branch can be pushed for, then the PR for that created. We don't want an insta-close possible in that situation. It's happened before.

Hmm... that seems like it should be caller's problem, though?

@mark-i-m sorta, but we should still handle it since it's easily possible.

The problem is that max(current_return_value, pr["created_at"]) returns current_return_value always, right?

@mark-i-m not always - reread my example:

Author pushes to example-branch
Author waits a couple hours
Author makes a PR for example-branch
Author's PR gets instantly closed

Current return value: time of 1 (too soon)
pr["created_at"]: time of 3 (correct)

This can also happen when a PR is recreated to address conflicts/other issues. It's happened before.

Oh, I thought by current_return_value you meant the value without this PR... I see now that I misread your post. Yes, that makes sense.

Oh I could see how that would be confusing. Great work on this! It's a shame it's slowing down your other PRs haha.

Lol, the irony :laughing:

Sorry, everyone... I need to sleep... will finish this up tomorrow :zzz:

Sounds good! Can't wait.

I need to sleep... will finish this up tomorrow

Sleep... nah

/essay
😛

wow @anythingbot good read 👍

Meanwhile, in the UK...

Can anyone decipher the error on that last failing test?

Nvm... got it :tada:

@mark-i-m I realized the patches were getting mixed up - never would have guess it needs to be in reversed.

Yeah, that's pretty unintuitive

Looks like that arg line is a bit too long.

@mark-i-m Wrong line - it's the arg line of the test we were working on.


Latest commits up to 9759602f

Cherry picked 12d608c8..9759602f

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 8 committers have signed the CLA.:x: HHans09:x: travisturner:x: rachithrr:x: tgruben:x: lorycloutier:x: bruce-b-molecula:x: pokeeffe-molecula:x: Joe FriedrichJoe Friedrich seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Cherry-pick was not complete.


@stryker-mutator/typescript-checker is incompatible with TypeScript 3.7

Summary
As reported by @LayZeeDK here: https://github.com/stryker-mutator/stryker/pull/2548#issuecomment-707312470

After I added back the TypeScript Checker, this error is reported:
    19:38:51 (3931) ERROR Stryker Error: Error: An error occurred during initialization of the "typescript" checker. Inner error: Error: TypeScript error(s) found in dry run compilation: ../../node_modules/@stryker-mutator/api/src/core/range.d.ts(4,36): error TS1005: ',' expected.\n
    ../../node_modules/@stryker-mutator/api/src/core/range.d.ts(4,57): error TS1005: ',' expected.

    Error: TypeScript error(s) found in dry run compilation: ../../node_modules/@stryker-mutator/api/src/core/range.d.ts(4,36): error TS1005: ',' expected.
    ../../node_modules/@stryker-mutator/api/src/core/range.d.ts(4,57): error TS1005: ',' expected.

        at TypescriptChecker.init (/home/runner/work/stryker/stryker/e2e/test/angular-project/node_modules/@stryker-mutator/typescript-checker/src/typescript-checker.ts:118:13)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)
        at CheckerWorker.init (/home/runner/work/stryker/stryker/e2e/test/angular-project/node_modules/@stryker-mutator/core/src/checker/checker-worker.js:21:21
        at ChildProcessProxyWorker.handleCall (/home/runner/work/stryker/stryker/e2e/test/angular-project/node_modules/@stryker-mutator/core/src/child-proxy/child-process-proxy-worker.js:62:28)
    Error: An error occurred during initialization of the "typescript" checker. Inner error: Error: TypeScript error(s) found in dry run compilation: ../../node_modules/@stryker-mutator/api/src/core/range.d.ts(4,36): error TS1005: ',' expected.
    ../../node_modules/@stryker-mutator/api/src/core/range.d.ts(4,57): error TS1005: ',' expected.

    Error: TypeScript error(s) found in dry run compilation: ../../node_modules/@stryker-mutator/api/src/core/range.d.ts(4,36): error TS1005: ',' expected.
    ../../node_modules/@stryker-mutator/api/src/core/range.d.ts(4,57): error TS1005: ',' expected.

        at TypescriptChecker.init (/home/runner/work/stryker/stryker/e2e/test/angular-project/node_modules/@stryker-mutator/typescript-checker/src/typescript-checker.ts:118:13)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)
        at CheckerWorker.init (/home/runner/work/stryker/stryker/e2e/test/angular-project/node_modules/@stryker-mutator/core/src/checker/checker-worker.js:21:21)
        at ChildProcessProxyWorker.handleCall (/home/runner/work/stryker/stryker/e2e/test/angular-project/node_modules/@stryker-mutator/core/src/child-proxy/child-process-proxy-worker.js:62:28)
        at CheckerWorker.init (/home/runner/work/stryker/stryker/e2e/test/angular-project/node_modules/@stryker-mutator/core/src/checker/checker-worker.js:24:27)
        at processTicksAndRejections (internal/process/task_queues.js:97:5)
        at ChildProcess.<anonymous> (/home/runner/work/stryker/stryker/e2e/test/angular-project/node_modules/@stryker-mutator/core/src/child-proxy/child-process-proxy.js:132:68)
        at ChildProcess.emit (events.js:315:20)
        at emit (internal/child_process.js:876:12)
        at processTicksAndRejections (internal/process/task_queues.js:85:21)

Remember that this project uses TypeScript version 3.7.5.
As seen in this TypeScript playground, range.ts is incompatible with TypeScript 3.7.
Labeled tuple elements were added in TypeScript 4.0, so range.ts is currently incompatible with e2e project using TypeScript <4.0.
// range.ts
/**
 * Represents a location in a file by range.
 */
type Range = [fromInclusive: number, toExclusive: number];

export default Range;

This is the declarations output in range.d.ts in @stryker-mutator/core v4.0.0:
// range.d.ts
/**
 * Represents a location in a file by range.
 */
declare type Range = [fromInclusive: number, toExclusive: number];
export default Range;
//# sourceMappingURL=Range.d.ts.map

Meaning TypeScript <4.0 is not supported for a bunch of the APIs.
TypeScript 4.0 is supported by Angular 10.1.

I can't reproduce it with this simple example. Will try the e2e tests now.
Uploading ts3.7-example.zip…

I just tested in an Angular 9.0 project with the following dependencies and configuration and it doesn't seem to be an issue outside of the stryker monorepo.
package.json
{
  "name": "ngx-stryker-cli900",
  "version": "0.0.0",
  "scripts": {
    "postinstall": "ngcc",
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular/animations": "~9.0.0",
    "@angular/common": "~9.0.0",
    "@angular/compiler": "~9.0.0",
    "@angular/core": "~9.0.0",
    "@angular/forms": "~9.0.0",
    "@angular/platform-browser": "~9.0.0",
    "@angular/platform-browser-dynamic": "~9.0.0",
    "@angular/router": "~9.0.0",
    "rxjs": "~6.5.4",
    "tslib": "^1.10.0",
    "zone.js": "~0.10.2"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.900.0",
    "@angular/cli": "~9.0.0",
    "@angular/compiler-cli": "~9.0.0",
    "@angular/language-service": "~9.0.0",
    "@stryker-mutator/core": "^4.0.0",
    "@stryker-mutator/karma-runner": "^4.0.0",
    "@stryker-mutator/typescript-checker": "^4.0.0",
    "@types/jasmine": "~3.5.0",
    "@types/jasminewd2": "~2.0.3",
    "@types/node": "^12.11.1",
    "codelyzer": "^5.1.2",
    "jasmine-core": "~3.5.0",
    "jasmine-spec-reporter": "~4.2.1",
    "karma": "~4.3.0",
    "karma-chrome-launcher": "~3.1.0",
    "karma-coverage-istanbul-reporter": "~2.1.0",
    "karma-jasmine": "~2.0.1",
    "karma-jasmine-html-reporter": "^1.4.2",
    "protractor": "~5.4.3",
    "ts-node": "~8.3.0",
    "tslint": "~5.18.0",
    "typescript": "~3.7.5"
  }
}

stryker.conf.json
{
  "$schema"<EMAIL_ADDRESS>  "_comment": "This config was generated using a preset. Please see the handbook for more information: https://github.com/stryker-mutator/stryker-handbook/blob/master/stryker/guides/angular.md#angular",
  "mutate": [
    "src/**/*.ts",
    "!src/**/*.spec.ts",
    "!src/test.ts",
    "!src/environments/*.ts"
  ],
  "testRunner": "karma",
  "checkers": ["typescript"],
  "karma": {
    "configFile": "karma.conf.js",
    "projectType": "angular-cli",
    "config": {
      "browsers": ["ChromeHeadless"]
    }
  },
  "reporters": ["progress", "clear-text", "html"],
  "concurrency": 4,
  "concurrency_comment": "Recommended to use about half of your available cores when running stryker with angular",
  "coverageAnalysis": "perTest"
}

Thanks. It is indeed the mono repo setup. We have the verify, which was used in the typescript compilation. See https://github.com/stryker-mutator/stryker/pull/2548#issuecomment-707981725 for more info.


New version: Calibre Portable 6.24.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/115307&drop=dogfoodAlpha

@wingetbot run


Accessibility Update

Made a small update to the code: Changed outline: none to outline-color: transparent. It's good to always have this in outlines for inputs and buttons and such, since users with higher contrasts and such could have issues using the tab button selector. This could have an unintentional effect of making special animations and attributes of the button disappear. Reference: https://www.youtube.com/shorts/4B_4WLpbyp8

Hi @7agabond - thank you for your contribution.
As with https://github.com/nationalarchives/tna-frontend/pull/48#issuecomment-1802283399, this is an instance where we are focusing on an element programatically and need to omit the outline entirely.
The element cannot be tabbed to directly.
You can see the implementation here: https://github.com/nationalarchives/tna-frontend/blob/main/src/nationalarchives/components/gallery/gallery.mjs#L71-L73


[FEATURE REQ] Remove api-version of subscription in all test recording files

Library name
Azure.ResourceManager.*
Please describe the feature.
We are planning to upgrade the api-version of subscription, it will break all the existing tests since the api-version will mismatch in recordings.
So, we need to replace the current api-version of subscription to ** to get rid of the dependencies in all recording files.
There are two parts of work for this:

[x] Recording files in azure-sdk-for-net
[x] Recording files in https://github.com/Azure/azure-sdk-assets and update the connection in azure-sdk-for-net with below

cd azure-sdk-for-net/sdk/{service}/{package}
test-proxy push -a ./assets.json

Done


Tweak transcription rules

Tweak transcription rules to implement TWYS, and other changes to reflect new system capabilities and to reflect Free UK Genealogy methodology.

This is a FC1 issue. We completely reviewed the transcription rules when we wrote the Handbook.
Is this still pertinent?
Geoff


fix: update deps

:tada: This PR is included in version 1.32.19 :tada:
The release is available on:

v1.32.19
GitHub release

Your semantic-release bot :package::rocket:


⚠ API - Lens has degraded performance

In 91e3d21, API - Lens ($LENS_API_URL) experienced degraded performance:

HTTP code: 502
Response time: 336 ms

Resolved: API - Lens performance has improved in 92997d7 after 6 minutes.


Building on Ubuntu

Greetings,
I am having trouble building this library on Ubuntu 16.04 (Swift 3.0.2). The issue may be related to a compiler bug, but I decided to post it here in case you thought otherwise. The code I'll refer to below is that in https://github.com/hkgumbs/SwiftParsec/master, which has only compatibility changes. I think the quickest way to play with Ubuntu 16.04 would be use Docker: docker run -it -v $PWD:/code -w /code swiftdocker/swift bash.
Sources
swift build
...
	Cross-reference to module 'SwiftParsec'
	... TokenParser
	... in an extension in module 'SwiftParsec'
	... identifier
	... with type GenericParser<String, τ_0_0.UserState, String>

I found a SO post that described similar symptoms, and the recommendation there is to use the  -whole-module-optimization flag.
swift build -Xswiftc -whole-module-optimization -c release

The release configuration is what ultimately tells the swift-build-tool to look elsewhere for dependency mappings (Source). Otherwise, swift build fails with unable to open dependencies file '/code/.build/debug/SwiftParsec.build/CharacterMembership.d'.
Tests
These flags don't port as nicely to tests. I think this is the major issue since I want to verify that the changes and optimizations are not affecting the behavior of the library. The root of the problem seems to be that I cannot force -c release in test builds. One workaround is run swift test -Xswiftc -whole-module-optimization then manually modify .build/debug.yaml:
--- a/.build/debug.yaml
+++ b/.build/debug.yaml
@@ -22 +22 @@ commands:
-    enable-whole-module-optimization: false
+    enable-whole-module-optimization: true
@@ -38 +38 @@ commands:
-    enable-whole-module-optimization: false
+    enable-whole-module-optimization: true

Once you make those changes, you can run the swift-build-tool manually, and it will compile the tests. However, you'll still see a problem at link time. The output is mostly gibberish - this is the farthest I've gotten:
/usr/bin/swift-build-tool -f /code/.build/debug.yaml test
...

Like I mentioned at the start, this doesn't seem to be an issue with your project specifically, but I thought I'd bring it up just in case you had any ideas.
Cheers!

Hi,
Thank you for your interest in SwiftParsec. I didn't work on porting the library to linux yet. But I'm planning to do so when I'll have more time. If you manage to do so, feel free to contribute.
Thank you for your research.

@davedufresne I'm not sure how to contact you outside of GitHub, but I've submitted a PR that implements this.

@hkgumbs you can find my email address in one of my commits. I will try to start code reviewing this weekend. Thanks for your work.

Great job! Many thanks. I only left comments about minor styling issues. As soon as you fix them I'll release a new version of the library.


Proposal: list of URL schemes to support in markdown rendering

Currently we're allowing only http and https schemes (protocols) in links rendered markdown. There are users that want others, like ftp (e.g. #8478)
Currently, this renders nothing:
[My link](ftp://www.mysite.com)

There are a number of other schemes we could support, and some of them could be very useful, like the aforementioned ftp, VS Code extensions, cvs, ed2k, torrent, git, ssh, magnet, maps, sftp, skype, svn, etc.
I'm not sure which ones could pose a security problem, so I propose adding an app.ini settings with the list of desired schemes. The obvious default is http, https, but perhaps we want to add ftp and others, so let's hear out your ideas.

Seems like a good addition. mailto: is another common scheme. Does anyone have insight on what possible security concerns could be?

Link to uri schemes is helpful. Consistency with either Github or Gitlab markdown links is probably reasonable.


C: no such highlight group name

When opening a c file in vim in the terminal, i get this output:
line    3:
E28: No such highlight group name: cConditional
line    4:
E28: No such highlight group name: cRepeat
line   46:
E28: No such highlight group name: cType
Any fix? Is it something on my end?

problem on my end, just fixed. I placed c.vim in ~/.vim/syntax instead of ~/.vim/after/syntax


Deploy event - validate if entity exist

Run validation to check if entity exists before sending the deployment event and throw a warning if there expression doesn't match anything. Also add a wait time before executing the query, to allow dynatrace to detect the new process (should be configurable)

solved by using version detection strategies https://docs.dynatrace.com/docs/platform-modules/cloud-automation/release-monitoring/version-detection-strategies and the corresponding tags as the base to filter the target for the deployment event. Actually verifying that the entity exists is complex because of the eventual consistency approach of the events


Why is a venv needed when doing uv pip install --target ?

Thanks a lot for adding the --target option to uv pip install.
I am using 0.1.39.
I am surprised that I do need to create a venv to be allowed to run uv pip install --target.
$ bin/uv pip install --target bla zope.component
error: Failed to locate a virtualenv or Conda environment (checked: `VIRTUAL_ENV`, `CONDA_PREFIX`, and `.venv`). Run `uv venv` to create a virtualenv.

$ bin/uv venv
Using Python 3.11.6 interpreter at: /usr/bin/python3
Creating virtualenv at: .venv
Activate with: source .venv/bin/activate
$ bin/uv pip install --target bla --no-deps zope.component
Resolved 1 package in 5ms
Installed 1 package in 2ms
 + zope-component==6.0
# success !

Is there a reason that I am missing ?

It's consistent with our rules for Python discovery. You can run with --system if you want to discover the system Python.


Base class for estimators using _incremental.fit

Here's a rough draft of what a base class calling _incremental.fit may look like. I've just been stealing pieces from https://github.com/dask/dask-ml/pull/221 and making it work for the random sampler with the remove_worst strategy.
Looking at #221 there were a few pieces that will be common to each subclass

data checking
CV splitting
building cv_results (partly)
selecting the best model (partly)

That leaves a few things that must be done by each class

Building the dict of {model_id: (param_list, additional_calls)}
transforming the output of fit on each of those into a common form

In the end, I'm not sure how much code reuse we'll actually get, but I think it's worth exploring a bit further. A next step would be to make a branch of #221 that builds on top of this, and see how well the hyperband structure maps on to this base class. From there we can decide whether the base class can be adjusted to fit hyperband's needs, or whether it should just be scrapped. I'll try to get to that today.
cc @stsievert

@mrocklin I think this is mostly done for now.
I may do a bit of restructuring to split out the CV-specific parts of DaskBaseSearchCV into a mixin. We currently inherit some things that don't make so much sense.
Followup items are to try out random search and successive halving from https://gist.github.com/mrocklin/4c95bd26d15281d82e0bf2d27632e294 on this. Do you want to do that or should I?

Do you want to do that or should I?

I can take a look.  It'll force me to better understand the system you've
put in place here.
On Fri, Sep 7, 2018 at 11:44 AM, Tom Augspurger<EMAIL_ADDRESS>wrote:

@mrocklin https://github.com/mrocklin I think this is mostly done for
now.
I may do a bit of restructuring to split out the CV-specific parts of
DaskBaseSearchCV into a mixin. We currently inherit some things that don't
make so much sense.
Followup items are to try out random search and successive halving from
https://gist.github.com/mrocklin/4c95bd26d15281d82e0bf2d27632e294 on
this. Do you want to do that or should I?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/356#issuecomment-419481063, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszFmEb3_C1Td9L-wlpmDcsSEBIwruks5uYpRRgaJpZM4WcvYU
.

OK, just merged in master to hopefully fix the CI failure.
If you want to "check your work", here's a solution :)

diff --git a/dask_ml/model_selection/_incremental.py b/dask_ml/model_selection/_incremental.py
index c2983ae..b208ae9 100644
--- a/dask_ml/model_selection/_incremental.py
+++ b/dask_ml/model_selection/_incremental.py
@@ -618,3 +618,68 @@ class RandomizedWorstIncrementalSearch(BaseIncrementalSearch):

     def _get_params(self):
         return ParameterSampler(self.parameters, self.n_iter, self.random_state)
+
+
+class RandomIncrementalSearch(BaseIncrementalSearch):
+    def __init__(
+        self,
+        estimator,
+        param_distribution,
+        n_iter=10,
+        max_iter=100,
+        patience=10,
+        tol=0.001,
+        test_size=0.15,
+        random_state=None,
+        scoring=None,
+        iid=True,
+        refit=True,
+        error_score="raise",
+        return_train_score=_RETURN_TRAIN_SCORE_DEFAULT,
+        scheduler=None,
+        n_jobs=-1,
+        cache_cv=True,
+    ):
+        self.max_iter = max_iter
+        self.n_iter = n_iter
+        self.patience = patience
+        self.tol = tol
+        super(RandomIncrementalSearch, self).__init__(
+            estimator,
+            param_distribution,
+            test_size,
+            random_state,
+            scoring,
+            iid,
+            refit,
+            error_score,
+            return_train_score,
+            scheduler,
+            n_jobs,
+            cache_cv
+        )
+
+    def _get_params(self):
+        return ParameterSampler(self.parameters, self.n_iter)
+
+    def _additional_calls(self, info):
+        out = {}
+        max_iter = self.max_iter
+        patience = self.patience
+        tol = self.tol
+
+        for ident, records in info.items():
+            if max_iter is not None and len(records) > max_iter:
+                out[ident] = 0
+
+            elif len(records) > patience:
+                old = records[-patience]["score"]
+                if all(d["score"] < old + tol for d in records[-patience:]):
+                    out[ident] = 0
+                else:
+                    out[ident] = 1
+
+            else:
+                out[ident] = 1
+        print(out)
+        return out

I think some of these parameters should be removed:

iid
refit
error_score
return_train_score
scheduler
n_jobs
cache_cv

But need to double check first.

Care to push up your RandomSearch implementation?
On Fri, Sep 7, 2018 at 1:04 PM, Tom Augspurger<EMAIL_ADDRESS>wrote:

I think some of these parameters should be removed:

iid
refit
error_score
return_train_score
scheduler
n_jobs
cache_cv

But need to double check first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/356#issuecomment-419504102, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszI8RemEqLzCwZeQOP5uw_FxsYntqks5uYqcXgaJpZM4WcvYU
.

NM, I'm on it
On Fri, Sep 7, 2018 at 1:36 PM, Matthew Rocklin<EMAIL_ADDRESS>wrote:

Care to push up your RandomSearch implementation?
On Fri, Sep 7, 2018 at 1:04 PM, Tom Augspurger<EMAIL_ADDRESS>wrote:

I think some of these parameters should be removed:

iid
refit
error_score
return_train_score
scheduler
n_jobs
cache_cv

But need to double check first.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/356#issuecomment-419504102, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszI8RemEqLzCwZeQOP5uw_FxsYntqks5uYqcXgaJpZM4WcvYU
.

So we're not handling history correctly.  It's not clear to me what history should be here actually.  In SKLearn we have one entry per parameter/CV-split.  Now we have many entries.
Currently this is manifesting because things like best_score_ is broken (see recent commit).

n_iter here is closer to "number of initial parameters to try".  Should we change the parameter name?

Any thoughts on how to handle test_size? We probably can't assume that a flat 15% makes sense any longer.

I briefly considered something that would look at X.nbytes and the size of distributed RAM, but didn't pursue it. I'm not sure how robust it would be.

Any thoughts on a better name than additional_calls?

update_calls? Not really sure.

n_iter here is closer to "number of initial parameters to try". Should we change the parameter name?

n_iter is the name used by RandomizedSearchCV, but it has a slightly different meaning in this context so it may be safe to diverge. Perhaps n_initial_parameters.

Any thoughts on how to handle test_size? We probably can't assume that a flat 15% makes sense any longer.

The only purpose of a test set is to provide a stable benchmark. I'd imagine for most uses, having a test dataset that fits in RAM will serve this purpose. I didn't put much thought into 15%, but chose it because it does a reasonable job at trading off amount of data to learn from with test stability (for some model complexity, for some definition of "reasonable").
I guess there's no requirement that the test dataset fit in RAM (though that's likely good enough). We could distribute the test set, score the model on each chunk and take a weighted average with the chunk size.

I guess there's no requirement that the test dataset fit in RAM (though that's likely good enough).

Hmm, interesting. Currently we explicitly call compute the test sets to convert them to ndarrays. We also wrap the scorer in dask.delayed. In practice, both of those means that the training set has to fit in memory, even if it doesn't actually need to in theory.
It doesn't look too difficult to modify _fit to support this directly. I think the main thing is ensuring that the scorer can support dask arrays, and that it returns a delayed score.
Though not sure how high-priority this should be. I share your suspicion that an in-memory dataset is likely to be good enough most of the time.

With the current implemenation the testing data has to fit in memory
On Fri, Sep 7, 2018 at 9:00 PM, Tom Augspurger<EMAIL_ADDRESS>wrote:

FYI @mrocklin https://github.com/mrocklin I pushed a commit fixing a
few compatibility things and your best_score_ issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/356#issuecomment-419600891, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszL-nWIP0gsPfsLbiKksCfJupZ7c_ks5uYxa4gaJpZM4WcvYU
.

Pushed some documentation updates.
On naming, it seems like the class name could capture a few components

initial parameter selection strategy (Randomized vs. Grid)
additional calls strategy
the fact that we're doing hyperparameter optimization.

So I'd propose the naming rubric <Randomized|Grid><Strategy><Search>.

RandomizedPlateauSearch (not sure about plateau)
`RandomziedSuccessiveReductionSearch (that's a mouthful)

OTOH, do we think grid search is useful? We don't have anything that does that yet (though it's trivial to implement; just override _get_params to use ParameterGrid).

Added those two to the public API, and tried to write a bit of prose about what we mean by incremental hyperparameter optimization. Some additional thoughts there would be appreciated.

So I'd propose the naming rubric <Randomized|Grid><Strategy><Search>.

Maybe <Strategy>Search? The initial selection method isn't the focus of this class, though it is important. I'd be inclined to choose random parameter sampling by default unless params is a list, and maybe provide a parameter_selection keyword to choose between grid and random search.

Maybe Search?

Sounds reasonable.

maybe provide a parameter_selection keyword to choose between grid and random search.

That seems more natural to me.

OK, so some pending topics that I see:

Rename SuccessiveReduction -> ExponentialDecay or something similar?
Rename additional_calls?
Add max_iter and/or patience/tol to successive ?  I'll need to try things out to see how this does.
@stsievert somewhere you have a notebook in which you apply your hyperband solution onto a real-world problem that uses CPUs only.  Would you mind providing a link to that here?

One more thing to consider: exactly what is shared between DaskBaseSearchCV and this class. I think there's not too much, so it might be cleaner to not inherit from DaskBaseSearchCV. I can take care of that on this branch or as a followup.

On the names, I think I prefer ExponentialDecay since it's more indicative of how things are successively reduced.
I haven't come up with anything better than additional_calls. At first it didn't make sense to me, but after having played with it on this branch it seems like the most sensible name.

Add max_iter and/or patience/tol to successive? ... Would you mind providing a link to that here?

Here's a link to the notebook that searches for patience: https://gist.github.com/stsievert/33bdc47b52ffc085dddd75e9b719cc07 I'm running this right now on GCP, and it should be done by the end of today.

Rename additional_calls?

Maybe get_additional_calls?

Do you have any qualitative results from things you've observed?  I'm
surprised that it takes a full day to get a sense for what's going on
here.  I was planning to just run something for 20m or so to get a sense of
what was going on.
On Mon, Sep 10, 2018 at 11:05 AM, Scott Sievert<EMAIL_ADDRESS>wrote:

Add max_iter and/or patience/tol to successive? ... Would you mind
providing a link to that here?
Here's a link to the notebook that searches for patience:
https://gist.github.com/stsievert/33bdc47b52ffc085dddd75e9b719cc07 I'm
running this right now on GCP, and it should be done by the end of today.
Rename additional_calls?
Maybe get_additional_calls?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/356#issuecomment-419946553, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszGAG1cp-R5Bm65S8HohCyUPU7gUZks5uZn-7gaJpZM4WcvYU
.

Do you have any qualitative results from things you've observed?

Having a short patience decreases the best score Hyperband finds. It looks like having patience be 20 epochs (aka passes over training data) preserves the best score Hyperband finds.
It takes so long because running Hyperband once takes about an hour (at least for this example on GCP). I'm running it over different patiences and doing a couple repeats too.

OK, so ExponentialDecaySearch now has all of the functionality of RandomizedSearch if we set decay_rate=0.

So how do people feel about the following:
ExponentialDecay(model, params, n_initial_parameters=100)  # 100 initial parameters
ExponentialDecay(model, params, n_initial_parameters='grid')  # Use full grid

That sounds reasonable to me.

https://github.com/dask/dask-ml/pull/356/commits/658109ecb7ffea7bf25aa7d3c9ab74d08b84d17e makes BaseIncrementalSearch not inherit from DaskBaseSearchCV, since many of the methods / parameters didn't make sense here.
I opted to simply copy the implementation over for the ones we care about. It'd be DRYer to move those to a shared Mixin, but this seems simpler. No preference here.
Finally, https://github.com/dask/dask-ml/pull/356/commits/af25b79774f1bae04bbd64c1f988f6d6c2b3e645 adds docs for using an incremental hyper-parameter optimizer with ParallelPostFit. That'll be, I think, the most common use case, so that .score, .predict, etc. happen on the cluster for dask arrays.

Should we automatically provide ParallelPostFit functionality for
predict/score on this class?
On Mon, Sep 10, 2018 at 4:38 PM, Tom Augspurger<EMAIL_ADDRESS>wrote:

658109e
https://github.com/dask/dask-ml/commit/658109ecb7ffea7bf25aa7d3c9ab74d08b84d17e
makes BaseIncrementalSearch not inherit from DaskBaseSearchCV, since many
of the methods / parameters didn't make sense here.
I opted to simply copy the implementation over for the ones we care about.
It'd be DRYer to move those to a shared Mixin, but this seems simpler. No
preference here.
Finally, af25b79
https://github.com/dask/dask-ml/commit/af25b79774f1bae04bbd64c1f988f6d6c2b3e645
adds docs for using an incremental hyper-parameter optimizer with
ParallelPostFit. That'll be, I think, the most common use case, so that
.score, .predict, etc. happen on the cluster for dask arrays.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/356#issuecomment-420052489, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszC04MHDAgEt-xh74BkNidabgtQwkks5uZs22gaJpZM4WcvYU
.

I had a partially written comment thinking through that, but deleted it
after having not come to a conclusion.
The argument for auto-wrapping with something like ParellelPostFit is that
it's kind of the whole purpose for
this incremental hyperparameter optimization.
The downside is that it's magic that's liable to break things. Initially
wrappers.Incremental had some of this
magic for get_params and set_params, but we removed as it caused larger
issues (e.g. both the metaestimator
and the underlying estimator having the same keyword).
So for now, I'd recommend avoiding the temptation to be clever and just
documenting things.
On Mon, Sep 10, 2018 at 4:54 PM Matthew Rocklin<EMAIL_ADDRESS>wrote:

Should we automatically provide ParallelPostFit functionality for
predict/score on this class?
On Mon, Sep 10, 2018 at 4:38 PM, Tom Augspurger<EMAIL_ADDRESS>wrote:

658109e
<
https://github.com/dask/dask-ml/commit/658109ecb7ffea7bf25aa7d3c9ab74d08b84d17e
makes BaseIncrementalSearch not inherit from DaskBaseSearchCV, since many
of the methods / parameters didn't make sense here.
I opted to simply copy the implementation over for the ones we care
about.
It'd be DRYer to move those to a shared Mixin, but this seems simpler. No
preference here.
Finally, af25b79
<
https://github.com/dask/dask-ml/commit/af25b79774f1bae04bbd64c1f988f6d6c2b3e645
adds docs for using an incremental hyper-parameter optimizer with
ParallelPostFit. That'll be, I think, the most common use case, so that
.score, .predict, etc. happen on the cluster for dask arrays.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/356#issuecomment-420052489, or
mute
the thread
<
https://github.com/notifications/unsubscribe-auth/AASszC04MHDAgEt-xh74BkNidabgtQwkks5uZs22gaJpZM4WcvYU
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/356#issuecomment-420074133, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABQHIpd1nYlSP39iqrAHZj_38NVoHPOeks5uZt-kgaJpZM4WcvYU
.

It looks like this is ready for integration with Hyperband. I'm planning on rebasing off this branch and building up Hyperband tomorrow.

Yeah, this feels pretty close to being ready. @mrocklin do you have any objections to merging it as is?

No objections to merging as is, but I'd like to take another look at names and the API before releasing if possible.  I probably won't get to this before next week.

How do we feel about the following?
Exponential decay with patience on randomly selected parameters
IncrementalSearchCV(model, params, n_initial_params=1000, decay_rate=1.0, patience=20, tol=0.1)

100 partial_fit calls with no decay on a full grid
IncrementalSearchCV(model, params, n_initial_params='grid', decay_rate=0.0, max_iter=100)

cc @ogrisel your feedback on API and functionality here would be welcome

That seems reasonable, with the caveat that we shouldn't have the CV suffix if we're just doing a single train-test split. Now that RandomizedIncrementalSearch is a special-case with no decay, we should get rid of it.

OK, done.
@TomAugspurger I'm curious about your thoughts on the Incremental meta-estimator.  Are there still cases where this is useful (for example in pipelines) or should we start to deprecate it in favor of this mechanism?

I think wrappers.Incremental is still useful when you aren't doing hyperparameter optimization, and it's a bit easier to explain I think. I'll update the docs to try to clarify things.

For the default size of the test data how about using the size of a single chunk.  For example if the input data has ten chunks then we use 10%.  That provides some guarantee that the result will fit into memory.  This would be the default value if test_size=None

Yes that's a very good idea.

Edge case when there's a single parameter
    X, y = make_classification(n_samples=100, n_features=5, chunks=(10, 5))

    model = SGDClassifier(tol=1e-3)

    params = {"alpha": np.logspace(-2, 10, 3)}

    search = IncrementalSearch(model, params, n_initial_parameters="grid")
    search.fit(X, y, classes=[0, 1])

---------------------------------------------------------------------------
StopIteration                             Traceback (most recent call last)
~/sandbox/dask-ml/dask_ml/model_selection/_incremental.py in _fit(self, X, y, **fit_params)
    533         history_results = self._get_history_results(results)
--> 534         best_estimator, best_index = self._get_best(results, history_results)
    535         best_estimator = yield best_estimator

~/sandbox/dask-ml/dask_ml/model_selection/_incremental.py in _get_best(self, results, history_results)
    486         """Select the best estimator from the set of estimators."""
--> 487         best_model_id = first(results.info)
    488         key = operator.itemgetter("model_id")

~/Envs/dask-dev/lib/python3.6/site-packages/toolz/itertoolz.py in first(seq)
    367     """
--> 368     return next(iter(seq))
    369

StopIteration:

The above exception was the direct cause of the following exception:

RuntimeError                              Traceback (most recent call last)
<ipython-input-7-048117aa2d7a> in <module>()
----> 1 search.fit(X, y, classes=[0, 1])

~/sandbox/dask-ml/dask_ml/model_selection/_incremental.py in fit(self, X, y, **fit_params)
    559             Additional partial fit keyword arguments for the estimator.
    560         """
--> 561         return default_client().sync(self._fit, X, y, **fit_params)
    562
    563     @if_delegate_has_method(delegate=("best_estimator_", "estimator"))

~/Envs/dask-dev/lib/python3.6/site-packages/distributed/client.py in sync(self, func, *args, **kwargs)
    645             return future
    646         else:
--> 647             return sync(self.loop, func, *args, **kwargs)
    648
    649     def __repr__(self):

~/Envs/dask-dev/lib/python3.6/site-packages/distributed/utils.py in sync(loop, func, *args, **kwargs)
    275             e.wait(10)
    276     if error[0]:
--> 277         six.reraise(*error[0])
    278     else:
    279         return result[0]

~/Envs/dask-dev/lib/python3.6/site-packages/six.py in reraise(tp, value, tb)
    691             if value.__traceback__ is not tb:
    692                 raise value.with_traceback(tb)
--> 693             raise value
    694         finally:
    695             value = None

~/Envs/dask-dev/lib/python3.6/site-packages/distributed/utils.py in f()
    260             if timeout is not None:
    261                 future = gen.with_timeout(timedelta(seconds=timeout), future)
--> 262             result[0] = yield future
    263         except Exception as exc:
    264             error[0] = sys.exc_info()

~/Envs/dask-dev/lib/python3.6/site-packages/tornado/gen.py in run(self)
   1131
   1132                     try:
-> 1133                         value = future.result()
   1134                     except Exception:
   1135                         self.had_exception = True

~/Envs/dask-dev/lib/python3.6/site-packages/tornado/gen.py in run(self)
   1145                             exc_info = None
   1146                     else:
-> 1147                         yielded = self.gen.send(value)
   1148
   1149                     if stack_context._state.contexts is not orig_stack_contexts:

RuntimeError: generator raised StopIteration

On it
On Mon, Sep 17, 2018 at 3:48 PM, Tom Augspurger<EMAIL_ADDRESS>wrote:

Edge case when there's a single parameter
X, y = make_classification(n_samples=100, n_features=5, chunks=(10, 5))

model = SGDClassifier(tol=1e-3)

params = {"alpha": np.logspace(-2, 10, 3)}

search = IncrementalSearch(model, params, n_initial_parameters="grid")
search.fit(X, y, classes=[0, 1])

StopIteration                             Traceback (most recent call last)
~/sandbox/dask-ml/dask_ml/model_selection/_incremental.py in _fit(self, X, y, **fit_params)
533         history_results = self._get_history_results(results)
--> 534         best_estimator, best_index = self._get_best(results, history_results)
535         best_estimator = yield best_estimator
~/sandbox/dask-ml/dask_ml/model_selection/_incremental.py in _get_best(self, results, history_results)
486         """Select the best estimator from the set of estimators."""
--> 487         best_model_id = first(results.info)
488         key = operator.itemgetter("model_id")
~/Envs/dask-dev/lib/python3.6/site-packages/toolz/itertoolz.py in first(seq)
367     """
--> 368     return next(iter(seq))
369
StopIteration:
The above exception was the direct cause of the following exception:
RuntimeError                              Traceback (most recent call last)
 in ()
----> 1 search.fit(X, y, classes=[0, 1])
~/sandbox/dask-ml/dask_ml/model_selection/_incremental.py in fit(self, X, y, **fit_params)
559             Additional partial fit keyword arguments for the estimator.
560         """
--> 561         return default_client().sync(self.fit, X, y, **fit_params)
562
563     @if_delegate_has_method(delegate=("best_estimator", "estimator"))
~/Envs/dask-dev/lib/python3.6/site-packages/distributed/client.py in sync(self, func, *args, **kwargs)
645             return future
646         else:
--> 647             return sync(self.loop, func, *args, **kwargs)
648
649     def repr(self):
~/Envs/dask-dev/lib/python3.6/site-packages/distributed/utils.py in sync(loop, func, *args, **kwargs)
275             e.wait(10)
276     if error[0]:
--> 277         six.reraise(*error[0])
278     else:
279         return result[0]
~/Envs/dask-dev/lib/python3.6/site-packages/six.py in reraise(tp, value, tb)
691             if value.traceback is not tb:
692                 raise value.with_traceback(tb)
--> 693             raise value
694         finally:
695             value = None
~/Envs/dask-dev/lib/python3.6/site-packages/distributed/utils.py in f()
260             if timeout is not None:
261                 future = gen.with_timeout(timedelta(seconds=timeout), future)
--> 262             result[0] = yield future
263         except Exception as exc:
264             error[0] = sys.exc_info()
~/Envs/dask-dev/lib/python3.6/site-packages/tornado/gen.py in run(self)
1131
1132                     try:
-> 1133                         value = future.result()
1134                     except Exception:
1135                         self.had_exception = True
~/Envs/dask-dev/lib/python3.6/site-packages/tornado/gen.py in run(self)
1145                             exc_info = None
1146                     else:
-> 1147                         yielded = self.gen.send(value)
1148
1149                     if stack_context._state.contexts is not orig_stack_contexts:
RuntimeError: generator raised StopIteration
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/356#issuecomment-422146361, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszC011l4dJT2ACj0C564Q_TZqeJJ1ks5ub_yfgaJpZM4WcvYU
.

Added small tests for predict_proba, predict_log_proba, transform, and decision_function.

Sometimes the shape of the result in test_transform differs.  Is this expected?

Sorry, fixed.

+1


Possible to import via CDN?

Hi,
I'd really like to use this for a project; any chance to make it importable via a CDN?
Thanks.

Hi,
Of course you can using jsDelivr it creates urls for es modules and common js. You can use it for any package in npm registry.
regards

Common JS is not supported in the browser only ES Modules.
<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Document</title>
</head>
<body>
  <script type="module">
    import { DxfWriter } from 'https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>
    const dxf = new DxfWriter();
    // your code here
    console.log(dxf.stringify()) // get the dxf content.
    </script>
</body>
</html>

Thanks!


Question: Best way to present keyboard

Hey there! May I ask what's the best way to make the specific text field in EKFormMessageView to become the first responder?

I am curious as well. If anyone has an answer please let me know

Hi there! Sorry for taking long to respond!
Currently, there is no way to do what you ask (but to fork and change the internals).

Sorry I had another question. When I set the text of the ImageNote's label
from one of your built in examples, the text go past the screen. I notice
there's a numberOfLines property but changing it doesn't work. Any
thoughts? Thanks
On Wed, Sep 26, 2018 at 10:24 AM Herman Kayy<EMAIL_ADDRESS>wrote:

Hey Daniel,
Thanks for the response! Please let me know if you find a way around the
first responder thing. Really appreciate the time you put in into
SwiftEntryKit it's been an amazing framework so far.
On Wed, Sep 26, 2018 at 12:07 AM Daniel Huri<EMAIL_ADDRESS>wrote:

Hi there! Sorry for taking long to respond!
Currently, there is no way to do what you ask (but to fork and change the
internals).
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/huri000/SwiftEntryKit/issues/107#issuecomment-424608823,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AfXOqB3ZplyQbS1IwWSsbDPfXZLRWVYpks5ueye6gaJpZM4Wly9O
.

--
Cell:<PHONE_NUMBER>
Linkedin: Linkedin.com/in/hermankayy
Github: Github.com/hermankayy

--
Cell:<PHONE_NUMBER>
Linkedin: Linkedin.com/in/hermankayy
Github: Github.com/hermankayy

@retsohuang, @HermanKayy - Version 0.7.1 supports exactly that. Please see the CHANGELOG for the exact implementation info. I've added a sample that does that as well, inside PresetsViewController:
func showSignupForm(attributes: inout EKAttributes, style: FormStyle) { ... }

@HermanKayy - About that label issue - I'll look into it today/tomorrow. I'll keep you updated inside the related issue thread.


BULK VALIDATION missing descriptions 2

Docs Build status updates of commit d7a7f3a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Skype/SDN/articles/roundtripmax-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:warning:Warning

Details

Skype/SDN/articles/skype-for-business-sdn-interface-architecture.md
:warning:Warning

Details

Skype/SDN/articles/setting-up-sql-server-for-a-sdn-manager-database.md
:bulb:Suggestion

Details

Skype/SDN/articles/roundtrip-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/roundtripmax-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-messagetype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-messagetype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-qualitytype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-qualitytype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/routetype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/routetype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-and-debugging-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-and-debugging-skype-for-business-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-dialog-listene.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-sdn-interface-dialog-listener.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-sdn-interface-sdn-manager.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-sdn-manager.md
:white_check_mark:Succeeded

Skype/SDN/articles/schema-extensions.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-interface-bandwidth-estimates.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-interface-performance-overview.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-manager-command-line-example.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-manager-configuration-file-example.md
:white_check_mark:Succeeded

Skype/SDN/articles/sendlistenmos-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/sendlistenmos-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/sendlistenmosmin-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.

Skype/SDN/articles/roundtripmax-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md

Line 5, Column 1: [Warning: yaml-duplicate-key] Key 'description' is already defined, remove the duplicate key.

Skype/SDN/articles/skype-for-business-sdn-interface-architecture.md

Line 8, Column 1: [Warning: yaml-duplicate-key] Key 'description' is already defined, remove the duplicate key.

Skype/SDN/articles/setting-up-sql-server-for-a-sdn-manager-database.md

Line 2, Column 1: [Suggestion: description-missing - See documentation] Missing required attribute: 'description'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 7e63333:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/roundtrip-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/roundtripmax-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-messagetype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-messagetype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-qualitytype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-qualitytype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/routetype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/routetype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-and-debugging-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-and-debugging-skype-for-business-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-dialog-listene.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-sdn-interface-dialog-listener.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-sdn-interface-sdn-manager.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-sdn-manager.md
:white_check_mark:Succeeded

Skype/SDN/articles/schema-extensions.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-interface-bandwidth-estimates.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-interface-performance-overview.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-manager-command-line-example.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-manager-configuration-file-example.md
:white_check_mark:Succeeded

Skype/SDN/articles/sendlistenmos-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/sendlistenmos-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/sendlistenmosmin-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/sendlistenmosmin-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/setting-up-sql-server-for-a-sdn-manager-database.md
:white_check_mark:Succeeded

Skype/SDN/articles/setting-up-sql-server-for-a-sdn-manager-db.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Global effort to fix build validation errors
@lindalu-MSFT
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you’d like to see. Thank you!

Docs Build status updates of commit af93f9e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Skype/SDN/articles/roundtrip-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/roundtripmax-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-messagetype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-messagetype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-qualitytype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/route-element-qualitytype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/routetype-complextype-skype-for-business-sdn-interface-2-2-schema-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/routetype-complextype-skype-for-business-sdn-interface-2-2-schema-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-and-debugging-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-and-debugging-skype-for-business-sdn-interface.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-dialog-listene.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-sdn-interface-dialog-listener.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-sdn-interface-sdn-manager.md
:white_check_mark:Succeeded

Skype/SDN/articles/running-the-sdn-manager.md
:white_check_mark:Succeeded

Skype/SDN/articles/schema-extensions.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-interface-bandwidth-estimates.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-interface-performance-overview.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-manager-command-line-example.md
:white_check_mark:Succeeded

Skype/SDN/articles/sdn-manager-configuration-file-example.md
:white_check_mark:Succeeded

Skype/SDN/articles/sendlistenmos-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/sendlistenmos-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/sendlistenmosmin-element-qualitypropertiestype-complextype-skype-sdn-2-2-c.md
:white_check_mark:Succeeded

Skype/SDN/articles/sendlistenmosmin-element-qualitypropertiestype-complextype-skype-sdn-2-2-d.md
:white_check_mark:Succeeded

Skype/SDN/articles/setting-up-sql-server-for-a-sdn-manager-database.md
:white_check_mark:Succeeded

Skype/SDN/articles/setting-up-sql-server-for-a-sdn-manager-db.md
:white_check_mark:Succeeded

This comment lists only the first 25 files in the pull request.
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


See if we get a failure.

Make sure we get a test failure with v5 image and southcentralus.

Failed with expected failure--
{"timestampSeconds":1694197615,"timestampNanos":363000000,"severity":"ERROR","message":"Failed to create landing zone Postgres resource. landingZoneId=bda067db-0c5a-488f-becf-3dac96f9f7b3: com.azure.core.management.exception.ManagementException: Long running operation is Failed or Cancelled.: Subscriptions are restricted from provisioning in this region. Please choose a different region. For exceptions to this rule please open a support request with Issue type of 'Service and subscription limits'. See https://review.learn.microsoft.com/en-us/azure/postgresql/flexible-server/how-to-request-quota-increase for more details.","serviceContext":{"service":null,"version":null},"context":"default","thread":"pool-4-thread-2","logger":"bio.terra.landingzone.stairway.flight.create.resource.step.BaseResourceCreateStep","logging.googleapis.com/sourceLocation":{"file":"bio/terra/landingzone/stairway/flight/create/resource/step/


heimdall-7

The groupId for Heimdall was changed from com.miq.automation to com.miqdigital.automation.

@aakash17kc can you please create a ticket for this and add it under Issues?

@aakash17kc can you please create a ticket for this and add it under Issues?

It is the part of "Add Heimdall on Maven Central" issue. Attaching the link - https://github.com/MediaIQ/heimdall/issues/7


pulp build --to dist/Main.js failed but pulp build --to Main.js succeeded

In Chapter8:
The following command is roughly the same as https://leanpub.com/purescript/read#leanpub-auto-the-eff-monad-1, but failed like this:
qs@BF:~/../chapter8$ pulp build -O --to dist/Main.js
* Building project in /home/qs/Data/Documents/SourceCode/PureScript/purescript-book/chapter8
* Build successful.
* Bundling Javascript...
events.js:85
      throw er; // Unhandled 'error' event
            ^
Error: ENOENT, open 'dist/Main.js'
    at Error (native)

However the following succeeded without any problem.
qs@BF:~/../chapter8$ pulp build -O --to Main.js
* Building project in /home/qs/Data/Documents/SourceCode/PureScript/purescript-book/chapter8
* Build successful.
* Bundling Javascript...
* Bundled.

And if I modify the html/index.html to point to Main.js, the web page functions as expected.
My platform:

Operating System: Ubuntu 14.04.3
PureScript: pre-compiled binary <IP_ADDRESS>

Make sure directory dist exist in advance of pulp build -O --to dist/Main.js.

Thanks, I'll add a note to the book about this :+1:


How to detect a successful run?

Hey, great additon to Cakebuild. Using it with Pester post-build regression, completely love it.
However, not too sure on how to detect a successful outcome of StartPowershellFile(). Docs say it returns an array of PSObject, so.. what would be the easiest way to detect if StartPowershellFile had an exception or something?

I have a similar question regarding StartPowershellScript. I see the following line in the console output which says that an error occurred:
Exception of type 'System.Exception' was thrown

But the build is not failed. I would like to have the build failed in this case and also print exception details.

Alter your Powershell script to return a custom value, parse the PsObject in Cake and throw an exception in Cake based on its value.
Found a link on StackOverflow  that will give you a starting point. If you get it working can you add it to the example script for others to follow.


Update opera-beta to 46.0.2597.6

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Thank you for the contribution. It was merged directly as 3d0f8a78a11f4adb43cbcf9b6b49c22f93b83e12. Your contribution is still credited to you.


Change #metamorphoize to #metamorphosize in 1st instruction ("app/controllers/tadpoles_controller.rb")

This pull request has been automatically created by learn.co.

thanks


Hints popover: controls disappear the second time the popover is displayed

VSCode Version: 1.32.3
OS Version: macOS 10.14.4

Steps to Reproduce:

Create a new typescript file
Type the following code:

function reverse<T>(items: T[]): T[] {
    var toreturn = [];
    for (let i = items.length - 1; i >= 0; i--) {
        toreturn.push(items[i]);
    }
    return toreturn;
}

var sample = [1, 2, 3];
var reversed = reverse(sample);
console.log(reversed); // 3,2,1

// Safety!
reversed[0] = '1';     // Error!
reversed = ['1', '2']; // Error!

reversed[0] = 1;       // Okay
reversed = [1, 2];     // Okay

move the mouse over the first error: a popover will appear
click on peek problems
notice the nav arrows on the right of the popover  and the close button that appear
click on the close button
repeat steps 3/4

What happens?
The popover that is opened the second time does not have the arrows/close buttons
What should happen?
The popover should have the close button/arrows to navigate between each problem.
Video: https://www.youtube.com/watch?v=35mdvNlGPPw&feature=youtu.be

Duplicate of https://github.com/Microsoft/vscode/issues/70138


[Doc] Improve Array API documentation

ref: https://docs.cupy.dev/en/latest/reference/array_api.html
Potential improvements:

[ ] Add an example for stream/device management
[ ] Add code snippets to demo how to use the Array API
[ ] Add from_dlpack to demo interoperability
[ ] Document missing dunder methods for the Array object

I wanted to cross-reference to the array API standard using intersphinx directly, but it's blocked by this issue: data-apis/array-api#428


Assign tags to monitor

First of all, nice work! Thanks!
But currently it is not possible to assign tags to a monitor or is it possible?
Cant find any tag key in the monitor schema API for that ;(

I was looking in the docs: https://uptime-kuma-api.readthedocs.io/en/latest/
Looks like you can using:
api.add_monitor_tag(
    tag_id=1,
    monitor_id=1,
    value="test"
)

Works! Thanks!


Added Cloudwatt driver

Added Driver for new French cloud provider Cloudwatt https://www.cloudwatt.com/fr/
This provider is based on OpenStack but uses a custom kind of authentication,
The request data must look like below:
{'auth': {
'passwordCredentials': {
'username': 'THE_USERNAME',
'password': 'THE_PASSWORD'
},
'tenantId': 'THE_TENANT_ID
}}
So, I adapt classes to accept tenant_id argument.
I manually tested it with a custom script and Driver.list_nodes().

Do you want me to remake this patch from actual trunk ?

Hi @ZuluPro sorry for the delay. Can you rebase on trunk and squash your commits. We will then look into merging it.

Ok, I will make !

@ZuluPro Thanks.
Is it possible to get a test Cloudwatt account / credentials? I would like to test this driver before merging those changes into trunk.

@Kami, Sorry, my account is only for work purpose, Maybe you can ask them one account with notoriety of libcloud ?

@ZuluPro I've made some changes so it works with the latest OpenStack auth refactoring (8aa3e27563970decd851ca84672562a41e53ef0a) and merged changes into trunk.
Next time please make sure you create a branch for your changes and don't directly commit to trunk - this will make it easier for both of us (this time, I needed to do some git foo and rebase to get it into mergable state).
Please also submit a new pull request which inclues documentation and usage examples for the driver (see libcloud/compute/drivers*.rst` for an examples) - driver without documentation (and tests) is not really useful.
Thanks.


feat(httpit): support http/2

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Codecov Report

Merging #53 (63425ea) into main (554e3b8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   98.13%   98.15%   +0.01%
==========================================
  Files           8        8
  Lines         698      705       +7
==========================================
+ Hits          685      692       +7
  Misses          9        9
  Partials        4        4

Impacted Files
Coverage Δ

main.go
92.10% <100.00%> (+0.21%)
:arrow_up:

pit/client.go
100.00% <100.00%> (ø)

pit/config.go
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554e3b8...63425ea. Read the comment docs.


chore(main): release 0.6.0

:robot: I have created a release beep boop
0.6.0 (2023-02-26)
Features

add yarn lock file v1 support (4de4751)
run in parallel reading & validating tasks (c19d2d3)

Chores

deps: update dependency @trivago/prettier-plugin-sort-imports to v4.1.1 (a31bfc6)
deps: update vitest monorepo to v0.29.1 (58c4824)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/smarlhens/npm-pin-dependencies/releases/tag/v0.6.0 :sunflower:


Use arrow notation for FFI

I think it's safe to assume ES6 compatibility now.
Users may turn to Babel if necessary.

:-1: from me, there's no real reason to do this, and now people might have to think about Babel where before it just worked.

Agreed with @garyb. According to caniuse, 6% of people globally are using browsers which don’t support arrow functions; that’s too many to justify this, in my view.

Found https://github.com/purescript/purescript/pull/3714 to provide more background on the no-arrow decision.


Prepared States dependency should be Reference Counted

Description

When using prepared states, Future requires to be 'static so they can be spawned via spawn_local.
Currently, prepared states accept a FnOnce<&D> -> impl Future<T> + 'static type as its closure type.
If the closure is not rewritten, the lifetime of &D can be extended with cloning.
|deps| {
    let deps = deps.clone();
    async move {
        // ...
    }
}

However, as we rewrite prepared states from async closure to closure + async block automatically, users do not have the ability to add any statements between the closure and async block.
This pull request adjusts the signature so that it passes Rc<D> instead of &D so the async block can be guaranteed to live 'static.
Checklist

[x] I have reviewed my own code
[ ] I have added tests

I'd argue that we should add a Clone bound on deps so they don't end up being double Rcd. See the following example:
#[derive(Properties, PartialEq)]
struct CloneProps {
    state: Vec<u8>,
}

#[function_component)]
fn Cloned(props: &CloneProps) -> Html {
    let state = use_preapred_state!(async move |state: Rc<Vec<u8>>| {  }}, props.state.clone()) // notice how this clone is required

    html! {}
}

#[derive(Properties, PartialEq)]
struct RcProps {
    state: Rc<Vec<u8>>,
}

#[function_component]
fn RcComp(props: &RcProps) -> Html {
    let state = use_preapred_state!(async move |state: Rc<Rc<Vec<u8>>>| {  /* now there's double Rc*/ }}, Rc::clone(&props.state)) // No clone of data is done

    html! {}
}

#[function_component]
fn Parent() -> Html {
    let state = use_state(Vec::<u8>::new)

    html! {
        <div>
            <RcComp state={Rc::clone(&*state)} /> // this won't compile, but that is a another issue that we should deal with
            <Cloned state={(*state).clone()} />
        </div>
    }
}

Notice how we can avoid the clone by modifying use_state to return an Rc.
This problem isn't limited to this hook either. It spans to other hooks as well, such as use_future_with_deps.

serde does not implement Serialize and Deserialize for Rc<T> by default.
I think we have 2 ways to solve this:

Accept deps as-is and Provide Rc<T> for them.
Create a sealed trait ReferenceCounted to ensure only Rc<T> and Arc<T> is passed as deps and use associated types on trait (<D as ReferenceCounted>::Stored) for extraction of T.

There's another option of making the parameter PartialEq + Clone and forcing users to Rc::new it. That would cover the cases where Rc is not needed and where the value is already an Rc

There's another option of making the parameter PartialEq + Clone and forcing users to Rc::new it. That would cover the cases where Rc is not needed and where the value is already an Rc

We cannot do this with Clone + PartialEq because Rc<T> is not Serialize + Deserialize even if T is.
To achieve this, we need a way to extract T: Serialize + Deserialize + PartialEq + 'static from the following types:

Rc<T> where T: Serialize + Deserialize + PartialEq + 'static
T: Serialize + Deserialize + Clone + PartialEq + 'static

Which needs specialisation.


"go test" failed

$ go test
# _/home/mpech/disco/libdisco
./conn_test.go:71:25: conversion from int to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
FAIL	_/home/mpech/disco/libdisco [build failed]
$ go version
go version go1.15.5 linux/amd64

hey! Thanks for reporting this @tankf33der , do you want to submit a PR to fix it : o ?

I never use PR, fix it, setup CI, add green badge.


show_in_notebook() flips positive/negative values when labels or top_labels is specified

show_in_notebook() seems to have a bug if the explanation is generated for a "0" label rather than a "1".
What the explanation should look like:

What it looks like if you specify labels=[0] or top_labels=1 in explain_instance():

Here's a Colab notebook to reproduce, based on the tutorial notebook Lime - basic usage, two class case.ipynb.

This is indeed a bug, due to a hack I added to the javascript where I assume that if you have binary classification you'd always want to see the same plot with label 0 on the left and label 1 on the right.
I think I just won't fix it, as I think that is a fair assumption and people should just use labels=(1,) if they're doing binary classification (I should document it though).
Thanks!!


update help text

that was like one of the first pieces of code ever written and it is not up to par lol

done in e55168c3733850ab16442e2f347ebdf6a152a665


Tests namespace in production

Tests are only useful during the development stage. Their namespaces shouldn't pollute the autoloader in production.

Thanks very much @michaelspiss ! Merged and release tagged as v1.3.1.


tools shuffle-files-cleaner

Why are the changes needed?
Add Kyuubi tools cache-file-cleaner on kubernetes.
This tools help to start daemonSet on Kubernetes to clean shuffle file and spark cache file.
By config some envs, cache-file-cleaner will help to check some old file(which depending on configuration) and delete them for free dist.
And after first cleaning, if the free capacity lower than threshold, cache file cleaner will start deep clean to help free dist.
With the cache-file-cleaner, add Dockerfile, entrypoint and daemonSet.yaml to help user to use this tool.
Using threadPool to help delete shuffle files.
How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[x] Run test locally before make a pull request

Codecov Report

Merging #704 (93d5995) into master (2a05326) will decrease coverage by 1.58%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
- Coverage   80.52%   78.93%   -1.59%
==========================================
  Files         122      124       +2
  Lines        4730     4843     +113
  Branches      572      590      +18
==========================================
+ Hits         3809     3823      +14
- Misses        600      699      +99
  Partials      321      321

Impacted Files
Coverage Δ

...org/apache/kyuubi/tools/kubernetes/Constants.scala
0.00% <0.00%> (ø)

...ools/kubernetes/KubernetesShuffleFileCleaner.scala
0.00% <0.00%> (ø)

...kyuubi/engine/spark/operation/SparkOperation.scala
70.14% <0.00%> (-7.47%)
:arrow_down:

...mon/src/main/scala/org/apache/kyuubi/Logging.scala
57.14% <0.00%> (-4.23%)
:arrow_down:

...c/main/scala/org/apache/kyuubi/schema/RowSet.scala
84.35% <0.00%> (-3.41%)
:arrow_down:

...g/apache/kyuubi/engine/spark/KyuubiSparkUtil.scala
90.90% <0.00%> (-3.21%)
:arrow_down:

...ala/org/apache/kyuubi/session/SessionManager.scala
52.94% <0.00%> (-2.30%)
:arrow_down:

...e/authentication/KyuubiAuthenticationFactory.scala
77.50% <0.00%> (-1.08%)
:arrow_down:

...rg/apache/kyuubi/engine/spark/SparkSQLEngine.scala
68.51% <0.00%> (-0.72%)
:arrow_down:

...org/apache/kyuubi/ha/client/ServiceDiscovery.scala
55.62% <0.00%> (-0.27%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a05326...93d5995. Read the comment docs.

close this PR for creating new one
KYUUBI #768


[feature] Adding SystemVerilog support

Tasks;

[x] add SystemVerilog simulator
[x] add circuit print
[x] add stats of the circuit (number of wires, regs, memory, ...)
[ ] add waveform
[x] add an example of Google Colab usage: link

great to have SystemVerilog!

Can CAD4u install locally using Anaconda or Conda? thanks.


Get additional loader errors when trying to build with babel-plugin-redux-saga

Steps to reproduce

Clone https://github.com/philbarresi/demo-babel-plugin-redux-saga-issue
npm install
npm run build

The build will then fail.
Description of the bug/issue
Attempting to build while using babel loader and babel-plugin-redux-saga causes the build to fail
 {
            test: /\.(js|jsx)$/,
            include: jsSourcePath,
            loader: require.resolve("babel-loader"),
            options: {
              babelrc: false,
              presets: [
                [
                  require.resolve("@babel/preset-env"),
                  {
                    useBuiltIns: "usage",
                    corejs: 3
                  }
                ],
                require.resolve("@babel/preset-react")
              ],
              plugins: ["babel-plugin-redux-saga"],
              compact: true
            }
          },

Steps to reproduce the bug/issue

See above
...

Example
I have provided a demo repository at https://github.com/philbarresi/demo-babel-plugin-redux-saga-issue
Actual results
ERROR in ./src/js/sagas/test/index.js 15:131
Module parse failed: Unexpected token (15:131)
File was processed with these loaders:
 * ./node_modules/babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
|  */ // export all watcher sagas as an array to be composed in the top level
| // root saga
> Object.defineProperty(fetchManifest,"@@redux-saga/LOCATION",{value:{fileName:"src/js/sagas/test/index.js",lineNumber:8,code:null}})export default testSagas;function getManifest(){return Promise.resolve({icons:["$pac","0xbtc","2give","abt","act","zrx"]});}
 @ ./src/js/sagas/index.js 1:1160-1202 1:1417-1426
 @ ./src/js/config/configureStore.js
 @ ./src/js/index.js
 @ multi ./src/js/index.js

The Expected results
I expect the bundle to be built.
Environment information
Redux saga 1.1.3
    "@babel/core": "^7.8.4",
    "@babel/polyfill": "^7.8.3",
    "@babel/preset-env": "^7.8.4",
    "@babel/preset-react": "^7.8.3",
    "babel-loader": "^8.0.6",
    "babel-plugin-redux-saga": "^1.1.2",
    "babel-preset-env": "^1.7.0",
    "babel-preset-react": "^6.24.1",
    "core-js": "^3.6.4",
    "fibers": "^4.0.2",
    "file-loader": "^5.0.2",
    "html-loader": "^0.5.5",
    "html-webpack-plugin": "^3.2.0",
    "react": "^16.12.0",
    "react-dom": "^16.12.0",
    "react-hot-loader": "^4.12.19",
    "react-redux": "^7.1.3",
    "redux": "^4.0.5",
    "redux-saga": "^1.1.3",
    "thread-loader": "^2.1.3",
    "webpack": "^4.41.5",
    "webpack-cli": "^3.3.10"

Interesting. I've located the syntax error and confirmed the issue - but not sure why the output has been generated like this. Need to investigate further, might a bug in Babel itself.

I'm not sure why, but adding an extra semicolon to the template resolves the issue:
  var extendExpressionWithLocationTemplate = template(`
    Object.defineProperty(TARGET, SYMBOL_NAME, {
      value: {
        fileName: FILENAME,
        lineNumber: LINE_NUMBER,
        code: SOURCE_CODE,
      },
    });;
  `);

Update: that actually makes no sagas run, so that's nice. probably only an accidental fix. Do you have any recommendations where I should post this issue?

I think I will be able to fix this on our side - need to wrap the inserted expression with a statement, I'm still looking into why this happens in the first place though.

Were you ever able to figure out why that happened? I looked through the code again and don't really understand.

I think i've sorted out the issue here. After reading this post...
https://github.com/babel/babel/issues/10526
I realized that the babel-plugin-redux-saga was extracting the CallExpression from the ExpressionStatement.
https://github.com/redux-saga/redux-saga/blob/master/packages/babel-plugin-redux-saga/src/index.js#L53
This is desired in the case of the FunctionExpression and the YieldExpression but not in the case of the FunctionDeclaration. When doing this on the FunctionDeclaration it causes the trailing semicolon to be removed and results in errors when the next expression is concatenated to the wrapped one.

I've started a PR here that fixes the issue https://github.com/redux-saga/redux-saga/pull/2171

Greetings!  Since no progress has been made for awhile I'm going to close this issue.  If anyone stumbles upon this issue and wants to help us debug or provide a PR, please feel free to comment and we can reopen.  Thanks!


One more fix for showing messages without payment.

If money, xp and point payment set to 0 with external API's it still shows action bar even without payment.
It was fixed with #513 but for some reason removed with https://github.com/Zrips/Jobs/commit/a07cbb246d3ebc69b69f140723b5535b2df84383

Seems my last test not worked, but a server restart and using this code will fixed it, weird, but nvm.
Thanks for your PR!


SchemaLocation might collide with properties named the same thing

The new SchemaLocation property is great, but it might collide with defined schema properties. Maybe some sort of unlikely naming convention could be used instead, or convert it to a method?
Would also be great to have it defined in a suitable interface, maybe within IJsonValue?
Our use case is (T : struct, IJsonValue<T>):
var schemaLocation = T.GetSchemaLocation();
var result = new JsonSchema(schemaLocation).Evaluate(jsonPayload);
if (!result.IsValid())
  throw ....
var foo = T.Parse(jsonPayload);

I have failed to add it to the list of global exclusions which would ensure a safe name.
If I add it to the IJsonValue<T> interface it would a) be a breaking change and b) need to be available on all types and I'm not quite sure what I would add for e.g. JsonString etc.
I could add a new interface, IGeneratedFromSchema<T> which includes it, and add that to all the generated types?

As an aside: I'm intrigued to know what you're doing in Evaluate()

A new interface would work as well.
With a global exclusion list, to you mean that certain property names in a schema would not be supported?
We do json instance evaluation on the json payload before trying to parse it, so we know it corresponds to the defined schema. We use JsonSchema.NET for that; https://docs.json-everything.net/schema/basics/#schema-evaluation-2

Oh, you don't need to do that.
Just Parse it and call IsValid() - it's WAAAAY faster than JsonSchema.NET and zero allocation.

As to the global exclusion list - no, it just ensures that the property is named safely (and the documentation now tells you which json property it maps to in the underlying code)

(Depending on how you are managing your json payload you may want to use ParsedValue<T> which gives you a disposable wrapper around your payload to avoid more allocations)
https://github.com/corvus-dotnet/Corvus.JsonSchema/blob/main/Solutions/Corvus.Json.ExtendedTypes/Corvus.Json/ParsedValue{T}.cs

(We love JsonSchema.NET, BTW, but you don't need to bring both to bear on the problem.)

With risk of going off topic even more, you mean Validate is validating the underlaying json structure according to the current json schema validation vocabularies? The output format as well?

There is an overload Validate() that returns a ValidationContext that can capture those results if you pass a higher validation level.
We do not yet provide output from that that conforms to the Output Format schema. If you open an issue for it, though, you may be pleased with the speed with which I can close it 😁

With risk of going off topic even more, you mean Validate is validating the underlaying json structure according to the current json schema validation vocabularies?

And yes, we support draft6, draft6, draft2019-09 and draft2020-12 and validate against the full Json-schema test suite.
(We need to get our Bowtie integration done so everyone can see that!)

I wasn't aware of that, that's really great!


twitter-color-emoji: use noto-fonts-emoji’s src

Motivation for this change

Clean up twitter-color-emoji
Fix #72164 for emojione and twemoji-color-font.

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Notify maintainers
cc @

EmojiOne did fail for me
Traceback (most recent call last):
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/bin/.scfbuild-wrapped", line 18, in <module>
    sys.exit(main())
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/main.py", line 124, in main
Traceback (most recent call last):
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/bin/.scfbuild-wrapped", line 18, in <module>
    return builder.run()
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/builder.py", line 58, in run
    sys.exit(main())
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/main.py", line 124, in main
    fforge.add_glyphs(ff_font, svg_filepaths, self.conf)
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/fforge.py", line 87, in add_glyphs
    u_str = ''.join(map(unichr, u_ids))
NameError: name 'unichr' is not defined
    return builder.run()
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/builder.py", line 58, in run
    fforge.add_glyphs(ff_font, svg_filepaths, self.conf)
  File "/nix/store/6yl3kmgd09r33xs5gc58v9ihymsw1pkl-scfbuild-1.0.3/lib/python3.7/site-packages/scfbuild/fforge.py", line 87, in add_glyphs
    u_str = ''.join(map(unichr, u_ids))
NameError: name 'unichr' is not defined
make: *** [Makefile:93: build/EmojiOneColor-SVGinOT-OSX.ttf] Error 1
make: *** Waiting for unfinished jobs....

@GrahamcOfBorg build twemoji-color-font emojione

The patch was not being applied. Aargh, foiled by phases` again.

@GrahamcOfBorg build twemoji-color-font emojione