error in composer Undefined array key "mahocommerce/maho"

Composer return me this error: "Undefined array key 'mahocommerce/maho'"

https://github.com/MahoCommerce/maho-composer-plugin/blob/49fe8b773fbc50a44e2d8018688ee85f29795f81/src/MahoAutoload.php#L87
I quickly fixed it like this:

my php version is 8.2

quando ti succede? in fase di installazione?

durante un composer update e in dump-autoload --optimize
ti riporto il log
❯ composer update                                                                                ─╯
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 28 updates, 0 removals
  - Upgrading composer/pcre (3.3.1 => 3.3.2)
  - Upgrading composer/semver (3.4.2 => 3.4.3)
  - Upgrading ezyang/htmlpurifier (v4.17.0 => v4.18.0)
  - Upgrading mahocommerce/maho-composer-plugin (dev-main 12a714b => dev-main 49fe8b7)
  - Upgrading mahocommerce/maho-phpstan-plugin (v1.0.0 => v1.2.0)
  - Upgrading mklkj/tinymce-i18n (24.9.2 => 24.11.11)
  - Upgrading pelago/emogrifier (v7.2.0 => v7.3.0)
  - Upgrading phpseclib/phpseclib (3.0.41 => 3.0.42)
  - Upgrading phpstan/phpstan (1.12.2 => 1.12.10)
  - Upgrading psr/log (3.0.1 => 3.0.2)
  - Upgrading sabberworm/php-css-parser (v8.6.0 => v8.7.0)
  - Upgrading squizlabs/php_codesniffer (3.10.2 => 3.11.0)
  - Upgrading symfony/console (v7.1.4 => v7.1.8)
  - Upgrading symfony/css-selector (v7.1.1 => v7.1.6)
  - Upgrading symfony/event-dispatcher (v7.1.1 => v7.1.6)
  - Upgrading symfony/filesystem (v7.1.2 => v7.1.6)
  - Upgrading symfony/finder (v7.1.4 => v7.1.6)
  - Upgrading symfony/options-resolver (v7.1.1 => v7.1.6)
  - Upgrading symfony/polyfill-ctype (v1.30.0 => v1.31.0)
  - Upgrading symfony/polyfill-intl-grapheme (v1.30.0 => v1.31.0)
  - Upgrading symfony/polyfill-intl-normalizer (v1.30.0 => v1.31.0)
  - Upgrading symfony/polyfill-mbstring (v1.30.0 => v1.31.0)
  - Upgrading symfony/polyfill-php80 (v1.30.0 => v1.31.0)
  - Upgrading symfony/polyfill-php81 (v1.30.0 => v1.31.0)
  - Upgrading symfony/process (v7.1.3 => v7.1.8)
  - Upgrading symfony/stopwatch (v7.1.1 => v7.1.6)
  - Upgrading symfony/string (v7.1.4 => v7.1.8)
  - Upgrading tinymce/tinymce (6.8.4 => 6.8.5)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 0 installs, 30 updates, 0 removals
  - Downloading mahocommerce/maho-composer-plugin (dev-main 49fe8b7)
  - Downloading composer/pcre (3.3.2)
  - Downloading squizlabs/php_codesniffer (3.11.0)
  - Downloading ezyang/htmlpurifier (v4.18.0)
  - Downloading symfony/stopwatch (v7.1.6)
  - Downloading symfony/process (v7.1.8)
  - Downloading symfony/polyfill-php81 (v1.31.0)
  - Downloading symfony/polyfill-php80 (v1.31.0)
  - Downloading symfony/polyfill-mbstring (v1.31.0)
  - Downloading symfony/options-resolver (v7.1.6)
  - Downloading symfony/finder (v7.1.6)
  - Downloading symfony/polyfill-ctype (v1.31.0)
  - Downloading symfony/filesystem (v7.1.6)
  - Downloading symfony/event-dispatcher (v7.1.6)
  - Downloading symfony/polyfill-intl-normalizer (v1.31.0)
  - Downloading symfony/polyfill-intl-grapheme (v1.31.0)
  - Downloading symfony/string (v7.1.8)
  - Downloading symfony/console (v7.1.8)
  - Downloading fidry/cpu-core-counter (1.2.0)
  - Downloading psr/log (3.0.2)
  - Downloading composer/semver (3.4.3)
  - Downloading friendsofphp/php-cs-fixer (v3.64.0)
  - Downloading phpstan/phpstan (1.12.10)
  - Downloading mahocommerce/maho-phpstan-plugin (v1.2.0)
  - Downloading mklkj/tinymce-i18n (24.11.11)
  - Downloading symfony/css-selector (v7.1.6)
  - Downloading sabberworm/php-css-parser (v8.7.0)
  - Downloading pelago/emogrifier (v7.3.0)
  - Downloading phpseclib/phpseclib (3.0.42)
  - Downloading tinymce/tinymce (6.8.5)
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Upgrading mahocommerce/maho-composer-plugin (dev-main 12a714b => dev-main 49fe8b7): Extracting archive
  - Upgrading composer/pcre (3.3.0 => 3.3.2): Extracting archive
  - Upgrading squizlabs/php_codesniffer (3.10.2 => 3.11.0): Extracting archive
  - Upgrading ezyang/htmlpurifier (v4.17.0 => v4.18.0): Extracting archive
  - Upgrading symfony/stopwatch (v7.1.1 => v7.1.6): Extracting archive
  - Upgrading symfony/process (v7.1.3 => v7.1.8): Extracting archive
  - Upgrading symfony/polyfill-php81 (v1.30.0 => v1.31.0): Extracting archive
  - Upgrading symfony/polyfill-php80 (v1.30.0 => v1.31.0): Extracting archive
  - Upgrading symfony/polyfill-mbstring (v1.30.0 => v1.31.0): Extracting archive
  - Upgrading symfony/options-resolver (v7.1.1 => v7.1.6): Extracting archive
  - Upgrading symfony/finder (v7.1.3 => v7.1.6): Extracting archive
  - Upgrading symfony/polyfill-ctype (v1.30.0 => v1.31.0): Extracting archive
  - Upgrading symfony/filesystem (v7.1.2 => v7.1.6): Extracting archive
  - Upgrading symfony/event-dispatcher (v7.1.1 => v7.1.6): Extracting archive
  - Upgrading symfony/polyfill-intl-normalizer (v1.30.0 => v1.31.0): Extracting archive
  - Upgrading symfony/polyfill-intl-grapheme (v1.30.0 => v1.31.0): Extracting archive
  - Upgrading symfony/string (v7.1.3 => v7.1.8): Extracting archive
  - Upgrading symfony/console (v7.1.3 => v7.1.8): Extracting archive
  - Upgrading fidry/cpu-core-counter (1.1.0 => 1.2.0): Extracting archive
  - Upgrading psr/log (3.0.0 => 3.0.2): Extracting archive
  - Upgrading composer/semver (3.4.2 => 3.4.3): Extracting archive
  - Upgrading friendsofphp/php-cs-fixer (v3.62.0 => v3.64.0): Extracting archive
  - Upgrading phpstan/phpstan (1.11.11 => 1.12.10): Extracting archive
  - Upgrading mahocommerce/maho-phpstan-plugin (v1.0.0 => v1.2.0): Extracting archive
  - Upgrading mklkj/tinymce-i18n (24.7.29 => 24.11.11): Extracting archive
  - Upgrading symfony/css-selector (v7.1.1 => v7.1.6): Extracting archive
  - Upgrading sabberworm/php-css-parser (v8.6.0 => v8.7.0): Extracting archive
  - Upgrading pelago/emogrifier (v7.2.0 => v7.3.0): Extracting archive
  - Upgrading phpseclib/phpseclib (3.0.41 => 3.0.42): Extracting archive
  - Upgrading tinymce/tinymce (6.8.4 => 6.8.5): Extracting archive
Generating autoload files

In MahoAutoload.php line 73:

  Undefined array key "mahocommerce/maho"

update [--with WITH] [--prefer-source] [--prefer-dist] [--prefer-install PREFER-INSTALL] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-audit] [--audit-format AUDIT-FORMAT] [--no-autoloader] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-m|--minimal-changes] [-i|--interactive] [--root-reqs] [--] [<packages>...]

❯ composer dump-autoload --optimize                                                                                ─╯
Generating optimized autoload files

In MahoAutoload.php line 73:

  Undefined array key "mahocommerce/maho"

dump-autoload [-o|--optimize] [-a|--classmap-authoritative] [--apcu] [--apcu-prefix APCU-PREFIX] [--dry-run] [--dev] [--no-dev] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--strict-psr]

mmmm non riesco a riprodurlo, né 8.2 né 8.3, non è che avevi una versione vecchissima che magari tra plugin di composer ecc s'è scassata in update? se provi con un nuovo clone?

non saprei ma se tolgo la mia patch continua a darmi errore sulla versione correttamente aggiornata

É un progetto figlio o è il clone del core?

è un git clone del mio fork
https://github.com/empiricompany/maho/tree/main
ma sicuramente mi sfugge qualcosa

con livello log su debug mi da errore anche su backend

mmm io ho sempre il developer mode ma forse tu hai l'error reporting più alto proprio nel php.ini

dovrebbe essere quello di default
❯ php -i | grep 'error_reporting'                                                                                ─╯
error_reporting => 22527 => 22527

error_reporting = E_ALL & ~E_DEPRECATED & ~E_STRICT

ho aggiunto la tua patch al plugin composer, puoi fare un update?

sembra ok
❯ composer update                                                                                ─╯
Gathering patches for root package.
Removing package shardj/zf1-future so that it can be re-installed and re-patched.
  - Removing shardj/zf1-future (1.24.0)
Loading composer repositories with package information
Updating dependencies
Lock file operations: 0 installs, 1 update, 0 removals
  - Upgrading mahocommerce/maho-composer-plugin (dev-main 49fe8b7 => dev-main f270363)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 3 updates, 10 removals
  - Downloading mahocommerce/maho-composer-plugin (dev-main f270363)
  - Downloading phpstan/phpstan (2.0.1)
  - Downloading mahocommerce/maho-phpstan-plugin (v2.4.0)
  - Downloading shardj/zf1-future (1.24.2)
  - Removing tinymce/tinymce (6.8.5)
  - Removing symplify/vendor-patches (11.3.7)
  - Removing symfony/polyfill-php81 (v1.31.0)
  - Removing symfony/polyfill-php80 (v1.31.0)
  - Removing symfony/polyfill-mbstring (v1.31.0)
  - Removing symfony/polyfill-intl-normalizer (v1.31.0)
  - Removing symfony/polyfill-intl-grapheme (v1.31.0)
  - Removing symfony/polyfill-ctype (v1.31.0)
  - Removing mklkj/tinymce-i18n (24.11.11)
  - Removing magento-ecg/coding-standard (4.5.4)
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Upgrading mahocommerce/maho-composer-plugin (dev-main 49fe8b7 => dev-main f270363): Extracting archive
  - Upgrading phpstan/phpstan (1.12.10 => 2.0.1): Extracting archive
  - Upgrading mahocommerce/maho-phpstan-plugin (v1.2.0 => v2.4.0): Extracting archive
  - Installing shardj/zf1-future (1.24.2): Extracting archive
  - Applying patches for shardj/zf1-future
    https://raw.githubusercontent.com/MahoCommerce/maho-composer-patches/c0a65fb380c98ae1e0618014d1bbe4e56fa39e01/MAG-1.1.1.patch (MAG-1.1.1)
    https://raw.githubusercontent.com/MahoCommerce/maho-composer-patches/c0a65fb380c98ae1e0618014d1bbe4e56fa39e01/MAG-<IP_ADDRESS>.patch (MAG-<IP_ADDRESS>)
    https://raw.githubusercontent.com/MahoCommerce/maho-composer-patches/e75f155864138ef4ee2b18a82797d6f40d71ad51/MAG-<IP_ADDRESS>.patch (MAG-<IP_ADDRESS> - SUPEE-10415)
    https://raw.githubusercontent.com/MahoCommerce/maho-composer-patches/e75f155864138ef4ee2b18a82797d6f40d71ad51/OM-918.patch (OM-918 - Add runtime cache to Zend_Locale_Data)
    https://raw.githubusercontent.com/MahoCommerce/maho-composer-patches/e75f155864138ef4ee2b18a82797d6f40d71ad51/OM-1081.patch (OM-1081 - Not detecting HTTPS behind a proxy)
    https://raw.githubusercontent.com/MahoCommerce/maho-composer-patches/e75f155864138ef4ee2b18a82797d6f40d71ad51/OM-2047.patch (OM-2047 - Pass delimiter char to preg_quote)
    https://raw.githubusercontent.com/MahoCommerce/maho-composer-patches/e75f155864138ef4ee2b18a82797d6f40d71ad51/OM-2050.patch (OM-2050 - Prevent checking known date codes)

Generating autoload files
30 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
PHP CodeSniffer Config installed_paths delete
No security vulnerability advisories found.
 ~/www/github-maho  on main !1 ?1 ························································· took 7s  at 13:17:06 ─╮
❯ composer update                                                                                ─╯
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Nothing to install, update or remove
Generating autoload files
30 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
No security vulnerability advisories found.

super

@empiricompany had you changed the composer.json name field anywhere in your fork from "name": "mahocommerce/maho", to something else? I also can't reproduce the issue.
Note that if mahocommerce/maho isn't found, you'll get incorrect module load ordering. The patch fixes the warning, but there is something deeper here...

no, composer.json and all other files are  aligned with the upstream in my fork
I didn't touch it

@empiricompany if you don't mind a few more questions:
What version of Composer do you have installed?
Do you see mahocommerce/maho in vendor/composer/installed.php ? If so can you paste the section? Mine looks like:
        'mahocommerce/maho' => array(
            'pretty_version' => 'dev-main',
            'version' => 'dev-main',
            'reference' => '58d73ff36c981b130d57342a461bf464834ac4cb',
            'type' => 'maho-source',
            'install_path' => __DIR__ . '/../../',
            'aliases' => array(),
            'dev_requirement' => false,
        ),

@justinbeaty
❯ composer --version                                                                                ─╯
Composer version 2.7.4 2024-04-22 21:17:03
PHP version 8.2.20 (/usr/bin/php8.2)
Run the "diagnose" command to get more detailed diagnostics output.
 ~/www/github-maho  on main !1 ?1 ··································································· at 09:48:06 ─╮
❯ composer diagnose                                                                                ─╯
Checking composer.json: OK
Checking platform settings: OK
Checking git settings: OK git version 2.25.1
Checking http connectivity to packagist: OK
Checking https connectivity to packagist: OK
Checking github.com oauth access: OK does not expire
Checking disk free space: OK
Checking pubkeys:
Tags Public Key Fingerprint: 57815BA2 7E54DC31 7ECC7CC5 573090D0  87719BA6 8F3BB723 4E5D42D0 84A14642
Dev Public Key Fingerprint: 4AC45767 E5EC2265 2F0C1167 CBBB8A2B  0C708369 153E328C AD90147D AFE50952
OK
Checking Composer version: You are not running the latest stable version, run `composer self-update` to update (2.7.4 => 2.8.2)
Checking Composer and its dependencies for vulnerabilities: FAIL
Audit found some issues:
Found 3 security vulnerability advisories affecting 2 packages:
+-------------------+----------------------------------------------------------------------------------+
| Package           | composer/composer                                                                |
| Severity          | high                                                                             |
| CVE               | CVE-2024-35241                                                                   |
| Title             | Composer has a command injection via malicious git branch name                   |
| URL               | https://github.com/advisories/GHSA-47f6-5gq3-vx9c                                |
| Affected versions | >=2.3,<2.7.7|>=2.0,<2.2.24                                                       |
| Reported at       | 2024-06-10T21:36:32+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+
+-------------------+----------------------------------------------------------------------------------+
| Package           | composer/composer                                                                |
| Severity          | high                                                                             |
| CVE               | CVE-2024-35242                                                                   |
| Title             | Composer has multiple command injections via malicious git/hg branch names       |
| URL               | https://github.com/advisories/GHSA-v9qv-c7wm-wgmf                                |
| Affected versions | >=2.3,<2.7.7|>=2.0,<2.2.24                                                       |
| Reported at       | 2024-06-10T21:36:25+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+
+-------------------+----------------------------------------------------------------------------------+
| Package           | symfony/process                                                                  |
| Severity          | high                                                                             |
| CVE               | CVE-2024-51736                                                                   |
| Title             | CVE-2024-51736: Command execution hijack on Windows with Process class           |
| URL               | https://symfony.com/cve-2024-51736                                               |
| Affected versions | >=2.0.0,<3.0.0|>=3.0.0,<4.0.0|>=4.0.0,<5.0.0|>=5.0.0,<5.1.0|>=5.1.0,<5.2.0|>=5.2 |
|                   | .0,<5.3.0|>=5.3.0,<5.4.0|>=5.4.0,<5.4.46|>=6.0.0,<6.1.0|>=6.1.0,<6.2.0|>=6.2.0,< |
|                   | 6.3.0|>=6.3.0,<6.4.0|>=6.4.0,<6.4.14|>=7.0.0,<7.1.0|>=7.1.0,<7.1.7               |
| Reported at       | 2024-11-05T08:00:00+00:00                                                        |
+-------------------+----------------------------------------------------------------------------------+
Composer version: 2.7.4
PHP version: 8.2 - Package overridden via config.platform, actual: 8.2.20
PHP binary path: /usr/bin/php8.2
OpenSSL version: OpenSSL 1.1.1f  31 Mar 2020
cURL version: 7.68.0 libz 1.2.11 ssl OpenSSL/1.1.1f
zip: extension present, unzip present, 7-Zip not available

❯ grep 'mahocommerce/maho' vendor/composer/installed.php -A6 -B1                                                     ─╯
    'root' => array(
        'name' => 'mahocommerce/maho',
        'pretty_version' => 'dev-main',
        'version' => 'dev-main',
        'reference' => '18be58c902454de56b7a9e494111714f5a9b262a',
        'type' => 'maho-source',
        'install_path' => __DIR__ . '/../../',
        'aliases' => array(),
--
        ),
        'mahocommerce/maho' => array(
            'pretty_version' => 'dev-main',
            'version' => 'dev-main',
            'reference' => '18be58c902454de56b7a9e494111714f5a9b262a',
            'type' => 'maho-source',
            'install_path' => __DIR__ . '/../../',
            'aliases' => array(),
--
        ),
        'mahocommerce/maho-composer-plugin' => array(
            'pretty_version' => 'dev-main',
            'version' => 'dev-main',
            'reference' => 'f27036354a10aa699718c9e3828fb2b2720eb94e',
            'type' => 'composer-plugin',
            'install_path' => __DIR__ . '/../mahocommerce/maho-composer-plugin',
            'aliases' => array(
                0 => '9999999-dev',
            ),
            'dev_requirement' => false,
        ),
        'mahocommerce/maho-phpstan-plugin' => array(
            'pretty_version' => 'v2.4.0',
            'version' => '<IP_ADDRESS>',
            'reference' => '71dbdaa6c53274ef5d5fd3ab0ec2867a79118f23',
            'type' => 'library',
            'install_path' => __DIR__ . '/../mahocommerce/maho-phpstan-plugin',
            'aliases' => array(),
            'dev_requirement' => true,
        ),
        'paragonie/constant_time_encoding' => array(
            'pretty_version' => 'v3.0.0',
            'version' => '<IP_ADDRESS>',


picolibc: Disable LTO while building picolibc bits

The compiler requires that much of the C library be built without using LTO so that various symbols are available for use by generated code, including things like memset and memcpy.
Add -fno-lto when building both picolibc itself as well as the Zephyr interface bits.
Closes: #81674

The following west manifest projects have changed revision in this Pull Request:
Name 	Old Revision 	New Revision 	Diff
picolibc 	zephyrproject-rtos/picolibc@d492d5f 	❌ Impostor SHA: 82d62ed1ac55b4e34a12d0390aced2dc9af13fc9<EMAIL_ADDRESS>⛔ DNM label due to: 1 impostor SHA
Note: This message is automatically posted and updated by the Manifest GitHub Action.

Fixed.

I might be missing something but it is not obvious to me why this is also pulling a new version of the module, since at first glance one could think updating the CMakeLists would be enough. Could you elaborate briefly in the commit message?

Could you elaborate briefly in the commit message?

"Add -fno-lto when building both picolibc itself as well as the Zephyr interface bits" from the commit message seems to already do that.

I might be missing something but it is not obvious to me why this is also pulling a new version of the module, since at first glance one could think updating the CMakeLists would be enough. Could you elaborate briefly in the commit message?

Is @stephanosio 's explanation enough? Or would you like me to try to expand the commit message a bit more?


feat: Tweak cache

What this PR does / why we need it
Docker cache keeps increasing with each build and will reset itself once it hits 15G in circleci, this will prune cache after each build and will keep usage under 6GB.
Another solution could be to switch to different provider, rather then DLC in circleci. For example https://docs.docker.com/build/cache/backends/s3/

Jira ID
[XX-XX]

Notes for your reviewers

I've had mixed results with using docker buildx cache backends (on Github Actions, anyways). The prune change here makes sense though, I like it.


NumberBox parsing

The NumberBox is not good for entering big Numbers
The basses type is double but I cant enter scientific notation like: "1e6" or "1M".
Therefore it would be  good to be able overwrite  the INumberParser like this:
struct CustomNumberParser : winrt::implements<CustomNumberParser, winrt::Windows::Globalization::NumberFormatting::INumberParser>
{
	winrt::Windows::Foundation::IReference<int64_t> ParseInt(winrt::hstring const& text)
	{
		try
		{
			int64_t value = std::stoll(std::wstring(text));
			return winrt::Windows::Foundation::IReference<int64_t>(value);
		}
		catch (...)
		{
			return nullptr;
		}
	}

	winrt::Windows::Foundation::IReference<uint64_t> ParseUInt(winrt::hstring const& text)
	{
		try
		{
			uint64_t value = std::stoull(std::wstring(text));
			return winrt::Windows::Foundation::IReference<uint64_t>(value);
		}
		catch (...)
		{
			return nullptr;
		}
	}

	winrt::Windows::Foundation::IReference<double> ParseDouble(winrt::hstring const& text)
	{
		try
		{
			double value = std::stod(std::wstring(text));
			return winrt::Windows::Foundation::IReference<double>(value);
		}
		catch (...)
		{
			return nullptr;
		}
	}
};

An other way to do it, is to have a TextChanged event. Together with  ValidationMode="Disabled" I could parse the value there. But this is a bit more to do.
The best scenario is to have it build in, with a property to be able to change its behavior.
It would be nice to have the ability to increase the  increment of the spin buttons if the spin button is pressed and hold. (The longer the bigger should be the increase of the value.)
An other thing that has proven in the past, is to increase the value inside the NumberBox by the position of the cursor inside the number.

Any news on this?


[General]: Add support for lists with multiple fields in each item

Is there an existing issue for this?

[X] I have searched the existing issues

Package/Plugin version
9.2.1
What you'd like to happen
Add support for lists with multiple fields in each item.

Alternatives you've considered
No response
Aditional information

Refer to the Form.List component in the and library
https://ant.design/components/form#components-form-demo-dynamic-form-items

solved.


Bugfix/30

Fixed non-unique attribute variable name in query message

I've tested and confirmed that those two sparql queries seem to be the only ones that were broken. I've tested with the ieee13nodeckt, ieee13nodecktassets, and ieee123. @AAndersn this PR can be merged and issue 30 can be closed.


Deprecation warnings coming from within the library

Describe the bug
In version 1.9.6 calling Numer::decimal results in deprecation warnings, because Number::decimal uses Number::decimal_part.
Additionally, there is a bug in the deprecation warning where it is suggesting an empty string as a replacement. (Same steps to reproduce)
NOTE: Faker::Number.decimal_part is deprecated; use  instead. It will be removed on or after 2019-06-01.
Faker::Number.decimal_part called from /usr/local/bundle/gems/faker-1.9.6/lib/faker/default/number.rb:34.
NOTE: Faker::Number.leading_zero_number is deprecated; use  instead. It will be removed on or after 2019-06-01.
Faker::Number.leading_zero_number called from /usr/local/bundle/gems/faker-1.9.6/lib/faker/default/number.rb:29.

To Reproduce
Use Number::decimal anywhere. I found it using rake test, but the easiest repro is with an interactive ruby terminal, e.g. in pry:
[1] pry(main)> require 'faker'
=> true
[2] pry(main)> Faker::Number.decimal
NOTE: Faker::Number.decimal_part is deprecated; use  instead. It will be removed on or after 2019-06-01.
Faker::Number.decimal_part called from /Users/nathanhinchey/.rvm/gems/ruby-2.6.2/gems/faker-1.9.6/lib/faker/default/number.rb:34.
NOTE: Faker::Number.leading_zero_number is deprecated; use  instead. It will be removed on or after 2019-06-01.
Faker::Number.leading_zero_number called from /Users/nathanhinchey/.rvm/gems/ruby-2.6.2/gems/faker-1.9.6/lib/faker/default/number.rb:29.
=> "78132.07"

Expected behavior
There should not be a deprecation warning for code that is not deprecated. Non-deprecated code should not call deprecated code.
Additionally, the deprecation warning should suggest an alternative instead of an empty string.

Possibly related to https://github.com/stympy/faker/issues/1610 ?

This issue will be fixed in v2. Thanks for reporting.

This is a little bit frustrating to see happen. I went searching for where I was possibly using Faker incorrectly, but it seems like you are warning yourselves? I can't see some actual CI output currently because I have 100+ lines of these deprecations.
Can this be turned off through a flag? When is v2 releasing if not?
Thanks for our work on the library! Use it all the time.

@rylanb sorry about that! We'll remove all the deprecation warnings in v2.
I can commit myself to get the pending things done this weekend and publish v2.

@vbrazo oh no worries. In the grand scheme of things, not a big deal. I was more concerned that it would be months before a v2 might come out. If its a couple weeks, not a big deal.
Thanks for responding!

Is the solution for now just to wait, or is there a change that should be made if you're using the decimal method?

@connorshea probably the easiest solution for now is to jump back before the deprecation was added (~> 1.9.4?). Have to wait for v2 to come out, I think?

For now I'm just going to hack around it since I only have one call to the decimal method. It isn't pretty, but it does seem to work:
# Before
Faker::Number.decimal(3, 1)
# After
"#{rand(999)}.#{rand(9)}".to_f

Hopefully that's useful to someone while we wait :P

@connorshea it's going to be fixed in this PR https://github.com/stympy/faker/pull/1651. The change is here.

Please feel free to review this PR. I need some eyes on it @rylanb @connorshea @nathanhinchey

@vbrazo I tried to review it but the context is beyond me. I think @nathanhinchey got you covered though!

@rylanb yeah! He did a good job. I still need to read that PR again and apply any necessary changes. I think we're getting pretty close.


fix(share/p2p/shrexeds): ugly hotfix shrex contexts for bsr

Currently we are timing out in shrex for the full context length (2.5 minutes) because we fail to

Open streams
Read status from streams

This PR limits stream open to 5s, and reading the status from the stream to 5s (via read Deadline config param). We also put peers on timeout that return a context deadline. It is a bad fix and the correct way to do this can be discussed once we can look deeper into the problems - but for now, we need to fix the test network before it ends next week.
This fix does not appear to be enough to fully fix syncing stall/syncing speed (the only solution that has done that so far is a new ResultDropPeer in peerman), but it is simple and helps a bit.
Related: https://github.com/celestiaorg/celestia-node/discussions/2191

Codecov Report

Merging #2192 (081e960) into main (687704e) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2192      +/-   ##
==========================================
- Coverage   55.82%   55.79%   -0.04%
==========================================
  Files         216      216
  Lines       14060    14099      +39
==========================================
+ Hits         7849     7866      +17
- Misses       5422     5445      +23
+ Partials      789      788       -1

Impacted Files
Coverage Δ

nodebuilder/header/service.go
13.55% <0.00%> (-4.63%)
:arrow_down:

share/getters/shrex.go
79.59% <0.00%> (-0.55%)
:arrow_down:

share/availability/discovery/set.go
88.88% <66.66%> (-2.03%)
:arrow_down:

das/state.go
86.29% <87.50%> (+1.21%)
:arrow_up:

das/checkpoint.go
100.00% <100.00%> (ø)

das/worker.go
95.65% <100.00%> (-0.87%)
:arrow_down:

share/availability/discovery/discovery.go
76.59% <100.00%> (-0.95%)
:arrow_down:

share/p2p/shrexeds/client.go
69.15% <100.00%> (+5.15%)
:arrow_up:

... and 3 files with indirect coverage changes


dropdown list to insert text in editor

I have created these 2 buttons to insert some text into the editor... that is working 100%.  I need to add more buttons and instead of having an icon for each of them, i would like to place them in a dropdown list.  How can I achieve that?
var editor = new Jodit('#editor', {
    buttons: [
        {
            iconURL: '/public/icons/image_left.png',
            exec: function (editor) {
                editor.selection.insertHTML('...');
            }
        },
        {
            iconURL: '/public/icons/image_right.png',
            exec: function (editor) {
                editor.selection.insertHTML('...');
            }
    }]
});

var editor = new Jodit('#editor', {
   buttons: [
       iconURL: '/public/icons/image_left.png',
       list: {
         first: 'first',
         second: 'second'
       },
        childTemplate: (editor, key: string, value: string) => {
		return `<span>${key}</span>`;
	}
        exec: function (editor, t, {control}) {
            editor.selection.insertHTML(control.args);
        }
   ]
});

Thank you!

        exec: function (editor, t, {control}) {
            editor.selection.insertHTML(control.args);
        }

Thanks!
I was struggling with this.
The documentation at https://xdsoft.net/jodit/pro/docs/how-to/add-custom-button.md#drop-down-list seems to be incorrect.
In the example there:
	exec(editor) {
		let value = control.args && control.args[0]; // h1, h2 ...

control isn't received as an argument, therefore it's undefined here, and this line raises an error!


Missing Enter the Golden House domain

While reviewing #34 I realized that Enter the Golden House trounce domain is also missing from the domain list.
Low-prio as it works the exact same way as Confront Stormterror and Wolf of the North Challenge right now.

Could I take this on after #36 is solved? Thank you!

Could I take this on after #36 is solved? Thank you!


Convert to one package

[] update webpack to build one package
[] remove all package.json and .npmignore files from each individual package
[] create mono-package directory to combine all pacakges
[] update packages to use relative paths instead of @material/react-foo packages
[] update documentation

This topic has come up recently for core as well but I would like to consider what we're gaining out of this vs. losing before jumping to conclusions and doing it.
In the case of MDC React in particular though, I'm curious which method of consumption is more common / preferable.

I think its important to make a distinction between how a projects source-code is structured and how it's distributed. A mono-repository can make sense from a maintainability point of view, as you wont have to make releases of a core library before adopting changes (that might result in new requirements on the core library) but that is different from the method of distribution.
On the topic of which method of consumption is more common / preferable I would definitely advocate for separate packages for each framework (React, Vue, Angular, etc.) - if you are not distributing separate packages for each component it would also be preferable if there existed a way / guide to avoid bundling in components that my app is not actively using (perhaps by some sort of configuration or automatic dead-code removal).

Given that both React Toolbox and Material UI, both very popular React component libraries, serve their components as one package...I think we should update MDC React to one package as well.
This does not necessarily mean MDC Web needs to update to one package. We can make this change only in MDC React, and then do more investigation for MDC Web.

RMWC is also a single package, so I suppose there's that. I might put more weight in that than the others since RMWC is also wrapping MDC Web. :)

I'd still like to know what problem we're actually solving by doing this, though?
One thing I'd point out is that this makes it impossible to do partial upgrades as MDC React works towards updating to a new MDC Web release. In other words you can't e.g. update just text field and deal with breaking changes there in isolation from updating everything else at the same time. I'm pretty sure that was something that was taken advantage of in a previous upgrade process.

Somewhat related, because webpack.config.js needs cleaning before we take on this project: #146

I’ve debated moving to multiple packages but ended up keeping the mono repo for simplicity.
Webpack 3 / 4 / and roll up all do tree shaking by default so final bundle size is optimized. I know this is cared about since I’ve been alerted by an issue anytime I’ve broken it :)
@kfranqueiro that’s a great point about fixing things in isolation and definitely a valid use case. I’m curious to know how much this comes into play in practice. I personally have never used this pattern but it could be useful as the component library becomes much larger and project using it become much older.

As a consumer of MDC React, I just want to point you that installing 20+ separate packages (and updating their versions later) is a huge pain.
npm i -S @material/react-button @material/react-card @material/react-some-other-component # etc. painful
npm i -S @material/react # much better

definitely agree - and I'm anticipating having some bandwidth at the end of the quarter since the roadmap doesn't have any new components in December yet.

Couple of things.
For @rustemgareev

You can make this much easier on yourself. Just make bash script that looks something like this with all of the components you need. update-mdcr.sh

npm i -S \
@material/react-button@latest \
@material/react-card@latest \
@material/react-fab@latest

Run like so, or proxy it through a node script.
./update-mdcr.sh

There is a lot of value in having the individual packages, someday it will save you from the never ending upstream changes.
For @moog16
I'm assuming you're already using lerna. This is trivial to do, just setup a new directory with whatever you want the mono package called inside of packages with its own package.json, and then just add all of the other packages as a dependency. Lerna will do the rest in keeping it up to date. Here mine from RMWC.
https://github.com/jamesmfriedman/rmwc/blob/master/src/rmwc/package.json

Originally I was on the mono repo train but at this point I would highly recommend keeping the separate packages. While the mono repo was easier to maintain and deploy, every breaking change was miserable to fix for consumers and as you know. MDC contains lots of them.

Are you saying that you'd rather fix breaking changes in different PRs? Or in different steps. I'm assuming you fix all breaking changes

Version 0.X.0 comes out, breaks buttons, dialogs, and drawers
Drawers and buttons are easy, but the dialogs are a total rewrite
For my app, I can just update buttons and drawers, and wait to update dialogs until I have time to go through the entire app and fix them
Its more for workflow for larger teams than anything. Splitting up the mono-repo has actually allowed the company I work to upgrade our own internal UI library that wraps RMWC more fluidly and not be an all or nothing week long ordeal.


About the attention_net function

Thanks for your codes. About the code, I have some questions. Dose the attention_net() function in the file lstm.py is completed? Or how can I apply the attention_net into loganomaly process. Thanks again!

The attention mechanism(seems popular in papers in the nlp field) has little effect on My experimental results.
You can try it


Revert "Don't set ResponseHeaderTimeout for restclient"

Reverts apcera/util#48 for now to reduce our suspicious numbers, at least it didn't fix the problem, we can reopen it later if we find out the root cause.
@krobertson @zquestz @wallyqs @shobhit85

LGTM

lgtm


manage include files

outline
fly-sass is transform scss into css file include helper file ( e.g. _helper.scss )
target

ignore helper file to transform in plguin.
or remove helper file after transform.

AFIK this is solved, check out examples in Fly. This is done via options.
export default function* () {
  yield this.clear("dist")
  yield this
    .source("src/*.scss")
    .sass({
      outputStyle: "compressed",
      includePaths: ["src/imports"],
      sourceMap: true
    })
    .target("dist")

Let me know if this makes sense.

@bucaran
Sorry...
I will update in this weekend !!!!

@bucaran
Thanks !!!
I have updated readme !


Fix autocompletion no envs

Fixes Issue #18

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   73.87%   73.87%
=======================================
  Files          10       10
  Lines         513      513
=======================================
  Hits          379      379
  Misses        134      134

Impacted Files
Coverage Δ

pipenv_pipes/__init__.py
100% <100%> (ø)
:arrow_up:

pipenv_pipes/cli.py
95.12% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a53dc4...5a52ce9. Read the comment docs.


Path resolution with composes

Right now I have to provide an exact relative path to composes, like this:
.button {
   composes: rounded from '../../../../../../../../styles/shared/button.m.css';
}

Wouldn't it be nice to be able to declare the files or folders to search for, if the given path fails?
// First, add button.m.css to package.json as a global shared file for composes

// then...
.button {
   composes: rounded from 'button.m.css';
}

Or is this already possible somehow?

This isn't currently possible, but you can use absolute paths instead of relative paths. If styles is under your Meteor project root, you can do this:
composes: rounded from '/styles/shared/button.m.css';

That works just fine, thanks!


CI failed with incompatible module

The last CI build failed with the error:
#!/bin/sh -eo pipefail
yarn install

yarn install v1.9.4
info No lockfile found.
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=8.10".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Exited with code 1

Currently there's no test case setup yet.
I think we can still use CI to build the workshop app, for example:

Use npm to install the dependencies, instead of yarn.
Do npm run release in the CI pipeline.

What do you think @Lokeh ?

Yeah I started adding CI a few months ago and just never got around to finishing. Now it just spams my inbox everytime a commit gets made 😛
Building the workshop and deploying it to github pages or netlify or whatever could be cool.

I've setup tests to run on CI now.
I'm not sure how helpful deploying the devcards would be for people.
Closing this for now.

Appreciate to look into this!


XmlProviderImpl#removeEmptyTextNodes is flawed

I needed to edit the XML of a POM in a project I'm writing a build for currently.
As I'm using Kotlin, I used withXml { asElement() } to do the modifications.
Unfortunately this destroyed the optics, as every second line in the nested elements was an empty line.
XmlProviderImpl#removeEmptyTextNodes should remove those empty text nodes and do some manual indenting, but it has a logic error.

Calling the remove at :one: affects the result of :two:, so if a node is removed, the next node is effectively skipped.
The length of the child list should be retrieved once at the start of the loop and captured in a variable instead.

Here a work-around:
fun <T : Node> T.removeEmptyTextNodes(): T {
    childNodes.asList().forEach {
        if ((it.nodeType == TEXT_NODE) && it.nodeValue.trim().isEmpty()) {
            removeChild(it)
        } else {
            it.removeEmptyTextNodes()
        }
    }
    return this
}

withXml { asElement().removeEmptyTextNodes().... }

Still relevant in 6.6.1, PR available now


I have setup all thing but can't understan how toi use and appy

Runing on Window 10
and using VSCode
Also help how to get api

Leave solution here: https://github.com/UndeadSec/SocialFish/issues/278#issuecomment-840444976


chore: port matchContext.tsx

closes #16

@MengLinMaker me and nicole worked on this one, mind having a look and seeing if we did this PR right? Also it says merging is blocked


Wrap last remaining procs

setShaderValue
setShaderValueV
UpdateTexture
UpdateTextureRec
GetPixelColor
SetPixelColor
UpdateMeshBuffer
UpdateSound
UpdateAudioStream
GetWindowHandle ?

from the source // NOTE: pixels data must match texture.format

Same for UpdateSound it can be a number of types. I guess assuming openarray[byte] is wrong

Problem: There are no enums for UpdateMeshBuffer, UpdateSound, UpdateAudioStream These will have to wait

done!


WIP: Add support for mlflow

Describe your changes
Add support for mlflow logger by utilising pytorch_lightning.loggers
The native wandb module is replaced with pytorch_lightning wandb logger and introducing pytorch_lightning mlflow logger.
https://github.com/Lightning-AI/pytorch-lightning/blob/master/src/lightning/pytorch/loggers/logger.py
This will allow people to choose between wandb and mlflow.
Builds upon https://github.com/mllam/neural-lam/pull/66 although this is not strictly necessary for this change, but I am working with this feature to work with our dataset.
Issue Link
Closes https://github.com/mllam/neural-lam/issues/76
Type of change

[ ] 🐛 Bug fix (non-breaking change that fixes an issue)
[x] ✨ New feature (non-breaking change that adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

[ ] My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
[ ] I have performed a self-review of my code
[ ] For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
[ ] I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
[ ] I have updated the README to cover introduced code changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have given the PR a name that clearly describes the change, written in imperative form (context).
[ ] I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:

[ ] the code is readable
[ ] the code is well tested
[ ] the code is documented (including return types and parameters)
[ ] the code is easy to maintain

Author checklist after completed review

[ ] I have added a line to the CHANGELOG describing this change, in a section
reflecting type of change (add section where missing):

added: when you have added new functionality
changed: when default behaviour of the code has been changed
fixes: when your contribution fixes a bug

Checklist for assignee

[ ] PR is up to date with the base branch
[ ] the tests pass
[ ] author has added an entry to the changelog (and designated the change as added, changed or fixed)
Once the PR is ready to be merged, squash commits and merge the PR.

WIP, mlflow logger still not working, but got wandb working with the pytorch_lightning wandb logger.
This is dependent on https://github.com/mllam/neural-lam/pull/66 to be merged first.

Current issue is that in ar_model.py the figure is given as the same name for every epoch
if self.trainer.is_global_zero and not self.trainer.sanity_checking:
            for key, figure in log_dict.items():
                self.logger.log_image(key=key, images=[figure])

            plt.close("all")  # Close all figs

This works fine for wandb, for in mlflow, the figure gets overwritten so we only keep the last one. Looking for some iterator that I can pass to the custom mlflow  log_image function.

I now got model metrics, system metrics and artifacts logging (including model logging) supported for mlflow. See e.g:
https://mlflow.dmidev.org/#/experiments/2/runs/aceb8c6c94844736844dc7d1c12aa57f
However I get this warning:
2024/10/07 12:04:38 WARNING mlflow.models.model: Model logged without a signature and input example. Please set `input_example` parameter when logging the model to auto infer the model signature.

I am calling a log_model function after trainer.fit
training_logger.log_model(model)

which is
def log_model(self, model):
        mlflow.pytorch.log_model(model, "model")

But I need to set the signature
From https://mlflow.org/docs/latest/model/signatures.html
In MLflow, a model signature precisely defines
the schema for model inputs, outputs,
and any additional parameters required for
effective model operation.

It should be possible to use infer_signature() from mlflow (https://mlflow.org/docs/latest/python_api/mlflow.models.html#mlflow.models.infer_signature), but to work with data one needs to input the training data like signature = infer_signature(model, training_data).
But the training dataset is probably too big to parse, and I am not sure I can get it via train_model.py. Could we manually infer a signature or should we discard giving a signature at all?
Any thoughts @joeloskarsson, @sadamov, @TomasLandelius ?

A status from me. I got a bit further with the signature (thanks to @sadamov), but I am seeing an error that I am currently trying to understand. @elbdmi will also have a look at this.
The log_model() and create_input_example() functions now looks like (in train_model.py:
def log_model(self, data_module, model):
        input_example = self.create_input_example(data_module)

        with torch.no_grad():
            model_output = model.common_step(input_example)[0] # expects batch, returns tuple (ar_model)

        #TODO: Are we sure we can hardcode the input names?
        signature = infer_signature(
            {name: tensor.cpu().numpy() for name, tensor in zip(['init_states', 'target_states', 'forcing', 'target_times'], input_example)},
            model_output.cpu().numpy()
        )

        mlflow.pytorch.log_model(
            model,
            "model",
            input_example=input_example[0].cpu().numpy(),
            signature=signature
        )

def create_input_example(self, data_module):

        if data_module.val_dataset is None:
            data_module.setup(stage="fit")

        data_loader = data_module.train_dataloader()
        batch_sample = next(iter(data_loader))
        return batch_sample

For example model(*input) had to be changed to model.common_step(input) because pytorch expected a function called forward(), which is default as far as I understand. @joeloskarsson would it make sense to rename common_step() to forward()?
When I log the model I do
training_logger.log_model(data_module, model)

but it fails to validate "serving the input example" and print the full tensor:
2024/12/03 10:56:04 WARNING mlflow.models.model: Failed to validate serving input example {
  "inputs": [
    [
      [
        [
          -1.1313700675964355,
          1.9031524658203125,
          -0.8801671266555786,
          0.11871696263551712,
          0.9589263200759888
        ]
...
...
...
   [ 0.08666334  0.1328821  -3.2410812  -0.21018785 -0.6424305 ]]]]' with schema '['init_states': Tensor('float32', (-1, 2, 464721, 5)), 'target_states': Tensor('float32', (-1, 1, 464721, 5)), 'forcing': Tensor('float32', (-1, 1, 464721, 3)), 'target_times': Tensor('int64', (-1, 1))]'. Error: Model is missing inputs ['init_states', 'target_states', 'forcing', 'target_times'].
2024/12/03 10:56:19 INFO mlflow.tracking._tracking_service.client: 🏃 View run dazzling-bird-134 at: https://mlflow.dmidev.org/#/experiments/2/runs/8d183886feb648ed87e0e981b6e2c898.
2024/12/03 10:56:19 INFO mlflow.tracking._tracking_service.client: 🧪 View experiment at: https://mlflow.dmidev.org/#/experiments/2.
2024/12/03 10:56:19 INFO mlflow.system_metrics.system_metrics_monitor: Stopping system metrics monitoring...
2024/12/03 10:56:19 INFO mlflow.system_metrics.system_metrics_monitor: Successfully terminated system metrics monitoring!

Input and output data examples are uploaded to mlflow, see this example.

I think it's best to skip the log model feature of mlflow for now.
It is not straightforward to implement in an useful way I think, but I would like some opinions.
Discarding the log model feature, means mlflow only will be supported for training (like wandb).
When I call mlflow.pytorch.log_model() with an input example the full tensor is printed, because ( https://mlflow.org/docs/latest/models.html - thanks @elbdmi )
MLflow will propagate any errors raised by the model if
the model does not accept the provided input type

Instead, I can infer the signature and give that, which kind of works. However, there are two issues with that.
1: mlflow.pytorch.log_model() tries to define a conda env to upload with the model. It can't find my environment (I'm using pdm), so I get some useless requirement files uploaded which doesn't reflect the dependencies needed.
2: I get some warnings from MLFlow about modules not being found. It doesn't seem to affect the results, but I have not figured out what the reason is. However, it is related to when it tries to load the model, where it seems to refer to a name similar to the processor:
stdout:
stderr: Traceback (most recent call last):
  File "/vf/kah/neural-lam/.venv/lib/python3.10/site-packages/mlflow/utils/_capture_modules.py", line 256, in <module>
    main()
  File "/vf/kah/neural-lam/.venv/lib/python3.10/site-packages/mlflow/utils/_capture_modules.py", line 233, in main
    store_imported_modules(
  File "/vf/kah/neural-lam/.venv/lib/python3.10/site-packages/mlflow/utils/_capture_modules.py", line 210, in store_imported_modules
    importlib.import_module(f"mlflow.{flavor}")._load_pyfunc(model_path)
  File "/vf/kah/neural-lam/.venv/lib/python3.10/site-packages/mlflow/pytorch/__init__.py", line 720, in _load_pyfunc
    return _PyTorchWrapper(_load_model(path, device=device), device=device)
  File "/vf/kah/neural-lam/.venv/lib/python3.10/site-packages/mlflow/pytorch/__init__.py", line 614, in _load_model
    pytorch_model = torch.load(model_path, **kwargs)
  File "/vf/kah/neural-lam/.venv/lib/python3.10/site-packages/torch/serialization.py", line 1097, in load
    return _load(
  File "/vf/kah/neural-lam/.venv/lib/python3.10/site-packages/torch/serialization.py", line 1525, in _load
    result = unpickler.load()
  File "/vf/kah/neural-lam/.venv/lib/python3.10/site-packages/torch/serialization.py", line 1515, in find_class
    return super().find_class(mod_name, name)
  File "/vf/kah/neural-lam/.venv/lib/python3.10/site-packages/mlflow/utils/_capture_modules.py", line 57, in wrapper
    result = original(name, globals, locals, fromlist, level)
ModuleNotFoundError: No module named 'Sequential_e291b6'

I have also tried to use mlflows validate_serving_input() function to validate the input when not given to the log_model() function (https://mlflow.org/docs/latest/_modules/mlflow/models/utils.html#validate_serving_input) but I could not get that to work.
The whole CustomMLFlowLogger class looks like this now:
class CustomMLFlowLogger(pl.loggers.MLFlowLogger):
    def __init__(self, experiment_name, tracking_uri):
        super().__init__(
            experiment_name=experiment_name, tracking_uri=tracking_uri
        )
        mlflow.start_run(run_id=self.run_id, log_system_metrics=True)
        mlflow.log_param("run_id", self.run_id)

    @property
    def save_dir(self):
        return "mlruns"

    def log_image(self, key, images, step=None):
        # Third-party
        from PIL import Image

        if step is not None:
            key = f"{key}_{step}"

        # Need to save the image to a temporary file, then log that file
        # mlflow.log_image, should do this automatically, but is buggy
        temporary_image = f"{key}.png"
        images[0].savefig(temporary_image)

        img = Image.open(temporary_image)
        mlflow.log_image(img, f"{key}.png")

    def log_model(self, data_module, model):
        input_example = self.create_input_example(data_module)

        with torch.no_grad():
            model_output = model.common_step(input_example)[
                0
            ]  # expects batch, returns tuple (prediction, target, pred_std, _)

        log_model_input_example = {
            name: tensor.cpu().numpy()
            for name, tensor in zip(
                ["init_states", "target_states", "forcing", "target_times"],
                input_example,
            )
        }

        signature = infer_signature(
            log_model_input_example, model_output.cpu().numpy()
        )

        mlflow.pytorch.log_model(
            model,
            "model",
            signature=signature,
        )

        # validate_serving_input(model_uri, validate_example)

    def create_input_example(self, data_module):

        if data_module.val_dataset is None:
            data_module.setup(stage="fit")

        data_loader = data_module.train_dataloader()
        batch_sample = next(iter(data_loader))
        return batch_sample

I am aware that I am still missing the changelog.


Analyze, prototype and experiment easily applicable solutions to reduce bandwidth usage

Problem
The bandwidth consumption in CometBFT is high. In particular, this comes from the fact that the reactor of the mempool is a basic flooding gossip protocol (à la Bitcoin). Because the network topology is dense, it is very likely that a node receives a transaction multiple times from different neighbors. Notice that such a redundancy is useful to prevent byzantine or selfish nodes to stop the dissemination of a transaction in the network.
Some evidence of this redundancy is seen in #613
Target audience
Consensus developers
Upside
Small improvements could cut bandwidth usage in CometBFT by (at least) 25%, based on other results.
Downside
There are many possible improvements to test. To mitigate the risk of spending too much time on discussing improvements, we will divide the improvements into two batches, one with quick wins and one with ideas that require further though and refinement.

[x] #1086

For each of the approaches that are chosen on the brainstorm we will

prototype the approach
experiment with improvements using e2e and fast prototyping
experiment with the approaches that turned out promising in the QA infra
document the solutions as ADRs

The remaining ideas will become part of #11 and if there is room to try these and other ideas on that issue, we will iterate on brainstorming and prototyping.
Consider if #1048 is pre-requisite for this task of if backlog.
Definition of done

Provide in the form of an ADR a new gossip protocol, or an improvement to the current one, that reduces the bandwidth of mempool transactions, as demonstrated by experiments on a testnet that resembles as close as possible to a real-world mainnet.
Implement, test, and merge into main the solution proposed in the ADR.
Protocols or ideas discussed but not implemented or prototyped should also be documented.

Tentative list of improvements to the propagation protocol:

For each transaction, keep track of the nodes that are known to have the transaction (currently it is only the senders)
Reply with TxAck instead of Tx itself if Tx is large.
Random sleep during gossip to allow receiving Tx before having to send it.
Send HaveTxId instead of Tx itself, depending on Tx size, to warn that Tx is not required.
Send HaveTxIdSet (BF) instead of Tx themselves, depending on the Tx set size, to let neighbors know which Txs are required.
Propose TxId instead of Tx and accept a block only when the Tx with TxId is known.

aka Content Addressable Transactions (CAT), in Celestia
also mentioned in the Narwhal and Tusk paper (page 4, right column)

Batch transactions (was removed, see tendermint#5796)
Attach to Txs message the list of peers that are known to have the txs

draft implementation
Note that this approach should use a Bloom filter on the list of peers to reduce the message size, and it needs to check for Byzantine behavior.

Output of discussing the tentative list of optimizations.

For each transaction, keep track of the nodes that are known to have the transaction (currently it is only the senders)

Open an issue to discuss the approach to discuss the situation in which the same transaction can be sent several times to the same peer because the iterator used to navigate the list of pending transactions (the mempool) can be reset to the beginning of the list. There are two solutions for this problem:

Prevent the mempool implementation from resetting iterators to the beginning of the list
Store in the senders map the peers to which a node sends a transaction, which prevents sending the same transaction to a peer multiple times even when the mempool iterator is reset

Why is the code the way it is right now? Is it a deficiency in the iterator code or was it added to solve a bug?

Reply with TxAck instead of Tx itself if Tx is large

The idea comes from a misunderstanding of the mempool behavior, which is now better defined here
another way of looking at it is as a duplicate of 4th approach in the list.
In any case, we are crossing this approach out of the list.

Random sleep during gossip to allow receiving Tx before having to send it.

This is now better understood as a form of throttling, which may be implemented as a random sleep inside the broadcastTx routine or as quota on the amount of bytes sent within a time period.
Yet another approach would be skipping some transactions during the gossiping, which could lead to the fifo ordering of transactions not being respected.

Have opened issued #1147 to discuss the first point.

Have opened #1148 to investigate throttling

Have opened #1049 to investigate the effects of skipping transactions in the gossiping.

Have opened #1049 to investigate the effects of skipping transactions in the gossiping.

The wrong issue is linked here.

Hi! Are there any quick wins I could contribute to?

Reopening to handle back port into experimental branches

Fixed with the flurry of PRs mentioned above.


[FLOC-2052] Tell NetworkManager to reload config.

https://clusterhq.atlassian.net/browse/FLOC-2052

When this is merged, #1471  should also be merged (assuming the tests pass).

Thanks.  This looks good and BuildBot seems to agree. Please address one minor comment and then merge.


Add better base password reset functionality

This PR leverages the new Password Broker service that was introduced in Laravel 7 (I believe) to provide password reset services for users.
More details forthcoming once it's closer to completion.

Any updates on this @bennothommo?

I completely forgot I attempted to do this. I must circle back to it soon.


Modules

Let the linking commence!

We should emit a warning diagnostic if the module declared in a source file does not match the base name of the source file's path.

:eyes:

I've submitted #73 :eyes:


Fix the options handling for components

I am updating my Rails GEM to version 4. In my usecase I want to use your picker for the following markup:

   <input id="demo_model_date_field" class="string date_picker optional form-control" type="text"
      name="demo_model[date_field]"
      data-date-options="{"calendarWeeks":true,
          "dayViewHeaderFormat":"YYYY MMMM",
          "showTodayButton":true,
          "widgetPositioning":{"horizontal":"left","vertical":"bottom"},
          "locale":"en"}"
   >

      <button class="btn btn-default" type="button">

       </button>

The version 3 of your picker worked with this usecase. Could you please merge this pull request.

PR request need to be submitted to the dev branch


Load test for cleanup exports

Part of https://github.com/google/exposure-notifications-server/issues/250 and https://github.com/google/exposure-notifications-server/issues/243
This PR adds load test for cleanup exports. Worth noting that:

Exports were "generated" slightly differently from a standard procedure(a.k.a. /export endpoint)
Only added a single test scenario of 10000 exports + 3 keys in each
The new functions in integration.go were copy/pasted from their old locations

/cc @stati0n

This PR assumes the mako logic will be setup from the PR that @stati0n is working on

/lgtm

/retest

Failed a different test this time, flakiness?
/retest

@sethvargo , I have rebased on top of #733 , could you take a look again?

Seems like it went through a pretty bad rebase, let me figure it out first

Rebase completed, now it's ready for review

/lgtm

/approve


Unfold all keybinding does not work

Hi all,
I used the shortcut to fold all code in a python file. It worked perfect.
But when I went to unfold all it didn't do anything.
I used the shortcuts from here https://code.visualstudio.com/docs/customization/keybindings
Mac 10.11.6
VSCode: 1.3.1
Laszlo

@lzantal ⌘K ⌘0 and ⌘K ⌘J work for me on Mac, in 1.3.1 and 1.4.0 without problems.

Please reopen if you have additional info.


Doesn't work with openhab2

Doesn't work with openhab2. Please port to openhab2 because first openhab is no more perspective. Development is focused on openhab2.
root@Home /usr/src/OpenHAB-HomeKit-Bridge # npm start --server=<IP_ADDRESS>:8080

<EMAIL_ADDRESS>start /usr/src/OpenHAB-HomeKit-Bridge
node openHABBridge.js

*** WARNING *** The program 'node' uses the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see http://0pointer.de/avahi-compat?s=libdns_sd&e=node
*** WARNING *** The program 'node' called 'DNSServiceRegister()' which is not supported (or only supported partially) in the Apple Bonjour compatibility layer of Avahi.
*** WARNING *** Please fix your application to use the native API of Avahi!
*** WARNING *** For more information see http://0pointer.de/avahi-compat?s=libdns_sd&e=node&f=DNSServiceRegister
OpenHAB Bridge starting...
/usr/src/OpenHAB-HomeKit-Bridge/lib/ItemProvider.js:4
for (var i = 0; i < widgets.length; i++) {
^
TypeError: Cannot read property 'length' of undefined
at Object.parseSitemap (/usr/src/OpenHAB-HomeKit-Bridge/lib/ItemProvider.js:4:30)
at /usr/src/OpenHAB-HomeKit-Bridge/openHABBridge.js:32:30
at Request._callback (/usr/src/OpenHAB-HomeKit-Bridge/lib/RestClient.js:11:7)
at Request.self.callback (/usr/src/OpenHAB-HomeKit-Bridge/node_modules/request/request.js:354:22)
at Request.emit (events.js:110:17)
at Request. (/usr/src/OpenHAB-HomeKit-Bridge/node_modules/request/request.js:1207:14)
at Request.emit (events.js:129:20)
at IncomingMessage. (/usr/src/OpenHAB-HomeKit-Bridge/node_modules/request/request.js:1153:12)
at IncomingMessage.emit (events.js:129:20)
at _stream_readable.js:908:16
npm ERR! Linux 3.18.7+
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "start" "--server=<IP_ADDRESS>:8080"
npm ERR! node v0.12.1
npm ERR! npm  v2.5.1
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>start: node openHABBridge.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script 'node openHABBridge.js'.
npm ERR! This is most likely a problem with the OpenHAB-HomeKit-Bridge package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node openHABBridge.js
npm ERR! You can get their info via:
npm ERR!     npm owner ls OpenHAB-HomeKit-Bridge
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /usr/src/OpenHAB-HomeKit-Bridge/npm-debug.log

Since OpenHAB 2 is in an early pre alpha state and the current OpenHAB code is under further development I will not add OpenHAB 2 support in the near future. The main focus is to extend the item types supported and stability.


[utils] Update the in-tree Emacs swift mode to teach it about new keywords

The swift-mode.el file is really rudimentary, but unfortunately still useful. Teach it some of the new Swift keywords we added over recent years.

@swift-ci smoke test

ERROR: Execution failed
java.io.EOFException

Cool

@swift-ci test macOS platform


[Bug] the side bar with channels doesnt change from theme

Describe the Bug

the side bar with all channels is the default one no matter the theme
To Reproduce

enable a theme that changes the side bar
Expected Behavior

the side bar should be different, but it stays the same
Discord Version
Stable 71447 (29091ef)
BBD 0.3.5
Host 0.0.12
Injector 0.6.2
Linux 64-Bit (5.4.0-52-Generic)

There was a Discord update and themes need to update to this change.


Link a new dashboard page to the created template via the admin.

When a new template is created for a dashboard, link it to the Custom Dashboards model so they can be selected by other countries.  With this also add a check for public or private and redirect non authenticated users when they hit the private dashboards.

@glind do you know the status of this work?  should this be moved back to the backlog?


Unable to fetch from 'origin' - ERROR: Repository not found.

I created a repository at the command line yesterday and then, via Gittyup, I made my initial commit and pushed to github via SSH. Today - from a different PC - I cloned the repo, made some changes, committed to a new branch, and pushed these changes back to github.
When I got home I went back to the original PC and tried to fetch the changes, but Gittyup reported Unable to fetch from 'origin' - ERROR: Repository not found. I deleted the local copy of the repo and cloned it again, also via SSH, from the command line - this worked fine. I opened the local repo in Gittyup and it showed the new commits, but when I tried to fetch it just gave the same error.
I have tried supplying the path to my SSH config file and default SSH key file via Tools -> Options... Misc, but the error persists.
I have also double-checked that the origin remote is set correctly via Repository -> Configure Repository... -> Remotes.
If I delete my local copy of the repository and try to clone it directly from Gittyup it says: Failed to clone into <path_to_repo> - ERROR: Repository not found.  I double checked that the URL field contains the correct SSH URL as copied-and-pasted from github.
Why am I unable to clone or fetch while using Gittyup when I can do so without issue from the command line? And what can I do to fix the issue, please?

Hi @cakemonitor Which system do you use and which version of Gittyup are you using?

Hi, I'm running Ubuntu 22.04.2 and using Gittyup v1.3.0

Can you try with the development version? https://github.com/Murmele/Gittyup/releases/tag/development

Thanks for the suggestion. I reinstalled Gittyup from the link that you provided, and the Help -> About Gittyup menu now reports: Gittyup v1.3.0 - Monday, 19 June 2023 - d3acf74. But unfortunately the issue persists.
Could it be because my SSH key type is RSA 4096-bit?

To follow up, I don't think it's due to my SSH key. I just deleted all files in ~/.ssh and ran ssh-add -D to remove all identities. I then created a new SSH key using ssh-keygen -t ed25519 -C "<my-email>", added the key to the ssh agent with ssh-add ~/.ssh/id_ed25519, and finally at github.com I deleted the old public key and created the new with the contents of the id_ed25519.pub public key file.
At the command line git fetch still works fine, but but clicking the fetch button within Gittyup continues to report Unable to fetch from 'origin' - ERROR: Repository not found.  I also tried navigating to Tools -> Options... -> Misc and setting the path to default SSH key to /home/<user>/.ssh/id_ed25519 but this did not help.

Thanks for trying also with ed25519. I will check it today in the evening

Thanks!
A bit further info since my last message: it started working fine the next day - but I'm pretty sure I didn't change anything! All I did was clone a different repo from the same github account, just as a test, and that worked. So I switched back to trying to fetch for the original repo and suddenly it was behaving correctly!
Also, FYI, I tried Gittyup about two or three months ago but stopped using it soon after becasue this exact issue cropped up then as well. So I reverted back to using git on the command line. I've never has issues using git that way, but I'd like to use a GUI and Gittyup seems to nicely meet all my requirements.
Feel free to let me know if there is anything further I can test to help resolve the issue.


@FeignClient  -  root context path

Hi,
I have a case where the endpoint has root path defined at  the top level, on the interface, like below
@RequestMapping("/foo/")
public interface FooService{

@RequestMapping("/foo1/")
public void foo1();
.....
@RequestMapping("/foo100/")
public void foo100();
}

I have client interface which relays on @FeignClient which has similar definition
@RequestMapping("/foo/")
@FeignClient(name = "fooService")
public interface FooServiceClient{

@RequestMapping("/foo1/")
public void foo1();
.....
@RequestMapping("/foo100/")
public void foo100();
}

Definition also could look like as follows
@FeignClient(name = "fooService")
public interface  FooServiceClient extends FooService {}

The result of such feign client definition is that spring registers another endpoint on the client side with root  path /foo/foo1,/foo/foo2....
Another issue appears when we define fallback class which is inherited from the FooServiceClient.
Spring also tries to register another endpoint with the same definition as FooServiceClient service has.
@FeignClient(name = "fooService", fallback = FooServiceFallback .class)
public interface FooServiceClient extends FooService {
}

@Component
public class FooServiceFallback  implements FooServiceClient {

}

My question is whenever we can pass  root path to the @FeignClient in the different way, to avoid necessary endpoint registration?

We don't support putting @RequestMapping on the Feign interface. This is a limitation of Spring MVC in that beans that are annotated with @RequestMapping on the class are registered as beans even thought they aren't annotated with @Component.

Ok. My question is rather, how I can pass root-path to the @FeignClient then. Let's assume that I would change the definition of FooService to the form as bellow
public interface FooService{

@RequestMapping("/foo1/")
public void foo1();
.....
@RequestMapping("/foo100/")
public void foo100();
}

@RequestMapping("/foo/")
public interface FooServiceImpl implements FooService{

public void foo1();
.....
public void foo100();
}

This change makes that service is available on the same address
/foo/foo1
....
/foo/foo100
When we back to our definition of FooServiceClient
@FeignClient(name = "fooService", fallback = FooServiceFallback .class)
public interface FooServiceClient extends FooService {
}

we will see two changes

/foo/foo1; ... ; /foo/foo100 endpoints will not registers on the client side
FooServiceClient will stop working

The reason that it will stop working is that is dosent have root path to service.

In that case he knows nothing about root-path to the service and indicates that  fallback always be executed.
So my question is, how to pass this root-path to the @FeignClient then?

Repeat the root mapping.
@RequestMapping("/foo/foo100/")
public void foo100();
}

This is an option, but:) then  I will have to repeat it for each method.
I purposely presented definition of FooService in that way
@RequestMapping("/foo1/")
public void foo1();
.....
@RequestMapping("/foo100/")
public void foo100();
For some reason I would not like to follow that way.


Fix LFortran to build this

Currently it fails with:
+ FC=lfortran
+ cmake -Bbuild -DMATMUL_BLAS=OpenBLAS
-- The C compiler identification is AppleClang <IP_ADDRESS>00029
-- The CXX compiler identification is AppleClang <IP_ADDRESS>00029
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /Library/Developer/CommandLineTools/usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /Library/Developer/CommandLineTools/usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- The Fortran compiler identification is unknown
-- Detecting Fortran compiler ABI info
-- Detecting Fortran compiler ABI info - failed
-- Check for working Fortran compiler: /Users/ondrej/bin/lfortran
-- Check for working Fortran compiler: /Users/ondrej/bin/lfortran - works
-- Checking whether /Users/ondrej/bin/lfortran supports Fortran 90
-- Checking whether /Users/ondrej/bin/lfortran supports Fortran 90 - no
-- Found OPENBLAS: /Users/ondrej/mambaforge/envs/fastgpt/include
-- Found OMP: /Users/ondrej/mambaforge/envs/fastgpt/include

Configuration results
---------------------
Fortran compiler: /Users/ondrej/bin/lfortran
Build type: Release
Fortran compiler flags:
Installation prefix: /usr/local
MATMUL_BLAS: OpenBLAS
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/ondrej/repos/matmul/build
+ cmake --build build
[ 16%] Building Fortran object CMakeFiles/matmullib.dir/linalg_c.f90.o
[ 33%] Building Fortran object CMakeFiles/matmullib.dir/m.f90.o
[ 50%] Building C object CMakeFiles/matmullib.dir/linalg_openblas.c.o
[ 66%] Linking Fortran static library libmatmullib.a
[ 66%] Built target matmullib
[ 83%] Building Fortran object CMakeFiles/matmul.dir/main.f90.o
ASR verify pass error: ASR verify: Var::m_v `bb` cannot point outside of its symbol table
Internal Compiler Error: Unhandled exception
Traceback (most recent call last):
  File "/Users/ondrej/repos/lfortran/lfortran/src/bin/lfortran.cpp", line 1937
    return compile_to_object_file(arg_file, outfile, false,
  File "/Users/ondrej/repos/lfortran/lfortran/src/bin/lfortran.cpp", line 897
    res = fe.get_llvm3(*asr, lpm, diagnostics, infile);
  File "/Users/ondrej/repos/lfortran/lfortran/src/lfortran/fortran_evaluator.cpp", line 346
    compiler_options, run_fn, infile);
  File "/Users/ondrej/repos/lfortran/lfortran/src/libasr/codegen/asr_to_llvm.cpp", line 7969
    pass_manager.apply_passes(al, &asr, pass_options, diagnostics);
  File "/Users/ondrej/repos/lfortran/lfortran/src/libasr/pass/pass_manager.h", line 277
    apply_passes(al, asr, _passes, pass_options, diagnostics);
  File "/Users/ondrej/repos/lfortran/lfortran/src/libasr/pass/pass_manager.h", line 153
    + passes[i]);
LCompilersException: Verify failed in the pass: array_op
make[2]: *** [CMakeFiles/matmul.dir/main.f90.o] Error 1
make[1]: *** [CMakeFiles/matmul.dir/all] Error 2
make: *** [all] Error 2

TODO:

[ ] Create a minimal reproducible example and report it to LFortran
[ ] Fix it
[ ] See what else fails

One can use LFortran via:
--- a/build.sh
+++ b/build.sh
@@ -2,6 +2,6 @@

 set -ex

-FC=gfortran cmake -Bbuild -DMATMUL_BLAS=OpenBLAS
-cmake --build build --parallel
+FC=lfortran cmake -Bbuild -DMATMUL_BLAS=OpenBLAS
+cmake --build build
 OMP_NUM_THREADS=1 build/matmul


autosave: comments should be saved by thread-id

Having a comment autosaved an then clicking in another commentbox will populate the new commentbox with text from another thread otherwise. This behaviour is prone to error.

Let me merge this with my previous issue #1068 -
While autosave is very useful and works pretty much as advertised, the comment handling is a bit weak. I think we need to not only save them by thread-id, but also load them during page load/update so that the correct comment box is opened.
As an additional feature (lower priority) put a timestamp on saved comments (and maybe posts also) where they will expire after 48 hours. I've been known to leave a page as a means of deciding not to post the comment I've spent the last 30 minutes working on. It's one click instead of click to focus, ctrl-a, ctrl-x. I'll need to adjust that behaviour but we probably don't want unfinished and abandoned comments piling up in localstorage

I believe I have it all working except for expiration.


Completions don't work for python.django combined filetypes

Problems summary
Seems like completions don't popup in python.django filetypes autocmd BufNewFile,BufRead *.py setlocal filetype=python.django
let g:loaded_deoplete_jedi returns 1, just doesn't complete.
Need confirmation. And don't know is this deoplete itself or deoplete-jedi.
Expected
Competions should work in combined filetypes
Environment Information

OS: Arch Linux
Neovim version: 0.1.3

Provide a minimal init.vim with less than 50 lines (Required!)
" Your minimal init.vim
set runtimepath+=~/path/to/deoplete.nvim/
set runtimepath+=~/path/to/deoplete-jedi/
let g:deoplete#enable_at_startup = 1
autocmd BufNewFile,BufRead *.py setlocal filetype=python.django

This is a limitation in deoplete.nvim: deoplete.py#L105-L106
Not sure if it was intentional.  What's your case for using multiple filetypes?  I have some plans for adding better support for Django, but most likely as a separate plugin.

My case is to make django filetype snippets work in python files.
There is another solution to make this work with snippets-plugin, so this is not such a problem.
But my completions in htmldjango.html filetypes work for both django snippets and html omnifunc.

Oh, so snippets.  I had this issue a while back.  Multiple filetypes seems to be supported by Vim, but only a handful of plugins actually recognize them.  I just made some autocmd's to deal with it.
autocmd BufNewFile,BufRead */templates/*.html setlocal filetype=htmldjango
autocmd FileType htmldjango,jinja UltiSnipsAddFiletypes html

I am making a plugin that helps with detection of Django project files because this is something that annoys the hell out of me.  Also, the fact that you can't get completions from Whatever.objects.

@tweekmonster : I made a small test by patching the line you mentioned in deoplete, and it seems to work as expected. I will wait for an answer from Shougo on https://github.com/Shougo/deoplete.nvim/issues/258 , but I may propose a pull request if it it ok with him.

@JeanCoopengo I'm on the fence for this issue because I don't know if this particular case is a fallacy.  Vim has builtin support for the htmldjango filetype.  There's also a builtin django syntax but only for templates so you can have highlighting for markdown.django and so on.  You can see them with :!find $VIMRUNTIME -iname \*django\*.  I feel that Vim's default handling of Django sucks, but it's not likely to change due to how old the runtime scripts are.
As a plugin developer, I don't know where the line is drawn.  If you have python.django, is it a template python script?  Should completions be given for template tags?  I'm inclined to say yes since that's what Vim implies.  In this case, deoplete.nvim should definitely support multiple filetypes.
I submitted a PR to fix the multiple filetypes.  But, my (off topic) opinion for this particular issue is that making *.py always use python.django isn't the way to go, and snippets auto-loading with the django filetype wasn't a great idea in hindsight.  markdown.django would give you syntax highlighting for template delimiters, but you'll also get snippets for markdown, and django models, forms and so on.  That doesn't make sense to me.  If you were really annoyed by this, you would end up with autocmds to remove the django snippets for markdown.django.

@tweekmonster : I have worked on a plugin to manage tryton projects. Basically, I need to extend the syntax and indentation rules for python files which are related to a tryton project.
I achieved that by extending the filetype of my python files and using custom syntax / indent files for the new extended type.
I consider that python.trpy files are python files with a bit of tryton in them. The main type is python, the second part could be seen as an extension of python in a specific context. So I expect everything that work in python files to be available in python.trpy files (including jedi :) ), as well as tryton specific behaviors.
Just my opinion though, I do not know how the builtin vim support of Django is designed, and my only experience with multiple types comes from working on one plugin.

@JeanCoopengo python.trpy will work if the PR is accepted 🙂
I agree with your point.  My beef is with how Vim's core script is treating the django filetype as not-python but snippets are treating it as python.  By my reasoning, the filetype python.django is synonymous with python.html.

@tweekmonster : I will test your PR :)

@monkoose @JeanCoopengo I finally got around to making a plugin that helps with Django development: https://github.com/tweekmonster/django-plus.vim
If you are working in a Django project directory, you won't need the python.django filetype any longer.

Thank you @tweekmonster
Already got your plugin, but even without it seems like django snippets works fine in python files, atleast for me. Should have close this some time ago.


PHOENIX-6078 Remove Internal Phoenix Connections from parent LinkedQueue when closed

https://issues.apache.org/jira/browse/PHOENIX-6078

Please open up follow up jira for unhappy path handling.  Thanks.

Please open up follow up jira for unhappy path handling. Thanks.

@dbwong added that here: https://issues.apache.org/jira/browse/PHOENIX-6079

@ChinmaySKulkarni and @sakshamgangwar , what's the status of this PR? I see that it's approved (and skimming through seems pretty straightforward). Any reason it hasn't been committed?

Kicked off a Yetus build to make sure this still passes tests. If it's green I'll merge this tomorrow.

@gjacoby126 Thanks for triggering the tests again.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 45s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ 4.x Compile Tests _

+1 :green_heart:
mvninstall
13m  0s
4.x passed

+1 :green_heart:
compile
1m 20s
4.x passed

+1 :green_heart:
checkstyle
0m 48s
4.x passed

+1 :green_heart:
javadoc
0m 58s
4.x passed

+0 :ok:
spotbugs
4m  3s
phoenix-core in 4.x has 950 extant spotbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
7m 18s
the patch passed

+1 :green_heart:
compile
1m  5s
the patch passed

+1 :green_heart:
javac
1m  5s
the patch passed

-1 :x:
checkstyle
0m 46s
phoenix-core: The patch generated 6 new + 464 unchanged - 0 fixed = 470 total (was 464)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
javadoc
0m 52s
the patch passed

+1 :green_heart:
spotbugs
4m 29s
the patch passed

_ Other Tests _

-1 :x:
unit
140m 56s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 47s
The patch does not generate ASF License warnings.

180m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-858/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/858

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile

uname
Linux a14d3d98499f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
4.x / 55c41f7

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

checkstyle
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-858/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-858/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-858/2/testReport/

Max. process+thread count
6519 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-858/2/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Test passed save for one JVM crash. Merging.


Missing "Convert between Auto property and Full property"

What the title says.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e8ce42b1-5ca3-2bba-be51-172e0ad715fd
Version Independent ID: 3e28ccb0-f87e-bb74-c4f0-ed0ed2f1b364
Content: Refactoring - Visual Studio
Content Source: docs/ide/refactoring-in-visual-studio.md
Product: visual-studio-windows
Technology: vs-ide-general
GitHub Login: @TerryGLee
Microsoft Alias: tglee

Yes, we are missing this to be documented. We do think this is discoverable within the tool. I will mark as low priority and help wanted.

@TerryGLee I dont have permissions to add labels.

@mikadumont Thanks for your response; I've change the priority. @MechanoRealist Thanks for your feedback; this is in the queue. We'll report back after we've made updates to the docs.

Thanks @TerryGLee! Can you give me access to change labels?

@mikadumont You should have this soon, if not already. (If you don't have this yet, please check again tomorrow. Then, let me know if you require further follow-up re: access.)

@TerryGLee I have it now - thank you!

Here is the missing doc for this refactoring.


Use ods spacings in demo app and SDK components

Spacing tokens review
Requirement
As a developer reviewing the mobile demo app
I want to be able to observe the entire code of the demo app
So That it reflects the way to use the spacing tokens
General description
Review the code of the demo app and check that we are using the right tokens inside each of the screens

I cannot confirm this task


docs(examples): expand all glob imports

Consensus is that explicit imports make it easier to understand the
example code. This commit removes the prelude import from all examples
and replaces it with the necessary imports, and expands other glob
imports (widget::, Constraint::, KeyCode::*, etc.) in all the
examples.
See https://github.com/ratatui-org/ratatui/issues/1150 for more details.

Given that there are 4 warnings remaining when enabling (= removing the allow) of wildcard_imports (one in the examples), should it just be enabled in this PR too?
https://github.com/ratatui-org/ratatui/blob/74a32afbaef8851f9462b27094d88d518e56addf/Cargo.toml#L77

wildcard_imports = "allow"

b82ccc28e

This helps a lot with reading code without an IDE ✨
Maybe remove the "all" from the title as prelude::* is still used in the lib itself. Also, this is a "refactor:" as it adapts the source code while maintaining the behavior? 🤔

done and done. Also fixed a doc lint


Problem with input fields through Android WebView

Hi,
We have an application that is built in Laravel with MDL as a basis for the front-end and using Vue.js as the front-end framework. Our app was initially only intended to be consumed as a standalone PWA but we then decided to develop native app wrappers.
The problem we are experiencing is that if we try to type user input into any input field, the cursor just blinks, the item loses focus and the text is instantly erased, leaving an empty field. We've tried so many workarounds to get around this, but it seems the complex HTML structure of MDL doesn't play well with the Android WebView framework.
We're using MDL version 1.3.0 and this bug only appears for users who are running our Android app where the web-app is being shown through a WebView. It's also persistent across versions, so everything from Android 6-9 and all different brands and phones.
There are no certain steps to reproduce it, input fields simply don't work. Unfortunately as this is a locked down commercial project I have nothing to show you other than a simple explanation from this SO thread: https://stackoverflow.com/a/9500715/739557.
We've been debugging this for weeks and come to the conclusion that there is nothing wrong with the app nor the way it handles focus. The WebView just is not capable of handling input alongside the MDL framework. And it's not only MDL fields. It's any fields that reside in the complex MDL structure of nested fixed elements etc.
Please, is there anyone with a fix? If we can't solve this then we need to scrap MDL and completely re-do the UI of our entire service.
Thanks.
Jonathan

i fix this issue here https://youtu.be/QTSqnqoESY4

@ahmedaniss25, unfortunately your video has been removed :(


prompt: causes nvm warnings about $PRESET

For some reason prompt is setting PRESET variable, which causes nvm to yell out.
Expected Behavior
No nvm warnings when running prompt.
Current Behavior
Running prompt with nvm installed node prints out warnings:
nvm is not compatible with the "PREFIX" environment variable: currently set to "/usr/local"
Run `unset PREFIX` to unset it.

Affected packages

[ ] cli
[ ] core
[x] prompt
[ ] config-angular

Could you provide some more detail, as: When is this happening exactly - during startup, while entering messages, when exiting?

Can reproduce
❯ footer: :skip
nvm is not compatible with the "PREFIX" environment variable: currently set to "/usr/local"
Run `unset PREFIX` to unset it.
husky > npm run -s commitmsg (node v9.8.0)

⧗   input: test(scope): REMOVE
✖   subject must not be sentence-case, start-case, pascal-case, upper-case [subject-case]
✖   found 1 problems, 0 warnings

husky > commit-msg hook failed (add --no-verify to bypass)

So it looks like it is happening after the commit message is composed but before linting it.


mAP equals 0 after 10 epochs of training

Hi! Thank you for amazing work!
I am trying to train r50vd_giam_aug model on my dataset in COCO format. In categories I have only 1 class with id=1 and each segment has category_id=1. I changed NUM_CLASSES parameter to 1 and registered dataset in train_net.py script. Also I am training on 1 GPU with batch size = 8 with AMP (reduced LR to 0.000005). After 10 epochs of training mAP is still equals 0.  What am I doing wrong?

Tried to train the model without AMP and mAP start growing. I've read other issues and it seems something wrong with AMP training

Hi @RocketFlash, thanks for your interest in SparseInst.
The learning rate is too small and you can use the default learning rate for an attempt. As for AMP, we suggest you use the  soft version of SparseInst to avoid the nan error.


Kill FsAutoComplete.Suave.exe when vscode closes

Right now I dont have windows available to test if it also works on windows.
#12

nevermind, this is still bad.


Card view for visible columns

When presenting tables of results that have thumbnails or other complex content, it is often necessary to reformat some metadata into a "card" style presentation, making a taller and narrower layout for content adjacent to the 2D thumbnail.  Currently, we do this with custom markdown formatting such as building a markdown table as part of the column-display annotation for one column that we abuse as the proxy container for this card view.  Maintenance of these annotations is painful as they are so verbose and combine so much templating and markdown syntax.
It would be much nicer (and more robust) if the visible-columns annotation structure could support this functionality using a more model-aware system like we have in the rest of Chaise.
Imagine a new visible-column element type which looks something like {"card": [...]}.  The inner list would support the same syntax as the current top-level list, so you could define a sequence of columns, foreign keys, or pseudo columns.  The object could also contain other parameters as siblings to this list, e.g. to define "markdown_name" or other card-level presentation options.
The ermrestjs/chaise interfaces and presentation layer should be extended to understand the card as a first-class concept and we should refactor our presentation templates to reuse the same logic.  E.g. the list of "columns" for a contextualized reference should be able to contain a card instance which has its own list of columns.  The presentation layer should be able to reuse much of the record app's "main entity" template to render a card's content.
I'm less certain how the card concept should affect the "tuples" in the ermrestjs api nor the environments built for the templating engine.  We would need to discuss this more and consider some use cases.
There might be more use cases to consider before designing a solution here

The vertical attribute-value list I would like to reuse alongside thumbnails in compact table presentations
Whole-entity cards, e.g. more like a conventional card UX representing a set of cards in a tiled space or in a carousel
A grouping structure within already vertical detailed record presentations?
Hybrids/nesting, e.g. card set within card or compact/tabular display within card?

Example of how this is being done in nih-cfde using markdown templating:


(Suggestion) Make TimetableList grid-like for horizontal terminals

Overview
I know it would be quite a challenge, but I was hoping to make TimetableList look like a Grid in the case of long horizontal devices.
Sample
（I don't think FlowRow is suitable for proper height positioning）

Actual
Using FlowRow

@nobonobopurin This will be a feature for tablet. I think this is not bad. What do you think?

@takahirom I think it's a good idea! 👍

I don't have condident, but i'll try :raised_hand_with_fingers_splayed:


Added browse cards

Added browse cards using styling defined on Figma. I realize there is a lot of overlap between the BrowseCard component and the PortfolioCard component, and once they are both merged I will work to remove any duplicate code/logic. It is also worth noting that this PR is just for the cards and the overall layout and not the other components on the page.
Pictures below show said cards.

@adamegyed I merged the Portfolio Card changes and then removed duplicate code between them. Take a look when you get the chance.

@adamegyed Please take a quick look at the code and then merge ASAP

@adamegyed Addressed comments, take a look when you get the chance


[Splittermond] Small fix for importer script

Changes / Comments

I fixed small importer error

Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[X] Does the pull request title have the sheet name(s)? Include each sheet name.
[X] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.


Update contributors.html

Row container was closed early, incorrect class names, two extraneous div tag closures.

I hope I did that right!

Looks like it 👍