The HLLC Riemann solver fails for some mildly discontinuous problems

Hi Guys,
I found that the HLLC Riemann Solver in Athena++ sometimes could even fail for a mildly discontinuous Riemann problem. After some examination and comparison with Athena C version, I doubt this issue is related to a few suspicious lines in the hllc.cpp file. Specifically, from line 89 to 107, it defines temp variables ql/qr and used them in the calculation of al/ar, while ql/qr are not contained in the C version HLLC Riemann solver.
My problem generator only contains a simple initial configuration:
void MeshBlock::ProblemGenerator(ParameterInput *pin) {
  Real gm1 = peos->GetGamma() - 1.0;
  Real x;
  // Initialize density, momentum
  for (int k=ks; k<=ke; k++){
    for (int j=js; j<=je; j++){
      for (int i=is; i<=ie; i++){
        x=pcoord->x1v(i);

        if (x<0.0){
        phydro->u(IDN,k,j,i) = 0.070;
        phydro->u(IM1,k,j,i) = 3.619*phydro->u(IDN,k,j,i);
        phydro->u(IM2,k,j,i) = -0.570*phydro->u(IDN,k,j,i);
        phydro->u(IM3,k,j,i) = 0.0;
        phydro->u(IEN,k,j,i) =
              0.0340/gm1 +
              (0.5)*
              (SQR(phydro->u(IM1,k,j,i)) + SQR(phydro->u(IM2,k,j,i))
               + SQR(phydro->u(IM3,k,j,i)))/phydro->u(IDN,k,j,i);
        }

        if (x>=0.0){
        phydro->u(IDN,k,j,i) = 4.847;
        phydro->u(IM1,k,j,i) = 0.173*phydro->u(IDN,k,j,i);
        phydro->u(IM2,k,j,i) = 6.584*0.001*phydro->u(IDN,k,j,i);
        phydro->u(IM3,k,j,i) = 0.0;
        phydro->u(IEN,k,j,i) =
              0.242/gm1 +
              (0.5)*
              (SQR(phydro->u(IM1,k,j,i)) + SQR(phydro->u(IM2,k,j,i))
               + SQR(phydro->u(IM3,k,j,i)))/phydro->u(IDN,k,j,i);
        }

        if (MAGNETIC_FIELDS_ENABLED){
        pfield->b.x1f(k,j,i) = 0.0;
        pfield->b.x2f(k,j,i) = 0.0;
        pfield->b.x3f(k,j,i) = 0.0;
        }
      }
    }
  }
  return;
}

I compiled it with python configure.py --prob=RStest --flux=hllc , and this choice of initial data simply comes from the problem I encountered while running my own simulation.
Now I have tried to solve this Riemann problem by several different solvers: HLLC in Athena++, HLLD with zero-amplitude magnetic field (which is supposed to reduce to HLLC), HLLE, ROE and HLLC solver in Athena C version. Only the HLLC in Athena++ would lead to crash, while all the other solvers worked well. Since the old C version works just fine, I doubt there is an issue in the hllc.cpp file. Could anyone explain where the ql/qr in line 98~101 came from? Do they belong to a standard HLLC algorithm?

@msbc, can you take a look at this issue?

I'll look into this tomorrow. Also those lines come from the general EOS changes (that I made): https://ui.adsabs.harvard.edu/abs/2020ApJS..248....7C/abstract

Okay, thanks @msbc for pointing it out. It is very useful to know about this good work. But I suppose when GENERAL_EOS==0 in Athena++, HLLC should reduce to its original version?

Ok, so I recently got an email from Hsi-Yu Schive that I had made a typo when transcribing the equations defining ql/qr to code. Fixing these fixes the issue (I'll post a PR soon). Unrelated, Hsi-Yu also found a bug in the Hydrogen EOS asq function.
Jim, Kengo, and I had a discussion about reducing HLLC to its original version. I had tested various pgens/test with both versions and found no discernible difference in results. So, we came to the conclusion that it was better to have just one version of HLLC and used ther version in my paper.


plot image missing in online documentation

niche_vlaanderen version: 1.0b5
On: https://inbo.github.io/niche_vlaanderen/floodplain.html
some plots are not rendered

Seems to be the case with every first plot of a page.

Interestingly this does not happen when building locally.


Features request for Android version

Please add support for Chrome add-ons

@Subbarao6338 I might do this in the future, using code from kiwi browser. Currently it is the only Chromium fork for android with proper chrome extension support.


Are you going to develop Deconvolution layers?)

Hi! Amazing framework! Thanks! The framework would be even more amazing if you provide convolution transpose layer ;))) Are you going to do this? :)

Good question. :-) MPSCNN has some new layer types that I should add to Forge, including transposed convolution. But no promises. ;-)

Looking Forward...


First commit

Please check the following conditions for your PR.

[x] apiDefinition.swagger.json is validated using paconn validate command.
[x] apiProperties.json has a valid brand color. Invalid brand colors are #007ee5 and #ffffff.

Hi @amancdk
We found the following error for the submission. It appears that the ending space in the folder name may have caused the error. Can you please submit the PR after removing the ending space?
If we encounter the same problem again you may have to remove all spaces.
error: invalid path 'custom-connectors/CDK Elead Product Reference /apiDefinition.swagger.json'

Hi @amancdk
We found the following error for the submission. It appears that the ending space in the folder name may have caused the error. Can you please submit the PR after removing the ending space?
If we encounter the same problem again you may have to remove all spaces.
error: invalid path 'custom-connectors/CDK Elead Product Reference /apiDefinition.swagger.json'

Hi,
I tried making changes to the existing PR but was not able to.
Created a new 1 with the fix.
https://github.com/microsoft/PowerPlatformConnectors/pull/650
Regards,
Aman

From: Mahbub Murshed<EMAIL_ADDRESS>Sent: Monday, January 11, 2021 12:55 PM
To: microsoft/PowerPlatformConnectors
Cc: Bhargava, Aman Avinash; Mention
Subject: Re: [microsoft/PowerPlatformConnectors] First commit (#649)
Hi @amancdkhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_amancdk&d=DwMCaQ&c=N13-TaG7c-EYAiUNohBk74oLRjUiBTwVm-KSnr4bPSc&r=dIPM_KF4GTc3orW0l-o6d2q5c9CbawZrDX7hsGTtRT0&m=sC1ruy462_bWZ4SRl8kiLfb8fFu_1CfgltJlT39xtA0&s=CITTVZIS6EYWkkFvThPVL_V7UINv1cKtx3rq9kXbSAU&e=
We found the following error for the submission. It appears that the ending space in the folder name may have caused the error. Can you please submit the PR after removing the ending space?
If we encounter the same problem again you may have to remove all spaces.
error: invalid path 'custom-connectors/CDK Elead Product Reference /apiDefinition.swagger.json'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_microsoft_PowerPlatformConnectors_pull_649-23issuecomment-2D758153365&d=DwMCaQ&c=N13-TaG7c-EYAiUNohBk74oLRjUiBTwVm-KSnr4bPSc&r=dIPM_KF4GTc3orW0l-o6d2q5c9CbawZrDX7hsGTtRT0&m=sC1ruy462_bWZ4SRl8kiLfb8fFu_1CfgltJlT39xtA0&s=-IDpEc3WlkMUUa5eFuW_h9ZiifVLaKcMhUq2F5KewbM&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AIRAEBFNRYM4J3MFMDYDXHLSZNCTTANCNFSM4V52RA2Q&d=DwMCaQ&c=N13-TaG7c-EYAiUNohBk74oLRjUiBTwVm-KSnr4bPSc&r=dIPM_KF4GTc3orW0l-o6d2q5c9CbawZrDX7hsGTtRT0&m=sC1ruy462_bWZ4SRl8kiLfb8fFu_1CfgltJlT39xtA0&s=o35qm5uAv-tqDZp7sWLhd_YIEFi-G-1xyhXtDQpi9e4&e=.

This message and any attachments are intended only for the use of the addressee and may contain information that is privileged and confidential. If the reader of the message is not the intended recipient or an authorized representative of the intended recipient, you are hereby notified that any dissemination of this communication is strictly prohibited. If you have received this communication in error, notify the sender immediately by return email and delete the message and any attachments from your system.

Hi,
I tried making changes to the existing PR but was not able to.
Created a new 1 with the fix.
https://github.com/microsoft/PowerPlatformConnectors/pull/650
Regards,
Aman

From: Mahbub Murshed<EMAIL_ADDRESS>Sent: Monday, January 11, 2021 12:55 PM
To: microsoft/PowerPlatformConnectors
Cc: Bhargava, Aman Avinash; Mention
Subject: Re: [microsoft/PowerPlatformConnectors] First commit (#649)
Hi @amancdkhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_amancdk&d=DwMCaQ&c=N13-TaG7c-EYAiUNohBk74oLRjUiBTwVm-KSnr4bPSc&r=dIPM_KF4GTc3orW0l-o6d2q5c9CbawZrDX7hsGTtRT0&m=sC1ruy462_bWZ4SRl8kiLfb8fFu_1CfgltJlT39xtA0&s=CITTVZIS6EYWkkFvThPVL_V7UINv1cKtx3rq9kXbSAU&e=
We found the following error for the submission. It appears that the ending space in the folder name may have caused the error. Can you please submit the PR after removing the ending space?
If we encounter the same problem again you may have to remove all spaces.
error: invalid path 'custom-connectors/CDK Elead Product Reference /apiDefinition.swagger.json'
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_microsoft_PowerPlatformConnectors_pull_649-23issuecomment-2D758153365&d=DwMCaQ&c=N13-TaG7c-EYAiUNohBk74oLRjUiBTwVm-KSnr4bPSc&r=dIPM_KF4GTc3orW0l-o6d2q5c9CbawZrDX7hsGTtRT0&m=sC1ruy462_bWZ4SRl8kiLfb8fFu_1CfgltJlT39xtA0&s=-IDpEc3WlkMUUa5eFuW_h9ZiifVLaKcMhUq2F5KewbM&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AIRAEBFNRYM4J3MFMDYDXHLSZNCTTANCNFSM4V52RA2Q&d=DwMCaQ&c=N13-TaG7c-EYAiUNohBk74oLRjUiBTwVm-KSnr4bPSc&r=dIPM_KF4GTc3orW0l-o6d2q5c9CbawZrDX7hsGTtRT0&m=sC1ruy462_bWZ4SRl8kiLfb8fFu_1CfgltJlT39xtA0&s=o35qm5uAv-tqDZp7sWLhd_YIEFi-G-1xyhXtDQpi9e4&e=.

This message and any attachments are intended only for the use of the addressee and may contain information that is privileged and confidential. If the reader of the message is not the intended recipient or an authorized representative of the intended recipient, you are hereby notified that any dissemination of this communication is strictly prohibited. If you have received this communication in error, notify the sender immediately by return email and delete the message and any attachments from your system.


[Roadmap] 1.5.0 Roadmap

@dmlc/xgboost-committer Please add your items here by editing this post. Let's ensure that

Each item has to be associated with a ticket
Major design/refactoring are associated with a RFC before committing the code
Blocking issue must be marked as blocking
Breaking change must be marked as breaking

For other contributors who have no permission to edit the post, please comment here about what you think should be in 1.5.0.

[x] New external memory implementation using data iterator. (#7070)
[ ] Improve ranking implementation. (#6450)
[ ] [JVM-Packages] Early stopping attributes (https://github.com/dmlc/xgboost/issues/6893)
[ ] Further development on categorical data support. (#6503)
[ ] Staged predict (#5006)
[x] [Python] Add min_delta to early stopping. (#6942, #7137)
[ ] Add score tree interval to early stopping. (#5238, #5090)
[x] New R predict function.

+1 for Revising ranking objectives. #6450

+1 for ([XGBoost4J-Spark] Early stopping and best iteration)  #6893

[ ] Add score tree interval to early stopping. (#5238, #5090)
[ ] Improve ranking implementation. (#6450)

Moving the 2 items to the next release.  I will start planning the release before the end of next week.


[x11] Use "application/config/name" for WM_CLASS

Fix #18510.
I don't know how to add this as an option for export project. (and I don't think it's necessary)

ProjectList:

Editor:

Game:

Also, special chars will be escaped:

I thinks that it's not a great idea to add the 'Godot_Engine' class because it will group all games made with Godot into one window if running in parallel.

@Nobelix "Godot_Engine" is used for res_name and this property is not used to group applications, only res_class will be considered.
godot editor and two games running:

Thanks!


[TE] Detection runs multiple times at same time

Detection job gets triggered multiple times at same time because multiple detection tasks get scheduled. The problem is with detection task creation which doesn't factor in concurrent insertions. Scheduler can call same detection job creation concurrently depending on free scheduler threads.
Though after taking lock on scheduler job (@DisallowConcurrentExecution) the problem will persist when multiple scheduler nodes exists in cluster. DetectionPipelineJob taskDao insertion need to have some distributed lock semantics.
INFO  [2020-09-13 18:18:27,548] org.quartz.core.QuartzScheduler: Scheduler meta-data: Quartz Scheduler (v2.2.1) 'DefaultQuartzScheduler' with instanceId 'NON_CLUSTERED'
  Scheduler class: 'org.quartz.core.QuartzScheduler' - running locally.
  NOT STARTED.
  Currently in standby mode.
  Number of jobs executed: 0
  Using thread pool 'org.quartz.simpl.SimpleThreadPool' - with 10 threads.
  Using job-store 'org.quartz.simpl.RAMJobStore' - which does not support persistence. and is not clustered.
.
.
.
.
INFO  [2020-09-13 17:30:07,425] org.apache.pinot.thirdeye.detection.alert.DetectionAlertJob: Created DETECTION_ALERT task 299 with settings TaskDTO[taskType=DETECTION_ALERT,workerId=<null>,jobId=<null>,jobName=DETECTION_ALERT_24,status=WAITING,startTime=0,endTime=0,taskInfo={"detectionAlertConfigId":24},message=<null>,lastModified=<null>,id=299,version=0,updateTime=<null>,createdBy=<null>,updatedBy=<null>]
INFO  [2020-09-13 17:30:07,928] org.apache.pinot.thirdeye.detection.alert.DetectionAlertJob: Created DETECTION_ALERT task 300 with settings TaskDTO[taskType=DETECTION_ALERT,workerId=<null>,jobId=<null>,jobName=DETECTION_ALERT_24,status=WAITING,startTime=0,endTime=0,taskInfo={"detectionAlertConfigId":24},message=<null>,lastModified=<null>,id=300,version=0,updateTime=<null>,createdBy=<null>,updatedBy=<null>]
INFO  [2020-09-13 17:30:08,647] org.apache.pinot.thirdeye.detection.DetectionPipelineJob: Created DETECTION task TaskDTO[taskType=DETECTION,workerId=<null>,jobId=<null>,jobName=DETECTION_23,status=WAITING,startTime=0,endTime=0,taskInfo={"configId":23,"start":1600018092445,"end":1600018201552,"online":false,"detectionConfigBean":null},message=<null>,lastModified=<null>,id=301,version=0,updateTime=<null>,createdBy=<null>,updatedBy=<null>] with taskId 301
INFO  [2020-09-13 17:30:08,813] org.apache.pinot.thirdeye.detection.DetectionPipelineJob: Created DETECTION task TaskDTO[taskType=DETECTION,workerId=<null>,jobId=<null>,jobName=DETECTION_23,status=WAITING,startTime=0,endTime=0,taskInfo={"configId":23,"start":1600018092445,"end":1600018201980,"online":false,"detectionConfigBean":null},message=<null>,lastModified=<null>,id=302,version=0,updateTime=<null>,createdBy=<null>,updatedBy=<null>] with taskId 302
INFO  [2020-09-13 17:30:08,969] org.apache.pinot.thirdeye.detection.alert.DetectionAlertJob: Created DETECTION_ALERT task 303 with settings TaskDTO[taskType=DETECTION_ALERT,workerId=<null>,jobId=<null>,jobName=DETECTION_ALERT_24,status=WAITING,startTime=0,endTime=0,taskInfo={"detectionAlertConfigId":24},message=<null>,lastModified=<null>,id=303,version=0,updateTime=<null>,createdBy=<null>,updatedBy=<null>]
INFO  [2020-09-13 17:30:10,384] org.apache.pinot.thirdeye.detection.DetectionPipelineJob: Created DETECTION task TaskDTO[taskType=DETECTION,workerId=<null>,jobId=<null>,jobName=DETECTION_23,status=WAITING,startTime=0,endTime=0,taskInfo={"configId":23,"start":1600018092445,"end":1600018203484,"online":false,"detectionConfigBean":null},message=<null>,lastModified=<null>,id=304,version=0,updateTime=<null>,createdBy=<null>,updatedBy=<null>] with taskId 304
INFO  [2020-09-13 17:30:10,844] org.apache.pinot.thirdeye.detection.DetectionPipelineJob: Skip scheduling detection task for DETECTION_23 with start time<PHONE_NUMBER>445. Task is already in the queue.
INFO  [2020-09-13 17:30:10,942] org.apache.pinot.thirdeye.detection.alert.DetectionAlertJob: Created DETECTION_ALERT task 305 with settings TaskDTO[taskType=DETECTION_ALERT,workerId=<null>,jobId=<null>,jobName=DETECTION_ALERT_24,status=WAITING,startTime=0,endTime=0,taskInfo={"detectionAlertConfigId":24},message=<null>,lastModified=<null>,id=305,version=0,updateTime=<null>,createdBy=<null>,updatedBy=<null>]
INFO  [2020-09-13 17:30:11,083] org.apache.pinot.thirdeye.detection.alert.DetectionAlertJob: Created DETECTION_ALERT task 307 with settings TaskDTO[taskType=DETECTION_ALERT,workerId=<null>,jobId=<null>,jobName=DETECTION_ALERT_24,status=WAITING,startTime=0,endTime=0,taskInfo={"detectionAlertConfigId":24},message=<null>,lastModified=<null>,id=307,version=0,updateTime=<null>,createdBy=<null>,updatedBy=<null>]
INFO  [2020-09-13 17:30:11,092] org.apache.pinot.thirdeye.detection.DetectionPipelineJob: Created DETECTION task TaskDTO[taskType=DETECTION,workerId=<null>,jobId=<null>,jobName=DETECTION_23,status=WAITING,startTime=0,endTime=0,taskInfo={"configId":23,"start":1600018092445,"end":1600018204022,"online":false,"detectionConfigBean":null},message=<null>,lastModified=<null>,id=306,version=0,updateTime=<null>,createdBy=<null>,updatedBy=<null>] with taskId 306

Slack conversation: https://apache-thirdeye.slack.com/archives/C014CS60A22/p1600027780034000

Closing third-eye related issue as the project has been moved out of the pinot repo. For unsolved issue that still applies, please create a new one under third-eye repo: https://github.com/project-thirdeye/thirdeye


set with_ms2 is ignored

When I run a query with with_ms2 true, I get the same answer as with_ms2 false. The query 'with_ms2 true' should only return the cases where the 'withMS2' flag is set to 1.

All set.


add bg.line to telescope.selection

nearly impossible to see what line in a telescope picker you have selected without this.

thanks for the catch!


How to config java agent with spring-native

We are using Skywalking APM to trace microservices.
Skywalking agent is configured by -javaagent:/path/to/skywalking-package/agent/skywalking-agent.jar.
https://skywalking.apache.org/docs/main/latest/en/setup/service-agent/java-agent/readme/
The question is how to config java agent with spring-native?

@mattwmj when I last looked into this it wasn't possible. We're using Datadog and had a similar issue to yours but couldn't find a way around it. I believe the GraalVM team has a ticket on this and I'll try and find it and attach it here.

Probably https://github.com/oracle/graal/issues/1065.

We are using Skywalking APM to trace microservices. Skywalking agent is configured by -javaagent:/path/to/skywalking-package/agent/skywalking-agent.jar.
https://skywalking.apache.org/docs/main/latest/en/setup/service-agent/java-agent/readme/
The question is how to config java agent with spring-native?

I found an approach, but I still need to do a test. It may help you. Yep, I am 程浩. Nice to see you, Master Wang.
https://shardingsphere.apache.org/document/current/en/user-manual/shardingsphere-proxy/startup/graalvm-native-image/


[C# Grpc] Support initializing a grpc service client with a CallInvoker instance.

New feature of Interceptor was added to grpc, and client side
interceptor relies on CallInvoker to work.
Protobuf has already added the constructor for C#.
See
L12-csharp-interceptors
and
discussion.
Fix #950

@ara-ayvazyan @lalo

Changes LGTM. Thanks!
However, the AppVeyor build is broken due to changes introduced in CMake 3.12. These need to be addressed before this can be merged, as we cannot merge without a clean build.
I do not have the time to fix the AppVeyor build and I won't have time in the near future either. If you want to see this merged, it would help if you can--in a separate PR--fix the AppVeyor build as well. It looks like the fix is to rename a few CMake variables to not end with _ROOT.

Changes LGTM. One minor thing: can you update the changelog to include this new C# functionality?
However, the AppVeyor build is broken due to changes introduced in CMake 3.12. These need to be addressed before this can be merged, as we cannot merge without a clean build.
I do not have the time to fix the AppVeyor build and I won't have time in the near future either. If you want to see this merged, it would help if you can--in a separate PR--fix the AppVeyor build as well. It looks like the fix is to rename a few CMake variables to not end with _ROOT.

I can try to fix the AppVeyor build, though not quite familiar with the CMake stuff.

Hi, may I ask when this change will be released? Need it desperately. Thanks.

@whisperingchild @YanlongLi a release has been cut you can get it from Nuget.org as usual. For example -> https://www.nuget.org/packages/Bond.CSharp/

@lalo Thanks very much.


x86_64-linux only?

Hi,
I use your flake and neovim config and I like it a lot. Thanks!
Can you eleborate why you force the use ov x86_64-linux system now in https://github.com/jordanisaacs/neovim-flake/commit/d5fc2d3e23dcb4f1dd7c55ded2e0f431d84653ea ?
I used your flake successfully on my raspberry and due to the recent change, I can't use it anymore..

Hi gador,
Sorry for the late reply, been on midterms and break recently. I packaged a treesitter plugin for a language that currently only builds on x86-64 linux (tree-sitter-hare in my jdpkgs repo). Thus it would fail nix flake check and I am working on getting all my flakes to pass. Feel free to fork it, reintroduce the flake-utils and remove the dependency on jdpkgs and it should work just fine!

Jordan

Hi Jordan,
thanks for the pointers! I ended up using an older revision and then later switched to https://github.com/pta2002/nixvim
Thanks for all the work you put into this!


feat: log workbox build result and warnings

This PR includes:

log workbox-build result (for injectManifest and generateSW) when vite.logLevel is undefined or info
log always workbox-build warnings (for injectManifest and generateSW)
pwa docs: added to workbox entry Missing assets from SW precache manifest on injectManifest and generateSW
pwa docs: added to workbox entry Log injecManifest result on injectManifest and generateSW

Requires new release 0.11.3, referenced on pwa docs changes.
closes #134

wait, I have some errata on docs...

@antfu I think it is now  ready to reviw


added a way to customize video quality

Added a new option to be able to set up the video/picture quality

Awesome :+1: we have a parallel pr on the Android side that we will need to reconcile.

Hey @lwansbrough   any news on this?

I think @rt2zz  are refering to https://github.com/lwansbrough/react-native-camera/pull/203, right?  which one will you take as the standard API for the quality change? Is there anything I can do to get this moving?

This would be really useful for me as well.

+1

+1

Does this work only for video. From the code it looks like it should apply to photographs as well...
@lwansbrough how do you feel about this api? Namely the captureQuality prop. If you like it I can work on getting android in line with the same api and we can merge this.

yup @rt2zz  you are right, this works for both video and pics. I just updated the title so that people dont get confused

Any progress on this? It would be great to have this merged.

Cool, I would very much like to see this integrated with the solution for Android. Not sure I can get to it tonight. Someone want to take this on? All the work appears to be done - it just requires aligning the APIs between this PR and @juggleru's here: https://github.com/lwansbrough/react-native-camera/pull/203


Avoid file/dir name collisions by putting profiles in an isolated location

Moved profile root to $XDG_DATA_HOME/qutebrowser/profiles so profile names cannot collide with Qutebrowser data files (eg: webengine)

Thanks for the PR! Good thinking, this is sensible. I've left one comment on it - once that's resolved we can merge.
On versioning, at the moment this just has a straight master branch, but I can see it would benefit folks to have versioning around this as it appears to get some usage, so I'll put up a separate issue for that.

No problemo.  Updated!

This looks good to me, but is a breaking change. A release note should be added to note that manual migration is required for the upgrade by creating the directly and copying the folders into it.

Thanks for your work on this folks. I've re-implemented qutebrowser-profile in Python which solves a few headaches with its implementation. Would it be possible to re-work this PR in Python?
I agree with @markstos that, as a breaking change, we need to add it to release notes. We may also be able to automate migration in most cases so perhaps should consider that (though I'm not sure how wide our userbase is!)


Fixed link to OTA documentation

Thank you for pointing out this issue. We have updated our docs.

@ivankravets,
Glad to provide this little contribution. In fact it was me who changed original link on https://github.com/esp8266/Arduino/tree/master/doc and now I am just cleaning the mess I did :smile:
Krzysztof


[DOCFIX]Update table/cn/common-configuration.yml

alluxio-bot, check this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/20477/
Test PASSed.


Unable to run

Hi @Lars-Ki unable to run the project facing some sort of rrt node error please help

Hi. Could you provide a view more details on what exactly is not working?
Please provide the following:

do you have local changes?
copy and paste the error message

Thanks

Hi. Could you provide a view more details on what exactly is not working? Please provide the following:

do you have local changes?
copy and paste the error message

Thanks

Im using custom depth camera and point cloud along with px4 flight controller...i tried running it on simualtion first but getting error saying:
[ERROR] [1686292411.124087, 1035.659000]: bad callback: <bound method Drone.set_drone_position of <__main__.Drone object at 0x7f02033972b0>>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_planner.py", line 43, in set_drone_position
    local_map_value = local_map.map_matrix[y_ind][x_ind]
TypeError: list indices must be integers or slices, not float

[ERROR] [1686292411.177534, 1035.695000]: bad callback: <bound method Drone.set_drone_position of <__main__.Drone object at 0x7f02033972b0>>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_planner.py", line 43, in set_drone_position
    local_map_value = local_map.map_matrix[y_ind][x_ind]
TypeError: list indices must be integers or slices, not flo

Tried implementing it on hardware too the avoidance system is showing ready but the drone just took off and holded on a height and didint move anywhere...projected_map topic was working good at 30hz
Please help

You are also mentioned that it will fly only from 5 meters could u please explain why? also if i want to make it run below 5 what i will have to do.

One of the Issues in the noisy signal simulation was, that under a certain altitude, the ground was mapped as an obstacle. This happens when the drone's position starts to drift vertically. To avoid this my code only maps obstacles above 1m. (See here, Link) For real applications be aware of this. If the ground is mapped and seen as an obstacle, it will try to exit the safety radius and could go crazy (flying in one direction always mapping new ground, therefore obstacles and this circle will continue).
The error msg looks like it is returning nonsense. The indexes of the voxels in the local map could be none. Try a print() in the else part here in the local_planner.py Line 713
If I remember correctly you need to start the Master_node.py separately after launching the script (Here you can see why The master node is not launched. Did you do that?
Or did you forget to set the COM_OBS_AVOID = 1 in Q-Ground Control?
can you maybe run:
rqt_graph
and see which node is active or not.
If you manage to fly it outside on a drone, please send me a video. I would love to see it  :D

This is my RQT_GRAPH

This is my frames:

Please help

Okay so on my setup it works:
The error msg you provided in the second post:
[ERROR] [1686292411.124087, 1035.659000]: bad callback: <bound method Drone.set_drone_position of <__main__.Drone object at 0x7f02033972b0>>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_planner.py", line 43, in set_drone_position
    local_map_value = local_map.map_matrix[y_ind][x_ind]
TypeError: list indices must be integers or slices, not float

[ERROR] [1686292411.177534, 1035.695000]: bad callback: <bound method Drone.set_drone_position of <__main__.Drone object at 0x7f02033972b0>>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_planner.py", line 43, in set_drone_position
    local_map_value = local_map.map_matrix[y_ind][x_ind]
TypeError: list indices must be integers or slices, not flo

is "normal" as long as the master node is not running. When you run:
rosrun px4_rrt_avoidance Master_node.py
this should stop correct?
The next thing that I have noticed is on your rqt_graph, is that the local_map is not published by local_map_publisher.
I am very confident that this causes the route planning issue (your drone staying stationary). This could happen because of two reasons:

There is an issue in the local_map_publisher node. Here just disable the node in the launch it manually (incl master noder) or kill the node and relaunch it. If you have an error msg please report.
the local_map_publisher sees no obstacle and therefore does not publish a local_map.  Here maybe try to bring the obstacle closer to the camera in gazebo

For reference, here is my rqt_graph

Maybe also check rviz. If you launch roslaunch px4_rrt_avoidance iris_depth.launch there should be a fountain in front of the drone:

in rviz you should see some voxels like these:

Feel free to post those images as well, maybe this will help resolve your issue.

Okay so on my setup it works: The error msg you provided in the second post:
[ERROR] [1686292411.124087, 1035.659000]: bad callback: <bound method Drone.set_drone_position of <__main__.Drone object at 0x7f02033972b0>>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_planner.py", line 43, in set_drone_position
    local_map_value = local_map.map_matrix[y_ind][x_ind]
TypeError: list indices must be integers or slices, not float

[ERROR] [1686292411.177534, 1035.695000]: bad callback: <bound method Drone.set_drone_position of <__main__.Drone object at 0x7f02033972b0>>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_planner.py", line 43, in set_drone_position
    local_map_value = local_map.map_matrix[y_ind][x_ind]
TypeError: list indices must be integers or slices, not flo

is "normal" as long as the master node is not running. When you run: rosrun px4_rrt_avoidance Master_node.py this should stop correct? The next thing that I have noticed is on your rqt_graph, is that the local_map is not published by local_map_publisher. I am very confident that this causes the route planning issue (your drone staying stationary). This could happen because of two reasons:
1. There is an issue in the local_map_publisher node. Here just disable the node in the launch it manually (incl master noder) **or** kill the node and relaunch it. If you have an error msg please report.

2. the local_map_publisher sees no obstacle and therefore does not publish a local_map.  Here maybe try to bring the obstacle closer to the camera in gazebo

For reference, here is my rqt_graph
Maybe also check rviz. If you launch roslaunch px4_rrt_avoidance iris_depth.launch there should be a fountain in front of the drone:
in rviz you should see some voxels like these:

Feel free to post those images as well, maybe this will help resolve your issue.

Thank you for the reply.
I have tried the steps you told to manually launch the local_map_publisher node instead of launching it from launch file but then also there is same error. also i have add obstacle closer to the drone camera here is the image:

this is the screenshot of my terminal where im launching things:

this is the rosgraph again:

also no voxels is being shown on rviz:

Please help!!!:))

This is a different issue than before. Here gazebo is not publishing anything to camera/depth/points. This could be due to multiple reasons.
1. Gazebo is not correctly set up. (Have you tried my launch script? Does it work there?)

2. Your camera is not publishing the correct msg. Make sure to tell octomap to listen to the correct msg [here](https://github.com/Lars-Ki/px4_rrt_avoidance/blob/main/launch/iris_depth.launch#L42)

Sorry my bad my simulation drone publish pointcloud topic named /iris/camera/depth/points i made the change in launch file these are the screenshots :

VOXELS are IN UPWARD DIRECTION it should be in forward :(
This is the new RQT_GRAPH:

This is a little bit more tricky to solve without further information:
1. Can you tell me more about the mission (altitude). It looks like you are sitting on the ground with your drone?

2. In your rviz image, I do not see the local map. Did you disable the view in rviz? Maybe listen to this msg in your terminal and see if it is updating ( `rostopic echo ...` or `rostopic hz ....`)

3. Are you sure that `COM_OBS_AVOID = 1`

4. Maybe PX4 has changed their system and needs new parameter or they need it to be published on a different topic.

5. listen to mavros/trajectory/generated to make sure master_node is publishing a path to follow.

6. I believe to take off your drone needs to be initiated in a **un**-occupied local_map area for it to take off. This looks like it is already too close to the obstacle.

You could try a rosbag. If you send me the file or give me access rights to download it somewhere I can see for myself what is going on. (Pls also provide the rviz configuration for me)
FYI: Would be nice If you could upload your code with the "Add Code" Button instead of uploading your launch file or error msg as an image ;) A picture won't help me to find a specific error msg ;) Thank You!

My mission altitude is 4 meters i tried both with taking off prior and mission takeoff

Local map is showing no map received

Yes COM_OBS_AVOID = 1

Error when launching iris_depth.launch
[ERROR] [1687278970.609805, 437.859000]: bad callback: <bound method Drone.set_drone_position of <__main__.Drone object at 0x7f009e0a9310>>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_planner.py", line 43, in set_drone_position
    local_map_value = local_map.map_matrix[y_ind][x_ind]
TypeError: list indices must be integers or slices, not float

[ERROR] [1687278970.641511, 437.891000]: bad callback: <bound method Drone.set_drone_position of <__main__.Drone object at 0x7f009e0a9310>>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_planner.py", line 43, in set_drone_position
    local_map_value = local_map.map_matrix[y_ind][x_ind]
TypeError: list indices must be integers or slices, not float

Error when running local_map_publisher.py :
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_map_publisher.py", line 535, in separate_msg
    global_map.set_occupancy_matrix(msg.data)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_map_publisher.py", line 434, in set_occupancy_matrix
    local_map.publish_map()
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_map_publisher.py", line 466, in publish_map
    pub.publish(msg)
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 886, in publish
    raise ROSSerializationException(str(e))
rospy.exceptions.ROSSerializationException: field data[] must be an integer type

Here is the folder which have my workspace named drone_ws and rosbag of all the topics while running the mission i have recorded.
https://enordpvtltd913-my.sharepoint.com/:f:/g/personal/bhaskar_enord_tech/EnBcg5xGN3lCjfZq9jwTzpUBMTixGJJ69WcYuRlb3BtNMw?e=5KmXnn
Thank you,:))

I believe I have found one issue.
On your latest rqt_graph the local_map_publisher is not listening on all of the following mavros msg:

/mavros/trajectory/desired (missing).  I don't know why. This msg is also missing for the master node
/mavros/state (OK)
/mavros/local_position/pose (missing)
and obviously /projected_map (from local_map_publisher)

2 is needed to create the second corner of the local map.
3 is needed for the first corner of the local map.
I believe I remember PX4 was working on changes back then. (This could help???: Link )
Try if you can find some information on that and let me know what you find ;)

I believe I have found one issue. On your latest rqt_graph the local_map_publisher is not listening on all of the following mavros msg:
1. /mavros/trajectory/desired (missing).  I don't know why. This msg is also missing for the master node

2. /mavros/state (OK)

3. /mavros/local_position/pose (missing)

4. and obviously /projected_map (from local_map_publisher)

2 is needed to create the second corner of the local map. 3 is needed for the first corner of the local map.
I believe I remember PX4 was working on changes back then. (This could help???: Link )
Try if you can find some information on that and let me know what you find ;)

Do you think it could be a problem of frames??

Please check my frames and could u share yours?
Also my /mavros/local_position/pose and /projected_map topic is working very fine i checked it properly and yes /mavros/trajectory/desired topic isnt working beacuse when i echoed it after running mission it isnt giving any points.:((
Please help

local_map_publisher
I am very certain that the issue lies in the missing desired trajectory. Have you read this paper ( link to pdf )? This should make it very clear why it is needed.
Did you check that:

/mavros/local_position/pose is publishing data:  rostopic echo /mavros/local_position/pose
That you have uploaded the mission (check before and after rostopic echo /mavros/trajectory/desired  (see example below)
Try disabling all prints from local_map_publisher and see if there are any error msg coming up

And yes your local_map is most likely initiated but is not publishing any data:
try:
rostopic echo /local_map
rostopic hz /local_map (mine is pub. at 12.6 hz)
Example Rostopics:
mavros/trajectory:/desired
---
header:
  seq: 4542
  stamp:
    secs: 0
    nsecs:   3867098
  frame_id: "local_origin"
type: 0
point_1:
  header:
    seq: 0
    stamp:
      secs: 0
      nsecs:         0
    frame_id: ''
  coordinate_frame: 0
  type_mask: 0
  position:
    x: 0.0062934695743
    y: 0.0159048866481
    z: -0.185148119926
  velocity:
    x: nan
    y: nan
    z: nan
  acceleration_or_force:
    x: nan
    y: nan
    z: nan
  yaw: nan
  yaw_rate: nan
point_2:
  header:
    seq: 0
    stamp:
      secs: 0
      nsecs:         0
    frame_id: ''
  coordinate_frame: 0
  type_mask: 0
  position:
    x: nan
    y: nan
    z: nan
  velocity:
    x: nan
    y: nan
    z: nan
  acceleration_or_force:
    x: nan
    y: nan
    z: nan
  yaw: nan
  yaw_rate: nan
point_3:
.
.
.

mavros/local_position/pose
---
header:
  seq: 21819
  stamp:
    secs: 732
    nsecs: 699953907
  frame_id: "map"
pose:
  position:
    x: 0.0217683389783
    y: -0.00763884140179
    z: -0.0043252883479
  orientation:
    x: -0.000933672631935
    y: 0.00339157031752
    z: -0.00674492875459
    w: -0.999971070148
---

local_map
header:
  seq: 14836
  stamp:
    secs: 1177
    nsecs: 768000000
  frame_id: "map"
info:
  map_load_time:
    secs: 0
    nsecs:         0
  resolution: 0.5
  width: 24
  height: 24
  origin:
    position:
      x: -6.0
      y: -6.0
      z: 0.0
    orientation:
      x: 0.0
      y: 0.0
      z: 0.0
      w: 0.0
data: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 30, 30, 30, 30, 30, 30, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 30, 80, 80, 80, 80, 80, 80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 80, 80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 80, 80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 80, 80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 80, 80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 80, 100, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 100, 100, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 100, 100, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 100, 100, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 100, 100, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 80, 100, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 80, 80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 80, 80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 80, 80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 80, 80, 80, 80, 80, 80, 80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 30, 80, 80, 80, 80, 80, 80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 30, 30, 30, 30, 30, 30, 30, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]
---

Starting local_map_publisher
Local_map_pub gives me the following printouts (no changes)
lkillian@lkillian-All-Series:~$ rosrun px4_rrt_avoidance local_map_publisher.py
local_LLC[1]: -6
global_LLC[1]: -1.5
local_LLC[1]: -6
global_LLC[1]: -1.5
local_LLC[1]: -6
global_LLC[1]: -1.5
local_LLC[1]: -6
global_LLC[1]: -1.5
local_LLC[1]: -6
global_LLC[1]: -1.5
local_LLC[1]: -6
global_LLC[1]: -1.5

Frames
The frames look good to me:

Could you try again uploading a new rosbag with only the relevant rostopics? I have currently an issue with the one you have provided. Thx

Could you try again uploading a new rosbag with only the relevant rostopics? I have currently an issue with the one you have provided. Thx

Bag file of the desired topic that is :
mavros/trajectory/desired
mavros/local_position/pose
/local_map (not working)
https://enordpvtltd913-my.sharepoint.com/:u:/g/personal/bhaskar_enord_tech/Efpwlsg1PodIgDyffftOxb8BG1frs9hWq8ryya4eQyEWCQ?e=muMhEf
also as your local_map_publisher.py is printing some local_LLC and so, in my case it is printing the same but only sometime along with error that is:
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 750, in _invoke_callback
    cb(msg)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_map_publisher.py", line 535, in separate_msg
    global_map.set_occupancy_matrix(msg.data)
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_map_publisher.py", line 434, in set_occupancy_matrix
    local_map.publish_map()
  File "/home/bhaskar/drone_ws/src/px4_rrt_avoidance/nodes/local_map_publisher.py", line 466, in publish_map
    pub.publish(msg)
  File "/opt/ros/noetic/lib/python3/dist-packages/rospy/topics.py", line 886, in publish
    raise ROSSerializationException(str(e))
rospy.exceptions.ROSSerializationException: field data[] must be an integer type

**local_LLC[1]: -6
global_LLC[1]: -0.5**
[ERROR] [1687372923.984120, 195.728000]: bad callback: <function separate_msg at 0x7fd5e72f9f70>
Traceback (most recent call last):
  File "/opt/ros/noetic/lib/python3/dist-packages/nav_msgs/msg/_OccupancyGrid.py", line 139, in serialize
    buff.write(struct.Struct(pattern).pack(*self.data))
struct.error: required argument is not an integer

During handling of the above exception, another exception occurred:

also here is the screenshot how i have planned mission in qgc:

My steps of execution is:

Im launching px4 by

roslaunch px4 mavros_posix_sitl.launch

Im launching px4 rrt avoidance by

roslaunch px4_rrt_avoidance iris_depth.launch

Im launching local_map_publisher.py by

rosrun px4_rrt_avoidance local_map_publisher.py

Im running Master_node.py by

rosrun px4_rrt_avoidance Master_node.py

Then im running mission by QGC by that start mission toggle
Requesting you that can you pleas help me with your repository which u are using currently also the px4 autopilot version u r using along with gazebo and iris camera setup Please.

@Lars-Ki Have you gone through the steps i have sent you of my execution?

Hey
Sorry for the late reply. I#ve managed to play the rosbag. It looks like there is data inside the trajectory/desired.
Unfortunately, I have not found the reason for your issue in local_map_publisher.
Can you print at the error line the value it trys to set and theactual value? This may be a bad idea but you can force it to be an integer in python.
I have also found this for path planing: Link It seems to be a different topic than trajactory/genertaed. Only try this when the local_map is generated. I do not believe it is an issue of ros melodic or other ROSs.
Looks like I am using the following versions:

mavros 1.6.0
px4: commit e79b3930f37b7463dbcd48882f3b4fdd938cf8ce
Author: PX4 BuildBot<EMAIL_ADDRESS>Date:   Sun Mar 21 12:39:12 2021 +0000

you can try to switch to those commits.
Did you find anything in the mean time?
FYI. I will be on a business trip next week and won't be able to try anything on Linux.

Hey Sorry for the late reply. I#ve managed to play the rosbag. It looks like there is data inside the trajectory/desired. Unfortunately, I have not found the reason for your issue in local_map_publisher.
Can you print at the error line the value it trys to set and theactual value? This may be a bad idea but you can force it to be an integer in python. I have also found this for path planing: Link It seems to be a different topic than trajactory/genertaed. Only try this when the local_map is generated. I do not believe it is an issue of ros melodic or other ROSs.
Looks like I am using the following versions:
* mavros 1.6.0

* px4: commit e79b3930f37b7463dbcd48882f3b4fdd938cf8ce
  Author: PX4 BuildBot [bot<EMAIL_ADDRESS>  Date:   Sun Mar 21 12:39:12 2021 +0000

you can try to switch to those commits. Did you find anything in the mean time?
FYI. I will be on a business trip next week and won't be able to try anything on Linux.

Was waiting for your reply Lars..Actually we have 2 laptops in one i have ros melodic and noetic in other the errors i shared you was from my noetic laptop i just tried to test it once on melodic and BOOM!! there was no error the local_map_publisher is also printing the same thing as your was. :)) i tried to test the same on my actual drone the 5 meter height is a issue bcoj 5 meter height is a big gap and how will i put any obstacle on that much height!!
Please help me to reduce that height also how to run on noetic??

Hi @Lars-Ki fortunetly i made it work on noetic today all the topic are working fine but the drone is not moving forward after takeoff. Occupancy grid is looking so weird.
Here are the screenshots:

As you can see here everything is working fine.

Hey.
Glad to here you made it work.
So why the voxels look so strange could be due to a sensor issue (your camera obstacle data is very noisy) or the drone position from PX4 is noisy.
Is the GPS good or other positioning system? Is the test outside?
It looks like you have changed the voxels size could that be true? Then maybe we have a parameter issue on my code. We would need to fix this so the local map is working fine again.
As for the 5 m I have checked my code I could not find any remains of this minimum altitude (except the >1m

Hey. Glad to here you made it work. So why the voxels look so strange could be due to a sensor issue (your camera obstacle data is very noisy) or the drone position from PX4 is noisy. Is the GPS good or other positioning system? Is the test outside? It looks like you have changed the voxels size could that be true? Then maybe we have a parameter issue on my code. We would need to fix this so the local map is working fine again.
As for the 5 m I have checked my code I could not find any remains of this minimum altitude (except >1m min altitude) for tests I would recommend a tree maybe for the beginning. Try flying slow and see if it starts deviating. Also make sure you do not loose ssh connect when you start the flight. If you loose it master mode will crash or stop. Try to find a command so it stays active even when you loose ssh connect.
Hope that helped for now.

What if i give /mavros/local_position/odom instead of pose?? will that work?

From what I have found on the internet the Odom topic is less reliable (covariance Matrix = 0, data coming directly from Sensor)
Have you tried it? How does it work?


⚠ haccp has degraded performance

In c61ff7d, haccp (https://www.haccp.or.kr) experienced degraded performance:

HTTP code: 200
Response time: 8138 ms

Resolved: haccp performance has improved in 8ed23bf.


fix: update pg-meta for column ordering

What kind of change does this PR introduce?
Bug fix #602
What is the current behavior?
table columns are not consistently ordered
What is the new behavior?
latest pg-meta sorts table columns by alphabetical order
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 61.812%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
3412

Relevant Lines:
5520

💛  - Coveralls


feat: extend pallas-applying API

Extend pallas-applying API with top-level phase-1 validation functions. Additionally, validation errors are refined to provide a clearer understanding of what they mean

I can check this, sure. It was related to

https://github.com/txpipe/laceanatomy/issues/14
https://github.com/txpipe/laceanatomy/issues/13
https://github.com/txpipe/laceanatomy/issues/12
https://github.com/txpipe/laceanatomy/issues/11


Unit test the Events package

There aren't any tests for the Events package, and it's fairly simple.
Routing doesn't need this because it's going to be refactored a lot in 0.5.2.

Sorted. Such a clean and simple package at the moment. :purple_heart:


GCN (global cycling network)

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2023.03.04 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
UK
Example URLs
https://plus.globalcyclingnetwork.com/watch/1397691
Provide a description that is worded well enough to be understood
Would love to be able to download videos from GCN offline. It requires a username and password
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
# yt-dlp https://plus.globalcyclingnetwork.com/watch/the-athertons-mountain-bikings-fastest-family --cookies --verbose
[generic] Extracting URL: https://plus.globalcyclingnetwork.com/watch/the-athertons-mountain-bikings-fastest-family
[generic] the-athertons-mountain-bikings-fastest-family: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] the-athertons-mountain-bikings-fastest-family: Extracting information
ERROR: Unsupported URL: https://plus.globalcyclingnetwork.com/watch/the-athertons-mountain-bikings-fastest-family

add verbose log with --cookies-from-browser or --cookies options being passed

Edited to add verbose log

You need to pass an argument with the --cookies option, e.g. --cookies cookies.txt
in the log you posted, yt-dlp interpreted --cookies --verbose as --verbose being the filename of your cookies file, and there was no verbose output (and no cookies were passed)

Oh ok. That makes sense.
Wouldn't have a clue how to pull the cookies from GCN though.

Ok,
I think I was able to figure the cookie thing out. So here's a verbose log (hopefully I've got it right)
yt-dlp https://plus.globalcyclingnetwork.com/watch/1397691 --cookies cookie.txt --verbose [debug] Command-line config: ['https://plus.globalcyclingnetwork.com/watch/1397691', '--cookies', 'cookie.txt', '--verbose'] [debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version<EMAIL_ADDRESS>[392389b7d] (pip) [debug] Python 3.10.4 (CPython x86_64 64bit) - Linux-<IP_ADDRESS>-microsoft-standard-WSL2-x86_64-with-glibc2.35 (OpenSSL 3.0.2 15 Mar 2022, glibc 2.35) [debug] exe versions: ffmpeg 4.4.2 (setts), ffprobe 4.4.2 [debug] Optional libraries: Cryptodome-3.18.0, brotli-1.0.9, certifi-2020.06.20, mutagen-1.46.0, secretstorage-3.3.1, sqlite3-2.6.0, websockets-11.0.3 [debug] Proxy map: {} [debug] Loaded 1786 extractors [generic] Extracting URL: https://plus.globalcyclingnetwork.com/watch/1397691 [generic] 1397691: Downloading webpage WARNING: [generic] Falling back on generic information extractor [generic] 1397691: Extracting information [debug] Looking for embeds ERROR: Unsupported URL: https://plus.globalcyclingnetwork.com/watch/1397691 Traceback (most recent call last):   File "/home/pete/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1518, in wrapper     return func(self, *args, **kwargs)   File "/home/pete/.local/lib/python3.10/site-packages/yt_dlp/YoutubeDL.py", line 1594, in __extract_info     ie_result = ie.extract(url)   File "/home/pete/.local/lib/python3.10/site-packages/yt_dlp/extractor/common.py", line 694, in extract     ie_result = self._real_extract(url)   File "/home/pete/.local/lib/python3.10/site-packages/yt_dlp/extractor/generic.py", line 2510, in _real_extract     raise UnsupportedError(url) yt_dlp.utils.UnsupportedError: Unsupported URL: https://plus.globalcyclingnetwork.com/watch/1397691

The trouble with GCN is I can skim the videos files through video downloader helper.
It gives various video only downloads and then lists about 10-15 audio streams, all of which are about 5 seconds long so manually downloading them all and then stitching them together isn't really an option but I just can't figure out a way to get them to automatically download them all and stitch them together themselves.

Sorry to reopen a dead issue, but GCN+ seems to now be DRM protected.

Sorry to reopen a dead issue, but GCN+ seems to now be DRM protected.

Poor timing too with the announcement of GCN+ ending in December too...
Anyone know if there's anything that can be fixed here? Or are we toast for downloading their films before it closes up?

We cannot support DRM content due to legal reasons

Sorry to reopen a dead issue, but GCN+ seems to now be DRM protected.

Poor timing too with the announcement of GCN+ ending in December...
Anyone know if there's anything that can be fixed here? Or are we toast for downloading their films before it closes up?

I suppose in that case it should be completely removed from the software?

I haven't tried it extensively (yet!), and don't know if it's safe to apply across other dplus channels, but I noticed my browser (Firefox) wasn't getting DRM content from GCN.
The streaming object in the response in my browser looks like:
{
        "cdn" : "akamai",
        "fallback" : false,
        "playbackProfile" : "h264-hls-ts-fhd-sdr-free-clear",
        "protection" : {
          "clearkeyEnabled" : false,
          "drmEnabled" : false,
          "schemes" : null
        },
        "provider" : "gps",
        "streamMode" : "VOD",
        "type" : "hls",
        "url" : "https://eurosport-vod.akamai.prod-live.h264.io/..."
      }

compared to this in yt-dlp's existing implementation:
{
        "cdn" : "akamai",
        "fallback" : false,
        "playbackProfile" : "h264-dash-fmp4-fhd-sdr-widevine-cenc",
        "protection" : {
          "clearkeyEnabled" : false,
          "drmEnabled" : true,
          "drmToken" : "[redacted]",
          "schemes" : {
            "widevine" : {
              "certificateUrl" : "https://discovery-eur.conax.cloud/widevine/certificates/conax",
              "licenseUrl" : "https://discovery-eur.conax.cloud/widevine/license"
            }
          }
        },
        "provider" : "gps",
        "streamMode" : "VOD",
        "type" : "dash",
        "url" : "https://eurosport-vod.akamai.prod-live.h264.io/..."
      }

Simply omitting the wisteriaProperties key from the request to playback/v3/videoPlaybackInfo can get yt-dlp to successfully pull down the video in 1080p. I don't think there's any meaningful difference between the results (hls vs dash). If it's safe to make the change, can someone figure out how to test it across other properties, so we can save GCN content before it's gone?
tldr: GCN content isn't (all?) DRM'd, at least not in my region, by omitting a key from the request.

Happy to report that works for me too @notjosh. Not sure if that counts as circumventing DRM, but it works!

It's what my browser does by default (for some reason - maybe some privacy settings?), so I can only assume it's condoned.

Since the issues around this mostly comes down to difficulty testing, an implementation that uses the new method and then falls back to the old one on error would be best imo. We can issue a warning on fallback to users and see if anyone reports it, effectively crowd-sourcing the testing. If no reports come in for a while, that code branch can be removed.

Not sure if that counts as circumventing DRM

No, it doesnt.

then falls back to the old one

the old method yields DRM-protected content 100% of the time though

(#7530, #7955)

Then why are these needs-testing?

I'm geo-blocked and/or don't have access to premium

The GCN+ service gets turned off in 12 days, so although this might be useful for now it wouldn’t be in a short time!It would be interesting to see if this also happens with other Discovery content though - perhaps someone with another D+ subscription service can check.On 7 Dec 2023, at 17:23, bashonly @.***> wrote:
I'm geo-blocked and/or don't have access to premium
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

I've created a plugin if anyone wants to help me test it: yt-dlp-GlobalCyclingNetworkPlusDRMWorkaround.
After installing it, make sure to include the argument when calling yt-dlp. For example, I can run the following successfully:
$ yt-dlp -f bestaudio+bestvideo --cookies-from-browser firefox --extractor-args 'globalcyclingnetworkplus:use_drm_workaround' https://plus.globalcyclingnetwork.com/watch/5210311
Extracting cookies from firefox
Extracted 634 cookies from firefox
[GlobalCyclingNetworkPlus+GlobalCyclingNetworkPlusDRMWorkaround] Extracting URL: https://plus.globalcyclingnetwork.com/watch/5210311
[GlobalCyclingNetworkPlus+GlobalCyclingNetworkPlusDRMWorkaround] 5210311: Downloading JSON metadata
[GlobalCyclingNetworkPlus+GlobalCyclingNetworkPlusDRMWorkaround] 5210311: Downloading JSON metadata
[GlobalCyclingNetworkPlus+GlobalCyclingNetworkPlusDRMWorkaround] 5210311: Downloading m3u8 information
[info] 5210311: Downloading 1 format(s): hls-audio_0-Default+hls-9005
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 597
[download] Destination: UNBOUND [5210311].fhls-audio_0-Default.mp4
[download] 100% of   54.63MiB in 00:00:43 at 1.25MiB/s
[hlsnative] Downloading m3u8 manifest
[hlsnative] Total fragments: 597
[download] Destination: UNBOUND [5210311].fhls-9005.mp4
[download] 100% of    3.29GiB in 00:02:47 at 20.09MiB/s
[Merger] Merging formats into "UNBOUND [5210311].mp4"
Deleting original file UNBOUND [5210311].fhls-9005.mp4 (pass -k to keep)
Deleting original file UNBOUND [5210311].fhls-audio_0-Default.mp4 (pass -k to keep)

$ ls -l ./UNBOUND\ \[5210311\].mp4
.rw-r--r--@ 3.5G user group 2023-12-07 16:05 ./'UNBOUND [5210311].mp4'

(...it's my first yt-dlp plugin, so let me know if there are any problems!)

Having some issues with this, still replying back with DRM protected
➜  gcn yt-dlp -f bestaudio+bestvideo --cookies-from-browser firefox --extractor-args 'globalcyclingnetworkplus:use_drm_workaround' https://plus.globalcyclingnetwork.com/watch/5210311
Extracting cookies from firefox
Extracted 47 cookies from firefox
[GlobalCyclingNetworkPlus] Extracting URL: https://plus.globalcyclingnetwork.com/watch/5210311
[GlobalCyclingNetworkPlus] 5210311: Downloading JSON metadata
[GlobalCyclingNetworkPlus] 5210311: Downloading JSON metadata
[GlobalCyclingNetworkPlus] 5210311: Downloading MPD manifest
ERROR: [GlobalCyclingNetworkPlus] 5210311: This video is DRM protected

Maybe a region issue (quite possibly user error as well)? I'm in US.


Merge 2-15 updates to live

OPS Build status updates of commit 15ea716:
:clock10: Preparing: average preparing time is 3 min(s) 17 sec(s)

OPS Build status updates of commit 15ea716:
:clock10: Incremental building: average incremental building time is 53 min(s) 48 sec(s)

OPS Build status updates of commit 15ea716:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

F1/gridlinewidthbottom-property-access-vbaac10-chm10535.md
:white_check_mark:Succeeded
View

F1/gridlinewidthbottom-property-access-vbaac10-chm11163.md
:white_check_mark:Succeeded
View

F1/gridlinewidthright-property-access-vbaac10-chm10534.md
:white_check_mark:Succeeded
View

F1/gridlinewidthright-property-access-vbaac10-chm11162.md
:white_check_mark:Succeeded
View

F1/gridlinewidthtop-property-access-vbaac10-chm10533.md
:white_check_mark:Succeeded
View

F1/gridlinewidthtop-property-access-vbaac10-chm11161.md
:white_check_mark:Succeeded
View

Language/Reference/User-Interface-Help/hex-function.md
:white_check_mark:Succeeded
View

access/Concepts/Miscellaneous/repaintobject-showallrecords-requery-and-refresh-action-method-comparison.md
:white_check_mark:Succeeded
View

api/Access.AcColorIndex.md
:white_check_mark:Succeeded
View

api/Access.CheckBox.GridlineWidthBottom.md
:white_check_mark:Succeeded
View

api/Access.CheckBox.GridlineWidthLeft.md
:white_check_mark:Succeeded
View

api/Access.CheckBox.GridlineWidthRight.md
:white_check_mark:Succeeded
View

api/Access.CheckBox.GridlineWidthTop.md
:white_check_mark:Succeeded
View

api/Access.ComboBox.GridlineWidthBottom.md
:white_check_mark:Succeeded
View

api/Access.ComboBox.GridlineWidthLeft.md
:white_check_mark:Succeeded
View

api/Access.ComboBox.GridlineWidthRight.md
:white_check_mark:Succeeded
View

api/Access.ComboBox.GridlineWidthTop.md
:white_check_mark:Succeeded
View

api/Access.CommandButton.GridlineWidthBottom.md
:white_check_mark:Succeeded
View

api/Access.CommandButton.GridlineWidthLeft.md
:white_check_mark:Succeeded
View

api/Access.CommandButton.GridlineWidthRight.md
:white_check_mark:Succeeded
View

api/Access.CommandButton.GridlineWidthTop.md
:white_check_mark:Succeeded
View

api/Access.Control.GridlineWidthBottom.md
:white_check_mark:Succeeded
View

api/Access.Control.GridlineWidthLeft.md
:white_check_mark:Succeeded
View

api/Access.Control.GridlineWidthRight.md
:white_check_mark:Succeeded
View

api/Access.Control.GridlineWidthTop.md
:white_check_mark:Succeeded
View

api/Access.CustomControl.GridlineWidthBottom.md
:white_check_mark:Succeeded
View

api/Access.CustomControl.GridlineWidthLeft.md
:white_check_mark:Succeeded
View

api/Access.CustomControl.GridlineWidthRight.md
:white_check_mark:Succeeded
View

api/Access.CustomControl.GridlineWidthTop.md
:white_check_mark:Succeeded
View

api/Access.DoCmd.SetMenuItem.md
:white_check_mark:Succeeded
View

api/Access.EmptyCell.GridlineWidthBottom.md
:white_check_mark:Succeeded
View

api/Access.EmptyCell.GridlineWidthLeft.md
:white_check_mark:Succeeded
View

api/Access.EmptyCell.GridlineWidthRight.md
:white_check_mark:Succeeded
View

api/Access.EmptyCell.GridlineWidthTop.md
:white_check_mark:Succeeded
View

api/Access.Image.GridlineWidthBottom.md
:white_check_mark:Succeeded
View

api/Access.Image.GridlineWidthLeft.md
:white_check_mark:Succeeded
View

api/Access.Image.GridlineWidthRight.md
:white_check_mark:Succeeded
View

api/Access.Image.GridlineWidthTop.md
:white_check_mark:Succeeded
View

api/Access.Label.GridlineWidthBottom.md
:white_check_mark:Succeeded
View

api/Access.Label.GridlineWidthLeft.md
:white_check_mark:Succeeded
View

api/Access.Label.GridlineWidthRight.md
:white_check_mark:Succeeded
View

api/Access.Label.GridlineWidthTop.md
:white_check_mark:Succeeded
View

api/Access.ListBox.GridlineWidthBottom.md
:white_check_mark:Succeeded
View

api/Access.ListBox.GridlineWidthLeft.md
:white_check_mark:Succeeded
View

api/Access.ListBox.GridlineWidthRight.md
:white_check_mark:Succeeded
View

api/Access.ListBox.GridlineWidthTop.md
:white_check_mark:Succeeded
View

api/Access.NavigationButton.GridlineWidthBottom.md
:white_check_mark:Succeeded
View

api/Access.NavigationButton.GridlineWidthLeft.md
:white_check_mark:Succeeded
View

api/Access.NavigationButton.GridlineWidthRight.md
:white_check_mark:Succeeded
View

api/Access.NavigationButton.GridlineWidthTop.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add pipe(1) to PlatformUtility

@swift-ci please smoke test

@swift-ci please smoke test

Hmm, I can't seem to trigger a please smoke test after force pushing an update to the branch @shahmishal

@swift-ci please smoke test


Arc Furnace will not smelt

I must be overlooking something. (Sorry, this is probably best for the forums, but I am unsure if there are Advanced Rocketry forums.)
I have tried iron/coal, sand, and now rutile ore, and, even though my arc furnace is powered nicely, and I can open the various GUIs, nothing happens, no matter how many hours I leave the game running.
Am I missing a step, is something misconfigured, or is this possibly a bug?
I am using Forge 1.11.2-<IP_ADDRESS>4, LibVulpes-1.11.2-0.2.5, and AdvancedRocketry-1.11.2-1.2.3
Thanks for any help!

Rolling back to LibVulpes 1.11.2-0.2.4 and AdvancedRocketry-1.11.2-1.2.1 seems to have fixed this.
Now on Forge 1.11.2-<IP_ADDRESS>6

I just tried downgrading and it didn't work. I think it might be a mod conflict.

matrix07012, are you sure BetterFps is the culprit? I am finding that the machines work intermittently, even with 0.2.4 and 1.2.1. Try destroying a block or two (one of the inputs or outputs seems to work), replacing it, and then seeing if the machine works.

might be related to #851?

Is this still a issue? Please comment if it is and i will reopen if if you are unable? We are closing old issues to see what is still relevant and needs to be fixed.


Report gzip content-encoding for vector.pbf response

This looks like a holdover from pre-gzip days.
@yhahn - can you give me a tip for where best to add a test for this? I've looked around middleware.test.js, source.test.js, and test-client.js but its opaque to me where the right place would be to query a source via url and assert on its content-encoding.

Note: without this fix downloading tiles in chrome would produce corrupt files:

:+1:

merging now, tests in followup #1240


Fix require dependency resolve

In my opinion, the this.resolve should use this.context, enabling relative require paths that use './' or '../' to be found correctly.
An example that makes use of this is here:
nwcutlib.lua-web

enabling relative require paths that use './' or '../' to be found correctly.

this is intentionally unsupported: they would be relative to the loader; not to the lua file.

they would be relative to the loader; not to the lua file.

This is not my experience, which is why I had to make the change.

This is not my experience. With this change, my requires are relative to the source file being loaded, and definitely are not relative to the loader.

That's even worse; as lua caches requires for use across all files. If you had:
./a.lua
require "./foo.js"

and somedir/b.lua
require "./foo.js"

then they'd be racing each other.

Thanks for your responses, and sorry for the confusion. I did not realize that these bundled sources were being cached by fengari using the relative resource names.
I probably need to use a different loader/bundling strategy.
Withdrawn.


feat: New truncate-heading prop for header

Description
Default heading wrapping behavior might not be applicable when used inside small containers. When new property is set, the heading is truncated with ellipsis instead.
When the heading is truncated some part of its information is lost (exception - screen-reader users). That means the feature can only be used when there is an alternative way to obtain it.
How has this been tested?
Screenshot tests

Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

It might be worthwhile to expand the screenshot testing of this property beyond just rendering headers.

It might be worthwhile to expand the screenshot testing of this property to more diverse use cases than just rendering standalone headers.

The feature is specifically introduced for dashboard and I agree it does make total sense to test it there as well. As for other possible use cases I'd hesitate. The problem with truncation is that it hides certain information and there must be a way to recover it. Otherwise the feature is not applicable.

The feature is specifically introduced for dashboard and I agree it does make total sense to test it there as well. As for other possible use cases I'd hesitate.

@pan-kot Once we release this it will be a public API on the header component that can be used anywhere, right? So, the intended use behind the API is somewhat irrelevant and what matters is where it could be used?

Closed due to a better mitigation found for board components.


fuseconfig.sh script missing from wildfly-camel distribution

We tell users that they can run fuseconfig.sh to enable the camel subsystem in their existing WildFly config files:
https://wildflyext.gitbooks.io/wildfly-camel/content/start/index.html
We can pull in the missing content from the fuse-patch distro bin directory.

I believe all of fuse-patch distro needs to be part of the wfc patch (for the project)

Does it though? We're only concerned with config file patching on the community branch.
The required WildFly modules are already part of the module tar.gz. All that's missing is the fuseconfig.sh script.

A model where foo contains bar is imho easier to maintain than a model where foo contains parts of bar. That we also add the patching functionality to the wfc distro does no harm.


vendor: use go mod

Just to summaries what's going here, this PR brings along a partial switch to go mod vendor for managing dependencies, but it doesn't introduce go.mod just yet. The resulting change to vendor/ is minimal.
Here is the plan for a few follow-up PRs:

Update Moby to use new SwarmKit
Remove most of replace directives from vendor.mod and get latest dependencies, as long as build doesn't break
Update etcd & grpc dependencies
Update Moby again
Move vendor.mod to go.mod

So make photos fails:
2021/12/11 19:01:31 File "google/protobuf/descriptor.proto" not found (looked in: [. vendor/github.com/gogo/protobuf /usr/local/include])

I wonder how can this be solved, ideally go mod vendor should really expose controls to what files are pruned.

I just now see your comment; is it because the directory in which descriptor.proto is located does not contain any .go files?

I just now see your comment; is it because the directory in which descriptor.proto is located does not contain any .go files?

Yes... and its intentional.

Another failure in unit tests:
--- FAIL: TestRaftLeaderDown (10.19s)
    require.go:794:
        	Error Trace:	testutils.go:97
        	            				raft_test.go:161
        	Error:      	Received unexpected error:
        	            	did not find a ready leader in member list
        	            	github.com/docker/swarmkit/manager/state/raft/testutils.WaitForCluster.func1
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/testutils/testutils.go:74
        	            	github.com/docker/swarmkit/testutils.PollFuncWithTimeout
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/testutils/poll.go:22
        	            	github.com/docker/swarmkit/testutils.PollFunc
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/testutils/poll.go:36
        	            	github.com/docker/swarmkit/manager/state/raft/testutils.WaitForCluster
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/testutils/testutils.go:60
        	            	github.com/docker/swarmkit/manager/state/raft_test.TestRaftLeaderDown
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/raft_test.go:161
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1259
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1581
        	            	polling failed
        	            	github.com/docker/swarmkit/testutils.PollFuncWithTimeout
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/testutils/poll.go:28
        	            	github.com/docker/swarmkit/testutils.PollFunc
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/testutils/poll.go:36
        	            	github.com/docker/swarmkit/manager/state/raft/testutils.WaitForCluster
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/testutils/testutils.go:60
        	            	github.com/docker/swarmkit/manager/state/raft_test.TestRaftLeaderDown
        	            		/home/circleci/.go_workspace/src/github.com/docker/swarmkit/manager/state/raft/raft_test.go:161
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1259
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1581
        	Test:       	TestRaftLeaderDown
2021-12-13 20:04:47.476352 I | wal: segmented wal file /tmpfs/TestGCWAL1818517640/wal-v3-encrypted/0000000000000001-000000000000000d.wal is created
2021-12-13 20:04:47.485782 I | wal: segmented wal file /tmpfs/TestGCWAL4003008272/wal-v3-encrypted/0000000000000001-000000000000000d.wal is created
2021-12-13 20:04:47.498093 I | wal: segmented wal file /tmpfs/TestGCWAL3101151943/wal-v3-encrypted/0000000000000001-000000000000000d.wal is created
2021-12-13 20:04:48.191302 I | wal: segmented wal file /tmpfs/TestGCWAL3777704426/wal-v3-encrypted/0000000000000001-000000000000000d.wal is created
2021-12-13 20:04:48.198998 I | wal: segmented wal file /tmpfs/TestGCWAL4046463290/wal-v3-encrypted/0000000000000001-000000000000000d.wal is created
2021-12-13 20:04:48.204374 I | wal: segmented wal file /tmpfs/TestGCWAL328303241/wal-v3-encrypted/0000000000000001-000000000000000d.wal is created
FAIL
coverage: 69.9% of statements
FAIL	github.com/docker/swarmkit/manager/state/raft	34.342s

@dperny this is ready to merge now!

Looks good so far, I'll try to remove a few more of the replace directives...


feat(cli): add get-nonce cli commands

Add get-user-first-nonce to cli
Description
Adds a function to the aligned-cli to retrieve the users nonce from ethereum. This is useful in scenarios where you need to replace your proofs with higher fees. For that, you'll need the first proof's nonce corresponding to the value in the BatcherPaymentService contract.
Adds a function to the aligned-cli to retrieve the amount of proofs a user has in the batcher queue
To Test:

Setup a local devnet.

Get the nonce from the Batcher:

cargo run --release -- get-user-nonce --user_addr <YOUR_WALLET_ADDRESS>

You should see it is <BURST_SIZE>

Bump the fees using the nonce you got from the ethereum:

cargo run --release -- submit  --proving_system Risc0 --proof ../../scripts/test_files/risc_zero/fibonacci_proof_generator/risc_zero_fibonacci.proof  --vm_program ../../scripts/test_files/risc_zero/fibonacci_proof_generator/fibonacci_id.bin --public_input ../../scripts/test_files/risc_zero/fibonacci_proof_generator/risc_zero_fibonacci.pub --repetitions 3 --keystore_path <YOUR_KEYSTORE_PATH> --network devnet  --max_fee<PHONE_NUMBER>000  --nonce "0"

Type of change
Please delete options that are not relevant.

[x] New feature

Checklist

[ ] “Hotfix” to testnet, everything else to staging
[ ] Linked to Github Issue
[ ] This change depends on code or research by an external entity

[ ] Acknowledgements were updated to give credit

[ ] Unit tests added
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

[ ] This change is an Optimization

[ ] Benchmarks added/run

[ ] Has a known issue

Link to the open issue addressing it

[ ] If your PR changes the Operator compatibility (Ex: Upgrade prover versions)

[ ] This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
[ ] This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

Got some unexpected behavior while testing it locally that should be discussed offline

This error was related to the usage of non paying addresses. It works as expected for paying addresses


llms/anthropic: adds full support for messages api

PR Checklist

[x] Read the Contributing documentation.
[x] Read the Code of conduct documentation.
[x] Name your Pull Request title clearly, concisely, and prefixed with the name of the primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. Fixes #123).
[ ] Describes the source of new concepts.
[x] References existing implementations as appropriate.
[ ] Contains test coverage for new functions.
[x] Passes all golangci-lint checks.

This adds full support for the new messages API including streaming.
It backwards compatible with client option flag for using message api.
It also updates the default model to 1.3 as 1.0 isn't supported by either completions or messages API.
Closes #695

I updated this to remove the fatals from the stream processing. I think it's better to pass the errors back instead of crashing and just letting the user handle them. This is different than the other LLM implementations like OpenAI which I used as a guideline.


Update commit message

Mirror changes from here. Also replace {{cask_file}} with actual cask name during commit.

Thank you for the contribution. It needed some fixes, so they were made in 8f7cfdf74a3f76d93cb002125517d1407b025c16. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

{{cask_file}} is not supposed to be changed, it’s simply a guideline. I don’t want to encourage people to replace that part of the checklist as it’s boring and unnecessary for them.


Clarify mixed precision training support

Change the wording to avoid confusion. Mixed precision ensures both higher arithmetic throughput and numerical stability, not exactly synonymous to pure half-precision/FP16 training. Also add mentioning of tensor cores since older generation GPUs without tensor cores don't support true mixed precision training.

Thanks :)


peformance test

Hello:
i use the current master code and test it. Below is my test code :
//
// Created by root on 3/21/17.
//
#include "message_queue.h"
#include <stdint.h>
#include <pthread.h>
#include <sys/time.h>
#include
#include
//#include <boost/thread>
struct my_message{
int a;
};
static uint64_t loopnum=1000L * 1000L * 300;
struct message_queue queue;
static uint64_t worker_counter=0;
void * worker(void *){
while (1)
{
    struct my_message *message =(struct my_message *)message_queue_read(&queue);
    message_queue_message_free(&queue, message);
    ++worker_counter;
}

}
int main(int argc ,char *argv[])
{
message_queue_init(&queue, 512, 1024*8);

struct my_message *message ;
pthread_t  p1;
pthread_create(&p1,NULL,worker,NULL);

uint64_t counter=0;
struct timeval start_time, end_time;
gettimeofday(&start_time, NULL);
while (counter<loopnum)
{
    message=(struct my_message *)message_queue_message_alloc_blocking(&queue);
    message_queue_write(&queue, message);
    ++counter;
}

while (worker_counter <loopnum)
{
    std::this_thread::yield();
}
gettimeofday(&end_time, NULL);
double start, end;
start = start_time.tv_sec + ((double) start_time.tv_usec / 1000000);
end = end_time.tv_sec + ((double) end_time.tv_usec / 1000000);

std::cout.precision(15);
std::cout << "1P-1EP-PIPELINE performance: ";
std::cout << (loopnum * 1.0) / (end - start)
 << " ops/secs" << std::endl;

}
1P-1EP-PIPELINE performance: 2975702.29264578 ops/secs
1P-1EP-PIPELINE performance: 2772546.52341586 ops/secs
1P-1EP-PIPELINE performance: 2849838.09520119 ops/secs
the result is about 2,800,000 ops;
my machine cpu is “model name	: Intel(R) Xeon(R) CPU E5-2643 v3 @ 3.40GHz”。
i don't understand why your ops arrived 6,500,000.

Then i use release version v0.1.1 for testing ,the result is about:
1P-1EP-PIPELINE performance: 3798728.56695137 ops/secs
1P-1EP-PIPELINE performance: 4095063.0676993 ops/secs

That is… interesting. I ran your code locally, on a Mid 2009 MacBook Pro (Apple LLVM version 8.0.0 (clang-8<IP_ADDRESS>), -O2), and got this output:
1P-1EP-PIPELINE performance: 8684122.91332518 ops/secs

The old version was faster when only using two threads, but scaled catastrophically poorly.
Can you provide details for the compiler, flags, and environment you're using? My 7-year-old mobile Core 2 Duo should not be outrunning your modernish Xeon.

my OS:CentOS Linux (3.10.0-327.36.3.el7.x86_64) 7 (Core)
complier:c++ (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4)/cc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4)
flags: -std=c++11  -g -O0
I don't use "-O2" , because i meet one problem, but i guess that it does not affect the results.
The problem is "
while (worker_counter <loopnum)
{
std::this_thread::yield();
}
" ， it meet  "http://stackoverflow.com/questions/28631378/function-optimized-to-infinite-loop-at-gcc-o2" . I change to "
int a;
while (worker_counter <loopnum)
{
++a;
std::this_thread::yield();
}
"
The result is the same to before .
Then i remove "-g". The old version result is :1P-1EP-PIPELINE performance: 5893060.64424721 ops/secs.
But I still did not achieve your effect. Is it because the compiler is different? Do you have any idea?

This code is less sensitive to optimization options than I expected—I still see better than 7,000,000 messages/second at -O0. Though the big overhead is atomic operations on two counters that are both accessed by all readers and writers, so I should have expected that. Even cheap synchronization is expensive.
But that means the compiler shouldn't hurt too much even if it's terrible, since a couple single instructions are the bulk of the work. Though I can try GCC 4.8. Unfortunately I can't try anything in the same class of CPU—I tested on a MacBook Pro from 2009 because that's my only reasonable machine at all. But it's also a non-hyperthreaded dual core with only two layers of cache—the L2 being shared. So writes from one core only force an L1 cache miss for the other one when reading.
Is this running on dedicated hardware? That's the only really obvious thing that comes to mind. I wouldn't expect it to matter much if it runs in a VM on an otherwise idle host, but if the host has other work going on that could dramatically affect results.

Incredible！It seems that I need to go to a MacBook test.

Or I need to find a way to test on a fancy Xeon. 2.8 million operations/sec is unexpected. It's about comparable to my Athlon X2 back when it worked, and as I mentioned about comparable to a Raspberry Pi 3—which while surprisingly decent for a $35 board that runs off of USB, is still a $35 single board computer.
That's just not right. If it's something I can fix, I should fix it.


Plugin card - plugin name

Hide word "Homebridge" from plugin name (only in plugin card title). Every plugin name starts with "Homebridge"...

What if it is a scoped plugin?

@donavanbecker
This change only has an impact on the title displayed on the card.
Currently, it works like this:
If it is filled displayName it displays it. If there is no displayName, it checks the name. Here if it starts with @ it removes everything until the first /. I don't change anything about it - I just hide the Homebridge word and only on the list of plugins - in plugin info and everywhere else it stays as it is.

@mkz212, I reverted this because of this:


getting ng-model as gregorian datetime

Hi
I searched all around for angularJS datetime (Jalali/Gregorian)  for last 8 months.Finally, I found  "ADM-dateTimePicker".
I want to special thanks to everyone who involved in. It's perfect and almost covered all of my needs, simply.
I know you probability, considered for next publishes. But let me suggest:
It would be nice if there was an option to allowing use ng-model just as Gregorian or Jalali.
Thanks.
Morteza

Hi,
Thanks Morteza, I'm really glad to hear that.
You mean the first solution of my answer to issue number #18 ?


python3Packages.pyfronius: 0.6.3 -> 0.7.0

Motivation for this change
Update to latest upstream release 0.7.0
Change log: https://github.com/nielstron/pyfronius/releases/tag/release-0.7.0
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 138757 run on x86_64-linux 1

2 packages built:

python38Packages.pyfronius
python39Packages.pyfronius


Bookstore: Add reducers and actions

Hi Code Reviewer🙋♂ I followed the requirements below:
✔ Open separate folders for separate files ( Books and Categories )
✔ Use reducers in Books and Categories files
✔ Use Actions in Books and Categories files
✔Export Actions and Reducers
✔ Use store in configureStore file and import all actions and reducer functions
Happy Reviewing🐱👤

Thanks @BrianSammit


kasantest: Add some tests for legitimate and illegitimate operations of memory APIs

Summary

By printing the results, we can know which libc memory APIs or illegal memory operation detectionin the current system support kasan check; for examples:
KASan Test: heap underflow -> PASS
KASan Test: heap overflow -> PASS
KASan Test: heap use after free -> PASS
KASan Test: heap invalid free -> PASS
KASan Test: heap double free -> PASS
KASan Test: heap poison -> PASS
KASan Test: heap unpoison -> PASS
KASan Test: heap illegal memchr -> PASS
KASan Test: heap illegal memcpy -> PASS
KASan Test: heap illegal memcmp -> PASS
KASan Test: heap illegal memmove -> PASS
KASan Test: heap illegal memset -> PASS
KASan Test: heap illegal strcmp -> PASS
KASan Test: heap illegal strcpy -> PASS
KASan Test: heap illegal strlen -> FAIL
KASan Test: heap illegal strncpy -> FAIL
KASan Test: heap illegal strchr -> PASS
KASan Test: heap illegal strncmp -> PASS
KASan Test: heap illegal strnlen -> FAIL
KASan Test: heap illegal strrchr -> PASS
KASan Test: heap legal memchr -> PASS
KASan Test: heap legal memcpy -> PASS
KASan Test: heap legal memcmp -> PASS
KASan Test: heap legal memmove -> PASS
KASan Test: heap legal memset -> PASS
KASan Test: heap legal strcmp -> PASS
KASan Test: heap legal strlen -> PASS
KASan Test: heap legal strlen -> PASS
KASan Test: heap legal strncpy -> PASS
KASan Test: heap legal strchr -> PASS
KASan Test: heap legal strncmp -> PASS
KASan Test: heap legal strnlen -> PASS
KASan Test: heap legal strrchr -> PASS
KASan Test: globals underflow -> PASS
KASan Test: globals overflow -> PASS

Impact
None
Testing
Please set CONFIG_TESTING_KASAN to run this test, and open CONFIG_MM_KASAN

[Experimental Bot, please feedback here]
The PR summary is very difficult to understand without context. Here's a breakdown of why this PR summary doesn't meet NuttX requirements and how to improve it:
Problems:

Unclear Purpose: The summary primarily focuses on the test results rather than the change itself. What was changed to achieve these results?
Missing Key Information:

Why? What problem does this change solve? Why is knowing which APIs support KASan important?
What? What code was modified to print these results? Was a new testing framework added?
How?  How does the code now determine and print which APIs support KASan?

Assumes Knowledge:  It assumes the reviewer knows what KASan is and why these tests are important.

How to Improve:

Start with the "Why": Begin by explaining the motivation behind the change. For example:

"This PR enhances KASan testing by providing a clear overview of supported libc memory APIs."
"To improve KASan diagnostics, this change introduces a mechanism to identify and report which memory APIs are effectively monitored."

Describe the Change: Clearly state what was modified:

"Added a new test suite that systematically exercises KASan instrumentation for different libc memory APIs."
"Modified the existing KASan test framework to print the results of each API test."

Explain the "How":  Provide a concise explanation of the technical implementation:

"The test suite iterates through a list of memory APIs, triggering potential KASan violations for each one. Results are then printed to the console."

Contextualize Test Results: Instead of just listing results, connect them to the change:

"With this change, we can now confirm that most libc memory APIs are correctly monitored by KASan, as shown in the test output below."

Example of an Improved Summary:
"This PR improves KASan diagnostics by introducing a mechanism to identify and report which libc memory APIs are effectively monitored. It adds a new test suite that systematically triggers potential KASan violations for each API and then prints the results. This allows developers to quickly identify any gaps in KASan's coverage. Initial testing confirms that the majority of libc memory APIs are correctly instrumented by KASan."
Addressing other sections:

Impact: While you state "None," this seems unlikely. Consider:

Does this add new configuration options?
Does it increase the size of the NuttX build (even slightly)?
Does it affect execution time of tests or other parts of NuttX?

Testing:

Specify the OS, CPU, compiler, and versions used for your build host.
Provide the architecture, board, and configuration used for your target.
Instead of full logs, include relevant snippets that clearly show the changes made by your PR.

By providing a clear, concise, and informative PR summary, you significantly increase the chances of your contribution being reviewed and merged quickly.


week-1 IOC RNAseq

Some global setting changes are introduced in mkdocs.yml

Even If I did not totally finished the week 1, I am merging this PR, to show advances and serve as example for @Ning-L and @bellenger-l in the case of the R-IOC


Datavec debugging

Datavec needs better debugging facilities for understanding why a pipeline fails.
Right now when running on a spark cluster, it's hard to envision the steps a transform goes through and why particular kinds of edge cases in data pipelines occur.
Datavec should help us interpret failures in data pipelines by adding logging for edge cases. This is similar to what streamsets does. It wraps exceptions as errors and outputs the stack traces to a GUI.
Something that could also help us is error propagation and handling.

https://github.com/deeplearning4j/deeplearning4j/issues/5180