Install and Deploy using Docker fails due to Glide dependency

Golang dependencies are required for compiling the services.
Glide must be installed to pull dependencies.
I'd just update the README and add Glide as pre-requisite.
Thanks,
Antonio

@mhall119 attention.  Michael - is this something you can address when you rework the READMe page?  Thanks

Instead of having this duplicated in the README and in the docs, can we shorten the README to be just a "Quick Start" running the existing docker images, and then point to the docs for instructions on building and running your own?


The plot of RNA velocity has no arrows

Hi,
I'm having another problem when plotting RNA velocity.
The following is my command:
cellDancer_df=cd.compute_cell_velocity(cellDancer_df=cellDancer_df, projection_neighbor_choice='gene', expression_scale='power10', projection_neighbor_size=5, speed_up=(100,100))
fig, ax = plt.subplots(figsize=(10,10))
cdplt.scatter_cell(ax,
                   cellDancer_df,
                   colors=color_dict,
                   alpha=0.5,
                   s=30,
                   velocity=True,
                   legend='on',
                   min_mass=15,
                   arrow_grid=(20,20),
                   )
ax.axis('off')
plt.show()

This is my plot of RNA velocity:

We can see the plot has no arrows. So I checked the velocity1 values of cellDancer_df, and I found some data rows(3268 rows × 17 columns) have values, the following are my data without NaN:

Can you tell me how to adjust the parameters to get the arrows in the RNA velocity plot?

try
projection_neighbor_choice='embedding',

Thanks for your reply! I used this command
cellDancer_df=cd.compute_cell_velocity(cellDancer_df=cellDancer_df, projection_neighbor_choice='embedding', expression_scale='power10', projection_neighbor_size=5, speed_up=(100,100))
but the plot I got still has no arrows：

Hello zcaiwei, thank you for reaching out!
Is it possible for you to try to decrease the parameter min_mass when plotting? If you have any other questions, please feel free to contact us.

min_mass (optional, float (default: 2)) – Filter by using the isotropic gaussian kernel to display the arrow on grids. The lower the min_mass, the more arrows.

Hello zcaiwei, thank you for reaching out! Is it possible for you to try to decrease the parameter min_mass when plotting? If you have any other questions, please feel free to contact us.

min_mass (optional, float (default: 2)) – Filter by using the isotropic gaussian kernel to display the arrow on grids. The lower the min_mass, the more arrows.

Thanks for your reply! I tried to lower the parameter min_ mass, for example, I set 2, 1, 0.1, 0.01, 0.001, but there are still no arrows in the cell velocity plot. Can you tell me what's wrong?

Hello, could you change it to 0 and see what happens? Thank you!


[Question] Why pipeline network is too slow

Steps to reproduce (least amount of steps as possible):
1 - I've created a cluster for CI/CD and I've installed a Sonatype Nexus from helm to manage my artifacts.
2 - I'm using maven to manage my project dependencies.
3 - I configured a pipeline in another cluster with a step to build my artifact and generate the Docker image.
4 - My script does a "mvn clean install" command.
When the pipeline is running, the artifact download gets stuck in a random artifact.
Progress (3): 1.0/3.4 MB | 0.4/1.9 MB | 72 kB
Progress (3): 1.0/3.4 MB | 0.4/1.9 MB | 72 kB
Progress (3): 1.0/3.4 MB | 0.4/1.9 MB | 72 kB

Downloaded from Nexus: http://my-nexus/repository/b2b-group/org/springframework/security/spring-security-crypto/5.0.11.RELEASE/spring-security-crypto-5.0.11.RELEASE.jar (72 kB at 619 kB/s)
02:10:13 Progress (2): 1.0/3.4 MB | 0.4/1.9 MB

Downloading from Nexus: http://my-nexus/repository/b2b-group/io/github/openfeign/feign-slf4j/9.5.1/feign-slf4j-9.5.1.jar

Obs.: The artifact download only gets stuck inside the pipeline.
If I execute the same command inside an arbitrary  POD, all the downloads work fine.
My question is:
How can I troubleshoot this issue?  I do not even wonder where to start.
Additional informations:
My pipeline yaml:
stages:
- name: Create the artifact
  steps:
  - runScriptConfig:
      image: maven:3.5.2-jdk-8
      shellScript: mvn -T 1C clean install -DskipUTs -DskipITs
- name: Build and publish the image
  steps:
  - publishImageConfig:
      dockerfilePath: ./Dockerfile
      buildContext: .
      tag: account/app:${CICD_GIT_TAG}
      pushRemote: true
      registry: index.docker.io
- name: Deploy to environment
  steps:
  - applyYamlConfig:
      path: ./k8s.yaml
timeout: 60

The runScript stuck:

我也遇到了相同的问题

you can try to package a local repository into your maven image

same issue

Same here. Builds are nondeterministically get stuck while downloading stuff. A few attempts have been succeeded.


Added GetStatement method and some naming corrections

Added handler for the GetStatement method
Corrected variable name

@KarimovMurodilla rahmat pull request uchun :)

@KarimovMurodilla rahmat pull request uchun :)

Yordamim tekganidan hursandman ))


Frontend: Basic van location tracking

Will add real icons and colors later

@shanecranor @ezrichards Please review


Fix conditional match to use typeof

We're missing a typeof in our conditional to check if something needs to be redirected.

Thanks @nickcolley @colinrotherham @joelanman for spotting and fixing this.


fix(partners): update styles to center carousel

https://openforge.teamwork.com/#/tasks/17495247

QA Passes


Collision with tracked plane?

Hiya, been banging my head on the table for a few days trying to figure out how to get collision working on the tracked plane. Actors I spawn on the plane have collision but the plane itself does not. The line trace finds the plane just fine, and the procedural mesh says collision is enabled, but objects with physics enabled pass right through, like projectiles.

This is more like a general Unreal question. I wonder if you can get a simple procedural mesh working with physics simulation in Unreal Editor without ARCore enabled?

LineTraceTrackedObject


Cannot run zero-shot-actions

Hi Askshita,
I cannot run the task of zero-shot-actions. Some configurations are not clear in the codes. Fo example, opt.zsl_dec and opt.use_mult_rep are not defined in config.py. And, I am confused on these two files: classifier.py and classifier_entropy.py. Some variables are not defined as well. Can you check and update this repo?
Many thanks.

Hello @kaiqiangh
Thank you for letting me know the errors. I have updated the zero-shot actions files. Let me know if the error persists.

Thanks for your updates!
It solves the major errors, but I still get one more error.
for val_gzsl() in classifier_entropy.py file, the error comes from the codes below:
seen_mask = torch.Tensor(np.array(entropy)) < thresh
Error: RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!
I am running your codes in Colab. I am not sure the variable of "entropy" would be computed in CPU or GPU. It seems like "entropy" should be ran in cpu, but why this variable was put in gpu? I also tried to modify codes by:
seen_mask = torch.Tensor(np.array(entropy), device=device=torch.device('cpu')) < thresh
It does not work as well. Anu tips? Thanks!

Also, the same error comes from the codes below (in the same file)
acc_per_class += torch.sum((test_label[idx] == predicted_label[idx])*mask[idx]) / torch.sum(idx)

Hello @kaiqiangh, Did you made any other GPU related changes in the code?

Hi,
No, I did not change anything. I just used the updated codes by you. I am running it in Colab. It may be a reason

Hi @kaiqiangh,
If your code is fully on GPU even while running on colab you shouldn't face this type of issue. Let me know if the issue still persists I can have a look at your colab notebbok.
Regards,
Akshita

Hi @kaiqiangh,
If your code is fully on GPU even while running on colab you shouldn't face this type of issue. Let me know if the issue still persists I can have a look at your colab notebbok.
Regards,
Akshita

Thanks for your reply. Sorry to check this message so late.
Yes, I am running in Colab with GPU setting, but got the error below
File "/content/gzsl/zero-shot-actions/classifier_entropy.py", line 195, in compute_per_class_acc_gzsl     acc_per_class += torch.sum((test_label[idx] == predicted_label[idx])*mask[idx]) / torch.sum(idx) RuntimeError: Expected all tensors to be on the same device, but found at least two devices, cuda:0 and cpu!
Could you please have a look at it? Thanks.

By the way, this error only occurred when enabling "gzsl_od". (It works fine when enabling "zsl"). I think the problem is only about some calculations for variables in the file of "classifier_entropy.py"

Hi @kaiqiangh. Can you share your colab notebook link. So that I look clearly at what is happening?

Thanks. It has been solved. Just put a variable to be computed on CPU, then it works.


Only create local tracks if component is active

Avoid creating a local audio or video track (webcam/microphone) if the
component is not active. Instead leave the Track property as NULL.

Rebased, handled more corner cases, and added a bunch of Unity tests to validate all of that. Can you please re-review?


optimize: remove use connPool.

Ⅰ. Describe what this PR did
remove use connPool, Because apache object-pool is already used.

Codecov Report

Merging #2530 into develop will increase coverage by 0.11%.
The diff coverage is 16.66%.

@@              Coverage Diff              @@
##             develop    #2530      +/-   ##
=============================================
+ Coverage      50.94%   51.06%   +0.11%
+ Complexity      2763     2762       -1
=============================================
  Files            551      550       -1
  Lines          17569    17524      -45
  Branches        2063     2062       -1
=============================================
- Hits            8950     8948       -2
+ Misses          7775     7733      -42
+ Partials         844      843       -1

Impacted Files
Coverage Δ
Complexity Δ

...ava/io/seata/core/rpc/netty/NettyClientConfig.java
45.31% <ø> (-1.66%)
22.00 <0.00> (-1.00)

...va/io/seata/core/rpc/netty/RpcClientBootstrap.java
41.09% <16.66%> (+7.38%)
6.00 <0.00> (ø)


403 forbidden

I ran into this error today trying to use this library with DigitalOCean Spaces.
error: Uncaught (in promise) S3Error: Failed to put object: 403 Forbidden
My code as below
import { S3, S3Bucket } from<EMAIL_ADDRESS>
const s3 = new S3({
    accessKeyID: cfg.key,
    secretKey: cfg.secret,
    region: 'us-east-1',
    endpointURL: 'nyc3.digitaloceanspaces.com',
});

const bucket = s3.getBucket('myspace');

const fileName = '/tmp/about.json';
const text = await Deno.readTextFile(fileName);

const result = await bucket.putObject('about.json', text, {
    contentType: "application/json",
    acl: "public-read"
});

I've enabled CORS, set headers to '*' , enable all methods etc. I don't have issue accessing Spaces, just this API. Thanks.

I also got this error. I ended up being able to bundle the browser/es6 code produced by skypack for the actual aws s3 package. Here's the code and process: https://gist.github.com/josephrocca/443634eda6df30b1950a8fba3c942ecf
Maybe there's an easier way... I wasn't able to get npm:@aws-sdk/client-s3 working due to this: https://github.com/denoland/deno_std/issues/2557


Removed src from npmignore (so we can import it with browserify etc)

Your can import lib/htmlhint.js

yeah but that's not the nice way to do it!

Why must import the src?


Reporting a vulnerability

Hello!
I hope you are doing well!
We are a security research team. Our tool automatically detected a vulnerability in this repository. We want to disclose it responsibly.  GitHub has a feature called Private vulnerability reporting, which enables security research to privately disclose a vulnerability. Unfortunately, it is not enabled for this repository.
Can you enable it, so that we can report it?
Thanks in advance!
PS: you can read about how to enable private vulnerability reporting here: https://docs.github.com/en/code-security/security-advisories/repository-security-advisories/configuring-private-vulnerability-reporting-for-a-repository

Hi @igibek,
Thanks for reaching out, we will forward this request to our security team.
Meantime please report the security vulnerabilities<EMAIL_ADDRESS>More information on security vulnerability reporting can be found at https://wso2.com/security/

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


HTML formatting in documentation of sap.ui.table.Column.html.getFilterValue()

First of all, I'm going to apologize for this issue, because it's probably wrong from all sides,  but if it's resolved it's helpful in a way.
Recently I stumbled into a very nice tool called tern-openui5. Tern is a plugin for various editor for things such as code-completion. tern-openui5 is a plugin for tern, that teaches tern the openui5 syntax. I'm using tern/tern-openui5 in atom to help me code openui5 applications. The code completion is truely wonderful and god-given.
Tern-openui5 relies on a crawler, that crawls the API documentation site. With the documentation if finds there, it builds up a rule-database for tern. This crawler works very quick and almost perfect. Except, it can't handle illegal html very well.
Time to get to the point. The issue is that the https://openui5.hana.ondemand.com/docs/api/symbols/sap.ui.table.Column.html#getFilterValue section has documentation containing a couple of greater than and less than signs that haven't been encoded to > and < html entities. Most browsers will probably still display them correctly, but this crawler isn't able to process it.
I'm sure that this probably has the very lowest of lowest priorities, but if you're able to fix the doc-generator in a way that it encodes these html entities according to html spec, that would be totally awesome!

Hi,
I see that < is already encoded as its entity name < do you mean it should be encoded as entity number <
Regards,
Cahit

Hi Cahit,
Thanks for looking into this. In particular it's the section: as shown here: > 50 < 100 >= 150 <= 200 = 250 != 300 in which the > and < are not properly encoded as > and <. They don't necessarily need to be numeric, but at this moment they're not encoded at all.
Best regards,
Jan Penninkhof

Hi Jan, I am confusing here,
The following is the outerHTML of the section that you've mentioned. Everything seems properly encoded to me.
<p> Specifies the value of the filter as string (will be converted into the proper data type). It is possible to provide a filterOperator as string, as shown here: > 50 < 100 >= 150 <= 200 = 250 != 300 something ends with something* starts with something* contains some..thing between 50..100 between </p>

Hi Jan,
thanks for your reply now I see what you mean.
Normally this section https://github.com/SAP/openui5/blob/master/src/sap.ui.table/src/sap/ui/table/Column.js#L102-L112
should be inserted between <pre> .. </pre> tags. Would this be OK for tern-openui5 or is it really necessary to encode it?
Regards,
Cahit

Hi Cahit.
That's weird, if I grab the page from the internet, I really see the unencoded characters. Please have a look at the image below for an example:

curl https://openui5.hana.ondemand.com/docs/api/symbols/sap.ui.table.Column.html | grep -o 'as.\{0,100\}300'
It's not so much tern-openui5 that trips over it, but cheerio, which is the parser used by tern-openui5. It seems it can't deal with the unencoded < and > signs. As far as I can see, the enclosing tags are irrelevant.

A very similar issue seems to exist in the docs for sap.ui.core.HTML on line 67:
...

* (e.g. setContent("<div/><div/>")), but this is not a guaranteed feature. The accepted content

...

It would be awesome if you could have a look at this!

Hi Timo,
thanks for pointing this last one out. You're right and I'll fix it asap.
cw


control@1 stack overflow

when i open control@1, i get a stack overflow.
i´m using the newest versions of max and ppooll.

after opening again, i got this:

does anyone have an idea, what to do?

I've also had this issue; it occurs on both Max 8.5.3 and 8.5.4 on my machine (Mac Intel)

attempted to fix this in the most recent push to main.  was not able to recreate but there were some stale params in the "routing" window.  please try this out and lmk if it's fixed or not

thanks for your message, but:
what shall i do?

Am 25.04.2023 um 18:34 schrieb the_steech @.***>:
attempted to fix this in the most recent push to main. was not able to recreate but there were some stale params in the "routing" window. please try this out and lmk if it's fixed or not
—
Reply to this email directly, view it on GitHub https://github.com/ppooll-dev/ppooll/issues/101#issuecomment-1522093140, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7CBGXZZOKWE756SYINFADDXC74HTANCNFSM6AAAAAAW3OKVMQ.
You are receiving this because you authored the thread.

@xelandero please delete your current ppooll on your computer and redownload and install to get the changes

It´s working now - i was badly waiting for this - you are my hero :-)

Am 25.04.2023 um 19:49 schrieb the_steech @.***>:
@xelandero https://github.com/xelandero please delete your current ppooll on your computer and redownload and install to get the changes
—
Reply to this email directly, view it on GitHub https://github.com/ppooll-dev/ppooll/issues/101#issuecomment-1522182030, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7CBGX2MUTDU2KW2LS7SJ43XDAFCHANCNFSM6AAAAAAW3OKVMQ.
You are receiving this because you were mentioned.

amazing!! thanks for bringing this to my attention 🙂


[WIP] Runtime container configurations are now set through plugin_manifest rather than vent.template

Codecov Report

Merging #642 into master will decrease coverage by 0.93%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
- Coverage   89.09%   88.16%   -0.94%
==========================================
  Files          47       47
  Lines        3357     3362       +5
==========================================
- Hits         2991     2964      -27
- Misses        366      398      +32

Impacted Files
Coverage Δ

vent/api/actions.py
95.3% <100%> (ø)
:arrow_up:

vent/api/plugin_helpers.py
90.81% <88%> (-0.2%)
:arrow_down:

vent/menus/choose_tools.py
53.33% <0%> (-37.34%)
:arrow_down:

vent/core/rq-worker/file_watch.py
55.95% <0%> (-3.58%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c2d2c...3e18f48. Read the comment docs.

rq-worker will also need to be updated

Working on updating rq-worker now.

for rq-worker try/excepts need pragma marker and should set status, like line 140.  for plugin_helper try/excepts also need pragma marker.


support IPv6 address on veth

currently only link local addresses are added automatically. Addition on ipv6 address on intf is needed

while fixing this, ensure the support of multiple IP address assignment is taken care. example as below.
The Ip addresses can be both IPv4 and IPv6 .

name: pe1
image: crpd:latest
link:
- name: ce1
prefix: <IP_ADDRESS>/30
<IP_ADDRESS>/30

existing implementation handles it


No communication since installing PCIE USB card

Using a desktop and had wyzesense2mqtt fully functioning with several sensors connected. I shut it down to install a USB 3.0 card and on powering back up, auto detect no longer works for finding the bridge. It's been unable to detect any WyzeSense devices previously paired for a couple days now and have only just started troubleshooting.
Having the sensors integrated with HA, they stopped communicating as soon as the new card was installed, meaning it was on reboot. As this is the first time I've rebooted the machine since setup, I'm uncertain if it's related to the reboot or the new USB card having been installed. I did follow the steps for automatic startup during setup, as well as tried manually starting the service several times.
Currently running Pop OS 21.04 and the most recent pull of wyzesense2mqtt, don't know the version off the cuff but can edit it in later if needed.
The last several log entries are all identical, will exclude time stamps and IPs:
YYYY-MM-DD HH:MM:SS INFO     wyzesense2mqtt  Connecting to MQTT host ###.###.###.###
YYYY-MM-DD HH:MM:SS INFO     wyzesense2mqtt  Connecting to dongle auto
YYYY-MM-DD HH:MM:SS WARNING  wyzesense2mqtt  No device found on path auto: [Errno 2] No such file or directory: 'auto'
So far I've tried everything short of a complete uninstall-reinstall or directly hard coding the path into .yaml and rebooting to see if that fixes the issue. I'm about to try the hard coding the .yaml, but at a surface level it seems that adding new USB headers possibly breaks the auto?

After hard coding the file path in config.yaml, it still didn't find the device. I then set it back to "auto" just to get back to baseline and it resolved itself after another reboot. Now I'm facing an issue where my wyzesense2mqtt is running on the same system as my HA VM instance, and it errors out as it can't open communications to my MQTT gateway which is integrated into HA on load... but I feel like that's not a bug, that's me setting it up poorly.

@SkarnFlaxEnder, sorry for extreme delay, personal issues have kept me on the fringes of this project for most of the last year.
I'm not sure on what might have happened with the auto detection, it is based on how linux detects USB connected devices. It's possible with USB3 that something changed there, and maybe the extra reboot resolved it. I haven't explicitly done any testing with USB3 ports though, so this could happen again. You might check the linux system logs and device structure to make sure nothing odd is happening there, if the issue returns.
As for the communications side, I'm running all of my stuff extensively in docker, so can't fully help with VMs, but did have to resolve something similar. In docker I had to make sure that both my Mosquitto container and WS2MQTT were on the same virtual network in order to talk to each other. They could not route via the hosts network itself. So assuming you have both in VMs, try making sure they are on the same virtual switch, and possibly even jump into one of the VMs and make sure you can ping the other from it. You may have to access each by IP rather than hostname, if your VM stack doesn't handle automatic host resolution.


Make sure the Rust binding use the shared library on windows

The code was failing to find the shared library, and then defaulting to the static version. This caused issues when using the code from rascaline, since the corresponding Python module where using different versions of the code.

:books: Documentation preview :books:: https://equistore--330.org.readthedocs.build/en/330/

Is there a way to test this even further. To test were also passing before. If we destroy this again we will not notice...


fix: lower dark mode color of no token callout

#4336  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wraeth-eth and the rest of your teammates on  Graphite


fix typo

fix typo, Tsurugi Getting Stared -> Tsurugi Getting Started

@highpon Thanks for fixing it!


remove null fields for precaching from api response

when preCaching is set to false, no precaching field is returned
in the api response
when preCaching is set to true, only non null fields are returned

/cc @vitus133 @rcarrillocruz @danielmellado @donpenney
Signed-off-by: Sabbir Hasan<EMAIL_ADDRESS>

/retest

/retest

/retest

/test integration

/retest-required

/lgtm


use the current theme's coloring instead of the blue-based colors

Currently the pop-up seems out of place because the rest of the editor is has different colors, could you please utilize the colors from the current theme to style the popup?

That is a concern to the plugin. As you can see on the screenshots it tries to follow the current theme style.
Can you please inform your current UI and syntax themes?

I see, based on the color choices of the theme I assumed the colors were hardcoded and this is not the case so this issue is invalid.


Custom link URLs

It would be nice to be able to customize the URLs generated by the JSON API, as seen here: https://github.com/thephpleague/fractal/blob/master/src/Serializer/JsonApiSerializer.php#L72
Currently it's hard-coded based on the type and the ID. My type is usually singular, while my URLs are plural, so this is always wrong. Furthermore, this doesn't work with sub-resource style URLs.
It would be nice if it was on the Transformer object, like so.
class UserProfileTransformer extends TransformerAbstract
{
    public function url($id)
    {
        return "/api/users/$id/profile";
    }
}

That would make sense to do if JSON API was the only Serializer but it isn't.
There's a couple of other bits and pieces that are starting to crop up now that JSON API support is being looked for more and more.
It looks as though multiple interfaces are needed to customize this behaviour, or some additional concept in order to tie in Serializer specific behaviour without corrupting the intention of the transformers. Otherwise the transformers are going to end up containing a ton of logic specific to the use case of the JSON API serializer, which doesn't make sense when there are other serializers available. It feels like a Liskov violation.
interface UrlContract? Provides two methods, one for the singular URL (api/resource/id) taking the ID param, and one for the index (api/resource)? Then any serializer, be it JSON API or your own custom serializer, can optionally do things if the transformer implements this contract? This might be a bit tricky in fillRelationships.
Would be interested to hear people's thoughts on this.

I just noticed in the docs that the links object is defined within the transformer: http://fractal.thephpleague.com/resources/
Perhaps this might be the easiest approach. Any "meta" or "links" or any JSON API related functionality can simply be defined in that way. The serializer would just have to be smart enough to not overwrite it, and defined them if they don't exist.

I think I'm currently following @milesj's idea, extending JsonApiSerializer and overriding the item() method. Something like this:
public function item($resourceKey, array $data)
{
    // Extract links from the resource attributes
    $custom_links = [];
    if (isset($data['jsonapi->links'])) {
        $custom_links = $data['jsonapi->links'];
        unset($data['jsonapi->links']);
    }

    // JsonApi serialization
    $resource = parent::item($resourceKey, $data);

    // Reintroduce the custom links
    if ($custom_links && $this->shouldIncludeLinks()) {
        $resource['data']['links'] += array_map(
            function($url) {
                return $this->baseUrl . '/' . $url;
            },
            $custom_links
        );
    }

    return $resource;
}

A cleaner approach to setting links and meta entries would be great :)

I'm currently in the process of rethinking the whole serializer and transformer interaction to allow more flexibility but still maintain integrity, if it ends up getting to  a point where people can just set and do whatever they want with no structure then the whole point of Fractal has been lost but I do agree that there needs to be more flexibility in certain areas which are becoming problematic, JSON-API being one of them.

Any news on this? I would like to use a slug instead of an id in the self links and related links.

I implemented a "overrides" key in the transformer in order to overrides parts of the resource inside a extended JsonApiSerializer in a similar way @ln-francesco-figari did.
class FooTransformer {
   */
  public function transform(Foo $foo) {
    return
      'id'   => $foo->getId(),
      'name' => $foo->getName(),
      '_overrides' => [
        'links' => [
          'self' => '/bar/'. $foo->getBarId() .'/foo/'. $foo->getId(),
        ]
      ]
    ];
  }
}

inside Serializer
  public function item($resourceKey, array $data) {
    $resource = parent::item($resourceKey, $data);

    // overrides link['self']
    if (isset($data['_overrides'])) {
      foreach ($data['_overrides'] as $key => $override) {
        // override only existing values
        if (!isset($resource['data'][$key]))
          continue;

        $resource['data'][$key] = array_merge($resource['data'][$key], $override);
      }
      unset($resource['data']['attributes']['_overrides']);
    }

    return $resource;
  }

@willishq is there a solution for this yet?

Hey @belohlavek as far as I know @greydnls is the new leed of the project.

@lukasoppermann thanks for heads-up. Did you find a way to use a slug for links?

@belohlavek no I actually re-thought my idea and figured it is a bad idea. Instead of using a different url and breaking json-api standards I am just using filters now, so if you want to get something by slug you just do: /endpoint/?filter[slug]=slug-of-item.

Still no solution on it? In my system types are singular and urls are plural what JSON API allows. There is no way to achieve this with Fractal right now.

I'm just running into the same problem. Should we open a new issue or can this issue be re-opened?
(cc @willishq @greydnls)


Update message type and protocol identifier URIs to https

With the consensus in the Aries WG call to update protocol URI to use https, our next step is proposing a concrete mechanism. The prior discussion on this topic was held in https://github.com/hyperledger/aries-rfcs/issues/129
We would like to use a Hyperledger Aries URI string such that:

browses to the appropriate protocol documentation.
protocol documentation is up-to-date with the GitHub repo hyperledger/aries-rfcs

Example of protocol type URI:

https://aries.hyperledger.org/rfcs/didexchange/1.0/invitation

Example of redirecting to the source documentation (for the above):

https://aries.hyperledger.org/rfcs/didexchange/1.0/ -> https://github.com/hyperledger/aries-rfcs/blob/master/features/0023-did-exchange/README.md
A nice-to-have would be including the suffix as a fragment (e.g., https://github.com/hyperledger/aries-rfcs/blob/master/features/0023-did-exchange/README.md#Introduction).

Some options to explore for hosting:

GitHub Pages
Redirect to GitHub markdown page
Read the Docs
Hyperledger web server

Also need to check with Hyperledger to explore registering the aries.hyperledger.org subdomain.

I have opened a conversation with HL's community architects about how to approach the rewriting/hosting/redirection feature that we need. I will report back.

Update: Hyperledger IT is asking us for nginx rewrite rules. I am working on it.

@dhh1128 Thanks very much for your efforts. Are there any updates to share for this topic?
I know it's not directly coupled, but it would be nice to progress on updating the message types before we get too far down the path of community interop claims discussed in the test suite issue.

I'm stalled again. I could give HL IT people nginx rewrite rules, using either of two strategies:

HTTP 301 redirects from aries.hyperledger.org/something to github.com/hyperledger/aries-rfcs/something -- aries.hyperledger.org never serves content, but redirects 100% of the time.

aries.hyperledger.org hosts static content and uses redirects to expand short URIs into long ones.

Strategy 1 requires less work by HL IT, but causes content to be penalized in Google's PageRank.
Strategy 2 requires HL IT to allocate a web server, and it means we have to modify our repo's CI/CD to generate static content.
It is not obvious which we should do.
But what stopped me isn't this question. At IIW, there was intense discussion about taking DIDComm (not all Aries RFCs, but just the RFCs that sit below the level of application protocols, such as the encryption envelope and routing stuff) to a formal standard at a place like IETF. If we did this, the namespaces at the front of message type URIs probably should not contain a reference to Hyperledger (or to DIF, which wants to host DIDComm work during SDO-oriented spec development). Which means a lot of the change we're trying to do here needs to change again, sometime soon (Aargh!), or else we need to anticipate where it will end up and change to that, instead of to a URI like aries.hyperledger.org.
Right now, what I'm thinking is that we change to "didcomm.org/protocolname/version". This would take an organizational sponsor entirely out of the URIs. I just went and registered didcomm.org in case we want to do that, and we can give the domain to HL for now, DIF if the locus changes, and IETF or another SDO farther down the line if we get there.
But this has problems: A) it's not identical to what the community agreed to (aries.hyperledger.org); B) it is only relevant to didcomm, not to all Aries RFCs.
So I'm kind of scratching my head again. Sorry to get stuck so easily.
@TelegramSam

Update on this: we decided to use didcomm.org as the prefix, with static content served from a webserver owned by HL. Now working on it with HL IT. Ticket: https://jira.linuxfoundation.org/servicedesk/customer/portal/2/IT-17759

Should we close this issue now, or would it be preferable to wait until the ticket is completed?

Let's keep this open until the work is closer to closure. The IT ticket referenced above has now been replaced with a newer one that has more clarity around tasks: https://jira.linuxfoundation.org/servicedesk/customer/portal/2/IT-18070

@dhh1128 hello, what's the status? I don't have permissions to view that issue on LF's Jira.

Another question just raised on the call is what the final URI would look like? Is it still going to look like https://didcomm.org/protocolname/version?

@llorllale That was my understanding.
@dhh1128

When I updated the RFC I checked and the three RFCs that use the message type prefix - DID-Exchange, Introduce and Help-Me-Discover - use the format you have above.  Daniel also indicated that was the correct format in feedback on the community collaboration RFC.
I'd say we declare it official and say that's the format. Then I think we can close this.
I would still like to have a way for https://didcomm.org to point to actual documentation, but that's for the future when there is time for that.

@troyronda : the second IT ticket with the LF was closed by the IT people because they decided they wanted HL to host the web server, instead of them. This was frustrating, because they had asked HL people to defer to them in the first place.
Ry, being his typical helpful self, has offered to close the loop at HL. However, now that we know the didcomm subtopic is moving to DIF, I'm wondering if we should just let DIF host the docs instead.

Continue Issue here: https://github.com/decentralized-identity/didcomm-messaging/issues/23

For clarity, does this change just apply to Sovrin DIDs or all DIDs??

This is not a change to DIDs but to the identifier used for message types in Aries.  When an Aries agent sends a message (say, "Here is a credential offer"), it uses an "@type" field with a string identifier in it.  This change is to make that identifier a string based on an HTTP address instead of a DID.

Thanks.  Right.  So a DID is no longer a valid doc_uri correct?

It is deprecated, but still in use.  There is a community effort to move away from it that has stalled.  @TelegramSam -- second time this week this has come up.  We should push this.  Ready for step 2?
See: https://github.com/hyperledger/aries-rfcs/tree/master/features/0348-transition-msg-type-to-https


Refactor reduce_sym

circuit_frame::reduce_sym() needs careful attention. Naming could stand to be more principled and normalized. There may be latent bugs. A complete refactor might be in order, especially if that reduces (or at least doesn't increase) constraints.

This happened in #213.


Create style object which could be shared betwen Widgets

Hello. I'm new to Flutter with Angular background. I can compare these techs and I see a big pain with Flutter:

it's hard to style widgets (vs css)
styling is mixed with business logic (vs angular templates)

These problems lead to another one - it's hard to create plugins with customizable UI.
In a best-case, I would like to have Angular in Flutter where logic / structure / styles are split. But it's too hard. Just to make the picture a little bit better I would suggest the following:

create Style data class which will contain styles data (padding / colors / etc)
add api to apply Style object to Widget. E.g. Styled.widget(child: myRow).style(myStyle)
if Style object is null or empty Styled.widget(child: myRow).style(myStyle)  just returns myRow

Style class may have builder style api.
With Style object plugin consumers may provide custom styles for Widgets, Styles may be shared and etc....

Interesting concept. I have thought a bit about it myself. So far i have implemented the .parent() method which takes a function with a child as its parameter.
Widget _style({@required Widget child}) => child
  .padding(all: 20)
  .backgroundColor(Colors.blue);

AnotherWidget()
  .parent(_style);

But maybe there is a way to make it more intuitive with some sort of Style concept.
For example:
final Styled _style = Styled()
  .padding(all: 20)
  .backgroundColor(Colors.blue);

AnotherWidget()
  .style(_style);

and
final _style = (bool active) => Styled()
  .padding(all: active ? 0 : 20)
  .backgroundColor(Colors.blue);

final bool _isActive = false;

AnotherWidget()
  .style(_style(_isActive));

A downside with this method is that it's hard to modify. With css it's easy to override for example the padding, but it's not so easy with this method.

What if Styled had a .copyWith


Replace deprecated php-amqplib API

As of php-amqplib version 2.12.0 (see PR: https://github.com/php-amqplib/php-amqplib/pull/799) we should use method ack() on the message directly.

@patrickallaert Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@patrickallaert Thank you for signing the Contributor License Agreement!

OK. May I ask you to also look into updating https://github.com/rabbitmq/rabbitmq-tutorials/ where the executable examples reside? Thank you.


Logging mha2nnunet

Write the traceback to the log when an error occurs, instead of silently continuing.

The tests for Windows fail for some reason...

@snorthman I've updated the Python versions to test, and the tests are now running successfully. However, the test to verify preprocessing runs as expected through the command line interface fails on Windows. Would this be something you could debug? I don't have access to Windows... Otherwise, shall we deprecate support for Windows?

I will try to fix it first. What is the urgency on this?

The urgency is low, but it would be good to resolve the issue at some point.


--ra-mux-server argument applies to ra-multiplex and not ra-multiplex-server

Thank you for building this crate. It's very handy.
Problem
$ ra-multiplex-server --ra-mux-server /path/to/custom/rust-analyzer &
$ ra-multiplex <...>

then I get:
[INFO ] [32830] client connected
[ERROR] [32830] client error: spawn ra instance

     Caused by:
         0: couldn't spawn rust-analyzer
         1: No such file or directory (os error 2)

Passing --ra-mux-server to ra-multiplex-server doesn't seem to work. ra-multiplex cannot find rust-analyzer.
Solution
You have to pass it via the client. To fix:
$ ra-multiplex-server --ra-mux-server /path/to/custom/rust-analyzer &
$ ra-multiplex --ra-mux-server /path/to/custom/rust-analyzer <...>

Thoughts

Does passing --ra-mux-server to the server do anything?  If not, should it error?
If --ra-mux-server is a valid option to the server: In the absence of a client --ra-mux-server, the server's configuration should take priority.
Maybe we could pass ra-mux-server via the config?
Maybe this could be spelled out a bit more in the docs? We could kill two birds with one stone by adding a --help?

I am happy to submit PRs for any/all of these. I just wanted to ask first because the intended/correct behavior aren't clear to me.

Hi,

yes this is the intended behaviour. Setting the LSP server for the whole server wouldn't make sense since one ra-mux-server instance is meant to support any LSP server, it's meant to be configured by the LSP client (as is shown in the examples), this allows you to use multiple LSP servers concurrently from multiple LSP clients (say rust-analyzer from one workspace and clangd from another).

Definitely, I was trying to keep the cli trivial but erroring on unexpected input would be nice. I'm working on a big rewrite of the cli while trying to implement #1 but that's probably ways off as I don't have much time, so adding the error in the meantime sounds like a good idea.

Suggestions for the docs are welcome. I could've omitted something that felt obvious to me even though it isn't to others.

Also looking at the error message you've attached, it's missing the path ra-mux attempted to open, I'd also like to fix that.

Okay, I'll see if I can put something together this week/weekend.


enh: schemaless response add affected rows and total rows

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.05%. Comparing base (90d2967) to head (c9465d4).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.1     #331      +/-   ##
==========================================
- Coverage   69.07%   69.05%   -0.02%
==========================================
  Files          87       87
  Lines       10020    10033      +13
==========================================
+ Hits         6921     6928       +7
- Misses       2399     2407       +8
+ Partials      700      698       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Service usage inventory by org

In order to effectively focus our efforts in creating migration assistance materials, Squad 2 wants an inventory of which services+plans are used the most and who we can talk to about them.
Acceptance Criteria

[ ] We can easily identify which services+plans are instantiated the most
[ ] For a given service+plan, we can identify org+space in which it's used
[ ] For a given space, we can identify who to talk to about the services inside it (eg the set of people with SpaceDeveloper or SpaceManager roles)
[ ] It should be possible to annotate the information for purposes of further communication/tracking

Implementation ideas
CSV-based:

[ ] We'll generate a CSV with one line per service instance binding and import it into a spreadsheet

[ ] Can we generate this directly from a DB rather than traversing the API?

[ ] For each service instance, we'll include the org, space, app, service+plan, set of Space[Managers|Developers]
[ ] To make it easy to answer the questions in the ACs, we'll make some pivot tables in other tabs that render the raw data into a higher-level form

cf #229 .

Question for the team: how will we take user-provided service instances into account in our migration planning?

Okay, I got the word -- we don't need to take user-provided service instances into account.
I'm mostly done with this work, but I'm unclear on exactly what information from this API call will be useful to the team: https://apidocs.cloudfoundry.org/240/service_plans/list_all_service_plans.html

Script to date committed to branch respect_service_bindings here.

@datn:

Question for the team: how will we take user-provided service instances into account in our migration planning?

Their content is completely owned by the customer, and ordinarily I'd say that's reason enough that they would need to set it up again in the new environment. However, I think we have the actual UPS content in the DB, so it may be something that we can auto-migrate over! It's probably a separate story from the regular services; want to create a separate issue in the backlog?

@jbarnicle: I took a look at two sheets I had open in my browser. I'm not sure what link I followed to open them or what the difference between them is although at first glance they look identical.
Review points:

I'm seeing a lot of ,, among the OrgManagers and SpaceManagers... Seems like that's likely a bug.
We need to see SpaceDevelopers rather than SpaceManagers... They're the ones who are responsible for manipulating apps and services in a space and therefore the ones to talk to.
The data looks like it will be useful, but I can't really tell until I see some pivot tables based on it that help us answer the questions in the ACs above. Give me a DM if you have trouble figuring out how to set those up.

@mogul That SpaceManagers column is mislabeled - those are actually SpaceDevelopers (I don't think there is a role SpaceManager).  I'll fix that.   I'll also look into the ,, issue.
WRT to pivot tables - I might need a little input on what's needed there.  I think the data is there to support the acceptance criteria - but there are definitely opportunities to present it in a more clear fashion.  It would be nice to filter out dev / stage and other org data that is clearly not part of the migration plan.

@mogul I made the following changes to the script and reloaded the data

fixed ,, issue by ignoring OrgManager / SpaceDeveloper entries without a username
removed spaces that were obviously non-prod
sorted the data by org
removed any services columns that had no instances
corrected SpaceDeveloper heading and added column for SpaceManagers

I think it's fairly straightforward to glean the data from the existing sheet

We can easily identify which services+plans are instantiated the most

Instance totals are summed at the bottom of each column

For a given service+plan, we can identify org+space in which it's used

Instance usage is totaled for each org+space in the service plan column

For a given space, we can identify who to talk to about the services inside it

Space Developers / Space Managers are listed per space when available

It should be possible to annotate the information for purposes of further communication/tracking

The google sheet is editable

Let me know what you think.

If we're talking about this file, LGTM.
So the information we learned is that this is the order we should be prioritizing our efforts to document/make tools:

26 RDS Database Broker : shared-psql
13 Redis 2.8 service for application development and testing : standard
9 Amazon S3 is storage for the Internet. : basic
9 Elasticsearch 1.7.1 : 1x
4 RDS Database Broker : shared-psql
3 RDS Database Broker : medium-psql
3 MySQL 5.6 service for application development and testing : standard
2 MongoDB service for application development and testing : free
2 MongoDB 2.6 service for application development and testing : standard
1 Elasticsearch 1.7.1 : 3x
1 Redis 2.8 service for application development and testing : free
1 RDS Database Broker : shared-mysql
1 CouchDB 1.6 service for application development and testing : free
1 Elasticsearch 1.7.5 : 3x
1 RDS Database Broker : micro-psql

...and we have a list of people we can talk to for feedback/testing on them as we go.


Coverage reports

Added coverage badge

Coverage increased (+9.5%) to 89.573% when pulling 483b2f19c2c96c830d0b656ebb0abbb1cbe3e5ae on master into 87d6542c48c005d2d3252f89fac17998dea21af5 on feature/coverage.


JS Syntax Highlighting Error

I found no instance of this issue in a Github search.

VSCode Version: 1.18.0
OS Version: 10.13 (High Sierra)

Steps to Reproduce:

Create a .js file that has React code
In the render method, using a for loop and an if statement nested within it, chain some methods like push.
Incorrect syntax highlighting

Reproduces without extensions: Didn't test
I suspect it something to do with nesting of parentheses and multiple boolean operators in the if statement. When I add parentheses on the if statement to be more explicit, highlighting is corrected.
This problem existed yesterday too before I upgraded to 1.18.0.

Can you please share some source code along with the screenshot

I can't post all of it, but I narrowed it down to this and still get the same error:
// @flow
for (let i = postLen; i >= 0; i--) {
  if (node) {
    const element = ((node: any))
  }
}

for (let i = 0; i < postsLen; i++) {
  if (
    prevPost &&
    prevPost.creatorId === post.creatorId &&
    post.timestamp < prevPost.timestamp + 300
  ) {
    postsWithBreaks.push(renderPost(post, true))
  } else {
    postsWithBreaks.push(renderPost(post, false))
  }
}

We don't provide flow support out of the box. If i get rid of the flow bits, everything seems to work fine
Please try filing an issue against whatever extension you are using to syntax highlight flow files


Suggest yarn add x for yarn install x

Yarn has changed from using yarn install PACKAGE_NAME to yarn add PACKAGE_NAME but when running fuck I get yarn install suggested.
➜  Twistly git:(master) ✗ yarn install ava
yarn install v0.23.4
error `install` has been replaced with `add` to add new dependencies.


Prevent inopportune collision errors with unconnected faces in Convex shapes

Additionally adds an extra parameter to bypass bounding sphere radius and faceNormals calculations, if supplied with a THREE.Geometry that contains such information.
These changes work in tandem with changes in use-cannon, to better support ConvexPolyHedron.
--
While looking into this I cleaned up some formatting, passed axes to the convexPoly constructor within Box, and corrected the sphere volume formula.

you can always merge if you want to, you're the only one that understands it anyway 😅

Fair enough :)


Bug: @SQL variable isn't correctly declared

If you run a server with case sensitive collation the instance dashboard does not work.
The @SQL variable is written with small letters, but it should be written with big letters to match the  following commands.
I would create a PR but the .rdl file in the repo does not match the .rdl file in the release. Maybe that should be fixed too.

Hi @BitDesert ,
Thanks for the heads-up.
At the moment I am not actively maintaining this project at the moment but I will try and have a look at it.
Thanks!
Enrico


Revising suggestions for systemctl unit creation mentioned in README

Original text

Using systemctl
Another script using systemctl:

sudo touch /etc/systemd/system/mattermost_gitlab.service
'sudo vi /etc/systemd/system/mattermost_gitlab.service`
Copy the following lines into /etc/systemd/system/mattermost_gitlab.service

[Unit]
Description=Mattermost gitlab integration
After=syslog.target network.target

[Service]
Type=simple
User=mattermost
Group=mattermost
ExecStart=/usr/local/bin/mattermost_gitlab http://mattermost/hooks/hook-id
PrivateTmp=yes
WorkingDirectory=/opt/mattermost
Restart=always
RestartSec=30
LimitNOFILE=49152

[Install]
WantedBy=multi-user.target

systemctl daemon-reload
systemctl enable mattermost
systemctl start mattermost

Suggested text

Using systemctl
Another script using systemctl:

sudo chown mattermost:mattermost /usr/local/bin/mattermost_gitlab
sudo nano /etc/systemd/system/mattermost_gitlab.service
Copy the following lines into /etc/systemd/system/mattermost_gitlab.service

[Unit]
Description=Mattermost gitlab integration
After=syslog.target network.target

[Service]
Type=simple
User=mattermost
Group=mattermost
ExecStart=/usr/local/bin/mattermost_gitlab http://mattermost/hooks/hook-id
PrivateTmp=yes
WorkingDirectory=/opt/mattermost #for omnibus installations, use /opt/gitlab/embedded/service/mattermost
Restart=always
RestartSec=30
LimitNOFILE=49152

[Install]
WantedBy=multi-user.target

systemctl daemon-reload
systemctl enable mattermost_gitlab
systemctl start mattermost_gitlab

Corrections made

Not sure if this is a good idea, but I added instruction to do chown command and assign ownership of gitlab_mattermost to user mattermost and group mattermost. Assuming this is the best approach, correct me if chmod is the better option or if this should be skipped entirely.
systemctl commands at bottom did not reference the correct unit name
nano is better suited for all audiences, hands down.
working directory needs to be different for omnibus installations, otherwise you'll get a very cryptic error message from /opt/var/syslog. (Reference can be found here)

Dec 12 10:31:35 gitlab systemd[5406]: mattermost_gitlab.service: Failed at step CHDIR spawning /usr/local/bin/mattermost_gitlab: No such file or directory

Done !


Beginnings -- comment here to be added to the team

See https://github.com/ipfs/ipfs/issues/21
I dont have the bandwidth to lead this effort, so ideally we could find a maintainer that can take a lead on. Ideally someone who understands ipfs at both a technical, ideological, and product levels.
Doing this well will in short term will need:

stable specs https://github.com/ipfs/specs/ (which we're headed toward)
passing a common test suite (which we'll extract from go-ipfs)
coordination with others in ipfs world in general (come hang out in #ipfs)

we're super happy to support this effort however we can. (biggest need is docs i think). i'd encourage you to play with existing go-ipfs, and come hang out in #ipfs.

Oh and, comment here if you want to be added to the team. We've been following a pretty simple policy of just trusting people. The only rules are:

don't push to master
don't merge to master without maintainers' approval
don't rebase others' branches without asking first

On Fri, Apr 17, 2015 at 04:00:12AM -0700, Juan Batiz-Benet wrote:

Oh and, comment here if you want to be added to the team. We've been
following a pretty simple policy of just trusting people. The only
rules are:

don't push to master
don't merge to master without maintainers' approval
don't rebase others' branches without asking first

Out of curiosity, why do this instead of using the integration-manager
workflow where contributors all fork 1?  With an additional
remote.origin.fetch line, you can easily fetch remote-tracking
branches for all PRs 2.  For example, I have:
$ git config --get-all remote.origin.fetch
+refs/heads/:refs/remotes/origin/
+refs/pull/:refs/remotes/origin/pr/
in my go-ipfs fork.  That lets me:
$ git fetch origin
…
From git://github.com/ipfs/go-ipfs
2406334..a97e9e7  master     -> origin/master

[new branch]      feat/pipe  -> origin/feat/pipe
224df31..e4f0970  fix/pin-bug -> origin/fix/pin-bug
34ad88d..ed0469d  migrations -> origin/migrations
961451e..9d80fd1  refs/pull/1001/head -> origin/pr/1001/head

9b6948b...359e960 refs/pull/1001/merge -> origin/pr/1001/merge  (forced update)
224df31..e4f0970  refs/pull/1010/head -> origin/pr/1010/head
de509c2...eb093f0 refs/pull/1076/merge -> origin/pr/1076/merge  (forced update)
dd2d795...7c79c8e refs/pull/1081/merge -> origin/pr/1081/merge  (forced update)
2368464...9947cf9 refs/pull/1085/merge -> origin/pr/1085/merge  (forced update)

[new ref]         refs/pull/1087/head -> origin/pr/1087/head
[new ref]         refs/pull/1089/head -> origin/pr/1089/head
[new ref]         refs/pull/1089/merge -> origin/pr/1089/merge
34ad88d..ed0469d  refs/pull/950/head -> origin/pr/950/head

9147b80...d12c2d8 refs/pull/950/merge -> origin/pr/950/merge  (forced update)
ec24e31...305f0e5 refs/pull/999/merge -> origin/pr/999/merge  (forced update)

and:
$ git log --graph --topo-order --oneline --decorate origin/master

a97e9e7 (HEAD, origin/master, origin/HEAD, master) Merge pull request #1087 from ipfs/bitswap-perf
|\
| * 30ee01f (origin/pr/1087/head) increase window size for yamux streams
|/
2406334 Merge pull request #1079 from ipfs/chriscool-readme-fix-todo
|\
| * 89961d9 (origin/pr/1079/head) README: alpha version has been released
|/
e225e9f Merge pull request #1074 from ipfs/fix/warning-logs
…

As far as I can tell, that gives you all the benefits of your current
workflow with none of the trust assumptions ;).

We run our CI suite against the pr namespace. It's very useful.
Do you guys want me to make PRs now or are you happy for me to work on master until more contributors turn up?

@wking ah interesting. would love to make it work with 0 trust. But the most important problem we've run into is collaborating, sometimes i can go in and fix some of the pedantic CR requests (or rebase on new master) to make it easier on others, and we cannot do that when it's a fork + PR. Also, so far we've had trouble with some CI systems running for PRs (jenkins!!! but we dont use jenkins anymore cause it died).
@bmcorser we always do PRs even when working on the same repo.

@jbenet @bmcorser I think for now, until there are other contributors youre good to work on  master. Although, jbenet might have other opinions

@bmcorser i'll try to read the code + comment if you do PRs. i think it's safest so can help answer questions / notice bugs / etc

I'd love to work on this project - my time is currently heavily constrained by school work but after the winter holidays I will be able to devote a large amount of time to the project.

I think I am already added, but I am starting to have to bandwidth that would let me push on this project.
I might start working out modules + involved processes (a bit more involved in python than go) over the next few days.

Great! I too am rather constrained by work and study, but would be interested in doing code review and managing CI things. How do you guys want to communicate? I quite like the look of https://gitter.im (it's like a hipster IRC room attached to a GitHub repo) ...

I'd really like to join this effort. I think I'd be able to contribute 1-3 hours a week to throw Python at infrastructure/development problems :).

I'm in, but I don't know how many hours I'll be able to throw in ^-^ Just liked the idea (IPFS) since the beginning :-) Glad today they have some specs -> give me motivation ! ("Walking on water and developing software from a specification are easy if both are frozen." - Edward V. Berard -)

Not currently sure what my commitment can be, but I'm interested in joining the initiative.
@bmcorser gitter works for me.
@jbenet do you have a recommendation for the best way to coordinate/get in touch with people pursuing the test suite?  I feel like this is probably a strong apriori requirement for a burgeoning ipfs polyglot community and I'd personally love a spec to build against.

Jumped in on gitter. Posting here as well to indicate interest. I'm going to read the white paper and really dive into the details in the upcoming week.

@mvanveen right now, there is a "sharness test suite" in go-ipfs which is actually just testing the cli and api". this is a good step to testing behavior from an HTTP api. we'll be separating this out into its own repo with a test suite.
the next thing to do would be to setup network tests using an instrumented or controlled node (likely go-ipfs for now) speaking directly to another node in the target language to test. this is not yet done.

I'm commenting here to show my interest. I've been reading the whitepaper, the specs site, the kademlia paper, etcetera. The checklist on the README of the js-ipfs implementation seems to be a good organisation method also for breaking down into chunks so py-ipfs can be tackled by newcomers. The elephant is too damn big and wriggly even for a first bite.

I want to help out with this. I plan on digging deeper into the white paper and specs.

@candeira @marknagelberg and anyone else interested, we had a short kickoff hangout recently (https://github.com/ipfs/py-ipfs/issues/20) and we've made some tentative plans for what to do next.  The network stack of go-ipfs is going to be factored out into libp2p, so it would make sense for us to build a python-libp2p first, and then the IPFS protocols on top of it.  I'm hoping that soon we'll start doing py-ipfs hangouts as part of the monday sprints.

@amstocker, thanks. Would it help if I took the js-ipfs roadmap and created a template in the py-ipfs readme?
The way I see it, while it doesn't make sense to break the code down into as many modules as in JS (we don't have to worry about shipping too much code to a browser), the breakdown in functionality is pretty much the same.

@candeira sure that would work.  I agree that we shouldn't have that many modules, maybe just a python-libp2p module and then py-ipfs.

@amstocker thanks. I'm at work now, I'll make a PR tonight.

@candeira awesome!  Sounds good.

@candeira I'm not an admin of this repo so I cant merge your PR, but the roadmap looks good.  @jbenet would it be possible for me to be a contributor for this repo?

Yes, @amstocker @jbenet, I would like to be a contributor too. I've read the rules (don't commit to master, make PRs only, don't merge other people's code without code reviews). What else is required?

Hi everyone, I'd also like to contribute to the development of IPFS in Python.  I was developing PyTables some years ago and I'd like to get to speed with coding once more by contributing here, so I may start taking some simple, no rocket science things like tests, documentation and the like.  I'm currently unemployed so I'd be able to dedicate some hours a week.
I've read the white paper (I'm reviewing it now), and I've read the latest issues about python-libp2p.  Do you have any other suggestions for docs I could review or code I may start looking at?  Thanks!

Hi people,
I am Lorenzo. It would be great to join this venture as Python developer and space exploration fan. Hope to learn as much as possible. I am trying adding test to ipfs/python-ipfs-api but first I would like to see a complete version of Dignifiedquire/ipfs-http-api
Keep rollin'

I've just finished updating the js-ipfs status page, following the new API spec organization and linking each component to its respective spec. I believe it is more sane and easier to understand what needs to be implemented in terms of components and respective expectations for them.
Check https://github.com/ipfs/js-ipfs#project-status :)

@diasdavid thanks for that. I'll update the py-ipfs status page to follow the js status and organisation. I believe it will be of great use to us!

@Mec-iS Lorenzo, welcome :) .  @diasdavid This looks great, thanks for the clarifications!

I'd love to be added to the team. I'm pretty busy, but I'd be down to throw some hours into this project.

Hi everyone! It would be grate to join your team. I am not very busy now, so I would be glad to productively participate in such an inspiring project.

Very interested in helping with this effort as well.  I have been looking at the ipfs project for the past few weeks and it seems very interesting.

I'd be interested in helping here. Looking at the traffic though, it it still alive? Is there anything happening right now?

@fredthomsen, @avastmick
There's some stuff happening, have a look here if you didn't already. I'm deep in exams right now, but will be taking stock again in a few weeks.

@avastmick I started looking at some of the multiaddr and multihash work.  These lower level modules are still in the early stages and definitely need some assistance.

@fredthomsen Okay great, starting to have a look today, in particular at the the multihash work done by @candeira  and @ivilata  - seems to be some duplication... I'll pick one that makes most sense to me to narrow in on.

@avastmick @bmcorser and anyone else really.  I started on a python multicodec implementation since I saw there was none.  https://github.com/fredthomsen/py-multicodec.  Only json so far.
Feedback and comments appreciated.

I'm interested in contributing to this project. I've just become aware of ipfs, so still need to look over things.

I would like to participate.

For IPFS beginners, we can start a study/research group to come closer to the different layers of the stack and then start contributing to py-ipfs. We can start a mail thread to share what we have understood so far and keep going helping each other. Who wants to join, write me at tunedconsulting [at] gmail.com, when we will be three or four people I will send an introductory letter to the argument. Cheers!

Hey, I would love to contribute :)

i'd be interested in contributing as well!

I'm interested in contributing as well :)

I would like to join the team. I have been thinking for a system like this. I like the concept.

add me to, I've also sent you an email...

I'd love to contribute to this project. I also sent an email to @Mec-iS.

@jbenet  Count me in :) Let me know what needs attention. Already forked, so will work off that for now.

Following from https://github.com/ipfs/ipfs/issues/112#issuecomment-282338767, I'd like to help out and am just seeing what's what from https://github.com/ipfs/py-ipfs#contribute now.

A good chunk of the work building IPFS is actually building libp2p.
The documentation on libp2p and its modularity are in a state where I feel it is easier to start by just mirroring that implementation for new implementations in other languages. See https://github.com/libp2p/js-libp2p for more details and definitely check the examples to learn more about:

Transports - https://github.com/libp2p/js-libp2p/tree/master/examples/transports
Protocol and Stream Muxing - https://github.com/libp2p/js-libp2p/tree/master/examples/protocol-and-stream-muxing
Encrypted and Authenticated Comms - https://github.com/libp2p/js-libp2p/tree/master/examples/encrypted-communications
Peer Discovery Mechanisms - https://github.com/libp2p/js-libp2p/tree/master/examples/discovery-mechanisms
Peer and Content Routing (coming later today :D)

Hi there, I would like to contribute to this project. I am going through the go implementation and am playing with it for now but would love to pick up some low hanging fruits or read some documentation about the current status, having the current context will be extremely useful. Is there a place where I can see it?
Thanks!

@dhruvbaldawa as @diasdavid mentioned, libp2p is the first step on the path to implementing ipfs. Writing some of the lower level libp2p pieces like multistream and a basic multiplexer would go a long way

Actually I think a basic implementation of IPLD and e.g. the dag-pb and unixfs formats might get you to something usable quicker -- although admittedly it feels less exciting if its not networked :) On the other hand the networking stack is a lot of work.

@whyrusleeping and @lgierth thanks for your prompt reply, I didn't know about IPLD.
This does look interesting to me. I have opened an issue here https://github.com/ipld/ipld/issues/24

Hi! I would like to help with the project.  I took a look at the project roadmap and the rest of the discussion on this thread, but it would be great if I could get some pointers to what would be a good place to start from.

Hi @Projjol,
I recently started with the implementation, you can check the progress here - https://github.com/ipld/ipld/issues/24
I am currently working on https://github.com/ipld/py-ipld-dag, we can have a detailed discussion about it, if you'd like.

Hey @dhruvbaldawa ! I'd love to talk to you about it, where can I hit you up? :)

Hey @Projjol, you can contact me at dhruv [at] dhruvb.com

Hi there, I'd like to participate!

hey @drozdziak1, check out https://github.com/ipfs/py-ipfs/issues/1#issuecomment-338458221 and we can get in touch and discuss about the current status.
sounds good?

@dhruvbaldawa Sure, so nowadays it's about implementing py-ipld, and then moving over to py-ipfs with py-ipld as a dependency?

@dhruvbaldawa I'd like to help with this. It would be great if you can guide to get started with it

@meanmachin3 Welcome! Please take a look at the current status here -- https://github.com/ipfs/py-ipfs/issues/1#issuecomment-338458221
You are welcome to join us during our weekly calls -- https://github.com/ipld/py-ipld-dag/issues/7
If you need some more information, we can get in touch :)

@jbenet The IPFS protocol is very interesting. I would like to contribute to this project. Please add me to the team.

The active Python team is @alexander255, @whereswaldon, and @amstocker

@lgierth: We're only maintainers of py-ipfs-api (and @amstocker is inactive, and @whereswaldon and me are currently keeping it mostly maintanance-only mode – we may do more again at some point but no promises). And while being assigned membership of all Python-related repositories was a noble gesture I think none of us had any immediate plans of starting to hack on the py-ipfs implementation (althrough having a Python client implementation would be nice indeed).
@vuonghv: I certainly can provide some guidance on this, but it would mostly be you hacking away. You should also probably get in touch with @dhruvbaldawa as he's working on all those base modules that you'll need.
Anyway, for now I think the best first step would be to have a Python multistream-select client that can connect to a TCP multiaddr[1]. Maybe even write a little test utility like mss-nc to verify that it's working, then move on to bitswap and try to fetch and provide some blocks.
Also you're more than welcome to ignore Python 2 entirely and use asyncio and async/await for everything involving I/O. No backwards compatiblity concerns here. 🙂
[1]:  There doesn't seem to be any Python libp2p implementation currently in the works, so let's skip that subject for now and stick to the most trivial and widely used transport for now.
@lgierth: From your organizational perspective: Is it better to add him to the repo/team and have him do work here, or is it better to have him use his own fork and submit a PR with something sensible (whatever it may be)? I'd think the later, but I'm not sure since the repo has been abandoned for so long. (Also, is there no better documentation of bitswap than that diagram in the js-ipfs-bitswap repo?)

Hey guys I'd really like to contribute somehow!

I also would like to contribute！:blush:

Add me to the team =D

@adamteale @alienmao @R3sFruitRollUp: Are you interested in contributing to py-ipfs? My response to vuonghv on how to get started still stands. I can make you a repository maintainers if you prefer, but what we'd need first and foremost would be a multistream-select implementation and that'd be over at https://github.com/multiformats/ (where I don't have access).
Also the current repo is not very useful at all, so feel free to ditch it and start from scratch.

@alexander255 Can you contact with the maintainers of multiformats to ask them to create a repo called py-multiaddr?

@alienmao: Sorry you got lost in one of my slightly neglected mailboxes. I'll see what I can do.

@alienmao: I asked them to create https://github.com/multiformats/py-multiaddr
Please open an issue there or create a PR to get in touch with them.

+1

@mooperd: +1 what?

Still need help?

@brunoalano py-ipfs-api is maintained for bugfixes and the like, but not actively developed right now. If you want to add features, we're happy to provide guidance on that.

A third implementation of IPFS under Python sounds like a great idea! If this were to happen, it would make IPFS even more flexible and easy to port to various devices, potentially easier to integrate with various applications as a plugin (eg: game engines). I don't think I currently know enough Python nor IPFS core code to be useful to the team, but commenting both to subscribe and offer feedback that I'm interested in this initiative.

I'm interested in a third implementation of IPFS under Python.too

@alienmao @alexander255 I found an existing Python multiaddr implementation: https://github.com/sbuss/py-multiaddr. I'm thinking it just wasn't realized that this exists? I was thinking we should put that code into the new repository that was made for python under the Multiformats team. Then we could start building the Python multistream-select implementation as suggested.
Unless anyone disagrees I can make a PR to do this.

@kaleposhobios Maybe we can do that as the repo https://github.com/sbuss/py-multiaddr seems to be no longer maintained and there was no answer after I commented on this issue https://github.com/sbuss/py-multiaddr/issues/19 .

Cool. Before I just blindly did that I was going to make sure it still
matches the latest spec. And also try to see if we can take over the pypi
stuff.
Do you know the right procedure for updating the authors? Leave as is, even
though it’s in a new repo, because indeed he still did write it?
On Thu, Jul 26, 2018 at 10:30 AM wto<EMAIL_ADDRESS>wrote:

@kaleposhobios https://github.com/kaleposhobios Maybe we can do that as
the repo https://github.com/sbuss/py-multiaddr seems to be no longer
maintained and there was no answer after I commented on this issue
sbuss/py-multiaddr#19 https://github.com/sbuss/py-multiaddr/issues/19 .
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ipfs/py-ipfs/issues/1#issuecomment-408117141, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AMwNkKrK9OTlIgpk1yutDkwPxpmtCJyJks5uKdKegaJpZM4EBazc
.

Hey @kaleposhobios, any updates?

thanks  I will try to do this.

@alexander255 There's a py-multiaddr implementation already. I will start working on a python implementation of multistream-select.

@ngetahun: [Sorry, I did mean py-multistream in my last comment.] Thanks for looking into this! Once you have any working code (even if not a complete implementation) please leave a comment here so that others following this project know.

📣 Calling out Python developers!
The Ethereum Foundation is funding the development of py-libp2p via grants in their Round V: https://blog.ethereum.org/2018/10/15/ethereum-foundation-grants-update-wave-4/
If you're interested in working on a Python libp2p implementation, this is a great opportunity to do so. Guidelines here: https://app.tettra.co/teams/ethereum/pages/applying-for-ef-grants

@raulk I would like to join in but I can't find any actionable information in those links, am I missing something? How can I contribute?

@dhruvbaldawa Here's the link to the application form: https://efgrants.typeform.com/to/huczUJ (extracted from the blog post). You'll need to put together an application and submit it to the Ethereum Foundation.

@raulk so do individual contributors apply separately? or is there a pool of issues from where we can pick up issues? how does this work?

@dhruvbaldawa Yes, individual contributors apply separately, although if you want to assemble a team, I suggest posting on the Ethereum Sharding Gitter: https://gitter.im/ethereum/sharding, as others there might be interested in making a joint proposal. The EF call for proposals is intentionally left open-ended for contributors to pitch what they intend to work on.

Hi, Please add me to the team

This project is in planning stages at best and does not have any code (and hence not contribution guide). For details on the current status and an idea on how to proceed please see my comment from last december, particularly the response to vuonghv.
Since then @ngetahun has apparently started working on an implementation of py-multistream-select (very early stages, hardly any code yet): https://github.com/ngetahun/py-multistream-select
You may want to coordinate with him.

As a side-note: If anybody is interested in working on local data storage (i.e. caching) instead, take a look at https://github.com/ipfs/go-ds-flatfs and try to implement that as a backend for https://github.com/datastore/datastore – several backends already exist so it shouldn't be too hard; the serious problem is that the base library doesn't support Python 3, so that would need to be addressed first.
Getting this done is basically a requirement for serving data later on.

Since then @ngetahun has apparently started working on an implementation of py-multistream-select (very early stages, hardly any code yet): https://github.com/ngetahun/py-multistream-select
You may want to coordinate with him.

@alexander255 Okay but there is some development on multistream-select here already https://github.com/multiformats/multistream-select. Should we go for Python client implementation now?

Regarding libp2p: a team supported by the Ethereum Foundation has a significant head start implementing py-libp2p (including multistream et al).
Repo is here for now: https://github.com/zixuanzh/py-libp2p/ but it'll be moved to the libp2p organisation soon.
@zixuanzh and @stuckinaboot are part of the dev team, in case you want to reach out to join the py-libp2p community. They also run a Gitter channel: https://gitter.im/py-libp2p/Lobby
I expect py-ipfs will be able to use this implementation going forward.

@raulk: That's great news! Since you mentioned multistream: Could you assemble a list of all the Multiformats modules you are using/providing? It seems with what you implemented work on an actual py-ipfs could maybe be started right now. :+1:

So I guess we would have to wait for the python implementation of libp2p to be mature enough to be used for this project

@tranlyvu: Not really. I think using Ethereum's libp2p as a base for project would be very beneficial even at this stage – some breakage is to be expected however. Also remember that libp2p is a library whose main purpose is to give you a connection stream for an arbitrary multiaddr.
@ngetahun: Looking through the py-libp2p source code I discovered
https://github.com/zixuanzh/py-libp2p/tree/master/protocol_muxer, which appears to be a complete implementation of py-multistream-select. Maybe you (or somebody else) can take that code and merge it into your repo, then submit a PR to py-libp2p to use your separate module instead?
Also let's continue this discussion at issue #49. I've create an OP there with the current status and will keep that updated as things evolve, so that the posts won't always get drowned.

@alexander255  Okay sounds good, let's use libp2p to get the ball rolling for this project

@jbenet I would like to be a part of the group and contribute to the project. I seriously find this useful and interesting. For me contributing to it will help me learn new things.


Maintainers: Updates charging API maintainers

Swaps aaronemassey for GRobertZieba as the new charger maintainer.

@rriveramcrus Do you want to revert this change and we can work on following the proper procedure? The PEC PR that I have open is probably gonna take a while to resolve, but I do have at least two smaller Zephyr changes in my backlog that I can work on so I can get collaborator status.

@rriveramcrus Do you want to revert this change and we can work on following the proper procedure? The PEC PR that I have open is probably gonna take a while to resolve, but I do have at least two smaller Zephyr changes in my backlog that I can work on so I can get collaborator status.

Sounds good, I'll close it out.


arq integration: transaction name can be wrong for concurrent jobs

How do you use Sentry?
Sentry Saas (sentry.io)
Version
1.39.0
Steps to Reproduce
We use the Sentry arq integration. When running many concurrent jobs at scale, we have noticed that the transaction and extra arq metadata can be wrong and mixed between jobs. I have tried to write a test case to test_arq.py which fails and reproduces the problem:
@pytest.mark.asyncio
async def test_job_concurrency(capture_events, init_arq):
    """
    10 - division starts
    70 - sleepy starts
    110 - division raises error
    120 - sleepy finishes

    """

    async def sleepy(_):
        await asyncio.sleep(0.05)

    async def division(_):
        await asyncio.sleep(0.1)
        return 1 / 0

    sleepy.__qualname__ = sleepy.__name__
    division.__qualname__ = division.__name__

    pool, worker = init_arq([sleepy, division])

    events = capture_events()

    await pool.enqueue_job(
        "division", _job_id="123", _defer_by=timedelta(milliseconds=10)
    )
    await pool.enqueue_job(
        "sleepy", _job_id="456", _defer_by=timedelta(milliseconds=70)
    )

    loop = asyncio.get_event_loop()
    task = loop.create_task(worker.async_run())
    await asyncio.sleep(1)

    task.cancel()

    await worker.close()

    exception_event = events[1]
    assert exception_event["exception"]["values"][0]["type"] == "ZeroDivisionError"
    assert exception_event["transaction"] == "division" # fails, transaction is sleepy
    assert exception_event["extra"]["arq-job"]["task"] == "division" # fails, task is sleepy

Expected Result
The correct transaction and arq extra metadata will always be attached to the correct events and not mixed between concurrent jobs.
Actual Result
It is not guaranteed that the correct transaction and arq extra metadata is attached to the correct events for concurrent jobs.

Hey @andreasdri thanks for reporting this and creating a test case! We will look into this


Why not use apply instead of commit?

The SharedPreferences editor apply() is more performant than commit(), so why not use it when we don't need the value being returned?

Hey @feinstein
I don't have answer on top of my mind. Why is the problem ?

Commit waits, apply is async.. Its on the android docs.

commit() returns a boolean value indicating if the write was (un)successful. apply() doesn't return anything. As the return value of commit() is not used at all at this point, I agree with @feinstein.


finances API

I'm getting data through the Finances API, but when I pass in the next_token page flip, it returns exactly the same data as the previous page.
(The different Next_Tokens return exactly the same data)
Did I get it wrong?
Helpppppppppppppppppppppppppppppppppppppppp!

Please ask questions in discussions.


Application error: a server-side exception has occurred (see the server logs for more information).

If I search for another city, for example Tijuana, or Mexico City, I get this error:

This seems to happen all the time when running it as a Vercel demo.

This seems to happen all the time when running it as a Vercel demo.

Same to me, Im getting this error on Vercel


[BUG] Can't edit the existing Harvester containerd registry setting, it display empty content

Describe the bug

When we already add values to containerd registry setting.

Then we click the edit settings button, we can't get the previous settings content to change

To Reproduce
Steps to reproduce the behavior:

Go to settings
Add valid setting values (Mirror, config) to containerd registry setting
Save the settings
Edit the containerd registry setting

Expected behavior

When edit containerd registry setting, can display previous saved settings
Can edit existing setting and save correctly
Support bundle

Environment

Harvester ISO version: master-75876dee-head (10/4)
Underlying Infrastructure (e.g. Baremetal with Dell PowerEdge R630): 1 node local kvm machine

Additional context
Add any other context about the problem here.

Hi, @TachunLin   I can't reproduce this.


Documentation update

Description

Updated documentation's example to use Swift 3.0 syntax.

Status

[ ] Review

Looks good, just one comment @danieladias


Loading...

I totally think it would be amazing once @tonyjaramillo gets the walking octocat done to use it as the loading screen. (except then I might want to slow the app down so I can see it more often)

The link is dead


[bugfix] Ensure correctness of isDurationValid when Object.prototype is extended

isDurationValid returns false negatives when Object.prototype is extended with additional properties. JSFiddle: https://jsfiddle.net/pcsn3vhL/
The proposed fix is to only enumerate an object's direct properties using Object.getOwnPropertyNames.

@anthonygood I'd use hasOwnProperty in the loop, because it is more portable.

Looks like this is fixed by: https://github.com/moment/moment/pull/4953


undefined local variable or method `logo_scale'

Were you able to get it working with solidus?
I install the gem and run the installer and got this when trying to print with everything at default.

I was able to do it with defaults on solidus 1.2.


Incorrect typing for fractionReached()

https://github.com/UnbounDev/node-strava-v3/blob/7880953ff924baaefde5ad8c47239f9c1d71b854/index.d.ts#L129
Should be of type number

Whenever you know an exact change to make, submit a PR. It's the easiest for the volunteer maintainers and mostly likely to get the change want faster.
It's faster to click "merge" then then is to open a up a terminal, make sure the project has a fresh check out, re-create your change, write a commit message, push and close the issue.
Plus, you get credit in the commit history when you submit a PR, no matter now trivial the change.
So please submit a PR for this even though it's trivial. Thanks.

My PR should correct this.


For solving error for cases when github repo is found however subdir is None

get_repository_url_and_subdir(PYPI, "kiwisolver")

kiwisolver is an interesting case.
This and some other package, I see the that we fail to validate because the package contains only binaries.
In package-locator, we may tweak the design by considering the stars and other fields as a reliable source of info, and we will return the repository from these fields even if we can't validate the subdirectory. I have opened an issue for this, and will fix it in due time.


NullPointerException in GatewayServicesManagementCheck

It seems that in
src/main/java/org/apereo/cas/web/config/CasSupportActionsConfiguration.java
the argument is missing in the constructor of GatewayServicesManagementCheck.
Currently:
    public Action gatewayServicesManagementCheck() {
        return new GatewayServicesManagementCheck();
    }

I think it should be:
    public Action gatewayServicesManagementCheck() {
        return new GatewayServicesManagementCheck(this.servicesManager);
    }

Without it there is a bug in line 43 of GatewayServicesManagementCheck.java

Good one. Do submit a PR plz.


Count oldLines and newLines when there are conflicts

Summary
Try to count oldLines and newLines when the hunk contains conflicts. If the patches have the same base file then oldLines should be valid. If base files are different then oldLines is deleted. newLines isn't very useful but I'm keeping the logic symmetric.

Reverted .gitignore

Can you remove the dist and lib files as well?

Removed


CB-4444 Fix token expiration issue (version 1)

Use credential provider with aws client builders instead of deprecated client creation -> clients always accessing credentials through credential providers (with depricated client -> it creates a static credential provider without refresh function, and that is used there)
Solution 1
Pros:

we can refresh the token more often (based on our custom cache), even if expiration time is close (can be configurable)
log expiration time for role arn

Cons:

custom credential provider

(note, not tested too well yet + if it will be acceptable, i will change the base branch to rc-2.15 if it's needed)
solution 2:  https://github.com/hortonworks/cloudbreak/pull/6772

retest this please

retest this please

@sodre90
i have reverted the usage of Amazon ClientBuilders -> reason is that, because of as we have used the deprecated form for creating a client, we often try to change its state later in our code -> the support of deprecated clients are solved in a way that the aws code checks was the client created with builder or not (with a volatile isImmutable variable), if it was it throws an exception anywhere where we want to change the state of the client (we are doing that in multiple places in the code)

retest this please


Foreground Image format only png supported

Foreground image i.e. image "bring to front" on top of already having a background image is invisible if jpg or webp or psd only png is visible. I tested the same on ios rive renderer runtime and it doesn't have the issue. So it seems to be an issue with unity rive renderer.

Hi @Saurabh7SSR, at this time only PNG is supported for Unity. Apologies for this, I thought there was an info banner in our docs that stated this, but I see there isn't. We're looking into supporting the other formats, hopefully soon.

No Problem. Thanks for confirming.

JPEG is now supported from v0.1.188 upwards. Please upgrade and let us know if you run into issues.


VimBindings development flow is not compatible with Revise.jl

It would speed up development if VimBindings worked with Revise. Doesn't currently work due to the early code loading necessary for VimBindings (see #19).
This may be as simple as julia -i -e "using Revise; using VimBindings". Nonetheless it should be verified and documented.

It should also be investigated whether Revise can be used to reload the REPL code if it is loaded from within the Julia config.
I don't believe Revise can do that, since it is loaded after the repl code in that case. But that should be ruled out as a solution to code loading.


Let PR authors re-run Jenkins job

Occasionally the jobs in Jenkins fail because of some flakiness.
The only way to re-run the Jenkins build is to push some changes to the branch to trigger a new build.
It would be useful to be able to manually force re-run of the Jenkins build.
As an example https://github.com/kubernetes/kubernetes has a bot with commands /retest and /test testName, and it is really convenient.
We don't have to do something as fancy, but at least some way of manually triggering the build is very important.
Example of flaky build failure: https://service-catalog-jenkins.appspot.com/job/service-catalog-PR-testing2/1151/console
[service-catalog] Running shell script
+ /var/lib/jenkins/workspace/service-catalog-PR-testing2/src/github.com/kubernetes-incubator/service-catalog/contrib/jenkins/cleanup_cluster.sh --kubeconfig /var/lib/jenkins/workspace/service-catalog-PR-testing2/src/github.com/kubernetes-incubator/service-catalog/k8s-kubeconfig
error: current-context is not set
[Pipeline] echo
Exception caught during cleanup.

/cc @kibbles-n-bytes

For that specific failure, what actually happened was that the cluster initialization code failed due to the issue fixed in the following PR: https://github.com/kubernetes-incubator/service-catalog/pull/1023 . If you rebase on master, that should fix everything.
The error reporting at the bottom of the Jenkins log is misleading though, sorry about that. Cluster initialization pretty much never fails so we haven't seen many results of the non-happy paths. I will fix that.
As to the re-running issue, I just looked into it and may actually be able to get something like /retest working.

Submitting /retest as a comment on a PR should now rerun the Jenkins tests! I tested it on your PR and it worked, though I'd like to see a couple more examples of it working from others before I close this.

Seems to be working!

Awesome, thanks


permission to use and modify your code

Hi Michelle - Thanks for sharing your work here.
https://github.com/michellemho/covid-19/blob/master/covid-19-papers/text_exploration.ipynb
Just wanted your permission to use and modify your code for academic research? I didn't see a specific license hence this outreach.

Sorry for the delay in response-- yes, that's absolutely fine.


Add link to Service Bus content about asynchronous messaging

Unsure about how to use relative links though.

@udidahan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@doodlemania2 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hey folks, any idea when the site itself will be updated?
https://docs.microsoft.com/en-us/azure/architecture/guide/architecture-styles/n-tier

It should be live within the next day :)

Hmm, it doesn't look like the update went through.
Is something broken?

It's possible! Me checks...

looks like sync got stuck. @MikeWasson is on the case! Standby

Just saw that the update went through! Thanks for getting this unstuck.
Looking forward to additional contributions to the docs!


Add Input components API

Lots of these are missing examples and elaboration, but it's a good start.

looks great, keep it up! :)


Curious about the original results for three metrics in MR-Score

Thanks to all the authors for this wonderful benchmark!
I am reaching out with a query regarding the MR-Score calculation formula: MR-Score = w_1 * max(0, MCC) + w_2 * Accuracy(step) + w_3 * Accuracy(reason)
I am interested in the original results for the three metrics(MCC, Accuracy(step), Accuracy(reason))
Could you please provide the specific numerical data for these metrics? I understand that this might be a lot of work, but this may help understand the models' performance thoroughly.
Thanks very much!

Hi @scorpio-nova, thanks for your issue. Indeed these sub metrics might provide another insight for the models' performance. I will update the paper and create the table for these sub metrics in the appendix soon. In the meantime, you can look for the submetrics you are interested in this json I crawled from the experiment outputs.
mr_scores_breakdown.json

Thanks for your timely response! This data works for me :)


Refactor of code and following PEP8 style guidelines

Last time I worked on my small improvement to add extra control regarding to the user permissions I noticed that there are quite some PEP8 violations and that some parts need a refactor to be better readable and easier to work with. (Check for instance the permission tests. They do their job, but are hard to understand.)
Fixing the PEP8 violations is quite easy, but refactoring large parts of the code may take several individual pull requests since it covers large parts of the codebase.
My proposal is to start with fixing all the PEP8 errors ASAP and to split up the refactor of parts like the test, the permission system etc. in order to limit the amount of time that has to be invested before a new project can be merged.
I can start with fixing all the PEP8 errors in the upcoming week if people can check and merge it soon after I propose the PR. Please let me know if we can start with this. :-)

@Ecno92,  your PR are very welcomed. @walterrenner , @yannik-ammann  or myself will review your PRs promptly to get ahead. Thanks again for your contribution.