Unable to build for Android with version 1.1.4+

I have been trying to build a unity project for Android, but whenever I use version 1.1.3, 1.1.4 or 1.1.5 the build will fail
DllNotFoundException: NatML assembly:<unknown assembly> type:<unknown type> member:(null)
NatML.MLEdgeModel.CreateSecret () (at ./Library/PackageCache/ai.natml.natml@1.1.4/Runtime/MLEdgeModel.cs:292)
NatML.Editor.NatMLSettingsEmbed.CreateEmbeds (UnityEditor.Build.Reporting.BuildReport report) (at ./Library/PackageCache/ai.natml.natml@1.1.4/Editor/NatMLSettingsEmbed.cs:50)
NatML.Hub.Editor.BuildEmbedHelper`1[T].UnityEditor.Build.IPreprocessBuildWithReport.OnPreprocessBuild (UnityEditor.Build.Reporting.BuildReport report) (at ./Library/PackageCache/ai.natml.hub@1.0.20/Editor/BuildEmbedHelper.cs:89)
UnityEditor.Build.BuildPipelineInterfaces+<>c__DisplayClass16_0.<OnBuildPreProcess>b__1 (UnityEditor.Build.IPreprocessBuildWithReport bpp) (at /home/bokken/build/output/unity/unity/Editor/Mono/BuildPipeline/BuildPipelineInterfaces.cs:499)
UnityEditor.Build.BuildPipelineInterfaces.InvokeCallbackInterfacesPair[T1,T2] (System.Collections.Generic.List`1[T] oneInterfaces, System.Action`1[T] invocationOne, System.Collections.Generic.List`1[T] twoInterfaces, System.Action`1[T] invocationTwo, System.Boolean exitOnFailure) (at /home/bokken/build/output/unity/unity/Editor/Mono/BuildPipeline/BuildPipelineInterfaces.cs:465)
UnityEditor.BuildPlayerWindow:BuildPlayerAndRun() (at /home/bokken/build/output/unity/unity/Editor/Mono/BuildPlayerWindow.cs:188)

I have tried building with both Mono and IL2CP and with several editor versions in the range 2021.3-2023.2.
I am building on linux.
I am new to Unity, so I might be doing something wrong. I am hoping you can give me some pointers and if you need me to dig out more information, I'll be happy to help.
Also, I noted there seem to be some issues with the inter-dependencies between packages that also seem to nag. Some packages, e.g. yolox-unity, depend on earlier versions or have dependencies that do. In the unlikely case it's not me misunderstanding something fundamental, this will cause problems using the latest versions.

Hey @peternormann, you're getting this error because we don't yet have support for Linux. Given that you are only building on Linux (and not trying to run on the platform), we can add a workaround to get you past this error. I should be able to get an update with the workaround in a day or two.

Also, I noted there seem to be some issues with the inter-dependencies between packages that also seem to nag. Some packages, e.g. yolox-unity, depend on earlier versions or have dependencies that do. In the unlikely case it's not me misunderstanding something fundamental, this will cause problems using the latest versions.

Please report all of these! We've made some API changes which might cause compiler errors. We've been updating the predictor samples, but haven't yet gotten to all of them.

Fixed in 1.1.6.


HapticFeedback doesn't work on IOS except HapticFeedback.vibrate()

Steps to reproduce
Run any Flutter project and add one of the following HapticFeedback lines of code
Expected results
I would expect all methods of HapticFeedback to function properly on IOS
Actual results
lightImpact(), mediumImpact(), heavyImpact(), selectionClick() don't work on IOS (on my iphone 11 pro ) but interestingly HapticFeedback.vibrate() works fine.
also all methods works on my Samsung S21
Code sample
Code sample
HapticFeedback.lightImpact(),
HapticFeedback.mediumImpact(),
HapticFeedback.heavyImpact(),
HapticFeedback.selectionClick()

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.24.3, on macOS 14.7 23H122 darwin-x64, locale fr-CH)
[!] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    ✗ cmdline-tools component is missing
      Run path/to/sdkmanager --install "cmdline-tools;latest"
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run flutter doctor --android-licenses to accept the SDK licenses.
      See https://flutter.dev/to/macos-android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2024.1)
[✓] VS Code (version 1.94.2)
[✓] Connected device (3 available)
[✓] Network resources

Thanks for the report. I do see the same behavior upon running the code sample on iphone 6s with latest versions. Only HapticFeedback.vibrate() works but not other options.

 runnable code

import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      home: Scaffold(
        appBar: AppBar(
          title: Text('Material App Bar'),
        ),
        body: Center(
          child: ElevatedButton(
              child: Text('Tap here'),
              onPressed: () {
                HapticFeedback.vibrate();
              }),
        ),
      ),
    );
  }
}

Interestingly, a similar issue is open for Android wherein there are some comments mentioning it works on iOS.
https://github.com/flutter/flutter/issues/73987#issuecomment-832431271
https://github.com/flutter/flutter/issues/73987#issuecomment-844051577
stable : 3.24.3
master : 3.27.0-1.0.pre.181
beta : 3.27.0-0.1.pre

That code is here.
https://github.com/flutter/engine/blob/48ff670d256bcac91f2f2efcce8cae1abf8cd1ef/shell/platform/darwin/ios/framework/Source/FlutterPlatformPlugin.mm#L251-L259

I tried it on iOS 18 and I feel the haptic feedback for heavyImpact() and selectionClick() with the sample code https://github.com/flutter/flutter/issues/157442#issuecomment-2434529486 on master.
@max-anders what version of iOS are you on?  @darshankawar you said latest versions, does that mean iOS 18?
Hmm, initWithStyle: is marked as "to be deprecated", maybe it's broken in some scenarios?
- (instancetype)initWithStyle:(UIImpactFeedbackStyle)style API_DEPRECATED_WITH_REPLACEMENT("+feedbackGeneratorWithStyle:forView:", ios(10.0, API_TO_BE_DEPRECATED));

Not sure if the replacement works better:
- (void)vibrateHapticFeedback:(NSString*)feedbackType {
  if (!feedbackType) {
    AudioServicesPlaySystemSound(kSystemSoundID_Vibrate);
    return;
  }

  if<EMAIL_ADDRESS>isEqualToString:feedbackType]) {
    [self vibrateHapticFeedbackWithStyle:UIImpactFeedbackStyleLight];
  } else if<EMAIL_ADDRESS>isEqualToString:feedbackType]) {
    [self vibrateHapticFeedbackWithStyle:UIImpactFeedbackStyleMedium];
  } else if<EMAIL_ADDRESS>isEqualToString:feedbackType]) {
    [self vibrateHapticFeedbackWithStyle:UIImpactFeedbackStyleHeavy];
  } else if<EMAIL_ADDRESS>isEqualToString:feedbackType]) {
    [[[UISelectionFeedbackGenerator alloc] init] selectionChanged];
  }
}

- (void)vibrateHapticFeedbackWithStyle:(UIImpactFeedbackStyle)feedbackStyle {
  if (@available(iOS 17.5, *)) {
    NSView *view = self.engine.viewController.viewIfLoaded;
    if (view) {
      [UIImpactFeedbackGenerator feedbackGeneratorWithStyle:feedbackStyle forView:self.engine.viewController.viewIfLoaded];
      return;
    }
  }
  // Fallback if new not loaded (-feedbackGeneratorWithStyle:: requires non-null) or < iOS 17.5.
  [[[UIImpactFeedbackGenerator alloc] initWithStyle:feedbackStyle] impactOccurred];
}

@darshankawar you said latest versions, does that mean iOS 18?

@jmagman No,  I meant Flutter versions. I verified on iOS 15.3.1 on which only vibrate() works but not other options.

@jmagman Hello, no, I'm on IOS 17.6.1


Re-integrate direct I/O

After #706 is merged, the ad-hoc implementation of direct I/O will temporarily not be available in the raw dataset. It should be implemented as an I/O backend instead, which is then available for most file formats.

[ ] Implement direct I/O backend
[ ] Add I/O backend selection, where each dataset can return its supported io backends
[ ] Replace "enable_direct" checkbox with a backend dropdown selection

Can be added to the buffered reader, which should also allow Windows support. Can also work on liburing backend instead, which is more forward-looking. #268

Can be added to the buffered reader, which should also allow Windows support. Can also work on liburing backend instead, which is more forward-looking. #268


Define new state type that encompasses STATE_VECTOR_LIKE plus density matrices and use it in fidelity function

STATE_VECTOR_LIKE exists.  We likely need an equivalent for density matrices (should be different, though, right?)
This has not been added to fidelity in measures.py

In general, there is no way to distinguish between a density matrix and the state tensor of a pair of qudits (a type which is encompassed by STATE_VECTOR_LIKE). For example, consider the matrices
A = [[1, 0]
     [0, 0]]
B = [[0.5, 0.5]
     [0.5, 0.5]]

Both are valid density matrices for a single qubit, but they are also valid state tensors for two qubits. In the first case, their fidelity is 0.5, while in the latter, their fidelity is 0.25. Therefore, if we want functions like cirq.fidelity to accept both kinds of inputs, they will need additional information in order to distinguish these two cases when the inputs are two-dimensional arrays with the same shape. I can think of two solutions:

Force the user to specify the qid shape in this situation. I don't like this solution because I expect that the vast majority of the time, the user will be using density matrices, not state tensors.
Default to assuming density matrices, with a flag that can be set to change it to state tensors. Unfortunately the flag would have a complicated name like two_dimensional_arrays_are_state_tensors or something like that.

Discussed on Cirq Cynq:
A final idea we came to as a conclusion to explore further: type system + a central utility function to interpret numpy arrays (by default as a density matrix).

More details on discussion: Kevin's example shows that in some contexts numpy array is insufficient to describe a quantum state. In such contexts, the additional information must be specified somehow. Below are a few possible approaches we discussed:
Types
Very extensible in the sense that if in the future we find out we want to attach more information to states, the types would offer a natural place to do it. Also, type signatures would help document the code. However, users are burdened by having to wrap their states, so this is considered a "high friction" approach.
Keyword arguments
Continue to use numpy arrays, but in a few places where ambiguity exists use keyword arguments, e.g.:
fidelity(state_vector1=np.array(...), density_matrix2=np.array(...))
fidelity(density_matrix1=np.array(...), density_matrix2=np.array(...))

Function names
Put the extra information in function names instead:
fidelity_state_vector_vs_density_matrix(np.array(...), np.array(...))
fidelity_density_matrix_vs_density_matrix(np.array(...), np.array(...))

Proliferates functions and pollutes namespace making autocomplete annoying.
Shape argument
Have functions in which ambiguity arises accept an additional parameter:
fidelity(np.array([[0.5, 0.5], [0.5, 0.5]]), np.array([[1, 0], [0, 0]]), qid_shape=(2,))

Inference
Use types, but mostly internally and implement inference so that wherever a state is expected users can pass in either a numpy array or even a python list (for low friction) or cirq's special type for representing quantum states (for resolving ambiguity in cases where inference fails), e.g.:
# cirq infers that both of these arrays describe single-qubit states
fidelity(np.array([0, 1]), np.array([1, 1])/np.sqrt(2))
# user tells cirq explicitly that the first is a single-qubit state, cirq infers the second
fidelity(density_matrix([[0.5, 0.5], [0.5, 0.5]]), [[1, 0], [0, 0]])

I like using types to solve problems and specify APIs, but I accept the "high friction" argument. Function names solution leads to proliferation of functions and pollution of cirq's namespace which would make autocomplete annoying (scrolling/searching through more names).
I think the real contenders are kwargs, shape and inference. Among these I think inference is the best because the other two make it harder to pass states between functions (you need to pass qid_shape or the right kwargs along).

@viathor thank you so much for capturing the details of the discussion - awesome notes.
+1 for "inference" as well

I like to code against types (but I'm biased as I come from a statically typed background)
explicit language makes the code more readable (I find fidelity(density_matrix([[0.5, 0.5], [0.5, 0.5]]), [[1, 0], [0, 0]]) more readable than fidelity(np.array([[0.5, 0.5], [0.5, 0.5]]), np.array([[1, 0], [0, 0]]), qid_shape=(2,))
well documented inference rules will reduce the overhead for users to learn the "type language" for the most frequently used paths (e.g. density matrices in the fidelity function's case)

I also like inference. If I understand correctly, this is how it would work:

We create a QuantumState class that stores a numpy array and a qid shape.
In the example fidelity(density_matrix([[0.5, 0.5], [0.5, 0.5]]), [[1, 0], [0, 0]]), the function density_matrix returns a QuantumState.

There is still the question of how the function density_matrix should infer the qid shape of its input. For example, a 4x4 density matrix could have qid shape either (2, 2) or (4,). For an nxn matrix, if n is a power of 2 then we should probably assume qubits. If n is not, then I'm not sure what we should do. Perhaps use the prime factorization?

For JSON serialization of the QuantumState data type it would be nice to have https://github.com/quantumlib/Cirq/issues/2742.


ControlledTree: cleanup copiled SparseTree code

Changes

SparseArray class has two symbol properties defined: immerable and Symbol.iterator. For some reason compiled javascript looks like this:
var _b;

export class SparseArray {
  constructor() {
      this[_b] = true;
      // ...
  }

  [(_b = immerable, Symbol.iterator)]() {
    // ...
  }
}

This causes some problems for terser when minimizing code and removing dead code to reduce bundle size. Minimized code looks like this:
(_b = lC), Symbol.iterator;

Which under "use strict" mode throws runtime error because _b is not defined: https://github.com/iTwin/viewer/issues/283
Setting immerable property value in constructor seems to result in cleaner compiled javascript code which does not cause problems for terser:
Compiled javascript code:
export class SparseArray {
  constructor() {
      // ...
      this[immerable] = true;
  }
  [Symbol.iterator]() {
    // ...
  }
}

Terser output:
Symbol.iterator;

This probably should be fixed at terser or typescript level (maybe some changes to tsconfig would solve this). But at least for now this provides a workaround to avoid runtime error when building apps with @bentley/react-scripts
Testing

Building locally with different configurations.

@Mergifyio backport release/4.2.x


Add traceFlags to SpanContext

As an ongoing effort to minimize #325, I will decouple some independent changes into small PRs. This PR adopts several ideas from the https://github.com/typelevel/otel4s/pull/236.

Resolved by #236.


[Docs] Remove session-mismatch error workaround

Summary
Human Summary
Remove session-mismatch workaround section in the quickstart documentation page.
This workaround is no longer needed as per #326
AI Summary
reviewpad:summary
Type of change
Select one or more:

[ ] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[x] Documentation
[ ] Other (specify)

Sanity Checklist

[ ] I have tested my changes using the available tooling
[x] I have performed a self-review of my own code
[ ] I have commented my code, updated documentation and left TODOs throughout the codebase

@red-0ne it just worked!?


Private files

Problem
User should be able to add/get/list public & private files as if interacting with a file system
Solution
Create an FFS object that contains both a public & private tree of nodes. And exposes an api to:

listDir
makeDir
addFile
getFile
getNode

The private file tree implements an encrypted DAG node structure as described here: https://whitepaper.fission.codes/file-system/private-directories
Note for @icidasset: I see that you use ipfs.catReadableStream in drive. Unfortunately WebCrypto does not allow encrypting/decrypting streams so we can't implement that yet :unamused:. Which isn't great, especially for large file I have a plan for implementing streaming tho, tracking here: https://github.com/fission-suite/ts-sdk/issues/19
Closes https://github.com/fission-suite/ts-sdk/issues/5
Closes https://github.com/fission-suite/ts-sdk/issues/6

Oh yeah, this might be good to know, how do I start using this? :sweat_smile:
So based on previous conversations I guess we're starting out with a single private directory in the root. And for that we need some auth, which will give us a private key, which I then use in ffs.resolve(cid_from_dnslink, key)?

👀

Moving from Discord here

An idea for ontology:
class FileSystem

Stateful imperative wrapper / main interface
class Tree.Public

Stateless public tree type
class Tree.Private

Stateless private tree type

Some POSIX-based interface thoughts:
const ffs = new Fisson.FileSystem("Qm12345")
await ffs.mount() // defaults to background prefetching. Awaits top-level only.
await ffs.ls()
// ["photos/", "documents/"]
await ffs.cd("photos/vacation")
await ffs.ls()
// ["vacation.png"]
const myPhoto = await ffs.cat("vacation.png")
const myPhotoData = await ffs.metadata("vacation.png")
await ffs.map(/* some action on each dir/file */)

Also just to clarify: all paths in this API are full paths, yes? e.g. you need to pass like public/foo/bar/baz.jpg to the top-level object

Also just to clarify: all paths in this API are full paths, yes? e.g. you need to pass like public/foo/bar/baz.jpg to the top-level object

At the moment yes. I'll be incorporating your suggestion around a stateful "Session" class soon


How to install a specific imagemagick version?

Hello,
I'm trying to install a specific Imagemagick version, but this doesn't seem to work.
With the latest version, I tried :
./imei.sh --no-sig-verify --force-im --im-version=7.1.0-47
But It still compiles ImageMagick 7.1.1-15 in /usr/local/bin/magick
I also downloaded IMEI 6.7.0 and tried the same after a "rm /usr/local/bin/magick", I changed manually the version in /versions before running imei.sh, but everything I try installs ImageMagick 7.1.1-15.
Am I missing something ?
Thanks.

I'll check that tomorrow.

You were supposed to use --im-version 7.1.0-47 instead of --im-version=7.1.0-47. However, version 6.10.2 should support both.


Significant input lag in editor since 3.2

Godot version:
3.2 Stable (Mono)
OS/device including version:
Windows 10
Intel UHD 620 graphics
Issue description:
Tried out 3.2 today. I am getting severe input lag when interacting with the UI, sometimes up to 10 seconds, Menu highlights are out of position (presumably from the events for highlights being so far behind). Interacting with UI elements also has the same lag.
The delay itself seems to be quite variable, anywhere between 0.5s and 10s, but is always present. I am not sure if anything particular causes the longer delays. It seems to be random for me.
If I swap back to 3.1.2, there is no problem.
I am including video recordings to demonstrate.

I'm unsure how I can provide further information to diagnose this, but happy to do additional tests as needed.

Attached is a short 30s profile interacting with the menus + about page. As before, there was significant input lag during the test. CPU is idle for almost all the test - it doesn't look CPU bound at all.
Profile.zip
I used Visual Studio's profiler for these results. Are these results usable? Or would you like me to use VerySleepy specifically?

How much RAM do you have? I am seeing something similar, but only in a moderately large 3D project while the game instance is running. I was suspecting the debugger thread, but it's not happening while a 2D project is running, so it's most likely not just the debugger, but also the amount of data involved.

I used Visual Studio's profiler for these results. Are these results usable? Or would you like me to use VerySleepy specifically?

I personally don't have visual studio or a windows machine... Usually a screenshot of the profile chart is all that is needed, it will show up what is taking all the time (or a couple of screenshots ranking by which functions are taking the most themselves, and the most with themselves + child functions).

How much RAM do you have? I am seeing something similar, but only in a moderately large 3D project while the game instance is running. I was suspecting the debugger thread, but it's not happening while a 2D project is running, so it's most likely not just the debugger, but also the amount of data involved.

16GB on the device in question. I get the input lag with a new empty project.

I personally don't have visual studio or a windows machine... Usually a screenshot of the profile chart is all that is needed, it will show up what is taking all the time (or a couple of screenshots ranking by which functions are taking the most themselves, and the most with themselves + child functions).

I am pretty suspicious of the 20% time spent in process_events, with a large amount if in spent parse_input_event. I don't know Godot's internals well enough, but they seem high?

That provides some info, but really what we need is something like this (this is an example captured with valgrind):

A list of functions, with the percentage of time spent in each function.
From looking at the visual studio docs, it may be called 'functions view', (or maybe summary view, it isn't clear). If you think about it, we want to know which EXACT functions are using up lots of time. If you press a key or move a mouse, anything could be happening as a result of that.
Another useful bit of info is what percentage of time is within Godot and what within other processes (and what those processes are).

CSV of inclusive function calls attached. I've also included the same test using 3.1.2 for a comparison.
FunctionSummary.zip
Whilst trying to debug this, I have noticed some more oddities in 3.2 for me:

If I change the window size, the window will not redraw (it will be completely black) until an input event occurs (e.g. I move the mouse or click within the window).
If I show the about dialog (Help -> About), the dialog will not show until I click on the editor window again. At this point the dialog flashes on screen, and then disappears again (presumably from the second click being away from the dialog).

Putting these both here, as I think its all input related....
Video of the screen resize being black until a new event happens:

Video of the about window. Notice that after the menu is clicked, the screen does not update. If I move to the left of the screen, I will get the window resize cursor on the edge of the about window (where the window should be). If I move to the right, as soon as I hit the scrollbar on the about window, a redraw seems to happen and I get the window as expected.

:+1:  That does suggest the possibility that the real problem is that rendering the screen on demand isn't working correctly. It is even possible that the 'lag' is not real lag at all, but godot not realising that the frame has not been displayed. That would explain why there is nothing obvious in the profile.
Of course I can't say this with any certainty, only you know the behaviour. You could try setting the IDE update mode (with the spinner) to continuous and see what effect this has. I'm presuming you have it set to 'update when changed'. If not, then something very strange is going on with your screen updates.

You could try setting the IDE update mode (with the spinner) to continuous and see what effect this has.

That indeed fixes it. I guess that means it's the display not updating rather than input lag as initially thought.

Could be something in the windows OS / SwapBuffers code, I don't really know that side so I'll bow out now. There were recently some changes adding vsync via compositor, could possibly be something to do with that. I've had similar problems in the past using glAddSwapHintRectWIN function on some devices.
Or it could be graphics drivers, although I don't usually like to try and blame third parties .. and you'd have thought you'd see similar problems in other programs...

This issue reminds me a lot of #23069 now. Try updating your graphics driver to the latest version provided by Intel. Alternatively, start the Godot editor with the --verbose command-line argument, which can also mitigate the issue.

Updating to Intel drivers <IP_ADDRESS>55 fixes the issue for me, thanks.
I tested the others suggestions before updating. Using --verbose made no difference for me. Interestingly, it wasn't actually the "Update Continuously" setting that also fixed it, but rather the "Show Update Spinner" setting alone (ie. with "Update Continuously" still off). For some reason the presence of the spinner resulted in the screen updating correctly. I was unable to tell this was a regression or not, since I can't disable the spinner in 3.1.2 - the option doesn't do anything for me when toggled. The problem could have always been with on the older drivers and just hidden by having the setting always on.

Thanks for answering :slightly_smiling_face: I'll close this issue as a duplicate of #23069 then.


Fix wrong TCP flags and CNP flows in Antrea Traceflow

This PR fixes two bugs:

When destination Service is set, the actual tcpFlags is set to 0 if tcpHeader exists with tcpFlags=0 or not set, which should be forced set to 2.
When CNP/ANP drop rule exists, Traceflow cannot generate OVS flows properly.

Codecov Report

Merging #1602 (9caebf0) into master (9d3d10b) will decrease coverage by 22.92%.
The diff coverage is 14.70%.

@@             Coverage Diff             @@
##           master    #1602       +/-   ##
===========================================
- Coverage   63.31%   40.39%   -22.93%
===========================================
  Files         170      106       -64
  Lines       14250    12908     -1342
===========================================
- Hits         9023     5214     -3809
- Misses       4292     7220     +2928
+ Partials      935      474      -461

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
40.39% <14.70%> (-0.89%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/antrea-agent/agent.go
0.00% <0.00%> (ø)

cmd/antrea-agent/options.go
21.69% <0.00%> (+0.97%)
:arrow_up:

pkg/agent/agent.go
12.20% <0.00%> (-36.51%)
:arrow_down:

pkg/agent/agent_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/cniserver/pod_configuration.go
34.52% <0.00%> (-19.24%)
:arrow_down:

pkg/agent/config/node_config.go
0.00% <0.00%> (-100.00%)
:arrow_down:

...gent/controller/noderoute/node_route_controller.go
32.20% <ø> (-14.26%)
:arrow_down:

...agent/controller/traceflow/traceflow_controller.go
0.00% <0.00%> (-82.70%)
:arrow_down:

.../agent/flowexporter/connections/conntrack_linux.go
28.37% <0.00%> (-0.79%)
:arrow_down:

pkg/agent/proxy/proxier_linux.go
0.00% <0.00%> (-25.00%)
:arrow_down:

... and 157 more

/test-all

The fix LGTM, but hope we can improve comments and tests to enhance the readability and validation as well.

@lzhecheng Could you take over this patch since I may not have enough time before the deadline of this release?

@antoninbas Here it says Skipping inter-Node Traceflow test but it is actually in TestTraceflowIntraNode. Did I miss anything?
https://github.com/vmware-tanzu/antrea/blob/master/test/e2e/traceflow_test.go#L71

@lzhecheng thanks for pointing this out. That skip logic should be in the other (inter-Node) test. I verified that the test was sometimes failing in CI because of this... I also noticed that some comments are wrong (https://github.com/vmware-tanzu/antrea/blob/370e2f4e011da38b0559adca702243646b5bbc48/test/e2e/traceflow_test.go#L112-L118). I'll open a PR right away...

In the new e2e test, networkPolicyDelay is allocated for ANP to be realized instead of using antctl get networkpolicy like other traceflow tests. The reason is that I cannot get ANP in a antrea-agent pod with antctl. I am not sure if there's something wrong with antctl or it is the way I was using that is wrong.
@GraysonWu could you please verify if antctl get networkpolicy -T anp works well now? Also you may want to update this doc:
https://github.com/vmware-tanzu/antrea/blob/master/docs/antctl.md
It seems "antctl get networkpolicy -T" is not mentioned.

/test-all

/test-windows-conformance
/test-conformance
/test-e2e
/test-ipv6-all
/test-ipv6-only-all

/test-all-features-conformance

/test-windows-conformance

/test-windows-conformance

/test-windows-conformance

/test-all

/test-windows-networkpolicy
/test-ipv6-all
/test-ipv6-only-all

I rebased this PR because windows-conformance test is failing. Now antrea-windows image name is the harbor one but code cloned to Windows VM doesn't include the latest change in Makefile.
https://github.com/vmware-tanzu/antrea/blob/master/ci/jenkins/test.sh#L243
Code above should be improved so latest change can be included in a PR even if it hasn't been rebased to TOT.


Make script installable

Via curl I think... :/

Need to check on Bash tomorrow...

Work fine, pardner!


Error message in log when send server start.

Using the latest version of All The Mods 6
DiscordIntegration-2.0.1 (MC 1.16.3)
https://pastebin.com/TLSp3ZAv
Any further information needed please let me know

How did you manage to fix this?

Add your clientid to this page https://discordapi.com/permissions.html#805399632
Make sure you also New Requirement: Enable Server Members Intent on this bot page


Add line numbers to result output (#3)

Before I review this, thanks so much for contributing! This is the biggest PR I've received thus far. Great work.

Works really well, thanks for your work!
If you feel like it, it would be nice to add a printLineNumbers flag to PrintOpts, so this can be disabled from the command line.

Thank for your quick review! I will fix code according to your comments. I find the idea with flag very interesting and useful, I can do that as well :)

Could you please review again? I finished with fixes. Thanks in advance :slightly_smiling_face:

Looks good! I'll merge this once it's all green. Thank you so much for contributing.


Chartjs is fully redrawn on every update instead of just updated

It seems that since the whole data object is updated on the chart object, the chart loses all it's metadata and it redraws the whole chart from scratch. That is why the pie chart on your example always animates from 0 instead of just changing the slices dynamically.
I managed to get around it currently by changing the refreshChart function to the following
var refreshChart = function () {
   var d = ko.toJS(chartBinding.data);
   chartData.data.datasets[0].data = d.datasets[0].data;
   activeChart.update();
   activeChart.resize();
};

but of course this only works in the specific case of one dataset and nothing else changing...

As mentioned in the other ticket currently I am unable to work on this lib, but I accept PRs.


Update to latest many-rs

Make main great again.

I'll merge this as I need it for the base of my next PR. Easier to just start on main.


3.0.0 Beta Events Error

Describe the bug
When I installed 3.0.0 and edited Client.ts, TS-Node send me 4 errors.
Error on the screenshot.
What should I do?

Read the beta docs


[RDBMS] az mysql flexible-server replica create: Add parameters to support cross region paired vnet

Related command

az mysql flexible-server replica create --vnet --subnet --private-dns-zone

Description

Creation of cross region (paired) read replica needs to have a different vnet configuration if the source server is on private access as the vnet settings from the source does not get carried over to the replica.
If the location passed is different the source server, it is identified as a cross region (paired) region replica. In such a case, user can also pass additional parameters for configuring private access for the replica as well: private-dns-zone for replica, subnet, vnet

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR title and description has followed the guideline in Submitting Pull Requests.

[x] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

RDBMS


Apply php8.1 in Rector preset

Q
A

QA?
✔

Continue apply php 8.1 set.

Ready to merge 👍

Ready to merge 👍


BrokerService.UnregisterSubscriberAsync deletes the subscriber actor message queue

When my actor after handling a specific TMessage unsubscribes from it, the subject method removes the corresponding subscriber from _queues  ConcurrentDictionary as well as the message queue. Hence, subsequent messages are not delivered.
await StateManager.RemoveAsync(tx, reference.GetQueueName());
await StateManager.RemoveAsync(tx, reference.GetDeadLetterQueueName());
ServiceEventSourceMessage($"Unregistered subscriber: {reference.Name}");
_queues.TryRemove(reference.GetQueueName(), out reference);

Thank you for taking the time to investigate this. I've published a new version (4.5..4) which should resolve this issue. Please have a look and let me know.

@loekd I see the 4.5.4 package of "ServiceFabric.PubSubActors", but I can't update my NuGet package yet because the "ServiceFabric.PubSubActors.Interfaces" NuGet package isn't yet update to version 4.5.4

@loekd Thanks a lot for the fix. Will be testing this the next spring. However, as @Sterlingg mentioned we do need NuGet to be fixed first.

Sorry, there was an error in the build pipeline. It's published now.


Remove content-type from static website upload command

Running through this quickstart myself, I ran into issues where my Azure static website wasn't properly loading CSS content because my .css files were being served with MIME type text/html instead of text/css. Removing the explicit content-type flag from the az cli command caused the tool to properly set the content type for all of my files, letting my website work as expected.
It looks like this guide was specifying that to avoid situations where unrecognized filetypes were being given a content-type that meant they wouldn't be displayed in-browser as text. That's definitely a valid problem, but I'd imagine your average developer going through this tutorial is going to be primarily uploading HTML/CSS/JS/etc files that will be properly picked up by the content-type inference system. In that use case, not forcing text/html for every single file is going to be the path of least surprise.

@lazerwalker : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


[Feature request] Manual control of legend placement

Describe the feature
Best doesn't always work. For example, it seems to ignore Hlines. Not a problem when showing the figure because the legend is draggable (though a bit annoying to move it every time) but when saving there's no way around it.
Is there currently a (suboptimal?) way to do this?
Probably by accessing the axes?
Another way is to show, drag to desired location, then save the figure from the MPL interface.
Describe the solution you'd like
Not sure where it should go exactly. In show/save? In Figure init?

Could also add a control for the number of column in the legend.


feature: Add slots

Hi @RED143 - please ping me about this again next week; I need to take the time on Monday to actually review. Looking great!


influxdb2: init at v2.0.2

Signed-off-by: David Anderson<EMAIL_ADDRESS>Motivation for this change
InfluxDB 2.0 is GA upstream.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is the PR for the revert https://github.com/NixOS/nixpkgs/commit/fbc4af5725bb8e3449ac84bffb870a3f4047220b and the PR https://github.com/NixOS/nixpkgs/pull/104484

Yup. I think I corrected the ofborg failure, but I'm waiting for the CI verdict to be sure.

@offlinehacker @zimbatm ready for review. Same PR as last time, except it passes ofborg this time :)


use getRunningAVDWithRetry instead of getRunningAVD

Hi, team. Could we use getRunningAVDWithRetry() instead of getRunningAVD() ?
I occasionally run into an issue where getRunningAVD() timeouts.
2022-08-29 10:25:01:887 [W3C] Encountered internal error running command: Error: Error getting AVD. Original error: Did not get the initial response from the Emulator console at <IP_ADDRESS>:5554 after 5000ms

I feel this is more likely to happen when running many emulator sessions in parallel. I hope retrying would mitigate this. I use old uiatutomator2 (1.57) but I believe it happens with the latest version.

humm.. I confirmed creating a session works well with Appium2 and latest uiautomator2 driver 🤔

These CI failures are lated to the recent changes we are doing to dev modules (getting rid of gulp). I'll try to address it in https://github.com/appium/appium-android-driver/pull/755, so you could rebase afterwards.

Cool, thank you for taking a look!

I have updated the imports. Please rebase your PR with master


Update partner package versions

cc @Eilon \ @muratg \ @divega \ @bricelam

Haven't run the tests as yet. Verified this compiled though.

Please wait until @bricelam reviews.

LGTM assuming we've made conscious decisions regarding my comments.

You may need to update some binding redirects too.


US78151 - Don't fetch filter items for a small number of enrollments

The call to fetch filters is expensive, and is largely pointless if a user only has a handful of enrollments. If a user only has a small number of enrollments, there's no need to do the (expensive) calls to fetch filters - if absolutely required, the search functionality should be enough.
To do:

[x] Check with Bob to make sure 20 is the right magic number

Code LGTM. I wonder if we should wrap filterSection in a dom-if as well just so we don't initialize it for 99% of people, but I haven't measured any performance impact or anything.

Ah, right - gave that a shot, but was reminded of this issue once again, wherein dom-if doesn't work well with dynamic content.
Did update it a bit to add the _hasManyEnrollments property though, as that's a bit nicer to look at.

:+1:

@apalaniuk Redid it a bit, again. Back to the original way, since sometimes things weren't happening in quite the right order, causing the menus to disappear when they shouldn't.
Also changed to hide both filter and sort menus, as per Bob.

Tested with accounts over/under admin enrollment limit, looks good.

Noice, thanks! :)


fix docs for podman build

podman build docs should now reflect that the --layers default value is true.
Signed-off-by: baude<EMAIL_ADDRESS>

LGTM

LGTM
@rh-atomic-bot r+


Invalidate ListCollectionViewLayout after device rotation

New issue checklist

[x] I have reviewed the README and documentation
[x] I have searched existing issues and this is not a duplicate

General information

IGListKit version: 3.2.0
iOS version(s): 11.2.5
CocoaPods/Carthage version: CocoaPods 1.3.1
Xcode version: 9.2
Devices/Simulators affected: All
Reproducible in the demo project? (Yes/No): Yes, Storyboard demo for example
Related issues:

Hello, is there a way to invalidate ListCollectionViewLayout after device rotation? It seems that when I use this layout and rotate my device, sizeForItem is not triggered in section controllers. It is working fine when switching back to UICollectionViewFlowLayout. Any advice would be appreciated. Thanks!

Hey @jurex !
You should be able to do this in your view controller. See Apple's UIViewController docs and look for the traitCollectionDidChange callback.

Thanks @jessesquires 👍
I've ended up with something like this:
override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
        super.traitCollectionDidChange(previousTraitCollection)
        adapter.reloadData(completion: nil)
}

It's not probably the most effective solution, but it's working. Thnx again for great library✌


Defaulting to HTTPS on YouTube

This is a minor issue, but when you supply a YouTube link without an http:// or https:// prefix, the first output line is:
WARNING: The url doesn't specify the protocol, trying with http

Because HTTPS is default and expected on YouTube these days, it would be nice if youtube-dl defaulted to it.
It seems that a condition or a call to a helper function here is all we would need.
Thanks for your time.

youtube-dl supports not only YouTube, some of which are only accessible by http.

I'm aware of that. It would be extremely simple to check the URL against a list of domains know to support HTTPs, though. That's what I was suggesting.

Note that in the case of YouTube videos the extractor matches http:// urls and it will do all the requests with htttps://, so it won't use any insecure connection.


Add optional profile for accepter and requester

what

Allow user to pass in optional profile to be used when assuming the specified role.

why

As stated in the issue, if you normally configure profile in your aws provider block, plan will fail with the following message. This is because the default credentials don't have permission to assume the specified role.

Refreshing Terraform state in-memory prior to plan...
The refreshed state will be used to calculate this plan, but will not be
persisted to local or remote state storage.

Error: error configuring Terraform AWS Provider: IAM Role (arn:aws:iam::XXXX:role/vpc-peering-role) cannot be assumed.

There are a number of possible causes of this - the most common are:
  * The credentials used in order to assume the role are invalid
  * The credentials do not have appropriate permission to assume the role
  * The role ARN is not valid

Error: NoCredentialProviders: no valid providers in chain. Deprecated.
	For verbose messaging see aws.Config.CredentialsChainVerboseErrors

Also, there was a question of whether or not passing in an empty string would be okay for the AWS provider and it seems to work fine.
references
closes https://github.com/cloudposse/terraform-aws-vpc-peering-multi-account/issues/7

@dtw45 could you please allow upstream maintainers to make changes to your branch?
https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#:~:text=to your branch.-,Enabling repository maintainer permissions on existing pull requests,like to allow commits on.
or run the following commands locally and commit:
make init
make readme
terraform fmt

@SweetOps Ran the above commands locally and pushed the results.
make readme exited  with an error.
* Package gomplate already installed
* Package terraform-docs already installed
make: gomplate: No such file or directory
make: *** [readme/build] Error 1

/test all

@dtw45 pls rebase your branch with current master

@SweetOps done

/test readme

@SweetOps I believe I resolved the reason why test/readme failed. Could we retest that?
Assuming that passes is there anything else you need from me before this can be merged?
Thanks!

/test readme

/test all


False positive: sizeIs == 1 (ComparingUnrelatedTypes)

When using the sizeIs method, a false positive is produced:
object A {
  val b = Seq("a", "b").sizeIs == 2
}

As a work around for now it is possible to achieve the same thing with .sizeCompare(2) == 0 without getting a warning, but it is not as convenient / readable.


Where did the font settings go?

On your github README the screen shows default font options to choose from, but on the actual software it is missing as well as in the screen that you have on your website
I don't know any other software which could work with font settings under wlroots, so It would be nice to see it back.

Sorry, it turns out you can choose a default font in the GTK theme settings menu, I will try rebooting, if settings will persist I will close the issue

Settings persist, closing the issue.


Use byte buffer in expansion.Expand

@a-robinson brought this up in code review; creating this as a follow-up.

Closed by #8736


wget send two identical http requests packetin

Hi murphy
A single time run cmd "h1 wget -O - h2" generates two identical packetin packet at the same time
[00:00:00:00:00:01>00:00:00:00:00:02 IP]
[00:00:00:00:00:01>00:00:00:00:00:02 IP] #output of event.parse of both the packetin that has arrived at the same time
i am suppose to call a function for anyone of the packetin packet. an attempt of counting the number of packet has been futile because both the packet happen to take the same count number.
so please suggest me how i could differenciate it and only call fucntion for anyone and ignore the second  packet

First question is why there are two.  Are both packet-ins coming from the same switch?  Have you looked at the traffic with Wireshark or something to see if you could tell if there are actually two packets?

ya had a look at wireshark , there is one http packet and two tcp protocol
packet with port 80 as the destination as shown below.
i am not sure how to obtaim only http specific packet
1 0.000000000 <IP_ADDRESS> <IP_ADDRESS> TCP 74 50376 → 80 [SYN] Seq=0 Win=42340
Len=0 MSS=1460 SACK_PERM=1 TSval=3792006818 TSecr=0 WS=512
2 0.029535730 <IP_ADDRESS> <IP_ADDRESS> TCP 74 80 → 50376 [SYN, ACK] Seq=0 Ack=1
Win=43440 Len=0 MSS=1460 SACK_PERM=1 TSval=1906848128 TSecr=3792006818
WS=512
3 0.029562923 <IP_ADDRESS> <IP_ADDRESS> TCP 66 50376 → 80 [ACK] Seq=1 Ack=1
Win=42496 Len=0 TSval=3792006847 TSecr=1906848128
*4 0.030201649 <IP_ADDRESS> <IP_ADDRESS> HTTP 201 GET / HTTP/1.1 *
5 0.032185443 <IP_ADDRESS> <IP_ADDRESS> TCP 221 80 → 50376 [PSH, ACK] Seq=1 Ack=136
Win=43520 Len=155 TSval=1906848135 TSecr=3792006848 [TCP segment of a
reassembled PDU]
6 0.032244318 <IP_ADDRESS> <IP_ADDRESS> TCP 66 50376 → 80 [ACK] Seq=136 Ack=156
Win=42496 Len=0 TSval=3792006850 TSecr=1906848135
7 0.032292438 <IP_ADDRESS> <IP_ADDRESS> TCP 1514 80 → 50376 [ACK] Seq=156 Ack=136
Win=43520 Len=1448 TSval=1906848136 TSecr=3792006848 [TCP segment of a
reassembled PDU]
8 0.032342929 <IP_ADDRESS> <IP_ADDRESS> TCP 66 50376 → 80 [ACK] Seq=136 Ack=1604
Win=41984 Len=0 TSval=3792006850 TSecr=1906848136
9 0.032306424 <IP_ADDRESS> <IP_ADDRESS> HTTP 790 HTTP/1.0 200 OK (text/html)
10 0.033180727 <IP_ADDRESS> <IP_ADDRESS> TCP 66 50376 → 80 [FIN, ACK] Seq=136
Ack=2329 Win=42496 Len=0 TSval=3792006851 TSecr=1906848136
11 0.033211895 <IP_ADDRESS> <IP_ADDRESS> TCP 66 80 → 50376 [ACK] Seq=2329 Ack=137
Win=43520 Len=0 TSval=1906848137 TSecr=3792006851
12 0.033645497 <IP_ADDRESS> <IP_ADDRESS> TCP 66 80 → 50376 [ACK] Seq=1 Ack=136
Win=43520 Len=0 TSval=1906848134 TSecr=3792006848
On Fri, Oct 23, 2020 at 12:47 PM Murphy<EMAIL_ADDRESS>wrote:

First question is why there are two. Are both packet-ins coming from the
same switch? Have you looked at the traffic with Wireshark or something to
see if you could tell if there are actually two packets?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/noxrepo/pox/issues/252#issuecomment-715556381, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKT7IT5D6WETZ4FBDHVRA7LSMHMTLANCNFSM4S453VFA
.

It's been a while, but is the output you're showing above ("[00:00:00:00:00:01>00:00:00:00:00:02 IP]") from just doing like... print(event.parsed)?  Try print(event.parsed.dump()).

thanks murphy , problem solved, i put a counter in the function that was
called  so worked out thank you again
On Sat, Oct 24, 2020 at 1:30 AM Murphy<EMAIL_ADDRESS>wrote:

It's been a while, but is the output you're showing above
("[00:00:00:00:00:01>00:00:00:00:00:02 IP]") from just doing like...
print(event.parsed)? Try print(event.parsed.dump()).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/noxrepo/pox/issues/252#issuecomment-715881007, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKT7IT3D37RIC3UIQACGT3TSMKGDRANCNFSM4S453VFA
.


Bugs in get_pos_proposal_indexes for mask loss

box_regression are not mutiplied by fpn_strides when get pos proposal indexes for mask loss
https://github.com/yinghdb/EmbedMask/blob/093348eface286f2fbe04cd6a08d79ea1f7c8ac3/fcos_core/modeling/rpn/embed_mask/loss.py#L227

You are right! This is a mistake. The bug is fixed as following:
https://github.com/yinghdb/EmbedMask/blob/3b4d9fb4e0b6112dc501708184ff684dfb45f3f0/fcos_core/modeling/rpn/embed_mask/loss.py#L232
Thanks a lot for your reminder. And the new models will be updated later.


edk2: 202108 -> 202202

Tested booting a VM with OVMF.fd.

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 163317 run on x86_64-darwin 1

2 packages marked as broken and skipped:

OVMF
OVMFFull

1 package built:

edk2


Unexpandable UltiSnips snippets are still shown as options during auto-complete

Auto-completion is showing UltiSnips snippets that cannot be expanded.
Minimal config based on this
minimal.vim
if has('vim_starting')
  set encoding=utf-8
endif
scriptencoding utf-8

if &compatible
  set nocompatible
endif

let s:plug_dir = expand('/tmp/plugged/vim-plug')
if !filereadable(s:plug_dir .. '/plug.vim')
  execute printf('!curl -fLo %s/autoload/plug.vim --create-dirs https://raw.githubusercontent.com/junegunn/vim-plug/master/plug.vim', s:plug_dir)
end

execute 'set runtimepath+=' . s:plug_dir
call plug#begin(s:plug_dir)
Plug 'hrsh7th/nvim-cmp'
Plug 'hrsh7th/cmp-buffer'
Plug 'hrsh7th/cmp-nvim-lsp'
Plug 'SirVer/ultisnips'
Plug 'quangnguyen30192/cmp-nvim-ultisnips'
Plug 'hrsh7th/vim-vsnip'
Plug 'neovim/nvim-lspconfig'
call plug#end()
PlugInstall | quit

" Setup global configuration. More on configuration below.
lua << EOF
local cmp = require "cmp"
cmp.setup {
  snippet = {
    expand = function(args)
	  vim.fn["UltiSnips#Anon"](args.body)
    end,
  },

  mapping = {
    ['<CR>'] = cmp.mapping.confirm({ select = true })
  },

  sources = {
	{ name = 'ultisnips' }, -- For ultisnips users.
  },
}
EOF

lua << EOF
local capabilities = require('cmp_nvim_lsp').update_capabilities(vim.lsp.protocol.make_client_capabilities())

require'lspconfig'.cssls.setup {
  capabilities = capabilities,
}
EOF

To Reproduce

Run this

nvim -u minimal.vim test.py

Call :UltiSnipsEdit and define an UltiSnips snippet for Python, like this example

snippet rt "Return True" b
return True
endsnippet

Type foo bar rt

Expected behavior
Because the rt snippet is set to b, the snippet can only expand if it is the beginning of a line (excluding whitespace).
In this case, because "foo bar" precedes "rt", UltiSnips won't expand the snippet even if we ask it to. So the snippet should not be visible as a completion option at all.
Actual Behavior
The rt snippet is displayed as an auto-complete option, regardless of whether it's expandable or not. In other words, the b option and existing text in the user's current line in the file has no effect on the completion list result.

It is cmp-ultisnips issue instead of nvim-cmp.

Ah okay, you're talking about https://github.com/quangnguyen30192/cmp-nvim-ultisnips, right? I will create a new issue over there, instead. Thank you!


Changes for Basque language

Changes for Basque language
Description
These changes, along with those sent to other repos, make Mycroft work in Basque language.
Made by Elhuyar, Talaios and Skura
Type of PR
Feature implementation

Any reason why this PR is still unmerged after almost a year, @luke5sky?

No, i simply did not see it

Thanks very much!


Fix adding events which have same names with methods of Object.

Usually this is not so much problem but anyway supporting any events would be nice.
Especially for Firefox which has watch and unwatch as methods of Object.
Related: https://github.com/Automattic/socket.io/issues/1983

Umm, I found Node also has the same problem, then maybe no chance to merge this change?
https://github.com/joyent/node/pull/4366

:+1: don't ever compare us to node

1.2.0!

thanks :D


Spv

support cross-chain from Ethereum to ckb. Including spv verification and checking whether the transaction is on the main chain.
test cases for spv verification and header verification.

support cross-chain from Ethereum to ckb. Including spv verification and checking whether the transaction is on the main chain.
test cases for spv verification and header verification.

for full support of eth <-> ckb, we still need to add eth-feature to theses transactions:

withdraw collateral
auction faulty when warranty
auction faulty when redeeming

of course, we will do this in other PRs


[R][C++] open_dataset and open_csv_dataset do not use skip argument

Describe the bug, including details regarding any error messages, version, and platform.
I noticed that a CSV with header rows can be successfully read with read_csv_arrow(..., skip=N), but not with open_csv_dataset unless a schema is provided. An example is below.
I expected open_csv_dataset to use the skip argument the same way read_csv_arrow does, skipping a fixed number of rows from every CSV, but it seems to not be skipping any. I think this is likely a bug -- maybe in the schema parsing?
library(arrow)

lines <- c(
  "This line should be skipped",
  "This one too, even though it has a comma",
  "X,Y,Z",
  "1,2,3",
  "4,5,6"
)
tmp_dir <- file.path(tempdir(), "arrow_test")
dir.create(tmp_dir, recursive=TRUE)
tmp_csv <- file.path(tmp_dir, "test.csv")
writeLines(lines, tmp_csv)

# This works as expected, skipping the first two lines and reading headers from the third
read_csv_arrow(tmp_csv, skip=2L)

open_csv_dataset(tmp_dir, skip=2L)
#> ! Invalid: Error creating dataset. Could not read schema from
#> '/tmp/RtmpPRG1yT/arrow_test/test.csv'. Is this a 'csv' file?:
#> Could not open CSV input source '/tmp/RtmpPRG1yT/arrow_test/test.csv':
#> Invalid: CSV parse error: Row #2: Expected 1 columns,
#> got 2: This one too, even though it has a comma

# These generate the same error:
open_csv_dataset(tmp_dir, skip=3L)
open_dataset(tmp_dir, format="csv", skip=2L)

schem <- schema(
  field(name="X", type=int32()),
  field(name="Y", type=int32()),
  field(name="Z", type=int32())
)

# Works when schema is supplied (now also need to skip header row)
open_csv_dataset(tmp_dir, skip=3L, schema=schem) |> dplyr::collect()

Version info:
R 4.2.2 on Linux
Arrow 12.0.0
(edited to add version info)
Component(s)
R

I've been looking into this more closely, and the CSVReadOptions object is being created correctly, and now I'm wondering if something else is happening here.
We haven't caught this before, I think, because we don't tend to see skip being used on its own without col_names or a schema being supplied.
I noticed this comment in the definition of ReadOptions:
https://github.com/apache/arrow/blob/3299d12efc91220237266bfa6f985f9eb37492f8/cpp/src/arrow/csv/options.h#L158
However, I can't find the code that implements actually falling back on autogenerate_column_names.  @westonpace - am I looking in the wrong place, or is that functionality missing?

I've ended up with a slightly different error message:
Error in `open_dataset()`:
! Invalid: Error creating dataset. Could not read schema from '/tmp/RtmpcW85O3/file633ce7dbf51dd/5/file1.csv'. Is this a 'csv' file?: Could not open CSV input source '/tmp/RtmpcW85O3/file633ce7dbf51dd/5/file1.csv': Invalid: CSV file contained multiple columns named 10

I had an R environment setup today and so I debugged this for a bit.  @thisisnic , I had, offline, pointed you at https://github.com/apache/arrow/blob/8b2ab4d8200fdd414b85d531f1cef4b58a3ce351/cpp/src/arrow/csv/reader.cc#L602 as the point where we handle autogenerated column names.
However, I had forgotten that we also (rather embarassingly :) have a duplicated copy of this logic in the datasets module here: https://github.com/apache/arrow/blob/8b2ab4d8200fdd414b85d531f1cef4b58a3ce351/cpp/src/arrow/dataset/file_csv.cc#L179
The logic in the dataset module is slightly different than the logic in the reader module.  It is (omitting some stuff):
  int32_t max_num_rows = read_options.skip_rows + 1;
  csv::BlockParser parser(pool, parse_options, /*num_cols=*/-1, /*first_row=*/1,
                          max_num_rows);

  RETURN_NOT_OK(parser.Parse(std::string_view{first_block}, &parsed_size));

  if (read_options.autogenerate_column_names) {
    column_names.reserve(parser.num_cols());

So we give the skipped rows to the parser (this is different than the reader.cc logic where we skip the rows outside the parser and then only give the first non-skipped row to the parser).
When we are not auto-generating column names then I think we kind of get away with it because we call parser.VisitLastRow which only really depends on the contents of the last row.
On the other hand, if the user is asking to autogenerate the column names we use parser.num_cols().  This calculation is based on the first row the parser sees!
I'm attaching a very clumsy sketch of a fix (which I verified works in OPs reprex) that just copy/pastes code from the reader so we can handle skipping in the exact same way.  This sketch is also missing unit tests.
I think a good long-term fix would be to eliminate this duplicate path entirely.  This could be done by adding an "inspect" method (or PeekMetadata or GetColumnNames or something) to the CSV reader.  Then the datasets API could use that instead of re-inventing the wheel.

Forgot the patch
Uploading csv-patch.txt…


bug Your p element should contain the first few words of the provided additional kitty ipsum text.

Challenge Change the Font Size of an Element has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

CatPhotoApp

Kitty ipsum text.

Kitty ipsum text.

This is not a bug. The additional text is:

Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.

@ngnam Thank you for reporting this issue. As @rholinshead has pointed out, you're using the wrong text.
This is a standard message notifying you that this issue seems to be a request for help. Instead of asking for help here, please click the "help" button on the challenge on freeCodeCamp, which will take you to the help chatroom for that specific challenge. You can also view our full list of official chatrooms.
If you think I'm wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding!

Here is some additional info that may help.
Firefox does not have a 100% setting. To get this exercise to pass it was necessary to go to "view" - "full screen" before  the system would accept the second paragraph of 'Kitty ipsum' text. Then I had to close Firefox to get out of full screen mode.


Replaced geom args with mol and updated tests

Fixes issue #62

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7f3d7bc). Click here to learn what that means.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master        #66   +/-   ##
===========================================
  Coverage          ?   26.0563%
===========================================
  Files             ?          7
  Lines             ?        284
  Branches          ?          0
===========================================
  Hits              ?         74
  Misses            ?        210
  Partials          ?          0

Impacted Files
Coverage Δ

qm10/__init__.py
100% <100%> (ø)

qm10/helper2.py
95.4545% <100%> (ø)

qm10/helper1.py
97.9591% <100%> (ø)


test: demonstrate panic when decoding into an untagged union

I've pushed a fix together with this test case to https://github.com/ipld/libipld/pull/140. Thanks for the test case!


[Monitoring V2 UI] Slack Receiver should default to using Rancher text

As shown in the default here, user-configured Receivers for Slack should set slack_configs.text='{{ template "slack.rancher.text" . }}' by default.
Without this, an alert to Slack would have something similar to the following outputted on Slack instead of the one dictated by the Rancher template:
AlertManagerAPP  1:37 PM
[FIRING:2] rancher-cis-scan (CISScanHasFailures cis-operator web <IP_ADDRESS>:8080 cis-operator-system 20 0 92 cis-operator-c7944dfb7-k5vtf cattle-monitoring-system/rancher-monitoring-prometheus rke-profile-hardened warning)

Failed to validate on rancher:v2.5-e2e530c19ac1fda3065cdf356cdc9a4e610bc51e-head
Basically, we cannot create any receiver.
As the screenshot shows, when we create a new receiver, a GET request is sent to https://server-url/k8s/clusters/c-sz97l/v1/secrets/alertmanager-rancher-monitoring-alertmanager, but the response does not contain anything in the data section.

And this secret does exist under the namespace cattle-monitoring-system

The UI enhancement is validated on rancher:v2.5-head 395b4f
By default, the following config is applied when the receiver is Slack
      text: '{{ template "slack.rancher.text" . }}'

and here is a sample of the message received in Slack

@jiaqiluo Hi, I'm having a problem fixing a slack config issue. The thing is that before upgrading the rancher-monitoring from 9.4 to 14.5 everything was normal, but after that the slack messages got ugly. Like this:

The title wasn't there before, and now it's this long title which is linked to the cluster internal URL. I wanted to know how I can make the title shorter and also if I can link it to the rancher monitoring magic link? If I can do this I'd prefer to remove it.
Thank you.

Hi @frouzbeh
I did not have a solution right now in my mind, but alertManager allows users to configure the title by setting a template. see https://prometheus.io/docs/alerting/latest/notification_examples/#ranging-over-all-received-alerts and https://prometheus.io/blog/2016/03/03/custom-alertmanager-templates/
In Rancher UI, you can edit the receiver as YAML and add the template/format for the title.

@jiaqiluo Thanks, I have resolved the title. thanks again.


Error: Cannot resolve ./override

Describe the bug
Hey, after importing config from react-native-ultimate-config, I'm getting this error
error: Error: Cannot resolve ./override
    at /project/node_modules/@nx/react-native/plugins/metro-resolver.js:31:15
    at Object.resolve (/ project/node_modules/metro-resolver/src/resolve.js:47:12)
    at ModuleResolver.resolveDependency (/ project/node_modules/metro/src/node-haste/DependencyGraph/ModuleResolution.js:79:31)
    at DependencyGraph.resolveDependency ( /project/node_modules/metro/src/node-haste/DependencyGraph.js:277:43)
    at Object.resolve ( /project/node_modules/metro/src/lib/transformHelpers.js:169:21)
    at Graph._resolveDependencies ( /project/node_modules/metro/src/DeltaBundler/Graph.js:473:35)
    at Graph._processModule ( /project/node_modules/metro/src/DeltaBundler/Graph.js:261:38)
    at async Graph._addDependency ( /project/node_modules/metro/src/DeltaBundler/Graph.js:372:20)
    at async Promise.all (index 7)
    at async Graph._processModule (/ project/node_modules/metro/src/DeltaBundler/Graph.js:322:5)

Steps to Reproduce

Just install the package in a react native project, and import config from the package.
Getting the metro resolver error.

Steps to reproduce the behavior.
Please consider creating small project that demonstrates the problem.
Having done clean setup helps pinpointing the problem.
Expected behavior
This snippet should work
// import module
import config from "react-native-ultimate-config";

// access variables
config.MY_CONFIG;

Stacktraces, logs, screenshots
Post stacktraces, logs or screenshots. The more information is available
is better.
Environment
Integration option

[x] I am using rnuc CLI to inject environment (default integration option
from quickstart guide)
[ ] I am using scheme/flavor based integration (experimental integration
option from cookbook:
scheme,
flavors)
[x] I am using react-native-ultimate-config within monorepo managed with NX Monorepo

Env file

[x] I am using dotenv file as a source for variables
[ ] I am using YAML file as a source for variables

Example of env file that is causing problems
❗PROVIDE EXAMPLE OF ENV FILE

OS

[x] ios
[x] android

Packages

version of react-native: ❗0.72.3
version of react-native-ultimate-config: ❗6.0.1

Run react-native info and post below:
System:
  OS: macOS 13.3
  CPU: (8) arm64 Apple M1
  Memory: 62.13 MB / 8.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 19.5.0
    path: /var/folders/w1/6fkl87mj5n9cmc_nk6xfsz7h0000gn/T/yarn--1704361025739-0.5088639990007069/node
  Yarn:
    version: 1.22.19
    path: /var/folders/w1/6fkl87mj5n9cmc_nk6xfsz7h0000gn/T/yarn--1704361025739-0.5088639990007069/yarn
  npm:
    version: 9.3.1
    path: ~/.nvm/versions/node/v19.5.0/bin/npm
  Watchman:
    version: 2<IP_ADDRESS>
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.11.2
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 22.4
      - iOS 16.4
      - macOS 13.3
      - tvOS 16.4
      - watchOS 9.4
  Android SDK:
    API Levels:
      - "23"
      - "28"
      - "29"
      - "30"
      - "31"
      - "33"
    Build Tools:
      - 28.0.3
      - 29.0.2
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 33.0.0
      - 34.0.0
    System Images:
      - android-31 | Google APIs ARM 64 v8a
      - android-31 | Google Play ARM 64 v8a
    Android NDK: 22.1.7171670
IDEs:
  Android Studio: 2020.3 AI-203.7717.56.2031.7678000
  Xcode:
    version: 14.3/14E222b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 1.8.0_292
    path: /usr/bin/javac
  Ruby:
    version: 3.2.2
    path: /opt/homebrew/opt/ruby/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: "*"
  react-native:
    installed: 0.72.3
    wanted: "*"
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Additional context
Add any other context about the problem here.

There is no override file, which is being called in the index.js
If we check here, is there something I'm missing @maxkomarychev
https://github.com/maxkomarychev/react-native-ultimate-config/blob/master/packages/react-native-ultimate-config/index.js

After removing that import, it started working. Is the override related something to the web?

Any fix for this or we will have to patch this?

After removing that import, it started working. Is the override related something to the web?

@quicksilverr After removing that import only, it starts working for web as well.
@maxkomarychev can you please help here.

Yep, there is no such file. In older versions, this file does indeed exist.
Im updating from version 3.4.2, and the file is there and looks like this
const RN = require("react-native");
const IOS_DATA = {}
const ANDROID_DATA = {}
module.exports = {
}
Im not sure what this file is supposed to do.

@quicksilverr @tilucast the .override file is not generated after running the command "rnuc .env"?

@vagnerlandio Youre right actually. I dont know what happened. The file now is being generated after running rnuc.

@vagnerlandio Youre right actually. I dont know what happened. The file now is being generated after running rnuc.

Awesome.
@vision1214 override file is not compatible with web.  For this case, you can create a file rnuc.rc in the project root directory with the following content.
module.exports = {
  js_override: true
};


Decide what type of exception to throw when TagContext deserialization fails.

The TagContext deserialization method needs to indicate failure when there is a parse error.  It shouldn't throw an unchecked exception, since the input could be coming from an untrusted source.  The method currently throws an IOException, but after #213/#603, it will no longer need to do IO.
Here are some options:

Throw ParseException.  This is what has been released in tracing: https://github.com/census-instrumentation/opencensus-java/blob/master/api/src/main/java/io/opencensus/trace/propagation/BinaryFormat.java#L84  However, it might not be a perfect fit for this case.  See https://github.com/census-instrumentation/opencensus-java/pull/208#issuecomment-294085122
Throw a new type of checked exception, such as TagContextParseException or a more general type that can be used for both tracing and tagging.  SpanContext serialization might also need to be updated to use a custom exception type.  It might be difficult to migrate, though.
Return null.  I don't think this is a good option, since it doesn't give any extra information about the error, and users could easily get NullPointerExceptions.

/cc @bogdandrutu

I'm a bit more in favor of an object with error status rather than allocating an exception. It is quite common for traces to be malformed, and usually the corrective action is to restart a trace. Even without error status, you could have an object with partial info, for example, sampling status that was parsed even if trace IDs werent

here are some notes about broken instrumentation which might be neat background https://github.com/openzipkin/b3-propagation/issues/3

I'm a bit more in favor of an object with error status rather than allocating an exception.

That is another option.  We could have something like a StatusOr class (https://github.com/google/protobuf/blob/master/src/google/protobuf/stubs/statusor.h), for efficiency, if errors are common.

It is quite common for traces to be malformed, and usually the corrective action is to restart a trace. Even without error status, you could have an object with partial info, for example, sampling status that was parsed even if trace IDs werent

here are some notes about broken instrumentation which might be neat background openzipkin/b3-propagation#3

Thanks for the link!  It looks like it is easier to parse just a SpanId or just a TraceId in that case, since they are separate headers.  For TagContext, it is possible that individual tags are invalid or that nothing can be parsed.  Maybe we should return a result that contains an optional TagContext and an optional error enum, where the error can indicate multiple possibilities.  Here are some example results:

Error
TagContext

no error
complete TagContext

parse error
no TagContext

n invalid tags
TagContext containing the valid tags

truncated input
TagContext containing the tags that could be parsed

There is more discussion of this issue in https://github.com/census-instrumentation/opencensus-java/pull/603#discussion_r138428013.

#621 and #642 added custom checked exceptions for TagContext and SpanContext deserialization.

I'm going to close this issue for now, since we added custom checked exceptions.


Render abyss rift portals as soon as visible

This increases usability of running the abyss. Because if you can see the portal sooner, you know which direction/entry obstacle is closest to it.

Do you have some screenshots that show the difference?

So, can this be merged?


added release-please-action workflow

Fixes #14

Here's an example of a WIP PR with release-please: https://github.com/pragmaticivan/nestjs-otel/pull/243
Here's an actual tag+ release created by release-please: https://github.com/pragmaticivan/nestjs-otel/releases/tag/v3.0.0
The only gotcha is that you really need to be on top of https://www.conventionalcommits.org/en/v1.0.0/ for every single important commit.

The only gotcha is that you really need to be on top of https://www.conventionalcommits.org/en/v1.0.0/ for every single important commit.

I believe that if i'm squashing PRs and having github set the commit to the PR title, all i need to do is make sure PRs to main follow conventional commits. Is that accurate? i think by default it treats it as a patch if the commit does not follow the conventional commit standards.

The only gotcha is that you really need to be on top of https://www.conventionalcommits.org/en/v1.0.0/ for every single important commit.

I believe that if i'm squashing PRs and having github set the commit to the PR title, all i need to do is make sure PRs to main follow conventional commits. Is that accurate? i think by default it treats it as a patch if the commit does not follow the conventional commit standards.

yes, you can do that. Any commit that does not follow the convention will be counted as not enough to bump even patch. Something like changing markdown docs.


Update KWasm installer version to 0.3.0

This PR updates the installer version used by the KWasm operator to 0.3.0.
This removes the crun runtime in favor of the wasmedge shim as a drop-in replacement.
However, the need to change the RuntimeClass makes this a breaking change.
related issue: https://github.com/canonical/microk8s-community-addons/issues/180
Thank you for making MicroK8s better
Please reference the issue this PR is fixing, or provide a description of the problem addressed.
Also verify you have:

[ ] Read the contributions page.
[ ] Submitted the CLA form, if you are a first time contributor.

Many thanks for this PR @0xE282B0. I really appreciate the super fast reaction. Awesome work!


[Bug]:  Blinking on with Missing blinking Image

Describe the bug?
You can enable the blinking function without an image to show.
As a result, the image disappears for a few seconds with each blink.
To Reproduce

new Screen object
set neutral Image
enable (if not already enabled) "has Blinking Texture"

Expected behavior
Ignore Blinking if no Image is Set.
Show warning on or near "has Blinking Texture" Option
or show Warning in Menu
Screenshots
No response
Godot Version
4.2.2
What Platforms does this occur on?
Windows
Additional Context
No response

Same goe's for "talking" and "blinking and talking"

We believe this is, for the most part, intended behavior.
We do want to give the user more feedback tho. I agree that there should be warning text when there are images missing.


Shows all items in a plain list (Python)

In Atom 1.41.0 on MacOS for python I get a plain list of all items (functions, classes, methods, variables...). No structure in the list.

Same issue for me.  Json file on MacOS shows alphabetical ordered single lined list.


Add check for S3 Config rules

Add a section to check for the existence of AWS managed Config rules related to S3:
https://docs.aws.amazon.com/config/latest/developerguide/managed-rules-by-aws-config.html#managed-rules-by-aws-config-storage

We're archiving this repository. Please consider using https://github.com/scalefactory/s3audit-rs instead.


IngressClass being deleted and recreated

The existingKongIngressClass conditional around the IngressClass resource causes it to be deleted every other release. This means that you're non-deterministically unable to deploy Ingress resources with spec.ingressClassName: kong.
I couldn't tell from a4958208df084ac5de81a5a665e5e1e31ec033e9 why this condition is there. Is it intended to guard for people that have manually created the resource prior to the chart including it? If so, could the conditional be removed and the upgrade notes instruct people to label the resource for adoption? helm.sh/resource-policy="keep" doesn't seem like the right solution because it wouldn't allow for a clean uninstall.
I'd be happy to raise a PR if you can advise on the desired implementation and any additional tests.

First release on a fresh cluster creates it:
$ minikube start
😄  minikube v1.22.0 on Darwin 11.6
✨  Using the hyperkit driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating hyperkit VM (CPUs=2, Memory=4000MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.21.2 on Docker 20.10.6 ...
    ▪ Generating certificates and keys ...
    ▪ Booting up control plane ...
    ▪ Configuring RBAC rules ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
$ helm upgrade kong kong/kong --install --version 2.6.2 --set ingressController.installCRDs=false | head -n1
Release "kong" does not exist. Installing it now.
$ kubectl get IngressClass/kong
NAME   CONTROLLER                      PARAMETERS   AGE
kong   konghq.com/ingress-controller   <none>       10s

Second release deletes it:
$ helm upgrade kong kong/kong --install --version 2.6.2 --set ingressController.installCRDs=false | head -n1
Release "kong" has been upgraded. Happy Helming!
$ kubectl get IngressClass/kong
Error from server (NotFound): ingressclasses.networking.k8s.io "kong" not found

Third release recreates it:
$ helm upgrade kong kong/kong --install --version 2.6.2 --set ingressController.installCRDs=false | head -n1
Release "kong" has been upgraded. Happy Helming!
$ kubectl get IngressClass/kong
NAME   CONTROLLER                      PARAMETERS   AGE
kong   konghq.com/ingress-controller   <none>       2s

Part to allow you to create your own but more because we do want that specific name and you can't install multiple releases into the same cluster if you remove it:
Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: IngressClass "kong" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: key "meta.helm.sh/release-name" must equal "bar": current value is "foo"

Since they are actually owned by another release, that'd preclude the adoption option.
We do get the full object back from lookup, so you should be able to modify the logic to create the resource if either of two conditions is true:

The resource doesn't exist (the current condition)
The resource exists, and the value of the meta.helm.sh/release-name annotation is equal to the Release.Name variable.

That way, whichever release created it originally will continue to include it on upgrades, but other releases will disable creating their own.

Good call, thanks! I've raised https://github.com/Kong/charts/pull/518


doSad() block emoji is messed-up in Chrome

Huh? That's… odd.

In progress - fixed by forthcoming PR from setup-menu-additions.

Closed by #12


JUnit XML output for Continuous Integration w/ Jenkins

I have been trying to set up Jest on our Continuous Integration servers that run Jenkins. Even though Jest is built on top of Jasmine, I could not integrate it with jasmine-reporters.
I've used the branch that supports Jasmine 1.3. You can install it with npm install<EMAIL_ADDRESS>My package.json has:
  "jest": {
    "setupTestFrameworkScriptFile": "<rootDir>/tests/unit/setup-jasmine-env.js",
...

And in setup-jasmine-env.js I have:
require('jasmine-reporters');

jasmine.VERBOSE = true;

jasmine.getEnv().addReporter(new jasmine.JUnitXmlReporter({
  savePath: "output/"
}));

The error I get is NodeJS attempt: Arguments to path.join must be strings or NodeJS attempt: Object [object Object] has no method 'join'. I've tried to debug it, but unfortunately you cannot set a debugger in a Jest test.
Is there a way I can make Jest work on Jenkins?

Thank you for reporting this issue and appreciate your patience. We've  notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Please feel free to reopen this if there is anything in jest that needs to be changed to support this.

The issue I'm having with integrating jasmine-reporters is that because Jest spawns a different jasmine instance for each file, you cannot consolidate results. Normally you would want the test suites from all tests to be aggregated into a single output but with Jest it's only possible to create an output per file

Got this to work by adding to jest config
  ...
  "collectCoverage": true,
  "unmockedModulePathPatterns": [
    "./node_modules/jasmine-reporters"
  ],
 ...
"setupTestFrameworkScriptFile": `<rootDir>/jasmineReporter.js`,
 ...

the problem is that i also have on my config "collectCoverage": true, this creates the following output
 PASS  src/__tests__/index-test.js (0.549s)
2 tests passed (2 total in 1 test suite, run time 2.371s)
----------------------|----------|----------|----------|----------|----------------|
File                  |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
----------------------|----------|----------|----------|----------|----------------|
 lib/test/            |      100 |      100 |      100 |      100 |                |
  jasmine-reporter.js |      100 |      100 |      100 |      100 |                |
 src/                 |    88.89 |      100 |    66.67 |    88.89 |                |
  index.ts            |    88.89 |      100 |    66.67 |    88.89 |              8 |
----------------------|----------|----------|----------|----------|----------------|
All files             |    92.31 |      100 |    66.67 |    92.31 |                |
----------------------|----------|----------|----------|----------|----------------|

Notice that the reporter is included in there, it should not be in there.

create a new issue with the above comment https://github.com/facebook/jest/issues/1274

got the same problem as @megawac , DId you manage to work around that ?

I did, I'll comment tmw

The only big gotcha of using jest with jasmine xml reporters is that because tests in different files are run in different contexts you can't use considateAll. So you have to merge the results after the tests are run.
jest/jasmine setup file for Junit results
var jasmineReporters = require('jasmine-reporters');
var reporter = new jasmineReporters.JUnitXmlReporter({
    consolidateAll: false,
    savePath: process.env.JUNIT_RESULTS,
    filePrefix: 'junit-'
});
jasmine.getEnv().addReporter(reporter);

Merge results scripts:
var fs = require('fs');
var path = require('path');
var async = require('async');

var reportMerger = require('junit-report-merger');

var results = fs.readdirSync(process.env.JUNIT_RESULTS);

let output = path.join(process.env.JUNIT_RESULTS, 'results.xml');
let files = results.map(x => path.join(process.env.JUNIT_RESULTS, x));
reportMerger.mergeFiles(output, files, {}, function() {
  async.each(files, fs.unlink);
});

we've been working on our reporting system and now we can actually generate junit\xunit using a separate jest-reporter plugin. I think we're going to have a plugin for junit in a couple of weeks

do you have any examples of how to write or use a jest-reporter plugin?

@noahpeters our internal reporters are here https://github.com/facebook/jest/tree/master/packages/jest-cli/src/reporters
but the thing is.. right now we don't have a mechanism to configure which reporters are used by jest without dealing with jest internals. As soon as we get that done, we'll be able to use any custom reporting system with jest

any update on this for jest 15?  I can't get junit xml output for the life of me!  it's nice when a test fails in ci and what not.

Any update on this beside the comment by @megawac https://github.com/facebook/jest/issues/104#issuecomment-233201678 ?
At the moment the missing integration with CI is a blocker to the adoption of jest in my org.

There hasn't been any progress on this. Please feel free to send a PR to add this feature.

@vampolo the jasmine-reporters package accomplishes this with the more recent versions (I'm using 2.2.0).
Create a file, something like setup-jasmine-env.js, that performs the following:
const reporters = require('jasmine-reporters');
const reporter = new reporters.JUnitXmlReporter({
  // Jest runs many instances of Jasmine in parallel. Force distinct file output
  // per test to avoid collisions.
  consolidateAll: false,
  filePrefix: 'jest-junit-result-',
  savePath: __dirname + '/arc-jest-output.tmp/',
});
jasmine.getEnv().addReporter(reporter);

Then just reference it in your jest config:
"setupTestFrameworkScriptFile": "<rootDir>/jest/setup-jasmine-env.js",

Also make sure to ignore that file in your unmockedModulePathPatterns jest config.

I was able to integrate that way at the end @rsolomon. No need for the unmockedModulePathPatterns tho since jest 15 does not automock anymore.
Still, this way of integrating junit output feel a bit hackish. Will try to hack a bit the jest codebase and see if i can come up with a PR.
Thanks all for the help.

@rsolomon you wouldnt happen to know of a way to only run the setup-jasmine-env (or generate junit tests) unless you're runing jest --coverage would you?

I've just got this working thanks to that very useful help by @rsolomon , thanks!
@th3fallen The way I did that was to create a separate jest config file:
In ./jest/jest-junit.json:
{
    ...
    "setupTestFrameworkScriptFile": "./jest/setup-jasmine-env.js"
}

And then specify this config file when you want junit output (e.g. in your case along with --coverage):
jest --config ./jest/jest-junit.json --coverage

Also you can try this node module https://www.npmjs.com/package/jest-junit

I was able to get this working with the cli option as I didn't have access to change the config.
I then used junit-merge module to get just one file.

@kellyrmilligan do you have an example? I'd like to use the new reporters configuration option, but I'd prefer to not write my own =)

On the sideline here, but i ended up ditching junit format altogether and use the mocha formatting via jest-bamboo-formatter. So far it works pretty good the integration with Bamboo, but any mocha parser would work.

create a script somewhere, chmod +x it:
const reporters = require('jasmine-reporters');
const path = require('path');
const reporter = new reporters.JUnitXmlReporter({
  // Jest runs many instances of Jasmine in parallel. Force distinct file output
  // per test to avoid collisions.
  consolidateAll: false,
  filePrefix: 'jest-junit-result-',
  savePath: path.join(process.cwd(), '/junit')
});
jasmine.getEnv().addReporter(reporter);

then however you're running it, something like this:
yarn run test:ci -- --setupTestFrameworkScriptFile=./bin/setup-jasmin-env.js
and after that is run, merge it all together:
 node ./node_modules/.bin/junit-merge -d ./junit -o ./junit/merged-junit-results.xml

@kellyrmilligan ... that helped quite a lot! But you don't need junit-merge. Just report *.xml files


embedded version?

is there an embedded version for terminal use on raspberry pi with limited resources and no python?

I dont know if that makes sense - this is a python library so it doesnt provide a non-python interface.
As far as I know, the pi supports python, if you have a pi that's resource constrained enough to not support python, you'd probably want to reconsider using it as a vehicle to download videos.

Are you referring to a terminal-like interface, @sherifomran? If so, pytube has one built in (cli.py) once you install it either through pip or through here. Just type in “pytube” (no quotes) into your terminal once you have it installed, and it will display a help menu for how to use the CLI interface.


Context log to loggerfactory

Context.log/failed/done/dispached will now also output to the default logger. Resolves #7
All runs will append the schedule name to the MDC with the key "scheduledTask".
Added support for NOOP runs. When seeing these runs in the monitorm and
if there is several consecutive runs in a row these will
be aggregated together and showing a count on how many where aggregated.
NOOP runs has deleteNoopRunsAfterDays and keepMaxNoopRuns that can be set.
They have defaults of deleteNoopRunsAfterDays = 7 and keepMaxNoopRuns=1440.
Added checkbox to allow to inspect all NOOP runs, this only works if the
new integration is using the html function to render the HTML GUI.
NOOP runs are shown with a color grey and a grey background.
DONE runs are shown with a green color.
FAILED runs are shown with red.
The loglines are now shown under the row and by clicking this row they will appear.
StackTraces are no longer shown in a modal box but rendered directly when the logs are shown.
StackTraces will show the indents.
BUG FIX: The HealthCheck "passed next run" where calculated from a memory variable on the given master.
If there was a master switch this meant that this variable would be null or worse be days old and thus
giving a wrong or not working HealthCheck.
HealthCheck changed from using true false to ✓/- when all is ok, and a describing word in caps when there
is an issue. This to assist in reading the healthCheck table.
BUG FIX: In rare occations you could get a negative sleep number resulting in exception thrown. This would
cause the schedule to wait a bit before trying again and autorecover.
If runOnce() is called inside a schedule run it will cause the schedule to retrigger immediately.
Listing of schedules is now sorted by name. Resolves #9
HealthCheck table column "Thread running" is renamed to "Thread alive".

Tested the new healthCheck:

Another screenshot showing that the Thread running is now renamed to Thread alive, it also shows when there is no issues with any of the schedules:

This change is tested in connect both with the support of the new html/outputStyleSheet/outputJAvaScript/json method calls and verified that the old way of initialising the HTML GUI also is supported. This where tested by deploying a custom version of MToolkitScheduledTask.
As a side note. The feature Show all NOOPs will only work in the new way of fetching the HTML GUI (by using the new html method). In the old way the page will refresh but the NOOPs will not show (only the aggregated ones).
Screenshot showing the default view of runs with fail, noops and done


sixel support

In case you need help with the scaling of the sixel graphics you could check out my little project https://github.com/gizak/termui/pull/233.
I use a combination of the ioctl TIOCGWINSZ and the escape codes \033[14t and \033[18t. This can be a bit more difficult with split views of terminal multiplexers like screen and tmux. tmux can pass escape codes through to the terminal.
It is possible to ask the terminal if it is capable to display sixel graphics - the response to \033[0c should contain a 4.

Getting the terminal size in pixel? Sounds great, I'll look into it, thanks.


Fix collisions with builtins

Split off from #2100.

The AI Assistant names some more examples
In Python, it is common to accidentally overshadow built-ins by using them as variable names. Here are some examples:

id: Python's built-in id() function returns a unique identifier for an object. Accidentally overwriting it with your own variable can cause confusion.
type: The type() function is used to determine the type of an object. It's also a common term and easy to inadvertently overwrite.
sum: Python's sum() function is used to add items in a sequence. Accidentally overwriting this can break any future call to sum().
list: Overwriting list would prevent you from converting other data types to lists with list().
filter: a function to filter items in a list based on a function. Overwriting filter would prevent you from being able to use it.
str, int, float: All these functions are used for typecasting and it's easy to accidentally use them as variable names.
Always try to use descriptive variable names and avoid using built-in function names to prevent such shadowin

You don't need an AI assistant for that, flake8 could check this with the flake8-builtins plugin. Or we switch to ruff (https://github.com/astral-sh/ruff) which is faster and has these checks built-in already. We should first introduce a test/lint for this, otherwise these issues will come back at some point. Do we want to do that? While at it, do we at some point want to enforce a specific formatting style (my preference would be black, or the code formatter that is now built-in to ruff which is very similar to black)?

You don't need an AI assistant for that, flake8 could check this with the flake8-builtins plugin. Or we switch to ruff (https://github.com/astral-sh/ruff) which is faster and has these checks built-in already. We should first introduce a test/lint for this, otherwise these issues will come back at some point. Do we want to do that? While at it, do we at some point want to enforce a specific formatting style (my preference would be black, or the code formatter that is now built-in to ruff which is very similar to black)?

We tried black some time ago and it broke MSS.  On the fs_filepicker repo we have a CI which enforces updates, but I am not happy with that extra traffic. I would expect an IDE solves the formatting.

Do you want to change the type line too?

I've fixed the cases where the shadowing was purely local and I've added ignores for now for the cases where class attributes or methods/functions shadow a builtin, since those would potentially require changes in multiple different locations.


fix: Change upgrade_and_set_addresses dispatch class to Operational

Description
Normal dispatch class is affected by block weight limits. upgrade_and_set_addresses by necessity consumes all remaining weight of the block (this behaviour comes form set_code), which on my local chain caused it to never be included in a block. Changing the dispatch class to operational removes this issue.
Checklist

[ ] Commit sequence broadly makes sense and commits have useful messages.
[ ] New tests are added if needed and existing tests are updated.
[ ] Relevant logging and metrics added
[ ] CI passes. See note on CI.
[ ] Any changes are noted in the changelog.md for affected crate
[ ] Self-reviewed the diff

Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges.  Please contact IOG Partner Chains developers to do this
for you.

Approved, however I don't fully understand the issue, because this call has weight = 0.

It has weight = 0, but nevertheless always consumes the whole weight of the block (because it invokes set_code). Normal dispatch extrinsics are only allowed to consume a part of the block per the documentation. Operational ones are not constrained in this way. This of course raises the question of why we didn't get the same problem running the extrinsic on other chains, and the answer is - I don't know. Perhaps we were lucky and it co-incided with some inherents being run, so it never was technically "the whole block", or there was some other reason. 🤷  But just to be safe, it's better to switch it to Operational.


[Mod Info] Train Converter [Steam ID  795514116] by BloodyPenguin

Mod:
Train Converter [Steam ID  795514116] by BloodyPenguin
Stability:

Minor issues: it functions, but with some smaller issues (please elaborate below).

It's confirmed to work with current game version (Sunset Harbour at least).
If you subscribe too many train assets, the mods' options screen might break
Some users report issues with config file not being properly created

Statuses:

Performance impact: it functions, but lowers the game FPS, increases loading time, ...

Impairs performance of content manager - has huge options screen with many UI components, so causes lag each time a mod or asset is enabled/disabled/subscribed/unsubscribed
Reduces fps in game due to large options screen - the main FPS Booster mod can be used to tackle that issue (by disabling UI components which are not in active use)

Source code: available at URL

https://github.com/bloodypenguin/Skylines-VehicleConverter

Other Information

Required mods/DLC: missing, or listed ones are not needed. Specificy which one.

Requires Prefab Hook: https://steamcommunity.com/workshop/filedetails/?id=530771650
Conversion of trains in to trams will require Snowfall DLC (the mod works fine without Snowfall; it won't show the tram options).

Additional info: anything else you want to tell.

Most users probably don't require this mod, it's mainly used to convert very old train assets (which were designed to look like metros/trams) in to actual metros/trams. It's default conversions are listed here. However, it can be used to convert any train to a metro/tram either via its options screen or config file, should users wish to do so.

This will be added to catalog 3.50.


add some more of the limitations documented elsewhere to this page as well

limitations about recovery and versioning are listed i those places, but not explicitly listed here.  adding/cross linking

@AbbyMSFT
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off