Triage builds of JDK8/HotSpot arm32 with JIT enabled

Tests of sanity.openjdk via Grinder - need to find some time to triage as the JIT-enabled version will, by default, get released this week as 8u242. Happy for this to be moved somewhere else if anyone objects :-)
First (JIT) run: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1672/
Second run (no JIT, like last GA - timed out after 10h): https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1687/
Third (JIT) run https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1723/
non-JIT build: https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u232-b09/OpenJDK8U-jdk_arm_linux_hotspot_8u232b09.tar.gz
JIT build: https://api.adoptopenjdk.net/v2/binary/nightly/openjdk8?openjdk_impl=hotspot&os=linux&arch=arm&release=latest&type=jdk&heap_size=normal

@sxa555
Triage
1st Run

com/sun/net/httpserver/SelCacheTest.java.SelCacheTest

Initially reported in (https://github.com/AdoptOpenJDK/openjdk-tests/issues/802) for JDK11-openj9. Also reported to be intermittent (https://bugs.openjdk.java.net/browse/JDK-8224603).

java/net/Socket/HttpProxy.java.HttpProxy

Reported in (https://bugs.openjdk.java.net/browse/JDK-8223465). New Failure.

java/net/URL/OpenStream.java.OpenStream

Excluded for JDK11-hs and JDK13-hs. New Failure.

java/net/ipv6tests/TcpTest.java.TcpTest

Unexcluded recently (https://github.com/AdoptOpenJDK/openjdk-tests/pull/1517).Seems to be intermittent (https://github.com/AdoptOpenJDK/openjdk-tests/issues/1259). New Failure.

java/nio/channels/SocketChannel/ExceptionTranslation.java.ExceptionTranslation

RAISED (https://github.com/AdoptOpenJDK/openjdk-tests/issues/340) for JDK9-hs with same failure. Also RAISED for JDK8-hs but never resolved, presumably because it started passsing again (https://github.com/AdoptOpenJDK/openjdk-tests/issues/827#issuecomment-456973398). Unexcluded in (https://github.com/AdoptOpenJDK/openjdk-tests/pull/1475)

java/util/stream/test/org/openjdk/tests/java/util/stream/MapOpTest.java.MapOpTest

No relevant history for the failing case. New Failure.

java/util/stream/test/org/openjdk/tests/java/util/stream/SliceOpTest.java.SliceOpTest

Excluded for JDK8-hs/j9 (https://github.com/AdoptOpenJDK/openjdk-tests/blob/d2f0946813daaf3cc9708eae88072953579ab261/openjdk/ProblemList_openjdk8.txt#L250) on zlinux for timeout reason (not an ArrayOutOfBoundsException like it is here). New Failure.

java/util/stream/test/org/openjdk/tests/java/util/stream/TabulatorsTest.java.TabulatorsTest

No relevant history for the failing case. New Failure.

2nd run

Timeout after 10 hours. Caused by sun/nio/cs/OLD/TestIBMDB.java. Test is excluded in JDK8 for zlinux and all platforms for JDK9. Known to cause timeouts: https://github.com/AdoptOpenJDK/openjdk-tests/issues/1051

#3rd run

com/sun/net/httpserver/Test1.java.Test1

Excluded for JDK8-hs-ppc64 (https://github.com/AdoptOpenJDK/openjdk-tests/issues/827) for timeout reasons. Unexcluded in (https://github.com/AdoptOpenJDK/openjdk-tests/pull/1323). Fails in this instance with a SIGSEGV when running attempting to get the instance of a Cipher. New Failure.

java/net/URL/OpenStream.java.OpenStream

See 1st run

java/net/ipv6tests/TcpTest.java.TcpTest

See 1st run

java/nio/channels/SocketChannel/ExceptionTranslation.java.ExceptionTranslation

See 1st run

java/util/stream/test/org/openjdk/tests/java/util/stream/MapOpTest.java.MapOpTest

See 1st run

java/util/stream/test/org/openjdk/tests/java/util/stream/StreamLinkTest.java.StreamLinkTest

No relevant history for the failing case. New Failure.

A lot of the tests are failing with ArrayOutOfBoundsException that have not been seen before.

OpenStream is an issue with it resolving hostnames it shouldn't (Same as https://github.com/AdoptOpenJDK/openjdk-infrastructure/issues/984 - now resolved on the machine - re-running with JIT at https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1757/console)
TcpTest is giving a SocketException which doesn't quite indicate that it's the same failure as the references above
Am re-running the non-JIT version with (hopefully) IBMDB excluded at https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1751 and it's at 7 hours so we'll see if it gets to the end and whether the same failures occur. It doesn't seem to have shown any output for TcpTest yet

@smlambert - If we choose to accept these failures as 'intermittent or expected on arm32' what would the next logical step be?  I assume we'd exclude these tests to get a green run and then investigate each more deeply?

Yes, to proceed, we should exclude failing tests on this platform (with links to issues to track) so that we can run green, investigate/fix issues as aggressively as we can.

jdk_nio_0
- java/nio/MappedByteBuffer/Truncate.java.Truncate Excluded on zlinux
- java/nio/channels/FileChannel/Transfers.java.Transfers Previously known to cause timeouts
- sun/nio/cs/FindDecoderBugs.java.FindDecoderBugs Might be intermittent (#1511 and M2 triage)
- sun/nio/cs/OLD/TestIBMDB.java.TestIBMDB As discussed above
- sun/nio/cs/TestStringCoding.java.TestStringCoding Excluded for all platforms on openj9 initially as an unrelated intermittent problem. Not clear what the error was here. Timeout would have been flagged up? Exit code 143 is a SIGTERM command, needs more investigation
- sun/nio/cs/TestStringCodingUTF8.java.TestStringCodingUTF8 Excluded for all platforms on openj9 initially as an unrelated intermittent problem. New failure.
jdk_security1_0
- java/security/KeyPairGenerator/SolarisShortDSA.java.SolarisShortDSA Excluded on zlinux.
- java/security/KeyStore/PBETest.java.PBETest No timeout history, new failure
- java/security/MessageDigest/TestDigestIOStream.java.TestDigestIOStream Excluded on zlinux
- java/security/MessageDigest/TestSameLength.java.TestSameLength No timeout history, new failure
- java/security/Security/SynchronizedAccess.java.SynchronizedAccess Related Thread Cleanup Error reported upstream
- java/security/SignedObject/Chain.java.Chain No timeout history, new failure
jdk_util_0
**- Timed out after multiple tests timed out **
jdk_rmi_0
PASSED
jdk_net_0
- com/sun/net/httpserver/Test9a.java.Test9a Known to fail on jdk11-arm32
- java/net/URLPermission/URLTest.java.URLTest Known to fail on jdk11-arm32. Looks like a timeout.
- java/net/URL/OpenStream.java.OpenStream (10) All same error.
- java/net/ipv6tests/TcpTest.java.TcpTest (5) 1 reported as passed, 4 fails (all crash with the same error).

@M-Davies - Are you able to add these to the appropriate exclude file and reference this issue?  I'm also happy to learn by looking over your shoulder when you do it :-)

@karianna Sure 😄. I'm basically going to be following the documentation at https://github.com/AdoptOpenJDK/openjdk-tests/tree/master/openjdk#exclude-a-testcase.

~Creating issues for each of the failing tests (except for ones that already have relevant issues or JBS entries)~ See references above
Add each of these issues into ProblemList_openjdk8.txtspecifying aarch32 as the culprit. I.e.

java/net/ipv6tests/TcpTest.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/1639    linux-aarch32

This will exclude these tests from testing on arm32
3) Create a PR to merge my problem list entries into master #1640

@M-Davies - Thank you!  I appreciate you doing the heavy lifting on my behalf there, I owe you one!

OK, so the next step is to put this through a release again :-).  @sxa555 - I might lean on you here for some advice.  Are the ARM builds now set to the JIT'd implementation or Zero Impl?

JIT by default since https://github.com/AdoptOpenJDK/openjdk-build/commit/333235e6f4e2f24c6706567446b7e23e9b91061f went in. The nightlies come out with e.g.:
openjdk version "1.8.0_252"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_252-202002210344-b02)
OpenJDK Client VM (AdoptOpenJDK)(build 25.252-b02, mixed mode)

I've scheduled another run at https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/880 from the jdk8u242-b08 tag which I believe is the correct one to use for arm32 release builds.

I did not get to seeing the results of the referenced arm32 pipeline in time.

@smlambert Doesn't matter - it failed as the repo doesn't appear to have mirrored correctly :-(

Egad, okay, I will leave this issue open until we can actually execute on it.

Repo is mirrored once more.  We just need to get faster hardware to run the JIT tests.

@karianna Does that mean we could now re-release a .1 of 8u242 with JIT enabled?

I think we need to get better hardware first @gdams is working on it with AZ

looking at the aarch32 mirror we only have jdk8u242-b06 rather than jdk8u242-b08. Let's talk to Red Hat

@jerboaa - Is there a particular maintainer we should talk to?

@karianna We don't maintain that tree, AFAIK.
http://openjdk.java.net/census#aarch32-port
You are talking about this repository, right?
https://hg.openjdk.java.net/aarch32-port/jdk8u/ It has a jdk8u242-ga-aarch32-200120 tag which should be what you're looking for no?

@jerboaa Oh, it's Ed Nevill from ARM right?  Let me go talk to him separately then :-).  you're right on the repo

I've rerun all of the tests that were thought to be previously excluded.  The excludes were not effective (using linux-aarch32 instead of linux-arm in the ProblemList files, so no tests were actually excluded).
The test reruns show that tests are passing.  If there are machines where they can not complete in a certain period of time and then fail due to timeout, I recommend removing those machines from the test farm.
I will close this.  We can raise a fresh issue should there be other issues spotted.

@ShelleyLambert Which ones did you have to change from linux_aarch32 to linux_arm? Looking at openjdk-tests it looks like linux_arm stuff is only excluded in the OpenJ9 files (which isn't built on arm32)

jtreg from openjdk project only knows to exclude stuff named linux-arm
if you look at the comments I added to any of the related issues that tests were excluded under, you will see what I am referring to (entries in ProblemLists that are then read by jtreg framework, https://github.com/AdoptOpenJDK/openjdk-tests/pull/2018).

linux_arm entries will also be ignored (note '-' vs '_'), so I need to update my #2018 PR once I check the state of those tests (excluded under #440 )

Also I should mention that @smlambert if my github ID, I do not see @ShelleyLambert mentions as that id was auto-created for me by my former employer whose email I no longer have access to.


Press the enter key lose focus on web (GitHub version)

In the GitHub version of this package (readOnly added) focus will lost when press the Enter key.
Tested on web.

Do you need to focus in readonly mode?

not in read-only mode. in edit mode.
I had to download code (pub.dev version) and add read-only myself.

@BertrandBev Also experiencing this problem on Master building the example app on macos desktop. Not entirely sure what might have changed.

Can confirm it is related to this merge (#36) at this line: https://github.com/BertrandBev/code_field/blob/befb10f12db622400c86ca388edc67c91b550774/lib/src/code_field.dart#L278

This should be resolved with #48 once merged in. Feel free to cherry-pick the commit with this ref number: 86182ef1b1dacddb8b9dbda0af0c03a10e12e29b


Define the semantic of individual Edifact extensions

Thanks for the great extension. It helps a lot to understand Edifact messages.
I am working with messages, that contain individual extensions. Eg.  i have such a line:
FTX+Z02+++MP-ID Absender:NAD'

This is not valid, because the value Z02 is an invalid code value for the qualifier 'Text subject code qualifier.
Is there a possibility, to extend the schema? I would like to be able to add somewhere the meaning of Z02 and show it in VS Code.

Hi klacol,
You can extend the schema by editing the schema file manually in vscode extension directory.
E.g.

Open C:\Users\xxx.vscode\extensions\dericlee.edi-edifact-support-1.4.4-dev\out\schemas\edifact\D97A\RSSBus_D97A.json

Add code to "Qualifiers/Text subject qualifier"

restart vscode

Where are extensions installed?
Windows %USERPROFILE%.vscode\extensions.
macOS ~/.vscode/extensions.
Linux ~/.vscode/extensions.


pd.rename() is failing to rename columns

The following code snippet fails to rename the columns 'a' and 'b' to 'x' and 'y'. Changing to regular pandas works fine, and also not doing the operation inplace results in the same
import modin.pandas as pd

print(pd.__version__)

df = pd.DataFrame({
    'a': [1, 2, 3],
    'b': [4, 5, 6]
})

df.rename({'a': 'x', 'b': 'y'}, axis=1, inplace=True)

print(df)

Output:
0.6.3
UserWarning: Distributing <class 'dict'> object. This may take some time.
   a  b
0  1  4
1  2  5
2  3  6

Also, I am using modin==0.7.0, but it is printing version 0.6.3.

It does work if I pass the dict to the columns parameter, instead of specifying mapper and axis.

Try specifying the axis as either index or column like so
df.rename({'a': 'x', 'b': 'y'}, axis='column', inplace=True)


refactor: Duplicate anchors instead of modifying them in-place

This will be useful for the soon-to-come Markdown anchors feature of mkdocs-autorefs.
Related to mkdocs-autorefs#39: https://github.com/mkdocstrings/autorefs/pull/39

I first went with a custom iterator approach (yielding parent, index, element) to insert at the right position, but since it iterated forward it was causing infinite loops.
Instead, I used a recursive approach, and at each layer I iterate on elements backwards to be able to insert in the being-iterated elements. The other option was to iterate on a copy of the list of elements, but this would have been less efficient. reversed is possible each because Element implements both __len__ and __getitem__.

Looks awesome otherwise :)

OK LGTM! Squashing incoming :slightly_smiling_face:


Multi-State Model Support

This is another interesting idea to support. :) For example, see section 6 in flexsurv's vignette: https://cran.r-project.org/web/packages/flexsurv/vignettes/flexsurv.pdf.

I would really like this too


⚠ Bofrost.at has degraded performance

In 9d1230c, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 2318 ms

Resolved: Bofrost.at performance has improved in 37c0e2a after 15 minutes.


Small tweak to Unity-HL2 getting started guide

I've run through this twice now on two different computers, and both times with Unity 2019.2.x and MRTK 2.2.0, the MRTK Project Configurator has popped up automatically after importing the asset package.
Obviously happy if you want to rewrite or restructure this, but figured I'd give you an easy one-line PR if that helps.

Docs Build status updates of commit 7b3bb4b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/mrlearning-base-ch1.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


deal with mobile

todo

[ ] investigate width unit

e.g.) vw, vh

[ ] define break points
[ ] use mixins
[ ] check design w/ :

pc
rotated mobile devices

memo
meta viewport
e.g.)
<meta name=”viewport” content=”width=device-width,initial-scale=1.0″>

dir. structures in Next.js
cf.)

Media queries in Next JS


Traffic flows with Host: <host>:<port> not allowed when hostname is set in HTTPRoute not Listener

Description:
Related https://github.com/envoyproxy/gateway/pull/1478#issuecomment-1644126796

as @jackkleeman already pointed out, EG maps the listener hostname into the IR listener hostname which maps to the Domains field in Virtual Hosts, but maps the http route hostname into IR Header matches
https://github.com/envoyproxy/gateway/issues/680 can fix this issue

I am currently working on a POC PR where we just use a virtualhost per domain we want to match against within a listener, instead of this :authority header match approach. Would you be happy with that?

for the time being as a workaround ive modified my crd to allow the use of : in header match name; that way i can just use an explicit match on :authority. i dont think theres any other way to do it right now

I am currently working on a POC PR where we just use a virtualhost per domain we want to match against within a listener, instead of this :authority header match approach. Would you be happy with that?

how do you plan on mapping it from an IR perspective ?
imo it might be easier to map the output of computeHosts to this

IgnorePortInHostMatching won't work for :authority exact/suffix header matching . because IgnorePortInHostMatching takes effect in find VirtualHost which matches the domain. https://github.com/envoyproxy/envoy/blob/ac42ba030f81a787d7bae7c3d0f59070ca7633ba/source/common/router/config_impl.cc#L1986C2-L1999C47

I've created a branch here with a proposal approach: https://github.com/envoyproxy/gateway/compare/main...jackkleeman:gateway:virtualhost2?expand=1
The general idea is that instead of creating a route in the IR per intersecting domain in the HTTPRoute, where each route has an :authority check, we just store in the IR the computed intersecting domains. Then, when creating the XDS, we use those domains to create more than one virtualhost - one per domain that we care about. then, we map each route into each virtual host that it matches into; so routes with domain *.example.com must go in the virtual host for foo.example.com AND *.example.com
the XDS logic here is a bit unpleasant. if we like this general approach, I can pull it out into individual tested functions so we have some confidence. i have added a new test that covers the whole PR; the current test coverage for the case with lots of different intersecting domains was quite poor

thanks for working on this @jackkleeman, took a peek into your branch and saw a lot of changes in the xds translator layer.
imo this can be solved in the gateway api layer w/o any changes in other places
Here is a suggestion

copy the o/p of hosts into irListener.Hostnames .
above hosts might need to get scrubbed to ensure there are no duplicates, if envoy doesnt like it
you can now also delete all the logic around header match of :authority
https://github.com/envoyproxy/gateway/blob/60e5f719f7a295b0b1f4e0bee20aa2ad6182d6ac/internal/gatewayapi/route.go#L493

how does that work? dont we need to be able to address specific routes by hostname? eg:
listener: *.example.com
route1: foo.example.com
route2: bar.example.com
with your suggestion, the listener would be for *.example.com foo.example.com bar.example.com and the routes would have no hostname selectivity. so wouldnt all traffic go to both routes?

youre absolutely right @jackkleeman , thanks for the correction, can you raise your changes as a PR, will raise this issue
in the community meeting since this design moves HTTPRoutes to Xds VirtualHost from N to 1 to 1:1

hey @jackkleeman, @zirain @AliceProxy and I discussed this issue in the community meeting today, and we were a -1 on using the regex approach which would slow down every data plane request, so indirectly +1 to your suggested idea of creating a new xds virtual host per IR route, will make sure to review your PR this week, thanks for raising it

ok, thanks!


get approval gate status rbac issue

We prefer small, well tested pull requests.
Please refer to Contributing to Spinnaker.
When filling out a pull request, please consider the following:

Follow the commit message conventions found here.
Provide a descriptive summary for your changes.
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Add inline code comments to changes that might not be obvious.
Squash your commits as you keep adding changes.
Add a comment to @spinnaker/reviewers for review if your issue has been outstanding for more than 3 days.

Note that we are unlikely to accept pull requests that add features without prior discussion. The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.
https://devopsmx.atlassian.net/browse/OP-12950

This PR  triggered this build in this execution, please merge to master only if this succeeds:  https://spin.prod.opsmx.com/#/applications/gcp-gitprtrigger/executions/details/01FXS96P3R014EJNBJW55TMW2X


val_loss=inf

I started training with train_bottleneck.py and managed to get a fast decreasing training loss till train_los=30 for epoch=25. However, the validation loss got the value "Inf" from epoch 1. Does anyone recognise this issue and how to solve this?

Seems to be a data related issue, comparable with the many val_loss=non issues reported. Issue solved by changing model.py, according to: https://github.com/qqwweee/keras-yolo3/issues/305#issuecomment-463042788


Tabbed Fields Styling Issue

Bug report
When creating a create/update on tabbed fields the styling that should be displayed is not working on fresh install.

What I did:
created tabbed fields with 'addField.'
What I expected to happen:
pretty tabs like before
What happened:
ugly vertical styling with no background or anything.
What I've already tried to fix it:
re-install all vendor files, copy/paste crud to fresh install.
Backpack, Laravel, PHP, DB version:

almasaeed2010/adminlte        2.4.3
backpack/base                         1.0.4
backpack/crud                         3.5.11
laravel/framework                    5.7.19
Valet                                          2.0.4

same problem here

For those wanting the older style:

I overwrote the /inc/show_tabbed_fields.blade.php file. and added some custom styling.
.tab-container {
  background: #fff;
  border-bottom: 0;
  box-shadow: 0 1px 1px rgba(0,0,0,0.1);
}
.nav-tabs-custom > .nav-tabs > li:first-of-type.active > a {
  border-left-color: #f4f4f4;
}

My Result

I had a similar problem and looking at my tabs just knew something was off. My tweak is
.nav-tabs-custom {             box-shadow: none;             background: #fff!important;         }
and to move the closing divs for <div class="nav-tabs-custom" id="form_tabs"> at line 47 to the end of the file.

How about vertical tabs? Does anyone has fix for vertical tabbing?

For vertical tab box class here https://github.com/Laravel-Backpack/CRUD/blob/bb57131e6b8bc0c94c13173edc66f3ebae093820/src/resources/views/inc/show_tabbed_fields.blade.php#L46 is setting width 100% which contradicts col-md-9 class

Ouch! You're totally right people - thanks a lot. Just pushed a fix for this, a composer update should do it for you - vertical tabs now look good again.


Fix screen resolution changes on Retina Mac running windowed Arcade app

This fixes the easy part of #890 where starting a windowed arcade app changes the screen resolution on Mac. When a Window is created it calls set_fullscreen. If the Window is not fullscreen then this calls Screen.restore_mode. restore_mode calls CGDisplaySetDisplayMode with the mode saved when CocoaScreen was created. This is not necessary because the screen mode was never changed. In the meantime setting up OpenGL may have changed the GPU from integrated to discrete. This exposes a bug in CGDisplaySetDisplayMode where it sets the screen to a random resolution. You can fix it by calling it again but this takes a long time. If the default mode is the same as the current mode, skip calling CGDisplaySetDisplayMode. There may still be cases where the current screen mode is not the same as the default mode, this does not fix those cases. But it fixes the problem I ran into.

Thank you for the pull request!


aa-genprof is broken

Describe the bug
aa-genprof is broken due to referencing /sbin instead of ${apparmor-parser}/sbin (I suspect that other apparmor tools are also affected)
To Reproduce
Steps to reproduce the behavior:

add security.apparmor.enable = true to configuration.nix
sudo nixos-rebuild switch (using master of nixpkgs, roughly a0c413f71d0d8bee11529e22e2d06ec47d1e2a75 at the time of writing
aa-genprof firefox outputs ERROR: Can't find apparmor_parser at /sbin/apparmor_parser

Expected behavior
I was expecting aa-genprof firefox to generate a profile for firefox.
Metadata
 - system: `"x86_64-linux"`
 - host os: `Linux 5.2.3, NixOS, 19.09.git.a0c413f (Loris)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.2.2`
 - channels(ajanse): `"unstable-19.09pre185259.362be9608c3"`
 - channels(root): `"nixos-19.03.173172.a607a931f6f"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
- apparmor-utils
# a list of nixos modules affected by the problem
module:

I would git bisect to find the offending commit, but my current config rebuilds the kernel often (long story, but each rebuild feels like an hour of compiling).

fixed in https://github.com/nixos/nixpkgs/commit/372edacef218efe37e222ada723e100e43ba272f i think


Thank you!

Hello @evbacher. Thank you for this add-on. It works perfectly and saved me a bunch of time. Truly appreciated.

You are welcome. Strikethrough text formatting is now working properly. Small iterations add up.


Replaced wrong method "process" with "handle"

It took me a while to find out why the example in your docu not worked for me. So, this could be helpful for other users.

This was an older version of PSR-15 that I forgot to change.
Thanks!


Allow overriding escape method

Change self to static to allow override escape method.

I'm not sure there is another way of reasonably implementing escape, is there a particular use case attached to wanting to override this method?

Oh yeah, we have use case when we do not allow any html input from user and only allow markdown syntax. We have this implemented by escaping everything before passing text to parsedown and that way we have double escaped code blocks. This will allow to disable escaping by parsedown.
Also i thought it would be no problem as escape method is protected so you can override it but it won't be used because of self. So maybe if you don't want this method to be overriden then it should be private?

Oh yeah, we have use case when we do not allow any html input from user and only allow markdown syntax. We have this implemented by escaping everything before passing text to parsedown and that way we have double escaped code blocks. This will allow to disable escaping by parsedown.

In this case you probably still don't want to override the method, e.g. if you don't escape quotes (which you'd need to permit for some markdown syntaxes) then consider what would happen given the following markdown input:
[foo](bar 'baz" onmouseover="alert(1)')

Right now this will result in
foo

But if you stop the escape method from escaping, it'll instead be:
foo

which is XSS.
The way in which markdown is required to be processed means that escaping input prior to parsing isn't sufficient (unless you actively counter markdown syntax specific vectors). You could perhaps reason about this by considering that escaping prior only guarantees safety as HTML, but not as interpreted markdown (and thus escaping prior isn't sufficient unless the markdown processor also has safety guarantees).
Incidentally, you can also still achieve XSS even if you escape quote via something like:
[xss](javascript:alert%281%29)

which outputs as

xss

Fortunately Parsedown has a safe-mode to deal with XSS from HTML input, and also with markdown specific vectors (like that last one), which I would advise using :)

Also i thought it would be no problem as escape method is protected so you can override it but it won't be used because of self. So maybe if you don't want this method to be overriden then it should be private?

It is protected, though that is more to do with visibility (i.e. it permits escape to be called by an extension). We perhaps mark it as final, although calling it via the class name (i.e. self) is also sufficient to use the known implementation without the need to prevent overriding. final might better communicate the intent I suppose.

In this case you probably still don't want to override the method, e.g. if you don't escape quotes (which you'd need to permit for some markdown syntaxes) then consider what would happen given the following markdown input:
[foo](bar 'baz" onmouseover="alert(1)')

Right now this will result in
foo

But if you stop the escape method from escaping, it'll instead be:
foo

which is XSS.

Yes, you are right but we are escaping text before passing it to parsedown so in this case we have
[foo](bar 'baz" onmouseover="alert(1)')

and parsedown produces:
foo

which is okay. But if user enter proper html such as:
foo

then parsedown won't escape that and we have XSS. If we escape all text without modifying parsedown then if we have escaped that html properly but when user enter markdown:
```
<a href="bar" title="baz" onmouseover="alert(1)">foo</a>
```

then and we escape this text we have:
```
<a href="bar" title="baz" onmouseover="alert(1)">foo</a>
```

and then when we pass this text to parsedown then we have:

&lt;a href=&quot;bar&quot; title=&quot;baz&quot; onmouseover=&quot;alert(1)&quot;&gt;foo&lt;/a&gt;

which is double escaped.
Again we want to allow creating links (and some other elements) with parsedown such as: [foo](link) but we don't want to allow inserting html. I hope I'm clear.
Maybe there's better way to prevent html but allowing markdown but i didn't find it :)

Yes, you are right but we are escaping text before passing it to parsedown so in this case we have
[foo](bar 'baz" onmouseover="alert(1)')

Indeed this will solve the concern about breaking out of quotes, but as mentioned, quotes are required for some markdown syntaxes (e.g. titles in link destinations), and so escaping them will break this type of markdown. Additionally this method still doesn't work, since escaping does nothing to address XSS caused by link destinations (inserting HTML directly isn't the only way of achieving XSS since markdown induces non-trivial transformations and converts perfectly safe characters from the escaper's perspective, to HTML—which isn't so safe).

Maybe there's better way to prevent html but allowing markdown but i didn't find it :)

Yes, there is! :) (as mentioned above) safe mode will deal with escaping HTML, as well as preventing things introduced by the markdown syntax (like javascript link destinations). Safe mode isn't enabled by default, because HTML is part of the markdown spec, so you've have to explicitly enable it by:
$parsedown = new Parsedown;
$parsedown->setSafeMode(true);

The benefit of using safe-mode over trying to combat the examples I've given here is that safe-mode is enforced by the parser (which understands the type of content it is producing from some given markdown syntax), and it'll also remain updated incase any new feature is added that permits similar danger to links.

Oh ok, thanks. I didn't notice that somehow :)


add ceylon.file::createTemporaryDirectory and File

It would be nice to have ceylon.file support for creating temporary directories and files. Something like:
import java.nio.file {
    JFiles=Files
}
shared Directory createTemporaryDirectory(String prefix = "") {
    value javaFile = JFiles.createTempDirectory(prefix);
    assert (is Directory result = parsePath(javaFile.string).resource);
    return result;
}

Edit - and to complement this feature, a way to deleteOnExit.

I thought we already had that somewhere.

For createTemporaryFile(), we might want to return a File & Destroyable, which attempts to delete the file on destroy().

@jvasileff I like that idea. However notice that java.nio.file already has createTempFile() and createTempDirectory() which perhaps we should reuse?
Anyway, want to send a PR?

Yeah, I was looking at java.nio.file.Files, I think. I can put something together once the build stabilizes.
BTW, any reason ceylon.file::File is sealed? This prevented me from writing something like this in my own code. And the docs seem to hint that you might want to write your own System, which would also require non-sealed interfaces.

BTW, any reason ceylon.file::File is sealed?

It's sealed? Oh that's unfortunate. I had thought to write my own FS at some point. That should definitely be changed if at all possible.

I now see that File & Destroyable createTemporaryFile() isn't possible; Destroyable resource expressions must be instantiation expressions. So it will be a class.

Moving to 1.2.2 in that case.

Moving to 1.2.3

This was resolved w/#472


Cleanup for release

Current coverage is 100% (diff: 100%)

No coverage report found for master at 16c7c4b.

Powered by Codecov. Last update 16c7c4b...7530b6d


Pull requests build on travis, but don't report

It looks like the PRs are built in travis, but we don't have commit status reports back.

possibly related to http://docs.travis-ci.com/user/migrating-from-legacy/

Seems fixed now


Dendrogram threshold color

This is a continuation of #3765, addressing comments and adding a unit test. I also rebased, squashed, and added the git commit message prefixes.

I think it's questionable, and have also received this spam. We'd rather just get donations for the project: http://scipy.org/scipylib/donations.html
I've filed an issue for removal at https://github.com/sigmike/peer4commit/issues/121


failed to build benchmarks -- undefined reference to BenchmarkName

Following the instructions on https://github.com/Maratyszcza/NNPACK#development-builds, I did the following to build NNPACK:
git clone https://github.com/Maratyszcza/NNPACK.git
cd NNPACK
confu setup
./configure.py
ninja

and it successfully built a bunch of stuff, until it failed with the following error:
[150/196] LINK bin/winograd-bench
FAILED: /path/to/NNPACK/bin/winograd-bench
g++ -pthread  -o /path/to/NNPACK/bin/winograd-bench /path/to/NNPACK/build/bench/winograd.cc.o /path/to/NNPACK/lib/libnnpack.a /path/to/NNPACK/lib/libpthreadpool.a /path/to/NNPACK/lib/libcpuinfo.a /path/to/NNPACK/lib/libclog.a /path/to/NNPACK/lib/libgooglebenchmark.a -lrt
/path/to/NNPACK/lib/libgooglebenchmark.a(benchmark_runner.cc.o): In function `benchmark::internal::RunBenchmark(benchmark::internal::BenchmarkInstance const&, std::vector<benchmark::BenchmarkReporter::Run, std::allocator<benchmark::BenchmarkReporter::Run> >*)':
/path/to/NNPACK/deps/googlebenchmark/src/benchmark_runner.cc:201: undefined reference to `benchmark::BenchmarkName::str[abi:cxx11]() const'
/path/to/NNPACK/lib/libgooglebenchmark.a(benchmark.cc.o): In function `benchmark::RunSpecifiedBenchmarks(benchmark::BenchmarkReporter*, benchmark::BenchmarkReporter*)':
/path/to/NNPACK/deps/googlebenchmark/src/benchmark.cc:402: undefined reference to `benchmark::BenchmarkName::str[abi:cxx11]() const'
/path/to/NNPACK/deps/googlebenchmark/src/benchmark.cc:230: undefined reference to `benchmark::BenchmarkName::str[abi:cxx11]() const'
/path/to/NNPACK/lib/libgooglebenchmark.a(benchmark_register.cc.o): In function `benchmark::internal::BenchmarkFamilies::FindBenchmarks(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::vector<benchmark::internal::BenchmarkInstance, std::allocator<benchmark::internal::BenchmarkInstance> >*, std::ostream*)':
/path/to/NNPACK/deps/googlebenchmark/src/benchmark_register.cc:229: undefined reference to `benchmark::BenchmarkName::str[abi:cxx11]() const'
/path/to/NNPACK/lib/libgooglebenchmark.a(json_reporter.cc.o): In function `benchmark::JSONReporter::PrintRunData(benchmark::BenchmarkReporter::Run const&)':
/path/to/NNPACK/deps/googlebenchmark/src/json_reporter.cc:198: undefined reference to `benchmark::BenchmarkName::str[abi:cxx11]() const'
/path/to/NNPACK/lib/libgooglebenchmark.a(reporter.cc.o):/path/to/NNPACK/deps/googlebenchmark/src/reporter.cc:86: more undefined references to `benchmark::BenchmarkName::str[abi:cxx11]() const' follow
collect2: error: ld returned 1 exit status

(For brevity, I find/replaced my actual path to /path/to.)
When I do a multithreaded ninja build, of the benchmarks fail to build with the above error. I am particularly interested to use the benchmarks, so I definitely want to figure out how to build them.
Any ideas what might be wrong?
I poked around in googlebenchmark for a while, but I been able to diagnose it so far.

Interestingly, when I look at the auto-generated NNPACK/build.ninja file, I see most of the other code files from googlebenchmark (e.g. csv_reporter.cc, statistics.cc), but not benchmark_name.cc. That seems odd.

Google Benchmark added source files, and those need to be reflected in the confu recipe: https://github.com/Maratyszcza/confu/blob/master/confu/recipes/googlebenchmark.py#L24-L43
Alternatively, you can use CMake to build NNPACK.

That worked. Thanks!


Differences between fluentd buffer_queue_limit, queue_limit_length and queued_chunks_limit_size

My understanding is that buffer_queue_limit and queue_limit_length are the same. These parameters determine how many chunks will be maintained until its full which trigger overflow_action?
Is queued_chunks_limit_size the same thing?
Thanks for the help!
This issue was opened and closed in #2157 , but was never answered.
Maybe now someone will know?

My understanding is that buffer_queue_limit and queue_limit_length are the same

Yes, see https://docs.fluentd.org/plugin-helper-overview/api-plugin-helper-compat_parameters

Is queued_chunks_limit_size the same thing?

No. See https://docs.fluentd.org/configuration/buffer-section#buffering-parameters

This issue was opened and closed in #2157 , but was never answered.

Maybe, he follows contribution guide: https://github.com/fluent/fluentd/blob/master/CONTRIBUTING.md#got-a-question-or-problem
or find the answer in the official document.


Cyclic reference error with autoload, preload and ordering

Godot version
4.1 stable
System information
Windows 11
Issue description
An error Parser Error: Could not resolve member "main": Cyclic reference. occurred when I tried to reference a preload() variable in the autoload by the other scenes. It crashes regardless if the related code has been accessed or not. (Possibly during pre-check by the engine?) More info and tests below.
Steps to reproduce
Prepare:

Autoload "event.gd", with the order-mattered content @onready var sub = preload(...sub.tscn) and @onready var main = preload(...main.tscn)
Scene "launcher.tscn" without script (to launch as the main scene, although not required at all)
Scene "main.tscn" with script "main.gd" with any kind of function that does print(Event.main)
Scene "sub.tscn" with script "sub.gd" with any kind of function that does print(Event.main)

Procedure:

Just launch any of the scenes available, it will crash with error Parser Error: Could not resolve member "main": Cyclic reference., pointing at "main.tscn", at code print(Event.main), even if it has not been accessed yet.

Additional:

Error does not occur if the order of variable sub and main in "event.gd" is reversed.
Error does not occur if variable main in "event.gd" use load() instead.
Error does not occur if only variable sub OR main exist alone in "event.gd".

Which means the "main.tscn" that has print(Event.main) actually cause no cyclic issue at all.

Minimal reproduction project
debug.zip

I'm not sure if I understand the flow, but the problem is that the error was output on main.gd instead, which sub.gd should have already done parsing before it.
I believe the real issue is, the order of the variable matters. I'll try to illustrate a bit:
# main.tscn & sub.tscn (has the same function)
func random_func():
	print(Event.main)

# TEST 1
# Event.gd (autoload)
@onready var sub = preload("res://sub.tscn")
@onready var main = preload("res://main.tscn")
# Error produced on main.tscn, on function that calls for Event.main

# TEST 2
# Event.gd (autoload)
@onready var main = preload("res://main.tscn")
@onready var sub = preload("res://sub.tscn")
# No error occurs

On "# TEST 1", Event.gd preloads sub.tscn that has a function calls for Event.main, which has no problem.
But when it tries to preload the next main.tscn that has a function calls for Event.main, error occurred.
On "# TEST 2", Event.gd preloads main.tscn FIRST, that has a function calls for Event.main, nothing occurs (as well as the next preload sub.tscn)
So, based on "# TEST 1", the preloading of sub.tscn already knows the existence of the member Event.main, yet on preloading of main.tscn, it produces a cyclic error. It seems like a false result.


Expected a request for an address, but did not receive one

The Issue
Seeing the below when running .20rc9 on a clean install.
2018-05-14 09:23:17,171 WARNING  lbrynet.core.Wallet:1387: Expected a request for an address, but did not receive one
2018-05-14 09:23:17,171 WARNING  lbrynet.core.server.ServerRequestHandler:162: An error occurred handling a client request. Error message: Expected but did not receive an address request
2018-05-14 09:23:17,174 WARNING  lbrynet.core.server.ServerRequestHandler:128: An error occurred handling a request. Error: Expected but did not receive an address request
2018-05-14 09:23:17,174 CRITICAL twisted:154: Unhandled error in Deferred:
2018-05-14 09:23:17,174 CRITICAL twisted:154:
ValueError: Expected but did not receive an address request
2018-05-14 09:23:17,174 CRITICAL twisted:154: Unhandled error in Deferred:
2018-05-14 09:23:17,174 CRITICAL twisted:154:
ValueError: Expected but did not receive an address request
2018-05-14 09:23:20,500 WARNING  lbrynet.core.Wallet:1387: Expected a request for an address, but did not receive one
2018-05-14 09:23:20,500 WARNING  lbrynet.core.server.ServerRequestHandler:162: An error occurred handling a client request. Error message: Expected but did not receive an address request
2018-05-14 09:23:20,500 WARNING  lbrynet.core.server.ServerRequestHandler:128: An error occurred handling a request. Error: Expected but did not receive an address request

System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

This stopped happening in later builds, closing for now.


CTUtil: interprete Array-Path in orderBy-Method

Pass an "Array-Path" to the orderBy-Method:
->orderBy("meta.created_at")
This code will order the Array by the created-at attribute nested in the meta array.

CTUtil-Method to use: #4fda8a5

Won't fix.


Add ability to match on ANYTHING for a custom slot, not just the supplied values

Need an ability to match on any supplied value, not just on the values provided in the custom slot definitions.  This needs to be done on a per-utterance basis.  For example, for an utterance like this:
"my first name is " it would be ok to do since it's a fairly specific utterance.  But the same intent and slot value in this utterance: "" should ALMOST NEVER be matched on whatever is supplied since it will match on ANYTHING.

Implemented via slot flag INCLUDE_WILDCARD_MATCH


Improve undo of EditCommands

Address #190
Formalize the undo role of different edit commands via exhaustive
matching
Open questions:

[ ] Undo behavior of pure moves

Do we want to make them undoable
Do we have to register them for accurate undos of true edits

[ ] Manual backspace and delete

Do we want to coalesce them if a whole word is manually deleted?

Excluding the moves as in 85dab62 has the weird side effect that after an undo the cursor jumps back to where it was after the last text changing operation

(Deletion of is with Ctrl+w and then undo via Ctrl+z)

Conversely when moves are recorded, undos will follow the cursor (Current behavior on main)

(Moving backwards with left arrow, undo (Ctrl-z) a few times and redo (Ctrl-g) again)

Would decide to merge this first (with undoable moves) and let somebody address the moves later with #193
CI checks failed due to more sensitive rustc/clippy warnings with latest toolchain


[$500] Standardize form error styles

Problem:
Right now we have mutliple different ways of styling a form error.

Solution:
Let's standardize on how we style these form errors. Ideally this should follow the red brick road (dot indicator) style.

Details:

Let's standardize on the dot indicator component we have as the main way to show an error
Let's update this component to use all red text (except things like links) instead of gray text

After some brief Slack discussion, let's move forward with making the error text all red as well. I have updated the original comment in this issue with the desired outcome.

Proposal
We can reuse DotIndicatorMessage here, we will also need to add a new prop textStyle we will use it for passing styles for text here
https://github.com/Expensify/App/blob/124ab4296f3d04ee276efbf0d74ff6eceb544898/src/components/DotIndicatorMessage.js#L61
And we just have to make changes in BaseTextInput
 class BaseTextInput extends Component {
     constructor(props) {
@@ -198,7 +199,6 @@ class BaseTextInput extends Component {
         const inputProps = _.omit(this.props, _.keys(baseTextInputPropTypes.propTypes));
         const hasLabel = Boolean(this.props.label.length);
         const inputHelpText = this.props.errorText || this.props.hint;
-        const formHelpStyles = this.props.errorText ? styles.formError : styles.formHelp;
         const placeholder = (this.props.prefixCharacter || this.state.isFocused || !hasLabel || (hasLabel && this.props.forceActiveLabel)) ? this.props.placeholder : null;
         const textInputContainerStyles = _.reduce([
             styles.textInputContainer,
@@ -304,10 +304,13 @@ class BaseTextInput extends Component {
                             </View>
                         </TouchableWithoutFeedback>
                     </View>
-                    {!_.isEmpty(inputHelpText) && (
-                        <Text style={[formHelpStyles, styles.mt1, styles.ph3]}>
-                            {inputHelpText}
-                        </Text>
+                    {(!_.isEmpty(this.props.hint) && _.isEmpty(this.props.errorText)) && (
+                    <Text style={[styles.formHelp, styles.mt1, styles.ph3]}>
+                        {inputHelpText}
+                    </Text>
+                    )}
+                    {!_.isEmpty(this.props.errorText) && (
+                        <DotIndicatorMessage messages={{0: inputHelpText}} type="error" textStyle={[styles.formError, styles.mt1]} />
                     )}
                 </View>

We can also use a variable shouldShowHint to check if we can show the hint and we can use it like this
                    {shouldShowHint && (
                        <Text style={[formHelpStyles, styles.mt1, styles.ph3]}>
                            {inputHelpText}
                        </Text>
                    )}

For bottom error we need to pass themeColors.textError at https://github.com/Expensify/App/blob/124ab4296f3d04ee276efbf0d74ff6eceb544898/src/components/FormAlertWrapper.js#L63
https://github.com/Expensify/App/blob/124ab4296f3d04ee276efbf0d74ff6eceb544898/src/components/FormAlertWrapper.js#L67
https://github.com/Expensify/App/blob/124ab4296f3d04ee276efbf0d74ff6eceb544898/src/components/FormAlertWrapper.js#L76
and for icon we can use -
<Icon src={Expensicons.DotIndicator} fill={colors.red} height={variables.iconSizeSmall} width={variables.iconSizeSmall} />

https://github.com/Expensify/App/blob/124ab4296f3d04ee276efbf0d74ff6eceb544898/src/components/FormAlertWrapper.js#L59
FormAlertWrapper component will be refactored soon with the red dot in https://github.com/Expensify/App/issues/11410 so I think we should leave this part to get fixed there.

Reviewing now!

@Puneet-here either customize the DotIndicatorMessage completely to fit here or create a new simple component for the same.

To me, this issue is exported first and completely focuses on the styling and mentioned the requirements so it should be done as part of it.

Upwork: https://www.upwork.com/jobs/~01f4b150900a44d8e0

Going to be OOO next week so I'm going to re-assign so this can keep moving along

@parasharrajat @Puneet-here thanks, waiting for a full proposal

Not overdue!

Going to double

Waiting for proposals
@Puneet-here interested in updating yours?

I am working on some other issues right now and I will be busy this week because of festivals so I won't be able to look into it.

No problem!

Thanks for the proposal @0xmiroslav. It looks fine but I think it will create issues in FormAlertWrapper. RenderHTML contains View(block elements) View does not render well in Text. You may have to make it more dynamic. I think the best thing to do would be to use another prop called text and when passed using the current text rendering logic that you have in FormHelpMessage. And overwrite everything with children when passed.
I think we can move forward with @0xmiroslav's proposal as this is a UI issue and it needs to go through a few iterations before we reach the desired UI. This can be done during the PR review.
cc: @mountiny
:ribbon: :eyes: :ribbon:  C+ reviewed

Thank you very much @parasharrajat
@0xmiroslav can you please raise your PR and accomodate it with recordings of all the paltforms so we can see how it looks?

@0xmiroslav any updates here

@0xmiroslav can you let us know when your PR will be ready for review?

Any updates here @parasharrajat

This is now in staging @dylanexpensify 🎉

It hasnt been that complex but I appreciate the PR grew in size. I think we can offer a $250 bonus for this work cc @dylanexpensify and @parasharrajat

I think we missed one location in the app to check. I did during testing as well.
the PasswordForm for protected PDF attachment.

There is a new issue which is related to this page but not the same issue https://github.com/Expensify/App/issues/12520.
@mountiny Should we create a follow up and fix it or ask on the other issue to take care of this?

I think let just do it here. @0xmiroslav Could you please raise a follow up PR to fix this as well?

I think let just do it here. @0xmiroslav Could you please raise a follow up PR to fix this as well?

I agree, that should be simple enough. No need to CP either.

Do we have an ETA when we could get the add-on PR raised?

@dylanexpensify lets not forget to increase the bounty here for $750 given @0xmiroslav had to work on this one a bit more. Not sure how you keep track of these, maybe update a title

reviewing today!

@parasharrajat @0xmiroslav please apply here! TY!

Offers sent! @parasharrajat @0xmiroslav

@0xmiroslav @parasharrajat Has this been all paid up?

@parasharrajat @0xmiroslav paid! (keeping this opened for the rest of the checklist)

I think this was not a bug per se but more so a follow up to our Form refactor and aligning on the styles in other forms/inputs hence I am not linking any PR since this was not a regression.
And therefore we dont have to add any new test into testrail either given this is not regression and there are tests covering forms and failure.s

I think I was not paid the correct amount as per https://github.com/Expensify/App/issues/11908#issuecomment-1311494259. @NicMendonca

@parasharrajat sent over amount missing!


Publish finders after integration data sync

This is necessary to publish any pre-production finders to Integration; without doing this, the prod sync wipes those out.

This also needs publishing_api:publish_finders or they'll 404.

@rgarner thanks, fixed.

:+1:

Looks good to me, after Paul and Alex's comments are addressed.


reanimate-svg-<IP_ADDRESS>: Simplifier ticks exhausted

While building for the Stackage Nightly build encountered:
Building library for reanimate-svg-<IP_ADDRESS>..
[ 1 of 17] Compiling Graphics.SvgTree.Misc
[ 2 of 17] Compiling Graphics.SvgTree.CssTypes
[ 3 of 17] Compiling Graphics.SvgTree.NamedColors
[ 4 of 17] Compiling Graphics.SvgTree.Types.Basic
[ 5 of 17] Compiling Graphics.SvgTree.Types.Internal
[ 6 of 17] Compiling Graphics.SvgTree.Types.Hashable
Simplifier ticks exhausted
  When trying UnfoldingDone $fGenericDrawAttributes_$cfrom
  To increase the limit, use -fsimpl-tick-factor=N (default 100).

  In addition try adjusting -funfolding-case-threshold=N and
  -funfolding-case-scaling=N for the module in question.
  Using threshold=1 and scaling=5 should break most inlining loops.

  If you need to increase the tick factor substantially, while also
  adjusting unfolding parameters please file a bug report and
  indicate the factor you needed.

  If GHC was unable to complete compilation even with a very large factor
  (a thousand or more), please consult the "Known bugs or infelicities"
  section in the Users Guide before filing a report. There are a
  few situations unlikely to occur in practical programs for which
  simplifier non-termination has been judged acceptable.

  To see detailed counts use -ddump-simpl-stats
  Total ticks: 540240
curator: Received ExitFailure 1 when running

I don't know if this is easily reproducible, but thought I would just record with this report anyway.

I'll remove reanimate with the constraint > <IP_ADDRESS> from stackage for now (since it breaks nightly - ghc 9.4.4 - and lts - ghc 9.2.7 - builds). Should automatically be re-added as soon as a higher version gets published (which hopefully builds reliable 👍 ). Thanks for your understanding.


Remove Duplicate State Update Data Storage

Some of the data stored in StateUpdatesByBlockNumber already exists in the database and shouldn't be stored again. Storing them again unnecessarily bloats our database.
This PR removes duplicate data storage and introduces a new way to store the nonce.
Changes

Nonce: Introduces historical nonce storage outside StateUpdate. Storing nonces in a separate table allows us to be able to serve starknet_getNonce in the future.
Remove duplicate data storage: Stop duplicated storage of block hashes, roots, declaredClasses, and deployedContracts since they are already stored as part of the block.

declaredClasses, and deployedContracts since they are already stored as part of the block.

That is not particularly correct. Txns in blocks could fail during execution, even if included in a block. So It is not really possible to rebuild declaredClasses, and deployedContracts just by looking at deploy and declare txns.

Stop duplicated storage of block hashes, roots

not really worth the effort, they are couple of felts per block anyways

That is not particularly correct. Txns in blocks could fail during execution, even if included in a block. So It is not really possible to rebuild declaredClasses, and deployedContracts just by looking at deploy and declare txns.

I think we should be able to skip failed transactions as it'll reflect in the status that the transaction has failed.

not really worth the effort, they are couple of felts per block anyways

Imo, these couple of felts add up at the end of the day. It may seem little at the moment, but when we start synching millions of blocks, it'll add up to something huge. We should look for ways to make our db smaller and future-proof

3 extra felts per block makes 96MB extra space used per 1M blocks. It is a drop in the bucket.

Closing this given the comments above


Use %v format for non-strings (and don't have String() method)

errors
KVPair.Key
Identifier fields in lib/errors/errors.go

This was prompted specifically by the following problem, seen in KDD/routereflector work:
2017-12-05 22:11:19.429 [INFO][16] watchercache.go 156: Failed to perform list of current data during resync ListRoot="/calico/ipam/v2/host/" error=operation List is not supported on { %!s(int=0)}


Feature

Great work on a non cloud solution for echo and node integration.
I would like control devices like garage doors etc, is possible to add I intents like open and close? Or because your are using hue emulator only the hue based intents are available?

You can control any device, but using "turn off/on" Alexa commands. I haven't found a way to use Open/Close commands for example, without using Alexa skills. As for now, only Hue emulated devices are supported.

Yes got it thanks.


Refactored tests from gopass binary instrumentation towards interface tests

see comment in #573

Some basic tests remain in tests/jsonapi_test.go to make sure that gopass properly passes stdin/out to the jsonapi code. All other cases are now tested in api_test.go.


Feat/enhancements

Closes #147 - added faq , explaining how total points work

This has been added in the faq online, hopefully explaining why the points in your case were not increasing, by design.
It is important to understand that the total points you see in the different apps or site are the points for the unique (distinct) Cotacols you rode.
So, if your weekly training loop contains the Berendries (#792), no matter how many times you ride it, you'll only get the 81 points once.


Issue: Unable to Play Entire Local Music Folder and Limited Playlist Options

What version of Music Assistant has the issue?
2.3.2
What version of the Home Assistant Integration have you got installed?
No response
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
Hi folks, I've been struggling with playing an entire music folder on my local network using Music Assistant (MA). I have a music folder mounted from my Synology NAS, which contains multiple subfolders categorized by genre or artist.
Problem 1: Adding Entire Folder to Queue or Playlist On the desktop interface, I can select all files using Ctrl + A and easily add them to the queue. However, on the Android companion app, there doesn't seem to be a simple way to add an entire folder (including its subfolders) to the queue or to a playlist. This makes it cumbersome to play large collections of music, especially when there are many files spread across different subfolders.
Problem 2: Limited Options for Multiple Selections When selecting multiple songs on the Android app, the only option available is to add them to the queue. There is no option to add the selected songs to a playlist. The "Add to Playlist" option is only available when viewing the individual song's information, making it time-consuming to create a playlist with multiple tracks.
How to reproduce

Mount a music folder from Synology NAS in Music Assistant, containing multiple subfolders (e.g., categorized by genre or artist).
Open the Music Assistant Companion App on Android.
Attempt to add an entire folder (including subfolders) to the queue or a playlist.
Notice that there is no direct option to add the folder; you need to enter each subfolder and manually select tracks.
Even when multiple tracks are selected, the app only provides the option to add them to the queue, not to a playlist.

Music Providers
Filesystem (remote share)
Player Providers
Any
Full log output
No response
Additional information
No response
What version of Home Assistant Core are your running
2024.7.4
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

Hi OzGav, thanks for your reply. Would you be more specific that by using which app so I can create a playlist and be played by MA? I did have tried VLC's m3u but MA didn't wanna play.

Others have successfully used VLC. If you are down too many levels then this might the problem https://github.com/music-assistant/hass-music-assistant/issues/2291

Moving to feature request


As a learner, I want to be apart a cohort of learners so that I can consume content that is most relevant to me.

Background
Explore the experience of creating custom courses that is visible to a subset group of users.
Goal
No response
Acceptance criteria

Creation of roles/cohorts (roles = students & professors) (cohorts = students & professor relation)
Expose existing content from 3rd party location through custom syllabus (course)
Exposing content to the correct cohort of students
Exposing public/private syllabus to cohorts
Additional branding elements for course catalog and course experience

Out of scope
No response
Resources
No response
Tasks
No response

@gracelindsell has created a design here

This repository is no longer maintained. It has been superseded by IBM Quantum Learning.


Doesn't work with Storyboard

It only works with blank storyboard view controller (as in example).
However I have some UI components connected with code. They become broken if using "Storyboard" init approach of SLKTextViewController.

Ok, got it. Thanks!


fix: prevent insertion of nil values in the dictionary

Description
Fixed issues #39 and #89.
The problem was that nil was potentially inserted into the returned NSPlaceholderDictionary.

@machour looks good to me!

Thank you so much. Just tested this in an app, looks fine.


Stockholm region is missing

The new Stockholm region is missing from Region enum (it's eu-north-1). Thankfully we have the custom variant.

Also this https://github.com/durch/rust-s3/blob/d6d43ac31cad39651e254911d6f4300bda9113a4/src/region.rs#L131 should fail. If  you try to parse an unknown region it should completely fail. Instead you should manually create the Region using a region and an endpoint string (as the docs suggest).


Fixed docstring for stopServices() & startServices() and url for _usagereport.py query()

Fixed docstring for stopServices() & startServices() in _services.py and url for _usagereport.py query()

Thanks!


separate css and js codes

With this development, CSS and JavaScript codes have been separated from the HTML file and moved to assets folder.

thanks for the pr,
if we are going to do this, i thnk we need different approach.
We can use webpack and bundle all js files into one (as well as css files too). With this way instead of many network requests we can reduce them to two.
To do this we need to change local development environment (setup nodejs, configure webpack etc.).
i am closing this for now.
@dinncer let me know if you have any different ideas.


[Run Admin] Submission Overview Revisit and add missing info

TODOs:

[ ]  Load data when loading the view
[ ] Paginate submissions
[ ] Display team information instead of IDs.

I think a mechanism to show the actual content of the submission would be good. Also, when showing the team names rather than ids, maybe it can be built in such a way that you actively need to click something to see the team information, such that submissions are 'anonymous' by default.

What do you mean by 'the actual content'?

There are now two mode: anonymized and deanonymized and a user can toggle between them (anonymized being the default). Does that work?

By 'the actual content' I mean the image or video sequence in question.

By 'the actual content' I mean the image or video sequence in question.

Done! We're now showing the thumbnail also used in the viewer. Mind that the resolution of that thumbnail is currently very small.

For videos, yes. For images, it will use the original resolution if I'm not mistaken.


[Bug] tap_action for header_actions with floating header broken

Checklist

[x] I updated the card to the latest version available
[x] I cleared the cache of my browser
[x] I verified that I'm really running the lastest version in my browser console
[x] I checked if there is another issue opened with the same problem

Describe the bug
If i use the card with the following yaml-code the tap_action for the states in the header is broken. The tap_action is working again if i set "floating" == "false" in header options.
Version of the card
Version: 2.0.4
To Reproduce
This is the configuration I used:
type: custom:apexcharts-card
layout: minimal
header:
  show: true
  show_states: true
  colorize_states: true
  floating: true
all_series_config:
  stroke_width: 2
  float_precision: 1
  show:
    in_header: raw
    legend_value: false
  type: area
  opacity: 0.2
  statistics:
    type: mean
    period: 5minute
span:
  end: minute
graph_span: 24h
apex_config:
  chart:
    height: 200px
  legend:
    show: false
  tooltip:
    items:
      display: flex
series:
  - entity: sensor.eg_temperatur
    stroke_width: 1
    color: red
    type: area
    opacity: 0.2
    header_actions:
      tap_action:
        action: more-info

Screenshots

https://github.com/RomRider/apexcharts-card/assets/29648553/37993f63-7908-4957-ace4-f0a6262b2ca9

Expected behavior

https://github.com/RomRider/apexcharts-card/assets/29648553/3455dc56-1b05-4b3d-8044-1a1ac9b9fba9
The tap_action should behave like the tap_action if floating is set to "false"

Desktop (please complete the following information):

Browser: Chrome
Version 118.0.5993.120

Smartphone (please complete the following information):

Device: Pixel 6
OS: Android 14
Browser: Chrome
Version: 118.0.5993.112

Additional context

@guevara777 I realize this card is closed, but I ran into this issue today as well. When the header is floating, it sits under the graph (you can see this in practice as the graph is drawn over the header info). If you have card-mod installed, then you can use it in your card to bring the header above the graph to make it tappable.
card_mod:
  style: |
    #header.floating {
      z-index: 1;
    }

Alternatively, I forked the repo and updated #header.floating in styles.ts to include the z-index element, built from my fork, and installed the resource in HAOS. This works without using card_mod. (Needed to remove the HACS install of apexcharts-card though.)
You may be able to adjust the apexcharts-card.js file manually without going through that trouble as well, but I'm not positive and that would get overwritten on any updates through HACS anyway.

@guevara777 I realize this card is closed, but I ran into this issue today as well. When the header is floating, it sits under the graph (you can see this in practice as the graph is drawn over the header info). If you have card-mod installed, then you can use it in your card to bring the header above the graph to make it tappable.
card_mod:
  style: |
    #header.floating {
      z-index: 1;
    }

Alternatively, I forked the repo and updated #header.floating in styles.ts to include the z-index element, built from my fork, and installed the resource in HAOS. This works without using card_mod. (Needed to remove the HACS install of apexcharts-card though.)
You may be able to adjust the apexcharts-card.js file manually without going through that trouble as well, but I'm not positive and that would get overwritten on any updates through HACS anyway.

Thank you 👍


Complain about wikipedia links to disambiguation pages

To replicate:

create an empty node.
select adding a Wikipedia tag
add fr:Micromania
description will show "Wikipedia disambiguation page" and https://www.wikidata.org/wiki/Q3312213 has "instance of Wikimedia disambiguation page"

But validator is not complaining and not making clear that it is a certainly wrong link.
Examples from Poland recently added by iD users: https://www.openstreetmap.org/node/6955967403 https://www.openstreetmap.org/node/7419077047 https://www.openstreetmap.org/node/7439953503
Related:  #4414

This is an okay idea in theory, but it'd take a lot of development work only to detect a few stray mistags. iD doesn't yet have validations that make server requests so we'd need to do a lot of refactoring. Plus checking every downloaded feature could cause performance issues.
I'd say let's fix #4414 to prevent new mistags and then perhaps someone can create a MapRoulette campaign to fix existing mistags.


Multiple jar plugin

Fixes #56

I have just tested it, and the scalatest includes the plugin jars  in the classpath despite being 'provided dependencies' ( the jars included in the classpath are listed in the TEST-com.hotels.styx.plugins.PluginPipelineSpec.xml), so we are effectively loading the plugin from the application classpath.
We should find a way around that if we really want to test we are loading the plugins correctly.

Note: I have added some refactoring, this is not intended to address @dvlato 's most recent comment, but to make unit-testable classes (mocking the classloading).

@dvlato Regarding your comment "the scalatest includes the plugin jars in the classpath" - is it the contents of the JAR or only the JAR itself? Does the normal classloader look inside the JARs or just regard them as non-class files?

If a jar is listed in the classpath, it is available. Otherwise only its
folder would be listed.
Classpaths usally reference:

Folders. The classloader will find classes inside the folder.
individual jar files. The classloader will find classes inside the jar
file.

That's why in startup scripts we list all the jar files one by one. That's
obvously different from other kinds of packaging (war, ear, rar files) that
can contain nested jar files inside.
I would assume that can add precondition assertions before the test : try
to load the plugin with the current (application/system) classloader and
assert that it throws a ClassNotFoundException.
El lun., 16 abr. 2018 11:03, kvosper<EMAIL_ADDRESS>escribió:

@dvlato https://github.com/dvlato Regarding your comment "the scalatest
includes the plugin jars in the classpath" - is it the contents of the
JAR or only the JAR itself? Does the normal classloader look inside the
JARs or just regard them as non-class files?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/HotelsDotCom/styx/pull/138#issuecomment-381530248,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AX-PjgN-kcVas94owD3IkfOaFAepowOUks5tpF5dgaJpZM4TSMwV
.


How can i make screen wave like on Sunshine sonic.exe

Describe your problem here.
i am trying to port but it was my first time doing it, LUA is what i am using i already did the lights out but idk how to make screen wave and floating opponent in circle help plssss

Are you modding a build from source or with Lua?
Lua
What is your build target?
Neko, HashLink, or other build system
Did you edit anything in this build? If so, mention or summarize your changes.
Just winning icon

you can create a vcr effect with addVCREffect() and for the floating effect
local floaty = 41.82
local tailscircle = '' -- you'll use this to make the opponent hover up/down or in circles

function onUpdate()
	floaty = floaty+0.03

	if tailscircle == 'hovering' or tailscircle == 'circling' then
		setCharacterY('dad', getCharacterY('dad')+math.sin(floaty) * 1.3);
	end
	if tailscircle == 'circling' then
		setCharacterX('dad', getCharacterX('dad')+math.cos(floaty) * 1.3);
	end
end

Thank you so much ♥♥
On Tue, Jan 18, 2022, 8:15 AM frantastic24 @.***> wrote:

you can create a vcr effect with addVCREffect() and for the floating
effect
local floaty = 41.82
local tailscircle = '' -- you'll use this to make the opponent hover up/down or in circles
function onUpdate()
floaty = floaty+0.03
if tailscircle == 'hovering' or tailscircle == 'circling' then
setCharacterY('dad', getCharacterY('dad')+math.sin(floaty) * 1.3);
end
if tailscircle == 'circling' then
setCharacterX('dad', getCharacterX('dad')+math.cos(floaty) * 1.3);
end
end
—
Reply to this email directly, view it on GitHub
https://github.com/ShadowMario/FNF-PsychEngine/issues/3658#issuecomment-1014967649,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7OPGG7DO7B7ZS2TVYMCQTUWSWJTANCNFSM5MDJ6OLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

can i ask 1 amm, where i gonna put the 'addVCREffect()' on stage or lua on
data tnxx
On Tue, Jan 18, 2022, 8:15 AM frantastic24 @.***> wrote:

you can create a vcr effect with addVCREffect() and for the floating
effect
local floaty = 41.82
local tailscircle = '' -- you'll use this to make the opponent hover up/down or in circles
function onUpdate()
floaty = floaty+0.03
if tailscircle == 'hovering' or tailscircle == 'circling' then
setCharacterY('dad', getCharacterY('dad')+math.sin(floaty) * 1.3);
end
if tailscircle == 'circling' then
setCharacterX('dad', getCharacterX('dad')+math.cos(floaty) * 1.3);
end
end
—
Reply to this email directly, view it on GitHub
https://github.com/ShadowMario/FNF-PsychEngine/issues/3658#issuecomment-1014967649,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7OPGG7DO7B7ZS2TVYMCQTUWSWJTANCNFSM5MDJ6OLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

if you are planning to just use it in one stage just put it in your stage .lua under onCreate()

Like this, i run the game and the stage is gone

you have to specify which camera to add the effect on, like addVCREffect('camHUD') for example

ohh, okay imma try it

for some reason, if i put it in the TDStage.lua the TailsBG is gone but it doesn't say error on lua

then you're doing something wrong

but i placed it on under the function onCreate()

you didn't close the line with ;

im sorrryyy, i am not good at lua's
On Tue, Jan 18, 2022, 10:50 AM frantastic24 @.***>
wrote:

you didn't close the line with ;
—
Reply to this email directly, view it on GitHub
https://github.com/ShadowMario/FNF-PsychEngine/issues/3658#issuecomment-1015024411,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7OPGBIAQBG5AU5OKNOSS3UWTIQFANCNFSM5MDJ6OLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

i did it but, i doesn't apply the effects and bg still gone

!

you probably have an outdated version that doesn't support shaders then

I am at 0.5, but still thank you for your help :)
On Tue, Jan 18, 2022, 11:16 AM frantastic24 @.***>
wrote:

you probably have an outdated version that doesn't support shaders then
—
Reply to this email directly, view it on GitHub
https://github.com/ShadowMario/FNF-PsychEngine/issues/3658#issuecomment-1015035589,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7OPGFW7AYEP5Y3XJT3OMLUWTLSTANCNFSM5MDJ6OLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

i'm pretty sure 0.5 doesn't have shader support so yeah

maybe, i will wait for 0.5.1 port 😄
On Tue, Jan 18, 2022, 11:23 AM frantastic24 @.***>
wrote:

i'm pretty sure 0.5 doesn't have shader support so yeah
—
Reply to this email directly, view it on GitHub
https://github.com/ShadowMario/FNF-PsychEngine/issues/3658#issuecomment-1015038267,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7OPGGVBGFAQMW4ZXR6NXTUWTMKLANCNFSM5MDJ6OLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

You're doing everything through the mods folder right? If so you can just get the latest version and just copy the folder
I recommend updating to 0.5.1 anyways since some Lua variables (namely curBeat I think) were broken in 0.5

Ok, I'll do that. thanks, im using android ports soo i gonna need to wait
till, someone or the porter update it😄
On Tue, Jan 18, 2022, 11:35 AM frantastic24 @.***>
wrote:

You're doing everything through the mods folder right? If so you can just
get the latest version and just copy the folder
I recommend updating to 0.5.1 anyways since some Lua variables (namely
curBeat I think) were broken in 0.5
—
Reply to this email directly, view it on GitHub
https://github.com/ShadowMario/FNF-PsychEngine/issues/3658#issuecomment-1015042658,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7OPGGA5FN27LUWYTBF2RDUWTNZHANCNFSM5MDJ6OLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

I see, probably gonna take a good while then unfortunately

Ok, no problem. but can i have an 1 question again 😅 it is possible to
change the 3, 2, 1, GO  to ready, set, go using the onStartCountdown i saw
it on the source of sonic with crochet i think, but how can i stop the song
while playing the ready, set, go
On Tue, Jan 18, 2022, 11:43 AM frantastic24 @.***>
wrote:

I see, probably gonna take a good while then unfortunately
—
Reply to this email directly, view it on GitHub
https://github.com/ShadowMario/FNF-PsychEngine/issues/3658#issuecomment-1015044954,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AW7OPGCNQFWA7YDE535WYIDUWTOVTANCNFSM5MDJ6OLA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

i did mine like this

You should use function onStartCountdown() and if counter == (number) for that, I think
I'm doing my own port of this song so I can let you know if this works in a bit

like this? or i will put the counter on up
(sorry i didn't notice your comment i sleep)
function onStartCoundown()
if counter == 0 then
setProperty('ready1.visible', true);
playSound('intro2')
end

i will try it

Well I did kinda manage to replicate it by skipping the countdown and just doing it manually but in doing that it messed up the spawning strums and the opponent's left strum behaves weirdly, so I just decided not to include it

maybe the best way is just like
on sounds
make no sound intro3
'ready' the intro1 (will be intro2)
'set' intro2 (intro1)
'go' introGo
then
ready, set, go assets

is the
var is local? and
spr.alpha like when tdoll-alt hits note will hide the hud

Unfortunately you can't use different countdown assets with a folder, although you can if you include the song in a different pack but that's just inconvenient
I can send you the code I made for the lights out segment if you want
Here's the finished product if you're interested

wait, how do you keep the hud fade when long notes, i alrdy did the off lights

if curStep > 588 and curStep < 860 and isSustainNote == false then

the if curStep on function onStepHit
function opponentNoteHit
the isSustainNote == false then
doTweenAlpha('hudAlpha', 'camHUD', 1, 0.1, 'linear');

this doesn't go in curStep, the entire line (yes, the ANDs are part of it) goes under onOpponentHit

ohh sorry, i thought curStep only will be on onStepHit thnx
(i will credits you 😄)

like this or doNoteAlpha is what i need i cant send videos here for soem reason

first you need to set the alpha to 0.7, then do an alpha tween that lowers it to 0
setProperty('camHUD.alpha', 0.7);
doTweenAlpha('hudAlpha', 'camHUD', 0, 0.4, 'linear')

that's pretty much what i did except i individually got rid of each UI object so i can just brighten the strums and nothing else, but this works if you prefer the simpler solution

id, direction, noteType, isSustainNote  iforgot to put this, but it fade fast then back to normal again

it's supposed to fade quickly, that's how it works in the original song
what do you mean by "back to normal" though, because it's working fine for me

how can i send vids here, wait i will show ti

you could upload it to google drive or something if it's too big

https://user-images.githubusercontent.com/96397208/150059009-9b3089bc-39b1-46ac-82a9-32de5d3775cf.mp4
this

like this or doNoteAlpha is what i need i cant send videos here for soem reason

did you delete the tween on this screenshot

yes and replaced it like this
setProperty('camHUD.alpha', 0.7);
doTweenAlpha('hudAlpha', 'camHUD', 0, 0.4, 'linear')

no you did it the other way around

https://user-images.githubusercontent.com/96397208/150060406-a1fc1666-ab38-4f39-ac57-f79064edb1cc.mp4
still keeps coming back to normal it doesn't want to stay faded

send a screenshot of the code, i already tested it twice and it works fine

hmm do you mind sending me the entire script file? the code is correct so there's no reason for the alpha to return to 1, on this piece of code anyways

okay but hide it fast

k

i don't see it

what you cant see

where's the file, i don't have much time to go through it right now

how cna i send file

change the extension to .txt and send it as you would with any other file

https://www.mediafire.com/file/7ux24xcs7t7lnf3/lol.lua/file
this i am not using windows i cant put txt

any file explorer can do that but it's fine

did you already downloaded it i will hide it now

it's still working fine for me so i guess it could either be a source code problem or one of the other scripts you're running

wait, the addLuaScript('hudshe') i deleted it and its now working, i forgot that i used addLuaScript with hidehud  on it

the problem is, i will vid it when it hits 860 step it doesn't back the hud

Again sounds like an issue with one of the scripts you're loading, you didn't send me those and I don't have access to the main one right now so I can't help much

can i do both like if curStep 860 already have one
if curStep == 860
setProperty('camHUD.alpha', 1);

I did it i remove some of it

but is there anyway to make thing  go back to normal the playerstrum at curStep 860?

just do the same thing but with their original X value
i figured out a way to do a custom countdown without having to include the song in a separate pack, just make the intro sounds blank and hide countdown assets when it ticks, then do the custom stuff

function onCountdownTick(counter)
	if counter == 0 then
			addLuaSprite('ready', true);
			playSound('ready');
			doTweenX('readyx', 'ready.scale', 0.9, crochet/500);
			doTweenY('readyy', 'ready.scale', 0.9, crochet/500);
	end
	if counter == 1 then
			addLuaSprite('set', true);
			removeLuaSprite('ready');
			playSound('set');
			doTweenX('setx', 'set.scale', 0.9, crochet/500);
			doTweenY('sety', 'set.scale', 0.9, crochet/500);
	end
	if counter == 2 then
			addLuaSprite('go', true);
			removeLuaSprite('set');
			playSound('go');
			doTweenX('gox', 'go.scale', 1.1, crochet/500);
			doTweenY('goy', 'go.scale', 1.1, crochet/500);
	end
	if counter == 3 then
			removeLuaSprite('go');
	end
		setProperty('countdownReady.visible', false)
		setProperty('countdownSet.visible', false)
		setProperty('countdownGo.visible', false)
end

intro sounds in modpack are blank, this code can also be edited to play this custom countdown if this song is playing and you can do something similar but only play the vanilla sounds instead (so you restore the original countdown)
https://user-images.githubusercontent.com/95725102/150222618-b8b2168b-402a-4e57-856c-c7b6bc6695e8.mp4

can it be delay like 3,,2,,1,,GO i think its also wait i will

it can, also i tried to add the TdollStart not that visible because of the blacks

i did is like this

idk if the startCountdown work i just maked it (start.visible', true)

https://user-images.githubusercontent.com/96397208/150236283-8e0fea4c-d815-4a9d-9887-e4add8afc549.mp4
like this, my phone is lagging when to many assets

https://user-images.githubusercontent.com/96397208/150237377-96fbc912-ac93-49a1-914d-08d2540f49ce.mp4
and the thing where, tdoll will back to his original position

i did like this this is from the source code

and lua


TDI-36471: The error messages are not clear

Please do not forget to provide some description for you pull request.
Other than my comment on StringUtils, this looks fine to me.

please Merge it when you are ready.


Spelling

Generated by https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn

Thank you for your report. While that is interesting, I am wondering if we should merge this one-off and/or integrate it in our CI jobs.

You might look at:
https://github.com/checkstyle/checkstyle/blob/master/.ci/test-spelling-unknown-words.sh
I'm probably going to work on a version that uses a bucket for storage for our word-list I'm the near future.
Someday I might manage to make this into a GitHub action or similar, but I can't offer a timetable.

Do I need to do anything else here?

Looks agreeable enough to me, thanks :) :+1:


Trying to bring up the education data web project

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az webapp up
Errors:
az webapp up: error: argument --name/-n: expected one argument

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az webapp up --resource-group {} --sku {} --name

Expected Behavior
Environment Summary
Linux-4.15.0-1061-azure-x86_64-with-debian-stretch-sid
Python 3.6.5
Shell: bash

azure-cli 2.0.75

Additional Context

the command needs to run from the run from the context of local dir where the code is &  needs name for the webapp.


Compile Error on Dart 2.3.3

I'm getting the following compiler message when trying to use dartz Options in a flutter project. It' on Dart 2.3.3.
    Compiler message:
    file:///Users/catherinethompson/.pub-cache/hosted/pub.dartlang.org/dartz-0.8.4/lib/src/endo.dart:5:7: Error: Found unsupported uses of 'A' in supertype 'Monoid'.
    class EndoMonoid<A> extends Monoid<Endo<A>> {
          ^
    file:///Users/catherinethompson/.pub-cache/hosted/pub.dartlang.org/dartz-0.8.4/lib/src/endo.dart:11:33: Error: A value of type 'EndoMonoid<dynamic>' can't be assigned to a variable of type 'Monoid<dynamic Function(dynamic)>'.
     - 'EndoMonoid' is from 'package:dartz/dartz.dart' ('file:///Users/catherinethompson/.pub-cache/hosted/pub.dartlang.org/dartz-0.8.4/lib/dartz.dart').
     - 'Monoid' is from 'package:dartz/dartz.dart' ('file:///Users/catherinethompson/.pub-cache/hosted/pub.dartlang.org/dartz-0.8.4/lib/dartz.dart').
    Try changing the type of the left hand side, or casting the right hand side to 'Monoid<dynamic Function(dynamic)>'.
    final Monoid<Endo> EndoMi = new EndoMonoid();
                                    ^
    file:///Users/catherinethompson/.pub-cache/hosted/pub.dartlang.org/dartz-0.8.4/lib/src/endo.dart:12:36: Error: A value of type 'EndoMonoid<dynamic>' can't be assigned to a variable of type 'Monoid<A Function(A)>'.
     - 'EndoMonoid' is from 'package:dartz/dartz.dart' ('file:///Users/catherinethompson/.pub-cache/hosted/pub.dartlang.org/dartz-0.8.4/lib/dartz.dart').
     - 'Monoid' is from 'package:dartz/dartz.dart' ('file:///Users/catherinethompson/.pub-cache/hosted/pub.dartlang.org/dartz-0.8.4/lib/dartz.dart').
    Try changing the type of the left hand side, or casting the right hand side to 'Monoid<A Function(A)>'.
    Monoid<Endo<A>> endoMi<A>() => new EndoMonoid();
                                       ^

Hi and thanks for reporting!
This looks like identical of https://github.com/spebbe/dartz/issues/12, which was closed a bit prematurely. A solution exists, but hasn't been released yet. I'll make a fix release soon and will keep this issue open until then.

Released in 0.8.5 from master and rebased onto 0_9_0_wip_2


Search function displays unformatted text

The search function currently (presumably) takes text directly from the md files, which means it is unformatted. Here is a photo.

Pictured: The text is raw and unformatted.
Is it possible to take this text and display it in some way that avoids markdown formatting? I figure this might be more work than its worth, it would just be great to look into if a fix is feasible.

@KeenanLukeOM Took a stab at it today but haven't managed to solve it....

Awesome! If it isn't a possibility then we can worry about it at a later date (the search still functions using unformatted text without issue, just looks a bit off for UX)


Faux scrolling under scrollback

How does faux scrolling fit in with native scrollback? It's disabled on the PR right now.

Whenever a native scrollback buffer is available, faux scrollback does not exist.
Faux scrollback also is a bit of a wrong name for this (totally my fault, see #1095). This should rather be "faux_scrolling". It only exists in the alternative screen buffer when the mouse is not captured, I don't think scrollback should interact with this at all, it should all be input related.

resolved by #1158


Having only Repeatable Migrations crashes Flyway

What version of Flyway are you using?
4.0.3
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin, SBT plugin, ANT tasks)
Command-line
What database are you using (type & version)?
Oracle, SQL Server
What operating system are you using?
Red Hat Linux
What did you do?
We're using the new Repeatable Migration feature. However, in one of our JARs there was no migration script, just a Repeatable Migration script. Flyway apparently doesn't like that  ;-)
ERROR: java.lang.ArrayIndexOutOfBoundsException: -1
What did you expect to see?
I would have liked the Repeatable Migration to be executed.
What did you see instead?
The error above

Could you please post the full stacktrace?

Sure:
Successfully validated 25 migrations (execution time 00:00.076s) SQLServer does not support setting the schema for the current session. Default schema NOT changed to dbo DEBUG: Schema [dbo] already exists. Skipping schema creation. DEBUG: Locking table [dbo].[schema_version]... DEBUG: Lock acquired for table [dbo].[schema_version] Current version of schema [dbo]: <IP_ADDRESS> WARNING: outOfOrder mode is active. Migration of schema [dbo] may not be reproducible. ERROR: Unexpected error java.lang.ArrayIndexOutOfBoundsException: -1         at org.flywaydb.core.internal.command.DbMigrate$2.doInTransaction(DbMigrate.java:201)         at org.flywaydb.core.internal.command.DbMigrate$2.doInTransaction(DbMigrate.java:173)         at org.flywaydb.core.internal.util.jdbc.TransactionTemplate.execute(TransactionTemplate.java:72)         at org.flywaydb.core.internal.command.DbMigrate.migrate(DbMigrate.java:173)         at org.flywaydb.core.Flyway$1.execute(Flyway.java:959)         at org.flywaydb.core.Flyway$1.execute(Flyway.java:917)         at org.flywaydb.core.Flyway.execute(Flyway.java:1373)         at org.flywaydb.core.Flyway.migrate(Flyway.java:917)         at org.flywaydb.commandline.Main.executeOperation(Main.java:139)         at org.flywaydb.commandline.Main.main(Main.java:102)

@cristalp do you apply migrations from different applications?
like you have one application that apply migrations from location1, and another from location2?

We have different applications that define the database server and schema with different paths, like db/migration/database/schema/V1.0.0__my_script.sql. During the build, all scripts found for an application are packed into a ZIP file. Then we have a shell script that takes the ZIP file, unpacks it and applies all migrations that it finds. Our Flyway configuration has a correspoding directory structure with /stage/database/schema/conf/flyway.conf
I hope I understood correctly what you were asking  :-)

Just we have the same issue.
We are using one database for different parts of application and each part has its own migrations set and they apply independently.
And i don't sure that flyway allow this :smile:

Well, most of our application just use one database and leave the others alone. But there's one database which is used by most applications, and for that database we set outOfOrder to true, and we will probably also set validateOnMigrate=false, since some applied migrations from other applications may be missing for the application. It's ugly, I admit, but it's the only way it works.

I believe I just ran into this error as well, even on 4.1.1 which has your commit https://github.com/flyway/flyway/commit/beae6ffc3768dae56f6deb7534194f10f1e1d140
However, the commit seems like it just adds some tests. Am I missing something?

@blai-cartera I just ran into this as well. Looks like it's still not fixed on 4.1.2.

@18thletter Please open a new issue and provide exact steps on how to reproduce.

@blai-cartera We have a test that covers this exact scenario and it passes: https://github.com/flyway/flyway/blob/master/flyway-core/src/test/java/org/flywaydb/core/FlywayMediumTest.java#L637

I just ran into the same error with version 4.1.2. Having configured a location on the filesystem that only contains repeatable migrations led to the same ArrayIndexOutOfBoundsException as above. I then added a versioned dummy script and it worked.

@jbrusis Please open a new issue and provide exact steps on how to reproduce.


Switch online key

The online key provisioning was refactored and as a result the key has changed.

[ ] Update the online key in metadata using tuf-on-ci-delegate, new keyid is projects/projectsigstore-staging/locations/global/keyRings/tuf-keyring/cryptoKeys/tuf-key/cryptoKeyVersions/1
[ ] Could remove the import user  from signers at the same time
[ ] Update the service account details in this repository repository variables

this should fix #22

I've changed the key, will now remove the import user from root signers.


webhook-deploy.sh: error upon unknown option

It's too easy to miss double dash in the --mode orchestration option leading to wrong mode of the webhook.
Exit on error in case a user types in something line -mode orchestration.

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   81.87%   81.87%
=======================================
  Files           6        6
  Lines         778      778
=======================================
  Hits          637      637
  Misses        129      129
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30916ff...eaff6f7. Read the comment docs.


Execution failed for task ':app:preDebugBuild'.

Summary

Version
24

Affected OS
android

when i instaled react-native-devise-info i did:
npm install react-native-devise-info react-native link react-native-devise-info
i tryed using
implementation ("com.google.android.gms:play-services-basement:15.0.1") {force = true;}
then ./gradlew :app:dependencies ask me for the following
implementation ("com.google.android.gms:play-services-tasks:15.0.1") {force = true;}
and now :app:dependencies worked but react-native run-android is still not working and i have no idea why
Current behavior
when i try to compile with the current vertion of react-native-device-info i get this error:
    The library com.google.android.gms:play-services-basement is being requested by various other       libraries at [[15.0.1,15.0.1]], but resolves to 16.0.1.
Expected behavior
bing abeld to start react-native run-android

Hi @julienJean99
Just add googlePlayServicesVersion = "15.0.1" in the ext part of you build.gradle.
👍

Hi
I have googlePlayServicesVersion but for me the error message is as following:
Execution failed for task ':app:transformDexArchiveWithDexMergerForDebug'.
> com.android.build.api.transform.TransformException: java.lang.RuntimeException: java.lang.RuntimeException: com.android.builder.dexing.DexArchiveMergerException: Error while merging dex archives:
  Learn how to resolve the issue at https://developer.android.com/studio/build/dependencies#duplicate_classes.
  Program type already present: com.reactnativecommunity.netinfo.BroadcastReceiverConnectivityReceiver$ConnectivityBroadcastReceiver

Anyone face the problem before?

Oh it is running now after I remove the whole build folder and run again. Thanks!