Tests take very long to start

Hello!
I'm struggling with the performance of the test with the use of cypress-cucumber-preprocessor. It hangs on this screen in the browser:

In the node terminal I can see such potential causes:
GET /__cypress/runner/cypress_runner.css 200 5.750 ms - -
GET /__cypress/runner/cypress_runner.js 200 4.877 ms - -
GET /__cypress/runner/fonts/fontawesome-webfont.woff2 200 1.103 ms - 77160
GET /__cypress/iframes/integration/FeatureName.feature 200 2.750 ms - 753
GET /__cypress/tests?p=cypress%5Csupport%5Cindex.js-310 200 37241.251 ms - -
GET /__cypress/tests?p=cypress%5Cintegration%5CFeatureName.feature-891 200 40345.918 ms - -

As you can see, there are some files that take a very long time to load properly.
This line seems to be problematic:
https://github.com/TheBrainFamily/cypress-cucumber-preprocessor/blob/master/lib/index.js#L46
Without this await here everything works quite fast. Do you have a clue what might be the issue here? I'm using Windows 10 with Node v12.13.1.

Hello. Thanks for the submitting issue and sorry for the problems! Looks like I have to revert that commit, will work on this and some of the stale issues next week. For now it should be fine for you to go a few versions back. 1.18.0 should do the trick

@lgandecki Thank you for a quick response. I had to roll back to 1.17.0 for this line to disappear.
Thanks for all the hard work!

@lgandecki
There are quite a few issues in the ps-node library indicating that there are performance issues on Windows
https://github.com/neekey/ps/issues

I'm using 1.16.2 which appears to be stable than 1.17.0 but I too notice a noticeable performance delay when starting first feature file after cypress started (+40 seconds) and upon next run (+10 seconds).. Following a subset of log from (set DEBUG=cypress*&&npm run ..) command where I notice something suspicious... Any clues? @lgandecki @mwanago
Note: If i run a standard *.spec.js test script, it starts almost instantaneously.
cypress:server:events sending ipc data { type: 'get:project:status', data: { id: 0.35663456046380393, data: { path: 'C:\Users\\Repo\<project_base_folder>\ui', state: 'VALID'
} } } +16ms
cypress:browserify finished bundling: C:\Users<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cypress\integration\Features\re
lease.feature +15s
cypress:server:plugins promise resolved for id 'inv76' with value C:\Users<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cyp
ress\integration\Features\release.feature +15s
cypress:server:controllers:spec sending spec { filePath: 'C:\Users\\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\
cypress\integration\Features\release.feature' } +15s
GET /__cypress/tests?p=cypress%5Cintegration%5CFeatures%5Crelease.feature-811 200 15046.796 ms - -
cypress:server:browsers:electron console message: { column: 32, level: 'log', line: 178269, source: 'console-api', text: 'console.clear', url: 'http://localhost:8080/__cypress/r
unner/cypress_runner.js' } +16s
cypress:server:socket automation:request get:cookies { domain: 'localhost' } +16s
cypress:server:cookies getting:cookies { domain: 'localhost' } +46s
cypress:server:browsers:electron debugger: sending Network.getAllCookies with params undefined +64ms

the differences between 1.16.2 and 1.17.0 are as you can check here: https://github.com/TheBrainFamily/cypress-cucumber-preprocessor/compare/v1.16.2..v1.17.0 , so that shouldn't matter.
Looks like the test gets stuck on cypress:server:cookies and socket commands (one minute togeter), are you sure your .spec.js also run these steps?

Here is the log extract when I run a spec.js file (fresh start with cypress:open command)... The delay about 10seconds on a fresh start and almost instant when a re-run of the same spec.js file. Let me know if any additional information needed to debug. Thanks in advance.
cypress:server:controllers:spec sending spec { filePath: 'C:\Users\\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles
\cypress\integration\02.release.spec.js' } +4s
GET /__cypress/tests?p=cypress%5Cintegration%5C02.release.spec.js-330 200 4114.461 ms - -
cypress:server:events got request for event: get:project:status, { path: 'C:\Users\\Repo\<project_base_folder>\ui' } +7s
cypress:server:project get project status for client id undefined at path C:\Users<user>\Repo<project_base_folder>\ui +10s
cypress:server:project no project id +1ms
cypress:server:events sending ipc data { type: 'get:project:status', data: { id: 0.48950603809433946, data: { path: 'C:\Users\\Repo\<project_base_folder>\ui', state: 'VALID
' } } } +18ms
cypress:browserify finished bundling: C:\Users<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cypress\support\index.js +6s
cypress:server:plugins promise resolved for id 'inv3' with value C:\Users<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cyp
ress\support\index.js +6s
cypress:server:controllers:spec sending spec { filePath: 'C:\Users\\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles
\cypress\support\index.js' } +6s
GET /__cypress/tests?p=cypress%5Csupport%5Cindex.js-388 200 10253.226 ms - -
cypress:server:socket automation:request get:cookies { domain: 'localhost' } +11s
cypress:server:cookies getting:cookies { domain: 'localhost' } +0ms
cypress:server:browsers:electron debugger: sending Network.getAllCookies with params undefined +11s

Not sure if this adds any value to debug, but I see below log repeated every 10s even when there are no tests running actively. Also it seems the id in ipc data element is not fetched correctly (id undefined)..
cypress:server:events sending ipc data { type: 'get:project:status', data: { id: 0.5012873103360875, data: { path: 'C:\Users\\Repo\\ui', state: 'VALID' } } } +1ms
cypress:server:events got request for event: get:project:status, { path: 'C:\Users\\Repo\\ui' } +10s
cypress:server:project get project status for client id undefined at path C:\Users<user>\Repo<project>\ui +10s
cypress:server:project no project id +0ms

Hi! I'm experiencing the same as the author does. Had written a simple test to open a google page and take its screenshot and it for me it takes:
around 16 seconds to complete on 1.17.0
around 80 seconds to complete on 1.18.0
4 seconds if I'm not using cypress-cucumber-preprocessor and doing this in a regular cypress way
I have a shared step def placed in a file under a common folder
and
{   "testFiles": "**/*.{feature,features}",   "ignoreTestFiles": "*.js" }
in my cypress.json
Is there any fix coming in a observable future?
Please ping me if you need any additional information from my side.
Thanks! =)

Guys, please try with version 2.0.0  - I hope it's faster. @greenwest if you could post your time with 2.0.0 that would be great as well.

@lgandecki Nice work, thank you! It's totally better with 2.0.0. Now I'm getting around 4-5 seconds when I'm running it using command line. On the first attempt to run it through the cypress GUI it takes around 10 sec but after I hit re-run it drops to like 2 or 3 seconds.

Hi @lgandecki thanks for the great work!!. I was excited to run on the latest version but unfortunately the test is breaking for version 2.0.0. Not sure if some configuration changes would fix it but except the version upgrade (and adding two elements to the configuration in package.json), I did not do any changes but it fails to run.
Please review and suggest. Also tried changing feature (and folder) name from 01.Navigation to 01Navigation without any luck.
Folder structure:
cypress
|-- integration
......|-- common
.............|-- common-steps.js
......|-- 01.Navigation
.............|-- visit.steps.js
......|-- 01.Navigation.feature
plugins/index.js
module.exports = (on, config) => {

  on('file:preprocessor', cucumber());

  on('task', (...));

  on('after:screenshot', (...));

}

<EMAIL_ADDRESS>(SUCCESS)
package.json
{
	...
	"cypress": "3.7.0",
	"cypress-cucumber-preprocessor": "1.16.2",
	...
	"cypress-cucumber-preprocessor": {
		"nonGlobalStepDefinitions": true,
		"cucumberJson": {
			"generate": true,
			"outputFolder": "cypress/cucumber-json",
			"filePrefix": "",
			"fileSuffix": ".cucumber"
		}
	}
}

  cypress:cucumber cucumber.json {"generate":true,"outputFolder":"cypress/cucumber-json","filePrefix":"","fileSuffix":".cucumber"} +0ms
  cypress:server:plugins:child execute plugin event: file:preprocessor ({ eventId: 2, invocationId: 'inv2' }) +505ms
  cypress:browserify received user options: { browserifyOptions: { extensions: [ '.js', '.jsx', '.coffee' ], transform: [ [Function: transform], [Array], [Array] ], plugin: [] }, watchifyOptions: { ignoreWatch: [ '**/.git/**', '**/.nyc_output/**', '**/.sass-cache/**', '**/bower_components/**', '**/coverage/**', '**/node_modules/**' ] } } +449ms
  cypress:browserify get: C:\Users\<user>\Repo\<project>\ui\cypress\support\index.js +1ms
  cypress:browserify input: C:\Users\<user>\Repo\<project>\ui\cypress\support\index.js +0ms
  cypress:browserify output: C:\Users\<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cypress\support\index.js +0ms
  cypress:browserify browserifyOptions: { extensions: [ '.js', '.jsx', '.coffee' ], transform: [ [Function: transform], [ 'C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\coffeeify\\index.js', [Object] ], [ 'C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\babelify\\index.js', [Object] ] ], plugin: [], cache: {}, packageCache: {}, debug: true, entries: [ 'C:\\Users\\<user>\\Repo\\<project>\\ui\\cypress\\support\\index.js' ] } +0ms
  cypress:browserify making bundle C:\Users\<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cypress\support\index.js +7ms
  cypress:browserify **finished bundling**: C:\Users\<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cypress\support\index.js +33s
  cypress:server:plugins promise resolved for id 'inv2' with value C:\Users\<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cypress\support\index.js +0ms

<EMAIL_ADDRESS>(FAILURE)

{
	...
	"cypress": "3.7.0",
	"cypress-cucumber-preprocessor": "^2.0.0",
	...
	"cypress-cucumber-preprocessor": {
		"nonGlobalStepDefinitions": true,
		"stepDefinitions": "cypress/integration",     <-- added newly
		"commonPath": "cypress/integration/common", <-- added newly
		"cucumberJson": {
			"generate": true,
			"outputFolder": "cypress/cucumber-json",
			"filePrefix": "",
			"fileSuffix": ".cucumber"
		}
	}
}

    cypress:cucumber cucumber.json {"generate":true,"outputFolder":"cypress/cucumber-json","filePrefix":"","fileSuffix":".cucumber"} +0ms
  cypress:browserify **errored bundling**: C:\Users\<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cypress\integration\01.Navigation.feature { Error: Parsing file C:\Users\<user>\Repo\<project>\ui\cypress\integration\01.Navigation.feature: Bad character escape sequence (14:50)
    at Deps.parseDeps (C:\Users\<user>\Repo\<project>\ui\node_modules\module-deps\index.js:510:15)
    at getDeps (C:\Users\<user>\Repo\<project>\ui\node_modules\module-deps\index.js:438:44)
    at C:\Users\<user>\Repo\<project>\ui\node_modules\module-deps\index.js:421:38
    at ConcatStream.<anonymous> (C:\Users\<user>\Repo\<project>\ui\node_modules\concat-stream\index.js:37:43)
    at ConcatStream.emit (events.js:199:15)
    at finishMaybe (C:\Users\<user>\Repo\<project>\ui\node_modules\readable-stream\lib\_stream_writable.js:630:14)
    at endWritable (C:\Users\<user>\Repo\<project>\ui\node_modules\readable-stream\lib\_stream_writable.js:638:3)
    at ConcatStream.Writable.end (C:\Users\<user>\Repo\<project>\ui\node_modules\readable-stream\lib\_stream_writable.js:594:41)
    at DuplexWrapper.onend (C:\Users\<user>\Repo\<project>\ui\node_modules\readable-stream\lib\_stream_readable.js:577:10)
    at Object.onceWrapper (events.js:282:20)
    at DuplexWrapper.emit (events.js:199:15)
    at endReadableNT (C:\Users\<user>\Repo\<project>\ui\node_modules\readable-stream\lib\_stream_readable.js:1010:12)
    at processTicksAndRejections (internal/process/task_queues.js:81:17)

  stream:
   Labeled {
     _readableState:
      ReadableState {
        objectMode: true,
        highWaterMark: 16,
        buffer: BufferList { length: 0 },
        length: 0,
        pipes: [Labeled],
        pipesCount: 1,
        flowing: true,
        ended: false,
        endEmitted: false,
        reading: true,
        sync: false,
        needReadable: true,
        emittedReadable: false,
        readableListening: false,
        resumeScheduled: false,
        destroyed: false,
        defaultEncoding: 'utf8',
        awaitDrain: 0,
        readingMore: false,
        decoder: null,
        encoding: null },
     readable: true,
     _events:
      [Object: null prototype] {
        end: [Array],
        error: [Function],
        data: [Function: ondata],
        _mutate: [Function] },
     _eventsCount: 4,
     _maxListeners: undefined,
     _writableState:
      WritableState {
        objectMode: true,
        highWaterMark: 16,
        finalCalled: false,
        needDrain: false,
        ending: true,
        ended: true,
        finished: true,
        destroyed: false,
        decodeStrings: true,
        defaultEncoding: 'utf8',
        length: 0,
        writing: false,
        corked: 0,
        sync: false,
        bufferProcessing: false,
        onwrite: [Function],
        writecb: null,
        writelen: 0,
        bufferedRequest: null,
        lastBufferedRequest: null,
        pendingcb: 0,
        prefinished: true,
        errorEmitted: false,
        bufferedRequestCount: 0,
        corkedRequestsFree: [CorkedRequest] },
     writable: false,
     allowHalfOpen: true,
     _options: { objectMode: true },
     _wrapOptions: { objectMode: true },
     _streams: [ [Deps] ],
     length: 1,
     label: 'deps' },
  filePath:
   'C:\\Users\\<user>\\Repo\\<project>\\ui\\cypress\\integration\\01.Navigation.feature',
  originalStack:
   'Error: Parsing file C:\\Users\\<user>\\Repo\\<project>\\ui\\cypress\\integration\\01.Navigation.feature: Bad character escape sequence (14:50)\n    at Deps.parseDeps (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\module-deps\\index.js:510:15)\n    at getDeps (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\module-deps\\index.js:438:44)\n
  at C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\module-deps\\index.js:421:38\n    at ConcatStream.<anonymous> (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\concat-stream\\index.js:37:43)\n    at ConcatStream.emit (events.js:199:15)\n    at finishMaybe (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\readable-stream\\lib\\_stream_writable.js:630:14)\n    at endWritable (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\readable-stream\\lib\\_stream_writable.js:638:3)\n    at ConcatStream.Writable.end (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\readable-stream\\lib\\_stream_writable.js:594:41)\n    at DuplexWrapper.onend (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\readable-stream\\lib\\_stream_readable.js:577:10)\n    at Object.onceWrapper (events.js:282:20)\n    at DuplexWrapper.emit (events.js:199:15)\n    at endReadableNT (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\readable-stream\\lib\\_stream_readable.js:1010:12)\n    at processTicksAndRejections (internal/process/task_queues.js:81:17)\n' } +508ms
  cypress:server:plugins promise rejected for id inv1 ':' Error: Parsing file C:\Users\<user>\Repo\<project>\ui\cypress\integration\01.Navigation.feature: Bad character escape sequence (14:50)
    at Deps.parseDeps (C:\Users\<user>\Repo\<project>\ui\node_modules\module-deps\index.js:510:15)
    at getDeps (C:\Users\<user>\Repo\<project>\ui\node_modules\module-deps\index.js:438:44)
    at C:\Users\<user>\Repo\<project>\ui\node_modules\module-deps\index.js:421:38
    at ConcatStream.<anonymous> (C:\Users\<user>\Repo\<project>\ui\node_modules\concat-stream\index.js:37:43)
    at ConcatStream.emit (events.js:199:15)
    at finishMaybe (C:\Users\<user>\Repo\<project>\ui\node_modules\readable-stream\lib\_stream_writable.js:630:14)
    at endWritable (C:\Users\<user>\Repo\<project>\ui\node_modules\readable-stream\lib\_stream_writable.js:638:3)
    at ConcatStream.Writable.end (C:\Users\<user>\Repo\<project>\ui\node_modules\readable-stream\lib\_stream_writable.js:594:41)
    at DuplexWrapper.onend (C:\Users\<user>\Repo\<project>\ui\node_modules\readable-stream\lib\_stream_readable.js:577:10)
    at Object.onceWrapper (events.js:282:20)
    at DuplexWrapper.emit (events.js:199:15)
    at endReadableNT (C:\Users\<user>\Repo\<project>\ui\node_modules\readable-stream\lib\_stream_readable.js:1010:12)
    at processTicksAndRejections (internal/process/task_queues.js:81:17)
 +0ms

Oops...we found an error preparing this test file:

  cypress\integration\01.Navigation.feature

The error was:

**Error: Parsing file C:\Users\<user>\Repo\<project>\ui\cypress\integration\01.Navigation.feature: Bad character escape sequence (14:50)**

This occurred while Cypress was compiling and bundling your test code. This is usually caused by:

- A missing file or dependency
- A syntax error in the file or one of its dependencies

Fix the error in your code and re-run your tests.

@pravynandas  Can you please try 2.0.1?

@greenwest this looks like you might be missing baseUrl in the cypress configuration, can you verify?

@lgandecki Yes, you're totally right. I forgot to add it. Thanks!

Hi @lgandecki with v2.0.1 I think the previously reported error (Bad escape character sequence) is gone. But getting a different error which also seemingly appearing from 1.19.0. See the Issue  on our example.
cypress:cucumber cucumber.json {"generate":true,"outputFolder":"cypress/cucumber-json","filePrefix":"","fileSuffix":".cucumber"} +0ms
  cypress:server:plugins:child execute plugin event: file:preprocessor ({ eventId: 2, invocationId: 'inv2' }) +1s
  cypress:browserify received user options: { browserifyOptions: { extensions: [ '.js', '.jsx', '.coffee' ], transform: [ [Function: transform], [Array], [Array] ], plugin: [] }, watchifyOptions: { ignoreWatch: [ '**/.git/**', '**/.nyc_output/**', '**/.sass-cache/**', '**/bower_components/**', '**/coverage/**', '**/node_modules/**' ] } } +1s
  cypress:browserify get: C:\Users\<user>\Repo\<project>\ui\cypress\support\index.js +0ms
  cypress:browserify input: C:\Users\<user>\Repo\<project>\ui\cypress\support\index.js +0ms
  cypress:browserify output: C:\Users\<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cypress\support\index.js +0ms  cypress:browserify browserifyOptions: { extensions: [ '.js', '.jsx', '.coffee' ], transform: [ [Function: transform], [ 'C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\coffeeify\\index.js', [Object] ], [ 'C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\babelify\\index.js', [Object] ] ], plugin: [], cache:
{}, packageCache: {}, debug: true, entries: [ 'C:\\Users\\<user>\\Repo\\<project>\\ui\\cypress\\support\\index.js' ] } +0ms
  cypress:browserify making bundle C:\Users\<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cypress\support\index.js +6ms
  cypress:browserify errored bundling: C:\Users\<user>\AppData\Roaming\Cypress\cy\production\projects\ui-417ea8e8657c3973acf0ad6fe5826428\bundles\cypress\integration\01Navigation.feature { Error: Cannot find module 'cypress/integration/common/common.steps.js' from 'C:\Users\<user>\Repo\<project>\ui\cypress\integration'
    at C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:46:17
    at process (C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:173:43)
    at ondir (C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:188:17)
    at load (C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:69:43)
    at onex (C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:92:31)
    at C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:22:47
    at callback (C:\Users\<user>\AppData\Local\Cypress\Cache\3.7.0\Cypress\resources\app\packages\server\node_modules\graceful-fs\polyfills.js:295:20)
    at FSReqCallback.oncomplete (fs.js:163:21)

  stream:
   Labeled {
     _readableState:
      ReadableState {
        objectMode: true,
        highWaterMark: 16,
        buffer: BufferList { length: 0 },
        length: 0,
        pipes: [Labeled],
        pipesCount: 1,
        flowing: true,
        ended: false,
        endEmitted: false,
        reading: true,
        sync: false,
        needReadable: true,
        emittedReadable: false,
        readableListening: false,
        resumeScheduled: false,
        destroyed: false,
        defaultEncoding: 'utf8',
        awaitDrain: 0,
        readingMore: false,
        decoder: null,
        encoding: null },
     readable: true,
     _events:
      [Object: null prototype] {
        end: [Array],
        error: [Function],
        data: [Function: ondata],
        _mutate: [Function] },
     _eventsCount: 4,
     _maxListeners: undefined,
     _writableState:
      WritableState {
        objectMode: true,
        highWaterMark: 16,
        finalCalled: false,
        needDrain: false,
        ending: true,
        ended: true,
        finished: true,
        destroyed: false,
        decodeStrings: true,
        defaultEncoding: 'utf8',
        length: 0,
        writing: false,
        corked: 0,
        sync: false,
        bufferProcessing: false,
        onwrite: [Function],
        writecb: null,
        writelen: 0,
        bufferedRequest: null,
        lastBufferedRequest: null,
        pendingcb: 0,
        prefinished: true,
        errorEmitted: false,
        bufferedRequestCount: 0,
        corkedRequestsFree: [CorkedRequest] },
     writable: false,
     allowHalfOpen: true,
     _options: { objectMode: true },
     _wrapOptions: { objectMode: true },
     _streams: [ [Deps] ],
     length: 1,
     label: 'deps' },
  filePath:
   'C:\\Users\\<user>\\Repo\\<project>\\ui\\cypress\\integration\\01Navigation.feature',
  originalStack:
   "Error: Cannot find module 'cypress/integration/common/common.steps.js' from 'C:\\Users\\<user>\\Repo\\<project>\\ui\\cypress\\integration'\n    at C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\browser-resolve\\node_modules\\resolve\\lib\\async.js:46:17\n    at process (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\browser-resolve\\node_modules\\resolve\\lib\\async.js:173:43)\n    at ondir (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\browser-resolve\\node_modules\\resolve\\lib\\async.js:188:17)\n    at load (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\browser-resolve\\node_modules\\resolve\\lib\\async.js:69:43)\n    at onex (C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\browser-resolve\\node_modules\\resolve\\lib\\async.js:92:31)\n    at C:\\Users\\<user>\\Repo\\<project>\\ui\\node_modules\\browser-resolve\\node_modules\\resolve\\lib\\async.js:22:47\n    at callback (C:\\Users\\<user>\\AppData\\Local\\Cypress\\Cache\\3.7.0\\Cypress\\resources\\app\\packages\\server\\node_modules\\graceful-fs\\polyfills.js:295:20)\n    at FSReqCallback.oncomplete (fs.js:163:21)\n" } +27s
  cypress:server:plugins promise rejected for id inv1 ':' Error: Cannot find module 'cypress/integration/common/common.steps.js' from 'C:\Users\<user>\Repo\<project>\ui\cypress\integration'
    at C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:46:17
    at process (C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:173:43)
    at ondir (C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:188:17)
    at load (C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:69:43)
    at onex (C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:92:31)
    at C:\Users\<user>\Repo\<project>\ui\node_modules\browser-resolve\node_modules\resolve\lib\async.js:22:47
    at callback (C:\Users\<user>\AppData\Local\Cypress\Cache\3.7.0\Cypress\resources\app\packages\server\node_modules\graceful-fs\polyfills.js:295:20)
    at FSReqCallback.oncomplete (fs.js:163:21)
 +0ms

Oops...we found an error preparing this test file:

  cypress\integration\01Navigation.feature

The error was:

Error: Cannot find module 'cypress/integration/common/common.steps.js' from 'C:\Users\<user>\Repo\<project>\ui\cypress\integration'

This occurred while Cypress was compiling and bundling your test code. This is usually caused by:

- A missing file or dependency
- A syntax error in the file or one of its dependencies

Fix the error in your code and re-run your tests.

Can you open a new issue and create a reproduction? I consider this issue fixed now. If there are more - let's chase them


Dockerfile for grounder.

I have marked this as a WIP because to run it I have been also using a script file that I believe to be poorly designed.

Also, if I knew more about GitHub actions, I would suggest setting up a GitHub action that would automatically build the Docker image.

For simple cases like this, there is a sample GitHub action, which I have attempted to insert into the branch.  Not sure if it will run -- may need to extend the on: part to make it testable.

For your copy there is really no reason to keep the changes in a separate branch (as we still have the panda-planner-dev:master as the overall true master). If you merge the dockerfile branch into your master, you can still PR your master into this one and try to test-run the dockerfile in your repo.

I have the dockerfile working again. I don't like the need to apply the patch, though, because it means that if I run docker build in a directory in which the patch has already been applied, then the build will fail.
That's why the Dockerfile now makes sure that cpddl is clean and then applies the patch.
This is very kludgy and will fail as soon as the patch becomes no longer necessary.
It would be much better to fork the cpddl repo, apply the patch to the fork, and use the fork for the external, instead of using upstream as the external and having to patch it.  Doing so makes the build process ugly and brittle.


Exception on error in response code

Hi, I use pronto with gitlab, and I guess it returns one of this errors on comments post https://github.com/NARKOZ/gitlab/blob/2eb3a093419fcf367cbd19576c116febfbd17d2e/lib/gitlab/request.rb#L52-L61
But there are exception when it decodes the error message
/lib/gems/2.3.0/gems/gitlab-4.3.0/lib/gitlab/request.rb:37:in `rescue in decode': The response is not a valid JSON (Gitlab::Error::Parsing)
	from /var/lib/gems/2.3.0/gems/gitlab-4.3.0/lib/gitlab/request.rb:35:in `decode'
	from /var/lib/gems/2.3.0/gems/gitlab-4.3.0/lib/gitlab/request.rb:16:in `parse'
	from /var/lib/gems/2.3.0/gems/gitlab-4.3.0/lib/gitlab/request.rb:10:in `block in <class:Request>'
	from /var/lib/gems/2.3.0/gems/httparty-0.16.2/lib/httparty/request.rb:391:in `parse_response'
	from /var/lib/gems/2.3.0/gems/httparty-0.16.2/lib/httparty/request.rb:359:in `block in handle_response'
	from /var/lib/gems/2.3.0/gems/httparty-0.16.2/lib/httparty/response.rb:25:in `parsed_response'
	from /var/lib/gems/2.3.0/gems/gitlab-4.3.0/lib/gitlab/error.rb:39:in `build_error_message'
	from /var/lib/gems/2.3.0/gems/gitlab-4.3.0/lib/gitlab/error.rb:16:in `initialize'
	from /var/lib/gems/2.3.0/gems/gitlab-4.3.0/lib/gitlab/request.rb:64:in `exception'
	from /var/lib/gems/2.3.0/gems/gitlab-4.3.0/lib/gitlab/request.rb:64:in `raise'
	from /var/lib/gems/2.3.0/gems/gitlab-4.3.0/lib/gitlab/request.rb:64:in `validate'
	from /var/lib/gems/2.3.0/gems/gitlab-4.3.0/lib/gitlab/request.rb:44:in `block (2 levels) in <class:Request>'
	from /var/lib/gems/2.3.0/gems/gitlab-4.3.0/lib/gitlab/client/commits.rb:61:in `commit_comments'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto/gitlab.rb:5:in `commit_comments'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto/formatter/commit_formatter.rb:6:in `block in existing_comments'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto/formatter/commit_formatter.rb:6:in `each'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto/formatter/commit_formatter.rb:6:in `flat_map'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto/formatter/commit_formatter.rb:6:in `existing_comments'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto/formatter/git_formatter.rb:6:in `format'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto.rb:67:in `block in run'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto.rb:66:in `each'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto.rb:66:in `run'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto/cli.rb:61:in `block in run'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto/cli.rb:60:in `chdir'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/lib/pronto/cli.rb:60:in `run'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
	from /var/lib/gems/2.3.0/gems/thor-0.19.4/lib/thor/base.rb:444:in `start'
	from /var/lib/gems/2.3.0/gems/pronto-0.9.5/bin/pronto:6:in `<top (required)>'
	from /usr/local/bin/pronto:22:in `load'
	from /usr/local/bin/pronto:22:in `<main>'

Should be fixed in version 4.5.0 via 2eb3a093419fcf367cbd19576c116febfbd17d2e


[Request] Add more fuel sources

Currently stuck trying to find sea pickles for fuel, nearest village got wiped by zombies (I don't even know if they sell pickles) and i started in the middle of a deep ocean biome (not warm ocean which spawns corals resulting in pickles) and i've enabled large biomes so i've been boating A LOT trying to find warm ocean (let alone any other biome). Gonna try nether fast travel to see if I can cover more ground.
I would appreciate if there was an alternative fuel source (maybe with different qualities like dirty fuel that works but has higher malfunction/overheat rate) to make this easier mod easier to take advantage of.

Thank you for the suggestion!
I had planned to introduce a new fluid source to the mod as fuel, but due to the time limit of the ModFest event, I put in the fuel bucket (more or less as a debug item). This will most likely be worked on pretty soon, and I am also looking into ways to incorporate other mods which introduce fluid handling.
If you need a fix urgently, you can change the recipe by making a small Datapack for your world with the namespace of boatism instead of minecraft.
https://minecraft.wiki/w/Tutorials/Creating_a_data_pack#Recipes

Managed the recipe modification approach, thanks!

Does the engine disappear when it fails? I got attacked by trident-wielding drowned. I reclaimed the boat but the engine is nowhere to be found. I am using a mod that gives items extending pick-up range so I'm positive it's not just somewhere on the seabed.

The engine entity itself has an HP value so it can technically die. If the linked boat gets destroyed while the engine still exists, the engine will be dropped as an item with all the attachments still on it (they just don't render in item form).

It's a nightmare to deal with so far. Made the engine twice, upgraded it(not armour lol since it overlaps with fuel canister). Got destroyed in one hit by trident-wielding scum both times despite moving at high speed. Good thing there's a config to tweak the engine properties.

It's a nightmare to deal with so far. Made the engine twice, upgraded it(not armour lol since it overlaps with fuel canister). Got destroyed in one hit by trident-wielding scum both times despite moving at high speed. Good thing there's a config to tweak the engine properties.

will take a look at balancing a bit more. Maybe it might be better to give it aloooot of health and destroy it if the boat goes down. But I can imagine that this could lead to side effects where the engine could be used as a shield.

Forgot to mention engine keeps the boat moving if u disembark the boat lmfao.

Yup, it's intended behaviour. An engine doesn't just stop just because you disembark. I could put that into the config too tho.

And one last question hopefully. How much fuel does one bucket give?

Like I mentioned earlier the bucket is more or less a debug item. It always fills up the engine completely. So strap on a canister first and then fill it up if you want to go further.

I raised overheat threshold but it does not affect the overheat warning (i assume it's because warning is related to rate of overheat instead of how soon it will overheat)

Technically the overheat warning is based on if it is starting to overheat. This always happens if the power level is above 6 or your power level is bigger than 3 and you boat is going slower than expected. You can drastically increase the overheat threshold with the exhaust item if needed, or change the base value in the config. The amount of overheat is currently displayed using the overheating sound but I planned on also displaying it in the coming UI feature.

I initially assumed the engine is just a modification to the boat's properties (making it go faster when the engine is on) but the engine providing its own thrust - which is normal and sane - in addition to the rowing's own thrust makes no sense, which makes me wonder, is it possible to mod it so manual forward movement is disabled and only engine thrust is usable (with the row thrust power added to the engine's instead)?

The engine's thrust value is added to the boat's velocity if a player is driving it. But yes in the backend there is a mechanism which calculates empty seats, load value, and other information. This is also what still allows the boat to take a curve at the moment. I was thinking about letting the boat engine rotate to clean up the visuals but I'm not sure on that one yet.
The power level can be changed using the scrolling or by using the keybinds in the settings.

But I can imagine that this could lead to side effects where the engine could be used as a shield.

Realistically, engines do make for good shields. It should render it inoperable and switch to a damaged variant if destroyed, or even give it durability points instead of mob HP, this way you can repair it on the anvil.

Like I mentioned earlier the bucket is more or less a debug item. It always fills up the engine completely. So strap on a canister first and then fill it up if you want to go further.

That's strange cuz when i configged the max fuel to 99999, refueling would never stop the low fuel warning.
Just examined the code, it seems fuel add amount is hardcoded to 3000.

Yup, I see your point. Maybe limiting power levels/thrust and adding ways to repair it on the go with drawbacks might be a good way of dealing with that issue as well.
I double-checked the code too now. Seems like I capped it for the ModFest event a while ago. The bucket will probably be removed or changed completely so I won't change this value for now until the fuel rework.
Thanks for the testing!


⚠ Home NAS has degraded performance

In 22a74c0, Home NAS ($MY_NAS_URL) experienced degraded performance:

HTTP code: 200
Response time: 8422 ms

Resolved: Home NAS performance has improved in fdb1ec8.


feat: directed href targets

:tada: This PR is included in version 8.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


How to use customized Swagger-ui?

There is a very nice fork for Swagger-ui, please refer to https://github.com/jensoleg/swagger-ui.
My question is how to use it in Swashbuckle? Show I build Swashbuckle from scratch?

First and foremost, SB is a Swagger generator. It does bundle in a version of the swagger-ui for convenience, to help get up and running quickly. But, at the end of the day, the swagger-ui is just a set of static assets which could be easily added to any ASP.NET project independent of SB.
If I were you, I would just use SB to provide the generated Swagger JSON and then serve the forked version of swagger-ui independently as a set of static assets. You'll just need to make sure the forked index.html points to the Swagger endpoints generated by SB.

FYI - this would mean your omit the call to EnableSwaggerUi in SwaggerConfig.cs


Dialog issue

Hi,
I'm not sure if is an issue here or I'm doing something wrong. I have a window which opens another window when i press  button Test. This new window have a Multiselect-ComboBox, but when i open this window there are no items in the Multiselect-ComboBox.
I made a test on a test project because i don't know what the issue. The initial window:

From the second window(the same), I don't have any items.

I mention that I want to use it with dialoghost from materialDesign but because i didn't have any idea where is the issue,  i test it with ShowDialog.
Thank you,
Simona

Hi @simonatocanie ,
Would it be possible to send a sample project?

Hi @simonatocanie, I responded to a similar issue a while back, as follows:
https://github.com/sdl/Multiselect-ComboBox/issues/5
not sure if that helps?

Hi,
Thank you very much for your help.  I didn't had access on my laptop until now. It's working now.
You can close the issue.
Have a nice evening!

Not an actual issue.


issue with import { ModuleWithProviders } from '@angular/compiler/src/core';

we have issue with import, file https://github.com/gabrielbusarello/material2-carousel/blob/master/projects/carousel/src/lib/carousel.module.ts
error message during npm install:
error: node_modules/@ngbmodule/material-carousel/lib/carousel.module.d.ts:2:10 - error TS2305: Module '"@angular/compiler/src/core"' has no exported member 'ModuleWithProviders'.
2 import { ModuleWithProviders } from '@angular/compiler/src/core';
can this import be changed to "from '@angular/core'"?

this issue is already reported


Update Resource Coverage FAQ with newly added resources

https://forsetisecurity.org/docs/v2.0/faq/#resource-coverage
Specifically, looking for the KMS resources, but verify others are up-to-date.

Addressed by PR #2537.


Document Migration from ftw

Hi go-ftw Team,
I am working on updating some documentation, and I found that some of the docs are missing in the go-ftw. (e.g., the format of the YAML test file)
And I found it in the ftw repo: https://github.com/coreruleset/ftw/tree/main/docs
Should we migrate the documentation to go-ftw?

We're working on generating the documentation for the test file format. If we can get that off the ground soon then we don't have to. @fzipi?

Exactly. I'm working on having this in the code. I'll update everything accordingly.

@dextermallo The new repo with generated documentation is here: https://github.com/coreruleset/ftw-tests-schema

@dextermallo Do you still have time to update this documentation?

Hi @fzipi, sure! Lemme do a quick check on this issue :)

Hi, I have another idea. Instead of making it under an individual repository, would it be better to make the official documentation as an all-in-one collection to ease the difficulty of referencing/searching for documentation?
The schema/usage for testing may be reused across different repositories. Putting it in the main documentation can make things easier.
Can also be put together in this issue: https://github.com/coreruleset/documentation/issues/133


Pass string to wasm function

Hi, I think the project looks really great. How would you pass a string to a function defined in wasm. The memory example shows how you could return a string from a function. I would assume that we could also create a Uint8Array and pass this containing the string bytes to the wasm function? In this case we could probably create in this lib some helper functions i.e. to convert a string to Uint8Array. Also Iam curious whether it would be possible to pass more complex data structures like assoc array (struct) to a wasm function?

Hello :-),
Creating a library à la wasm-bindgen is something we are thinking of.
We look at the Host Bindings API too, which can be adapted to PHP. This is not stable yet, though.

I would assume that we could also create a Uint8Array and pass this containing the string bytes to the wasm function?

Exactly, but you need to allocate some memory before, and it depends of your Wasm program. We can't just assume an alloc or a dealloc exported functions exist.
Would it help if I add examples to see how to handle strings, or more sophisticated data structures?

Hi, yes it would be really great if you could provide some examples howto pass and return more complex data structures to a function defined in wasm.
I am currently working on an API management tool where the endpoint logic can be developed by a user. It would be great if a user could upload a wasm file with a custom function which is then invoked by the API management tool for a specfic route. This would have the great advantage that the user could develop the
endpoint logic in basically every programming language and is not bound to PHP. For this I would need to pass all request data to the wasm function as i.e. assoc array or object and then the wasm function could return a simple JSON encoded string.

@Hywan I believe that wasm-bindgen’s goal is for the underlying foundation to be able to support other languages - so one other option here might be trying to work with the wasm-bindgen folks to get a sense of how some of their underlying infrastructure can be re-used here.

@chinedufn True. We've already discussed about that with the wasm-bindgen folks. The project is closely tied to JS however. That's a big discussion to have: Between the language-interop itself, and the Host Bindings API.

Bonus: Recents commits (see #54 and #53) have boosted function invocation by 9.75 to 15.9%.

@chriskapp I hope https://github.com/wasmerio/php-ext-wasm/blob/master/examples/greet.php is a good basis for you! Tell me if you need help :-).

@Hywan thank you very much, this looks really promising. I will try to implement this in my project and I will let you know whether everything works as expected.


Create the parties table

User Story

As a user, I can update a candidate's party affiliation.

As a user, I can request a single candidate's information, including party affiliation.

As a user, I can request a list of all the parties.

As a user, I can request a single party's information.

As a user, I can delete a party.

As a user, I can request a single candidate's information.

As a user, I want to delete a candidate.

As a user, I want to create a candidate.

The user can now update the party affiliation of candidates, request a single candidate's information that includes party affiliation, request a list of all the parties, request a single party's information, delete a party, request a single candidate's information, and delete and create a candidate.


Nuscenes train annotation without location key

Hi, I found a problem in nuscenes_dataset.py, like:
    def get_data_info(self, index: int) -> Dict[str, Any]:
        info = self.data_infos[index]

        data = dict(
            token=info["token"],
            sample_idx=info['token'],
            lidar_path=info["lidar_path"],
            sweeps=info["sweeps"],
            timestamp=info["timestamp"],
            location=info["location"],
        )

But, in nuscenes_infos_train.pkl info values, without location.
Anyone met the same problem ?

Are you using the pkl file generated from mmdetection3d? If so, I would recommend you to either regenerate the info file using our codebase or remove the location term in the data dict. Our data preprocessing code does record location in the pkl, as indicated here.

Closed due to inactivity. Please feel free to reopen if you feel it necessary.

Thanks for your reply ! Can you show the way how to use nuscenes_converter.py ? I can't find anything about it in README.


Bug: Undefined method `downcase' for nil:NilClass

brew install diamond
Error: No available formula for diamond
Searching formulae...
Searching taps...
Error: undefined method `downcase' for nil:NilClass
Please report this bug:
    https://github.com/Homebrew/linuxbrew/blob/master/share/doc/homebrew/Troubleshooting.md#troubleshooting
/home/leebergstrand/.linuxbrew/Library/Homebrew/cmd/search.rb:105:in `search_tap'
/home/leebergstrand/.linuxbrew/Library/Homebrew/cmd/search.rb:98:in `block (2 levels) in search_taps'

Thanks for the bug report, Lee.


WebpackDevServer: (Only) Ignore node_modules if polling is required

Fixes the most common case of https://github.com/facebook/create-react-app/issues/2956.
This PR changes WebpackDevServer settings to only ignore node_modules if the resource intensive CHOKIDAR_USEPOLLING environment variable is set. AFAIK using the said environment variable is the only way to end up poll watching, as CRA itself doesn't explicitly set polling related options. (edit: wrong, check below)
The PR also ignores the special ignoredFiles set, as CRA now supports monorepos natively. Instead we ignore all node_modules folders with a /node_modules/ RegExp. Removing the special case also removes the tests from react-dev-utils as they were the only related tests to that package.
Not sure if we should also have an escape hatch (like IGNORE_NODE_MODULES_WATCHING env variable) for cases where native file watching could be too intensive anyway?
Also should we warn the users if polling is enable that the node_modules folder is ignored or is the README notice enough?

AFAIK using the said environment variable is the only way to end up poll watching, as CRA itself doesn't explicitly set polling related options.

What if fsevents failed to install? I imagine chokidar would also switch to polling.

Good point and it is true, missed that Chokidar falls back to the polling in that case on OSX:
https://github.com/paulmillr/chokidar/blob/master/index.js#L89
Not quite sure what the strategy catching that would be. Just checking that fsevents exists and requires neatly like it does in  https://github.com/paulmillr/chokidar/blob/d1bac5bfe707c71a9f82b81d4c80de0fae3a8715/lib/fsevents-handler.js#L7-L9?

Yes but you’d need to make sure you’re trying to resolve it from the same folder. So you might need to recursively resolve the package chain. Sounds kinda complicated.

Also what happens on windows? Does it need polling?

On Windows Chokidar docs state that

On other platforms, the fs.watch-based implementation is the default, which avoids polling and keeps CPU usage down. Be advised that chokidar will initiate watchers recursively for everything within scope of the paths that have been specified, so be judicious about not wasting system resources by watching much more than needed.

So Windows shouldn't use polling unless forced (which is also the impression I got from a quick dive to fs.watch internals.
The resolving thing does sound kinda complicated, let me try something on that.
Thanks for the comments @gaearon 👍

@gaearon I did a test of diving into the the cache and confirmed that something like the following does work, tested by first having fsevents installed and then not having fsevents installed.
const watchOptions = {};

// While Create React App does not use polling for watching files by default,
// polling can occur if CHOKIDAR_USEPOLLING environment variable is
// set to a truthy value. Excessive polling can cause CPU overloads
// on some systems (see https://github.com/facebookincubator/create-react-app/issues/293),
// which is why we ignore node_modules if polling is enforced.
let shouldIgnoreNodeModules = false;

const envForceUsePolling = process.env.CHOKIDAR_USEPOLLING;

if (envForceUsePolling) {
  const usePollingLower = envForceUsePolling.toLowerCase();

  // Chokidar rules https://github.com/paulmillr/chokidar/blob/master/index.js#L99
  if (
    usePollingLower === 'true' ||
    usePollingLower === '1' ||
    !!usePollingLower
  ) {
    shouldIgnoreNodeModules = true;
  }
}

if (process.platform === "darwin") {
  // check if fsevents is loaded
  const cacheKeys = Object.keys(require.cache);
  const cachedFsEvents = require.cache[cacheKeys.find(i => i.includes("/fsevents/fsevents.js"))];

  if (cachedFsEvents && cachedFsEvents.loaded) {
    // fsEvents is loaded, check if its WebpackDevServers
    let parentIsWebpackDevServer = false;
    let parent = cachedFsEvents.parent;

    while (parent && !parentIsWebpackDevServer) {
      if (parent.id.includes("webpack-dev-server")) {
        parentIsWebpackDevServer = true;
      }

      parent = parent.parent;
    }

    if (!parentIsWebpackDevServer) {
      shouldIgnoreNodeModules = true;
    }
  } else {
    shouldIgnoreNodeModules = true;
  }
}

if (shouldIgnoreNodeModules) {
  watchOptions.ignored = /node_modules/;
}

Not sure if that just cachedFsEvents && cachedFsEvents.loaded would be enough, but the parent check works too. Does that sound crazy? Caveats include possibly (but very unlikely) the filenames changing or something deleting it from the cache in between WebpackDevServer being required and the config being initialized (not very likely either I guess).

I don't mind something like this as long as it's hidden in react-dev-utils and doesn't negatively impact startup time. (That Object.keys is worth measuring)

Cool 👌 Did some measurements on my machine and rolling the whole check takes ~500000ns on my machine so it shouldn't be a worry (we can double check on that later). I'll move the check to react-dev-utils and commit the thing in.

Not sure why the tests flaked 🤔

@petetnt you need to add the new files to the files property in package.json https://github.com/petetnt/create-react-app/blob/0c4bbc9355bc3e733316351813b644477c2f13f4/packages/react-dev-utils/package.json#L13-L37

Ah, of course. Thanks @viankakrisna


[Enhancement] improve usert prompt when data loading meets drop table or schema change (backport #28425)

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto-backported to the target branch

[ ] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:heart_eyes: pass : 0 / 0 (0%)


LoRA support

This should be relatively easy due to the existing infrastructure for X-LoRA. Additionally, the weight stacking mechanism can be used to speed up.

#93 laid the groundwork for this, by implementing weight merging. This will allow the weights to be merged into a single Linear weight matrix, so there will be no additional cost to using LoRA over the base model!


Show all container images in Workload view

Addresses Github issue: #4736
Addresses Zube issue: #4644
Added tooltip with all container images in Workload view

@nwmac addressed the changes requested. Can you take another look? Thanks 🙏
Preview


[WIP] Make actions and filters unhookable.

Summary
Requires https://github.com/google/web-stories-wp/pull/2623

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

Fixes #

Can you resolve merge conflicts here?


Return Collection of results rather than just the first one.

I started with this project when I was looking to create an address search drop-down. Rather than selecting the first result, which I found to rarely be the one I needed, I wanted to have a collection of results instead. I've re-written this so that it doesn't break changes with the original getCoordinatesForAddress().
This pr adds getAllCoordinatesForAddress() which will return an Illuminate\Support\Collection object containing all of the results.

Could you add a test for getAllCoordinatesForAddress?

Any news ? :(


⚠ Bofrost.fr has degraded performance

In 175e541, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1069 ms

Resolved: Bofrost.fr performance has improved in 48edd2e after 6 minutes.


New Ring: VM Ring

Please create a "VM Ring".
Purpose: to discuss EVM and eWASM design, improvements, and compatibility. New opcode definition. Keeping Jello / Yellow paper specifications up to date.
cc @gcolvin @expede

Created ring on Discourse: https://ethereum-magicians.org/t/forming-a-ring-vm-ring/2830


Replacing GitHub Link in CONTRIBUTING.md

Pull Request Description:
This pull request addresses the following changes in the project's documentation:

Replaces the GitHub issues link in CONTRIBUTING.md from "https://github.com/hashirshoaeb/star_book/issues" to "https://github.com/Blocship/star_book/issues".

This change aligns the documentation with the correct GitHub repository and will help users and contributors navigate to the correct location for reporting issues and seeking help.
Closes Issues:
Closes #485, #486, #487
How to Test:

Go to the CONTRIBUTING.md file.
Locate the GitHub issues link: "https://github.com/hashirshoaeb/star_book/issues".
Verify that it has been replaced with "https://github.com/Blocship/star_book/issues".

If there are any further changes or clarifications required, kindly let me know, and I will be happy to assist.

Appreciation: @Redvey, I appreciate your work.
Issue Resolution: Please solve one issue in one PR.
Change Limitation: Do not make changes except the desired ones mentioned in the issue.
Branch Naming: Refer to the contributing section in readme.md for branch naming instructions.
Closure: I am closing this PR.
Acknowledgment: Thank you for your contribution and time for this project.
Next Steps: Make the necessary changes and push a new PR.
Wishes: Happy learning! 🙏🙌

ok alright


Fix/hapi17

Quick and dirty support for Hapi 17. You probably don't want this PR but figured I'd open it in case the reference is helpful. cc #18

Thank you for the initial PR @patbenatar! We've added Hapi v17 support in #26.


Too many Enchantments can block ENCHANT.

Having too many enchantments blocks the ENCHANT button.
Maybe have it to where ENCHANT is on the Left Side, or works when you press Enter/Return.

You're right, I will work on implementing moving the button and making enter press the enchant button.

Maybe instead of moving the button, have a scrolling GUI?

On the topic of reworking the UI, having the ability to unselect enchantments would be pretty good. I think it´d also be good to make it more clear which enchantments do you have currently selected and how many can you select

You're right, I will work on implementing moving the button and making enter press the enchant button.

I would rather a page button system:
[Option #1]
[Option #2]
[Option #3]
[Option #4]
[Option #5]
[Option #6]
[<] 1/2 [>]
[ENCHANT!]

smart, i think thats way better

smart, i think thats way better

Yeah, it's the faster than scrolling, compact, but allows for infinite enchants.
You could even make the "1"/2 a text box so you could manually type the number in if the player wishes. That being said, that would imply you got over 9 pages of enchants to go through for such a feature to even be convient in the first place. . . and personally speaking, I "doubt" such a circumstance would be that frequent of an issue to justify the effort for the textbox implementation.


editorconfig: Default to 4 spaces

As evidenced in #947 the majority of our .talon files use 4-space indents. This changes the default to 4 spaces, overriding it for Markdown and YAML files (which should always be 2 spaces).

While we're doing a reformatting of all talon files, that's probably the right time to choose an indent depth, so I'm going to discuss this question in #947 if that's all right


ScalametaParser: allow Enum.Val before generator

This is described in SIP-62.

superseeds #3727.

I'm a bit late to the party, but I think that these changes are incorrect, which is weird since it looks like @kitbellew literally copied over the test cases from my PR. Is this intentional?
The following example should not be accepted under any compiler flag or option:
for {
  a = 1
  if b > 0
  b <- Some(2)
} yield a + b

@KacperFKorban i know it should not, but that's my point: i don't know if scalameta should really be in the business of policing syntax as long as it's not ambiguous.
i kept the check for guard not being first, and didn't introduce this check partly because (for some reason) there was a test case with generator followed by val and then followed by guard.
there are a lot of cases which we don't detect, such as mismatched levels of significant indentation.

@kitbellew Ok, fair enough. Just making sure that it is intentional and also transparent with @tgodzik


new simplegesture throws error

 onMoveShouldSetPanResponder: (e, gs) => {
        let sgs = new SimpleGesture(gs);
        return true;
      }

throws an error - cannot read property 'dx' of undefined.

sorry, was calling the constructor without the event


Firebase exception handling

When I tried to login with Firebase using GitHub no errors were shown on the site, but in the console I could see this message
{
  "code": "auth/account-exists-with-different-credential",
  "message": "An account already exists with the same email address but
              different sign-in credentials. Sign in using a provider
              associated with this email address.",
  "email"<EMAIL_ADDRESS>  "providerId": "github.com",
  "signInMethod": "github.com",
  "oauthAccessToken": "b4a0ae573b[...]80e6f399a4a6"
}

I'm not sure how complete we need the auth example implementations to be. It is just a playground after all. But perhaps we should at least indicate that something went wrong. Maybe even say something like "See the dev console for more details"
What do you all think?

Related to issue https://github.com/redwoodjs/playground-auth/issues/39


Add padding py-1 for links

This increases Lighthouse SEO score from 94 to 100
Current score: https://lighthouse-dot-webdotdevsite.appspot.com//lh/html?url=https%3A%2F%2Fdoc.deno.land%2F#seo

@lucacasonato PTAL


Tensorflow > 2.11 ?

Are Tensorflow version above 2.11 supported by TF Similarity?
The setup.py (https://github.com/tensorflow/similarity/blob/v0.18/setup.py#L91) limits the TF version to <= 2.11.
Thank you for your reply!

Hi Hannes,
we just need to update the setup and workflow tests. Looks like there are a few changes but not too bad. I've started a PR and I'll try and merge the changes by tomorrow.

Is the merge unlikely to happen any time soon?


Added samples for most of the filters

I had a hard time to understand the usage of some of the filters. So i created examples for most of the filters.

Excellent addition, thanks!


lsblk doesn't see USB storage

Version
Microsoft Windows [Version 10.0.19043.1706]
WSL Version

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>-microsoft-standard-WSL2
Distro Version
Ubuntu
Other Software
No response
Repro Steps
I followed this instruction to get my USB seen by WSL2:
https://github.com/dorssel/usbipd-win
Unfortunately lsblk command doesn't return this storge while lsusb does.
Please introduce proper driver so no custom kernel compilation will be required.
Expected Behavior
USB driver available by default.
Actual Behavior
lsblk not recognizing USB storage
Diagnostic Logs
No response

@marcin2x4 Hello, just so I can better understand, are you requesting support for this feature or is this an actual bug you are encountering?

If this is expected behavior, then this is a feature request. If this is not expected, then this is a bug
I am experiencing the same thing

Is there any progress, on this task?

Marking as a feature request

Same here.. Please add drivers for external disk support into kernel

Any progress about this issue, thanks


How to mapping ui query with oal

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion

Question

What do you want to know?
the purpose of  oal expression is to compute metric by a simple way.
In my mind,the using of it contains the 2 following ways:

for alert:
so the alerm-settings.xml metrcs-nem is mapping to the official_analysis.oal
for watching:
the ui dashborad

1st querstion: i don't know the mapping between rules and interfaces.
for example:
the name of ServiceReponseTIme in oal is service_resp_time,however the name of ServiceReponseTIme in ui is serviceResponseTime.

2nd question:  Whether the ui can change dynamically follows the oal rules,
How to do it if skywalking-ui have this ability ?
Thanks for your helping.

1st querstion: i don't know the mapping between rules and interfaces.
for example:
the name of ServiceReponseTIme in oal is service_resp_time,however the name of ServiceReponseTIme in ui is serviceResponseTime.

This is normal case. UI is for human reading, and OAL is for developers. They are different.

2nd question: Whether the ui can change dynamically follows the oal rules,
How to do it if skywalking-ui have this ability ?

This is a complex feature. @TinyAllen used to try this, but don't work very well. So, currently, it is not there. UI doesn't support custom metrics.

But how does the ui  and oal correspond one by one?I found the name is different,is there a doc for explain it,or say all in the official oal.
the second question ,I found the past issue which says ui support the custom metrics,but in your response I think it is unrealistic.
So i found the exporter module, is it a good way to get this custom information? How to use it?why don't combine it to promethus module. thanks for your helping

so the metrics exporter is a way to get this custom

I got it from promethus plugin ,thanks for your helping


Add String#enclosed_with?

A method that combine starts_with? and ends_with?.
This is of course not an essential feature, but I find it quite elegant - specially when used with when inside case expressions.
Be free to not merge.

I don't think this adds a visible value to what we currently have with starts_with? / ends_with?.

@sdogruyol Agree - I've added custom methods for String and Regex to merge both starts_with? and ends_with? programmatically. We can expect a performance gain.

Sorry, I hardly see the value.

There is something to it when start and end are the same...

Use &&. Define a helper method. Let's not clutter the std.

@asterite can you consider reopening this? I've done some cleanups. I guess the commits doesn't appear here because the PR is closed...

Sorry @j8r, but enough people have raised that adding enclosed_with? does not improve the std. For readability of code it can be easily added. If there are some effort that will be great for certain usages maybe a shard is a better fit. If so, feel free to drop a link here for reference.
I hope to see you in other issue & PR around 🙇


Code cleanup

Coverage decreased (-0.03%) to 73.823% when pulling fdb4f5264ee0cce3f52ed0599680ee61c6cfa45a on enhance-code-quality into 9c2fb982da9796fea6f3c796ea42bd0ee6b55bb4 on master.


hello-world-js

What the program do ?
console log "Hello World!"
In what programming language it is written?
JavaScript

This pull request do not contains files in specific folders. Please fix it and reopen


https_server_test (Timeout) fails

This appears to be a race condition that periodically pops up on some pbuilder builds for the PPA. Specifically the https_server_test unit test fails due to a timeout. This happened recently on the i386 build. The build log is available here.

Strangely, the https_server_test also randomly times out when ran on my Gentoo Linux box for a clang build, but never for gcc build.  I've not attempted to debug it though.

Yeah. Let's keep this issue open as a placeholder for eventually figuring out what the issue is.

I take back what I posted above.  I can get the "https_server_test" to timeout on both gcc and clang builds.
The lockup happens much more frequently on the clang build than the gcc.  However, the gcc build seems to lock up more frequently when there is external cpu contention 9for example, compiling something unrelated on the side).
The clang build seems to lock up about ever 3rd run of the test.
$ clang++ --version
clang version 9.0.1
$ g++ --version
g++ (Gentoo 9.2.0-r3 p4) 9.2.0

$ mkdir build
$ cd build
$ CC=clang CXX=clang++ cmake -G "Unix Makefiles" \
    -DCMAKE_BUILD_TYPE=Debug \
    -DPISTACHE_BUILD_EXAMPLES=true \
    -DPISTACHE_BUILD_TESTS=true \
    -DPISTACHE_ENABLE_NETWORK_TESTS=true \
    -DPISTACHE_USE_SSL=true \
    ..
$ make
$ cd build/tests
$ while ./run_https_server_test ; do date; done

kip, can you try to repro the above?  I'm a bit tired right now, but soon I'll try to get a stack dump for all threads when it is locked up.

Hey Dennis. It looks like the trailing server.shutdown() in the basic_tls_request_with_auth_client_cert_not_signed is hanging. The stack trace leads to L81 of the Listener destructor waiting on acceptThread.join(). For whatever reason the acceptThread never returns control.

my c5 on the issue: it happens more frequently on SuSE testbed, rather than on Fedora/Cent8
Compilers are GCC 7.4.0 and 9.2.1 on SuSE and 8.3.1 and 9.2.1 on RH-derivatives.
May it be some external dependency (or just a lack of tests)?

I'm fairly certain that this is caused by a race condition in pistache.  The test is hard to trigger on the gcc build on my gentoo box if the box is otherwise idle, but when there is CPU contention, it becomes easy to trigger.  In my experience, this strongly suggests a race condition.  I just need to find time to hunt it down w/ valgrind and tsan.

Broke in the PPA builder again this evening (just in disco and only on ppc64el). Same timeout issue. Here is the log.

I will experiment and see if #761 will close this.


Unable to convert a Tensorflow DeepSpeech model with beta converter

Hello,
I recently tried converting a Tensorflow model of DeepSpeech to CoreML and was unable to.
Here is where the pre-trained model came from: https://github.com/mozilla/DeepSpeech/releases/download/v0.4.1/deepspeech-0.4.1-models.tar.gz
Here is my code to convert:
import tfcoreml as tf_converter
tf_converter.convert(tf_model_path = '/path/to/deep_speech.pb',
                     mlmodel_path = '/path/to/export/deepspeech_model.mlmodel',
                     output_feature_names = ['logits:0', 'new_state_c:0', 'new_state_h:0'],
                     input_name_shape_dict = {
                         'input_reshaped:0': [16, 494],
                         'previous_state_c:0': [1,2048],
                         'previous_state_h:0': [1,2048]
                     },
                     use_coreml_3 = True)

Here is the end of the output:
68         for f in ssa.functions.values():
     69             for n in f.graph.values():
---> 70                 assert (n.datatype is not None)
     71     return ssa

AssertionError:

+1. I'm getting this for my custom model that converts fine without the use_coreml_3 = True flag

(This is preventing experimentation with CoreML3, in case it isn't obvious...)

If the model converts without the flag being set to true, thats great, please continue to use that.
The flag use_coreml_3, at the moment, is really for trying out the converter on those networks (such as RNN etc) that were not supported in the previous converter.

@MatthewWaller @lauriebyrum Here's an example convert script: https://github.com/tf-coreml/tf-coreml/blob/master/examples/deep_speech.ipynb. Note that this convert requires seed 5 or later. Please re-open if you find any issues. Thanks!