Equals and HashCode for XML Element

I want to use the XmlReader in unit tests to compare a generated xml file and a predefined one. To compare each XmlReader.Element is a overridden equals-method needed. I didn't include parent in equals and hashCode to prevent an infinite loop

it's a important breaking change... i'm not sure we want that.
also, not sure that diamond operator is something we want.

The diamond operator is a problem if we still target Java 6, but I don't think we do. @mgsx-dev , I don't know exactly what the breaking change is here -- two value-equivalent XmlReader.Element values could compare as either equal or not equal before this, depending on identity. You still can compare by identity using == on objects and probably should do that if you expect identity equality. You can use System.identityHashCode() if you want to hash objects by identity, or use IdentityMap, both of which are the correct ways to expect keys to be hashed by identity. I don't know why you would want identity equality for what are typically just-parsed items, potentially from different XML files. It seems like relying on identity equality for XML elements would cause more bugs than it fixes.
I also want to point out that the more changes we mark as a BREAKING CHANGE, the less likely people are to update. Case in point:
If it actually does break code, absolutely mark it as breaking; if it fixes a bug or incorrect behavior, then don't. Still mark it in the changelog, of course.

the more changes we mark as a BREAKING CHANGE, the less likely people are to update.

I don't see how some of those are even breaking, namely the shared libraries and Ubuntu version. But perhaps the newspost will clarify things.
It's a bit of a monster of an update. Ideally we'd release more frequent, smaller updates so that bugs can be fixed in a reasonable timeframe (for those not using snapshot builds) and there's less risk for things to go wrong when incrementing a project's libGDX version. Don't know if it's too late to split the merged changes into 1.10.1 and 1.11.0?

This shouldn't be merged imo. The parent(s) of an XML element are part of
its identity.
On Fri, Feb 4, 2022, 07:20 Frosty-J @.***> wrote:

the more changes we mark as a BREAKING CHANGE, the less likely people are
to update.
I don't see how some of those are even breaking, namely the shared
libraries and Ubuntu version. But perhaps the newspost will clarify things.
It's a bit of a monster of an update. Ideally we'd release more frequent,
smaller updates so that bugs can be fixed in a reasonable timeframe (for
those not using snapshot builds) and there's less risk for things to go
wrong when incrementing a project's libGDX version. Don't know if it's too
late to split the merged changes into 1.10.1 and 1.11.0?
—
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/pull/6789#issuecomment-1029693130, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5QBGFEBAUEX2V7KHDADDUZNV2RANCNFSM5NQM6UKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This shouldn't be merged imo. The parent(s) of an XML element are part of its identity.
…
On Fri, Feb 4, 2022, 07:20 Frosty-J @.> wrote: the more changes we mark as a BREAKING CHANGE, the less likely people are to update. I don't see how some of those are even breaking, namely the shared libraries and Ubuntu version. But perhaps the newspost will clarify things. It's a bit of a monster of an update. Ideally we'd release more frequent, smaller updates so that bugs can be fixed in a reasonable timeframe (for those not using snapshot builds) and there's less risk for things to go wrong when incrementing a project's libGDX version. Don't know if it's too late to split the merged changes into 1.10.1 and 1.11.0? — Reply to this email directly, view it on GitHub <#6789 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD5QBGFEBAUEX2V7KHDADDUZNV2RANCNFSM5NQM6UKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.>

Technically no, the parent doesn't affect referential identity, but the parent(s) are part of its value though. If the parent information can be changed for an XML element, that won't change its identity, but will change its value. Without this PR, we still use referential identity for equality and hashing. With this PR, we use some of the value in equality and hashing, but not parents. I don't know how this should consider parents if there could be infinite loops.

You're right, technically. However, the referential identity is kinda
simulating taking parents into account, as two elements with the same
value(s) will still be distinct, as they are independently instantiated
during parsing the tree of elements.
On Fri, Feb 4, 2022, 09:12 Tommy Ettinger @.***> wrote:

This shouldn't be merged imo. The parent(s) of an XML element are part of
its identity.
… <#m_-8549830950298928347_>
On Fri, Feb 4, 2022, 07:20 Frosty-J @.> wrote: the more changes we
mark as a BREAKING CHANGE, the less likely people are to update. I don't
see how some of those are even breaking, namely the shared libraries and
Ubuntu version. But perhaps the newspost will clarify things. It's a bit of
a monster of an update. Ideally we'd release more frequent, smaller updates
so that bugs can be fixed in a reasonable timeframe (for those not using
snapshot builds) and there's less risk for things to go wrong when
incrementing a project's libGDX version. Don't know if it's too late to
split the merged changes into 1.10.1 and 1.11.0? — Reply to this email
directly, view it on GitHub <#6789 (comment)
https://github.com/libgdx/libgdx/pull/6789#issuecomment-1029693130>, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5QBGFEBAUEX2V7KHDADDUZNV2RANCNFSM5NQM6UKA
https://github.com/notifications/unsubscribe-auth/AAD5QBGFEBAUEX2V7KHDADDUZNV2RANCNFSM5NQM6UKA
. Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.>
Technically no, the parent doesn't affect referential identity, but the
parent(s) are part of its value though. If the parent information can be
changed for an XML element, that won't change its identity, but will change
its value. Without this PR, we still use referential identity for equality
and hashing. With this PR, we use some of the value in equality and
hashing, but not parents. I don't know how this should consider parents if
there could be infinite loops.
—
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/pull/6789#issuecomment-1029746300, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5QBCKXANLYZSDQGRDZUTUZODAVANCNFSM5NQM6UKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

So with the goal of this being for unit testing, how should we support comparing XML elements for equality? Note that two Strings, "dog" and "dog" compare as equal regardless of what collections contain them.

For unit testing, i suggest the use of comparators that live outside the
XML element class.
On Fri, Feb 4, 2022, 09:23 Tommy Ettinger @.***> wrote:

So with the goal of this being for unit testing, how should we support
comparing XML elements for equality? Note that two Strings, "dog" and "dog"
compare as equal regardless of what collections contain them.
—
Reply to this email directly, view it on GitHub
https://github.com/libgdx/libgdx/pull/6789#issuecomment-1029752863, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAD5QBHAS44AQLULLVSHKEDUZOEIFANCNFSM5NQM6UKA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you commented.Message ID:
@.***>

Yeah, that's perfectly reasonable. All of the relevant variables are accessible through getters, except for the actual Array of children (and since the count of children can be obtained and individual children accessed, that should be fine). That should make an external equals() possible, and though it isn't as easy to change hashCode(), that shouldn't be required for unit tests. I'm fine with closing this now.

It's a breaking change because 2 similar elements are no longer considered different which could break some user code when used in Set, Map and such.

I also want to point out that the more changes we mark as a BREAKING CHANGE, the less likely people are to update.
That's why we should avoid them as much as possible.

Also, this change bring some complexity: Comparing deep XML trees in a sorting algorithm could have significant impacts.
I agree with badlogic, you can always use an external comparator for some use case.
@tommyettinger for the diamond operator, we don't have it for other classes and it doesn't bring any value but some noise. I won't fight against that though :-)

You guys are right, I agree. Trying to remove my approval.

I disagree with taking the parent in account.
For example with those XMLs:
XML1:
<a>
    <b Blub="ha">
        <c/>
    </b>
</a>

XML2:
<d>
    <b Blub="ha">
        <c/>
    </b>
</d>

Both b-elements can be replaced without changing anything at the behavior/value. So both b-elements are equal and the equals-methods should return true.
I understand that the reference to the parent might be wrong when substituted with the other object. But I would say that the parent variable in the class is wrong rather then this code. Maybe we can set the parent in addChild so we maintain the correct reference?

In a pom.xml file, to use Maven as an example, the parent does change the semantics of a child -- you can have <exclude> tags in various places, all of which could mean different things depending on their parent. This only occurred to me just now, but it might be a serious issue when comparing XML Elements for equality.

Actually, I would have needed this change till yesterday for the submission of my groups' university project, so I really don't care if it gets merged even if I think it's still a valid change

I'll close this for now, the PR is on a libGDX repo branch, there's been strong oppostion and OP has not an special need anymore for it. If you still think it's an important change please create a new PR from a personal repo branch.


Drop stalled timeseries tails

This PR
This PR addresses https://trello.com/c/UKy1yEtd/664-hhs-test-positivity-handle-bad-data-in-recent-days-better and https://trello.com/c/W96ocnI5/663-daily-new-cases-handle-anomalous-trailing-zeros-better and is a first basic attempt at https://trello.com/c/Cq2zNk2M/674-annotate-data-outliers-that-weve-flagged-in-the-ui

Adds class TailFilter which looks for and removes suspiciously low recent values of a cumulative timeseries.
Adds AnnotationField and AnnotationType as a way to tag a particular location, variable, date as a place where the data was modified.
Uses the above to filter the cumulative timeseries put in combined datasets
Writes the annotations to a new CSV during data update
Adds a new command run-bad-tails-filter for testing the filter.

Tested
Checked out the data from ~Dec 8 where TN and VA were broken, than used run-bad-tails-filter to check what the filter would have done. It looks like the stalled values would have been removed. The other changes I saw when skimming through the diff looked reasonable.
git checkout 04885f796deebab7cc6ed1e607a080d4483bff6a -- data/multiregion.csv data/multiregion-wide-dates.csv data/multiregion-static.csv data/multiregion-provenance.csv
./run.py data run-bad-tails-filter data/multiregion-wide-dates-bad-tails-filter.csv
vimdiff data/multiregion-wide-dates.csv data/multiregion-wide-dates-bad-tails-filter.csv

 HHS Test Positivity: Handle bad data in recent days better.

One small point that we can 100% change later is it might be helpful to separate the annotations out to 1 per day - thinking about how we would display this data on a chart and daily seems more reasonable.  But I don't think we should change the current implementation, something to think about for the future

 Daily New Cases: Handle anomalous trailing zeros better.


enhancesupport SHOW-TRANSACTION

Proposed changes
Issue Number: close #xxx
now only support eg：
SHOW TRANSACTION WHERE ID=xxxxx；
SHOW TRANSACTION WHERE LABEL = 'xxxxx';

run buildall

run buildall

run buildall

run buildall


Drop DebugCommand const

The service and job Debug feature is removed from the operators in favor of using oc debug directly.
Implements: OSPRH-4290

Keeping it draft until the service operator changes are removed


Error while parsing copybook definition: PIC 9(15)+.

I hit a copybook with the following definition: PIC 9(15)+.
The copybook parser is not able to handle it. What isthe meaning of the + in this case ?

Thanks for the interest. The '+' symbol looks like an explicit sign position. We currently don't support it since we don't have an example copybook and mainframe file that contains it.
It is likely an equivalent to PIC 9(15) SIGN TRAILING SEPARATE. but I'm not 100% sure. If you can confirm that that is the case we can add support for such PICs in the future versions.
If '+' means something else, we need an example copybook + data file to add support for this.

I will find out the exact meaning and let you know. Thanks
On Fri, 21 Dec 2018, 20:37 Ruslan Yushchenko<EMAIL_ADDRESS>wrote:

Thanks for the interest. The '+' symbol looks like an explicit sign
position. We currently don't support it since we don't have an example
copybook and mainframe file that contains it.
It is likely an equivalent to PIC 9(15) SIGN TRAILING SEPARATE. but I'm
not 100% sure. If you can confirm that that is the case we can add support
for such PICs in the future versions.
If '+' means something else, we need an example copybook + data file to
add support for this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AbsaOSS/cobrix/issues/23#issuecomment-449378056, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AApX61UXcAGKo3WB5KZXBihpTePKOO-Nks5u7NX4gaJpZM4ZdXz8
.

9(15)+ basically means that, in addition to the 15 numeric characters the last character is the sign, which can be + or -.
For example 9(3)+ is a valid picture for a value 345-

Great, Thanks for the confirmation. So 9(15)+ is the same as PIC S9(15) SIGN TRAILING SEPARATE and it can be used as a workaround for now. In the meantime we are going to add the support for the '+' sign in the next release.


Changed ES dependency to 1.7.5 to get it working with ES 1.5+

In ES 1.5, org.elasticsearch.indices.IndicesService was changed from an interface to a class.
Compiling the plugin with ES 1.7.5 fixes this issue.
This should fix #2

LGTM :+1:


Add all PowerToys shortcut keys to Shortcut Guide

Description of the new feature / enhancement
While shortcut guide is definitely handy to remind me of the inbuilt Windows shortcuts, the ones that are far more valuable are the ones for PowerToys. It seems a little crazy that PowerToys shortcuts aren't included, as I far more often need to recall, for example, what keys do what with FancyZones, which I use constantly, as opposed to needing the quick switch panel to connect to a projector, which I've never used not even one time in my entire life.
Scenario when this would be used?
Every time I can't remember a key, I hit the Win+Shift+/ shortcut and I see the Windows shortcuts, but also, perhaps tabbed by application, the shortcut keys for each of the PowerToys. Also, it remembers the last tab I used next time I open it.
Supporting information
No response

/dup #15405


[Bug] [RaySerivce] Missing readiness and liveness probe causes 5xx error

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
Others
What happened + What you expected to happen
When the Service Operator update a new Ray Cluster. It should install necessary livenessProbe and readinessProbe targeting specifically to Ray Serve.

Check the HTTP Proxy has been properly started on each node (by calling localhost:8000/-/healthz) as part of readiness probe.
Check the application is ready to be served (as part of readiness probe) (by calling Serve's status API, waiting to application to be running)
Check the application is healthy via status API (as part of liveness probe).

Two more considerations:

Should we also health check Ray and GCS health as part of this. As context, the Ray cluster operator will fill in the following probes if there is non specified:

https://github.com/ray-project/kuberay/blob/5e862beebbd5a85c9a84eb44db2bdac5b5b48723/ray-operator/controllers/ray/common/pod.go#L226-L270

Should we add some helper method in the CLI for this?

The impact of this fix will help reduce the 500s error during startup because it will then make sure only to route traffic to pod when it is ready to accept traffic; rather than suffering from several layers latency of Python startup, Ray startup, and actor startup.
Reproduction script
...
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

is there any specific reason why we use Exec with Wget instead of the HTTPGet in the probe?
type ProbeHandler struct {
	// Exec specifies the action to take.
	// +optional
	Exec *[ExecAction](https://pkg.go.dev/k8s.io/kubernetes/pkg/apis/core#ExecAction)
	// HTTPGet specifies the http request to perform.
	// +optional
	HTTPGet *[HTTPGetAction](https://pkg.go.dev/k8s.io/kubernetes/pkg/apis/core#HTTPGetAction)
	// TCPSocket specifies an action involving a TCP port.
	// +optional
	TCPSocket *[TCPSocketAction](https://pkg.go.dev/k8s.io/kubernetes/pkg/apis/core#TCPSocketAction)

	// GRPC specifies an action involving a GRPC port.
	// This is a beta field and requires enabling GRPCContainerProbe feature gate.
	// +featureGate=GRPCContainerProbe
	// +optional
	GRPC *[GRPCAction](https://pkg.go.dev/k8s.io/kubernetes/pkg/apis/core#GRPCAction)
}

https://pkg.go.dev/k8s.io/kubernetes/pkg/apis/core#ProbeHandler

I think the reason might be httpGet doesn't cover multiple endpoints.

Yeah, that should be feasible. I can take it.

@shrekris-anyscale Is this issue resolved? Thanks!

Hi @kevin85421 the bug that motivated this suggestion is resolved by #730. However, #730 doesn't use liveness and readiness probes, which design-wise would be a better solution. There's no straightforward ways to check for RayService health in the probes at the moment, but I think we should leave this ticket open to track the issue. I've reclassified this from a P1 to a P2.


Light miner: Remove dbus container

upnp removal: https://github.com/NebraLtd/hm-diag/issues/322
Acceptance criteria

dbus container removed from helium-miner-software

@shawaj can you explain exactly why we no longer need session dbus? I understand why we don't need upnp.

Because this doesn't communicate over dbus and never will.
It uses gRPC for communicating with gateway config

Thanks. My doubt is because dbus is still used for Bluetooth pairing in config and ModemManager in diag. Couldn't remember if they also depended on the dbus container.

@marvinmarnold I believe they are using the system bus from the host OS but certainly worth verifying that


Global Menu Bar on KDE has Stopped Working

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.68.1
OS Version: Kubuntu 22.04

I have tried installing libdbusmenu-glib4 as suggest here, but it just causes the menu to disappear entirely.
Steps to Reproduce:

Launch VS Code
The menu bar appears in the window rather than in the global menu bar

Expected results: the menu bar appears as expected (screenshot of app where behaviour is correct:

Actual results:

This issue is still present in VS Code 1.69

And in VS Code 1.69.2

Are you using wayland ?

At the time, I believe I was using X11. Currently am using Gnome due to some unrelated issues, so I can't check on later versions of VS Code. Will try again when connecting a display doesn't delete my desktop layout and let you know then.

Hey @deepak1556, this issue might need further attention.
@MiguelGuthridge, you can help us out by closing this issue if the problem no longer exists, or adding more information.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


CI: skip building dependabot branches, we already build PRs

If we skip the test job for dependabot on branch merge, should we also skip  test-bin-compat & test-windows for the same situation/reason?


fix: SQL injection

Feature or Bugfix

Bugfix

Detail

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: feee7f14ee1c1de15736660f7e8e12548b1ae4c6
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


IN() with complex expressions

Allows IN() to uses Complex Expression Lists including multiple SubSelects
Simplifies the IN() Statement by removing the Multi Expression List property
Fixes #905

Please resolve conflicts.


Remove the "Widths" section from the OuiModal docs

In https://oui.opensearch.org/1.0/#/layout/modal, we have a section about how to manually specify widths via inline styles. This seems like a bit of an antipattern, and not something we want to encourage. See https://github.com/opensearch-project/oui/issues/783 for examples where we do customize modal widths today.
If we do want to allow direct sizing controls, we probably want to add more props. Otherwise, I think we should just scratch the section altogether.

I agree that we should remove this guidance - it does not align with the Design System directive to rely on the responsive system as much as possible out of the box.

@joshuarrrr @BSFishy can I take this issue?

Yep, looks like this is ready to pick up

Fixed in #1066


Apply proposed fixes from the issue list

Please have a look at each commit message for what is included.

@artf
Can you please look at it and merge it.
For me the code looks good.

for easier review/merge this should probably be split into several PRs, I cherry picked one commit from this PR into https://github.com/artf/grapesjs-mjml/pull/171

closing this due to inactivity, please let me know if you still want to work on this


Optimisation for PassiveTreeView: cache the search results.

Simple but effective optimisation for the PassiveTreeView, caching the search results saves several thousand calls of string.match() which were quite expensive.
Storing the previous string used isn't the neatest solution but I think it's the most error resistant. Alternatives include:

A boolean searchStrNeedsChecking, which requires the anyone who sets searchStr to set that too.
The same flag with a SetSearchStr(str) function to set it for you, but you'd still need to remember to call the setter instead of setting it directly (Lua doesn't do private variables).
Use the function above and iterate over the nodes in that function rather than doing it later, which risks multiple calls in the same frame causing spikes, and you'd probably still have to store the string somewhere so you can save/load it so it has the same problem as the above.

Attempt 2: Now with more dev and less commits!

Alright, this looks better. Unfortunately though, there's a major issue with the code itself: you're storing the match flags within the current spec, but the mapping of PassiveTreeView instances to PassiveSpec instances isn't 1:1, as the main PassiveTreeView instance used in the Tree tab can display different passive specs (in the case of multiple passive trees in one build), and multiple PassiveTreeView instances can display the current spec (as both the Items and Calcs tab do when displaying node locations).
So the match flags will need to be stored in a dedicated table within the PassiveTreeView. Otherwise though, the code looks fine, so if you can fix that then maybe it can be third time lucky!

That's fair.  Although... does that mean each tree within a build has it's own set of references to the same base tree data (like node names)?
Anyway, I've changed my code as you suggest (having the cached results right next to the cached string is tidy), but I see I'm now a few commits behind your repository.  Will I have to merge (probably the wrong word for Git) your commits onto my fork before I make another pull request?  I'd rather not risk my repo by messing up an unnecessary merge.  I can easily make the changes again in a fresh fork if I mess it up, but it'd be nice to keep the history.  Your PassiveTreeView.lua hasn't changed so there'll be no traditional merge conflicts.
Thanks for putting up with a git newbie!

As always when doing stuff with git you are not confident enough with: make a copy of the directory.
Then you should follow GitHub Standard Fork & Pull Request Workflow. The section about rebasing should be the thing you are looking for.


[BUG]: Inconsistent metadata overrides (master issue)

Purpose:
One of the current, most notable issues with Winston today is the how we handle the application of default metadata for a given instance of a logger. As it stands the current implementation makes some bad assumptions around metadata precedence in different contexts. This issue is being created to consolidate all relevant/duplicate issues & the associated Pull Requests.
Consolidations
Below is a compiled list of all issues and pull requests I have been able to find regarding this issue. They are sorted newest to oldest. All issues below are going to be marked as a duplicate and then closed. This is being done to hopefully centralize all efforts for resolving this issue to this issue moving forward.
Issues:
Potential Regression Issues

These are all the issues that reference 3.7.1 & 3.7.2

Error objects can no longer be logged
#2103
#2144
#2162
#2168

likely can be considered unrelated for time being as it's specific to the SPLAT format

#2306

Need to verify test cases cover this issue

Original Issues:

#1884 (I believe this would be a departure from currently documented behavior)
#1864
#1788
#1759
#1665
#1596
#1054

Pull Requests:

#2037 (Centered around #1626 but also claims to solve metadata override issues)
#1989 (Recreation of my original PR)
#1943
#1935 (Implements a fix for #1665 but in a manner that I feel introduces maintenance burden)
#1885
#1883
#1879
#1875
#1782
#1598 (opened by myself)

Notes
If you're aware of any other Issues or PRs (including those that have been closed) that are not included above please let me know and I'll get them added to the list.

@Maverick1872 I think this one is related as well https://github.com/winstonjs/winston/pull/1935

@Maverick1872 I think this one is related as well https://github.com/winstonjs/winston/pull/1935

It looks to be related but I'm not as familiar with the expected behavior of the profiler functionality. Will look into it though.

Was able to make some progress on this after-hours this week finally. I have a handful of new test cases setup that are expected failures on our current trunk. There's more general cleanup I'd like to do, as well as improving the structure of these tests to further improve their intent & readability. Hopefully I can make this a little easier for others to drop in and further improve the current test coverage, as it's currently in a state that needs some extra love/attention.

@wbt @fearphage @DABH
I've got a set suite of tests built out proving the current issue with our logic for applying metadata, as well as an associated fix that gets all of them to pass. As it stands the only other PR currently (that I'm aware of) that gets my tests to pass is #2037.
That implementation introduces a few things other than a fix for merge inconsistencies. Most notably it introduces a means to add getters for lazy determination of metadata. This is a feature that would honestly be pretty valuable in my opinion to have in future versions of Winston.
But, the implementation does come at a downside (in my opinion) with how it solves the merge issue. Each child that is generated holds on to a reference of the parents metadata. When generating metadata for a given log statement it recursively walks the parent chain to generate the output on the fly. This causes two things; first it's fairly inefficient and adds overhead to every write call which is something we should avoid where possible. But more severely, is that any changes to a parent's metadata will be reflected in any/every child due to the reference that's retained. I intend to add a handful of additional tests to prove out this behavior, both in mine and in #2037.
With that being said I am really interested to know what y'all's thoughts are regarding this.

I'm actually a fan of the "downside". I'm doing exactly that (using getters for child metadata) because I specifically want the functionality of metadata being dynamic. It might not be the best solution at this point but having it as an option in my toolbelt has been extremely useful.

@FoxxMD I wholly understand the value in it, but I believe it to be a breaking change from our current implementation hence it being a "downside" Semi-related to our other discussion is that if we offer first-class support for extending the Logger class this becomes moot as one could just override our default implementation with their own metadata merge logic. Alternatively we could surface the merge logic as a configurable option to continue being backwards compatible while supporting this behavior.
In terms of resolution of the issue at hand, the smallest set of changes, that are non-breaking to our current behavior receives my vote. I'm not partial to any implementation beyond that.

Added the above mentioned tested to my PR and have confirmed my implementation does not allow any modifications to the parent's metadata to propagate to the child, after the child has been created.

This is due to:
<EMAIL_ADDRESS>This processing should not exist and should be done by format if desired.

@wbt re-opening since we reverted and released a patch bump. Should have done this awhile ago. As such I'll be re-opening a PR that includes reverts the revert, and then publish a release candidate that's equivalent to 3.7.1; at that point I'll start iterating again on a fix for the regressions it introduced.

In case someone else runs into this issue and needs a simple workaround, I just use nullish coalescing to provide default and custom output (remove the defaultMeta from your LoggerOptions and use this instead):
const logFormat = format.printf(({ level, message, label, timestamp, ...meta }) => {
    return `${timestamp} [${meta.service ?? "user-service"}] ${level}: ${message}`;
});

Came across the same issue just now. Not a big problem at this time but the inconsistency is irritating.
"env":"development","level":"debug","message":"Example kicked off","service":"scraper-alpha","timestamp":"2024-08-09T09:50:10.341Z"}
{"durationMs":419,"level":"info","message":"adapter","timestamp":"2024-08-09T09:50:10.760Z"}
{"durationMs":1162,"level":"info","message":"adapter","timestamp":"2024-08-09T09:50:11.922Z"}
{"env":"development","level":"info","message":"Example authenticated","service":"scraper-alpha","timestamp":"2024-08-09T09:50:12.014Z"}
{"durationMs":121,"level":"info","message":"screenshot","timestamp":"2024-08-09T09:50:12.043Z"}


Error in getPosSize for parent-child windows, when child moves off-screen while dragging

I am using parent-child connected floating windows, and
found that child-windows that move off the screen give
an error on the getPosSize because
self._window.screen()
gets None when off-screen. I solved if for now with the
following redefinition of the method.
It may not be entirely right in the returned values, but
now it works without errors when dragging the parent window.
to the side of the screen.
Petr
def getPosSize(self):
"""
A tuple of form (left, top, width, height) representing the window's
position and size.
"""
frame = self._window.frame()
if self._window.screen() is not None:
l, t, w, h = _flipFrame(self._window.screen().visibleFrame(), frame)
titlebarHeight = self._calculateTitlebarHeight()
t += titlebarHeight
h -= titlebarHeight
else:
(l, t), (w, h) = frame
return (l, t, w, h)

What exactly do you mean with "off screen"? Can you provide a snippet that produces a window in such a state?

something like this:
it goes wrong on osx level, where the child window disappears when moving between screens
vanilla does it good, so far
please close if this is not an issue anymore (2013 whoewhoe)
import AppKit
import vanilla

def callback(sender):
    print(w.getPosSize())
    print(w2.getPosSize())
    print()

w = vanilla.Window((400, 400))
w.b = vanilla.Button((10, 10, 200, 22), "hit", callback)
w.open()

w2 = vanilla.FloatingWindow((500, 100, 200, 200))
w2.b = vanilla.Button((10, 10, 200, 22), "hit", callback)

w.getNSWindow().addChildWindow_ordered_(w2.getNSWindow(), AppKit.NSWindowBelow)


Added cancel (test fails)

Added cancel.
It seems that in the test stop_token is not propagated from scope.spawn into a coroutine. Did not debug it yet

Closed in favor of https://github.com/GorNishanov/conqueue/pull/3


[music3] add a log file

This PR will be rebased with the others music3 PRs.
Commit: https://github.com/medInria/medInria-public/commit/b0063049d166cee7a73295eae8151125d907b6ab
Fixes https://github.com/Inria-Asclepios/medInria-public/issues/139
Add a log file:

logs are redirect to the console and to the file
possibilities: dtkInfo/etc, qDebug/etc, std::cout/cerr
allow users to send the log file if needed, or to look at it
works with the displayMessageError from https://github.com/medInria/medInria-public/pull/358
add a button on homepage to open the logs: https://github.com/medInria/medInria-public/pull/360 was already adapted to this button

:m:

@Florent2305 i finished my previous work. Did you forget to send me the mail about utf16? (it happens ^^)
I'm going to look at it.

@Florent2305 this new version is working \o/


Missing advanced list properties

Hello,
The latest version of schema lacks some advanced list features:

DefaultItemOpen attribute
NavigateForFormsPages attribute
ExcludeFromOfflineClient attribute
XmlDocuments collection
and probably a bunch of other ones

Some of these attributes are not exposed through CSOM objects, but can be managed through SchemaXml. Implementation in the engine would be quite easy.
Is there a way to add these missing attributes ?

We closed this issue as it had not activity within last 180 days. This is a generic process we have decided to perform for issues, which have not been explicitly marked still to be "work in progress" based on tags. We are performing this cleaning to make sure that old issues that have already been solved (but not closed) or are no longer relevant are cleaned out and make the issues more manageable. If this issue still valid, we would ask you to open a new issue and follow the guidance in the issue template related on the recommended location. We do apologize any inconveniences this might cause. Please do remember that issues in the issue lists are also messages for others in the community, so you can also check if you can assist on any of them. “Sharing is caring!”


Migrate pipeline from VMWare to Community Concourse

Description
Once the community Concourse has been setup, let's move the necessary pipelines over. This includes retrieving the necessary credentials form VMWare.
Questions

So far there are AWS S3 blobstores used for several artifacts. Would it make sense to use instead GCS blobstores instead where possible?
Would we need a new repository for this?

Context

a rough overview of the assets has been collected in https://docs.google.com/document/d/1846mRZ1X-Z5mv0ayHykp2N7B7aT1fujEGV-ntuVxO98

ToDo

[x]  fix usn log resource
[ ]  investigate ami push access to aws gov region
[ ] setup publish pipeline
[ ] ..

PRs
Acceptance Criteria

the pipelines are capable to release candidates for:

AliCloud, AWS, Azure, GCP, OpenStack, vSphere, vCloud heavy stemcells
AWS, GCP light stemcells

i thought they used a different account for that.
but i think you can request it just for your account

First stemcell has been successfully released from the community owned  pipeline - 1.10 version. Closing this ticket.

@ramonskie From this issue I cannot discover what work has been done and what changes have been made. Can you complete the todo list and link to relevant changes/repos?

the PR https://github.com/cloudfoundry/bosh-stemcells-ci/pull/4


Texture Requests

I thought it would make sense to keep track of what textures we could use, in order of importance:
emphasized = with tool materials (wood, stone, iron, gold, diamond)
Javelin
Musket
Knife
Musket with Bajonet (Knife)
Blunderbuss
Blowgun + (different?) Darts

Looks cool! It'd be very cool, if you could provide those in copper, tin and silver, too :D (I am working on the OreDictionary-Things right now ^^)

Nananana, let him handle the list. Suncore can do the material stuff. :P

Ok, then forget my comment :P

I'll work on tin and silver tomorrow. I just managed to get my sleep on track, and there are a few other things I need to work on.

And that should be everything on this list.

I did not really recognize the Javelin (looks more like a shovel on first site o.O ), but the rest look great. Thanks you!

Yeah I can see that...

I tried to base this one off of Olympic throwing javelins. Tell me what you think.

First of all, I think it does not make sense to keep the Javelin at 16 Pixels, while all other pole weapons are 32.
16 Pixel just does not look good for items longer than a sword.
Besides, MAYBE we could go into the Roman direction (or maybe make that a stronger version?)
https://duckduckgo.com/?t=lm&q=pilum&iax=1&ia=images
If we stay 'primitive', maybe make the tip look more like a flint, since that was in the crafting recipe, maybe just a little thinner.

Okay, I made the tip look like flint and it's 32x32 now.

One looks the most refined and three looks the most primitive. Take your pick.

Thanks.
It is too much to ask for a grip, once we decided on one?^^

Not at all.

Yeah, something like that. I'm trying to recall what the javelins in our sports classes looked like...I think it's more or less in the middle of the shaft.
But..hmyeah...I guess I'll try what the look like ingame and then decide...I mean, if you're using layers it might not be much work to do the grip for all three versions, but I do not want to give you unnecessary work.^^

I googled modern javelins, yes it is in the middle of the shaft. Also, how long do you think it takes to make textures? xD... It doesn't take long for me anyway... I made all the gun textures in like an hour with frequent breaks to check on things.

Done.

Well, I still do not want anyone to waste time on things we throw away, which will be one out of thhose three textures.^^
Anyway...I guess we did not have a final Katana version so far?

Uuurhg... I don't even know with the Katana anymore... Honestly, it would probably be better if we just used a 16x16 one... It's impossible to make a good Katana curve  with 32x32...
Here, I drew up a 16x16 one for example purposes...

I can change it to your liking.

Well, I still liked most of those better than this not-katana-formed 16*16 thing^^
But I know your struggle...hmmm...I'll go through what you've sent me so far and see what looks the least bad ingame.^^

#74 Could you help us? ^^

Could you try to do a Katana-Texture again? I coded them and I don't wanna steal Balkon's Textures for them...

Ok. Silvercatcher just sent me the other Katana-textures: http://imgur.com/a/XqJN4
If you can: I would like to have the second texture, but not so bent. Could you manage to do this?

Like that?

Yeah, looks nice! Could you do the Wood, Stone etc. textures of it?

That should be all of them.

Thank you!
A brass variant of blunderbuss is a good idea. But I think, that we should add this in the "Integration update", because steel and brass are features of other mods.

That's exactly what I meant by it. :P

Can we get a normal crossbow and a really big one? I have things to break. ;)
I mean, I can do the scaling...it should just look heavy.

Tell me what you think.

What sabre texture is that in the latest version?

About the crossbows: looks good, but I realize I have to find out how to switch between textures when loading.
And whatever is in this folder: https://github.com/TheOnlySilverClaw/Reforged/tree/master/resources/assets/reforged/textures/items is currently in use.

Hi again ^^
I would have a new texture request: I would need a Keris (It would be cool, if its texture is based on this one).
P.S.: There is no need to hurry. I just need it until the 0.7-preversions release.

Sounds good! This one looks like it's made out of Damascus steel. Would it need to be in all the different materials?

Hmmm... I think it would be enough to have one out of - I think - Iron?
But it would be cool, if it is a little bit darker iron (Good to know, that the one in the picture is made out of Damascus Steel: The Integration Update is getting bigger and bigger ^^).
I forgot: I would need a simple texture for the "Gold-Rod" (A stick crafted out of 2 Gold ingots, used to craft the Keris). Thank you! ^^

Should I make the handle gold colored?

According to the crafting recipe: Yeah, would be a good thought ^^

I made a few test versions cause making curves like that aren't the easiest things, tell me what you think and what I should improve on.

Errr...I was thinking of making it golden, since that's the most enchantable material in Minecraft. And yes, a good crafting recipe might be tricky to find but I'm not sure if making an extra item for that is the best solution.

@TheOnlySilverClaw But if it's all golden, the crafting recipe (which I want as iron / in the integration update the iron wil be replaced with steel) has to be out of gold...
@SnowballFlame I like the 4th texture ^^ I will add it for now. If the crafting recipe gets changed, I will contact you again and ask for another color :D

Sooo... I will have my Swedish exam on Tuesday and can hopefully finish the Necromancer's Staff next week. I'm not actually sure how to make it look, though...
Maybe the staff could be made out of obsidian, the tip could be an undead mob's head... depending on how rare the staff should be.
Any suggestions?

And I had my stage play yesterday and 2 days ago. I have more time now again ^^

I tried to make a Necromancer's staff. What do you think?

The idea of the texture is genious!
I don't know, if it looks better then, but I think, if the head is a little bit brighter, it would look better. But I don't know.

I'm not sure about the mob heads as a tip, but well...if you really want it, maybe make them a separate layer, so we can make it look a little 3-dimensional.

https://github.com/TheOnlySilverClaw/Reforged---Cross-and-Grave/tree/master/java/org/silvercatcher/reforged_cag
So, I decided to put the crosses and necromancer staffs into a side project, so I can release them as a standalone mod for now.
I came to the conclusion that I could use three different textures for both items. I'm still not sure about the staffs, but the crosses could make do with the following changes:

wooden cross with gold centre
golden cross with diamond centre
diamond cross with emerald centre
And maybe make the centres their own layer, so they can stand out a little.

So, I ended up doing my own textures for now. I like the crosses a little thinner, but maybe something between our versions would be nice. If you have the time, feel free to give them a final retouch, otherwise we will have to live with these:

Hi, I would need a texture for a Caltrop.
I thought of something like this: https://upload.wikimedia.org/wikipedia/commons/1/1e/Caltrop.jpg
Is this possible? ^^

Whoops, clicked the wrong button just there.

No problem ^^ And thanks for the texture: It fits the entity one's perfectly!
If you have enough time, could you make a texture for dynamite, too?
I don't wanna steal Balkon's one ^^

Hello again,
I would need a Dynamite texture (Right now we use Balkon's one...) ^^
And I am asking, if you could make some more crossbow-textures. I want to animate the crossbow a little bit, while reloading. I took those textures by you for now:

Is it possible, that you make like 2 or 3 "stages between the 2"?
That would be awesome :)

Sorry it's late, I've been busy lately. I'll do the crossbow textures soon.

No problem and thanks for the Dynamite ^^

Use these instead, I noticed some things that were wrong with the old crossbows so

Wow, awesome! Thanks!
I think, that I just found out how I can animate them like I want ^^
1 Request again XD
Could you make the last one without an arrow, too? Then I could let it look like the player would lay it on the crossbow.

Nice! That should be everything needed for the crossbow. Thank you!

Hi @SnowballFlame
I am working again on the mod and I would need a texture for a pike (will be crafted out of iron, no other materials).
Are you able to make one?

Yeah, but I'd need to know how you want them to look.
Pikes in real life closely resemble a spear.

Thanks!
The tip should look like this one: http://www.weapons-universe.com/Swords/Polearms.jpg (The one on the very right)
The stick should look like this: http://vignette2.wikia.nocookie.net/thesaoproject/images/0/0d/Pike.jpg/revision/latest?cb=20131210064930

What do you think?

They look perfect, I will include them.
Thanks!

Hi again ^^
Could you make a Mace texture in all 5 materials?
It should look like this:

Sorry it took so long, the past few days have been busy.
What do you think?

No problem, they look pretty good so far.
Could you make a 32x32-version of them?
Maybe they will be recognized even better then :)

Sorry, I'll do it as soon as I can. I've been a little busy lately...

No problem, just take your time. I am very busy at the moment, too

Finally got to making them. What are your thoughts?

They look good, I will include them, when I'm back from Italy

Misclick, sry

Ok, now I have more time working on Reforged, could you make some textures for Dirks (something like this in all materials: ![http://www.sea-thieves.com/education_pages/education_photos/weapons_rn-dirk.gif])?
That would be great :)

How are these?

They look good, thanks! :)

I've been keeping up silently with the updates recently. Just thought I'd let you know, I'm still here if you need anymore work done.

He's on CurseForge, try messaging him there. I tried to show him something that might allow him to fix some of the strangeness with some weapons and what not, but he has not shown up.
You could look at Baykok's bow in Totemic for seeing how to apply any changes to the ranged weaponry, as well. https://github.com/TeamTotemic/Totemic/blob/9ef2837bd6296003bd8b9cf855c8c91b9438fcaa/src/main/resources/assets/totemic/models/item/baykok_bow.json

After bug fixing, I will need you, SnowballFlame ;)
I've read your comment and thought, I would have replied to it. Strange. Well, I will definetly use that in the next update ;) Thank you!

Okay, I'm here again. Pushed out a new update yesterday. I now want to start working on the 0.8-update.
A Cannon, Flail (Wood - Diamond), Halberd (Wood - Diamond) and Warhammer (Wood - Diamond) is planned.
A popular German YouTuber contacted me in the mean time and wanted to know, when the cannon would be ready. I think, that I might start with the cannon to give him a exclusive pre-release (he needs it for a project with many other popular German YouTubers).
So, I would need textures for all of those. The Cannon will need 2 textures. One for the item and one for the entity (which will get pretty complicated to make). I will send you a UV-Texture with all of the sides marked on it, so you can texture it the right way.
Just tell me, when you are ready and thank you in advance ^^

Yeah, I've textured models before, shouldn't be too complex.
Anyway, I'm ready, send it when you can.

Perfect, thank you ^^

Flails:

Halberds:

War hammers:

Sorry it took me a month, forgot for a few weeks, then had to find the time.
Tell me what you think.

No problem :) They look great!
The thing with the cannon: Right now I just re-modeled the cannon by BalkondeurAlpha (I looked at his model and then did it myself). But I want to have it look different. I need some time to think about a new model... When I'm finished with that, I will contact you again


Description of consent is contradictory

The docs say both that admin consent is required, and that the admin can't consent instead the users have to do so individually. We should clarify this seemingly contradictory statement.
The note also says that admin needs to allow users to consent in AAD. That seems wrong-- consenting to the app upgrade is not related to users being able to consent to AAD permissions.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 307f3f54-bd2e-2b85-91fd-35c3cce97e8b
Version Independent ID: a9ec4bbb-64d7-718c-f585-cc496300123f
Content: Apps update experience in Microsoft Teams - Microsoft Teams
Content Source: Teams/apps-update-experience.md
Service: msteams
Sub-service: teams-apps
GitHub Login: @ashishguptaiitb
Microsoft Alias: guptaashish

Hello @aosolis Adrian, how are you?
I am working on this one.

Hi Andres and Adrian, please see the updated doc at https://learn.microsoft.com/en-us/microsoftteams/apps-update-experience for the bug fix. I'm closing this issue.
Thank you @get-itips , @aosolis , @scanum .


Feature: Add version information, links, etc. at the bottom of the settings flyout

Fixed by 1106ca5 commit


Gamepads::register and deregister methods should be public

What problem does this solve or what need does it fill?
Gamepad registration and deregistration methods are not pub, making it challenging to write realistic external unit tests for libraries that extend the input methods.
In addition, this makes alternative approaches to gamepad management
A full app can be generated, and then
What solution would you like?
Make register and deregister methods on Gamepads resource pub.
What alternative(s) have you considered?

Use workaround methods that assume a fixed gamepad ID, and test those. This is limiting and flaky.
Make the entire HashSet field public. This is less clear, and more limiting in the future.
Create a public method on Gamepads to handle gamepad events, and use that in gamepad_connection_system. This is less direct and clear, and more of a nuisance when testing.

Can I pick this up? Seems straight forward and a nice chance to poke around the input crate

@BlondeBurrito absolutely. Link back to this issue when you open a PR.

I don't think this is the right direction to take this. The state of Gamepads is automatically managed by  gamepad_connection_system. The point of the Gamepads collection is to contain the exact list of "actually connected" gamepads. Public register and deregister methods make it possible for app developers (or plugin developers) to invalidate that promise. "Making external unit testing easier" isn't a good enough reason to expose internals. And alternative gamepad management solutions can build their own apis that feed off of Gamepad events.


Just want everyone to know: THIS LIBRARY STILL WORKS GREAT!

I used it with an ESP32 and DHT22 and it works wonders!  Much easier to use than the Adafruit library.

#23

Actually, nevermind, this library has been forked to have better ESP32 support, and that fork can be found on github or on platformIO/arduino IDE under the name DHTesp


Update observability tutorial link

Signed-off-by: Nick Greenfield<EMAIL_ADDRESS>Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation

Several more links were broken @greenie-msft. I snuck those into another PR from dependabot which I merged :)


TypeError: Failed to fetch dynamically imported module

Hi, @revolist .
I am trying to use revogrid-column-date with vite&vue3. When running in dev mode, and click the date cell ,I am getting the error:
TypeError: Failed to fetch dynamically imported module: https://y0g9y3-3001.sse.codesandbox.io/node_modules/.vite/deps/duet-date-picker.entry.js

Does anyone know how to fix it?
thanks.

codesandbox: https://codesandbox.io/s/prod-violet-y0g9y3

@JavaZWT did you get the solution of this problem. i am also facing the same issue in vite vue project on revogrid-column-date.

@JavaZWT @revolist did you get the solution of this problem. i am also facing the same issue in vite vue project on revogrid-column-date.

I didn't use this component again，and I use Element DatePicker + Revolist vue3-datagrid VGridVueTemplate to define my own component. And you can define your own date-picker template, too

@JavaZWT may you send the code , so that i took some idea .....Also just want to confirm from your idea is it will work for any type of input editor, i mean i have to make a column having dropdown option.

I created demo on sandbox, you can refer to it.
https://codesandbox.io/p/sandbox/revogrid-vite-forked-kb8m7t?file=%2Fsrc%2FApp.vue
The important is  column.editor = YourTemplate

@JavaZWT I am also facing a similar issue, do you have any solutions?

Should be working in the v4+
Update to the latest version of the date picker


Automatically exclude incomplete dates ariaAOIassist

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- tools/bin/ariaAOIassist.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- tools/bin/ariaAOIassist.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tools/bin/ariaAOIassist.py  1

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tools/bin/ariaAOIassist.py  1

See the complete overview on Codacy


chore(deps): update all non-major dependencies docker tags

This PR contains the following updates:

Package
Type
Update
Change

alpine
final
minor
3.13.5 -> 3.15.0

coverallsapp/github-action
action
patch
v1.1.2 -> 1.1.3

github.com/AlecAivazis/survey/v2
require
minor
v2.2.9 -> v2.3.2

github.com/clok/cdocs
require
minor
v1.1.2 -> v1.2.0

github.com/google/go-github/v35
require
minor
v35.0.0 -> v35.3.0

gopkg.in/yaml.v2
require
minor
v2.2.3 -> v2.4.0

Release Notes

coverallsapp/github-action
v1.1.3
Compare Source
Added:

feat: add addition override parameters (@mad-it)

Security improvements:

Dependabot PRs

AlecAivazis/survey
v2.3.2
Compare Source
v2.3.1
Compare Source
v2.3.0
Compare Source
v2.2.16
Compare Source
v2.2.15
Compare Source
v2.2.14
Compare Source
v2.2.13
Compare Source
v2.2.12
Compare Source
v2.2.11
Compare Source
v2.2.10
Compare Source

clok/cdocs
v1.2.0
Compare Source
Features

options: add support for Hidden help message for install-manpage command

google/go-github
v35.3.0
Compare Source
This release contains the following changes since v35.2.0:

Add missing fields to Star event (#1869) …
Support map type in go generate (#1867) …
Add support for the list failed organization invitations feature (#1871) …
Change all *map to map in JSON structs (#1870) …
Fix typo in repos.go (#1873)
fix: Updated comparisons in test files (#1875) …
compare decoded go struct for request body (#1876)
Add missing installation permissions (#1880) …

v35.2.0
Compare Source
This release contains the following changes since v35.1.0:

https://github.com/google/go-github/pull/1858
https://github.com/google/go-github/pull/1860
https://github.com/google/go-github/pull/1862
https://github.com/google/go-github/pull/1864

v35.1.0
Compare Source
This release contains the following changes since v35.0.0:

https://github.com/google/go-github/pull/1853
https://github.com/google/go-github/pull/1854
https://github.com/google/go-github/pull/1856
https://github.com/google/go-github/commit/94d2fbbfba4de5018c7b19da5bc99aa1e9769f2c
https://github.com/google/go-github/pull/1857

go-yaml/yaml
v2.4.0
Compare Source
v2.3.0
Compare Source
v2.2.8
Compare Source
v2.2.7
Compare Source
v2.2.6
Compare Source
v2.2.5
Compare Source
v2.2.4
Compare Source

Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: go.sum
Command failed: docker run --rm --name=renovate_go --label=renovate_child -v "/var/folders/bf/90yzq4vn42s2163sp1g5d0n80000gn/T/renovate/repos/github/renovate-testing/test-9748-ghlabels":"/var/folders/bf/90yzq4vn42s2163sp1g5d0n80000gn/T/renovate/repos/github/renovate-testing/test-9748-ghlabels" -v "/var/folders/bf/90yzq4vn42s2163sp1g5d0n80000gn/T/renovate/cache":"/var/folders/bf/90yzq4vn42s2163sp1g5d0n80000gn/T/renovate/cache" -e GOPATH -e GOFLAGS -e CGO_ENABLED -e GIT_CONFIG_KEY_0 -e GIT_CONFIG_VALUE_0 -e GIT_CONFIG_COUNT -e GIT_CONFIG_KEY_1 -e GIT_CONFIG_VALUE_1 -w "/var/folders/bf/90yzq4vn42s2163sp1g5d0n80000gn/T/renovate/repos/github/renovate-testing/test-9748-ghlabels" docker.io/renovate/go:1.17.6 bash -l -c "go get -d ./... && go mod tidy && go mod tidy"
docker: Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?.
See 'docker run --help'.


Product.dart should not contain the fields price and compareAtPrice.

double get price =>
productVariants.isEmpty ? 0 : productVariants.first.price.amount;
String get formattedPrice =>
productVariants.isEmpty ? '' : productVariants.first.price.formattedPrice;
Product.dart should not contain the fields price and compareAtPrice, because this will confuse developers. These two fields belong to productVariants, so it is not appropriate to get them directly with first.

Generally, the prices of different SKUs of the same product are the same, but I feel that at least a note is needed here.

The Product model contains the formattedPrice and formattedPrice properties to make it easy to display the price in the list where products are displayed.
It reduces the logic of searching for the variant and getting its price.
Yes, I do agree a note is needed for those properties.
I will update it in later update

Totally agree.

飞天小麦迪
@.***

------------------ 原始邮件 ------------------
发件人: "Sujan @.>;
发送时间: 2024年9月13日(星期五) 下午4:03
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [imsujan276/shopify_flutter] Product.dart should not contain the fields price and compareAtPrice. (Issue #79)
The Product model contains the formattedPrice and formattedPrice properties to make it easy to display the price in the list where products are displayed.
It reduces the logic of searching for the variant and getting its price.
Yes, I do agree a note is needed for those properties.
I will update it in later update
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Fix metrics error when data is less than selected date

Related to #4309
Fix the 'sql: Scan error on column index 5, name "usedPercent": converting NULL to float64 is unsupported' error on the metrics page.

Update the getMemoryMetrics method in app/Models/Server.php to handle NULL values for the "usedPercent" field by setting them to 0.0.
Add a check for NULL values in the getMemoryMetrics method before converting to float64.

Thank you for the PR!

I still get this error on v380 @vishwamartur


Nonce account creation

This adds support for creating nonce accounts and leveraging their nonces including decoding the data in the account to figure out what the next nonce value is.

@kevinheavey, it seems like only the async tests are failing:
tests/integration/test_async_http_client.py EEEEEEEEEEEEEEEEEEEEEEEEEEEE [ 25%]
EEEEEEEEE                                                                [ 33%]
tests/integration/test_async_token_client.py EEEEEEEEEEEEEEEEEE          [ 50%]
tests/integration/test_http_client.py EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE [ 80%]
EEE                                                                      [ 83%]
tests/integration/test_token_client.py EEEEEEEEEEEEEEEEEE                [100%]

../../../.local/share/virtualenvs/solana-py-aVJNdTPk/lib/python3.7/site-packages/pytest_docker/plugin.py:108: Exception
------------------------------ Captured log setup ------------------------------
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
ERROR    solanaweb3.rpc.httprpc.HTTPClient:async_http.py:35 Health check failed with error: All connection attempts failed
_______________ ERROR at setup of test_send_invalid_transaction ________________

Any ideas?

I've been running some experiments here https://github.com/kevinheavey/pytest-docker-ci-example
The problem seems to be in the interaction between the CI server and the Solana Docker image.
My findings so far:
Some images work on my machine but not on the CI server, such as solana:stable which we're using currently.
Some images don't even work on my machine e.g. solana:v1.7.13.
v.1.7.12 works on my machine and in the CI for my example repo, so now let's hope it works here 🕯

Ok these are all failing now for just one reason:
On v1.7.12 the response from .get_account_info looks like this {'jsonrpc': '2.0', 'result': {'context': {'slot': 124}, 'value': None}, 'id': 13}. This causes the assertions in the test_token fixture to fail.
According to the docs if value is None it means the account doesn't exist. So it looks like something is going wrong in creating the stubbed_sender account. I'm not sure where the account actually gets created on-chain.
Any thoughts @michaelhly ?

Alright pinning the Solana version to 1.6.28 works. Looks like something breaks between 1.6 and 1.7, which we need to fix separately

Alright pinning the Solana version to 1.6.28 works. Looks like something breaks between 1.6 and 1.7, which we need to fix separately

Created an issue for this. https://github.com/michaelhly/solana-py/issues/116


[WIP] Notifications refactor

issue #5409

[x] remove old 'notification.location' concept
[x] fix display of persistent (alert) notifications
[x] change persistent/passive status types to alert/notification to keep naming consistent
[x] re-enable timed auto-close of notifications
[x] move filtering of alerts/notifications from components into notifications service
[x] reduce public notifications interface to showAlert/showNotification
[x] review all notifications and update/remove as per new requirements
[x] update notification/alert colours as per new requirements
[x] tests
[x] rebase and resolve merge conflicts from inline-errors
[x] update general settings to use inline errors (+ kill generic error notification)
[x] update signin to use inline errors
[x] update reset to use inline errors
[x] update signup to use inline errors
[x] update user form to use inline errors
[x] update setup/three to use inline errors
[x] review error handling in code-injection
[ ] review error handling in upload modal
[ ] notifications.showErrors is used in a number of places to display validation errors. Review and remove/update
[ ] add method for alerts/notifications to have a click action specified
[ ] remove notification.location concept in the API

Known issues:

[ ] Notifications are still shown after server-side "user not found" error during sign-in as the server does not respond with a DS.Errors compatible format

Whoop it's green :tada:

Yep, nearing the end now! Hoping to have some time tomorrow evening after the dev meeting to get the last inline-validation bits done.
Regarding the clickable notifications, do they need to open in the same tab or a new tab?

Regarding the clickable notifications, do they need to open in the same tab or a new tab?

Will be a mix, mostly same tab - but "view post" links in new tab

@kevinansfield correct on all counts :+1:

Seeing as this is passing, would it be worth getting it rebased and squashed up a bit and merging in it's current form, and then sharing out the remaining work?

Yeah, that will probably be best. I'll find some time today to cleanup/rebase/squash and raise some issues for the final todos.

Perfect thanks :+1:

Rebased and squashed into 3 main areas of work so it's easier to track review.
Main issues remaining:

A method to handle clickable notifications
I believe there are still edge cases where the editor displays notifications that don't comply with the rules set out in #5409
Final run-through to check situations where notifications are displayed in place of inline-validations or alerts due to notifications.showErrors being used
I've noticed that at least in one place (signin/signup) the API's error response for validation related concerns is not compatible with DS.Errors meaning that it can't picked up by the inline-errors implementation.


Files

Hi,
Can we remove the different .sh and .cmd files from the root of the repo? Or move them elsewhere? Also, do we need the .vscode-stuff?
Thanks,
Bjørn

@fjukstad Sorry, these files were never meant to be there in the first place, I added their commit by mistake. Gone now.

No worries, thanks!


Pods with a pod disruption budget are not evicted

Version
rancher/system-upgrade-controller:v0.5.0
Describe the bug
System upgrade jobs running in hosts that have any pods with a pod disruption budget are stuck forever initializing.
To Reproduce
Run any workload that has a pod disruption budget and try to apply an upgrade plan. The job will be stuck on initializing forever on the node where the pod with the pod disruption budget is running.
Expected behavior
There should be a way to drain pods with pod disruption budget
Actual behavior
I added the following drain options to my plan:
  drain:
    deleteLocalData: true
    ignoreDaemonSets: true
    force: true

However, nodes that have any pods with a pod disruption budget are stuck forever initializing. The drain init container is stuck with the following error (that repeats every 5 seconds):
evicting pod "<pod-name>"
error when evicting pod "<pod-name>" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.

If I manually remove those pods (using --force --grace-period=0), then the drain container is able to finish and the plan is applied successfully.

Our drains are currently implemented by creating a container that runs on the node in question invoking kubectl drain. As of v1.18 it looks like kubectl drain has picked up a new flag, --disable eviction, for dealing with  scenarios like this. When generating the drain container we will want to perform some minimal check that the kubectl image we are using is v1.18 or newer before including use of this flag. The controller should log a warning when .spec.drain.disableEvicition is true but the kubectl image does not support the flag.
A possible alternative is to make use of the --dry-run=client flag combined with --disable-eviction to see if it is supported.

Using SUC v0.6.1, verified the two scenarios.

With minAvailable set to 2 in PDB, on a cluster with 2  schedulable nodes  and concurrency set to 2 and with disableEviction set to true, pods got Evicted and upgrade was successful.
With minAvailable set to 2 in PDB, on a cluster with 2 schedulable nodes  and concurrency set to 2 and without disableEviction, jobs were stuck in initializing state and node stuck in Ready,SchedulingDisabled state.


Plain sasl auth is failing in IE 11

@legastero It appears that this commit broke sasl auth in IE 11: https://github.com/legastero/stanza.io/commit/7fb610f8f348a7fcb8f0e3839e8e946210452d85
I pulled the latest stanza (8.4.8) and I am creating a Stanza.Client instance with plain auth and when I try to connect I get an auth:failed event and when I debugged it I found that no sasl mechanisms were loaded because existingMech.name is undefined. This worked on stanza 8.4.0. I am using browserify as my module loader/bundler.
What was existingMech.name supposed to check? Right now it is the function name which is 'Mechanism' in chrome and is undefined in IE. Maybe that line could either check if existingMech is a function or that existingMech.prototype.name is truthy to make sure it is loaded.

Ok, that check isn't working like I thought it was then.
The intent was to handle cases where those require calls don't actually load the module (from ignoring them via Webpack or browserify). With Browserify you can make it return false, but Webpack returns {}.
I'll get this patched sometime today or this weekend then. Thanks so much for the report!

Thanks! That fixed the issue


Pregen MineColonies base camp or supply ship instead of crafting them

I was thinking of making the base camp and supply ship both structures you find while exploring (complete with the town hall item) rather than something you make. Thoughts?

That sounds pretty nice.

@Alan19: you said you found a base camp while exploring?

Yes


Manage quadicon methods to consider special cases for the x_show method

The GTL view sometimes contains items that are not exactly individual records but are a collection of records like the "Unassigned Profiles Group" in the Provider Foreman List view as shown in the sceenshot below:

Clicking on the "Unassigned Profiles Group" in the Grid and Tile view (where the quadicons exist) did not work and had to be fixed. List view works fine without any issues.
Fixed some of the quadicon methods to address this special case, and made a few adjustments around that in the Provider Foreman controller and the grid and tile hamls.
Note that, this is the second fix for the same BZ. The first fix https://github.com/ManageIQ/manageiq/pull/12224 fixed the issue for the List View, while this fix is specifically targeted for the Grid/Tile view.
https://bugzilla.redhat.com/show_bug.cgi?id=1388431

@miq-bot add_label ui,bug,euwe/yes

@hayesr @martinpovolny please review . . . thx, Dan

LGTM 👍
This is probably as clean as we're going to be able to add these special cases for now.

Euwe backport details:
$ git log -1
commit d9cdbf52e6a3724045991cd2034376a9109c9c27
Author: Martin Povolny<EMAIL_ADDRESS>Date:   Fri Dec 2 09:51:08 2016 +0100

    Merge pull request #12936 from AparnaKarve/bz1390731_fix_unassigned_profile_grid_tile

    Manage quadicon methods to consider special cases for the x_show method
    (cherry picked from commit 5653530f1f7cb236244e95b270b9ca0c32083974)

    https://bugzilla.redhat.com/show_bug.cgi?id=1390731


 Hopefully :crossed_fingers: this fixes it!

Retry worked on flake:
https://github.com/jupyrdf/ipyelk/pull/33/checks?check_run_id=1332540404#step:7:1599

Gah, windows failing very un-helpfully, investigating...


Node Dock is not cleared when deleting selected node

Godot version
4.2 beta4
System information
Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; <IP_ADDRESS>3) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)
Issue description
When you select a node, the Node dock's signals and groups will point to that node. When you unselect it, the dock is properly cleared. If you instead delete the node, the dock content will stay and you can still make changes, which will go into the void (there is no way to restore the node without undoing the changes). What's worse, if you make a new scene and do the same to root node, it will result in editor crash.
Related is that the inspector does not fully clear either. The node header stays, the content is empty:

Steps to reproduce

Add node
Select it
Go to Node dock's Groups
Press Delete to delete the node (tested with the "no confirm" action, IIRC Shift+Delete by default?)
The node is removed, but dock stays
Add groups

Minimal reproduction project
N/A

I reproduced this in Macbook pro (2019) Ventura 13.3.1.

Was this solved previously? I'm working on v4.0.3.stable.official [5222a99f5] and I can reproduce this:
Before pressing Shift+Del (or before pressing Del to confirm the deletion)

After deleting the node (any of the methods above)

I think I have an idea of how to fix this issue, I'll look into coming up with a solution in the next week or two.


[BUG] Error on mounted disked which causes data loss

Describe the bug (🐛 if you encounter this issue)
Sometimes on my servers when a disk is mounted it's doing that error :
kernel:[308741.015168] EXT4-fs (sdg): failed to convert unwritten extents to written extents -- potential data loss!  (inode 262194, error -30)
This causes various problem in the cluster like crashing pods maybe due to data loss
Environment

Longhorn version: master from 18 november
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): Kubectl
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: k3s

Number of management node in the cluster: 2
Number of worker node in the cluster: 1

Node config

OS type and version: Ubuntu 20.04
CPU per node: 4 or 3
Memory per node: 24G / 20G / 12G
Disk type(e.g. SSD/NVMe): HDD

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): one node at home on proxmox and two in OCI
Number of Longhorn volumes in the cluster: 13

@greggameplayer don't use the master for your setup, because the master is under development. Use releases instead and right now it's 1.3.2 or 1.2.5.

@innobead i can't because my kubernetes cluster version is v1.25.4+k3s1

@greggameplayer How did you trigger this error? Any power outage or unstable network?

@derekbit append a lot when trying to deploy nextcloud using helm chart

Apart from the development branch issue, if you encounter the issue again, suggest providing the dmesg and the support bundle for further investigation.
In addtion, if the instance-manager-r/e crashes corrupt the filesystem, you can try to fix the filesystem as the steps in https://longhorn.io/kb/troubleshooting-volume-filesystem-corruption/

Same problem here:
[10910.096082] blk_update_request: I/O error, dev sda, sector 4778544 op 0x1:(WRITE) flags 0x0 phys_seg 44 prio class 0
[10910.096083] blk_update_request: I/O error, dev sda, sector 4474608 op 0x1:(WRITE) flags 0x800 phys_seg 5 prio class 0
[10910.096093] Aborting journal on device sda-8.
[10910.096448] EXT4-fs warning (device sda): ext4_end_bio:347: I/O error 10 writing to inode 131080 starting block 597319)
[10910.096791] blk_update_request: I/O error, dev sda, sector 4456448 op 0x1:(WRITE) flags 0x800 phys_seg 1 prio class 0
[10910.097128] buffer_io_error: 109 callbacks suppressed
[10910.097133] Buffer I/O error on device sda, logical block 597318
[10910.097462] Buffer I/O error on dev sda, logical block 557056, lost sync page write
[10910.097819] EXT4-fs warning (device sda): ext4_end_bio:347: I/O error 10 writing to inode 131080 starting block 597362)
[10910.098177] JBD2: Error -5 detected when updating journal superblock for sda-8.
[10910.098495] blk_update_request: I/O error, dev sda, sector 4636672 op 0x1:(WRITE) flags 0x0 phys_seg 5 prio class 0
[10910.098553] blk_update_request: I/O error, dev sda, sector 0 op 0x1:(WRITE) flags 0x800 phys_seg 1 prio class 0
[10910.098566] Buffer I/O error on dev sda, logical block 0, lost sync page write
[10910.098574] EXT4-fs (sda): I/O error while writing superblock
[10910.098577] EXT4-fs error (device sda): ext4_journal_check_start:83: Detected aborted journal
[10910.098936] EXT4-fs (sda): Remounting filesystem read-only
[10910.099225] EXT4-fs warning (device sda): ext4_end_bio:347: I/O error 10 writing to inode 131074 starting block 579589)
[10910.099626] EXT4-fs (sda): failed to convert unwritten extents to written extents -- potential data loss!  (inode 131080, error -30)
[10910.099909] Buffer I/O error on device sda, logical block 579584
[10910.100302] Buffer I/O error on device sda, logical block 597319
[10910.100562] Buffer I/O error on device sda, logical block 579585
[10910.100952] Buffer I/O error on device sda, logical block 597320
[10910.101258] Buffer I/O error on device sda, logical block 579586
[10910.101653] Buffer I/O error on device sda, logical block 597321
[10910.101920] Buffer I/O error on device sda, logical block 579587
[10910.102697] Buffer I/O error on device sda, logical block 597322
[10910.102945] Buffer I/O error on device sda, logical block 579588
[10910.704033] ------------[ cut here ]------------
[10910.704287] bdi-(unknown) not registered
[10910.704576] WARNING: CPU: 13 PID: 260752 at fs/fs-writeback.c:2310 __mark_inode_dirty+0x24b/0x300
[10910.704827] Modules linked in: sd_mod t10_pi crc_t10dif crct10dif_generic sg nf_conntrack_netlink xt_statistic xt_owner xt_REDIRECT rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd grace nfs_ssc fscache xt_multiport xt_set ipt_rpfilter ip_set_hash_net ip_set_hash_ip ip_set vxlan wireguard curve25519_x86_64 libchacha20poly1305 chacha_x86_64 poly1305_x86_64 ip6_udp_tunnel udp_tunnel libcurve25519_generic libchacha veth xt_nat xt_recent xt_addrtype ipt_REJECT nf_reject_ipv4 xt_tcpudp xt_MASQUERADE nft_chain_nat xt_mark xt_conntrack xt_comment nft_compat nft_counter nf_tables nfnetlink iptable_filter iptable_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 libcrc32c overlay br_netfilter bridge stp llc intel_rapl_msr intel_rapl_common nfit libnvdimm kvm_intel kvm irqbypass ghash_clmulni_intel aesni_intel cirrus libaes crypto_simd ib_iser cryptd glue_helper drm_kms_helper joydev evdev rdma_cm virtio_balloon serio_raw rapl iw_cm cec qemu_fw_cfg button ib_cm ib_core iscsi_tcp
[10910.704922]  libiscsi_tcp libiscsi drm scsi_transport_iscsi sunrpc fuse configfs ip_tables x_tables autofs4 ext4 crc16 mbcache jbd2 crc32c_generic virtio_net net_failover uhci_hcd virtio_blk failover ata_generic ehci_hcd ata_piix crct10dif_pclmul crct10dif_common usbcore libata virtio_pci virtio_ring crc32_pclmul psmouse scsi_mod usb_common virtio crc32c_intel i2c_piix4
[10910.707739] CPU: 13 PID: 260752 Comm: prometheus Tainted: G        W         5.10.0-23-amd64 #1 Debian 5.10.179-3
[10910.708024] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.0-debian-1.16.0-5 04/01/2014
[10910.708284] RIP: 0010:__mark_inode_dirty+0x24b/0x300
[10910.708541] Code: ff ff 48 8b 38 48 89 c5 f6 47 44 01 74 1e 48 8b 40 08 a8 01 75 16 e8 b4 1f f3 ff 48 c7 c7 ab b8 af 92 48 89 c6 e8 32 ea 5a 00 <0f> 0b 48 8b 05 cc 3d 2f 01 49 89 85 c8 00 00 00 45 85 ff 74 0e 48
[10910.709066] RSP: 0000:ffff9ee2cdcdfca8 EFLAGS: 00010286
[10910.709326] RAX:<PHONE_NUMBER>000000 RBX:<PHONE_NUMBER>000000 RCX: ffff8ceddfd60908
[10910.709588] RDX: 00000000ffffffd8 RSI:<PHONE_NUMBER>000027 RDI: ffff8ceddfd60900
[10910.709877] RBP: ffff8ce8500c9000 R08:<PHONE_NUMBER>000000 R09: ffff9ee2cdcdfac8
[10910.710147] R10: ffff9ee2cdcdfac0 R11: ffffffff930cb7a8 R12: ffff8ce8dbae4bc8
[10910.710397] R13: ffff8ce8dbae4b40 R14:<PHONE_NUMBER>000000 R15:<PHONE_NUMBER>000000
[10910.710645] FS:  000000c000600890(0000) GS:ffff8ceddfd40000(0000) knlGS:0000000000000000
[10910.710895] CS:  0010 DS: 0000 ES: 0000 CR0:<PHONE_NUMBER>050033
[10910.711174] CR2: 00007f93b1579e81 CR3: 000000042a82e003 CR4:<PHONE_NUMBER>770ee0
[10910.711623] PKRU: 55555554
[10910.712017] Call Trace:
[10910.712319]  __block_commit_write.constprop.0.isra.0+0x55/0xc0
[10910.712698]  ? ext4_da_release_space+0x100/0x100 [ext4]
[10910.712926]  block_page_mkwrite+0xf2/0x100
[10910.713161]  ext4_page_mkwrite+0x5a5/0x640 [ext4]
[10910.713403]  do_page_mkwrite+0x52/0xc0
[10910.713626]  do_wp_page+0x2ae/0x470
[10910.713854]  handle_mm_fault+0x1222/0x1c00
[10910.714074]  do_user_addr_fault+0x1b8/0x400
[10910.714294]  exc_page_fault+0x78/0x160
[10910.714505]  ? asm_exc_page_fault+0x8/0x30
[10910.714710]  asm_exc_page_fault+0x1e/0x30
[10910.714936] RIP: 0033:0x470e97
[10910.715153] Code: f3 44 0f 6f 54 1e a0 f3 44 0f 6f 5c 1e b0 f3 44 0f 6f 64 1e c0 f3 44 0f 6f 6c 1e d0 f3 44 0f 6f 74 1e e0 f3 44 0f 6f 7c 1e f0 <f3> 0f 7f 07 f3 0f 7f 4f 10 f3 0f 7f 57 20 f3 0f 7f 5f 30 f3 0f 7f
[10910.715679] RSP: 002b:000000c003720be0 EFLAGS: 00010283
[10910.715935] RAX: 00007f93b1579e81 RBX:<PHONE_NUMBER>00008c RCX:<PHONE_NUMBER>00008c
[10910.716172] RDX:<PHONE_NUMBER>003e81 RSI: 000000c008f47cb0 RDI: 00007f93b1579e81
[10910.716411] RBP: 000000c003720c80 R08: 00007f93b1579e81 R09:<PHONE_NUMBER>000fa0
[10910.716669] R10: 00007f93b1576000 R11:<PHONE_NUMBER>000000 R12:<PHONE_NUMBER>000000
[10910.716906] R13:<PHONE_NUMBER>000034 R14: 000000c025dc4ea0 R15: 000000c000600800
[10910.717181] ---[ end trace 9cc1e37a63b347e7 ]---
[10911.800104] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
[10911.800370] IPv6: ADDRCONF(NETDEV_CHANGE): cali69db01c864a: link becomes ready
[10914.570497] scsi host3: iSCSI Initiator over TCP/IP
[10914.576370] scsi 3:0:0:0: RAID              IET      Controller       0001 PQ: 0 ANSI: 5
[10914.577158] scsi 3:0:0:0: Attached scsi generic sg0 type 12
[10914.577921] scsi 3:0:0:1: Direct-Access     IET      VIRTUAL-DISK     0001 PQ: 0 ANSI: 5
[10914.578492] sd 3:0:0:1: Attached scsi generic sg1 type 0
[10914.578532] sd 3:0:0:1: Power-on or device reset occurred
[10914.579556] sd 3:0:0:1: [sdb] 10485760 512-byte logical blocks: (5.37 GB/5.00 GiB)
[10914.579997] sd 3:0:0:1: [sdb] Write Protect is off
[10914.580188] sd 3:0:0:1: [sdb] Mode Sense: 69 00 10 08
[10914.580392] sd 3:0:0:1: [sdb] Write cache: disabled, read cache: enabled, supports DPO and FUA
[10915.611775] sd 3:0:0:1: [sdb] Attached SCSI disk
[10928.214081] EXT4-fs warning (device sda): htree_dirblock_to_tree:1042: inode #131078: lblock 0: comm prometheus: error -5 reading directory block
[10928.216461] EXT4-fs warning (device sda): htree_dirblock_to_tree:1042: inode #131076: lblock 0: comm prometheus: error -5 reading directory block
[10939.220134] EXT4-fs error (device sda): ext4_wait_block_bitmap:531: comm prometheus: Cannot read block bitmap - block_group = 18, block_bitmap = 524290
[10939.220583] EXT4-fs error (device sda): ext4_discard_preallocations:4462: comm prometheus: Error -5 reading block bitmap for 18
[10939.221306] EXT4-fs error (device sda): ext4_wait_block_bitmap:531: comm prometheus: Cannot read block bitmap - block_group = 18, block_bitmap = 524290
[10939.221782] EXT4-fs error (device sda): ext4_discard_preallocations:4462: comm prometheus: Error -5 reading block bitmap for 18
[10942.891946] EXT4-fs (sdb): mounted filesystem with ordered data mode. Opts: (null)
[10943.280395] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
[10943.280675] IPv6: ADDRCONF(NETDEV_CHANGE): cali9645982db1d: link becomes ready

I am facing the same issue, with a cluster of RPI4's. The problem occurs even on the local disks.
Did you guys find any solution? Mitigations?

Can you provide a support bundle? Thanks.
取得 iOS 版 Outlookhttps://aka.ms/o0ukef

寄件者: Leonardo Benicio @.>
寄件日期: Saturday, September 23, 2023 9:02:40 PM
收件者: longhorn/longhorn @.>
副本: Derek Su @.>; Mention @.>
主旨: Re: [longhorn/longhorn] [BUG] Error on mounted disked which causes data loss (Issue #4925)
I am facing the same issue, with a cluster of RPI4's. The problem occurs even on the local disks.
Did you guys find any solution? Mitigations?
—
Reply to this email directly, view it on GitHubhttps://github.com/longhorn/longhorn/issues/4925#issuecomment-1732313799, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AC7SNAMHHKPX3U25MGKUKXLX33MXBANCNFSM6AAAAAASI5OMHU.
You are receiving this because you were mentioned.Message ID: @.***>

In my case the issue occur with debian 11 (not tested yet on debian 12) with only 1 node with localfs (no replicas). The more simple way to test...

Can you provide a support bundle? Thanks. More questions: - Did your longhorn nodes experience power outage? - Was the replica rebuilding triggered in the problematic volume?

@gigi206
Got it.
Can you provide more information

Support bundle

I assume the corrupted filesystem is gone, but I would like to check the configuration from the support bundle.

Machine information

OS distro/kernel: uname -a
CPU
Memory
Underlying storage
Cloud provider or baremetal machine

Steps to reproduce

I know it is difficult, but I want to know how you use the storage and the application. If possible, you can send us the manifest for the workloads and volumes, and we can try to reproduce it as well.

Longhorn relies on the ext4 or other filesystems on the host. You can also try Debian 12 and see if the issue still exists.

I've done a single-replica node IO stress using fio for hours on Debian 12.
The filesystem is still healthy and without any corruption.
[global]
ioengine=libaio
iodepth=64
direct=1
loops=20
verify=md5
verify_fatal=1
size=4G
bs=4k
rw=randrw
rwmixread=50
rwmixwrite=50

[job1]
filename=/data/file.1

[job2]
filename=/data/file.2

[job3]
filename=/data/file.3

[job4]
filename=/data/file.4

cc @gigi206

I switch from Debian 11 to Debian 12 and I also switch to cilium CNI at the same time and at the moment no corruption occurs

I switch from Debian 11 to Debian 12 and I also switch to cilium CNI at the same time and at the moment no corruption occurs. But with Debian 11 I test multiple times and it leads to corruption

I also encountered this problem， I suspect it's a problem with the kernel version， it work fine on 5.4, later after upgrading 5.15, this situation has occurred many times.

I don't think it is related to linux kernel.
Can you always reproduce the issue?

S type and version: Ubuntu 20.04

not always,  I don'y known why, Sometimes volumes become read-only


URL builder

Right now the URI must be constructed perfectly. The base URI must end with a / or otherwise, it won't work. Parse the incoming string and construct the URI.

Assess URI and append trailing slash if necessary, commit 2f0849f21a207df1e871a6b7a34f499a3c5f3531

Assess URI and append trailing slash if necessary, commit 2f0849f21a207df1e871a6b7a34f499a3c5f3531


[vm] Revalidate txns

Motivation
This refactoring fixes a minor inconsistency in the way that WriteSet transactions are validated during the execution phase -- the checks for the gas currency were not done during execution. This is not a huge problem because WriteSet transactions are not charged for gas, but it shows the potential for inconsistencies. I'd like to avoid any potential for that in future.
Now that #6918 is landed, this refactor will no longer be a breaking change.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
The first commit changes the gas charging and thus changes the golden files. The second one should only change one golden file.
Related PRs
#6780

I tested this locally and confirmed that it is no longer a breaking change.
@runtian-zhou Can you please edit the git commit message to remove the 2nd paragraph about the gas issues?

Looks good to me. It's nice for us to refactor out the common pieces of the code to prevent errors like missing checks.

/land

:broken_heart: Test Failed - Build images and run cluster test

/land


Make channel ID and name configurable in DefaultMediaNotificationProvider

Use case description
After integrating your DefaultMediaNotificationProvider with the MediaSessionService, I found that there are a few points worth to be discussed, but before jumping into them, I'd like to make sure that I understand the purpose of this class correctly.
Our use case is quite straightforward, displaying media notification for audio playback with custom actions, and the notification building/ bitmap handling in DefaultMediaNotificationProvider is exactly what I need, so I chose to extend this class, provide own BitmapLoader implementation, and override the member functions to achieve the custom actions rather than providing full-blown implementation from scratch.
Everything is working fine, but here are a few things that our team and I think would be nice to improve:

The Default naming prefix of the class made me think that we should provide our own implementation originally, but turns out it's quite flexible and we can just extend from it. Maybe a better naming is possible here?
Notification channel id and name are too generic and can't be overridden, we actually would like to provide translations for the channel naming if possible.
The only way to provide own playback icons is to override by the same resource name, we think that a proper API to override the resources will be a neater solution.

Please let us know your thought about those points, we'll be glad if any of them makes sense to you! Thanks as always.

@marcbaechinger  Thanks for the reply and tip!

The API allows you to do your own buttons by overriding DefaultMediaNotificationProvider.getMediaButtons

Sorry for not being clear, I actually meant the small notification icon (media3_notification_small_icon), as the createNotification function is final, the only way to provide the icon is to override it in the top-level module, it's working fine but just a bit implicit and hard to trace, do you think we can at least have an API to provide own small icon?

We changed DefaultMediaNotificationProvider so that

The notification ID, the channel name and channel ID can be set when constructing the instance. We moved construction to a builder to support this better.

Note that channel name must be provided as a string resource id, default is default_notification_channel_name.

Add a setter to configure the small icon.

The commit will appear here once it's pushed to the main branch. I'll close this issue but feel free to re-open if something did not work as expected.


Make toast notifications non-stackable.

What would you like to be added:
Currently toast notifications are stacked on top of each other, I would like them to not stack on top of each other and instead remove the previous and add a new one.
Why is this needed:
So I don't need to press +5 times when doing testing to get rid of error toast messages.

Example:

You can see the stacked shadows.


Artifacts in the inference output

Hi,
i've used your implementation for SRGAN. The steps are below.
i've used 800 images from div_2k as training dataset and 90 images from div_2k as test images.
I've ran initially SRRESNET with VGG54 for 10 power 5 iterations. Then used the obtained weights to initialize (--load) for SRGAN with VGG54 and ran for another 10 power 5 iterations.
The PSNR and SSIM are given below for Set5, Set14, BSD100 as well as Div_2K's 90 images (all average values):
[BSD100] PSNR: 25.18, SSIM: 0.6398
[Set14] PSNR: 26.25, SSIM: 0.6966
[Set5] PSNR: 29.33, SSIM: 0.8370
[div2k-90] 26.48, SSIM: 0.6984
But some of the images (from all the 4 sets given above) had artifacts. (Please see the attached images).
The artifacts are present in some iterations and not present in some iterations. But the iterations with low training loss also has artifacts.
Can you help me with the following questions?

Should i also train the SRGAN with VGG54 for another 10 pow 5 iterations with learning rate 1e5? will it solve the artifact issue?
Why are the artifacts appearing? is there a fix / saturation needs to be done?
Have you encountered these artifacts? Any way i can correct them?
In the files that i've attached, 195500 had least training loss, but had artifacts. 198500 had more worse training loss, but didn't have any artifacts. Which iterations's weights shall i choose?

Expecting your reply, as i'm struck in this a bit.

Hi Trevor,
Thank you for your clarifications.
Based on our discussion on your feedback, we've decided to try a few things, which are given below.

Change the scaling to 4X, by running the upscaling block in Generator only 1 time, instead of 2 times.
Hope this change to topology of Generator is sufficient. Please comment.
Run
a) SRRESNET with VGG22 for 10^6 iterations with learning rate 1e4.
b) SRGAN with VGG22 with Weights from a, for 10^5 iterations with learning rate 1e4.
c) SRGAN with VGG22 with Weights from b, for 10^5 iterations with learning rate of 1e5.
I tried to run a) with MSE, but i'm getting error while i load MSE weights obtained from a) and try initialize/load it for b).
Can you plz suggest the ideal commands for a proper MSE-based SRRESNET, followed by SRGAN commands?

Kindly let me know your comments on all the 3 steps.