Performance Discrepancy Between Naive and Approximated Methods in ml-casadi

Hi,
I've been working with the MLP network examples provided in the repository, specifically the "Naive" and "Approximated" methods. Upon evaluation, I noticed a significant discrepancy in their performance rates—the naive method executed at 2116Hz, while the approximated method performed at a slower 162Hz.
Could you shed some light on the processes each method uses to derive the MLP network weights within the c_generated_code? Additionally, any insights into the substantial difference in their execution speeds would be greatly appreciated.
Thank you for your time and any information you can provide.
Warm regards,
Merdan

Hi Merdan,
Thanks for reaching out!
Differences are expected here. Generally, the naive approach will be faster for smaller models as no context switch between C and Python/PyTorch occurs. For larger models and especially multiple parallel calls as in MPC which can be batched together by PyTorch the approximated approach will be faster.
Naive will rebuild the PyTorch Graph in CasADi, while Approximated will only build the Taylor function in CasADi and updates the parameters.
I would encourage you to read our paper [1] and especially pay attention to Figure 3 where "Ours" is similar to "Approximated".
Let me know if this helps!
Best
Tim

Hi Tim,
Thank you for your insightful response!
Your explanation clarified the distinctions between the naive and approximated approaches, and the emphasis on context switching was particularly helpful. I've gained a preliminary understanding of the differences and have referred to Figure 3 in your paper for a clearer comparison.
However, while reviewing the code, I noticed the absence of details on how the network weights are utilized within the c_generated_code. Could you provide a brief overview of how mlcasadi integrates the model into CasADi? Furthermore, I'm curious about the use of the model in c_generated_code.
Additionally, I observed the following function in the C code generated by the approximated method:
for (int ii = 0; ii <= N; ii++)
{
    wr_acados_update_params(acados_ocp_capsule, ii, p, NP);
}

I'm having difficulty understanding how this function interacts with the model in Python. An explanation of the principles behind this interaction would be greatly appreciated.
Thank you once again for your assistance, and I look forward to your guidance on these queries.
Best regards,
Merdan

Hi Merdan,
All functionality of MLCasADi has been moved to L4CasADi:

Naive: https://github.com/Tim-Salzmann/l4casadi#naive-l4casadi
Approximated: https://github.com/Tim-Salzmann/l4casadi#real-time-l4casadi

Thus MLCasADi is deprecated at this point. I would therefore ask you to re-open the issue in the L4CasADi repository so that other people looking into this can see it there. I will be happy to try and answer your questions there.
Best
Tim


[BugFix] Null JSON array

Fixes https://github.com/StarRocks/starrocks/issues/31520
This PR fixes the issue when use jsonpath to extract null key.
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)
[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.2
[x] 3.1
[ ] 3.0
[ ] 2.5

[BE Incremental Coverage Report]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exprs/json_functions.cpp
2
2
100.00%
[]

[FE Incremental Coverage Report]
:heart_eyes: pass : 0 / 0 (0%)

[BE Incremental Coverage Report]
:heart_eyes: pass : 4 / 4 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
src/exprs/json_functions.cpp
4
4
100.00%
[]

@Mergifyio backport branch-3.2

@Mergifyio backport branch-3.1


[QuickAccent] Fix minimum width being too large

Summary of the Pull Request
After the recent move to WPFUI, Quick Accent started respecting its minimum width, but it doesn't look great when we have small characters.

This PR removes this minimum width.

@jaimecbernardo Hmm, looks like that this was there already from the beginning.. not sure why, and not sure what happens when we remove it :). I'll give it a test

Please enable the setting forvthe character names and validatevthatvthey are readable and not trimmed. I am sure that is the reason for the min width.

Well spotted! I've put a Min Width on the name field instead :)


docs: add CONTRIBUTING.md

This repo is missing a contributing guide referenced in the README.

Thanks, added in https://github.com/moov-io/customers/pull/141 from our project template.


Terminal history is lost

Type: Bug
I see Terminal history is lost when IDE is left idle and reload is required.
VS Code version: Code 1.71.2 (Universal) (74b1f979648cc44d385a2286793c226e611f59e7, 2022-09-14T21:05:37.721Z)
OS version: Darwin x64 21.6.0
Modes:
Sandboxed: No
Remote OS version: Linux x64 4.18.0-305.7.1.el8_4.x86_64
Connection to 'SSH: sjc-ads-392' could not be established  Canceled
Connection to 'SSH: sjc-ads-392' could not be established  Canceled
Extensions (23)

Extension
Author (truncated)
Version

remote-containers
ms-
0.251.0

remote-ssh
ms-
0.84.0

remote-ssh-edit
ms-
0.84.0

remote-wsl
ms-
0.66.3

vscode-remote-extensionpack
ms-
0.21.0

ccls
ccl
0.1.29

baseline-coverage
cis
0.0.8

cisco-marketplace
cis
2.0.3

polaris-pack
cis
0.1.3

xdev-ai
cis
0.1.8

xdev-cscope
cis
0.0.9

xdev-indentor
cis
0.0.3

xdev-onboard
cis
0.0.8

xdev-persistent-terminal
cis
3.0.4

xdev-polaris
cis
0.1.5

xdev-polaris-builder
cis
1.4.3

xdev-pull-requests
cis
0.1.0-beta1

gitlens
eam
12.2.2

cmake-tools
ms-
1.12.27

cpptools
ms-
1.12.4

cpptools-extension-pack
ms-
1.3.0

shader
sle
1.1.5

cmake
twx
0.0.17

(2 theme extensions excluded)

Please provide a screenshot or a gif illustrating the problem (attaching images won't work via email, you need to go to github.com). See this wiki page for more general info on how to report actionable terminal issues.
/label info-needed terminal

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


This project is only about training, but how do I use this project to blur the picture?

This project is only about training, but how do I use this project to blur the picture?

for i in seq 1 30; do
python data_sampler.py --pattern '/home/alan/train/_blurry.mp4' --lmdb /home/alan/train$i.lmdb --num 5000
done
for i in seq 1 10; do
python data_sampler.py --pattern '/home/alan/train/_blurry.mp4' --lmdb /home/alan/train/val$i.lmdb --num 5000
done

but I don't have train$i.lmdb and val$i.lmdb，what should I do?

Please read the code carefully. There are two places for blurring images:
motion blur and camera shake

Sorry， I mean deblur

I re-trained a slightly larger model in TensorPack just for testing the TensorPack library some months ago. It seems to have similar performance (although it is not compatible with this GitHub project).
Find the inference code/weights here:
http://files.patwie.com/suppmat/patwie_iccv17_deblurring_model.tar.gz


[Bug]: Lab_08: Bootstrapping the Kubernetes Control Plane: Server URL  is incorrect in kube-scheduler.kubeconfig

Your Workstation
Ubuntu, 16 GB RAM, 8 core i7 CPU
What happened?
I followed your instruction file. But when the last check command: ./cert_verify.sh. I got this output:
vagrant@master-1:~$ ./cert_verify.sh 3
ca cert found, verifying the authenticity
ca cert is correct
etcd-server cert and key found, verifying the authenticity
etcd-server cert and key are correct
ca cert and key found, verifying the authenticity
ca cert and key are correct
kube-apiserver cert and key found, verifying the authenticity
kube-apiserver cert and key are correct
kube-controller-manager cert and key found, verifying the authenticity
kube-controller-manager cert and key are correct
kube-scheduler cert and key found, verifying the authenticity
kube-scheduler cert and key are correct
service-account cert and key found, verifying the authenticity
service-account cert and key are correct
apiserver-kubelet-client cert and key found, verifying the authenticity
apiserver-kubelet-client cert and key are correct
etcd-server cert and key found, verifying the authenticity
etcd-server cert and key are correct
Checking /var/lib/kubernetes/kube-controller-manager.kubeconfig
/var/lib/kubernetes/kube-controller-manager.kubeconfig found
Path to CA certificate is correct
Path to client certificate is correct
Path to client key is correct
Server URL is correct
Checking /var/lib/kubernetes/kube-scheduler.kubeconfig
/var/lib/kubernetes/kube-scheduler.kubeconfig found
Path to CA certificate is correct
Path to client certificate is correct
Path to client key is correct
Server URL  is incorrect

I also check kube-scheduler.kubeconfig file, which was generated in lab05, but I dont know how to fix that bug:
vagrant@master-1:~$ cat /var/lib/kubernetes/kube-scheduler.kubeconfig
apiVersion: v1
clusters: null
contexts:
- context:
    cluster: kubernetes-the-hard-way
    user: system:kube-scheduler
  name: default
current-context: default
kind: Config
preferences: {}
users:
- name: system:kube-scheduler
  user:
    client-certificate: /var/lib/kubernetes/pki/kube-scheduler.crt
    client-key: /var/lib/kubernetes/pki/kube-scheduler.key

Please help me, thanks!
Relevant log output
No response

I also debug:

Because api server is https://<IP_ADDRESS>:6443/. And ChatGPT hint that:

The value for <KUBERNETES_API_SERVER_ENDPOINT> in the kube-scheduler configuration depends on where your kube-scheduler is running in relation to the Kubernetes API server. Here are the typical scenarios:

If the kube-scheduler is running on the same machine as the Kubernetes API server: You can use <IP_ADDRESS>:6443. This local loopback address assumes that the kube-scheduler and the API server are on the same node, and it will connect to the API server on the local machine.
If the kube-scheduler is running on a different machine than the Kubernetes API server: You should use the actual IP address or DNS name of the Kubernetes API server, like https://<IP_ADDRESS>:6443. This ensures that the kube-scheduler can reach the API server over the network.

In most Kubernetes setups, especially in production or multi-node environments, the kube-scheduler is not typically on the same machine as the API server. In such cases, you need to use the actual network address. However, in single-node setups or for certain testing scenarios, it might be on the same node, and using <IP_ADDRESS>:6443 would be appropriate.
Which IP should I choose: <IP_ADDRESS> or INTERNAL_IP (like: <IP_ADDRESS>).

# INTERNAL_IP=$(ip addr show enp0s8 | grep "inet " | awk '{print $2}' | cut -d / -f 1)
LOCAL_IP="<IP_ADDRESS>"
cat <<EOF | sudo tee /var/lib/kubernetes/kube-scheduler.kubeconfig
apiVersion: v1
clusters:
- cluster:
    certificate-authority: /var/lib/kubernetes/pki/ca.crt
    server: https://${LOCAL_IP}:6443
  name: kubernetes-the-hard-way
contexts:
- context:
    cluster: kubernetes-the-hard-way
    user: system:kube-scheduler
  name: default
current-context: default
kind: Config
preferences: {}
users:
- name: system:kube-scheduler
  user:
    client-certificate: /var/lib/kubernetes/pki/kube-scheduler.crt
    client-key: /var/lib/kubernetes/pki/kube-scheduler.key
EOF

In this lab the scheduler is running on the same host as the API server. The kube-scheduler.kubeconfig is created in step 5 and will use <IP_ADDRESS>:6443.

I also check kube-scheduler.kubeconfig file, which was generated in lab05, but I dont know how to fix that bug:

From what you pasted below that comment, it looks like you did not run the following during lab05
  kubectl config set-cluster kubernetes-the-hard-way \
    --certificate-authority=/var/lib/kubernetes/pki/ca.crt \
    --server=https://<IP_ADDRESS>:6443 \
    --kubeconfig=kube-scheduler.kubeconfig

Please

Don't trust ChatGPT as a source of truth
Do follow the instructions in this lab to the letter. If you miss any step, no matter how small, things will not work.

I've solved this, thank you so much !


Standup report for manager

send a message to the manager at 5 pm that someone did not write the standup

Need to add method SelectStandupByChannelID #61

Fixed manager notifier:
Now notifier works and checks if each team had completed their stand ups. Method selects unique channels from list of all standupers. Then checks if the channels have users who did not submit the standup. At the exact time (configured from .env) bot sends messages to manager channel with a report by channels.
https://github.com/maddevsio/comedian/commit/da943b2c407416361eb1890b834c0b5fabe0f1e9


Check whether Timestamps are replicated correctly

I am currently not sure whether timestamps are replicated correctly. When using CreateTime TimestampType this should be fine, but I am not sure whether LogAppendTime is replicated correctly.

We set timestamps explicitly so this should be fine.


Get Space Summary does not document last_operation parameter type

The API documentation for Get Space Summary describes a services.last_operation payload element.  The type of this payload element is undocumented as the example only shows null.
See: cloudfoundry/cf-java-client#354

Hi @nebhale,
We've added documentation of this field to the docs. Please reopen if you find any further issues.
@wendorf and @fkotsian
CF CAPI Team

@wendorf Is the last_operation payload a hash with keys created_at, description, state, type, and updated_at (since I can't yet see the docs)?

Hi @nebhale,
Yes indeed. The payload appears as follows:
"last_operation": {
  "type": "create",
  "state": "succeeded",
  "description": "description goes here",
  "updated_at": "2016-02-18T22:12:11Z",
  "created_at": "2016-02-18T22:12:11Z"
}

This should show up in the release candidate docs relatively soon.

Thanks much.


It shows box with warning

It says,"an error occured wihle trying to create a file in the destination directory". I always choose the option that says , "cancel installation". I can work without any problem. I just thought you could improve vs code by looking into this problem

Is this when updating VS Code on Windows? Can you uninstall and reinstall?


GDScript: Hot-reload changed scripts only

hot reloading currently reloads all scripts
when working with dosens of scripts, it means a small change can take take a while, even tho you just wanted 1 script reloaded
with this PR only changed scripts are reloaded
was not sure how to change godot_icall_Internal_EditorDebuggerNodeReloadScripts csharp interop, so i left the behavior unchanged

Thanks!


The actor could speak but doesn't read

Hi
Recently I contributed to add the Shadow of The Demon Lord system. However, the system supports complex language structure like the following:
data: {
    "read": false,
    "speak": true,
    "write": false
}

I am thinking if could encrypt the Journal though the chat log would be legible.

I've implemented it, check it out!

It's working!
great job @mclemente


Rename pilot hubs to infrastructure

This renames references of pilot hubs to infrastructure or community hubs when we refer to specific hubs.

General comment, you are making some changes in our templates to fix comment links...
I would be hesitant to do that because we are going to trigger unneeded deployments just to fix a comment link.
I would prefer to change those at the time we implement change in the terraform files, IMHO.

Resolved conflicts! I wonder if @damianavila would be willing to take one last look to make sure I'm not overwriting something important?

For future reference, the path list the would cause new deployments can be found here:
https://github.com/2i2c-org/infrastructure/blob/be6c30f5ce31f49081c6426fdcbac712137110f5/.github/workflows/deploy-hubs.yaml#L7-L15
I left a couple of small comments, otherwise it looks good.

Resolved conflicts! I wonder if @damianavila would be willing to take one last look to make sure I'm not overwriting something important?

I was willing but people have beaten me at it 😜  .


fix,how-to-sg: add 'update-dist-git' to the shell output

since the existing command would fail on the fact that no command was
specified

I literally made this mistake every single time locally. Thanks for noticing and fixing it!


Added aliases for clippy and fmt to flake.nix

Please let me know if you have any questions.

Can you merge this @rtfeldman?


Click on Textbox in Wikipedia Add-in

There is Wikipedia add-in avaliable in In MS Word. I click on 'Wikipedia' button which launched another custom window in the side right. There is search box (edit) in wikipedia custom window. I am able to find this search using winappdriver API but unable to perform click action.
During action, word application is minimized. One of my observation is
<Pane AcceleratorKey="" AccessKey="" AutomationId="" ClassName="OsfAxControl" FrameworkId="Win32" HasKeyboardFocus="False" HelpText="" IsContentElement="True" IsControlElement="True" IsEnabled="True" IsKeyboardFocusable="True" IsOffscreen="False" IsPassword="False" IsRequiredForForm="False" ItemStatus="" ItemType="" LocalizedControlType="pane" Name="" Orientation="None" ProcessId="7228" RuntimeId="42.799252" x="1126" y="210" width="320" height="511">

<Edit AcceleratorKey="" AccessKey="" AutomationId="" ClassName="" FrameworkId="MicrosoftEdge" HasKeyboardFocus="False" HelpText="I want to know..." IsContentElement="True" IsControlElement="True" IsEnabled="True" IsKeyboardFocusable="True" IsOffscreen="False" IsPassword="False" IsRequiredForForm="False" ItemStatus="" ItemType="" LocalizedControlType="edit" Name="" Orientation="None" ProcessId="19176" RuntimeId="42.1519796.4.403" x="2697" y="514" width="252" height="24"/>

As you can see, Edit control "I want to know..." has X is 2697 & Y is 514.
Whereas top parent (pane) of edit control has x= 1126 & y=210.
There is some miscalculation of X & Y for "Edit" control under Wikipedia add-in .
May be its the reason of Word application getting minimized when winapp driver tries to click on this edit field because clicks occurs outside word application.
Is there any solution to this problem of performing click on edit box in add-in.
Thanks

Hi,
Please have a look, need some help on it.
Thanks.

Hi,
Please have a look, need some help on it.
Thanks.

Just a guess is what I can give you.  We use a chromedriver to test our controls that use an embedded webpage.  Maybe you need to look at using this web driver?  https://docs.microsoft.com/en-us/microsoft-edge/webdriver-chromium/?tabs=c-sharp

Just a guess is what I can give you.  We use a chromedriver to test our controls that use an embedded webpage.  Maybe you need to look at using this web driver?  https://docs.microsoft.com/en-us/microsoft-edge/webdriver-chromium/?tabs=c-sharp


Fix wrong checks in command section

The previous test exited with success at the first check.
Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender

cc @GiulioRomualdi if you need to copy the recipe, get this new fixed version :D

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Docstrings sometimes doesn't highlight

@Moosems:

If I have docstrings and I type them in line by line they don't highlight as such but if I paste it in then it is highlighted properly

This is due to it not rendering all at once because doing that every time an edit is made would be incredibly time expensive. The viewport-only tags may help alleviate the slowness of tagging all but overall could be slower. Tests into this idea will have to be some time. We could also just look for """ but that could lead to a myriad of other bugs.

My worry is if there're multiple docstrings near each other.


Add Support for Pydantic v2

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

Add Support for Pydantic v2 without breaking Pydantic v1 installs. (#893)

Test plan
How are these changes tested?

[x] Tests pass locally with pytest for python, yarn test for js

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
Yes, no changes necessary.

@srhinos, Thank you for this. I think part of it is included in - https://github.com/chroma-core/chroma/pull/1033. But let's have a look at actually supporting 2.x. Have you run local tests and are they all passing?

@srhinos, Thank you for this. I think part of it is included in - #1033.

That PR is doing the opposite of what mine is, its further ensuring Pydantic is pinned below 2 where as this PR enables support for both 1.x and 2.x depending on the needs of all the libraries a project is importing.

But let's have a look at actually supporting 2.x.

outright support for v2 is probably not recommended right off the bat. Several other large projects like langchain, llama index, etc are all implementing this same strategy of unpinning <2 and enabling cross compatibility.
This would unblock projects in the short term that are (reasonably) frustrated they can't upgrade several core libraries because of a few packages. Right now, the five lines of chromadb we use in our code base for a niche use case is blocking us from upgrading fastapi and several libraries that have minor CVEs so this is a pretty important upgrade.
In the long term, full v2-only support will require auditing all dependancies of chromadb and submitting PRs on those repos where open source to ensure you can safely install pydantic 2.x.x with them.

Was having trouble getting my env running, would appreciate help fixing tests if my recent commit doesn't fix them!

Thanks, I've been waiting for this.

@srhinos unfortunately the pinned version of fastapi does not work with pydantic 2.x. What do you think should your change also include unpinning fastapi? What consequences will that have to other parts of the code?

@tazarov afaik we pinned to the current version of fastapi mostly because of pydantic v2 as well. we'd like to support it bidirectionally!

@jeffchuber gets sketchy when I unpin things:
pip freeze | grep -E 'fastapi|numpy|pydantic'
fastapi==0.103.0
numpy==1.25.2
pydantic==2.3.0
pydantic_core==2.6.3

I just stopped it when most tests started failing:
=================================== 142 failed, 212 passed, 4 xfailed, 4 xpassed, 12069 warnings in 533.74s (0:08:53) ===================================

Most errors are like this:
FAILED chromadb/test/property/test_filtering.py::test_empty_filter[fastapi_persistent] - Exception: {"detail":[{"type":"missing","loc":["query","collection"],"msg":"Field required","input":null,"url":"https://errors.pydantic.dev/2.3/v/mi...
FAILED chromadb/test/property/test_filtering.py::test_boolean_metadata[fastapi_persistent] - Exception: {"detail":[{"type":"missing","loc":["query","collection"],"msg":"Field required","input":null,"url":"https://errors.pydantic.dev/2.3/v/mi...

Ref: https://errors.pydantic.dev/2.3/v/missing

LMK if there's anything we (the pydantic team) can do to get this over the line.
Seems a shame that chromadb is preventing people from adopting pydantic v2.

LMK if there's anything we (the pydantic team) can do to get this over the line.
Seems a shame that chromadb is preventing people from adopting pydantic v2.

I tried digging into this issue for ~20 mins but couldn't properly decipher chroma's implementation of FastAPI. The test calls a consumer of a backend api thats causing the failure but I just can't find where the backend is actually being hit at.
ex: https://github.com/chroma-core/chroma/blob/main/chromadb/test/test_api.py#L67-L83 is calling https://github.com/chroma-core/chroma/blob/main/chromadb/api/fastapi.py#L172-L188 which should be making a call to the backend which is ingested @ https://github.com/chroma-core/chroma/blob/main/chromadb/server/fastapi/init.py#L224-L229 but I'm not seeing that function actually trigger while running tests.

I don't think this is working due to how fastapi switches support for v1 https://github.com/tiangolo/fastapi/discussions/9966

I added some color here, would love people's thoughts.
https://github.com/chroma-core/chroma/issues/893#issuecomment-1730485796

Closing in favor of #1174 - thanks for helping us think this one through @srhinos


Sentry

Add Sentry integration

Yeah we decided to go with company account for now.
Invites will be sent out once I merge.


Multiple keys with --ssh-key-values

When you need to pass multiple keys when creating a VM I found that this syntax worked:
 --ssh-key-values sshkey-work.pub sshkey-homelenovo.pub
So space separated as described here

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fbbd6dbf-a5be-f8cf-4f8d-08809db1d973
Version Independent ID: 50b13de9-334d-0db5-492c-862935df2cd9
Content: Create and use an SSH key pair for Linux VMs in Azure - Azure Linux Virtual Machines
Content Source: articles/virtual-machines/linux/mac-create-ssh-keys.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn

does this command take ssh public key on string format?
example --ssh-key-value ssh-rsa xxxyyyzzz ssh-rsa zzzaaa


Page information needs updating.

Needs updating. The option to download keys no longer exists.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f67ebee8-4451-c7d4-2c00-720e1886ea12
Version Independent ID: 60e9e39f-3906-150a-f455-375dbdfe119d
Content: Download perpetual software and product license keys bought through the Cloud Solution Provider (CSP) program - Microsoft 365 admin
Content Source: microsoft-365/admin/setup/download-software-licenses-csp.md
Service: o365-administration
GitHub Login: @cmcatee-MSFT
Microsoft Alias: cmcatee

@ericsayles Thank you for your feedback. The option exists if you have purchased the perpetual software through the CSP program(Via Partner). If you still do not see the option to download keys, I'd recommend you to contact Microsoft support via the need help section on the admin center so they can fix it.
Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @ericsayles Hope this comment is helpful for you. Considering the nature of the issue, as advised, please open a service ticket in your tenant and follow with them for the resolution. We proceed to close it as here we are limited to documentation fixes and improvements only.
We will be very happy if you can share the outcome or resolution with us if you see documentation update is required. We will certainly update this documentation with that valuable information. Thanks again, for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


chore: 3943 - removed unused package from pubspec.yaml

What

Removed unused package from pubspec.yaml

Part of

#3943

That was quick @monsieurtanuki 🤣

Thank you @M123-dev for #3956 btw!


Type inference makes mistakes.

Here are some examples of bad type inference in a comparison with the "Rust" VSC expansion. The upper hints are from "Rust" and are correct and the lower hints are from "rust-analyzer".

The next one isn't really wrong, but in other cases it hints with the pub struct String, not just String.

The next one refers to the return type of the unwrap() method.

Is the project open source? It's almost impossible to discover what is wrong without source code.
But from the third image, this might be a case of #1165. Your use crate::* inside the function isn't supported yet, if you move it out of the function everything "should" work correctly.

Yes, it is open source.
Moving use crate::* out of function fixes all mistakes but 3. It is still String.

3 is correct as I see it, the String type is std::string::String (but used in the prelude), unless you are saying that you've defined your own String type.

It seems you are right and I was confused about variables' types hints and hints for the return types of functions in their definitions. Thank you.


Develop merge - release <IP_ADDRESS>

Awaiting https://github.com/luxonis/depthai/pull/242

Thanks.
So if #244 was already present in main (is it @Luxonis-Brian ?) I think we should merge before that.  And then we can hot-fix main based on the fix for #244 .  Thoughts?

checking @Luxonis-Brandon....

Thanks.
So if #244 was already present in main (is it @Luxonis-Brian ?) I think we should merge before that. And then we can hot-fix main based on the fix for #244 . Thoughts?

@alex-luxonis already fixed it, and opened a PR for it (waiting for CI to finish)

Ok perfect thanks!

Yes, it's good to have #244  fixed, as the issue was not present in main.


feat(jsx): Define jsxTemplate/jsxAttr/jsxEscape for "@jsx precompile" of Deno 1.38

What is this PR?
Merging this PR will support the JSX transforms included in Deno's 1.38
https://deno.com/blog/v1.38#fastest-jsx-transform
The async component and renderToReadableStream() are also working.
Benchmark
The following benchmarks were used for comparison
import { bench, run } from 'https://esm.sh/mitata'

const title = '<Hello>'
const name = '<Deno>'
const Component = (props: { name: string }) => (
  <>
    Hello {props.name}!
  </>
)
const getHtml = () => (

      <Component name={name} />

)

if (getHtml().toString() !== '
Hello <Deno>!
') {
  throw new Error('failed')
}

bench('toString()', () => {
  for (let i = 0; i < 10000; i++) {
    getHtml().toString()
  }
})

await run()

"react-jsx" : Previously available
deno.json
{
  "compilerOptions": {
    "jsx": "react-jsx",
    "jsxFragmentFactory": "Fragment",
    "jsxImportSource": "hono/jsx"
  },
  "imports": {
    "hono/jsx/jsx-runtime": "./deno_dist/jsx/jsx-runtime.ts",
    "hono": "./deno_dist/hono.ts"
  }
}

# deno run --allow-read bench-jsx.tsx
cpu: unknown
runtime: deno 1.38.0 (x86_64-unknown-linux-gnu)

benchmark       time (avg)             (min … max)       p75       p99      p995
-------------------------------------------------- -----------------------------
toString()   12.31 ms/iter         (10 ms … 14 ms)     12 ms     14 ms     14 ms

"precompile" : Newly available
deno.json
{
  "compilerOptions": {
    "jsx": "precompile",
    "jsxFragmentFactory": "Fragment",
    "jsxImportSource": "hono/jsx"
  },
  "imports": {
    "hono/jsx/jsx-runtime": "./deno_dist/jsx/jsx-runtime.ts",
    "hono": "./deno_dist/hono.ts"
  }
}

# deno run --allow-read bench-jsx.tsx
cpu: unknown
runtime: deno 1.38.0 (x86_64-unknown-linux-gnu)

benchmark       time (avg)             (min … max)       p75       p99      p995
-------------------------------------------------- -----------------------------
toString()    7.65 ms/iter          (6 ms … 72 ms)      8 ms     72 ms     72 ms

Author should do the followings, if applicable

[x] Add tests
[x] Run tests
[x] yarn denoify to generate files for Deno

I'm trying to figure out how to write a concise test...

Completed some minor adjustments.

Hi @usualoma!
This is a super interesting feature and awesome work! The point is that you can do this with just a few code changes, which is cool!
hono/jsx may be the first JSX engine to support jsx: precompile outside of Preact.
Looks good to me. I'll merge this into "next" later. Thanks a lot!


Look into founding a German "Verein" for ORT to be able to receive donations

Also paying for services (servers, DBs etc.) might be easier with a "Verein".

Closing as TSC decided against it on July 1st, 2021 due to limitations discovered by @mnonnenmacher.


gtk: make sure that window-decoration is honored on all paths

Fix a regression from #4110 .

I confirm that this fixes the regression.

With this config the problem of the absent window decoration still reproduces:
keybind = ctrl+z=toggle_window_decorations
window-decoration = true
gtk-titlebar = false

The GTK titlebar is not shown: correct
The native WM decoration with its titlebar is not shown: incorrect
Pressing ctrl-z shows some minor change to the window border, but also then the WM decoration with its titlebar is not displayed.

With this config the problem of the absent window decoration still reproduces:
keybind = ctrl+z=toggle_window_decorations
window-decoration = true
gtk-titlebar = false

The GTK titlebar is not shown: correct The native WM decoration with its titlebar is not shown: incorrect
Pressing ctrl-z shows some minor change to the window border, but also then the WM decoration with its titlebar is not displayed. And pressing ctrl-t to create a new tab crashes ghostty.

I don't think that this is directly a result of this PR. I'm getting the following logs when I try and toggle window decorations:
debug(surface): key event binding flags=input.Binding.Flags{ .consumed = true, .all = false, .global = false } action=toggle_window_decorations
warning(gtk): unimplemented action=apprt.action.Action.Key.key_sequence

Indeed this PR is not the cause, but it is related. The problem is originally from commit a7c93cd I think, as there are multiple commits modifying Window.zig it's not easy to determine, but if this PR is to "make sure that window-decoration is honored on all paths" the mentioned issue also needs to be solved.
Thank you.

With this config the problem of the absent window decoration still reproduces:
keybind = ctrl+z=toggle_window_decorations
window-decoration = true
gtk-titlebar = false

Ah, I think I understand. When gtk-titlebar=false the titlebar will never be shown, even when toggling window decorations. I'm not sure if that's a regression from previous behavior or not, those are not options that I use.
The decorations are toggling but it's very hard to see as it's basically just a shadow.

I'm not sure how to address this, but without a fix for the regression ghostty is no longer usable in case gtk-titlebar=false.

Indeed this PR is not the cause, but it is related. The problem is originally from commit a7c93cd I think, as there are multiple commits modifying Window.zig it's not easy to determine, but if this PR is to "make sure that window-decoration is honored on all paths" the mentioned issue also needs to be solved. Thank you.

Hmm... The user has explicitly told Ghostty that they do not want a titlebar via --gtk-titlebar=false and that's not what we are toggling. In any case, I don't think that this is going to be a easy/quick fix as we don't even create a titlebar if --gtk-titlebar=false.

Indeed gtk-titlebar is false, but window-decoration is true so the native window title bar should be show just like it was before today;s commits.

I checked out 1.0.0 and tested:
gtk-titlebar: false
window-decoration: true
Titlebar was shown on launch but could be hidden with toggle_window_decorations
gtk-titlebar: true
window-decoration: true
Worked as expected.
gtk-titlebar: true
window-decoration: false
Worked as expected.
gtk-titlebar: false
window-decoration: false
toggle_window_decorations had no effect, titlebar and decorations never appeared
So I don't think that this was ever working 100% as one would expect.

@artist-artix Please open a new discussion about the interaction of gtk-titlebar, window-decoration, and toggle_window_decorations. It's broken now, but it was broken before, just in a different way. Part of the problem is that the interaction between these options isn't well defined/documented so the behavior has changed as different people have worked on the code. We'll use the new discussion to iron out those details and update the documentation and the code to match.

I have opened https://github.com/ghostty-org/ghostty/discussions/4172

I checked out 1.0.0 and tested:
gtk-titlebar: false
window-decoration: true
Titlebar was shown on launch but could be hidden with toggle_window_decorations

This is exactly as expected and how it is supposed to work when reading the documentation. So in 1.0 this was NOT broken.

This is exactly as expected and how it is supposed to work when reading the documentation. So in 1.0 this was NOT broken.

That is not how I would expect things to work, and yes I've read the documentation. So as I said there's both documentation problems and code problems. Please open a new discussion so that we can figure out what the interactions should be between these options rather than continuing the discussion here.


[Bug] US - Blank Images and throws 'Error: The image does not have a complete color palette. R, G, and B palette data are required.'

Describe the Bug
Hi, I am still encountering the same error as in my previous issue #4075. My US (multi-frame) DICOM images with PALETTE COLOR photometric interpretation still cannot be viewed, even though I am using the latest master branch version (3.9.38) as you said it was fixed in dev.
Steps to Reproduce

Download the exported Ultrasound (US) DICOM images from this link (https://drive.google.com/file/d/17xuICqMgf5v4cosGWRuNlt7R9n4Kq8aS/view?usp=sharing).
Upload the DICOM images to OHIF using the latest master branch version (3.9.38).
View the DICOM images using the basic viewer.

The current behavior
The cornerstone in the basic viewer still returns a blank screen. For example, when using the version 3.9.38, it throws this error.

fetchPaletteColorLookupTableData.js:70
 No data found for [object ArrayBuffer] palette
convertPALETTECOLOR.ts:59
 Uncaught (in promise)

Error: The image does not have a complete color palette. R, G, and B palette data are required.
    at convertPALETTECOLOR.ts:59:13
DataArray.js:518
 Uncaught (in promise)

RangeError: model.size is not a multiple of model.numberOfComponents
    at p (DataArray.js:518:11)
    at Object.n [as newInstance] (macros2.js:917:5)
    at ue.createVTKImageData (StackViewport.ts:1659:25)
    at ue._createVTKImageData (StackViewport.ts:1690:28)
    at ue._updateActorToDisplayImageId (StackViewport.ts:2352:10)
    at ue.renderImageObject (StackViewport.ts:2171:14)
    at renderToCanvasGPU.ts:178:36
    at new Promise (<anonymous>)
    at oe (renderToCanvasGPU.ts:101:10)
    at u (loadImageToCanvas.ts:146:7)

The expected behavior
The DICOM should be displayed like this (OHIFv2 or other DICOM viewers like the MedDream demo).
OHIFv2 Viewer

MedDream Viewer

OS
Ubuntu 22.04.3 LTS
Node version
20.12.2
Browser
Chrome 123.0.6312.122 (Official Build) (64-bit)

So i will close the other issue since you opened a new one

I got additional information for this issue. It might be that the issue is related to how OHIF or Cornerstone interprets the Palette Color metadata. The LUT handling isn't correctly implemented, resulting in a blank screen.
I attempted to reproduce the issue using another ultrasound image from [these sample], which also uses palette color interpretation for US images, and encountered the same blank screen.
However, when I converted the DICOM file using my Python script to YBR then opened it on OHIF, it displayed correctly.

Hey, which samples from this link https://www.aliza-dicom-viewer.com/download/datasets are you using to display? There are many available.

I used multi-frame ultrasound image that appeared affected, so you can choose one of them from the datasets

So this works fine in latest, i guess we can close this issue?

Can you check the latest OHIF viewer, which now includes Cornerstone 3D 2.0?
Here are the migration guides:
Try OHIF locally: https://viewer-dev.ohif.org/localbasic
Try Cornerstone3D 2.0 locally: https://www.cornerstonejs.org/live-examples/local.html
https://docs.ohif.org/migration-guide/3p8-to-3p9/

Wow, I tried it using the viewer-dev with the same DICOM from the datasets, and it worked just fine. Thanks a lot for this! We'll look into it further, but for now, we can close this issue. Thanks again.


Use GH checks' markdown content for announcements, news

The output of our architecture discussion: we could utilise the markdown content to include links to the current blogposts/news in Packit in general. The place could be more visible to users and still should not be disruptive.
Example check https://github.com/packit/packit/pull/1786/checks?check_run_id=9573901707 : we would attach after the table few lines with links, e.g.
If you are interested in the changes in Packit, see our latest blog post.
Figure out:

[ ] what kind of information to include
[ ] a flexible way to include the links

This was implemented in #1881, closing.


Please clarify the difference between pigpio and pigpiod C interface

In what cases would a person choose to use the pigpio C interface instead of the pigpiod C interface? Are there performance differences? It appears a similar if not identical set of functions are included.

The proper choice depends on what you plan to achieve.
A simplistic assessment is

C linked against pigpio. Fastest code, slowest development. Only one program linked against the pigpio library can be running at a time (the program in effect becomes the pigpio daemon).  Program can only run on the Raspberry Pi.

C linked against pigpiod_if2 (via pigpio daemon): Fast code, fast development.  Requires the pigpio daemon to be running.  Many programs can be running at any one time talking to the pigpio daemon.  Programs can be compiled and run on any machine with a suitable compiler, e.g. Linux, Windows, Mac.

Python (via pigpio daemon). Slowest code, fastest development.  Requires the pigpio daemon to be running.  Many programs can be running at any one time talking to the pigpio daemon.  Programs can be run on any machine with a suitable Python interpreter, e.g. Linux, Windows, Mac.

The accuracy of PWM,  Servo pulses, callbacks etc. is the same regardless of the above choice.

Choice 1. is what you need MHO if you have to protect certain pins / functions again spurious changes from proto-type or unprivileged code - I have a UPS daemon running on one of my RPis and that needs exclusive control/access: to a GPIO pin used to monitor a critical function (power WILL be GONE 45 seconds after pin is taken low by UPS ⚡ ); and to: the serial port which it uses for frequently and regular communicating with the UPS to monitor other status details.
In that situation where this daemon is started in /etc/rc.local {I'm a sysV init fan who thinks systemd is daemon spawn rather than it being something to spawn daemon :rofl:} with root privileges it is not unreasonable for it to provide the functions of the pigpiod daemon - though as I mentioned in #63 it meant I had to tweak the signal handling otherwise it would die as soon as it got signals associated with debugging it!

Yes @SlySven, good point.
With Choice 1 you get much more control of who is allowed to manipulate the GPIO and how.
The permissions to access GPIO may be set (read only or read write) as well as enabling/disabling the socket and pipe interfaces.

Though if you do go that route you'd be advised to have something to check for the PID file the daemon or other program acting as it before trying to instantiate another daemon providing the library functions - this is what I'm currently using:
    // ... near top of main() ...
    // Test for existance of lockfile as proof of another instance of this or pigpiod
    // already running
    int lockFilePid = initCheckLockFile();
    if( lockFilePid > 0 ) {
        syslog( LOG_WARNING, "an instance of this, the pigpiod daemon or some other program using the pigpio library is already running (as Process %i) and only one may operate at any time please investigate that process and kill it before trying to run this program again.",
                lockFilePid );
        closelog();
        exit( EXIT_FAILURE );
    }
    else if( lockFilePid == -1 ) {
        syslog( LOG_WARNING, "an instance of this, the pigpiod daemon or some other program using the pigpio library is already running and only one may operate at any time please investigate that process and kill it before trying to run this program again." );
        closelog();
        exit( EXIT_FAILURE );
    }
    // ...

The define for PI_LOCKFILE is located in the pigpio.h that you will of course need to #include :
// Returns:
// (positive) PID of instance of daemon already running!
// 0 if there is no lockfile
// -1 if there is a lockfile but cannot make sense of contents
int initCheckLockFile(void)
{
    int fd;
    int count;
    int pid = 0;
    char str[20];

    fd = open( PI_LOCKFILE, O_RDONLY );
    if( fd != -1 ) {
        pid = -1;
        count = read(fd, str, sizeof(str)-1);
        if( count ) {
            pid = atoi( str );
        }
        close( fd );
    }
    return pid;
}

Thanks for all the thoughtful answers.


New package: DeveloperInsider.TurboC++ version 3.2

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

This is a C++ Package to install TurboC++ for Windows so that programmers can use winget to install TurboC++

@microsoft-github-policy-service agree

@TheGidoGod please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@TheGidoGod please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Automatic Validation ended with:
(Automated response - build 887.)

Manual Validation ended with:


Is v1.8.0 the last Mojave (10.14.6) supported build?

Is v1.8.0 the last Mojave (10.14.6) supported build?
I can perfectly understand the reason(s) to move on.  (I too manage software-development projects.)
fwiw, I'm often "One of the Last Person(s) to Upgrade," because I do not trust Apple to be an "Organization That Knows How to Properly Architecturally-Design and Test Software for Large Scale Reliability." (They've demonstrated this to me, repeatedly, especially with macOS.)
If the above is true, Fastmate.app will now probably be the first app that will motivate me to upgrade to Catalina. I'm sure there will be more to come. I'm not complaining, just noting. I work with reality as much as possible.  🤓

Unfortunately it is! However, I wouldn't stress updating just yet, for now the only practical difference is a bug fix regarding quotations in email titles (d561d9f5f6ae6a03264423a5642bf300c719a676) and I imagine 1.8.0 will work perfectly fine apart from those small bug fixes for a long time. I don't have any major changes planned for now.
I totally understand your reasoning and I've long hesitated to do a Swift rewrite because of backwards compatibility reasons. If something critical comes up, I might backport those updates to the 1.8.0 branch if a lot of people keep using Fastmate on Mojave.

Pointing out that while staying on Mojave is certainly preferable, considering the disaster that was Catalina and is Big Sur/Mojave, the reality is that Mojave is no longer receiving security patches.
So you need to figure out what you are going to do about that.

Keeping a backported version seems like quite a hassle, specifically now that Ventura is on the horizon and we've already had Catalina and Monterey following up after Mojave.

In case it matters: I have upgraded to macOS Catalina and Fastmate functionally works on it (although on my current laptop its grown remarkably slow... not sure where the slowness issue might originate, could be Fastmail.com, some software config on Catalina, etc).
I'll probably upgrade to BigSur in Q4/2022 or sooner.

Following up here, my blank-screen-on-launch problem was resolved.  In case anyone else should run into this:

First, by trying another user account, I found that Fastmate v1.8.0 did still work on macOS 10.14.6.  So it should work, and maybe something was off in the other user's profile or some such.
Then in Mac's user account with the problem, I did a more "thorough" uninstall (with AppCleaner [0]).  Then, reinstalling FastMate and prompted to sign in, and let Fastmate work as normal.

Phew.
[0] https://apple.stackexchange.com/a/446853

@u35253 thanks for trying and updating with your findings!


Fix kwazthis test [phab:D249]

Created by schroederc at 2015-05-13 22:16:38:

fromberger accepted this revision at 2015-05-14 00:47:14

schroederc closed via commit 09e5689b909cacbd1de96e9ec646f0ef71348d7f at 2015-05-14 16:05:38


Nullable not working correctly when using $ref

Hello @davishmcclurg!
I stumble upon this issue where nullable: true is not honored when used in a field declared with $ref. This is my exact example.
Volume:
      type: object
      description: A representation of a volume in the system, which can be attached to virtual machines.
      properties:
        id:
          type: integer
          format: int32
          description: The unique identifier of the volume.
          example: 1
        object:
          type: string
          enum: [volume]
          description: The object type, which is always "volume" for volumes.
        name:
          type: string
          description: The name of the volume.
          example: swagger-vol
        size_bytes:
          type: integer
          format: int64
          description: The size of the volume, in bytes.
          example:<PHONE_NUMBER>0
        status:
          type: string
          description: The current operational status of the volume.
          example: in_use
          enum:
            - creating
            - in_use
            - available
            - deleting
        volume_attachment:
          nullable: true
          $ref: '#/components/schemas/VolumeAttachment'

I have created a test that reproduces the problem, the last assert is not passing when it should IMO => https://github.com/bilby91/json_schemer/blob/8097bd3d9a497a6803c71d31cd5bf23bf7326372/test/open_api_test.rb#L1119
I've also found a typescript implementation where they are handling this "correctly" => https://github.com/acacode/swagger-typescript-api/pull/40

@davishmcclurg I was able to get the test passing without breaking any other test. Here is the PR => https://github.com/davishmcclurg/json_schemer/pull/200
I know that the PR might need adjustment since I'm impacting draft202012 instead of OpenAPI 3.0 but I wasn't able to figure out how to hook the type yet.

nice, I just hit this

Hi @bilby91, thanks for reporting this and for taking the time put together a fix. Unfortunately, I think this is expected behavior. From the OpenAPI 3.0 specification section on $ref:

This object cannot be extended with additional properties and any properties added SHALL be ignored.

OpenAPI 3.0 is based on JSON Schema Draft 4, which uses "JSON Reference":

Any members other than "$ref" in a JSON Reference object SHALL be ignored.

Same behavior in draft 4:
?> schema = JSONSchemer.schema(
?>   {
?>     '$ref' => '#/definitions/example',
?>     'minLength' => 2,
?>     'definitions' => {
?>       'example' => {
?>         'type' => 'string',
?>         'maxLength' => 2
?>       }
?>     }
?>   },
?>   :meta_schema => JSONSchemer.draft4
>> )
=> #<JSONSchemer::Schema @value={"$ref"=>"#/definitions/example", "minLength"=>2, "definitions"=>{"example"=>{"type"=>"string", "maxLength"=>2}}} @parent=nil @keyword=nil>
>> schema.valid?('x')
=> true
>> schema.valid?('xx')
=> true
>> schema.valid?('xxx')
=> false

Feel free to reopen if you'd like to discuss further.


remove check service principal key requirement logic

Remove service principal key requirement logic from exception. Key is not supported anymore

@LiliDeng LGTM


Cache not working

ci.yml:
  check:
    name: 'check'
    runs-on: ubuntu-latest
    if: github.event_name != 'push'
    steps:
      - uses: actions/checkout@v4
      - uses<EMAIL_ADDRESS>      - uses: dtolnay/rust-toolchain@stable
        with:
          components: clippy
      - uses<EMAIL_ADDRESS>        with:
          ssh-private-key: ${{ secrets.XXXX_SSH_KEY }} ${{ secrets.XXXX_SSH_KEY }}
      - uses: taiki-e/install-action@just
      - uses: baptiste0928/cargo-install@v3
        with:
          crate: cargo-cranky
      - uses: eifinger/setup-rye@v1
        with:
          enable-cache: true
      - uses: docker/setup-qemu-action@v3
        with:
          platforms: 'arm64'
      - run: |
          just install
          just check

The run basically does:
rye sync --no-lock
rye lint
rye run mypy

Run eifinger/setup-rye@v1:
  with:
    enable-cache: true
    version: latest
  env:
    CARGO_INCREMENTAL: 0
    CARGO_NET_GIT_FETCH_WITH_CLI: true
    RUSTC_WRAPPER: sccache
    RUSTFLAGS: -Dwarnings
    SCCACHE_GHA_ENABLED: true
    SCCACHE_PATH: /opt/hostedtoolcache/sccache/0.7.7/x64/sccache
    ACTIONS_CACHE_URL: https://acghubeus1.actions.githubusercontent.com/XXXXXXXXXXXXXXXXXX/
    ACTIONS_RUNTIME_TOKEN: ***
    CARGO_TERM_COLOR: always
    SSH_AUTH_SOCK: /tmp/ssh-XXXXXXRYONL9/agent.1718
    SSH_AGENT_PID: 1719
Latest version is 0.24.0
Downloading Rye from "https://github.com/mitsuhiko/rye/releases/download/0.24.0/rye-x86_64-linux.gz" ...
Extracting downloaded archive...
/usr/bin/gunzip /home/runner/work/_temp/785c558a-0255-4e63-9161-ssssssssssss.gz
/usr/bin/chmod +x /home/runner/work/_temp/785c558a-0255-4e63-9161-ssssssssssss
Installing Rye into /home/runner/work/_temp/rye_temp_home
/home/runner/work/_temp/785c558a-0255-4e63-9161-ssssssssssss self install --yes
Welcome to Rye!

This installer will install rye to /home/runner/work/_temp/rye_temp_home
This path can be changed by exporting the RYE_HOME environment variable.

Details:
  Rye Version: 0.24.0
  Platform: linux (x86_64)

Installed binary to /home/runner/work/_temp/rye_temp_home/shims/rye
Bootstrapping rye internals
Downloading<EMAIL_ADDRESS>Checking checksum
success: Downloaded<EMAIL_ADDRESS>Upgrading pip
Installing internal dependencies
Updated self-python installation at /home/runner/work/_temp/rye_temp_home/self

The rye directory /home/runner/work/_temp/rye_temp_home/shims was not detected on PATH.
It is highly recommended that you add it.
Added to PATH.
note: for this to take effect you will need to restart your shell or run this manually:

    source "/home/runner/work/_temp/rye_temp_home/env"

error: process ID out of range

Usage:
 ps [options]

 Try 'ps --help <simple|list|output|threads|misc|all>'
  or 'ps --help <s|l|o|t|m|a>'
 for additional help text.

For more details see ps(1).
For more information read https://mitsuhiko.github.io/rye/guide/installation

All done!
Moved Rye into /opt/hostedtoolcache/rye/0.24.0/x86_64
Added /opt/hostedtoolcache/rye/0.24.0/x86_64/shims to the path
Cache is not found

If you run this action for the first time it will not find a cache yet. It is created in the Post step. Do you have a public workflow run you can link here?

For example in this run the cache is created here: https://github.com/eifinger/setup-rye/actions/runs/7914237486/job/21603560019#step:7:6

Actually, it is working in our test workflow, but not in our check workflow. Unfortunately, it is not a public repo or something that I can share. I'm closing for now.

You can also run with debug logging enabled to get more information what is happening


The item Medichamite might be missing in the output

The issue existed when I tried to paste an ORAS OU team extracted from showdown team builder.
I tested seven mega stones, and Medichamite was the only one missing at the moment.
There is a proof as: https://pokepast.es/183ce6779536a2f2
Could you please have a look while available? I really appreciate this converter and it delights me. Thank you so much.

Thanks for pointing this out! I had a closer look and Houndoominite was missing too. Both should be added now.

Thanks for pointing this out! I had a closer look and Houndoominite was missing too. Both should be added now.

Hi felixphew,
Thanks so much and I saw these two mega stones were already implemented.
However, I had two findings which might deserve a looking, as the text colour of items sometimes could be a little bit inconsistent with others.
a) The text colour of Medichamite or Houndoomite would be fixed to dark red/brown now, while other mega stones would be all black/white based the on the settings of light mode.
b) The text colour of power boost items (e.g. Mystic water/soft sand) would be synchronised to the colour of type it boosted (water - blue/ground - clay), while I found most other items would be black/white.
Thanks

Hi @jhao7,
For a) (the mega stones), I set that by accident when I was fixing this issue - I thought I had them all highlighted like that, but I misremembered. This should be fixed now.
For b), this is intentional. All the type-boosting items are highlighted in their corresponding type, as are all plates (type boosting / for Arceus), memories (for Silvally), drives (for Genesect), gems, Z-crystals, incenses, and type-resist berries like Wacan (electric), Colbur (dark), Shuca (ground), etc.

Hi @jhao7,
For a) (the mega stones), I set that by accident when I was fixing this issue - I thought I had them all highlighted like that, but I misremembered. This should be fixed now.
For b), this is intentional. All the type-boosting items are highlighted in their corresponding type, as are all plates (type boosting / for Arceus), memories (for Silvally), drives (for Genesect), gems, Z-crystals, incenses, and type-resist berries like Wacan (electric), Colbur (dark), Shuca (ground), etc.

Yep. So that was why I said 'personally speaking" for the second finding. Quite appreciate for your devotion.


Fantasic example, but won't work for .NET Core 3+

Hi,
I really appreciate people who put their time into producing code like this to help people like myself, but every time I find a useful example, it has been broken by changes to .NET Core versioning. In this case, the DefaultRazorPageFactoryProvider class and other Razor classes have now been changed to Internal in .NET Core 3.0, making them inaccessible.
Trying to figure out a way around it as I type.
Thanks,
Darren

Not sure what Razor has to do with this, but I can confirm this example doesn't seem to work in .NET Core 3.1. It looks like the hosted service is started before Configure is called.
The StartAsync method is async, but ASP.NET Core will wait around for us to start before doing anything else (boo!) but we can just spin off a new task and wait there.
`		public Task StartAsync(CancellationToken cancellationToken) {
Task.Run(this.GoAsync);
return Task.CompletedTask;
}
	private async Task GoAsync() {
		while (ServerAddresses == null) {
			await Task.Delay(250);
		}
                   /* same as before, but remove the return Task.CompletedTask */

`


Added Finnish replacement characters

Hi all. I added Finnish replacement characters into the character arrays.
All PHPUnit tests are passed, so the build is good to go.

Coverage decreased (-0.35%) to 97.3% when pulling e2a273cb4d0bc2607269bba29c93ee2d45ef83a7 on Newman101:master into f384f9521de065e9f29f7b5e6a2ae8f5594c1787 on brandonwamboldt:master.

Coverage remained the same at 97.65% when pulling bbdd4ecb757f2a7c3fa7bc8cbaebae1f097776df on Newman101:master into f384f9521de065e9f29f7b5e6a2ae8f5594c1787 on brandonwamboldt:master.

Thanks!


Attempting to fix spring upgrade to 5.3.13

What's this PR do/fix?
Attempting to upgrade spring framework to the latest and spring boot
Are there unit tests? If not how should this be manually tested?
No I haven't done any yet but not sure if they are required as current tests might cover this change.
Any background context you want to provide?
Latest springframework is deprecating PatternsRequestCondition and it's no longer the default https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-2.6-Release-Notes#pathpattern-based-path-matching-strategy-for-spring-mvc
What are the relevant issues?
springfox swagger won't load when using the latest springframework or spring-boot

Could you squash commits as one and force push?

Any idea when this will be merged?


Create the run script if it doesn't exist on build

The run script is created at porter create but really it's a boring file that we don't encourage people to modify. Let's make it so that if its not present during porter build, we recreate it for them. That way you can just check in the run script if you modified it.

Hey @carolynvs, this looks like an interesting issue to tackle but I'm new to porter and might be missing some context. I'm unsure about how a bundle author would get into this scenario and what would be the expected outcome after running porter build?

Great! Here is what I did to get myself into this situation. 😊

I didn't actually run porter init. I copied an existing porter.yaml from an example.
I then immediately ran porter build and it failed because the cnab directory and run script was missing.

Another way to have this problem is to do this

Run porter init, porter creates the cnab/ directory and run script (cnab/app/run).
Forget, or not understand, to check it in. Only check in the porter.yaml
Now go to another computer, or do a git clean, etc. You don't have a cnab directory and run script anymore.
Try to run porter build and you get an error again.

Both situations are pretty easy for porter to fix because the cnab directory and run script are easy for porter to recreate if missing during the build command.
What I hope to see is when the user runs porter build, the function "prepareDockerFilesystem" in https://github.com/deislabs/porter/blob/master/pkg/porter/build.go should check if run script exists at cnab/app/run. If not, it should execute the Create function again in https://github.com/deislabs/porter/blob/master/pkg/porter/create.go.
If you need to reorganize the functions a bit, that's OK.

This has now been implemented


Do we still have to configure the rule in Windows Firewall on the VM?

It's unclear whether adding the rule through the azure portal, will also update the windows firewall rules on the actual VM itself, or do we have to add a rule there too?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4b29d46b-5a37-3e56-00a5-98971bce4f6c
Version Independent ID: 87d3401e-dca7-20b1-5544-64f72e83eb54
Content: Open ports to a VM using the Azure portal - Azure Virtual Machines
Content Source: articles/virtual-machines/windows/nsg-quickstart-portal.md
Service: virtual-machines
GitHub Login: @cynthn
Microsoft Alias: cynthn

Hi dazinator,
Using Azure Network Security Group rules to block/allow traffic is sufficient. Setting the rules using the Azure portal will update the VM's OS level firewall rules for you so there is no need to go in and adjust the rules directly on the VM itself. There are some use cases where you may need to update the firewall rules directly on the VM but in most cases you will not need to.
I hope this helps!
-Jessica


Fix typo from rollup.yaml

Hello guys,
I'm sending some suggestion to this interface.
https://github.com/cartesi/openapi-interfaces/pull/9

Merged, thanks!


Refactor scheduler

Description

Related Issue
fix #366

Motivation and Context

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation Update (if none of the other choices apply)

Checklist:

[x] Code compiles correctly.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #369 (7481a54) into main (9af0bab) will increase coverage by 2.98%.
The diff coverage is 20.12%.

@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   36.51%   39.49%   +2.98%
==========================================
  Files          89       81       -8
  Lines        6959     6284     -675
==========================================
- Hits         2541     2482      -59
+ Misses       4051     3441     -610
+ Partials      367      361       -6

Flag
Coverage Δ

e2etests
?

unittests
39.49% <20.12%> (+2.98%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cdnsystem/daemon/cdn/manager.go
57.57% <ø> (+1.14%)
:arrow_up:

cdnsystem/server/service/cdn_seed_server.go
0.00% <0.00%> (ø)

client/config/peerhost.go
35.48% <ø> (ø)

client/daemon/proxy/proxy.go
7.98% <0.00%> (ø)

client/daemon/proxy/reverse_proxy.go
0.00% <0.00%> (ø)

client/daemon/service/manager.go
33.00% <ø> (ø)

internal/idgen/uuid.go
50.00% <0.00%> (-50.00%)
:arrow_down:

pkg/source/source_client.go
0.00% <0.00%> (ø)

pkg/structure/sortedlist/sorted_list.go
58.58% <ø> (ø)

scheduler/config/config.go
0.00% <0.00%> (ø)

... and 10 more


Feat faq component

Here is a video of the functionality of the FAQ:
https://github.com/CS633SP23Team4/magic-kitchen/assets/35639529/02589b28-9364-44ee-b36b-adf298126b74

Online Demo appears to not working yet

@ah0606

Is this expected or maybe we should just use 1 per row.


test: Demonstrate Proof with invalid Num Leaves incorrectly verifies

New test generated by https://github.com/FuelLabs/fuel-vm/pull/721/files#diff-e200c85df3463cea05788a48e5f4cd3a796f2b169cd113c2378e1a0b4a123091R198

Closing as not an issue


Update readme.md

Add a link for Feishu Bot

Looks great @linjungz 😄
I'd recommend adding a screenshot to your readme :)


SB-1266: PropertiesBooter improvements

More fixes.

No. Would you like to poke around?

@sbespalov , @fuss86 , @ptirador ,
We need to figure out the issues with the spring.main.allow-bean-definition-overriding. When this is not set to true, Spring fails to initialize.

@carlspring

Sort out the strongbox.vault_IS_UNDEFINED issue. This is related to the logs and a logging property which is somehow not set, or not set on time.

this is also fixed with this commit

Thanks, @sbespalov !

A massive thanks to everyone who helped out! :)


ESR - Support Other Chains

Is your feature request related to a problem? Please describe.
The ESR specification has a "chain_id" in the payload
https://github.com/eosio-eps/EEPs/blob/master/EEPS/eep-7.md#chain_id
Describe the solution you'd like
Support chain_id - that means we can sign any requests on any chain, EOS, Telos, WAX, Telos Testnet, and so on - just as long as we have keys for the signing of the request.
Initially this will be useful mostly for Telos Testnet, since we're not set up to import EOS accounts...
Additional context

The LW TokenModel includes chain, contract, and symbol. It wouldn't be a huge stretch to support currency cards and send/receive token actions for any eosio chain.


TextFormat Performance:  Avoid quadratic behavior for map and Any fields

Credit: OSS-Fuzz
The TextFormat encoding visitor would create a new child visitor when traversing into map or Any fields.  This resulted in multiple references to the underlying byte array, triggered unnecessary copy-on-write operations, which led to quadratic behavior for large messages with lots of map and/or Any fields.
Regular message fields didn't have this problem because we didn't create a new visitor in that case -- instead we adjusted the configuration of the current visitor object.  This adjusts the handling of map and Any fields to work the same way.
The test case demonstrates > 100x performance improvement for a multi-megabyte text encoding of a message containing 50,000 map fields or Any fields.  The test was tuned so that on a fast machine it used to take >60s but now takes well under 1s.  Hopefully, if anything regresses here, that will be a glaring enough difference to call attention to it.

This replaces #1321


[HOLD][No QA] Add automated tests for Report actions/ Pusher

cc @AndrewGable
This adds a mocked test for one of our most critical flows
Optimistic comment > Create comment in server (this is mocked) > Pusher handles comment > Expected response verified in Ion
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/145497
Tests
Automated tests were added.
Screenshots
❌

Gonna close this until I have time to investigate how to fix this. Also I think we should have a broader conversation about testing and test conventions. Specifically, agreeing to the use of async/await to make linear testing of asynchronous JS easier would be nice. That was my main blocker when attempting to write these tests.


Mysql db not able to sync fully, it fails snapshotting after 25M, syncs the table over and over again

The debizium connector fails periodically and starts syncing everything again
This is the config file we set up https://gist.github.com/Lokesh14120/dd38d7cc7d07d61576eff318c2d77384
System specifications
Cpu :- 8 core
Ram :- 16 gb
This is the execution entry point
"sh", "-c", "java -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 -XX:ParallelGCThreads=4 -Xms6g -Xmx6g -Dlog4j2.configurationFile=log4j2.xml -jar /app.jar /config.yml com.altinity.clickhouse.debezium.embedded.ClickHouseDebeziumEmbeddedApplication"
These are the errors we encountered.
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.pipeline.ChangeEventSourceCoordinator - Context created
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.connector.mysql.MySqlSnapshotChangeEventSource - No previous offset has been found
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.connector.mysql.MySqlSnapshotChangeEventSource - According to the connector configuration both schema and data will be snapshotted
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.relational.RelationalSnapshotChangeEventSource - Snapshot step 1 - Preparing
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.relational.RelationalSnapshotChangeEventSource - Previous snapshot was cancelled before completion; a new snapshot will be taken.
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.relational.RelationalSnapshotChangeEventSource - Snapshot step 2 - Determining captured tables
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.connector.mysql.MySqlSnapshotChangeEventSource - Read list of available databases
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.connector.mysql.MySqlSnapshotChangeEventSource -    list of available databases is: [dnsbl_checks, experimental, information_schema, mysql, performance_schema, ri_mailer, ri_mailers, sys]
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.connector.mysql.MySqlSnapshotChangeEventSource - Read list of available tables in each database
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.connector.mysql.MySqlSnapshotChangeEventSource -   snapshot continuing with database(s): [ri_mailer]
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.relational.RelationalSnapshotChangeEventSource - Adding table ri_mailer.custom_domain to the list of capture schema tables
[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] INFO io.debezium.relational.RelationalSnapshotChangeEventSource - Adding table ri_mailer.webhook_logs to the list of capture schema tables```

```[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] ERROR io.debezium.relational.RelationalSnapshotChangeEventSource - Error during snapshot
java.lang.InterruptedException
        at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1638)
        at java.base/java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:435)
        at java.base/java.util.concurrent.ExecutorCompletionService.take(ExecutorCompletionService.java:200)
        at io.debezium.relational.RelationalSnapshotChangeEventSource.createDataEvents(RelationalSnapshotChangeEventSource.java:467)
        at io.debezium.relational.RelationalSnapshotChangeEventSource.doExecute(RelationalSnapshotChangeEventSource.java:165)
        at io.debezium.pipeline.source.AbstractSnapshotChangeEventSource.execute(AbstractSnapshotChangeEventSource.java:92)
        at io.debezium.pipeline.ChangeEventSourceCoordinator.doSnapshot(ChangeEventSourceCoordinator.java:253)
        at io.debezium.pipeline.ChangeEventSourceCoordinator.doSnapshot(ChangeEventSourceCoordinator.java:237)
        at io.debezium.pipeline.ChangeEventSourceCoordinator.executeChangeEventSources(ChangeEventSourceCoordinator.java:189)
        at io.debezium.pipeline.ChangeEventSourceCoordinator.lambda$start$0(ChangeEventSourceCoordinator.java:137)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:833)
[Sink connector Debezium Event Thread] INFO io.debezium.pipeline.signal.SignalProcessor - SignalProcessor stopped```

```[debezium-mysqlconnector-embeddedconnector-change-event-source-coordinator] ERROR io.debezium.relational.RelationalSnapshotChangeEventSource - Error during snapshot
java.lang.InterruptedException
        at java.base/java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:1638)
        at java.base/java.util.concurrent.LinkedBlockingQueue.take(LinkedBlockingQueue.java:435)
        at java.base/java.util.concurrent.ExecutorCompletionService.take(ExecutorCompletionService.java:200)
        at io.debezium.relational.RelationalSnapshotChangeEventSource.createDataEvents(RelationalSnapshotChangeEventSource.java:467)
        at io.debezium.relational.RelationalSnapshotChangeEventSource.doExecute(RelationalSnapshotChangeEventSource.java:165)
        at io.debezium.pipeline.source.AbstractSnapshotChangeEventSource.execute(AbstractSnapshotChangeEventSource.java:92)
        at io.debezium.pipeline.ChangeEventSourceCoordinator.doSnapshot(ChangeEventSourceCoordinator.java:253)
        at io.debezium.pipeline.ChangeEventSourceCoordinator.doSnapshot(ChangeEventSourceCoordinator.java:237)
        at io.debezium.pipeline.ChangeEventSourceCoordinator.executeChangeEventSources(ChangeEventSourceCoordinator.java:189)
        at io.debezium.pipeline.ChangeEventSourceCoordinator.lambda$start$0(ChangeEventSourceCoordinator.java:137)
        at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
        at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
        at java.base/java.lang.Thread.run(Thread.java:833)
[Sink connector Debezium Event Thread] INFO io.debezium.pipeline.signal.SignalProcessor - SignalProcessor stopped```

Is there something we are missing in the config

We actually tries  snapshot.locking.mode= none  only

This was the config file
https://gist.github.com/Lokesh14120/dd38d7cc7d07d61576eff318c2d77384

@Lokesh14120 : see the above issue. It is a side effect of automatic restart.

it should have resumed processing data from the saved offset. If this feature isn't available yet, it should be considered for future implementation.
We ended up abandoning snapshotting entirely and relied on snapshot.mode: "schema_only" to update data from the binlogs. Additionally, we wrote a script/SQL to backfill data into the ReplacingMergeTree from the MySQL engine.

@Mitrajit for MySQL, you can use this https://github.com/Altinity/clickhouse-sink-connector/blob/develop/sink-connector/python/README.md This works well with snapshot.mode: "schema_only".


Fixed: Layout issue for viewing docs in mobile view

Fixes Issue
Closes #4120

Changes proposed

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

Screenshots
Before

After

Note to reviewers

@swagataroy30 You should also add before screenshot along with after screenshot

I hope this does not break anything, that's why a better approach would be to update the DocsLayout.js instead

Actually I was trying to target this div where i added min-w-fit

this div reduces in size in smaller screen so does the content alongwith, so i set a width to it to fit all it's content and also tried DocsLayout.js but it wasn't working out and i have checked nothing breaks tho!

@swagataroy30 try this and see how it looks

@Aadarsh805 I did try this earlier and tried it again right now this doesn't seem to work, it's not taking up the full width this way. Did you try on all smaller devices? Here's a snap of it after i implemented as you said

@Aadarsh805 I did try this earlier and tried it again right now this doesn't seem to work, it's not taking up the full width this way. Did you try on all smaller devices? Here's a snap of how it looks on my mobile device after i implemented as you said

Works fine on mine though 🤔

@Aadarsh805 I did try this earlier and tried it again right now this doesn't seem to work, it's not taking up the full width this way. Did you try on all smaller devices? Here's a snap of how it looks on my mobile device after i implemented as you said

Works fine on mine though thinking

Did you try other devices below 375? except my mobile i toggled all smaller devices it shows the same

@Aadarsh805 I did try this earlier and tried it again right now this doesn't seem to work, it's not taking up the full width this way. Did you try on all smaller devices? Here's a snap of how it looks on my mobile device after i implemented as you said

Works fine on mine though thinking

Did you try other devices below 375? except my mobile i toggled all smaller devices it shows the same

Oh I see it doesn't work for phone under 375
check out this pr though #4331

I like the simplicity of it, but on the docs page it breaks due to the images, can the images be made more responsive then I think it might work

I like the simplicity of it, but on the docs page it breaks due to the images, can the images be made more responsive then I think it might work

Hey, sure I will try to make changes on this! Thanks for the feedback! :+1:

I like the simplicity of it, but on the docs page it breaks due to the images, can the images be made more responsive then I think it might work

Hey, the visual changes of the navabar getting reduced in smaller screens can be fixed with 'min-w-fit' to the parent container and after applying this it doesn't break anymore but the navbar gets too small in it's overall height but I think it's happening because of the Clipboard as i was trying to check what was going wrong. I did make some changes to fix it - should i commit those changes. Thank You!

Thank you for your contribution. There have been multiple PRs for the same issue. I will close this PR for another one with a different solution https://github.com/EddieHubCommunity/LinkFree/pull/4448
Please have a look at our open issues that are not yet assigned, and ask for one of them to be assigned to you


Increase the WordPress version the plugin was tested with

The current WordPress version is 5.8.x.
https://wordpress.org/download/
After the readme.txt file update in the repo just reupload everything to wordpress.org, without bumping the plugin version. This will fix "this plugin hasn't been tested with the current version of WordPress" notice that right now everyone sees when trying to install Ray plugin.

Thank you!


react 15 compatibility

can you update react version in package.json like :
"peerDependencies": {
    "react": "^0.14.0 || ^15.0.0"
},

Done :)


horizon: enable multidomain support

Required for https://github.com/osism/cloud-in-a-box/pull/184


Fix: error when trying to read an encrypted ec key file

Issue introduced in
https://github.com/openssl/openssl/commit/33a6d5a0e565e08758bcb6af456ec657c3a7a76a
This patch fixes and issue where a key cannot be read after it has been
encrypted using the 'openssl ec' command. Because the header is not
incremented the load_iv method will always fail.

this is a dpulicate of an open ticket just waiting code review.


discuss.apistar.org  activate account link problem

["BAD CSRF"]

I'd suggest refreshing the page and trying again.

As with #203 if you're still seeing this issue, it'd be great if you could give me a clear step by step walk though of exactly what you're doing so that I have something I can forward on to the discourse team.

Could be this?... https://meta.discourse.org/t/solved-bad-csrf-on-attempted-login-issue-with-lastpass-and-discourse/51848
(Interaction with LassPass?)


Kubectl get cs/componentstatuses returns Unknown in embedded/UI shell

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):
Setup custom cluster and execute kubectl get cs via embedded kubectl in UI.
Result:
NAME                 AGE
controller-manager   <unknown>
scheduler            <unknown>
etcd-0               <unknown>
etcd-1               <unknown>
etcd-2               <unknown>

Workaround is to use kubectl get cs -o yaml (or basically anything else than table)
Other details that may be helpful:
Upstream issue: https://github.com/kubernetes/kubernetes/issues/83024
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.3.1
Installation option (single install/HA): single

Can confirm the same after upgrading to rancher v2.3.3. Unfortunately hadn't checked before the upgrade.

v1.16.3.  I get same error. How to fix it?

Seems to be deprecated:
https://github.com/kubernetes/kubernetes/issues/83943

Solved in kube-apiserver v1.17.0, workaround available for older versions

kubectl get cs -o=go-template='{{printf "NAME\t\t\tHEALTH_STATUS\tMESSAGE\t\n"}}{{range .items}}{{$name := .metadata.name}}{{range .conditions}}{{printf "%-24s%-16s%-20s\n" $name .status .message}}{{end}}{{end}}'


Is this still maintained?

I see that the last commit is made 2 years ago. Is this still maintained?
This is a great library!

Use figlet instead. :smile:


Topological Sort

Description
Topological sort is a standard graph algorithm. It is only for Directed Acyclic Graph (DAG) and is a linear ordering of vertices such that for every directed edge u v, vertex u comes before v in the ordering.
Domain
Algorithm
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

I want this assigned to me under GSSOC. Thanks!

I want to work on this under GSSOC2022. Can you assign it to me.


Add a project setting to control the minimum ReflectionProbe roughness

This can be used as a form of antialiasing with very little performance cost.
The default value removes almost all aliasing present in ReflectionProbes while still keeping reflections fairly sharp for real world use cases.
I could only get it working in GLES3, so the feature is limited to GLES3. The default value for the minimum roughness is 0.05 and can be changed at run-time.
This closes https://github.com/godotengine/godot/issues/49789.
Preview
Reflective materials have Roughness = 0, Metallic = 1.
Before (Min Roughness = 0.0)

After (Min Roughness = 0.05)

How does this compare to just setting the material's roughness to 0.05?
Also, I'm a little confused about why this works, for the top level mipmap, the shader uses "USE_DIRECT_WRITE" and just copies the cubemap without blurring based on roughness https://github.com/godotengine/godot/blob/1673e3a8aae56c511dfe802c61436cd6888c8101/drivers/gles3/shaders/cubemap_filter.glsl#L258-L281
For the higher levels, roughness should already be greater than 0.05.

How does this compare to just setting the material's roughness to 0.05?

You don't need to edit any existing materials, and the rest of roughness calculations (such as light energy conservation) is not affected.


Discussion: Ugoira animations and metadata

Recently, an image viewer for Windows named HoneyView received a support for viewing Ugoira animated format. It was per feature request and not present in the latest final build yet. Details here.
Right now, actual requirements in HoneyView for the file to be processed as Ugoira animation are:

it should have .ugoira extension. (currently PixivUtil2 writes them as .zip)
it should contain a file animation.json inside the zip package. (currently PixivUtil2 saves those as .js near the .zip under the same name, when 'writeugoirainfo' is enabled)

Metadata is currently located in plain text on the image page on Pixiv, and it likely won't change any time soon. There won't be any official way to either save Ugoira zip as a file or animation, and metadata will stay in plain html text. So, maybe if there is enough demand from several 3rd party tools like downloaders and viewers, we may come to agreement over an unofficial way of keeping Ugoira animations as files.
Converting Ugoira to anything else is quite a problem (additional quality loss, playback difficulties), I'd rather see it as a proper animation format - "frames-in-zip" idea feels quite simple already.
I'd like to ask everyone interested to discuss this and possibly formulate the requirements for future use of these animations as files, hopefully in more tools.
There are several issues for now:

animation.json file requirement originates from here - this is a collection of bookmarklets that allow saving Ugoira as files in various formats. The first DL_zip bookmarklet links to the javascript that contains the code for converting metadata into the file and putting it into the original .zip:

zip.file("animation.json", JSON.stringify(pixiv.context));
This is by no means an official "way" of keeping the metadata (the said javascript is not made by Pixiv). The said javascript can be changed or wiped in future, so it may not produce animation.json anymore.

Including the metadata as a file inside the .zip package invalidates the file. Afaik, PixivUtil2 can check filesize with server with 'alwayscheckfilesize' option. If used with files modified in such a way, it will not make sense.

Files that are already downloaded will need to be either re-downloaded (in case PixivUtil2 learns to include metadata inside the .zip) or processed with some script (to insert .js into .zip and rename .zip to .ugoira for each file).

I think there are several options here that can be applied individually or together, to improve the situation:

teach PixivUtil2 to save metadata under different name and include it inside the Ugoira zip, optionally or by default.
do not check filesizes of Ugoira files. When 'alwayscheckfilesize' is enabled, use something else for checking with server (may be difficult or impossible).
process files that are already downloaded in the same manner (include metadata inside .zip as a file).
talk with developers of HoneyView more about it, perhaps ask them to support metadata as a separate file, like it's saved right now when 'writeugoirainfo' is enabled in PixivUtil2. This way only renaming will be needed for already downloaded files.

EDIT:
There may be another option (although highly unlikely):

create a separate file container format: "zip-slideshows" of some sort. Include all image files into .zip and have it optionally have a metadata about delays, loop etc. Make the format of Ugoira JSON metadata supported as an option, thus making Ugoira a subset of our container format (this would still require inserting additional stuff inside Ugoira .zips). Then make viewers support that slideshow format instead of just Ugoira. Heh.

Ugoira support got included in latest HoneyView 5.11 build now - changelog.

I think I can add extra field in the animation.json for the original zip size.

try http://www.mediafire.com/download/x593yibkh74mu53/pixivutil20150315-beta1.7z

Thanks!
I've set this before running:
writeugoirainfo = False
createugoira = True
So far I can see that it now creates .zip and .ugoira. The .ugoira itself works fine.
As you already mentioned on the blog, modifying original .zip is not very good way, and I agree. But for a it to be a proper image, it would be a valid requirement to keep all data inside 1 file.
What I'd like to know:

What happens when original file gets modified and user has 'alwayscheckfilesize' enabled? Both .zip and .ugoira get overwritten?

Is .zip being kept only for 'alwayscheckfilesize'=true case? If so, wouldn't it be better to not keep it when 'createugoira'=true? If only filesize gets checked, maybe better keep it elsewhere? Because right now both files are mostly dupes, and each Ugoira may be 1~30 mb. Here are some examples I can think of:

keeping it inside the database may be bad, so keep it in a separate file near the .ugoira, e.g. in .txt.
since we already modified original .zip, might aswell go and add that info inside .ugoira as a .txt file or just its name (e.g. empty file named 'zipsize=1234567'). Then check the size by checking .txt contents or its name.
there are methods of checking contents of .zip archive without downloading actual file. After we get only its header, we can see sizes of all files inside. It may take more time to fetch that for each .zip though - each header may be 1-10 kb.
finally, there are modification dates on server that can be fetched in the same way like filesizes. I'm sure you are familiar with that and with all difficulties it involves - it may be a bad option.

Previously I thought that additionally allowing user change "animation.json" default string via config may be a good idea. But not anymore: keeping it fixed and simple might be better for format adoption. And what do you think?

Yap.
Kinda, no checking logic for .ugoira files yet, but I have add
additional field in the animation.json called zipSize which store the zip
file size.
Refer to
https://github.com/Nandaka/PixivUtil2/blob/master/PixivModel.py#L547

Still thinking how to implement the checking :P

Well, since all files inside .ugoira are not compressed anyway, you may be able to read zipSize straight from the file.
Or are there difficulties with logic when user already has some ugoira downloaded as .zip?

Here is my batch script for converting existing pairs of .zip.js and .zip into .ugoira. It should do all the same job as the pixivutil20150315-beta1. Logic is less complex but it should provide exactly same result. If the functionality changes in later versions, I'll try to update it.
@echo off

::prepare vars
set jsname=%1
set jsname=%jsname:"=%
set zipname=%jsname:.zip.js=.zip%
set ugoiraname=%zipname:.zip=.ugoira%

::make sure to only accept .zip.js
echo %1 | findstr /C:".zip.js">nul && (goto :process) || (echo Not .zip.js! & pause & exit)
:process

::get path
for /f "delims=" %%F in ("%1") do (set filepath=%%~dpF)
for /f %%F in ("%1") do (set rawpath=%%~dpF)

::get filesize of .zip
for %%A in ("%zipname%") do set size=%%~zA

::change work directory to our base folder
cd /d "%~dp0"

::display all collected info
echo path:      %filepath%
echo raw path:  %rawpath%
echo .js path:  %jsname%
echo .zip path: %zipname%
echo .ugoira:   %ugoiraname%
echo zipSize:   %size%

::check if Windows can process the path properly (e.g. there are problems with U+3000)
if not "%filepath%" == "%rawpath%" (echo Path contains illegal characters! & pause & exit)

::remove this pause for silent processing
pause

::prepare animation.json
copy /Y "%jsname%" animation.json

::put zipSize info inside animation.json
fart animation.json ]} ],\"zipSize\":%size%}

::add animation.json into .zip
7za a -mx0 -tzip -mtc=off "%zipname%" animation.json

::rename .zip.js to .zip.js_processed
ren "%jsname%" *.js_processed

::rename .zip to .ugoira
ren "%zipname%" *.ugoira

::clean up
del animation.json
Usage:

save as zipjs2ugoira.bat, copy 7za.exe + 7za.dll + 7zxa.dll and fart.exe into the same folder
drag&drop any .zip.js onto zipjs2ugoira.bat
or use it for command line processing like this

zipjs2ugoira.bat "C:\some path\123456_ugoira1920x1080 - title.zip.js"

Updated with http://www.mediafire.com/download/uy8ovvcp1luru51/pixivutil20150321-beta2.7z

Before testing beta2 with alwayscheckfilesize=true, should I convert all my Ugoira .zip+js to .ugoira?

I think you need to.
It check if the local zip file is exists and have the same size with server
size, if true, it will skip the download and ugoira creation.
see
https://github.com/Nandaka/PixivUtil2/commit/a9b2a086cd7b7feacb747dcbc5cb0eeae0899e40#diff-7a612caa8f02f7c30e49d68a8c1ab43fR644

Tested it, found few issues:

It still leaves .zip files near .ugoira. So I was deleting those by hand before testing with alwayscheckfilesize=true.
When I already have .ugoira downloaded and there is no corresponding .zip file: if local zipSize saved inside json is increased a bit - upon checking it says "Local is larger" and does nothing. Not sure if it's same for usual images. I find it wrong to not get the new file if it's smaller than previous version.

Other than that, it works well for me.

I haven't add an option to delete the original zip file :P
It is by design. I think someone request to keep the old file if the
local file is larger.

I guess you will add it anyway, and since filesize checking works properly with just .ugoira files.
Thinking of myself many years ago, I too could request such a thing. Anyway - https://github.com/Nandaka/PixivUtil2/issues/71

There is also a minor problem upon exiting now:
Traceback (most recent call last):
  File "PixivUtil2.py", line 1756, in
  File "PixivUtil2.py", line 1752, in main
NameError: global name 'exit' is not defined

crap forgot to add os. :smile: