Unknown field 'description' on type 'StripeSkuProduct'.

I Created a new project using this starter and Configured my API Keys with no issues. However, I get the following errors -
success open and validate gatsby-configs — 1.846 s
success load plugins — 22.471 s
success onPreInit — 0.010 s
success initialize cache — 0.074 s
success copy gatsby files — 1.218 s
success onPreBootstrap — 0.095 s
⠄ source and transform nodes✕ We were unable to download images that Stripe was pointing at
Error: We were unable to create a valid Gatsby file node
⠠ source and transform nodesFailed to process remote content https://files.stripe.com/files/f_test_MvxUIHD9YnwN8hharE8i9Or1
Downloading remote files [==============================] 1/1 0.0 secs 100%
✕ We were unable to download files that Stripe was hosting
URL: https://files.stripe.com/files/f_test_MvxUIHD9YnwN8hharE8i9Or1
Error: We were unable to create a valid Gatsby file node
✕ We were unable to download images that Stripe was pointing at
Error: We were unable to create a valid Gatsby file node
⠁ source and transform nodesFailed to process remote content https://files.stripe.com/files/f_test_ZHMenNxOZqp8bT0G8JTxUVIH
Downloading remote files [==============================] 2/2 0.7 secs 100%
✕ We were unable to download files that Stripe was hosting
URL: https://files.stripe.com/files/f_test_ZHMenNxOZqp8bT0G8JTxUVIH
Error: We were unable to create a valid Gatsby file node
✕ We were unable to download images that Stripe was pointing at
Error: We were unable to create a valid Gatsby file node
success source and transform nodes — 3.458 s
success building schema — 0.997 s
success createPages — 0.091 s
success createPagesStatefully — 0.117 s
success onPreExtractQueries — 0.083 s
success update schema — 0.080 s
error GraphQL Error Encountered 1 error(s):

Unknown field 'description' on type 'StripeSkuProduct'.
file: C:/Users/user/Documents/webDev/my-gatsby-stripe-site/src/components/ProductsProvider.js

success extract queries from components — 0.622 s
⠁ (node:5416) DeprecationWarning: Passing lineNumber and colNumber is deprecated to @babel/code-frame. Please use codeFrameColumns.
success run graphql queries — 0.035 s — 5/5 151.73 queries/second
success write out page data — 0.124 s
success write out redirect data — 0.006 s
success Build manifest and related icons — 0.376 s
success onPostBootstrap — 0.383 s
info bootstrap finished - 124.113 s
[HPM] Proxy created: /  ->  http://localhost:9000
[HPM] Proxy rewrite rule created: "/.netlify/functions/" ~> ""
i ｢wdm｣: wait until bundle finished: /
DONE  Compiled successfully in 16567ms
My STRIPE logs indicate -
Response body
{
"error": {
"message": "You provided an API key, but the requested endpoint does not require authentication. Try sending your request again without the 'Authorization' header.",
"type": "invalid_request_error"
}
}
Thank you.

You provided an API key, but the requested endpoint does not require authentication. Try sending your request again without the 'Authorization' header.

This looks like an issue that was fixed recently in gatsby-source-stripe. This has to do with the failing file downloads in the logs. Are you using the new version of Stripe Checkout? Try updating that package, I'll get around to updating it in the starter.

Unknown field 'description' on type 'StripeSkuProduct'.

Not sure what would be causing this without more info. Are there descriptions on your Stripe products?

I have the same problem in my local development environment.
below is my info:
system: windows 10
browser: chrome 72.0.3626.109
E:\learning\gatsby\gatsby-stripe-shop (master -> origin)
$ node -v
v10.15.3
E:\learning\gatsby\gatsby-stripe-shop (master -> origin)
$ npm -v
6.4.1
E:\learning\gatsby\gatsby-stripe-shop (master -> origin)
$ cat package.json
{
"name": "gatsby-starter-stripe",
"private": true,
"description": "A minimal starter to create a storefront with Stripe & Gatsby.",
"version": "0.1.0",
"author": "Brock McElroy (https://brockmcelroy.com)",
"dependencies": {
"dotenv-webpack": "^1.7.0",
"gatsby": "^2.7.1",
"gatsby-image": "^2.1.1",
"gatsby-plugin-manifest": "^2.1.1",
"gatsby-plugin-offline": "^2.1.1",
"gatsby-plugin-react-helmet": "^3.0.12",
"gatsby-plugin-sharp": "^2.1.1",
"gatsby-source-filesystem": "^2.0.37",
"gatsby-source-stripe": "^2.2.2",
"gatsby-transformer-sharp": "^2.1.19",
"prop-types": "^15.7.2",
"react": "^16.8.6",
"react-dom": "^16.8.6",
"react-helmet": "^5.2.1",
"react-stripe-checkout": "^2.6.3",
"slug": "^1.1.0",
"stripe": "^7.1.0",
"typescript": "^3.4.5"
},
"keywords": [
"gatsby"
],
"license": "MIT",
"scripts": {
"develop": "gatsby develop",
"start": "run-p start:",
"start:app": "npm run develop",
"start:lambda": "netlify-lambda serve -c ./webpack.development.js src/functions",
"build": "run-p build:",
"build:app": "gatsby build",
"build:lambda": "netlify-lambda build -c ./webpack.production.js src/functions"
},
"repository": {
"type": "git",
"url": "https://github.com/brxck/gatsby-starter-stripe"
},
"bugs": {
"url": "https://github.com/brxck/gatsby-starter-stripe/issues"
},
"devDependencies": {
"eslint": "^5.16.0",
"eslint-config-gatsby-standard": "^2.2.0",
"eslint-plugin-react": "^7.13.0",
"http-proxy-middleware": "^0.19.1",
"netlify-lambda": "^1.4.13",
"npm-run-all": "^4.1.5",
"prettier": "^1.17.1"
}
}
error messages as follows:
E:\learning\gatsby\gatsby-stripe-shop (master -> origin)
$ gatsby develop
success open and validate gatsby-configs - 0.102 s
success load plugins - 2.219 s
success onPreInit - 0.008 s
info One or more of your plugins have changed since the last time you ran Gatsby. As
a precaution, we're deleting your site's cache to ensure there's not any stale
data
success initialize cache - 0.053 s
success copy gatsby files - 0.126 s
success onPreBootstrap - 0.019 s
✕ We were unable to download images that Stripe was pointing at
Error: We were unable to create a valid Gatsby file node
warn Failed to process remote content

✕ We were unable to download files that Stripe was hosting
URL: https://files.stripe.com/links/fl_test_eAxWFIeJWUcuCZipvjTzKwwD
Error: We were unable to create a valid Gatsby file node
✕ We were unable to download images that Stripe was pointing at
Error: We were unable to create a valid Gatsby file node
success source and transform nodes - 3.674 s
success building schema - 0.406 s
success createPages - 0.032 s
success createPagesStatefully - 0.041 s
success onPreExtractQueries - 0.007 s
success update schema - 0.036 s
error GraphQL Error Encountered 1 error(s):

Unknown field 'description' on type 'StripeSkuProduct'.
file: E:/learning/gatsby/gatsby-stripe-shop/src/components/ProductsProvider.js

success extract queries from components - 0.373 s
success run static queries - 0.006 s
error (node:12884) DeprecationWarning: Passing lineNumber and colNumber is deprecated to
success run page queries - 0.054 s — 5/5 121.92 queries/second
success write out page data - 0.016 s
success write out redirect data - 0.005 s
success Build manifest and related icons - 0.162 s
success onPostBootstrap - 0.173 s

info bootstrap finished - 23.029 s

info [HPM] Proxy created: /  ->  http://localhost:9000
info [HPM] Proxy rewrite rule created: "/.netlify/functions/" ~> ""
DONE  Compiled successfully in 4813ms                                              14:06:38

You can now view gatsby-starter-stripe in the browser.

I believe any issues should be fixed by the new gatsby-source-stripe version, and required fields are now clarified in the README thanks to #12.


Missing backbone checkpoint file?

Thanks for releasing this repo!
I am try to write a interfacing code based on this repo and I found I couldn't load the backbone checkpoint using the provided checkpoint?  Does it need a independent checkpoint file for backbone?

Hi!
An interface to Mask3D sounds like a great idea! :)
The backbone is included in the checkpoint file. Can you give me more details?
Best,
Jonas

Hi
I made a mistake of using the Scannet dataset config for S3dis dataset. I now can load the full model weights. Thanks for the quick response.


Local File Storage Settings

Local database path & name; Accumulating backup path & name; Whether to save data gathered during census gathering in the main database and in the accumulating database at the same time; Regular backup paths; Whether to warn if there is low storage space; Whether to only allow backups to removable flash memory; or to only allow backups to a remote database

This is under discussion and some of this may change as we improve the methods the user has for import/export, etc., specifically with regards to specifying paths.

This is no longer going to be needed due to the way files are being managed.   Storage details are being abstracted from the user.


Fix: Add missing info endpoints to Gateway Admin API EE spec [skip ci]

Description
The spec was missing the following information endpoints:

GET /
GET /{workspace_name_or_id}/kong
GET /endpoints
GET /timers
GET /status

Testing instructions
Preview link:
Checklist

[x] Review label added
[x] PR pointed to correct branch (main for immediate publishing, or a release branch: e.g. release/gateway-3.2, release/deck-1.17)

@Guaris can you please take a look? Also, this adds 5k lines to the spec - is there any way around that, or is that just what we have to live with?

It's hard to see a diff in a spec like this, but here's what I did.

pulled the response in /endpoints into a parameter variable and then referenced it. This improves readability in line.
Fixed an issue with a tags example object not actually being an array object in the example.
Fixed an issue with this workspace config property that was written like:

 portal_developer_meta_fields:
              default:
                - label: Full Name
                  title: full_name
                  validator:
                    required: true
                    type: string

and needed to be turned into an object by adding a properties field.
This is everything that had to do with your initial changes.. i think.
In the process:

I applied the consumer_groups and licenses tags to the appropriate endpoints that were originally rendered under the default category in Swagger. (Here's a link the live site where they are rendered there https://docs.konghq.com/gateway/api/admin-ee/latest/#/default)

Standardized to no quotes in description: fields, which meant I had to reword some descriptions that contained a colon because they caused the rendered version to break unless quotes were present. I didn't mean to touch this in this PR but when I made the first commit I realized some had quotes and some didn't so I opted for none.  (sorry about putting this in this PR)


godot exit code improvement for --script --check-only, fixes #33895

this commit causes godot executable to return non-zero exit code
once invalid script is passed via --script during --check-only
$ ./bin/godot.x11.tools.64 --check-only -s samples/fine.gd &>/dev/null; echo $?
0
$ ./bin/godot.x11.tools.64 --check-only -s samples/non_compiling.gd &>/dev/null; echo $?
1

Bugsquad edit: Fixes #33895.

Could you squash commits together?

done

Thanks!


Synapse Login

initialize.R doesn't call library(synapser) before synLogin()
But also how is the user supposed to pass login credentials to the initializer script?

The packages, and thus synapser, are loaded in the initialize script before synLogin() is called with source("R/packages.R").
The assumption is the user has already cached credentials. I will add verbiage to make that clearer.


why the projector head MLP set to requires_grad=False

I noticed that a new projector head MLP is added after loading the pre-trained MoCo v3 model. However, the parameters of this newly added component are also set to requires_grad=False.
My question is - since this MLP head is randomly initialized, why does it not require any training before being used for feature projection?
Intuitively, adding an untrained random projection head could disrupt the original feature distributions learned by the pre-trained encoder. So what is the motivation behind fixing the parameters of this newly added head?
Does it relate to better retaining the pre-trained feature distributions? Or leveraging the fixed random projections to improve generalization of the downstream tasks?
It will be great if someone could help explain the rationale behind not training the added projector head. Thanks!

I have the same question, @LTH14 could you please clarify how do you train the newly added projection head of the MoCoV3 model?

The head in moco_vits is inherited from timm's VisionTransformer, which is a single Linear layer. However, the projection head of the pre-trained moco-v3 is an MLP (module.base_encoder.head). I don't want to change the original MoCo code and re-train that model, so instead I replace the Linear head with an MLP head so that the pre-trained weights can be loaded.

Note that the initialization of the pre-trained encoder (and MLP) is before loading the pre-trained weights, as shown here https://github.com/LTH14/rcg/blob/main/pixel_generator/mage/models_mage.py#L263-L278


update render markdown action

Closes #297

Yeah I should've been more specific. I'm pretty sure the bug was fixed in the background a while ago, and I just never updated the workflows.


docs: update dependabot workflow to add commit message and label

what's wrong with the documentation?

Current One:

version: 2
updates:
  - package-ecosystem: 'npm'
    directory: '/'
    schedule:
      interval: 'daily'

Firstly, it should have a proper commit prefix according to conventions, such as chore(deps). Additionally, it lacks a label, which could be helpful for someone looking at the PR, like 📦 dependencies.
Add screenshots

looks clean and according to conventions

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSoC'23 contributor
[X] I want to work on this issue

hey @Anmol-Baranwal I think this issue is not related to solving documentation, so please use blank issue template in future.

I think we don't need to add/change any thing for dependabot configaration. Now you can see the screenshot where dependabot already added dependencies label & also added good prefix chore(dep):

Closed dependabot PRs
https://github.com/priyankarpal/ProjectsHut/pulls?q=is%3Apr+author%3Aapp%2Fdependabot+is%3Aclosed

Sure, maybe I didn't notice properly.
Also workflows are considered as a part of documentation. Because when we add a workflow, we use docs. Correct me if I am wrong.

Sure, maybe I didn't notice properly.
Also workflows are considered as a part of documentation. Because when we add a workflow, we use docs. Correct me if I am wrong.

for CI/CD we have to use ci: title the format. You can check the documentation https://www.conventionalcommits.org/en/v1.0.0/


771 | Jewels and Stones | Python

Jewels and Stones -
Adding New Solution
Type of Issue -

[x] Adding New Code

Programming Language

[x] Python

Self Check

Ask for issue assignment and wait to get assigned to it before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Discord server ✉ - https://discord.gg/CXksGdn
Happy Coding,

Can I be assigned?


Add option to export only dev-dependencies

This PR adds the support, for exporting only the dev-dependencies, to the export plugin.
Related to https://github.com/python-poetry/poetry/issues/1441
Opening a PR here too, as the export function will be soon moved as a plugin.
Extension to https://github.com/python-poetry/poetry/pull/4283

[x] Updated documentation for changed code.

Hi @sdispater, I think the dependency groups feature would make it possible to solve this issue.

--only: The only dependency groups to include when exporting.

I understand poetry export --only dev -f requirements.txt --output requirements.txt something along this command would make it possible to export only the dev-dependencies (assuming the dev-dependencies are grouped under dev).
I know it might take some time to publish new release to have all these features, but could you confirm if my assumption is right? If yes, I think we can go ahead and close this PR too.
Thanks.
Best,
Venu

Closing the PR in favour of https://github.com/python-poetry/poetry-export-plugin/pull/3#issuecomment-922474131


GUI fix: DebugLog file opens twice after clicking "Open" in RPC Console Information tab

Sorry I picked up on this in my original commit #168 but at the time it wasn't very detrimental and I didn't have the fix so I let it go through.
But here's the fix :)

Lol, someone will want to look at this in windows I guess :D

I've tested in Windows myself and it works. But happy for others to also test.


Grid is laying out too often

I've noticed that when the grid is in a vertically-scrollable SingleChildScrollView, it will be laid out even if the scroll view changes height. This shouldn't be happening, because the grid is being provided identical constraints between size changes.
This is reproducible in the periodic table example.
First place to look: what's the SingleChildScrollView doing?

I added a bunch of code to recognize when grid properties are the same between rebuilds, which eliminates a ton of layouts. I suspect there's more low hanging fruit, so I'm leaving this open.

As far as I can tell, the number of layouts is now minimized.


Notes for your website

The email area at the top of the page, it doesn't give any reply when submitted
You might want to double check the visibility of the Submit button at the bottom of the contact form (hidden by the footer?)
Resize the pages for tablets, phones and smaller screens
:)

thank you


ENV var key value paring in 2.3.0 critical bug

TL;DR
bug introduced here: https://github.com/google-github-actions/deploy-cloudrun/pull/496
The KV parser creates a delimiter string which does not exist in the input string. This can cause an error when an env var value ends with the start of the delim string.
For instance, if a delim string is dd and I have an ENV var SOMETHING=hello-world SOMETHING_ELSE=foo, the string ends up like SOMETHING=hello-worldddSOMETHING_ELSE=foo, which creates cloud run ENV variables:
SOMETHING=hello-worl
dSOMETHING_ELSE=foo

Expected behavior
ENV variables correctly parsed
Observed behavior
No response
Action YAML
N/A

Log output
No response
Additional information
No response

This is still an issue in the (presumably uncommon, but still possible case) where concatenating the value and delimiter results produces a new occurrence of the delimiter.
e.g. for the label commit-sha=xxxx524 and the delimiter 5245
^5245^commit-sha=xxxx5245245ref-name=main
yields 245ref-name=main


Question: When debugging, how can i resolve a Question?

I am trying to debug my tests in particular:
See.if(ClientLookup.All_Clients, containsMembers(this.clientList))
ClientLookup.All_Clients is
static All_Clients: Question<PromiseLike<string[]>> = Text.ofAll(ClientLookup.List_Of_All_Clients)
and containsMembers is
expected => actual => expect(actual).to.eventually.contain.members(expected)
using Chai
When it run I get AssertionError: expected [ Array(30) ] to be a superset of [ Array(30) ]
So I am trying to debug it and this.clientList I can easily output to the console as it is plain array. But i need to know if there is a way to output the Resolved Question so I can output it to the console. When I use ClientLookup.All_Clients.toString()  I get the List of all clients

You could try to create a wrapper around the question that outputs the result of the wrapped question:
const Debug = <T>(question: Question<PromiseLike<T>>) => Question.where<PromiseLike<T>>(`debug output of ${question}`, actor => {
    const answer: PromiseLike<T> = question.answeredBy(actor);

    return answer.then(value => console.log(value)).then(() => answer);
});

Please let me know if that helps?
Jan

This works like a charm. My typescript isn't brilliant so I dont fully understand quite what it is doing but it is outputting what i Need.
Cheers

Just updated to latest version of Serenity and now Question does not have a property of where. Is there an alternative?

Yes, apologies for that, I've changed the api from Quetion.where to Question.about; Question.where was a mistake, should've been about in the first place.


show creator paths associated to service instance

When a service has been configured and the service code has modified one or more devices in the device tree we also set the appropriate creator attributes in the device config. For example a BGP peering service could look something like this:
<services xmlns="http://clicon.org/controller">
   <bgp-peer xmlns="http://nordu.net/ns/ncs/bgp">
      <service-name>AS123</service-name>
      <as-number>123</as-number>
      <irr-sources>RIPE</irr-sources>
      <description>SOMEISPNAME</description>
      <as-macro4>AS-SOMEMACRO</as-macro4>
      <exchange-points>
         <exchange-point>SOME-IX</exchange-point>
         <peering>
            <ip><IP_ADDRESS></ip>
            <as-number>888</as-number>
            <import-rules>peering-in</import-rules>
            <import-rules>peer-specific-in</import-rules>
         </peering>
         <peering>
            <ip><IP_ADDRESS></ip>
            <as-number>999</as-number>
            <import-rules>peer-specific-in</import-rules>
            <import-rules>peering-in</import-rules>
         </peering>
         <peering>
            <ip><IP_ADDRESS></ip>
         </peering>
      </exchange-points>
   </bgp-peer>
</services>

And the service code has created the following creator attributes:
<creator>
   <name>bgp-peer[service-name='AS123']</name>
   <path>/devices/device[name="ptx"]/config/configuration/policy-options/policy-statement[name="AS123-in"]</path>
   <path>/devices/device[name="ptx"]/config/configuration/policy-options/as-path-group[name="AS123"]</path>
   <path>/devices/device[name="ptx"]/config/configuration/protocols/bgp/group[name="SOME-IX"]/neighbor[name="<IP_ADDRESS>"]</path>
   <path>/devices/device[name="ptx"]/config/configuration/protocols/bgp/group[name="SOME-IX"]/neighbor[name="<IP_ADDRESS>"]</path>
   <path>/devices/device[name="ptx"]/config/configuration/protocols/bgp/group[name="SOME-IX"]/neighbor[name="<IP_ADDRESS>"]</path>
</creator>

A new CLI command to show paths associated to the service is needed. The CLI command could look like this:
> show services bgp-peer AS2603
Paths for device ptx:
/config/configuration/policy-options/policy-statement[name="AS123-in"]
/config/configuration/policy-options/as-path-group[name="AS123"]
/config/configuration/protocols/bgp/group[name="SOME-IX"]/neighbor[name="<IP_ADDRESS>"]
/config/configuration/protocols/bgp/group[name="SOME-IX"]/neighbor[name="<IP_ADDRESS>"]
/config/configuration/protocols/bgp/group[name="SOME-IX"]/neighbor[name="<IP_ADDRESS>"]

See: https://clixon-controller-docs.readthedocs.io/en/latest/cli.html#creators
cli> show services creators
<creators xmlns="http://clicon.org/lib">
   <creator>
      <name>ssh-users[service-name='test1']</name>
      <path>/devices/device[name="openconfig1"]/config/system/aaa/authentication/users/user[username="test1"]</path>
      <path>/devices/device[name="openconfig2"]/config/system/aaa/authentication/users/user[username="test1"]</path>
   </creator>
</creators>

Verified.


Variable viewer for Native Notebooks

Working on validating this. Is the expectation just 'works as before with native notebooks'?
One question I had: I noticed that we have this smaller tab within the Jupyter: Variables tab. Is there a reason we have this / can we remove this? I clicked on it to see what it would do and had to reload all of VSCode to get the variable panel back. If we are planning on keeping it around, I'd expect to be able to restore it with a command or on the next cell execute / notebook open.

Working on validating this. Is the expectation just 'works as before with native notebooks'?
One question I had: I noticed that we have this smaller tab within the Jupyter: Variables tab. Is there a reason we have this / can we remove this? I clicked on it to see what it would do and had to reload all of VSCode to get the variable panel back. If we are planning on keeping it around, I'd expect to be able to restore it with a command or on the next cell execute / notebook open.

Hi, i would appreciate it if it worked just as before.
I am running the latest beta build and cana not find the JUPYTER:VARIABLES tab, how can I access that?

Hi, i would appreciate it if it worked just as before.
I am running the latest beta build and cana not find the JUPYTER:VARIABLES tab, how can I access that?

@matrix303 this isn't available yet. I believe it will become available in our next release. Thanks for your patience!

@matrix303 this isn't available yet. I believe it will become available in our next release. Thanks for your patience!

@joyceerhl I'm never fully sure how to validate these more meta work items. I was counting this as when the bulk of the work was done with a functioning variable view that was in. Then I was using individual work items to track follow up issues (tests, ui cleanup). Personally I care more about the validations for bugs / regressions where it's easy to see if something is fixed. If the variable view shows up and generally works I'd count this as done.
You are correct about the X button. That's part of the remaining UI cleanup. The variable view still thinks that it's part of the interactive window and that x I'm pretty sure is a leftover from that. Same thing with the height and width sizing. Hoping to do that after I get the tests up and running.

@joyceerhl I'm never fully sure how to validate these more meta work items. I was counting this as when the bulk of the work was done with a functioning variable view that was in. Then I was using individual work items to track follow up issues (tests, ui cleanup). Personally I care more about the validations for bugs / regressions where it's easy to see if something is fixed. If the variable view shows up and generally works I'd count this as done.
You are correct about the X button. That's part of the remaining UI cleanup. The variable view still thinks that it's part of the interactive window and that x I'm pretty sure is a leftover from that. Same thing with the height and width sizing. Hoping to do that after I get the tests up and running.

Sweet, yeah it shows up and generally works 😊 marking this one as validated then.

Sweet, yeah it shows up and generally works 😊 marking this one as validated then.


Support for mocks in tests

Majority of the functions involve calls to functions from external packages which need to be mocked. Adding support for mocks can take gotests to the next level I believe.
e.g. An example function and its generated test can look something like this (pseudocode)
CODE
package A

import B

func fA(in) out{
	...
    resp := B.fB(p1, p2)
    ...
}

TEST
package A

import bmock

func TestfA(t *testing.T) {
	type mockB struct {
		resp   // mock resp of B.fB
		times  // number of times B.fB will be called
	}

	testCases := []struct {
		name
		args
		mockB
		want
	} { // add testcases }

	for _, tc := range testCases {
		t.Run(tc.name, func(t *testing.T) {
			gmc := gomock.NewController(t)
			defer gmc.Finish()

			bStub := bmock.NewMockService(t) // just an example, this is debatable
			bstub.Expect().fB(gomock.Any(), gomock.Any()). // 2 params so 2 gomock.Any()
					Times(tc.mockB.times).
					Return(tc.mockB.resp)

			...... // existing logic follows
		})
	}
}

I would first like to ask whether you have already thought about the feasibility of this idea. If you feel this is possible, I would love to work on this enhancement.

Hi @chatrasen, while personally I'm not the biggest fan of mocks (I prefer fakes and stubs), I understand that many Go programmers would love to have this feature. I also see that goland/mock is very popular. As long as this feature is disabled by default, and enabled by a flag like --automock='mock', so that we can extend this to use other mocking libraries in the future.


fix: cannot resolve path when building with EXTERNAL_PATH

Fixes https://github.com/nodejs/cjs-module-lexer/pull/91#issuecomment-2081320861

wow that's quick. Thanks!

Uh, I recalled why this was a thing. It should be import.meta.resolve("../lib/lexer.wasm") for tests to work without globally installing the module.


Moving the LCLs prepared by LEGO to the preferred location.

I'm working with Mikhail Arkhipov. Upon his request, I'm trying to fix the locations of the LCLs that are used to facilitate localization for R-tools.

__@csigs__,
    Thanks for your contribution.

To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
       It will cover your contributions to all Microsoft-managed open source projects.

Thanks, Microsoft Pull Request Bot


bug: cdk-overlay-dark-backdrop is removed before overlay is able to transition out

Bug, feature request, or proposal:
I'm considering this a bug since the default behavior in MdDialog is broken. Currently the overlay detaches once the transition caused by removing cdk-overlay-backdrop-showing has ended. However, the cdk-overlay-dark-backdrop class added by default is also removed before the transition occurs.
What is the expected behavior?
The overlay should smoothly transition the backdrop out.
What is the current behavior?
Notice how there's no fade out in the demo:
https://material.angular.io/components/dialog/overview
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Latest
Is there anything else we should know?
I'm assuming the removal of custom classes early is intentional so that custom transitions can be defined on the backdrop. The easiest change that is mostly non breaking is to change .cdk-overlay-backdrop to have transition-props: all. However that isn't completely accurate and isn't configurable.
My preference is that the backdropClass specified in the overlay config are always applied up until the dialog is detached, and while the dialog is shown, ${this._state.backdropClass}-showing is toggled on. This allows for full customization of the backdrop before and after the transition.

@crisbeto do you remember why we remove the backdrop class immediately?

I don't think there's a particular reason for the backdropClass. The logic can easily be moved to the transitionend callback.

@jelbourn I've been playing around with this one for a while now and it seems to be a bit more problematic than I thought. There are two things that are preventing the backdrop from animating away correctly:

We remove the class immediately.

I set it up to wait for the backdrop to animate away before removing the overlay, but that introduces its own set of issues:

The overlays that use a transparent overlay now "correctly" wait for the backdrop to "animate" away, even though its transparent, it still has a 400ms transition on its opacity. This can be worked around with something like a 1ms transition.
 I did it already and it's not too painful, but there are ~60 of the,
Waiting for the backdrop to go away seems to mess up the closing animations for some components.

Here's what I have so far: https://github.com/crisbeto/material2/commit/cb2ce6be608251f00d9d8dbcdca3b88a4edcfde9

@crisbeto if it's that problematic to change, I'd rather leave this for now and revisit it further down the road since I don't see it as being that major of an issue.

Here is the hack that I added to my project to get this working.
CSS:
.cdk-overlay-backdrop {
    background-color: rgba(0,0,0,0.5);
}

TypeScript:
this._overlayRef = this._overlay.create({hasBackdrop: true, backdropClass: ''});

As stated above the problem is that the class used to apply the color is removed immediately. It's also stated that changing when this is done introduces side effects.
Can't we add another config option that defines if the backdrop should be animated? Wouldn't that resolve side effect issues?

@thinkingmedia there's https://github.com/angular/material2/pull/10145 which solves the issue.

Angular 1's MD Dialog panel is very impressive than this evolving angular 2 material.
Please see this can get this feature(the backdrop animation to body of cdk-overlay-pane) sorted out sooner.


Reconsider Authors/Contributors list

After editing https://github.com/phpmd/phpmd/blob/2.6.0/AUTHORS.rst I noticed that it and the People behind page are totally outdated.
Even though commits aren't the only way one can contribute, most often the most active contributors are the ones with the most commits. Thus I would argue that we can scrap both lists and only link to the contributor list on GitHub.
Alternatively, we could have a top 10 contributors list, since this wouldn't change as often.
In any case I propose to have only one list and not two.

While we do something on this page I think we can directly check why this page has some render problems: https://phpmd.org/people-behind.html


Added implementation for WAIT command

Reference: https://redis.io/commands/wait

Not sure if this command was purposely left out of the commands list... but any rate here's an implementation.

Thanks - merging.


[APPS-3372] Deprecate v1 apps

:bear:
/cc @zendesk/wombat
@zendesk/vegemite
@jayvee
🛑 DO NOT MERGE UNTIL MARCH 1st
Description
Deprecate v1 apps.
Screenshot for the removed warning that no longer makes sense

References

JIRA: https://zendesk.atlassian.net/browse/APPS-3372

Risks

Low - Breaks apps validation

🎉 woohoo! 🎉


Separate mainloop from app

This grew way more than it should. Mainloop should be just mainloop, not handling "app specific tasks".  Move everything that's specific to mavlink-router elsewhere so mainloop is a small mainloop implementation rather than mainloop + app.

Will this be fixed by #242?

#242 is a starting point to at least be able to run the contents of the loop one iteration at a time. Once that's in it will be a lot easier to split the loop into smaller chunks, and unit tests can be written to make sure nothing breaks in the process.


I dont see any gui?

No GUI

Oh found it

Found it but only after running separately

Thank you very much for your interests in our app! Could you elaborate more on what you meant by "only after running separately"? Did you mean the behavior that when the cell is run, the app appears in a separate window?

Thank you very much for your interests in our app! Could you elaborate more on what you meant by "only after running separately"? Did you mean the behavior that when the cell is run, the app appears in a separate window?

yes


Authenticate to Github

Blocked by https://forum.golangbridge.org/t/why-am-i-not-getting-json-response-from-github/23199

This might come handy: https://spf13.com/presentation/building-an-awesome-cli-app-in-go-oscon/


Update publicação “2023-12-27-polimento-de-carro”

Automatically generated by Decap CMS

👷 Deploy Preview for driveclean-teste processing.

Name
Link

🔨 Latest commit
2144042b1ef2d0638a78e657bc76d21bf6b877c5

🔍 Latest deploy log
https://app.netlify.com/sites/driveclean-teste/deploys/658dec0ecface70007a07aa8


Performance: Restrict the directories searched for testitems to src/ and test/

@davidanthoff: We have found that the performance for our large repository is absurdly bad.
For example, consider this video, where you can see that it takes about 2 minutes to pick up changes in our testitems:
https://user-images.githubusercontent.com/1582097/214360420-4ea5b44a-d04d-4cc6-9bdf-f34a4fcc0a3c.mov
I believe that this is because our directory is very large, containing a bunch of test data and benchmark datasets, etc.
You can see how big this is by just running tree in the directory -- not even reading the files, just listing them takes 1 minute! Compare that to tree on src/ or test/, which both finish in 30 milliseconds:
$ time tree > /dev/null
tree > /dev/null  13.15s user 33.66s system 73% cpu 1:04.09 total
$ time tree src > /dev/null
tree src > /dev/null  0.02s user 0.01s system 85% cpu 0.036 total
$ time tree test > /dev/null
tree test > /dev/null  0.02s user 0.01s system 91% cpu 0.034 total

I don't see any reason why anyone should need to put tests anywhere except for src/ and test/.
I think by being a bit more prescriptive about this, we can have a much better experience. Finally, I think that there's actually some benefit to the community to have some clarity in the conventions, so that it's easier to compare across projects to find the tests always in the same places.

That would mean that we have to restrict the language server to those folders, the test item detection is just part of the regular parsing of Julia files in the LS and I believe doesn't really add much overhead at all. But of course, the LS generally tries to find all Julia files in the workspace.
I think we can't restrict the LS in general to a subset of folders, users just have too many different structures there. But what we could do is add an option to exclude certain folders, so that if users have a situation like yours there is a way to make things work. That would probably be enough for your use-case, right?
Although, watching your video right now I'm very confused... The live edits are sent from the VS Code client directly to the LS, and I would have thought that the number of files in the workspace actually has no impact on latency there at all... I think unless the LS is just generally busy with other stuff (but unclear what that could be) I'm not sure what is going on there... Here are some things to try out:

can you observe this after all initial LS processing/init stuff is done? So launch VS Code, open the folder, wait until the whole LS init sequence is over and maybe make sure it actually is by waiting until hover help really works.
Can you then observe the same behavior that edits in an open file are not picked up?

If that is so, then I'm pretty sure this is unrelated to the number of files, and due to something else. Maybe the static analysis is so slow that it saturates the LS process or something like that...

interesting. makes sense! No matter what else we do to investigate this, can we eliminate whatever caching is going on in the video that's causing it to run out of date test code?  That seems really bad, since you can think your newly written test passed even though it didn't. It seems to me that if the LS is stuck, it should simply wait to run the tests until the LS is able to send the new test content?
Or maybe, is there some way to change the way the tests are run so that running the test always involves fetching the latest contents of the test file from the cached file name and line number position?
Even if we're able to identify the cause of the delay in my video and fix it, i would want this situation to be impossible. My concern is that if we make it faster, it could still happen if you're super fast in between making the change and starting the test.

I wonder whether we might want to separate the process handling testitems and the process doing the rest of the work in the LS? Even if we're able to shrink the delay, it seems like very large projects could still have some kind of delay, and it would be great if running the tests was as low-latency as possible... What do you think about splitting these?

Regarding the rest of your ask:
I'll try that, yeah. I will note that the issue was repeatable, so it is slow for a while. But yeah i'll try again, and make sure to wait until mouseover is working.
I will note that for the last few months I've noticed that i'm seeing https://github.com/julia-vscode/julia-vscode/issues/1093 happening again, even though i've made the changes discussed in that thread (moved the .julia dir out of the repo).
There is almost always a julia task running in Activity Monitor at 100% CPU usage. So maybe that's related?
I see that both for our internal repo (RAICode), and also when I have the JuliaLang/julia repo open.

Ah, it looks like i've been suffering from https://github.com/julia-vscode/julia-vscode/issues/3037. I wonder if this was causing the server to keep restarting?

So I think the TODO here is that we should just remove all the info about detected tests while the LS is down. That is essentially a state where that information is stale, and then it is probably better to just remove it from the UI.


Cannot Differentiate Provision Catalog And Custom Action Ansible Playbook Catalog.

Environment: CloudPak with CloudForms.
Version:
IBM Cloud Pak for Multicloud Management - Infrastructure management 2.0.0
Version <IP_ADDRESS>00921060502_fe0b663
CP4MCM:IM Customization 10.y@6fa7958f
Description: For on-boarding custom operation like (Adding secondary disk) in Ansible playbook, I need to create a
catalog first then i should go to the button and select the Ansible playbook. Since the custom operation showing as a catalog if i would like to differentiate between provisioning catalog and custom action catalog, through API how do I differentiate between these two. until we differentiate the provision catalog and custom action ansible catalog will be in trouble.
Steps To Repoduce:

Create custom action playbook catalog in CloudForm
Login to CP4MCM
Click on Enterprise Marketplace
Ruin the catalog discovery
Observe the ansible custom action catalog are pulled as IaaS.

Expected:

There should be cloudform API with payload to differentiate provisioning catalog and ansible custom action catalog.

@pemcg I think you were helping @Franklin-lab in gitter chat.  Perhaps you can weigh in a little here?  cc @lfu @tinaafitz @gtanzillo

We may be confusing the terminology here. From your screenshot of IM, it looks like you  have 3 catalogs: "Ansible", "Automation", and "VMware Catalog". Is this what you mean, or are you looking to differentiate the items in the catalogs?

No @pemcg , There is folder called "Ansible" and custom action name is  "Add Additional Disk" under that folder.
When we run the discovery from CloudPak, it is getting pulled Ansible based custom action catalog as well.
So, my request here is only for the provisioned catalog should get pulled from CloudFrom to Clodpak.

ok, I think that's where the terminology confusion is coming in. What you're describing as "Folders" are Catalogs (expand the 'Catalogs' section in the accordion and you'll see them). Just to confirm, I think you're looking to differentiate between type of Catalog Item (in the 'Catalog Items' section in the accordion)?
Thanks

I will try and update you @pemcg


[flutter_tools] [iOS] Change UIViewControllerBasedStatusBarAppearance to true to fix rotation status bar disappear in portrait

Fixes https://github.com/flutter/flutter/issues/84852.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This has caused a regression in https://github.com/flutter/flutter/issues/95481


bugfix for #16 archive insertion

fixes bug #16 by giving priority to individuals in the archive in case of equal objectives

Coverage remained the same at 16.915% when pulling 3c8610d855f775d1dce9058bd1c39e41951ab6e6 on vrichthammer:bugfix/#16-archive-insertion into dfbd0143aa880330fca229def82ab35693eac586 on felixreimann:master.


Request for Proper Attribution of Copied Code

Dear balewgize,
I am writing to you to bring to your attention that I have recently discovered that you have used my code in your work without proper attribution. As you may know, plagiarism is a serious issue in the open source community, and it is important that we respect each other's intellectual property rights.
I have compared your code with mine, and it is clear to me that you have copied big chunks of my code (excluding the .gif processing part). While I am flattered that you found my work useful, I would appreciate it if you could update your work to include the proper attribution.
As the original author of the code, I would like to request that you add a clear and visible attribution in your work, indicating that you have used my code as a reference. This attribution should include my name and the name of the original work. You can include this attribution in the code comments, in the documentation, or on the platform where you published your work.
I believe that it is important that we maintain the integrity of our work and give credit where credit is due. I hope that you can understand my concerns and that we can resolve this matter amicably.
Thank you for your attention, and I look forward to hearing from you soon.
Best regards,
Alyetama

Hi Alyetama, thanks for bringing up your concern.
I just used your code as a reference since I thought everything publicly available on GitHub is meant to be used and modified freely. That is what I understood about open-source projects till now.
But if you need credit for your work, it would be great if you could have mentioned it in the readme so people can understand what needs to be done before using your code as a reference.
I will include credit to your work. If you wish, I can also delete the repo from my profile. Let me know if we can close this issue now. Thanks!

Thank you for your response. While I understand your perspective on the use of open-source code, it is standard practice to provide proper attribution when using someone else's code. Although my code was not protected by a license at the time you accessed it, I will be adding a license to make it clear how it can be used and what attribution is required. I appreciate your willingness to include a reference to my work, and I think adding the license will help avoid any similar issues in the future. As for deleting the repo, that's entirely up to you. I think we can close this issue now, but please let me know if you have any further questions or concerns.

Okay understood. Thanks for raising the issue in a professional way, appreciate it. I have added your name and link to your GitHub project in the readme.


XML Notepad version <IP_ADDRESS>

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Ok, I ran winget update wingetcreate and a new wingetcreate update and pushed the changes, there were more than you proposed above.  I added winget update wingetcreate to my publish script so it should stay up to date now.


Material texture fixes

Hi, thanks for maintaining this exporter.  It works pretty well except for some weird cases, which this pull request addresses.
(BTW, not sure why it can't automatically merge -- I think I'm up-to-date...?)
Fix several issues in material per-face mapping and texture mapping
-- track per-material-face textures, which can differ (e.g. in a skybox)
-- track original names of material texture slots (in kind of a nonobvious way since we can't add a yabee_name property)
-- fix several exceptions for faces with materials but no textures (e.g. just colors)

Added test .blend / .egg files to show the expected results (feel free to leave this out if it just takes up space)

Oh, I just saw where the conflicts are.  I will update soon...

OK, duh, I "rewrote" some other people's bug fixes, thinking they were my own.

Thanks!

I just found a few errors in that code: 1) It ignores texture sort (as the new code generates a dict first, which is not guaranteed to preserve order)  2) It ignores material textures when there is an active texture


feedback module error after update

I recently updated the feedback module on my site, and its now currently giving these errors,
is there any fix for this?
Error: Feedback is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Object reference not set to an instance of an object. ---> System.NullReferenceException: Object reference not set to an instance of an object. at DotNetNuke.Modules.Feedback.Feedback.cmdSend_Click(Object sender, EventArgs e) --- End of inner exception stack trace ---

What version of the DNNFeedback module and DNN are you using?
DNN7 and DNN8 require different versions.

i use version 6.5.1 of the feedback module, and i have DNN8

The error mesage does not tell much. Can you export the feedback data in this case and attach it to this issue?

There was an error on my part. thank you!


rework Adobe Flash

SteamDB app page links to a few games using this
https://steamdb.info/app/92/depots/
Brief explanation of the change
added a rule for Adobe Shockwave

idk what to call it actually, according to https://developer.valvesoftware.com/wiki/Codename:_Gordon it's made using Adobe Flash, which i guess could be true, but the format is called Shockwave

moved the rule to Adobe Flash and moved Adobe Flash into the Engine category

The format is not called Shockwave.
https://nosamu.medium.com/the-difference-between-flash-and-shockwave-b27609808a02


New package: SBRW.NFSW_GameLauncher version 2.2.2

Checklist for Pull Requests

[ ] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service agree

@microsoft-github-policy-service agree [company="SBRW"]

@microsoft-github-policy-service agree company="SBRW"

Hi @MeTonaTOR,
Manual Validation ended with:

Is a dependency needed?

Verify while here:

[Policy] zip-binary

Hey @stephengillie
Yes, this file is actually optional, it was used on older method of obtaining compressed chunks of data. Now it mostlu fetches one single zip-compressed chunk of data that executable itself can manage to extract

Hey @stephengillie
Yes, this file is actually optional, it was used on older method of obtaining compressed chunks of data. Now it mostlu fetches one single zip-compressed chunk of data that executable itself can manage to extract

Even though it says it downloaded the file, any time I attempt to start the installer it gives the same message and never actually launches


Create html Routes

to connect to db and video source

this should include:
main page
User page (if valid)
Login page / sign up page


Support Coc.nvim

Is it possible to support https://github.com/neoclide/coc.nvim ?

Any chance you could try out: https://github.com/sourcegraph/sg.nvim/pull/242
I tried it locally and it seems to be working for me, but I haven't used coc.nvim in a long time!

I've installed as follows:

local M = {
    "sourcegraph/sg.nvim",
    dependencies = {
        "nvim-lua/plenary.nvim",
        "nvim-telescope/telescope.nvim",
    },
    branch = "coc-nvim-support",
    -- build = ":SourcegraphDownloadBinaries<CR>"
}

But I don't know how to map a manual trigger for completion <C-a> or how to start the chat. I don't see any commands named "cody" or "sourgraph" in plugins, nor coc.commands
Issus with health might be versions of nvim ?

sg: require("sg.health").check()

sg.nvim report ~
- Machine: x86_64, sysname: Linux
- ERROR Invalid nvim version. Upgrade to at least 0.10.0. Current version: table: 0x7efcbcddfca0
- ERROR Invalid nvim version. Upgrade to at least 0.9.4 or nightly

this is my version:
 NVIM v0.9.5
 Build type: Release
 LuaJIT 2.1.1713773202
 system vimrc file: "$VIM/sysinit.vim"
 fall-back for $VIM: "/usr/share/nvim"
 Run :checkhealth for more info


Add info pop up to Ripple (XRP) Send sheet

I see some changes on walletkit, should we review them in its own repo? in other words, what is the code cycle on walletkit? still using support/fabriik-9.0.X? is @dvidovicNchain doing new releases?

I will revert walletkit changes, probably IDE made some changes


CLOUD-75338 Uprade traefik docker image to v1.1.2

@mhmxs please check

This fix would be nice on latest stable version too.


Karma-Coverage is exiting with exit code 0 while below threshold

Expected behaviour
When code-coverage fails, test should exit in error
Actual behaviour
Coverage is below check threshold and exits with code 0 and no error allowing for test to show success even though it has failed coverage tests
Environment Details

Karma version (output of karma --version): 6.33
Relevant part of your karma.config.js file:

module.exports = function (config) {
  config.set({
    basePath: '',
    frameworks: ['jasmine', '@angular-devkit/build-angular'],
    plugins: [
      require('karma-jasmine'),
      require('karma-chrome-launcher'),
      require('karma-jasmine-html-reporter'),
      require('@angular-devkit/build-angular/plugins/karma'),
      require('karma-coverage'),
    ],
    ...,
    coverageReporter: {
      dir: require('path').join(__dirname, './coverage/appName'),
      reports: ['html', 'lcovonly', 'text-summary'],
      type: 'text-summary',
      fixWebpackSourcePaths: true,
      check: {
        global: {
          statements: 80,
          branches: 80,
          functions: 80,
          lines: 80,
        },
      },
    },
    reporters: ['progress', 'kjhtml'],
    port: 9876,
    colors: true,
  });
};

I'm unable to reproduce it. Please provide a runnable reproduction repository and steps to follow, which will result in the described issue.
$ ng new test-proj
$ cat karma.conf.js
// Karma configuration file, see link for more information
// https://karma-runner.github.io/1.0/config/configuration-file.html

module.exports = function (config) {
  config.set({
    coverageReporter: {
      dir: require('path').join(__dirname, './coverage/test-proj'),
      subdir: '.',
      reporters: [
        { type: 'html' },
        { type: 'text-summary' }
      ],
      check: {
        global: {
          statements: 100,
          branches: 100,
          functions: 100,
          lines: 100,
        },
      },
    },
    // ... other properties omitted for brevity
  });
};
$ cat src/app/app.component.spec.ts
import { TestBed } from '@angular/core/testing';
import { AppComponent } from './app.component';

describe('AppComponent', () => {
  beforeEach(async () => {
    await TestBed.configureTestingModule({
      declarations: [AppComponent],
    }).compileComponents();
  });

  it('should create the app', () => {});
});
$ ng test --code-coverage --watch false
⠋ Generating browser application bundles...02 06 2021 21:53:20.906:INFO [karma-server]: Karma v6.1.2 server started at http://localhost:9876/
02 06 2021 21:53:20.908:INFO [launcher]: Launching browsers Chrome with concurrency unlimited
02 06 2021 21:53:20.911:INFO [launcher]: Starting browser Chrome
✔ Browser application bundle generation complete.
02 06 2021 21:53:24.820:INFO [Chrome 91.0.4472.77 (Mac OS 10.15.7)]: Connected on socket Svbu2YDpdJTkEBfuAAAB with id 69575801
WARN: 'Spec 'AppComponent should create the app' has no expectations.'
Chrome 91.0.4472.77 (Mac OS 10.15.7): Executed 0 of 1 SUCCESS (0 secs / 0 secs)
Chrome 91.0.4472.77 (Mac OS 10.15.7): Executed 1 of 1 SUCCESS (0.018 secs / 0.004 secs)
TOTAL: 1 SUCCESS
02 06 2021 21:53:26.845:ERROR [coverage]: Chrome 91.0.4472.77 (Mac OS 10.15.7): Coverage for statements (83.33%) does not meet global threshold (100%)
02 06 2021 21:53:26.845:ERROR [coverage]: Chrome 91.0.4472.77 (Mac OS 10.15.7): Coverage for lines (80%) does not meet global threshold (100%)

=============================== Coverage summary ===============================
Statements   : 83.33% ( 5/6 )
Branches     : 100% ( 0/0 )
Functions    : 100% ( 0/0 )
Lines        : 80% ( 4/5 )
================================================================================
$ echo $?
1

Ok looks like this was a mistake on my part. My mistake I will close the issue.
For anyone who is looking at this.
My issue seems to have been from:
reports: ['html', 'lcovonly', 'text-summary'],
type: 'text-summary',

Once I changed this over to:
reporters: [{ type: 'html' }, { type: 'lcovonly' }, { type: 'text-summary' }],

(key being "reporters" not "reports"
This seems to have resolved my issue.
I appreciate your help @devoto13


Add kind of streaming template compilation

Hi,
i recently added this awesome gulp plugin to one of the apps i'working on. I realized that the slim file compilation is kind of slow. It takes around 7 seconds to compile 9 templates on my MacBookPro.
I guess most of the time is used to start the ruby interpreter and load the gems (i'm using the bundle option). Unfortunately i have no idea how to benchmark the issue.
In my opinion it should be possible to write a command line executable that can compile templates in a streaming fashion (like gulp handles the files) which can be hooked up to the gulp process via a unix pipe.
Does anyone think this may be a good idea? Or has any suggestions?
I'd like to discuss the idea before investing my time and just get my PR's rejected.
Thanks

Yes, please!  A coworker and I have been racking our brains over this exact same thing.  The performance is slow, and it seems like starting ruby is taking most of the processing time.  I've been kicking around a few ideas here.  In a streaming solution, the trick seems to be communicating end of file and detecting a file delimiter in the output stream.
I've taken a few hacks at this and keep getting blocked.  Ideally, I would like to work with stdin and stdout communicating with slimrb.  Slimrb by default appears to look for an end of file (\x04) to begin processing the input stream.  It then prints the output and quits.  I've toyed around with the idea of putting in a file delimiter in an html comment, something like <!-- gulp-slim: EOF -->; however, this doesn't work because slimrb won't process stdin until EOF is sent.  I could still try to use a file delimiter, but that would require reading all the output into memory and splicing it up to the correct file object in gulp-slim.
It seems like we'll have to write a ruby script to invoke the slim engine through the ruby API.  Then, we can coordinate the stream to determine file delimiters.
I've got another issue specific to my usage of slim.  I'm used to have slim search the same directory as the file being processed for includes.  With streams, slim doesn't know the directory of the file currently being processed.  So, I introduced the chdir option in PR #26.  I'd like to see a solution that supports the same functionality.
In a number of ways, the plugin is well suited to invoke slimrb for each file.  I just wish we didn't have to incur the performance penalty of starting ruby for each file.  I hate to say it, because I prefer slim, but this issue is causing me consider Jade.  Because the Jade engine is invokable from the node instance running gulp, I imagine it will be much faster to process files.
I think this is a necessity to the usability of this plugin, and I encourage @cognitom to consider this issue.

... i totally missed your comment. Just read it today. At least i'm not alone with the problem. I'll try to free some time to work on this.

@JGantner We actually decided to go to jade instead.  Slim just isn't well supported or performant for use with node.js based tooling.  Jade isn't as robust as slim, but the syntax is fairly similar.  The conversion from slim to jade wasn't that difficult for our team.  As a further example, we're now using webpack as well, and jade support is a simple add-on.  I doubt we'll ever see a slim loader for webpack.

might want to look at slm it's nice and fast

i wasn't able to free up some time so i'm abandoning this idea. Slm looks promising.


list unpacking

https://github.com/OpenSourceEconomics/soepy/blob/8f32fa2573ae1b17a39651d01021845a561bebc6/soepy/python/simulate/simulate_auxiliary.py#L14-L19
This can just be replaced by ...
states_all, states_number_period, mapping_states_index, max_states_period = state_space_args

This is done in #25.


colour dependency fails on GHC HEAD (8.4)

Unless colour is updated, it is not going to be compatible come GHC 8.4 (or today's GHC HEAD, as I just found out) since there are at least two Monoid instances without Semigroup ones.
I'd file an issue, but colour doesn't have a bug tracker (and hasn't been updated in a while). I reckon you are more likely to know what to do - just thought I'd bring it to your attention.

Thanks for the notice. Could you contact colour's maintainer, Russell O'Connor, via email? You can find his address on the hackage page.

I've done this - I just reckoned you'd want to be aware (in case you weren't already). I'm not planning on really following up on this (colour just happened to be one of the things that broke when I tried  compiling Haddock's test suite on GHC HEAD, and it is a dependency through ansi-terminal) so I wanted to make sure this was on someone's radar 😃.

Ok, got it. There's not much I can do about this for now, really. In the unlikely case this is not fixed by the time ghc 8.4 is released, this can be brought up with hackage trustees, but even then I'd prefer the users take charge.

Russel O'Conner emailed me to let me know that colour-2.3.4 apparently addresses this.


Add All Slash Gateway Events

This should have controllors but also eventHandlers typings and such
https://github.com/discord/discord-api-docs/commit/762da2910e678bffc4d2c2fe13499bbb9d9927f5

This was already completed!


prevent further interactive shells in interactive mode

Fixes: https://github.com/Azure/azure-cli/issues/4287
Prevents new shell from being run in interactive mode.
If interactive is input in interactive mode, a message will inform user that he/she is already in the shell.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines

[na ] The PR has modified HISTORY.rst with an appropriate description of the change (see Modifying change log).

Command Guidelines

[na ] Each command and parameter has a meaningful description.
[na ] Each new command has a test.

(see Authoring Command Modules)

@williexu,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #4299 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4299   +/-   ##
=======================================
  Coverage   70.12%   70.12%
=======================================
  Files         475      475
  Lines       29692    29692
  Branches     4556     4556
=======================================
  Hits        20822    20822
  Misses       7426     7426
  Partials     1444     1444

Impacted Files
Coverage Δ

src/azure-cli-core/azure/cli/core/application.py
89.86% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a936d...2f08acd. Read the comment docs.

Slick :)

Except you have a PEP8 failure. For shame!


Live

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/TOC.md
:white_check_mark:Succeeded

windows-iotcore/build-your-image/CreateBSPs.md
:white_check_mark:Succeeded

windows-iotcore/commercialize-your-device/IoTCoreServicesOverview.md
:white_check_mark:Succeeded

windows-iotcore/commercialize-your-device/OEMLicenseRequirements.md
:white_check_mark:Succeeded

windows-iotcore/media/IoTCoreServices/IoTCoreServicesOverview-DUC.png
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


"Cannot find module './assets/content-types'" when using version 1.4.X in live mode

#4012 # What is your Test Scenario?

What is the Current behavior?
Live mode fails to start when using version 1.4.X. When I revert back to 1.3.X it works fine.

What is the Expected behavior?
It behaves the same as 1.3.X.
What is your web application and your TestCafe test code?
Private sorry.

Hi @rssfrncsrenishaw
I cannot reproduce the problem by your description with<EMAIL_ADDRESS> Could you please provide an example so that I can reproduce the problem on my machine?

Just created a clean project and it is working fine.
I wonder if this is a typescript config (source project) issue.

Another possible reason is that npm failed to update TestCafe properly. Try to execute the following commands in your project:
npm i -D testcafe@latest
npm cache clean -f
npx del-cli node_modules/
npm i

I use Yarn with an offline mirror, I deleted the entire mirror, cleaned the cache and node modules re-installed and still having the same error.

The folder "assets" is physically missing

I've downloaded the TestCafe package from the NPM registry and it contains the assets directory:

You can use npm show testcafe dist.tarball or yarn info testcafe dist.tarball to get the package URL (in my case it is https://registry.npmjs.org/testcafe/-/testcafe-1.4.1.tgz), download the package and check its content.
It seems that this issue is caused by npm, yarn or your package mirror. Please create bug reports in the corresponding projects.


feat(localization): add lidar_marker_localizer

Description
merge with https://github.com/autowarefoundation/autoware_launch/pull/861

Tests performed

Download sample dataset

The sample dataset was acquired in National Institute for Land and Infrastructure Management, Full-scale tunnel experiment facility. The reflectors were installed by Taisei Corporation.

Launch Autoware with pose_source:=ndt_lidarmarker

ros2 launch autoware_launch logging_simulator.launch.xml \
  map_path:=$HOME/autoware_map/kokusouken \
  vehicle_model:=sample_vehicle \
  sensor_model:=sample_sensor_kit \
  pose_source:=ndt_lidar-marker

play rosbag

https://github.com/autowarefoundation/autoware.universe/assets/13819566/7eefb672-d5c9-4459-a525-b964582ffcbb
Please visualize the following topic in RViz.

/localization/pose_estimator/lidar_marker_localizer/pointcloud_preprocessor/ring_filter/pointcloud_ex
input lidar pointcloud
/localization/pose_estimator/lidar_marker_localizer/lidar_marker_localizer/debug/marker_mapped
marker information listed in the vector map
/localization/pose_estimator/lidar_marker_localizer/lidar_marker_localizer/debug/marker_detected
detected marker positions
/localization/pose_estimator/lidar_marker_localizer/lidar_marker_localizer/debug/pose_with_covariance
estimated position by lidar_marker_localizer

Effects on system behavior

Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TaikiYamada4
Thank you for your review.
I have completed all the corrections.

Plus, about outside of this PR, maybe you should right some explanation about this lidar_marker_localizer in README.md of landmark_based_localizer

OK. I'll write something later

@YamatoAndo
Thank you for your revision!!
The content of this pull request seems good for me now, but the required checks (DCO and pre-commit.ci) haven't passed here, so could you check this out?

Current status: Using the /sensing/pointcloud_preprocessor/ring_filter/pointcloud_ex topic as input is not consistent with the interfaces defined in Autoware so it is not desirable.
Implementation is underway where the sensing component will output additional channel information, so we will wait for that to be implemented.

[Current status] Waiting for the following PR

https://github.com/autowarefoundation/autoware.universe/pull/6996

I checked this PR by TIER IV internal Evaluator.
https://evaluation.tier4.jp/evaluation/reports/cf23ec1f-f7c8-54e8-b9a2-5b549945d7b4?project_id=prd_jt
And I noticed that there is a issue with
tier4_localization_launch: Cannot locate rosdep definition for [lidar_marker_localizer]

I will fix it.

Sorry, I realized that the above problem has already been resolved at https://github.com/autowarefoundation/autoware.universe/pull/5573/commits/edabd49649d9534b9220476930288d60c2d50b2f

@SakodaShintaro @YamatoAndo
I see that the localization is going well, except I can't see the topic /localization/pose_estimator/lidar_marker_localizer/lidar_marker_localizer/debug/marker_mapped on rviz. What should it be like on rviz?
ros2 topic echo works and returns something like this.
header:
    stamp:
      sec:<PHONE_NUMBER>
      nanosec: 791924782
    frame_id: map
  ns: landmark_text
  id: 18
  type: 9
  action: 0
  pose:
    position:
      x: 16518.486750000855
      y: 97361.17539999983
      z: 28.375
    orientation:
      x: 0.5453159159375941
      y: -0.45014503421135593
      z: -0.4501450342113559
      w: 0.5453159159375941
  scale:
    x: 0.0
    y: 0.0
    z: 0.5
  color:
    r: 1.0
    g: 0.0
    b: 0.0
    a: 1.0
  lifetime:
    sec: 0
    nanosec: 0
  frame_locked: false
  points: []
  colors: []
  texture_resource: ''
  texture:
    header:
      stamp:
        sec: 0
        nanosec: 0
      frame_id: ''
    format: ''
    data: []
  uv_coordinates: []
  text: (0)
  mesh_resource: ''
  mesh_file:
    filename: ''
    data: []
  mesh_use_embedded_materials: false

@TaikiYamada4
Please set "transient local"

@YamatoAndo
Thanks! I found it, so the current PR here is approvable for me :+1:

I was also able to confirm that it works too. This PR is ready to merge.

Problem
I am encountering an issue where, despite successfully launching Autoware and loading the map, I am unable to see the car or point clouds in the RViz display. Additionally, this problem persists even after I attempt to initialize with GNSS.
Commands Used
I used the following commands to launch the simulation and play the rosbag:
ros2 launch autoware_launch logging_simulator.launch.xml map_path:=$HOME/autoware_map/kokusouken vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit pose_source:=ndt_lidar-marker

ros2 bag play autoware_map/kokusouken/rosbag/

Steps to Reproduce

Launch Autoware with the provided commands.
Open RViz and observe that the car and point clouds are not visible.
Attempt to initialize with GNSS, but the issue remains unresolved.

Expected Behavior
The car and point clouds should be visible in the RViz display, and GNSS initialization should allow proper visualization of the vehicle's position and sensor data.
Actual Behavior
Neither the car nor the point clouds are visible in RViz, even after attempting GNSS initialization.
Additional Information

Running on UBUNTU 22.04 with ROS 2 humble
Attached a screenshot of the RViz display showing the current state.

Problem
I am encountering an issue where, despite successfully launching Autoware and loading the map, I am unable to see the car or point clouds in the RViz display. Additionally, this problem persists even after I attempt to initialize with GNSS.
Commands Used
I used the following commands to launch the simulation and play the rosbag:
ros2 launch autoware_launch logging_simulator.launch.xml map_path:=$HOME/autoware_map/kokusouken vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit pose_source:=ndt_lidar-marker

ros2 bag play autoware_map/kokusouken/rosbag/

Steps to Reproduce
1. Launch Autoware with the provided commands.

2. Open RViz and observe that the car and point clouds are not visible.

3. Attempt to initialize with GNSS, but the issue remains unresolved.

Expected Behavior
The car and point clouds should be visible in the RViz display, and GNSS initialization should allow proper visualization of the vehicle's position and sensor data.
Actual Behavior
Neither the car nor the point clouds are visible in RViz, even after attempting GNSS initialization.
Additional Information
* Running on UBUNTU 22.04 with ROS 2 humble

* Attached a screenshot of the RViz display showing the current state.

@cavadibrahimli1
The rosbag doesn't contain the /clock topic so you need the --clock 200 option to your ros2 bag play command, but did you try that?

Tests Performed
1. Start Autoware
ros2 launch autoware_launch logging_simulator.launch.xml \
  map_path:=$HOME/autoware_map/kokusouken \
  vehicle_model:=sample_vehicle \
  sensor_model:=sample_sensor_kit \
  pose_source:=ndt_lidar-marker

2. Correct Way of Running Rosbag
ros2 bag play autoware_map/kokusouken/rosbag/ --clock 200

@TaikiYamada4
3. Play Rosbag Video

A video was recorded to demonstrate the correct playback of the rosbag and successful visualization of the following topics in RViz:

/localization/pose_estimator/lidar_marker_localizer/pointcloud_preprocessor/ring_filter/pointcloud
/localization/pose_estimator/lidar_marker_localizer/lidar_marker_localizer/debug/marker_mapped
/localization/pose_estimator/lidar_marker_localizer/lidar_marker_localizer/debug/marker_detected
/localization/pose_estimator/lidar_marker_localizer/lidar_marker_localizer/debug/marker_pointcloud
/localization/pose_estimator/lidar_marker_localizer/lidar_marker_localizer/debug/pose_with_covariance

Screencast from 08-13-2024 01:26:21 PM.webm
Effects on System Behavior

System Initialization: The system initializes correctly when launching Autoware with the specified command, loading the map, vehicle model, and sensor configurations without issues.

Rosbag Playback: Playing the rosbag with the --clock 200 option generally ensures synchronized data processing, accurately reflecting real-time behavior. However, there are occasional instances where the rosbag deviates from the expected path, which may require manual intervention or resetting the playback to correct the trajectory.

Data Visualization: The visualized topics in RViz, such as point clouds and marker positions, display as expected, confirming that the system’s localization and sensor data processing functions are operating correctly.

Performance Considerations: During testing, the system performed well under normal conditions. However, it was observed that the system might freeze if a swap file is not created, particularly during memory-intensive operations. Creating a swap file is recommended to prevent these freezes and ensure smooth performance.

Resource Usage: The system’s resource usage remains within acceptable limits under typical conditions. However, memory usage can spike during extensive data processing, emphasizing the need for adequate memory management, including the use of a swap file, to maintain system stability.

Pre-review Checklist for the PR Author
[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review Checklist for the PR Reviewers
[ ] The PR follows the pull request guidelines.

Post-review Checklist for the PR Author
[ ] There are no open discussions, or they are tracked via tickets.

@cavadibrahimli1
Is your comment an approval or something else?
It seems your video shows us the mismatch between the observed pointcloud and the pointcloud map.
Do you have any reasons why?

@cavadibrahimli1
This is a friendly reminder about my comment. What do you think about my previous comment?

@TaikiYamada4 Thank you for your follow-up. I apologize for not responding sooner—I got caught up with some other urgent tasks and unintentionally missed your earlier comment.
I think the problem is with my computer. Because when I did the same test with my other computer, it worked without any problems. But in this test, there is a slight drift.
What do you think?

But in this test, there is a slight drift. What do you think?
It depends on what kind of drift is happening. Are you talking about the vehicle doesn't match expecially in the Z coordinates?
In your video it looks like the NDT is not working at all, but are you sure the ndt is outputting topics?

Plus, I want to ask your stance on this PR. Is your comment meant as an approval or a request change?


Recognise and enable acceptance of AutoRecorded images.

Complementary feature to the implementation of AutoRecord proposed to iOSSnapshotTestCase in this pull request: https://github.com/uber/ios-snapshot-test-case/pull/32. Enables image to be accepted (“swapped”) as a reference image, when an original reference image does not exist.

This pull request stands alone, but would function best in combination with the following three pull requests:
https://github.com/Antondomashnev/FBSnapshotsViewer/pull/69
https://github.com/Antondomashnev/FBSnapshotsViewer/pull/70
https://github.com/Antondomashnev/FBSnapshotsViewer/pull/71
In combination, and with the AutoRecord change to iOSSnapshotTestCase linked above, these changes enable snapshots to be automatically created on first run of a test if a reference image does not exist, to be reviewed, to be accepted or rejected via FBSnapshotsViewer, and in both cases for the test images to be cleaned up afterwards.


Use new Search component

Resolves #3314.
Transferring search context between Weave Cloud aspects is to be done in separate PRs.

Only issue: new default behaviour of cmp/Search is to pin items onBlur. I think this feels quite strange when you: filter > click a node > close > topo is filtered w/ pin and everything has disappeared.

That's a good point - as discussed, we can resolve this with https://github.com/weaveworks/ui-components/issues/365.


Remove old extension, replaced by collapsible_headings

The templates and nbconvert preprocessor need to be converted to the new collapsible_headings extensions.

Yeah, I haven't addressed those so far, mainly because I don't currently use nbconvert, so don't have much idea how it works. They also seem a little prototypical, so I guess they could do with an update. I'll have a look at some examples & give it a try.

Addresses #481

For a nbconvert template, see #510


Garbled success example

Nice and handy extension. Thanks.
I believe there's a bug that removes repeating lines from the success example and thus generates illegal json structure
The code which inserts the output is:
     * @param $str string Insert one row in output.
     */
    private function insert($str)
    {
        if(array_search($str, $this->out) === false)
        {
            $this->out[] = $str;
        }
    }

Now, because of the check for duplicates strings lines are removed.
I'm pretty sure there was good reason to add this check but the fact is that it garbles the output
For example (I've numbered the lines just for the explanation)
Now lines 6 and 9 are not inserted to the output because the are a duplicate of lines 2 and 5.
1  [
2      {
3          "id": 123,
4          "deleted": null
5      },
6      {
7          "id": 456,
8          "deleted": null
9      },
10 ]

So the output becomes:
1  [
2      {
3          "id": 123,
4          "deleted": null
5      },
7          "id": 456,
8          "deleted": null
10 ]

Removing the check creates a good leagal outout

Thank you @yairpe.
Currently i have no time to fix, but would be great if you can do it :)


Add support for reaction events.

The object from this looks like this (unique IDs redacted):
Reaction added to a file:
{
  type: 'reaction_added',
  user: '[REDACTED]',
  item: {
    type: 'file',
    file: '[REDACTED]'
  },
  reaction: 'grin',
  event_ts: '[REDACTED]'
}

Reaction removed from a message:
{
  type: 'reaction_removed',
  user: '[REDACTED]',
  item: {
    type: 'message',
    channel: '[REDACTED]',
    ts: '[REDACTED]'
  },
  reaction: '+1',
  event_ts: '[REDACTED]'
}

Note the ts property in the type object.
It's up to the app to look at the item property, check the type and act accordingly. Script used to test this:
var S = require('slack-client');

var slackOptions = {
  token: "YourTokenHere",
  autoReconnect: true,
  autoMark: true
}

var Cl = new S(slackOptions.token, slackOptions.autoReconnect, slackOptions.autoMark);

Cl.login();
Cl.on('open', function() {

});

Cl.on('reaction_added', function(reaction) {
  console.log(reaction);
});
Cl.on('reaction_removed', function(reaction) {
  console.log(reaction);
});

Nice. Unrelated to your code, but something to keep in mind for the JSON examples is that the structure for reaction.item is totally different for file and file_comment types.  Specifically, you can't rely on item.channel or item.ts - in my experience, no channel information was included in file reaction item types
  "type": "file",
  "file": { ... },
    "reactions": [
       {
         "name": "thumbsup",
         "count": 1,
         "users": [ "U1" ]
       }
    ]

  "type": "file_comment",
  "file": { ... },
  "comment": { ... },
  "reactions": [
    {
      "name": "facepalm",
      "count": 1034,
      "users": [ "U1", "U2", "U3", "U4", "U5" ]
    }
  ]

https://api.slack.com/methods/reactions.list

That's right, the RTM API doesn't return a channel ID for the file type, though it will for the message type, and that's something the RTM API does. Your app would have to use the API https://api.slack.com/methods/files.info to get information about the file based on its the item.file property (which is the ID of the file), from which you'd get channel information.

#59 might be the pull request to watch instead of this one. That one incorporates the API requests to add/remove reactions as well as listen for them.

Ok, first off, I apologize for how long it's taken us to resolve this PR.
I just pushed the 2.0.0 release for this library, which is a ground up refactor with the aim of building a lib that both Slack and our external contributors can easily work with and improve.
That release now passes through all messages from the RTM API by default as well as providing handlers for reactions against objects in the in-memory data store. Hopefully that gives you what you need, but if not, please raise an issue or create a new PR.


Added string unique ID Generator

Adding a unique string ID generator, copied from https://firebase.googleblog.com/2015/02/the-2120-ways-to-ensure-unique_68.html and https://gist.github.com/kiliman/ca1d9f4135078a6b24c5005113bbeea4
Thanks to @kiliman

Cool, but could you add a test that uses this with an actual document and add some docs for the usage too?

Thanks for looking at this code. It's pretty much a straight port of the original JavaScript implementation, so there might be some things to make it more idiomatic C#. I've commented on a couple of issues. I'm especially interested in the static lastPushTime. For the most part, the push ID would be generated client-side where thread concurrency isn't much of an issue. However, I could see potential problems on the server if 2 threads (requests) tried to generate an ID in the same millisecond, then you could potentially have duplicate IDs. Perhaps storing the static data in TLS would suffice.

Ugh... just noticed that I was logged in with my work account.

Added a test to store documents using the generator.

Should we change the default string generator into this one? if there's no value assign a unique string value else use the existing value..

Just to note in case it wasn't obvious, but these IDs are case-sensitive, as it encodes the data using both upper and lower-case letters. That's fine if you were to use it for JSON property names (which is primary use-case for Firebase). I know that PostgreSQL is case-sensitive by default, but could be an issue if somebody changed the collation, especially for the ID column.

@kiliman Just hitted the upper limit when adding 500 objects using StoreObjects resulting in "same Id already added to the session."

There's an issue with how it increments the last bit, especially if the previous digit is _ (largest value before rolls over to next digit). I'm looking at the code now.

Change the code to this and it will increment properly.
// If the timestamp hasn't changed since last push, use the same random number, except incremented by 1.
int i;
for (i = 11; i >= 0 && lastRandChars[i] == 63; i--)
{
    lastRandChars[i] = (char)0;
}
lastRandChars[i]++;

Thanks @kiliman ! Code is updated

Here are some changes that I think would make this more testable.
First, instead of the Func property I suggested in an earlier comment, simply add a default parameter to pass in the time to use.
public static string GeneratePushID(long unixTimeMilliseconds = 0L)
{
    var now = unixTimeMilliseconds == 0L
        ? DateTimeOffset.UtcNow.ToUnixTimeMilliseconds()
        : unixTimeMilliseconds;

This way, your unit tests can easily test for duplicate time handling, etc.
The other change would be to add a Reset method to control the static state as well as optional random number seed. Again this makes it simpler to unit test as you can then generate known values.
public static void Reset(int seed = 0)
{
    if (seed != 0)
    {
        rng = new Random(seed);
    }
    lastPushTime = 0L;
}

So now you can write a test like this:
FirebasePushIDGenerator.Reset(12345678);
var id1 = FirebasePushIDGenerator.GeneratePushID(1491859478805L);
var id2 = FirebasePushIDGenerator.GeneratePushID(1491859478805L);
var id3 = FirebasePushIDGenerator.GeneratePushID(1491859478805L);

id1.ShouldBe("-KhOkGZKQ_PEkTbWW_9a");
id2.ShouldBe("-KhOkGZKQ_PEkTbWW_9b");
id3.ShouldBe("-KhOkGZKQ_PEkTbWW_9c");

And for multi-thread tests, you can use the same time value and different seeds for each thread (call Reset(seed) in each thread) to verify that you'll get a unique ID even if multiple threads create an ID in same millisecond.
Hope this helps!

Hey guys, is there any update on this one? It's going to need some serious rebasing if you want this in for 2.0.

I've switched back to incrementing ID's, so for me the need is not there anymore.
I've got no time to make the adjustments in the tests.. I'm fine with closing the pull request

@mdissel kk


[release-1.2] virt-operator: Use informer stores for instance types and preferences

What this PR does
This is a manual backport of https://github.com/kubevirt/kubevirt/pull/12388.
See commit messages for conflicts.

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

None

/retest-required

/hold
for 1.3 to be first

/unhold

/override SonarCloud Code Analysis

/override "SonarCloud Code Analysis "

@fossedihelm @xpivarc @acardace - I've reviewed the SonarCloud failures and they are not relevant to this PR.
The SonarCloud checks should not be triggered against PRs - its just used for the badge on the kubevirt README.
I am not able to override the failure to allow tide to merge this - any objections to me merging this manually?

@fossedihelm @xpivarc @acardace - I've reviewed the SonarCloud failures and they are not relevant to this PR.
The SonarCloud checks should not be triggered against PRs - its just used for the badge on the kubevirt README.
I am not able to override the failure to allow tide to merge this - any objections to me merging this manually?

Thank you! lgtm from my side

@brianmcarey ok for me, thank you.

/hold
I am seeing issues with tests in another env.

/hold cancel
The env was broken

Sorry wrong button

/unhold

/retest-required

/unhold


Problem calling clear on input fields and then sendKeys() within element.all.each() loop

Hi,
So I'm running into an issue where I'm trying to loop through all of the input fields on the page, clear the input for them, and then update them with a value. Here's the essential code:
element.all(by.model('part.quantity')).each(function(part_q){
    part_q.clear().then(function(){
        part_q.sendKeys("1");
    });
}).then(function(){
    ...
}

This issue varies in scope (i don't mean the angular kind),  but say I have 7
<input ng-model='part.quantity'> 's on the page that i'm testing. When i run my test with the code above it goes through each input and clears all of them and updates them all with the value 1, except for the first 2 input fields. In the first 2 fields it clears, but it adds the value 1 to them twice. So say I have these values before running the test:
<input ng-model='part.quantity' value="4">
<input ng-model='part.quantity' value="4">
<input ng-model='part.quantity' value="4">
<input ng-model='part.quantity' value="4">
<input ng-model='part.quantity' value="4">
<input ng-model='part.quantity' value="4">
<input ng-model='part.quantity' value="4">

afterwards those values will become
<input ng-model='part.quantity' value="11">
<input ng-model='part.quantity' value="11">
<input ng-model='part.quantity' value="1">
<input ng-model='part.quantity' value="1">
<input ng-model='part.quantity' value="1">
<input ng-model='part.quantity' value="1">
<input ng-model='part.quantity' value="1">

but the expected result for all of the values is 1.
This changes if i have five elements. If i have five it only doesn't work for the first input field, but it works for the next 4. I've tried various solutions (different locators (e.g. by.css), or running through a recursive while loop such as:
$$('.part-quantity').count().then(function(num_parts){
    var idx = 0;
    function alterQuantity() {
        while (idx < num_parts){
            $$('.part-quantity').get(idx).then(function(part_q){
                part_q.clear().then(function(){
                    var rand_num = utils.randomIntFromInterval(2, 10).toString();
                    part_quantities.push(rand_num);
                    part_q.sendKeys(rand_num).then(function(){
                        idx++;
                        alterQuantity();
                    });
                });
            });
        }
    }
});

or running using filter() instead of each():
$$('.part-quantity').filter(function(part_q, idx){
    return part_q.clear().then(function(){
        var rand_num = utils.randomIntFromInterval(2, 10).toString()
        part_quantities.push(rand_num)
        console.log(rand_num);
        browser.sleep(2000);
        return part_q.sendKeys(rand_num);
    });
}).then(function(quantity){
    console.log(part_quantities);
});

but the filter() i used and the each() functions function identically. The recursive thing doesn't really work (i didn't spend too much time on it since I didn't really see too much promise in it working any better). This seems like a webdriver thing but I've hit a wall at this point and don't know what to do. I don't know if I need to be utilizing promises better?  Any help would be appreciated.
Thanks.
edit: I've tested with both chrome and firefox drivers and the same thing happens

So I tried doing the following:
element.all(by.model('part.quantity')).each(function(part_q) {
    part_q.click().sendKeys(protractor.Key.chord(protractor.Key.COMMAND, "a"));
    part_q.click().sendKeys(protractor.Key.BACK_SPACE);
    part_q.sendKeys("1");
});

but then I ran into issues with both chrome and firefox testing. In firefox it wouldn't clear the value, but it would add the 1 (although i think it would only add the 1 once). In chrome I would occasionally get this error Failed: unknown error: Element is not clickable at point. I can also confirm that my original code occurs both in firefox and chrome driver tests

I'm pretty sure this is due to https://github.com/SeleniumHQ/selenium/issues/444
Which will be fixed in the next selenium-webdriver release.

ok I will wait to test with the next selenium release and then report back with whether or not that fixes it

Any updates on this?

Closing as obsolete.

@juliemr Why is this obsolete? Is there a better method to do this? or was there a fix?

Hi, I'm facing same issue without element.all.each() loop.There are two input fields and I'm clearing both fields and then filling value respectively as 12.34 and for next field 1.25 but sometimes it fills 1,252.34 in the first field and test case is failing.This issue is occurring intermittently.
Is there any update on this?


[License] Remove CKEditor source + Introduce a command to download/install it

This PR fixes #295 and fixes #297. It removes CKEditor source from the bundle & introduce a new command to download/install it easily. It is a BC break and so, it will be available as 6.x version.

@javiereguiluz Is there something I have to do on the Flex recipes?

I don't think we need to change anything on the recipe. The only (optional) thing may be to display a short output message warning the user about the need to install CKEditor to use this bundle.


Organization Slots

When an organization is defined, it can be given "slots".  Each slot has a title (free text field) and role (selected from pre-defined choices).
Roles will include:

Administrator
Owner Manager
Precor Admin Asst
Serv Dealer Admin
Learner

Once a slot is defined on an organization, a user can be associated with it.  Users can also still be associated with an organization and a role irrespective of a slot.
I think this can be accomplished with a slight modification to the [UserOrgRole] (https://github.com/TireSwingSoftware/openassign-server/blob/b2e1f8e542cf5e25facf57b2e4a06b448f7b6144/pr_services/pr_models.py#L520) model.  We will need to add two attributes to it:

'title' : the title of the slot, such as "President", "Owner", "Secretary", "Master of the Universe", etc.
'persistent' : boolean indicating that the position should persist even without a user defined.

As such, any UserOrgRole with the "persistent" boolean set to True will be called a "Slot" and can exist without a user defined.  This is most helpful when a user is removed from an organization and we need to know if their UserOrgRole should persist without them.

I'll give this one a shot.

I don't completely understand the proposed schema. Maybe you could list some of the use cases.
It sounds like the "slots" aren't actually concrete objects in the model and will be defined implicitly by 'persistent' being true. If these roles are defined on organizations, isn't this already achieved with the association of roles to organizations in UserOrgRole (and the addition of the roles you listed)?
Should the roles be added to precor_org_roles.json?

Correct.  We are not creating a new type of object here.  A "slot" is a UserOrgRole where the "persistent" boolean is True.
It's true that right now we can create UserOrgRole records without a User defined and call them slots.  However, the "persistent" value is required when we are removing a user from an organization.  The question is- should this UserOrgRole persist without the user and be available for a new user, or should it be deleted?  Having the "persistent" attribute is the only way to know.
Does that answer your question?
Feel free to add the roles to the fixture.

Yes thanks for the good explanation.

It looks like this was merged in #33


[CWS] improve lock contention related to the pathnames LRU map

What does this PR do?
The pathnames map is currently driving most of our kernel side lock contention. To improve this, this PR moves the map to be a BPF_F_NO_COMMON_LRU LRU which reduces a lot the amount of contention.
Map resolution is used when eRPC fails, as such it's not critical if the LRU is behaving a bit differently than before.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


I have docker-kong checked out locally and on my CDPATH

This caused the pushd docker-kong to go to that folder rather than the locally cloned one. I also added some logging I found helpful.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

:tada: This PR is included in version 4.30.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Please help me.

How can I use for llama3?  it's only supported for openai. is it right?
if you support llama, it seemd to perfect.

I just added support for running open source models though Ollama in v0.4.2. See this example for using a local Ollama instance with llama3 installed. Hope this helps!
I plan to add support for directly running LLMs using the rustformers llm crate in the future.


Update golang to 1.21

Bump golang to 1.21

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.06%) to 25.706%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
2359

Relevant Lines:
9177

💛  - Coveralls

@SchSeba @adrianchiris @e0ne PTAL

@bn222 you will need to bump golangci-lint version as well , they added support for go 1.21 in ver 1.54

Bumped to 1.55.2 (latest as of today)

I think the new linter is more pedantic. I will wait until https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/553 merges, and then rebase on top to fix the remaining linter errors.
@adrianchiris Unless I missed something fundamental.

@bn222 #553 merged ! we can proceed with updating this one 🎊

@adrianchiris ptal