Temperature overhaul

About the PR

general refactoring
added a few docs to temperature fields
add internal temperature component which is modified by surface temperature
cooking uses internal temperature now

should be compatible with better temp alerts since we both file scoped it :trollface:
internal temperature doesnt affect animals right now but it could in the future
would make reptiles actually realistic ish since they cant regulate temperature, they have to rely on the enivornment (air and insulation) instead of sweating and stuff
Why / Balance
https://youtu.be/4gTMtUAAoNw
cooking things at 1000C doesnt cook them faster it just burns the outside while leaving the inside raw
you have to actually give it time to dissipate heat to the inside so everything cooks
(when food burning implemented this will actually nerf plasma fire cooking since everything would be scorched)
Technical details

removed the HeatCapacity field on TemperatureComponent, it uses GetHeatCapacity on the system now
added InternalTemperatureComponent

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes
HeatCapacity is no longer a field of TemperatureComponent, use GetHeatCapacity from TemperatureSystem.
Changelog
:cl:

tweak: Meats now have an internal temperature that changes slower than the surface temperature, cook them slowly not instantly in a plasma fire.

why did i click open :trollface:

Please do not make refactoring changes, breaking changes, and feature changes in the same PR.

that goes against the policy of bringing files you touch up to the latest standards

Please review the latest pull request guidelines. You can of course bring up a file to the latest standards in one PR, and then follow on with your changes.

You can of course bring up a file to the latest standards in one PR, and then follow on with your changes.

that would have lots of conflicts and be a huge pain to fix

that would have lots of conflicts and be a huge pain to fix

Then make only content changes in this PR.

yes and it will still conflict because file scoping

This code doesn't compile.

@Partmedia it do

@Partmedia

@Partmedia remove do not merge :trollface:

@Partmedia remove do not merge :trollface:

Not until checks demonstrate that this code compiles. But sorry for the delay and long wait on this.

very real

It seems to me that the data fields in InternalTemperatureComponent belong in TemperatureComponent. You admit that InternalTemperatureComponent does not work without TemperatureComponent, so why is it a separate component? It's not like any entity with TemperatureComponent doesn't have an internal temperature, either. In fact, you can just store the reciprocal of conductivity (thermal resistivity) and set it to zero when you want a TemperatureComponent that instantly equalizes.

when i first started i added them as fields to the temperature component but it was too messy and i made it into a separate component
also means there is less edge case handling since the fields can just be required instead of handling 0s for things

when i first started i added them as fields to the temperature component but it was too messy and i made it into a separate component also means there is less edge case handling since the fields can just be required instead of handling 0s for things

I see. As I mentioned, storing thermal resistivity instead of conductivity allows you to avoid special-casing 0.

Turns out that I'm having an off-day. Sorry, conductivity as you've stored here is the way to prevent divide-by-zero's. Unless otherwise specified, I think anything with a temperature also has an internal temperature, so setting a high default conductivity is probably fine. This also avoids having to remember to TryComp both internal and external temperatures.
Ultimately as I've mentioned I'm also fine with this as-is. Are you considering a revision? If not, I'm going to merge this.

i am gaming it can be changed later :trollface:

Cook chicken to an internal temperature of 165°F.


📦💻 - Fix Highlight issues with Tree Sitter

The issue was identified to be caused by the coc-highlight that gets enabled on CursorHold.
I've disabled that feature since it wasn't being used anyway.


vscode tries to restore packages evert 1 minute

after updating to
Версия 1.5.2
something with restoring packages of aspnet project was broken
vscode tries to restore packages even if i restored packages before by command line. and c# plugin intellisence is not working.
please stop broking vscode

Reading your description it seems that the issue originates from an extension and not VS Code itself. Thereby I will close this issue and kindly ask you to report this issue against the extension repository.
Most extensions are on GitHub as well so it should be easy to file it against the extension. If you open an extension on the market place, click on the Support link to find out more.

Thanks again for your feedback!


Feature Request: user/group security policy to enforce encrypted connection of vpn clients.

A far as I know there is no security policy (neither at user or group level) available on the vpn server to deny the connection of vpn clients, which have disabled the use of encryption by configuration on the client side.
Would be a big advantage to have this additional security policy available on the server side.
Kind regards.

I would like to draw attention to this issue again. It seems kinda important to have a setting to enforce encryption.


Queries

Query support for:

filter
inlinecount
orderby
select
skip
top

https://github.com/Unity3dAzure/AppServicesDemo/wiki/Feature-roadmap

$top is in master

HttpUtility.UrlPathEncode (using RestSharp.Contrib) wont build for Windows 10. Looking at http://docs.unity3d.com/ScriptReference/WWW.UnEscapeURL.html instead

Azure App Services related documentation:

Azure App Service REST API
Azure App Service Query
OData query (for use in $filter predicates)


Dynamic READMEs

Provides some tools to filter a readme, like hatch-fancy-readme.

Closed by #197.


Add the client version in CreateSessionRequest

Used for user behavior analysis
Better compatibility for servers to serve clients of different versions in the future


Save parameters and config to output

This PR saves the parameters and parsed_args to a folder reproducibility within the output dir.
The restart file is also saved if it is available - I'm not sure this is needed, as this may just create extra files without benefit.

One benefit of saving the yank file to the output folder, and not in the reproducibility subfolder, is that we could open/read those files from buildkite’s artifacts. Might that be better?
also, what is in the restart file?


feat: return value shows success/failure for shell

Shell processes can rely on success (0) / failure (1) return value to conditionally process other commands

@canadaduane, doesn't bash code (0 or 1) represents an error that happened at runtime? The absence of open ports is not an error, in my understanding.
As long as I made it pipe-friendly, maybe you are looking for something like this?
# will silently execute checking and return 0/1 if it exists or not
tcp-exists some-nonexisted-domain.com:80 | grep '\ton' > /dev/null
echo $? #will print 1

tcp-exists google.com:80 | grep '\ton' > /dev/null
echo $? #will print 0

Thanks for looking into this. As far as I understand it, a bash return code is just an 8-bit number that we can assign meaning to, and "0" is conventionally understood to mean "no problem occurred". I ended up making a little script that can be used to check if a port is blocked, optionally kill it if it is, and a few other minor things for our use case: https://github.com/canadaduane/blockaid
I appreciate you considering this idea, feel free to close if it does not align well with tcp-exists' intentions.

@canadaduane
I can understand your idea and it could be a nice features. Yeah, there is 2 features: silent mode and exit code as result of cmd execution.
But changing code exiting behaviour break back compatibility.
If you want to add this feature, then maybe you can make additionally another option? Something like --target=none|any|every. With --target=none it will work as work now (code 0 if no error occur). With --target=any will work as you described right now (code 0 only if at least one port is open, otherwise code 1). With --target=every will return 0 only if every desired ports are open.


fix: change the install output to include the executable path

With this change, the executable path will be printed to stdout in the following format: $browser@$revision $executablePath which makes it easy for tools to save the data for future use.

marked as a fix to trigger a patch release.


:bug: Comment out empty patches

Signed-off-by: Vince Prignano<EMAIL_ADDRESS>
What this PR does / why we need it:
Running kustomize build "github.com/kubernetes-sigs/cluster-api-bootstrap-provider-kubeadm//config/default/?ref=master" fails with error 2019/08/20 10:31:27 invalid patches from <nil>, this fixes the error and allows for files to be properly generated.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:

/assign @chuckha

interesting, is that new in kubebuilder rc.0?
/lgtm

Not sure, it has never worked for me with empty patches

weird, I've never hit this but it's fine to remove it if this works for you

I'm using
$ kustomize version
Version: {KustomizeVersion:3.1.0 GitCommit:95f3303493fdea243ae83b767978092396169baf BuildDate:2019-07-26T19:21:45+01:00 GoOs:darwin GoArch:amd64}

I really should be using a release
 kustomize version
Version: {KustomizeVersion:unknown GitCommit:$Format:%H$ BuildDate:1970-01-01T00:00:00Z GoOs:darwin GoArch:amd64}

😂


US 01.02.01

As an owner, I want to view an item and its details.
Requirements

Functionality for tapping item in list view to open view fragment
Implement view item details fragment

Requirements

[x] Need to implement the detailed view of the item.
[x] Need to launch the activity/fragment for the view of the item from the item list activity.

completed


New Sidebar UI changes and Scrolling feature

Description

Scrolling Blur Effect: When the user scrolls the page, a subtle blur effect is applied to the navigation bar. This effect helps draw the user's attention to the navigation bar and creates a sense of depth as the user interacts with the content.

Clear Visibility on Stop: After the user stops scrolling, the blur effect is removed, and the navigation bar becomes clearly visible. This behavior ensures that the navigation options are easily accessible when needed.

Implementation Details:

The Navbar component now utilizes React's useState and useEffect hooks to track scrolling and apply the blur effect.

A showing state variable is introduced to determine whether the navbar should be clearly visible when scrolling stops.

A showTimeout variable is used to manage the timeout for removing the blur effect when scrolling stops.

CSS styles have been added to control the blur effect and clear visibility.

Testing:
I have thoroughly tested this feature on different devices and browsers to ensure that it works as intended. I have also verified that the blur effect is applied while scrolling and removed promptly when scrolling stops.
Fixes # (issue no.)
#105
Type of change

[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

Reviewer Note:
Please review and provide feedback on the implementation, code quality, and user experience improvements. Thank you!
ATTACH SCREENSHOTS

on scroll

@piyush-mahajan could you fix the extra margin to the left of the sidepanel

Ya sure👍

so i have change the sidebar according to you, can you merge it✌

so i have change the sidebar according to you, can you merge it✌

After the user stops scrolling, the blur effect is removed, and the navigation bar becomes clearly visible. This behavior ensures that the navigation options are easily accessible when needed.

The current implementation only blurs navigation but does not disable the blur effect while the user stays for a page for any point of scroll,
make sure you the 2nd point you mentioned in the issue is implemented, then we are good to go with this PR.

Ok ✌

change the scroll feature, have a look ✌and merge it 🙂


next/prev click event: slide example

Can you able please supply an detailed example to implement directive next/prev slides?
i have the following directive markup and i trying to emit next/prev slide click event with no luck...

I don't quite understand you question. The configuration is just like with Swiper there is no differences when compared to this wrapper and the events are just normal Angular outputs like the documentation says. But the thing I don't quite get is that you are talking about emitting events, so not sure what you are trying to do. The library emits the events and if you are interested you provide a handler normally with Angular output binding.


[PowerToys Run] Win+S hotkey won't gain focus when Start menu is open

Microsoft PowerToys version
0.58.0
Running as admin

[x] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce

Set up PTR activation shortcut to Win+S.
Open Microsoft Teams.
Hit Win+S on keyboard.

✔ Expected Behavior
PowerToys Run panel appears.
❌ Actual Behavior
Windows Start menu opens.
Other Software
Microsoft Teams Version <IP_ADDRESS>63 (64-bit)

Just gave it a try setting PowerToys Run shortcut to Win+S and opening Microsoft Teams. Win+S still brings up PowerToys Run. Tried running it as admin/non-admin and with/without using the centralized keyboard hook.
Is there any other setting that might be relevant here?
Couldn't replicate this.
Can you give some more details on the behavior? Does Teams have to focused or just turned on for this to occur? Are you still able to start PTR without Teams running? /needinfo

It might be that this problem is not quite with Teams at all, but I was able to replicate this problem on my two different machines with absolutely different hardware and having win10 and win11 respectively.

So this is some incompatibility between having the Windows start menu opened, a Win+key shortcut. Given that we're trying to override a Windows shortcut, it'll be using a lowlevel keyboard hook which can't steal focus from some Windows controls (start menu is an example).

So this is some incompatibility between having the Windows start menu opened, a Win+key shortcut.

This is at least one clear scenario. Tell me, does it reproduce on your side?

So this is some incompatibility between having the Windows start menu opened, a Win+key shortcut.

This is at least one clear scenario. Tell me, does it reproduce on your side?

I can reproduce it. Don't think we're able to work this one out, though. Windows will switch focus on a hotkey, but that hotkey is already taken for search so we need to use a low-level hook instead. This won't be able to "steal" focus from certain Windows OS controls, like the Search menu, for example.

I've got small update - a workaround, actually. As you may know, there are many ways to disable system hotkeys in Windows, but this particular actually fixes the issue (checked on Win10 and Win11):
In registry open key HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced and add string value "DisabledHotkeys" = "S". This will disable Win+S system hotkey (along with Win+Shift+S, sadly) and the aforementioned bug is never reproduced again.
So, the bug nature has something to do with system hotkey trying to intercept control. Maybe you could disable any system hotkey in similar way when it's assigned as PTR activation key?

This appears to be fixed! Let us know if you see this happening again :)


[Thinkit] Add a util to verify queue limits are correctly set.Associate test case Id. Add a queue counter log in sFlow test. fix thread issue. Use absl::CleanUp to join threads in case tests failed. Fix parameter name.Add util to check if sFlow is enabled in gNMI config.

Key_word Check:
~/pins_upstream/sonic-buildimage/src/sonic-p4rt/sonic-pins/tests/sflow$ ~/tools/keyword_checks.sh .
Keyword check Passed.

Build result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Analyzed 636 targets (0 packages loaded, 0 targets configured).
INFO: Found 636 targets...
INFO: Elapsed time: 0.444s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

Test result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 636 targets (0 packages loaded, 0 targets configured).
INFO: Found 424 targets and 212 test targets...
INFO: Elapsed time: 161.726s, Critical Path: 116.14s
INFO: 266 processes: 321 linux-sandbox, 18 local.
INFO: Build completed successfully, 266 total actions
//dvaas:port_id_map_test                                                 PASSED in 1.8s
//dvaas:test_run_validation_golden_test                                  PASSED in 0.1s
//dvaas:test_run_validation_test                                         PASSED in 1.3s
//dvaas:test_run_validation_test_runner                                  PASSED in 0.1s
//thinkit:mock_control_device_test                                       PASSED in 0.9s
//thinkit:mock_generic_testbed_test                                      PASSED in 1.0s
//thinkit:mock_mirror_testbed_test                                       PASSED in 1.5s
//thinkit:mock_ssh_client_test                                           PASSED in 0.2s
//thinkit:mock_switch_test                                               PASSED in 1.6s
//thinkit:mock_test_environment_test                                     PASSED in 0.1s
//thinkit:switch_test                                                    PASSED in 1.4s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test     PASSED in 1.7s
  Stats over 5 runs: max = 1.7s, min = 1.4s, avg = 1.5s, dev = 0.1s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test     PASSED in 44.0s
  Stats over 50 runs: max = 44.0s, min = 1.2s, avg = 3.2s, dev = 8.3s

Executed 212 out of 212 tests: 212 tests pass.
INFO: Build completed successfully, 266 total actions

/azp run

/azp run

/azp run

@VSuryaprasad-HCL Pls fix conflicts

/azp run


refactor _read_or_write

This separates the data conversion for CFFI from the function selection.
This is a continuation of the discussion in #138 .

I don't see an improvement from passing a string to passing a function object (while adding 2 new functions that only differ in the substring 'read' vs. 'write'), but I can live with it since it's only a minor implementation detail.
But the real problem is still unsolved: the error checking is separated from the code that relies on it.
I think this is solved in a less complicated manner in #138 (with less levels of indirection and IMHO easier to read), but if you prefer your way, you should at least call _check_array() inside of _read() resp. _write()!

Probably we should skip the discussion here and implement #72 instead, because this potentially changes the same code (again) ...
But first, I think it would be a good time to release 0.7.1!

superseded by #72.


Fix readme to use proper action path (#1)

The readme example is wrong and outdated, it should be using hectorcoy namespace instead of the previous afinkorea namespace. It should also use the @master tag since there is no @v1 in @hectorcoy's repo.

Correction, it should use the @1.0.19 tag instead of master.


Question about label

I would like to ask about the label in the congestion prediction and DRV prediction problem. The value of each pixel in the label in the dataset is between 0 and 1. What is the actual physical meaning of this? I see that some other articles define congestion prediction as a classification problem, and the label value is 1 or 0. Is there also a threshold so that the pixel value above the threshold represents congestion? The label in DRV prediction is a similar problem

Yes, some articles define these tasks as a classification problem, but the model is trained in a regression manner, and the prediction is turned into binary with a threshold, then we plot ROC curve and PR curve to evaluate the result.

How is this threshold set, or is it also a hyperparameter？In addition, do the values in the label have actual physical meaning？

Of cource the values have physical meaning, in DRC task, the values are the number of DRC violations counted in each tile, and in IR drop task, the values are the IR drop values in each tile.
The threshold is set according to actual needs. For DRC, we want to find areas with most DRC, and let EDA tools to optimize these areas. Similarly, for IR drop, we have some specifications that the max IR drop should be limited under specfic percent, like 5-10%, then we set this as threshold.

Thank you for your answer.
Actually, my question is about congestion prediction. What is the physical meaning of congestion value? The congestion value in LHNN is described as follows: “set the congestion maps as a binary indicator according to whether the horizontal/vertical routing demand of the G-cell  exceeds the circuit's capacity”.. Here is converting the congestion prediction problem to a classification problem, and to align with it, I also want to convert the label of congestion in CircuitNet to binary. So I want to figure out what the physical meaning of this label is, is there a threshold that converts it to binary?
I am new to this field, so my basic knowledge is relatively weak. Thank you for your patient answer

In congestion prediction task, labels are generated from overflow files, and after resizing and normalizing, the values are between 0 and 1. If I want to plot ROC curve, how should I decide the threshold label to convert labels into binary?


Issue #134: Octane report plugin support

Description:
This PR adds Octane plugin code. We just need to add the config to the plaxrun file and plaxrun takes care of the rest.
Sample usage:

I added config (referred in the doc/octane_plugin.md below) to cmd/plaxrun/demos/waitrun.yaml and ran the command - plaxrun -run cmd/plaxrun/demos/waitrun.yaml -dir demos -g wait-no-prompt -json
Octane plugin - console log:

<test_result>
 <product_areas>
  <product_area_ref id="123456"></product_area_ref>
 </product_areas>
 <test_runs>
  <test_run name="test-wait waitrun-0.0.1:wait-no-prompt:wait" duration="606" status="Failed" started="1632173133000">
   <test_fields>
    <test_field type="Framework" value="plax"></test_field>
   </test_fields>
   <error>Broken: Err: Broken: phase phase1: Broken: step 5: Broken: Javascript problem: failure: too slow: 605</error>
  </test_run>
 </test_runs>
</test_result>

Equivalent Plax console log:

{
  "name": "waitrun",
  "version": "0.0.1",
  "testsuite": [
    {
      "name": "waitrun-0.0.1:wait-no-prompt:wait",
      "tests": 1,
      "passed": 0,
      "skipped": 0,
      "failures": 0,
      "errors": 1,
      "testcase": [
        {
          "name": "test-wait",
          "file": "/Users/smudig200/Documents/comcastgit/octane_plugin/plax/demos/test-wait.yaml",
          "status": "error",
          "time": 606178000,
          "started": "2021-09-20T21:25:33.730331Z",
          "message": "Broken: Err: Broken: phase phase1: Broken: step 5: Broken: Javascript problem: failure: too slow: 605"
        }
      ],
      "timestamp": "2021-09-20T21:25:33.728889Z",
      "time": 607622000
    }
  ],
  "tests": 1,
  "passed": 0,
  "skipped": 0,
  "failures": 0,
  "errors": 1,
  "timestamp": "2021-09-20T21:25:33.728736Z",
  "time": 607783000
}

Created a new pull request with clean editor info and updated it with suggested changes.


qiime_params.txt does not exist in qiita.microbio.me

I tried analyzing a metagenomic study and I got the following error message from beta_diversity.py:
beta_diversity_through_plots.py: error: option --parameter_fp: file does not exist: '/projects/qiita_data/reference/params_qiime.txt'

It seems like this file doesn't exist in qiita.microbio.me, and it probably doesn't exist in anyone's environment. These are the lines where this is happening

On of those awesome hardcoded things in the analysis pipeline that was done for a demo...

Agree

Wrong button, sorry. We can add that file and get a better fix ...

I just added a file to microbio.me with the following contents:
beta_diversity:metrics  bray_curtis,gower,canberra,pearson,euclidean

I'll close this for the time being as the real issue is described in #164


Clipetty for TTY users

Describe the feature
Hi, TTY user here. I have always find xclip package not as ideal as I wanted. Obviously, because it requires some sort of display server running in order to get it to work.
Recently, I cam across a reddit post by author of Clipetty, a package which utilizes OSC 52 escape sequences to forward kill-ring-save content to supported terminals directly without display server in-between.
I didn't know this terminal feature existed, but it sounded like exactly what I was hoping for. Thus, I gave it a try for about a month and it works amazing. (even through TMUX!)
This feature requires clipboard feature to be turned on in terminal emulators.
For xterm, following line should be added in ~/.Xresources
XTerm.vt100.allowWindowOps: true
For iTerm2, it's in Preferences/Selection/Application in terminal may access clipboard
It is picky about the terminal emulator, but I think it's much more reliable than X forward based mechanism.
Please consider adding this feature. I can also contribute if you can point me to the correct place for adding this feature. (Through editor module? or implement similar to xclip?)
Thanks!

I don't have a stance on whether this would help, but xclip is the surface cause of my issue #2617. Just remarking here to help link the discussions for folks.

+1 for this feature.

Just a heads up. As of 0a4841b Doom has a :os tty module for clipboard integration (also cursor-shape changing across evil states).

It will install xclip by default.
Enable :os (tty +osx) to enable clipetty instead (i.e. won't install xclip).
Or don't use it at all, if you don't like either implementation -- in either case, they are now opt-in.

Hope that's helpful!

Anecdotally I seem to be getting along very happily with the new tty module - thanks Henrik! 😁

Thanks Henrik. There is a typo in the comment above. Should've be +osc instead of +osx. XD


Code Climate Fixes

I adjusted two variable names that Code Climate was flagging as either too long or too short and also added the badge to the README.md file.

Thanks :-)


Changes based on testing on local VMs

Looks good to me. Maybe add something like to playbooks/catalyst_install.yml to install 'yarn'?

name: install npm global packages
shell:
cmd: npm install -G "{{ npm_global_pkg }}"
become: true
loop: "{{ nodejs_npm_global_packages }}"
loop_control:
loop_var: npm_global_pkg

Looks good. I don't exactly follow all the template stuff -- but understand you're accounting for missing files (database.yml, blacklight.yml, and .env) and capistrano stuff.


Action on event

Expected behavior
I could not find a way in Taiko to act on some event/status. For example in my application when the user logs in, the application opens up. However at times due to security, the application pops screen for validation of email or option to "remind later". In Selenium, I can find the title and if the title matches some text, I can do the required step, else continue. How can this be achieved in Taiko?
Actual behavior
Tell us what happens instead
Steps to reproduce

Versions
Paste `node` and `taiko` versions here.

If there is a predictable trigger for your popup, you can add a step that detects the popup with a selector and using .exists(), then saving that to a variable for evaluation at any time.  Though, I imagine you wouldn't want to go through this in every test, in which case you could manage your test case's state to prevent running into the popup at unpredictable times.

also discussed here: https://spectrum.chat/taiko/general/how-to-handle-rare-screens~f72b9dc1-4fa8-4c52-be06-53fbe388152d

As of now, we can suggest you handle the pop up by adding logic in the login scenario as it is dynamic in nature.
You can find more details here Events api.
Also we are requesting you to share a sample of code to replicate the same scenario.

Closing this. Feel free to reopen/comment if you have any details that can help replicate this issue.


compilation terminated

@jgwak  @liujiaxing
Hi,I was trying to reproduce this experiment,and I follow the given instructions. My compilation environment is Python3.5.3. However,I meet the same problem that Liujiaxing met .
Could you give me some help or any suggestions? Thanks very much.
`Problem occurred during compilation with the command line below:
/usr/bin/g++ -shared -g -march=ivybridge -mmmx -mno-3dnow -msse -msse2 -msse3 -mssse3 -mno-sse4a -mcx16 -msahf -mno-movbe -maes -mno-sha -mpclmul -mpopcnt -mno-abm -mno-lwp -mno-fma -mno-fma4 -mno-xop -mno-bmi -mno-bmi2 -mno-tbm -mavx -mno-avx2 -msse4.2 -msse4.1 -mno-lzcnt -mno-rtm -mno-hle -mrdrnd -mf16c -mfsgsbase -mno-rdseed -mno-prfchw -mno-adx -mfxsr -mxsave -mxsaveopt -mno-avx512f -mno-avx512er -mno-avx512cd -mno-avx512pf -mno-prefetchwt1 -mno-clflushopt -mno-xsavec -mno-xsaves -mno-avx512dq -mno-avx512bw -mno-avx512vl -mno-avx512ifma -mno-avx512vbmi -mno-clwb -mno-mwaitx -mno-clzero -mno-pku --param l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=3072 -mtune=ivybridge -DNPY_NO_DEPRECATED_API=NPY_1_7_API_VERSION -m64 -fPIC -I/home/wj/3D-R2N2/py3/lib/python3.5/site-packages/numpy/core/include -I/usr/include/python3.5m -I/home/wj/3D-R2N2/py3/include/python3.5m -I/home/wj/3D-R2N2/py3/lib/python3.5/site-packages/theano/gof -L/usr/lib -fvisibility=hidden -o /home/wj/.theano/compiledir_Linux-4.10--generic-x86_64-with-Ubuntu-17.04-zesty-x86_64-3.5.3-64/lazylinker_ext/lazylinker_ext.so /home/wj/.theano/compiledir_Linux-4.10--generic-x86_64-with-Ubuntu-17.04-zesty-x86_64-3.5.3-64/lazylinker_ext/mod.cpp -lpython3.5m
/home/wj/.theano/compiledir_Linux-4.10--generic-x86_64-with-Ubuntu-17.04-zesty-x86_64-3.5.3-64/lazylinker_ext/mod.cpp:1:20: fatal error: Python.h: No such file or directory
#include <Python.h>
^
compilation terminated.
Traceback (most recent call last):
File "/home/wj/3D-R2N2/py3/lib/python3.5/site-packages/theano/gof/lazylinker_c.py", line 75, in
raise ImportError()
ImportError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/wj/3D-R2N2/py3/lib/python3.5/site-packages/theano/gof/lazylinker_c.py", line 92, in
raise ImportError()
ImportError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "demo.py", line 17, in
from models import load_model
File "/home/wj/3D-R2N2/models/init.py", line 1, in
from models.gru_net import GRUNet
File "/home/wj/3D-R2N2/models/gru_net.py", line 4, in
import theano
File "/home/wj/3D-R2N2/py3/lib/python3.5/site-packages/theano/init.py", line 66, in
from theano.compile import (
File "/home/wj/3D-R2N2/py3/lib/python3.5/site-packages/theano/compile/init.py", line 10, in
from theano.compile.function_module import *
File "/home/wj/3D-R2N2/py3/lib/python3.5/site-packages/theano/compile/function_module.py", line 21, in
import theano.compile.mode
File "/home/wj/3D-R2N2/py3/lib/python3.5/site-packages/theano/compile/mode.py", line 10, in
import theano.gof.vm
File "/home/wj/3D-R2N2/py3/lib/python3.5/site-packages/theano/gof/vm.py", line 662, in
from . import lazylinker_c
File "/home/wj/3D-R2N2/py3/lib/python3.5/site-packages/theano/gof/lazylinker_c.py", line 127, in
preargs=args)
File "/home/wj/3D-R2N2/py3/lib/python3.5/site-packages/theano/gof/cmodule.py", line 2316, in compile_str
(status, compile_stderr.replace('\n', '. ')))
Exception: Compilation failed (return status=1): /home/wj/.theano/compiledir_Linux-4.10--generic-x86_64-with-Ubuntu-17.04-zesty-x86_64-3.5.3-64/lazylinker_ext/mod.cpp:1:20: fatal error: Python.h: No such file or directory.  #include <Python.h>.  `

You need to install python3-dev.
Please install python3-dev by running
sudo apt-get install python3-dev

Thank you very much for your advice.The above problem has been solved. But there are new problems.
ERROR (theano.sandbox.cuda): nvcc compiler not found on $PATH. Check your nvcc installation and try again. Traceback (most recent call last):   File "demo.py", line 17, in <module>     from models import load_model   File "/home/wj/3D-R2N2/models/__init__.py", line 1, in <module>     from models.gru_net import GRUNet   File "/home/wj/3D-R2N2/models/gru_net.py", line 8, in <module>     from lib.layers import TensorProductLayer, ConvLayer, PoolLayer, Unpool3DLayer, \   File "/home/wj/3D-R2N2/lib/layers.py", line 8, in <module>     from theano.tensor.signal import downsample ImportError: cannot import name 'downsample'
I come from Tsinghua University from China. I am very interested in your experiment. So I am trying my best to reproduce this experiment,but often meet problems.
I am very sorry to brother you. Could you give me some help or any suggestions for this problem?

https://github.com/Theano/Theano/issues/4337


Support for non-indexed drawing and line width

Fixed regression with non-textured meshes
Moved mesh handling into the renderer (one place) and out of all the shaders (code duplicated in many places)
Added support for line width (set "line_width" uniform in GVRMaterial)
Fixed regression in GVRCylinderSceneObject

This pull request fixes the problem with drawing polylines
GearVRf-DCO-1.0-Signed-off-by: Nola Donato<EMAIL_ADDRESS>

Looks good. Tried with few samples. Will merge in the afternoon.


add freebies mentioned in the web article

The following article contains 100+ free resources for designers and developers. I need your support to add them to Devbies platform.
https://dev.to/suhailkakar/best-design-resources-for-developers-4f
If interested, please let me know in the comments. Thanks a lot.

@ahmedinshaf You can work on this also, only if you have some free time 😃 .

Since there are lots of resources in this article ,I can make a scraper to scrape the name,description,and url for every resource , But the problem is with image url 😑 . Any suggestions to tackle this problem ?

Good idea mchn 👏
Regarding the image URL part, I was also thinking about that. I created a node.js app using Puppeteer that takes a screenshot of a webpage of a given URL, uploads it to Imgur and returns the image URL, but still couldn't deploy it.
I will let you know once it's done. probably will be able to complete it by tomorrow. Let's continue this task after that's done.
Cheers 🥂

I created json for every category that mentioned in article and added ✅  added to 👇
https://github.com/ahmedinshaf/Resources-for-Developers

Good idea mchn 👏
Regarding the image URL part, I was also thinking about that. I created a node.js app using Puppeteer that takes a screenshot of a webpage of a given URL, uploads it to Imgur and returns the image URL, but still couldn't deploy it.
I will let you know once it's done. probably will be able to complete it by tomorrow. Let's continue this task after that's done.
Cheers 🥂

That’s great !

I created json for every category that mentioned in article and added ✅ added to 👇
this repo

Thanks mchn. Good job you did there. I didn't expect that this fast 😃
Currently I'm facing a power failure here. I will let you know once power comes and img generator is deployed✌.

I created json for every category that mentioned in article and added ✅ added to 👇
this repo

Thanks mchn. Good job you did there. I didn't expect that this fast 😃
Currently I'm facing a power failure here. I will let you know once power comes and img generator is deployed✌.

I deployed the img ss generator. You can access it at https://devbies-backend.herokuapp.com/api/getUrlData.
pass the URL as the url query parameter and you will get a JSON response.
Example request:
https://devbies-backend.herokuapp.com/api/getUrlData?url=https://devbies.ml
Example response:
{ "img": "https://i.imgur.com/mFzlJf3.png", "url": "https://devbies.ml" }
I hope this will help you to generate image URLs for the resources. 😃

Sounds good, Using this SS generator I can work on creating json for each category 👍🏼. And also this  SS generator🤩 will be helpful in future as well .


Feature Request:  Insert only reference without bracket

Feature Requested
Would be great to have a shortcut to add only reference wirthout bracket
For example I want to have complex citation [@authorx2022, @authory2022], currently I need to manually remove additional brackets when trying to insert the reference into existeing brackets [[@authorx2022] @authory2022]
Relevant Screenshot
No response
Checklist

[X] The feature would be useful to more users than just me.

Good suggestion. Added in the latest release, triggered via ⌘⇧ + ↵. For the specifics, see the updated docs on citation actions.
(You will to update to the latest release by manually downloading it at GitHub, since I had to remove the auto-update mechanism for the upcoming Alfred Gallery. Auto-updating will be available again via Alfred in 1-2 days when the workflow is published in the Gallery.)

thanks!


Fixed visual display pages

Description of Work
Fixes #64
Visual display pages now work and display some basic figures.
Testing Instructions

Run example_runScripts.py in mantidpython.
Go to the neutron tables, open them and then click on the links.

neutron tables are located at "/fitbenchmarking/fitbenchmarking/results/neutron/Tables"

please fix merge conflicts

changes requested were addresssed


Fully Available

Hi, is this available under the 'education subscription'? it would be a massive benefit to our universities

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 18f3a2c9-0399-218d-cf9a-eb0f16fcbbb0
Version Independent ID: da6ada6e-ce41-f772-74b8-144cf540d423
Content: Multi-Geo Capabilities in OneDrive and SharePoint Online in Office 365
Content Source: Enterprise/multi-geo-capabilities-in-onedrive-and-sharepoint-online-in-office-365.md
Service: o365-solutions
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum

Hi Wayne, thanks for reaching out. We're currently making Multi-Geo available to customers with >5K Office 365 seats in the commercial space. We want to make sure that these customers are on boarded efficiently and have the best service experience, therefore we’re starting with stipulations to manage and scale the service in a controlled way. However, I am super interested in learning universities' global data residency needs and how Multi-Geo can help. It would be great if you can share scenarios here. Thanks!

Hi, thanks for replying back and I would be very interested if we were able to contact direct on this off this thread I would be very grateful, we are currently at 10k mailboxes globally for our universities. If you were able provide me contact details to continue offline that would be great, thank you  :-)

Happy to listen to your requirements. Please add me on LinkedIn and send an inmail. https://www.linkedin.com/in/samsearth/


🐛 Bug Report: Docker image not pulled

👟 Reproduction steps
When i run docker compose. i get error stating "pull access denied for appwrite/appwrite-lite"
👍 Expected behavior
It pull docker container and starts it.
👎 Actual Behavior
Error is displayed stating "pull access denied for appwrite/appwrite-lite"
🎲 Appwrite version
Version 0.10.x
💻 Operating system
Linux
🧱 Your Environment
No response
👀 Have you spent some time to check if this issue has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Is this no longer being developed?

Is this no longer being developed?

We are not actively working on this at the moment.


[i18n] Unlocalized 'not authorized' message when user has not rights to publish files

Expected Behaviour
'not authorized' and 'Error migrating legacy config: error loading sidekick config: Unexpected end of JSON input' strings are localized when user activated 'config' file
Actual Behaviour
Strings are unlocalized. Not found in GLaaS
Reproduce Scenario (including but not limited to)
Steps to Reproduce

Install extension
Add project to extension
Create '.helix' folder in project
In '.helix' folder create 'config' spreadsheet with 'key' and 'value' columns
Type 'admin.role.publish' in 'key' column, type different email in 'value' column
Activate 'config' file
Activate 'config' file again

Steps for 'Error migration legacy config' error were not found.
Platform and Version
Chrome 131.0.6778.86
Sidekick v7.1.2
Strings:
not authorized
Error migrating legacy config: error loading sidekick config: Unexpected end of JSON input

Depends on upcoming server error catalog.


Small rewording

How about this? I made the links to the blog and twitter more explicit, and added that the wikipedia page open in a new tab. I also merged it back into one paragraph, because I think it looks better, but let me know your thoughts!

Thanks for doing this, but all I see in the "files changed" tab is a one line white-space removal. Need a rebase of some sort?

yeah that's weird, let me check it out.

ha, you mean I'm supposed to commit things to branches? :P Take a look now, hopefully that fixes it!


golint fixed for routers

Current coverage is 3.03% (diff: 100%)

Merging #208 into master will not change coverage

@@            master      #208   diff @@
========================================
  Files           33        33
  Lines         8106      8106
  Methods          0         0
  Messages         0         0
  Branches         0         0
========================================
  Hits           246       246
  Misses        7840      7840
  Partials        20        20

Powered by Codecov. Last update b2cce12...68b581b

LGTM

LGTM not working ?

LGTM

resolved #70


Create issue_template.md

connect #173

:tada: This PR is included in version 4.2.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[BN] Collections Lesson

#968 first stab! I have also copied over the files under the basics category with (TODO) appended with the title of the yet-to-be-translated lessons.

I think your font / keyboard messed up some parts. I think this commit can be merged. I will clean those up after it's merged.

Thanks man. Vim doesn't support Bangla well :( So if you're cool with the merge we can always fix those little typoes afterwards.

I'm cool with it. Thanks for the excellent work! :+1:
On Fri, Feb 17, 2017 at 12:45 PM, Code Shoily<EMAIL_ADDRESS>wrote:

Thanks man. Vim doesn't support Bangla well :( So if you're cool with the
merge we can always fix those little typoes afterwards.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/doomspork/elixir-school/pull/969#issuecomment-280568298,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALsN0BwD8-rqqYVT62QC3Of4omXfzHDks5rdUIggaJpZM4MD2cf
.

--
Abu Ashraf Masnun | +8801711960803 | http://masnun.me

Let's keep those. Helps in translation.
On Fri, Feb 17, 2017 at 9:54 PM, Prio<EMAIL_ADDRESS>wrote:

@prio101 commented on this pull request.
I think we have some files which are not translated yet . It would be
great if you @mafinar https://github.com/mafinar remove these files
first :)
Otherwise , @masnun https://github.com/masnun made a great deal of
review and your work just great @mafinar https://github.com/mafinar ...
Thanks .... to you all
In bn/lessons/basics/comprehensions.md
https://github.com/doomspork/elixir-school/pull/969#discussion_r101784753
:

@@ -0,0 +1,114 @@
+---
+layout: page

Why we do have these files ??? we can only serve files that are translated
right ???
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/doomspork/elixir-school/pull/969#pullrequestreview-22525831,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALsN8c2iB9o1x6xdA07E6dt32K8PaRQks5rdcKygaJpZM4MD2cf
.

--
Abu Ashraf Masnun | +8801711960803 | http://masnun.me

Okay... @masnun .... then I am going to work on the Enum chapter .

Great. Thanks.
On Fri, Feb 17, 2017 at 10:20 PM, Prio<EMAIL_ADDRESS>wrote:

@prio101 approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/doomspork/elixir-school/pull/969#pullrequestreview-22532672,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALsN8I5S70miDsvPq65jysw6WFiEie5ks5rdcjUgaJpZM4MD2cf
.

--
Abu Ashraf Masnun | +8801711960803 | http://masnun.me

Thank you @code-shoily / @masnun / @prio101!


Revised validating process of a bounding box in ImageDetIter

Description
The previous ImageDetIter validated a bounding box with two points only (left-top and right-bottom points). Many other datasets provides a bounding box label with four points (left-top, left-bottom, right-top, right-bottom).
The new validating process of the bounding box in the ImageDetIter looks at the number of points given and validate appropriately.
 I finished coding on this PR)
[x] All changes have test coverage
[x] For user-facing API changes, API doc string has been updated.
[x] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@zhreshold Please have a look

@mun94 If you are referring to non-standard rectangles, it requires much more than this fix

It's validating polygons (not necessarily a rectangle) by looking at the four points. How would you suggest fixing it more?

Hi, the community has passed to vote about associating the code changes with JIRA<EMAIL_ADDRESS>We have updated the guidelines for contributors in https://cwiki.apache.org/confluence/display/MXNET/Development+Process, please ensure that you have created a JIRA at https://issues.apache.org/jira/projects/MXNET/issues/ to describe your work in this pull request and include the JIRA title in your PR as [MXNET-xxxx] your title where MXNET-xxxx is the JIRA id
Thanks!

@munkim Do you have any update on this?

Closing this for now. Let me know to reopen it if you got new ideas.


fix: adjust startup, liveness and readiness probes settings

Description
Startup probe settings seem to have been added in the upstream Backstage Chart
in [1], but the current settings do not allow the RHDH Chart for the
liveness probe to be triggered sufficiently enough for the app to be
considered live.
This adjusts such settings by accounting for the worst-case scenario
where the application might take a bit long to start.
This also aligns the probe endpoints with the Helm chart.
[1] https://github.com/backstage/charts/pull/216
Which issue(s) does this PR fix or relate to

Relates to issues.redhat.com/browse/RHIDP-5106
Relates to issues.redhat.com/browse/RHIDP-4968

PR acceptance criteria

[ ] Tests
[ ] Documentation
[x] If the bundle manifests have been updated, make sure to review the rhdh-operator.clusterserviceversion.yaml file accordingly

How to test changes / Special notes to the reviewer

/cherry-pick release-1.4

/uncc @coreydaley
/cc @nickboldt @PatAKnight @gustavolira


Can't access structure.stl file

I see error 404 when trying to download structure.stl file from readme tutorial (https://github.com/Danfoa/invite-robotics/wiki/Tutorial---Simulation-Scene-Objects):
structure.stl file is not available at this URL:
https://github.com/Danfoa/invite-robotics/blob/developmental/invite_motoman_moveit_config/scenes/STL/structure.stl
Could please update it? Thanks!

@sourabhacharya Just updated the link.
In the following weeks, this tutorial will be complemented with more useful information.


HOSTEDCP-1364, kubevirt: Use selector less services for ingress

What this PR does / why we need it:
The KubeVirt provider default ingress uses a passthrow service to
connect to the hosted cluster ingress using it's ingress service
nodeport, this works fine with pod network but when using secondary
networks custom endpoints has to be created and maintained. This change
remove the selector from the service and maintain the endpoints at a
reconcile cycle at nodepool controller, this is done for unconditionally
to pod network attachment configuration.
Depends on:

https://github.com/openshift/release/pull/47850

Which issue(s) this PR fixes
Fixes #HOSTEDCP-1364
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/retest e2e-kubevirt-aws-ovn

External cluster is failing
{"level":"error","ts":"2024-01-12T15:33:00Z","msg":"Reconciler error","controller":"machine","object":{"name":"example-s46dw-g6f9r-ts8bj","namespace":"e2e-clusters-7nvr5-example-s46dw"},"namespace":"e2e-clusters-7nvr5-example-s46dw","name":"example-s46dw-g6f9r-ts8bj","reconcileID":"5886a906-71ec-441a-8831-db3f36c58409","error":"failed reconciling kubevirt default ingress passthrough service endpoitns: failed to get default ingress passthrow Service: unable to get: guest-external-infra-ns/default-ingress-passthrough-service-mbbgzhbv8t because of unknown namespace for the cache","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227"}

After using the correct client for external infra now is failing on RBAC
{"level":"error","ts":"2024-01-15T09:16:23Z","msg":"Reconciler error","controller":"machine","object":{"name":"example-7v9bm-xnlnl-blqc2","namespace":"e2e-clusters-tbrf2-example-7v9bm"},"namespace":"e2e-clusters-tbrf2-example-7v9bm","name":"example-7v9bm-xnlnl-blqc2","reconcileID":"c2e6966e-ca3f-4e35-9256-30f7e05b8046","error":"failed reconciling kubevirt default ingress passthrough service endpoitns: failed to reconcile kubevirt default ingress endpoints: endpoints \"default-ingress-passthrough-service-cl6tk7lnlq\" is forbidden: User \"system:serviceaccount:guest-external-infra-ns:kv-external-infra-sa\" cannot get resource \"endpoints\" in API group \"\" in the namespace \"guest-external-infra-ns\"","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227"}

/pj-retest e2e-kubevirt-aws-ovn

/test e2e-kubevirt-aws-ovn

ovn-kubernetes team say that we need to create endpointslices instead of endpoints but that openshift ingress was failing on missing endpoints if we just create endpointslices, I will test it again.

Something is bad with the owners now
{"level":"error","ts":"2024-01-19T15:13:58Z","msg":"Reconciler error","controller":"machine","object":{"name":"foo-6qll4-g7rfk","namespace":"clusters-foo"},"namespace":"clusters-foo","name":"foo-6qll4-g7rfk","reconcileID":"af20abb3-3a1e-436b-ab67-24c61692ae64","error":"failed reconciling kubevirt default ingress passthrough service endpoints: failed to reconcile kubevirt default ingress IPv4 endpoints: endpointslices.discovery.k8s.io \"default-ingress-passthrough-service-tqnwj679pb-foo-6qll4-g7rfk-ipv4\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227"}

/hold
Depends on ci/prow/e2e-kubevirt-aws-ovn status

Looks like we have the "finalizers" issue with virtualmachines too
{"level":"error","ts":"2024-01-23T12:37:08Z","msg":"Reconciler error","controller":"machine","object":{"name":"live-migrate-jb6dl-9h262","namespace":"clusters-live-migrate"},"namespace":"clusters-live-migrate","name":"live-migrate-jb6dl-9h262","reconcileID":"52f8f452-5b80-422e-8f4c-e958c019fc07","error":"failed reconciling kubevirt default ingress passthrough service endpoints: failed to reconcile kubevirt default ingress IPv4 endpoints: endpointslices.discovery.k8s.io \"default-ingress-passthrough-service-khg2dqn2vq-live-migrate-jb6dl-9h262-ipv4\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/hypershift/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:227"}

/retest
Pod crashing issue not related

Failing at
TestNodePool/Main/TestNodepoolMachineconfigGetsRolledout/EnsureNoCrashingPods

Looks like is not related.

/retest

Local e2e is green but external e2e is failing on
=== NAME  TestAutoscaling/ValidateHostedCluster
    util.go:340:
        failed waiting for hostedcluster image rollout: status.version.history[0].state is "Partial", but we want "Completed"
        Unexpected error:
            <wait.errInterrupted>:
            timed out waiting for the condition
            {
                cause: <*errors.errorString | 0xc000640110>{
                    s: "timed out waiting for the condition",
                },
            }
        occurred

/retest
e2e local and external are green, it failed gatherling logs
ERRO[2024-01-29T19:28:30Z] Some steps failed:
ERRO[2024-01-29T19:28:30Z]
  * could not run steps: step e2e-kubevirt-aws-ovn failed: "e2e-kubevirt-aws-ovn" post steps failed: failed to create or restart e2e-kubevirt-aws-ovn-gather-audit-logs pod: unable to create pod: Internal error occurred: admission plugin "LimitRanger" failed to complete mutation in 13s
INFO[2024-01-29T19:28:30Z] Reporting job state 'failed' with reason 'executing_graph:step_failed:utilizing_lease:executing_test:executing_multi_stage_test'

Looks like this breaks non kubevirt clusters
--- FAIL: TestUpgradeControlPlane/Main/EnsureNoCrashingPods (0.08s)

/retest

/retest

/jira refresh

/hold cancel

/retest

/test e2e-kubevirt-aws-ovn


Feature/route progress bar

This PR is pertaining to #933
Motivation for the new feature:
Route transitions are not smooth over the network because chunks generated by webpack take some time to load. It causes a terrible user experience especially for the ones having slow internet. So it would make sense to show some kind of progress bar or loader to the users while browser downloads the chunk and renders it.
Changes in the project

Created a new ProgressBar component. Added tests for the same. (Might need some help with the test coverage)
Created a new Higher order component withProgressBar. Wrote tests.
Converted React component in App/index from stateless function to es6 class. Added tests.
Please note that a higher order component (HoC) withRouter (from react-router) is used in App/index to access newer API of react-router.

How it works
The ProgressBar percentage depends on listen hook of react-router and React's component life cycle methods.

Initially, the percentage is -1.
Progress is set to 0 when the location changes and it keeps on increasing until the new route is mounted or it reaches 99 (whichever is faster).
Percentage is set to 100 when the new route mounts.
Percentage is reset to -1 and ProgressBar is ready for a new route change.

Coverage decreased (-5.2%) to 93.75% when pulling 5e8a6c6198c0187249eb24bc34db1c76f1271b40 on KarandikarMihir:feature/route-progress-bar into 0f88f55ed905f8432c3dd7b452d713df5fb76d8e on mxstbr:master.

This looks amazing! (deploy preview to see this live without cloning)
One thing I'm not a fan of (this is without a code review, will do that in due time) is how the progress bar animates back to 0 when the route change is finished. Instead of retracting back to the left, can it fade out or slide out to the top?
I think that's a nicer experience, just from a visual perspective!

@mxstbr You're right! It is a little annoying. I'll fix it. Just waiting for you to review the code, so that I can push everything at once.

I won't have time today or tomorrow to review the code in depth, so feel free to push the change! Also, @justingreenberg's comments are usually on-point 👌

Coverage decreased (-3.8%) to 95.111% when pulling 43acc74b1235d10a9fb518ef50dd93f922851a29 on KarandikarMihir:feature/route-progress-bar into 0f88f55ed905f8432c3dd7b452d713df5fb76d8e on mxstbr:master.

Coverage decreased (-1.6%) to 97.38% when pulling c04ad63077a31cf53657f8603157efab4455c975 on KarandikarMihir:feature/route-progress-bar into 0f88f55ed905f8432c3dd7b452d713df5fb76d8e on mxstbr:master.

I patched my own app with this pull request and it seems like working. I also updated my beta/soon-to-be-production website using your awesome boilerplate. check it out since it's big enough to test this progress bar:
http://thirdeye-render.com/

@sourcesoft That's great! Thanks for giving a live preview! However, I did find some quirks on mobile. Sometimes, I saw progress bar running twice after page load :confused: Can you confirm the same, please?
@mxstbr Did you get any chance to see the code? Just checking in! I'm concerned about that quirk. If you could also reproduce it, maybe you could find the reason?

Should/could this be provided through an external library rather than within RBP's codebase?

@sedubois Yes! I had thought of it before submitting this PR. Creating another library will create a dependency. That library will have to be maintained by someone. And like most cases, that repo will be abandoned.
If we keep `ProgressBar

@sedubois I had thought of it before submitting this PR. Creating another library will create a dependency. That library will have to be maintained by someone. And like most cases, it will be abandoned.
If we keep ProgressBar inside RBP, we will have two advantages-

People will maintain and improve the component.
Users who do not wish to use it can easily get rid of it by simply deleting the folder from components directory.

That's understandable, but according to that logic, then we could end up with this repository engulfing the entire universe ;-) It's just a matter of scope I guess.
There could also be the opposite argument that, by making it a lib, you allow other projects to reference it, and therefore it gains visibility.

@KarandikarMihir After disabling cache and choosing a really slow throttling in network tab of chrome dev-tools, it seems that if it takes long, this happens once before transition starts and once again after transition ends and new chunks are loaded, but if the connection isn't like unreliable mobile you can't see it happen twice.

@sedubois Hahah! :smile:  We'll leave it up to @mxstbr to decide. Let's see what he has got to say about that. Of course, you can go ahead and make a lib out of this! I, for one, know that I won't maintain a repo of my own. I have a very short attention-span :sweat_smile:
@sourcesoft Thanks for confirming :+1:  It's strange! I'll look into it.

Coverage decreased (-1.6%) to 97.38% when pulling 1871fc905d66639f8fbba3084270b9d6df9af733 on KarandikarMihir:feature/route-progress-bar into 8693af3708e31f25fc0883256da605b3ccc03c9a on mxstbr:master.

Should/could this be provided through an external library rather than within RBP's codebase?

This is just in the example app, and will be removed after npm run clean.
It shows how to add a progress bar when loading a new route, something that every app with large pages/lots of content will do – otherwise users navigate to a new route, and nothing happens at all until the new route is loaded, which is horrible UX. We shouldn't be promoting that 😊

Coverage decreased (-1.6%) to 97.38% when pulling 5c983fa088e81480fc291cde3692eabcceb625ea on KarandikarMihir:feature/route-progress-bar into de78b9fb1499d647c8b5d838dc29270d21f60bfd on mxstbr:dev.

@KarandikarMihir this is super neat! It's funny how something this subtle really makes a difference Like @sourcesoft , I also patched this PR to my WIP project.

Coverage decreased (-1.6%) to 97.38% when pulling 55d6a0b05ae31f63792d3baf37ec622712f42a99 on KarandikarMihir:feature/route-progress-bar into 68eef925e9c1a6593c6aead84e128f1cc8182fe6 on mxstbr:dev.

@GGAlanSmithee Thanks so much! I'd love to see it in action :)

Coverage decreased (-1.6%) to 97.38% when pulling dc84174a06d33d35d2ab98ec77f0c4c02f76be3d on KarandikarMihir:feature/route-progress-bar into a78ef5f312506740315d1cc7df98a62894708eff on mxstbr:dev.

Coverage decreased (-1.6%) to 97.38% when pulling ff229744c8a57bbd4cd9ed360703b41a60258a6f on KarandikarMihir:feature/route-progress-bar into 8f6808150717dd3ad7092bd231327fd10e8ea282 on mxstbr:dev.

Coverage decreased (-1.6%) to 97.38% when pulling 4ad3ed0672850d8c25dac75022377edef1e6a9bf on KarandikarMihir:feature/route-progress-bar into 18952bfdcc8ee32778934906ece1799b1daf3987 on mxstbr:dev.

Coverage decreased (-1.6%) to 97.38% when pulling 4ad3ed0672850d8c25dac75022377edef1e6a9bf on KarandikarMihir:feature/route-progress-bar into 18952bfdcc8ee32778934906ece1799b1daf3987 on mxstbr:dev.

Coverage decreased (-1.6%) to 97.38% when pulling 98e9abf8178e98621e68244d4c95ccf929ccd265 on KarandikarMihir:feature/route-progress-bar into 18952bfdcc8ee32778934906ece1799b1daf3987 on mxstbr:dev.

Coverage decreased (-1.6%) to 97.391% when pulling 5ea221498609a180853a0f4e4539a32219dc204c on KarandikarMihir:feature/route-progress-bar into 1d18cc7d1a6fff18ca083a57dd1797bf13cc64ef on mxstbr:dev.

Coverage decreased (-1.6%) to 97.391% when pulling d7a40155f48762cf96dcbe66a49f3beaf7f0ba90 on KarandikarMihir:feature/route-progress-bar into d4e0052f101aca14e4f89b3e474edeab056e25fb on mxstbr:dev.

Coverage decreased (-1.6%) to 97.391% when pulling b6578d45666ba030aeadf00026342a407fe0bdd7 on KarandikarMihir:feature/route-progress-bar into 3a92bd97bb025b22f498c011cbd88d7f4993071d on mxstbr:dev.

Sorry, can you rebase this on top of dev with styled-components and fix all conflicts? Then we can finally land this! 🎉

Sorry for letting this hang for so long 😊

@mxstbr Sure thing!

Coverage decreased (-1.3%) to 97.287% when pulling e59a74e31007b54595c8d023a91d3369ec8c0d62 on KarandikarMihir:feature/route-progress-bar into 33485f41053caa6e90b9cbede8b51c168b38bda4 on mxstbr:dev.

@mxstbr If you see the test results, there are 4 lines in App/index.js untested. This is because I couldn't test <App /> separately, there seems to be some problem with react-intl. I need a little help with that... otherwise, I think we're good.

To my mind it transitions too quickly. When I test it with slow connection, it always transitions much much faster than the page changes and we still have this effect: progress bar animation has finished and already disappeared, but still nothing happened with with the page itself. Why don't we make if work like youtube's one? If transitions to about 60%, then stops and finishes after the new page has rendered. This is much more intuitive. What do you think?

@web2style You're right. I'm working on it. Please let me know if you have any ideas to improve the experience.

@web2style Yes. I'm working on it.

Coverage decreased (-1.3%) to 97.287% when pulling 5ec063d929c614913b6a5172a5bfe19c91e7689d on KarandikarMihir:feature/route-progress-bar into f0eb229b24a8db2ddf36cc03667fd0efad87de4c on mxstbr:dev.

@web2style Hi. Thanks for pointing that out. I've made some subtle changes that handles the progress bar better. If I'm not mistaken, 'componentDidUpdate()andcomponentWillReceiveProps()are the only two methods where we can callsetState()`.
You won't see the exact same thing like YouTube/Github.  We had a discussion on this. I didn't find any way to calculate loading time of javascript chunk.
The whole thing relies on listen() method of react-router to know that the route has changed. And when the new child mounts in <App />, it should complete the progress. If you can think of some better hook, I'll be more than happy to see it working! After all, it's a small part of example app. Actual users of this boilerplate can use it better with a little help from their back end.

Coverage decreased (-1.3%) to 97.287% when pulling f2ea416adea0c9df5ecb07ea0b7dee9f341efe5a on KarandikarMihir:feature/route-progress-bar into f0eb229b24a8db2ddf36cc03667fd0efad87de4c on mxstbr:dev.

Coverage decreased (-1.3%) to 97.287% when pulling 9a37563935e4d4079f61da16e9e4fa82e91d9a25 on KarandikarMihir:feature/route-progress-bar into f0eb229b24a8db2ddf36cc03667fd0efad87de4c on mxstbr:dev.

Coverage decreased (-1.3%) to 97.287% when pulling 425ab8863007e3201ca4ba22d941eb3d31ac20ec on KarandikarMihir:feature/route-progress-bar into b796a3aada6bd1632c357e5a9a6d96f1e51252ff on mxstbr:dev.

Can we finally land this? Please review one last time @Dattaya @gihrig I'd love to finally finally merge this!

Coverage decreased (-1.3%) to 97.244% when pulling 8f47b4569ffd856e2940324b02cdf674b96a9ad9 on KarandikarMihir:feature/route-progress-bar into 7efa929b5e64b2db67992658f5187fcbeeee588e on mxstbr:dev.

@Dattaya I'm glad that you look at it as a candidate. +1 for the last point. We shouldn't show progress for previously loaded routes. Thanks for taking time out for this. With all the flaws fixed, this could be a nice feature of rbp.

Coverage decreased (-1.3%) to 97.244% when pulling 2bb5e4cff77a8b1810e1926ab849c9ea7fe6b455 on KarandikarMihir:feature/route-progress-bar into fef5eb3a8b3b106b04f0209ce4d4848093504dbc on mxstbr:dev.

Where does 1.3% decrease in coverage come from? Now that I see it, that would be good to get up to 99% again!

@mxstbr It comes from here. I was just wondering how did you approved changes without saying anything about coverage :sweat_smile: I'll need a little help with this...

Once the app is loaded, transitions between routes look really nice :sparkles:
But... I'm seeing issues in local environment, production build:
OS X: 10.11.6
Chrome: 55.0.2883.87 (64-bit)
Safari: 10.0.1 (116<IP_ADDRESS>.7)
Firefox: 49.0
No connection throttling.
When the app is loaded (first load or CMD-R):

The progress bar appears and completes in ~.25 sec.
Fades out
Reappears and progress to about 95% in ~9 sec.
Stalls there, never clears.

On a route change (Features) operation becomes normal.

Merge branch 'dev' into feature/route-progress-bar

Brings import order in line with #1275.

As for help with coverage, do you know about the lcov-report that is produced on build? After 'npm run build' see:
/coverage/lcov-report/index.html
from here you can drill down to points of interest, e.g.
/coverage/lcov-report/app/components/ProgressBar/index.js.html
I think the < 100% branch coverage is here:

If I'm interpreting that report correctly.

Oh Bother! I broke your build with that merge :sad:

This is also the result of #1275 (higher code quality standards :wink:)
Let me see if I can fix that...

@gihrig @mxstbr I'll get back to this once I get a chance to be on my laptop. 😓

I would like to see this fixed before merging, but if others disagree, I won't hold it up.

Yeah that should definitely be fixed!

@mxstbr Roger that

This will take some time. I'm on time-out for personal reasons.

I hope everything is alright, looking forward to seeing you back around!

@mxstbr I'll be back in a few days. Can't wait to fix this!

I am eagerly waiting for this. When it will be released.

@ItsMrAkhil Working on it! Sorry for the delay!

@gihrig Thanks for the in-depth analysis. I don't really want this merged unless it is completely acceptable to all reviewers.
I've refined the behavior at the cost of keeping more boilerplate code in <App />. But I think, it does show a creative way of using withRouter to RBP adopters. Can you reconfirm that it indeed behaves the way we want?
Testing part is still impaired. I'll update tests when I find some time.

@KarandikarMihir It's great to here from you. Our team actually working on a application that is actually going to hit production in 15 days. And it's a wonderful boiler-plate that one can use.

Well, I guess it's perfect 😄
Works great at various throttling settings ✨
The only "issue" is that in an offline-first app, a loading indicator is largely irrelevant 😢

It can't show on the initial page load because there is no page to show it on...
Shows well on first page load made through an internal route change e.g. button click.
Does not show on subsequent page (re)load on route change. There's no need as nothing is loaded from the server. It's all internal from service worker/cache (offline-first) and pretty much instant.

But still, it's a nice addition. Get that test coverage up and I'll gladly approve :tada:

Coverage increased (+0.3%) to 98.872% when pulling 109d8cac8b8f7580df5d6b1c2df28c9b285792cb on KarandikarMihir:feature/route-progress-bar into cf65bc9098e0c2f6054e4fc862d9bba850ecd1ff on mxstbr:dev.

whew. The latest commit has some major changes.

I brought down <App /> back to a simple stateless function.
Updated tests of <App />.
Removed withRouter that comes with react-router.
Created a new HoC called withProgressBar.
Improved logic to prevent re-rendering of progress.
Wrote new tests for withProgressBar.

Things <ProgressBar /> cannot handle:

Offline mode
Progress before boilerplate loads in the DOM.

ONE MINOR (MAJOR?) WORKAROUND
I could not test router.listenBefore. If someone could help me with this, I'd appreciate it very much.

This is the original test coverage-

So I had cheat (/* istanbul ignore next */. ) to make the build pass.

Wouldn't it be more convenient if withProgressBar HOC renders ProgressBar component, so you don't need to put it in the markup?

It seems great. How can start using this now?

You can patch this into your boilerplate or manually copy progress bar related files.

Thank will you please let me know what are those files.

@smashercosmo I missed that. Thank you! 😊 @ItsMrAkhil  you can patch this branch or manually copy files in your code base.

Coverage increased (+0.3%) to 98.872% when pulling be6ef919ae8cef6694e0c976366fa6e5ccbfc8be on KarandikarMihir:feature/route-progress-bar into cf65bc9098e0c2f6054e4fc862d9bba850ecd1ff on mxstbr:dev.

Coverage increased (+0.3%) to 98.872% when pulling 6aa81823737807f62232e0a085fd9125a1fbad9c on KarandikarMihir:feature/route-progress-bar into cf65bc9098e0c2f6054e4fc862d9bba850ecd1ff on mxstbr:dev.

@smashercosmo Done.
@web2style I think this fixes the issue you had raised.

When I test it with slow connection, it always transitions much much faster than the page changes

It was actually a problem of re-rendering. That's why it was transitioning way too faster than it should and it was transitioning twice.. I'd like to hear from you, see if the latest changes are up to the mark.
And I take my words back!

You won't see the exact same thing like YouTube/Github.

I think this progress bar pretty much emulates their progress bar.

@KarandikarMihir It looks much better now. Thank you!
BUT. I tested the app with throttling and noticed a very unpleasant moment. When we open the app with slow connection, we just see white screen. For a very long time. I'm quite sure most users will just close the window thinking the app doesn't work.
Maybe we add a preloader? What do you think? I could make a PR.

@web2style Thanks for confirming!

When we open the app with slow connection, we just see white screen.

Yes. That still remains a problem.

Things <ProgressBar /> cannot handle:
Offline mode
Progress before boilerplate loads in the DOM.

It's up to @mxstbr and collaborators to decide if we want a preloader. :wink: I think it'll be a nice feature.

Maybe we add a preloader? What do you think?

Let's make that a separate PR so we can finally land and ship this amazing improvement?
This looks great to me! What do you think @gihrig?

@gihrig :smile: Yo!
I'll make those changes right away.

have docs briefly describing use of ProgressBar component and Remove instructions.

I should write those instructions in remove.md?

integrated into components/ProgressBar.

I'm not sure what you mean by "integrated". Do you want me to just move withRouter.js and withRouter.test.js in components/ProgressBar?
I'll just push new changes. If they're acceptable, :shipit:

Coverage increased (+0.3%) to 98.872% when pulling fce2e117d371c00dc2a4b7906ccd5e500bec97f3 on KarandikarMihir:feature/route-progress-bar into cf65bc9098e0c2f6054e4fc862d9bba850ecd1ff on mxstbr:dev.

I'm not sure what you mean by "integrated". Do you want me to just move withRouter.js and withRouter.test.js in components/ProgressBar?

That's right (if practical).
As it stands, components/ProgressBar requires considerable modification to the target component. containers/App/withProgressBar.js represents what feels to me like excessive coupling between components/ProgressBar and containers/App.
IMO, the ideal would be in containers/App to simply import components/ProgressBar and wrap the App jsx in a <ProgressBar>... element. or as you are doing now using the withProgressBar HOC.

Move withProgressBar to components/ProgressBar

Really nice 🎉

But, it will be removed automatically after npm run clean, right?

While that's true, the example app does provide many reusable components that (hopefully) represent best practices. I'm pretty sure that all your hard work on this will live on in many apps created with RBP. I know I'll use it in mine. 😃

Oh, I pushed new changes without reading your comments :|

I know I'll use it in mine.

I'm so happy to know that!! :smile:
The last thing to do is describe how <ProgressBar /> works :) Should take a few minutes.

Coverage increased (+0.3%) to 98.872% when pulling 9bfc438db4dfbbb80b17aaf7861915a6f913936e on KarandikarMihir:feature/route-progress-bar into cf65bc9098e0c2f6054e4fc862d9bba850ecd1ff on mxstbr:dev.

@gihrig Done! :godmode: :sparkles:

Coverage increased (+0.3%) to 98.872% when pulling 9fede98416649bdf963aaf0abf4010817f57b69e on KarandikarMihir:feature/route-progress-bar into cf65bc9098e0c2f6054e4fc862d9bba850ecd1ff on mxstbr:dev.

Hi. If I add withProgressBar(connect(mapStateToProps, mapDispatchToProps)(App)) inside my App -> index.js It is working like charm. But whenever I shifted the places of connect and withProgressBar the browser it getting crashed. I've tried in both Firefox, and Chrome browswers in Ubuntu 14.04

@ItsMrAkhil  Then don't shift the places :sweat_smile: I'd say wait for the final release, because the code can change at the last moment. By default <App /> is not a connect()ed component. But if you really want to connect it to the store, you'll have to do whatever that works, since your concern is not directly related to working of <ProgressBar />.

@KarandikarMihir 😂.. Of course. But I'm just informing. That's it.

@KarandikarMihir I have made minor edits to your doc, but I am unable to get them to you (in retrospect, this project probably should have occurred in mxstbr/branch not a PR).

I am not able edit your PR (GH edit returns a 404)
Attempted to fork your repo but GH does nothing (mine just another mxstbr branch)
Attempted to open a PR across forks, but GH says "nothing to compare"

Don't know if it can be done on an open PR, but GH has an "Allow edits from maintainers" checkbox at the bottom of the "Open a Pull Request" page. If you check that, I think I can edit your doc in the GH editor.
If that doesn't work you can see my changes here and edit from there.

Coverage increased (+0.3%) to 98.872% when pulling 92724ecfaff24e7ae52c47e247091ea4aa6a285f on KarandikarMihir:feature/route-progress-bar into cf65bc9098e0c2f6054e4fc862d9bba850ecd1ff on mxstbr:dev.

@gihrig I had never committed changes directly on GH. No idea why you couldn't make changes. Before opening this PR, I think I had enabled editing by collaborators.

@giautm can you create an issue and subsequently send a PR? If it's breaking UI, we should definitely remove extra dom nodes. Just make sure it works with your way before you do.

@KarandikarMihir I've found a bug in the ProgressBar. If we have an error in the console, for example invariant violation from React, and transition to another route, the ProgressBar never disappears, it hangs in the following state:

@yantakus As I know if something goes wrong with javascript, it will break (in the case of uncaught exception). From that point, it will never work until you refresh. I think this does not an issue with the progress bar. Correct me if I'm wrong.

@ItsMrAkhil It's weird, I can't reproduce the issue today with the same error in the console. Everything works as expected.


Custom JS Scripts

First off, this is incredible!  I love how you abstracted the details of making a game so that a non-developer can use it.  I've shared it with the people in my company (sales and all) in an attempt to help get them involved in code.
I don't distract from the "Scratch" component, but what would it take to add a "Custom Code" segment where an API call could be made?  I'm asking because, if it's a good idea and/or possible, I'd like to help.
I do Vue, Angular, Node and Go, and so I could be of assistance.

I'd very much love to be able to add my own "event" scripts -- maybe even full script access to GB Studio's built-in events, so that I can clone and tweak the behavior of certain scripts when needed.
This is maybe only partially-related, but as an example: One of my favorite game-development tools is Hutong Games' PlayMaker for Unity, a complete visual-scripting solution for state machines. Every single action provided by PlayMaker is a tiny C# script, so if you need an existing action to behave differently for whatever reason, you can just copy its script, make your changes to it, give it a new name, and then that action is available to use.
Because each of PlayMaker's actions are just C# scripts, an entire community has grown around PlayMaker for creating and distributing new Action packs, along with helping other users figure out solutions for how to combine certain actions to create larger events. I figure a similar approach would be greatly beneficial to GB Studio in the long run: Opening up script access would effectively help offset the workload required to create more events for users, allowing its developer to focus more on the program and the engine itself, and you can build a strong community around GB Studio in the process.

I believe this can be achieved by using c files with just 1 function in them.
void my_custom_script(void *state) {
   // my state changing function
}

The workflow could be the following

1 Include the files in a new folder named scripts
2 Each file would consist of myfunction.c, myfunction.h and myfunction.json (The c and h are needed for the compiler, the json is needed for the editor and will contain the definitions, params and other info).
3 In the editor select new script and pass the current state object.
4 If a file is named the same as one used in the core engine, use that file in the compiler instead of the default core one. (If somebody needs custom engine modifications).
5 Finally the editor will create a new scripts.h and scripts.c that will define and execute all the scripts.

I like this idea and I think the method that @clsource suggests could work quite well. I guess the problem is that the commands don't map cleanly to one function so take CameraMoveTo for example
This is the function that gets called when the event fires
void Script_CameraMoveTo_b()
{
  camera_dest.x = script_cmd_args[0] << 3;
  camera_dest.y = 0; // @wtf-but-needed
  camera_dest.y = script_cmd_args[1] << 3;
  camera_settings = (UBYTE)script_cmd_args[2] & ~CAMERA_LOCK_FLAG;
  camera_speed = (UBYTE)script_cmd_args[2] & CAMERA_SPEED_MASK;
  script_ptr += 1 + script_cmd_args_len;
  script_action_complete = FALSE;
}

Forget for a second the wtf comment, because the C compiler used is currently quite buggy and requires things like this from time to time (there's another issue about moving to a newer version of GBDK which hopefully will help). But the actual command is only setting the camera destination value, the actual work is done by  void SceneUpdateCamera_b() and then UBYTE SceneCameraAtDest_b() is called from UBYTE ScriptLastFnComplete() to determine when the event is finished and the next one can fire. Either we could provide a list of defined interactions that the commands could do or you'd probably end up having to overwrite a bunch of places in the engine to do anything useful.
The other option I'd considered is adding an "Eject Engine" button on the build screen that would add an engine folder to your project, if present  the app will use your local version over the inbuilt one allowing you to make any change you want to the code and providing a path for more advanced projects for those who want it. If you combine this with the json plugins definition that you suggested then you could add new events to the UI, then you need to code up the handlers for these in your custom engine. If you ever broke your custom engine you could just eject again causing it to replace the engine with the latest working version.

Yeah a engine selector could improve a lot in the current flow. You can have an engine tailored for RPG or platform, puzzle or visual novel or even demoscene like music games.
The engine just would consist c, asm files and supporting tools and a single json that will help the editor know wich events, actions, properties and other configurations are possible.
The idea is to standarize the engine directory and maybe have a single packages.json file that could trigger npm commands used in the editor. With this layout then anyone could fine tune the engine to their needs.
Maybe something similar to this
engines/
   default/
      tools/
          packages.json
          tool1.js
          build.js
       makefile
       code.c
       anothercode.h
       morecode.asm
       engine.json

    visualnovel/
       tools/
          packages.json
          tool1.js
          build.js
          index.js
       makefile
       code.c
       anothercode.h
       morecode.asm
       engine.json


Implemented Athena create_named_query, get_named_query (#1524)

Issue #1524

Coverage decreased (-0.05%) to 94.328% when pulling 24bc689176ff76a030737d2098cac5a2f724cf63 on ktrueda:ISSUE_1524 into b88f1660991ebd0118839a48948cab943913d317 on spulec:master.

This is now part of moto >= 1.3.15.dev892


Image recognition + visualization = issues

When turning TESTAR visualization on (green and red dots), the image recognition fails to find the action, at least the first action after turning the visualization on.
Not much we can do about that, unless we can take new pics of the buttons after turning on the visualization.

Check the status of the widget recognition protocols to determine if this issue persists and how to change the Spy painting order to remove the dots before taking the screenshot of the widget.

This was fixed in #395
To avoid TESTAR taking widgets screenshots containing green and red dots when the visualization is on, we clear the canvas just before taking the screenshot


Provide an example of how to use the ansible connection with sudo

I am unable to run the iptables functionality
def test_iptables_rules(host):
    rules = host.iptables.rules(table=u'filter', chain=u'INPUT')

How I invoke it
$ py.test-s --connection=ansible --ansible-inventory ./myhosts --hosts="agroup" mytest.py

In the same directory, I created ansible.cfg
Note that I don't have ssh keys configured on the target hosts & I want the program to prompt for passwords i.e. using ssh-pass ?
[privilege_escalation]
become_ask_pass=True

[defaults]
remote_user=donaldtrump
ask_pass=True

The exception. Note that I had to hack the code to add the full path /sbin/iptables as the original code could not find the binary.
ansible.py                  62 INFO     RUN Ansible(u'shell', u'/sbin/iptables -t filter -S INPUT', {}): {'_ansible_no_log': False,
 '_ansible_parsed': True,
 'attempts': 1,
 u'changed': True,
 u'cmd': u'/sbin/iptables -t filter -S INPUT',
 u'delta': u'0:00:00.134311',
 u'end': u'2018-01-27 01:36:59.495112',
 u'invocation': {u'module_args': {u'_raw_params': u'/sbin/iptables -t filter -S INPUT',
                                  u'_uses_shell': True,
                                  u'chdir': None,
                                  u'creates': None,
                                  u'executable': None,
                                  u'removes': None,
                                  u'stdin': None,
                                  u'warn': True}},
 u'msg': u'non-zero return code',
 u'rc': 3,
 u'start': u'2018-01-27 01:36:59.360801',
 u'stderr': u"iptables v1.4.7: can't initialize iptables table `filter': Permission denied (you must be root)\nPerhaps iptables or your kernel needs to be upgraded.",
 'stderr_lines': [u"iptables v1.4.7: can't initialize iptables table `filter': Permission denied (you must be root)",
                  u'Perhaps iptables or your kernel needs to be upgraded.'],
 u'stdout': u'',
 'stdout_lines': []}
base.py                    241 INFO     RUN CommandResult(command=u'/sbin/iptables -t filter -S INPUT', exit_status=3, stdout=u'', stderr=u"iptables v1.4.7: can't initialize iptables table `filter': Permission denied (you must be root)\nPerhaps iptables or your kernel needs to be upgraded.")

I am using ansible 2.5.0 (devel dcc05093db) last updated 2018/01/11 16:00:37 (GMT -700)
$ pip freeze
ansible==2.5.0
attrs==17.4.0
ecdsa==0.13
funcsigs==1.0.2
Jinja2==2.10
MarkupSafe==1.0
paramiko==1.17.1
pluggy==0.6.0
py==1.5.2
pycrypto==2.6.1
pytest==3.3.2
PyYAML==3.12
six==1.11.0
testinfra==1.10.1

Hi @erriapo,
I think this might help you :) https://testinfra.readthedocs.io/en/latest/modules.html#sudo

Given https://github.com/philpep/testinfra/issues/285#issuecomment-365219564, I think this can be closed.

hi
how to make a sudo with escalation privilege ?
``
sudo su - postgres


Streams - Quick start guide

I don't know why but I can't add any additional comments, Github always say's commented on a outdated diff... So I add them here...

 The materializer is picked up implicitly if it is omitted from the `run` method call arguments, which we will do in the following.
That's not possible for us, we always need to pass the materializer as parameter for run methods

BigInteger needs a reference to System.Numerics, so for simplicity I would preffer 1L

1: True. That was one thing that i still needed to remove.
2: A long goes negative pretty fast in this sample. In order to produce a proper output on par with the JVM example a BigInteger is needed.


Docs for PyTorch

Difficulty: ★☆☆☆☆
Blocked by: #31

Background
The documentation contains examples of each analysis type.
Problem
Only have keras models in the documentation.
Solution
Use the models from tests.py
Discussion
How to segment the docs? by library Keras (classify, binary), PyTorch (classify binary)? how many levels can the menu be?

Don't forget to share on pytorch google groups and discourse when done


Version Bump - TwilioConversationsClient 0.25.0

Once the Client and Common artifacts are promoted. 👍


Jimp.decoders is undefined in browser with webpack and typescript

Expected Behavior
I am expecting Jimp.decoders to be defined when running in a browser using webpack and typescript
Current Behavior
Jimp.decoders (and other fields) is undefined
Failure Information (for bugs)
An exception is thrown when trying to reference any field in Jimp.
Steps to Reproduce

Unzip the attached jimp.zip
jimp.zip
cd jimp
npm run debug
open browser to "http://localhost:4000".  View the browser console output (via inspect in Chrome) and you will see the log message with the value of "Jimp.decoders".

Screenshots
Context

Jimp Version: 0.22.10
Operating System: macOS Ventura 13.6.3
Node version: 16.20.2

Failure Logs

:rocket: Issue was released in v1.0.2 :rocket:


Tag a release!

@JuliaRegistrator register

@JuliaRegistrator register

Error while trying to register: "Branch master not found"

@JuliaRegistrator register branch = main

Registration pull request created: JuliaRegistries/General/23733
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 2f8cc3aaa17df228a669af8b37896227f8ffb9b5
git push origin v0.1.0

Let's try again (now that we've fixed a julia version)
@JuliaRegistrator register branch = main

Registration pull request updated: JuliaRegistries/General/23733
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.1.0 -m "<description of version>" 94a922cbdd4fa914d1ab60eaf8b57986cb9c5976
git push origin v0.1.0


Making HappyBase create_table() atomic.

In the process, adding a column families option to Table.create() in the low-level API.
Fixes #1524.
/cc @garye @tswast

LGTM


serviceEntry max cluster count capped at ~300

Bug Description
using istio v1.13+
I notice that if I create many similar SE (different names ,same url), the code will "choke" and refuse to create new SE after ~300 instances. (sometimes 250, sometime 350). Deleting the 300 SE will allow to create new ones.
for (counter=0 ; counter  < 400 ; counter++) {
create CRD:
apiVersion: networking.istio.io/v1beta1
kind: ServiceEntry
metadata:
  name: rule-${counter}
  namespace: myNS
spec:
  hosts:
  - api.a.c.com
  ports:
  - name: https-9341
    number: 9341
    protocol: HTTPS
  resolution: DNS

}

OK, I get it. there is some undocumented limit but here comes the bug:
not only you can’t create new SE , the port in question (this example is port 9341) will get blocked if using REGISTRY_ONLY egress policy. outgoing traffic is blocked until you free some old “9341” SE’s.
we need some clear error log in the istiod logs or somewhere...
I know that many of the istio users will not even get near that SE count.
and I changed the way I create SE to aggregate ports and check duplicates BEFORE creating new SE. but still ... a low prio bug.
maybe even just an istioctl analyze warning ?
Version
$ kubectl  version --short
Flag --short has been deprecated, and will be removed in the future. The --short output will become the default.
Client Version: v1.24.0
Kustomize Version: v4.5.4
Server Version: v1.21.14+IKS

$ istioctl version
client version: 1.13.3
control plane version: 1.13.5
data plane version: 1.13.5 (1391 proxies)

### Additional Information

_No response_

I didn't find any limit code about service entries.

the port in question (this example is port 9341) will get blocked
What's envoy' response error message? Can you provide some envoy's config and istiod's log?

yes, let me find the log line
Jul 29 11:23:11 istiod-66f99bfb55-9rq7v discovery info ads	Push Status: {
    "pilot_conflict_outbound_listener_tcp_over_current_tcp": {
        "<IP_ADDRESS>:9341": {
            "proxy": "pgbouncer-d7c9d88c6-njwzw.ibm-secretsmanager",
            "message": "Listener=<IP_ADDRESS>:9341 AcceptedTCP=api.a.b.com RejectedTCP=api.a.b.com TCPServices=1"
        }
    },
    "pilot_duplicate_envoy_clusters": {
        "outbound|9341||api.a.b.com": {
            "proxy": "lon04-public-custom-ingressgateway-f7b6c7bc7-shqrj.istio-system",
            "message": "Duplicate cluster outbound|9341||api.a.b.com found while pushing CDS"
        }
    }
}

 "pilot_duplicate_envoy_clusters": {
        "outbound|9341||api.a.b.com": {
            "proxy": "lon04-public-custom-ingressgateway-f7b6c7bc7-shqrj.istio-system",
            "message": "Duplicate cluster outbound|9341||api.a.b.com found while pushing CDS"
        }
    }

This means duplicate cluster didn't push  to envoy. It's normal.
There is a command pilot-agent request POST logging\?level=debug to enable debug envoy log to find out exactly what is happening.

istioctl pc all  lon04-public-custom-ingressgateway-f7b6c7bc7-shqrj.istio-system
And can you using istioctl to dump envoy config?

proxyConfigLon04.txt

proxyConfigLon04.txt

proxyConfigLon04.txt

proxyConfigLon04.txt

proxyConfigLon04.txt

wait... testing the loop


[FEATURE] Added StarisSpeed

you can run fast on the stairs bypass NCP Servers

bruh just use speed mode instant


Force<EMAIL_ADDRESS>

A possible solution to https://github.com/Qiskit/platypus/issues/280#issuecomment-1017133036

@abdonrd @Tansito , #301 has been merged (not sure if we want to continue with this PR). i am ok with closing this out unless you feel otherwise

@abdonrd @Tansito , #301 has been merged (not sure if we want to continue with this PR). i am ok with closing this out unless you feel otherwise

I'm ok too closing it 👍


VNET rule configuration section is missing from a "General Purpose" instance

I have a "General Purpose" server instance. At some point, VNET rule configuration section used to be visible under "Connection security", but it's now gone.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f8e785d4-cb1f-dc12-6702-48ffe1287734
Version Independent ID: f359048a-b2a7-9b42-c109-b5429ac5f24a
Content: Create and manage Azure Database for PostgreSQL VNet service endpoints and rules using the Azure portal
Content Source: articles/postgresql/howto-manage-vnet-using-portal.md
Service: postgresql-database
GitHub Login: @mbolz
Microsoft Alias: mbolz

@samisq Thanks for the feedback. We are actively investigating and will get back to you soon.

@kfile @samisq  The VNet Rules section shown here is missing. image

This is missing for me as well.  Same image as above.

@kfile @samisq @mappindrones This was a bug unfortunately and it has been fixed. Apologies.

@Alberto-Vega  : We are not getting this option in basic server setup. Although it is available in General Purpose.

@ngaba18 As is with Azure Database for PostgreSQL and other Azure services, VNET availability is also dependent upon the service tier of the service the VNET is being deployed. In the case of Azure Database for PostgreSQL, the limitations section details the following:

Support for VNet service endpoints is only for General Purpose and Memory Optimized servers.

Thank you for following up on this issue.


Detect unnecessary function return type declaration

The no-inferrable-types rule warns when variable or parameter declarations have a declared type that is directly inferable. A similar feature could be added for function return types.
For example, if a function doesn't return, its return type can be inferred as void and an explicit : void declaration in unnecessary.

needs some elaboration on how the control flow analysis would work, whether we would share code with no-unreachable, etc.

Probably need to implement this using the TypeChecker to ask it what the return type of the function is. If the return type is void, then you can check that the annotation is not present on the function declaration.

Implemented rule no-inferrable-return-types (github/npm).
It is my first tslint/typescript related project. I didn't found possibility to infer return type using TypeChecker, so I tricked getReturnTypeOfSignature. Simple typesAreEqual from https://github.com/ajafff/tslint-consistent-codestyle (@ajafff) is used.
What can be improved:

TS compiler already have checkTypeRelatedTo, isRelatedTo, isIdenticalTo internally
TS compiler has code inside getReturnTypeOfSignature, which infers return type

It would be much better if we had them exported.
However it seems like rule already works for my cases, tested with TypeScript 2.7.x.

Any update on this?

This looks like a duplicate (subset) of #758. Let's move discussion there.


Error for read new messages

Waiting for QR
Bot started
Checking for more messages
Traceback (most recent call last):
File "D:\Documentos\dash rodrigo\jrmenssageria\teste.py", line 14, in
for contact in driver.get_unread():
^^^^^^^^^^^^^^^^^^^
File "D:\Documentos\dash rodrigo\jrmenssageria\webwhatsapi_init_.py", line 424, in get_unread
raw_message_groups = self.wapi_functions.getUnreadMessages(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "D:\Documentos\dash rodrigo\jrmenssageria\webwhatsapi\wapi_js_wrapper.py", line 45, in getattr
wapi_functions = dir(self)
^^^^^^^^^
TypeError: 'NoneType' object is not iterable

How did you fix it? I have the same error

How did you fix it? I have the same error

Change webpackChunkbuild to webpackChunkwhatsapp_web_client in line 68 in webwhatsapi/js/wapi.js

Thanks for responding, I really appreciate it.
My python code fails before it runs webwhatsapi\js\wapi.js.
After the command
result = self.driver.execute_script(             "if (document.querySelector('*[data-icon=chat]') !== null) { return true } else { return false }"
result is False.
Any idea why? Could it be related to the fact that I'm not running it from a docker?
Thanks again!!!