cmake-configuration: remove hidden-attribute from 'build' and 'buildTarget'

Hiding build and buildTarget from the action-bar does not make sense:

starting a build with a single click is a regular task
changing the target also

Although the 'clean'-target currently seems to do nothing, I expect some improvements in the cmake-setup of the pico-SDK and then switching to the clean-target would be very useful.

IIRC we hide these buttons because there's a bug (?) in the VSCode CMake plugin which means that clicking them tries to do a native build of the code (e.g. x86_64-linux-gnu if working on a PC) rather than doing a arm-none-eabi build needed for the RP2040.

H'm the second commit should not have made it into the pull-request. I totally agree that this should be part of pico_sdk_import.cmake.
On my Pi4 installation the build button does not run a native build. I checked that yesterday after reading the getting-started guide. And section 6.2 actually recommends clicking the build-button.

I removed those buttons for a definite reason, but I cannot remember what that reason was. It's possible that the reason no longer exists because of other changes, and they can be reinstated, but would need to check.

I removed those buttons for a definite reason, but I cannot remember what that reason was. It's possible that the reason no longer exists because of other changes, and they can be reinstated, but would need to check.

What @lurch said. The buttons are broken due to the cross compile. They pick up the wrong compiler.

I've just double-checked the getting-started guide, and it says:
// These settings tweaks to the cmake plugin will ensure
// that you debug using cortex-debug instead of trying to launch
// a Pico binary on the host

and that certainly rings a bell from when I was trying this before we auto-hid those buttons. So maybe these settings are a bit overzealous (and perhaps I mis-spoke in my earlier comment), and perhaps it's only the debug and launch buttons that need to be hidden? I'll try to remember to check this next week.

I did some testing this afternoon, and I still think that build-button works. debug and launch should still be hidden. In the cmake-code of VSC there are already some code snippets which hint that debug will eventually support a configuration from launch.json. Once that is ready, the debug-button can be activated again.
BTW: it turns out that elf2uf2 needs to  be build together with the program if you want to use debugging (the RP2040 itself does not seem to care). So my second commit is definitely not helpful in the general case.

@bablokb You seem to have added a bunch of commits to this PR, unrelated to the original subject of this PR? I suggest you make each of your changes on a separate branch, and submit them as separate pull-requests, rather than trying to make all your changes directly on your master branch.

Yes, please send in as separate PR's - make it much easier to determine when there are problems.

I'll just close this PR. I prefer to make incremental changes to my fork instead of going through the hassle of branches. It does seem useless after all (nothing happening here).

It does seem useless after all (nothing happening here).

We're all rather busy with various other projects. Just because your PR doesn't get merged immediately it doesn't mean that it won't get merged eventually :wink:
Without the "hassle of branches" and one-feature-per-PR it's unlikely your changes will ever appear in this "upstream" repo.


Update Argentina holidays: fix movable holidays prior to 2010

Proposed change

Fix Argentina's Columbus Day/Respect for Cultural Diversity Day's movable status to only applies from 2010 onwards as per Decreto 1584/2010
Apply _add_columbus_day(...) for AR (blocked by #1256)

Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency upgrade (version update)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)x

Checklist

[x] I've followed the contributing guidelines
[x] This PR is filed against beta branch of the repository
[x] This PR doesn't contain any merge conflicts and has clean commit history
[x] The code style looks good: make pre-commit
[x] All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
[x] The related documentation has been added/updated (check off the box for free if no updates is required)

coverage: 100.0%. remained the same when pulling c79644ece2cffe34b42ea942db27412e0a98cb56 on PPsyrius:argentina_movable_holiday_fix into 4c691d998d1f31285d1a564e5ababcd3b00e973a on dr-prodigy:beta.

It has been merged into beta. 👍


Small refactoring

Purpose
So lazy...
Related Information

[ ] Design document: ...
[ ] Bench PR: ...

Testing

[ ] This change is a trivial rework or code cleanup without any test coverage.
[ ] This PR adds tests that were used to verify all changes.
[ ] There are tests in an external testing repository: ...
[ ] This change is already covered by existing tests.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

319 of 325 (98.15%)  changed or added relevant lines in 38 files are covered.
11 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-1.5%) to 98.47%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

include/yaclib/algo/detail/wait_group_impl.hpp
36
37
97.3%

include/yaclib/async/detail/result_core.hpp
4
6
66.67%

src/async/base_core.cpp
16
19
84.21%

Files with Coverage Reduction
New Missed Lines
%

include/yaclib/async/detail/result_core.hpp
1
88.57%

include/yaclib/async/detail/promise_impl.hpp
2
90.0%

include/yaclib/executor/detail/unique_task.hpp
2
85.71%

src/async/base_core.cpp
6
86.11%

Totals

Change from base Build<PHONE_NUMBER>:
-1.5%

Covered Lines:
1094

Relevant Lines:
1111

💛  - Coveralls


[WIP] warning message: always link to current uri

Description

Based off feedback from the community, I've updated the warning to append the current URL path instead of forwarding to /latest
Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

So this "works", but as new pages have been added/removed in newer versions, some of the link will return 404 therefore failing CI. I'm not sure how best to get around this in Jekyll as it's only a static site generator?

@ozdanborne might have some thoughts on the above?

Closing this for now as it's a bit more work than expected. Will re-evaluate in the future.


Update solana.tokenlist.json

Please provide the following information for your token.
Please include change to the src/lib/.json and in the PR
At minimum each entry should have
Token Address: k82Mpv3kMuC6NGZy1K51wjnZ6fmH2nHJNznLrf5NuzX
Token Name: Hopeful
Token Symbol: HOPE
Logo:
Link to the official homepage of token:
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_):

please store logo in this repo under assets/mainnet/

no updates.


fix: prevent JsonValue from being passed directly into JSX

Hey, I just made a Pull Request!
Fixes #18654
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Done @agentbellnorm

@agentbellnorm Done. Could you please TAL when you get a chance?

@agentbellnorm The type that we defined for FilterOption is based on the three different ways we saw it potentially being used in the code: as raw strings, numbers, or Records with the label and value fields.
export type FilterOption =
  | string
  | number
  | (Record<PropertyKey, string> & {
      value: string;
      label: string;
    });

While the type itself is varying, it was previously typed as a JsonValue, which effectively allowed it to be written as any type at compile-time. However, since TypeScript doesn't have control over what happens at runtime, these type changes won't break any existing apps.
In the worst case, if someone is using the FilterOption type outside of the defined bounds somewhere in the downstream, they would simply need to update their types.
In any case, let me know what changes you'd like to see and I'll make them happen.


 It is important to upgrade this image to Go 1.12.6 to do some go mod related check. @allencloud

Quite reasonable. Could you submit a pull request to update this? @yeya24
Then I will tag this, rebuild and push the image.

I have updated the pouchcontainer/pouchlinter:v0.2.0 on DockerHub. @yeya24


Added aliases.

This feature allows the addition of custom aliases in the hyper.js config file. This is useful for mapping tools that use the same icon such as nodemon -> node and python3 -> python.

Thanks for all the work. I'm definitely interested in merging this but there's a few changes I'd like to make beforehand when I get time ✌

When will be this merged? People have a lot of functions / aliases and this looks like cool feature.

hm, any progress on PR?

@henrikdahl ping


Sync config changes in real time

Use fs.watchFile to detect changes to the config file. Update servers and UI in real time without needing to restart the program.
Perhaps show a banner on the main list / refresh button icon at the top. Click to reload from config file. Essentially just restarts the program. Detect changes to config outside of program.

It would be nice if when I save a file that the browser would auto-refresh.

It would be nice if when I save a file that the browser would auto-refresh.

That couldn't be supported. The file would need to have javascript code thrown into it and keep a socket connection open with the server to know when to refresh. This issue is about the config file for the server settings, to refresh the app settings when the app settings are changed

It would be nice if when I save a file that the browser would auto-refresh.

Thanks for the suggestion! This could be possible, but it would require injecting some additional code into the page, and would only work with .html files. I know that some JavaScript frameworks take this approach already, and it would certainly be handy to have the page update whenever you make a change. We'll consider adding this as an optional feature in a future release.
I went ahead and parked the idea in issue #106. Let us know if you have any additional ideas or suggestions!


Compare route names between lin files and add and delete lines based on it

This should happen within the method evaluate_differences in transit.py.
Note I combined the add and delete since they essentially happen in the same place.

commit bbbb4e7


open source?

Are you going to be open sourcing anything here?
Saw this come across and hoping that it means yes. :)
https://github.com/ccxt/ccxt/issues/56#issuecomment-411422859

I will surely be contributing certain components of the websocket implementation in our platform to this repo.  My work is currently not compatible with ccxt so will have to work on that aspect.  I do not think loose ended decoupled PRs will pass the acid test and the high standards set forth in this library.  I will be working on this aspect and hopefully contribute meaningfully


239 hotfix refactor

Hi @CBROWN-ONS , please review suggested implementation and merge if happy. Apart from the simplification, the charts behave as expected.

Codecov Report
Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bc75e18) 97.79% compared to head (4527a54) 97.74%.

Files
Patch %
Lines

src/transport_performance/gtfs/multi_validation.py
90.90%
1 Missing :warning:

Additional details and impacted files
@@                        Coverage Diff                         @@
##           239-plot-trips-and-routes-real     #252      +/-   ##
==================================================================
- Coverage                           97.79%   97.74%   -0.06%
==================================================================
  Files                                  21       21
  Lines                                1906     1904       -2
==================================================================
- Hits                                 1864     1861       -3
- Misses                                 42       43       +1

Flag
Coverage Δ

unittests
97.74% <90.90%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Allow the TrustDomain to be set.

This PR is meant to add support for custom trust domains to Istio CSR. It sets the domain in the SPIFFE library allowing for certificates with a the trust domain to be signed.
The tests were updated to specify a custom trust domain (foo.bar). LMK if there's a better way to test a change like this.
The Helm chart was updated as well, a new value was added: trustDomain.

Thanks @janzantinge! This is a much needed addition.
/lgtm


New Mandem Territory

The print location array button wasnt working so i screenshotted it for you dont know if this will even be helpful to you as its not sent the way u intended but never the less.
https://i.imgur.com/Y06ak3A.png

Does Prune Gang still control the cemetery? Is it shared with the Mandem or has one pushed the other out?


Namespace completion issue

When I have class with namespace like this:
<?php

namespace My\Name\Space;

class MyClass {
  public function testFunction() {
    new DateTi //case 1
    new \DateTi //case 2
  }
}

For case one padawan is giving suggestions when pointing on 9th column (D letter), but for the case 2 when pointing at 10th column (D letter as in case 1).
Is that how it should be?
I'm not even sure if the case 1 should be suggested as the code is invalid (it's creating My\Name\Space\DateTi.... For the second case, shouldn't completion work when pointing at backslash (as it is part of the class name)?

that's because padawan uses same completer for use completion and classes completion after new and extends. So we need new completer that will check uses and will create relative name


Clip using input seek

Q
A

Bug fix?
no

New feature?
yes

BC breaks?
no

Deprecations?
no

Fixed tickets
fixes #issuenum

Related issues/PRs
#issuenum

License
MIT

What's in this PR?
Cutting video with clip filter is slow because use output seeking method.
This PR add clip that use input seeking method. It is faster option. For more information see http://trac.ffmpeg.org/wiki/Seeking
Why?
Because cut filter is slow.
Example Usage
$clip = $video->clip(FFMpeg\Coordinate\TimeCode::fromSeconds(30), FFMpeg\Coordinate\TimeCode::fromSeconds(15));
$clip->save(new FFMpeg\Format\Video\X264(), 'video.avi');

On clip you can apply same filters as on video. For example resizing filter.
$clip = $video->clip(FFMpeg\Coordinate\TimeCode::fromSeconds(30), FFMpeg\Coordinate\TimeCode::fromSeconds(15));
$clip->filters()->resize(new FFMpeg\Coordinate\Dimension(320, 240), FFMpeg\Filters\Video\ResizeFilter::RESIZEMODE_INSET, true);
$clip->save(new FFMpeg\Format\Video\X264(), 'video.avi');

Thanks for your contribution. :)

Thank you! I'm going to test this in a bit and then file a new release with this pull request. :)

Plan to test this at the weekend. Sorry for the delay :/

AWESOME! It is working fine for me! Thank you very much. 🎉
I want to file a new release tomorrow, hope that's okay for you. :)


socket: move connection id interface to SocketAddressProvider

Commit Message: socket: move connection id interface to SocketAddressProvider
Additional Description:
Avoid populating the connection id into streamInfo by multiple places, moving connection
id into SocketAddressProvider.
Risk Level: low
Testing: unittest
Docs Changes: n/a
Release Notes: n/a
Part of #17168
Signed-off-by: He Jie Xu<EMAIL_ADDRESS>

@mattklein123

/retest


The code portability issue for trained networks

Hi Tim,
When I try to porting my whole solvable project, l4casadi-acados solve frame, to another computer(computer1 - computer2), problems are encounted. The error reports are as follow:
terminate called after throwing an instance of 'c10::Error'
what(): open file failed because of errno 2 on fopen: . file path : /computer1/trained_net.pt (absolute path)
A stupid method is to create the same folder path of comput1 on the compute2 and copy *.pt to the folder, which result in poor portability.
How can we change call logic of *.pt from the absolute path to relative one?
Best
Hu

Hi Hu,
please see the reply in this issue: https://github.com/Tim-Salzmann/l4casadi/issues/16
Best
Tim


Add store to database.json

A key-value store that persists on disk for Deno.

@Acathur please merge with master

#646


createMachine function not found

I'm learning xstate and impatient as I am, I wanted to try out Typestates, but I cannot use the createMachine function as it doesn't seem to be present in the javascript code of 4.7.0-rc5 package, but present in its Machine.d.ts. Is this already fixed in master? Should I just wait for next RC or final release?
Thanks.

Released as 4.7.0-rc6 - should work there.

Released as 4.7.0-rc6 - should work there.

Thank you!


Please clarify "Diagonally right and up"

Hi there, in the README, the documentation mentions that the miner can move "diagonally right and up".  This is a bit confusing, so I wonder if you can clarify.  Does it mean that in one turn, the miner can move to #7 (column 2, row 1)?
or do you mean column 2, row 2 (which would be a value of 8)
If it is col 2 row 2, I would recommend you remove the wording "and up" and rather just state "can move "diagonally right upwards"
and "diagonally right downwards" - the word "and up" feels like it could be two moves.
Just a suggestion - let me know if you agree. Thanks!

Thanks for the suggestion @firecentaur ! I agree with your suggestion and will make the needed documentation updates.

Fixed in https://github.com/riipen/gold-mine/commit/acd227443106e5c3008da4e070cb8e198008c8e0.


throw exception if Chef::Provisioning::Transport.:WinRM#execute command is over 3040 chars

I've validated that 3040 is too long https://github.com/WinRb/WinRM/issues/41 so we should look at throwing an error if we are asked to do something we can't do.

Hey @hh it looks like this has overlap with https://github.com/chef/chef-provisioning/issues/431.  Can we close this in favor of your suggestion for #431 where we send the file over and execute it with a scheduled task?

Closing this in favor of #431


URL rewriting when minifying css file outside document root

While minifying a bootstrap library css file I noticed that if file is not
under document root and not symlinked in document root the url rewriter blindly
fails trying to remove document root path from absolute url.

Minify commit/version: 2.1.7
PHP version: any

What steps will reproduce the problem?

groupsConfig.php:

return array(
  'test2.css'=> array (
    '/var/h/lib/bootstrap-3.0.3/css/test.css',
  )
);

test.css:

@font-face {
  font-family: 'Glyphicons Halflings';
  src: url('../fonts/glyphicons-halflings-regular.eot');
}

debug output:

/* Minify_CSS_UriRewriter::$debugText

docRoot    : /var/www/www.example.org/public_html
currentDir : /var/h/lib/bootstrap-3.0.3/css

file-relative URI  : ../fonts/glyphicons-halflings-regular.eot
path prepended     :
/var/h/lib/bootstrap-3.0.3/css/../fonts/glyphicons-halflings-regular.eot
docroot stripped   : hicons-halflings-regular.eot <<<<<------- DOCROOT SHOULD
NOT BE STRIPPED AS PATH WAS ABSOLUTE
traversals removed : hicons-halflings-regular.eot

*/

/* test.css */

/* 1 */
/* 2 */ @font-face {
/* 3 */   font-family: 'Glyphicons Halflings';
/* 4 */   src: url('hicons-halflings-regular.eot');
/* 5 */ }
/* 6 */

I could not find any documentation about wether or not it should be possible to
minify files out of document root, but a possible easy solution would be to
modify UriRewriter line 163:

        // strip doc root
        $path = substr($path, strlen($realDocRoot));

to check if $path contains $realDocRoot before cutting it.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 26 Dec 2013 at 10:46

You must configure Minify to handle URLs served from outside the docroot.
http://code.google.com/p/minify/wiki/UriRewriting#Aliases_/_Symlinks_/_Virtual_D
irectories

Original comment by<EMAIL_ADDRESS>on 26 Dec 2013 at 4:37

Changed state: Invalid

After a bit experimenting, there is no use in generating correct paths outside
of document root.
Even if we were able to generate the correct path in the example, the fonts
would not be available as they are not reachable by the web server.

However, I still think this is a bug since min generated a wrong truncated path
without any error or notice.

Original comment by<EMAIL_ADDRESS>on 26 Dec 2013 at 3:29


it doesn't  support double type

This is the same as the original Clipper library, which uses ints to avoid rounding errors.
I've been converting my polygons by multiplying them by 1000, using Clipper, and then dividing again, to get some decimal places. Maybe that also works for you.


How do we express the intention of non-obvious test cases in our canonical-data.json files?

I'm spinning this off from #230 since #230 forked off into at least three separate topics.
The problem statement I wish to discuss:
When I look at a canonical-data.json, how can I be sure that every test case is necessary? For each test case:

What does it test for?
What mistaken solutions might it help catch?

If it is not already clear from the test description, I want some way to tell.
From #230, we have some suggestions from @kotp and @kytrinyx that a "notes" key for the non-obvious cases can be used. I have similarly used a "#" key (why "#"? Probably because it starts a comment line in some language, but I think I prefer a descriptive word than "#") such as at https://github.com/exercism/x-common/blob/master/exercises/largest-series-product/canonical-data.json#L89 . Note that that specific "#" was to explain why the test case is correct rather than why it is necessary, so it's slightly different, but I imagine it could still be changed to "notes".
One possible solution I anticipate people saying is "let's just use Git commit messages". I had some thought that it might take more time to look through those than to have it right there in the file, but I'm open to discussion on that one.
On the other hand, if we decide to use "notes", then we would want to update https://github.com/exercism/x-common#test-data-format-canonical-datajson .

From my reading of https://github.com/exercism/x-common/issues/382#issuecomment-248735331

This also feels different from canonical-data.json as well, as that feels like it is the end result of the discussion, and most people who want to use it to generate a new implementation should be able to follow it without worrying about the details, unless they're interested in them.

This may imply that a "notes" key is too much information for the canonical-data.json file, and that the answers to the questions I pose might be better served by having a separate file and/or looking through the commit messages.

One possible solution I anticipate people saying is "let's just use Git commit messages".

This is my answer. Git commit messages are for the "Why". Trying to convert a structured format (like json) so that it contains all the context sounds like trying to play basketball with a hockey puck. You might be able to make it work, but it's probably not going to be much fun.

On a basic level, I realize an analogy for this issue is like the difference between putting rationale for a certain piece of code in a code comment versus putting it a commit message. When is the right time to do one versus the other? This is something I don't have a good answer for personally. I would be interested in whether anyone has rules they use for deciding this. I'll do some looking and report back too.
As it relates to action on this issue: My need for something other than Git commit messages would be more convincing if I can point to an example of an exercise in which

I was confused by a test case, and
Git commit messages were not sufficient for me to understand.

I have no current example fitting these criteria, so that makes me unsure whether I should pursue this.
I think we have been good at asking for rationale in commit messages. And since people are already going to put their rationale in commit messages. One could argue that it is duplication to put the same rationale in both commit messages and somewhere in the JSON file!
If I can't come up with a good example for when Git messages did not serve me, I should close this issue, once I confirm that we have some document with guidelines for commit messages (I think we have one, but I want to be sure).

One possible solution I anticipate people saying is "let's just use Git commit messages".

I think git commit messages are for the why, but for a slightly different purpose. Git commit messages are something that you would dig into only if you wanted to change something and were unsure about whether or not something has been discussed before. In this case I think that we'd be interested in surfacing the why on a more broader scale: anyone implementing the exercise should be able to understand what philosophical vectors we've traveled along and why we ended up where we did. That seems like something worth surfacing in a policy document or a "notes" section in the canonical data.
I like the distinction that @petertseng makes between # for what and notes for why for a specific test case. That said, I think that since the why is not ever intended to be machine readable, and it's also likely that it doesn't apply to specific tests, a separate document would be easier to use.

That seems like something worth surfacing in a policy document or a "notes" section in the canonical data.

If we pick the former, it sounds like something #382 would handle.
(Just trying to figure out if I should still keep this issue open)

I should close this issue, once I confirm that we have some document with guidelines for commit messages

Confirm: https://github.com/exercism/x-common/blob/master/CONTRIBUTING.md#commit-messages
That's the last thing I had to check before closing the issue - the policy document discussion can go in #382, I think?


Pack all items - many available boxes

David
Would you please suggest how one could modify the code so that rather than just packing only one box at a time, that it would have an infinite number of each of the specified containers, and find the 'optimal' (or very good ;) packing of all items, for the minimum total container volume.

Pass all known items and boxes into the PackingService.Pack method and first find which container has the highest PercentContainerVolumePacked. You can then get all of the UnpackedItems from there and re-run the PackingService.Pack method with those UnpackedItems (again finding which container has the highest PercentContainerVolumePacked) until all items are packed. In the end, you would have the multiple boxes in which everything was packed in.


As a developer, I can update story and task status with drag and drop (click the triangle at far left of this story to show sub-tasks)

➤ James McLean commented:
Joined Sample Sprint 2 7 days 9 hours 10 minutes ago


Export the trained model

Hello Team,
I have trained a model and now I want to export the trained model. Is there is any way to achieve it (apart from the checkpoint directory)?

Closing the issue, I found the flag --model_path that works out well.


Merging master-ndkbuild branch into cmake branch

source code are shared with cmake's copy
two-libs and test-libstdc++ are not shared with cmake

LGTM


WIP - #1401 - Run a policy file stored in S3

Issue #1401
This allows you to run a policy file stored in S3, e.g.:
$ custodian run -s out s3://scot-test/ec2.yml
2017-07-16 09:52:34,069: custodian.policy:INFO policy: ec2-running-instances resource:ec2 region:us-east-1 count:2 time:1.44

@kapilt
One thing I'm not sure about is how to construct a session when fetching the policy file from S3.  I'm currently using the get_profile_session function which takes the profile into account but not the region if someone passes --region.  It seems like we should consider the region, but then again, what happens if someone passes multiple regions?  How would we know which one to use to fetch the policy?  So I opted for just using the profile for now, but wanted to call this decision out if you have other thoughts.

WIP because I need to add a test still.  Will do that soon.

i'd suggest taking a look at reusing the resolver.py implementation. re region, s3 auto resolves bucket region correctly.


Manually test different combinations with PressCombination method

In release 0.5, we added a new feature of pressing key combinations using KeyboardManipulator. But some system combinations don't work for some reason.
Our goal is to find all the combinations that don't work and find out what the problem is.
Please post here all combinations that didn't work for you.

CTRL + ALT + DELETE
WIN + L


Feature/GH-838 Documentation updates for SSR

Excellent doc input!! I reviewed and edited all the provided content in this PR! Have a look at my changes, and of course feel free to merge any time 😄


Return value is incorrect

When the tests don't succeed, returnvalue should be non-zero.

I think this is fixed in 65801814b2, but have no time to extensively create a reproduction of the problem. Can you verify?

Is this fixed?

Works for me in 0.2.4.beta1, thx


update collector resource request

/hold and will be merge to 2.3 z stream
Signed-off-by: Song Song Li<EMAIL_ADDRESS>

/unhold

/lgtm


Fix crash caused by dangling thread

Summary of the Pull Request
Background running thread was preventing Settings app to close properly causing crash on next launch.
Repro steps:

run PT
double click tray icon to run settings app
close settings app (X button)
double click tray icon again
crash

PR Checklist

[ ] Closes: #xxx
[ ] Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
[ ] Tests: Added/updated and all pass
[ ] Localization: All end user facing strings can be localized
[ ] Dev docs: Added/updated
[ ] New binaries: Added on the required places

[ ] JSON for signing for new binaries
[ ] WXS for installer for new binaries and localization folder
[ ] YML for CI pipeline for new test projects
[ ] YML for signed pipeline

[ ] Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

/azp run


fix(FeeEstimate): rename "amount" to "overall_fee"

Closes #194

I believe you'll also need to update the estimate_fee test data for the tests to pass.


Fixed ChatGPT nuspec file

Removed extra data
Fixed copyright
Used Statically for the icon so that it's tied to the commit and not the repository, that way if the icon ever changes we can update it by changing the URL
Improved description
Added screenshot to repo, used Statically for image URL in description
Improved code formatting
Added release notes
Added (Unofficial) in the title, that's generally recommended if it's not the official app
Improved the tags
Set requireLicenseAcceptance to false since it's not required when installing

I formatted update.ps1 since in VS Code you can just press Ctrl+Alt+F, but I understand if you don't want to change the formatting. 😊


'OpenGLCamera' object has no attribute 'background_color' when rendering using manim.opengl

Description
Hi, there! I have found that the newest V5.1.7 manim-slides can't render manim.opengl scene. The mwe is shown here:
from manim import *
from manim.opengl import *
from manim_slides import Slide, ThreeDSlide
config.renderer = "opengl"

class Test(ThreeDSlide):
    def construct(self):
        cir = Circle()
        self.play(Create(cir))
        self.wait()

The terminal then outputs:
[05/17/24 19:26:03] INFO     Animation 0 : Partial movie file written in                             scene_file_writer.py:527
                             '/home/semikernel/Tiktok/Projects/OneMonthPlan/media/videos/gaza/1920p6
                             0/partial_movie_files/Test/2702378517_2531373006_223132457.mp4'
[05/17/24 19:26:04] INFO     Animation 1 : Partial movie file written in                             scene_file_writer.py:527
                             '/home/semikernel/Tiktok/Projects/OneMonthPlan/media/videos/gaza/1920p6
                             0/partial_movie_files/Test/1069205256_3146877161_1023450693.mp4'
                    INFO     Combining to Movie file.                                                scene_file_writer.py:617
                    INFO                                                                             scene_file_writer.py:735
                             File ready at
                             '/home/semikernel/Tiktok/Projects/OneMonthPlan/media/videos/gaza/1920p6
                             0/Test.mp4'

                    INFO     Rendered Test                                                                       scene.py:241
                             Played 2 animations
[05/17/24 19:26:05] INFO     Generated 1 slides to                                                                base.py:503
                             '/home/semikernel/Tiktok/Projects/OneMonthPlan/slides/files/Test'
╭─────────────────────────────── Traceback (most recent call last) ────────────────────────────────╮
│ /home/semikernel/.local/lib/python3.10/site-packages/manim/cli/render/commands.py:115 in render  │
│                                                                                │
│   112 │   │   │   try:                                                                           │
│   113 │   │   │   │   with tempconfig({}):                                                       │
│   114 │   │   │   │   │   scene = SceneClass()                                                   │
│ ❱ 115 │   │   │   │   │   scene.render()                                                         │
│   116 │   │   │   except Exception:                                                              │
│   117 │   │   │   │   error_console.print_exception()                                            │
│   118 │   │   │   │   sys.exit(1)                                                                │
│                                                                                │
│ /home/semikernel/.local/lib/python3.10/site-packages/manim_slides/slide/manim.py:97 in render    │
│                                                                                │
│    94 │   │                                                                                │
│    95 │   │   config["max_files_cached"] = max_files_cached                                      │
│    96 │   │                                                                                │
│ ❱  97 │   │   self._save_slides()                                                                │
│    98                                                                                │
│    99                                                                                │
│   100 class ThreeDSlide(Slide, ThreeDScene):  # type: ignore[misc]                               │
│                                                                                │
│ /home/semikernel/.local/lib/python3.10/site-packages/manim_slides/slide/base.py:512 in           │
│ _save_slides                                                                                │
│                                                                                │
│   509 │   │   PresentationConfig(                                                                │
│   510 │   │   │   slides=slides,                                                                 │
│   511 │   │   │   resolution=self._resolution,                                                   │
│ ❱ 512 │   │   │   background_color=self._background_color,                                       │
│   513 │   │   ).to_file(slide_path)                                                              │
│   514 │   │                                                                                │
│   515 │   │   logger.info(                                                                       │
│                                                                                │
│ /home/semikernel/.local/lib/python3.10/site-packages/manim_slides/slide/manim.py:26 in           │
│ _background_color                                                                                │
│                                                                                │
│    23 │                                                                                │
│    24 │   @property                                                                              │
│    25 │   def _background_color(self) -> str:                                                    │
│ ❱  26 │   │   color = self.camera.background_color                                               │
│    27 │   │   if hex_color := getattr(color, "hex", None):                                       │
│    28 │   │   │   return hex_color  # type: ignore                                               │
│    29 │   │   else:  # manim>=0.18, see https://github.com/ManimCommunity/manim/pull/3020        │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
AttributeError: 'OpenGLCamera' object has no attribute 'background_color'

Version
manim-slides, version 5.1.7
Platform
ubuntu 22.04
Screenshots
No response
Additional information
Actually in previous manim-slides, everything works well. I am wondering where the error comes from. Thx a lot:)
No response

Hello, nice catch @semikernel!
I actually never use the OpenGL renderer, but I guess supporting it would be very easy.
Reading the OpenGLCamera class, it looks like I might need to try from config["background_color"] instead. Something similar might also be needed for the other attributes.
I don't have might time for this at the moment, but feel free to give it a try if you feel confident enough :-)

Hello, nice catch @semikernel!
I actually never use the OpenGL renderer, but I guess supporting it would be very easy.
Reading the OpenGLCamera class, it looks like I might need to try from config["background_color"] instead. Something similar might also be needed for the other attributes.
I don't have might time for this at the moment, but feel free to give it a try if you feel confident enough :-)

Hi,there! I figured it out by creating a ThreeDSlideGL class, it worked. I found it difficult to integrate it to manim-slides whole project. I need to change many all = [ ] stuffs. However, it worked well:)
from manim_slides import Slide, ThreeDSlide
from manim.renderer.opengl_renderer import OpenGLCamera

class ThreeDSlideGL(ThreeDSlide):
    @property
    def _background_color(self) -> str:
        try:
            # Attempt to get the background color for OpenGLCamera
            if isinstance(self.camera, OpenGLCamera):
                # Check for possible attributes
                if hasattr(self.camera, 'background_rgba'):
                    color = self.camera.background_rgba
                elif hasattr(self.camera, 'background_color'):
                    color = self.camera.background_color
                else:
                    # Fallback to default color if none is found
                    color = (0, 0, 0, 1)  # Default to black

                return "#" + "".join(f"{int(c*255):02x}" for c in color[:3])
            else:
                # Handle other camera types
                color = self.camera.background_color
                if hex_color := getattr(color, "hex", None):
                    return hex_color  # type: ignore
                else:
                    return "#000000"  # Default to black if attribute is not found
        except Exception as e:
            # Handle any unexpected errors
            return "#000000"  # Default to black


Plugin stopped working

HOOBS 3.2.6
Switcher V2 with firmware 3.32
My json
{
    "accessory": "SwitcherBoiler",
    "accessoryType": "valve",
    "name": "Boiler",
    "pollingIntervalInSec": 60,
    "debug": false
}

I get this error since the last update:
[Boiler] ERROR Getting State from the Switcher:
[Boiler] Error: [Errno 113] No route to host

more info:
the switcher is detected on load:
[Boiler]  ~~~~~~ DISCOVERED SWITCHER DEVICE (192.168.xxx.xxx) ~~~~~~
but than this happens:
(node:11847) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 shutdown listeners added to [API]. Use emitter.setMaxListeners() to increase limit [Boiler] ERROR Getting State from the Switcher (interval): [Boiler] Error: [Errno -2] Name or service not known
and the error goes on loop

check version 2.0


TST Avoid assert_allclose(.., atol=0) when comparing against 0

Avoid assert_allclose(.., atol=0) when comparing against 0 in test_zero_rhs[lgmres].
Fixes of the test failures with BLIS reported in https://github.com/scipy/scipy/issues/10744
The failure was,
    def test_zero_rhs(solver):
[...]
>                       assert_allclose(x, 0)
E                       AssertionError:
E                       Not equal to tolerance rtol=1e-07, atol=0
E
E                       Mismatch: 100%
E                       Max absolute difference: 1.19386456e-164
E                       Max relative difference: inf
E                        x: array([ 5.155324e-165,  7.054654e-165,  4.341326e-165, -1.193865e-164,
E                              -2.713329e-165, -7.597320e-165, -5.426657e-166, -4.341326e-165,
E                               3.255994e-165, -8.682651e-165])
E                        y: array(0)

Doesn't look right --- why does the routine claim successful convergence with atol=0, if the vector is not equal to zero?
There's probably some issue with the blas library that np.linalg.norm(x) == 0 does not imply all elements of x are zero?

You are right, I overlooked the atol=0 in the solver above.

There's probably some issue with the blas library that np.linalg.norm(x) == 0 does not imply all elements of x are zero?

I suspect it's the same issue as with overflow in https://github.com/flame/blis/issues/332 . Without a scale factor, squaring say [1e-165] while computing the norm will yield 0 even if all elements of the array are not zero.
Closing for now.


generate wifi QRCode

Hello,
Did you thinks that it's possible to generate qrCode for wifi access ?
Thanks a lot for the librarie.

Yupp, you certainly can. :)
Here is the long version from zebra crossing, but the TL;DR for your purposes can just use this format:
WIFI:S:;T:<WPA|WEP|>;P:;;
For example:
WIFI:S:STARBUCKS;T:WPA;P:PASSWORD123;;
Hope that helps.

thanks a lot


Kerberos SSO no longer working

Kerberos SSO is no longer working (kinit configured against IPA).  Browser targeting the Appliance pops up an Authentication Required dialog.
With Kerberos SSO, there is no password information on screen to grab, thus the API authentication done by miq_api.js will fail.

@jvlcek you won't be able to test the SSO flavor of the IPA/AD trust trello story until this is fixed.
@gtanzillo fyi.

@abellotti who is on this?  you or @jvlcek?
/cc @gtanzillo

Right now no one, briefly looked at it, will require UI (javascript) changes and possibly API.

Ok, giving this a try


Translation support

Would it be possible to support translating the motile/sessile messages into different languages?

I've changed Sessility to use raw JSON text instead of strings for both sessile and motile messages. Try this build with the Server Translations mod and let me know if the changes work for your use case.
You'll first need to provide a raw JSON text string with translatable contents for the message-motile and message-sessile properties. Make sure the : character is escaped with a backslash character. For example, the sessility.properties file might look something like this:
sessility.properties
message-motile={"translate"\:"multiplayer.player.motile","color"\:"yellow"}
message-sessile={"translate"\:"multiplayer.player.sessile","color"\:"yellow"}

Then, you will need to create a custom datapack with the translation files and place it in the server's datapacks directory. For example, your server's working directory might look something like this:
<server-working-directory>
|- config
|- log
|- mods
|- world
|  |- advancements
|  |- data
|  |- datapacks
|  |  |- <my-pack>
|  |     |- data
|  |     |  |- <my-namespace>
|  |     |     |- lang
|  |     |        |- en_pt.json
|  |     |        |- en_us.json
|  |     |        |- ...
|  |     |
|  |     |- pack.mcmeta
|  |
|  |- ...
|
|- ...

Each translation file might look something like this:
en_pt.json
{
	"multiplayer.player.motile": "%s be movin' again!",
	"multiplayer.player.sessile": "%s be like a sponge"
}

en_us.json
{
	"multiplayer.player.motile": "%s is no longer AFK",
	"multiplayer.player.sessile": "%s is AFK"
}

Perfect! I'll leave this issue open until these changes make it into a release, which will likely be version 0.7 for Minecraft 1.21.4.

Sessility 0.7 has been released!


[stable/seq] Fixing data volume mounting

This fix an indentation issue resulting in no data volume defined in the deployment.
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

/approve

/lgtm


[DO NOT MERGE] Add SSR support to search page

DO NOT MERGE
This is ready for review, but not ready to merge.
This change adds SSR to the /search page using the Gatsby 4 beta release. The server response uses the URL query parameters to fetch the filtered product list for the HTML response.

Adds a src/utils/search.js module for functions that involve the Shopify Storefront API for use in server and client rendering. Some of these functions were moved from the current src/utils/hooks.js module.
Due to the way URQL's useQuery hook works, there are some changes to prevent additional rerendering during client-side rehydration. I am unsure how to prevent this hook from making a fetch request during hydration, so any suggestions there could be helpful.
This also adds a basic empty state for searches that do not return any results.
Currently this does not work in local development due to a bug. For testing this locally, use yarn build && yarn serve

It's probably also worth updating the instructions in the README to use npm start instead of assuming a user has gatsby installed globally, which they might not if they use npx gatsby new

Yeah I think that would be a nice addition. I also had a bit of an issue piecing together all the steps needed to get this up and running locally, specifically around creating the .env and plugging in my values. It's mentioned here but if you're walking through that README step by step, you're going to experience issues before getting that far down the README.


Performance is really bad - how good should it be?

Hello!
I have a Radeon RX 6700, but am getting:
2023-10-04T11:05:19.373411Z  INFO bevy diagnostic: frame_time                      : 1000.697956ms (avg 1000.396673ms)
2023-10-04T11:05:20.373406Z  INFO bevy diagnostic: frame_count                     : 1230.000000
2023-10-04T11:05:20.373429Z  INFO bevy diagnostic: fps                             :    0.999357   (avg 0.999634)
of course running with cargo run --release --bin client
I tried disabling the lighting to no avail. Any ideas? Should it perform better?
I was on 42734750a632ae94b4bf2d5a178f1deec44a1288 btw

That's sounds bad~
Do you sure when you run the gpu is worked? your gpu should performance better than me.


Add Schedules Page

Is your feature request related to a problem? Please describe.
Ideally, we would like to have a basic schedules page that could show some information such as move in and move out schedules.
Describe the solution you'd like
WIP - we will need to have a meeting to spec this task out.
Potential requirements:

Ability to set your move-in and/or move out dates for the flat.

Checklist:

[x] I have double checked that the issue does not currently exist.
[x] I have added the appropriate labels (e.g. feature, front-end, back-end).
[x] I have added the Platform Project project

Out of scope.


[SQLite] Bug in prismaSchemaFolder: Incorrect Database File Generation and Missing Table Error

Bug description
When using Prisma and SQLite in NestJS and the new feature prismaSchemaFolder, with datasource db.url = "file:./dev.db". prisma db push, a dev.db file will be generated under prisma/schema. But when the application is running, for example, when accessing an API that uses Prisma Client, a dev.db will be generated under the prisma folder, which is a blank database.an error is reported: The table main.Project does not exist in the current database.

__
How to reproduce

use prismaSchemaFolder
db.url = "file:./dev.db"
prisma db push
access API with prismaService

Expected behavior
Use the dev.db file under prisma/schema
Prisma information
generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["prismaSchemaFolder"]
}

datasource db {
  provider = "sqlite"
  url      = "file:./dev.db"
}

@Injectable()
export class AppService {
  constructor(private prisma: PrismaService) {}
  getHello() {
    return this.prisma.project.create({
      data: {
        name: 'test',
        description: 'test',
      },
    });
  }
}

Environment & setup

OS: Windows11
Database: SQLite
Node.js version: v20.15.0

Prisma Version
prisma                  : 5.16.2
@prisma/client          : 5.16.2
Computed binaryTarget   : windows
Operating System        : win32
Architecture            : x64
Node.js                 : v20.15.0
Query Engine (Node-API) : libquery-engine 34ace0eb2704183d2c05b60b52fba5c43c13f303 (at node_modules\.pnpm\@prisma+engines<EMAIL_ADDRESS>Schema Engine           : schema-engine-cli 34ace0eb2704183d2c05b60b52fba5c43c13f303 (at node_modules\.pnpm\@prisma+engines<EMAIL_ADDRESS>Schema Wasm             : @prisma/prisma-schema-wasm 5.16.0-24.34ace0eb2704183d2c05b60b52fba5c43c13f303
Default Engines Hash    : 34ace0eb2704183d2c05b60b52fba5c43c13f303
Studio                  : 0.502.0
Preview Features        : prismaSchemaFolder

Hi @Typeve!
We've identified and fixed the issue. Could you try dev snapshot version 5.18.0-integration-fix-config-dir-client.5 and see if the problem still happens for you? We don't recommend using dev snapshot in production, but it is good enough to ensure the fix will work for you when it is released.
Thank you!

Hi @Typeve! We've identified and fixed the issue. Could you try dev snapshot version 5.18.0-integration-fix-config-dir-client.5 and see if the problem still happens for you? We don't recommend using dev snapshot in production, but it is good enough to ensure the fix will work for you when it is released. Thank you!

Thank you very much, I upgraded both prisma and @prisma/client to the snapshot version, and the problem I encountered was completely fixed!
Does this mean that this fix will be released in version 5.18?

@Typeve thank you for confirmation!
Yes, most likely 5.18.0 will be the first stable version to receive the fix.
In the meantime, you can workaround the issue by explicitly providing DB path when instantiating the client:
new PrismaClient({ datasourceUrl: `file:${absoultePathToDbFile}` })

thanks for the workdaround had same issue


Upgrade electron-windows-store

Pre-flight checklist

[X] I have read the contribution documentation for this project.
[X] I agree to follow the code of conduct that this project uses.
[X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description
Current electron-windows-store version used by forge is outdated.
The latest version notably allow specifying the protocol option: https://github.com/electron-userland/electron-windows-store/blob/7b45c54574596863b8c2f790cea09aabc03b6883/lib/index.js#L43
Also, I guess forge could re-export WindowsStoreOptions TS type to expose up-to-date options ?
Proposed solution
Upgrade electron-windows-store, update options (reusing WindowsStoreOptions ?) & run tests
Alternatives considered
None
Additional information
No response

I see electron-windows-store listed as v2.1.0 in our lockfile, which is the latest version available as per https://www.npmjs.com/package/electron-windows-store
<EMAIL_ADDRESS>  version "2.1.0"
  resolved "https://registry.yarnpkg.com/electron-windows-store/-/electron-windows-store-2.1.0.tgz#c217f0c0617fd70afd2d475c88eb35e8f9bb615e"
  integrity sha512-+kBL20yeY2ahJxvZ6dDtE3gPqWLZI5Glnx7VBLA1cGXagS82PZTFueuvDyLGLcKtI48lhPhW9QmdZ9omh+yKTA==
  dependencies:
    chalk "^2.4.1"
    commander "^2.19.0"
    debug "^4.1.0"
    fs-extra "^7.0.0"
    inquirer "^6.2.0"
    lodash.defaults "^4.2.0"
    lodash.merge "^4.6.1"
    multiline "^2.0.0"
    path-exists "^3.0.0"

Can you elaborate?

I see electron-windows-store listed as v2.1.0 in our lockfile, which is the latest version available as per https://www.npmjs.com/package/electron-windows-store
<EMAIL_ADDRESS>  version "2.1.0"
  resolved "https://registry.yarnpkg.com/electron-windows-store/-/electron-windows-store-2.1.0.tgz#c217f0c0617fd70afd2d475c88eb35e8f9bb615e"
  integrity sha512-+kBL20yeY2ahJxvZ6dDtE3gPqWLZI5Glnx7VBLA1cGXagS82PZTFueuvDyLGLcKtI48lhPhW9QmdZ9omh+yKTA==
  dependencies:
    chalk "^2.4.1"
    commander "^2.19.0"
    debug "^4.1.0"
    fs-extra "^7.0.0"
    inquirer "^6.2.0"
    lodash.defaults "^4.2.0"
    lodash.merge "^4.6.1"
    multiline "^2.0.0"
    path-exists "^3.0.0"

Can you elaborate?

Oh yes I missed the commits from the last few years were not published to npm.
I opened an upstream issue https://github.com/electron-userland/electron-windows-store/issues/156
I guess we can close this one, thanks.


Add help text to describe each form field

Add a question mark next to each field that pops up a helpful description of the field.
Make sure the description is exactly the same as the label.

Check PR #27
There's no question mark but hovering over the field will show the tooltip


[DOC] 4. set v1.7 website as default version

Description
To launch v1.7 website:

Create v1.7 website artifact -DONE
Add entry to v1.7 on master website - DONE #19116
Add entry to v1.7 on previous version website - DONE
Update redirect rule to set 1.7 as default website version - CURRENT

Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage
[x] Code is well-documented

Changes

[x] Set 1.7 as default website version

Comments

Preview: pending

@mxnet-label-bot add [Website]

@mxnet-bot run ci [windows-gpu ]


both fileId and filePid are required for Dataverse Handoff

Currently, both fileId and filePid are required when creating a DataverseHandoff object.  But only one of these fields is needed, either fileId or Pid, to identify the file.  Do we need to require both fields in the API, or should we make it valid to pass just fileId or Pid?

If it helps, all Dataverse installations support fileId (database ID). Only some Dataverse installations support filePid (DOI, usually), which is controlled by a system-wide setting.

Based on Phil's comments, it makes sense to keep things as they are - requiring fileId.  I think it's ok to close this.


:hammer: Api & Redux/RTK

:hammer: Api & Redux/RTK

[x] Made sure that a user can display a list of items and filter them. Data should come from the API.

#5 Implemented :heavy_check_mark:


Replace deprecated function for OpenSSL >= 3.0

ERR_get_error_line_data is deprecated in OpenSSL >= 3.0.
It can be replaced by the newer function ERR_get_error_all added in OpenSSL 3.0.

Please merge, Fedora 36, RHEL 9 Beta and CentOS 9 Stream now use OpenSSL 3.0


Instruct user to activate docker group addition.

Assimilate the command docker will prompt user to make into the useradd to docker step.
Alternative is for user to logout/in/reboot.

Everywhere I've followed these steps, docker has prompted me to do this when proceeding with 1inikube start`, so it might as well be in the docs.
The Docker post-installation docs suggest in step three you can reboot/log out and log back in as an alternative, but it might be easier to just add the command to the docs than include the explanation.


Progressive calls

This PR introduces Progressive calls WAMP Feature
What kind of change does this PR introduce?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] I have added tests to cover my changes.
[ ] Overall test coverage is not decreased.
[ ] All new and existing tests passed.
[ ] My change requires a change to the documentation.

[ ] I have updated the documentation accordingly.

@bboozzoo Can you have a look? :)

Well, at least it works :)
But I'm sure, there are places that can be improved/refactored/made more optimal.

@bboozzoo Refactored to pull model

And we still have a question of Send error checking on the plate. There are tons of such places. Let's think of this. But I suggest working around that in different PR.

Good! Done!


orders (full): bad query performance for sales_shipment_track data

on large enough instances the query performance when reading the shipment data is very bad and forces mysql to use filebased filtering & sorting. the bad query is using nested GROUP BY without filter clauses:
SELECT s_o.entity_id AS di_id, s_o.*, s_o_t.*, s_o_p.*, s_s_t.* FROM ( SELECT s_o.* FROM sales_order AS s_o WHERE (s_o.store_id IN ('1', '2') OR s_o.store_id = 0) ORDER BY s_o.entity_id DESC
 LIMIT 10 OFFSET 10 ) AS s_o

 LEFT JOIN ( SELECT sales_order_tax.tax_id AS s_o_t_tax_id, sales_order_tax.order_id AS s_o_t_order_id, sales_order_tax.code AS s_o_t_code, sales_order_tax.title AS s_o_t_title, sales_order_tax.percent AS s_o_t_percent, sales_order_tax.amount AS s_o_t_amount, sales_order_tax.priority AS s_o_t_priority, sales_order_tax.position AS s_o_t_position, sales_order_tax.base_amount AS s_o_t_base_amount, sales_order_tax.process AS s_o_t_process, sales_order_tax.base_real_amount AS s_o_t_base_real_amount FROM sales_order_tax GROUP BY order_id ) AS s_o_t ON s_o_t.s_o_t_order_id = s_o.entity_id

 LEFT JOIN ( SELECT sales_order_payment.entity_id AS s_o_p_entity_id, sales_order_payment.parent_id AS s_o_p_parent_id, sales_order_payment.base_shipping_captured AS s_o_p_base_shipping_captured, sales_order_payment.shipping_captured AS s_o_p_shipping_captured, sales_order_payment.amount_refunded AS s_o_p_amount_refunded, sales_order_payment.base_amount_paid AS s_o_p_base_amount_paid, sales_order_payment.amount_canceled AS s_o_p_amount_canceled, sales_order_payment.base_amount_authorized AS s_o_p_base_amount_authorized, sales_order_payment.base_amount_paid_online AS s_o_p_base_amount_paid_online, sales_order_payment.base_amount_refunded_online AS s_o_p_base_amount_refunded_online, sales_order_payment.base_shipping_amount AS s_o_p_base_shipping_amount, sales_order_payment.shipping_amount AS s_o_p_shipping_amount, sales_order_payment.amount_paid AS s_o_p_amount_paid, sales_order_payment.amount_authorized AS s_o_p_amount_authorized, sales_order_payment.base_amount_ordered AS s_o_p_base_amount_ordered, sales_order_payment.base_shipping_refunded AS s_o_p_base_shipping_refunded, sales_order_payment.shipping_refunded AS s_o_p_shipping_refunded, sales_order_payment.base_amount_refunded AS s_o_p_base_amount_refunded, sales_order_payment.amount_ordered AS s_o_p_amount_ordered, sales_order_payment.base_amount_canceled AS s_o_p_base_amount_canceled, sales_order_payment.quote_payment_id AS s_o_p_quote_payment_id, sales_order_payment.additional_data AS s_o_p_additional_data, sales_order_payment.cc_exp_month AS s_o_p_cc_exp_month, sales_order_payment.cc_ss_start_year AS s_o_p_cc_ss_start_year, sales_order_payment.echeck_bank_name AS s_o_p_echeck_bank_name, sales_order_payment.method AS s_o_p_method, sales_order_payment.cc_debug_request_body AS s_o_p_cc_debug_request_body, sales_order_payment.cc_secure_verify AS s_o_p_cc_secure_verify, sales_order_payment.protection_eligibility AS s_o_p_protection_eligibility, sales_order_payment.cc_approval AS s_o_p_cc_approval, sales_order_payment.cc_last_4 AS s_o_p_cc_last_4, sales_order_payment.cc_status_description AS s_o_p_cc_status_description, sales_order_payment.echeck_type AS s_o_p_echeck_type, sales_order_payment.cc_debug_response_serialized AS s_o_p_cc_debug_response_serialized, sales_order_payment.cc_ss_start_month AS s_o_p_cc_ss_start_month, sales_order_payment.echeck_account_type AS s_o_p_echeck_account_type, sales_order_payment.last_trans_id AS s_o_p_last_trans_id, sales_order_payment.cc_cid_status AS s_o_p_cc_cid_status, sales_order_payment.cc_owner AS s_o_p_cc_owner, sales_order_payment.cc_type AS s_o_p_cc_type, sales_order_payment.po_number AS s_o_p_po_number, sales_order_payment.cc_exp_year AS s_o_p_cc_exp_year, sales_order_payment.cc_status AS s_o_p_cc_status, sales_order_payment.echeck_routing_number AS s_o_p_echeck_routing_number, sales_order_payment.account_status AS s_o_p_account_status, sales_order_payment.anet_trans_method AS s_o_p_anet_trans_method, sales_order_payment.cc_debug_response_body AS s_o_p_cc_debug_response_body, sales_order_payment.cc_ss_issue AS s_o_p_cc_ss_issue, sales_order_payment.echeck_account_name AS s_o_p_echeck_account_name, sales_order_payment.cc_avs_status AS s_o_p_cc_avs_status, sales_order_payment.cc_number_enc AS s_o_p_cc_number_enc, sales_order_payment.cc_trans_id AS s_o_p_cc_trans_id, sales_order_payment.address_status AS s_o_p_address_status, sales_order_payment.additional_information AS s_o_p_additional_information FROM sales_order_payment GROUP BY parent_id ) AS s_o_p ON s_o_p.s_o_p_parent_id = s_o.entity_id

 LEFT JOIN ( SELECT sales_shipment_track.entity_id AS s_s_t_entity_id, sales_shipment_track.parent_id AS s_s_t_parent_id, sales_shipment_track.weight AS s_s_t_weight, sales_shipment_track.qty AS s_s_t_qty, sales_shipment_track.order_id AS s_s_t_order_id, sales_shipment_track.track_number AS s_s_t_track_number, sales_shipment_track.description AS s_s_t_description, sales_shipment_track.title AS s_s_t_title, sales_shipment_track.carrier_code AS s_s_t_carrier_code, sales_shipment_track.created_at AS s_s_t_created_at, sales_shipment_track.updated_at AS s_s_t_updated_at FROM sales_shipment_track GROUP BY parent_id ) AS s_s_t ON s_s_t.s_s_t_order_id = s_o.entity_id

 GROUP BY s_o.entity_id

using GROUP BY without clauses in a subquery forces mysql to do this for every record in the shipment table for each query.with millions of records, this takes minutes instead of milliseconds. the same problems might exist for the other left joins, but in our case fixing the sales_shipment_track subquery was good enough. as the main query already uses a GROUP BY it's safe to remove the GROUP BY in the sales_shipment_track query.
patch
diff --git a/Model/ResourceModel/Document/Order/Entity.php b/Model/ResourceModel/Document/Order/Entity.php
--- a/Model/ResourceModel/Document/Order/Entity.php	(revision b150b5a48c0920e739e12016cddd5acd707f1740)
+++ b/Model/ResourceModel/Document/Order/Entity.php	(date<PHONE_NUMBER>512)
@@ -27,7 +27,7 @@
         $mainEntitySelect = $this->getEntityByStoreIdsSelect($storeIds);
         $taxSelect = $this->appendPrefixToColumnsGroupBySelect("sales_order_tax", "s_o_t", "order_id");
         $paymentSelect = $this->appendPrefixToColumnsGroupBySelect("sales_order_payment", "s_o_p", "parent_id");
-        $shipmentTrackSelect = $this->appendPrefixToColumnsGroupBySelect("sales_shipment_track", "s_s_t", "parent_id");
+        $shipmentTrackSelect = $this->appendPrefixToColumnsSelect("sales_shipment_track", "s_s_t"); // group by is already done on the $mainEntitySelect
         $select = $this->adapter->select()
             ->from(
                 ['s_o' => new \Zend_Db_Expr("( ". $mainEntitySelect->__toString() . ' )')],

side notes

using this mysql GROUP BY quirk to reduce a set of rows to pick a random one entry is considered bad practice as it can lead to non-deterministic behavior. mysql "randomly"-ish picks one of the matching records.
if there is a 1:1 relation for tax & payments (which AFAIK is true in magento) their GROUP BY should be removed too
is it really intentional that just one of the possibly (and realisticly) many sales_shipment_track rows per order is exported?

is it really intentional that just one of the possibly (and realisticly) many sales_shipment_track rows per order is exported?
Yes. Currently that information is not used for any logic. It is merely exported as a sign of "there is tracking".

if there is a 1:1 relation for tax & payments (which AFAIK is true in magento) their GROUP BY should be removed too
I agree.

https://github.com/boxalino/data-integration-magento2/commit/d31ab5ffddc04ea8167ef435d422e2b7540e3f54
your fixes were applied. to be released in tag 1.2.3


Accepting pull requests?

Hi!
I cleaned up the code a bit, made it work with Python3, and made it more pythonic. Would you consider accepting a pull request, or would the effort be not worth it?
I realize this is an academic endeavor, so I can understand if there's not as much interest in active code maintenance ;)
Do let me know!
-Shirish

Sure. Please send it.


Put the configurations in a different file like flutter_intl.yaml or something

It's very annoying to have to deal with the IDE that for every change in the pubspec.yaml file pops up a new window and tries to regenerate the l18n files.

maybe even l10n.yaml

Exactly what I requested here https://github.com/localizely/flutter-intl-intellij/issues/73 unfortunately it was closed due to lack of upvotes.


.prettierignore file is ignored by the plugin

Is your feature request related to a problem? Please describe.
Yes, I have *.css.liquid files that I don't want to be formatted by Shopify VSCODE plugin. Tried using the .prettierignore file with proper pattern, but this doesn't work.
Describe the solution you'd like
Full support for .prettierignore file.

Also having this issue, sad to see this issue is over a year old with no response from anyone.

Thanks for bumping. That one fell through the cracks.


Made functions public

So they can be used in other modules

I'm not sure why you would want to manually call these functions. Could you perhaps explain your use-case?

I'm not sure why you would want to manually call these functions. Could you perhaps explain your use-case?

In Decode.swift you have the following definition:
/// Decode a JWT
public func decode(_ jwt:String, algorithms:[Algorithm], verify:Bool = true, audience:String? = nil, issuer:String? = nil) throws -> Payload {
verify defaults to true but could be false, so you can decode a token without verifying it.  If you do this I think you should have the option to manually call the verify functions at a later stage.
Danny

Alright, I've made these public in https://github.com/kylef/JSONWebToken.swift/commit/e36d4f010af8abd9ee16cb0522926433abd113fc. I wanted to expose these in a different way (on the new ClaimSet) structure instead of stand-alone functions. I've also exposed the date based validations too.
let claims = try JWT.decode("eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.e30.2_8pWJfyPup0YwOXK7g9Dn0cF1E3pdn299t4hSeJy5w", algorithm: .hs256("secret".data(using: .utf8)!), verify: false)
try claims.validateAudience("example.com")
try claims.validateIssuer("fuller.li")
try claims.validateExpiary()
try claims.validateNotBefore()
try claims.validateIssuedAt()


Add UIMenuScroll

Add library UIMenuScroll
Project URL
https://github.com/AlekseyPleshkov/UIMenuScroll
Category
Menu
Description
UIMenuScroll creating menu how on Facebook Messenger on take photo
Why it should be included to awesome-ios (mandatory)
This library allows simple creating slider menu how on Facebook Messenger (In take photo a view). And it's my first library :)
Checklist

[ x] Only one project/change is in this pull request
[ ] Has unit tests, integration tests or UI tests
[ x] Addition in chronological order (bottom of category)
[ ] Supports iOS 9 / tvOS 10 or later
[x ] Supports Swift 4 or later
[ ] Has a commit from less than 2 years ago
[x ] Has a clear README in English

          1 Warning

:warning:
Found 2 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

1688
301
https://github.com/VirgilSecurity/virgil-foundation-x redirects tohttps://github.com/VirgilSecurity/crypto-x

2629
301
http://holko.pl/2016/01/05/typed-table-view-controller/ redirects tohttps://holko.pl/2016/01/05/typed-table-view-controller/

  Generated by :no_entry_sign: Danger

Hey @AlekseyPleshkov, thanks for contributing! Unfortunately I cannot merge your PR because the library is not ready yet.
First, the example project is missing a delegate implementation.
Second, it would be cool if your example project could be more detailed: an idea would be to mimic Facebook Messenger's screen where you got the idea for the lib.
Third, I'd add an example gif instead of a screenshot.
Please let us know if you need any help in improving UIMenuScroll 😉


Fail to perform 'buildPlugin' task for 'Appcode' plugin

Hi, I try to develop plugin for 'appcode' using gradle,
my build.gradle is:
intellij {
    localPath '/Applications/AppCode.app'
    alternativeIdePath '/Applications/AppCode.app'
    type 'OC'
    downloadSources false
}

It can generate a gradle dependency: 'com.jetbrains:ideaLocal:OC-171.4694.27' which contains all of jar in /Applications/AppCode.app/Contents.
the whole progress seems perfect. But when I run buildPlugin, I get the following error:
:instrumentCode
Gradle now uses separate output directories for each JVM language, but this build assumes
a single directory for all classes from a source set. This behaviour has been deprecated and is
scheduled to be removed in Gradle 5.0
:instrumentCode FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':instrumentCode'.
> taskdef class com.intellij.ant.InstrumentIdeaExtensions cannot be found
   using the classloader AntClassLoader[/Applications/AppCode.app/Contents/lib/jdom.jar:
/Applications/AppCode.app/Contents/lib/jgoodies-forms.jar]

I found two jars are missing from the error log:
14:21:19.562 [DEBUG] [org.gradle.api.internal.project.ant.AntLoggingAdapter] dropping /Applications/AppCode.app/Contents/lib/javac2.jar from path as it doesn't exist
14:21:19.563 [DEBUG] [org.gradle.api.internal.project.ant.AntLoggingAdapter] dropping /Applications/AppCode.app/Contents/lib/asm-all.jar from path as it doesn't exist
14:21:19.563 [DEBUG] [org.gradle.api.internal.project.ant.AntLoggingAdapter] Adding reference: java2.loader

so my workaround way is:
cp ~/Downloads/javac2.jar /Applications/AppCode.app/Contents/lib/.
cp ~/Downloads/asm-all.jar /Applications/AppCode.app/Contents/lib/.

It works.
But, please tell me the official solution.

Official solution is NOT to use AppCode as an SDK, you should use IDEA

But I need parse specific PSI struct of Appcode, such as com.jetbrains.cidr.xcode.strings.OCStringsFileImpl, so I MUST use AppCode as SDK, right?
Now I skip instrument task via intellij.instrumentCode=false, So I don't need copy extra jar into Appcode anymore

so I MUST use AppCode as SDK, right?

No, you just should add obj-c specific jar from AppCode distribution as a compileOnly  dependency. Build plugins still must be done with IntelliJ IDEA.


Translate Rewards to Java

contract to be translated:
https://github.com/balancednetwork/balanced-contracts/tree/continuous-integration/core_contracts/rewards

Hey @AntonAndell I’m using ZenHub in GitHub, click this link to join my workspace and see other features available in GitHub or download the ZenHub extension and sign up with your GitHub account.
Posted using ZenHub


Cannot build cubelights with light_omni_shadow_projection_01_seq units

title. trying to build cubemaps with light_omni_shadow_projection_01_seq units causes them to be skipped over, or if they're the only selected units then nothing happens at all. the only way to build cubemaps with them is to change them to light_omni_shadow_projection_01, select them, and then build cubemaps and reload the level without saving the unit changes.

You need to have that unit in your extract folder for it to work. It will also magically get the ability to be edited


ARM support on Linux

Hello, is there any chance you could provide build releases for ARM architectures running linux?
I tried building it myself on a Raspberry pi 3 but the build process gets stuck on rebuilding at step 7. I have no experience in building relevant packages myself so I thought I ask if you got anything relevant in mind before looking more deeply into it.

see https://github.com/sumneko/lua-language-server/issues/891

Please checkout if this works: https://github.com/sumneko/lua-language-server/actions/runs/2102457961


interact-outside utility not working correctly with the shadow dow.

🐛 Bug report
First off, great library! This is really awesome, can't wait for the stable release!! We are thinking of moving from react-aria to zag (since we are building shadow dom components), and so far it's been great working with this library. 💯
So here is a problem: when using the Menu within a shadow dom, I've noticed some strange behaviour with multiple instances.  The first obvious problem is that closing the menu (from clicking outside the menu/trigger) only works on the document outside of the shadow root, any clicks within it are ignored.  I've passed the getRootNode correctly, all the a11l features worked again after that, but any clicking outside was causing unexpected behavior.  This causes a larger problem with multiple menus, since opened menus are not automatically closed when clicking on another trigger.
💥 Steps to reproduce
Do it yourself steps

Load a menu component within a shadow dom
Add a ref to a wrapping div
Set the getRootNode property to getRootNode() {return ref.current?.getRootNode({ composed: false }) ?? document;}
Load multiple instances

Or just go to the sandbox and then

Click on a trigger in the shadow dom
Then click on another (now both with be open)
Click within the shadow dom (nothing happens)
Click outside the shodow dom (both close)

💻 Link to reproduction
Here is a reproduction showing the differences between inside and outside the shadow dom:
CodeSandbox reproduction: https://codesandbox.io/p/sandbox/agitated-chatelet-s4npc0
🧐 Expected behavior
interact-outside should have the click listeners set within the scope of the getRootNode property.
🧭 Possible Solution
I've been digging in the codebase all day but at no avail.  The only conclusion that I could come up with is that event listeners created in the interact-ouside utility are not added to the node passed through the getRootNode property of the machine.  It does call getDocument on an element passed from trackInteractOutside in the menu.machine.ts, but there are no hint of a possible shadow dom selection here.  I've tried hacking my way through it, but I keep running into a dead end 😅
If anyone has an idea what might work I would be open to giving another try and creating a PR, but for now just wanted to see if any more experienced "zaggers" (as opposed to my one day zaggathon) would see an obvious solutions.
🌍 System information

Software
Version(s)

Zag Version
"@zag-js/menu": "^0.3.7", "@zag-js/react": "^0.3.8"

Browser
Chrome (109.0.5414.119 )

Operating System
MacOS Catalina

📝 Additional information
I could imagine that similar issues could happen to other components using the interact-ouside utility, but haven't tried that out yet.

Thanks for this detailed breakdown of the problem @acapro.
I'll have a look at the reproduction and attempt to fix this.
Generally speaking, it'll be great to have a shadow dom sandbox in the repo to verify these issues for any component we create going forward. cc @anubra266

I just pushed a fix for this. We'll release an update shortly.
If the issue persists after upgrading, I'll re-open it.


dlrs_CaseTrigger Interfering with Asset Lookups on Case?

We are having an issue where certain assets are not able to be added to certain cases. It's been difficult to see a pattern to the problems. It is giving us this error:
"When you try and add your asset C-6302-CP, it is not complete with the trigger that was created."
Salesforce Support reports that the error is being caused by the dlrs_CaseTrigger Apex Trigger when we attempt to save the case.
Is there any additional info you can provide regarding this message? How do we make the Case "complete with the trigger"?

@cgerth if possible I would start by disable the DLRS jobs on cases, possibly even removing the rollup triggers. If disabling DLRS fixes it then we can dig deeper, if it doesn't then we know this is not the tree you're looking for.
Please take those steps and let us know.

@cgerth let us know if @aheber suggest helped or if we need to progress here? I will close out in the meantime, but we can for sure re-open. Thanks!


[Core] Enable strict checking of http content-length

We have a big data application heavily relying on the azure blob store to store the data. Unfortunately, we keep running into client-side data corruption issues when reading data from the blob store: sometimes, fewer bytes are returned than expected; sometimes the returned data has the correct length, but data is corrupt.
(I reported an issue in a similar vein already as https://github.com/Azure/azure-sdk-for-python/issues/16723 . This was fixed in the meantime and has already substantially improved the situation for us.)
A potential cause for these issues are prematurely closed tcp connections: If a tcp connection is closed while in the middle of transferring the body of a http response, the azure-core library so far returned truncated data -- rather than raising an exception. This PR fixes this behavior by enabling strict checking of the http content-length. In case of a prematurely closed tcp connection, an exception is raised rather than returning the truncated body.
Note that the aiohttp backend already raised in such case, so no change was required for the aiohttp backend.
The fix boils down to setting urllib3.response.HTTPResponse.enforce_content_length at an appropriate time: when or directly after constructing the HTTPResponse object, but before reading the body.
I chose to do this in a requests hook, as:

setting it in a HTTPAdapter.send (e.g. by adding BiggerBlockSizeHTTPAdapter.send) would also be possible in principle, but it would not cover cases in which RequestsTransport cannot set the adapter as it does not own the session.
setting it after requests.Session.request returns would only cover the stream=True case: For stream=False, the body of the response was already fully read once requests.Session.request returns, so setting enforce_content_length would have no effect.

Sorry for the late reply, I was on vacation.

Thanks @jochen-ott-by for the feedback and contributing.
Could you give us more details about your scenarios?

The scenario is reading the content of many (tens of thousands) blobs from the azure blob store in a big data application. Indeed, this uses stream=True.

e.g. I guess the failure only matters in streaming scenario because if we fail to read the body, we will raise exceptions when deserializing it?

I do not think this is true in general.
This really depends on the serialization format: some formats can reliably detect truncated data, but many formats do not. In particular, for reading "raw blobs", there is (in general) no notion of a "deserialization", so there is no step that would reliably raise an exception. To make it more concrete, think of a small helper tool that copies data (as in: raw blobs) from one blob storage technology to another. For such an application, there is no deserialization that would ever raise.

I ask this because this will help us scope the fix. We need to evaluate if "enforce_content_length" should be an always-on setting by default or we can only enable it in some situations.

I think the sane thing to do here is to always enable it. Note that the aiohttp-based async client already does this, so in this sense, this just brings the requests-based implementation on par with the aiohttp implementation.

I also find https://github.com/streamlink/streamlink/pull/3768/files. Seems like that can also solve the problem, right?

This seems to also address the same issue, yes. However, it works by monkey-patching third-party (urllib3 / requests) classes. Monkeypatching does not compose well: if several libraries to "patch" via such a mechanism, at most one of them will succeed. Also, there might be (subtle) incompatibilities, e.g. if other parts of the application rely on the unpatched behavior.
I would therefore strongly advice against using monkeypatching in a library like azure-core that is typically part of a much larger applications, and azure-core should avoid making too many assumptions about these applications. (Monkeypatching can be acceptable for self-contained applications such as streamlink, as they have different trade-offs than libraries.)

@jochen-ott-by Thanks for the information. We will have a discussion with our architect how to add the check.

@jochen-ott-by in terms of "Note that the aiohttp-based async client already does this", could you help point me where aiohttp implement this?
It looks to me aiohttp only check length when we call readexactly.
https://github.com/aio-libs/aiohttp/blob/master/aiohttp/streams.py#L425-L438
Did I miss anything?

@jochen-ott-by in terms of "Note that the aiohttp-based async client already does this", could you help point me where aiohttp implement this?

This PR adds a test that shows the behavior I described:
https://github.com/Azure/azure-sdk-for-python/pull/20412/files#diff-524251c35211f89b7517d30ac4f3eb5375189356582eed96d3e23c50769c6868R47
In aiohttp code, this check is quite deep, but done somewhere here:
https://github.com/aio-libs/aiohttp/blob/09ac1cbb4c07b4b3e1872374808512c9bc52f2ab/aiohttp/http_parser.py#L707
This code path is active in case "length" is set, which is usually the case if the "Content-Length" header was set; see
https://github.com/aio-libs/aiohttp/blob/09ac1cbb4c07b4b3e1872374808512c9bc52f2ab/aiohttp/http_parser.py#L319-L335

It looks to me aiohttp only check length when we call readexactly.
https://github.com/aio-libs/aiohttp/blob/master/aiohttp/streams.py#L425-L438
Did I miss anything?

readexactly and content-length checking are two very different things: the former is an API to get data, the latter is a protocol level check. So they have not much to do with each other.

Is there any update here? I can add that we did deploy this change in production, it did solve the issues we observed before. I therefore believe this is a robust fix that really improves real-world usage.
I again want to remind you that without this fix, we see data corruption issues when using the azure blob store via this library. I think it deserves some priority.

@jochen-ott-by Thank for the follow up.
Your PR looks great.
Well, we need some small changes based on your PR because we want to unify the error and make it inherit from AzureError to be less breaking.
The new PR can be found at #20888.
We will keep you posted.
Thanks again for your contribution.


Allow system indices when domain is index create block

Is your feature request related to a problem? Please describe.
During the cluster write block, sometimes we have seen the opensearch-dasboards is not able to work due to kibana index being red.
For background, kibana tries to creates “.kibana*” indices  in two cases, while boot up or index migration. Index migration is done during version upgrade. For ex: if current index is “.kibana_1” so after version upgrades new index is created with name “.kibana_2”  and so on.
However if there is cluster create-index block, opensearch-dashboards index creation fails.
Below are logs found in kibana.log
{
    "type": "log",
    "@timestamp": "...",
    "tags": ["info", "savedobjects-service"],
    "pid": ***,
    "message": "Creating index .kibana_-190122424_cognitouswest2qt8dmhfaysnuser_2."
}
{
    "type": "error",
    "@timestamp": "...",
    "tags": ["error", "migration"],
    "pid": ***,
    "level": "error",
    "error": {
        "message": "[index_create_block_exception] blocked by: [FORBIDDEN/10/cluster create-index blocked (api)];",
        "name": "Error",
        "stack": "Error: [index_create_block_exception] blocked by: [FORBIDDEN/10/cluster create-index blocked (api)];\n ......"
    },
    "message": "[index_create_block_exception] blocked by: [FORBIDDEN/10/cluster create-index blocked (api)];"
}

Describe the solution you'd like
The idea is to create a dynamic setting which can used to specify the system indices to be skipped when the cluster is write blocked. The setting will be set to false by default which would mean no indices will be allowed to skip the index create block. The setting will be like this when applied:
cluster.blocks.create_index.allowed_sys_indices_pattern: [".kibana"]

In the index create block we will check if the index is of the following pattern and we will skip the index create block for these cases.
Describe alternatives you've considered
We can also create a new setting for allowing all the sys indices to skip the index creation block. The setting will be like this:
cluster.blocks.create_index.allow_sys_indices: True

The major disadvantage of this is that this can cause the domain to go down if the size of the system index is too big since we are not filtering the system index here.
Additional context
Add any other context or screenshots about the feature request here.

Ideal solution would be to migrate from hidden index to system index and have this support added for system indices(and not hidden indices): https://github.com/opensearch-project/OpenSearch/issues/3942

There is already an effort going on to identify the system generated indices using system index plugin: https://github.com/opensearch-project/OpenSearch/issues/9239
After this is done, we should be able to distinguish between user & system indices which can be used for write block validation logic.


[BUG]: Admin | Sync Template v3 (Apps) issue - "admin_app With Id = xxxxxx-xxxxx-xxxxxxx-xxxx Does Not Exist"

Describe the bug
The COE Starter Kit Admin | Sync Template v3 (Apps) flow always returns the following exception on several apps.
The Get Apps as Admin connector extracts several apps GUIDs that the Get Power App connector is not able to find and return the following exception :
{
"error": {
"code": "0x80040217",
"message": "admin_app With Id = 4b690dd0-42a0-4937-ab87-9664a711ce5f Does Not Exist",
<EMAIL_ADDRESS>"Plugin/Microsoft.Crm.ObjectModel.CustomBusinessEntityService",
<EMAIL_ADDRESS>"b2d7683e-947a-eb11-b1ac-000d3a23c6ad",
<EMAIL_ADDRESS>"1",
<EMAIL_ADDRESS>"0cb7acd1-45bf-4e14-b076-571dc17ead0b",
<EMAIL_ADDRESS>"System",
<EMAIL_ADDRESS>"System",
<EMAIL_ADDRESS>"ClientError",
<EMAIL_ADDRESS>"ObjectDoesNotExist",
<EMAIL_ADDRESS>"404",
<EMAIL_ADDRESS>http://go.microsoft.com/fwlink/?LinkID=398563&error=Microsoft.Crm.CrmException%3A80040217&client=platform,
<EMAIL_ADDRESS>"admin_app With Id = 4b690dd0-42a0-4937-ab87-9664a711ce5f Does Not Exist"
}
}
Component (please tell us which flow or app you are experiencing issues with):

Core
API version 2020-07-01
Admin | Sync Template v3 (Apps)

To Reproduce
Steps to reproduce the behavior:
The App GUID 4b690dd0-42a0-4937-ab87-9664a711ce5f reproduces the error.
You can reproduce the issue also with the following PowerShell commands:
Get-AdminPowerAppEnvironment  |%{
Get-AdminPowerApp -EnvironmentName $_.EnvironmentName | %{
Write-output “powerapps data”
}
Expected behavior
No Exceptions, the Get Apps as Admin should retrieve only valid apps
Screenshots

Additional context
Add any other context about the problem here.

Hello. The action Get Power App is a check to see if the app already exists in the inventory. As you can see, the failure is caught by the next action Set isNewToCoE to true. This is an expected failure for new items to the inventory.
If the flow failed on this iteration (565) then it failed later down in the flow. Can you please look for the uncaught failure?

Hi,
I attached the json file downloaded
thanks
Output.txt

Unfortunately you have hit a product bug in which Get Apps as Admin is returning deleted apps, while later calls to get at that app fail (correctly) in that the app no longer exists.
You can validate that this is the case outside of the toolkit using the attached flow.
Simply select the environment from your repro above, save, and run the flow. Then you will have to create a support ticket for them to clear the cache in your tenant.

Here is that flow for you to use.
ProductBug-GetAppfails-TheresponseisnotinaJSONformat.zip
Closing issue as there is nothing the toolkit can do to help

The productbug flow fails as well when running here.

Please create a support ticket with this flow as it shows the repro in a simple case without the toolkit involved.
Thanks for using CoE


Sweep: print hello world

Print "hello world" under the main method in "/backend/app.py.
create a branch called "sweep-dummy" off of the latest "next-js" branch before starting the task. good luck!

Checklist

[X] backend/app.py

Under the main method (i.e., under the condition if __name__ == "__main__":), add the line print('hello world').

there's only one app.py file in the backend/ directory

i saw your pr. good job. i closed it. sweep, can you close this github issue

@sweep-ai


Mixer of Bormatec Maja not working in Manual Override

While testing the v1.6.5 of the PX4 I found the following issue:
During normal flight operation everything works as expected. In case of an FMU crash in the manual flight mode the OVERRIDE flag is correctly set in the px4io. However, in this mode the outputs for MAIN 1, MAIN 3 through MAIN 5 are correctly set. But the MAIN 2 (right aileron) output remains always at 1500 which corresponds to a zero deflection.
This behavior can be solved by removing the lines for the airbrakes (L24, L29), or changing the index from 6 to a value lower than 4. However, I was not able to identify why an index value of 6 or higher breaks the mixing.
See also this topic in the forum.

I'm not sure what the root cause is, but we can safely remove the airbrakes entries from the mixer.

Thanks for the fix!

@LorenzMeier
This was more of a temporary fix to the issue as somebody might want to use the flaperons or any other input with an control group index > 5 in the future.
I do not really know the px4io code but I think the issue is caused by the px4io during loading or applying the mixer. Could maybe someone with more knowledge of px4io code trace down the cause of this issue?


Add function to tsdb.point to get line-protocol string in the correct…

… units
@jwilder @otoolep @corylanou

I think it would be much better to have SetPrecision convert the given string into a time.Duration. Then when you're working with the timestamp to output it in the string, instead of doing division, use .Round(p.Precision) where precision is a duration.
It's cleaner and I think more readable.

Can we see some unit tests? Would that make sense?

@otoolep updated PR with unit tests and made some of a commenting changes you suggested

@pauldix I'm not sure this API is working exactly as intended, so I'm going to have to leave in the division as it is right now, I'll send around an email for a separate discussion about what we should do about the write API

+1, though I think @pauldix may still have some feedback pre-merge.


Request: share stats with friends

Quickly: Thank you for this indispensable software.
The other product I use frequently is arena mastery, which has a "Share these stats with friends" link. I'd love to be able to do the same with trackobot.

This is something I'm still planning to do.


Normalize the th element

Normalize the th element. I have specifically observed that th elements sometimes show content vertically aligned in the middle. th elements are used for all columns, so they should be normalized to be vertically aligned to the top.

I have now cleaned up the commit. Any chance this might be merged?

Thanks for your contribution to Foundation Emails.


configure_outputs param missing

Hi @tfhartmann I think the merge was missed from your feature branch that allowed to make outputs.conf optional via configure_outputs param as per closed issue https://github.com/huit/puppet-splunk/issues/54
Im not seeing this parameter in init.pp or params.pp in master or 1.7.0 tag.
Thank you

Ah shoot your right, I'll make sure it passes tests then cut another release
https://travis-ci.org/huit/puppet-splunk/builds/69919382

Awesome thank you very much!

@aamerik just confirming, the second forge release on Jul7 resolved this didn't it? (don't want to close if I didn't cut the release like I said I was going to! )


fix: nav menu groups can be selected without action/href

🐛 Bug Report
The indicator of a selected nav menu item jumps to non-selectable elements like FluentNavMenuGroups without href/custom action and back to the actual selected element, when the groups are clicked.
🤔 Expected Behavior
FluentNavMenuGroups without rhef/custom action should not be selectable. The indicator for selected elements should remain on the selected element, when a nav group element is clicked.
💁 Possible Solution
Maybe add a parameter to nav items to prevent them from being selectable.

The FluentNavMenuGroup is basically a 'dressed-up' . Clicking and selecting such an item and raising a custom ('selectchanged') event for that is done on the web component side and is out of our control. Changing this would require a change in the way the works. You can raise an issue in the fluentui web components repo but I think it will take a while to see such a change being implemented (if at all).
Only thing we can do on 'our' side (which we do already) is to detect the invalid action and revert it.


Requires react-router to use the Select component.

Hey, I wanted to use the Select component, but it seems like a single component cannot be used without (at least) react-router.
Error:
ERROR in ./~/react-responsive-ui/build/menu.js
Module not found: Error: Cannot resolve module 'react-router' in /Users/jameskraus/projects/orgcrmapp/node_modules/react-responsive-ui/build
 @ ./~/react-responsive-ui/build/menu.js 47:19-42

My only import statement:
import { Select } from 'react-responsive-ui';

I have rewritten the <Menu/> component and removed react-router out of it.
Try the latest version.