arch64 release

Feature request

What problem does this feature solve?
If u use an RPI4 with arch64 u can't use HyperHDR. I compiled it on my PI like in your Guide, and it works. Would be nice to have it as Official Release from you
What does the proposed API look like?
How should this be implemented in your opinion?
Are you willing to work on this yourself?

Hi
Yes, I know the issue. The main problem is current github action scripts and github 500MB limitation on storage for free accounts. Last release took around ~460MB and ordinary push action took ~200MB. And there are some other my repos that take space also. I don't know what happen  after adding arch64 and reaching reach 500MB. At some point migration to paid plan could improve the situation.
BTW I doubt there will be much benefit of using HyperHDR on arch64 system. It's quite a different story than for example Windows 32 vs 64. int64_t data type that is fundamental in the fast video processing is available natively also on 32-bit arm v6/7 OS. Maybe memory bandwidth/access is improved... Must test it some day ;)

I need the arch64 for other things, just want to let hyperhdr run on the same pi. Maybe u can provide me with the info how to bundle in a dpk when I build for arch64. So I can install it like one of your releases?
Thanks for your great work and best regards

I understand. If you managed to compiled the application from sources then you can build installation packages executing cpack at the end or modify build with make -j $(nproc) package (than will compile & build packages at once). Scripts for cpack should be prepared by the cmake during configuration automatically if the rpi target is detected.

Thanks it worked perfectly. Maybe the community could take over the cost for Github. I would like to contribute a part to it.

Hi! I was looking at the Github pricing page (https://github.com/pricing), and as far as I can tell, the 500MB limit does not apply to public projects:

500MB of Packages storage
Free for public repositories

Hi
That's not our only repo. Of course, all the developing in the end lands on HyperHDR site when it's finished and ready for release or beta testing. Due to amount of changes and new features it's not ready for that phase now. So the problem exists for the limit and free account (not only the storage but also git action service limit: each version consumes its time for compiling). And now we just hit the operational limit and we won't increase it further: that's for sure, at least for our current model.
What can we provide it's a change for test in the next release: based on download statistics x64 RPM installers will be removed and aarch64 will be provided. So space limit will be obey but it increases a problem with our github action spending anyway already... so we will see how it will work for us and for users.

Implemented in version 17 (beta for testing).
If you have some time, please test it. Reopen the issue if needed.
https://github.com/awawa-dev/HyperHDR/releases/tag/v<IP_ADDRESS>beta


Oracle Database: please remove volume from base image

Base Oracle DB images container-registry.oracle.com/database/enterprise:<IP_ADDRESS> and container-registry.oracle.com/database/enterprise:<IP_ADDRESS>-slim have the following volume mount declared:
VOLUME ["/ORCL"]
Because there is no way to remove or unset a volume when extending an image, this basically prevents me from being able to create an image pre-loaded with a test or dev database.
Even if you unpack, setup, configure, and load a database, it just disappears after that Dockerfile line ends.
There are no benefits to declaring a volume line in a dockerfile.  Even if you do, the client still has to declare a volume anyway to make any use of it (for example, by declaring it in a run statement or in their docker-compose.yaml file). And removing this line will have no effect, because the client can still create a volume anytime they want to be putting it in their run statement or docker-compose file.
Can you please remove the volume mount declaration from the base image?

After a while of discussions, etc. I have followed up on this on the Docker Forum: https://forums.docker.com/t/why-use-the-volume-instruction/55420

I was about to write up another issue, but luckily did a search instead.
I see a couple reasons why the VOLUME instruction should be removed.

one can not unset the VOLUME instruction in inheriting dockerfiles. See: https://github.com/moby/moby/issues/3465
DB images are often used with baked in data(integration testing for example)
Even if prebaked data is not needed, first start-up is slow.
When just running the image(docker run), it doesn't even provide that much data-safety for someone who is new to docker, as the container will start with a new anonymous volume when docker run is executed again. (+ not being able to find the correct volume, as said before)
if disaster recovery is needed, one can docker cp files out from a stopped container.
(subjective) it's better to inherit from a common base image/dockerfile and bake data by extending the image, instead of having many forks of the original Dockerfile.
(subjective) People will stumble on this issue, like https://github.com/moby/moby/issues/3465#issuecomment-371186059, I just spent the better part of a night not understanding why my data isn't persisted properly.

I guess the Dockerfile volume instruction is a left-over from a time when docker handed volumes differently and didn't have named volumes yet?
So i'd like to show support towards removing the VOLUME instruction from DB dockerfiles here.

I would like it if the image can be built without any volume.
So it is possible to build an image that contains a completely preinstalled instance. Especially for testing it would be nice not to wait until the instance has been created.
I think it would be better if the VOLUME were optional at least for the Dockerfiles. The VOLUME could be added at a separate stage at the end of the Dockerfile:
https://docs.docker.com/develop/develop-images/multistage-build/#stop-at-a-specific-build-stage

This unremovable VOLUME also hurts me while trying to create a database instance during docker build.
There's a simple workaround possible for the VOLUME-issue:

copy content of /opt/oracle/oradata at end of db creation to a backup dir
link the two dirs in /opt/oracle/oradata to the saved content as first step of container creation

The Dockerfile and two wrapper-files for docker build and run I attach here as zip
files.zip
:

@simpss has clearly listed the problems related to having a VOLUME in the Dockerfile and there does not seem to be any reason to keep it.
@brunoborges you said

I'd say you should simply get the original Dockerfile, and edit it to your own needs. Most users do want VOLUME.

Could you please clarify why most users would want or need VOLUME in the Dockerfile?

@brunoborges has nothing to do with this repo any more. It's up to @gvenzl now.

The VOLUME and EXPOSE instructions got removed.


feat(guardian-prover-health-check): gp address routes instead of id

@cyberhorsey there seems to be a lint error

@cyberhorsey there seems to be a lint error

yeah I'll fix this pr and deploy it to internal in a bit I'm taking a breather


feat: support custom CA

Any plans on supporting this
Passing a custom CA would make it easier to spin up clusters using the same CA (and thus not needing to have a new kuber config except for the api url).

I’ll look at it, I already implemented some secrets so it should be pretty easy.

It should look something like this https://github.com/eddycharly/terraform-provider-kops/pull/362

Tested the branch and it seems to work just fine!

Thanks for trying it out.


Feature Log combined with alarm for webhook？

Please answer these questions before submitting your issue.

Why do you submit this issue?

[ ] Question or discussion

[ ] Bug

[ ] Requirement

[x] Feature or performance improvement

Please describe your requirements or improvement suggestions.
Feature Log combined with alarm for webhook ，i want one feature,webhook alarm log details

I am not following what do you mean. What is Feature Log combined?


DLC versions

First of all, many thanks for this great project!
The file titles.US.en.json has been recently removed. Although the commit message suggests to switch to another file, I cannot find any other way to accurately check the latest version of DLCs:

versions.json does not contain DLCs.
cnmts.json contains DLCs but versions are outdated (example: 0100E95004039001 has v131072 while the latest is v196608).
US.en.json contains DLCs but versions are always null.

Do I miss something? Any help would be really appreciated!
Thanks!

I just added versions.txt for you, this has the DLC versions in it.

you should use nut to generate the json file you are accustomed to.  just run nut.py -s on a cron job, every 2 days it will auto download the latest language jsons then rebuild titledb/titles.json which is the same file as titles.US.en.json.
alternatively, you could clone the titledb repo into nut, do git pulls daily and then run "nut.py --import-region US --language en" to regenerate the titles.json.
titles.json flattens all of the language jsons into a single json.  if you read US.en.json, you will only get US titles.

This is exactly what I needed, thanks a lot!
I use your data in custom bash & jq scripts, so it was super easy for me to adapt to the new format :wink:.
Will this new file be regularly updated like the other ones in the future?

This is exactly what I needed, thanks a lot!
I use your data in custom bash & jq scripts, so it was super easy for me to adapt to the new format 😉.
Will this new file be regularly updated like the other ones in the future?

That file is updated daily.  Cronjob didn't run last night.


Website favicon update.

Feature request-
new favicon of latest logo.

/assign

Assign this to me under GSSOC 21

/reviewed

there is no gssoc label on this issue


Type aliases impossible to use with declaration: true

It's not a bug, I believe, but it's an ergonomic issue.
TypeScript Version:  2.1.6
Code
state.ts:
export interface State {
  field: number
}

alias.ts:
import { State } from './state.ts'
import { Dispatch as ReduxDispatch } from 'redux'

export type Dispatch = ReduxDispatch<State>

actions.ts
import { Dispatch } from './alias'

export function action() {
  return (dispatch: Dispatch) => { return; }
}

Expected behavior:
No errors. When I compile the example with declaration: true, it should generate:
actions.d.ts
import { Dispatch } from './alias'
export function action(): (dispatch: Dispatch) => void

Actual behavior:
Error
Return type of exported function has or is using name 'Dispatch' from external module "./node_modules/redux/index" but cannot be named.

The problem here is that I can't use the type alias to simplify my code, I should operate only with "origin" library types. I see an ergonomic issue here, because I should repeat myself and avoid useful type aliases.

Should be fixed in latest.


Crash in cmdGmXmlHttpRequest

It seems that this is the most popular crash on AG for Mac at the moment:
https://sentry.adguard.com/adg/adguard-mac/issues/17042/

core/pull-requests/1019

Testing instructions:

enable assistant in adguard
install web of trust userscript extension
surf the internet for some time - adguard is expected to work stable


Force Drop

   MongoDB\Driver\Exception\CommandException  : a collection 'funder.batches' already exists

  at /Users/narwy/Desktop/GitHub/php-app/vendor/mongodb/mongodb/src/Operation/CreateCollection.php:205
    201|         if (isset($this->options['writeConcern']) && ! \MongoDB\server_supports_feature($server, self::$wireVersionForWriteConcern)) {
    202|             throw UnsupportedException::writeConcernNotSupported();
    203|         }
    204|
  > 205|         $cursor = $server->executeWriteCommand($this->databaseName, $this->createCommand(), $this->createOptions());
    206|
    207|         if (isset($this->options['typeMap'])) {
    208|             $cursor->setTypeMap($this->options['typeMap']);
    209|         }

  Exception trace:

  1   MongoDB\Driver\Server::executeWriteCommand("funder", Object(MongoDB\Driver\Command), [])
      /Users/narwy/Desktop/GitHub/php-app/vendor/mongodb/mongodb/src/Operation/CreateCollection.php:205

  2   MongoDB\Operation\CreateCollection::execute(Object(MongoDB\Driver\Server))
      /Users/narwy/Desktop/GitHub/php-app/vendor/mongodb/mongodb/src/Database.php:209

Using:
module:migrate-refresh Funder
Then
module:seed Funder
Doesn't drop the current collections using MongoDB, Everything else seems to work fine, but even using the --force tag doesn't have any affect either.

Hi,
As you can see here:
https://github.com/nWidart/laravel-modules/blob/master/src/Commands/SeedCommand.php#L143-L145
The force flag is directly sent to laravel. I would check this with laravel.

Hey,
If I do:
php artisan db:seed --class="Modules\Funder\Database\Seeders\FunderContactsTableSeeder" --force
It works fine?

What about the module:migrate-refresh what command is that running to pass params?

is that a question?
If so you could try to see what it doesn't in the module seed command.

You can view the code of every command.

Can't find anything referencing to migrate:fresh not refresh?

What is this then? https://github.com/nWidart/laravel-modules/blob/master/src/Commands/MigrateRefreshCommand.php

https://laravel.com/docs/5.8/migrations
php artisan migrate:fresh and php artisan migrate:fresh --seed
There's no support for fresh then?

There's no fresh command in this package no.

Are we okay with me doing a PR for it?

That'd be nice yeah. 👍

I'll close this as there hasn't been a reply in a while, feel free to comment if needed.


Code clean up

I'm currently working through the code. I'm 'starting' to get an overview of what is going on. :)
One question: Is this file essentially the same as this package from @aldeed?
Could that be thrown out and replaced by the package (which seems to have some test)?

I think it is - It would make sense to use Erics separate package (we can hope that it would be migrated into meteor core at some point)

I agree we can switch to depending on the package. Probably did that before I created the package.

I already resolved this in https://github.com/CollectionFS/Meteor-CollectionFS/commit/dd3e57f72581ecb61b69fdd85e42414350574373. It's now using https://github.com/aldeed/meteor-http-extras.


Devtools slowing down data updates

Version
6.0.0-beta.7
Browser and OS info
Chrome 89.0.4389.82 / MacOS 10.15.7
Steps to reproduce
I have created a project with Inertia.js   Laravel   TS   Vue 3. When enabling Vue Devtools any update to the data object gets delayed. I have tried with both the Options API and the Composition API. For example, when typing something into an input, the letters appear after a delay. But without Devtools, it's fast as. I tried with Vue 2   Devtools 5 but that was fast.
I added all the lifecycle hooks to see what was happening and saw that a couple of them were fired when updating the data. I suppose this is the normal behavior but here is a gif of the hooks getting triggered: https://gyazo.com/7ac63a61f7cd4e4a50ec7aafc2ee7e5a
Here is a simple example component:
<template>
  <input
    v-model="text"
    type="text"
  >
</template>

<script lang="ts">
  import { defineComponent, ref, onBeforeMount, onMounted, onBeforeUpdate, onUpdated, onBeforeUnmount, onUnmounted, onErrorCaptured, onRenderTracked, onRenderTriggered } from 'vue';

  export default defineComponent({
    setup() {
      const text = ref('');

      // ... all lifecycle listeners here

      return { text }
    },
  })
</script>

What is expected?
Devtools not slowing down any input
What is actually happening?
Typing and updates to data is delayed

I just realized that the update events shouldn't get triggered just by updating the data. The update event is fired when the DOM updates according to the docs. So maybe this is an issue in Inertia.js then?


gemlite integration in torchao

Summary:

integrated gemlite kernels from https://github.com/mobiusml/gemlite
updated kernel wrappers to work with compile (needed to change acc_dtype to torch.dtype equivalent and added basic op/fake_op registration)
added bs>1 support to llama benchmark

on A100 results are not great for the kernel, likely needs further tuning before further integration makes sense.

Test Plan: benchmarks.sh
Reviewers:
Subscribers:
Tasks:
Tags:

I see that you removed the pruning config, that will produce incorrect results for group-sizes lower than 128

its there now, needed the custom op support stuff


Unsoundness bug with recursion and shortcircuiting

Here is a minimized version of an example that verifies, but it shouldn't. It basically says that searching an element only in the head of a list is the same as searching the whole list.
val search : x:int -> l:(list int) -> Tot (r:bool{r <==> mem x l})
let rec search x l =
  match l with
  | [] -> false
  | n :: l' -> x = n || (false && search x l')

(* this equivalent thing fails as it should
val search' : x:int -> l:(list int) -> Tot (r:bool{r <==> mem x l})
let rec search' x l =
  match l with
  | [] -> false
  | n :: l' -> x = n || (search' x l' && false)
*)

(* this equivalent thing fails as it should
val search' : x:int -> l:(list int) -> Tot (r:bool{r <==> mem x l})
let search' x l =
  match l with
  | [] -> false
  | n :: l' -> x = n
*)

(* this equivalent thing fails as it should
val search' : x:int -> l:(list int) -> Tot (r:bool{r <==> mem x l})
let rec search' x l =
  match l with
  | [] -> false
  | n :: l' -> if x = n then true else (if false then search' x l' else false)
*)

F* is as unsound as it gets at the moment. Today, I've run over one more dead wrong example that type-checks. I've minimized it to this statements about any list having any property you like (note, one would expect this to hold only when all returns true).
val all : p:(int -> Tot bool) -> xs:list int ->
            Tot (r:bool{forall x. mem x xs ==> p x})
let rec all p xs =
  match xs with
  | [] -> true
  | x :: xs' -> p x && all p xs'

We need to fix this before releasing the binaries for the course. I don't want this kind of homework solutions:
val ff : u:unit -> Lemma (False)
let ff u = ignore (all (fun _ -> false) [42])

Working on minimizing this further if possible.

After inspecting the Z3 queries on bug154.fst, the bug comes from an hypothesis (= (BoxBool false) (BoxBool true)) at line 24,090. Inspecting further...

My guess is that the bug is in short-circuiting and.

That was my first idea, but the function that flattens and simplifies and in tosmt/term.fs is correct.

Type-checking of short-circuiting operators is bogus at the moment. As far as Chantal and me understand, in order to type-check b1 && b2 F* checks that b1 and b2 are booleans, and then tries to prove the post-condition assuming the result is b2 and in an environment in which b1 holds. For this to be correct, one should also prove the post-condition, assuming the result is false and in an environment in which not b1 holds. Basically b1 && b2 should be equivalent to if b1 then b2 else false not to match b1 with true -> b2 (an incomplete pattern match!). I also don't undestand why &&  and || are not simply desugared to the correct ifs (or matches).

Basically, I was mistakenly treating short-circuiting for WPs in the same way as i was short-circuiting well-formedness conditions that were just in Type. This was blatantly wrong ... Sorry! In effect, I now generate WPs for && and || that corresponds to their desugaring as conditionals.

Thanks a lot for fixing this Nik!


Edit item in cart

Feature or Bug?

[x] Feature
[ ] Bug

Feature
Edit item already in cart
What would you like?
For items that can have ingredients support clicking them in cart for editing
How should it work?
Click item in cart and be presented with IngredientModal

#34 Has this feature


add prettier, husky, and lint-staged

Looks like yarn.lock was not updated. And the lint-staged config does not run eslint --fix. Also I prefer eslint-plugin-prettier. Formatting, linting can be done through eslint itself.

Thanks you for the PR @viankakrisna,
I decided to merge #18 for now.
I believe it will be wiser to add prettier in a PR of its own.

@asfktz Would be simpler if you set it up to avoid conflicts. The repo is being updated quite frequently as of now. You could also customise it to your preference.

Ok, I will.


remove useless conversions

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors r+

:pushpin: Commit af9a36dfe4ed2f14b70842fecefc74f1ff332640 has been approved by Eh2406

:hourglass: Testing commit af9a36dfe4ed2f14b70842fecefc74f1ff332640 with merge 9b34f9a6993a9075b00ba901179107232c9322aa...

:sunny: Try build successful - checks-actions
Build commit: 9b34f9a6993a9075b00ba901179107232c9322aa (9b34f9a6993a9075b00ba901179107232c9322aa)

@joshtriplett i think this should be ready for review.
whopping great change that it is!

@bors r+

:pushpin: Commit a6d3fb0c611fed62be0fcc0bda959e4fb7981541 has been approved by ehuss

:hourglass: Testing commit a6d3fb0c611fed62be0fcc0bda959e4fb7981541 with merge bcd7fba64f8d3dcad5229ec75faeab018ec09c42...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing bcd7fba64f8d3dcad5229ec75faeab018ec09c42 to master...


[WIP] Dynamic list refactor

Will need to be merged after #2355.
This PR removes all mentions of DialogFieldDynamicLists and uses the regular drop-down list instead, with the ability to make it dynamic.

After talking with @gmcculloug, realized I need to include a migration for the old DialogFieldDynamicList objects to be changed to DialogFieldDropDowns with the dynamic flag enabled, so I've marked this WIP for now.

@eclarizio this is nice

@eclarizio So the PR looks good and I was able to test it out with existing dialogs which got properly converted.  Where I am running into an issue is importing dialogs that include the old dynamic list field type.  Can we detect and modify those during import?

@gmcculloug Yeah, good catch, I didn't even think about that. Importer has been updated to handle the old dynamic lists now. :+1:

Verified changes fixed the import issues.  Looks good.


The code displayed on this page does not retry as indicated

The code showed in item "4" on the "Open and edit the solution" section does not work as indicated. In case a 429 is returned by keyVault, the code won't actually retry as suggested. That's because the try/catch block is outside of the loop. In addition, the variable "waitTime" is not used anywhere in the code.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 87e2cd41-2a63-d083-22e0-cf5f75fb4b07
Version Independent ID: e82a144d-f425-d6ed-9f7d-bd4b5f395e45
Content: Tutorial - Use Azure Key Vault with an Azure web app in .NET - Azure Key Vault
Content Source: articles/key-vault/tutorial-net-create-vault-azure-web-app.md
Service: key-vault
GitHub Login: @prashanthyv
Microsoft Alias: pryerram

@grlima Thanks for the feedback! We are currently investigating and will update you shortly.

Hi @prashanthyv @YutongTie-MSFT @grlima
Has this problem been fixed?

Yes it has

@prashanthyv so the above code sample now works as expected? I just tried it and it appears to  get the secret twice which doesn't seem right. It gets it once from the original getAsync then gets it again in the do while loop.

@developercreativepos - Are you looking at this page - https://docs.microsoft.com/en-us/azure/key-vault/key-vault-ovw-throttling ?

No sorry, this page https://docs.microsoft.com/en-us/azure/key-vault/tutorial-net-create-vault-azure-web-app

Thanks. Will fix that

Awesome, thank you. Do you have an ETA for when it will be updated?

Is there a way to subscribe to this issue, either on Microsoft or GitHub?  Maybe this will subscribe me just by posting, but I know that's not ideal.

@JohnBoncek - The fix should be available by tomorrow

Hi guys, well the variables: retry and retries are not being used in this tutorial (https://docs.microsoft.com/en-us/azure/key-vault/tutorial-net-create-vault-azure-web-app), there are no retries here.

@barclayn do you know the status on this tutorial?

Guys, I also do not understand how this code works. Unused functions, bogus retry variables.
Better remove than keep and confuse.

Code is updated with retries. #please-close


Bump hetznercloud/hcloud provider to v1.38.2 version

Bump hetznercloud/hcloud provider to v1.38.2 version
Running apply with the old provider throws the following error. Bumping to latest provider fixes the error
│ Error: more than one Image found for name debian-11

Looks good to me, thank you @ThisIsQasim !
Could I maybe bug you to file a similar PR to our documentation repository, too? It's here: https://github.com/flatcar/flatcar-docs/blob/main/docs/installing/cloud/hetzner.md
That Hetzner documentation duplicates some of the terraform code because it does a step-by-step walkthrouugh through the code. The docs example therefore has the same issue.

Could I maybe bug you to file a similar PR to our documentation repository, too?

Done. https://github.com/flatcar/flatcar-docs/pull/302/files


Add config relative path environment variable

🎉 New feature
Closes #337
Summary
Before trying to load the --config path, check environment variable GZ_GUI_RESOURCE_PATH.
This allows relative config paths with respect to those environment variables to be specified after --config.
Implementation similar to ign-gazebo https://github.com/ignitionrobotics/ign-gazebo/blob/b825c27841f38c1df06cd053f70f9836786b590d/src/cmd/cmdgazebo.rb.in#L393-L409 but in C++ instead of Ruby.
Questions:
- Do we want both variables? Are those the final names we want? The ign-gazebo env var name is IGN_GAZEBO_RESOURCE_PATH. So it might be more consistent if we call it IGN_GUI_RESOURCE_PATH.
From the description of the original issue, maybe we only want IGN_GUI_CONFIG_PATH and not the *RESOURCE* variable?
- Is there a way to test at the ign gui level that automatically close the GUI?
Currently, the added unit test brings up the GUI via popen, but doesn't close it. That's not going to work as an automated test, as it requires manual closing of the window. The way ign-gazebo does it is by running headless (-s), which ign-gui doesn't have a flag for. Other ign-gui tests that automatically close the window initialize Application or MainWindow in the code. Here, we are testing the Ruby code at the ign command a level above, so we don't have those objects.
Should we just not test the valid cases? Only the valid cases bring up the GUI. The invalid cases just print a message and exit.
Test it
Environment variable should show up in help message:
$ ign gui --help
...
Environment variables:
  GZ_GUI_RESOURCE_PATH    Colon separated paths used to locate GUI
 resources such as configuration files.

Unit test:
./build/ignition-gui3/bin/UNIT_Application_TEST

Manual test:
Test with config files in examples/config/.
For all following commands, replace environment variable with path on your machine.
Valid environment variable and file, should show color themed GUI:
GZ_GUI_RESOURCE_PATH=/path/to/ign/src/ign-gui/examples/config ign gui --config style.config

Invalid file:
# No env var
ign gui --config pubsub.config
[GUI] [Err] [Application.cc:263] Failed to load file [style.config]: XMLError

# Valid env var, invalid file
$ GZ_GUI_RESOURCE_PATH=/path/to/ign/src/ign-gui/examples/config ign gui --config pubsub.config2
[GUI] [Err] [Application.cc:263] Failed to load file [style.config]: XMLError

Multiple paths, some valid, some invalid. Should find file and load up correct GUI:
GZ_GUI_RESOURCE_PATH=/invalid:/path/to/ign/src/ign-gui/examples/config ign gui --config style.config

Test at ign-gazebo level:
Should show color themed GUI (add Gz Scene 3D plugin to see the world axis):
GZ_GUI_RESOURCE_PATH=/path/to/ign/src/ign-gui/examples/config ign gazebo --gui-config style.config default.sdf

Do after merging
New env var should be added to the ign gazebo help message after this is merged.
Checklist

[x] Signed all commits for DCO
[x] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Ah okay. I contemplated putting it in Application but went to cmdgui after looking at ign-gazebo. Hadn't thought of the library use. Will move.

All above resolved - moved to Application, renamed env var to GZ_*, tests OK.
Should add env var description to ign gazebo help message after this PR is in.
Ready for review.


ppo2 atari not converging with policy=mlp

Using env=PongNoFrameskip-v4 and ppo2 with policy=cnn, it converges as expected. Using policy=mlp however it does not appear to make any progress (using same hyperparams). I would have expected it to converge but more slowly (in #steps) than cnn. Have I missed something?

atari tasks are image based, and it is notoriously hard to process images with fully-connected layers. It is likely possible to make ppo2 with network=mlp, but will probably require some hyperparameter tuning. First thing I would try is increasing number of timesteps per batch (nsteps).

Okay. Closing as I'm not going to try to make this work with mlp.


Cypress Stability Improvements

Description

Adds more timeout to some requests because in these cases, Cloud Manager had not fully loaded yet. More timeout will allow Cloud Manager to load.

Uses a random Firewall name to ensure the API does not return 400 error for conflicting Firewall names

Cypress will delete the firewall after the test, but that was not enough (probably due to multiple e2es running at the same time)

How to test

Run test that changed locally, or just check the GitHub Actions of this PR

Considering changing in cypress.json:
"requestTimeout": 10000,

"requestTimeout": 20000,


Create CODEOWNERS file for SDK

see comment here https://github.com/anthropics/anthropic-sdk-python/pull/170#issuecomment-1747699895


[BUG] Config lost when reload OR different config paths for reading and saving

Environment
Self-Hosted (Bare Metal)
System
No response
Version
2.1.1
Describe the problem
If I modify the config via the UI, it works correctly, and it's saved in public/conf.yml (there's also a bunch of backup configs). However, if I reload the page, the original config file dist/conf.yml, so I have to manually edit the conf.yml file there
Additional info
No response
Please tick the boxes

[X] You have explained the issue clearly, and included all relevant info
[X] You are using a supported version of Dashy
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

@juantxorena Can you update the description its not clear what's supposed to happen and what bug is there

Fresh bare-metal installation
Modify config in the UI visual editor
The config file in public/conf.yml is updated with whatever changes I did
Hard reload page (Ctrl+F5)
The config file dist/conf.yml is used (as opossed to the previously updated public/conf.yml), so none of the changes done in step 2 are shown

same here

It is of course still active.

This is still not fixed, but unfortunately, I think it's the project the one who's stale

This is still not fixed, but unfortunately, I think it's the project the one which is stale

Just checking, you did a rebuild right? And you have write permissions where the config is located right?

Hi
This problems seems to be related to dashy not automatically rebuilding on changes, see #1479 and https://github.com/Lissy93/dashy/issues/1290#issuecomment-1884249018
A new release has just been published, which should fix this issue, so please upgrade to the latest version.
If this is not the case just respond back to this ticket and I'll reopen this issue.
Thanks and have a nice day.


After failed "apply" for Schema Compare then unchecking one of the changes, "Apply" button is still disabled

Repro:

Create a project from a database
Add two changes: one that will succeed, the other that will fail when deployed (both need to be valid for Build)
Schema compare the project against original database, see failure.
"Apply" button is now disabled since previous attempt failed and there haven't been any changes.
Uncheck the "bad" change.

Expected: "Apply" button should be re-enabled since the set up changes is different.
Reality: "Apply" button is still disabled.  If you re-check the bad change, "Apply" becomes enabled again.  Now, you can uncheck it and click "Apply"

Other thought: do we really want to be clever and disable the button when the user hasn't changed anything in Schema Compare?  If the problem is not related to SC at all (e.g. DB was offline or in single-user mode; sql object that isn't part of the dacpac required for applying changes), the user may want to try applying again without any changes.


Fixes #188

What title says.

Codecov Report

Merging #189 (df5632b) into develop (6451ca8) will decrease coverage by 0.07%.
The diff coverage is 73.68%.

@@             Coverage Diff             @@
##           develop     #189      +/-   ##
===========================================
- Coverage    85.79%   85.71%   -0.08%
===========================================
  Files           74       74
  Lines         5385     5399      +14
  Branches      1203     1208       +5
===========================================
+ Hits          4620     4628       +8
- Misses         497      499       +2
- Partials       268      272       +4

Impacted Files
Coverage Δ

src/instrumenter/instrumentation_context.ts
96.48% <73.68%> (-2.98%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat: add qhull v8.0.2

as title
need skip url stability check
http://www.qhull.org/

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (qhull) have been updated in this PR. Please review the changes.


Is .NETStandard still supported?

It looks like 3.x targets .NET Core, while 2.x targets .NET Standard.  Any plans to create a .NET Standard version of 3.x for people who are running ASP.NET Core on .NET Framework?

No. Because 3.x targets ASP.NET Core 3 - which only runs on .NET Core.

.NET Framework is "done" yes.


No way to perform a custom merging with store's preloadedState over reducer's defaultState

Am I missing something or there is still no way to customize init store by partially merge or fill server side or persistent storage data preloadedState into reducers' defatulState? For example, if I have a server-side data that is supplied to the store by preloadedState:
{
  "countyId": "5",
}

And the defaultState in reducers is:
{
  "sortBy": "created",
  "countyId": "1",
}

What I like to have in my store after init is like this:
{
  "sortBy": "created",
  "countyId": "5",
}

We may manually merge the data In typical reducers or use combineReducers to achieve partial hydration that are described as follows:
https://github.com/reactjs/redux/issues/433#issuecomment-129187414
https://github.com/reactjs/redux/issues/433#issuecomment-220124645
redux-actions returns the whole preloadedState and use it as the initial state of the store if preloadedState is not undefined.
Is there any way to customize init store in a more complex case?

Hi @stomvi,
I've just been granted access to the repo and will start maintaining it going forward. I need a few days to get a clear understanding of the code and the project's roadmap. After that, I can answer your issue. Does this work for you?

@mslipper, Yes and thank you. If I wasn't clear enough, the main goal of custom merging is in some cases that the server won't have to provide all the init state (I think most of the cases are) but the client-side code should have solid default state.
For example, a page that has a filter set with part of the filters contain their own default state. While working with router like react-router, the url may collect some filter queries after user clicks. Next time the same url is opened, filters may get it's own default state by merging the preloadedState and defaultState so that the backend won't have to provide all the filter state at once.
Some said to dispatch an init action as quickly as the components are loaded to set custom state to the store. Or combine preloadedState with defaultState before supplied to handleActions. Since it's a bad idea to handle @@INIT action (https://github.com/reactjs/redux/issues/186), by the former solution we have to dispatch a custom action which we might do this it in a whatever component's life cycle. The latter one we have to use preloadedState inside a reducer.js. These will all decrease the reusability of the code.
Currently I just use nested combineReducers like:
function searchMethod(state = SEARCH_METHOD_COUNTY, action) {
  // codes here
}

function countyId(state = false, action) {
  // ...my code
}

function staticData(state = {}) {
  // this state will be hydrated
}

const reducer = combineReducers({
  filter: combineReducers({
    searchMethod,
    countyId,
  }),
  staticData,
});

export default reducer;

It will help a lot If there is a good way to do this while using redux-actions.

I really don't understand what is the problem with passing a 'merge' option to the store when merge is desired and manage merging the two states internally.
Makes for a much cleaner api compared to the combine reducers mumbo jumbo IMO.
Let's say that you have a reducer state
{
    isFetching: false,
    result: { foo: '' },
    error: null
}

When the server provides error state, for example it received a 404 from an external api, then the error field will get filled in, but the other defaults will just disappear and this is what will be sent to the client.
When you want to use destructuring at the client when using the result, you get bugs in case of an error.
Of course this can be solved by manually merging (which is how everyone solves it I assume), but it is needlessly contrived and sort of an eyeroll when you bump into this problem IMO.

I will close this issue for now. If this issue is still present please feel free to comment and reopen it :)


TakeNote for serenityjs 3.0

@jan-molak
Hi Jan- I need help in the following snippet, please see the screenshot as it says error.

        await apiActor.attemptsTo(
            TakeNote.of(
                List.of(LastResponse.body<UserDetails[]>())
                    .where(Property.at<UserDetails>().verificationCodeOrTable, endsWith(creditInterestTable))
                    .first()
                    .map(() => details => details.verificationId)
            ).as('ID'),
        );
        const question = q`${Note.of('ID').map(replace(/.*\//, ''))}`;
        const verificationID = await apiActor.answer(question);
        console.log(verificationID);

Could you please help in correcting the above based on Serenityjs 3.0

Hi there, please have a look at the "What's new in Serenity/JS v3" to learn more about the changes to notes.
In general, I think a nice way to do it in Serenity/JS 3 should be something like this:
interface MyNotes {
  ID: string;
}

await apiActor.attemptsTo(
    notes<MyNotes>().set(
        'ID',
        List.of(LastResponse.body<UserDetails[]>())
            .where(List.item<UserDetails>().verificationCodeOrTable,  endsWith(creditInterestTable))
            .first()
            .verificationId
            .replace(/.*\//, '')
    ),
    Log.the(notes<MyNotes>().get('ID')
);

However, List.item<UserDetails>().verificationCodeOrTable doesn't exist yet - see #1420.
For the time being, you might be able to get away using filter:
await apiActor.attemptsTo(
    notes<MyNotes>().set(
        'ID',
        LastResponse.body<UserDetails[]>()
            .filter(userDetails => userDetails.verificationCodeOrTable.endsWith(creditInterestTable))
            [0]
            .verificationId
            .replace(/.*\//, '')
    ),
    Log.the(notes<MyNotes>().get('ID')
);

If you think #1420 is useful, please feel free to upvote it and consider supporting Serenity/JS to help me bring more features like this to the Community.


port CRA for demo

Added Create React App for Demo
Reference this issue

Hi friend @iswanj :smile:
Thanks for the great PR! You have put alot of work into this :tada:
In the spirit of open-open-source I've added you as a contributer to this project. Please feel free to merge this PR and whatever else you see fit for the project.
Please let me know if you have any questions or need help with publishing to npm :smile: :+1:

Great :+1:


[Bug] Deploying Model in a DataScience Project with Trusty service installed, Model doesn't get registered.

Describe the bug
TrustyAI service is unable to register a model in the Data Science project where model is deployed after the service
Steps To Reproduce
Steps to reproduce the behavior:

Create a new data science project
Deploy trustyai -crd
Create a model server and deploy the model

Expected behavior
The model doesn't get registered with the service
Version #:
Provider (Baremetal, OpenStack, RHV, AWS, OKD, CodeReady Containers, ...): ODH 2.4.0

Thanks, @nehachopra27.
Can I ask additional information, if available?

ODH operator version (I'm assuming 2.4.0)
DataScienceCluster used
Any TrustyAI and/or ODH operator logs?


Create Entity "Contract" #15

Description
New Entity Contract should be created and prepopulated in Database Contract should have the following properties:

[ ] time: date -- time for actual contract
[ ] salary: int -- Number of salary of employee

User Interface component:

[ ] Centre created for the entity Contract(to see employee's time of contract and salary in company)
[ ] Master created for entity Contract(to edit time of contract or to change salary employee[salary])

Expected outcome

Resolved by branch #20

Resolved to #20


warning: Can't open file anon_inode:[io_uring] ...

I been getting segfault for over a week now, not sure whats causing it. gdb giving out this Warning:
"warning: Can't open file anon_inode:[io_uring] which was expanded to anon_inode:[io_uring] during file-backed mapping note processing"
Linux 6.8.5

$ coredumpctl debug
           PID: 46207 (python3)
           UID: 1000 (stealth)
           GID: 1000 (stealth)
        Signal: 11 (SEGV)
     Timestamp: Sat 2024-04-27 12:17:59 CST (4s ago)
  Command Line: /opt/python/3.13/bin/python3 -q -X faulthandler -u /data/Files/Shakti/Python/Shakti/_.py
    Executable: /opt/python/3.13/bin/python3.13
 Control Group: /user.slice/user-1000.slice/session-2.scope
          Unit: session-2.scope
         Slice: user-1000.slice
       Session: 2
     Owner UID: 1000 (stealth)
       Boot ID: 845bcb4477a845ba99cc90baa74b3bf4
    Machine ID: 8fb1e06c986d4cc880274ee263f3f394
      Hostname: stealth-x8dal
       Storage: /var/lib/systemd/coredump/core.python3.1000.845bcb4477a845ba99cc90baa74b3bf4.46207.1714241879000000.zst (present)
  Size on Disk: 1.1M
       Message: Process 46207 (python3) of user 1000 dumped core.

                Stack trace of thread 46207:
                #0  0x0000760b344ef32c n/a (libc.so.6 + 0x9132c)
                #1  0x0000760b3449e6c8 raise (libc.so.6 + 0x406c8)
                #2  0x0000760b3449e770 n/a (libc.so.6 + 0x40770)
                #3  0x00005bffe1a82569 unicode_fromformat_write_cstr (python3.13 + 0x1d8569)
                #4  0x00005bffe1a83480 unicode_fromformat_arg (python3.13 + 0x1d9480)
                #5  0x00005bffe1b0ea1d _PyErr_FormatV (python3.13 + 0x264a1d)
                #6  0x00005bffe197603c PyObject_Format (python3.13 + 0xcc03c)
                #7  0x0000760b339329dd __pyx_pw_6shakti_3lib_4time_6Timeit_5__exit__ (time.cpython-313-x86_64-linux-gnu.so + 0xa9dd)
                #8  0x0000760b343ed7b9 __Pyx_CyFunction_CallAsMethod (run.cpython-313-x86_64-linux-gnu.so + 0xc7b9)
                #9  0x00005bffe1999a24 _PyObject_MakeTpCall (python3.13 + 0xefa24)
                #10 0x00005bffe199e2c2 _PyObject_VectorcallTstate (python3.13 + 0xf42c2)
                #11 0x00005bffe199a340 _PyObject_VectorcallTstate (python3.13 + 0xf0340)
                #12 0x00005bffe192baba _PyEval_EvalFrameDefault (python3.13 + 0x81aba)
                #13 0x00005bffe19b712d _PyEval_EvalFrame (python3.13 + 0x10d12d)
                #14 0x0000760b343f8eca __Pyx_PyObject_FastCallDict.constprop.1 (run.cpython-313-x86_64-linux-gnu.so + 0x17eca)
                #15 0x0000760b3440b8de __pyx_pw_6shakti_5event_3run_1run (run.cpython-313-x86_64-linux-gnu.so + 0x2a8de)
                #16 0x00005bffe1999a24 _PyObject_MakeTpCall (python3.13 + 0xefa24)
                #17 0x00005bffe192baba _PyEval_EvalFrameDefault (python3.13 + 0x81aba)
                #18 0x00005bffe1aeaf6f _PyEval_EvalFrame (python3.13 + 0x240f6f)
                #19 0x00005bffe1b57aa9 run_eval_code_obj (python3.13 + 0x2adaa9)
                #20 0x00005bffe1b597d7 pyrun_file (python3.13 + 0x2af7d7)
                #21 0x00005bffe1b59e6c _PyRun_AnyFileObject (python3.13 + 0x2afe6c)
                #22 0x00005bffe1b832a1 pymain_run_file_obj (python3.13 + 0x2d92a1)
                #23 0x00005bffe1b8390a Py_RunMain (python3.13 + 0x2d990a)
                #24 0x0000760b34487cd0 n/a (libc.so.6 + 0x29cd0)
                #25 0x0000760b34487d8a __libc_start_main (libc.so.6 + 0x29d8a)
                #26 0x00005bffe193c215 _start (python3.13 + 0x92215)

                Stack trace of thread 46209:
                #0  0x0000000000000000 n/a (n/a + 0x0)
                #1  0x00005bffe1dc7c20 PyBaseObject_Type (python3.13 + 0x51dc20)
                ELF object binary architecture: AMD x86-64

GNU gdb (GDB) 14.2
Copyright (C) 2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /opt/python/3.13/bin/python3.13...

warning: Can't open file anon_inode:[io_uring] which was expanded to anon_inode:[io_uring] during file-backed mapping note processing
[New LWP 46207]
[New LWP 46209]

This GDB supports auto-downloading debuginfo from the following URLs:
  <https://debuginfod.archlinux.org>
Enable debuginfod for this session? (y or [n]) y
Debuginfod has been enabled.
To make this setting permanent, add 'set debuginfod enabled on' to .gdbinit.
Downloading separate debug info for /usr/lib/libm.so.6
Downloading separate debug info for /usr/lib/libc.so.6
Downloading separate debug info for /lib64/ld-linux-x86-64.so.2
Downloading separate debug info for /data/Files/Shakti/Python/Shakti/src/shakti/event/run.cpython-313-x86_64-linux-gnu.so
Downloading separate debug info for /opt/python/3.13/lib/python3.13/site-packages/liburing/time.cpython-313-x86_64-linux-gnu.so
Downloading separate debug info for /opt/python/3.13/lib/python3.13/site-packages/liburing/queue.cpython-313-x86_64-linux-gnu.so
Downloading separate debug info for /opt/python/3.13/lib/python3.13/site-packages/liburing/error.cpython-313-x86_64-linux-gnu.so
Downloading separate debug info for /data/Files/Shakti/Python/Shakti/src/shakti/event/entry.cpython-313-x86_64-linux-gnu.so
Downloading separate debug info for /opt/python/3.13/lib/python3.13/site-packages/liburing/helper.cpython-313-x86_64-linux-gnu.so
Downloading separate debug info for /data/Files/Shakti/Python/Shakti/src/shakti/lib/time.cpython-313-x86_64-linux-gnu.so
Downloading separate debug info for system-supplied DSO at 0x7fffc4b41000
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/usr/lib/libthread_db.so.1".
Core was generated by `/opt/python/3.13/bin/python3 -q -X faulthandler -u /data/Files/Shakti/Python/Sh'.
Program terminated with signal SIGSEGV, Segmentation fault.
--Type <RET> for more, q to quit, c to continue without paging--c
#0  0x0000760b344ef32c in ?? () from /usr/lib/libc.so.6
[Current thread is 1 (Thread 0x760b3445b740 (LWP 46207))]
(gdb) bt
#0  0x0000760b344ef32c in ?? () from /usr/lib/libc.so.6
#1  0x0000760b3449e6c8 in raise () from /usr/lib/libc.so.6
#2  <signal handler called>
#3  0x00005bffe1a82569 in unicode_fromformat_write_cstr (writer=writer@entry=0x7fffc4ae0ed0, str=0x0,
    width=width@entry=-1, precision=precision@entry=200, flags=flags@entry=0) at ../Objects/unicodeobject.c:2392
#4  0x00005bffe1a83480 in unicode_fromformat_arg (vargs=0x7fffc4ae0f08, f=0x5bffe1c0c5c4 "s",
    writer=0x7fffc4ae0ed0) at ../Objects/unicodeobject.c:2741
#5  PyUnicode_FromFormatV (format=format@entry=0x5bffe1c0c598 "Format specifier must be a string, not %.200s",
    vargs=vargs@entry=0x7fffc4ae0f90) at ../Objects/unicodeobject.c:2877
#6  0x00005bffe1b0ea1d in _PyErr_FormatV (vargs=0x7fffc4ae0f90,
    format=0x5bffe1c0c598 "Format specifier must be a string, not %.200s",
    exception=0x5bffe1db3320 <_PyExc_SystemError>, tstate=0x5bffe1e27858 <_PyRuntime+264632>)
    at ../Python/errors.c:1161
#7  PyErr_Format (exception=0x5bffe1db3320 <_PyExc_SystemError>,
    format=format@entry=0x5bffe1c0c598 "Format specifier must be a string, not %.200s")
    at ../Python/errors.c:1196
#8  0x00005bffe197603c in PyObject_Format (obj=<optimized out>, format_spec=0x760b33a45080)
    at ../Objects/abstract.c:847
#9  0x0000760b339329dd in __pyx_pw_6shakti_3lib_4time_6Timeit_5__exit__ ()
   from /data/Files/Shakti/Python/Shakti/src/shakti/lib/time.cpython-313-x86_64-linux-gnu.so
#10 0x0000760b343ed7b9 in __Pyx_CyFunction_CallAsMethod ()
   from /data/Files/Shakti/Python/Shakti/src/shakti/event/run.cpython-313-x86_64-linux-gnu.so
#11 0x00005bffe1999a24 in _PyObject_MakeTpCall (tstate=tstate@entry=0x5bffe1e27858 <_PyRuntime+264632>,
    callable=callable@entry=0x760b33a3dcb0, args=args@entry=0x760b33c53930, nargs=<optimized out>,
    keywords=keywords@entry=0x0) at ../Objects/call.c:242
#12 0x00005bffe199e2c2 in _PyObject_VectorcallTstate (kwnames=0x0, nargsf=4, args=0x760b33c53930,
    callable=0x760b33a3dcb0, tstate=0x5bffe1e27858 <_PyRuntime+264632>) at ../Include/internal/pycore_call.h:166
#13 _PyObject_VectorcallTstate (kwnames=0x0, nargsf=4, args=0x760b33c53930, callable=0x760b33a3dcb0,
    tstate=0x5bffe1e27858 <_PyRuntime+264632>) at ../Include/internal/pycore_call.h:153
#14 method_vectorcall (method=<optimized out>, args=0x760b33c53938, nargsf=<optimized out>, kwnames=0x0)
    at ../Objects/classobject.c:62
#15 0x00005bffe199a340 in _PyObject_VectorcallTstate (kwnames=0x0, nargsf=<optimized out>,
    args=0x5bffe1e27858 <_PyRuntime+264632>, callable=0x760b33a37dc0, tstate=0x5bffe1e27858 <_PyRuntime+264632>)
    at ../Include/internal/pycore_call.h:168
#16 PyObject_Vectorcall (callable=callable@entry=0x760b33a37dc0, args=args@entry=0x760b33c53938,
    nargsf=<optimized out>, kwnames=kwnames@entry=0x0) at ../Objects/call.c:327
#17 0x00005bffe192baba in _PyEval_EvalFrameDefault (tstate=<optimized out>, frame=<optimized out>,
    throwflag=<optimized out>) at ../Python/generated_cases.c.h:813
#18 0x00005bffe19b712d in _PyEval_EvalFrame (throwflag=0, frame=0x760b33c538c8, tstate=<optimized out>)
    at ../Include/internal/pycore_ceval.h:114
#19 gen_send_ex2 (closing=0, exc=0, presult=<synthetic pointer>, arg=0x5bffe1dabf40 <_Py_TrueStruct>,
    gen=0x760b33c53880) at ../Objects/genobject.c:228
#20 gen_send_ex (closing=0, exc=0, arg=0x5bffe1dabf40 <_Py_TrueStruct>, gen=0x760b33c53880)
    at ../Objects/genobject.c:269
#21 gen_send (gen=0x760b33c53880, arg=0x5bffe1dabf40 <_Py_TrueStruct>) at ../Objects/genobject.c:292
#22 0x0000760b343f8eca in __Pyx_PyObject_FastCallDict.constprop.1 ()
   from /data/Files/Shakti/Python/Shakti/src/shakti/event/run.cpython-313-x86_64-linux-gnu.so
#23 0x0000760b3440b8de in __pyx_pw_6shakti_5event_3run_1run ()
   from /data/Files/Shakti/Python/Shakti/src/shakti/event/run.cpython-313-x86_64-linux-gnu.so
#24 0x00005bffe1999a24 in _PyObject_MakeTpCall (tstate=0x5bffe1e27858 <_PyRuntime+264632>,
    callable=callable@entry=0x760b33a33ed0, args=args@entry=0x760b34749088, nargs=<optimized out>,
    keywords=keywords@entry=0x0) at ../Objects/call.c:242
#25 0x00005bffe199a39f in _PyObject_VectorcallTstate (kwnames=0x0, nargsf=<optimized out>, args=0x760b34749088,
    callable=0x760b33a33ed0, tstate=<optimized out>) at ../Include/internal/pycore_call.h:166
#26 0x00005bffe192baba in _PyEval_EvalFrameDefault (tstate=tstate@entry=0x5bffe1e27858 <_PyRuntime+264632>,
    frame=<optimized out>, frame@entry=0x760b34749020, throwflag=throwflag@entry=0)
--Type <RET> for more, q to quit, c to continue without paging--c
    at ../Python/generated_cases.c.h:813
#27 0x00005bffe1aeaf6f in _PyEval_EvalFrame (throwflag=0, frame=0x760b34749020,
    tstate=0x5bffe1e27858 <_PyRuntime+264632>) at ../Include/internal/pycore_ceval.h:114
#28 _PyEval_Vector (args=0x0, argcount=0, kwnames=0x0, locals=0x760b33c30780, func=0x760b33c23240,
    tstate=0x5bffe1e27858 <_PyRuntime+264632>) at ../Python/ceval.c:1806
#29 PyEval_EvalCode (co=co@entry=0x5bffe3c2f0d0, globals=globals@entry=0x760b33c30780,
    locals=locals@entry=0x760b33c30780) at ../Python/ceval.c:601
#30 0x00005bffe1b57aa9 in run_eval_code_obj (locals=0x760b33c30780, globals=0x760b33c30780, co=0x5bffe3c2f0d0,
    tstate=0x5bffe1e27858 <_PyRuntime+264632>) at ../Python/pythonrun.c:1291
#31 run_mod (mod=<optimized out>, filename=filename@entry=0x760b33c39ca0, globals=globals@entry=0x760b33c30780,
    locals=locals@entry=0x760b33c30780, flags=flags@entry=0x7fffc4ae1a78, arena=arena@entry=0x760b33d1b790,
    interactive_src=0x0, generate_new_source=0) at ../Python/pythonrun.c:1376
#32 0x00005bffe1b597d7 in pyrun_file (flags=0x7fffc4ae1a78, closeit=1, locals=0x760b33c30780,
    globals=0x760b33c30780, start=257, filename=0x760b33c39ca0, fp=0x5bffe3b4d400) at ../Python/pythonrun.c:1212
#33 _PyRun_SimpleFileObject (fp=fp@entry=0x5bffe3b4d400, filename=filename@entry=0x760b33c39ca0,
    closeit=closeit@entry=1, flags=flags@entry=0x7fffc4ae1a78) at ../Python/pythonrun.c:461
#34 0x00005bffe1b59e6c in _PyRun_AnyFileObject (fp=0x5bffe3b4d400, filename=filename@entry=0x760b33c39ca0,
    closeit=closeit@entry=1, flags=flags@entry=0x7fffc4ae1a78) at ../Python/pythonrun.c:77
#35 0x00005bffe1b832a1 in pymain_run_file_obj (skip_source_first_line=0, filename=0x760b33c39ca0,
    program_name=0x760b33c912a0) at ../Modules/main.c:357
#36 pymain_run_file (config=0x5bffe1dfa798 <_PyRuntime+80120>) at ../Modules/main.c:376
#37 pymain_run_python (exitcode=exitcode@entry=0x7fffc4ae1bc0) at ../Modules/main.c:628
#38 0x00005bffe1b8390a in Py_RunMain () at ../Modules/main.c:707
#39 pymain_main (args=0x7fffc4ae1b80) at ../Modules/main.c:737
#40 Py_BytesMain (argc=<optimized out>, argv=<optimized out>) at ../Modules/main.c:761
#41 0x0000760b34487cd0 in ?? () from /usr/lib/libc.so.6
#42 0x0000760b34487d8a in __libc_start_main () from /usr/lib/libc.so.6
#43 0x00005bffe193c215 in _start ()
(gdb)

This doesn't look io_using related at all, and the fact that the ring fd is from an anon inode and you get complaints about that isn't related to the crash.

ok, forget about the crash, I mainly posted it here because I saw that warning. I wasn't sure what it was about. If that warning is normal, lets just close this issue.

Nothing nefarious about it.


Add SteamOS Btrfs

Is your feature request related to a problem? Please describe.
No problem.
Describe the solution you'd like
Add SteamOS Btrfs to the Software section: https://gitlab.com/popsulfr/steamos-btrfs
Describe alternatives you've considered
I don't believe any alternatives are available to provide btrfs support for /home and SD cards on SteamOS.
Additional context
This project will convert the /home partition in SteamOS to the btrfs filesystem, and allow SD cards to use that filesystem as well. This has several benefits, like the potential for space savings via transparent compression and deduplication, as well as the use of subvolumes and snapshots for more technical applications. The project also provides an optional weekly deduplication service that is particularly helpful for compatdata.
It is not without drawbacks, though: btrfs does not support casefolding like ext4 does, so Proton and Wine have to use the slower fallback codepath, which could hypothetically impact applications that make frequent filesystem accesses. I haven't run into any games that do that yet.

As an aside, I'm not sure the existing issue templates are well suited to this project.

As an aside, I'm not sure the existing issue templates are well suited to this project.

Do you think a simpler template will be more suitable?

Accidentally closed after merging the PR, sorry!

Do you think a simpler template will be more suitable?

Yeah. The templates concern "bugs", "feature requests", and "security vulnerabilities", which are not applicable to this sort of repo. This repo should basically only concern itself with additions to the list, and removals/replacements from the list.
You basically just need two questions for an addition: "What do you want to add, and in what section?" and "What benefit does it provide Steam Deck users?"
You may want a separate template for a removal/replacement: "What do you want to remove or replace, and from what section?" and "What happened to the project that necessitates its removal or replacement?"

You're totally right. Usually I use a predefined template for all my repositories.
I'll be making the changes you suggested soon.
Thank you kindly for your precious support @HugLifeTiZ. I really appreciate that!


Publish NuGet AppMetrics.Client package on each build

See CIAPI.CS for example on how to do this.
Basically you need to register the NuGet API key on the build server, and then call nuget push at the end of the build if all tests pass.
See https://github.com/cityindex/CIAPI.CS/blob/master/tools/msbuild/DropsAndPackaging.targets.xml#L20

How I can register this API key on the server?

http://bit.ly/sCzZGV
On 3 January 2012 11:39, fandrei <
<EMAIL_ADDRESS>
wrote:

How I can register this API key on the server?

Reply to this email directly or view it on GitHub:
https://github.com/fandrei/AppMetrics/issues/21#issuecomment-3338826

--
David Laing
Open source @ City Index - github.com/cityindex
http://davidlaing.com
Twitter: @davidlaing

It's clear, but how I can execute this command on this server? ;)

Permanently storing API key didn't work for some reason, so I pass it to build task at every build (using MaskPassword add-in to prevent showing in job output).


Enable screen reader to read Collapsed/Expanded states in JSON viewer

Fixes MS63920
Description
As reported by the issue, Narrator was not being able to read when parent nodes are collapsed or expanded in the JSON viewer tree view.
Changes made

Added a DIV element to the DOM using the role and aria-live attributes to enable screen readers to read specific events
Added a message to be announced when a parent node is collapsed or expanded
Added a CSS class to position the DIV element offscreen
Updated test cases related to JSON Viewer component

Testing
No unit tests were added.

Coverage increased (+0.002%) to 67.825% when pulling fd83254701a9c197f5a6d291c3ec0b2af795315e on southworks:internal/southworks/json-viewer-announce-state-changes into b3c977094aae49189b1de464a9f10c206c184e14 on microsoft:main.


ListObjectVersionsOutputTypeDef CommonPrefixes key can be missing

Describe the bug
ListObjectVersionsOutputTypeDef has the key CommonPrefixes typed as a List[CommonPrefixTypeDef], but the key can be missing in the response to list_object_versions.
To Reproduce
Steps to reproduce the behavior:

Install boto3-stubs[s3]
Run mypy/pyright on the following code sample

import boto3

s3_client = boto3.client("s3")
response = s3_client.list_object_versions(
    Bucket="some-bucket", Delimiter="/", Prefix="a/prefix/with/no/common/prefixes/"
)

common_prefixes = response["CommonPrefixes"]

The type checker is fine with this piece of code.

Actual output
The CommonPrefixes is missing from the response and the snippet fails when running on a real-life example.
KeyError: 'CommonPrefixes'

Expected output
There is no expected output, I would have liked my type checker to warn me about a potentially missing key.
Additional context
I'm using macOS 14.2, python 3.9.5, poetry 1.8.1 to manage dependencies, boto3 & boto3-stubs 1.34.31
An example of a response I got from AWS where the key CommonPrefixes is missing.
{
  "DeleteMarkers": [
    {
      "IsLatest": "true",
      "Key": "some/key/to/a/file",
      "LastModified": "",
      "Owner": {
        "ID": "**********"
      },
      "VersionId": "**********"
    }
  ],
  "Delimiter": "/",
  "EncodingType": "url",
  "IsTruncated": "false",
  "KeyMarker": "",
  "MaxKeys": 1000,
  "Name": "bucket-name",
  "Prefix": "some/prefix/",
  "ResponseMetadata": {
    "HTTPHeaders": {
      "content-type": "application/xml",
      "date": "**********",
      "server": "AmazonS3",
      "transfer-encoding": "chunked",
      "x-amz-id-2": "**********",
      "x-amz-request-id": "**********"
    },
    "HTTPStatusCode": 200,
    "HostId": "**********",
    "RequestId": "**********",
    "RetryAttempts": 0
  },
  "VersionIdMarker": ""
}

Unfortunately, right now there is no way to tell if the key in output shape is optional or not. I am still investigating it.

By the way, you are getting key error because method name is incorrect: list_object_versionslist_object_versions

corrected, but this doesn't change my issue: the key is optional from the S3 response but the type checker misses that.

I will try to fix it. If you have time you can also take a look at botocore shapes and help me figure out how optional/required keys are marked for output shapes.
One solution would be to use the same key totality as for input shapes. But it is also not an ideal solution, because almost all keys are optional in input shapes.
Another solution would be to somehow figure out which keys are required in output shapes, but I still have no idea how to do it.

If I use the same rules as for input shapes, this is what I get :
ListObjectVersionsOutputTypeDef = TypedDict(
    "ListObjectVersionsOutputTypeDef",
    {
        "ResponseMetadata": ResponseMetadataTypeDef,
        "IsTruncated": NotRequired[bool],
        "KeyMarker": NotRequired[str],
        "VersionIdMarker": NotRequired[str],
        "NextKeyMarker": NotRequired[str],
        "NextVersionIdMarker": NotRequired[str],
        "Versions": NotRequired[List[ObjectVersionTypeDef]],
        "DeleteMarkers": NotRequired[List[DeleteMarkerEntryTypeDef]],
        "Name": NotRequired[str],
        "Prefix": NotRequired[str],
        "Delimiter": NotRequired[str],
        "MaxKeys": NotRequired[int],
        "CommonPrefixes": NotRequired[List[CommonPrefixTypeDef]],
        "EncodingType": NotRequired[Literal["url"]],
        "RequestCharged": NotRequired[Literal["requester"]],
    },
)

As you see, all keys are marked as not required. I do not think that this is a proper solution.

The issue has finally been fixed in mypy_boto3_builder 7.24.0 release. I have also released mypy-boto3-s3 1.34.91 with the fix included. Please update and let me know if it works as it should.


Can't open push notifications

Hello,
Using cordova android 10.1.1 platform and the dev version of the plugin (unstable) because 2.0 does not compile with android 10. The problem is that push notifications don't open the app when tapping on the notification. This is what adb logcat shows,
When the push notification is received (This one goes away when adding notId to the payload but same problem)
10-31 05:59:59.263 19765 19928 E cordova-plugin-push (FCMService): Exception occurred when parsing notId: null
When trying to open the app from the push notification
10-31 06:47:33.341  2020  5370 W ActivityTaskManager: startActivity called from non-Activity context; forcing Intent.FLAG_ACTIVITY_NEW_TASK for: Intent { flg=0x24000000 cmp=HERE GOES MY APP ID/com.adobe.phonegap.push.PushHandlerActivity (has extras) }
10-31 06:00:26.281  2020  2043 E system_server: Invalid ID 0x00000000.
Before upgrading to version 10 this problem did not exist.
Thank you.
This is the log when trying to build using version 2 (stable)
  - In plugin 'com.google.gms.google-services' type 'com.google.gms.googleservices.GoogleServicesTask' field 'intermediateDir' without corresponding getter has been annotated with @OutputDirectory.

    Reason: Annotations on fields are only used if there's a corresponding getter for the field.

    Possible solutions:
      1. Add a getter for field 'intermediateDir'.
      2. Remove the annotations on 'intermediateDir'.

    Please refer to https://docs.gradle.org/7.1.1/userguide/validation_problems.html#ignored_annotations_on_field for more details about this problem.
  - In plugin 'com.google.gms.google-services' type 'com.google.gms.googleservices.GoogleServicesTask' field 'packageNameXOR1' without corresponding getter has been annotated with @Input.

    Reason: Annotations on fields are only used if there's a corresponding getter for the field.

    Possible solutions:
      1. Add a getter for field 'packageNameXOR1'.
      2. Remove the annotations on 'packageNameXOR1'.

    Please refer to https://docs.gradle.org/7.1.1/userguide/validation_problems.html#ignored_annotations_on_field for more details about this problem.
  - In plugin 'com.google.gms.google-services' type 'com.google.gms.googleservices.GoogleServicesTask' field 'packageNameXOR2' without corresponding getter has been annotated with @Input.

    Reason: Annotations on fields are only used if there's a corresponding getter for the field.

    Possible solutions:
      1. Add a getter for field 'packageNameXOR2'.
      2. Remove the annotations on 'packageNameXOR2'.

    Please refer to https://docs.gradle.org/7.1.1/userguide/validation_problems.html#ignored_annotations_on_field for more details about this problem.
  - In plugin 'com.google.gms.google-services' type 'com.google.gms.googleservices.GoogleServicesTask' field 'quickstartFile' without corresponding getter has been annotated with @InputFile, @Optional.

    Reason: Annotations on fields are only used if there's a corresponding getter for the field.

    Possible solutions:
      1. Add a getter for field 'quickstartFile'.
      2. Remove the annotations on 'quickstartFile'.

    Please refer to https://docs.gradle.org/7.1.1/userguide/validation_problems.html#ignored_annotations_on_field for more details about this problem.
  - In plugin 'com.google.gms.google-services' type 'com.google.gms.googleservices.GoogleServicesTask' field 'searchedLocation' without corresponding getter has been annotated with @Input.

    Reason: Annotations on fields are only used if there's a corresponding getter for the field.

    Possible solutions:
      1. Add a getter for field 'searchedLocation'.
      2. Remove the annotations on 'searchedLocation'.

    Please refer to https://docs.gradle.org/7.1.1/userguide/validation_problems.html#ignored_annotations_on_field for more details about this problem.

Hello to all,
Apparently there is a problem which causes what you describes in the latest development version of the plugin. I get the same problem (also with Cordova Android 10.1.1) and what I do is to specify the previous development version of the plugin, that is<EMAIL_ADDRESS>What I do is to specify that version when installing the plugin:
cordova plugin add<EMAIL_ADDRESS>If you did not specify the version, then the latest development version of the plugin (3.0.0-dev.1) become installed, and, certainly, that version causes / introduce the problem that you describes: the push notification is received, but, when tap on the notification the app is not opened as expected.

Thank you very much, i just tried it and it works ok with dev.0!

It is also working on 3.0.1

Closing the ticket as resolved, as it has been reported to be working with version 3.0.1.
If the issue persists after testing with the latest release (5.0.0), please open a new ticket with updated information.


Server Side Pagination doesn't work on version 7.0.0-rc.16 [7.0.0-rc.15 works]

Using v7?
Describe the bug
I have been using version 7.0.0-rc.15 and recently updated to 7.0.0-rc.16. My server side pagination stopped working properly. The page index is stuck on 0 and I can't go to other pages (results per page still works). I haven't done anything new from the previous version and when I go back a version in my package.json it works, no code refactor neccessary.
Played around with the codesandbox demo and when switching between versions the Manual Pagination still worked.
Please help.
Expected behavior
Go from page to page as expected
Codesandbox!
//Getting users from server
const fetchData = useCallback((pageIndex, pageSize) => {
        setStaffLoading();
        getUsers({page: pageIndex, perPage: pageSize, include: ['servicePartners']});
        //eslint-disable-next-line
    }, [perPage, currentPage]);

//DataTable props
<DataTable columns={columns}
                           data={users}
                           fetchData={fetchData}
                           loading={usersLoading}
                           pageCount={totalPages}
                           allResults={totalResults}
                           viewMode={tableViewMode}
                           cardDataType={'users'}
                           rowsPadded={rowsShrunk}
                           withActions={prepareActions(actions)}/>

//fetch Data in DataTable component
    useEffect(() => {
        fetchData(pageIndex, pageSize);
        //eslint-disable-next-line
    }, [pageIndex, pageSize, dynamicData]);

Works in 7.0.0-rc.15
Screenshots
When page loads for the first time it send request to get first page

After next page is clicked:

The new page is fetched successfully but for some reason the request is sent again and it goes back to page 1.
This code has worked for more than a month on version 7.0.0-rc.15 without issues.
Any suggestions?
Desktop (please complete the following information):

OS: Windows 10
Browser: Brave Browser
Version Version 1.3.118 Chromium: 80.0.3987.116 (Official Build) (64-bit)

Sorry for the raised issue. The problem was in me. I didn't notice the autoResetPage value.
I am closing it now.


make cred-rotation bg sleep interruptable

Make the background sleep interruptible for temporary credential rotation.
Similar previous PR https://github.com/aws-controllers-k8s/test-infra/pull/152

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

merging this one word change to unblock CI/CD pipeline. please leave any feedback and i will address it.


What is the ordering of "on summon" or "on buy" effects and golden-infication.

The triple rewards removes the three cards and creates a new one.  Does this happen before or after effects that trigger when you gain the new card?  Do those effects target the base card, or the golden one that was created?

https://www.youtube.com/watch?v=883KhR_zTtE
This video has a bunch of examples with Cap'n Hoggarr. It seems to me that the coins are gained before the triple is formed. Starting at around 9:35 there is one instance and then a few more shortly after.

Other than Hoggarr, I think Patches the Pirate and The Rat King are the only other relevant cards/heroes.


Regression of the number of operations in the EOMs after CSE

In the switch to using attachments in #103 a regression has been observed in the number of operations in the EOMs. For the default Whipple bicycle the following regression has been observed:

Implementation
Computation time$\mu \pm \sigma$ (s)
#Operations EOMsbefore CSE
#Operations EOMsafter CSE

Manual by Moore
$3.5\pm0.2$
230789
2198

Manual by Stienstra
$6.6\pm0.3$
390554
2389

BRiM before #103
$5.8\pm0.3$
468290
2176

BRiM after #103
$7.3\pm0.8$
352210
2291

The table also shows some other implementations as a reference, which are also in the benchmarks/test_whipple_bicycle.py file. The first three results were specifically created over 50 runs on an Inter(R) Core(TM) i7-8750H CPU @ 2.20GHz with BRiM commit: ec02a0a7852b15de2f37e0630e2af962f69bba9d. Note that the computation time does not matter too much and should be taken with a grain of salt, as the timing results differ more than the standard deviation from time to time.
I have tracked the change down to the fact that the usage of the rear_frame.steer_hub.to_valid_joint_arg() instead of rear_frame.body as parent argument in the steer joint results in the increase of operations after CSE. This means that the velocity graph of the points is defined a little differently. It is notable that the number of operations in the EOMs before CSE actually decreases.
In #103 I propose the following three solutions:

Upgrade the Point.vel method. While it would be ideal to make this more advanced, it is quite a nasty problem to solve.
Add an optimize_velocity_definition when exporting to a single System, which can later be moved to System within sympy. This is also not a simple solution, as one needs to detect when it is advantageous to compute a velocity using a certain theorem.
Add a manual set of velocity theorems in WhippleBicycle to optimize the velocity definition. This has the disadvantage of a constant labor.

When working on the third point I noticed that I was not able to get the wanted decrease when manually specifying the velocities which would be set by PinJoint when using rear_frame.body`. My hypothesis is that the automated velocity computation just follows a suboptimal path or multiple paths to compute the same velocity component. It would be optimal if everything always uses the same velocity component and not an alternative, but figuring out how to force this is quite a challenge.
This issue challenges us to find the exact reason for the seen regression and find an appropriate fix for it.

It might be an idea to study the Point.vel warnings it gives on that a velocity can be computed w.r.t. different points. They seem to be different than before.

This regression has been solved with the implementation of AuxiliaryDataHandler._compute_velocity in #128. The current number of operations in the EoMs before and after CSE is 266594 and 1908 respectively (2e7c89f456cb2c59895a4ed3862955c4e0522f5d).


Improve gitignore

I improved the gitignore file, generated with https://www.gitignore.io/
I also removed files that were tracked by Git but should be ignored: .user, .vspscc, .vssscc and project.lock.json files.

Thanks @StevenLiekens


feat: adjust input width to char limit

When using non transparent background for char limited input text, the field weirdly fill all the layout view, resulting in a poor user interface experience.
In this example, CharLimit is set to 12:

This pr adjusts its final width during the view time, letting the WithWidth method doing the hard job
And voila:

And before you asks, yes it supports inline mode:

Incredible work @nervo, thank you so much! I also really appreciate the attention to detail with inline mode screenshots too!


make use of the common-request internal module

Adds tests for most all

Coverage increased (+33.5%) to 93.213% when pulling 8cf161d00f4738cda58c6b34a3d5eeff932c1746 on lholmquist:17-common-request into 7df6addf2c29c0236cd6deb95fac48c327ce07a1 on bucharest-gold:master.


Closes softlayer/sl-ember-components#863

I think this resolves the intention of this open issue.

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


Deprecated GitHub API endpoint for teams

The trac-github plugin is using a deprecated GitHub API endpoint for /teams/ that will be removed on 2022-03-15. Right now on 2022-03-01, GitHub has some brownouts in effect to make users of the API aware of the deprecation. I see the following log message:
Trac[github] ERROR: Error communicating with GitHub API at https://api.github.com/teams/3156412/members: You are receiving this error due to a service brownout. Please see https://github.blog/changelog/2022-02-22-sunset-notice-deprecated-teams-api-endpoints/ for more information.

The easiest route seems to be to replace the /teams/ endpoint with /organizations/:org_id/team/:team_id. I have not yet checked whether they are fully compatible, though.

The required patch probably is the following. I need to do more testing, though.
diff --git a/runtests.py b/runtests.py
index 62f5127..69b8fb6 100755
--- a/runtests.py
+++ b/runtests.py
@@ -1482,8 +1482,8 @@ class GitHubGroupsProviderTests(TracGitHubTests):
                     "slug": u"gentlepeople"
                 }
             ],
-            '/teams/1/members': team1members,
-            '/teams/12/members': team12members
+            '/organizations/%s/team/1/members' % self.organization: team1members,
+            '/organizations/%s/team/12/members' % self.organization: team12members
         })

         with TracContext(self, env=self.tracd_env_debug, **self.trac_env):
@@ -1665,8 +1665,8 @@ class GitHubGroupsProviderTests(TracGitHubTests):
                     "slug": u"gentlepeople"
                 }
             ],
-            '/teams/1/members': team1members,
-            '/teams/12/members': team12members
+            '/organizations/%s/team/1/members' % self.organization: team1members,
+            '/organizations/%s/team/12/members' % self.organization: team12members
         })

         update = {
@@ -1698,7 +1698,7 @@ class GitHubGroupsProviderTests(TracGitHubTests):
                         "slug": u"gentlepeople"
                     }
                 ],
-                '/teams/12/members': team12members
+                '/organizations/%s/team/12/members' % self.organization: team12members
             })

             # Send the delete event
@@ -1783,7 +1783,7 @@ class GitHubGroupsProviderTests(TracGitHubTests):
                         "slug": u"justice-league"
                     },
                 ],
-                '/teams/1/members': team1members,
+                '/organizations/%s/team/1/members' % self.organization: team1members,
             })

             # Send the update event
@@ -1826,7 +1826,7 @@ class GitHubGroupsProviderTests(TracGitHubTests):
                     "slug": u"justice-league"
                 },
             ],
-            '/teams/1/members': list(team1members)
+            '/organizations/%s/team/1/members' % self.organization: list(team1members)
         })

         update = {
@@ -1848,7 +1848,7 @@ class GitHubGroupsProviderTests(TracGitHubTests):
                         "slug": u"justice-league"
                     },
                 ],
-                '/teams/1/members': list(team1members)
+                '/organizations/%s/team/1/members' % self.organization: list(team1members)
             })

             # Send the update event
@@ -1891,7 +1891,7 @@ class GitHubGroupsProviderTests(TracGitHubTests):
                     "slug": u"justice-league"
                 },
             ],
-            '/teams/1/members': list(team1members)
+            '/organizations/%s/team/1/members' % self.organization: list(team1members)
         })

         update = {
@@ -1913,7 +1913,7 @@ class GitHubGroupsProviderTests(TracGitHubTests):
                         "slug": u"justice-league"
                     },
                 ],
-                '/teams/1/members': list(team1members)
+                '/organizations/%s/team/1/members' % self.organization: list(team1members)
             })

             # Send the update event
diff --git a/tracext/github/__init__.py b/tracext/github/__init__.py
index 0dddb2b..fe9dc6f 100644
--- a/tracext/github/__init__.py
+++ b/tracext/github/__init__.py
@@ -475,11 +475,12 @@ class GitHubTeam(GitHubUserCollection):
         :param slug: the GitHub team shortname in URL representation
         """
         self._teamid = teamid
+        self._orgid = org
         fullname = '-'.join(['github', org, slug])
         super(GitHubTeam, self).__init__(api, env, fullname)

     def _apicall_parameters(self):
-        return ("teams/{}/members", self._teamid)
+        return ("organizations/{}/team/{}/members", self._orgid, self._teamid)

 #class GitHubOrgMembers(GitHubUserCollection):
 #    """

GitHub moved the sunset of the teams API endpoint to an unannounced later date. This gives us more time for testing this properly, but we should still move to the newer API endpoint eventually.


virtualservice hosts *.com return 404

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities/
To ask questions about how to use Istio, please visit https://discuss.istio.io
)
Bug description
[root@master01 virtaulservice]# istioctl proxy-config route istio-ingressgateway-698f645c48-jjcrm.istio-system --name http.80
NOTE: This output only contains routes loaded via RDS.
NAME        DOMAINS     MATCH                 VIRTUAL SERVICE
http.80     *.com       /productpage          bookinfo.istio
http.80     *.com       /static*              bookinfo.istio
http.80     *.com       /login                bookinfo.istio
http.80     *.com       /logout               bookinfo.istio
http.80     *.com       /api/v1/products*     bookinfo.istio

[root@master01 virtaulservice]# kubectl get vs bookinfo -n istio -o yaml
apiVersion: networking.istio.io/v1beta1
kind: VirtualService
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"networking.istio.io/v1alpha3","kind":"VirtualService","metadata":{"annotations":{},"name":"bookinfo","namespace":"istio"},"spec":{"gateways":["bookinfo-gateway"],"hosts":["*"],"http":[{"match":[{"uri":{"exact":"/productpage"}},{"uri":{"prefix":"/static"}},{"uri":{"exact":"/login"}},{"uri":{"exact":"/logout"}},{"uri":{"prefix":"/api/v1/products"}}],"route":[{"destination":{"host":"productpage.istio.svc.cluster.local","port":{"number":9080}}}]}]}}
  creationTimestamp: "2020-08-22T05:29:21Z"
  generation: 11
  name: bookinfo
  namespace: istio
  resourceVersion: "3878769"
  selfLink: /apis/networking.istio.io/v1beta1/namespaces/istio/virtualservices/bookinfo
  uid: 704b0bba-c457-4abd-8c2f-0f3df18d303e
spec:
  gateways:
  - bookinfo-gateway
  hosts:
  - '*.com'
  http:
  - match:
    - uri:
        exact: /productpage
    - uri:
        prefix: /static
    - uri:
        exact: /login
    - uri:
        exact: /logout
    - uri:
        prefix: /api/v1/products
    route:
    - destination:
        host: productpage.istio.svc.cluster.local
        port:
          number: 9080

[root@master01 virtaulservice]# kubectl get gw bookinfo-gateway -n istio -o yaml
apiVersion: networking.istio.io/v1beta1
kind: Gateway
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"networking.istio.io/v1alpha3","kind":"Gateway","metadata":{"annotations":{},"name":"bookinfo-gateway","namespace":"istio"},"spec":{"selector":{"istio":"ingressgateway"},"servers":[{"hosts":["*"],"port":{"name":"http","number":80,"protocol":"HTTP"}}]}}
  creationTimestamp: "2020-08-22T06:03:35Z"
  generation: 13
  name: bookinfo-gateway
  namespace: istio
  resourceVersion: "3878636"
  selfLink: /apis/networking.istio.io/v1beta1/namespaces/istio/gateways/bookinfo-gateway
  uid: 419e2ccb-9d3a-4e24-a5d4-b9cdeaa9e386
spec:
  selector:
    istio: ingressgateway
  servers:
  - hosts:
    - '*'
    port:
      name: http
      number: 80
      protocol: HTTP

Affected product area (please put an X in all that apply)
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Expected behavior
Steps to reproduce the bug
Version (include the output of istioctl version --remote and kubectl version and helm version if you used Helm)
[root@master01 virtaulservice]# istioctl version
client version: 1.7.0-beta.1
control plane version: 1.7.0-beta.1
data plane version: 1.7.0-beta.1 (17 proxies)
[root@master01 virtaulservice]# kubectl version
Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2019-10-15T19:18:23Z", GoVersion:"go1.12.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.2", GitCommit:"c97fe5036ef3df2967d086711e6c0c405941e14b", GitTreeState:"clean", BuildDate:"2020-05-12T09:28:18Z", GoVersion:"go1.12.4", Compiler:"gc", Platform:"linux/amd64"}
How was Istio installed?
Environment where bug was observed (cloud vendor, OS, etc)
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

the config i have give you ,you can make tests on your own bookinfo demo

I am not able to reproduce this. This is extensively tested, and you will not give the required information, so I don't see how we can move forward with this issue. Please see https://istio.io/latest/docs/tasks/traffic-management/ingress/ingress-control/ for more information, you are likely not setting the host header
curl <IP_ADDRESS>/productpage -H "Host: example.com" -v


[Refactor] Remove TinyDB

Summary
Removes TinyDB in favour of reading/writing from TOML files directly.

I believe it's working:

Submission
Badges / stars
Batch merge

I believe it's working:

Submission
Badges / stars
Batch merge

Cool :)
Seems working for badges/stars.
The commit of the PR generated by the submission wf : https://github.com/frankharkins/ecosystem/pull/4/commits/426423ba08b69a382f5b26338da80b8710f7f0e7 should have only one file modified, not every member :o

It's very strange; it seems the commit is changing all those files, but I can't reproduce it locally when I run python manager.py add_repo_2db ...😕

Indeed seems to be working as usual now :)

Tested members.json locally (see 38d0f25d502ae77850597f0133fe6fae3047ceb3 – not on this branch) and worked correctly.


NAS-122227 / 23.10 / fix typo'ed artfacts.md file (should be artifacts.md)

Pointed out by @DjP-iX

Jira URL: https://ixsystems.atlassian.net/browse/NAS-122227


Delegate and injector insertion

I was wondering what the arguments look like on a delegate callback and if it would be possible (without breaking compatibility) to send the injector into the callback.  I am guessing a more complex factory will actually run through it's own dependency injection so for example:
class Factory
{
    public function __construct(Foo $foo, Bar $bar) {
        ...
    }

    public function create()
    {

    }
}

If I delegate to ['Factory', 'create'] would create() be executed via $injector->execute() -- thereby allowing for DI on the method as well as the constructor?  If not, would it be possible to pass the $injector back into it similar to prepare()?  I find using the injector directly on these methods preferable because I can make dependencies with specific concrete/instantiated arguments.
If this is not possible, you could give some insight as to how to lazy instantiate dependencies of the same concrete class type?  I have two separate Twig_Environments with different loaders (a dependency for the Twig_Environment) that need to be injected into the same service.

Instead of using a delegate for the class, you can instead delegate single parameters as shown in the added example.


Need to enable ADFS Verbose Auditing

The script needs to enable ADFS Verbose Auditing as well as application generated auditing.  Right now it is collecting Security event logs that in many cases do not have any ADFS Auditing events as they are not already enabled by the customer.  The script needs to enable this or prompt the user to allow it to enable this.  We need the ADFS Auditing events as part of this data collection.  It is hard to go back later and ask for all this data collection again because we missed the ADFS Auditing events.
#ADFS Auditing:
Set-AdfsProperties -AuditLevel Verbose
Import-Module ADFS
Set-ADFSProperties -LogLevel $((Get-ADFSProperties).LogLevel + "SuccessAudits" + "FailureAudits")
auditpol.exe /set /subcategory:"Application Generated" /failure:enable /success:enable

Hi Paul,
for the troubleshooting we  dont need the Security Audit Events generated by ADFS
the context that generates these audits in the first place is already in the ADFS Tracing/Debug Eventlogs
so they add little value in this
Security Auditing is primarily collected in the hopes the customer has configured Windows Security Auditing for logon events
which sometimes helps understanding certain auth/logon failures on the Windows side of things
auditpol does not work well with GPO based Audit Policies

Hi Paul,
for the troubleshooting we dont need the Security Audit Events generated by ADFS
the context that generates these audits in the first place is already in the ADFS Tracing/Debug Eventlogs
so they add little value in this
Security Auditing is primarily collected in the hopes the customer has configured Windows Security Auditing for logon events
which sometimes helps understanding certain auth/logon failures on the Windows side of things
auditpol does not work well with GPO based Audit Policies

whilst the prototype works ..will not implement this for the following reasons
a) if we just run ADFS posh for making the changes in WId it takes up to 5 min to propagate and the script trace needs to first
be run on the primary
a1) if we  make a modification directly to the DB on the nodes ithas the potential to break the service settings
not to mention that in an SQL deployment the Account running the script needs DBA rights too
b) with the ADFS Sign In Events now fetched by AAD connect Health and pushed to AAD Sign In logs,  Verbose should be enabled  anyway by customers or should be enabled on demand for troubleshooting ahead
c)will add  a pre-check for Auditing Settings so admins can turn it on by themself


Added S3 support for datasets, refactored asset loaders

What's changing

Added S3 support for datasets
Refactored the asset loaders to (1) support S3 datasets and (2) be asset-specific. We now have one class for datasets, one for models/configs, one for tokenizers.

How to test it

Used pytest for backwards compatibility.
Manually tested S3 dataset loading in the prometheus job (we might want to rely on localstack for testing)

I have one comment to consider regarding asset loader classes vs helper functions. It's your call, so if you don't want to make the changes I can approve after your response.

Thanks Sean! As S3 support for models & co (basically anything which is not a dataset) has a dependency on an s3 client, I think it makes sense to keep this (even if I agree with you that the function approach looks cleaner!).

@aittalam whoops! Add a version bump before merging please.

@aittalam whoops! Add a version bump before merging please.

Great catch! 🙏 :-)


Is there a way to do /1vs1 join {specific_level}

For particular reasons, my server requires that you can join a specific 1vs1 world with a command. Let's say I have a 1vs1 set up in world "x", would it be possible to do /1vs1 join x, and have it take me to that specific world out of the multiple other worlds I have (y, z, a, etc), each with 1vs1 arenas?

The reason why I am asking this is that, when I tried it, it took me to a random world sometimes. It seemed like I had done nothing by adding the level name to the end of the command. If this feature really isn't available, or I'm not doing it right, please tell me or code it in. This plugin is very good and I will support your decision, no matter what it is @GamakCZ.


[feat] Support cookie subdomains

Related issue https://github.com/storyofams/next-password-protect/issues/41
Summary

Enables explicitly setting the cookie's domain.
Adds corresponding test cover.

@BJvdA mind if I ask for that workflow approval? 😁

Thanks. All set for the merge. 👏

@BJvdA I hate to be pushy but could I get an estimate on merging and releasing this?

looks good, thanks for the pr!

Great, thanks! 🎉🎉


Bloomberg

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when X happens [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Which api specifically?

https://www.bloomberg.com/professional/support/api-library/

https://www.bloomberg.com/professional/support/api-library/

you still weren't specific?
Please see http://www.catb.org/~esr/faqs/smart-questions.html

It doesn't directly work with it but from now on with v2.1.3, you can use custom data! I'll be closing this issue since the question has been answered.


update "Recommended License" to "Suggested License" in stack report

changes are in prod. closing it.


leadingIcon and similar props should pass React.ReactNode instead of components

When passing props like the leadingIcon and trailingIcon props on a button, it's not uncommon to pass something that relates to props from the containing function.
Currently, to do this one needs to wrap this in a function
<Button leadingIcon={() => getAnIconBasedOnSomething(props)} />

This leads to Button needing to render more often than necessary
we could always memoize this, of course
<Button leadingIcon={useCallback(() => getAnIconBasedOnSomething(prop1, prop2), [prop1, prop2])} />

But react already has a built in mechanism for dealing with this, components.
<Button leadingIcon={<IconBasedOnSomething prop={prop} />} />

This manages these icons, and similar (I assume in other components) in an internal way, similar to children by default, allows the parent context to control what gets rendered, rather than internalizing that to the button, and avoids the need to either bloat code by memoizing what are effectively inline components or handling these inefficiently by default
https://github.com/primer/react/blob/c3eedb23e632d73d77aa65e973c21382b8921ce3/src/Button/ButtonBase.tsx#L29-L42
could be minimally changed to support that
const ButtonBase = forwardRef<HTMLElement, ButtonProps>(
  ({children, as: Component = 'button', sx: sxProp = defaultSxProp, ...props}, forwardedRef): JSX.Element => {
    const {leadingIcon, trailingIcon, variant = 'default', size = 'medium'} = props
    const {theme} = useTheme()
    const baseStyles = useMemo(() => {
      return merge.all([getButtonStyles(theme), getSizeStyles(size, variant, false), getVariantStyles(variant, theme)])
    }, [theme, size, variant])
    const sxStyles = useMemo(() => {
      return merge(baseStyles, sxProp as SxProp)
    }, [baseStyles, sxProp])

    return (

    )
  }
) as PolymorphicForwardRefComponent<'button' | 'a', ButtonProps>

with no loss internally and more power for consumers to render what/how they need to
this would make the simple case slightly more complex - by default
<Button leadingIcon={LeadingIcon} />

we could choose to handle this internally, but checking whether react-is.isComponentTypes (any of them), and handling them separately. I don't think we should, because this is a moving target of possibility - prone to error, and the difference is minimal to consumers who are used to writing JSX when dealing with components
Components rendered this way could be memo forwardRef lazy or more, none of which are matches for the FunctionComponent interface currently, and all implement a standard that considers them React.ReactNodes

If this is a breaking change (I'm not sure just by reading through the suggestion) I happen to have a PR going with some other Button improvements. I wonder if it would be worth exploring this as well.

Some other use-cases, from the duplicate issue:

Styled icons, like the leading visual on the close/reopen issue button:
<Button leadingVisual={() => }>Reopen issue
Loading spinners for pending actions:
<Button leadingVisual={() => }>Save
Keyboard shortcut hints:
<Button trailingVisual={() => ⌘↵}>Submit


Split the data_api into its own terraform stack

This means we can make changes to the snapshot service with less risk of affecting the production catalogue API. (In particular, in a later pull request we can upgrade it to terraform 0.12!)
Follows https://github.com/wellcomecollection/catalogue/pull/491; another step towards https://github.com/wellcomecollection/platform/issues/4386
The eventual plan is to have the following folder structure in the terraform directory:

catalogue_api_shared (API Gateway, ECR repositories, ECS cluster, etc.)
catalogue_api_prod (ECS services for the prod API, alarms)
catalogue_api_staging (ECS services for the staging API)
data_api (snapshots service)
update_api_docs
modules (for shared pieces)

And then each of those can be rolled to terraform 0.12 independently (and in particular, the first time I hit apply I won't be affecting the production API!).

Just questions from the description rather than the code:

Why does API gateway have to be shared? Each env has it's own gateway?
ECR repos, I think, are all in platform. Do you have a separate ECR registry in storage? And should we? It might complicate deployment tooling unnecessarily.
Why no alarms on staging? Rather get them there before we prodify. Maybe round two when looking at monitoring of services, where we should monitor both.

Otherwise this feels like it'll give us way more confidence!

Currently the two environments share an API Gateway. I’m not opposed to changing that, but I’m trying to change as little other stuff as possible right now.

We have a separate ECR registry for the storage account, yep – because everything in the storage repo publishes into that account. This repo is kinda a weird hybrid of platform/catalogue.
(But doesn’t really affect this – we have one ECR repo for API images, prod and staging alike.)

That’s the way it’s always been; again, open to changing but not right now.