Scroll to top and bottom of notebooks

Working through DockYard's Elixir curriculum, I've needed to quickly scroll to the top and bottom of notebooks as there is different navigation at both ends. Some good examples of where this is useful are the course outline at https://github.com/DockYard-Academy/beta_curriculum/blob/main/start.livemd or https://github.com/DockYard-Academy/beta_curriculum/blob/main/reading/recursion.livemd.
I apologize, this state is pretty rough as I got bit by multiple naming conflicts. I reused the move focus functionality to perform the scrolling. These aren't indicators but buttons. It's not technically the head since it's hardcoded to focus on the 1st cell below the setup area, so moveFocusToHeadOrTail is awkwardly named. The keys f, u for focus up, and f, d for focus down are also awkward and I just realized all of the double keys are on the right-hand side of the screen when you bring up the help with ?.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @w0rd-driven, thank you for the PR!
I am not sure if we should include this feature. All browsers natively have the ability to scroll to bottom and top (on a Mac you can do cmd+up/cmd+down) and, while I understand that making the buttons is more convenient, there are only so many buttons we can have in the UI before it feels cluttered and I think those are not particularly the ones we should focus on.
We could add some shortcuts under the "Sections" pane though, so we have:
Sections         [DOWN] [UP]

But I am not sure if hiding it under the pane makes it as useful.

I understand the indicator section is extremely limited real estate. I only recently learned cmd+up and down map to home and end on macOS so it's possible I didn't really get it working as I expected before just now confirming it.
I personally could have use for it as only keyboard combinations like focus next and previous cell. But it's also possible I just don't have a quick way to break out of a cell for when I don't want to use the home/end keys inside it.
I'll try working with cmd+up and down more to see if I'm stumbling on something basic.

Home/End (or the respective shortcuts) should do the job on any page, I'm not convinced we we should have additional controls/shortcuts for that.

I just don't have a quick way to break out of a cell for when I don't want to use the home/end keys inside it.

What do you mean? If you are editing inside the editor then the livebook navigation shortcuts don't work anyway, and you can except the insert mode with Escape, and a second Escape should unfocus the cell entirely :)

Home/End (or the respective shortcuts) should do the job on any page, I'm not convinced we we should have additional controls/shortcuts for that.

I've been using macOS for 8 years and I've only known about cmd+arrow for the last week or so. Even pointing that out in the shortcut section is probably overkill, especially since I'm probably the first/only person to bring this up. Now I'm not convinced either.

What do you mean? If you are editing inside the editor then the livebook navigation shortcuts don't work anyway, and you can except the insert mode with Escape, and a second Escape should unfocus the cell entirely :)

That's the piece I've been missing. I knew escape put it in navigation mode but I've been played the "did I really click out of this cell" dance.
Sorry for needing the education over the weekend. I'm fine with closing this.


update picture for david

Docs Build status updates of commit 0c9b235:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

rd/media/profiles/david-goad.jpg
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Support installation via .sdkmanrc

I'm interested in Java (via SDKMan) but this will apply to any tool available via SDKMan. SDKMan supports installing tools if those are listed in .sdkmanrc file, see the docs. So, if repositories contain .sdkmanrc with content java=21-tem then sdk env install will install Java 21 from Temurin vendor.

Hi 👋
This will be a pretty cool enhancement to the Java Feature 💡
Wondering, @eddumelendez if you'd be interested in contributing a PR with the proposed changes? We appreciate the support from the community.
Side note, the Java Feature accepts jdkDistro Feature option where you can currently specify tem for installing the Temurin JDK distro. See https://github.com/devcontainers/features/blob/main/src/java/README.md#options


Bug: FzfLua command not available when plugin is installed using rocks.nvim

RTFM Checklist

[X] I have searched exisiting issues / discussions
[X] I have read the Wiki including the Advanced section
[X] I have read man fzf / I am well versed in shell fzf

Operating system
Linux
Shell
zsh
Neovim version (nvim --version)
v0.10.0-dev-2739+ge2224a793
Fzf version (fzf --version)
0.48.0 (091b7eac)
Output of :lua print(os.getenv('FZF_DEFAULT_OPTS'))
--border
Is the problem reproducible with mini.sh?

[ ] My issue is reproducible with mini.sh
[ ] My issue IS NOT reproducible with mini.sh
[X] I have not tested with mini.sh (not relevant, requires LSP, Windows, etc)

Fzf-lua configuration
require('fzf-lua').setup({
})

Describe the bug / steps to reproduce
With rocks.nivm installed run:
:Rocks install fzf-lua

The FzfLua command is not available.

It is worth mentioning that lua require('fzf-lua').files() works just fine.
The issue is not reproduced when fzf-lua is installed using  lazy.nvim or even when in installed from the git repository with rocks-git

@mrcjkb created the lua-rocks template, do you know why this happens?
Perhaps it’s time to update https://github.com/ibhagwan/fzf-lua/blob/main/plugin/fzf-lua.vim (which creates the commands and doesn’t seem to be loaded) to lua, I wonder if that will help.

@xm31, should work after the latest commit, Ty @mrcjkb!

FYI, this prompted https://github.com/ibhagwan/fzf-lua/commit/cd966d7e556b91d56b2cf3582d1a5b4f937a8f0e so we now have auto-completion the command arguments (auto-generated from defaults):

It's also possible to supply nested options to the command such as:
:FzfLua files winopts.fullscreen=true

It sounds great! I will give it a try. Now I am waiting for the luarocks-release action to be triggered.

Ty @xm31, currently planning integration with nvim-cmp with documentation window for fzf-lua opts so it should be even better.


Pleias

Pleias has been announced! An LLM trained only on text it's allowed to train on.
It would be fantastic to have this available in ollama, especially for us folks using computers with plenty of system RAM but barely any VRAM.
Here's a list of the models: https://huggingface.co/collections/PleIAs/common-models-674cd0667951ab7c4ef84cc4

Hi! Pleias trainer here.
We have starting building a colab demo for the rag model: https://colab.research.google.com/drive/1SW97SgVRUX3nNMbHA4XBC0XNMpMqSkyI?usp=sharing
I think ideally we should connect to whatever RAG standard there is already in ollama, as the models work really best for knowledge retrieval on CPU (especially the smaller one).


Release/1.9.0

Merge release/1.9.0 into main, following the release of SDK 1.9.0

Merging without approval, as this is just part of the release process, and those changes were approved in the past.


Hugo to gene id endpoint fixes

Query in order: approved, synonym, previous symbols. This is necessary
because there is overlap between these three.
Show hugo symbol in response

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #180   +/-   ##
=========================================
  Coverage     38.25%   38.25%
  Complexity      197      197
=========================================
  Files           101      101
  Lines          1626     1626
  Branches        219      219
=========================================
  Hits            622      622
  Misses          908      908
  Partials         96       96

Impacted Files
Coverage Δ
Complexity Δ

...ortal/genome_nexus/web/mixin/EnsemblGeneMixin.java
0% <ø> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b705976...ff5dbff. Read the comment docs.


Complete docs

Pull Request Test Coverage Report for Build<PHONE_NUMBER>1
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.035%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
812

Relevant Lines:
912

💛  - Coveralls

Great! Thanks @savita. I removed the requirements list as it will easily get out of date, and people who need that generally know to look for requirements.txt.


R8 Feedback

Is your feature request related to a problem? Please describe.
It should be easy to find the justification for why data is not being used. This should be a single column,
Describe the solution you'd like

Make sure result and lab comment text are included in removal reason (the values of those columns)
Include measure qualifier code definitions on flag page and also in the spreadsheet output
Add lab comment text to Filter page

This issue will be complete when the cm-release-review-2 TADA package branch is merged.


deps(npm): pin @swc/core and @swc/jest

Closes https://github.com/datavisyn/visyn_scripts/issues/104
Developer Checklist (Definition of Done)
Issue

[x] All acceptance criteria from the issue are met
[ ] Tested in latest Chrome/Firefox

UI/UX/Vis

[ ] Requires UI/UX/Vis review

[ ] Reviewer(s) are notified (tag assignees)
[ ] Review has occurred (link to notes)
[ ] Feedback is included in this PR
[ ] Reviewer(s) approve of concept and design

Code

[x] Branch is up-to-date with the branch to be merged with, i.e., develop
[x] Code is cleaned up and formatted
[ ] Unit tests are written (frontend/backend if applicable)
[ ] Integration tests are written (if applicable)

PR

[x] Descriptive title for this pull request is provided (will be used for release notes later)
[x] Reviewer and assignees are defined
[x] Add type label (e.g., bug, feature) to this pull request
[x] Add release label (e.g., release: minor) to this PR following semver
[x] The PR is connected to the corresponding issue (via Closes #...)
[x] Summary of changes is written

Summary of changes

Jest doesn't run due to a new patch release of @swc/jest and @swc/core
This PR pins the versions to the last patch release

Screenshots
Tests are passing locally again:

Using this branch in visyn_core the Jest tests in CI are succeeding again:
https://github.com/datavisyn/visyn_core/actions/runs/11703164933/job/32592929690
Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

Closed in favor of https://github.com/datavisyn/visyn_core/pull/622.


fix(controller): support parsing github enterprise urls

Fixes #2080

Feels like this could potentially be easily backported to 0.7.1?

Feels like this could potentially be easily backported to 0.7.1?

I wouldn't have done a v0.7.1 just for this, but since we're doing one for other reasons, I'm also inclined to include it.


Terraform definition documentation

Complete documentation for the platform terraform definition at repo, in a similar way the documentation for Open Targets Platform was created.

No longer applies


Tenant Qualify Paths in autheticators / extensions

Remainder of https://github.com/wso2/product-is/issues/9051

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Revert "squash on build"

This reverts commit 9d73672dc3b6204f89d7488cfa2086b8bd453834.

seems to be causing the push job some headaches though it passed the PR tester.  reverting for now.


Duration locale data

There seems to be no non-global way to update locale data for use with Duration?
Based on .locale and .updateLocale I would assume
const en = moment
  .duration(1, "minutes")
  .locale("en", {
    relativeTime: {
      future: "in %s",
      past: "%s ago",
      s: "few seconds",
      ss: "%d seconds",
      m: "minute",
      mm: "%d minutes",
      h: "hour",
      hh: "%d hours",
      d: "day",
      dd: "%d days",
      M: "month",
      MM: "%d months",
      y: "year",
      yy: "%d years"
    }
  })
  .humanize();

Might work but it seems the full locale object isn't exposed to .duration.
.duration is also not available to a moment() instance so updating locale that way would not work either.
Am I missing something here?

I'm not sure what you're asking here.
You can get or set the duration's locale here: https://momentjs.com/docs/#/durations/locale/

Please re-open if you still have concerns.


Feat: Improve discussion tree toggling

This PR tries to make toggling of the discussion tree a little more user friendly. It will:

Enable toggling nodes from the note body
Enable toggling resolved status from child nodes
Add keymap for toggling tree type

Apart from that, it fixes a small bug which caused an error whenever the cursor moved to a file_name or path node in the "by_file_name" discussion tree.

I'm changing the way releases are handled to reduce release churn and to allow myself a non-stable development branch. Please change the target of your MR to develop instead of main which will aggregate multiple patches + such prior to release.


[TS migration] Migrate 'Composer.js' lib to TypeScript

Details

Migrated Composer.js to TypeScript
Fixed Issues

$ https://github.com/Expensify/App/issues/24824
PROPOSAL: https://github.com/Expensify/App/issues/24824
Tests

Only on smaller screens

Log in
Enter any chat room
Edit message
Verify if the main composer disappeared when edit composer is focused
Cancel message editing
Verify if the main composer appears again

[x] Verify that no errors appear in the JS console

Offline tests

Same as tests
QA Steps

Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/39538890/abe5c5eb-4c58-4002-9780-9fe9873cb657

Mobile Web - Chrome

https://github.com/Expensify/App/assets/39538890/0799406c-49b2-4559-bec0-4642eca869a3

Mobile Web - Safari

https://github.com/Expensify/App/assets/39538890/ed043d20-e25c-4529-b603-6511ed1b5b73

Desktop

https://github.com/Expensify/App/assets/39538890/6e5bab89-f68f-4fb8-a398-d11f7b669d4c

iOS

https://github.com/Expensify/App/assets/39538890/13d436d8-6f3a-47e4-b736-67b0a86722de

Android

https://github.com/Expensify/App/assets/39538890/9e0a4f92-e206-4d20-8b12-e91bb576605f

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/20051562/a9bb6d76-c4ef-4a27-9839-cfb8446255be
https://github.com/Expensify/App/assets/20051562/97b9806b-f228-4ccf-b2f2-bf6e02d1abdc

Desktop
https://github.com/Expensify/App/assets/20051562/508404c3-474f-49cc-a8cb-eec76e94db89

Mobile Web - Chrome
https://github.com/Expensify/App/assets/20051562/683f0d14-080f-4fc0-b18e-46a127f083bf

Android
https://github.com/Expensify/App/assets/20051562/2db0463f-0186-4718-b0b1-64a5d940d5d2

Mobile Web - Safari
https://github.com/Expensify/App/assets/20051562/f08bab22-d319-41e0-b6ec-ad1d2ba03836

iOS
https://github.com/Expensify/App/assets/20051562/d713b48b-7f62-4721-bb04-a01ed06d9f9e

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.68-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.70-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


Suppress unused warnings

Instead of asking all the devs to add a bunch of  __attribute__((unused)) or #pragma GCC diagnostic ignored "-Wunused-...", just add compiler flags to ignore those warnings, for the final ROM of course

Additional C flags have been removed upstream


Add table-based auxiliary value in order to store long lists of integers

This will be used by cards like Lever. This will also be used by cards like Radio Telescope once we add some sort of option to tell the interaction to select all cards IDs in the table.

I see.  I can see two possible interactions that would be useful:

Allow a user to select all of the card ids in the list regardless of where they are.  This could be helpful for Hot Air Balloon. #489
Allow repeat age selections (crossword/lever).  This would make that interaction more natural.

The only possible outstanding piece of work is the part you had about "Allow repeat age selections (crossword/lever). This would make that interaction more natural."
However, I'll close this, and we can file a separate issue for that if we want to make that improvement.


TrinoSplitManagerBase's single read batch is too large

The nextPage method of TrinoPageSourceBase reads a batch of data each time. Through debugging, I found that the batch is very large, which leads to the use of DynamicSliceOutput.writeBytes of a VariableWidthBlockBuilder object when processing strings. String writing will cause the size attribute to continue to expand and eventually exceed the maximum value of int and overflow.

@JingsongLi jin

Thanks @groobyming
Already fixed.


Add almuni section in About page

Add officers who went to big companies

Reference: https://gtios.club/

I am not able to understand the feature. Could you please elaborate!

Could you assign me this task @bnleft

Hey @bnleft, what information should each alumni include (e.g. LinkedIn, current company, officer position held)?

Yes, that should be all

Rodolfo C. - JP Morgan (SWE)
Jennifer F. - JP Morgan (SWE Intern)
Eithan A. - JP Morgan (SWE)
Tailer N. - Microsoft (SWE)
Nghia L. - JP Morgan (SWE)
Abdullah S. - Meta (SWE)
Bryant L. - Amazon (SWE Intern)
Tori N. - Oracle (Technical Consultant)
Jake B. - Boeing (SWE Intern)
Omar R. - P&G (R&D Intern)
Fernando R. - Amazon (SWE Intern)
Sana A. - Google (SWE Intern)
Ayush P. - Paycom (SWE Intern)
Benjamin G. - American Airlines (SWE Intern)
Allie R. - American Airlines (SWE Intern)


Implementation of ModuleStructure class that represents module

Methods, functions or classes to implement are as follows:

[x] #780

[x] #781

[x] #782

[x] #783

All above methods were created and checked


Improve workflow for adding conditional questions

Please complete the following fields as applicable:
What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
3.0.2
Expected behaviour:
Users find the workflow for adding conditional questions counter-intuitive. During the summer 2020 UX exercise on Roadmap v2.1.6, we performed usability tests. One of the tasks was to add conditional questions to a template. All users struggled. I took up to 11 minutes to complete.
The problem was both logical and a problem with the interface.
Users expected the following behaviour:

add question
then some soft of condition
then add a question (option) generated by the condition

For example:

add question 7
add condition 'if the answer to question 7 is No, then go to question 8'
add question 8

Actual behaviour:

add question
add options
save question
add conditions
then 'remove' any subsequent questions, as imposed by options selected (or issue email notification, which is the other option available for setting conditions)

Steps to reproduce:
Edit test template to add conditional questions

I mentioned that the interface doesn't make it easy to add conditional questions. One of them is the fact that you have to add the question and options, scroll down to save, then scroll up to add conditions. This is counter-intuitive and doesn't follow the workflow. This could be sorted out by re-positioning buttons on the page or by adding helpful on mouse-over messaging e.g. 'To be able to add conditions, you must save the question first'.
Adding on mouse-over messaging could also help with conditional questions in general. For example, if users don't understand why they can't apply any conditions, they could be reminded that they need to have no subsequent questions 'Have you added all your questions? Conditions can only apply to subsequent question in your plan.' or something similar.


Uncaught app exception

2024-05-01 18:56:12.566 Uncaught app exception
Traceback (most recent call last):
File "/Users/doudou/miniconda3/lib/python3.10/site-packages/streamlit/runtime/scriptrunner/script_runner.py", line 535, in _run_script
exec(code, module.dict)
File "/Users/doudou/project/memary/streamlit_app/app.py", line 19, in
from src.agent.chat_agent import ChatAgent
ModuleNotFoundError: No module named 'src'

To run the app: streamlit run streamlit_app/app.py (as seen in the readme)

To run the app: streamlit run streamlit_app/app.py (as seen in the readme)

@chenggangqcg I had the same issue, here's how I workaround it
It has to do with the parent directory set by os package so that the code can access the diff folders
on /streamlit_app/app.py
replace:
parent_dir = os.path.dirname(curr_dir)
with:
parent_dir = os.path.dirname(curr_dir) + '/memary'

Then,
move the data folder from /streamlit_app
to outside, at the same level as src


fix: ThemeProvider properly resync the theme

Hi everyone,
The ThemeProvider didn't always notify when the theme changed.
There was an impact on the Search card and the eye animation of the search.

Codecov Report
Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 7.45%. Comparing base (4d9c7fc) to head (e83a2a8).
Report is 182 commits behind head on develop.

Files
Patch %
Lines

...mooth_app/lib/widgets/smooth_product_carousel.dart
0.00%
4 Missing :warning:

...ckages/smooth_app/lib/pages/scan/scan_tagline.dart
0.00%
3 Missing :warning:

packages/smooth_app/lib/themes/theme_provider.dart
85.71%
2 Missing :warning:

..._app/lib/data_models/tagline/tagline_provider.dart
0.00%
1 Missing :warning:

...kages/smooth_app/lib/resources/app_animations.dart
0.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5363      +/-   ##
==========================================
- Coverage     9.54%   7.45%   -2.10%
==========================================
  Files          325     380      +55
  Lines        16411   19431    +3020
==========================================
- Hits          1567    1448     -119
- Misses       14844   17983    +3139

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


too fast rendering causes bug

Expected Behaviour
A normal ride with a train 120km/h+
Actual Behaviour
Any train above 120km/h will cause a log output about being too fast resulting in the player being stuck in the air without the train existing anymore. The server doesn't crash but you have to rejoin and fast rails are not able to be used (occurs after a distance of approximatly 800 blocks traveled, depends on the speed of the track)
I get why the problem occurs, the rendering is just to slow to handle the speed, but my question is if there's a way to fix it
Also it's kinda weird that you are stuck in the air, the world around you might or might not render at some point but you're still stuck, as if you were in the train but you can't see it, it doesn't move and you can't get out. A rejoin fixes the stuckness at least
Reproduction Steps
Steps to reproduce the behaviour:

Have a huge modpack lol (fabric)
Make a track over 1000 blocks with tracks which have a speed higher than 120km/h (and even the 120km/h got problematic after 3000 blocks traveled)
Ride the track

Crash Report (respectively log output from server since there is no actual crash)
[03:27:51] [Server thread/ERROR]: Entity moves too fast class_3222['entchenbrot'/99415, l='ServerWorld minecraft:overworld Whats poppin', x=-961.30, y=94.99, z=3555.30](0.18099419978761944, -0.001460973203421645, -61.63994587842217)6053188
[03:27:51] [Server thread/INFO]: [STDERR]: java.lang.Throwable
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_1297.md3144b7$lambda$redirectHandleCollisions$0$7(class_1297.java:16066)
[03:27:51] [Server thread/INFO]: [STDERR]:      at qouteall.q_misc_util.my_util.LimitedLogger.invoke(LimitedLogger.java:28)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_1297.redirect$cfd000$redirectHandleCollisions(class_1297.java:16064)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_1297.method_5784(class_1297.java:623)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_3244.method_12063(class_3244.java:893)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_2828.method_12272(class_2828.java:114)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_2828$class_2830.method_11054(class_2828.java:16)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_2600.method_11072(class_2600.java:21)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_3738.run(class_3738.java:18)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_1255.method_18859(class_1255.java:151)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_4093.method_18859(class_4093.java:23)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:788)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:164)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_1255.method_16075(class_1255.java:125)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:770)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:764)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.class_1255.method_18857(class_1255.java:134)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:749)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:701)
[03:27:51] [Server thread/INFO]: [STDERR]:      at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:270)
[03:27:51] [Server thread/INFO]: [STDERR]:      at java.base/java.lang.Thread.run(Thread.java:833)
Environment

Minecraft Version: Fabric 1.17.1
Installed Mods: many, including mods which create some heavy world gen which results in lags sometimes (so I guess the server just hates it being too fast, I mean that's what it's saying)

Additional Information
My question would be if there is a way for me to fix it, like playing around with some settings or if I just have to live with my trains not being able to make more than 80km/h
Or is there a plan for a version which could resolve this problem
Thanks in advance! This is one of the best mods ever and I played with it's features all day long

Interesting, we could talk this over in our discord server. Ngl, this is quite new, possibly this is a server-side issue. Though I am also suggesting that maybe a lack of processing power from your computer as well; anyways join your discord here. https://discord.gg/gCFEzFTX. Thanks!


Error: 400-InvalidParameter, The maximum limit of 0 for Service gateway per VCN has been exceeded

terraform apply in Sandbox fails with:
│ Error: 400-InvalidParameter, The maximum limit of 0 for Service gateway per VCN has been exceeded in VCN ocid1.vcn.oc1.ap-sydney-1.amaaaaaa63mv4jyar22bcoqi6dyfu72e72k76nsn6tliwarj4jgfrr6qr5sq.
│ Suggestion: Please update the parameter(s) in the Terraform config as per error message The maximum limit of 0 for Service gateway per VCN has been exceeded in VCN ocid1.vcn.oc1.ap-sydney-1.amaaaaaa63mv4jyar22bcoqi6dyfu72e72k76nsn6tliwarj4jgfrr6qr5sq.
│ Documentation: https://registry.terraform.io/providers/oracle/oci/latest/docs/resources/core_service_gateway
│ API Reference: https://docs.oracle.com/iaas/api/#/en/iaas/20160918/ServiceGateway/CreateServiceGateway
│ Request Target: POST https://iaas.ap-sydney-1.oraclecloud.com/20160918/serviceGateways
│ Provider version: 5.46.0, released on 2024-06-12. This provider is 1 Update(s) behind to current.
│ Service: Core Service Gateway
│ Operation Name: CreateServiceGateway
│ OPC request ID: 764fb3f44507756aead7a326604ffcec/0D8E47689276E8B08E5EEA175F5DB892/AB188833BC2BFA96ACA99682C9A91536
│
│
│   with oci_core_service_gateway.test_service_gateway,
│   on main.tf line 71, in resource "oci_core_service_gateway" "test_service_gateway":
│   71: resource "oci_core_service_gateway" "test_service_gateway" {

According the following OCI CLI query, there is no limit available for service gateway:
printf -v query 'data[?contains("service-name",%s)].{"Name":name,"Description":description}' "'vcn'"
oci limits definition list --compartment-id ${tenancy_ocid} --query "${query}" --all --output table

The output is:
+--------------------------------------------------------------+----------------------------+
| Description                                                  | Name                       |
+--------------------------------------------------------------+----------------------------+
| Max byoip ranges per region per tenant                       | byoip-ranges-per-region    |
| DHCP Options (per VCN)                                       | dhcp-option-count          |
| FlowLogConfig Count                                          | flow-log-config-count      |
| Internet Gateways (per VCN)                                  | internet-gateway-count     |
| Max compartment limit for IP Inventory per region per tenant | ip-inventory-compartments  |
| NAT Gateways (per VCN)                                       | nat-gateway-count          |
| Max public ip pools per region per tenant                    | public-ip-pools-per-region |
| Reserved Public IP Count                                     | reserved-public-ip-count   |
| Route Tables (per VCN)                                       | route-table-count          |
| Security Lists (per VCN)                                     | security-list-count        |
| Subnets (per VCN)                                            | subnet-count               |
| Virtual Cloud Networks Count                                 | vcn-count                  |
+--------------------------------------------------------------+----------------------------+


Implemented check_disk_space function

Addressing #1551.

#1551

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@Wauplin many thanks for your detailed review comments. I'll attend to them soon.
What I realised is that I haven't added any test cases to test_file_download.py...
Would you have pointers for creating test file storage of a specific size in the testing environment?
So I could check for cases where enough space is available and where there is not?
Would you also want to have these helpers added to __init__.py?

Good questions!

Would you have pointers for creating test file storage of a specific size in the testing environment?
So I could check for cases where enough space is available and where there is not?

What I would do is to test the helper individually and not the end-to-end process of downloading a file.

I would define a new class TestDiskUsageWarning(unittest.TestCase) in test_file_download.py
I would 1 test where the free disk space is ok, 1 test where the free disk space is too low
Instead of artificially reducing the disk space to make the tests work, I would mock the shutil.disk_usage method.

To mock functions, you can use unittest.mock.patch. Instead of running disk_usage, the test will simply use the mock value. This is done for example here. In your case, you will decorate your test with @patch("huggingface_hub.file_download.shutil.disk_usage"). Then the test takes as input a Mock object on which you can set a specific return value (for instance: mock.return_value.free = 1024 * 1024 to simulate the fact that there is 1MB left on disk). When you call _check_disk_space afterwards, it will use this mocked value. Hope these explanations are clear enough. You can also look at the Python docs and check some examples in huggingface_hub.

Would you also want to have these helpers added to init.py?

No need for that! It's a small private helper so it's better to not expose it :)

Hi @Wauplin,
I believe I have addressed all your review points.
The only remaining point from my side:
When I run make quality, I receive the following messages:
src/huggingface_hub/file_download.py:977: error: Unsupported operand types for >= ("int" and "None")  [operator]
src/huggingface_hub/file_download.py:977: note: Right operand is of type "int | None"
src/huggingface_hub/file_download.py:981: error: Unsupported operand types for / ("None" and "float")  [operator]
src/huggingface_hub/file_download.py:981: note: Left operand is of type "int | None"
src/huggingface_hub/file_download.py:986: error: No return value expected  [return-value]

Is this something I need to address?
Thank you!

Oh, actually another question:
I did add a third test case when free disk space is exactly the size of the expected file size.
Do you think that adds value or not?

Addressed nearly all of the review points.
I need to read up on testing for warnings with self.assertWarns and address the outstanding right afterward.

I suspect we don't really have a warning with logger.warning? I might need to provide a mock logger and check that one as part of the test.


enable python version 3.10.0 or later

#3

#5
Constrain scipy version 1.13.* so that scipy can import LineSearchWarning.


Created Peerunity Theme.  Contains new icons, modification to global

color constants, and some edits to bitcoingui.ccp to load the
stylesheets and new fonts.  Packaged with WeblySleek UI Normal font and
Font Awesome icons.
Updated QSS and Changed Toolbar Properties
Updating Overview Page
Finished OverviewPage, changed some icons.
Packaged and applied a global font. Started on Sendcoinsdialog
More icon replacements, skin tables, and more controls.

@SigmundAlpha , awesome work! I'm going to work with the team to release 0.1.2 in the next day, and then I'll open up a new 0.1.3-RC1 branch that has the new theme integrated into it. Presuming that the testing goes as expected, 0.1.3 will be released very soon after that.

Wow this looks really good. I love it.

@brossi glad you like it.

Leave it open for now. It will need to be merged against master

Very nice :+1:

Merged in commit 135d683fec6058f9b9056e90eee73431020171e4


MB-1407 Optimistic locking with If-Match

Description
We're now using the If-Match header with base64 encoded timestamps for optimistic locking. It's also in the query builder so we don't have to think about the details of locking in handlers/service objects.
Reviewer Notes
Do the updates to the ADR and the addition of the how-to doc adequately explain things?
Setup

make db_dev_e2e_populate
make server_run
make client_run
Visit officelocal:3000/ghc/v1/docs
Get the move task order id from the existing mto_shipment and execute the GET /move_task_orders/{moveTaskOrderID}/mto_shipments request. You should get an array with one shipment that contains an eTag field, that will be important in the next step.
Execute the the request on the PATCH /move_task_orders/{moveTaskOrderID}/mto_shipments/{shipmentID}/status endpoint with a Body like:  {
    "moveTaskOrderID": "1f2270c7-7166-40ae-981e-b200ebdf3054",
    "id": "1f2270c7-7166-40ae-981e-b200ebdf3054",
    "scheduledPickupDate": "2020-02-03",
    "requestedPickupDate": "2020-02-03",
    "customerRemarks": "handle with care",
    "status": "REJECTED"
  }

and fill out the appropriate eTag, moveTaskOrderId, and ID fields. It should return a 200 OK
If you retry the same exact request, you'll receive a 412 precondition failed since the If-Match header is now stale. Consider our locking optimistic 😎

Code Review Verification Steps

[x] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

@tinyels question for you (we might have discussed this already, but I don't remember what we decided on): for endpoints that return a single record, should we be consistent and return the etag as part of the payload, or in the ETag header? In reading about how others do this, it seems like the header is the preferred way, but it strikes me as a bit confusing. Thanks to @donaldthai and @Ryan-Koch for pointing this out.

@tinyels question for you (we might have discussed this already, but I don't remember what we decided on): for endpoints that return a single record, should we be consistent and return the etag as part of the payload, or in the ETag header? In reading about how others do this, it seems like the header is the preferred way, but it strikes me as a bit confusing. Thanks to @donaldthai and @Ryan-Koch for pointing this out.

Let's pick what makes sense to you now. If the prime contractor wants us to switch later, I can't imagine it would be hard.


remove dublicated methods

@lmikelionis can you give us information, on why Tests/app/data/dummyData.sql was created? Is it hand crafted sql data for additional testing?

@tautrimas: no idea, wasn't me, i haven't work with OXID...

Please leave schema and data sql insertions in different files. Also for testing do you need the whole tables? Please remove not necessary from database.sql.


3D Tiles binary functions

For #4643
This PR supports four binary functions via a data-driven approach:

atan2
pow
min
max

Here are some screenshots:

Also make sure you have merged the latest 3d-tiles into this branch. The frameState is now required by all the evaluate functions.

@lilleyse Updated, but integration check is still failing. Not sure what the problem is.

It looks like you just need to add spaces after the commas in the expected strings.

And min(3,5) should be min(3.0, 5.0).

@lilleyse Updated, still failing. I checked the log and I don't think it's one of my tests that's failing.

There are jsHint errors.

Thanks, I see it now. Is there anyway to tell exactly where in Expression and ExpressionSpec things are failing?

There should be line numbers corresponding with the errors. Also if you run jsHint locally it should tell you as well.

@lilleyse Think I fixed it!

Looks good @leesafini!


skypeforlinux: <IP_ADDRESS> -> <IP_ADDRESS>

Motivation for this change
Supersedes #135980.
I am not a user of this, but at least it is able to build and run now I guess. @PanAeon
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Checked basic audio call functionality, seems to be working fine.

Thanks!

Apologies if this is the wrong way to ask, but will this change be made available in 21.05? Skype is broken for me on that branch currently.

Apologies if this is the wrong way to ask, but will this change be made available in 21.05? Skype is broken for me on that branch currently.

@philipstears Is it not able to build or not able to launch, can you provide some logs for that? Tested on a 21.05 VM, and the <IP_ADDRESS> skype builds and runs for me so i am not sure.

My apologies - I forgot I had an override for Skype, and it looks like some mirrors for Skype sources were added that I don't have.
Although the version of Skype specified in 21.05 has dropped out of Microsoft's repository, it is in one of the fallbacks, so there is no need to do anything.
Sorry!


Glitching component output on 1.0 ?

Hi, thanks for the great project and awesome modchip.
I have a 1.5 which works very fine, no problem here. However, I made a second chip for a 1.0 but the component output is glitching. I can hear the thing is booting fine and the menu is working. The cable works on the 1.5 without an issue.
Any idea?

Nevermind the xbox was set to 720p, it worked fine on another tv.


[5.0] Marshalling arguments to commands failed if the argument evaluated to fa...

When trying to marshall arguments to command constructors in getParameterValueForCommand(), empty strings, integer 0, bool false etc would all cause an exception to be thrown, suggesting the argument was missing.
Fixed the problem and added a test to verify the behaviour.

:+1:

Note that you still can't pass NULL as a value to a command, but I couldn't see a simple way of fixing this.


tests: drop extra [Serial] string from spec name

What this PR does
This is not needed anymore as ginkgo's serial decorator
adds a label now too: https://github.com/onsi/ginkgo/pull/1484

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

NONE

/test pull-kubevirt-e2e-k8s-1.31-sig-compute-serial
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-compute
/cc @brianmcarey @dhiller

/test pull-kubevirt-e2e-k8s-1.31-sig-compute-serial
/test pull-kubevirt-e2e-k8s-1.31-sig-storage
/test pull-kubevirt-e2e-k8s-1.31-sig-compute-migrations
/test pull-kubevirt-e2e-k8s-1.31-sig-network
/test pull-kubevirt-e2e-k8s-1.31-sig-compute

There still seems to be some disrepancy between the serial run in this PR and the previous merge:
Will run 188 of 1431 specs
While this normally is 184

There still seems to be some discrepancy between the serial run in this PR and the previous merge: Will run 188 of 1431 specs While this normally is 184

See the last commit for an explanation of the discrepancy

Looks wonderful! Can we adjust the tests/README.md too? Thank you

done

/cc @iholder101

Awesome stuff @akalenyu! Kudos!!
/approve

@EdDev @fossedihelm small conflict in tests/network/bindingplugin.go due to https://github.com/kubevirt/kubevirt/commit/581ee68c7868cd7ea2e575d7a16ba02f4ceeb701#diff-6908ec12a3bf74f9420e69e25c52eefee7906bfe638fbf10a1718940ecafdff0

/lgtm

/retest

/lgtm
Sunday is a good time to avoid conflicts hopefully :) :crossed_fingers:

@EdDev @fossedihelm small conflict in tests/network/bindingplugin.go due to 581ee68#diff-6908ec12a3bf74f9420e69e25c52eefee7906bfe638fbf10a1718940ecafdff0

yet another rebase. similar conflicts

/test pull-kubevirt-e2e-k8s-1.29-sig-compute


Test if timeinstk is opcode-relative

just delay invoking Taphath till after the first k-cycle and see if the pitches array gets initialized

hbout:
kcheck = 0
if kcheck = 0 then
[this executes at the first k-cycle for the opcode]
kcheck = 1
endif

timeinstk IS relative to the opcode. Probably still gonna change it though, it's one operation less!
sr = 44100
ksmps = 441

opcode Relative, k, 0
ktime timeinstk
xout ktime
endop

instr 1
kInstrTime timeinstk

if kInstrTime > 3 then
    kOpcodTime Relative
endif

printks "Instrument: %f, Opcode: %f\n", 0, kInstrTime, kOpcodTime
endin

This prints:
Instrument: 1.000000, Opcode: 0.000000
Instrument: 2.000000, Opcode: 0.000000
Instrument: 3.000000, Opcode: 0.000000
Instrument: 4.000000, Opcode: 1.000000
Instrument: 5.000000, Opcode: 2.000000
Instrument: 6.000000, Opcode: 3.000000
Instrument: 7.000000, Opcode: 4.000000
Instrument: 8.000000, Opcode: 5.000000
Instrument: 9.000000, Opcode: 6.000000
Instrument: 10.000000, Opcode: 7.000000


A lot of Features of this mod don't work on the 1.2.0 Beta

I wanted to prepare for the DLC with some new Character Ideas and noticed that a lot of things just are not there. All the Limitless Mythic Feats added by this mod are not there. I can't find Feral Combat Training in the normal Feats. The Kineticist Background seems to be missing aswell.

I usually update when it's released. I like to avoid having to fix it more than once, in case there are major changes during development.
This means the latest version isn't immediately available. But GOG doesn't force updates, which is really nice. Steam is really annoying in that regard.
I would take a look at these future changes, but I couldn't find a beta channel for GOG users. Wouldn't be the first time Owlcat leaves GOG out of beta. So, if you find the beta channel password, I will look at it. Otherwise we are out of luck.

As far as i know, the Beta is Steam only. Oh well, then i just write the Ideas down. not the World.


README error

Hello,
I think your install process should read
gt clone https://github.com/ivyl/redmine-gitolite.git
instead of
git clone git://github.com/ivyl/redmine-gitolite.git
Thank you

[ l1@lovecraft ~ ] $ git clone git://github.com/ivyl/redmine-gitolite.git
Cloning into 'redmine-gitolite'...
remote: Counting objects: 876, done.
remote: Compressing objects: 100% (369/369), done.
remote: Total 876 (delta 491), reused 859 (delta 474)
Receiving objects: 100% (876/876), 95.07 KiB, done.
Resolving deltas: 100% (491/491), done.
[ l1@lovecraft ~ ] $ rm -fr redmine-gitolite/
[ l1@lovecraft ~ ] $ git clone https://github.com/ivyl/redmine-gitolite.git
Cloning into 'redmine-gitolite'...
remote: Counting objects: 876, done.
remote: Compressing objects: 100% (369/369), done.
remote: Total 876 (delta 491), reused 859 (delta 474)
Receiving objects: 100% (876/876), 95.07 KiB | 129 KiB/s, done.
Resolving deltas: 100% (491/491), done.

HTTPS is currently "the way". I will change this with next commit.


mmdet_handler.py  and fuse_conv_bn

It seems that the mmdet_handler.py script used with TorchServe export does not include the use of mmcv.cnn.fuse_conv_bn. Is there any reason not to add this and also wrap the model in it? I just want to make sure I'm not missing a reason why it might have been intentionally left out.

Maybe earlier implementations missed it


German navigation

What: Added German translations for navigation
Why: Because there was not German translation for the navigation.
How: I translated the navigation markdown files into German.
As best as I can tell, the default content will show through if there's no page content behind it?? This is not the way it works in development. In development the page urls simply break if I run the test with Lang=de

Awesome! Thank you so much!!!

In development the page urls simply break if I run the test with Lang=de

Run with LOCALE=de

The translations work for the nav with the LOCALE (that's what I meant :)) but when I tried to navigate, the pages themselves weren't there

Yeah, that error is probably because the footer yaml was invalid. I should probably improve error messages :smile:

Thanks @karsasmus!

@motleydev, do you mind adding @karsasmus to the contributors as a reviewer? Thanks so much @karsasmus!

@kentcdodds Sure! How? If I scroll to the top it shows him listed under a reviewers section?

Oh, I'm talking about contributors on the repo (instructions) :smile:

Aha. :) Was wondering what magical github feature you were referring to.

Wonderful! Thank you all very much!


Bug: Transloco-keys-manager 6.1.0 and jsverse transloco 7.5.1 don't work together

Is there an existing issue for this?

[X] I have searched the existing issues

Is this a regression?
No
Current behavior
i18n:find fails after the update of the both packages.
Message
Warning: command "transloco-keys-manager find  --project test-app  -e --config /" exited with non-zero status code
Expected behavior
Shouldn't fail with the message. It works with Transloco-keys-manager 6.0.0
Please provide a link to a minimal reproduction of the bug
Not needed
Transloco Config
No response
Debug Logs
No response
Please provide the environment you discovered this bug in
Transloco: 7.5.1
Transloco Keys Manager: 6.1.0
Angular: 19.8.14
Node:
Package Manager: 20.3.0
OS:

Additional context
No response
I would like to make a pull request for this bug
No

@Nijaz-Zaljevic Can you run it with debug and share more information?

Sure, but first, is there a newer way to activate the debug logs?
"i18n-find": {
"executor": "nx:run-commands",
"options": {
"commands": [
{
"command": "DEBUG=* transloco-keys-manager find  --project -e --config /"
}
]
}
},
This doesn't work, it leads to this:
'DEBUG' is not recognized as an internal or external command,

@Nijaz-Zaljevic And what if you run it directly and not via nx? Debug with tkm should work.

@shaharkazaz it doesn't matter if I run it directly inside the terminal or if I replace the i18n:find command and then via npm run, I always receive  'DEBUG' is not recognized as an internal or external command.
E.g.
"i18n:find": "DEBUG=tkm:* transloco-keys-manager find  --project project -e --config /",

"i18n:find": "DEBUG=tkm:config transloco-keys-manager find  --project project -e --config /",

Any chance you are on windows? The Debug is an env var

Okay, I got it. I would say the logs for the versions 6.0.0 and 6.1.0 are equal with one difference and that is the part with the missing keys. This comes only with 6.1.0, which then leads to a failure of the command.


Use shared renovate preset

This project should follow our shared renovate preset as other repos do

Overrides are allowed, like  assignees  😉


docs: fix link to organizations documentation

@rriski  Turns out I can't merge the PR, so if you can, please do 😊

@rriski Turns out I can't merge the PR, so if you can, please do 😊

It looks like the branch is not up to date with main, could you rebase it on latest main?

Done!

Done!

Looks like there are no changes now, the link was already updated some time ago in https://github.com/aiven/terraform-provider-aiven/pull/1761

Hey. Thanks for the contribution! It looks like it was fixed two month ago https://github.com/aiven/terraform-provider-aiven/commit/6d6f72e4915253ef8e5f57b3865b12171ae667cd
Or do I miss something?


Repository cleanup

The docs repo currently pulls in close to 150MB of object files on every git checkout. Not only that this will make it unnecessarily harder/slower for anyone to check out the repo and debug locally/contribute etc., but is also making GH Actions/builds ~30s slower, as that's how long it takes CI to clone the repo.
We should clean up the history and get rid of the unneeded files bloating the repo.

Another reason we need this is that Docusaurus uses the git history during build (not exactly sure why, contributor attributions/changelogs seem like the likely reason) and the build will report errors if .git is .dockerignored:
[ERROR] Error: Retrieval of git history failed at "/tmp/docubuild/website/docs/grav/usage/getting-started/using-the-grav-instance.md" with exit code 128: fatal: /tmp/docubuild/website/docs/grav/usage/getting-started/using-the-grav-instance.md: '/tmp/docubuild/website/docs/grav/usage/getting-started/using-the-grav-instance.md' is outside repository

While .git is excluded the total build context is less than 20MB, while the .git objects inflate that to almost 300MB:
docker build . -t subo/docs
Sending build context to Docker daemon  19.53MB
Step 1/9 : FROM node:16 as builder
...

Besides git-filter-repo, the git-sizer tool may also come handy here. GitLab's docs have a detailed writeup on reducing repository size that may come handy here as well.

Thank you for the tips! @LauraLangdon and I spent a chunk of time looking at this and found with git-sizer that at some point a node_modules folder had been committed, adding 50MB of bloat.
We ran git filter-repo as recommended, and were able to remove this.
Question is, are we meant to force push now, effectively re-writing the repo history? I've never done this, makes me uneasy 😬 I'm all for it, though!

Just in case, I've made a branch for this new history


Handle ApiKey authentication error when it is invalid.

https://github.com/world-federation-of-advertisers/cross-media-measurement/issues/839

This change is


Using sort on motor

Hi, thanks for such an amazing package. I've used it very extensively with PostgreSQL. Really made life a lot easier—just one query.
Currently, I'm using it with MongoDB using motor.
I want to sort using a key, how do I do that?
notifications = await paginate(
        collection=notification_collection,
        query_filter=query,
        params=params
    )

I want to sort the notifications based on created_at key which exist in the collection. How do I do that? Thank you in advance.

Hi @koushik355,
Unfortunately sorting is not supported at this moment.
I will try to add this feature and release it ASAP.

Thank you. @uriyyo

Hi, for pymongo, sorting is missing. Please check that. Thank you. @uriyyo

Hi @koushik355,
pymongo sort has been released, I am closing this issue.


403 error when NEXT_IMAGE_ALLOWED_DOMAINS is declared in netlify.toml

Describe the bug
Environment variable NEXT_IMAGE_ALLOWED_DOMAINS declared in netlify.toml for image handling is ignored. If it's declared in Netlify UI works fine.

or

gives a 403 error "Image is not from a permitted domain" ❌

no "Image is not from a permitted domain" error ✔
To Reproduce
Repository: https://github.com/Marcelo-Figueiredo/next-plugin-issue
Steps to reproduce the behavior:

Create a new next app
have a next/image component with src="https://randomuser.me/api/portraits/men/75.jpg"
Set the NEXT_IMAGE_ALLOWED_DOMAINS = "randomuser.me" variable in netlify.toml
Deploy to netlify with essential plugin (403 error)
Set variables in Netlify UI
Re-deploy (no 403 error)

Expected behavior
There should be no error if NEXT_IMAGE_ALLOWED_DOMAINS is declared in netlify.toml
Versions

Next.js: 10.0.6

If you're using file-based installation

netlify.toml:

[build]
  command = "yarn build"
  publish = "out"

[build.environment]
  NEXT_IMAGE_ALLOWED_DOMAINS = "randomuser.me"
  FORCE_WEBP_OUTPUT = "true"
  NODE_VERSION = "12.18.2"
  YARN_VERSION = "1.19.1"
  NETLIFY_USE_YARN = "true"

Hi. This is apparently a known issue with env vars in the toml that I didn't know about until today! I will update our docs to make that clear, and then look into a better way of handling this config.

We've released a new version of the plugin that no longer needs the env var, and instead can use the value from the next config.

Since netlify UI plugin hasn't updatet yet i've added it in netlify.toml and can confirm the issue is gone!
Thank you, awesome work!
Closing.


Publishable Key Not Accessible

Hi Adam - I'm loving this but the Stripe Publishable Key isn't passed along to your classes.  In order to get the Stripe Publishable Key, I had to edit the getAccessToken method within the OAuth2 library's AbstractProvider class. I returned the prepared variable instead of the token variable.  This is obviously a poor solution and not ideal.  I wondered if you had an alternative way to get the publishable key. Thanks!
public function getAccessToken($grant, array $options = [])
    {
        $grant = $this->verifyGrant($grant);

        $params = [
            'client_id'     => $this->clientId,
            'client_secret' => $this->clientSecret,
            'redirect_uri'  => $this->redirectUri,
        ];

        $params   = $grant->prepareRequestParameters($params, $options);
        $request  = $this->getAccessTokenRequest($params);
        $response = $this->getResponse($request);
        $prepared = $this->prepareAccessTokenResponse($response);
		return $prepared;

		/*$token    = $this->createAccessToken($prepared, $grant);
                  return $token;*/
    }```

This should resolve the issue you're having. Contexted provided in https://github.com/thephpleague/oauth2-client/issues/377
@shadle10 Thanks for using the package!

@shadle10 fixed in release 1.1.1

Thanks for the quick response and the great support @adam-paterson!

@shadle10 no problem, good luck in your application


prohibit Unicode in texts

@rultor release, tag is 0.0.7

@rultor release, tag is 0.0.7

@yegor256 OK, I will release it now. Please check the progress here

@rultor release, tag is 0.0.7

@yegor256 Done! FYI, the full log is here (took me 3min)


TEST PR - ONLY to check the deployed version of #769

Just adding this PR to be able to have a build URL to test briceida's changes
https://featuretest-769-deployed-vers.fightpandemics.xyz/
That's the URL for the current changes that BMarical has on #769

epic fail. The build didn't trigger this time 🤦


Updating notebook: zendesk_get_created_tickets

PR Template

Are there new source to raw datasets?

[ ] If yes - has a trigger been attached at the appropriate frequency?
[ ] No

Have any new tables been created in Standardised?

[ ] No
[ ] If yes:

[ ] orchestration.json has been updated and tested in Dev and has been / is about to be PRd into main
[ ] the new schema exists inside odw-config/standardised-table-definitions OR is about to be PRd into main

Make sure to run Platform Integrate and Platform Deploy to Dev at least to ensure the schema is deployed into Synapse Dev Live

[ ] Is the raw-to-standardised python script scheduled to run for this dataset grouping?

Have any new tables been created in Harmonised or Curated?

[ ] No

[ ] If yes
[ ]  2-odw-standardised-to-harmonised/py_odw_harmonised_table_creation OR 4-odw-harmonised-to-curated/py_odw_curated_table_creation are set up to run in the pipeline pln_post_deployments with the base parameter specifying the correct table
[ ] the new schema exists inside odw-config/harmonised-table-definitions / odw-config/curated-table-definitions OR is about to be PRd into main

Make sure to run Platform Integrate and Platform Deploy to Dev at least to ensure the schema is deployed into Synapse Dev Live

Have any tables changed AND/OR have any columns changed in any scripts?
We only care about new columns or columns that change type.

[ ] No
[ ] If yes:

[ ] Please set py_change_table to run in the pipeline pln_post_deployments
[ ] Please create a script to backdate and fill in this new column in Test and Prod
Only delete and recreate tables with caution!

Have any scripts run in isolation in dev? Please look at the "spark.autotune.trackingId"
- If these changes need to be reflected in Test and Prod, please add to the pipeline post-			deployment/pln_post_deployment

[ ] Yes - I have reflected this script in the pln_post_deployments pipeline
[ ] Yes - This script is part of a scheduled run and has been added to the appropriate end to end pipeline with a trigger at the correct frequency
[ ] No - This change does not need to take place in Test and Prod
[ ] No - No scripts have run

Removed hardcoded parameter.
Added table_name as a variable.
Wrapped reading data code into a function.
Dropping columns with all na values - the structure should really remain static and align with a table definition. We can change this later but it needs looking at.
Removed a couple of unnecessary import but could maybe tidy this up a bit more in the future.

We're also switching to pandas and then back to spark dataframe in the function. It would be good if we can stick to spark and perform the same actions. A future fix.


added loop through all ranks (fix report log)

Tests were not correctly processed when distributed across multiple instances - in the end reading was done through reportlog-0.jsonl, which caused the tests to fail due to JSON errors. The fix is to loop through each rank and individually construct reports by appending data from their own JSON files.
Please accept this pull request.

Thanks for the PR! Do you have an example of a test that reports the wrong thing here? This duplicates all error output, which can make the output a bit confusing.

@minrk I agree duplicating errors that occur on all processes is confusing and would not be great. However, only using rank 0 can lead to a problem if rank 0 passes the test but some other rank doesn't. For example:
import pytest

@pytest.mark.mpiexec(n=4)
def example_test():
    from mpi4py import MPI
    comm = MPI.COMM_WORLD
    assert not comm.Get_rank()

shows the test passes but of course it really only passes for rank 0.
Is there a simple way to check each log to see if it passed and show all the ones that did not?

Thanks for the example! I think it should be possible to collect all of the reports and show only either:

the first failure, if any (easy, I think)
all failures (e.g. verbose mode, opt-in)
elide identical consecutive errors, e.g. "error repeats N times" (harder, but doable. Maybe not immediately)

This now adds a few options for reporting errors via --mpiexec-report
The main thing this fixes is if rank 0 passes but another fails, the test will correctly report as a failure instead of a pass


Client check sort order should always by sort by status first (and then default to by name)

The default sort order when viewing client checks is by status first and then each set of checks with different status is displayed unsorted. It's possible to sort by name but then the sorting by status is lost.
The sort order should be by status and then whatever is manually selected (defaulting to name). The current completely unsorted view is unusable with many checks, especially when going back and forward between checks because the sort order reverts back every time.

Agree :+1:


Update .net core too

The instructions do say to upgrade the NuGet packages but you also need to change the project to .net Core 2.1 otherwise the packages will not update correctly

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1f1718fa-0745-3fee-6ef5-18e36b61fabf
Version Independent ID: fd9ef97f-4540-e624-d459-c076e94a50ad
Content: Create a bot with the Bot Builder SDK for .NET - Bot Service
Content Source: articles/dotnet/bot-builder-dotnet-sdk-quickstart.md
Product: bot-framework
GitHub Login: @Kamrani
Microsoft Alias: kamrani

This has been addressed and will be in the next publish. Thanks.


Does Psych Support Sprite Atlases?

What is your question?
Title says it all, Does Psych support Atlases? if so how do I use them?

That's basically what a sprite sheet is, all animated assets within fnf use a sprite sheet

Yeah but Sprite atlases have all the parts all separate

It's on the wiki


Golang update for security scan mitigation.

Which version of the AzCopy was used?
10.17.0
Which platform are you using? (ex: Windows, Mac, Linux)
Linux
What command did you run?
N/A
What problem was encountered?
X-ray scan reported the below security issues:
CVE-2022-41716
CVE-2022-41720
How can we reproduce the problem in the simplest way?
Doing an x-ray security scan would report the below CVEs
Have you found a mitigation/solution?
No mitigation is possible unless golang is updated.
Updating golang for azcopy_linux_amd64 to the latest available version would resolve the security vulnerabilities.
Reference:

https://github.com/Azure/azure-storage-azcopy/issues/1811
https://github.com/Azure/azure-storage-azcopy/pull/1925

AzCopy only utilizes os.Exec within the testing framework in a generally controlled environment. AzCopy does not utilize DirFS. These particular CVEs do not apply to AzCopy as an application for the end-user. Use can be continued as expected.
Action: Update Golang in 10.18.0


Changed function name

https://github.com/golang/tour/issues/536

I don't think this should be done. See my comment on the issue.

Closing this as per https://github.com/golang/tour/issues/536#issuecomment-401058809


Druid-Kafka-Indexing-Service Running Time

Hello I want to ask you a quick question about druid-kafka. I am using kafka-indexing-service and I think it works too slow. I am always sending data to kafka(using logstash) but druid takes that data every 10-12 minutes. It doesn't matter how big data is. For example, I sent a 1.5 mb file to kafka and it took 11 mins. Then I shut it down and started using logstash and sent data continuously to kafka. After 10-12 mins, druid took all data. After 10-12 mins, it took new data. I mean every 10-12 mins, it is looking for new data. I am not sure if I explained it clearly. So I am wondering:

Is it normal?
How can I make it faster?
Is it possible to make it real-time? (If there is a data in Kafka, take it immediately)*******
I look forward to hearing from you. Thank you for your time.

you doing something completely wrong.
Do you send queries to broker or historical?
Is there something in the logs?
Which version of druid do you use?

Neither. I am using coordinator. Like:

What are u looking for is there http://druid.io/docs/latest/development/extensions-core/kafka-ingestion
intermediatePersistPeriod | ISO8601 Period | The period that determines the rate at which intermediate persists occur. | no (default == PT10M)
Change it to PT10S and u will see ur date updated more often. Every 10 sec ;-)


Note that dependabot doesn't seem to flag these, presumably because they don't have formal releases.  I glanced through the new commits for these packages and didn't see anything that looked obviously risky.
Setup to Run Your Code

💻 You will need to use three separate terminals to test this locally.
Terminal 1
Start the Storybook locally.
make storybook

Terminal 2
Start the UI locally.
make client_run

Terminal 3
Start the Go server locally.
make server_run

Verification Steps for Author
These are to be checked by the author.

[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

Verification Steps for Reviewers
Just make sure all tests seem to pass.

Warnings

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 0b5aec554b25217cb4a7ca3ff2264d2d2da60b82


Create CONTRIBUTING.md

re: https://github.com/ros-industrial/ros_industrial_issues/issues/26

Sorry for the slow response, I recently got back from vacation and I had a pile of stuff to go through.
I assume this is something commonly added to ROS-Industrial repos, is that correct?

See my comment in https://github.com/ros-industrial/abb_libegm/pull/13#issuecomment-411175632.

@jontje: could you take a look at the file contributed here whether it would be OK for inclusion in this repository?

Yes, this is long overdue, I will look at it today.

Same comments as on https://github.com/ros-industrial/abb_libegm/pull/13.

Closing according to https://github.com/ros-industrial/abb_libegm/pull/13#discussion_r293834675


Remove unused fonts for Android

Similar to #475, we'll need to do the same in Android (RNE has react-native-vector-icons as a dependency and linking the library includes all which we aren't using)

Hello! I want to work on this.

When I try to commit, I've got this error.
cat: $GIT_PARAMS: No such file or directory
D:\Repositories\OS\git-point\node_modules\@commitlint\cli\cli.js:118
                throw err;
                ^

TypeError: Expected a raw commit
    at parser (D:\Repositories\OS\git-point\node_modules\conventional-commits-parser\lib\parser.js:17:11)
    at sync (D:\Repositories\OS\git-point\node_modules\conventional-commits-parser\index.js:96:10)
    at _callee$ (D:\Repositories\OS\git-point\node_modules\@commitlint\core\lib\library\parse.js:40:16)
    at tryCatch (D:\Repositories\OS\git-point\node_modules\regenerator-runtime\runtime.js:65:40)
    at Generator.invoke [as _invoke] (D:\Repositories\OS\git-point\node_modules\regenerator-runtime\runtime.js:303:22)
    at Generator.prototype.(anonymous function) [as next] (D:\Repositories\OS\git-point\node_modules\regenerator-runtime\runtime.js:117:21)
    at step (D:\Repositories\OS\git-point\node_modules\babel-runtime\helpers\asyncToGenerator.js:17:30)
    at D:\Repositories\OS\git-point\node_modules\babel-runtime\helpers\asyncToGenerator.js:28:13
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

husky > commit-msg hook failed (add --no-verify to bypass)
C:\Users\Dyesse YUMBA\AppData\Local\Yarn\config\global\node_modules\commitizen\dist\cli\strategies\git-cz.js:102
        throw error;
        ^

Error: git exited with error code 1
    at ChildProcess.<anonymous> (C:\Users\Dyesse YUMBA\AppData\Local\Yarn\config\global\node_modules\commitizen\dist\git\commit.js:50:26)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

D:\Repositories\OS\git-point>

Can somebody help me?
I'm using Windows 10, node 8.7 and yarn 1.2.1

@dyesseyumba I'm not on windows, but you can add --no-verify to your commit to bypass commitlint

Thank you so much @dyesseyumba 🙌 And WELCOME to the family.
Yeah we have a git commit hook that has errored for a few individuals time to time 😞  In the meantime if your commit follows the convention manually, you can use --no-verify as @machour suggested until we can figure out why you're seeing that error.

Closed in #512 by @dyesseyumba
❤


first pass on Bug 3964 recovery

don't do anything fancy, just try all possible device XORs
don't try to upgrade the keyring file or the secret store

r? @patrickxb
I think I might just leave this here, and postpone any secret file rewriting until a later job.  So once you're in this situation, you stay there until you change your passhrase or otherwise reencrypt your key.
Note that there is a big problem I just thought of --- this corruption can spread virally across all of your devices, since you can sync your bad secret store to another device, even with a fixed client, via the same mechanism.  I'm not quite sure how to solve that situation in general. But weirdly, this recover codepath will solve that problem (unintentionally).

C/I failures are unrelated KBFS failures :/

So if someone is stuck, we tell them to change passphrase?

No, with this patch, it "just works."   We try to decrypt with what we guess is the corrupted fullSecret.  I did actually test it successfully on one of my repro cases.
What this patch doesn't try to do is to fix the situation going forward.  It always applies the recovery option.


⚠ Bofrost.be has degraded performance

In 7331063, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2563 ms

Resolved: Bofrost.be performance has improved in a0bbe2b.


This repository is dead

Move along, the software doesn't work for up to date TVs and is no longer being maintained.

Super dead. I tried 3 TVs. One 8500 from 2016, another 2018 Q9FN and another 6290 from 2019. None of them work. I doubt it actually worked in the first place since it fails even on 2016 ones and up.

That's the problem if you skip anything's official way and you turn to 3rd party solutions. You never can be sure, the project owner won't leave alone. This is a risky way, sadly.
Github is full of great stuff, but a lot of already are dead.
If I were Github staff, I'd bind project owners to get their projects ceased in a good way and archive the project. There's no sign this project is dead, it seems, it is still under development. This is the betrayal of the users.
@Ape please inform your users properly, maintain or archive the project, otherwise we'll report you at Github.

https://github.com/tavicu/homebridge-samsung-tizen
The above is the ONLY active project I know of for any platform that can control most Samsung TVs.


Add basic components and fix workflow

Workflow is not allowed to push to a commit on a pull request.


Version of ZoomSDK is too low

When i try to join a meeting not load and receive an error MEETING_STATUS_UNKNOWN - Version of ZoomSDK is too low, how i can upgrade zoomsdk to latest?

Apologies for the late reply. This seemed to be temporary error due to an issue on Zoom's side. I have, in any case, bumped the SDKs to the very latest (5.14.5) for both Android and iOS.

Please also note the following:
Please be aware that in order to update the SDKs you need to completely remove the dependency-
flutter_zoom_sdk:
git:
url: https://github.com/craigspicer/flutter_zoom_sdk.git
ref: main
Then add the dependency back and run:
flutter pub run flutter_zoom_sdk:unzip_zoom_sdk
You will see console messages with information about the MobileRTC files being downloaded. The SDKs DO NOT automatically keep themselves up to date on your local machine.
The latest Zoom SDKs also do not seem to work on debug builds.

i have used the same package of zoom sdk 1.1.0+4 and also import the unzip_zoom_sdk , but when i click on join button it give me this error MEETING_STATUS_UNKNOWN - Version of ZoomSDK is too low, and MEETING_STATUS_IDLE.

No - do not use flutter_zoom_sdk: ^1.1.0+4. This package is using far outdated SDKs. As mentioned above, uou need to use my fork:
flutter_zoom_sdk:
git:
url: https://github.com/craigspicer/flutter_zoom_sdk.git
ref: main
Please follow the instruction in my comment above.

Hi Now I have used this
flutter_zoom_sdk:
git:
url: https://github.com/craigspicer/flutter_zoom_sdk.git
ref: main
but when i click on join button app will crash and give me  this error

Please try to run a release build on a real device. Not a debug build.

ok I will try that also but can you please tell what is this issue when click on join button app crashes  and i have also change the build.gradle minisdk version 23  then also getting this error :-

I have try with the release build also getting the same error app crashes when click on join button


implemented review suggestions

implemented review suggestions

@akaszynski the review suggestions are implemented, not sure why the pipeline fails here. Can you please check?

Hey @ayush-kumar-423 , I don't know if you noticed but the doc generated by the pipeline is not actually not there.
There is a problem currently with the doc generation, despite the job saying it passes. (see here)
I am investigating what the problem is (see #429 )


uzbl: Fix wrong python site-package path

Motivation for this change
Uzbl fails to build because of wrong python site-package path ('python3.5' expected vs 'python3.4' as it is now). An alternative fix would be specifying the python version to be used as 3.4.
Things done

[ ] Tested using sandboxing
(nix.useChroot on NixOS,
or option build-use-chroot in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

please use $out/python.sitePackages instead.
https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/python/3.5/default.nix#L112

in this case that would be python3.sitePackages

This looks ready to me, is it? @HappyEnte please squash the commits.

just having a closer look at this package, and there's more wrong with it. The expression mixes python 2 and 3. Python packages are added as buildInputs, which is wrong, since it will need pygtk during runtime.

Fixed with bae6ad8efa7aa085f39f6a024f3c06f546b75227


Support Twitch Broadcasts and Vods

Right now, this only supports clips, let's expand it to include broadcasts and vods.

Closed by #11


feat: openai-like embedding model support

Support OpenAI-Like embedding models, one of them is ZhipuAI. https://github.com/pingcap/tidb.ai/issues/373


Classify newlines as whitespace in the classifier.

Fixes #1997

Add a test.

:+1:

Pull in changes for this, let's get it in.


[Refactor] (inverted index) Refactor Inverted index file writer (#41625)

pick from mater #41625

run buildall

run buildall


[Feature Request]: Bestsellers & Top Rated: A section highlighting bestsellers and top-rated books with ratings and short reviews could give users a good starting point for exploring books.

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Bestsellers & Top Rated: A section highlighting bestsellers and top-rated books with ratings and short reviews could give users a good starting point for exploring books.
Use Case
The "Bestsellers & Top Rated" section is designed to give users a curated selection of highly popular and well-reviewed books. By providing a quick view of trending and top-rated titles, it helps users make informed choices without extensive browsing. This feature appeals to users looking for recommendations, trending books, or trusted reads based on community feedback.
Benefits
Advantages:
Enhanced User Experience: New visitors can easily find popular books without extensive searching. This streamlined approach reduces decision fatigue, making it easier for users to choose a book.
Increased Engagement: Displaying highly-rated books with reviews encourages users to explore more. It keeps users on the platform longer, as they’re more likely to discover books that fit their interests.
Social Proof: Seeing high ratings and positive reviews for certain books builds trust. Users are more likely to choose a book if others have given it positive feedback, leveraging the psychology of social proof.
Boosts Sales and Conversions: Showcasing bestsellers and top-rated books can lead to more purchases, as users are more inclined to buy books that others recommend or are currently popular.
Guided Browsing for New Users: New users may not know what they're looking for or might feel overwhelmed by the options. This section provides a helpful starting point by narrowing down their choices to popular and well-reviewed books.
Encourages User-Generated Content: This feature can motivate users to leave ratings and reviews for books they've read, further enriching the community and keeping the content fresh.
Promotes Discoverability of Lesser-Known Books: In addition to popular bestsellers, this section could occasionally highlight hidden gems with high ratings, helping users discover quality books outside the mainstream.
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@Shazia-Ilme go ahead, assigned to you, also please don't chat gpt anything