JBD_BLE battery temperature shown as MOSFET temperature in GUI

Is your feature request related to a problem? Please describe.
I Can't use new temperature protections functionality due to wrong BMS temperature assignments. Seems that driver detects first temperature sensor as MOSFET temperature but actually many batteries in the market instead of MOSFET NTC, they have  just a termoswitch that triggers upon certain temperature. So in those BMSs, the temperature sensor is attached to the cells and not the MOS. My BMS is for instance, JBD DP04S007. Quite common model.
Describe the solution you'd like
Option to select if NTC 1 Correspond to a Cell or MOSFET
Describe alternatives you've considered
No response
Additional context
No response

Since there are a few BMS that have a different temperature sensor order maybe it would be an idea that there is a default sensor association which you can overwrite in the config file.

Can you please share a screenshot of the dbus-spy where we can see /System values?

com.victronenergy.system
Ac/ActiveIn/Frequency                                                                                50.1026
Ac/ActiveIn/L1/Current                                                                                1.96
Ac/ActiveIn/L1/Power                                                                                463
Ac/ActiveIn/L1/Voltage                                                                                245.3
Ac/ActiveIn/L2/Current                                                                                -
Ac/ActiveIn/L2/Power                                                                                -
Ac/ActiveIn/L2/Voltage                                                                                -
Ac/ActiveIn/L3/Current                                                                                -
Ac/ActiveIn/L3/Power                                                                                -
Ac/ActiveIn/L3/Voltage                                                                                -
Ac/ActiveIn/NumberOfPhases                                                                                1
Ac/ActiveIn/Source                                                                                3
Ac/Consumption/Frequency                                                                                49.8214
Ac/Consumption/L1/Current                                                                                0.4
Ac/Consumption/L1/Power                                                                                112
Ac/Consumption/L1/Voltage                                                                                245.3
Ac/Consumption/L2/Current                                                                                -
Ac/Consumption/L2/Power                                                                                -
Ac/Consumption/L2/Voltage                                                                                -
Ac/Consumption/L3/Current                                                                                -
Ac/Consumption/L3/Power                                                                                -
Ac/Consumption/L3/Voltage                                                                                -
Ac/Consumption/NumberOfPhases                                                                                1
Ac/ConsumptionOnInput/Frequency                                                                                50.1026
Ac/ConsumptionOnInput/L1/Current                                                                                0
Ac/ConsumptionOnInput/L1/Power                                                                                0
Ac/ConsumptionOnInput/L1/Voltage                                                                                245.3
Ac/ConsumptionOnInput/L2/Current                                                                                -
Ac/ConsumptionOnInput/L2/Power                                                                                -
Ac/ConsumptionOnInput/L2/Voltage                                                                                -
Ac/ConsumptionOnInput/L3/Current                                                                                -
Ac/ConsumptionOnInput/L3/Power                                                                                -
Ac/ConsumptionOnInput/L3/Voltage                                                                                -
Ac/ConsumptionOnInput/NumberOfPhases                                                                                1
Ac/ConsumptionOnOutput/Frequency                                                                                49.8214
Ac/ConsumptionOnOutput/L1/Current                                                                                0.4
Ac/ConsumptionOnOutput/L1/Power                                                                                112
Ac/ConsumptionOnOutput/L1/Voltage                                                                                245.3
Ac/ConsumptionOnOutput/L2/Current                                                                                -
Ac/ConsumptionOnOutput/L2/Power                                                                                -
Ac/ConsumptionOnOutput/L2/Voltage                                                                                -
Ac/ConsumptionOnOutput/L3/Current

Here is my \System
com.victronenergy.system
Ac/ActiveIn/Frequency                                                                                50.1026
Ac/ActiveIn/L1/Current                                                                                9.55Ac/ActiveIn/L1/Power                                                                                1846
Ac/ActiveIn/L1/Voltage                                                                                240.25
Ac/ActiveIn/L2/Current                                                                                -Ac/ActiveIn/L2/Power                                                                                -
Ac/ActiveIn/L2/Voltage                                                                                -
Ac/ActiveIn/L3/Current                                                                                -Ac/ActiveIn/L3/Power                                                                                -
Ac/ActiveIn/L3/Voltage                                                                                -
Ac/ActiveIn/NumberOfPhases                                                                                1Ac/ActiveIn/Source                                                                                3
Ac/Consumption/Frequency                                                                                49.9488
Ac/Consumption/L1/Current                                                                                8.91Ac/Consumption/L1/Power                                                                                1720
Ac/Consumption/L1/Voltage                                                                                240.25
Ac/Consumption/L2/Current                                                                                -Ac/Consumption/L2/Power                                                                                -
Ac/Consumption/L2/Voltage                                                                                -
Ac/Consumption/L3/Current                                                                                -Ac/Consumption/L3/Power                                                                                -
Ac/Consumption/L3/Voltage                                                                                -
Ac/Consumption/NumberOfPhases                                                                                1Ac/ConsumptionOnInput/Frequency                                                                                50.1026
Ac/ConsumptionOnInput/L1/Current                                                                                0
Ac/ConsumptionOnInput/L1/Power                                                                                0Ac/ConsumptionOnInput/L1/Voltage                                                                                240.25
Ac/ConsumptionOnInput/L2/Current                                                                                -
Ac/ConsumptionOnInput/L2/Power                                                                                -Ac/ConsumptionOnInput/L2/Voltage                                                                                -
Ac/ConsumptionOnInput/L3/Current                                                                                -
Ac/ConsumptionOnInput/L3/Power                                                                                -Ac/ConsumptionOnInput/L3/Voltage                                                                                -
Ac/ConsumptionOnInput/NumberOfPhases                                                                                1
Ac/ConsumptionOnOutput/Frequency                                                                                49.9488Ac/ConsumptionOnOutput/L1/Current                                                                                8.91
Ac/ConsumptionOnOutput/L1/Power                                                                                1720
Ac/ConsumptionOnOutput/L1/Voltage                                                                                240.25Ac/ConsumptionOnOutput/L2/Current                                                                                -
Ac/ConsumptionOnOutput/L2/Power                                                                                -
Ac/ConsumptionOnOutput/L2/Voltage                                                                                -
Ac/ConsumptionOnOutput/L3/Current
-
Ac/ConsumptionOnOutput/L3/Power                                                                                -
Ac/ConsumptionOnOutput/L3/Voltage                                                                                -
Ac/ConsumptionOnOutput/NumberOfPhases                                                                                1
Ac/Genset/DeviceType                                                                                -
Ac/Genset/Frequency                                                                                -
Ac/Genset/L1/Current                                                                                -
Ac/Genset/L1/Power                                                                                -
Ac/Genset/L1/Voltage                                                                                -
Ac/Genset/L2/Current                                                                                -
Ac/Genset/L2/Power                                                                                -
Ac/Genset/L2/Voltage                                                                                -
Ac/Genset/L3/Current                                                                                -
Ac/Genset/L3/Power                                                                                -
Ac/Genset/L3/Voltage                                                                                -
Ac/Genset/LastStartTime                                                                                -
Ac/Genset/NumberOfPhases                                                                                -
Ac/Genset/ProductId                                                                                -
Ac/Genset/RunningByConditionCode                                                                                -
Ac/Genset/Runtime                                                                                -
Ac/Grid/DeviceType                                                                                -
Ac/Grid/Frequency                                                                                50.1026
Ac/Grid/L1/Current                                                                                9.55
Ac/Grid/L1/Power                                                                                1876
Ac/Grid/L1/Voltage                                                                                240.25
Ac/Grid/L2/Current                                                                                -
Ac/Grid/L2/Power                                                                                -
Ac/Grid/L2/Voltage                                                                                -
Ac/Grid/L3/Current                                                                                -
Ac/Grid/L3/Power                                                                                -
Ac/Grid/L3/Voltage                                                                                -
Ac/Grid/NumberOfPhases                                                                                1
Ac/Grid/ProductId                                                                                9780
Ac/In/0/Connected                                                                                0
Ac/In/0/DeviceInstance                                                                                276
Ac/In/0/ServiceName                                                                                com.victronenergy.vebus.ttyS4
Ac/In/0/ServiceType                                                                                vebus
Ac/In/0/Source                                                                                2
Ac/In/0/VrmDeviceInstance                                                                                276
Ac/In/1/Connected                                                                                1
Ac/In/1/DeviceInstance                                                                                276                                                      Ac/In/NumberOfAcInputs                                                                                2
Ac/PvOnGenset/L1/Current                                                                                -
Ac/PvOnGenset/L1/Power                                                                                -
Ac/PvOnGenset/L2/Current                                                                                -
Ac/PvOnGenset/L2/Power                                                                                -
Ac/PvOnGenset/L3/Current                                                                                -
Ac/PvOnGenset/L3/Power                                                                                -
Ac/PvOnGenset/NumberOfPhases                                                                                -
Ac/PvOnGrid/L1/Current                                                                                -
Ac/PvOnGrid/L1/Power                                                                                -
Ac/PvOnGrid/L2/Current                                                                                -
Ac/PvOnGrid/L2/Power                                                                                -
Ac/PvOnGrid/L3/Current                                                                                -
Ac/PvOnGrid/L3/Power                                                                                -
Ac/PvOnGrid/NumberOfPhases                                                                                -
Ac/PvOnOutput/L1/Current                                                                                -
Ac/PvOnOutput/L1/Power                                                                                -
Ac/PvOnOutput/L2/Current                                                                                -
Ac/PvOnOutput/L2/Power                                                                                -
Ac/PvOnOutput/L3/Current                                                                                -
Ac/PvOnOutput/L3/Power                                                                                -
Ac/PvOnOutput/NumberOfPhases                                                                                -
ActiveBatteryService                                                                                com.victronenergy.battery/3
ActiveBmsService                                                                           com.victronenergy.battery.blea5c2370595b6
AutoSelectedBatteryMeasurement                                                                      com_victronenergy_battery_3/Dc/0
AutoSelectedBatteryService                                                                                -
AutoSelectedTemperatureService                                                                                -
AvailableBatteries {"com.victronenergy.battery/278": {"name": "Shunt DC", "channel": null, "type": "battery"}, "com.victronenergy.ba
AvailableBatteryMeasurements {'com_victronenergy_battery_1024/Dc/0': Battery Aggregator on dbus,'com_victronenergy_battery_278/Dc/0'
AvailableBatteryServices {"default": "Automatic", "nobattery": "No battery monitor", "com.victronenergy.vebus/276": "Quattro 12/3000
AvailableBmsServices                        [{'instance': 1024,'name': Baterias de Servicio},{'instance': 3,'name': Bateria Serv 2}]
AvailableTemperatureServices {'com.victronenergy.vebus/276/Dc/0/Temperature': Quattro 12/3000/120-2x50 on VE.Bus,'default': Automati
Batteries [{'active_battery_service': 0,'id': com.victronenergy.battery.ttyS6:1,'name': Bateria Arraque,'voltage': 14.41},{'active_b
Buzzer/State                                                                                0
Connected                                                                                1
Control/ActiveSocLimit                                                                                -
Control/BatteryCurrentSense                                                                                0
Control/BatteryVoltageSense                                                                                0
Control/BmsParameters                                                                                1
Control/Dvcc                                                                                1
Control/EffectiveChargeVoltage                                                                                14.4
Control/ScheduledSoc                                                                                -
Control/SolarChargeCurrent                                                                                1
Control/SolarChargeVoltage                                                                                1
Control/SolarChargerTemperatureSense                                                                                0
Control/SolarChargerVoltageSense                                                                                0
Control/VebusSoc                                                                                1
Dc/Alternator/Power                                                                                -
Dc/Battery/Alarms/CircuitBreakerTripped                                                                                -
Dc/Battery/BatteryService                                                                  com.victronenergy.battery.blea5c2370595b6
Dc/Battery/ConsumedAmphours                                                                                199.2
Dc/Battery/Current                                                                                13
Dc/Battery/Power                                                                                173.81
Dc/Battery/ProductId                                                                                0
Dc/Battery/Soc                                                                                70.87
Dc/Battery/State                                                                                1
Dc/Battery/Temperature                                                                                -
Dc/Battery/TemperatureService                                                                                -
Dc/Battery/TimeToGo                                                                                86813
Dc/Battery/Voltage                                                                                13.37
Dc/Battery/VoltageService                                                                  com.victronenergy.battery.blea5c2370595b6
Dc/Charger/Power                                                                                -
Dc/FuelCell/Power                                                                                -
Dc/MotorDrive/Power                                                                                -
Dc/Pv/Current                                                                                2
Dc/Pv/Power                                                                                26.9
Dc/System/MeasurementType                                                                                0
Dc/System/Power                                                                                84.3527
Dc/Vebus/Current                                                                                18
Dc/Vebus/Power                                                                                241
Dc/WindGenerator/Power                                                                                -
Debug/BatteryOperationalLimits/CurrentOffset                                                                                0
Debug/BatteryOperationalLimits/SolarVoltageOffset                                                                                0
Debug/BatteryOperationalLimits/VebusVoltageOffset                                                                                0
DeviceInstance                                                                                0
Dvcc/Alarms/FirmwareInsufficient                                                                                0
Dvcc/Alarms/MultipleBatteries                                                                                1
DynamicEss/Active                                                                                0
DynamicEss/Capabilities                                                                                1
DynamicEss/ErrorCode                                                                                0
DynamicEss/LastScheduledEnd                                                                                -
DynamicEss/LastScheduledStart                                                                                -
DynamicEss/TargetSoc                                                                                -
DynamicEss/LastScheduledStart                                                                                -
DynamicEss/TargetSoc                                                                                -
FirmwareBuild<PHONE_NUMBER>0751
FirmwareVersion                                                                                201728
GpsService                                                                                -
HardwareVersion                                                                                -
Hub                                                                                1
Mgmt/Connection                                                                                data from other dbus processes
Mgmt/ProcessName                                                            /opt/victronenergy/dbus-systemcalc-py/dbus_systemcalc.py
Mgmt/ProcessVersion                                                                                2.140
ProductId                                                                                -
ProductName                                                                                -
PvInvertersProductIds                                                                                -
Relay/0/State                                                                                0
Relay/1/State                                                                                0
Serial                                                                                d4124390d6ca
ServiceMapping/com_victronenergy_battery_1024                                                   com.victronenergy.battery.aggregator
ServiceMapping/com_victronenergy_battery_278                                                         com.victronenergy.battery.ttyS6
ServiceMapping/com_victronenergy_battery_3                                                 com.victronenergy.battery.blea5c2370595b6
ServiceMapping/com_victronenergy_settings_0                                                               com.victronenergy.settings
ServiceMapping/com_victronenergy_solarcharger_277                                               com.victronenergy.solarcharger.ttyS5
ServiceMapping/com_victronenergy_solarcharger_279                                               com.victronenergy.solarcharger.ttyS7
ServiceMapping/com_victronenergy_temperature_20                                         com.victronenergy.temperature.adc_builtin0_8
ServiceMapping/com_victronenergy_temperature_21                                         com.victronenergy.temperature.adc_builtin0_7
ServiceMapping/com_victronenergy_temperature_22                                         com.victronenergy.temperature.adc_builtin0_6
ServiceMapping/com_victronenergy_temperature_23                                         com.victronenergy.temperature.adc_builtin0_5
ServiceMapping/com_victronenergy_vebus_276                                                             com.victronenergy.vebus.ttyS4
ServiceMapping/com_victronenergy_vecan_0                                                                com.victronenergy.vecan.can0
SystemState/BatteryLife                                                                                0
SystemState/ChargeDisabled                                                                                0
SystemState/DischargeDisabled                                                                                0
SystemState/LowSoc                                                                                0
SystemState/SlowCharge                                                                                0
SystemState/State                                                                                252
SystemState/UserChargeLimited                                                                                0
SystemState/UserDischargeLimited                                                                                0
SystemType                                                                                Hub-1
Timers/TimeOff                                                                                147050
Timers/TimeOnGenerator                                                                                0
Timers/TimeOnGrid                                                                                8006
Timers/TimeOnInverter                                                                                2724
VebusInstance                                                                                276

@mr-manuel I'll stay in the boat for few hours up to 17h PM CET. If you need to test anithing. As youll see I updated the driver to: 1.2.20240220dev

@mr-manuel jus to let you know that my system config is published as requested...

Unfortunately we misunderstood each other. I need the /System values of the com.victronenergy.battery.* devices like this:

OK... sorry... @mr-manuel here they are
com.victronenergy.battery.ble_a5c2370595b6
Alarms/BmsCable                                                                                0
Alarms/CellImbalance                                                                                -
Alarms/HighChargeCurrent                                                                                0
Alarms/HighChargeTemperature                                                                                0
Alarms/HighDischargeCurrent                                                                                0
Alarms/HighInternalTemperature                                                                                -
Alarms/HighTemperature                                                                                0
Alarms/HighVoltage                                                                                0
Alarms/InternalFailure                                                                                -
Alarms/LowCellVoltage                                                                                -
Alarms/LowChargeTemperature                                                                                0
Alarms/LowSoc                                                                                0
Alarms/LowTemperature                                                                                0
Alarms/LowVoltage                                                                                0
Balances/Cell1                                                                                0
Balances/Cell2                                                                                0
Balances/Cell3                                                                                0
Balances/Cell4                                                                                0
Balancing                                                                                0
Capacity                                                                                197.75
Connected                                                                                1
ConsumedAmphours                                                                                262.25
CurrentAvg                                                                                6.5
CustomName                                                                                Bateria Serv 2
Dc/0/Current                                                                                39.5
Dc/0/MidVoltage                                                                                -
Dc/0/MidVoltageDeviation                                                                                -
Dc/0/Power                                                                                526.14
Dc/0/Temperature                                                                                -
Dc/0/Voltage                                                                                13.32
DeviceInstance                                                                                3
DeviceName                                                                                -
FirmwareVersion                                                                                1.2.20240224dev
HardwareVersion                                                                                2.8
Info/BatteryLowVoltage                                                                                12
Info/ChargeLimitation                                                                                Max Battery Charge Current
Info/ChargeMode                                                                                Bulk (Linear Mode)
Info/ChargeModeDebug
Info/Config/AUTO_RESET_SOC                                                                                1
Info/Config/BATTERY_CAPACITY                                                                                50
Info/Config/BATTERY_CELL_DATA_FORMAT                                                                                1
Info/Config/BLOCK_ON_DISCONNECT                                                                                0
com.victronenergy.battery.ble_a5c2370595b6
Info/Config/BATTERY_CELL_DATA_FORMAT                                                                                1
Info/Config/BLOCK_ON_DISCONNECT                                                                                0
Info/Config/BMS_TYPE                                                                                -
Info/Config/CCCM_CV_ENABLE                                                                                0
Info/Config/CCCM_SOC_ENABLE                                                                                0
Info/Config/CCCM_T_ENABLE                                                                                0
Info/Config/CELL_VOLTAGES_WHILE_CHARGING                                                                        [3.61,3.55,3.5,3.45]
Info/Config/CELL_VOLTAGES_WHILE_DISCHARGING                                                                        [2.7,2.8,2.9,3.1]
Info/Config/CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_TIME_RESTART                                                                    0.013
Info/Config/CELL_VOLTAGE_DIFF_KEEP_MAX_VOLTAGE_UNTIL                                                                            0.01
Info/Config/CELL_VOLTAGE_DIFF_TO_RESET_VOLTAGE_LIMIT                                                                            0.08
Info/Config/CVCM_ENABLE                                                                                1
Info/Config/CVL_ICONTROLLER_FACTOR                                                                                0.2
Info/Config/CVL_ICONTROLLER_MODE                                                                                0
Info/Config/DCCM_CV_ENABLE                                                                                0
Info/Config/DCCM_SOC_ENABLE                                                                                0
Info/Config/DCCM_T_ENABLE                                                                                0
Info/Config/DRIVER_VERSION                                                                                1.2.20240224dev
Info/Config/EXCLUDED_DEVICES                                                                                -
Info/Config/FLOAT_CELL_VOLTAGE                                                                                3.4
Info/Config/GREENMETER_ADDRESS                                                                                1
Info/Config/HELTEC_MODBUS_ADDR                                                                                [1]
Info/Config/INVERT_CURRENT_MEASUREMENT                                                                                1
Info/Config/LINEAR_LIMITATION_ENABLE                                                                                1
Info/Config/LINEAR_RECALCULATION_EVERY                                                                                120
Info/Config/LINEAR_RECALCULATION_ON_PERC_CHANGE                                                                                5
Info/Config/LIPRO_CELL_COUNT                                                                                15
Info/Config/LIPRO_END_ADDRESS                                                                                4
Info/Config/LIPRO_START_ADDRESS                                                                                2
Info/Config/MAX_BATTERY_CHARGE_CURRENT                                                                                150
Info/Config/MAX_BATTERY_DISCHARGE_CURRENT                                                                                150
Info/Config/MAX_CELL_VOLTAGE                                                                                3.6
Info/Config/MAX_CHARGE_CURRENT_CV                                                                                [0,7.5,75,150]
Info/Config/MAX_CHARGE_CURRENT_SOC                                                                                [0,22.5,75,150]
Info/Config/MAX_CHARGE_CURRENT_T                                                     [0,17.4,17.4,55.8,75,150,150,120,0,750,41.85,0]
Info/Config/MAX_DISCHARGE_CURRENT_CV                                                                                [0,15,75,150]
Info/Config/MAX_DISCHARGE_CURRENT_SOC                                                                               [0,15,30,75,150]
Info/Config/MAX_DISCHARGE_CURRENT_T                                                                           [0,30,45,60,150,150,0]
Info/Config/MAX_VOLTAGE_TIME_SEC                                                                                900
Info/Config/MIDPOINT_ENABLE                                                                                0
Info/Config/MIN_CELL_VOLTAGE                                                                                3
Info/Config/PATH_CONFIG_DEFAULT                                                                                config.default.ini
com.victronenergy.battery.ble_a5c2370595b6
Info/Config/SOC_CALC_CURRENT_MEASURED_BY_USER                                                                             [-300,300]
Info/Config/SOC_CALC_CURRENT_REPORTED_BY_BMS                                                                              [-300,300]
Info/Config/SOC_LEVEL_TO_RESET_VOLTAGE_LIMIT                                                                                80
Info/Config/SOC_LOW_ALARM                                                                                20
Info/Config/SOC_LOW_WARNING                                                                                25
Info/Config/SOC_RESET_AFTER_DAYS                                                                                0
Info/Config/SOC_RESET_CURRENT                                                                                7
Info/Config/SOC_RESET_TIME                                                                                60
Info/Config/SOC_RESET_VOLTAGE                                                                                3.65
Info/Config/SOC_WHILE_CHARGING                                                                                [100,95,90,85]
Info/Config/SOC_WHILE_DISCHARGING                                                                                [0,5,10,15,20]
Info/Config/TEMPERATURES_WHILE_CHARGING                                                                    [0,2,5,10,15,20,35,40,55]
Info/Config/TEMPERATURES_WHILE_DISCHARGING                                                                     [-20,0,5,10,15,45,55]
Info/Config/TEMP_1_NAME                                                                                Temp 1
Info/Config/TEMP_2_NAME                                                                                T Celdas
Info/Config/TEMP_3_NAME                                                                                Temp 3
Info/Config/TEMP_4_NAME                                                                                Temp 4
Info/Config/TEMP_BATTERY                                                                                2
Info/Config/TIME_TO_GO_ENABLE                                                                                1
Info/Config/TIME_TO_SOC_INC_FROM                                                                                0
Info/Config/TIME_TO_SOC_POINTS                                                                                [30,20,0]
Info/Config/TIME_TO_SOC_RECALCULATE_EVERY                                                                                180
Info/Config/TIME_TO_SOC_VALUE_TYPE                                                                                2
Info/Config/VOLTAGE_DROP                                                                                0
Info/Config/custom_config_file_path                                                 /opt/victronenergy/dbus-serialbattery/config.ini
Info/Config/default_config_file_path                                        /opt/victronenergy/dbus-serialbattery/config.default.ini
Info/Config/degree_sign                                                                                °
Info/Config/zero_char                                                                                0
Info/DischargeLimitation                                                                               Max Battery Discharge Current
Info/MaxChargeCurrent                                                                                150
Info/MaxChargeVoltage                                                                                14.4
Info/MaxDischargeCurrent                                                                                150
InstalledCapacity                                                                                460
Io/AllowToBalance                                                                                1
Io/AllowToCharge                                                                                1
Io/AllowToDischarge                                                                                1
Io/ForceChargingOff                                                                                0
Io/ForceDischargingOff                                                                                0
Io/TurnBalancingOff                                                                                0
Mgmt/Connection                                                                                BLE A5:C2:37:05:95:B6
Mgmt/ProcessName                                                                 /opt/victronenergy/dbus-serialbattery/dbushelper.py
Mgmt/ProcessVersion                                                                                Python 3.8.14
com.victronenergy.battery.ble_a5c2370595b6
Mgmt/ProcessName                                                                 /opt/victronenergy/dbus-serialbattery/dbushelper.py
Mgmt/ProcessVersion                                                                                Python 3.8.14
ProductId                                                                                0
ProductName                                                                                DP04S007L4S150A
Serial                                                                                a5c2370595b6
Soc                                                                                54.24
System/MOSTemperature                                                                                14.2
System/MaxCellTemperature                                                                                -
System/MaxCellVoltage                                                                                3.343
System/MaxTemperatureCellId                                                                                -
System/MaxVoltageCellId                                                                                C3
System/MinCellTemperature                                                                                -
System/MinCellVoltage                                                                                3.34
System/MinTemperatureCellId                                                                                -
System/MinVoltageCellId                                                                                C2
System/NrOfCellsPerBattery                                                                                4
System/NrOfModulesBlockingCharge                                                                                0
System/NrOfModulesBlockingDischarge                                                                                0
System/NrOfModulesOffline                                                                                0
System/NrOfModulesOnline                                                                                1
System/Temperature1                                                                                -
System/Temperature1Name                                                                                Temp 1
System/Temperature2                                                                                -
System/Temperature2Name                                                                                T Celdas
System/Temperature3                                                                                -
System/Temperature3Name                                                                                Temp 3
System/Temperature4                                                                                -
System/Temperature4Name                                                                                Temp 4
TimeToGo                                                                                29450
TimeToSoC/0                                                                                -
TimeToSoC/20                                                                                -
TimeToSoC/30                                                                                -
Voltages/Cell1                                                                                3.341
Voltages/Cell2                                                                                3.34
Voltages/Cell3                                                                                3.343
Voltages/Cell4                                                                                3.341
Voltages/Diff                                                                                0.003
Voltages/Sum                                                                                13.37

Could you test v1.2.20240227dev? Option 6 with the latest installer script:
wget -O /tmp/install.sh https://raw.githubusercontent.com/Louisvdw/dbus-serialbattery/master/etc/dbus-serialbattery/install.sh

bash /tmp/install.sh

If there is only one temperature sensor it is used as battery sensor.

Nice idea. Single temp sensor always on battery cells.
Unfortunately, there is an error and no BLE connection. here logs
2024-02-27 11:18:10.529207500 Device A5:C2:37:05:95:B6 (public)
2024-02-27 11:18:10.529218500   Alias: Bateria Serv 2
2024-02-27 11:18:10.529220500   Paired: no
2024-02-27 11:18:10.529221500   Trusted: no
2024-02-27 11:18:10.529222500   Blocked: no
2024-02-27 11:18:10.529224500   Connected: no
2024-02-27 11:18:10.529225500   LegacyPairing: no
2024-02-27 11:18:10.529227500   UUID: Device Information        (0000180a-0000-1000-8000-00805f9b34fb)
2024-02-27 11:18:10.529230500   RSSI: -58
2024-02-27 11:18:10.530128500
2024-02-27 11:18:11.922318500 INFO:SerialBattery:
2024-02-27 11:18:11.923035500 INFO:SerialBattery:Starting dbus-serialbattery
2024-02-27 11:18:11.925089500 INFO:SerialBattery:Venus OS v3.14
2024-02-27 11:18:11.925743500 INFO:SerialBattery:dbus-serialbattery v1.2.20240227dev
==> /data/log/dbus-blebattery.0/current <==
2024-02-27 11:18:17.923959500 INFO:SerialBattery:Init of LltJbd_Ble at A5:C2:37:05:95:9E
2024-02-27 11:18:17.924928500 INFO:SerialBattery:Test of LltJbd_Ble at A5:C2:37:05:95:9E
2024-02-27 11:18:22.937010500 ERROR:SerialBattery:>>> ERROR: Unable to connect with BLE device
2024-02-27 11:18:22.940435500 ERROR:SerialBattery:No BMS found at A5:C2:37:05:95:9E
2024-02-27 11:18:22.941297500 ERROR:SerialBattery:ERROR >>> No battery connection at LltJbd_Ble
2024-02-27 11:18:25.010415500 INFO:SerialBattery:BLE client disconnected
2024-02-27 11:18:25.015829500 ERROR:SerialBattery:BleakClient(): Exception occurred: BleakError('failed to discover services, device disconnected') of type <class 'bleak.exc.BleakError'> in /opt/victronenergy/dbus-serialbattery/bms/lltjbd_ble.py line #101
2024-02-27 11:18:25.344481500
2024-02-27 11:18:25.344904500 INFO:Bluetooth details

On the first restart another error came.
2024-02-27 11:22:57.224888500 INFO:SerialBattery:
2024-02-27 11:22:57.225617500 INFO:SerialBattery:Starting dbus-serialbattery
2024-02-27 11:22:57.227680500 INFO:SerialBattery:Venus OS v3.14
2024-02-27 11:22:57.228388500 INFO:SerialBattery:dbus-serialbattery v1.2.20240227dev
2024-02-27 11:23:02.668509500 [CHG] Device A5:C2:37:05:95:B6 RSSI: -56
2024-02-27 11:23:13.802748500 INFO:SerialBattery:Init of LltJbd_Ble at A5:C2:37:05:95:B6
2024-02-27 11:23:13.803624500 INFO:SerialBattery:Test of LltJbd_Ble at A5:C2:37:05:95:B6
2024-02-27 11:23:19.310874500 ERROR:SerialBattery:Exception occurred: TypeError("unsupported operand type(s) for -: 'NoneType' and 'float'") of type <class 'TypeError'> in /opt/victronenergy/dbus-serialbattery/bms/lltjbd.py line #275
2024-02-27 11:23:19.311937500 ERROR:SerialBattery:No BMS found at A5:C2:37:05:95:B6
2024-02-27 11:23:19.312633500 ERROR:SerialBattery:ERROR >>> No battery connection at LltJbd_Ble
2024-02-27 11:23:19.312968500 #0
2024-02-27 11:23:19.312972500 #1
2024-02-27 11:23:19.312973500 #2
2024-02-27 11:23:19.312974500 #3

The problem was fixed with v1.2.20240227.


Dynamic target-name resolution via function as argument.

I've added some functionality on my fork (https://github.com/ktstowell/gulp-concat) that allows the user to pass in a function as the first argument (or as the value of path). The returned value would then be used as the target for file contents.
Running the test suite would further elaborate what I was trying to accomplish. Basically, with the given glob of: ['scripts/one/**/*.js', 'scripts/two/**/*.js', ''scripts/three/**/*.js'] to result in the contained files of each directory in a dedicated file of the user's choosing - in the case of the test: dist/one.js, dist/two.js, dist/three.js.
I want to submit a PR but in accommodating this new functionality, I have invalidated some tests and was looking for some meaning as to whether they are still meaningful.
(at 48e757a90687a8c5bca9d2945285ac0689aa7023 the last test of 4) should calculate relative path from cwd and path in arguments is failing. It does not seem to be affected by my changes)
So if someone could clone my forked repo and run the tests and check out the changes that would be great. If it sounds like something gulp-concat would be interested in I will open a PR.
Thanks!

I feel like this could be solved with a meta stream tool instead of putting it into the lib. Branching based on filename is a very common use case and shouldn't be built into every single plugin. Have you tried using gulp-if for this?
.pipe(gif('a/b/**/*.js', concat('b.js'))
.pipe(gif('a/c/**/*.js', concat('c.js'))
// etc

Definitely achievable via gulp-if, which is how I have traditionally done it. The idea was to be able to handle JIT target names if the structure of the app is dynamic.
This is why I'm putting some feelers out there: to see if this has any philosophical alignment to the project.

I think gulp-if or other stream meta-tools are the way to handle this since it is such a common thing you would do with other plugins as well

That's fair. Thanks for the involvement and feedback!


Set up a cleanup cron job that checks all the entries in the database for existance

Checks the source field in the database to see if they still exist (does not return 404), if not, mark it as withdrawn.

Can you assign me this issue i want to work on it

Hey @rajbhoyar729, sorry missed this comment for a long time. This is more of a internal task as you would need access to the database backend to be able to adequately  work on it.

#1859 is another example of this being potentially useful.

Can you guide me how can I do it

@rajbhoyar729 your enthusiasm for contributing to OSV has been noticed 🥇
This particular issue is difficult for external contributors who don't have access to our GCP infrastructure (that's what we cooked up the needs-gcp-infra-access to.
Please take a look at the issues tagged with good first issue. These are more suitable for folks like yourself. You may also like to contribute to OSV Scanner
Stay enthusiastic!

Manually ran this in Production:
5220 Bugs in Datastore considered deleted from GCS for cve-osv
23 Bugs in Datastore considered deleted from GCS for debian-dsa
19 Bugs in Datastore considered deleted from GCS for go

I think we can call this done finally.


raftstore, resolved_ts: clarify the use of term safe_ts and resolved_ts

Signed-off-by: JmPotato<EMAIL_ADDRESS>What is changed and how it works?
Issue Number: Close #13437.
What's Changed:

Clarify the use of term `safe_ts` and `resolved_ts`.

Check List
Tests

Unit test
Integration test

Release note
None.

/cc @5kbpers @lhy1024
PTAL, thx!

/merge

/test

/unlabel needs-rebase


Behaviour during Manage mode

If one enters Manage mode (by inserting a valid API key into the box) but doesn't finish managing through clicking either Save or Cancel (i.e. just disregards that tab and continues browsing the site), clicking on sense box markers doesn't work as expected (box title remains an input box).
To fix this and avoid confusion in general, I'd suggest to remove the Manage tab and replace it with a lightbox/dialog UI that pops up when clicking a Manage link -- usually sense boxes aren't managed too often anyways :-)

Moved it into a modal, should work better now


Cannot call value of non-function type '[String : Any]'

I am getting Compile error "Cannot call value of non-function type '[String : Any]'" error on line number 593 & 618 in KeychainAcess.swift file.

I am also seeing this issue after installing with Cocoapods on Xcode 8.

Closing as duplicated to https://github.com/kishikawakatsumi/KeychainAccess/issues/273 and https://github.com/kishikawakatsumi/KeychainAccess/issues/272

Still getting this issue on Xcode Version 8.1 (8T61a). I try all the steps provided by you but still facing the same issue.

how to slove that problem I am getting Compile error "Cannot call value of non-function type '[String : Any]'" error  in swift 5


text-editor-popover position relative to f7-root

As described here: https://github.com/framework7io/framework7/issues/3617
The popover is relative (css'ly speaking) to the #framework7-root element, but is computed relative to the html element.
The proposal is to compute the position relative to the #framework7-root element
Important: I haven't been able to test if for real! It should work, but it should definitely not be merged without real verification!

I just remembered that I HAD a Framework7 running on which testing my code... On the node_modules of my own project.
So I tested, and it works as expected (a review is still welcome of course).

Thanks, merged!


nixos/opensnitch: remove services.opensnitch.settings.Ebpf option

closes https://github.com/NixOS/nixpkgs/issues/368315
the option was previously entirely unused, but introduced weird failure mechanisms if the audit method was not ebpf.
No sensible person would ever define this option, as it simply did nothing. Because this did nothing, removing it will not break most existing opensnitch ebpf setups. Whether non-ebpf setups work after this PR is questionable, but at least the eval error goes away. This might potentially need a follow-up PR, i have to do more testing.
CC @onny

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[x] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Update: I totally overlooked https://github.com/NixOS/nixpkgs/blob/6c90912761c43e22b6fb000025ab96dd31c971ff/nixos/modules/services/security/opensnitch.nix#L210 where the settings are being written to json. This obviously means this does not work and the option is, in fact, not unused. Sorry!


Fix metric reporting error

What changes are proposed in this pull request?
Fix metric reporting error.
When the worker reports metrics to the master, the metric type reported to the master should be consistent with the instanceType
Why are the changes needed?
When I was reading data, I found that some metrics in the master were inaccurate.
For example, the "Remote Alluxio Read" on the master homepage was less than the amount of data read by the client, and also less than the "Bytes Read Remotely" on the worker page.
By adding logs, it can be found that the "Bytes Read Remotely" of the worker is correct. However, after the woker sent it to the master, some alluxio.grpc.Metric records were skipped.
alluxio.grpc.Metric is obtained from the worker's alluxio.metrics.MetricsSystem#reportMetrics and received and processed by the master's alluxio.master.metrics.MetricsStore#putReportedMetrics.
When processing reportMetrics, in alluxio.metrics.MetricsSystem#SHOULD_REPORT_METRICS, there are actually both InstanceType.CLIENT and InstanceType.Worker metrics. They will be reported to the master by calling alluxio.metrics.MetricsSystem#reportWorkerMetrics and alluxio.metrics.MetricsSystem#reportClientMetrics interfaces by different worker threads. However, in the master, putReportedMetrics will only process the records of InstanceType.Worker and ignore the records of InstanceType.CLIENT.
Since Counter only sends diff, if a Worker's metric is sent by reportClientMetrics, the master's record will record one less data.
Does this PR introduce any user facing changes?
none

OK, I have signed the CLA and e-mail back to<EMAIL_ADDRESS>


Remove swagger instrumentation from Ciao

The current swagger instrumentation for the APIs are outdated and unhelpful so we made a decision to remove them from the source tree. This change removes the swagger entries from the source code and disables the documentation generation on travis.
Fixes: #1292

CC @kaccardi

Coverage increased (+0.009%) to 65.777% when pulling 4c2dca42687e41e59ba5bcc2b1623220385fbdce on rbradford:deswagger into 3833b1fed7c8eba0f2fdf5ed7f5858c26c4a6500 on 01org:master.

@rbradford thanks for the cleanup. Would you mind just confirming whether we need all the functions in legacy_api.go now? I think some of them might have just been for documention purposes only.

@kaccardi I went through this file and found that legacyListTenants and its API entry point isn't used. All the others currently are in use. I deleted that commen that implied that the API entry point was only there for documentation.

Coverage decreased (-0.01%) to 65.723% when pulling f12ab0c0e0cd41922a42f74741b8d6a9919269f6 on rbradford:deswagger into 2dc4802ee81cd926463fdb669781b45bfdbe4aa0 on 01org:master.

@kaccardi ping!


Support sibling snupkg file

Fixes #925.
When opening a nupkg file from disk, if its symbols are in a snupkg file next to it, it would be flagged as having no symbols. This commit tests for such a file, using it if possible, before returning to the prior behaviour of checking nuget.org for packages identified as coming from there.

I’ll test and merge tomorrow, thanks!

Oh, one other thought -- as long as we're checking for .snupkg sibling files, we should also check for .symbols.nupkg.


Automated cherry pick of #3292: fix: policy support description

Cherry pick of #3292 on release/2.11.
#3292: fix: policy support description

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11@1159ad7). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release/2.11   #3293   +/-   ##
==============================================
  Coverage                ?   7.13%
==============================================
  Files                   ?     476
  Lines                   ?   77213
  Branches                ?       0
==============================================
  Hits                    ?    5512
  Misses                  ?   71237
  Partials                ?     464

Flag
Coverage Δ

#aFlag
7.13% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1159ad7...8f1c0d7. Read the comment docs.

/approve
/lgtm

google cloud architect


The return value for initialize is documented incorrectly

Suppose I have this very basic class:
class Test
  def initialize
  end
end

If I generate yardocs for this, the return value of initialize is Test:
- (Test) initialize

But that is incorrect. The return value of new is Test. The return value of initialize is the value of the last statement. In this case: nil.
I hope this doesn't sound like nit-picking: this inconsistency is an issue for yard-contracts. See this issue: https://github.com/sfcgeorge/yard-contracts/issues/9

I gotta agree with @sfcgeorge on this one. yard-contracts should probably handle this specific case as special, and it's probably not the last thing it would have to treat specially.
While you're technically correct, the reality is that, from a documentation perspective, it would make just as little sense to mark #initialize as returning nil. YARD focuses on modeling the semantic behavior of an API from the user's perspective-- we aren't trying to accurately model Ruby's runtime. This is because Ruby's runtime doesn't always reflect the actual behavior that a user expects when they use an API. From a semantic/functional perspective, your "constructor" is the initialize method, not "new".
Realistically, there would be an inconsistency no matter what we did. I've thought about this before, and none of the alternatives are any better:

initialize returns nil: this would be counter-intuitive for users reading documentation and seeing a nil return on the constructor.
YARD documents initialize as "new": this would be confusing to users documenting initialize and not seeing that method in documentation.
YARD requires users to document "new" as a separate method: this would be extremely awkward because nobody does this in real world code.

Returning the class type in initialize is the least confusing of the above options. We're probably going to stick with this going forward.

Just to be clear, I think @sfcgeorge was saying that he won't specialize yard-contracts. I see your point though, it could get confusing reading the documentation. Maybe the best way to handle this is to either:

return self in initialize
explicitly set the return type using @return.

I'm fine with this. cc @fappelman
On a side note: thank you for yardoc! Great software.

I don't mind the current behaviour, and I like the added "constructor" next to it to hint that there's some magic going on in Ruby but not going any further than that. It's little touches like that which make me really respect YARD, thanks! I'm quite happy for it to be left as is, and when using Contracts simply return self in initialize and contract the return type as the class name. That said, some thoughts:
Calling it new would also break cases where new has been overridden so I agree it would be confusing.
I don't think initialize returning nothing would be confusing though, it may even make more sense. All Ruby devs need prior knowledge that you call new but somehow initialize is called and you get an instance back. It's clear that new returns the object because that's what you called. I think it's also clear that initialize doesn't return anything meaningful because you could put an explicit return 'junk' in initialize yet new would still return the class instance. This will be familiar to any Java developer as constructors have no return value either. They aren't even void, they return nothing! It is the new keyword that returns the object, constructor just fills in fields. Ruby is exactly the same as this, new calls allocate to put an object in memory, then calls initialize to fill in the object, then returns it. So I agree that saying initialize returns nil would be confusing because it doesn't, it returns nothing at all. You could just not document a return value. We know it's a constructor (because we have to have learned that and YARD says so) and it's clear which class it's inside. And why do you need to know the return value of initialize—it's (nearly) impossible to call it:
irb(main):001:0> class Foo; def initialize; end; end
=> :initialize
irb(main):002:0> Foo.new.initialize
NoMethodError: private method `initialize' called for #<Foo:0x007fc05205cd90>

You can with send but if you know enough to do that you won't be put off by documentation oddities.

Would it be a possibility to add a new Pseudo type contracts named Constructor. Yard-contracts would be able to use that to generate insert the class name and contracts could just see this as an alias for Any. Just a thought.

A Constructor contract is a possibility, sitting somewhere in between the class name and void/nothing options. yard-contracts would just skip documenting it's type thus letting YARD fill it in with whatever it's default is (currently the class name).

I would prefer that over being forced to put self in each constructor. Although a small effort it just feels wrong.

It's clear that new returns the object because that's what you called. I think it's also clear that initialize doesn't return anything meaningful because you could put an explicit return 'junk' in initialize yet new would still return the class instance.

I think this is all besides the point. The point here is that YARD has to (*) document a single "constructor" method, but a constructor in Ruby is actually made up of an allocator and initializer wrapped in a .new. Because we are effectively communicating multiple behaviors within a single "constructor" method, certain things have to be handwaved.
What you say makes sense if you read the documentation as if it were a strict initializer method, but that's not how YARD documents it. YARD calls this a "constructor"-- a constructor must return the type of its class. This is not technically correct for initialization, but it is necessary to communicate the object construction process in its entirety to the reader of an API, because the user on the outside of the black box doesn't care how the object is initialized.
Basically, users looking to figure out how to create a new Thing will be visiting the docs associated with Things constructor, and that would be Thing#initialize, because that's the Ruby convention on documenting constructor-specific behaviors. With this in mind, it would be weird, IMO, if the constructor documentation that the user navigated to told said user that object construction returns nil.
(*) YARD doesn't "have to" document a single constructor, but it is is a very strong convention in Ruby-land to associate constructor docs with the initializer. This is unlike, say, Obj-C, where there is a strong convention around explicitly creating an allocator method separate from the initializer, and since this behavior not abstracted away in the language, it can be documented cleanly as two separate things. Unfortunately to get away with this in Ruby you'd have to explicitly document self.new.
(* contd.) In RDoc's world, it's typical to rewrite the signature to self.new -> Type, which is equally informative but slightly more misleading. YARD tries to meet users and authors half-way by being truthful about the method name (#initialize) while also pointing out the "special" behavior of this method in the object construction process (as, effectively, the "constructor" method when authoring such a class). The lie that YARD tells at least allows users to still understand how the constructor is implemented as well as where that implementation lives in source.

Closing out old issues. The behavior here is working as intended. It can be confusing, but YARD is as consistent as it can be given the duality of the way object construction works vs. the convention in documenting "constructors".

In RDoc's world, it's typical to rewrite the #initialize signature to self.new -> Type, which is equally informative but slightly more misleading.

How is it misleading here? Essentially Thing::new is nothing different from any other class methods except for being the only method in built-in Object able to allocate an instance. I can just create a Thing::my_new that calls a private Thing#my_initialize and returns a Thing. ::new being special is more of a convention than a syntax thing to me.


Adds hacking UI pop-up when using a hacking tool on an open panel

No idea why this code doesn't work but here's a draft for people to look at it.
Fixes #1049 (when it eventually works)

Looks good to me


Feature: Add flag to install python to different prefix

I am looking to use this container to volume mount to my neovim development environment and keep the python tools in a separate container. As such, it would be great if python can be installed to a different prefix, would it be a useful feature to add the ability to set custom flags for the configure script such as --prefix?
Example:
docker create -v '/usr/local/python' python:3.7-alpine /bin/true
docker run -it --rm --volumes-from python-tools omnidapps/nvim:alpine

If this would be helpful, I volunteer to add this into the images
Thanks!

Closing issue... realized after that this would likely be a better use-case for a custom docker image


[BUG] buyerIdentityUpdate function update deliveryAddressPreferences object in checkout

Describe the bug
Using the buyerIdentityUpdate function from the useCart hook, doesn't respect the deliveryAddressPreferences object entered.
To Reproduce

Call function with values

buyerIdentityUpdate({
      countryCode: 'GB',
      email<EMAIL_ADDRESS>      phone: '123412344',
      deliveryAddressPreferences: [{
        deliveryAddress: {
          address1: '1',
          address2: '2',
          city: 'London',
          country: 'GB',
          firstName: 'Test',
          lastName: 'Example',
          phone: '123412344',
          zip: 'SW12 1JG',
          province: 'London',
        }
      }]
 })

Go to the checkout link, either via component or fetch checkoutUrl from hook
Note shipping address is empty

Expected behavior
Shipping address to be populated
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.

Hydrogen UI version: 2022.10.5
Framework used: NextJS
Node version: v16.18.0
Browser: Chrome 108.0.5359.98

Ok, looking into it, just taking some notes mostly for myself.
It seems that the cartBuyerIdentityUpdate is generally just meant for you to get accurate pricing info for the customer's cart. https://shopify.dev/api/storefront/2022-10/mutations/cartBuyerIdentityUpdate
We do keep the checkoutUrl in state in one location (useInstantCheckout()), but otherwise we just get the URL from the response from the Storefront API. I think.
I don't think the Storefront API supports returning that info at the moment, so if we decide to do something, it would have to be done in our library directly (or by writing guides on how to augment the checkout url with that information). See also https://github.com/Shopify/storefront-api-feedback/discussions/55

So I guess the question is, do we want to add something to this library to help with this use case, or ask that the Storefront API support it, or some other options? @elisenyang thoughts?

@frehner this seems like something we should bring to the SF API team first so let's do that before we implement anything


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-yml-archive-non-versioning-archive/pull/62 is merged into live branch.
Auto archive content to https://github.com/VSC-Service-Account/docs-yml-archive-non-versioning-archive.git

Docs Build status updates of commit 030dbc6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

docs/TOC.yml
:white_check_mark:Succeeded
View

docs/index.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/article3-1-3.yml
:white_check_mark:Succeeded
View

docs/to-be-archive/level1/sql-database-engine.png
:white_check_mark:Succeeded

docs/to-be-archive/level2/article3-2-1.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-2.md
:white_check_mark:Succeeded
View

docs/to-be-archive/level2/article3-2-3.yml
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Java withDelay() not respected in response callback

When ExpectationResponseCallback is used to generate a response, the withDelay() method has no effect. I've done minimal stepping and it seems like the problem is that WebSocketClient calls writeAndFlush() directly when the callback returns.
Example usage:
ClientAndServer server = ClientAndServer.startClientAndServer(80)
HttpRequest request = ...
server.when(request).respond(r -> {
	return response("ok").withDelay(TimeUnit.SECONDS, 5);
});

Version: 5.4.1

Sounds good. I used Thread.sleep() in the callback in the meantime.

this behaviour has now been implemented so closing issue


Is this project still being maintained?

I don't see the package on Hex.  @mendrugory Are you still working on this?  I just want to use this library to connect to a signalrHub to simply check the server.

Hi,
The project is not in Hex because I don't like to publish libraries without tests. The project is not maintained at this moment because I am not using.

@mendrugory Thanks for your reply. After I digged into it a bit, I found that our servers are using Kerberos which I don't think will work with elixir.  Sadly I will move on.


New Topic: Using custom nginx.conf reference

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement
As a user I'd like to use a custom nginx.conf file on my Kong Gateway pods
Proposed Solution
No response
Additional information
No response
Acceptance Criteria

Provide instructions how to use a custom nginx.conf file with Kong Gateway on Kubernetes
Instructions may be provided as a response to this issue and @Rajakavitha1 will port to the WIP KIC 3.0 branch in docs

From @randmonkey:
If they just want to load the template to some path inside the kong  container, they can save it to some ConfigMap  or Secret  and mount it into the container, like:
deployment:
  userDefinedVolumes:
  - name: custom-template
    configMap:
      name: custom-template
      items:
      - key: "nginx_kong.lua"
        path: "nginx_kong.lua"
  userDefinedVolumeMounts:
  - mountPath: "/var/kong" # the template where you want to put
    name:custom-template
    readOnly: true
    subPath: "nginx_kong.lua"

Closing this issue because it has been addressed in https://github.com/Kong/docs.konghq.com/pull/6415.


opcache.dups_fix must be enabled, or run with --force

hi im getting this message {"result":{"message":"opcache.dups_fix must be enabled, or run with --force"}}
i can turn on opcache.dups_fix on my shared host
in Compile.php its asking for a option:
response = $this->sendRequest('compile', ['force' => $this->option('force') ?? false]);
where do i set option force to true ?

Use php artisan opcache:compile --force

Where in the php code do I do that?

Where in the php code do I do that?

Just paste this command in a terminal in your folder directory.

Is there no way to doing this through php so I don’t have to log in to cpannel every time I make a change?

You can programmatically execute artisan commands:
Artisan::call('opcache:compile --force');

Is there no way to doing this through php so I don’t have to log in to cpannel every time I make a change?

You can programmatically execute artisan commands:
Artisan::call('opcache:compile --force');


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-target_9c80bdb5-4234-4136-aa2c-74a605f36e55/pull/1 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-target_9c80bdb5-4234-4136-aa2c-74a605f36e55.git

Docs Build status updates of commit fd85c37:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-RuningBuildFailed] Some unexpected errors happened when running build, please open a ticket in https://aka.ms/SiteHelp and include the error report for our team to troubleshoot

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Fix the critical multithreaded correctness issues discovered by Clinker Sonarqube

http://clinker.netty.io/sonar/drilldown/issues/io.netty:netty-parent:master?severity=CRITICAL
Multithreaded correctness - Inconsistent synchronization	7
Multithreaded correctness - Incorrect lazy initialization of static field	1

@futurely - Thanks for bringing out attention to this.  @jpinner has already commented on these and indicated they were false positives.  @trustin - Is there any way to mark them as such in sonar?

I marked all but the OpenSslEngine one as false positives. @normanmaurer, could you confirm if it's a false positive or not?

@trustin actually I think this one is fixed as part of https://github.com/netty/netty/pull/3481


Add e2e tests for metrics

What this PR does
Before this PR:
KubeVirt had no e2e tests validating that metrics were being scrapped by Prometheus
After this PR:
KubeVirt has e2e tests validating that metrics from all components are being scrapped by Prometheus
jira-ticket: https://issues.redhat.com/browse/CNV-29328

Fixes #
Why we need it and why it was done in this way
The following tradeoffs were made:
The following alternatives were considered:
Links to places where the discussion took place:
Special notes for your reviewer

Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note

Add e2e tests for metrics

/cc @sradco @enp0s3

/retest

/hold
needs #11264

/unhold

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

@machadovilaca Hi, thank you for the PR! can you please check the file tests/infrastructure/prometheus.go and see if there are no duplicates? if you can arrange all the monitoring e2e under one directory it could be great.

@enp0s3 These tests are a bit different, on the tests/infrastructure/prometheus.go they are testing 2 things:

Prometheus endpoints are working and throttling requests
Each virt-* component, is correctly exposing metrics through their internal endpoints

This new test added validates that:

All metrics registered in the virt-* components are present in Prometheus

They seem to intent to test different things

/retest

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

@machadovilaca Maybe I am missing something here but the only added value of testing these metrics in e2e is because we bring up a real Prometheus endpoint and query it with web client. But why do we need to test the registration and the query? these are generic Prometheus functionalities IMO.
I think we can test the metrics in unit tests, by creating a fake VM objs, load them into informers and call the relevant functions to observe a particular metric value. It will be even better since monitoring e2e is only running upon monitoring related files change, it won't run when someone changed VM lifecycle code that can affect metrics.

this tests that the metrics are being properly registered by the components
yes, prometheus client tests that if they are registered they will be served
but this ensures that the kubevirt components are actually registering those metrics
and in the case of collectors, that those collectors are being used and pushing all metrics
because of the way collectors work, by pushing a "custom metric", those metrics are not initialized by default and may happen that some of them are not used

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

/test pull-kubevirt-e2e-k8s-1.29-sig-monitoring

@enp0s3 any chance to get another review here? Thanks

Nothing else from my side. Thank you for your patience!
/lgtm


Search command message grammar issue

When only 1 person is listed it prints 1 personS listed.

Closed by #421


Let codeblocks create a console to display the log

Let codeblocks create a console output log, which can be displayed through LV_LOG...() or printf() output!

Mail have been received， thank you.

Can you revert the change to LittlevGL.layout so the diff isn't too large? Aside from that this looks fine to me. The console window is a bit annoying for demo purposes but is very helpful for debugging.

Can you revert the change to LittlevGL.layout so the diff isn't too large? Aside from that this looks fine to me. The console window is a bit annoying for demo purposes but is very helpful for debugging.

ok I try it.


help me！！！

This prompt appears, can't continue:
Error: tempSymbol.detachByReplacingWithGrop is note afunction. (In'tempSymbol.detachByReplacingWithGroup()',
thanks!

@danny0823 , please give this a try:
Remember to uninstall the plugin, restart sketch and install the downloaded version, just to make sure there's no cached plugin information.
Also, make sure you're using Sketch v53.2 (72643).
Get the Fork version (v2.8.0)
Download from sketch-measure-latest
Still not working?
Follow the steps below:

[ ] Uninstall the plugin
[ ] Quit Sketch
[ ] Follow the steps bellow to remove the PluginsWarehouse folder
[ ] Download the latest zip file from the fork
[ ] Reinstall the plugin
[ ] Test the Mark Properties / Spec Export again

Remove the PluginsWarehouse folder that lives in ~/Library/Application Support/com.bohemiancoding.sketch3/. This is where we cache plugin downloads, and if you’ve been testing different versions of your appcast, you probably have some old stuff there that’s worth cleaning.

Go to the Finder of Mac OS
From the “Go” menu navigate down to “Go to Folder” or...
Hit Command+Shift+G from the Mac OS X desktop or a Finder window
Paste the folder location ~/Library/Application Support/com.bohemiancoding.sketch3/
Remove/Delete the PluginsWarehouse folder

Let me know how it goes 😊
If after all this it still doesn't work, please share a small sketch example file (doesn't need to be your actual design file) that you can reproduce the bug and I'll take a look.


Add example profile 3 canary workload services projects around bigquery development

follow document ai canary at https://github.com/GoogleCloudPlatform/pubsec-declarative-toolkit/blob/canary/solutions/document-processing/gcloud/deployment.sh#L88
https://cloud.google.com/bigquery/docs/access-control#bq-permissions
https://cloud.google.com/bigquery/docs/access-control#bigquery
Roles
gcloud projects add-iam-policy-binding $CC_PROJECT_ID  --member=sgroup:$EMAIL --role=roles/bigquery.admin --quiet > /dev/null 1>&1

Services
Big Query is usually enabled by default on a project - but the lz workflow has it unset - fixing
root_@cloudshell:~/lz-tls/_lz2/pbmm-on-gcp-onboarding (lz-tls)$ gcloud config set project tzpe-tlz-tlz-de
Updated property [core/project].
root_@cloudshell:~/lz-tls/_lz2/pbmm-on-gcp-onboarding (tzpe-tlz-tlz-de)$ gcloud services list | grep NAME
NAME: accesscontextmanager.googleapis.com
NAME: appengine.googleapis.com
NAME: artifactregistry.googleapis.com
NAME: cloudbilling.googleapis.com
NAME: cloudbuild.googleapis.com
NAME: cloudidentity.googleapis.com
NAME: cloudkms.googleapis.com
NAME: cloudresourcemanager.googleapis.com
NAME: compute.googleapis.com
NAME: containerregistry.googleapis.com
NAME: iam.googleapis.com
NAME: iamcredentials.googleapis.com
NAME: logging.googleapis.com
NAME: oslogin.googleapis.com
NAME: pubsub.googleapis.com
NAME: secretmanager.googleapis.com
NAME: serviceusage.googleapis.com
NAME: sourcerepo.googleapis.com
NAME: storage-api.googleapis.com

add
bigquery.googleapis.com
bigquerymigration.googleapis.com
bigquerystorage.googleapis.com

gcloud services enable bigquerymigration.googleapis.com
gcloud services enable bigquery.googleapis.com
gcloud services enable bigquerystorage.googleapis.com

before - no access as expected

after

check limited access

getting iam admin via group role

although only the terraform service account can modify group membership

removing opsadmin group role
diff --git a/environments/common/iam-groups.auto.tfvars b/environments/common/iam-groups.auto.tfvars
index 019403f..dd6fdab 100644
--- a/environments/common/iam-groups.auto.tfvars
+++ b/environments/common/iam-groups.auto.tfvars
@@ -32,7 +32,7 @@ iam-group_opsadmin = {
   domain       = "terraform.landing.systems"
   #owners       = ["ro..ding.systems"]#, "tfsa..tlz-tlz-de.iam.gserviceaccount.com"] # var.service_accounts
   #managers     = ["roo..m.landing.systems"]
-  members      = ["root..stems", "devel...landing.systems"]
+  members      = ["roo..landing.systems"]

verified lower iam permissions on dev user

20240406: Closing issue during retrofit/rebase of this TEF V1 based/modified repo to TEF V4 standards
This issue may participate in the LZ refactor after rebase
Query on all issues related to the older V1 version via the tag
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/labels/2024-pre-tef-v4


Startup Performance hit with source zsh-syntax-highlighting

I had this in my ~/.zshrc, and I found there are some performance issue when loading up this zsh.
source /usr/local/share/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh
before comment out the above line:
 /usr/bin/time zsh -i -c exit;
        3.08 real         1.75 user         1.03 sys

after comment out the above line:
 /usr/bin/time zsh -i -c exit;
        2.69 real         1.47 user         0.89 sys

Current version at :
commit ad522a091429ba180c930f84b2a023b40de4dbcc
Note: I have other perf issues on startup that is not related to zsh-syntax-highlighting, but I'm pursuing each hotspot to cut the perf number lower. And zsh-syntax-highlighting is one of them.

I had this in my ~/.zshrc, and I found there are some performance issue when loading up this zsh.
source /usr/local/share/zsh-syntax-highlighting/zsh-syntax-highlighting.zsh

To clarify, are you asking only about the startup performance, or also
about performance during subsequent interactive usage?
What's the output of typeset -p ZSH_HIGHLIGHT_HIGHLIGHTERS ZSH_HIGHLIGHT_REVISION ZSH_HIGHLIGHT_VERSION ZSH_VERSION ZSH_PATCHLEVEL?

@danielshahaf
I should clarify a bit more, will update this issue ticket on the title. I'm talking specifically about startup performance.
Output from that command you suggested:
typeset -p ZSH_HIGHLIGHT_HIGHLIGHTERS ZSH_HIGHLIGHT_REVISION ZSH_HIGHLIGHT_VERSION ZSH_VERSION ZSH_PATCHLEVEL
typeset -a ZSH_HIGHLIGHT_HIGHLIGHTERS
ZSH_HIGHLIGHT_HIGHLIGHTERS=( main )
typeset ZSH_HIGHLIGHT_REVISION=HEAD
typeset ZSH_HIGHLIGHT_VERSION=0.6.0-dev
typeset ZSH_VERSION=5.2
typeset ZSH_PATCHLEVEL=zsh-5.2-0-gc86c20a

It takes about the same time here:
% typeset -F SECONDS=0; source ./zsh-syntax-highlighting.zsh; echo $SECONDS
0.3567790000
I agree, it'd be good to make the startup faster.  I don't intend to
implement this myself, but patches would be welcome.

Probably not related to this then. Closing it.

Side note. There is zsh/zprof module that gives much more insight about startup time and most taxing function calls.

@xbeta We both see the same overall time in z-sy-h, and it would be a good thing to reduce that time, so I'm reopening.
@z0rc I'm aware, thanks — and welcome aboard :).

I've followed https://xebia.com/blog/profiling-zsh-shell-scripts/ and here's the callee map from kcachegrind

As you can see, _zsh_highlight_bind_widgets (a function from zsh-syntax-highlighting) is the highest percentage single function in the callee map. While yes, there are plenty of things I could try to trim out, the fact that _zsh_highlight_bind_widgets takes 32,389 micros per call; which pushes zsh-syntax-highlighting-plugin.zsh up to 50,178 micros per call, which then pushes antigen's init.zsh up to 110,105 micros per call; is something that feels like it should be investigated.
For reference, here's Antigen's init.zsh list of callees

Here's the contents of _zsh_highlight_bind_widgets as will be used as of the next zsh release:
https://github.com/zsh-users/zsh-syntax-highlighting/blob/ebef4e55691f62e630318d56468e5798367aa81c/zsh-syntax-highlighting.zsh#L437
As you can see, it literally does nothing.  Furthermore, it's called only once.  I rest my case :)
That codepath is only enabled by default as of zsh <IP_ADDRESS> and newer (not yet released) for reasons explained in the comment above the if.  However, you can disable the is-at-least check locally if the interop considerations (point (2) in the link) don't affect you, in which case any zsh ≥5.3 will use the new codepath.

@danielshahaf this is the contents of _zsh_highlight_bind_widgets for me, and it's up to date with master (according to antigen)
_zsh_highlight_bind_widgets()
  {
    setopt localoptions noksharrays
    typeset -F SECONDS
    local prefix=orig-s$SECONDS-r$RANDOM # unique each time, in case we're sourced more than once

    # Load ZSH module zsh/zleparameter, needed to override user defined widgets.
    zmodload zsh/zleparameter 2>/dev/null || {
      print -r -- >&2 'zsh-syntax-highlighting: failed loading zsh/zleparameter.'
      return 1
    }

    # Override ZLE widgets to make them invoke _zsh_highlight.
    local -U widgets_to_bind
    widgets_to_bind=(${${(k)widgets}:#(.*|run-help|which-command|beep|set-local-history|yank|yank-pop)})

    # Always wrap special zle-line-finish widget. This is needed to decide if the
    # current line ends and special highlighting logic needs to be applied.
    # E.g. remove cursor imprint, don't highlight partial paths, ...
    widgets_to_bind+=(zle-line-finish)

    # Always wrap special zle-isearch-update widget to be notified of updates in isearch.
    # This is needed because we need to disable highlighting in that case.
    widgets_to_bind+=(zle-isearch-update)

    local cur_widget
    for cur_widget in $widgets_to_bind; do
      case ${widgets[$cur_widget]:-""} in

        # Already rebound event: do nothing.
        user:_zsh_highlight_widget_*);;

        # The "eval"'s are required to make $cur_widget a closure: the value of the parameter at function
        # definition time is used.
        #
        # We can't use ${0/_zsh_highlight_widget_} because these widgets are always invoked with
        # NO_function_argzero, regardless of the option's setting here.

        # User defined widget: override and rebind old one with prefix "orig-".
        user:*) zle -N $prefix-$cur_widget ${widgets[$cur_widget]#*:}
                eval "_zsh_highlight_widget_${(q)prefix}-${(q)cur_widget}() { _zsh_highlight_call_widget ${(q)prefix}-${(q)cur_widget} -- \"\$@\" }"
                zle -N $cur_widget _zsh_highlight_widget_$prefix-$cur_widget;;

        # Completion widget: override and rebind old one with prefix "orig-".
        completion:*) zle -C $prefix-$cur_widget ${${(s.:.)widgets[$cur_widget]}[2,3]}
                      eval "_zsh_highlight_widget_${(q)prefix}-${(q)cur_widget}() { _zsh_highlight_call_widget ${(q)prefix}-${(q)cur_widget} -- \"\$@\" }"
                      zle -N $cur_widget _zsh_highlight_widget_$prefix-$cur_widget;;

        # Builtin widget: override and make it call the builtin ".widget".
        builtin) eval "_zsh_highlight_widget_${(q)prefix}-${(q)cur_widget}() { _zsh_highlight_call_widget .${(q)cur_widget} -- \"\$@\" }"
                 zle -N $cur_widget _zsh_highlight_widget_$prefix-$cur_widget;;

        # Incomplete or nonexistent widget: Bind to z-sy-h directly.
        *)
           if [[ $cur_widget == zle-* ]] && (( ! ${+widgets[$cur_widget]} )); then
             _zsh_highlight_widget_${cur_widget}() { :; _zsh_highlight }
             zle -N $cur_widget _zsh_highlight_widget_$cur_widget
           else
        # Default: unhandled case.
             print -r -- >&2 "zsh-syntax-highlighting: unhandled ZLE widget ${(qq)cur_widget}"
             print -r -- >&2 "zsh-syntax-highlighting: (This is sometimes caused by doing \`bindkey <keys> ${(q-)cur_widget}\` without creating the ${(qq)cur_widget} widget with \`zle -N\` or \`zle -C\`.)"
           fi
      esac
    done
  }

@JamesYeoman What's your question? Did you read my previous comment?

Ah, sorry, I glossed over that second paragraph. Disregard what I said then


Automatic error report

Spyder crashes while closing jupyter notebook.
<!---   *** BEFORE SUBMITTING: PASTE CLIPBOARD HERE TO COMPLETE YOUR REPORT ***   ---!>

Please describe step by step how you got this error so we can reproduce it in our side. If you fail to do that, we'll close this issue in a week from now.
Also, please read our
https://github.com/spyder-ide/spyder/wiki/Troubleshooting-Guide-and-FAQ
to see if you are able to fix this problem by following it.

Spyder crashes while closing jupyter notebook.

Jupyter notebook within Spyder, i.e. the spyder-notebook plugin? If so, this belongs in that repo, and be aware it currently has known issues and isn't maintained for lack of funds.

Closed due to lack of response. If you can provide more information, please re-open and do so. Thanks.


content: Distinguish direct and wildcard mentions

Currently, we don't distinguish the appearance of direct mentions and wildcard mentions:

The web app does that—

—and we should too, probably using the same colors web does.
I'll file a separate issue for a related but different feature: highlighting non-silent mentions of the self-user. That will take more data-model thinking. -> #647

(Should we add this to #309?)

This is one of the pieces of:

#157

in that the styling we have matches what was current in web when I started the prototype, but hasn't been updated.
Having this separate issue in the tracker is useful, though — for actually tackling #157, we'll probably want separate issues like this one anyway. And it provides an on-point answer for someone wondering why it doesn't match web. I'll edit #157 to point to this.

We've already done the first part of this: the mentions no longer look like the first screenshot above. Instead they always look like the blue pill in the second screenshot.
The remaining task is to have the distinct styling for group mentions.