CryptoSwift dependency license need clarification

As written in https://github.com/LFDT-Hiero/tsc/issues/3 we have the direct dependency<EMAIL_ADDRESS>that has a license that needs clarification.

License: https://github.com/krzyzanowskim/CryptoSwift?tab=License-1-ov-file#readme
License Text
Copyright (C) 2014-3099 Marcin Krzyżanowski<EMAIL_ADDRESS>This software is provided 'as-is', without any express or implied warranty.

In no event will the authors be held liable for any damages arising from the use of this software.

Permission is granted to anyone to use this software for any purpose,including commercial applications, and to alter it and redistribute it freely, subject to the following restrictions:

- The origin of this software must not be misrepresented; you must not claim that you wrote the original software. If you use this software in a product, an acknowledgment in the product documentation is required.
- Altered source versions must be plainly marked as such, and must not be misrepresented as being the original software.
- This notice may not be removed or altered from any source or binary distribution.
- Redistributions of any form whatsoever must retain the following acknowledgment: 'This product includes software developed by the "Marcin Krzyzanowski" (http://krzyzanowskim.com/).'

The license appears to be a modification of the Zlib license, which takes the suggested but not required attribution requirements of Zlib and makes them mandatory and additionally adds various requirements concerning attribution in both source and binary form. We need to carefully review the strict attribution requirements and should also have a plan for how attribution and the other statements the license requires will be maintained in source and binary form. It might be worth considering alternatives that do not contain such strict attribution requirements.

@hendrikebbers So there are other Crypto libraries for Swift that have less license restrictions but none that offer the wide range of functionality that CryptoSwift does. Would it be appropriate to add a NOTICE in the Swift SDK acknowledging CryptoSwift license for now, or do alternatives need to be incorporated in order to move to transition to Hiero?

@RickyLB "none that offer the wide range of functionality" does that mean that we need to replace it with like 2 libs? Because I assume the license will be a problem when moving it to Linux Foundation.

@hendrikebbers Correct— this will require an overhaul of the key implementations in the SDK. In the meantime, i'll start looking into other options. What's the priority of this at the moment?

In January as far as I know


Question about the number of categories related to the network.

Thanks for sharing good work!
I have a simple question about your work.
Q1. Dose DeepSDF covers all the categories (ex. chair, plane, table, lamp, sofa) of one network?
Or Does It requires one class per one network for training and inference??

Given there are different config files for different classes in the example folder, I suspect there should be one model per class.

@amaleki2  Thanks for your replry.


Adding code coverage to Travis build

Also fixing the Travis badge URL, which was pointing to the wrong repo.

Hmm, coverage isn't working but it's passing anyway. Investigating...

Changes Unknown when pulling c999c691bcc3214164f6eda89f691febfb2c526c on mtlynch:add-coverage2 into ** on JeetShetty:master**.


HADOOP-16944. Jenkinsfile to use Yetus master

JIRA: https://issues.apache.org/jira/browse/HADOOP-16944

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 30s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
shadedclient
16m 43s
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 49s
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

36m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1917/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1917

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 203c1d0b4d22 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / cbe71ea

Max. process+thread count
307 (vs. ulimit of 5500)

modules
C: . U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1917/1/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.3.7

Powered by
Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
35m 52s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  0s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
shadedclient
16m 29s
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m  4s
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

70m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1917/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1917

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 95308d126511 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 55fcbcb

Max. process+thread count
309 (vs. ulimit of 5500)

modules
C: . U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1917/2/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.3.7

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
24m 40s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+0 :ok:
shelldocs
0m  1s
Shelldocs was not available.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ trunk Compile Tests _

+1 :green_heart:
shadedclient
13m 58s
branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
shellcheck
0m  0s
There were no new shellcheck issues.

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m  1s
patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
asflicense
0m 35s
The patch does not generate ASF License warnings.

55m  5s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1917/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1917

Optional Tests
dupname asflicense shellcheck shelldocs

uname
Linux 6677063af3a5 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 3481895

Max. process+thread count
476 (vs. ulimit of 5500)

modules
C: . U: .

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1917/3/console

versions
git=2.7.4 maven=3.3.9 shellcheck=0.3.7

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


I hope that I can change the default installation location

Description of the new feature / enhancement
I hope to configure the json file to install the software to the specified drive through winget, and I don't want to install it to C by default
Proposed technical implementation details
I hope to configure the json file to install the software to the specified drive through winget, and I don't want to install it to C by default

Duplicate of #3608


PROD-837 Fix READER access to workspace files in Terra UI

Jira Ticket: https://broadworkbench.atlassian.net/browse/PROD-837

Depends on Sam: https://github.com/broadinstitute/sam/pull/1102
Summary of changes:
Tells sam not to include a user project when getting signed urls for gcs objects.
What

If the calling user is a READER, they don't have billing project access. Therefore, providing the workspace project causes the signed url to fail when accessed.

Why

We broke it, now we fix it.

Testing strategy

[ ] Create a workspace, add a file, add another account as a READER, and make sure the reader can download the file from the UI.

I have confirmed that userProject no longer appears the url params of the signed URL and that a reader can download a file in the workspace.


--kube-context is not used

Great plugin!
It seems though that --kube-context to helm tiller does not have an effect. It uses the current-context, so it will deploy in current-context even though --kube-context is different, or if current-context is blank, will terminate with an error.

The issue is that Tiller uses the default configuration for the kubernetes client and it defaults to current-context. It's designed to be run inside the same cluster your are deploying to which is probably why they didn't add a flag for context.
I don't think there's a workaround except for changing the current context which is a bit annoying. I believe you'd have to add an option to tiller to make this work.
See here for client creation: https://github.com/helm/helm/blob/master/cmd/tiller/tiller.go#L150
And here for defaults: https://github.com/kubernetes/cli-runtime/blob/a04da5c88c0796c1dc5ff976a9c91999779ac0e4/pkg/genericclioptions/config_flags.go#L288

The easiest workaround is to use export KUBECONFIG=

I'm not sure I understand how that's a workaround. I want to use my same kubeconfig file and current context, but deploy using a different context.

@asetty I think I can tell you why it's so hard and KUBECONFIG is the best possible workaround that worth the effort. PTAL my comment in the context of an another helm-related tool https://github.com/roboll/helmfile/issues/642#issuecomment-500279829


Implement known_identity

This implements known_identity, has_known_identity as well as corresponding tests.
Changes buildins.hpp consist of adding static_cast<T> to the scalar branch (and slight reformatting, since some lines are now longer). This doesn't change anything for scalar values, as T is returned anyways. For vectors the static_cast makes the branch valid, and doesn't change the return type, since vectors don't use the scalar branch.
In HIPSYCL_BUILTIN_GENERATOR_UNARY_T_RET_INT the return value needs to be casted to int first, to tell the compiler how the casting should work.
The vector class needed to be adjusted slightly to make it a literal type. For this the constructors are now labeled constexpr and count_num_elements was moved into the detail namespace (was a private vector-member before).
The _storage needs a default initialization, because writing to uninitialized elements is only allowed starting with C++20.
The actual identity implementation is done using a macro, which creates specializations for the default template for both known_identity and has_known_identity. If no identity is known, a compile time error is triggered.
This PR only includes the known_identity struct, but doesn't add code to use it for example when computing reductions.

known_identity is already implemented according to spec in #578, but not for vector types. Maybe this PR should be rebased onto #578 as a hipSCYL specific extension for sycl::vec?

superseded by #778


LanguageRepresentation

Include an example for the LanguageRepresentation feature if possible.

Here's the feedback from the team internally:


Electron 6 Release Notes seem to be missing a lot

The current page of stable releases just shows this:

Quite a lot is missing from here. Is that update just delayed?

this is resolved now


[Feature] Add support for Bundler to manage Gem dependencies

What's this feature about?
Added --[no]-use-bundler flag so that you can manage Cocoapods gem using Bundler and execute bundle exec pod install rather than pod install if Gemfile exists.
Closes these issues:

[DISCUSSION] Use bundler to configure dependencies for iOS project
Don't rely on global pod installation, use bundled version

How to Test this PR?

Checkout the branch.
Create new project using --use-bundler via this command flutter create --platform ios,android test_case --use-bundler. It will make sure to add the proper Gemfile for you inside ios folder.
Add new dependency to the pubspec.yaml file that have a native counterpart. For example webview_flutter:
Build the iOS project via this command to build using Bundler, flutter build ios --use-bundler

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] I followed the breaking change policy and added Data Driven Fixes where supported.
[ ] All existing and new tests are passing.

Thank you for putting out this PR! However, I actually don't think we should make this change as we're planning to deprecate cocoapods, see https://github.com/flutter/flutter/issues/22998.
I apologize for the inconvenience, and I hope to see you around with future contributions!

Thank you @christopherfujino :)


Disabling manual control with service set_manual_control is giving errors about brightness_pct

I'm able to call the service to set manual control to true without issue. Recently (within the past week or so) I started getting errors when trying to call the service to disable manual control.
From the Developer page -> Call Service, this is what I was testing:
service: adaptive_lighting.set_manual_control
data:
  entity_id: switch.adaptive_lighting_al
  manual_control: false
  lights: light.lr_lamp

Here is the log after enabling debug mode:
This error originated from a custom integration.

Logger: homeassistant.helpers.script.websocket_api_script
Source: custom_components/adaptive_lighting/switch.py:733
Integration: Adaptive Lighting
First occurred: 12:18:05 PM (1 occurrences)
Last logged: 12:18:05 PM

websocket_api script: Error executing script. Unexpected error for call_service at pos 1: 'brightness_pct'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 366, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 566, in _async_call_service_step
    await service_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 1481, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1516, in _execute_service
    await handler.job.target(service_call)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 630, in handle_service
    await service.entity_service_call(
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 658, in entity_service_call
    future.result()  # pop exception if have
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 726, in async_request_call
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 695, in _handle_entity_call
    await result
  File "/config/custom_components/adaptive_lighting/switch.py", line 246, in handle_set_manual_control
    await switch._adapt_lights(
  File "/config/custom_components/adaptive_lighting/switch.py", line 846, in _adapt_lights
    await self._adapt_light(light, transition, force=force, context=context)
  File "/config/custom_components/adaptive_lighting/switch.py", line 733, in _adapt_light
    brightness = round(255 * self._settings["brightness_pct"] / 100)
KeyError: 'brightness_pct'

I originally thought this was because I was using a group (of lights) for the lights: parameter but switching to a single light produced the same results.

I think this is related to #112 as I was also seeing the errors related to sunrise. Strangely, Adaptive Lighting wasn't showing as an installed repo for me in HACS so I added it, installed it and restarted HA and everything appears to be working now (though I've abandoned the automation I had to set manual control for specific rooms in favor of multiple "installs" of Adaptive Lighting for each room and using the switch.adaptive_lighting_<room_name> to toggle rooms instead.

This is still an issue for me with the same stack trace, it happens on all of my adaptive_lighting.apply service calls from all of my automations.
Logger: homeassistant.components.automation.xx_my_automation_xx
Source: custom_components/adaptive_lighting/switch.py:772
Integration: Automation (documentation, issues)
First occurred: 15:23:26 (2 occurrences)
Last logged: 15:23:26

XX My Automation XX: Error executing script. Unexpected error for call_service at pos 2: 'brightness_pct'
While executing automation automation.xx_my_automation_xx
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 368, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 568, in _async_call_service_step
    await service_task
  File "/usr/src/homeassistant/homeassistant/core.py", line 1491, in async_call
    task.result()
  File "/usr/src/homeassistant/homeassistant/core.py", line 1526, in _execute_service
    await handler.job.target(service_call)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 666, in handle_service
    await service.entity_service_call(
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 658, in entity_service_call
    future.result()  # pop exception if have
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 760, in async_request_call
    await coro
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 695, in _handle_entity_call
    await result
  File "/config/custom_components/adaptive_lighting/switch.py", line 222, in handle_apply
    await switch._adapt_light(  # pylint: disable=protected-access
  File "/config/custom_components/adaptive_lighting/switch.py", line 772, in _adapt_light
    brightness = round(255 * self._settings["brightness_pct"] / 100)
KeyError: 'brightness_pct'

Any update on this?


Examples?

I'm struggling to use this effectively and am wondering if you could provide some examples.
The actually communication with the STUN server works fine: it returns the public addr observed by the STUN server.
But USING this information isn't working for me, and it has me wondering if I'm just misunderstanding how the package works (thus the request for examples).
For example, when calling stun.Discover it returns a conn and addr. I'm attempting, after performing the discover, to receive UDP packets sent to addr. So I'm trying to read from the return conn (while sending UDP messages to addr from another machine), but nothing ever comes through.
The purpose of STUN in my understanding is to hole-punch so peers can send UDP traffic to the public addr, which is then forwarded to the correct host. Can I see an example of how this package gets that done?

@isaachess Yes, It should work exactly you described, but currently stun.Discover uses net.Dial instead of Listen (so, the socket is associated with a STUN-server's address) and hole-punching does not work. I'll fix it, thanks.

I just spent the better part of a day tearing my hair out over this, so I wanted to make sure that I documented exactly what's happening here, in the hopes that someone else won't have to.
Although @pixelbender fixed the issue with the fact that net.Listen* wasn't being used, the net.PacketConn returned by Discover() isn't actually  relinquished in a way that allows it to be repurposed! When the Conn is created, an Agent is set up to handle it. Upon start, the Agent calls this method, which calls ReadFrom on the net.PacketConn to loop over/handle received messages. Turns out, when the net.PacketConn is handed back to you from Discover(), that loop is never actually stopped.
I guess that's what @pixelbender meant by the TODO: hijack comment 😜 Anyway, long story short, it turns out that this issue hasn't really been addressed.

@isaachess That PR (#8) should allow you to use this library for hole-punching. The net.PacketConn you get back is now usable, so if you know the public address (host/port) of your peer, you can get them to try to send packets to one another at the same time.
For what it's worth, you'll do something like this for both clients (although you still need an external service to help them exchange addresses):
conn, externalAddr, err := stun.Discover(STUNServer)
if err != nil {
	return nil, errors.Wrap(err, "failed to set up public UDP socket")
}
peerExternalAddr := &net.UDPAddr{
	IP: net.ParseIP("<peer addr>"),
	Port: 1234,
}
conn.WriteTo([]byte("hello"), peerExternalAddr)

Could you please point me to the example on how to setup a TCP connection between 2 nodes both behind NAT?
Something like node1_code.go, node2_code.go, external_server_code.go
Thanks!


Adding a Java program to test if two strings are anagrams.

I would like to add a program created using Java to check if two strings are anagrams. Please assign this issue to me. @Ethan-Nowa

/assign


ellipsis in tuple patterns

This PR lowers ellipsis in tuple patterns. It fixes a bug in the way ellipsis were previously lowered (by replacing the ellipsis with a single Pat::Wild no matter how many items the .. was taking the place of).
It also uses this new information to properly handle .. in tuple struct patterns when perform match statement exhaustiveness checks.
While this PR provides the building blocks for match statement exhaustiveness checks for tuples, there are some additional challenges there, so that is still unimplemented (unlike tuple structs).

bors r+


[occm] loadbalancer doesn't honor the spec.loadBalancerIP on service update

Is this a BUG REPORT or FEATURE REQUEST?:
/kind bug
What happened:
Documentation says:

Sometimes it's useful to use an existing available floating IP rather than creating a new one, especially in the automation scenario. In the example below, <IP_ADDRESS> is an available floating IP created in the OpenStack Networking service.

NOTE: If <IP_ADDRESS> is not available, a new floating IP will be created automatically from the configured public network. If <IP_ADDRESS> is already associated with another port, the Service creation will fail.

However once I create a svc with no spec.loadBalancerIP defined, OCCM assigns the random FIP to a LB. If I want to change the FIP on the existing service by setting the spec.loadBalancerIP, the setting persists, but the actual FIP is not assigned.
What you expected to happen:
I expect OCCM to assign a new FIP once spec.loadBalancerIP is changed.
How to reproduce it:

create a service without a FIP
assign a  spec.loadBalancerIP to a desired value
FIP is not changed

Anything else we need to know?:
https://github.com/kubernetes/cloud-provider-openstack/blob/ed517e1f07057cd439542c73bff12102d8849dde/pkg/openstack/loadbalancer.go#L1039-L1041
see also #2377, where this bug is seen more clearly.
Environment:

openstack-cloud-controller-manager(or other related binary) version: master
OpenStack version: ???
Others: ???

@kayrus spec.LoadbalancerIP is deprecated, see https://github.com/kubernetes/cloud-provider-gcp/issues/371

and imo current code is working like expected. If your tenant has floating ip address that is specified, it will use that.

Yes, I agree with @zetaab, if possible, we can adopt the new way of assigning the floating IP for LB. nevertheless, one thing I would like to clarify is that "Field Service.Spec.LoadBalancerIP is deprecated, and it will not be deleted".
I have verified the feature of updating the Octavia LB with a single floating IP, as described in the documentation. and the result is FIP of this LB has been changed.
I would like to propose fixing this issue to ensure consistency with the documentation. I've noticed that the logic currently only allows newly created LBs to use the LoadBalancerIP. Perhaps we could consider a hot-fix similar to the method described below.
if (floatIP == nil && loadBalancerIP != "") || (floatIP != nil && floatIP. FloatingIP != loadBalancerIP) {
    // check & attach the FloatingIP to LB
}

From my perspective it would be best to switch to the annotation first. It doesn't hurt to use the existing field, but note that very soon we'll be adding dual stack LBs support. There I'll advocate to ignore spec.loadBalancerIP existence completely and only use annotations.

I believe the annotation approach mirrors the existing method(the same logic). For this issue, I intend to address it ASSP.
Additionally, I'm aware @kayrus makes efforts to significantly refactor for the enhancement, maybe the support for dual stack LBs via annotation can be encompassed within that PR or later.

seems PR #2451 is intend to fix with older way while we actually want to use loadbalancer.openstack.org/floating-ip
are we good with temp fix first then go with the annotation ?

@jichenjc, I've incorporated the annotation approach and adjusted the priority for compatibility purposes.

I notice this PR #2451 introduce a new annotation loadbalancer.openstack.org/floating-ip, I like this change. But, It seems like similar with service.beta.kubernetes.io/openstack-internal-load-balancer in semantics. IMO, If a LB has FloatingIP it is external and vice versa. So, whether or not we should deprecate service.beta.kubernetes.io/openstack-internal-load-balancer after we introduced loadbalancer.openstack.org/floating-ip.  And I strongly suggest that we clarify the definition and relationship of loadbalancer.openstack.org/floating-ip and service.beta.kubernetes.io/openstack-internal-load-balancer and service.spec.loadBalancerIP firstly. It seems like a bit untidy now.

@jeffyjf well if you look these annotations https://github.com/kubernetes/cloud-provider-openstack/blob/eeba48501bf743e3992093bd806a513ad103a347/pkg/openstack/loadbalancer.go#L69-L103 there are not many service.beta.kubernetes.io annotations. Which means that new ones will be using loadbalancer.openstack.org

@zetaab I agree with you, I also think there are not many service.beta.kubernetes.io annotations.  I just think the annotation service.beta.kubernetes.io/openstack-internal-load-balancer is redundant after we introduce loadbalancer.openstack.org/floating-ip. Service has floating-ip means it is external and Service has no floating-ip means it is internal.

it does not mean always that. When you create new loadbalancer and want to provision new floating ip, you do not need to define loadbalancer.openstack.org/floating-ip annotation. Only if someone wants to use existing ip loadbalancer.openstack.org/floating-ip is useful.

Yep, what Jesse says. All LBs are external in CPO by default. We cannot change that. We could probably make setting loadbalancer.openstack.org/floating-ip=None internal, but I don't exactly see that much value in the effort. Current code doing internal LBs is super complicated already due to shared LBs.

Thanks @zetaab @dulek. I got it.

Current code doing internal LBs is super complicated already due to shared LBs.

I really agree that.

The annotation proposal from @kayrus has been revised. as follows:
loadbalancer.openstack.org/floatingip: designed for the dual stack
loadbalancer.openstack.org/floatingip-v4:   same as the spec.loadBalancerIP

from my perspective, if the intention is to utilize annotation for dual-stack support, maintaining a single, clear annotation should be considered for simplicity and to avoid confusion.

and how would that work if I have dualstack setup and I specify also loadbalancer.openstack.org/floatingip-v4? Which annotation it should use?

/remove-lifecycle stale
Still valid to me.


Creator: Hovering an arrow highlights it

A suggestion from a codesigner:
Hovering an arrow makes it highlight. We could probably have it increase in line width by a visually distinct amount.
We should also consider adding a tooltip on hover that indicates the components joined
e.g., "imgPositionController -> img1Position", "img1Position -> imgComponent"

JG noted we could also do this for a hovered component to highlight all arrows connected to it. Let's investigate the above suggestion first, then default to the suggestion in this comment.

For expediency, let's go with the simpler implementation and just highlight all arrows connected to a component when it is hovered.

OK, I went with the following.

When a component is being edited, connections in or out of that component have a thicker line width. Other connections have a thinner line width.
When there is no edit, all lines have the same default line width.
I used the active edit instead of 'hover' for ease and for better performance. However, if hover is better, we can do that instead easily now.
This doubles the number of canvas strokes so we may have a performance hit.
Line widths are in ViewConstants.js and can be adjusted if you want to play around with values.

Just made a slight decrease to the line width on the edited component to emphasize the dashes. The decrease to the others means the visual contrast is plenty.


Control over bluetooth

Have you explored the option of controlling GoPro cameras over bluetooth? Is it actually possible? The information I'm finding suggests this is only possible on iOS to pair the devices, after which the camera is controlled via WiFi. I'm not willing to believe they've wasted the bluetooth radio for that. Thoughts?

http://developer.gopro.com/info they also allow camera control using BLE but right now there isn't a device that supports it. I already posted the commands to pair with Bluetooth devices.

@KonradIT, planning on connecting via a RPi 3, which should support BLE (Bluetooth 4.1). I assume there would be a bluetooth specific API and the reverse-engineered http requests would be irrelevant.

Someone needs to get their hands on a BLE compatible GoPro controller device, which there isn't right now

Thought that smartphones have BLE for years now. Maybe decompiling the camera firmware could reveal more hints... :o)

maybe, you want to try?

@KonradIT, sure, @evilwombat has some tools for decompiling the firmware, can keep this thread updated if you're interested.

please do.


chore: update deps: google-{gax,proto-files}

Coverage remained the same at 100.0% when pulling 9a94c9c2db971837e70f9405f9da6908be85dc2c on ofrobots:deps into 19c7dcd9e9ec0319b6a45a39e14e668444499a9d on GoogleCloudPlatform:master.

Coverage remained the same at 100.0% when pulling 99d3b43adddf7ec0ebb723b3d186916efd80183f on ofrobots:deps into 19c7dcd9e9ec0319b6a45a39e14e668444499a9d on GoogleCloudPlatform:master.

Removed the change from logging, monitoring and spanner as those code-bases are already migrated.

Coverage remained the same at 100.0% when pulling 01b004f42d261d93b67ba825e19260ed1dbff71e on ofrobots:deps into 19c7dcd9e9ec0319b6a45a39e14e668444499a9d on GoogleCloudPlatform:master.


Add tests for ignoring symlinks

This adds tests for the expected behavior in https://github.com/rust-lang/cargo/issues/10032. Interestingly, these tests pass (🎉). Will update that issue with more details shortly, but figured these tests were worthwhile to add to the testsuite anyway now that I've written them.

r? @ehuss
(rust-highfive has picked a reviewer for you, use r? to override)

The Windows failure here is surprising. It suggests that on Windows, Cargo considers the symlinks files, not directories, and thus they don't match /symlink/. Probably around here
https://github.com/rust-lang/cargo/blob/b74705419e39b206b326ce1e6187ad7c383dcb0e/src/cargo/sources/path.rs#L395-L396
Even though the docs for Path::is_dir pretty clearly state

This function will traverse symbolic links to query information about the destination file.

🤔
Given that I don't have a Windows computer handy to debug with, I think this has me stomped for now.
I'll just add that the fix I had originally intended for #10032 is
        let is_dir = path.is_dir();

        // Symlinks that point to directories are a little odd because they are both directories
        // _and_ files for the purposes of matching. At least as far as Cargo is concerned, since
        // we never include symlinks directly in the pacakge. The actual rules are:
        //
        //  1. A pattern of `/symlink` should match the symlink itself.
        //  2. A pattern of `/symlink/` should match the symlink's target's contents.
        //
        // But for us, this means that if a directory symlink is excluded as either a directory
        // _or_ a file, it should be skipped.
        if !is_root && is_dir {
            let is_symlink = path.symlink_metadata()?.file_type().is_symlink();
            // See if the symlink is filtered out when viewed as a file -- if so, skip it.
            // The directory case is handled by the regular logic below.
            if is_symlink && !(*filter)(path, false)? {
                return Ok(());
            }
        }

        if !is_root && !(*filter)(path, is_dir)? {

which may come in handy for whoever decides to try tackling this.

I believe the issue here is with libgit2.  When creating the repository, the add_all function ends up adding the symbolic links to the repo. There is something about libgit2's gitignore implementation that is not honoring symlinks as directories.  I have opened https://github.com/libgit2/libgit2/issues/6250 with a reproduction.
If you want to just disable these tests on Windows, I think it would be fine.

Pushed a change that ignores the test on Windows 👍

Thanks!
@bors r+

:pushpin: Commit 79cc65fa5ad5f84a5df9542a2a1d689975e5f75e has been approved by ehuss

:hourglass: Testing commit 79cc65fa5ad5f84a5df9542a2a1d689975e5f75e with merge e458f6d32002832181bb0b50404b9c74d13284e2...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing e458f6d32002832181bb0b50404b9c74d13284e2 to master...


Update plugin svg from 32x32 px to 24x24 px

Can you regenerate InteractiveHtmlBom/icon.png ? That's the one that is rendered in toolbar.
I haven't done simple scaling so far because I'm afraid that the features that I pixel aligned for 32px will be blurry in 24px unless they are realigned and there may not be space to realign them so icon may have to be simplified.

Sure. I've just scaled it down to since I was not sure what you wanted to do. I will regenerate the png, It is is not goog, we can fix it later, cool? Because 32px icon it is worst than a blurry one, I think.

I redid the icon, thanks for the PR still.

No problem. Thanks for fixing to this.
On Thu, Jan 27, 2022, 05:09 qu1ck @.***> wrote:

I redid the icon, thanks for the PR still.
—
Reply to this email directly, view it on GitHub
https://github.com/openscopeproject/InteractiveHtmlBom/pull/285#issuecomment-1022949623,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJX7YEHO7GN4VOC2LTIUMLUYD4STANCNFSM5M4XRVXA
.
You are receiving this because you authored the thread.Message ID:
@.***>


add ability to provide custom grunt task as cli option

This enables developers to do specific grunt build process for development, local, production, or any number of environments

@harsaharsa is this something you can merge?

This is now in master with https://github.com/AppGyver/steroids/commit/2bc18e1097d245e38d8d25f5672bf4f3fb7f8929 – I added usage information and changelog. Thanks for this!


Is there plans to support cordova-android 6.3.0+?

Great library really enjoy it! This is just a simple question, I hope it was alright to write it here. Are there any future plans to support cordova-android 6.3.0+? Support for new 7.0.0 would be awesome.
Thanks, keep up the good work!

Yes. Didn't test it myself, but Maybe it's already working on 7.0.0.

@mauron85 Thanks for the fast answer, great will definitely keep an eye out for it.


Python numeric trait properties can be set to the wrong type

What
Python float trait properties can easily be set to int values without realising, causing an empty optional when attempting to retrieve them.
ACs

An TypeError exception is thrown in Python trait view class mutator methods when the incorrect value type is given.

We already have the following code in place
        if not isinstance({{ VarName }}, {{ VarType }}):
            raise TypeError("{{ property.id }} must be a '{{ VarType }}'.")
        self.__data.setTraitProperty(self.kId, "{{ property.id }}", {{ VarName }}

I confirmed this works fine to ensure you can't set a float trait property with an int value.
However, it is possible to set a bool value on an int property. Perhaps the description in the issue had the wrong type?
I'll update the description.


Backticks in document definitions cause syntax errors

Because Sync Gateway uses backticks (`) to denote the beginning and end of multiline strings, any backtick that happens to appear in a document definition will be treated by Sync Gateway as the closing character of the sync function's multiline string, resulting in a syntax error (e.g. "FATAL: Error reading config file config/synctos-test.json: invalid character 'p' after object key:value pair -- rest.ParseCommandLine() at config.go:476") when the sync function is loaded. Therefore, backticks should be replaced with the escape sequence "\`" when generating a sync function.

Satisfied by #114


feat(curriculum): add markdown converter lab

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

@zairahira Regarding paragraphs, I'm not asking to convert them because it can be a bit complex (although it would make sense to have them in the HTML). Since campers are not supposed to copy the demo I suppose it's fine have some extra functionalities there. If we prefer to not have that, for whatever reason, we can remove paragraphs from it.
Otherwise we could add more user stories to include paragraphs. I'd be happy to write more tests for those in case we agree that they should be able to convert them.
In any case, for the way tests are written, there shouldn't be any issues other than the mismatch between the output mentioned in the hint ... and the one obtained from the demo
...
.

The tests ran fine with different solutions 👍

@moT01 I made some changes but I'm not sure how much I should explain about the markdown syntax.
Do you think that it would be better to convert each table row into a user story and add more info in each?

A PR has been merged that moves the block order from the meta.json file to the full-stack.json file.](https://github.com/freeCodeCamp/freeCodeCamp/pull/56795) This PR will need an update, and the order will need to be removed from the meta.json file and moved to the new file.

I hope you don't mind @Dario-DC, I went ahead and updated this and made those fixes.

Also, I am not able to pass any of the tests due to these errors in the console:
// tests completed
// console output
[ReferenceError: convertMarkdown is not defined]
[ReferenceError: input is not defined]
[ReferenceError: input is not defined]

Also, I am not able to pass any of the tests due to these errors in the console:
// tests completed
// console output
[ReferenceError: convertMarkdown is not defined]
[ReferenceError: input is not defined]
[ReferenceError: input is not defined]

input is defined in --after-user-code-- so I guess the html is not linked to the script.js. Let me know if that is not the case @zairahira

I have ensured that the script.js is linked properly but I am still getting this error. I am using Chrome.

@ilenia-magoni caould you give this PR a review? I am running into some strange issues.

It works for me, I don't get the input is not defined if I copy the solution code @zairahira

Thanks for confirming that @ilenia-magoni 👍


User isn't gaining experience or going into the database

Describe the bug
For some reason, award_xp isn't putting the user into the database or giving experience even if I use add_record to put them in.
To Reproduce
Minimal code to reproduce the bug/error
I have written the bare minimum to get a bot running with this code, as this is how I have my bot written.
import discord
import asyncio
from discordLevelingSystem import DiscordLevelingSystem
from discordLevelingSystem.errors import DatabaseFileNotFound, LeaderboardNotFound, ImproperLeaderboard, NotConnected,\
    ConnectionFailure, DiscordLevelingSystemError
from discord.ext import commands
from discord.ext.commands import AutoShardedBot
from pathlib import Path
from config import donator_role, prefixes, token

intents = discord.Intents.default()
intents.message_content = True
intents.members = True
intents.presences = True

if not Path(r'database/DiscordLevelingSystem.db').is_file():
    try:
        DiscordLevelingSystem.create_database_file(r'./database/')
    except (ConnectionFailure, DatabaseFileNotFound) as error:
        raise error

class DiscordBot(AutoShardedBot):

    def __init__(self):
        super().__init__(
            command_prefix=commands.when_mentioned_or(*prefixes),
            intents=intents
        )

    lvl = DiscordLevelingSystem(rate=1, per=60.0, awards=None, announce_level_up=True, stack_awards=True)

    async def on_message(self, message: discord.Message) -> None:
        if message.author == self.user or message.author.bot:
            return
        await self.process_commands(message)
        try:
            await self.lvl.add_record(
                guild_id=message.guild.id,
                member_id=message.author.id,
                member_name=message.author.name,
                level=0
            )
        except DiscordLevelingSystemError:
            raise DiscordLevelingSystemError
        try:
            await self.lvl.award_xp(
                amount=[15, 25],
                message=message,
                refresh_name=True,
                bonus=DiscordLevelingSystem(
                    donator_role,
                    20,
                    multiply=False
                )
            )
        except (DatabaseFileNotFound, LeaderboardNotFound, ImproperLeaderboard, NotConnected) as e:
            raise e

if __name__ == "__main__":
    try:
        DiscordBot.lvl.connect_to_database_file(r'database/DiscordLevelingSystem.db')
    except (ConnectionFailure, DatabaseFileNotFound) as error:
        raise error
    asyncio.run(DiscordBot().start(token=token))

Traceback if any
N/A

Required Checklist

[X] I am using discord.py 2.0 or higher
[X] I am using discordLevelingSystem 1.2.0 or higher
[X] I have the required intents enabled

Version Info
What's the exact version of discordLevelingSystem/discord.py are you using?

discord.py: [2.1.0]
discordLevelingSystem: [1.2.0]

Not sure why you're catching an error just to raise it...but the bonus parameter in award_xp is incorrect, please refer to the documentation. When you raise the DiscordLevelingSystemError, it is missing the message parameter.
Other that that, I tested your code and it works fine for me (I made the mentioned corrections above before I tested the code).

Oh wow, I'm blind. Didn't even notice I was missing the .Bonus. Thanks for the help!


bower.json still on v2.0.6

🐛 Bug Report
When installing from bower it won't install the latest version including the fixes for => leaked to dist folder.
-> i changed to npm now but thought i'll let you know.
Have you read the Contributing Guidelines on issues?
A bit
Expected Behaviour
Installing through bower (yes, we still use that -.-) results in 2.0.6 for "^2.0.0"
Actual Behaviour
latest version of 2.0.8
To Reproduce
bower install clipboard
Operational System
Windows 10

Hey @TheGreatRefrigerator, thanks for the heads up.
Feel free to open a PR, we will really appreciate the engagement of the community.


Integration with Bitdefender context menu

Describe the solution you'd like
Add a context menu specifically for Bitdefender's. I'm not sure if it requires a special API or such, but that has been missing in the menu.

Additional context
Add any other context or screenshots about the feature request here. Ex: What device type/UI layout and app version?

Desktop OS Version: [Windows 10 20H2 19042.662]
App version: [v0.21.0]

@flumiie is this still an issue?

I still don't have the option

I might close this as it seems to be very specific to one software. I guess it's "impossible" for now. It's been 1.5 years and I'm now on Windows 11


Feat : Update prettier for TS 4.9

[x] update prettier to handle TS 4.9

@ayusharma, @byara Can we merge this ? It's blocking for projects using typescript 4.9 and the new satisfies operator

When can we expect an official release for this fix?

I'm also looking for this change.
With the latest version of yarn, you can patch the package on .yarnrc using packageExtensions
packageExtensions:
  '@trivago/prettier-plugin-sort-imports@*':
    dependencies:
      prettier: '^2.8.2'

Released in v4.1.0. I appreciate your patience. ❤


[bug] Pouch can't find correct image to create container while using repoDigest

Ⅰ. Issue Description
Pouch can't find correct image to create container while using repoDigest.
In Scenario 1，pouch created container with unexpected image
➜  ~ pouch images
IMAGE ID       IMAGE NAME                                     SIZE
4493f9e1fd39   registry.hub.docker.com/library/nginx:latest   42.46 MB
➜  ~ pouch run -d registry.hub.docker.com/library/fake_image@sha256:c4ee0ecb376636258447e1d8effb56c09c75fe7acf756bf7c13efadf38aa0aca
f6befab19d384e54202cd0b637f343cc7b3ec309245ecab379b57446195d3a9d
➜  ~ pouch inspect -f '{{.Image}}' f6befab19d384e54202cd0b637f343cc7b3ec309245ecab379b57446195d3a9d
registry.hub.docker.com/library/nginx:latest

In Scenaria 2, failed to create container caused by too many images
➜  ~ pouch images
IMAGE ID       IMAGE NAME                                      SIZE
786f81bbee21   registry.hub.docker.com/library/alpine:latest   1.97 MB
4493f9e1fd39   registry.hub.docker.com/library/nginx:latest    42.46 MB
➜  ~ pouch run -d registry.hub.docker.com/library/fake_image@sha256:c4ee0ecb376636258447e1d8effb56c09c75fe7acf756bf7c13efadf38aa0aca
Error: failed to run container: {"message":"image: : too many"}

Ⅱ. Describe what happened
Ⅲ. Describe what you expected to happen
Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?
Ⅵ. Environment:

pouch version (use pouch version):
OS (e.g. from /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

@faycheng Thanks for your issue.
Actually the code of pouch's image is complicated and confusing and it will be hard to maintain in the future.
So I refactor the related code and make the rule more simple #973 , also fix the bug in this issue.
Thanks again for your issue and would you like to convert it into a test case in test/cli_images_test.go ? :)

@YaoZengzeng Thanks for your repay.
And i will create a pr to convert this issue into a test case.


Update with info on build command

Update the docs with  the build command and add missing required dependency. Clears up #8

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #9   +/-   ##
=======================================
  Coverage   93.37%   93.37%
=======================================
  Files          29       29
  Lines         906      906
=======================================
  Hits          846      846
  Misses         60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33cbf3...12094fe. Read the comment docs.


Add StackVariable support in r2script thanks @oddcoder !

Add StackVariable support in r2script thanks @oddcoder !

looks good to me

Awesome !


Add a check for Room only ranks

Normally when you do /owner it gives 'did you mean /roomowner or /globalowner?' However global room owner doesn't exist as owner is a room only rank. This PR fixes this issue.
Sorry for the bad pr name, I'm still kinda new to contributing here.

Thanks!


Improve validation and representation of FrameOptions

Description
Based on the work from #1345 where FrameOptions were defined as:
CREATE field type='default', cacheType='ranked', cacheSize=10000
CREATE field type='int', min=0, max=1023
CREATE field type='time', quantum='YMD'

We need to decide how best to validate options on frame creation.
For example, should the following raise an error:
{"options":{"type":"int", "cacheType": "ranked"}}

Frame type int doesn't take a cacheType. Currently, we just ignore this, but perhaps we should raise an error.
Also, when frames are displayed in the schema, it can look like this:
"options":{"type":"int","cacheType":"none","max":10000}

Two issues here:

cacheType, even though it's none, doesn't apply to int frames
min is excluded because it is 0

Success criteria (What criteria will consider this ticket closeable?)
We have defined and implemented how best to validate and display frame options.

Probably the easiest thing would be to have separate options structs for each field type - then we can use Decoder.DisallowUnknownFields and not use omitempty to get the behavior we want.


Refactor reward modelling script to work with chat models

What does this PR do?

This PR cleans up the reward modelling script which was a bit broken for chat models due to absent chat templates. I also took the liberty of training a small Qwen2 reward model with it so that we can update the online DPO example (the SmolLM models don't work for reward modelling for reasons I'll investigate separately)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a GitHub issue? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


New Feature Request - Slashcommand SysID Searches

Please consider adding sys_id search functionality to the SlashCommands.
For example, today if this command is used /br f78dc6038f00110036bf21ca47e79af8
The resulting page is:
https://instance.service-now.com/sys_script_list.do?sysparm_query=nameLIKEf78dc6038f00110036bf21ca47e79af8
I'm hoping that the sysid can be detected using a simple regex and if matched, the resulting page can be:
https://instance.service-now.com/sys_script_list.do?sysparm_query=sys_id%3Df78dc6038f00110036bf21ca47e79af8
or
https://instance.service-now.com/sys_script_list.do?sysparm_query=nameLIKEf78dc6038f00110036bf21ca47e79af8^ORsys_id%3Df78dc6038f00110036bf21ca47e79af8

Off day...Wrong tool so please ignore.
https://github.com/arnoudkooi/ServiceNow-Utils/issues/120


[Minor] Fix Java Lint errors introduced by #13286 and 13280

What changes were proposed in this pull request?
Fix Java Lint errors introduced by #13286  and #13280

remove unused imports
Change Append and Complete to append and complete

How was this patch tested?
Existing tests

Test build #59833 has started for PR 13464 at commit 09486b1.

Test build #59833 has finished for PR 13464 at commit 09486b1.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59833/
Test PASSed.

Test build #59843 has started for PR 13464 at commit 2eb12af.

Test build #59843 has finished for PR 13464 at commit 2eb12af.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59843/
Test PASSed.

Oh, shouldn't we just fix that method name? I don't see why it was named Append() CC @tdas?

This is not the right fix. Please close this PR.

@andrewor14 btw making it lowercase(which was my first fix) or adding an
exception in check style suppression, please let me know what is the way
here
On Friday 3 June 2016, andrewor14<EMAIL_ADDRESS>wrote:

This is not the right fix. Please close this PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/13464#issuecomment-223424215, or mute
the thread
https://github.com/notifications/unsubscribe/ABUJw7L7gVmt9GNG6MKKT-pD2FaEWhxuks5qH0eygaJpZM4IsPqi
.

I believe it is intended to be upper case to match scala; it's just that for java it must be a method so that's failing the style. @srowen is there anyway to turn off the lint checks for a part of the code like scalastyle:off?

@andrewor14 As @dongjoon-hyun has suggested simply added the file to dev/checkstyle-suppressions.xml should work

@andrewor14 ah OK if that was on purpose, this can just be suppressed.

created a updated PR with couple of more java lint fixes #13559


Filemin Option

Hello!
First thanks for authentic theme.
In v 17.64 filemin option missed. only shortcuts available. but option was good then shortcuts. so please add same filemin option of v 17.62 in new version theme.

Thanks,

It will be added to module's options in the feature. Meanwhile, you can enable Toolbar back in the theme settings.

yes, got it, Thanks


Adding development strategy md file

[x] Written all the user stories
[x] written according to the backlog and the design
[x] discussed with the teammates

Updated comments


Add proper S3 signature version 4 support

Add proper S3 signature version 4 support.
See https://github.com/request/request/issues/2708 for more info.

Why isn't this still merged? I'm working with Amazon S3 right now and I need this.

@dominikkadera i finally proceeded by using https://aws.amazon.com/sdk-for-node-js/. The is the official library from AWS for handling S3 (and other). It offers far more features (streaming files for example, which can be handy for large files) and supports all regions by default.
I would advice to use that module instead, when you want proper S3 support.


Fixes issue #714 - Add HandlesTypes functionality

Fixes #714

Thanks for the great work!

Can you see if you can replace the Jersey initializer with the ServletContainerInitializer extension and then validate it indeed bootstraps Jersey?

I have tested using the org.glassfish.jersey.servlet.init.JerseyServletContainerInitializer instead of our JerseyInitializer it indeed started Jersey.
The Mojarra and Myfaces won't work right away because we don't scan all the annotated classes it requires but for JAX-RS, it is only four classes.

Actually we should not directly have to use the org.glassfish.jersey.servlet.init.JerseyServletContainerInitializer, but instead use cloud.piranha.webapp.scinitializer.ServletContainerInitializerExtension and let it take care of adding the Jersey specific class automatically

Alright! I do some more tests and change to use the ServletContainerInitializerExtension


feat: validate linked operations

W.I.P.
Issue Reference(s):
Fixes #1355

Summary by CodeRabbit

New Features

Introduced asynchronous validation and construction for server configurations and application contexts.
Added new methods and public visibility to various structs, enhancing functionality and accessibility.
Implemented endpoint schema checks before logging configuration information.
Expanded the rest module with a new operation module and enhanced endpoint handling capabilities.

Refactor

Modified initialization patterns across several components to utilize asynchronous operations and consolidated argument passing.
Updated struct fields and method implementations for clearer, more efficient code execution.

Bug Fixes

Fixed endpoint validation logic to ensure correct configuration and operation handling.

Tests

Adjusted test setups to align with the new asynchronous initialization and configuration patterns.

Can we set the file name in the trace?
ERROR Invalid Configuration
Caused by:
  • Unknown field "posts" on type "User". [at 17:5]

The [at 17:5] isn't very useful
Expected
ERROR Invalid Configuration
Caused by:
  • Unknown field "posts" on type "User". [at ./routes.graphql:17:5]

Can we set the file name in the trace?
ERROR Invalid Configuration
Caused by:
  • Unknown field "posts" on type "User". [at 17:5]

The [at 17:5] isn't very useful
Expected
ERROR Invalid Configuration
Caused by:
  • Unknown field "posts" on type "User". [at ./routes.graphql:17:5]

hard to pass path to the places where we validate.. might have to carry list of the paths just for this


AzureCommunicationChat: Guidelines Exceptions

[ ] Trouter bitcode enabled. [Trouter]
[ ] Trouter to support $ARCH_STANDARD (arm64) [Trouter]

Hello @tjprescott, Any update on this? I am not able to release the TestFlight build.
Could you please let me know another way to release TestFlight build for arm64 architecture?

@knvsl do you have an update on this or know who the right dev would be on the ACS Chat team?

@tjprescott due to other priorities we had to put this one on hold. We will be looking at closing all the iOS pending tasks on Q1 2022.
FYI @glorialimicrosoft  @LuChen-Microsoft

Hello @tjprescott, Any update on this?

Hi @kevalvadoliya, @juancamilor is your best point of contact for this issue, but my understanding is that one of the internal dependencies is not arm64 compatible and thus Chat cannot be either. @juancamilor can you comment further?

I'm facing the same issue. I'm not able to build the project when AzureCommunicationChat is embeded via Cocoapods, even if Bitcodes are disabled. Is there any workaround for now?


pandas.XMLDataSet

Description
Add a pandas.XMLDataSet to the list of dataset implementations. Newly available in pandas 1.3.0
https://pandas.pydata.org/docs/reference/api/pandas.read_xml.html?highlight=read_xml
https://pandas.pydata.org/docs/reference/api/pandas.DataFrame.to_xml.html?highlight=xml
Context
Such a feature would allow users to read data from a url or file straight into a pandas df without needing to create a node to parse the xml.
I'd be happy to have a crack at this one starting next week :) .

@lucasjamar we'd love a PR doing this, in theory you can copy and paste pandas.CSVDataSet and simply change the pandas call.

Sounds like a great idea! But I'd just check with @lorenabalan or @ignacioparicio first since I know we've recently changed the pandas requirement from 1.0 to 1.2 in develop (master is still >=0.24). There might be a good reason we can't yet support 1.3?

Closing as resolved in #822 , will be available in 0.18.0.


Using with maven

Hi, I am unable to use this as a dependency in my maven project.
Here is the relevant part of my pom.xml:
    <repositories>
        <repository>
            <id>jitpack.io</id>
            <url>https://jitpack.io</url>
        </repository>
    </repositories>

    <dependencies>
        <dependency>
            <groupId>com.github.Minestom</groupId>
            <artifactId>Minestom</artifactId>
            <version>master-SNAPSHOT</version>
        </dependency>
    </dependencies>

What should I change?

https://github.com/Minestom/Minestom/wiki/Dependencies
You should add the Minecraft repository, also I've had issues with using the "SNAPSHOT" version with jitpack. I think that you'll be better using the latest commit id (meaning that you'll unfortunately have to update manually)

Adding the minecraft repo wasn't neccesary for me, I just changed the version to master.


Update to version 1.5 (test from private repo)

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] ~Bumped the build number (if the version is unchanged)~
[X] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

@conda-forge-admin , please rerender

@conda-forge-admin , please rerender

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

@conda-forge-admin , please rerender

@conda-forge-admin please rerender

@conda-forge-admin restart ci

Finally, it works now on all platforms with all MPI-frameworks, thanks to the fixes in the compiler and mpich packages.


Opening link in Markdown file wrongly decodes %2F

Issue Type: Bug

Open a new editor of type Markdown
Paste a link including %2F, e.g. [test](https://example.com/This%20is%20a%20test%20with%2F%20in%20the%20URL)
Ctrl-Click or Cmd-Click the https link and open it in a browser
The %2F is wrongly decoded before the URL is handed to the browser

(This does not occur when clicking the link in the Markdown preview.)
VS Code version: Code 1.47.3 (91899dcef7b8110878ea59626991a18c8a6a1b3e, 2020-07-23T13:12:49.994Z)
OS version: Windows_NT x64 10.0.18363

I was taking a look at this and found this is related to #85930

I was taking a look at this and found this is related to #85930

Seems to be related to a larger issue #79474

Based on #79474 and #83645, I think this is a limitation of vscode.Uri and not something we can easily work around in the markdown extension (right now we use vscode.Uri.parse but I also tried using .with, which seems to cause its own set of issues)
I'm going to close this issue since it has not gotten much attention since it was opened, but if anyone still wants to try looking into this, we'd still take PRs


flask 3.0.3

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_6ee8pkacjo/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:68: license_file_overspecified: Using license_file and license_url is overspecified.

===== ERRORS =====

clone/recipe/meta.yaml:55: invalid_url: https://github.com/pallets/flask/blob/main/LICENSE.rst : Not reachable: 404
===== Final Report: =====
1 Error and 1 Warning were found

Linter check found the following problems:
ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_44htjf9qm1/clone` failed. (See above for error)
The following problems have been found:
===== WARNINGS =====

clone/recipe/meta.yaml:68: license_file_overspecified: Using license_file and license_url is overspecified.

===== ERRORS =====

clone/recipe/meta.yaml:55: invalid_url: https://github.com/pallets/flask/blob/main/LICENSE.rst : Not reachable: 404
===== Final Report: =====
1 Error and 1 Warning were found


AttributeError: module 'giskard.llm' has no attribute 'embeddings'

Issue Type
Bug
Source
source
Giskard Library Version
2.15.5
OS Platform and Distribution
Macos 14
Python version
3.11
Installed python packages
No response
Current Behaviour?
giskard.llm.embeddings.openai.set_embedding_model('text-embedding-ada-002')
    ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: module 'giskard.llm' has no attribute 'embeddings'

Standalone code OR list down the steps to reproduce the issue
import openai
import pandas as pd
import tiktoken
from scipy import spatial

from giskard import scan, Dataset, Model

giskard.llm.set_llm_model('gpt-4o-mini')
giskard.llm.embeddings.openai.set_embedding_model('text-embedding-ada-002')

Relevant log output
No response

okey, apparently there is a PR that was merged 45min ago
https://github.com/Giskard-AI/giskard/pull/2074

Hey @AmineDjeghri !
Thanks for reporting this.
Could you try running this code:
from giskard.llm.embeddings.openai import set_embedding_model
set_embedding_model('text-embedding-ada-002')

for an unknown reason, it seems that giskard.llm.embeddings.openai.set_embedding_model is not working directly. I'll investigate further to see the cause of this. In the meanwhile, the previous code snippet should work.

Hey
thanks it works
Do you know if the doc is deprecated ?
https://docs.giskard.ai/en/latest/reference/notebooks/LLM_QA_Winter_Olympics.html
i found this code and it seems that it doesn't work :
    query_embedding_response = openai.Embedding.create(model=EMBEDDING_MODEL, input=query)
    query_embedding = query_embedding_response["data"][0]["embedding"]

Traceback (most recent call last):
  File "/Users/aminedjeghri/PycharmProjects/ai-cloud-project-template/temp.py", line 102, in <module>
    ask('Which athletes won the gold medal in curling at the 2022 Winter Olympics?')
  File "/Users/aminedjeghri/PycharmProjects/ai-cloud-project-template/temp.py", line 83, in ask
    message = query_message(query, db, model=model, token_budget=token_budget)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/aminedjeghri/PycharmProjects/ai-cloud-project-template/temp.py", line 63, in query_message
    strings, _ = strings_ranked_by_relation(query, db)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/aminedjeghri/PycharmProjects/ai-cloud-project-template/temp.py", line 40, in strings_ranked_by_relation
    query_embedding_response = openai.Embedding.create(model=EMBEDDING_MODEL, input=query)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/aminedjeghri/PycharmProjects/ai-cloud-project-template/.venv/lib/python3.11/site-packages/openai/lib/_old_api.py", line 39, in __call__
    raise APIRemovedInV1(symbol=self._symbol)
openai.lib._old_api.APIRemovedInV1:

You tried to access openai.Embedding, but this is no longer supported in openai>=1.0.0 - see the README at https://github.com/openai/openai-python for the API.

You can run `openai migrate` to automatically upgrade your codebase to use the 1.0.0 interface.

Alternatively, you can pin your installation to the old version, e.g. `pip install openai==0.28`

Hey @henchaves - Can this issue be closed thanks to the latest release?

@AmineDjeghri yes, might be... I'll be reviewing soon all notebooks we have to make sure they are using the most up-to-dates libs such as OpenAI and RAGAS. Thanks!
@alexcombessie Yes, thanks!

Closing this issue because release v2.16.0 changes they way of setting an embedding model.


cache cleaned to empty when i restart a server

I have two servers A and B, they can synchronize their cache in each other server. when server A was restarted for some reasons and another server B's cache became empty. But i think the restart one should get cache from server B, instead of  server B's cache cleaned to empty, that's right? How can i config ehcache.xml or code in .java file so that i can achieve the purpose?

I was puzzled by this question for a long time, can anybody help me?

Hello,
Thanks for your interest in Ehcache 3.
We request that users start the conversation on the google group ehcache-users before opening issues.

Given this is really a usage question more than a bug report, closing and asking for the conversation to happen on the mailing list.


Mushroom stew doesn't auto-refill

I'm in 1.7.10, using "InventoryTweaks-1.59-dev-152"
When I eat a mushroom stew, it changes into an empty bowl instead of being replaced with another in inventory.  It happens without any other mods (except forge).  With biomes o plenty, their variation "Shroom Salad" works as you would expect (it's replaced with a new one).

I think I see why, although I'm surprised a different version works if it does the same thing as mushroom stew with leaving a bowl behind in the slot.


Ray Version - Complexities

Hello
Have been able to replicate the exact scenarios that you have mentioned in the paper. One question that I would like to ask, is were you able to try the same model with more complexities involved such as n number of warehouses/products? The reason I ask is the Ray version fails as more complexities get into the picture. Have you tried that? Wanted your opinions on it. Thank you so much!

Hi @aravsekar,
I need more information to help you!
For example, with which number of warehouses and products did you encounter the error? And what kind of error is it? With which version of Ray?
Have a great day!

Hello
Apologies for missing some information. I am testing the same with 2P and 3W and have attached the env settings of the same.

I am using the basic Ray version 1.0.0 because this is the only one that my Linux environment accepts. When I initially used Ray version 1.5.2, it gave me the error that is displayed below. Hence after changing that to 1.0.0 I was able to execute the three scenarios. But when I make it more complex with 2P and 3W, with Ray version 1.0.0, it gives me this error

Hence the reason I feel that some ray versions are not compatible with certain Linux environments.

Hi @aravsekar,
I agree that the problem is related to the Ray version given that with version 1.0.0 I also had problems on macOS.
I suggest you try the latest Ray version available (i.e., 2.0.0).
Let me know if you need any further information!

Thank you! By any chance can you check the env settings for a 2P and 3W, that I have attached? That will help if I am taking the right path. Please do let me know.


Temporarily stop updating queries editing/adding a task [until a fixed period after user stops typing]

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
When a note contains a query, if you start adding a new task or edit a task in the same note, it causes the page to refresh every 2 seconds, which I believe is done by the plugin to keep queries up to date. But, this makes an unpleasant and frustrating experience seeing the page content refreshed frequently.
✔ Solution
I think one of the possible solutions could be to stop refreshing the queries for some period of time if a new task is being added or an existing one is being edited. The condition could be: if the user has stopped typing for 10 seconds, it can be safely assumed that they're done with the new entry, so the plugin can now refresh the queries on that page.
❓ Alternatives
The alternative is to switch to edit mode, which works fine, but I wish the Live view also worked just fine (without the "extra" refreshes). Would greatly appreciate it if you could implement this (or something to this effect)
📝 Additional Context
No response

There is a way to do this already.
Edit the query with a line like this:
# limit 1

Or even:
# limit 0

Then, if you want to speed up redraws, un-comment that line (remove the #) temporarily.

Thank you for a very helpful suggestion. Above is a suggested workaround, in the meantime.

What platform are you on?

Linux

Hi @ma-sadeghi

Linux

Great, then if you want to track down the source of the performance problems, I suggest opening Obsidian's Developer Tools, viewing the console, and looking at the output generated when you edit a task.
You will see which files are getting updated, and how many tasks are being displayed in query blocks in which file.
If in Live Preview, there is what I believe to be an Obsidian bug which is that previously-viewed files remain 'open' in the Tab's history and these can accumulate over time.
If it happens, the workaround is to close the current file in a tab, and the retained files will then be closed.

There is a way to do this already.
Edit the query with a line like this:
# limit 1

Or even:
# limit 0

Then, if you want to speed up redraws, un-comment that line (remove the #) temporarily.

Thanks, but this only leaves one entry. I do want to see all the other entries. I find the other workaround, i.e., switching betweem edit/live mode more handy, especially that there's already a shortkey for it (ctrl+L), and it doesn't require modifying the queries. But, thanks anyway.

Hi @ma-sadeghi

Linux

Great, then if you want to track down the source of the performance problems, I suggest opening Obsidian's Developer Tools, viewing the console, and looking at the output generated when you edit a task.
You will see which files are getting updated, and how many tasks are being displayed in query blocks in which file.
If in Live Preview, there is what I believe to be an Obsidian bug which is that previously-viewed files remain 'open' in the Tab's history and these can accumulate over time.
If it happens, the workaround is to close the current file in a tab, and the retained files will then be closed.

Thanks for the suggestion, here's the output:
[Violation] Forced reflow while executing JavaScript took 38ms
plugin:obsidian-tasks-plugin:133 At least one task, its line number or its heading has changed in Journal/2022/11 November/2022-11-28.md: triggering a refresh of all active Tasks blocks in Live Preview and Reading mode views.
20plugin:obsidian-tasks-plugin:162 Render tasks called for a block in active file "Journal/2022/11 November/2022-11-28.md", to select from 373 tasks: plugin state: Warm
5plugin:obsidian-tasks-plugin:162 4 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 5 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 9 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 33 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
plugin:obsidian-tasks-plugin:133 At least one task, its line number or its heading has changed in Journal/2022/11 November/2022-11-28.md: triggering a refresh of all active Tasks blocks in Live Preview and Reading mode views.
20plugin:obsidian-tasks-plugin:162 Render tasks called for a block in active file "Journal/2022/11 November/2022-11-28.md", to select from 373 tasks: plugin state: Warm
5plugin:obsidian-tasks-plugin:162 4 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 5 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 9 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 33 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
plugin:obsidian-tasks-plugin:133 At least one task, its line number or its heading has changed in Journal/2022/11 November/2022-11-28.md: triggering a refresh of all active Tasks blocks in Live Preview and Reading mode views.
20plugin:obsidian-tasks-plugin:162 Render tasks called for a block in active file "Journal/2022/11 November/2022-11-28.md", to select from 373 tasks: plugin state: Warm
5plugin:obsidian-tasks-plugin:162 4 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 5 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 9 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 33 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
plugin:obsidian-tasks-plugin:133 At least one task, its line number or its heading has changed in Journal/2022/11 November/2022-11-28.md: triggering a refresh of all active Tasks blocks in Live Preview and Reading mode views.
20plugin:obsidian-tasks-plugin:162 Render tasks called for a block in active file "Journal/2022/11 November/2022-11-28.md", to select from 373 tasks: plugin state: Warm
5plugin:obsidian-tasks-plugin:162 4 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 5 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 9 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 33 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
plugin:obsidian-tasks-plugin:133 At least one task, its line number or its heading has changed in Journal/2022/11 November/2022-11-28.md: triggering a refresh of all active Tasks blocks in Live Preview and Reading mode views.
20plugin:obsidian-tasks-plugin:162 Render tasks called for a block in active file "Journal/2022/11 November/2022-11-28.md", to select from 373 tasks: plugin state: Warm
5plugin:obsidian-tasks-plugin:162 4 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 5 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
5plugin:obsidian-tasks-plugin:162 9 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"
plugin:obsidian-git:7420 simple-git [GitExecutor] [SPAWN] git (7) ['-c', 'core.quotepath=off', 'status', '--porcelain', '-b', '-u', '--null'] +0ms
plugin:obsidian-git:7420 simple-git [GitExecutor] [HANDLE] retrieving task output complete +32ms
plugin:obsidian-git:7420 simple-git [GitExecutor] [SPAWN] git (5) ['-c', 'core.quotepath=off', 'branch', '-v', '--no-color'] +0ms
plugin:obsidian-git:7420 simple-git [GitExecutor] [HANDLE] retrieving task output complete +23ms
5plugin:obsidian-tasks-plugin:162 33 of 373 tasks displayed in a block in "Journal/2022/11 November/2022-11-28.md"

Thank you. That's not what I expected at all. It's not picking up any other tasks blocks in other files to redraw.
That looks like a reasonable about of redraws and I would have predicted that Tasks and Obsidian could have coped with this. It obviously isn't, but that leaves me stumped for suggestions right now.
How are your tasks blocks created? Are they vanilla tasks blocks, or are they generated by dataviewjs?

They are generated by dataviewjs. I don't mind sharing them, so there you go (these are the exact same blocks in the note whose debug information I shared with you earlier):
Later
not done
(path does not include 2022-11-28) AND (tag includes later)
hide backlink
hide edit button

Leftover
not done
(((path includes Journal) AND (path does not include 2022-11-28)) OR (tag includes todo)) AND (tag does not include later) AND (tag does not include errand)
hide backlink
hide edit button

Done today
done 2022-11-28
hide backlink
hide edit button
hide done date

Errands
not done
(tag includes errand) AND (path does not include 2022-11-28)
hide backlink
hide edit button
hide done date

Try setting the Dataview setting Refresh Interval. Mine is one 5 seconds.

Try setting the Dataview setting Refresh Interval. Mine is on 5 seconds.

I just noticed that I don't even have dataview installed!

They are generated by dataviewjs

I just noticed that I don't even have dataview installed!

I am confused! What am I misunderstanding?

Sorry for the confusion, I wasn't aware of the jargon! I wasn't sure if my queries count as dataviewjs. Anyway, I don't have the "dataviewjs" plugin installed, I'm just using the "tasks" plugin typical queries.

Sorry to bug you again, @claremacrae can we proceed with the triage? I'd be happy to help if you further need information on my side.

Sorry, I am working hard on other areas of Tasks at the moment and supporting others who are contributing to this plugin.
I just don’t have the time and capacity to take on anything more.
Once the next release is out, @ilandikov and I intend to prioritise what we will work on next.
If it includes improving performance, then I already know of some first steps to take.
And then, if you still have a problem after we have released some performance improvements, then we can examine specifically what is going on in your setup.

Awesome, I don't have any particular issue at the moment, I just saw this open thread and thought I could chip in, only if it's providing you guys with some extra input to debug. So it's all good :) And thanks for working on this!

I think there might be another related issue: When multiple tabs are open (some with and some without task queries), Tasks plugin seems to be running in the background even when the active tab doesn't contain any task queries. This makes Obsidian choppy, which is noticeable when typing. I can open up a new issue if you'd like.

Hi @ma-sadeghi,

I think there might be another related issue: When multiple tabs are open (some with and some without task queries), Tasks plugin seems to be running in the background even when the active tab doesn't contain any task queries. This makes Obsidian choppy, which is noticeable when typing. I can open up a new issue if you'd like.

Thanks for the comment.
Looking at the issues labelled with scope: performance issues, I don't think that this suggestion has been recorded before.
So yes please, a new issue would be very welcome. Thank you.


Add post-synthesis verification

I have added the post-synthesis verification. Let me know if there is any change I am missing.

It looks like lines 160-188 in neq2lut could be moved to a function with few inputs, could you refactor this?

FYI, currently testing this on the branch feat/post-synth-verification.


Verify/examples does not get retested by /retest

Also because its a workflow_dispatch job users are not able to rerun themselves
currently /retest doesnt work due mostly to above, but almost certainly could be made to

cc @tyxia @alyssawilk

If you need to retest verify/examples, click through to the CI page and "Re-run all jobs"

i had assumed that contributors would be able to restart their own ci in github - but sadly it seems not

Thanks @phlax for bringing this up!
That will be great to have this supported so that the contributors besides maintainer can re-run it themselves. I think this issue is also applicable to other CD/CI checks like

,which may share the same root cause though

cc @adisuissa as well, we have discussed about this briefly before.

@tyxia can you confirm that you are not able to "Re-run all jobs"
if not, i think the only way to resolve this is to hook it into /retest

Yes, I am able to re-run as i don't see the button


xpraGtk3: 2.1.3 -> 2.2.5

Semi-automatic update generated by https://github.com/ryantm/nix-update tools. These checks were done:

built on NixOS
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/xpra -h got 0 exit code
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/xpra --help got 0 exit code
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/xpra --version and found version 2.2.5
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/udev_product_version -h got 0 exit code
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/udev_product_version --help got 0 exit code
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/udev_product_version help got 0 exit code
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/..xpra-wrapped-wrapped -h got 0 exit code
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/..xpra-wrapped-wrapped --help got 0 exit code
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/..xpra-wrapped-wrapped --version and found version 2.2.5
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/.xpra-wrapped -h got 0 exit code
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/.xpra-wrapped --help got 0 exit code
ran /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/.xpra-wrapped --version and found version 2.2.5
found 2.2.5 with grep in /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5
directory tree listing: https://gist.github.com/78f0907352399b3a9966fb6f71f1f0d4

No attempt on x86_64-darwin
The following builds were skipped because they don't evaluate on x86_64-darwin: xpraGtk3
No partial log is available.

Success on x86_64-linux (full log)
Attempted: xpraGtk3
Partial log (click to expand)
/nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/udev_product_version: interpreter directive changed from "/bin/bash" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/bash"
/nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/xpra_Xdummy: interpreter directive changed from "/bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/lib/cups/backend/xpraforwarder: interpreter directive changed from "/usr/bin/env python" to "/nix/store/b8gd0cbvkm59x8flbc53bvsvmskyig5a-python3-3.6.4/bin/python"
checking for references to /build in /nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5...
wrapping `/nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/.xpra-wrapped'...
wrapping `/nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/xpra_browser'...
wrapping `/nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/xpra_launcher'...
wrapping `/nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5/bin/xpra_signal_listener'...
running install tests
/nix/store/raq8vylxav1gm8v4gsphfmpbq6mw9362-xpra-2.2.5

Success on aarch64-linux (full log)
Attempted: xpraGtk3
Partial log (click to expand)
/nix/store/yvb0viyzfyyvyffdaksxdlfrvqcicy3s-xpra-2.2.5/bin/udev_product_version: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/yvb0viyzfyyvyffdaksxdlfrvqcicy3s-xpra-2.2.5/bin/xpra_Xdummy: interpreter directive changed from "/bin/sh" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/sh"
/nix/store/yvb0viyzfyyvyffdaksxdlfrvqcicy3s-xpra-2.2.5/lib/cups/backend/xpraforwarder: interpreter directive changed from "/usr/bin/env python" to "/nix/store/143hazf8s5236kvprxlrgw9fdgzkrg0v-python3-3.6.4/bin/python"
checking for references to /build in /nix/store/yvb0viyzfyyvyffdaksxdlfrvqcicy3s-xpra-2.2.5...
wrapping `/nix/store/yvb0viyzfyyvyffdaksxdlfrvqcicy3s-xpra-2.2.5/bin/.xpra-wrapped'...
wrapping `/nix/store/yvb0viyzfyyvyffdaksxdlfrvqcicy3s-xpra-2.2.5/bin/xpra_browser'...
wrapping `/nix/store/yvb0viyzfyyvyffdaksxdlfrvqcicy3s-xpra-2.2.5/bin/xpra_launcher'...
wrapping `/nix/store/yvb0viyzfyyvyffdaksxdlfrvqcicy3s-xpra-2.2.5/bin/xpra_signal_listener'...
running install tests
/nix/store/yvb0viyzfyyvyffdaksxdlfrvqcicy3s-xpra-2.2.5


Tag v0.16.0 missing from repository

I have a kubernetes cluster running on GCE and followed the steps outlined in the tutorial. However, I'm seeing the following message in my logs.
Failed to pull image "kubernetes/heapster:v0.16.0" from pod "monitoring-heapster-controller-jskpj_default" and container "heapster": Tag v0.16.0 not found in repository kubernetes/heapster

I'm not sure if this is supposed to be pulling from Dockerhub, but a cursory glance at the tags there seems to confirm that the v0.16.0 tag was not pushed to Dockerhub.
edit: forgot to mention that this was with the latest commit, fc13ee3bd0a3bc0f2c9bfd245c032286b5d82c74.

I'm seeing the same thing, attempting to run kubectl.sh create -f deploy/kube-config/influxdb out-of-the-box.
Spot-checked via docker directly:
$ docker run kubernetes/heapster:v0.16.0
Unable to find image 'kubernetes/heapster:v0.16.0' locally
Pulling repository kubernetes/heapster
FATA[0005] Tag v0.16.0 not found in repository kubernetes/heapster

Apologies, we uploaded to gcr.io, but not Docker Hub. Should be up now!


Add documentation

Kind of here https://github.com/xdefrag/ska/commit/822d9c40e91e44cebe082146394ac6387e6f1b5b
Sincerely, I find module pretty simple and small. Already provided documentation must be enough.


Merge master branch to prTesting1_202005132029 branch

Docs Build status updates of commit 6e924b1:
:clock10: Pending: waiting for processors (14 builds ahead of you)
:warning: Docs Build is busy, currently there are 14 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 6e924b1:
:warning: Validation status: warnings

File
Status
Preview URL
Details

split/updateTestCon1.md
:warning:Warning

Details

split/updateTestCon1.md

[Warning] Missing attribute: author. Add the current author's GitHub ID.
[Warning] Missing attribute: title. Add a title string to show in search engine results.
Line 0: [Warning] Markdown content is not allowed before H1.
Line 1: [Suggestion] H1 is required. Use a single hash (#) followed by a space to create your top-level heading. NOTE: This Suggestion will become a Warning on 04/01/2020.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Issue 31: make baseRequest throw payload messages not simply res

Find a possible solution at: https://codereview.stackexchange.com/questions/133911/fetch-how-to-deal-with-a-json-payload-in-an-error-response (implemented the last piece of code in this thread).
I'm not sure about how to test this?

Codecov Report

Merging #90 into master will decrease coverage by 0.58%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #90      +/-   ##
==========================================
- Coverage   82.56%   81.97%   -0.59%
==========================================
  Files          21       21
  Lines         281      283       +2
==========================================
  Hits          232      232
- Misses         49       51       +2

Impacted Files
Coverage Δ

src/baseRequest.js
70% <0%> (-5%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc26cb...982a473. Read the comment docs.


Add Dynamic Changes to Contributors in README.md

Issue Description
Current README.md only shows the static image of contributions made by contributors. It needs to be automatically updated as contributions of contributors are made.
Suggested Change
The changes need to be look something like this:

The above code o/p would be:

Rationale
No response
Urgency
Medium

@varshith257  i would like to work on it ,could you  please assign me

@varshith257  for this issue i can create a new GitHub Action workflow file .github/workflows/update-contributors.yml
that will run on every push or pull request merge to the main branch, adding the contributor and updating the README.md file automatically.OR
I can write a custom script that interacts with the GitHub API to fetch contributors and update your README.md.
could you you please  assign me

@Rishikesh63 I think we don't need to go for complexity. Refer to above suggested changes in the issue. It works fine


torrenttools changing windows cmd behaviour

After executing torrenttools, the arrow keys no longer move the cursor left and right, but produce the escape sequences ("^[[D^" and the like). Backspace is also affected, now deleting entire words rather than single characters.

Can you verify if this still happens with release  v0.6.2 ?

checked with v0.6.2, everything is fine with powershell, with cmd same problems.
powershell:
cmd:


refactor: persistence implementations in TransferProcessStore harmoni…

…ze in CRUD operations.
What this PR changes/adds
The persistence implementations in TransferProcessStore are refactrored in CRUD interactions.
Why it does that
consistency, recognizability
Further notes
Linked Issue(s)
ref #2559
Checklist

[ ] added appropriate tests?
[ ] performed checkstyle check locally?
[ ] added/updated copyright headers?
[ ] documented public classes/methods?
[ ] added/updated relevant documentation?
[ ] assigned appropriate label? (exclude from changelog with label no-changelog)
[ ] formatted title correctly? (take a look at the CONTRIBUTING and Etiquette for pull requests for details)

@majadlymhmd Needs a rebase.

@majadlymhmd can you rebase so this can be merged?

Codecov Report
Patch coverage: 85.00% and no project coverage change.

Comparison is base (f92bb70) 64.32% compared to head (b627f5d) 64.32%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2590   +/-   ##
=======================================
  Coverage   64.32%   64.32%
=======================================
  Files         949      949
  Lines       19532    19532
  Branches     1165     1165
=======================================
  Hits        12563    12563
  Misses       6513     6513
  Partials      456      456

Impacted Files
Coverage Δ

.../transferprocess/InMemoryTransferProcessStore.java
83.33% <ø> (ø)

...os/transferprocess/CosmosTransferProcessStore.java
0.00% <ø> (ø)

...transferprocess/store/SqlTransferProcessStore.java
0.00% <0.00%> (ø)

...r/transfer/process/TransferProcessManagerImpl.java
88.03% <80.00%> (ø)

...ferprocess/TransferProcessProtocolServiceImpl.java
98.68% <100.00%> (ø)

...ce/transferprocess/TransferProcessServiceImpl.java
85.45% <100.00%> (ø)

.../handlers/SingleTransferProcessCommandHandler.java
100.00% <100.00%> (ø)

...amic/HttpDynamicEndpointDataReferenceReceiver.java
95.91% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Weird error: Trying to index variable that is not an array

 (The error)

 (The project)
weirdError.zip (The project in a Zip file because github refuses to accept it directly)
When the sprite sheet is generated, the error happens 50 times after starting and once at the end (frame 100)
Version: 1.14.6 Steam (Beta branch)
OS: Windows 10

Oops, the issue appeared to be between chair and keyboard


bsim_bt: mesh: persistence storage testing

Adds support for testing of persistence storage
for mesh Babblesim tests. Adds a sample test
for testing provisioning data.
Signed-off-by: Omkar Kulkarni<EMAIL_ADDRESS>

Why does it require a separate folder? It causes a lot of copy-paste of what already have


README Instruction Improvements

correct spelling errors
correct grammar errors

read me has been updated and all spelling errors and grammar corrections made


updates modified time fix #27

This is to fix #27. I'm caching the modified time, and only changing it at most once per minute by updating the file mtime.

Seems reasonable. 👍

LGTM 👍  Thanks everyone ❤


Running the app again does not raise the window from the tray icon

I confirm (by marking "x" in the [ ] below: [x]):

[x] This is not a troubleshooting question. Troubleshooting questions go here: http://www.mattermost.org/troubleshoot/.
[x] This doesn't reproduce on web browsers (such as in Chrome). If it does, issue reports go to the Mattermost Server repository.
[x] I have read contributing guidelines.

Summary

Running the app again does not raise the window from the tray icon
Environment

Operating System: Arch Linux, KDE
Mattermost Desktop App version: 5.0.0
Mattermost Server version: 5.39.0

Steps to reproduce

Run the app either from shell or the app menu mattermost-desktop
Open settings and check both options:

"Show icon in the notification area"
"Leave app running in notification area when application window is closed".

Close the app window. Window is being minimized to tray.
Run the app again either from shell or the app menu mattermost-desktop

Expected behavior
Nothing is happening. The app window still be minimized to tray.
Observed behavior
Raise the app window as it was for mattermost-desktop prior to 5.0.0 release.

Possible fixes

P.S.: personally I'm using this to raise the app window by global hotkey. If there is another useful method to raise the window from tray with a hotkey, I will be okay with that.

@devinbinnie Are we able to repro this / is there a ticket for this already?

This is another issue that's a part of this ticket: https://mattermost.atlassian.net/browse/MM-30713
@dkuzmenko-sunpower Are you able to have this work if you uncheck "Leave app running in notification area when application window is closed"? I don't think that setting is doing what it's supposed to.

I have the same issue on windows 10 since I updated the desktop app to version 5

Yes, I can reproduce that. Created a ticket: https://mattermost.atlassian.net/browse/MM-39843

@devinbinnie the same behavior whenever the "Leave app running in notification area when application window is closed" checkbox checked or not. The application binary execution is not raising the running application window.


Upgrade version 1.0 to 2.0, the bearer authentication doesn't work. Why?

Hello everyone,
Using Swashbuckle.AspNetCore v1.0.0, I configured as below:
 services.AddSwaggerGen(c =>
{
 c.SwaggerDoc("v1", new Info { Title = ".NET API", Version = "v1" });
 c.AddSecurityDefinition("Bearer", new ApiKeyScheme
  {
  Description = "Example: \"Authorization: Bearer {token}\"",
 Name = "Authorization",
In = "header",
 Type = "apiKey"
   });
});
It worked fine.
After that, I upgrade the latest version Swashbuckle.AspNetCore v2.3.0, no change the code and try to run swagger, but it doesn't work, I check the request header, missing the bearer authentication header.
See the picture:

Please tell me why? How to fix it?
Thanks in advance.

Add this after your code:
c.AddSecurityRequirement(new Dictionary<string, IEnumerable<string>>
{
     { "oauth2", new string[] { } },
});

Above guidance is correct. Also, this is a dup of #603