Feature/performance tweaks

Investigating the performance of the TubeGeometry leads me to believe that

the # of tube segments is a large contributor to the overall mesh size
we're creating more tube segments than necessary.

The screenshot it shows that the tube is divided evenly along its length while we need more division towards the corners and less far away form the corners.
This has to do with how a curve is divided. In turn this is based on where the FrenetFrames are defined along the path of the curve.
The maximum bend radius of a corner should be equal to the line width, as set in the slicer. This means that no extra segments are needed at a distance of line-width/2 from the corners.

I played with your branch yesterday and I am preparing a deep dive!
First thing I did was to replace the CatmullRomCurve3 by a CurvePath. There was no significant changes in the performance of the rendering of a benchy. It also made the end result look worse in sharp corners and top layers. I don't have a strong opinion right now into keeping it or not.
What's the most intensive in terms of processing is, as you pointed out, the number of segments.
When we build the TubeGeometry, one of the constructor's argument is the number of segments. That number is currently calculated by the length of the curve we're passing it. Longer extrusion line = more segments. The thing is, those segments are all equidistant. That's the implementation of the TubeGeometry and we don't have control on that. I've tried to split the extrusions curves to generate fewer segments to long straight lines, but the fact that it ends up adding more objects to the scene resulted in even worse performance. The key would be to reduce the number of segments overall, without changing the number of objects added to the scene while still keeping enough segments in the corners.
I looked into the implementation of TubeGeomery. I think we can create our own geometry that looks a lot like the tube geometry but instead of having equidistant segments, it would be smart about where to place them. I think it's also a good long term solution because a custom geometry will allow changing the shape of the tube to set line height and line width at the same time for an accurate representation of an extrusion.
This is where your branch comes into play and is super useful! The wireframe view really helps in understanding the effect of any changes on the number of segments.
I'm very optimistic about where this is going.

My idea was to have a custom TubeGeometry that also combines a custom Curve (if I remember correctly). It might as well be called ExtrusionGeometry because if it's solely for that purpose we can ditch all the generic stuff and the geometry/curve separation and most of the math. This would also be a speedup because we can basically hardcode some unitvectors for the frames iso using trig to compute them.
Awesome you're diving into this. It was a bit daunting so didn't start on this myself yet. My request would be to document your insights so it can be built on later, by anyone. Maybe the hard part now is deciding where to start, code-wise.

I agree with everything you just said. Approaches, naming, benefits.
I also found that we could benefit from https://threejs.org/docs/index.html#api/en/objects/BatchedMesh, but the three.js version we're using does not have it. Since we're using a limited number of colors, I'm sure we'll get a significant boost. We would have to do a slight refactor to generate the material outside of the addTubeLine.
I'm starting with the custom volume for now.

This was mostly to discuss and work towards a new geometry, which is now merged. So closing this and the batchedMesh can be a new PR


Spec Steps

What if we change spec to be steps that are configurable. Possible steps are Filter, Select, and Verify. Each step can occur more than once. The output of one is the input to the next essentially.
Benefits:

Allow multiple filters steps for narrowing search space based on data that passed previous step.
Selection of properties (and nested tags) so that we can be more agnostic to the data coming into the verification step.
I think would allow potential to reduce number of necessary specs.
Much more flexibility obviously.

Cons:

Type/data rework which would require migration and potential data loss if not handled.

I think this might make #35 unnecessary.

Instead of steps, just adding group number to criterion. This would let us separate filters into groups. Each group gets processed together to then pass along to the next to get the "steps" we were looking for. From the UI, we can just have a list per group in the filter section. Selection step would be lot of rework, and we would only need it for nested tags. We need to just figure out another approach for deeply selecting tag members. We also would only ever have one verification step. So, all things considered, we don't need steps but rather filter groups.


Look into Node.js compatibility guidelines

Originally suggested by @benrudolph in #1
http://en.wikipedia.org/wiki/CommonJS

nice!


fix: pin tRPC version to 9.27.* to correspond with trpc-sveltekit

Pertains to #23. Currently, the RPC client and server in templates/trpc/package.json and templates/prisma_trpc/package.json have no specified versions, causing initial package.json creation to fail when installed in conjuction with trpc-sveltekit. This PR simply pins the versions to ^9.27.2 in both these files.
There is currently a PR open in trpc-sveltekit to update it to be compatible with tRPC 10, but this fixes this issue for now.

Thank you!


Type sharing testPrototypes/ChangePrototype is flaky on r1.8

CCRobot caught this on release1.8 branch;
[1192/2354 0.20] Failed -> Prototypes/ChangePrototype.js
out/Debug/ch -WERExceptionSupport -ExtendedErrorStackForTestHost -BaselineMode -maxInterpretCount:1 -maxSimpleJitRunCount:1 -bgjit- -dynamicprofilecache:profile.dpl.1466 -RecyclerVerifyMark -RecyclerConcurrentStress -VerifyBarrierBit -KeepRecyclerTrackData -trace:TypeShareForChangePrototype -JsBuiltIn- test/Prototypes/ChangePrototype.js
Output: (at line 28)
----------------------------
TypeSharing: Updating prototype object s DictionarySlot cache in __proto__.
----------------------------
Expected Output:
----------------------------
TypeSharing: Reusing prototype object s DictionarySlot cache in __proto__.
----------------------------
exit code: 0

Looks like Kunal had prepared the test and the bug fix associated with it almost a year ago. I'm going to assign myself for now and take a look.

This test fails all the time if -RecyclerStress is set. I tested this version in order to confirm an hypothesis. The reason this test fails from time to time is that the BG GC sometimes kick faster (or somehow gets faster time share from scheduler) IMO the correct approach is to skip this test if -RecyclerConcurrentStress is set.


Run serially integration tests with volumes

What type of PR is this:
/kind tests

Tests still failing when running serially :(
https://s3.eu-de.cloud-object-storage.appdomain.cloud/odo-tests-openshift-logs/pr-6246-openshift-tests-3074.html


[NFR] PHPUnit support

Can you please add support for the following PHPUnit annotations?

@author
@after
@afterClass
@backupGlobals
@backupStaticAttributes
@before
@beforeClass
@codeCoverageIgnore
@covers
@coversDefaultClass
@coversNothing
@dataProvider
@depends
@expectedException
@expectedExceptionCode
@expectedExceptionMessage
@expectedExceptionMessageRegExp
@group
@large
@medium
@preserveGlobalState
@requires
@runTestsInSeparateProcesses
@runInSeparateProcess
@small
@test
@testdox
@ticket
@uses

Docblockr is a tool to recognize your code and smartly create Doc Comments. I think it's only necessary to recognize a @test doc and @depends. If you're seeking to highlights, you need to change the PHP setup of atom or add your own stylesheet,as docblockr has no styles.
Thanks!!

+1

Closing with the same reasons as #140.


🐞[bug]: Misalignment in Navbar

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
The Logo of the website is not aligning well with other navbar links
Expected behavior
It should be aligned
Add ScreenShots

What browsers are you seeing the problem on?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24EXTD contributor
[X] I have starred the repository

@Bhum-ika it going to be updated it is already assigned.


[incubator/buzzfeed-sso] upgrade deprecated Kubernetes APIs

What this PR does / why we need it:
Removes usage of API versions removed in Kubernetes 1.16: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/.
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

@darioblanco @komljen

/assign @komljen

@komljen Can you look into this?

/ok-to-test

This is a breaking change, it will not work for users with older k8s versions. Here is the simple solution:
{{- if .Capabilities.APIVersions.Has "apps/v1" }}
apiVersion: apps/v1
{{- else }}
apiVersion: apps/v1beta1
{{- end }}

Same for networking. Please update the chart.

Done.

/lgtm


Remove unused imports

There are some more warnings but I'm struggling to understand where or how to fix them. There's quite a bit of whitespace removal here too! (My editor does this automatically).

Hey, I realize this is an annoyance for 1.3. However, https://github.com/CargoSense/ex_aws/pull/165 handles this I think in the best way, which is to remove the metaprogramming approach entirely. I hope to release this as a beta here in the next couple days, and will continue pushing further updates there.


Console log level not being respected.

It seems when I create a logger, then add a console type transport the level on that transport is ignored and is looking at the logging level specified on the logging instance itself to determine the log.
var winston = require('winston');
var logger = new winston.Logger({
level: 'trace',
colorize: 'all'
});

logger.add(winston.transports.Console, {
name: 'console',
level: 'debug'
});

logger.trace("I shouldn't be appearing"); // but it does.

Output of console.dir(logger):
EventEmitter {
  domain: null,
  _events: {},
  _eventsCount: 0,
  _maxListeners: undefined,
  transports:
   { console:
      EventEmitter {
        domain: null,
        _events: [Object],
        _eventsCount: 1,
        _maxListeners: undefined,
        silent: false,
        raw: false,
        name: 'console',
        formatter: undefined,
        level: 'debug',
        handleExceptions: false,
        exceptionsLevel: 'error',
        humanReadableUnhandledException: false,
        json: false,
        colorize: 'all',
        prettyPrint: false,
        timestamp: [Function],
        showLevel: true,
        label: null,
        logstash: false,
        depth: null,
        align: false,
        stderrLevels: [Object],
        eol: '\n',
        _onError: [Function: bound ] } },
  _names: [ 'console' ],
  padLevels: false,
  levels:
   { emergency: 0,
     alert: 1,
     critical: 2,
     error: 3,
     warning: 4,
     notice: 5,
     info: 6,
     debug: 7,
     trace: 8 },
  emergency: [Function],
  alert: [Function],
  critical: [Function],
  error: [Function],
  warning: [Function],
  notice: [Function],
  info: [Function],
  debug: [Function],
  trace: [Function],
  level: 'trace',
  emitErrs: false,
  stripColors: false,
  exitOnError: true,
  exceptionHandlers: {},
  profilers: {},
  rewriters: [],
  filters: [] }

Notice the level: 'trace' on the main logger but the transport has level: 'debug'.

+1

+1

I had a similar issue where my error level logs are being logged to my info level logs.

@its2mc I think your issue is slightly different - error is a lower log level than info, so info picks up error logs (and all other levels below info) - see #614.
trace should not be picked up by debug as it is a higher level.


Access Denied

I have ACD set up and I can view my files in a mounted drive, however when I try to transfer a file I get a Destination Folder Access Denied message. This happens even with files as small as 1 KB. Windows asks me to provide administrator permission, but it makes no difference; I can't transfer any files. Everything seems to be set up for read only even though I did not check the read only box in options. I have my cache set to %TEMP%\ACDDokanNetCache, small files size set to 20 Mb and small files cache set to 1000 Mb. Any idea what the problem could be?

I noticed a closed issue that says the cache folder permissions may cause this issue. Unfortunately, if I try to change the cache folder, the program crashes. If I click on Export Log the program also crashes.
I tried changing the permissions on the %TEMP%\ACDDokanNetCache folder, but I still get  access denied messages.
FYI, I'm running Windows 10 Pro and the latest version of ACD Dokan.Net

If you are transferring files to ACD I would recommend using Copy and Upload here from Explorer context menu instead of Paste.

I completely uninstalled ACD Dokan.Net, including the configuration files. After reinstalling, I can now change the cache directory without the program crashing.
I still cannot transfer files to my ACD folders. Copy/Paste results in folder access messages. Copy/Upload gives me a message saying Cached Upload File Is Not Found

Here is my log in case it helps you to determine what might be happening.
ACDDokanNetLog.zip

Can you try 1.6.4?

I've tried 1.6.4 as well as various other programs for accessing my ACD files. Unfortunately nothing seems to work, so the problem must be on my end. Thanks for your help.


docs: fix store methods link

Problem
All links to Store methods seem to be outdated.
Solution

before
after

#dispatch
#dispatchaction

#subscribe
#subscribelistener

#replaceReducer
#replacereducernextreducer

Thanks!


feat: transitive dependencies

Implements https://github.com/fansenze/snowpack-plugin-stylus/issues/8
The approach is similar to the one found in the sass plugin, but way simpler, as we don't need to rely on regex to parse the imports. Stylus offers a convenient way to get all dependencies of a file. This also includes transitive dependencies.
These dependencies are added to a map whenever a file is loaded. Whenever one of these files is changed, we mark all files importing it as changed, thus triggering a live reload.

it's cool


Fix: code quality issues

Description
Hi 👋 I ran the DeepSource static analyzer on the forked copy of this repo and found some interesting code quality issues. This PR fixes a few of them.
Summary of changes :

Removed unused imports
fixed the not in statement
Removed reimported modules
added .deepsource.toml file

@NandaScott kindly review the PR.

Thank you for submitting this PR. I will look more into this, and overall the removal of imports is good.

Thank you for submitting this PR. I will look more into this, and overall the removal of imports is good.

@NandaScott Thanks for response.

Hi, my apologies for this late reply. I don't always have the time to sit down with this project.
I appreciate the code quality updates, but I don't think this project really needs the DeepSource integration.


Investigate emitting :on_sp event for ripper lex

IRB needs this for calculating leading whitespace so it knows how to indent multi statements.
If this can be done on the Ruby side, we should do it there, so keep the simplicity of the C parser.

Closing this for now. It's documented, and as long as all of our consumers can work around it, we're going to avoid implementing it. I really hope no one ends up needing it. If they do we'll revisit.

My only worry is that the original source couldn’t be constructed using the lex information and position information if we are dropping tokens.
I don’t know the theory behind different lex output, but I somewhat assumed that I could convert between source code and lex output and back with no loss.
Syntax suggest doesn’t rely on that property, but it’s something I’ve considered using before.

The only tokens we drop are on_sp. We don't emit them because it's a lot of tokens and I didn't think anyone actually relied on them because they don't have any semantic meaning.
If you want to reconstruct the source, you still can. The only thing that's missing is spaces, so if you put all of the tokens back in their exact positions and slice out all of the spaces from the source, you could definitely do that.
I just figured that's not something anyone actually needs to do. But if they do we can do it in Ruby instead of slowing down the overall parser.


Error while fetching calendar: Response error: 404

receiving 404 error using example config

I can't reproduce this. Which example config did you try? Did you change anything (like the entity)?

same problem here.

@BirdCamp Are your calendar entities actually named my_calendar_1 and my_calendar_2 or did you just copy/paste the example and not alter it?


Support updating existing records in postgres

When running a simple app, moving data from mongo to postgres, if there's a unique constraint, and records exist already, it ends up failing.
Update the postgres adapter to support the "ON CONFLICT DO UPDATE" syntax seems the best way to prevent this.
Have a basic implementation that needs refining (I'm not v proficient in Go!)

The basic implementation:

Needs tests
Needs to act on primary keys not called id
Should probably be optional


Add a beta channel formula to homebrew and update homebrew release tooling

For homebrew, there will be a new dart-beta package, this will work like this:
brew install dart # works as before
brew install dart-beta # fails, conflicts with dart
brew unlink dart # dart still installed, but no longer in the path
brew install dart-beta # works, dart-beta is now in the path

The dev version is installed with brew install dart --devel as before. The dart-beta package won't have an unstable version.

The new script doesn't update the version. This needs to be fixed as well.

Is the dev channel still installed using brew install dart -- --devel?

Yes, the dev channel should not be affected by this change.
On Fri, Apr 3, 2020, 19:03 John Ryan<EMAIL_ADDRESS>wrote:

Is the dev channel still installed using brew install dart -- --devel?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/40990#issuecomment-608553947,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEYRJB7VFYZRKM6QCKE2HNLRKYJHTANCNFSM4LFWK34A
.

Yes, the dev channel should not be affected by this change.

I'm curious why we have separate formulas for dart and dart-beta? Could we have added a beta version to the dart formula, so it supported stable, beta, and dev?
golang does something lime that - they support stable, 'bottle', and head versions:
https://github.com/Homebrew/homebrew-core/blob/master/Formula/go.rb

My impression is that bottles are some sort of pre-builts for built-from-source packages rather than channel specific distributions.
But, if they can be used I still think the UX is better with a separate formula: The stable and dev channels map quite nicely on a single formula because there's brew install --devel to select the dev channel. Using bottles for beta would probably mean something like brew install --force-bottle=beta dart.  brew install dart-beta is shorter and doesn't require any knowledge about bottles.


Dev tools opened in firefox fix the flickering/vibration issue of the table header

Firefox issue, from the samples you have created, with HTML Table, there is a flickering/vibration issue when you scroll up and down, and its quite obvious to the user.
Just want to check how is that possible from your sample, with HTML Table, the issue is no longer there when the dev tools is opened. Not sure if its the console.log thing, or some scripts will only be triggered when dev tools is opened and I haven't got chance to go through the source code.
I am testing from the samples/demo, with HTML Table.
Firefox version 70.0.1

I also experienced this and what I did to solve it was to create the header outside of the "table" HTML element. That solved the problem, I hope it helps you!

Unfortunately the HTML Table with header code isn't perfect. It's a known issue. If you're able to come up with a fix, please submit a PR.


Added dynamic width to display calendars

Added a simple function to get the number of colums of the current terminal and calculate the width that the calendars can be displayed.
I don't know much of python so I'm no able to perform any test to see if this change can bring any issue.
But it works for me in Arch Linux 4.2.5-1 with both st 0.6 and xterm(320).

Unfortunately, this would only work on Linux/BSD and you haven't built in any OS detection.  Python 3 now has a way to do it (shutils) but I haven't found anything similar in Python 2.x that works consistently across OSs.


Default import doesn't work with "proxy" file

I'm having an issue importing the default export from a project that uses a "proxy" file to handle the exports. I've created a repo for it, as that was the easiest way to reproduce the whole problem. That repo is at https://github.com/MikeTheReader/rollup-playground and includes a somewhat deeper explanation of what I'm seeing. Basically, it comes down to trying to include a package that uses a file like module.exports = require("exportedDefault.js"); doesn't import correctly. I'm able to fix this by changing the file to export the object by hand. Something like:
const index = require('./index');

module.exports = {
  default: index.default,
  NAMED: index.NAMED,
  __esModule: true
}

but the fact that rollup creates the unwrapExports function call, but does nothing with the response from that call leads me to believe there may be a bug that this is tripping.
Thanks for creating a great tool. Please let me know if there's any other information I can provide.

Hey folks (this is a canned reply, but we mean it!). Thanks to everyone who participated in this issue. We're getting ready to move this plugin to a new home at https://github.com/rollup/plugins, and we have to do some spring cleaning of the issues to make that happen. We're going to close this one, but it doesn't mean that it's not still valid. We've got some time yet before the move while we resolve pending Pull Requests, so if this issue is still relevant, please @ me and I'll make sure it gets transferred to the new repo. :beer:


EventListener mouseup or mousedown doesn't work since 5.2.0

Since update from 5.0.3 to 5.2.0 (also 5.3.0) the addEventListener method for mouseup or mousedown on ViewPort doesn't work.
Here is the question at Stack Overflow and the exact problem description with an example.
https://stackoverflow.com/questions/52535545/eventlistener-mouseup-or-mousedown-doesnt-work-since-5-2-0

You can think mouseup and mousedown on viewport are fixed correctly. You should add the event on map if you want the similiar functionalities.

There unfortunately no mouseup or mousedown-Events on Map-Object possible.
map.on('mouseup', function(evt){ alert('MouseUp');}, false);
This example does not work either.

See also #8219

But that is exactly the problem. The solution shown in #8219 doesn't work since v5.2.0.
map.getTargetElement().addEventListener('mousedown', function(e) { alert('abc') });
Diesn't work anymore! In the v5.0.0 ist works fine without any problems.

c74b9c1d55fc91216aa73895c1e247f82b96e851 is the first bad commit

Sorry, but what does that mean for me? Is it a bug and will it be fixed in the upcoming versions or is it a feature and I have to write the event differently?


Fix crash while uploading

This potentially fixes #6053
I notice that writing chunks to file was copying byte buffers for each of the chunks it was creating during an upload, rather than re-using the buffer that it had.  Although Ive not encountered a crash (Pixel 5 / Pixel 9 Pro XL) this is a likely root cause.
Can someone who's seen the problem also test?
Tested on: Pixel 5, Pixel 9 Pro XL

I am traveling without a computer this week, but will test next week. Thanks! 🙂


Installation Issue

sayantan@kali:~$ sudo pip3 install kekas
Collecting kekas
Using cached https://files.pythonhosted.org/packages/2d/04/4487855bbc12532d54729b1bf07531c8b69202981fa69561a983e234220d/kekas-0.1.12.tar.gz
Complete output from command python setup.py egg_info:
Traceback (most recent call last):
File "", line 1, in
File "/tmp/pip-install-6wp28_se/kekas/setup.py", line 3, in
import kekas
File "/tmp/pip-install-6wp28_se/kekas/kekas/init.py", line 1, in
from .keker import Keker
File "/tmp/pip-install-6wp28_se/kekas/kekas/keker.py", line 12, in
from .callbacks import Callback, Callbacks, ProgressBarCallback,
File "/tmp/pip-install-6wp28_se/kekas/kekas/callbacks.py", line 14, in
from tensorboardX import SummaryWriter
File "/usr/local/lib/python3.6/dist-packages/tensorboardX/init.py", line 5, in
from .torchvis import TorchVis
File "/usr/local/lib/python3.6/dist-packages/tensorboardX/torchvis.py", line 11, in
from .writer import SummaryWriter
File "/usr/local/lib/python3.6/dist-packages/tensorboardX/writer.py", line 27, in
from .event_file_writer import EventFileWriter
File "/usr/local/lib/python3.6/dist-packages/tensorboardX/event_file_writer.py", line 28, in
from .proto import event_pb2
File "/usr/local/lib/python3.6/dist-packages/tensorboardX/proto/event_pb2.py", line 15, in
from tensorboardX.proto import summary_pb2 as tensorboardX_dot_proto_dot_summary__pb2
File "/usr/local/lib/python3.6/dist-packages/tensorboardX/proto/summary_pb2.py", line 15, in
from tensorboardX.proto import tensor_pb2 as tensorboardX_dot_proto_dot_tensor__pb2
File "/usr/local/lib/python3.6/dist-packages/tensorboardX/proto/tensor_pb2.py", line 15, in
from tensorboardX.proto import resource_handle_pb2 as tensorboardX_dot_proto_dot_resource__handle__pb2
File "/usr/local/lib/python3.6/dist-packages/tensorboardX/proto/resource_handle_pb2.py", line 22, in
serialized_pb=_b('\n(tensorboardX/proto/resource_handle.proto\x12\x0ctensorboardX"r\n\x13ResourceHandleProto\x12\x0e\n\x06\x64\x65vice\x18\x01 \x01(\t\x12\x11\n\tcontainer\x18\x02 \x01(\t\x12\x0c\n\x04name\x18\x03 \x01(\t\x12\x11\n\thash_code\x18\x04 \x01(\x04\x12\x17\n\x0fmaybe_type_name\x18\x05 \x01(\tB/\n\x18org.tensorflow.frameworkB\x0eResourceHandleP\x01\xf8\x01\x01\x62\x06proto3')
TypeError: new() got an unexpected keyword argument 'serialized_options'
----------------------------------------

Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-6wp28_se/kekas/
sayantan@kali:~$

Can't replicate this bug.
You can try sudo pip3 install --user kekas , it usually helps in such situations

Thanks, done!


using etcdcpp in project with exception disabled

We have a project that strictly disable exception handling flag. Using try catch will result in compile error.
From a glance, etcdcpp is heavily using exception, but I'll try my luck here by asking if there's any build flag that will generate library without exception?

I think it is possible. I would give it a try.


skywalking.org has been hacked

Looks like http://skywalking.org/ has been hacked.
For instance, it just redirected me to: http://www.memevibe.com/2017/05/01/top-10-handsome-men-usa/

Hi, skywalking.org has not been used by ours. Becausing of moving into apache, we only keep skywalking.io and skywalking.apache.org
Is there any place still pointing to skywalking.org ?

I see, thanks.
I'm only aware of the OpenTracing site.
Ref: opentracing/opentracing.io#265


Fix: Ruby interpreter crash

Resolves https://github.com/lazebny/ramda-ruby/issues/10

Coverage decreased (-0.003%) to 97.542% when pulling 68051a2be442040508b3d34812086be27bd70021 on 10-ruby-interpreter-crash into b94e31fac9e4fd357ba644b7b6ef2d3cdb2213a3 on master.


Default ES heap size is too high

@sharand reported in Gitter that his ES instance was being killed automatically (dockerelk_elasticsearch_1 exited with code 137).
I've seen that happening myself in Docker for Mac, which has only 2GB of RAM available by default. With the default set to ES_JAVA_OPTS: "-Xms1g -Xmx1g" we're already reserving half of the total memory for ES alone.
I've been experimenting myself with ES_JAVA_OPTS: "-Xms256m -Xmx256m" and never had any issue so far. While these values are definitely too low for production, I would suggest we make it the default in the repo and add instructions in the README for people who would want to increase it.
See also: https://www.elastic.co/guide/en/elasticsearch/guide/master/heap-sizing.html
@deviantony thoughts?

@antoineco +1, this repo is aimed to help people who are starting to learn/play with ELK and not to be a production ready solution. Lowering the default ES heap size and adding instructions to increase it is a good solution.


Build flow plugin dependency

The Build Flow plugin is both deprecated and has a known arbitrary code execution vulnerability.  GHPRB depends on Build Flow so it's not possible to remove the Build Flow plugin.
Consideration should be made as to whether the dependency can be removed.

This should be able to be made an optional dependency.

I'm also very happy if this plugin dependency could be made optional. As I want to remove the Build Flow plugin as well.

Crickets?  Oh well, I guess it doesn't really matter if Jenkins is secure, right?  Or better yet, maybe we can just stop using external services like GitHub.

Really you want to look at #560.

It now is a optional dependency, therefore closing this for now.

@bjoernhaeuser
A bit confused as Jenkins is mandating that I must use either both plugins or neither... It does not seem like it is an optional dependency. What would you suggest in this case?

In the case where it's already installed you need to manually disable the optional plugin before you can uninstall it.  See this bug comment: https://issues.jenkins-ci.org/browse/JENKINS-33843?focusedCommentId=307253&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-307253

Thanks @alexwhitman


add gitpod config

[x] add gitpod config
[x] add gitpod badge to readme
[x] add gitpod to development docs
[ ] prepare gitea setup (add oauth client somehow and add the credentials to woodpecker env settings)

@6543 I added this Gitpod config. Gitpod is a pretty cool tool which I used a lot recently to quickly start a development of a project. Its basically a VS-Code in the cloud like Github Workspaces etc. I think it would help especially first-time contributors a lot.
The setup works already, but my idea was to automatically start a Woodpecker server & agent and a Gitea instance. To be able to automatically start Woodpecker we need the oauth credentials from Gitea. Do you know a nice way to create & get those credentials or should I simply do a super simple setup of Gitea and store that minimal setup as sqlite file to the repo?

That looks pretty cool. How did you pass the initial admin account creation and database setup screen by this?

Codecov Report

Merging #1020 (863714d) into master (6351684) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1020   +/-   ##
=======================================
  Coverage   50.51%   50.51%
=======================================
  Files          82       82
  Lines        6263     6263
=======================================
  Hits         3164     3164
  Misses       2916     2916
  Partials      183      183

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6351684...863714d. Read the comment docs.


Add test for profiling

Coverage increased (+0.6%) to 74.727% when pulling 90231504a959b3345fd70202559c672db7805def on feature/test-profiling into 68d41493504f823953a8975cd3115674e9af85fe on master.


How to choose the appropriate aggregate sharpness metric

Thinking about the construction of a summary sharpness metric, we should be thoughtful about how we are comparing the distributions of our chosen measures of sharpness between the predicted and observed image. For a sharpness metric like gradients, we want to reward images that have a similar distribution of gradients to the target image, but we don't care that the gradients are in exactly the same spot. Thus we should use metrics that compare the predicted and observed gradient distributions aggregated across each image or over a reasonably large region of an image.
The most distribution agnostic way to compare two images would be to calculate the empirical CDF of the gradients for both images and then take either the total difference between the two CDFs (similar to CRPS) or the max difference (similar to the K-S test). The max difference would be the most aggressive metric for sharpness.
Would anyone be interested in implementing this or should I take a stab at it?

This makes a lot of sense to me - as far aggregating over local regions, we could make use of the heatmap code to compute across tiles, although it may be that we want to be able to tune the tile sizes separately for each metric - this would be easy enough to implement, although it might slow the implementation down a little bit (right now, when computing all metrics, it only has to subset the tiles once then compute everything on each tile, where with varying tile sizes we'd need to recreate the tiles for each metric).
Also, I believe that the Histogram of Oriented Gradients (HOG) method that @jsschreck implemented in the gradients module has some of this idea, in that it computes a distribution of gradients for each image and compares those, so it'd be interesting to see that idea expanded to other metrics.


[WIP] Support for Chef-15

Chef-15 has come up with a common bootstrapping technique that supports all knife plugins. Using the same which would affect knife vsphere vm clone
Description
Few bootstrapping options have been changed. Details are mentioned in release notes

Applied and ensured chefstyle
Test cases fixed

Related Issue

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have run the pre-merge tests locally and they pass.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] All commits have been signed-off for the Developer Certificate of Origin.

Drop the support of ruby 2.4 and update s.required_ruby_version = ">= 2.5" at https://github.com/MsysTechnologiesllc/knife-vsphere/blob/3e09f2518e0b17ff4b76db6deae578d51eaa18ed/knife-vsphere.gemspec#L14


Fix VMS ftp LIST parsing - allocated part is optional.

Signed-off-by: rogrigor<EMAIL_ADDRESS>

This PR fixes a failure to parse server output on LIST command when size / allocated part is missing slash and allocated value. I am not sure if there is any specification on that subject to make clear if this is a valid server output or not, however MultiNet FTP Server Process V5.1(16) does this reply, for example:
FILE123.DAT;1
64   4-MAR-2019 00:04 [USR,USRGROUP] (RWED,RWED,RWED,R)
FILE456.DAT;1
102  28-APR-2013 23:12 [USR,USRGROUP] (RWED,RWED,RWED,R)

If I try to connect to that server with FileZilla client the LIST response is parsed without problems.

looks ok to me

Thank you @sebbASF ! Is there anything I can help with moving this change towards release?


test_formulae: delay requiring utils/github/artifacts

Fixes
Error: cannot load such file -- utils/github/artifacts

https://github.com/MikeMcQuaid/strap/actions/runs/5153221949/jobs/9282422805?pr=782#step:3:8

Have we ever supported test-bot on old versions of Homebrew? We very routinely add new flags etc in Homebrew and use them here immediately (#920, #887, etc.).

🤷 Maybe not, but it's a tiny change so I don't mind carrying it for a bit.

It gets a bit complicated because GitHub runner images roll out over a period of time (and potentially even separate times across macos-11, 12 & 13). e.g. 14% of repositories use macos-13 20230524.1, while others use 20230509.4.

Thanks @carlocab!


[FEATURE] - Custom Taskbar Notifications based on Wireguard connection status

The consistent notification in the taskbar is already present. It would be great if we could use this to display a custom message based on the WireGuard connection status. I was also able to set a custom toast notification that made a small pop-up appear and disappear based on the status.
With my old setup (Original WireGuard + Tasker), I created custom notifications based on whether WireGuard was connected to my home network or not. It looked like this:
Note: This message is specific to how I set mine up, but for this request, it should be customizable to whatever the user would like it to say based on the status.
Note 2: This should also give the user the ability to replace the default message on the taskbar currently "Auto-Tunnel Service" "Monitoring network state changes: active".

TaskBar Messages based on WireGuard Connection Status:
Connected to VPN Message |  "Off Home Network" - customizable
Disconnected to VPN Message |  "On Home Network" - customizable

Pop Up Toast Message (2 - 3 sec pop up) based on change in WireGuard Connection Status:
"wg-home VPN Connected" - customizable
"Disconnected from wg-home VPN" - customizable

Screenshots of what this looked like with my old setup

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."

Download https:// In the installer menu, select "gcc."

All Please do not download the link above it is likely malware after reading about this user on another github thread.
See below for more details and Zane can you flag or remove Jonty650413's post above so that somone doesnt accidently download the file from his link.
https://github.com/Anjok07/ultimatevocalremovergui/issues/1533

Thanks for the detailed explanation. I'll look into adding this feature.


Add a note about /etc/apt/keyrings to pkgs.k8s.io migration guide

This PR updates the pkgs.k8s.io announcement blog post to include a note about creating /etc/apt/keyrings directory on older versions of some distros upon migrating to the new package repositories. This has been an issue for many users, e.g. see https://github.com/kubernetes/release/issues/3491
The note has been copied from Installing Kubeadm page.
cc @kubernetes/release-engineering

/lgtm
Thanks!

Oh, also forgot to add the lgtm.
/lgtm


[Bug] Wrong discussion used as comment when search return multiple discussion results

Step to reproduce:

I have some post with similar path and file name:

https://jiekun.dev/posts/kubecon-2023/
https://jiekun.dev/posts/kubecon-2023-otel-sampling/

giscus search with post/kubecon-2023/ in discussion: link.
Github response multiple discussion.
giscus choose the wrong one. It mighe because giscus did not exact match the title, but matched the prefix (I did not read the codes, it's my guess)
Wrong discussion is displayed as comment in blog post page.

Expected result:
Page https://jiekun.dev/posts/kubecon-2023/ use https://github.com/jiekun-dev/blog-comment/discussions/12 as comment;
Page https://jiekun.dev/posts/kubecon-2023-otel-sampling/ use https://github.com/jiekun-dev/blog-comment/discussions/13 as comment.

It's expected, use the strict matching option if you have such titles.

It's expected, use the strict matching option if you have such titles.

Thank you, sir. I'm changing the config now. Thanks for your kindly response :0 very appreciated.

Confirm and solved.


add methods to create and list pr status.

Add methods to create and list a pull request's statuses.
List the statuses (see vsts code pr statuses list -h for the options):
vsts code pr statuses list --repository [repository] --id [ID]

Create a status (see vsts code pr statuses create -h for the options for the options):
vsts code pr statuses create --repository [repository] --id [ID] --state [state] --name [name]

Related to issue #78

@vbossica Closing the older PRs on VSTS-CLI code. Feel free to get the corresponding workitems assigned to yourself when you work on it with the new codebase.


Handle 'keyof' for generic tuple types

This PR implements support for keyof T with generic tuple types that was missing in #39094.

@DanielRosenwasser Would be good if we can get this into the 4.0 beta.

@weswigham Should be good to go now.

Does this fix/relate to #27995?

@treybrisbane No.


Device orientation

Hi @skx926 ,
When the device orientation changes the GuideController is not updating properly.

when the demo run in iOS8.0,there are a bug when the first guide show,i think it is because hollowFrame is wrong.

That's because the convert frame method in iOS 8.0 not working properly, I'll fix this later this week.

These 2 bugs has been fixed in version 0.0.3.


browser-shim.js prevents nice console logs

If I run tests in the browser, all console logs in the browser are somehow redirected to browser-shim.js, which forces the output to a simple string instead of a nicely formatted log (e.g. objects that can be inspected).

This applies to the whole app, not only logs from the tests. This is caused by browser-shim.js overriding console.log. In the code, I can see that mocha seems to need console.format. But why are log and error overridden, too? Is there a way to workaround this behavior?

Please provide a way for me to reproduce this - this is the first time I see a problem like this ...
If possible, please publish a github repo where I can reproduce this.


cant find send_file() method

i am using Jsocket for transfering files but i cant find send_file() method is it removed or its replaced ??

First off, thank you for using my library. File transferring is a feature that was removed from Jsocket. The reason is, since Jsocket is a library that simply wraps around a java.net.Socket object, it does not implement a protocol. To incorporate file transferring would require implementing a protocol. If the library were to implement a protocol, it may interfere with a protocol implemented by the user. Another reason for removing it was the fact that it was still quite buggy. I wanted to proceed with a library that had a minimal amount of bugs. I will not rule out including this as a feature in the future, or I might make a separate library for transferring files. Apologies if this is an inconvenience.
My I ask which version of Jsocket you are using? It seems you might be using a slightly older version, especially if you are looking for the file transfer feature. I am currently working on vNext 0.5.0. I've just released the first and second beta. It is a complete rewrite of the library, so swapping out an older version with this version may break things since it is not backwards compatible. However, connecting via TCP to an older version should work just fine. I'm working on updating documentation for it, but feel free to check it out.

Thank you for your response
i am using 0.3.1 I think
i am using the last one on github
i am hoping u create one for FTP
thank you

From: Will Czifro<EMAIL_ADDRESS>Sent: Monday, April 18, 2016 4:04 AM
To: czifro-tech/jsocket
Cc: Kareem El-sayed Aly Mohamed Arida; Author
Subject: Re: [czifro-tech/jsocket] cant find send_file() method (#12)
First off, thank you for using my library. File transferring is a feature that was removed from Jsocket. The reason is, since Jsocket is a library that simply wraps around a java.net.Socket object, it does not implement a protocol. To incorporate file transferring would require implementing a protocol. If the library were to implement a protocol, it may interfere with a protocol implemented by the user. Another reason for removing it was the fact that it was still quite buggy. I wanted to proceed with a library that had a minimal amount of bugs. I will not rule out including this as a feature in the future, or I might make a separate library for transferring files. Apologies if this is an inconvenience.
My I ask which version of Jsocket you are using? It seems you might be using a slightly older version, especially if you are looking for the file transfer feature. I am currently working on vNext 0.5.0. I've just released the first and second beta. It is a complete rewrite of the library, so swapping out an older version with this version may break things since it is not backwards compatible. However, connecting via TCP to an older version should work just fine. I'm working on updating documentation for it, but feel free to check it out.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHubhttps://github.com/czifro-tech/jsocket/issues/12#issuecomment-211153471

The latest one on github is v0.4.2. In the wikis I mention that I removed FTP from the library due to its inconsistency in reliability. If this is a feature that you immediately need, it is in v0.4.1, which was considered unstable because of the FTP feature.
FTP was a feature that I regrettably had to pull out. I have created a separate repo for FTP: instant-transmission . I will probably start working on it once I finish v0.5.0 of this library, since I'll probably use this library as a dependency. I would watch that repo to get updates on the progress of that library.
Thanks for supporting this library and my work.


Add plugin discovery options to use cache explicitly

What this PR does / why we need it

Added PluginDiscoveryOptions to customise the discovery mechanism. Currently added ForceCache setting to explitly use the cache image and not check or fetch the inventory
By Default ForceCache is false and doesn't have any impact on tanzu cli commands.
This Setting will be used to check and install or update essential plugin group.

Which issue(s) this PR fixes

Fixes #
Describe testing done for PR
Unit tests, E2E tests
Tanzu CLI continue to work as expected

mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> tanzu version
version: v1.0.0-dev
buildDate: 2023-07-12
sha: a86ef3a7
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> tanzu plugin group search
  GROUP               DESCRIPTION      LATEST
  vmware-tkg/default  Plugins for TKG  v2.2.0
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> rm -rf ~/.cache/tanzu/plugin_inventory/
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> tanzu plugin list
Standalone Plugins
  NAME   DESCRIPTION   TARGET  VERSION  STATUS
  hello  hello 0.0.10  global  v0.0.10  installed
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> tanzu plugin clean
[ok] successfully cleaned up all plugins
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> clear
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> tanzu
Usage:
  tanzu [command]

Available command groups:

  System
    completion              Output shell completion code
    config                  Configuration for the CLI
    context                 Configure and manage contexts for the Tanzu CLI
    init                    Initialize the CLI
    plugin                  Manage CLI plugins
    version                 Version information

  Target
    kubernetes              Tanzu CLI plugins that target a Kubernetes cluster
    mission-control         Tanzu CLI plugins that target a Tanzu Mission Control endpoint

Flags:
  -h, --help   help for tanzu

Use "tanzu [command] --help" for more information about a command.
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> tanzu plugin list
Standalone Plugins
  NAME  DESCRIPTION  TARGET  VERSION  STATUS
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> tanzu plugin group search
[i] Reading plugin inventory for "projects.registry.vmware.com/tanzu_cli/plugins/plugin-inventory:latest", this will take a few seconds.
  GROUP               DESCRIPTION      LATEST
  vmware-tkg/default  Plugins for TKG  v2.2.0
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> tanzu plugin search
  NAME                  DESCRIPTION                                                                       TARGET           LATEST
  builder               Build Tanzu components                                                            global           v0.90.1
  isolated-cluster      Prepopulating images/bundle for internet-restricted environments                  global           v0.29.0
  pinniped-auth         Pinniped authentication operations (usually not directly invoked)                 global           v0.29.0
  test                  Test the CLI                                                                      global           v0.90.1
  cluster               Kubernetes cluster operations                                                     kubernetes       v0.29.0
  feature               Operate on features and featuregates                                              kubernetes       v0.29.0
  kubernetes-release    Kubernetes release operations                                                     kubernetes       v0.29.0
  management-cluster    Kubernetes management cluster operations                                          kubernetes       v0.29.0
  namespaces            Discover vSphere Supervisor namespaces you have access to                         kubernetes       v1.0.0
  package               Tanzu package management                                                          kubernetes       v0.29.0
  secret                Tanzu secret management                                                           kubernetes       v0.29.0
  telemetry             configure cluster-wide settings for vmware tanzu telemetry                        kubernetes       v0.29.0
  account               TMC account management for the organization                                       mission-control  v0.1.1
  agentartifacts        Image artifacts of all the agents to be made available on the cluster             mission-control  v0.1.1
  aks-cluster           aks-cluster plugin is used to provision and manage the tmc aks clusters.          mission-control  v0.1.1
  apply                 Apply a resource file                                                             mission-control  v0.1.1
  audit                 Run an audit request on an organization                                           mission-control  v0.1.1
  cluster               A TMC managed Kubernetes cluster                                                  mission-control  v0.1.1
  clustergroup          A group of Kubernetes clusters                                                    mission-control  v0.1.1
  continuousdelivery    Manage cluster configurations                                                     mission-control  v0.1.1
  data-protection       Backup, restore, or migrate cluster data.                                         mission-control  v0.1.1
  ekscluster            ekscluster plugin is used to provision and manage the tmc eks clusters.           mission-control  v0.1.1
  events                TMC events for any meaningful user activity or system state change                mission-control  v0.1.1
  helm                  Manage helm deployments                                                           mission-control  v0.1.1
  iam                   IAM Policies for tmc resources                                                    mission-control  v0.1.1
  inspection            Run an inspection on a cluster                                                    mission-control  v0.1.1
  integration           Get available integrations and their information from registry.                   mission-control  v0.1.1
  management-cluster    A TMC registered Management cluster                                               mission-control  v0.1.1
  policy                Policy management for resources                                                   mission-control  v0.1.1
  provider-aks-cluster  provider-aks-cluster plugin is used to manage and unmanage tmc provider aks       mission-control  v0.1.1
                        clusters
  provider-eks-cluster  provider-eks-cluster plugin is used to manage and unmanage tmc provider eks       mission-control  v0.1.1
                        clusters
  secret                Manage kubernetes secrets resource for a cluster                                  mission-control  v0.1.1
  setting               Manage default settings for some tmc features                                     mission-control  v0.1.1
  tanzupackage          Install and manage Tanzu packages. Note: tanzu-standard package repository is     mission-control  v0.1.1
                        unavailable for non-TKG clusters.
  workspace             A group of Kubernetes namespaces                                                  mission-control  v0.1.1
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> tanzu plugin install builder
[i] Installing plugin 'builder:v0.90.1' with target 'global'
[ok] successfully installed 'builder' plugin
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)> tanzu plugin list
Standalone Plugins
  NAME     DESCRIPTION             TARGET  VERSION  STATUS
  builder  Build Tanzu components  global  v0.90.1  installed
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (add_cache_options_discover_plugins)>

With ForceCache disabled and using essential plugins
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (cli_essential_plugin_groups)> tanzu version
InstallEssentialPlugins: 34.458µs
version: v1.0.0-dev
buildDate: 2023-07-13
sha: e510c7ae-dirty
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (cli_essential_plugin_groups)> tanzu plugin clean
InstallEssentialPlugins: 49.209µs
[ok] successfully cleaned up all plugins
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (cli_essential_plugin_groups)> rm -rf ~/.cache/tanzu/plugin_inventory
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (cli_essential_plugin_groups)> tanzu plugin list
[i] Reading plugin inventory for "projects.registry.vmware.com/tanzu_cli/plugins/plugin-inventory:latest", this will take a few seconds.
[i] Reading plugin inventory for "localhost:5001/test/v1/tanzu-cli/plugins/plugin-inventory:latest", this will take a few seconds.
[!]
[i] Reading plugin inventory for "localhost:5001/test/v1/tanzu-cli/plugins/plugin-inventory:latest", this will take a few seconds.
[!] Skipping the plugins discovery image signature verification for "localhost:5001/test/v1/tanzu-cli/plugins/plugin-inventory:latest"

Plugins in Group:  vmware-tzcli/essentials:v0.0.10
  NAME   TARGET  VERSION
  hello  global  v0.0.10
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (cli_essential_plugin_groups)> tz plugin list
DiscoverPluginGroups: 32.023625ms
IsPluginsFromPluginGroupInstalled: 33.662916ms
false false
[i] Looks like you haven't installed essential plugins, installing the essential plugins
[i] Installing plugin 'hello:v0.0.10' with target 'global'
InstallEssentialPlugins: 3.117538667s
Standalone Plugins
  NAME   DESCRIPTION   TARGET  VERSION  STATUS
  hello  hello 0.0.10  global  v0.0.10  installed
mpanchajanya@mpanchajanF09MK ~/v/r/tanzu-cli (cli_essential_plugin_groups)>

Release note

 Able to customise the plugin discovery process to use cache image

Additional information
Special notes for your reviewer

I like this, it is quite elegant.
There is an implementation alternative, but I don't know if it would be worth spending time on it considering our time constraints. We can quickly discuss, but here is the alternative, at least so you are aware of it.
When we introduced the SQLite DB, I started with a similar approach to pass the criteria to the List() function. After discussing it with @vuil he suggested a different approach that turned out to be more flexible.
Instead of passing the new options to List() and GetGroups() directly, which then also needs to get passed to the kubernetes, rest, local and legacy oci discoveries, we could instead pass the options when we actually create the OCI discovery (in CreateDiscoveryFromV1alpha1). The advantages are that:

we would not affect the other discoveries (although the current impact is minimal)
the options would be available to any call to the discovery, not just List() and GetGroups(), which could prove useful in the future.

In fact, we could include the PluginDiscoveryCriteria and GroupDiscoveryCriteria as part of such a new options approach.

Thanks for the suggestions. I have made the changes to move the options from the interfaces to creation methods.


doc(release-24.08): change log preparation

Description
PR to collaboratively work on the Changelog for R24.08
[24.08] - 2024-08-01
Added

Component
Helm Chart (s)
App-/KIT Version (s)

Knowledge Agents AAS Bridge
aas-bridge: 1.13.7
1.13.7

Supply Chain Disruption Notifications Kit
n/a
1.0.0

SSI Authority & Schema Registry
ssi-asr: 1.0.0
1.0.0

Updated

Component
Helm Chart (s)
App-/KIT Version (s)

BPDM Kit
n/a
6.0.0

BPN DID Resolution Service (BDRS)
0.5.2
0.5.2

Circularity Kit
n/a
1.2.0

DCM Kit
n/a
1.1.0

Digital Product Pass (DPP)
digital-product-pass: 4.0.1
v4.0.1

Digital Twin Kit
n/a
2.0.1

Digital Twin Registry
digital-twin-registry: 0.5.2
v0.5.0

Discovery Finder
discoveryfinder: 0.3.1
v0.4.0

Discovery Service (BPN Finder)
bpndiscovery: 0.3.1
v0.4.0

Eclipse Data Space Connector (Tractus-X EDC)
0.7.3
0.7.3

EcoPass Kit
n/a
1.5.0

ESS Kit
n/a
0.3.0

Golden Record Business Partner Number (BPN) Service
bpdm: 5.1.0
v6.1.0

Identity and Access Management (IAM)
centralidp: 3.0.1sharedidp: 3.0.1
keycloak: 23.0.7

Industry Core KIT
n/a
1.1.0

Item Relationship Service (IRS)
item-relationship-service: 7.4.0
5.4.0

Knowledge Agents
remoting-agent: 1.13.22provisioning-agent: 1.13.22conforming-agent: 1.13.22matchmaking-agent: 1.13.22
v1.13.22matchmaking-agent: v1.13.22

Knowledge Agents EDC
agent-plane: 1.13.22agent-plane-azure-vault: 1.13.22
v1.13.22

Managed Service Orchestrator
managed-service-orchestrator: 1.6.0
v1.5.7

Managed Simple Data Exchanger (SDE)
sde: 0.1.12
frontend: v2.4.3backend: v2.4.3

PCF Exchange Kit
n/a
1.2.0

Policy Hub
policy-hub: 1.1.0
v1.1.0

Portal
portal: 2.1.0
registration: v2.0.1frontend: v2.1.0backend: v2.1.0assets: v2.1.0

PURIS
puris: 2.7.0
2.1.0

PURIS Kit
n/a
0.3.0

Self Description (SD) Factory
sdfactory: 2.1.21
v2.1.13

Semantic Hub
semantic-hub: 0.3.1
v0.4.0

SSI Credential Issuer
ssi-credential-issuer: 1.1.0
v1.1.0

Trace-X Traceability Application
helm-charts: 1.3.43
13.0.1

Traceability Kit
n/a
5.1.0

OSIM Kit
n/a
3.0.0

Unchanged, untested

Component
Helm Chart (s)
App-/KIT Version (s)

Managed Identity Wallet (MIW)
managed-identity-wallet: 0.5.0
v0.5.0

Country Risk
country-risk: 4.0.2
1.3.1

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[X] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[X] Copyright and license header are present on all affected files

Product SSI Authority & Schema Registry checked -> OK
Product Identity and Access Management (IAM) checked -> OK
Product Policy Hub checked -> OK
ProductPortal checked -> OK
Product SSI Credential Issuer checked -> OK
It might make sense to mention somewhere that for E2E Testing the v1.2.0 of the SSI DIM Middle Layer was used, this component is FOSS but the Wallet from SAP is not.

Product SSI Authority & Schema Registry checked -> OK Product Identity and Access Management (IAM) checked -> OK Product Policy Hub checked -> OK ProductPortal checked -> OK Product SSI Credential Issuer checked -> OK
It might make sense to mention somewhere that for E2E Testing the v1.2.0 of the SSI DIM Middle Layer was used, this component is FOSS but the Wallet from SAP is not.

THX @evegufy adapted the known knowns with this commit -> Please have a look.

Message from @ciprianherciu
** SDE:**

Helmchart version v 0.1.11
App version v 2.4.2

** SD Factory**:

Helmchart version 2.1.21
AppVersion 2.1.13

** MSO**

Helmchart version 1.6.0
AppVersion - 1.5.7

Product BPN DID Resolution Service (BDRS) checked -> OK
Product Eclipse Data Space Connector (Tractus-X EDC) checked -> Ok

Message from @ciprianherciu
SDE

Helmchart version v 0.1.11
App version v 2.4.2

SD Factory

Helmchart version 2.1.21
AppVersion 2.1.13

MSO

Helmchart version 1.6.0
AppVersion - 1.5.7

@ciprianherciu done, please have a look in the PR or in the table in the desription

From Digital Product Pass ok!
From EcoPass KIT ok!

Also fixed one error:

The pcf exchange kit url was incorrect. I added the "v" to the versions that have one, so we can be consistent with the versioning.

Product Digital Twin Registry checked -> OK
Product Discovery Finder checked -> Ok
Product Discovery Service (BPN Finder) checked -> Ok
Product Semantic Hub checked -> Ok

Maybe in the future we could optimize this changelog part with markdown variables.
I have created a ticket so we can work on this in the future: https://github.com/eclipse-tractusx/tractus-x-release/issues/36

@ther3sa @jSchuetz88 we have to check the versions here. Maybe not all expected versions were already released.
Processing table 'Added'
Checking CHART for FOSS Component: BPDM Certificate Management

[ ]   ERROR: Chart version of FOSS Chart bpdm-certificate-management has version 1.0.1-alpha.3 while version 1.0.0 is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart bpdm-certificate-management (app BPDM Certificate Management) has app version 1.0.1-alpha.3 while version 1.0.0 is set in Chart available in tractusx-dev

Checking LINKS for FOSS Component: Knowledge Agents AAS Bridge

[ ]   ERROR: Release of FOSS Chart aas-bridge has invalid link 'https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/aas-bridge-1.13.7'
[ ]   ERROR: Release of FOSS APP Knowledge Agents AAS Bridge has invalid link 'https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/v1.13.7'

Checking CHART for FOSS Component: Knowledge Agents AAS Bridge

[ ]   ERROR: Could not retrieve latest Helm chart or app version for aas-bridge.
[ ]   ERROR: Chart version of FOSS Chart aas-bridge has version 1.13.7 while version None is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart aas-bridge (app Knowledge Agents AAS Bridge) has app version 1.13.7 while version None is set in Chart available in tractusx-dev

Checking LINKS for KIT: Supply Chain Disruption Notifications Kit

[ ]   ERROR: KIT Supply Chain Disruption Notifications Kit has invalid link 'https://eclipse-tractusx.github.io/docs-kits/category/supply-chain-disruption-notifications-kit'
[ ]   ERROR: Changelog of KIT Supply Chain Disruption Notifications Kit has invalid link 'https://eclipse-tractusx.github.io/docs-kits/kits/Supply Chain Disruption Notifications KIT/Supply Chain Disruption Notifications Changelog'

Checking CHART for FOSS Component: SSI Authority & Schema Registry

[ ]   ERROR: Could not retrieve latest Helm chart or app version for ssi-asr.
[ ]   ERROR: Chart version of FOSS Chart ssi-asr has version 1.0.0 while version None is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart ssi-asr (app SSI Authority & Schema Registry) has app version 1.0.0 while version None is set in Chart available in tractusx-dev

Processing table 'Updated'
Checking CHART for FOSS Component: BPN DID Resolution Service (BDRS)

[ ]   ERROR: Could not retrieve latest Helm chart or app version for [0.5.2](https.
[ ]   ERROR: Chart version of FOSS Chart [0.5.2](https has version 0.5.2 while version None is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart [0.5.2](https (app BPN DID Resolution Service (BDRS)) has app version 0.5.2 while version None is set in Chart available in tractusx-dev

Checking CHART for FOSS Component: Eclipse Data Space Connector (Tractus-X EDC)

[ ]   ERROR: Could not retrieve latest Helm chart or app version for [0.7.3](https.
[ ]   ERROR: Chart version of FOSS Chart [0.7.3](https has version 0.7.3 while version None is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart [0.7.3](https (app Eclipse Data Space Connector (Tractus-X EDC)) has app version 0.7.3 while version None is set in Chart available in tractusx-dev

Checking LINKS for FOSS Component: Identity and Access Management (IAM)

[ ]   ERROR: Release version '23.0.7' and link version 'https://www.keycloak.org/docs/latest/release_notes/index.html#keycloak-23-0-7' of FOSS APP Identity and Access Management (IAM) do not match

Checking CHART for FOSS Component: Identity and Access Management (IAM)

[ ]   ERROR: Chart version of FOSS Chart centralidp has version 3.0.1 while version 3.0.0 is available in tractusx-dev

Checking LINKS for FOSS Component: Knowledge Agents

[ ]   ERROR: Release of FOSS Chart remoting-agent has invalid link 'https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/matchmaking-agent-1.13.22'
[ ]   ERROR: Release of FOSS APP Knowledge Agents has invalid link 'https://github.com/eclipse-tractusx/knowledge-agents/releases/tag/v1.13.22'

Checking CHART for FOSS Component: Knowledge Agents

[ ]   ERROR: Chart version of FOSS Chart remoting-agent has version 1.13.22 while version 1.12.19 is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart remoting-agent (app Knowledge Agents) has app version v1.13.22 while version 1.12.19 is set in Chart available in tractusx-dev

Checking LINKS for FOSS Component: Knowledge Agents EDC

[ ]   ERROR: Release of FOSS Chart agent-plane has invalid link 'https://github.com/eclipse-tractusx/knowledge-agents-edc/releases/tag/agent-plane-azure-vault-1.13.22'
[ ]   ERROR: Release of FOSS APP Knowledge Agents EDC has invalid link 'https://github.com/eclipse-tractusx/knowledge-agents-edc/releases/tag/v1.13.22'

Checking CHART for FOSS Component: Knowledge Agents EDC

[ ]   ERROR: Chart version of FOSS Chart agent-plane has version 1.13.22 while version 1.12.19 is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart agent-plane (app Knowledge Agents EDC) has app version v1.13.22 while version 1.12.19 is set in Chart available in tractusx-dev

Checking CHART for FOSS Component: Managed Service Orchestrator

[ ]   ERROR: Chart version of FOSS Chart managed-service-orchestrator has version 1.6.0 while version 1.5.9 is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart managed-service-orchestrator (app Managed Service Orchestrator) has app version v1.5.7 while version 1.5.6 is set in Chart available in tractusx-dev

Checking CHART for FOSS Component: Managed Simple Data Exchanger (SDE)

[ ]   ERROR: Chart version of FOSS Chart sde has version 0.1.11 while version 0.1.10 is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart sde (app Managed Simple Data Exchanger (SDE)) has app version v2.4.2 while version 2.3.8 is set in Chart available in tractusx-dev

Checking CHART for FOSS Component: Policy Hub

[ ]   ERROR: Chart version of FOSS Chart policy-hub has version 1.1.0 while version 1.0.0 is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart policy-hub (app Policy Hub) has app version v1.1.0 while version 1.0.0 is set in Chart available in tractusx-dev

Checking CHART for FOSS Component: Portal

[ ]   ERROR: Chart version of FOSS Chart portal has version 2.1.0 while version 2.0.0 is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart portal (app Portal) has app version v2.0.1 while version 2.0.0 is set in Chart available in tractusx-dev

Checking CHART for FOSS Component: SSI Credential Issuer

[ ]   ERROR: Chart version of FOSS Chart ssi-credential-issuer has version 1.1.0 while version 1.0.0 is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart ssi-credential-issuer (app SSI Credential Issuer) has app version v1.1.0 while version 1.0.0 is set in Chart available in tractusx-dev

Checking CHART for FOSS Component: Trace-X Traceability Application

[ ]   ERROR: Could not retrieve latest Helm chart or app version for helm-charts.
[ ]   ERROR: Chart version of FOSS Chart helm-charts has version 1.3.43 while version None is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart helm-charts (app Trace-X Traceability Application) has app version 13.0.1 while version None is set in Chart available in tractusx-dev

Processing table 'Unchanged, untested'
Checking CHART for FOSS Component: Country Risk

[ ] ERROR: App version of FOSS Chart country-risk (app Country Risk) has app version 1.3.1 while version 2.0.0 is set in Chart available in tractusx-dev

@stephanbcbauer @ther3sa you provided me this link for the app dashboard. This still links to the state of the old argo cd and thus can't be used to evaluate the known knowns.

@stephanbcbauer @ther3sa you provided me this link for the app dashboard. This still links to the state of the old argo cd and thus can't be used to evaluate the known knowns.

@tom-rm-meyer-ISST not 100% sure, but I think in our past meeting @ther3sa provided this link https://app-dashboard.int.catena-x.net/ and not the old one?

@stephanbcbauer @ther3sa you provided me this link for the app dashboard. This still links to the state of the old argo cd and thus can't be used to evaluate the known knowns.

@tom-rm-meyer-ISST not 100% sure, but I think in our past meeting @ther3sa provided this link https://app-dashboard.int.catena-x.net/ and not the old one?

Thanks a lot. I just found the old one. I was also pretty sure you sent the correct one. Gonna cross check

Managed Simple Data Exchanger need to be updated to
Helm Chart Version: 0.1.12
App Version: 2.4.3

Managed Simple Data Exchanger need to be updated to Helm Chart Version: 0.1.12 App Version: 2.4.3

adapted with 225d01e

@ther3sa and @stephanbcbauer the overall table looks ok to me (have NOT specifically checked any versions). Recommendation is to add description text for 24.08 above table. Recommendation is to add "known knowns" as appropriate. IMHO especially MIW listed as "unchanged, untested" seems awkward...

@RolaH1t Thx for the review. known knowns are included? Did we miss something? MIW, but this is the case.

@eclipse-tractusx/automotive-tractusx-committers @ds-mwesener please have a look again and check the PR, what about the known knowns?
i checked again the versions and Links with the tool provided by @tom-rm-meyer-ISST (Thx it helps a lot) -> There are still some issues
Checking LINKS for KIT: Supply Chain Disruption Notifications Kit

[X] ERROR: KIT Supply Chain Disruption Notifications Kit has invalid link 'https://eclipse-tractusx.github.io/docs-kits/category/supply-chain-disruption-notifications-kit'
[X] ERROR: Changelog of KIT Supply Chain Disruption Notifications Kit has invalid link 'https://eclipse-tractusx.github.io/docs-kits/kits/Supply Chain Disruption Notifications KIT/Supply Chain Disruption Notifications Changelog'
=> Thats OK since the KIT was not merged yet

Checking CHART for FOSS Component: Eclipse Data Space Connector (Tractus-X EDC)

[ ] ERROR: Could not retrieve latest Helm chart or app version for [0.7.3](https.
[ ] ERROR: Chart version of FOSS Chart [0.7.3](https has version 0.7.3 while version None is available in tractusx-dev
[ ] ERROR: App version of FOSS Chart [0.7.3](https (app Eclipse Data Space Connector (Tractus-X EDC)) has app version 0.7.3 while version None is set in Chart available in tractusx-dev
=> I heard there is something special with EDC?

Checking CHART for FOSS Component: BPN DID Resolution Service (BDRS)

[ ] ERROR: Could not retrieve latest Helm chart or app version for [0.5.2](https.
[ ] ERROR: Chart version of FOSS Chart [0.5.2](https has version 0.5.2 while version None is available in tractusx-dev
[ ] ERROR: App version of FOSS Chart [0.5.2](https (app BPN DID Resolution Service (BDRS)) has app version 0.5.2 while version None is set in Chart available in tractusx-dev
=> @lgblaumeiser can you please check again? is it the same as for EDC?

Checking CHART for FOSS Component: Portal

[] ERROR: App version of FOSS Chart portal (app Portal) has app version v2.0.1 while version 2.1.0 is set in Chart available in tractusx-dev
=> @evegufy is this correct?

Checking CHART for FOSS Component: Trace-X Traceability Application

[ ] ERROR: Could not retrieve latest Helm chart or app version for helm-charts.
[ ] ERROR: Chart version of FOSS Chart helm-charts has version 1.3.43 while version None is available in tractusx-dev
[ ] ERROR: App version of FOSS Chart helm-charts (app Trace-X Traceability Application) has app version 13.0.1 while version None is set in Chart available in tractusx-dev
=> @mkanal not sure about this

ThX for your support

Hello @stephanbcbauer , I do not understand the reason for the errors and the question for that. I checked with TRG 5.01 and the charts have exactly the fields set as defined there. Could the problem be, that both EDC and BDRS provide two helm charts for different distributions of the service? Either way, the versions specified in your overall release item are correct.

Hello @stephanbcbauer , I do not understand the reason for the errors and the question for that. I checked with TRG 5.01 and the charts have exactly the fields set as defined there. Could the problem be, that both EDC and BDRS provide two helm charts for different distributions of the service? Either way, the versions specified in your overall release item are correct.

@tom-rm-meyer-ISST haven't looked into the tool, but can this be the reason? i checked the links a.s.o manually and everything seems to be fine

Checking CHART for FOSS Component: Trace-X Traceability Application

[ ]  ERROR: Could not retrieve latest Helm chart or app version for helm-charts.
[ ]  ERROR: Chart version of FOSS Chart helm-charts has version 1.3.43 while version None is available in tractusx-dev
[ ]  ERROR: App version of FOSS Chart helm-charts (app Trace-X Traceability Application) has app version 13.0.1 while version None is set in Chart available in tractusx-dev

=> @mkanal not sure about this
ThX for your support

Hi @stephanbcbauer we have rechecked the chart / app versions and everything seems to be fine:
Looking the versions up here: https://eclipse-tractusx.github.io/charts/dev/index.yaml
We will find the helm chart 1.3.43 as well as the app version 13.0.1
Could you please explain what you mean with None is set / found?

Checking CHART for FOSS Component: Trace-X Traceability Application

[ ]   ERROR: Could not retrieve latest Helm chart or app version for helm-charts.
[ ]   ERROR: Chart version of FOSS Chart helm-charts has version 1.3.43 while version None is available in tractusx-dev
[ ]   ERROR: App version of FOSS Chart helm-charts (app Trace-X Traceability Application) has app version 13.0.1 while version None is set in Chart available in tractusx-dev

=> @mkanal not sure about this
ThX for your support

Hi @stephanbcbauer we have rechecked the chart / app versions and everything seems to be fine:
Looking the versions up here: https://eclipse-tractusx.github.io/charts/dev/index.yaml We will find the helm chart 1.3.43 as well as the app version 13.0.1
Could you please explain what you mean with None is set / found?
Regarding the Known-Knowns we have listed them in our release log. All of them have very small impact on the functionalities and will be accepted from our perspective. Do you need anything else?

@ds-mwesener thx, checked it also again. It should be fine.

@eclipse-tractusx/automotive-tractusx-committers @ds-mwesener please have a look again and check the PR, what about the known knowns?
FYI @jSchuetz88 @ther3sa
i checked again the versions and Links with the tool provided by @tom-rm-meyer-ISST (Thx it helps a lot) -> There are still some issues
Checking LINKS for KIT: Supply Chain Disruption Notifications Kit

[x]  ERROR: KIT Supply Chain Disruption Notifications Kit has invalid link 'https://eclipse-tractusx.github.io/docs-kits/category/supply-chain-disruption-notifications-kit'
[x]  ERROR: Changelog of KIT Supply Chain Disruption Notifications Kit has invalid link 'https://eclipse-tractusx.github.io/docs-kits/kits/Supply Chain Disruption Notifications KIT/Supply Chain Disruption Notifications Changelog'

=> Thats OK since the KIT was not merged yet
Checking CHART for FOSS Component: Eclipse Data Space Connector (Tractus-X EDC)

[ ]  ERROR: Could not retrieve latest Helm chart or app version for [0.7.3](https.
[ ]  ERROR: Chart version of FOSS Chart [0.7.3](https has version 0.7.3 while version None is available in tractusx-dev
[ ]  ERROR: App version of FOSS Chart [0.7.3](https (app Eclipse Data Space Connector (Tractus-X EDC)) has app version 0.7.3 while version None is set in Chart available in tractusx-dev

=> I heard there is something special with EDC?
Checking CHART for FOSS Component: BPN DID Resolution Service (BDRS)

[ ]  ERROR: Could not retrieve latest Helm chart or app version for [0.5.2](https.
[ ]  ERROR: Chart version of FOSS Chart [0.5.2](https has version 0.5.2 while version None is available in tractusx-dev
[ ]  ERROR: App version of FOSS Chart [0.5.2](https (app BPN DID Resolution Service (BDRS)) has app version 0.5.2 while version None is set in Chart available in tractusx-dev

=> @lgblaumeiser can you please check again? is it the same as for EDC?
Checking CHART for FOSS Component: Portal

[ ]  ERROR: App version of FOSS Chart portal (app Portal) has app version v2.0.1 while version 2.1.0 is set in Chart available in tractusx-dev

=> @evegufy is this correct?
Checking CHART for FOSS Component: Trace-X Traceability Application

[x]  ERROR: Could not retrieve latest Helm chart or app version for helm-charts.
[x]  ERROR: Chart version of FOSS Chart helm-charts has version 1.3.43 while version None is available in tractusx-dev
[x]  ERROR: App version of FOSS Chart helm-charts (app Trace-X Traceability Application) has app version 13.0.1 while version None is set in Chart available in tractusx-dev

=> @mkanal not sure about this
ThX for your support

@stephanbcbauer I'm not sure to what you're referring to, the overarching appVersion is 2.1.0 as well, there's just the registration app where we had a patch version (2.0.1) for the rest 2.1.0, so all fine.

Lets check of the known knowns 👍🏻 But in case I am not here to approve it, it looks already for me.

@eclipse-tractusx/automotive-tractusx-committers thx for your help, I think we are good to go and merge the PR ⇾ Exactly the content will also be merged with this PR https://github.com/eclipse-tractusx/eclipse-tractusx.github.io/pull/1011


covid metro search component

Description
Adds a new component which checks an address is in/out of the metro area.
It does this by comparing user input to a list of suburbs and postcodes, which are already categorised for inside/outside/borderline.
For borderline cases it prompt the user to enter a full address, which is then looked up and geocoded, and the compared against a polygon of the metro area.
Motivation and Context
This was work completed by geoplex and requested by DPC.
How Has This Been Tested?
Tested locally.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

[x] The PR title is no longer than 64 characters.
[x] My code follows the code style of this project.
[ ] I've added relevant changes to the documentation (applies to new features and breaking changes in core

Hey @richorama @b-schiller As MetroAreaAddressSearch is a specific component just for single usage, please don't publish it to NPM. Ideally I would like it to be in our project instead of here. Then we will able to update and test it in our site more convenient.

Hi @tim-yao , sorry, I'm not familiar with how these components are published and consumed. Are you suggesting I have put this component in the wrong repository? Or is this a configuration problem in this repo?

Hi @tim-yao , sorry, I'm not familiar with how these components are published and consumed. Are you suggesting I have put this component in the wrong repository? Or is this a configuration problem in this repo?

Hi @richorama yes, for MetroAreaAddressSearch component, I would like it to be inside our project. I have invited you to our slack channel, we can talk there. Thanks!


Include shared library

Hi,
Thanks for the work! I'm however looking into including a shared library to validate our Jenkinsfiles, but I do not know how to proceed. Could you help me out?
Thanks!

Hi,
You could do this by using JCasC plugin and define your lib in the config.yml.
Here the example how the lib details can be defined:
https://github.com/jenkinsci/configuration-as-code-plugin/tree/master/demos/workflow-cps-global-lib.
Best regards.

Hey @belsander,
in the meantime this is really easy to solve using Configuration as Code as mentioned by @OliverNocon. I've described it for a specific case in a blog post, should be really simple to adopt for other cases. I think this issue can be closed.

My plan is to have support of packaging libraries with Custom WAR Packager flow:  https://issues.jenkins-ci.org/browse/JENKINS-56100
https://jenkins.io/blog/2018/10/16/custom-war-packager/ explains the flow for custom packages

@fwilhe Just in case you are interested, your blog could be reposted on https://jenkins.io/node/ . It would be an interesting case study. CC @tracymiranda
W.r.t rhis particular issue, I am going to close it. JCasC formally addresses the request (see the blogpost), the rest will be automated in https://issues.jenkins-ci.org/browse/JENKINS-56100 .

@oleg-nenashev @tracymiranda I'd love to share the post in other places. What would I need to do for that?

@fwilhe We use configuration-as-code so you can just submit a pull request to https://github.com/jenkins-infra/jenkins.io. Guidelines: https://github.com/jenkins-infra/jenkins.io/blob/master/CONTRIBUTING.adoc#adding-a-blog-post

Submitted a PR :)
Thanks for the offering!