Typescript Support

Hi All,
I know there is an @types/sortablejs file out in the wild, but in the react world I don't know how to hook it up correctly, due to unfimilarity with the react specific implementation of SortableJs. I've used VueJs Component which works easily and am familiar with many SortableJS options.
From the example in this README.md, I entered this code:
import uniqueId from 'lodash/uniqueId';
import React from 'react';
import Sortable from 'react-sortablejs';

The squiggly lines of death are under 'react-sortablejs', which displays the following message on hover:
Try `npm install @types/react-sortablejs` if it exists or
add a new declaration (.d.ts) file containing `declare module 'react-sortablejs';

I am trying to go through the typescript documentation for an answer, but can't figure out how to extend the sortablejs types into react-sortablejs
Any ideas?
On resolution of this, we should link @types/sortablejs as a dependency in future builds alongside a declaration form for this package. I'll be happy to try doing this once I start using this Component.

Hi
I had the same issue, and I fixed it by adding the file src/react-sortablejs.d.ts
declare module 'react-sortablejs' {
  import Sortable from 'sortablejs';

  export interface SortableProps<ItemData, ListProps> {
    options?: Sortable.Options;
    onChange?: (list: ItemData[], sortable: Sortable, event: Sortable.SortableEvent) => void;
    tag?: string | React.ComponentType<ListProps>;
    style?: React.CSSProperties;
  }

  export default class SortableComponent<ItemData, ListProps> extends React.Component<
    SortableProps<ItemData, ListProps>
  > {}
}

I also installed @types/sortablejs and added this to tsconfig.ts:
    "esModuleInterop": true,
    "allowSyntheticDefaultImports": true,

I'm importing the Sortable component like this:
import Sortable from 'react-sortablejs';

Tell me if it works for you. We could submit this to @types/react-sortablejs.

Hi Godefroy,
That looks great! I will try it within 24 hours.
I'm a bit confused on how ItemData in interface SortableProps<ItemData, ListProps> would work, but I'm sure i'll answer my own question.
I actually converted the whole package into a Typescript file to the best of my ability. What are your thoughts on it? You can import it into your project using package name tsc-react-sortable
https://github.com/waynevanson/tsc-react-sortablejs

We could submit this to @types/react-sortablejs.

We should definitely submit this to @types/react-sortablejs. I'll try it and add recommendations to this issue.
I also feel we should clean up this component, as it's hard to read and manage. I feel like making a React.FunctionComponent would make the code easier to maintain and easier to add to.

From https://github.com/DefinitelyTyped/DefinitelyTyped#create-a-new-package

If you are the library author and your package is written in TypeScript, bundle the autogenerated declaration files in your package instead of publishing to Definitely Typed.

@types works, I'd prefer a rewrite in Typescript so when the source changes, so does the package. Otherwise we'll be writing 2 different packages for something small like this.

We have 3 solutions:

Add typings to this repo
Rewrite this repo to Typescript
Create @types/react-sortablejs

You picked solution 2 but you still have a lot of any, and it's a different repo, so it's less maintanable in sync with this repo. My solution is probably more simple and has complete typings.
I guess we could remove the generic ItemData because it will always be string, as data-id is always a string (it's an HTML attribute, so it's a string).
@cheton What do you think?

Sorry, I closed by accident.
For a short term solution, I modified your declaration file given below. This is because it was giving me a JSX Constructor Error
declare module 'react-sortablejs' {
  import React from 'react';
  import Sortable from 'sortablejs';

  class ReactSortable extends React.Component<Props> {
    public options: Sortable.Options;
  }

  export interface Props extends React.ClassAttributes<Component> {
    onChange?: (list: ItemData[], sortable: Sortable, event: Sortable.SortableEvent) => void;
    options?: Sortable.Options;
    tag?: string | React.ComponentType<ListProps>;
    style?: React.CSSProperties;
    className?: string;
  }
  export = ReactSortable;
}

you still have a lot of any

There are some types that I do not understand yet. The goal is to have no any's.

and it's a different repo, so it's less maintanable in sync with this repo.

I made it as a proof of concept. Ideally with suggestion 2, this repo transforms into a Typescript project.

My solution is probably more simple and has complete typings.

With some modifications it works, but considering how small this project is (just a component), a rewrite wouldn't be too difficult and it's an all-in-one solution for the project. The benefits of a Typescript rewrite outweigh the cons.
I'd love to hear what @cheton has to say.

@owen-m1 it looks like @cheton is not maintaining this package, many issues are open etc. Even the build fails, according to the indicator.
I'd be happy to maintain this, or perhaps in the meantime you'd be able to help us push Typescript into this repository. What do you think about this?
Currently, I find the code on this package hard to work with. In comparison, the Vue.Draggable package is remarkable and works right out of box without configuration. In react-sortablejs, there are features such as sorting an input list to state and better nesting support which should be part of this package.
Have a look at https://github.com/waynevanson/tsc-react-sortablejs to see a basic conversion. It's the same as the current package and handles strict null checks. there are some any's as it was probably written without 100% type safety in mind.
Aside from my current efforts, I'd much prefer this being either a FunctionComponent or break down the Class component into testable parts. Which route do you think is a good idea?

@waynevanson I don't know if he is still maintaining this or not. You'll have to ask him about this, this is his project. If he approves I can add you to the project.
I can help in any way I can as the "Sortable expert" but I don't know React :).

Thanks, @owen-m1 . I've sent him an email asking if I'd be able to switch maintainers, or if he doesn't want to switch, if he can reply to this thread.

@waynevanson Would this package need Typescript support if Sortable uses Typescript? Or do you mean writing this package itself in Typescript?

Hi @waynevanson
I'm currently busy at work in the last few months and the situation will not end until August, so I don't have much time to watch and respond GitHub issues. Also, I'm not an expert in TypeScript, I'd be happy if someone can help maintain / contribute to this project to complete TypeScript support, I can help do code review and publish new releases to NPM.
@owen-m1 Can you help add @waynevanson as a maintainer for this repo. Thank you.

Sure, @waynevanson I sent you an invite.

There we are boys: https://github.com/SortableJS/react-sortablejs/issues/83


Laravel customizing & modifying URL::temporarySignedRoute for must verify email

Any help would be really appreciated.
I'm using hyn/multi-tenant. I'm trying to register the user account with tenancy in placed. The user does get registered & the email is sent to them. The email looks like the following.
http://example.com/email/verify/1?expires=1551615525&signature=b389f8c5d25c426c966ba0092ee062ab4e3febaebab5dcfd083549c7c2362150
When the user clicks on it, the account doesn't get activated.
The user will have to log in to there dashboard, and resend the verification email from http://abc.example.com, then the URL is generated correctly and the account is activated successfully.
http://abc.example.com/email/verify/1?expires=1551615525&signature=b389f8c5d25c426c966ba0092ee062ab4e3febaebab5dcfd083549c7c2362150
My actual question is can we modify or hook into URL::temporarySignedRoute? to add the sub-domain name inside the URL? so it should look like http://abc.example.com

Hi there,
Looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC


Refactor as package

Refactor  to:
thai2transformers provides utility functions, scripts and notebooks to pretrain, finetune, evaluate and infer Huggingface models and datasets in Thai language.

Progress tracking: https://docs.google.com/spreadsheets/d/1Arusyp3NOiBSv3KAdNPnN1VWOsVnj5ZHG71fKxnEK7o/edit?usp=sharing

Close to use smaller PRs instead.


ESM Version

could you also provide a ESM build in your package?
I'm haveing a frontend without using a bundler, only ESM modules.
You could add an extra directory in your nuget, like "esm" and then create a new property in your package.json, like:
"module": "..." and
"exports": { "requier": "...", "import":"..."}

you could use esbuild for this... https://medium.com/geekculture/build-a-library-with-esbuild-23235712f3c

Hey @jogibear9988, can you send over a pull request for this? I don't know what it means and this is an free open-source project powered by the community who use it! 🙌🏻

@jogibear9988 this is currently almost working in #288.


Show minimum supported version of a feature

currently it shows the latest version of a browser that has support
as an example
https://caniuse.com/#search=first-child
this will come up for IE11 as supported, and is also supported since IE7 altho not displayed till you click "show all". It would be amazing to see the minimum version, when a feature was introduced.

I agree. "show all" is a bit painful to navigate when there is a large time/version gap between browser-version-that-first-supported-feature-x and latest-version-of-browser-that-supports-feature-x.
For example, I want to add a service worker to a site and so I wanted to try and determine earliest browser versions that supported this, in order to determine what other browser features were supported by that version (so I could also use them without transpilation in my service worker JS file).

Having looked at caniuse-cmd I can get the info I'm looking for. Would be nice if the website could show this too.
caniuse serviceworkers
E.g. I can see from the following that Chrome 45+ fully supports service workers.
Service Workers √ 84.43% Θ 0.2% [W3C Working Draft]
  Method that enables applications to take advantage of persistent background
  processing, including hooks to enable bootstrapping of web applications while
  offline. #JSAPI

  IE ×
  Edge × 12+ × 15+² √ 17+
  Firefox × 2+ × 33+¹ √ 44+ √ 45+³ √ 46+ √ 52+³ √ 53+
  Chrome × 4+ Θ 40+ √ 45+
  Safari × 3.1+ √ 11.1+
  Opera × 9+ Θ 27+ √ 32+

    ¹Partial support can be enabled in Firefox with the
    `dom.serviceWorkers.enabled` flag.
    ²Available behind the "Enable service workers" flag
    ³Disabled on Firefox ESR, but can be re-enabled with the
    `dom.serviceWorkers.enabled` flag
   ⓘ  Details on partial support can be found on [is ServiceWorker
   Ready?](https://jakearchibald.github.io/isserviceworkerready/)

The issue described here is now fixed with the new view mode rework: "Show all" is now the default and combines multiple versions into one, making it much easier to see when support changed.


Doesn't work with cross-env

When running this plugin with cross-env I get an error coming from cross-spawn
using<EMAIL_ADDRESS>using<EMAIL_ADDRESS>using<EMAIL_ADDRESS>(latest at the moment of writing this issue)
Error: Can't find specified path.
    at notFoundError (J:\MAMP\htdocs\langhe\wp-content\themes\my-theme\node_modules\cross-spawn\lib\enoent.js:11:11)
    at verifyENOENT (J:\MAMP\htdocs\langhe\wp-content\themes\my-theme\node_modules\cross-spawn\lib\enoent.js:46:16)
    at ChildProcess.cp.emit (J:\MAMP\htdocs\langhe\wp-content\themes\my-theme\node_modules\cross-spawn\lib\enoent.js:33:19)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>prod-cross: `cross-env NODE_ENV='prod' env UV_THREADPOOL_SIZE=100 webpack -p --config webpack/webpack.prod.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prod-cross script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\blabla\AppData\Roaming\npm-cache\_logs\2017-11-03T13_58_53_850Z-debug.log

See attached debug log file.
2017-11-03T13_58_53_850Z-debug.log

I don't believe this is a problem with this plugin.
I'm able to use it with cross-env and cross-spawn myself fine with the given versions.
If you are able, can you provide a full webpack config that causes the problem?


[wpe-webkit] Bumping up WPE WebKit to 2.24.3

The md5sum and sha256sum need to be updated. Was this tested?

md5sum and sha256sum have changed I hope :)

:-)


How to log which files changed and caused webpack to reload?

Documentation Is:

[ ] Missing
[ ] Needed
[ ] Confusing
[x] Not Sure?

How I can access which files changed and caused webpack to recompile?

Please don't remove portions of issue templates, or your issue may be closed as invalid next time.
It looks like you chose the "Documentation" issue to ask a question looking for help. Note that we have a separate issue type specifically addressing that.

👉🏽 Need support, help, or advice? Don't open an issue! Head to StackOverflow or https://gitter.im/webpack/webpack.

If you legitimately feel that this is a documentation issue, please edit your issue, add the missing template sections, and provide context about what documentation you feel does not exist or is missing.

Closing due to no response from OP.


DocumentBuilder doesn't handle multiple styles with the same style name but different IDs

Observation 1
When creating a document, DocumentBuilder merges styles by using the first style with a given ID from the list of sources. As an example, if source 1 and source 2 both specify a style with the ID heading1, the style from source 1 will be used.
Observation 2
When saving a document in a version of Word with a different display language than English, Word localizes the style IDs of built-in styles. However, it doesn't localize the style names. This leads to style XML like the following (from a Danish-language instance of Word):
<w:style w:type="paragraph" w:styleId="Overskrift1" xmlns:w="http://schemas.openxmlformats.org/wordprocessingml/2006/main">
  <w:name w:val="heading 1" />
  <w:basedOn w:val="Normal" />
  <w:next w:val="Normal" />
  <w:link w:val="Overskrift1Tegn" />
  ...
</w:style>

Observation 3
When opening a document containing multiple (localized) styles with the same style name, Word deletes all but the last style, applying it to all elements that referenced one of the styles.
Result
Taken together, this means that DocumentBuilder seems to behave erratically with regards to style merging when building documents from sources saved in different language-versions of Word.
Solution
A possible solution would be to merge not only styles with the same ID, but also styles with the same name. This would mean that all references to one of the merged style would have to be changed to reference the ID of the "canonical" style.

@EricWhiteDev: A description of the style issue and a potential fix for discussion at our meeting tomorrow.


context.actor is nil in preparations and changes in Transfer resource, causing KeyError

Bug Description
When performing a transfer operation on the Transfer resource with an actor directly, it works as expected. However, context.actor is nil in a module preparation or change, resulting in the following error:
** (Ash.Error.Unknown) Unknown Error

     * %KeyError{key: :current_tenant, term: nil, message: "key :current_tenant not found in: nil\n\nIf you are using the dot syntax, such as map.field, make sure the left-hand side of the dot is a map"}
       (kamaro 0.1.0) lib/my_app/preparations/set_tenant_from_actor.ex:5: MyApp.Preparations.SetTenantFromActor.prepare/3
       (ash 3.2.4) lib/ash/query/query.ex:704: anonymous fn/6 in Ash.Query.run_preparations/6

How To Reproduce

Define preparation

defmodule MyApp.Preparations.SetTenantFromActor do
  use Ash.Resource.Preparation

  def prepare(query, _opts, context) do
    Ash.Query.set_tenant(query, context.actor.current_tenant.domain)
  end
end

Define change

defmodule MyApp.Changes.SetTenantFromActor do
  use Ash.Resource.Change

  def change(changeset, _opts, context) do
    Ash.Changeset.set_tenant(changeset, context.actor.current_tenant.domain)
  end

  def atomic(changeset, opts, context) do
    {:ok, change(changeset, opts, context)}
  end
end

Add them to your resource

defmodule MyApp.Ledger.Transfer do
  use Ash.Resource,
    domain: MyApp.Ledger,
    data_layer: AshPostgres.DataLayer,
    extensions: [AshDoubleEntry.Transfer]

  postgres do
    table "ledger_transfers"
    repo MyApp.Repo
  end

  preparations do
    prepare MyApp.Preparations.SetTenantFromActor
  end

  changes do
    change MyApp.Changes.SetTenantFromActor
  end

  multitenancy do
    strategy :context
  end

  actions do
    defaults [:read]
  end

  transfer do
    account_resource(MyApp.Ledger.Account)
    balance_resource(MyApp.Ledger.Balance)
  end
end

Attempt to transfer by passing an actor

MyApp.Ledger.transfer(account_1, account_2, actor: user)

Expected behavior
The context.actor should be properly set in preparations and changes so that the tenant can be accessed.
** Runtime

Elixir version: 1.17.2
Erlang version: Erlang/OTP 27
OS: Ubuntu 24
Ash version: {
, "~> 3.2.0"}
Related extension versions: {
, "~> 1.0.3"}

Thanks for the report. Please try ash main, the issue should be fixed there. Reopen this issue if it persists, 🙇


[Bug]: ngx-editor hangs and crashes in Chrome when inserting external image links, but works in Firefox

What happened?
When using ngx-editor in Chrome to insert external image links, the editor experiences hangs and subsequently crashes. Interestingly, this issue is specific to Chrome under regular browsing mode, as the editor functions correctly in Firefox. Upon further testing, it was observed that when Chrome is switched to incognito (privacy) mode, ngx-editor operates without any hitches or crashes when inserting the same external image links. This suggests that the issue might be influenced by certain browser configurations, extensions, or cached data present in normal mode but not in incognito mode.
Version
v15.3.0
Angular Version
v15.2.0
What browsers are you seeing the problem on?
Chrome
Link to reproduce
No response
Relevant log output
No response
Willing to submit a PR?
None

Sorry i found the problem, My Chrome browser was exhibiting abnormal behavior due to an extension. Once I disabled the extension, everything returned to normal.

Hi. thanks for update. Sorry I saw the issue on a weekend and forgot to reply once I came back.
Glad the issue is fixed now


The more options, the longer time it takes to open the Combobox dropdown

Description of the bug
Title basically, this starts to be slightly noticeable at around 365 elements, and is very noticeable at around 1800 elements.
I've created an example here: https://codesandbox.io/p/devbox/autumn-platform-j8z3wh
Steps To Reproduce
Add ~365 or more options to a Combobox.
Open the combobox.
Additional Information
No response

Just a headsup we haven't forgotten this :)
We did some quick testing to see if could improve this without avail, so this is a bigger deep-dive/investigation thats needed.


WarpAffine

I'm trying to rotate an image saved in a raw uchar4 pointer but the result I get in a single color green image.
My transformation matrix is:
	const float transform[2][3] = {{0,-1,0},{1,0,0}};
and then I call
uchar4 *temp = NULL, *temp1 = NULL;
cudaWarpAffine( temp, temp1, IMG_ROW, IMG_COL, transform);

It works when I use the identity matrix, but I don't get what I am doing wrong when  calling the function.

It looks like green is the default background color when the inverse-transformed coordinates are out-of-range of the size of the input image:
https://github.com/dusty-nv/jetson-utils/blob/1f3709f48258c2d75500c35605e8f6f4a3447afc/cuda/cudaWarp-affine.cu#L49
I probably made this green so I could easier debug it.
The function expects the width before the height, and you have the IMG_ROW before IMG_COL.   Try this:
cudaWarpAffine( temp, temp1, IMG_COL, IMG_ROW, transform);

For simplicity, it appears when I made these warp functions, the image size is kept the same, so it may not be ideal to capture the full rotate.   Different input/output dimensions would need to be added to properly support it.   In this kernel you would essentially use different input/output width & height (instead of one width/height):   https://github.com/dusty-nv/jetson-utils/blob/1f3709f48258c2d75500c35605e8f6f4a3447afc/cuda/cudaWarp-affine.cu#L29


error install on fedora 24

i try to install on fedora 24 and get error when execute swiftbuild.sh build
$ ./swiftbuild.sh build
build
~/tmp/swiftbuild/swift ~/Dokumen/programfile/swift
utils/build-script: fatal error: preset file not found (tried ['/home/hahnfedora/Dokumen/programfile/swift/linuxpreset.ini'])
~/Dokumen/programfile/swift

how to solve this? thanks in advance :)

ah my bad. forget download linuxpreset.ini
sorry

This script is probaly no longer relevant other than to extract the list of
build dependencies.
The swift project created thier own build driving script that now does much
of the tasks this script did for earlier versions.  And you would be better
going down that path.
On 14 Jul 2016 20:25, "Hanhan"<EMAIL_ADDRESS>wrote:

Reopened #6 https://github.com/thawkins/fedora-swift/issues/6.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/thawkins/fedora-swift/issues/6#event-722912372, or mute
the thread
https://github.com/notifications/unsubscribe/AAA4ybv5LeIfor2zuZfRpMFxrtV2UiOpks5qVirKgaJpZM4JMIMc
.

when execute swiftbuild.sh build get error when convert swift.pod. from [1] i download again swift.pod and edit CMakeLists.txt.
when build again, error like this [2].
FAIL: Swift :: SILGen/collection_subtype_upcast.swift (1661 of 8328)
******************** TEST 'Swift :: SILGen/collection_subtype_upcast.swift' FAILED ********************
...

[1] http://www.kianmeng.org/2015/12/swift-in-fedora-24-rawhide.html
[2] https://gist.github.com/hahn/0cc2ab6859e9470185a72591e8ad36a8

oh ok.
when i try to run swft from build/buildbot_linux/swift-linux-x86_64/bin it's still work.
thanks for the script :)


Create CODE_OF_CONDUCT.md

...based on the Free Code Camp CoC,  Required for pro features of Netlify
#17 on the baord

reviewed by community.  preparing to merge....


ITK 5.4.0 GetArrayFromImage returns None

Environment is Python 3.10 on Ubuntu. When I go back to ITK 5.3.0 GetArrayFromImage works again.

Hi, what version of Ubuntu do you have?


Add symbol subscription for use in before-trading-start

When one calls now data.current the ib_broker will subscribe to the data. This subscription process can take longer then a minute when you have several tickers and therefor the handle_data will not function properly. Can be solved by pre-subscribing to the data in before_trading_starts

=Done


Development: Add git commit to navbar version in dev mode

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[x] This is a small issue that I tested locally
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

Description

This adds a git commit id into the header, when Artemis is run in development mode.

Not displayed in the prod mode:

Steps for Testing

Start Artemis in dev mode
Have a look at the version in the header

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Branch
Line

Screenshots

I removed the additional service and moved to the already existing profile service. Thanks for the hints!
Since this PR, you can see which branch was used by just visiting the /managment/info page and it will tell you a lot of information. I think having the git commit in the header when in dev (as suggested by Stefan) is a good idea and if you want to have more information about git, you can look it up in the mentioned endpoint. And this PR also added the branch name to the startup log.

I would display the branch name immediately on dev and test systems.
The commit id should be shown in a tooltip on such systems.
On production systems, we should not show the commit as tooltip!
Instead, I suggest to show the branch and commit id in the bottom of the about page.

I would display it directly right to the version number

The branch name in the navbar:

On mobile devices and on production system, the branch name will be hidden.
And the about page:

Well, yes, this is messing up the breakpoints; if you're adding stuff to the navbar that consumes width, the calculation for the breakpoints needs to be adjusted here.

At best, I could hover over the version and a tooltip would show me commit id and branch name.

This would probably be the simplest solution for that problem
https://user-images.githubusercontent.com/23171488/192281821-38cf5bfd-f56d-494f-a0bc-e239492dd69d.mov

Thanks for the hint!
The hover style was actually the first approach.
@krusche
Should I revert it back to hover or do you want to display the information right away?

Thanks for the hint! The hover style was actually the first approach.
@krusche Should I revert it back to hover or do you want to display the information right away?

If it is too complicated to show it in the navbar directly, then I suggest to add it to the bottom of the page (branch + git commit) above or below the following footer

Of course, this should only be shown for dev and test environments
If you want to show it additionally when hovering over the version, this would be fine for me, but I'd like to see it quickly on dev and test environments without the need to move the mouse ;-)

I would change Git Commit ID: a8482b6 to simply Git commit: a8482b6


Support for PHP 7.1

Support for PHP 7.1
uses develop branch of prooph/common branch ("prooph/common" : "dev-develop as 4.0")
uses develop branch of prooph/event-store branch ("prooph/event-store" : "dev-develop as 7.0")
add snapshot namespace (moved from event-store)
add aggregate namespace (moved from event-store)
add docheader
update copyright

@codeliner finished! puh


ISPN-6225 Allow the ratio segments/shard to be configurable for the A…

…ffinityIndexManager
https://issues.jboss.org/browse/ISPN-6225
Cannot reopen the previous PR https://github.com/infinispan/infinispan/pull/4576 due to https://github.com/isaacs/github/issues/361, so creating a new one

@tristantarrant fixed

This looks fine. However it is missing some documentation as to why and how one would configure a different ratio

@tristantarrant I will include the doc in another PR, which will describe in detail all index manager available: the InfinispanIndexManager, ElasticsearchIndexManager, AffinityIndexManager and DirectoryBasedIndexManager

I'll have to trust you on that :)
Merged !


Update use of alternative text when rendering an image

First – thanks for taking the time to make this awesome library and react-markdown !!
Second – when rendering  elements the alternative text attribute is set as the first element of an array with the comment "Commonmark treats image description as children. We just want the text". Some characters (HTML entities, some punctuation, etc) can cause this text to be truncated so instead of selecting the first element I'd like to suggest using the full original string with the change in this PR.
The case for this becomes more obvious when you want to create an alternate rendering method. Consider the following samples based on an alternative image renderer component, the CaptionImage:
const CaptionImage = (props) => (

    {props.alt}

);

Before the proposed fix:

```
props.alt == "When we take the position that it is not only the programmer";
```
After the proposed fix:

```
props.alt == "When we take the position that it is not only the programmer's responsibility to produce a correct program but also to demonstrate its correctness in a convincing manner, then the above remarks have a profound influence on the programmer's activity: the object he has to produce must be usefully structured.";
```

Nice work! Thanks for a great pull request - love the effort you put into the description :+1:

Released as 4.1.4


Is there any reason not to publish this onto DefinitelyTyped?

npm @types with typescript 2.0 is really useful and I want to use this on that.
Do you think to add this into DefinitelyTyped??
If not, is there any specific reason for that?

Yeah, with introduction of @types having this unavailable in there is really inconvenient
+1

One possible blocker is that in good form an update to DT would require a bunch of tests to be brought over or created. Both this and DT seem to lack coverage.

Would be nice if AWS could fund the maintenance of this.

isnt it already there?  https://github.com/DefinitelyTyped/DefinitelyTyped/tree/types-2.0/aws-sdk

You must use is https://www.npmjs.com/package/@types/aws-sdk

If someome is able to submit a patch, it would be nice. Unfortunately, I need to maintain it in my spare time. And its not much time.

@ehartford you're comparing a 100KB file with a 5.7MB file. So I guess its not the same :)

I'm not sure if there's a need to publish a version of this to DefinitelyTyped since the typescript definitions are already included in the latest version of the AWS SDK

Yes, but last time I've checked - need to confirm, AWS had its own take on TypeScript. Need to confirm, but last time, they wrote this to me:

Thank you for reaching out. As it turns out, we have actually been working on TypeScript support in the SDK (https://github.com/aws/aws-sdk-js/tree/support/typescript), and we’re getting pretty close to shipping an initial version of the feature. Our JavaScript engineer has looked at aws-sdk-typecript before and says it has components that add value not covered by our current implementation. We’d love to spend some time to dive deeper and tease out more details about how those can be integrated into the SDK.

So you want to give it a try

this package is better than the one in DT now.  I agree this should be published to @types/aws-sdk

Can you guys make a comparison against the one AWS started to supply a few weeks ago? I must admit this project is becoming an emotional burden and I don't want to fight an uphill battle by myself.

I've been using the latest versions of the AWS SDK (without @types/aws-sdk) for about a month now and have not come across anything that's missing - so don't see any reason for continuing with this project or using @types/aws-sdk.


MISRA-C - Do not use reserved names

The C standard reserves all identifiers that begin with an underscore for implementation details. Zephyr is using underscore for identifiers and macros all over the project resulting in many violations. Bellow a suggestion to handle this:

If a function is static, it is renamed so that the leading underscore is removed
If a function isn't static, a rule based on its name is used to rename the function based on its name:

_arch_ -> z_arch_
_sys_ -> z_sys_
_k_ -> z_
_impl_ -> z_sys_impl_
_handler_ -> z_sys_handl_
Otherwise, z_
Shortcuts such as "_current", "_ready_q", "_timeout_q" and "_threads" can be changed to their respective values.

According to the C Standard, 7.1.3 [ISO/IEC 9899:2011]

All identifiers that begin with an underscore and either an uppercase letter or another underscore are always reserved for any use.
All identifiers that begin with an underscore are always reserved for use as identifiers with file scope in both the ordinary and tag name spaces.
Each macro name in any of the following subclauses (including the future library directions) is reserved for use as specified if any of its associated headers is included, unless explicitly stated otherwise.
All identifiers with external linkage (including future library directions) and errno are always reserved for use as identifiers with external linkage.

Part of #9552

impl -> z_sys_impl_
handler -> z_sys_handl_

What's the semantics of the sys in the middle?
Can we just do:
impl -> z_impl_
handler -> z_handl_

I missed the discussion earlier and was pointed here after the @pfl had already submitted.
Regarding conventions, not that both _impl and _handler are only ever applied to syscalls, which are symbols in the public headers that already have (or should have, prior to this patch) well-formed namespaced names like "k_yield()" or whatever.  I'd argue we don't need the "z" at all, and it's perfectly acceptable to do a mapping like k_yield -> impl_k_yield  (or "k_impl_yield" or "kimpl_yield", ...)
Would also generally prefer to save bytes by not stuffing underscores into the middle of a prefix, so e.g. "zarch_" and "zsys_" make more sense to me.

The original renaming list was written down by @ceolin so I'd guess it can be discussed and the scripts updated accordingly.

Shall we go for
`_impl_` -> `z_impl_`
`_handler_` -> `z_handl_`

here?

Shall we go for
`_impl_` -> `z_impl_`
`_handler_` -> `z_handl_`

here?

Works for me

+1
it seems better go with
_impl_ -> z_impl
_handler_ -> z_handl_


Realtime Calculation is not working

Hello!
I have created two roll-ups and scheduled them in realtime and using system sharing mode. My criteria is when a box is checked on the Quote, to sum up the GrandTotal on a Quote to the Opportunity but this only works when I manually click "Calculate". I thought it had something to do with the total fields but we are manually checking the accepted box and it still isn't firing. Any thoughts on this one?

Have a read of this, https://andyinthecloud.com/2016/02/13/rollups-and-cross-object-formula-fields/ especially the bit about Relationship Criteria Fields. You need to put your checkbox field in that as well basically. Good luck, happy to re-open if no joy. 👍


[bug 746795] Make the curators field in the form required.

@johngian r?

Tested it locally and field is required. Code looks ok. r+


nsc-event-android-1-52-Event-DTO

Resolves #52

Overall looks great but after testing, I noticed that the back button to the login screen has a text field overlapping it which makes it hard to click:  I also noticed that some of the data types in nestjs are type String[] but we are using String here. @theGaryLarson is this fine for now or do you want us to start implementing the String[] right away?

The following attributes need to be String arrays:

eventTags
eventSpeakers

@TroyFPV48  please make these requested changes so we can approve, thanks.

sure I will fix the String elements again!

@TroyFPV48 let's also not forget to resolve the conflicts on this so we can get it merged in.

Overall looks great but after testing, I noticed that the back button to the login screen has a text field overlapping it which makes it hard to click:

I also noticed that some of the data types in nestjs are type String[] but we are using String here. @theGaryLarson is this fine for now or do you want us to start implementing the String[] right away?
We can probably trim some of these attributes of event. @Robel-003 what were the main things that they have asked tracked. I was thinking just the basics for now. Once everything is connected and functioning it will not be too difficult to come and add in additional attributes.
The following attributes need to be String arrays:

eventTags

@TroyFPV48 please make these requested changes so we can approve, thanks.

In addition to the fields, they wanted a date, location, and an option to insert a flier or image, like an attach image button

Sorry, I wasn't cleared. Which fields specifically need attachable items?

@Robel-003 what do you think? Can we waive the attachable items on this PR and get it on the next one since this is getting to be a fairly large merge?

I have fixed the conflicts, please review this PR.

hey @TroyFPV48, it's still showing unresolved conflicts in the Event.kt and AddEvent.kt files

@TroyFPV48 helpful doc on resolving merge conflicts: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github


Use status column in config tables to handle decomissioning of stations/controllers/detectors

The config log tables have a "status" column, which seemingly indicates when a station has been decomissioned. Right now, we are not using that column in our SCD-2 tables, so our metadata tables have some devices which are not currently active.
We should use the "status" column to determine when a station is no longer active and ensure that those stations do not show up in the final tables (or are easy to filter out)

Thanks for bringing this up @ian-r-rose and I will check the status column in our new tables against what I see in the current PeMS to confirm your observation initially mentioned.

@britt-allen pending the results of @kengodleskidot's investigation, would you be able to take a look at this?

I will be able @ian-r-rose

@kengodleskidot can you share the results of your investigation, please?


Updating MS Dark Theme

The MS Dark Theme userscript appears to be be unmaintained. When I tried it, a decent number of MS UI elements were still light-themed.
I'd like to start maintaining it and updating it to be more comprehensive of the MS UI
@ArtOfCode- seems to be the maintainer, but that script doesn't appear to have been updated for several years (at least here). If it is being maintained elsewhere and I've missed it - let me know. I don't want to take it from you if you're still maintaining it
If nobody objects, I'll likely work on it soon and probably send a PR
Thoughts?

No objection here.

TODO:

[ ] Fix font colors on charts, remove "glow" effect on some charts
[ ] Ensure suitable contrast ratios on text
S
[ ] Separate logic for moving search/flagging into separate userscript
[ ] Decide on Less vs. plain CSS

@CoconutMacaroon  Please don't turn the "MS Dark Theme" userscript into a Swiss Army knife of changes which you'd like to see. Please keep it focused on doing just creation of a dark theme.
You're welcome to create an additional userscript which performs other changes. It's reasonable for us to host such a userscript in this repository, if you desire.
However, given that we have complete control of the content on MS, I suggest trying to make such changes either as integrated into MS or in a way that allows them to be integrated into MS in the future. That does, however, require trying to reconcile the multiple points of view as to why things are done the way which they are. Sometimes there are reasons. Sometimes there are diverging opinions. Sometimes the only reason is because that was the way it happened to be implemented. Reconciling such things may require creating options which user could set, or taking a more complete look at the design.
An example is your desire to move the search and flagging links back into the topbar. I agree that they should be there. However, when moving them, we should take into account the reason they were moved out in the first place. Those links were moved out because one developer found the topbar to be poorly formatted at the viewport width which they were typically using. What should really happen is that a more detailed look should be taken at the topbar to make it more fully responsive, such that it looks and functions well at all viewport widths.

@makyen Yes, I fully agree. Unfortunately, I'm not familiar with how MS was written and so making changes to MS itself isn't something I can easily do. Regarding me moving those two buttons, yes, I believe I already have a TODO in there to remove it from this script and make it into a separate userscript

BTW: Please don't use something like Less in a userscript. That introduces a dependency into every single page for something that is merely a static transformation that can, and should, happen only once.
If you feel a need to use Less/SASS/SCSS, then a better solution is to keep a separate file which is translated and then included in the main userscript file as text. I strongly recommend against having it as a separate file which generates a .css file which you then include into the page as a dependency. That can and does break from time to time. It also makes development of the userscript substantially less convenient, because you have to actively manage the hosting of the resulting file and make sure that you're loading the appropriate version (release/production vs. development). We have had userscripts which have done that in the past (FIRE) and one which still does (SDS), but have/are actively moved/moving away from doing so due to the increased aggravation in development and the intermittent failures when the chosen hosting isn't available.
Also, please try to avoid using !important in CSS, unless really necessary. In a userscript, that's usually because something in the page uses it. Using !important so prolifically appears to be something which was part of how the original script built its CSS, so I understand that doing so is likely a holdover from that. It's also possible that every use is actually necessary, due to the CSS which is in the page (I haven't checked). I'm writing this paragraph merely because I happened to see !important used in multiple places in your prototype version and its use is often a red flag.

I also note that on review pages you're removing the space between the "False Positive" and "Skip" buttons when the "NAA" button isn't present. That space exists so that the position of the "Skip" button on the page doesn't move between reviewing questions and answers. As I recall, that button not moving between questions and answers was an explicitly requested feature.

That all seems reasonable, I've switched to plain CSS in this commit and I've reverted my toolbar change. I may put it in a separate script later, but for now I've just removed it. I've also put the gap back in the Review page.
Regarding !important, yes, I've used it quite a bit. I think I can fully not need it, but at the cost of having to have much more specific selectors. I'm not against doing that, per se, but it would take more time and add more complexity to the styles, but it would mean I wouldn't need !important. I can do that if you'd like, so let me know which you'd prefer.


Implement an integration with nLog

A customer requested an integration with https://github.com/NLog/NLog

NLog - Advanced .NET, NETSTANDARD, Silverlight and Xamarin Logging

In terms of its interface and features, it should be similar to our existing integration with glog for Go: https://github.com/airbrake/glog

Implemented in PR #65, released in v4.1.0

Nice one 👍


Fixed Issue-201 by adjusting locals json files with English

These changes are not required since already merged through PRs of new UI-related tasks from JIRA. Hence closing the PR.


Refactors and adds stage-specific extraction tests to enable more targeted testing of metadata extraction pipeline improvements.

Closes #183

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.77%. Comparing base (80b31fd) to head (2d84809).
Report is 48 commits behind head on dev.

:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #184      +/-   ##
==========================================
+ Coverage   93.23%   94.77%   +1.53%
==========================================
  Files          25       26       +1
  Lines        1878     1953      +75
==========================================
+ Hits         1751     1851     +100
+ Misses        127      102      -25

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Content references have not margins in mobile (all pages)

Some examples of the problem found here:

This repository is no longer maintained. It has been superseded by IBM Quantum Learning.


incorrect chart marker display for some cases

While working with react-leaflet-v3 updates and tests, I found a bug on chart markers where some markers did not show chart or total numbers. Initially, I thought they were due to v3, but I confirmed that it happened at qa.restricted now. Here are some screenshots.
a) SCORE S. mansonni CRT study

b) SCORE Mozambique (Full screen map)

After delving into the issue, I found the reason why, so a PR will be made at web-components.

I will close this ticket as it is now resolved by merging https://github.com/VEuPathDB/web-components/pull/445

Looks good! I see numbers under charts of charts with 0 on them so this is good. Weirdly though when I first selected age group at the variable on the same study above I got a huge error, picked it again and it was fine.

@moontrip I forgot to tag you in this yesterday :)

@SAK22 No problem! I got your message via email. Thank you for your reviews and tests 👍

@SAK22 Thank you for asking. I think you were worried about the case you experienced the error when selecting age group as you mentioned. Can you please check it out again? I just tried but did not have such an error. If it will be okay, then you can close this ticket 👍

Did not get the error this time! Yay!

@SAK22 🥳 Perhaps it was a temporary glitch from backend at that time? Thank you for your confirmation! 👍


What the metadata env value do?

https://github.com/leptos-rs/start-axum/blame/0448e6dbeb6edef2ca9e83bdaf08867ebfe43ab2/Cargo.toml#L84
I can't see what is reacting to this value or when it would be set to "PROD".  Is it only read for certain deployment solutions?

Isn't it deserialized into the env field of LeptosOptions? It's purely optional but users can use that to toggle between (for example) development and production databases, depending on deployment.


Wrong Resize at PageLoad

I have noticed, that in some cases of image-sizes, vegas-plugin will not correctly resize the image at page-load. The event of the image-load plugin "imagesLoadedForVegas" is called too early - or, at least, the image-element is responding for getWidth() and getHeight() with 0.
To solve this problem, i have just implemented a kind of a wait-for-element logic inside of the initialization of the plugin.
Somewhere at line 98-100, there is the first "resize" call -> at this line, i've replaced that single line of code with the "resize" with that one:
/**
 * Wrong-Initial-Dimension-Fix
 * @author Remo Vetere
 *
 * Logical fix for initial resize operation -> if the image returns 0 on getWidth(), the resize logic
 * is screwed up -> and on this line of the code, it will always return 0. So, we simply make a wait-for-element
 * logic to resize imediately the image is successfully inserted into the dom -> a time value that is extremely
 * different, depending on the platform and the browser-engine.
 */
var waitForElement = function() {
	if ($current.width() == 0) {
		setTimeout(waitForElement, 25);
	} else {
		resize( $current, options );
	}
};
waitForElement();

could you go ahead and fork this so it easier to see exactly what you mean?

yes i will do that - the only thing is, i've never worked with git before and with github either.. but that is now a good reason to start over with that and as soon as i know enough to work with all that stuff, i will make the fork ;)

Thanks a lot rvetere.
I will merge this quickfix as soon as possible (currently no time).

Sorry i failed :D
Ignore the commit-comment before and look here:
https://github.com/rvetere/vegas/commit/420daee522f00eebb31f4343dbfc43a9608a0d90
I have still problems with my php-storm that the author here on github is still "unknown", but i have configured the global settings (twice and re-checked them) and i fill out the "author" field explicitly in the commit-dialog.
But, doesn't matter.. i hope you can see better now what i mean ;)


CRUD management for TXT record

@chinmayb @saiprasannasastry guys, any feedback ?

@chinmayb i've squashed the commits so ready for merge if you didn't spot anything else. Thanks a ton for in-depth review.

@chinmayb I've added TTL specification support during record creation https://github.com/infobloxopen/infoblox-go-client/pull/89/commits/0dd42c77df20c2c8387c84968f75ed136235d239 , please check it out

@chinmayb spotted the issue with GetTXTRecord during e2e testing, https://github.com/infobloxopen/infoblox-go-client/pull/89/commits/508141b434e53a619cc85c0a94045eb2ba0fb888 - here is the fix

@chinmayb merge ? :)


NTR negative regulation of viral RNA binding

negative regulation of viral RNA binding
standard def
is_a GO:1905215
PMID:21233210

Not sure if this is a useful annotation to have in addition to
negative regulation of RIG-I signaling pathway

NTR seems broader?

yeah....I meant to capture
ARL16 binds RIG-I
which prevents RIG1-I binding to viral RNA
to negatively regulate RIG-I signaling
but it doesn't really say that does it

Are there any MF terms that are suitable?
receptor antagonist activity ? or is that an odd choice?

Not really my field;
def of 'negative regulation of RIG-I signaling pathway"  has
'as a consequence of the cytoplasmic pattern recognition receptor (PRR) RIG-1 (also known as DDX58) binding to viral RNA" so it's implicit?

Yes you are right. Thanks!

@ValWood
just checking...do you think there is an MF term I can use here? Protein binding feels unsatisfactory (from a curator-wanting-to-make-annotations point of view  :-)  maybe it is sufficient with the BP)

ARL16 protein binding RIG-I part_of 'negative regulation of RIG-I signaling pathway
would work.
OR
GO:0098772    molecular function regulator has_direct_input RIG-I part_of 'negative regulation of RIG-I signaling pathway
maybe?
I don't think you need to capture:
"NTR negative regulation of viral RNA binding"  its really  a MF in the process ontology...
if you know that ARL16 is directly inhibiting RIG-I
https://www.ebi.ac.uk/QuickGO/term/GO:0039529
it's a given from  what RIG-1 does that you are inhibiting virus detection/binding.
Otherwise, it's a minefield:
https://www.uniprot.org/uniprot/O95786
Since it's  inhibiting the "sensor activity" (which is a MF type of binding )
It would be nice if the BP term "detection of virus"  was a "molecular function" instead
"RNA virus sensor" would say exactly what it did .....
(I strongly believe sensors should be MF terms)...but we aren't going to solve this one today....
Then you could do
GO:0098772    molecular sensor inhibitor has_direct_input RIG-I part_of 'negative regulation of RIG-I signaling pathway
Which would capture everything....
but as it is I think "binding" + "process"  is fine...

which is the "unknown" here ;)

ok, "binding" + "process" sounds good.
cheers, happy with "binding" + "process"


alarm : if we have a service instance not work ,how to alarm

Please answer these questions before submitting your issue.

Why do you submit this issue?
[ ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.

Requirement or improvement

Please describe about your requirements or improvement suggestions.

服务中要发送一个http 或者 resttemplate 请求如果 请求返回错误则触发报警，我们应该怎么做才能触发报警呢

https://github.com/apache/skywalking/blob/master/docs/en/setup/backend/backend-alarm.md

We have the instance level metrics alarm now.


Create a jupyter notebook for Mondo processing with OAK

Create a jupyter notebook (src/scripts/notebooks/mondo.ipynb with the following features:

[ ] A nice header (first cell) saying something like "code examples interacting with Mondo"
[ ] An explanation on how to install OAK (links to docs)
[ ] Code cell 1: An example of loading mondo (:obo selector) in python, not CLI (!)
[ ] Code cell 2: Traversing through all children of "tuberculosis" (look up ID on OLS) and extract the following features from each term:

[ ] Cross-species analog relation (its an annotation property, not sure how it looks in OAK)
[ ] conformsTo relation to pattern (blocked by #6806)
[ ] A list of all children
[ ] A list of all parents
[ ] The label
[ ] A list of all disease mappings

[ ] Code cell 3: print the results for a single term that exhibits all of the above (will need to search for one).

For all cells, add a few words explanatory text what we do here. Format nicely. This is for our Data Science users.
When done, assign to Sabrina to link from user docs.

@hrshdhgd this is needed for a user ideally before the end of the coming week. Let me know if you have difficulties prioritising this, we can allocate it to someone else.

What do you want the source file to be?

released MONDO
src/ontology/tmp/mondo-ingest.db in the project.

Also the current annotation properties that exist are:
<http://purl.org/spar/cito/citesAsAuthority>
<http://swrl.stanford.edu/ontologies/3.3/swrla.owl#isRuleEnabled>
<https://w3id.org/biolink/vocab/category>
<https://w3id.org/biolink/vocab/has_evidence>
IAO:0000111
IAO:0000112
IAO:0000113
IAO:0000114
IAO:0000115
IAO:0000116
IAO:0000117
IAO:0000118
IAO:0000119
IAO:0000142
IAO:0000231
IAO:0000232
IAO:0000233
IAO:0000234
IAO:0000411
IAO:0000412
IAO:0000424
IAO:0000425
IAO:0000426
IAO:0000427
IAO:0000589
IAO:0000596
IAO:0000597
IAO:0000598
IAO:0000599
IAO:0000600
IAO:0000601
IAO:0000602
IAO:0000603
IAO:0000700
IAO:0006011
IAO:0006012
IAO:0010000
IAO:0100001
MONDO:exclusionReason
OMO:0001001
OMO:0002000
RO:0001900
RO:0002175
RO:0002259
RO:0002575
RO:0002579
RO:0002581
RO:0002582
RO:0004049
RO:0004050
RO:0040042
dce:contributor
dce:coverage
dce:creator
dce:date
dce:description
dce:format
dce:identifier
dce:language
dce:publisher
dce:relation
dce:rights
dce:source
dce:subject
dce:title
dce:type
dct:contributor
dct:creator
dct:description
dct:isVersionOf
dct:license
dct:source
dct:title
foaf:homepage
obo:ro/subsets#ro-eco
obo:valid_for_go_annotation_extension
obo:valid_for_go_gp2term
obo:valid_for_go_ontology
obo:valid_for_gocam
oio:SubsetProperty
oio:consider
oio:created_by
oio:creation_date
oio:date
oio:default-namespace
oio:hasBroadSynonym
oio:hasDbXref
oio:hasExactSynonym
oio:hasNarrowSynonym
oio:hasOBOFormatVersion
oio:hasRelatedSynonym
oio:hasSynonymType
oio:id
oio:inSubset
oio:saved-by
oio:source
owl:deprecated
protege:defaultLanguage
rdfs:comment
rdfs:label
rdfs:seeAlso
skos:broadMatch
skos:closeMatch
skos:exactMatch
skos:narrowMatch
skos:relatedMatch

oops! didn't mean to close this :)

@twhetzel given the time-sensitive nature of this, I am reassigning this to you now; @hrshdhgd has made a start in the linked PR. This is regarding the meeting you and me were in earlier this week!

https://incatools.github.io/ontology-access-kit/packages/interfaces/basic.html#oaklib.interfaces.basic_ontology_interface.BasicOntologyInterface.ontology_metadata_map

oaklib command: term-metadata

@matentzn For "An example of loading mondo (:obo selector) in python, not CLI (!)" - do you mean load Mondo as: !runoak --input sqlite:obo:mondo?

I meant proper python, like "from oaklib import get_descendants" (this is just a guess". Runoak is what I mean by "CLI".

What are the expectations on how a user will get and create a ".db" version of mondo? Will they need to clone the mondo repo and run make commands? And do these commands need to be in the notebook?
Also, should the last released version of mondo be the source file?

@matentzn I pushed an update for WIP.
Questions for the requirements for this demo notebook:

For ancestors and descendants, is the intent this is simply the call of ancestors and descendants for a curie of interest, e.g. adapter.descendants([curie], predicates=[IS_A])?

Can this call be limited to IS_A for now with a note the user can add in additional predicates if interested?

Are the only annotations and relations on each curie to include:

curie
label
cross-species analog relation
conformsTo relation
dbxrefs (disease mappings)

For ancestors and descendants, is the intent this is simply the call of ancestors and descendants for a curie of interest, e.g. adapter.descendants([curie], predicates=[IS_A])?

Yes, good enough! Thank you!

Are the only annotations and relations on each curie to include:

Sounds good for a first draft! Thank you!


.

This package contains no exported methods! How am I suppose to use this garbage?! Who names a package "main".
0/7.

.


ActorRef Registry

I am starting to explore an implementation of a registry for XState-based actor systems. This is still very much in the exploration phase and will evolve once we start to gather feedback in the XState community.
Related work:

Elixir: https://hexdocs.pm/elixir/Registry.html
Akka: ??? Have not dived into it yet.
IoC containers (kinda similar): Inversify, Dotnet, Spring, etc.
Other?

Features / Use-Cases that should be supported by an implementation (uncertainty is marked with ???):

[ ] Registry should be an ActorRef itself
[ ] Register a existing ActorRef in the registry
[ ] Receive an ActorRef from the registry for a given ID
[ ] Spawn Behavior and StateMachine definitions directly with the registry as their parent

[ ] Pass the registry to their factories (Passing via context would require XState core support)

[ ] (???) Query the children of stored references for a given ID if it is not found in the direct references (walk the actor hierarchy)
[ ] (???) Broadcast an event to all references, which contains an example in the Elixir docs. Necessary when an event bus exists?
[ ] (???) Isomorphic Actors: Spawn actors from Web-Workers and sync the registry (and calls to references) with a wrapper in the worker

[ ] (???) Same but for other contexts as well (iFrame, WebSocket, ...)

We might be able to achieve greater integration of a registry concept in XSystem if we deviate from XState and its current actor spawning implementations. For example, we could provide a spawn function that accepts a registry as an option or a registry factory that returns bound spawn and query functions - using an API similar to Stitches^1.
Our custom implementation would focus on Behavior, ActorRef, and spawning behaviors (machines are considered behavior), while trying to remain compatible with the original interfaces, i.e. only extending them.
Using custom implementations for spawning behavior would further allow us to look into error handling and supervision trees, which are greatly inspired by Elixir's supervisors^2 and the OTP.

XState v5 will introduce system receptionist. Therefore, this issue can be closed


jitting a module with segment sums

Hello; I am new to equinox and the jax ecosystem, so apologies if this is a trivial question, but I am having some difficulty in sorting it out:
I have written an eqx.Module and would like to use jit in its training; the problem is the module has several spots where ops.segment_sum are used. According to jax documentation this is ok, provided one can make the num_segments argument to segment_sum static (by which I interpret constant throughout all samples in the dataset). I have done this by constructing batches of samples in such a way that the num_segments argument is indeed the same for every batch. However, when decorating my training step function with @eqx.filter_jit it is slower than not jitting at all, and I suspect that this is because jit is recompiling every time because it is assuming that num_segments changes from batch to batch, when it does not.
I guess I need to declare those num_segment values as static somewhere, perhaps as an option to @eqx.filter_jit, but I have not found how to do it; can someone point me in the right direction? Thanks!
And while I am at it: is there a way to confirm that jit is recompiling at every step? At present this is my impression (I was expecting my jitted code to be much faster than the unjitted), but I am not 100% sure.
Thank you in advance for any hints received!

Welcome to JAX and Equinox! :)
You can check recompilations using eqx.debug.assert_max_traces.. This will also give you which argument caused recompilations.
Note that recompilation is triggered by passing new static arguments (non-arrays) through eqx.filter_jit, or by changing the shape/dtype of the arrays passed to eqx.filter_jit. It is not triggered by changes in segment_sum. Instead, if a traced (non-static) argument is passed to segment_sum then it should simply raise an error during compilation.
As such you should be able to isolate the cause of recompilations solely by checking what is passed across the JIT boundary :) (e.g. using eqx.debug.assert_max_traces or by any other means)
I hope that helps!

Thanks for your response. By reading more thoroughly your excellent documentation I had found out about eqz.debug.assert_max_traces, so I can confirm that indeed there were recompilations happening, and I assumed this was due to the segment_sums in my model because jax documentation says that to jit a segment_sum one must ensure that the num_segments does not change; so I have been chasing a red herring? It surprises me that the suspects are passing new static arguments or changing shapes/dtypes, as you suggest, but I will make sure of this. Thanks again!

Sorry! Me again!
When you say "Note that recompilation is triggered by passing new static arguments (non-arrays) through eqx.filter_jit", do I interpret this correctly to mean that the arguments have to be arrays? A dict is not allowed? I am certainly passing a number of book-keeping arrays, but bundled up in a dictionary; the sizes and shapes of those book keeping arrays are the same from sample to sample, but their values inevitably change. But that shouldn't trigger recompilation, should it?

Hi Eduardo, Hi Patrick,
a dictionary with arrays is a PyTree of Arrays, this should not be a problem. However, it is important that the numbers in your dictionary are actually wrapped in arrays, like so:
import equinox as eqx
import jax.numpy as jnp
from jaxtyping import Array, PyTree

@eqx.filter_jit
@eqx.debug.assert_max_traces(max_traces=1)
def some_function(x: Array, book: PyTree[Array]) -> tuple[Array, PyTree[Array]]:
    y = 2 * x
    book['a'] += 1
    return y, book

x = jnp.linspace(0, 1, 10)

dict_of_arrays = {'a': jnp.array(1), 'b': jnp.array(2)}
dict_of_numbers = {'a': 1, 'b': 2}

for _ in range(2):
    y, dict_of_arrays = some_function(x, dict_of_arrays)

for _ in range(2):
    y, dict_of_numbers = some_function(x, dict_of_numbers)
``

Note that passing a dictionary of numbers will trigger recompilation.

Thank you @johannahaffner for your feedback. Indeed at least one of the items in my dict of indices was itself a dict of numbers; I was not aware that this would trigger recompilation, so I have changed following your remarks. I think I am closing in on the solution thanks to your and @patrick-kidger's comments, but my problem still persists; I need to try a little harder.
Specifically, my application is a graph neural network, and more specifically a graph regression. I batch my graphs together so that all the batches have exactly the same total number of nodes and the same total number of edges (I did this thinking it would help with segment_sums, although according to @patrick-kidger this is not the issue). However there remain other book-keeping indices, to track which node sends messages to which other nodes (an same for edges) that cannot easily be made of the same size, as these depend on each graph's particular pattern of connections. I suspect the problem may lie here. Could this be it?
Thanks again to you both for your helpful comments.

That sounds like it could be it!
Can you work with padded arrays? This means adding zeros to your arrays, such that they all have the same shape. For your graphs, you could cast them all to the same shape by adding unconnected nodes.

This I did already (padding with zeros) with the node and edge features so as to make sure that each batch (a graph composed of multiple graphs) had the same total number of nodes and edges; I am not sure if I can do the same with the book-keeping indices, but I will give it a good try. Thank you so much!

I'm sure there's a way around it, though.

Great!


Cannot clone recursive

When trying to clone the repository, I get several errors similar to this one:
Cloning into '/tmp/gb-hardware/GB-BRK-LINK-B/external/kicad-symbols'...
fatal: remote error:
  Gekkio/gb-hardware.git/external/kicad-symbols is not a valid repository name
  Email<EMAIL_ADDRESS>for help
fatal: clone of 'git@github.com:Gekkio/gb-hardware.git/external/kicad-symbols' into submodule path '/tmp/gb-hardware/GB-BRK-LINK-B/external/kicad-symbols' failed

I think the urls for the subrepos might be broken.

This was caused by me trying to be too clever with submodules...I've reverted that change so now every project has submodules with proper git repository URLs instead of a relative paths. The downside is that the full repository takes a long time to clone and takes a lot of disk space because of duplicate submodules. :crying_cat_face:


Change align_corners to True in position encoding interpolation

In current implementation, we have align_corners=False, which according to this post this will led position encoding at the edge be value padded(have the same value as the endpoint of source values, the original PE) and behave differently compared to patches at the center.
We therefore suggest changing to align_corners=True to avoid the difference between PE at the edge v.s. others.

image credit: Lucas Beyer

In our experiments, a strange position encoding emerged which we believe originates from the interpolation (resizing) of position encodings. Has anyone observed similar behavior?

During training, gradients from both local crops (at shape 96x96) and global crops (224x224) contribute to the formation of the learned position encodings. Downsizing the position encoding tensor from 224x244 to 96x96 (global to local crop sizes) results in gradient distributions like this during backprop (assuming constant gradient image):

Aligning corners appears to only make a small difference. What would really result in homogenously distributed gradients from local and global crops would be anti-aliasing according to this image:

Note: I previously used DINO v1, and just saw, that in DINOv2 this is actually a parameter:
https://github.com/facebookresearch/dinov2/blob/main/dinov2/models/vision_transformer.py#L66

In addition to the comment of @maxrohleder, I would like to share the result of an additional experiment, which we have conducted to investigate the influence of different parameter settings in torch.nn.functional.interpolate().

        mode=bicubic, antialias=False, align_corners=False

        mode=bicubic, antialias=True, align_corners=False

The figure on the right shows that using antialias=True produces a learned position encoding without a checkerboard pattern, unlike the initial case with antialias set to False. Additionally, the PCA reduced features show how the model nicely captures different spatial directions in the encoding (e.g., from left to right or from top to bottom).
We believe this behavior is caused by the smoother gradient backpropagating of nn.functional.interpolate(antialias=True) compared to nn.functional.interpolate(antialias=False) (see comment https://github.com/facebookresearch/dinov2/issues/468#issuecomment-2488820722). We would really appreciate it if you could briefly verify our solution and explain if self.interpolate_antialias in DINOv2 (commit https://github.com/facebookresearch/dinov2/commit/9c7e3245797cf7be5b5729445a4af1272bd610df) was introduced for the same reason.


numbers in the population table is wrong

solved by https://github.com/ReMobidyc/ReMobidyc/pull/190


Make html and escape modules optional

This PR introduces a new enabled-by-default-feature html. If this feature is enabled, there are no functional differences. If it is disabled, the html and escape modules are not compiled. This is helpful, if a dependent crate does not require any HTML rendering.
Note, that this will break user crates, that use --no-default-features and also use one of the two modules in question. Therefore I understand, if this PR cannot be merged.
Note, that some tests and examples need new annotations, as they require the html module.

Thank you for your thoughtful PR. I am sympathetic to this change, but would like one more pair of eyes on this before I merge.
@raphlinus: does this look a good idea to you as well?

Hmm, I have mixed feelings about it. I certainly understand the desire to keep compile times down and avoid bloat, but these modules don't strike me as especially heavy. The experience with default features is that they're almost always left on, and are somewhat inconvenient to control.
Do we have any kind of quantitative measurement about how much compile time is saved here?

I understand the mixed feelings :wink:
I've run some measurements with hyperfine on my laptop (crates were all downloaded):

That's a nontrivial improvement. I'm ok with this change. If the time delta had been much smaller I would have said it's not worth it. Thanks for the PR and measurements :)

Oh, I've noticed something:
I think the previous comparison was not 100% fair, as there is another additional crate built (getopts) when default features are active.
Here is a better benchmark, which shows the real difference:

I would caution against making a breaking change like this.  There are a number of projects that use default-features=false (like rustdoc, clippy, etc.).
Also, to me, 0.7 seconds does not seem worth a change.

Is there anything to do here? Should this PR be closed or left open until a decision is reached?

This makes a lot of sense to me, and having an HTML renderer in a parser crate was a bit shocking the first time I checked the project. I think that both features should be in different crates, but keeping the current minimal functionality as optional features can make sense for tests.
All implications must be carefully reviewed though, so I will be back on this relatively soon.
Related to #526.

This pull request is interesting for the 0.10 release, merged


Remove useless and error-ing call to pkg-config --pclibdir

The rationale behind this removal is the following:

--pclibdir is a non-existent flag of pkg-config, resulting in a not 0 exit code (I can't find a reference to this --pclibdir existing ever, except for this line in this repo)

Due to how the Bash code is written, the fail is not passed to the calling script (build.sh). Infact export MYVAR=$(error-now) will always be true.  If the line is rewritten as MYVAR=$(error-now); export MYVAR the call will fail.
Infact changing this line to PKG_CONFIG_LIBDIR=$("${USED_BUILD_PREFIX}"/bin/pkg-config --pclibdir); export PKG_CONFIG_LIBDIR will fail exactly with --pclibdir unknown option.
For more details on this see the following: https://github.com/koalaman/shellcheck/wiki/SC2155

Effectively this line does nothing and an error is exposed when it is rewritten following best-practices.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

To add a bit more context to this, in my current company we have a fork of this package and while running sheellcheck on the build.sh script the error about the dangerous use of export VAR=$(error-now) was reported. Upon fixing it to VAR=$(error-now);export VAR the build started failing because of --pclibdir.
Having it the way it is now it does not change any behavior, but to me it looks like code that has no purpose. It is definitely possible I am missing something there, so don't take my word for granted.

Yep, let's close it.
@crisbal, if you still need this, please submit it to the qt-main feedstock. And sorry for not taking your work into account before but the team was focused on updating Qt to 5.15.


Slow 1D BarCode scanning

I'm testing 1D barcode scanning on a Moto G 1st gen. I need the users of my application to be able to scan barcodes on products.
I find 1D BarCode scanning pretty slow. In particular, it seems the cellphone must be "put in parallel to the barcode" in order to recognize it efficiently. This is not always easy considering the variety of products packages on the market and the possible position of the barcode on those.
I guess this is not caused by the low-end (Moto G)camera specifications, because the BarCode Scanner from ZXing is somewhat more efficient recognizing barcodes in the same cellphone.
I'm already limiting the accepted barcodes formats to only what i need, in order to accelerate decoding. Also, i'm using setAutoFocusEnabled(true).
What are the best advices to optimize 1D barcode recongition?

Some of what you describe is expected. In general, nearly every barcode API only detects barcodes that are aligned near some multiple of 90 degrees. However, it's surprising that you get results faster with ZXing.
Which barcode formats are you trying to read, and how much of a latency difference between our API and ZXing are you seeing?
It would also be helpful to see an example image that exhibits the problem.

1D barcode scanning is very slow


LLVMCpuVectorization Fails with mixed FP-Int types for linalg.conv_1d_nwc_wcf

Error thrown:
/usr/local/google/home/suderman/Repos/jax/tests/lax_test.py:308:33: error: 'arith.extf' op operand #0 must be floating-point-like, but got 'vector<1x2x3xi8>'
    result_with_preferred_type = lax.conv(
                                ^
/usr/local/google/home/suderman/Repos/jax/tests/lax_test.py:308:33: note: see current operation: %42 = "arith.extf"(%39) : (vector<1x2x3xi8>) -> vector<1x2x3xf32>
/usr/local/google/home/suderman/Repos/jax/tests/lax_test.py:308:33: error: failed to run translation of source executable to target executable for backend #hal.executable.target<"llvm-cpu", "embedded-elf-x86_64", {cpu = "generic", cpu_features = "", data_layout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128", native_vector_size = 16 : index, target_triple = "x86_64-unknown-unknown-eabi-elf", ukernels = false}>

IR Pre Failure:
https://gist.github.com/rsuderman/1c653690081a1514ee9a98704abc4e65
Input StableHLO:
module @jit_conv_general_dilated attributes {mhlo.num_partitions = 1 : i32, mhlo.num_replicas = 1 : i32} {
  func.func public @main(%arg0: tensor<2x3x9x10xi8> {mhlo.sharding = "{replicated}"}, %arg1: tensor<2x3x4x5xi8> {mhlo.sharding = "{replicated}"}) -> tensor<2x2x6x6xf32> {
    %0 = stablehlo.convolution(%arg0, %arg1) dim_numbers = [b, f, 0, 1]x[o, i, 0, 1]->[b, f, 0, 1], window = {stride = [1, 1], pad = [[0, 0], [0, 0]], lhs_dilate = [1, 1], rhs_dilate = [1, 1], reverse = [0, 0]} {batch_group_count = 1 : i64, feature_group_count = 1 : i64, precision_config = [#stablehlo<precision DEFAULT>, #stablehlo<precision DEFAULT>]} : (tensor<2x3x9x10xi8>, tensor<2x3x4x5xi8>) -> tensor<2x2x6x6xf32>
    return %0 : tensor<2x2x6x6xf32>
  }
}

Just taking a quick look. Is this operation valid?
%17 = linalg.conv_1d_nwc_wcf {dilations = dense<1> : vector<1xi64>, strides = dense<1> : vector<1xi64>} ins(%extracted_slice_3, %extracted_slice_4 : tensor<1x2x3xi8>, tensor<1x3x2xi8>) outs(%extracted_slice_5 : tensor<1x2x2xf32>) -> tensor<1x2x2xf32>

It has i8 inputs and an f32 output so what are the semantics? Every multiplication should be de-quantized to f32 before the accumulation? There isn't too much information in the op doc that makes me think this convolution flavor is supported.

Wouldn't we want to dequantize within the loop body as it decreases the number of bytes that need to be loaded?

Yeah, if I get it correctly, we should load i8s, convert it to f32 and then multiply and accumulate. The current lowering is only trying to "extf" i8 to f32, which is not correct.

Yup. Phab review is uploaded now: https://reviews.llvm.org/D152982

I verified that it is fixed.


Client Allocation Request for: Speedium

Client Allocation Questions
Core Information

Name: Speedium
Website / Social Media: www.speedium.network
Region: Europe
DataCap Requested: 10TiB
Addresses to be Notarized: f3vuq53z65cgyty7polrwyqyqios6qbjrkxihipvrzlg3yzocnd4najuso3y26nm22pqimadur6fyt6bqqt3xa
Notary Requested: NeoGe-IPFSMain

on request of @neogeweb3

Can you introduce yourself? Where can I find you online? (Github, Twitter, Linkedin handle, Wechat, etc.)

We are Speedium ( www.speedium.network ). Speedium is an active usenet company and has been engaged with blockchain technology since day one. We are extremely interested in all sorts of decentralized storage and have been experimenting with multiple blockchain storage projects since 2019. Since the launch of Filecoin we have been participating in Testnet, Spacerace 1, Spacerace 2 and Mainnet. We have been expanding our calculating power with a setup containing more than 25 units for PC2 and 5 units for PC1 being able to seal more than 10 TiB daily on full throttle. At this moment we are storing our populair cache data of Usenet on to the Filecoin Network, so this can be retrieved by our endusers without intervention of Speedium itself in the near future, directly from their software like SABnzbD.
My GitHub handle actively participating is cryptowhizzard.

If you represent an organization, what is the name, nature, registration country, time since inception, and named officers of your organization?

We represent Speedium BV and are registred in the Netherlands.
https://www.kvk.nl/orderstraat/product-kiezen/?kvknummer=759796320000  (For our Chamber of commerce information)

In which region(s) do you intend to use the DataCap?

Europe

What is your use case for the DataCap being requested?

At this moment we are storing our populair cache data of Usenet on to the Filecoin Network, so this can be retrieved by our endusers without intervention of Speedium itself in the near future, directly from their software like SABnzbD.

Do you plan to specify advanced features when utilizing a DataCap in your storage deal? If so, please specify the feature.

The data needs to be fast-retrievable.

How many miners do you plan on allocating the DataCap? If you have a specific miner(s) you would like to allocate a DataCap, please specify.

5 miners:
f02576 (BenjaminH)
f022352 (Reiers)
f023467 (Phrijan)
f010446 (Angelo)
f010479 (Sonic)

Do you agree on providing transparency of DataCap allocation decisions & execution details in public to prevent excessive/unfair self-dealing?

We always do. The statistics of who we send deals to are available at : https://dcentnetworks.nl/deals.php
We have always been storing N+1 where we store one copy on our own miner and the rest randomly distributed.
If there is a community decision that this needs to change we are open to move to N+2 or even N+3 but this will increase datacap needs.

You can find our active history in issue #31

Hey @cryptowhizzard, thanks for the request. you could take a look at my allocation strategy  and flow which shows how I utilize the assessment. My allocation strategy is to build trust progressively. So I could allocate 100 GiB to you for the first time. Feel free to request more DataCap when you use up the allocation.

Request Approved
Your Datacap Allocation Request has been approved by the Notary
Message sent to Filecoin Network

bafy2bzacedbar2gccpqprv7mkpmwhdf3pm37typw7fw6xbop25nswpm3o22u4

Address

f3vuq53z65cgyty7polrwyqyqios6qbjrkxihipvrzlg3yzocnd4najuso3y26nm22pqimadur6fyt6bqqt3xa

Datacap Allocated

100GiB

You can check the status of the message here: https://filfox.info/en/message/bafy2bzacedbar2gccpqprv7mkpmwhdf3pm37typw7fw6xbop25nswpm3o22u4

This user’s identity has been verified through filplus.storage


Adding missing description of the new runtime field in router check config

Signed-off-by: Jyoti Mahapatra<EMAIL_ADDRESS>For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Correcting documentation of router check tookl
Risk Level: Low

@mattklein123 I missed adding a piece of documentation in the previous PR and had some typos.


Bug: Inserting only specific columns does not work on SQLite

This problem is present on SQLite, all the tries work on MS SQL Server
Here and here are shown samples of how to execute .Insert/.InsertAsync specifying data for some columns only, using the fields parameter.
I tried to use this feature providing all the columns info but the Id (in order to let the db generate it) but it does not work: every time I specify the fields parameter I get the following exception:

"The non-identity primary field must be present during insert operation."

If I provide the Id the .Insert/.InsertAsync doesn't fail but the Id is not generated by the DB, it keeps the provided value, also accepting 0 as a valid Id.
The only version that correctly lets the DB generate the Id is the hard-coded INSERT INTO <table> (<columns>) VALUES (<values>), which also returns the correct generated Id.
This is my sample:

RepoDb (1.12.0-beta3)
RepoDb.SqLite (1.1.0-beta1)

Just copy this code in the Program.cs of a .NET Core 3.1 Console App

Source Code
using System;
using System.Data.SQLite;
using System.Threading.Tasks;
using RepoDb;

namespace RPT.UI.WinConsole2
{
	static class Program
	{
		static async Task Main(string[] args)
		{
			SqLiteBootstrap.Initialize();

			var conn = new SQLiteConnection(@"Data Source=:memory:;Version=3;");
			await conn.OpenAsync();
			await conn.ExecuteNonQueryAsync(CreateDatabaseScripts.EnsurePersonTable);

			var person = new Person { Name = "Cal", Surname = "Crutchlow" };
			var addedFields = Field.Parse<Person>(x => new
			{
				x.Name,
				x.Surname
			});
			var insertPersonSql = $"insert into [{nameof(Person)}] " +
				$"(" +
				$"  [{nameof(Person.Name)}]" +
				$", [{nameof(Person.Surname)}]" +
				$") values (" +
				$"  '{person.Name}'" +
				$", '{person.Surname}'" +
				$")";

			person.Name += "_2";
			uint id;
			ushort i = 1;

			var affectedRows = await conn.ExecuteNonQueryAsync(insertPersonSql).TryCatch(i++);
			// works, inserts correct data, db generates Id

			var dynamicPerson_no_Id = new { Name = "Cal", Surname = "Crutchlow" };
			id = await conn.InsertAsync<dynamic, uint>(nameof(Person), entity: dynamicPerson_no_Id).TryCatch(i++);
			// {"The non-identity primary field must be present during insert operation."}

			var dynamicPerson_with_Id = new { Id = 13, Name = "Jack", Surname = "Brown" };
			id = await conn.InsertAsync<dynamic, uint>(nameof(Person), entity: dynamicPerson_with_Id).TryCatch(i++);
			// works, inserts the Id into the dynamic, returns correct Id, but it is the provided Id, it is not generated by the DB

			dynamicPerson_with_Id = new { Id = 17, Name = "Bruce", Surname = "Wayne" };
			id = await conn.InsertAsync<dynamic, uint>(nameof(Person), entity: dynamicPerson_with_Id, fields: addedFields).TryCatch(i++);
			// {"The non-identity primary field must be present during insert operation."}

			person.Id = 0;
			id = await conn.InsertAsync<Person, uint>(nameof(Person), entity: person).TryCatch(i++);
			// inserts Id = 0, returns correct inserted Id

			person.Id = 37;
			id = await conn.InsertAsync<Person, uint>(entity: person).TryCatch(i++);
			// inserts id = 37, returns correct inserted Id

			id = await conn.InsertAsync<dynamic, uint>(nameof(Person), entity: dynamicPerson_no_Id, fields: addedFields).TryCatch(i++);
			// {"The non-identity primary field must be present during insert operation."}

			id = await conn.InsertAsync<uint>(nameof(Person), entity: dynamicPerson_no_Id, fields: addedFields).TryCatch(i++);
			// {"The non-identity primary field must be present during insert operation."}

			id = await conn.InsertAsync<Person, uint>(nameof(Person), entity: person, fields: addedFields).TryCatch(i++);
			// {"The non-identity primary field must be present during insert operation."}

			id = await conn.InsertAsync<Person, uint>(person, fields: addedFields).TryCatch(i++);
			// {"The non-identity primary field must be present during insert operation."}

			Console.ReadLine();
		}
	}

	public class Person
	{
		public uint Id { get; set; }
		public string Name { get; set; }
		public string Surname { get; set; }
	}

	public static class CreateDatabaseScripts
	{
		public static string EnsurePersonTable = $"create table if not exists [{nameof(Person)}] (" +
			string.Join(",",
				$"[{nameof(Person.Id)}] integer primary key",
				$"[{nameof(Person.Name)}] text not null",
				$"[{nameof(Person.Surname)}] text not null") +
			$");";
	}

	public static class TaskMixins
	{
		public static async Task TryCatch(this Task task, ushort i)
		{
			Console.WriteLine($"#{i++}");

			try
			{
				await task;
			}
			catch (Exception ex)
			{
				Console.WriteLine(ex.Message);
			}
			finally
			{
				Console.WriteLine("-----------------------");
			}
		}

		public static async Task<T> TryCatch<T>(this Task<T> task, ushort i)
		{
			Console.WriteLine($"#{i++}");

			try
			{
				return await task;
			}
			catch (Exception ex)
			{
				Console.WriteLine(ex.Message);
			}
			finally
			{
				Console.WriteLine("-----------------------");
			}

			return default;
		}
	}
}

@snalesso - would you be able to share your table schema (the CREATE TABLE statement)? We are happy to give you feedback very soon about this issue.

SQLite3 DB schema is included in the source code I provided. To speed up here it is:
public static class CreateDatabaseScripts
{
	public static string EnsurePersonTable = $"create table if not exists [{nameof(Person)}] (" +
		string.Join(",",
			$"[{nameof(Person.Id)}] integer primary key",
			$"[{nameof(Person.Name)}] text not null",
			$"[{nameof(Person.Surname)}] text not null") +
		$");";
}

which translates into:
create table if not exists [Person]
(
	[Id] integer primary key,
	[Name] text not null,
	[Surname] text not null
)

It seems the ID column is not an identity column? Can you create a table like this.
create table if not exists [Person]
(
	[Id] integer primary key autoincrement,
	[Name] text not null,
	[Surname] text not null
)

Auto-increment makes your table generate a new identity value everytime you insert a new row to it.

The non-identity primary field must be present during insert operation.

This is a customized exception in the Statement Builder. It tries to ensure that you should provide a value to the non-identity primary key.

Actually it is. SQLite3 will always treat INT PRIMARY KEY as identity column, auto-generating the Id.
When you specify AUTOINCREMENT you tell SQLite3 that new Id's must not reuse old removed Ids, so there's always a progression.
This adds CPU work because the DB checks the highest value at each Id generation, also when the max INT value is reached no more Ids can be generated even though there are values not in use.
For reference: official AUTOINCREMENT documentation

@snalesso - Cool, never thought the item 3 in the link you provided. Thank you for leading us there. Then this as a bug!
The IDbHelper object of RepoDb.SqLite is using the AUTOINCREMENT keyword as an identification for the identity, which I think we can simply be replaced or modified by adding an additional 'OR' condition for the PRIMARY KEY / INTEGER. See this code line.
Anyway, I will fix this on the next upcoming release. But if you are adventurous enough, you can advancely test it by simply injecting your own DbHelper.
Follow these steps:

Copy the entire class from here and place it on your project solution. Maybe name it CustomSqLiteDbHelper.
Replace the AUTOINCREMENT with PRIMARY KEY. Note: Ignore the data type for now, just for your own use-case.
Then, simply inject your customized database helper class like below. Ensure to call it after the RepoDb.SqLiteBootstrap.Initialize().

DbHelperMapper.Add(typeof(SQLiteConnection), new CustomSqLiteDbHelper(), true);

Did a fast test but it solved only partially: now it recognizes that the identity/primary was provided but it inserts the data into the DB only if:
Id is provided AND if fields are passed they contain Id
also, Id = 0 is accepted

It seems not properly parsed. I will issue you a new beta release for this. When do you need the fix?

I have no hurry, I'm more focused on the app structure for the moment (which is still far from release) and I can use MSSQLS for now since the DB schema is still simple.
But for sure I will use SQLite as final engine.

I am yet to verify whether this last_insert_rowid() call is the correct call. It seems to be not working as expected for INTEGER PRIMARY KEY.

It is

LOL. I am into other issue now, but thanks @snalesso for the research. I will do create Integration Tests later. I maybe can give you the beta by Saturday (or even before that).

Spent my time on this and it seems it is not working as expected. And/or the last_insert_rowid() may not be the correct function. I could not think of anything else for now, it seems to be an invalid behavior from SQLite. Or else, maybe you can help identify by simply cloning the project and running the Integration Tests.
On this line, I would expect that the last_insert_rowid() would return 3, but it is returning 11. Below is the overview of that Integration Test.

Create 10 SdsCompleteTable models (with Id 1-10).
InsertAll the 10 models.
Check the count equality of created rows (10).
Delete the 3rd row (with Id = 3).
Check the count equality after deletion (9).
Create 1 SdsCompleteTable model (with Id 1).
Insert the newly created model (with all fields except the "Id").
Assert the result of the insert, expecting 3, but the result is 11.

Here is the model, and here is the table creation script.

The database fields returned is also correct based on the new logic implied INTEGER PRIMARY KEY and/or AUTOINCREMENT.
var dbFields = DbFieldCache.Get(connection, ClassMappedNameCache.Get<SdsCompleteTable>(), null);

It even says true.

The RepoDb.SqLite v1.1.0-beta2 is now available with the recent fixes in relation to INTEGER PRIMARY KEY.

Closing this ticket now. Please feel free to revisit if you still have problems. Thanks


boards native_sim: Deprecate CONFIG_NATIVE_APPLICATION & CONFIG_NATIVE_SIM_NATIVE_POSIX_COMPAT

boards native: Deprecate CONFIG_NATIVE_APPLICATION

This option is used in tree only by native_posix, which is deprecated
and being replaced by native_sim. But may be used also in out of tree
targets.
As part of the native_posix deprecation, and therefore the lack of
testing this feature would have in the future, we are also deprecating
this option.

boards native_sim: Deprecate CONFIG_NATIVE_SIM_NATIVE_POSIX_COMPAT

This option existed only to make the transition from native_posix to
native_sim easier. As native_posix is going to be removed in v4.2
we deprecate this option now, so it will also be removed.

We also switch this option to default to false already now.

& add to release notes and migration guide

3 new pushes since last:

removed default kconfig as requested by @rugeGerritsen
rebase on top of main without changes
added a link in the migration guide with an example of how to convert a board from being based on NATIVE_APPLICATION to NATIVE_LIBRARY


Unused variable cleanup and new overmask px default

Default overmask px now 20px as discussed in #125. This pull will also include inpainting model detection and offer to change on first boot, also from #125.
Will probably add tool settings persistence as well at some point. Not necessarily in this pull, but maybe the next.

Fucked up the branch, will fix tomorrow.

Fixed branch, give it a look and merge if applicable! (LMB now also works for pan)
@zero01101 if you could test if it is at least useable using a MacBook touchpad!

Supposedly should work better for touchpad users in general now, and should mostly resolve #116

confirmed significantly better on macbook touchpad :) ctrl (NOT CMD) + two-finger-vertical swipe zooms beautifully, and ctrl+left-click-drag pans very nicely

Will merge this pull then for now!


[NEW ICON] Skill Name

Skill Name
Vuetify
Why?
UI framework
Reference Image
No response

Added in e67133b!


programatic resizing of grid item causes collision detection to reorder items

https://plnkr.co/edit/ou5UhYLKJUQ8d5M0ju27?p=info
If you resize an item such that it causes multiple collisions, the order of the widgets returned by the collision detection keeps reversing.  In the example plunk, if you click makeBig on item 1, then items 2,3,4 get reordered as 4,3,2.
Suggest revising _getCollisions() to return
returns.reverse()
instead of
returns

Also, in the same plunk, if you just drag item 1 to the right a little, and release, it will reorder 2,3,1,4 even though there should not have been any collisions detected.

We are also experiencing this and its preventing us to do a release atm. I will have a look if I can find the reason, but I can already say that returns.reverse() wont fix the issue. It works if there is only 1 column, but already with 2 columns it won't help and it almost seems like the items are getting randomly moved. In our application it works for some reason if I change the getCollisions to always return empty array. So there is definitely something wrong.

Actually our problem was different. The fault in our case was accidental resetting of the grid settings :).


[ENH/DOC] Support multi-column inputing, change_type

PR Description
Please describe the changes proposed in the pull request:
col could receive a single column or multi-column.
But currently, the documentation of change_type only shows supporting a single column.
df[col] = df[col].astype(dtype)

PR Checklist

Please ensure that you have done the following:

[x] PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.

[x] If you're not on the contributors list, add yourself to AUTHORS.md.

[x] Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.

Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks
There will be automatic checks run on the PR. These include:

Building a preview of the docs on Netlify
Automatically linting the code
Making sure the code is documented
Making sure that all tests are passed
Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

When all tests pass, I will hit the merge button :smile:.


Linux support

It would be useful to support Linux, now that ovr-platform-util is available on that platform.
We use a Linux runner with a Unity game-ci builder, as it's easier to have it automatically install the required Android SDK 32.

Meta does not have a Linux binary for this.

it's easier to have it automatically install the required Android SDK 32.

My unity-setup action does the same thing but without the docker container which makes it easier to build il2cpp.

All of our buildalon unity actions are verified by GitHub. Check them out! 😁

Ahh closed this too hastily. You're right @dri-richard they did add support.

@dri-richard you should still check out our actions. Game-CI isn't in active development afaik

Thanks, will do.


Nested question within non-group items does not show or work

Describe the bug
According to fhir specs the nested items within any question is possible. Means that nesting items is not only possible in type=group but also in any other type like integer/string etc. this, this, and this shows example questionnaires where items are nested into string, choice, and boolean types.
However, currently the app completely skips the nested questions which are in any type other than group and does not show or renders questions. The nesting without group is helpful for simplification purposes and associating questions with items directly on which they depend by any means.
Component
SDC library
To Reproduce
Paste this question in any where in capture library to test, it does not render the "linkId": "a-age-unit" item. However, if it parent is change to type=group it starts showing off.
{
  "resourceType": "Questionnaire",
  "item": [{
      "linkId": "a-birthdate",
      "text": "Birth Date",
      "type": "date"
    }, {
      "linkId": "a-age",
      "text": "Age",
      "type": "integer",
      "item": [{
        "linkId": "a-age-unit",
        "text": "Age unit",
        "type": "string"
      }]
    }
]}

Expected behavior
It should show 3 questions on form instead of 2. birthdate, age, and age unit.
Screenshots

@maimoonak
Can you please verify whether the mentioned issue has been fixed, along with Issue  #1812 ?
Issue #1812 has nested items which get enabled when enableWhen is true.

@santosh-pingle I verifed on master branch. This does not work. As per questionnaire shared in issue there should be 3 items shown, but it skips the age-unit  (i.e. nested item in integer type) and shows only 2 outer elements

looking into it, thanks!

https://github.com/google/android-fhir/assets/86107848/55052da1-dc7a-4390-b9d2-a8a3aaf9a656

can we close this @maimoonak @santosh-pingle if this is ok?

@maimoonak i'm gonna close this as working as intended. please feel free to reopen if this is still an issue.