Add suburb, quarter, neighborhood rendering

This PR renders urban districts (OSM place=suburb, place=quarter, and place=neighbourhood), resolving #1058. Urban districts are rendered in all caps with a dark blue font color, the same font color as currently used for waterway label. However, waterway labels are always mixed case and italicized, so I think the risk of confusion is low. The color and capitalization, along with the lack of a dot, distinguishes urban districts from the 'independent' place hierarchy (i.e. city, town, village).
Since the distinction in OSM between each place value in American usage is fuzzy at best, all three classes are rendered similarly. The only differences are zoom level and font size. Suburbs appear between z11-z15, quarters between z14-z16, and neighbourhoods between z14-z17. I would've liked quarters to appear at z13, but they only begin to appear in the tiles at z14. The maximum zooms ensure that the labels disappear to make room for POIs once you are at high zoom.
In the legend, I labeled suburb "Major district", quarter "Large neighborhood", and neighbourhood "Neighborhood". Though maybe all three could just be grouped together?
Samples:
Los Angeles, z11 (localhost)

San Francisco-Oakland, z11 (localhost)

Oakland, z12 (localhost)

Midtown Manhattan, z14 (localhost)

Manhattan, z16 (localhost)

Marina del Rey, z14 (localhost)

Compare the place=quarter (top) to the natural=water (bottom)
Legend, z14 (localhost)

Though maybe all three could just be grouped together?

The different font sizes suggest separate entries. At these zoom levels, these are the only entries in the “Populated places” section, so I don’t see a problem with listing up to all three of them at a time.

Since the distinction in OSM between each place value in American usage is fuzzy at best, all three classes are rendered similarly.

It’s fuzzy, but there’s still a hierarchy. The font size is one possible tool, but also explore other options like mixed case. Once the user is at a high enough zoom level that only suburb, quarter, and neighbourhood are labeled, consider giving suburb more prominence resembling, say, a village at a lower zoom level.

This looks really really good.  The only thing I might explore a bit is whether the labels for suburb might be rendered larger at zooms 11-12.
z11 example:

This looks good.  Thanks for working on it!

Urban districts are rendered in all caps with a dark blue font color, the same font color as currently used for waterway label.

Any particular reason for this color choice?  It feels a bit unexpected to me.  So far blue is mostly used for water related features and various POI types.  I think even if a shade of gray was used, the capitalization and font weight differences would still be distinct enough.  See state labels vs city labels for example.

The only thing I might explore a bit is whether the labels for suburb might be rendered larger at zooms 11-12.

Increased the font size a bit for suburb at low z:

I think this looks good.

Any particular reason for this color choice? It feels a bit unexpected to me. So far blue is mostly used for water related features and various POI types.

No particularly strong reason. A lighter blue was used in the sample I posted in the original issue, and going with blue was gently encouraged. But you're right to point out it's not particularly consistent with what's been done so far. I did want to avoid black to remove confusion with street labels, which will be prominent at similar zoom levels.

I think even if a shade of gray was used, the capitalization and font weight differences would still be distinct enough. See state labels vs city labels for example.

I think gray might prove tricky because we already have a lot of gray in the background where these labels appear with buildings and minor streets. But maybe with some iteration a shade can be found that works (this one was a "medium gray", hsl(0,0%,50%), and IMO it's too close to the street color).

also explore other options like mixed case, so that the user doesn’t have to squint at two labels to decide whether one is subordinate to the other.

I worry that using mixed case will make these look too much like street labels, which they appear at similar zoom levels to. If we do, they probably need to be very clearly not black. Hopefully the tweak above making the labels more different in font size helps distinguish them more.

Once the user is at a high enough zoom level that only suburb, quarter, and neighbourhood are labeled, consider giving suburb more prominence resembling, say, a village at a lower zoom level.

I'm not sure I understand what you mean. Probably it shouldn't get a dot, and the font sizes are already pretty similar to the labels villages get. Actually, at z12 suburbs are in bigger font, which you can tell in that Oakland screenshot by comparing the North Oakland label to that of the village of Canyon.
One thing I was playing around with that maybe accomplishes what you mean is increasing the letter spacing as you zoom in for suburbs:

A lighter blue was used in the sample I posted in the original issue, and going with blue was gently encouraged.

Oops, I should have looked back at the original issue before commenting.  The blue labels on the paper map sample do look good.  I wonder about leaning into the color choice with a brighter, more saturated blue closer to the paper map?  Here's a test with the color set to hsl(208, 90%, 45%).  I think something along these lines could work.

Comparatively, the water label color (hsl(211, 43%, 28%)) is very dark.  When used with the thinner text on labels over land I find it looks almost just like a very dark grey or black, but I can discern the blue when looking closely.  The dark text gives a bit of a different cartographic effect but it is readable and works well to my eyes.  I think it just initially struck me as slightly odd that the water label color was being used.

I think gray might prove tricky because we already have a lot of gray in the background where these labels appear with buildings and minor streets. But maybe with some iteration a shade can be found that works (this one was a "medium gray", hsl(0,0%,50%), and IMO it's too close to the street color).

Yes it would need to be quite a dark gray.  In the samples you showed I also find the medium gray labels lack contrast with their background and don't work so well.

Letter or word spacing is a fantastic idea, almost a must for anything in all caps.
The AAA map’s blue labels look good, but that’s partly because the map has a limited color palette. Most print maps are printed in CYMK halftone. Brighter blue and magenta colors would almost evoke a note scribbled in highlighter, or marker on a transparent cellophane overlay, floating high above the cityscape. Some maps make heavy use of this effect for not only neighborhood names but also ZIP codes.
If we take this approach, we might want to consider a similar approach at lower zoom levels for other place labels that gesture broadly at a territory rather than pinpointing a specific location, such as states and counties. Even with a lighter blue, we will be encroaching enough on water labels that we should once again look into setting the water labels in a real italic font, maybe even a serif one.

I've merged in the font size increases I previously showed, as well as an increase of the text spacing for all three classes of labels as one zooms in.
Regarding the coloring, using a lighter blue like in the AAA maps is worth a look. To me, the district labels end up really bright/prominent with this color: they stick out even more to my eye than the city labels, which feels off to me. Kind of a similar phenomenon to #993:

This lighter blue is also really similar to the water fill (probably a purposeful choice by print mapmakers working in CMYK ink, as @1ec5 alluded to):

Based on this, my opinion is that a darker color works better for these labels, since neighborhoods probably shouldn't be terribly high in the visual hierarchy. I think the paper maps get away with it by having the color almost washed out, and having the labels be fully transparent (you can see the roads are on top of them). But I'm not sure that's as workable in this style. Maybe with some iteration a lighter label could work.
Also tried a darker gray (hsl(0, 0%, 30%)): the tricky aspect with shades of gray is that as you zoom in, the roads behind gradually turn from light to dark gray, so some roads always nearly match whatever gray you choose:

Not really a deal-breaker, but I think having a slightly different color is helpful for legibility. One other color already used for place styling is hsl(0, 33%, 30%), which is used to label continents at z0 (!):

Need to resolve the taginfo conflict.

I think the gray could still work, if we change the font weight to bold:

Thanks for trying out the lighter blue and darker gray @wmisener.  I agree with your assessment and support your current color choice (hsl(211, 43%, 28%)).  It distinguishes the labels just enough from other dark gray/blackish labels in the vicinity.
@claysmalley, bold could make some sense to tie these labels a bit more closely to the other place labels that use bold.  My initial reaction is that it feels a bit like the map is yelling at me with so much bold all over the place.  Probably due to bold and caps used together.  I think I prefer one or the other.

Lost momentum on this one just before the finish line, but now my life has settled down so I'm bringing my attention back. From the above conversation it seems like the dark blue text was acceptable to most folks, any final thoughts or is this ready to be merged?
Some miscellaneous samples:

I still personally prefer the bold/light gray approach, but at this point I'd just be happy to see labels show up at all. This style is fine by me.
There are some text overlap issues with the legend (example location). Maybe we could substitute a constant letter spacing in the legend.

There are some text overlap issues with the legend (example location). Maybe we could substitute a constant letter spacing in the legend.

The column width is probably being constrained in terms of character-relative units.

There are some text overlap issues with the legend (example location). Maybe we could substitute a constant letter spacing in the legend.

Huh weird, I don't reproduce that text overlap on my PR preview (Mac OS 14.6, Chrome):

To be honest, I'm not totally sure how to fix that either. I attempted to add a "text-letter-spacing" argument to the legendEntries items. But it seemed to have no effect for me, i.e. the legend text seemed to still have whatever spacing appeared on the map.

I attempted to add a "text-letter-spacing" argument to the legendEntries items. But it seemed to have no effect for me, i.e. the legend text seemed to still have whatever spacing appeared on the map.

text-letter-spacing is from the style specification, but the legend is built using HTML and SVG. The CSS and SVG equivalent would be letter-spacing.

In Firefox 133.0b9 on macOS, with either an overlay scrollbar or persistent scrollbar, there’s no overflow when my window is a full 1,728×966 pixels:

However, if I resize the window to, say, 921×966 pixels, then everything goes haywire:

I think this is essentially #684. It’s unfortunate, but I don’t think it needs to block this feature.

Yes, definitely not a blocker. Confirming that #684 addresses this issue. We should be good to merge.

Ah OK, I'm able to reproduce it as well by shrinking my browser window. I agree in thinking that this is another manifestation of #684, and I don't think forcing the legend entries to have fixed letter spacing would actually fix it.


Pagination current page dropdown misaligned

Detailed description

Current page dropdown carat svg appears outside the drop down

Is this a feature request (new component, new icon), a bug, or a general issue? - Bug

Is this issue related to a specific component? - Pagination

What did you expect to happen? What happened instead? What would you like to see changed?

What browser are you working in?

What version of the Carbon Design System are you using? - 4.40.0

Steps to reproduce the issue

https://angular.carbondesignsystem.com/?path=/story/components-pagination--basic
Hover over the current page dropdown
Click on the carat drop down icon

Actual result - It has no action. It works only when clicking the number

We are seing this in the Galasa project as well,  same on Firefox, Chrome and Safari.


Move all forks of dependencies to the noir-lang organisation

When we fork a dependency for use in noir, we should add it to noir-lang so that everything is in one place

@jfecher the only forked dependency that I'm aware of is the chumsky parser -- can you check to see if the newer versions of chumsky do not require us to fork and if we are still required, can you put the fork under the noir-lang organisation?

Although the master branch is being updated, there have yet to be any new versions of chumsky (latest is 0.8.0 from 2022-02-07). The extra parser we need has since been merged to master and we can migrate the next time a version is released. I can work on moving the chumsky fork since I am not sure how long it will take for a new chumsky version to be released.

Closing in favour of #853 as it's the only known form we depend on.


Fix CI bench compile check

Objective

Fixes #14723

Solution

add the manifest path to the cargo command

Testing

ran cargo run -p ci -- bench-check locally

Not sure why winit is blowing up in ci. Locally it compiles, but I get 300+ clippy warnings.

Currently not sure why winit is failing compiling in CI. Works on my machine :P

I think it's failing to compile because neither x11 nor wayland is enabled. You may have to manually pass the feature flag.

Updated the Cargo.toml as it is a problem for running locally on linux too. Thanks for the advice.


Multiple sequential newlines in JSDoc comments are not parsed correctly

TypeScript Version: 1.8.7
Code
/** first line of the comment

third line */
function foo() {}

Note that there are no spaces on the empty line. If there were at least a single space, the parser would work as expected.
Expected behavior:
calling Symbol.getDocumentationComment() would return:
[
{ kind: "text", text: "first line of the comment" },
{ kind: "lineBreak" },
{ kind: "text", text: "" }, // this is optional
{ kind: "lineBreak" },
{ kine: "text", text: "third line" }
]

Actual behavior:
[
{ kind: "text", text: "first line of the comment" },
{ kind: "lineBreak" },
{ kine: "text", text: "third line" }
]

Cause
Line 532 of services/services.ts that consume all sequential newline characters.
Fix
I replaced locally this call to consumeLineBreaks() with this method:
function consumeOneLineBreak(pos, end, sourceFile) {
    if (pos < end) {
        var c = sourceFile.text.charCodeAt(pos);
        if (ts.isLineBreak(c)) {
            pos++;

        // consume \r\n as a single newline
            if (c === 13 && pos < end && sourceFile.text.charCodeAt(pos) === 10) {
                pos++;
            }
        }
    }
    return pos;
}

@RyanCavanaugh to comment on the design/impl here. I believe the intent is to behave similarly to markdown (i.e. line breaks in the comment text purely for wrapping purposes are removed, but an empty line should be preserved).

I am actually using the the API output to parse the comment text as markdown and this issue is preventing me from creating paragraphs.

This seems to be fixed now in TypeScript 2.1 with the new jsdoc parser.

Thanks for confirming @Knagis. I didn't know enough about the API to confirm that it was fixed.


Community V.2.9.3 Helm installation failed with NFS integration

Alluxio Version:
Community version 2.9.3
Describe the bug
I installed community version 2.9.3 by Helm chart on my cluster which each host have a /deeplearning/us-model-data dir mounted to a NFS server.
I put the DIR into the config file as UFS. But after the installation, runTests failed by complaining the DIR does not exsit. I check the pod by docker inspect , found the DIR is not visible in the containers, so no way for Alluxio to mount the UFS
To Reproduce
Have a k8s cluster with NFS mounted to each node, install community version 2.9.3 by helm. Then either runtest or go to the webUI to check UFS
Expected behavior
The ufs works in the alluxio.
Urgency
Urgent, the bug block my set up
Are you planning to fix it
Would try with a PR to add ufs mounting to the workes and masters.
Additional context
Add any other context about the problem here.

This can be satisfied with extravolumes


Update README.md

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

You ignored a list of PR requirements, including one indicating "My pull request has a descriptive title (not a vague title like Update index.md)". Descriptive titles and good explanations of changes are necessary for a well maintained codebase. Free Code Camp is choosing to relax some of its requirements to help people reach their Hacktoberfest goals, but this PR would normally be rejected. In the future, please help repository maintainers by providing useful titles and do not ignore contributing requirements.

Hi,
Thanks for this pull request (PR).
Unfortunately, we are marking this PR invalid for hacktoberfest. We believe it does not follow the recommended guidelines:

Quality Standards
In line with Hacktoberfest value #2 (Quantity is fun, Quality is key), we have provided examples of the quality standards we encourage. This applies mainly to beginners.

PRs that are automated e.g. scripted opening PRs to remove whitespace / optimize images.
PRs that are disruptive e.g. taking someone else's branch/commits and making a PR.
PRs that are regarded by a project maintainer as a hindrance vs. helping.
Something that's clearly an attempt to simply +1 your PR count for October.

Learn more at https://hacktoberfest.digitalocean.com/details


[ENG-544] Stop temporal log spam

I don't love this fix (see comments in ENG-544), but it works :)

Got some unrelated changes here, will repoen a new one.


Add option to repartition by partition column in merge to reduce the number of files

Currently, merge can produce a very large number of files when the table is partitioned. Reducing # shuffle partitions can reduce the # files but also reduce the parallelism of the operation, making it slower.
Reports

https://delta-users.slack.com/archives/CJ70UCSHM/p1582931151094700
https://github.com/delta-io/delta/issues/345

As discussed in the above slack thread, a solution is the add an additional conf that optionally repartitions the data to be written by the partitioning column.

Done in this commit - https://github.com/delta-io/delta/commit/6d9420539e9b00f8df8d5bc80ce6aa7a5a9f3b7d

Awesome feature! But how to use it?
Example needed where in merge statment repartition option can be used.


Build criteria flow

Clicking on the "Build Criteria" button results in popping up:

The save button is disabled for now until we hook up the authoring tool.
Criteria Builder header and toggle button are also implemented.

Currently there is a blank space left for the authoring tool. Clicking on the toggle button will bring the pathway view back up.
Added buildCriteria to CriteriaProvider so Builder can know when to display the Criteria Builder header and toggle button.

Using the sample pathway:

Click add branch node and select the new node
Click Add Transition and click build criteria
Click on the button in the top right to view the pathway
Click on a different node

The criteria builder header is still there but you are no longer building a criteria, you can double check with @noranda but I think that once we select a new node we need to cancel in progress build.
From this state re-selecting the branch node and then clicking build criteria removes the banner.

Similarly if you have 2 transitions and click build on both of them the header and toggle button goes away on the second click and both transitions have the builder option open. I think we probably want to cancel the first build criteria in this case as well

@mdube7 Your comments should be addressed.

@noranda good catch on header persisting when returning to pathways list. I made your change and also reset buildCriteriaNodeId when clicking the logo.


An error occurs everytime an sfdx command is run.

Note: Our DevHub org has been updated to Spring '24 today.
Summary
An error occurs everytime an sfdx command is run. The DevHub org has been updated to Spring '24 today.
Steps To Reproduce
Run any sf command (e.g. scratch org creation)
Expected result

Actual result
A generic error is returned:
sf org create scratch --edition developer --alias testOrg

Error (1): A fatal signup error occurred. Please try again. If you still see this error, contact Salesforce Support for assistance

Try this:

See https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev_scratch_orgs_error_codes.htm for information on error code C-9999.

System Information
full output of the sf version --verbose --json command:
{
  "architecture": "win32-x64",
  "cliVersion"<EMAIL_ADDRESS>  "nodeVersion": "node-v20.11.0",
  "osVersion": "Windows_NT 10.0.22631",
  "rootPath": "C:\\Users\\zanaa\\AppData\\Local\\sf\\client\\2.27.6-2617cbc",
  "shell": "cmd.exe",
  "pluginVersions": [
    "@oclif/plugin-autocomplete 3.0.5 (core)",
    "@oclif/plugin-commands 3.1.1 (core)",
    "@oclif/plugin-help 6.0.12 (core)",
    "@oclif/plugin-not-found 3.0.9 (core)",
    "@oclif/plugin-plugins 4.1.23 (core)",
    "@oclif/plugin-search 1.0.12 (core)",
    "@oclif/plugin-update 4.1.8 (core)",
    "@oclif/plugin-version 2.0.11 (core)",
    "@oclif/plugin-warn-if-update-available 3.0.9 (core)",
    "@oclif/plugin-which 3.0.15 (core)",
    "@salesforce/cli 2.27.6 (core)",
    "apex 3.0.22 (core)",
    "auth 3.3.6 (core)",
    "data 3.0.18 (core)",
    "deploy-retrieve 3.2.9 (core)",
    "info 3.0.19 (core)",
    "limits 3.1.6 (core)",
    "marketplace 1.0.20 (core)",
    "org 3.3.10 (core)",
    "packaging 1.22.2 (user)",
    "schema 3.1.0 (core)",
    "settings 2.0.21 (core)",
    "sobject 1.1.6 (core)",
    "source 3.1.8 (core)",
    "telemetry 3.1.10 (core)",
    "templates 56.0.12 (core)",
    "trust 3.3.4 (core)",
    "user 3.2.6 (core)"
  ]
}

I know that a C-9999 is a generic serverside error that Salesforce is returning and sfdx cli has nothing to do with it, but I'm still  posting this to get a confirmation that the Salesforce's orgs update to Spring '24 has nothing to do with this issue returned by the cli.

I'm facing the same issue when I try to create a new scratch org.

I'm experiencing the same issue, this is the error thrown creating a new scratch org using --dev-debug command:
{
   "code":1,
   "actions":[
      "See https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev_scratch_orgs_error_codes.htm for information on error code C-9999."
   ],
   "context":"EnvCreateScratch",
   "commandName":"EnvCreateScratch",
   "data":{
      "username":"...",
      "orgId":"...",
      "scratchOrgInfoId":"..."
   },
   "message":"A fatal signup error occurred. Please try again. If you still see this error, contact Salesforce Support for assistance",
   "name":"RemoteOrgSignupFailed",
   "status":1,
   "stack":"RemoteOrgSignupFailed: A fatal signup error occurred. Please try again. If you still see this error, contact Salesforce Support for assistance\n    at checkScratchOrgInfoForErrors (/Users/franciscorojas/.local/share/sf/client/2.27.6-2617cbc/node_modules/@salesforce/core/lib/org/scratchOrgErrorCodes.js:63:19)\n    at async pollForScratchOrgInfo (/Users/franciscorojas/.local/share/sf/client/2.27.6-2617cbc/node_modules/@salesforce/core/lib/org/scratchOrgInfoApi.js:308:16)\n    at async scratchOrgCreate (/Users/franciscorojas/.local/share/sf/client/2.27.6-2617cbc/node_modules/@salesforce/core/lib/org/scratchOrgCreate.js:168:17)\n    at async EnvCreateScratch.run (file:///Users/franciscorojas/.local/share/sf/client/2.27.6-2617cbc/node_modules/@salesforce/plugin-org/lib/commands/org/create/scratch.js:164:72)\n    at async EnvCreateScratch._run (/Users/franciscorojas/.local/share/sf/client/2.27.6-2617cbc/node_modules/@oclif/core/lib/command.js:304:22)\n    at async Config.runCommand (/Users/franciscorojas/.local/share/sf/client/2.27.6-2617cbc/node_modules/@oclif/core/lib/config/config.js:417:25)\n    at async run (/Users/franciscorojas/.local/share/sf/client/2.27.6-2617cbc/node_modules/@oclif/core/lib/main.js:85:16)",
   "exitCode":1,
   "warnings":[
      "Record types defined in the scratch org definition file will stop being capitalized by default in a future release.\nSet the `org-capitalize-record-types` config var to `true` to enforce capitalization."
   ]
}

Version in use: @salesforce/cli/2.27.6 darwin-x64 node-v20.11.0

I have created a Salesforce case (internal number: #46265556 - not publicly reachable, but you can mention it if you create a case too).

They identified the issue as a bug and made it public:
https://issues.salesforce.com/issue/a028c00000yx0wjAAA/~

I don't know if it will work for you, but we changed the edition to enterprise in the config file as a workaround and it works

The bug seems to have been fixed that blocked scratch org creation but i think there is a new secondary bug.
Admin: You may not modify the permission Allow user to train and generate models for Object Detection. (Retired) while editing a Standard Profile
I did some digging and found the API name of the permission that was referenced in the error and I searched in VS code and i dont have the "PermissionsAllowObjectDetectionTraining" permission anywhere in vscode, so I'm thinking there is a new bug.

@cesarParra, yeah i tried that...  Nothing in VS code by that name at all. and the app actually doesn't have any System Permissions in either of the two packaged perm sets all.

closing this because the scratch org signups problem is behaving now.
@bacasystems-IT if you've got a new bug, please open a new issue with all the specifics, probably including your scratch-def


math functions and large numbers

Examples include (seconds from $gametime and bank balances are what's getting me). The math engine really wants to drop significant figures and convert to scientific notation which is messing up my wealth tracking

Related to #86
I’m not sure that I can fix this in the existing script engine.


[BUG] Not full loaded albums.

I have other one gallery app and I see some albums display different photos/videos count.
That method work incorrectly.
List<AssetPathEntity> albums = await PhotoManager.getAssetPathList(hasAll: false);

Try ignoreSize in the filter options.

Try ignoreSize in the filter options.

Yes. It's work, thank you.


No way to determine which tile in a tilemap has collided with an area2d

Godot version:
3.2.2
OS/device including version:
linux
Issue description:
I have a tilemap (32x32 tiles), it has a collision layer set.
I fire at a tile and get the result via its area2d collision:
func _on_AbstractProjectile_body_entered(body: Node) -> void:

In order to find the tile it hit I do the following:
var pos=map.world_to_map(position)
var id=map.get_cellv(pos)

However, even when not moving and firing at the same tile I get a different, wrong, result.
Example:

The tile you can see being hit by the bullet is at location 114,109. This translates to:
min x: 3648
max x: 3680
The debugger stopped at this point saying 3650.735, 3493.999
Giving me 114,109. Which is exactly the tile you see being hit
I then fire again without moving

and the position reported is: 3647.91,3493.999
It now reports 113,109 which is the empty tile, i.e. the position is out because world_to_map is transforming 3647.91 to 3647, which is 113.
The problem is unlike every other node that can interact with a body or area2d, you cannot get the actual thing colliding with you, just the entire tilemap. So even though it is a specific tile reporting the collision you cannot get it.
If your body has a collision shape (or shapes) that are different to the size of the body and it is not centre, there is no way to calculate the actual tile being collided with. This is just a simple collision 2d, but if my body had complex shapes, there is no way to actually find the tile. If the shape_id/area_id returned, say, the tile id then it would be fine, but it doesn't.
Steps to reproduce:
Minimal reproduction project:

I guess the problem is because you cannot get a collider from an area2d collision you have to use your body's position, which is typically the centre point. Surely there's a better way of having to know a direction and a size of an area2d and apply offsets based on this, in order to get the thing you're actually colliding with...

I didn't mean to close it....
The problem, as I see it, is unlike any other node, you cannot get a position from an area2d collision because there is no 'position' for a map and you cannot get a tile position.

Duplicate of https://github.com/godotengine/godot/issues/24739.


Remove empty attribute parenthesis

fixes #105
Assumption: Attributes with no parameters don't have enforced newlines

I do think literals are escaped but I'll add a test case-------- Ursprüngliche Nachricht --------Betreff: Re: [ApiApprover/ApiApprover] Remove empty attribute parenthesis (#118)Von: Joseph Musser An: ApiApprover/ApiApprover Cc: Daniel Marbach ,Author @jnm2 commented on this pull request.
In src/PublicApiGenerator/ApiGenerator.cs:

@@ -191,6 +191,7 @@ static string NormaliseGeneratedCode(StringWriter writer)
gennedClass = Regex.Replace(gennedClass, set, " { set; }", RegexOptions.IgnorePatternWhitespace);
gennedClass = Regex.Replace(gennedClass, @"\s+{\s+}", " { }", RegexOptions.IgnorePatternWhitespace);
gennedClass = Regex.Replace(gennedClass, @")\s+;", ");", RegexOptions.IgnorePatternWhitespace);

       gennedClass = gennedClass.Replace("()]", "]"); // [Attribute] instead of [Attribute()]

Is there any need to defend against this replacement being done to a string literal?
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

The problem is nobody forces you to suffix attributes right? -------- Ursprüngliche Nachricht --------Betreff: Re: [ApiApprover/ApiApprover] Remove empty attribute parenthesis (#118)Von: Joseph Musser An: ApiApprover/ApiApprover Cc: Daniel Marbach ,Author @jnm2 commented on this pull request.
In src/PublicApiGenerator/ApiGenerator.cs:

@@ -191,6 +191,7 @@ static string NormaliseGeneratedCode(StringWriter writer)
gennedClass = Regex.Replace(gennedClass, set, " { set; }", RegexOptions.IgnorePatternWhitespace);
gennedClass = Regex.Replace(gennedClass, @"\s+{\s+}", " { }", RegexOptions.IgnorePatternWhitespace);
gennedClass = Regex.Replace(gennedClass, @")\s+;", ");", RegexOptions.IgnorePatternWhitespace);

       gennedClass = gennedClass.Replace("()]", "]"); // [Attribute] instead of [Attribute()]

That sounds good. It could still edit string literals, but the chance of it matching is getting smaller and smaller.
if the second matching group is empty.
Then why not: @"[(.*)Attribute()]"
—You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.

This one is going to be hard to explain, but it works in each combination of cases:
from input in new[]
{
	"[FooAttribute]",
	"[FooAttribute()]",
	"[FooAttribute(2)]",
	"[Foo]",
	"[Foo()]",
	"[Foo(2)]"
}
select Regex.Replace(input, @"(?<=\[.*)(Attribute)?(\(\)(?=\])|(?=\([^)]+\)\]))?", string.Empty)

Output:
[Foo]
[Foo]
[Foo(2)]
[Foo]
[Foo]
[Foo(2)]

Regular expressions have always been some sort magic to me.

It's bad. I documented it and made some changes that seemed important while writing comments:
from input in new[]
{
    "[FooAttribute]",
    "[FooAttribute()]",
    "[FooAttribute(2)]",
    "[Foo]",
    "[Foo()]",
    "[Foo(2)]"
}
select Regex.Replace(
    input,
    @"
        (?<=\[[^\]]*)       # Require a starting square brace on the same line and any following characters except an ending square brace.
        (Attribute)?        # Delete this if present.
        (                   # Then require either:
            \(\)(?=\])      # - Empty parens (to delete) immediately followed by closing square brace (not deleted),
        |
            (?=\(.+\)\]) # - or non-empty parens immediately followed by closing square brace (not deleted).
        )",
    string.Empty,
    RegexOptions.IgnorePatternWhitespace)

It's still pretty bad. Don't feel like you have to do anything with it. :D

@sungam3r @jnm2 have a look. I think this should cover all the cases

What about this?
 public class Attribute1 : Attribute
 {
 }

 public class Attribute1Attribute : Attribute
 {
 }

 [@Attribute1Attribute]
 [@Attribute1]
 public class Class1
 {
 }

Honestly, I have no good idea for now how to solve
https://github.com/ApiApprover/ApiApprover/pull/118#issuecomment-549905472
other than tracking all the attributes generated and then find out if a potential clash could be produced and then special name again. Which to me seems super silly for such an edge case.
And making everything pluggable and configurable seems overkill as well. Do you guys see this special case as a killer for this feature or should I proceed?

Nope, I really don't think that situation will really happen in real-world projects. If it does, it won't be hard for the users to figure out what happened since their C# source code that they'll immediately compare with will look so unusual in the first place.

Nope, but let's leave a note about this special case near to the regex for attributes in CodeNormalizer.


How to trigger OTPTextField to use the errorBorderColor / disabledBorderColor?

how to trigger OTPTextField to use the errorBorderColor / disabledBorderColor?
Originally posted by @aulia-rosyida in https://github.com/iamvivekkaushik/OTPTextField/issues/2#issuecomment-1034918465

This will be fixed with #27


Change diagnostic-settings-blade image for the monitoring overview of…

Update the monitoring overview of diagnostic logs settings image to show the Network tab with the proper label.

@nclandrei : Thanks for your contribution! The author, @, has been notified to review your proposed change.

@johnkemnetz - You should pull this change over to the private repo so you can stage the change first. You can use these steps to pull the commits over to your local copy of the private repo.

The content has been revised and the image that's updated in the pull request no longer exists in the repository. We'll close this PR.
@nclandrei Thanks for contributing.


Extract additional information from MCInst

The MCInst holds additional information about the instruction, like mnemonic and operands. Using smth like
for (int i = 0; i < insn.getNumOperands(); ++i) {
    std::string op_str;
    llvm::raw_string_ostream op_stream(op_str);
    auto oper = insn.getOperand(i);
    oper.print(op_stream, register_info.get());
}

(or similar) should enable the instruction details to hold more information.

Duplicate of #34.


Vue scrumboard

https://github.com/yappkahowe/scrumboard

@VitaliyLogvin Please create a PR if this is still relevant.


Question: determining whether or not a type name is a class.

Hi, people from ts-simple-ast.
I am trying to determine if an expression is a class name by using the vanilla TS compiler I have the following problem. When I ask for the definition of Date, because Date is defined as a mix of DateConstructor const variable and Date interface, is quite hard to determine whether or not Date is a class.
Does ts-simple-ast provide a mechanism to solve this problem?
Thank you,
Ezequiel.

Hi ezequiel-umu, once you get the type, I believe you could check if type.getConstructSignatures().length > 0.
Alternatively, if that isn't sufficient, I believe this might work:
// untested code... not sure if this works
function isClassType(type: ts.Type) {
    const tsSymbol = type.getSymbol();
    const declarations = tsSymbol.getDeclarations() || [];
    return declarations.some(d => d.kind === ts.SyntaxKind.ClassDeclaration);
}

...essentially, get the symbol of the type then check all its declarations for a class declaration.
There might be some combination of TypeFlags that signify a class is a type (see type.flags property). You might want to look into that as well.
I'll look into this later and see about adding a type.isClass() method in ts-simple-ast.

The snippet code would only work when the type is declared using class keyword, right? Otherwise, type.getConstructSignatures().length > 0 should do the trick?

Yes, exactly. I believe that's the case.

It fails for Map:
console.log(((type.getSymbol() as AstSymbol).getDeclarations() || []).some((d) => d.getKind() === ts.SyntaxKind.ClassDeclaration));
console.log("Object not parsed: " + objectFlags);
console.log("Object's name: " + (type.getSymbol() as AstSymbol).getName());

true
Object not parsed: 4
Object's name: Type
Type not parsed: 16384
Type not parsed: 16384
false
Object not parsed: 4
Object's name: Map

I'll look into this later. I'd have to play around with it to find out how to get it to work in this scenario.
Maybe looking at the source for Map might help in the meantime though:
interface Map<K, V> {
    clear(): void;
    delete(key: K): boolean;
    forEach(callbackfn: (value: V, key: K, map: Map<K, V>) => void, thisArg?: any): void;
    get(key: K): V | undefined;
    has(key: K): boolean;
    set(key: K, value: V): this;
    readonly size: number;
}

interface MapConstructor {
    new (): Map<any, any>;
    new <K, V>(entries?: [K, V][]): Map<K, V>;
    readonly prototype: Map<any, any>;
}
declare var Map: MapConstructor;

As I said earlier: a mix of an interface with the info and an interface with the Constructor. Map by itself has no constructor signatures but is construct-able.

@ezequiel-umu here's some code that works for Map:
function isClassType(type: Type) {
    if (type.getConstructSignatures().length > 0)
        return true;

    const symbol = type.getSymbol();
    if (symbol == null)
        return false;

    for (const declaration of symbol.getDeclarations()) {
        if (TypeGuards.isClassDeclaration(declaration))
            return true;
        if (TypeGuards.isVariableDeclaration(declaration) && declaration.getType().getConstructSignatures().length > 0)
            return true;
    }

    return false;
}

Btw, you can write type.getSymbol()!.getDeclarations() instead of (type.getSymbol() as AstSymbol).getDeclarations(). I'll update Type to have a getSymbolOrThrow() method.

Closing for now. Please reopen if the above doesn't solve the problem.

export type Constructor = new (...args: any[]) => T;
I don,t have a class, but type.getConstructSignatures().length > 0 works for this type.


BadRequestException: Invalid model identifier specified: Empty

Hello,
I run
$  terraform version
Terraform v0.14.0

I have a tf file looking like:
resource "aws_api_gateway_rest_api" "backend" {
  name        = "backend-api"
  description = "Backend API"
  body        = templatefile("${path.module}/api/api.json", { })

  endpoint_configuration {
    types = ["REGIONAL"]
  }
}

module "apigateway-cors" {
  source  = "mewa/apigateway-cors/aws"
  version = "2.0.0"

  api = aws_api_gateway_rest_api.backend.id
  resource = aws_api_gateway_rest_api.backend.root_resource_id

  methods = ["OPTIONS", "GET", "PUT", "POST"]

  origin = "https://xxx.cloudfront.net"
}

when I run terraform apply it fails with:
  # module.apigateway-cors.aws_api_gateway_integration.cors_integration will be created
  + resource "aws_api_gateway_integration" "cors_integration" {
      + cache_namespace      = (known after apply)
      + connection_type      = "INTERNET"
      + http_method          = "OPTIONS"
      + id                   = (known after apply)
      + passthrough_behavior = (known after apply)
      + request_templates    = {
          + "application/json" = jsonencode(
                {
                  + statusCode = 200
                }
            )
        }
      + resource_id          = "XXX"
      + rest_api_id          = "XXX"
      + timeout_milliseconds = 29000
      + type                 = "MOCK"
    }

  # module.apigateway-cors.aws_api_gateway_integration_response.cors_integration_response will be created
  + resource "aws_api_gateway_integration_response" "cors_integration_response" {
      + http_method         = "OPTIONS"
      + id                  = (known after apply)
      + resource_id         = "XXX"
      + response_parameters = {
          + "method.response.header.Access-Control-Allow-Headers" = "'Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token'"
          + "method.response.header.Access-Control-Allow-Methods" = "'OPTIONS,GET,PUT,POST'"
          + "method.response.header.Access-Control-Allow-Origin"  = "'https://XXX.cloudfront.net'"
        }
      + rest_api_id         = "XXX"
      + status_code         = "200"
    }

  # module.apigateway-cors.aws_api_gateway_method.cors_method will be created
  + resource "aws_api_gateway_method" "cors_method" {
      + api_key_required = false
      + authorization    = "NONE"
      + http_method      = "OPTIONS"
      + id               = (known after apply)
      + resource_id      = "XXX"
      + rest_api_id      = "XXX"
    }

  # module.apigateway-cors.aws_api_gateway_method_response.cors_method_response will be created
  + resource "aws_api_gateway_method_response" "cors_method_response" {
      + http_method         = "OPTIONS"
      + id                  = (known after apply)
      + resource_id         = "XXX"
      + response_models     = {
          + "application/json" = "Empty"
        }
      + response_parameters = {
          + "method.response.header.Access-Control-Allow-Headers" = true
          + "method.response.header.Access-Control-Allow-Methods" = true
          + "method.response.header.Access-Control-Allow-Origin"  = true
        }
      + rest_api_id         = "XXX"
      + status_code         = "200"
    }

Plan: 4 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

module.apigateway-cors.aws_api_gateway_method.cors_method: Creating...
module.apigateway-cors.aws_api_gateway_method.cors_method: Creation complete after 0s [id=agm-XXX-XXX-OPTIONS]
module.apigateway-cors.aws_api_gateway_method_response.cors_method_response: Creating...
module.apigateway-cors.aws_api_gateway_integration.cors_integration: Creating...
module.apigateway-cors.aws_api_gateway_integration.cors_integration: Creation complete after 0s [id=agi-XXX-XXX-OPTIONS]

Error: Error creating API Gateway Method Response: BadRequestException: Invalid model identifier specified: Empty

Any idea how to solve that?
Thanks in advance.

Actually my swagger did not defined Empty, sorry about that.


Add index for transaction:broadcast

Documentation for transaction:broadcast is present here, however, the list of commands section does not list this broadcast type of transaction.

#167


run long running sync on pyrmont and mainnet to see how addVotes profiles [1D]

We need to better understand how long running sync performs, running an hour long sync on each network through profiler will hopefully give us a good point of comparison.

Test scenario:

Start with no database
configuration:

➜  teku cat pyrmont-profile.yaml
network: "pyrmont"
log-destination: "console"
Xdata-storage-create-db-version: 4
data-storage-archive-frequency: 2048
data-storage-mode: "archive"
data-path: /Library/teku/pyrmont-profile

duration: 30.0 minutes, running in intellij on JDK11 with CPU Profiler.

pyrmont
finish slot: 15552
addvotes: 46% of doUpdate time
doUpdate time: 10.56% of total time

mainnet
finish slot: 54376
addvotes: 37% of doUpdate time
doUpdate time: 13% of total time

At this point I think it's probably fair to say that while it does take a considerable amount of the doUpdate time, that we may be better off spending time on finding other bottle necks rather than chasing down addVotes any further for now...
It's a little surprising the difference in speed in reference to slots completed in 30 minutes.


Text is stretched out on mobile.

On mobile, the titles of posts are stretched out across the screen, leaving out of place gaps.

It's not just for mobile. Problem is text alignment. I set text alignment as justify for all content area. I suppose i should edit it.


Fixed PostgreInsertReplaceMethod not quoting the column in CONFLICT

When using the import data wizard (in my case, a CSV) on a Postgres table that had capitalized column names (like HelloWorld rather than helloworld) this caused the insert/replace function to error out, because it did not properly quote the column name, and Postgres defaults capitalized column names to all-lowercase when they are unquoted. This fixes that.
I'm not really a Java programmer, so I just did the most straight-forward fix.

Hello @Seanld
Thanks for your contribution!
But we can't always use quotes for attribute names. Usually, we use quotes only for attributes that need them.
However, thanks for the bug report. I'll create a new issue on our board and fix this bug.

https://github.com/dbeaver/dbeaver/pull/15231


Namsonx/task/stabi branch

Hi @namsonx ,
as discussed today I wait for an update of the "_" documentation before merging.
Thank you,
Thomas

Hello Thomas,
I already updated the release note information.
Thank you,
Son


Improve NuGet configuration for SSF artifacts

Checking the only existing symphonyOSS released artifact on nuget, the following challenges are noticed:

There is no landing page for all SSF artifacts
There is no 2-step publication process (to validate what's being published by SSF officers)
Need to identify a "scope" (or "groupId", or "namespace") that  identifies an SSF artifact

From https://docs.nuget.org/create/managing-package-owners:
"Packages can also utilize a convention for "organizations" to indicate company/group ownership of a package. For example, the Microsoft ASP.NET packages are co-owned by microsoft, aspnet, and sometimes individuals on the feature team. The 'microsoft' and 'aspnet' accounts are simply set up with a mailing list email address that reaches the teams that manage the accounts."
This suggests that we need to:

@maoo creates a symphonyoss account on nuget.org
@jforsell shares/transfers ownership of the artifact to symphonyoss nuget account
@maoo validates the artifacts and publishes it

1 is done - https://www.nuget.org/profiles/symphonyoss . Assigning issue to @jforsell

Hi @jforsell , have you tried adding https://www.nuget.org/profiles/symphonyoss to the NuGet project? the SSF profile still doesn't show the project.
Thanks!

Hi @maoo - I just added symphonyoss as an owner of the package in NuGet - looks like you'll need to approve the change.

Done, thank you SO much!
Now we can claim that we closed the circle for .NET release; although not automated (as with Java, the only automation for now is with NPM and semantic-release), we have walked through all steps to publish OSS code in .NET under the Foundation umbrella.
Thanks a lot for your help @jforsell !


mgmt, choose parent with polymorphic

Case: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2022-02-01-preview/mfe.json#L8604-L8624
1st allOf is not polymorphic.
2nd allOf AutoMLVertical is polymorphic.
Existing code takes first parent to keep, and flatten the rest.
It would fail the polymorphic hierarchy if that polymorphic chain is not via first parent.
Fix: for polymorphic, takes the one in hierarchy as parent to keep.

looped in Alan since I am changing ModelMapper.


[Collapsible][Accordion] Fix content animation of collapsible

Fixes https://github.com/radix-ui/primitives/issues/1074 by allowing to add an animation-fill-mode.
When using the Collapsible with React 18 Concurrent Mode, the close animation flickers. This is due to the fact, that it takes too long (not quite sure why) for the content to be hidden/unmounted. Since the animation doesn't specify any fill-mode, the animation styles will only be applied during the execution of the animation. Therefore the content height is animated to 0 during the animation but jumps back to its original size afterwards, before beeing unmounted.  Adding animation-fill-mode: forwards fixes that issue (visually).

@dlehmhus would you mind running yarn bump:check -i to select the versioning strategy for this PR? you'll have to do it twice annoyingly to reject the main workspace in order for the PR checks to pass.
we need to update our contributing guidelines to explain all this, apologies it isn't clear anywhere atm 🙂


In Firefox is not working

https://izolate.github.io/agegate/   verified on your demo version
FF 49.0.1

Tested on FF 49.0.1, running into the same issue, console throwing a e.srcElement is undefined on click.

For some reason it appears that during build the latter half of this line: https://github.com/izolate/agegate/blob/master/src/index.js#L120
let elements = e.target.elements
Is being transpiled to e.srcElement.elements. srcElement is non-standard and is not supported in Firefox.
Curious...

Confirmed.  Firefox 52.0.1 .

Idk if I understood the problem but its working here. Firefox 63. Maybe this is too old and just need to be closed?

Hi all, I'm sorry for the slow response. I've just released v4.0.0, which is a complete rewrite of this library, and therefore I'm closing this issue because it no longer applies to the current version.


[BUG] v5.0.0-rc.1. CLI switch --k3s-arg "--disable=traefik@all" not applied during the creation of a cluster

@iwilltry42 during testing the same issue I found another one in v5.0.0-rc.1. CLI switch --k3s-arg "--disable=traefik@all" not applied during the creation of a cluster, but when I'm using the same 'options.k3s.extraArgs' in config file - it's working.
Originally posted by @gickis in https://github.com/rancher/k3d/issues/209#issuecomment-922235176

Fix landing in v5.0.0-rc.2


Settings for BigFloat

using Clarabel
CSf = Clarabel.Settings()
CSb = Clarabel.Settings{BigFloat}()
println(CSf.tol_feas,"\n" ,CSb.tol_feas)

It seems that the Settings for BigFloat  are the same as those (tolerances etc) of Float64.
What sets of  settings for BigFloat   do you recommend?  We need a stringent one as we have more digits involved

You are correct that the solver uses the same default settings regardless of the precision of the underlying data type.   It is  difficult to give numbers that will work in all cases, particularly given that the Julia BigFloat has user-definable precision.
That said, I can at least make some suggestions.   All of the parameters are listed here:  https://oxfordcontrol.github.io/ClarabelDocs/stable/api_settings/
As a starting point, I would suggest setting all of the parameters with names like tol_* to some tighter tolerance.   What that would be is up to you of course, but maybe start with 10^-12 in the absence of any other information.   The only one you may wish to leave the same would be tol_ktratio, which could either stay at 10^-7, or at least kept at a lower tolerance than the others.
A similar comment should hold for the reduced_tol_* parameter set.   Those are only used when the solver can't reach the desired precision anyway, but probably reasonably to set them to something like 10*(sqrt(X)), where X is whatever you have for used the full accuracy settings.   I suggest that only because it is roughly what we have there already.
I would start like that.   If you don't get good convergence, the next tolerance to tighten would be iterative_refinement_reltol and iterative_refinement_abstol.   Make this something like X*1e-4, i.e. try to maintain the same relative sizes as in the default settings.
Unless you get really weird behaviour for your problem, or your problem is very badly scaled or something, I would be inclined to leave everything else as it is.
You didn't ask this, but for anyone finding this in the future: for Float32 types, a reasonable starting point would be to take the square root of the default values for all parameters named above, leaving everything else unchanged.


questions about ‘social_nav_simulation’

Hi!
I have questions about how to control people to move in Gazebo simulation，which makes it easy to test the planner in the  dynamic situation.
ps:
the people model is set like this in launch files，

Hi,
unfortunately I don't know any good way to control people in the Gazebo simulation. That is why I used the fake people detection node which simulates a detected person walking on a line. For testing I also used to joystick the robot around and recorded the robot poses and afterwards played them back as fake people detections. Like this you can simulate a person walking along some arbitrary path. You can generally try to translate a keyboard or joystick input to simulated people poses, but I did not implement anything like that. Finally, I saw that the v-rep simulator has some build in people simulation where you can make them walk along a path. Maybe that would be interesting for you?
Best,
Marina

Thanks for advice, and I will learn about the v-rep simulator recently.
And I am using a simulated turtlebot for people simulation in player stage and it works.


please add rtmp function

please add rtmp function

Currently being completed and will be available in version 14.24.

Coming soon !


Get blob size from layer descriptors and remove redundant HTTP round trip

Issue #, if available: #229
Description of changes:
Removed the HTTP round trip call that is just for getting blob size when resolving blobs.
Instead, we get blob sizes from layer descriptors. Create a new label "targetImageLayersSizeLabel" to add blob sizes to layers' labels/annotations. The label is parsed during layer mount to get blob sizes.
Testing performed:
make test
make integration
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

I'm confused why we're doing all this when c.Annotations[targetSizeLabel] already contains the image size. All we need to do is pass that value from fs.Mount to makeBlob.

@rdpsin we need to know the sizes of all layers of the image to resolve neighboring layers..

#536 requests conditionally getting the layer size from the registry if the label/annotation is missing.


Bug - Randomgender gives wrong genders

Some regular Pokémon are getting a genderless gender requirement and vice versa.
For example, Solgaleo being male or Shellos being genderless.
Should also consider Pokemon with 100% male or female ratios such as Hitmontop (100% male) to prevent them from getting an impossible gender.

I couldn't think of anything so may be best to just leave it as is and do workarounds such as keeping the spec in it's own hunt.


metadata key naming of Block and Directory

Is your feature request related to a problem? Please describe.
As I noticed FairOS uses snake case for naming keys in JSON objects, but the Block interface using different convention:
Name, Size, CompressedSize, Reference:{ R }
Additionally, instead of R, swarm or any other alternative could be used which describes the stored value better.
The directory related metadata has the same problem.
Describe the solution you'd like
name, size, reference:{ swarm }
Is compression works in FairOS? and if so how?

As I noticed FairOS uses snake case for naming keys in JSON objects, but the Block interface using different convention:
Name, Size, CompressedSize, Reference:{ R }
Additionally, instead of R, swarm or any other alternative could be used which describes the stored value better.

The directory related metadata has the same problem.
As they were only used in fairOS-dfs internally, I was made that way, But now that we have fdp-storage, it makes sense to change it, we are have breaking changes anyway...
Just for reference BlockInfo & DirMeta

Is compression works in FairOS? and if so how?

Yes, compression works. we have two types compression available snappy and gzip. After we break the data into blocks we compress. Now with the encryption changes in place, we encrypt after compression.

Thanks for your answer.
the most ideal would be to use camelCase tbh since it is the most influential naming JSON keys.


sound and scaler issues

i have minor issues with sound on Zelda Oracle of Ages on Gameyob 3DS CIA, it's like lagging a bit...
also, i like to have crisp pixels on my GB/C games and so i use the Nearest scaler and Aspect zoom, and the pixels are kind of misplaced somewhere

wrong repository. sorry
gonna close


Issue when working with WebSockets

From URL: https://flutter.io/cookbook/networking/web-sockets/
When executing this example from the android or ios emulator everything works like expected. When I try it from my actual android device, the connect method states an error that the request was not upgraded. Looking into my server application (asp net core 2.1) the request headers of the emulator look like this:
Cache-Control
no-cache
Connection
Upgrade
Upgrade
websocket
User-Agent
Dart/2.0 (dart:io)
and others.
Whereas the request coming from my pixel 2 device lokks like this:
Cache-Control
no-cache
Connection
Keep-Alive
Accept-Encoding
gzip
User-Agent
Dart/2.0 (dart:io)
and some others.
The question is: Why does the Pixel do not send an upgrade request? Looking into the dart SDK (_http package) the code does not give me any clue why it does not happen. Is this platform dependent, am Ilooking in the wrong driection?

To clarify:
over WiFi it works, but over cellular network the keep-alive header is sent to webserver. How does this come?

https://github.com/flutter/flutter/issues/16875#issuecomment-384758566 might be worth a try

I wonder how a proxy definition issue should be interconnected with this one? could you explain this further?
To clarify, my problems arise when using a cellular connection for the websocket, which is also the reason why I think it is flutter specific and not in the dart sdk.

Sorry, I misinterpreted your comment.

Is this still an issue?
Could it be related to https://github.com/flutter/flutter/issues/13747#issuecomment-451307615 ?


I host project on server and before login page it shows this message.

An uncaught Exception was encountered
Type: RuntimeException
Message: Unable to locate the model you have specified: Authmodel
Filename: /home/m32jqybw1zey/public_html/system/core/Loader.php
Line Number: 348
Backtrace:
File: /home/m32jqybw1zey/public_html/application/controllers/Login.php
Line: 12
Function: model
File: /home/m32jqybw1zey/public_html/index.php
Line: 315
Function: require_once

This is a support question, and should be asked on our forum. We use github for bug tracking.
Read the error message: CI cannot find application/models/Authmopdel.php


Model.create! returns model with nil ID

I have a production Rails 3.2.22 JRuby app that uses activerecord-jdbcpostgresql-adapter version '1.2.9'.
Recently though, I've tried to upgrade to 1.3.19 for some bug fixes (namely .pluck support).  However, it seems that a trivial Rails 3.2.22 app is broken with any version of activerecord-jdbcpostgresql-adapter  1.3.0+.
Any Model.create calls return a model/object with a nil ID rather than the new ID (aka primary key).
I've created a bare bones rails app to demonstrate this:
https://github.com/jrl08d/jruby_test
To reproduce:

Check out app, bundle, create db's, etc
rails c (development or production)
Payment.create

The model that gets returned has a nil ID (which makes it more or less useless).
Loading production environment (Rails 3.2.22)
irb(main):001:0> Payment.create!
  ←[1m←[36mSQL (16.0ms)←[0m  ←[1mINSERT INTO "payments" ("amount", "created_at","notes", "updated_at") VALUES (NULL, '2015-11-18 22:21:59.000000', NULL, '2015-
11-18 22:21:59.000000')←[0m
=> #<Payment id: nil, amount: nil, notes: nil, created_at: "2015-11-18 22:21:59", updated_at: "2015-11-18 22:21:59">

Environment:
jruby 1.7.22 (1.9.3p551) 2015-08-20 c28f492 on Java HotSpot(TM) 64-Bit Server VM 1.8.0_65-b17 +jit [Windows Server 2008 R2-amd64]

Should I chalk this up to no Rails 3.2 support?

This is not an issue on Rails 4.0
I suppose the world has moved on from Rails 3.2

3.2 should be still working - just did no have the time to look into it yet

Fair enough, I'll test any PR if you need.

actually a small isolated test-case or piece of .rb script with everything in 1 place would help fix this sooner.

tried a script as well as your repo - all seems well, you should upgrade your JRuby 1.7.x version :
Loading production environment (Rails 3.2.20)
jruby-1.7.24 :001 > Payment.create!
  SQL (2.0ms)  INSERT INTO "payments" ("amount", "created_at", "notes", "updated_at") VALUES (NULL, '2016-03-04 12:10:13.820000', NULL, '2016-03-04 12:10:13.820000') RETURNING "id"
 => #<Payment id: 1, amount: nil, notes: nil, created_at: "2016-03-04 12:10:13", updated_at: "2016-03-04 12:10:13">


d_a_obj_movebox

osiBLK0, osiBLK1, Kkiba, Hseki2, Hseki7, Mmrr, MkieBB, Ecube, Hjump1, Hbox1, MpwrB, DBLK0, DBLK1, DKkiba, Hbox2

has weak function ordering issues that seem related to its create function (which is not weak itself), Mthd_Create(void*)


Changes for building a ppc64le stemcell for Power8 Ubuntu LE

Assumes that gccgo is installed under /usr/local/gccgo in the machine running the stemcell build commands.

@ipoddar-ibm can you make sure to rebase this PR. I'd rather look at it after the rebase since that's something you'd need to do anyway.
Thanks.

I have rebased this changes to the latest BOSH stable tag (stable-3033). You can find diff with develop branch here: https://github.com/cloudfoundry/bosh/compare/develop...Altoros:power-3033-stemcell.
Still this changes are not completely ready for PR because of some dev artifacts. Also there are some things to be done:

I needed to remove rsyslog-mmjsonparse package, because it was absent in package sources.
I had problem installing system_ixgbevf.
I made changes that rely on this PRs: https://github.com/cloudfoundry/bosh-agent/pull/24 and https://github.com/cloudfoundry/bosh-davcli/pull/1.

Closing - feature set merged in https://github.com/cloudfoundry/bosh/pull/1027


Include M365 Business Premium license in this docs page

Licensing requirements doesn't include the new Microsoft 365 Business Premium license which includes support for Microsoft Defender for Endpoint for SMB customers (<300 seats in the tenant).
According to the following article, macOS devices are also covered by the threat protection from MDE:
https://www.microsoft.com/en-us/security/business/threat-protection/microsoft-defender-business
Reference text: Cross platform: Extend protection across devices for Windows, MacOS, iOS, and Android.
Another reference: https://techcommunity.microsoft.com/t5/small-and-medium-business-blog/introducing-microsoft-defender-for-business/ba-p/2898701
Reference text: Defender for Business helps you to protect against cybersecurity threats including malware and ransomware across Windows, macOS, iOS, and Android devices.
Please confirm macOS is also covered and update the license part of this page to include also Microsoft 365 Business Premium license.
Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 82e9b530-4f11-0483-ed65-42b23082f9f6
Version Independent ID: 38263c08-7cab-7d52-552d-e724ede401aa
Content: Microsoft Defender for Endpoint on Mac
Content Source: microsoft-365/security/defender-endpoint/microsoft-defender-endpoint-mac.md
Product: m365-security
Technology: mde
GitHub Login: @Dansimp
Microsoft Alias: dansimp

@smedin4 Thank you for your feedback. We have added M365 Business premium to the license part via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/7037
Mac  os is also covered and this has been updated in the document.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @smedin4 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


fix title and large labels

@javierarce could you take a look?
Now when the label is very long the text is hidden, talking with @urbanphes we decided add and ellipsis and a title

:D 👍


CoreInk display fades after some time in use

Hi there,
After some time with the display on, something makes it fade. I am using a repeating cycle of wake from deep sleep, clear display, update display with sensor data, wait for user input for 10 seconds, then go to deep sleep for 60 seconds and repeat. After a few hours the ePaper display fades (sorry I don't know exactly how long, but some time).
No amount of my powering down, or resetting, or clearing the display helps unfortunately.
This photo doesn't show it very well, the humidity 41.8% has not faded much, but the battery "Batt: 100%" has faded quite a lot.
 Also if you look closely the background still has some grey which hasn't been cleared properly.
I did some searching, and there is some feature called HV on and HV off for the SPI connection to the ePaper display. This issue is discussed on the M5Stack forum here. Apparently it solves this display fade issue.
I also see the M5Stack library has this HV on and off function for Arduino here and here.
I would like to try using HV on and off using M5Unified but I don't think those functions are currently available. How hard would it be to implement this? I would be happy to test if you need. Maybe I will try using the M5stack library and see if this solves my problem.
Thank you!

Hello, @patfelst . Thanks for letting me know.
Perhaps executing the following command before going to sleep will solve the problem.
M5.Display.powerSaveOn();

Thanks just tried but it doesn't seem to make any difference, but I think my current problem is I cannot turn off the CoreInk properly to reset the display. As far as I can tell M5.Power.powerOff() puts the device in deep sleep (I might be wrong) and pressing reset button on back of CoreInk just, well, resets it.

The M5.Power.powerOff() function operates to turn off power by setting the power hold pin LOW.
CoreInk is deepSleep because the power does not turn off while USB power is being supplied due to circuit specifications.
If the USB is not connected, the power should turn off.

thanks yes that works to power down the device - ie remove USB power and .powerOff()
I'm not sure what fixed it but I did the following and it looks ok again now:

added M5.Display.powerSaveOn() before entering deep sleep
changed the display rotation
played with turning the CoreInk power off (I don't think this played a part now)
changed display mode from M5.Display.setEpdMode(epd_mode_t::epd_text) to M5.Display.setEpdMode(epd_mode_t::epd_fast)

Before I close, what does M5.Display.powerSaveOn() actually do?
Thanks for your help!

M5.Display.powerSaveOn() should do the same as powerHVON() in the CoreInk library.
However, it does not include a delay.
Hence, you may want to wait a few seconds after executing M5.Display.powerSaveOn() before turning off the power.


EBS-CSI addon should default to gp3

Describe the feature
Currently it seems to me like upon installing the EBS-CSI addon it defaults to the gp2 StorageClass. As far as I've checked there seems to be no easy way to change this default on the addon installation, neither is it documented or in any existing issues. One workaround I've adapted from here (https://github.com/aws-ia/terraform-aws-eks-blueprints/issues/986#issuecomment-1258064937) is doing this post cluster provisioning:
        // Remove default tag from gp2 StorageClass volumes
        new eks.KubernetesPatch(this, `${clusterName}-SCGP2-RemoveDefault`, {
            cluster: eksCluster.getClusterInfo().cluster,
            resourceName: "storageclass/gp2",
            applyPatch: {
                metadata: {
                    annotations: {
                        'storageclass.kubernetes.io/is-default-class': 'false',
                    },
                },
            },
            restorePatch: {
                metadata: {
                    annotations: {
                        'storageclass.kubernetes.io/is-default-class': 'true',
                    },
                },
            },
        });

        // Create and set gp3 StorageClass as cluster-wide default
        new eks.KubernetesManifest(this, `${clusterName}-SCGP3-SetDefault`, {
            cluster: eksCluster.getClusterInfo().cluster,
            manifest: [
                {
                    apiVersion: 'storage.k8s.io/v1',
                    kind: 'StorageClass',
                    metadata: {
                        name: 'gp3',
                        annotations: {
                            'storageclass.kubernetes.io/is-default-class': 'true',
                        },
                    },
                    provisioner: 'ebs.csi.aws.com',
                    reclaimPolicy: 'Delete',
                    volumeBindingMode: 'WaitForFirstConsumer',
                    parameters: {
                        type: 'gp3',
                        fsType: 'ext4',
                        encrypted: 'true',
                    },
                },
            ],
        });

Ideally, there should be an option passed to the addon that would install the gp3 SC as default, without needing to patch resources like above.
Use Case
Utilize the newer GP3 EBS volume type.
Proposed Solution
No response
Other Information
No response
Acknowledgements

[ ] I may be able to implement this feature request

CDK version used
2.115.0
EKS Blueprints Version
1.13.1
Node.js Version
v18.19.0
Environment details (OS name and version, etc.)
Ubuntu 22.04 x86_64

@elamaran11 let's review and assign.

Sounds good @shapirov103 We can plan to have someone work on this.

@nrajb Has show interest to work on  this issue.


View servers that employ a certain parameter

For any given parameter, I would like to view servers associated to it. Currently, I can see all the profiles that are attached to a parameter and from that I can figure out the servers that use those profiles but i'd rather just quickly see what servers employ a certain parameter (thru the parameter/profile/server relationship).

I believe Traffic Portal has this feature now. Would you please confirm?


Fix QuarkusCliConfigEncryptIT for Windows OS

Summary
Currently there are some failures in our win jobs related to QuarkusCliConfigEncryptIT because special characters Strings in QuarkusCliConfigEncryptIT class on Windows OS
Please check the relevant options

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Dependency update
[ ] Refactoring
[ ] Release (follows conventions described in the RELEASE.md)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] This change requires a documentation update
[ ] This change requires execution against OCP (use run tests phrase in comment)

Checklist:

[ ] Example scenarios has been updated / added
[x] Methods and classes used in PR scenarios are meaningful
[x] Commits are well encapsulated and follow the best practices

rsvoboda requested a review from michalvavrik 7 minutes ago

this fix is needed, @jcarranzan is testing it ATM, there are other places that could be escaped as well https://github.com/quarkus-qe/quarkus-test-framework/blob/1eac84630b28fd24e2fb1d98efc930e65d8e8e36/quarkus-test-cli/src/main/java/io/quarkus/test/bootstrap/config/QuarkusSetConfigCommandBuilder.java#L62 but it is not required to fix tests itself

I  did a partial fix and additional improvements needs to be done to be working on Windows OS because still there are other issues:
[ERROR] Errors:
[ERROR]   EncryptPropertyTest.encryptSecret_PlainKeyFormat_ExistingEncryptionKey:44->getSecret2:84 ? Runtime java.lang.IllegalArgumentException: Illegal bas
e64 character 5b
[ERROR]   EncryptPropertyTest.encryptedSecret_Base64SecretFormat_GeneratedEncryptionKey:39->getSecret1:80 ? Runtime java.lang.IllegalArgumentException: Ille
gal base64 character 5b
[ERROR]   EncryptPropertyTest.failToDecryptSecretInWrongFormat:60->getSecret3:88 ? Runtime java.lang.IllegalArgumentException: Illegal base64 character 5b
[INFO]
[ERROR] Tests run: 6, Failures: 0, Errors: 3, Skipped: 1

Remaining failure for the set config test I cannot fix after spending days on that. I think when it's consequence of default encoding. We cannot expect that it will work without adjusting of the defaults on executors.


Closes: #1

Sistemato tutto no problema
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[x] Tests pass
[ ] Appropriate changes to README are included in PR

apposto


[Snyk] Upgrade keyv-file from 0.2.0 to 0.3.0

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade keyv-file from 0.2.0 to 0.3.0.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 1 version ahead of your current version.
The recommended version was released 21 days ago, on 2023-12-03.

Release notes

Package name: keyv-file

0.3.0 - 2023-12-030.3.0

0.2.0 - 2020-05-150.2.0

    from keyv-file GitHub release notes

Commit messages

Package name: keyv-file

dd362f0 0.3.0
9d18c9b fix: set & field
5250207 changle import style on first example (#17)

Compare

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cc2cf19) 77.83% compared to head (ba29903) 78.46%.

:exclamation: Current head ba29903 differs from pull request most recent head 953da03. Consider uploading reports for the commit 953da03 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1995      +/-   ##
==========================================
+ Coverage   77.83%   78.46%   +0.62%
==========================================
  Files          40       27      -13
  Lines        3086     2442     -644
  Branches      625      507     -118
==========================================
- Hits         2402     1916     -486
+ Misses        479      365     -114
+ Partials      205      161      -44

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Spotlight cannot handle Pandas DataFrames with Column MultiIndex

When loading a Pandas DataFrame with Column MultiIndex using spotlight.show() Spotlight will not load the columns.
:computer: To reproduce run:
import numpy as np
from renumics import spotlight

df = pd.DataFrame(np.random.random((4,4)))
df.columns = pd.MultiIndex.from_product([[1,2],['A','B']])
spotlight.show(df)

:warning: Spotlight will warn with:
2023-03-02 13:07:29.191 | WARNING  | renumics.spotlight.plugins.core.pandas_data_source:get_columns:111 - Column '(1, 'A')' not imported from `pandas.DataFrame` because of the following error:
'tuple' object has no attribute 'startswith'
2023-03-02 13:07:29.193 | WARNING  | renumics.spotlight.plugins.core.pandas_data_source:get_columns:111 - Column '(1, 'B')' not imported from `pandas.DataFrame` because of the following error:
'tuple' object has no attribute 'startswith'
2023-03-02 13:07:29.194 | WARNING  | renumics.spotlight.plugins.core.pandas_data_source:get_columns:111 - Column '(2, 'A')' not imported from `pandas.DataFrame` because of the following error:
'tuple' object has no attribute 'startswith'
2023-03-02 13:07:29.195 | WARNING  | renumics.spotlight.plugins.core.pandas_data_source:get_columns:111 - Column '(2, 'B')' not imported from `pandas.DataFrame` because of the following error:
'tuple' object has no attribute 'startswith'

:1234: Spotlight displays version:
spotlight, version 1.0.0-pre.9

I confirm this bug, we haven't took multiindex pandas columns into account.
Wirking on this.
@dani2112 would it be alright for you to have (1, 'A'), (1, 'B') etc. as column names in Spotlight? Because this is what pandas gives out as column name. Or do you have another idea?


Custom _ReducerPrinters to enable using loggers

This change enables using custom logging for ._printChanges() for customDump & actionLabels
Example use:
._printChanges(.actionLabels {
  logger.notice("View action: \($0)")
})

@ddeneka Thanks for taking the time to PR!
While _printChanges() is a super useful API for debugging, we're not totally happy with the customization it offers right now. It's very bare bones and may not work for everyone. Even though these APIs are still underscored, we'd still like to give a bit more thought to how we want to evolve them and minimize churn in the meantime, so we may hold off on changes for now. I think the good news is all these APIs are public, so you can make the same customizations in your app without waiting on us to bring changes into the library.
Let us know what you think!

Thanks @stephencelis! You are right, this can be implemented using a public API + grabbing the debugCaseOutput func from the TCA code base.
The ability to use custom logging can be really helpful especially for apps which are outputting a lot of stuff to the stdout.
Thanks again for such a quick response


Server stops sending data when a 0x00  byte is in content

I'm trying to send raw data with the server, but when I have null values in the content, the next bytes are all null. The file size is correct, but I assume it's due to the length header. This is how I did:
    HttpResponse response(HttpStatusCode::Ok);
    // send the framebuffer to the client as an arraybuffer
    response.SetHeader("Content-Type", "arraybuffer");

    const char *framebuffer_ptr = (const char *)framebuffer;
    const std::string framebuffer_str = std::move(std::string(framebuffer_ptr, sizeof(framebuffer)));
    response.SetContent(framebuffer_str);

    // print framebuffer_str as hex values with 2 digits per byte
    for (uint16_t i = 0; i < sizeof(framebuffer); i++)
    {
      std::cout << std::hex << std::setfill('0') << std::setw(2) << (int)framebuffer[i];
    }
    std::cout << framebuffer_str << std::endl;

The bytes are correctly printing in the console of the program, but on the client, only the first bytes are received:
server cout:
1d de ab 41 cd 26 e6 41 79 0 a4 6f 0 a3 84 0 a3 87 0 a3 35 0 86 46 0 92 6d 0 a3 7c 0 a4 7a 0 a4 7a 0 a4 70 0 a3
...

client :
1D DE AB 41 CD 26 E6 41 79 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
...

I can't find by myself where the problem is, I know that all these pointers conversions are not the best choice, but since the server is  minimal, there is no other type for adding content, and I think there is probably a condition where if the string have a null byte, stop sending data.

found out it was in http_server.cc:221 strncpy makes the raw_response->buffer with the error in, while response_string seems OK.

I still don't know how to solve it.

Finally foud out. This is a property of strncopy. When a null byte is met, everything is null then. See https://m.cplusplus.com/reference/cstring/strncpy/.
Just need to replace strncpyby memcpy and everything is good then.

That's a very good catch. Thank you for resolving it


fix: zapper spew

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5591   👈

This stack of pull requests is managed by Graphite.


How many gpu memory do I need to train the model from scratch?

If it is for the UCF Sports dataset, we can set the batch size to 2 on a single 1080Ti. But you may also decrease the length of image features or prediction features length to reduce the model consumption.


Replace user research banner

Introduces GOV.UK Frontend phase banner component
While we were trying to migrate from govuk_template to govuk-frontend
template. An issue was identified with having the user research sign up
banner positioned between the top black header and the colour. It would mean that we could not use GOV.UK Frontend header component
and we would still have to maintain the user research banner and it also
relied on govuk_templates cookie implementation which we would also need
to either copy or remove completely. As this was the only component using
GOVUK.cookie method it would be good to remove it.
This change also brings our designs closer inline with GOV.UK Design System and their recommendation:

Your banner must be directly under the black GOV.UK header and colour bar.

Before

After

Trello: https://trello.com/c/8oD7F688/309-replace-user-research-consent-banner-with-phase-banner-in-the-admin-frontend

Looks much nicer


Relative Image Directory

Currently, the relativeImages script assume that images are going to be stored in a folder called Images relative to the source file. This could be an option added via a YAML metadata file.

tex2html.yaml now has a variable called imageDir which allows a folder to be specified as the location of the image files.


EngSys for C container testing

Resources for EngSys to stand up:

ACR instance -- Public pipelines can download
Documentation for how to update images by pulling from Docker Hub and pushing to the ACR resource

Done: ACR instance
TODO: Documentation for updating image in ACR instance

Docs PR: https://github.com/Azure/azure-sdk-for-c/pull/2615/files


libva: 2.21.0 -> 2.22.0

Description of changes
Bump libva, adds support for wayland-dmabuf which fixes va-api based decoding on sway master.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofborg build libva


Add option to pass in different env vars

If we need to move away from the default set environment variables which are set elsewhere, we need to be able to break them out and specify them by class as we are unable to differentiate by specific node class where
we set our secrets in hieradata.
This allows us to set a different PATH for the CI cluster.

I think this will work but it's a little bit confusing:

govuk_ci::master has a parameter set in hieradata which is passed through to govuk_jenkins and then to govuk_jenkins::config
We also set hieradata on govuk_jenkins::config directly for the deployment Jenkins

So I think this works because class parameters that are passed in have higher precendence than hieradata.
I wonder if it would be more clear to add another parameter to govuk::node::s_jenkins and pass that through in the same way that govuk_ci::master passes things through (for consistency), and then change the existing hiera keys.

Sounds like a sensible idea.

@alexmuller I've added a new commit which makes this more explicit.


Add automatic upload flag on false no-upload flag

Currently it is not possible to add the attestation to the transparency log as the --yes flag was unset.
Also I've noticed that keyless signatures work, but keyless verifies are not possible due to those requiring a couple flags. Added a TODO for this as it is not necessary for our use case, but should nonetheless be a feature.
The attest-verify command is really janky, should probably split it as a subcommand, as mentioned in a TODO

Totally fair 👍🏾  merge and release as soon as its finished.


update appveyor config to build protobuf

Coverage remained the same at 1.394% when pulling 54d5d936475348ed8fc687098315f0c7d7cc19b9 on appveyor into 6c525480d0590380fcd3531d172b485a5f78b17e on master.


Errors throw in logs when some API commands are used.

info: System.Net.Http.HttpClient.ApiClient.ClientHandler[100]
      Sending HTTP request GET https://api.faforever.com/data/game?include=mapVersion,playerStats,mapVersion.map,playerStats.player,featuredMod,playerStats.player.globalRating,playerStats.player.ladder1v1Rating,playerStats.player.clanMembership.clan&filter=playerStats.player.login==Soyvolon
[2021-01-20 18:01:50 -05:00] [104 /EventHandler] [Error] Event handler exception for event MESSAGE_CREATED thrown from System.Threading.Tasks.Task QMmands_MessageCreated(DSharpPlus.DiscordClient, DSharpPlus.EventArgs.MessageCreateEventArgs) (defined in Faforever.Qai.Discord.DiscordBot)
Emzi0767.Utilities.AsyncEventTimeoutException`2[DSharpPlus.DiscordClient,DSharpPlus.EventArgs.MessageCreateEventArgs]: An event handler caused the invocation of an asynchronous event to time out.
[2021-01-20 18:01:50 -05:00] [104 /EventHandler] [Error] Event handler exception for event MESSAGE_CREATED thrown from System.Threading.Tasks.Task Client_MessageCreated(DSharpPlus.DiscordClient, DSharpPlus.EventArgs.MessageCreateEventArgs) (defined in DSharpPlus.DiscordShardedClient)
Emzi0767.Utilities.AsyncEventTimeoutException`2[DSharpPlus.DiscordClient,DSharpPlus.EventArgs.MessageCreateEventArgs]: An event handler caused the invocation of an asynchronous event to time out.

Command still executes properly, but the command handler errors.

Is this still an issue? Cause I fixed an issue with the clan parsing

Is this still an issue? Cause I fixed an issue with the clan parsing

No it is still a problem, but thats mainly because the commands are for some reason holding up the event handler. Which means I need to go refactor that to prevent timeouts on long running commands.

No it is still a problem, but thats mainly because the commands are for some reason holding up the event handler. Which means I need to go refactor that to prevent timeouts on long running commands.


Datasource absent

wildfly::datasources::datasource doesn't pass on an ensure attribute to wildfly::resource
support ensure => absent for datasource

don't enable for absent configuration

A future enhancement could add ensure -> disabled to keep the configuration around.

Just a warning that because I omitted the ordering arrow, this requires either puppet v6 or default v4+ ordering=manifest.


[Question] Is there a way to allow a state's resolve to map to the target component's resolve property?

UI-router: 1.0.0-beta.3
Angular: 1.5.8
Is there a way to allow a state's resolve to map to the target component's resolve property? It would be really nice if there were some way to accomplish this so that the "resolve logic" could live with the component rather than in the code where the states are defined.
For example...
BEFORE:
app.js
// Defining states
{
    name: 'people',
    url: '/people',
    component: 'people',
    resolve: {
        delayedData: function($q, $timeout) {
            // Set up a promise to return
            var deferred = $q.defer();

            // Simulate an external request, this could be an $http.get() in a real app
            $timeout(function() {
                var myData = { message: 'This string is the external data.' };
                deferred.resolve(myData);
            }, 1000);

            return deferred.promise;
        }
    }
},
...

AFTER:
app.js
// Defining states
{
    name: 'people',
    url: '/people',
    component: 'people',
    resolve: PeopleController.resolve    // or possibly people.resolve
},
...

people.component.js
(function () {
    'use strict';

    angular
        .module('moduleName')
        .component('people', {
            templateUrl: 'people.component.html',
            controller: PeopleController,
            bindings: {
                delayedData: '<'
            }
        });

    PeopleController.$inject = ['$log', '$q', '$timeout'];

    function PeopleController($log, $q, $timeout) {
        let vm = this;

        vm.resolve = {
            delayedData: function($q, $timeout) {
                // Set up a promise to return
                var deferred = $q.defer();

                // Simulate an external request
                $timeout(function() {
                    var myData = { message: 'This string is the external data.' };
                    deferred.resolve(myData);
                }, 1000);

                return deferred.promise;
            }
        };

        vm.$onInit = onInit;

        function onInit() {
            $log.info('initializing people component...');

            $log.info('delayedData: ' + vm.delayedData.message);
        }
    }
})();

The resolves are processed before the controller is instantiated.  So the resolve function can't be created as part of creating the controller, as in your example.
What you can do is attach the resolve function as a static member to the controller. Instead of
function PeopleController($log, $q, $timeout) {
        let vm = this;
        vm.resolve = {...}
}

try something like:
function PeopleController($log, $q, $timeout) {
        let vm = this;
        ...
}
PeopleController.resolve = {...}

Thanks @adharris , good advice


Allow opt-in to restore NVM backups without checking for compatibility with the target controller

Checklist

[ ]  I am not using Home Assistant. Or: a developer has told me to come here.
[ ] I have checked the troubleshooting section and my problem is not described there.
[ ] I have read the changelog and my problem is not mentioned there.

Deploy method
Docker
Z-Wave JS UI version
2.0.1
ZwaveJS version
0.1.93
Describe the bug
I made an NVM Backup from my currentlich running Aeotec Gen5 and tried to restore that backup to aother Stick of the same make and kind.
The restore stated with "converting ..." (for whatever reson) and after reaching 100% it stated theat it couln't find a matching converter.
The restore failed.
To Reproduce
Just as I described above
Expected behavior
to get a copy of my setup on a second stick
Additional context
Homeassistant 2023.3.9  on OS10,5 using supervisor 2023.09.2

@umtauscher If you are using docker and you don't want to wait for next release, you should be able to test the fix on master by using master tag in one hour from now

Tanks, unfortunaltely I will stay with my existing instalation.
I 'll wait, I have just restored to my backup stick with the old Aeotec tool. So I have time.
Thanks for the proposal anyways.
Cheers

Btw, just a quick question: If I risc installing the 1.02 firmware to the stick (Aeotc themself warn about bricking it in the process) would I then be able to use the normal restore function?

Yes, that one is supported - and it can also be migrated to newer sticks, unlike the 1.1 NVM.

Sorry, but dues to the zwave updates NVM-backup is now unusable for this configuration.
Tonight was the second time that NVM Backup froze the stick.
Should I open another thread for it youwould you like to continue here.
I was using NVM backup für at least a year without problems but something seems to be messes up.
Sorry

You can send me a log via discord, so I can look if that's a bug or usage error

All logs were disabled this night, sorry.
What usage error could cause this?
I am running homeasistant on a proxmox server. To get zwave back, I had to shut down the server completely, because the port the stick was using was nonexistant any more. A software restart wasn't enough, neither was unplugging and replugging the stick. I seemd as if the power on the usb port had been switched off.
I have deactivated nvm backup for now, which was running before every sunday at 3 am.

Could be that the VM isn't configured correctly to handle the controller reconnecting and you don't have soft-reset disabled.
See https://github.com/zwave-js/node-zwave-js/issues/6341

Ok, so what I have read up to now, the behaviour concerning the reset of the stick changed about 2 weeks ago.
That is consistent with the problems start.
At least that's an explanation.
Thanks


[BACKLOG-6496] - Database lookup step with "=" comparator fails on 6.1

use only those fields that are needed for look-up (fix an error introduced in PDI-3314)
add a test

@brosander, @deinspanjer, review it please

Build Commands:
Build:

rm -r ~/.kettle; rm -r ~/.pentaho; echo removed hidden folders
ant -Djunit.jvmargs=-XX:PermSize=256m -f engine/build.xml clean-all resolve jacoco jacoco-integration checkstyle publish-local

Cleanup:
rm -r ~/.ivy2/local || echo no publish local to remove
Changed files:
engine/src/org/pentaho/di/trans/steps/databaselookup/DatabaseLookup.java
engine/test-src/org/pentaho/di/trans/steps/databaselookup/DatabaseLookupUTest.java
Checkstyle violations:
See: https://github.com/pentaho/pentaho-coding-standards
File engine/test-src/org/pentaho/di/trans/steps/databaselookup/DatabaseLookupUTest.java

Message: Using a static member import should be avoided - java.util.Collections.singletonList. at Line: 59 Column: None
Message: Using a static member import should be avoided - org.hamcrest.CoreMatchers.instanceOf. at Line: 60 Column: None
Message: Using a static member import should be avoided - org.hamcrest.CoreMatchers.is. at Line: 61 Column: None
Message: Using a static member import should be avoided - org.junit.Assert.assertArrayEquals. at Line: 62 Column: None
Message: Using a static member import should be avoided - org.junit.Assert.assertNotNull. at Line: 63 Column: None
Message: Using a static member import should be avoided - org.junit.Assert.assertThat. at Line: 64 Column: None
Message: Using a static member import should be avoided - org.mockito.Matchers.any. at Line: 65 Column: None
Message: Using a static member import should be avoided - org.mockito.Matchers.anyInt. at Line: 66 Column: None
Message: Using a static member import should be avoided - org.mockito.Matchers.anyBoolean. at Line: 67 Column: None
Message: Using a static member import should be avoided - org.mockito.Matchers.anyString. at Line: 68 Column: None
Message: Using a static member import should be avoided - org.mockito.Matchers.eq. at Line: 69 Column: None
Message: Using a static member import should be avoided - org.mockito.Mockito.*. at Line: 70 Column: None

Unit test coverage change:
org.pentaho.di.trans.steps.uniquerows.UniqueRowsMeta:

instructionPercentCoverageChange :-0.17%

org.pentaho.di.trans.steps.databaselookup.DatabaseLookup:

instructionPercentCoverageChange : +0.45%
branchPercentCoverageChange : +0.52%
linePercentCoverageChange : +0.54%
complexityPercentCoverageChange : +1.16%
methodPercentCoverageChange : +1.10%

org.pentaho.di.job.entries.sql.JobEntrySQL:

instructionPercentCoverageChange :-1.64%
linePercentCoverageChange :-1.97%

org.pentaho.di.repository.kdr.KettleDatabaseRepositoryCreationHelper:

instructionPercentCoverageChange :-2.43%
branchPercentCoverageChange :-1.64%
linePercentCoverageChange :-2.95%
complexityPercentCoverageChange :-0.69%

org.pentaho.di.trans.step.StepMeta:

instructionPercentCoverageChange :-0.19%
linePercentCoverageChange :-0.27%

@brosander, I see static import violations in test classes. Are they correct? IMO, for Mockito they should be suppressed. @dkincade, @lucboudreau, can you clarify it please?

Is there a reason why they need to be used? If so then I would allow for test cases but I would prefer they not be used without a good reason.
Thanks,
David
On Feb 5, 2016, at 6:31 AM, Andrey Khayrutdinov <notifications<EMAIL_ADDRESS>wrote:
@brosanderhttps://github.com/brosander, I see static import violations in test classes. Are they correct? IMO, for Mockito they should be suppressed. @dkincadehttps://github.com/dkincade, @lucboudreauhttps://github.com/lucboudreau, can you clarify it please?

Reply to this email directly or view it on GitHubhttps://github.com/pentaho/pentaho-kettle/pull/2132#issuecomment-180308077.

@dkincade, Mockito's API is based on static imports, they make it concise and easy-to-read. Compare:
verify(a, atLeastOnce()).call()

and
Mockito.verify(a, Mockito.atLeastOnce()).call()

I do think the first is better. moreover, everyone use static imports in these cases.
The same happens with JUnit's Assert class

@brosander, review it please. I still insist Checkstyle settings should be amended to let using static imports either of several classes (Mockito, Assert, CoreMatchers, etc.) or of any class in tests

Hey Andrey, I'm on PTO today.  If it's urgent please contact womprats or r2d2.
On Feb 8, 2016 2:46 AM, Andrey Khayrutdinov<EMAIL_ADDRESS>wrote:
@brosanderhttps://github.com/brosander, review it please. I still insist Checkstyle settings should be amended to let using static imports either of several classes (Mockito, Assert, CoreMatchers, etc.) or of any class in tests

Reply to this email directly or view it on GitHubhttps://github.com/pentaho/pentaho-kettle/pull/2132#issuecomment-181243340.

@brosander, ok, have fun :)
That is not very urgent but should be processed before 6.1 is released


Use slice::iter

This helps https://github.com/rust-lang/rust/pull/65819

@AltSysrq Could you merge this tiny fix soonish? That would be great as lots of crates depend on proptest.
And have you considered getting the Rust Bus on board to help with maintaining? Just in situations where you don't have the time to invest into open source, so that important crates of the Rust ecosystem can be preserved. Thanks for your consideration :)

@AltSysrq Hey Jason :) Since I wrote non-trivial parts of this crate as well as wrote proptest_derive, if you want, I could help you actively maintain the crate, including with reviewing new feature development where needed.

@AltSysrq Could you have a little time to look at this PR?