Improve Footer Component

Improves layout of footer component
Adds (stub) links to footer navigation
Adds links to socials
Fixes #5

I'm confused, why did you create a new pull request?

Also, I have edited the title and the description of your pull request. It's important for us reviewers that your title and your description clearly describe the code you are submitting.

Hello! Please see my comments below.
Also, your yarn.lock file is still causing conflicts with the main branch; you can't merge if you don't solve them (just run yarn to install all dependencies and update the lock file). Finally, if you're done with #27 please close it.

Hello!  Today I was very busy but I will work on it tomorrow morning. Also, there is a bug that I am unbale to fix it. The problem is when hover on icons the color won't change. Could someone check it? Thank you

If you fix the issues I described in the comments related to the theme, that issue with the icons will also be fixed.

Thanks for the patiente @mojvaf! I think it looks fine now. I pushed some extra changes because I made a mistake in the code-style auto-fixer, but now it looks ok.

@all-contributors let's add @mojvaf for code!

@all-contributors let's add @mojvaf for code!

@all-contributors let's add @mojvaf for code!

Thanks


Update rubocop

Coverage decreased (-8.0e-05%) to 99.908% when pulling 99483ae1728b38308c80352f02b6c758eb889f57 on update_dependency into 7bdd24f93bf9b23dd7bb911840451273fbc1883c on master.


Use bootstrap in front page

Use the react-bootstrap components for the front page

frontend has been redesigned => close issue?


No close button, downloadbutton and navigation arrows

I'm getting these errors in the console:
Error: undefined is not an object (evaluating 'scope.index')
getImageDownloadSrc@http://xxx.xxx.xxx.xxx/Galley/js/ngGallery.js:128:43
Error: undefined is not an object (evaluating 'scope.index')
showImageDownloadButton@http://xxx.xxx.xxx.xxx/Galley/js/ngGallery.js:122:43
When I click an image there is no downloadbutton, nor close-button, and there are also no left and right arrows.
This is my JS code:
`var app = angular.module('galley', ['jkuri.gallery']);
app.controller('Ctrl', ['$scope', '$http', '$document', function($scope, $http, $document){
$http.get('images.json').success(function(data){
	$scope.images = data;
})

}]);`
How to fix this? Is my code wrong?
Gtrz,
MaccerC

Hi!
Could you please post an complete example including the html file?
What does "data" contain? If it's JSON you should probably parse it first and then assign it to $scope.images.

I've made a plunk. You can find it here: https://plnkr.co/edit/5hRnS8vNmr88t9DWOuis
Unfortunately I was not able to get the images in this plunk. I have them locally.
'Data' is the response from $http.get.
I renamed data to 'resp' as you can see in my code.
It's indeed JSON. But I think it's a proper JSON file and I am not sure if I should parse it first before assigning it to $scope.images.

If I open your plunkr example I get multiple errors:
ReferenceError: System is not defined  angular2.min.js:1:19 ReferenceError: angular is not defined  ngGallery.js:4:5 ReferenceError: angular is not defined
Also I'm not sure if ngGallery works with AngularJS 2 (which is used in your example).
It would be really nice if you could upload a complete example (maybe without the Ajax request, just hardcode the $scope.images in your controller).

I'm very sorry I didn't check the Angular version. I didn't mean to use Angular 2.
Now I've changed it in my Plnkr: https://plnkr.co/edit/5hRnS8vNmr88t9DWOuis?p=preview
However, I don't know how to give you a complete example. I hardcoded the $scope.images in which I put the url where the images are stored. But they don't show up so I can't show the problem where it's all about.

Hi MaccerC,
I tried to fix your plunkr:

Add ngGallery.css
Added ng-app and ng-controller in index.html
Added Font-Awesome
Fixed typo in your ng-app name

Now it seems to work:
https://plnkr.co/edit/MZ5NWlmhY7rqOxvXSuJv?p=info
Cheers,
Chris

Great! Now it works like a charm. I'm very sorry for my own mistakes and typo's....


[BEAM-7413] Fixes bug in partitioning of GroupNonMergingWindowsFunctions

We run our Beam pipelines on Spark. Since upgrading from Beam 2.8.0 to 2.12.0 we experience a very high number of tasks per stage (in the millions).
The two relevant tickets that have introduced this behavior are:
https://issues.apache.org/jira/browse/BEAM-5392
https://issues.apache.org/jira/browse/BEAM-4783
Both are good changes that should remain, no question there.
The underlying issue is the HashPartioner that is used in the new GroupNonMergingWindowsFunctions#groupByKeyAndWindow method. The partitioner that used to be there would reduce the number of partitions to the parallelism that was set when the pipeline was started. The partitioner that is there now, does no longer do this.
The fix: I have added the partitioner as an extra argument, so we can supply the same partitioner throughout the pipeline. Because the partitioner can be null, I have added the fallback to be the one that it was before:
  private static <K, V> Partitioner getPartitioner(
      Partitioner partitioner, JavaRDD<WindowedValue<KV<K, V>>> rdd) {
    return partitioner == null ? new HashPartitioner(rdd.getNumPartitions()) : partitioner;
  }

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[X] Choose reviewer(s) and mention them in a comment (R: @username). I have contacted the #beam-spark slack channel and will add suggested reviewers as soon as I know the best person(s) to add.
[X] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[N/A] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Run Spark ValidatesRunner

Thanks for the fix, and sorry for the delay to review. It looks ok.
I had not noticed this PR is opened against 2.12.0 branch, can you please create the PR against master. We need to get the fix into master first and eventually cherry pick it. Notice that there is not guarantee that we will do a 2.12.1 release with it, so you should probably upgrade to version 2.14.0 to get the fix.

Thanks @iemejia for the review. No worries it took a few days. I'm back in the office on Friday and will create a new PR against master.

Great to know, I assigned you the JIRA ticket and marked the issue for inclusion in 2.14.0 so we don't miss it.

Closing this one in favor of #8785


Fix missing comma in config.json.j2

Сorrection of missing comma when specifying consul_limits.

Thanks!


JSON Schema Type Conversion / Coercion

Hi there. I've been looking through the docs & existing issues but am having a hard time finding information about this.
Is there a standard way to handle type coercion with JSON Schema?
For instance, I have a select input with integer values but by simple virtue of being a select input the values will always be strings. In my DB, however, they need to be integers. If I try to input this data get a ValidationError. Checking every place some front end JavaScript messes with a type would be rather cumbersome.
Most general way I have found so far is to define a $parseJson on a BaseModel, look for keys that should be numbers, and make a conversion there. Is the generally The Way or is there a more built in approach to this? If there isn't would you want a built in approach?
Thanks for reading.

Hi,
Objection uses ajv as the json schema validator. You can enable the coerceTypes option.
This is how you can override ajv options:
class BaseModel extends Model {
  static createValidator() {
    return new AjvValidator({
      onCreateAjv: (ajv) => {
        // Here you can modify the `Ajv` instance.
      },
      options: {
        allErrors: true,
        validateSchema: false,
        ownProperties: true,
        v5: true,
        coerceTypes: true // <--- !!!
      }
    });
  }
}

const { BaseModel } = require('./base-model')

class Person extends BaseModel {
  ...
}

Let me know if this works

That works fantastically, thank you!


Error while running the script

When i run the following command, i see an assertion error
python splitter.py --spk rishabh
Loaded the voice encoder model on cpu in 0.01 seconds.
Traceback (most recent call last):
  File "/Users/gagandeepsingh/Projects/ColorSplitter/splitter.py", line 44, in <module>
    labels = Cluster.__call__(embeds)
             ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gagandeepsingh/Projects/ColorSplitter/modules/cluster.py", line 154, in __call__
    assert len(X.shape) == 2, 'Shape of input should be [N, C]'
AssertionError: Shape of input should be [N, C]

I have no idea what this means.

    - input
        - <speaker_name>
            - raw
                - wavs
                    - audio1.wav
                    - audio2.wav
                    - ...

Please check your file structure as shown above
Delete the *. pkl file in the folder... <speaker>\


Add PyPy manifest to extras bucket

Wouldn't it better to name it pypy2.json? Just in case pypy3 for windows gets released. Also the zip file itself is called pypy2 :smile:
Can you add the hash property to extract the checksum from the download page?
    "autoupdate": {
        "url": "https://bitbucket.org/pypy/pypy/downloads/pypy2-v$version-win32.zip",
        "extract_dir": "pypy2-v$version-win32",
        "hash": {
            "url": "https://pypy.org/download.html"
        }
    }

yes you are probably right i just thought naming it pypy would follow the convention used for python

The build-in regex  works fine because they include the checksums as standard sha256sum output format. :smile:

Fixed and i just noticed in the commit i did before applying your suggestion i didnt even have the hash object so regardless of if i had the regex correct it would not have been applied.

The mode property can be omitted because it's the default.


WT should start up fast: profile the startup path and trim anything that takes a while

Steps to reproduce

Click to launch Windows Terminal

Expected behavior
Windows Terminal should be ready instantaneously like windows console, or like Sublime Text.
Windows Terminal can't be slower than windows console.
While Windows Terminal is fast compared with other tools like Visual Studio, or iTunes, it is still not fast enough for a Terminal application.
Actual behavior
It takes too long to startup. It is not ready instantaneously. It's not as fast as windows console.

maintainer note: hijacking OP for task list:

[x] Use exactly one ColorPickerFlyout for all tabs, and just redirect it to whatever tab activated it.
[x] Delayload the ColorPickerFlyout.
[ ] Add a setting to disable ALL fragments / dynamic profiles. The app catalog search is expensive.

~Maybe we can just skip loading dynamic profiles on initial launch, unless we discover that the defaultProfile is a dynamic one...~ Nah, cause what about for defterm launches that end up matching a dynamic profile.

I mean, the Terminal is doing a lot more than the console ever was. I'm not sure there's much more we can do to optimize our UI setup. Conhost was using basically the simplest Win32/GDI interface possible, and the Terminal needs to stand up a XAML stack. Even if we somehow had a server process that already had the settings pre-loaded, we'd still need to stand up the UI stack.
At least the Terminal is faster at processing output than the console ever was, and opening new tabs/panes is certainly faster than opening a new conhost is.
Maybe there's something we can do here to optimize the creation of the XAML stack.

and the Terminal needs to stand up a XAML stack

XAML stack means UWP?

and the Terminal needs to stand up a XAML stack

XAML stack means UWP?

This uses a Xaml Island for now, but with WinUI 3.0 Xaml will not be tied to UWP, and can be used with Win32 code

To be technically correct - the Terminal is a Win32 application that's using Xaml Islands to host UWP XAML content in it's window, and is (typically) run as a packaged application.
The lines between what constitutes a "UWP" and a "Win32" application are becoming more and more blurred every day, and the Terminal is a great example of a hybrid application that can utilize both technologies.

@zadjii-msft Would it be possible to eliminate the XAML stack entirely from the equation? Using a combination of directx/directcomposition/win32 technologies to create the UI. I mean terminal really doesn't "require" XAML, most of its UI is pretty straightforward, and should be pretty easy to do in c++. The most important part I believe is the TermControl that is needed for a minimum viable product. Have you investigated this scenario/ is there interest in it. I surely would love to make this happen.

I mean, that's a possibility, sure, but I think as the Terminal UI gets more elaborate, using DComp for the entire UI is going to be less and less feasible. Plus, if we do want 3rd party developers writing extensions to provide their own UI elements for the Terminal (see #4000), it'd probably be more developer-friendly to ask them to write XAML components rather than DComp visuals

To be technically correct - the Terminal is a Win32 application that's using Xaml Islands to host UWP XAML content in it's window, and is (typically) run as a packaged application.
The lines between what constitutes a "UWP" and a "Win32" application are becoming more and more blurred every day, and the Terminal is a great example of a hybrid application that can utilize both technologies.

It looks and feels like a UWP app though. Maybe that's the problem.

@zadjii-msft Would it be possible to eliminate the XAML stack entirely from the equation? Using a combination of directx/directcomposition/win32 technologies to create the UI. I mean, terminal really doesn't "require" XAML, most of its UI is pretty straightforward, and should be pretty easy to do in c++. The most important part I believe is the TermControl that is needed for a minimum viable product. Have you investigated this scenario/ is there interest in it. I would love to help to make this happen. But I understand that would require significant resources, and currently, optimizing XAML is the best bet.

Part of the idea for this project is to modernise the terminal UI and feature set, supporting multiple console types, and show the best of Windows.
Choosing not to implement the modern UI stack, is not within that scope.  Windows 10X's shell has moved to XAML, and XAML is being decoupled from the OS and being open sourced, so the community can push it forward, without relying on new OS updates.
By the end of the year, all the code should be in the GitHub, and then the community can explore how to improve performance.
The app is using C++ and so is XAML.  Being able to move out of the use of an Island will possibly bring with it some perf benefits by default

To be technically correct - the Terminal is a Win32 application that's using Xaml Islands to host UWP XAML content in it's window, and is (typically) run as a packaged application.
The lines between what constitutes a "UWP" and a "Win32" application are becoming more and more blurred every day, and the Terminal is a great example of a hybrid application that can utilize both technologies.

It looks and feels like a UWP app though. Maybe that's the problem.

It is the direction Windows is moving in, so its not like it looks like UWP, but Windows is moving towards that UI everywhere.

It is the direction Windows is moving in, so its not like it looks like UWP, but Windows is moving towards that UI everywhere.

Well, I can't really do anything about that other than to give feedback as I am doing, and avoiding Windows updates and eventually moving out of the Windows platform.

I mean, that's a possibility

So you're telling me there's a chance /s
I hope winUI 3.0 alleviates this situation.

@AnuthaDev it’s nowhere near ready for primetime use (by developers who we can’t go bother when stuff goes wrong), but this repository does produce a WPF control that’s really just a standard Win32 HWND with the terminal surface on it. It’s pretty much the DirectWrite renderer wired up to a surface.
Our long term plan sees us producing composable controls other developers can integrate into their own experiences.
If only we had all the time in the world :smile:

If only we had all the time in the world :smile:

@DHowett-MSFT  Okay, serious question. Suppose somebody else does the entire work, what would your preference be XAML or win32 HWNDS (Provided that win32 significantly reduces memory consumpition and startup time)?

WinUI Desktop will use HWNDs for it's window implementation, but will use XAML UI (which uses DirectX to render to the screen)

Well, I can't really do anything about that other than to give feedback as I am doing, and avoiding Windows updates and eventually moving out of the Windows platform.

Why would you avoid future Windows updates? WinUI 3.0 brings many benefits, and as a dev, you're never going to be forced to update WinUI either. Opting out of Windows updates seems to be counter-productive in general  - or are you just making an orthogonal, abstruse gesture about your displeasure? It may be more effective to visit the new WinUI 3.0 site and assuage your worries.

WinUI Desktop will use HWNDs for it's window implementation, but will use XAML UI (which uses DirectX to render to the screen)

Ah, there's a difference between HWNDs and HWND. in XAML there is only parent HWND window, while in classic win32 every control has a HWND

WinUI Desktop will use HWNDs for it's window implementation, but will use XAML UI (which uses DirectX to render to the screen)

Ah, there's a difference between HWNDs and HWND. in XAML there is only parent HWND window, while in classic win32 every control has a HWND

Yea, that is a very classic windows concept.  Every control is also a Window.
@oising  I think he is maybe expressing a preference for the Win32 visual look, compared to the Windows 10/WinUI look.  Could be the density of controls, or just an old school familiarity with WinForms / WPF.

density

So, WinUI 2 started to offer a "Compact" sizing dictionary that changes control sizes to more closely match classic Win32. That might be worth investigating.

After testing: on account of we don't have too much UI right now it doesn't really help us.

Density keeps to the 32px min height for touch controls like buttons and text boxes I believe.  The flyouts from the Add Tab button could be affected, but until WinUI 3, flyouts are not affected by setting a compact density.

Now, I'm going to mark and minimize all the complaining about our choice in UI framework as off-topic and turn this into the issue for "make sure terminal launches fast". Kay? Kay.

Would running WT in tray be an option? It would not necessarily improve "startup" but it would make it unnoticeable. Would also fix quake mode not running unless there's a WT window open.

Sure, that's more of a request we're working on over in #9996.

@vannomad It's well known that windows terminal is extremely slow.
I've been using wezterm for a while. It does not mantain a tray icon, and it is lightning fast, starts up instantly! And even then people complain that wezterm is slow
It most definitely is not slow compared to windows terminal.

One thing I didn't see mentioned: Terminal currently starts up slow enough that if you hit enter and start typing, you will not only lose key-presses, you will lose focus, meaning that terminal will never get any input until you click the window.
I.e. you type terminal in the start menu, hit enter, then type "dir" or whatever, that first 'd' will happen long before terminal is actually active, so it gives focus to something else. Where does that keypress go? The "next" window? I'm not sure! Wherever it goes, it activates that window, which then prevents Terminal from getting focus once it gets around to actually launching. And at that point, Terminal will just be an inactive window that doesn't get any input until you take some manual action to give it focus.
So, at a bare minimum: Terminal needs to start up and immediately take focus, then buffer all the input keys so they can be fed to the command line. This needs to happen fast enough that I don't lose focus.
That's the bare minimum, but really in 2021 you shouldn't be able to say "one Mississippi" before a simple app like Terminal is not only launched and activated, but fully initialized.  That's an eternity. Really, terminal should be up and running and fully initialized before the key-up event on the enter key that launched it. I realize this is a hard problem because it's very likely the problem is in the UWP/XAML stack. Indeed, calculator suffers from the exact same problem these days, where the new version of the app loses input because it is just sooooo slow to launch. So I get that this may not be something you can entirely fix on your own, but you can add a requirement to the XAML folks to improve their startup performance (as well as do whatever you can do on your own side to mitigate the problem).
Indeed, I would argue that taking a XAML dependency in Terminal (and Calculator) before verifying that its performance was acceptable was a mistake. Backing out of that mistake until XAML achieves reasonable performance for core apps like Terminal and Calculator is not at all unreasonable IMO. It really doesn't seem like you actually need XAML for the core window/terminal area at all (maybe keep it for settings and initialize it asynchronously?).

One thing I didn't see mentioned: Terminal currently starts up slow enough that if you hit enter and start typing, you will not only lose key-presses, you will lose focus, meaning that terminal will never get any input until you click the window.

Yeah, I'm none-too-pleased about that. We're booking launch time perf into 1.11 thanks to this and other discussions (and regressions :|)

Just did a quick trace with some selected events:

So while XAML is indeed taking up a fair mount of time, it doesn't seem like it's responsible for most of it. For example, do we really need to wait until >1s in before we launch the processes for conhost and cmd.exe? Or could we launch them right away (in parallel with all the other processes that launch, and in parallel with XAML initialization)? And why is this ScriptedSandbox64 launched so late compared to the rest of the processes (no idea what that is).
Note that nothing really happens until 240ms in, so I guess that's the sort of "floor" of how long windows takes to launch anything (and maybe launching via VS is an issue here too).
Looking at the UI thread:

Again we see a big gap before anything happens at all on the UI thread, but then there's another big gap in the center before we reach the steady state rendering at the end. That middle gap seems to be mostly about the setup that happens in the render thread initialization (part of this is a slow initial render I think?):

Perhaps the render thread could be initialized at the very beginning of the process launch rather than waiting for XAML (and conhost/cmd.exe etc.) to finish first? So that it's (hopefully) ready to go by the time it's needed? Seems like it currently needs the swapchain to initialize, so I'd recommend trying to refactor that so you can get most things initialized (esp. DirectX, DirectWrite,
etc.), and then resize at the end and wire it up to XAML.

One of my takeaways from https://github.com/microsoft/terminal/issues/6409 / https://github.com/microsoft/microsoft-ui-xaml/issues/2648 was that XAML stack also loads a lot of useless libraries (even including Maps control) and probably this requires at least some useless accesses to hard disk

I just want to add feedback to this particular issue:

Currently, the Windows Terminal (1.14.1962.0) cold startup with the default profile of CMD takes at least 3-4 seconds on a new powerful machine: i9-12900K @ 5GHz with plenty of 32GB RAM and NVMe PCIe Gen4 disk ...
Idk what is going on but I tried to eliminate every possible setting to reduce the startup cost, but it's still a very noticable for me.
I tried fresh reinstall of the app, purging the settings folder, installing from the Store/winget/etc... nothing helps.
Using the ProcessExplorer from the SysInternal tools, I can see that WT initialization takes significant time, after which, cmd/powershell is started instantly.

Is that the case for anyone else or it's just me?

Idk what is going on

Ultimately, that's what's important- knowing what is going on here. Measurements of how long it takes on various CPUs isn't helpful. Actual traces of the startup, which can identify the bits of startup that are taking the longest, that's what's actually important to this thread. I've got some traces higher up that we're starting with. We'll start there, unless someone can narrow down some part of XAML init that's more costly that we can trim out.

I assume that there is something related to Xaml, because while searching on google/github/reddit for this issue, I saw this strange behavior happening at the start bar:

So I assume that it might be related. But sadly Idk how to debug further. I will try to search for additional instructions on how to run a debug build of Windows Terminal or running some kind of profiling.

It's probably a good idea to save this here just in case we need it later...
(WPR trace of starting 10 instances of Windows Terminal Preview 1.16.2142.0.)

I vote to have jumplist generation opt-in via settings. Seems like a quick win. Who uses jumplists with terminals that much? Is there telemetry on this?

jumplist generation opt-in via settings

Yea I'm not gonna do that. #576 was one of the biggest feature requests. Definitely not gonna disable that by default. A more sensible fix might be to wait until after TerminalPage::_CompleteInitialization to kick off the first UpdateJumplist. I know we're requesting it on a background thread, but I guess presumably, that just creates a thread that could ask for time slices before we've got the window on the screen.

Another optimization we discussed at least on Teams - stashing the initial size in state.json somewhere. Any time we hot-reload the settings, kick a BG thread to evaluate how big the window should be for the initialRows/Cols and the default profile's[1] font settings. On launch, we could avoid the cost of looking up the font to do that math most of the time, just use the dip we already precalculated. That would cause the initial size to be wrong in the case that someone edited the settings.json with the Terminal closed, sure.  We could cache each profile's startup size, sure. OR we could just encode into json the DIP for various fontFace/size pairs. Like, { "Cascadia Code": {"12": "8,13"}, ...}. And then regardless of the profile launched, look up the DIP from that precalculated cache. That would only be wrong if the font itself changed, and the cache would only miss again, when the settings are changed w/o the Terminal open.

Discussion idea:

Font metrics do not change between machines. We can build a compiled-in cache of font cell sizes at different point sizes for the five most popular fonts (Cascadia Code/Mono, Consolas, Lucida Console, Various types of Fira?) and short circuit the calculation. That will stop us from creating a font collection on every startup.

Would it be possible to also measure / provide publicly counters of hard page hits / L3 cache misses during startup / amount of committed RAM / amount of disk accessed including loading of shared XAML libraries (this is especially important for systems with slow disk) of Terminal startup (at Windows startup and at a later stage)?

That's a discussion we're already tracking over in #6409. I'm gonna collapse these two as off topic - feel free to continue the conversation over in that thread.

In https://github.com/microsoft/terminal/issues/15001 a related usecase: Windows OS running some autoruns do quick cmd.exe some_script.cmd that do not print anything and do not require user input. This spins up many Terminal instances and it's quite slow. The special thing about this usecase is that if the script completes quick, it was worthless of doing full XAML loading and such. So if full rendering can be delayed and then skipped completely because of exit in 500ms, it'd be a big win.

Cf. #10461. Cf. also this.

as users, we can upvote certain issues/bugs (that are preventing Terminal from being faster) on XAML github if they have github repo and you link these bugs :)

If I may add anything functional here. I can imagine that a possible solution would be to differentiate between 2 different ways of starting the Terminal:

Opening the application by explicitly clicking it as a user, whether that is via a shortcut or the right click menu in a folder.
Automatic launches by several console application executions when being configured as the default terminal in Windows, which would otherwise launch the old conhost.exe console window of windows.

When launching the first way, I love features, and startup time does not matter that much.
When launching the second way, the application should be absolutely blazingly fast by really not loading any more resources than it needs. Because these launches can happen a lot of time after each other. For example when running any kind of automated batch operation.
I don't know if this is possible, but it might be helpful as an idea.

Removing the Azure profile resolved slow startup times in WT-Preview, before there was a constant 600ms delay spent "loading user and system profiles"

Removing the Azure profile resolved slow startup times in WT-Preview, before there was a constant 600ms delay spent "loading user and system profiles"

Windows Terminal does not control what happens during "loading user and system profiles" inside powershell. None of Terminal's profiles are used in that process.
The term "profile" is overloaded here; they mean Profile.ps1 (and friends.)

Removing the Azure profile resolved slow startup times in WT-Preview, before there was a constant 600ms delay spent "loading user and system profiles"

Windows Terminal does not control what happens during "loading user and system profiles" inside powershell. None of Terminal's profiles are used in that process.
The term "profile" is overloaded here; they mean Profile.ps1 (and friends.)

very odd. been having a consistent "startup took ~600ms", removed the other "windows terminal" profiles and it went away. Whos printing the startup delay, its through powershell isnt it?

Yes, it's PowerShell. The powershell.exe process starts up, loads up the CLR, starts up a PowerShell host engine, starts parsing everything and then prints the message when it's done.
Terminal's job here is to spawn powershell.exe and then read the text it prints.


cmd/go: go get -t do not install packages

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.7.4 linux/amd64
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/tmp/build/a94a8fe5"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build834793487=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
What did you do?
go get -v -t ./proto/apns/
What did you expect to see?
Packages required for running tests not only downloaded, but also installed.
What did you see instead?
proto/apns# cat init_test.go
package apns

import (
	"testing"

	. "gopkg.in/check.v1"
)

func Test(t *testing.T) { TestingT(t) }
proto/apns# ls -l $GOPATH/pkg/linux_amd64/gopkg.in/check.v1.a
ls: cannot access /tmp/build/a94a8fe5/pkg/linux_amd64/gopkg.in/check.v1.a: No such file or directory
proto/apns# go get -v -t .
proto/apns# ls -l $GOPATH/pkg/linux_amd64/gopkg.in/check.v1.a
ls: cannot access /tmp/build/a94a8fe5/pkg/linux_amd64/gopkg.in/check.v1.a: No such file or directory
proto/apns# go get -v gopkg.in/check.v1
gopkg.in/check.v1
proto/apns# ls -l $GOPATH/pkg/linux_amd64/gopkg.in/check.v1.a
-rw-r--r-- 1 root root 400968 Dec 14 19:28 /tmp/build/a94a8fe5/pkg/linux_amd64/gopkg.in/check.v1.a

Real reason why I need it to be installed is because golang.org/x/tools/cmd/gotype fails if it's not installed (so maybe this should be fixed in gotype instead of go get):
proto/apns# rm $GOPATH/pkg/linux_amd64/gopkg.in/check.v1.a
proto/apns# gotype -a .
init_test.go:6:4: could not import gopkg.in/check.v1 (can't find import: gopkg.in/check.v1)
proto/apns# go get -v gopkg.in/check.v1
gopkg.in/check.v1
proto/apns# gotype -a .
proto/apns#

I think this is working as documented:
$ go help get
usage: go get [-d] [-f] [-fix] [-insecure] [-t] [-u] [build flags] [packages]

Get downloads the packages named by the import paths, along with their
dependencies. It then installs the named packages, like 'go install'.

...

The -t flag instructs get to also download the packages required to build
the tests for the specified packages.

...
$

Overall, get downloads and installs the named targets, but -t only downloads the test dependencies: it does not install them. If you want to install the test dependencies as well, then you can follow go get -v -t gopkg.in/check.v1 with go test -i gopkg.in/check.v1.
The new caching work planned for Go 1.10 will require gotype to coordinate a bit more anyway, and that coordination will make plain downloads of the test dependencies good enough.


[RESTEASY-1616] added section 45.3, JAX-RS with Spring MVC

@rsearls do we have 'jaxrs' and 'jax-rs' elsewhere in the doc in place of of 'JAX-RS' ? If not, I'd use 'JAX-RS' as that's the correct way of referring to the technology.

Text changed to JAX-RS in all references


Add default cloud-init-paths to build commands

This will run build-hooks from /oem, /system/oem and /usr/local/cloud-config by default.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3590bbb) 73.68% compared to head (776e8af) 73.68%.

:exclamation: Current head 776e8af differs from pull request most recent head 710b3d8. Consider uploading reports for the commit 710b3d8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1893   +/-   ##
=======================================
  Coverage   73.68%   73.68%
=======================================
  Files          71       71
  Lines        7747     7749    +2
=======================================
+ Hits         5708     5710    +2
  Misses       1618     1618
  Partials      421      421

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


anaconda conda builds include /lib/node_modules

Probably just need to fix up build.sh and bld.bat.

Verified removed from all the 1.1.1 distributions (conda and pypi). Size is right now right around 297-370k (high end is windows, of course). Could likely be tightened up, but at least no more node_modules!


Drawer item is not keyboard navigat-able

Describe the bug / expected behavior
Although we can use the tab key to navigate around different links in docit, we cannot use the space bar to select any drawer nav item. I expect hitting the space bar to trigger the corresponding onclick event, including:

open the page, and
expand to reveal its children, if applicable.

What are the steps to reproduce?

Go to docit
open drawer
use tab key to navigate to a drawer item
use space bar. Notice that the item is not selectable.

Screenshots / Screen recording
The following screen recording is done using keyboard navigation only
https://user-images.githubusercontent.com/8997218/219145968-40dfaac1-e228-40c1-b236-a3dbc19621bf.mov
side note
Playing with the react dev doc, it appears that the Info List Item is not keyboard navigatable either

This seems like it may be an issue with how we are using ListItem versus ListItemButton in the InfoListItem implementation. Refer to the MUI drawer examples where keyboard navigation is working for reference for how we may need to restructure this.


Sparse input with cosine metric does not use Pynndescent

Sparse input should default to Pynndescent. But it doesn't if the metric is cosine. I don't understand why?
https://github.com/pavlin-policar/openTSNE/blob/master/openTSNE/affinity.py#L278
preferred_approx_method = nearest_neighbors.Annoy
    if is_package_installed("pynndescent") and sp.issparse(data) and metric not in [
        "cosine",
        "euclidean",
        "manhattan",
        "hamming",
        "dot",
        "l1",
        "l2",
        "taxicab",
    ]:
        preferred_approx_method = nearest_neighbors.NNDescent

It's weird but I am actually pretty sure that it used to work correctly. My code that used to work previously does not work anymore. Anyway, what's the reason for this metric not in clause?
CC @TimRepke.

Oh @pavlin-policar, I think you might have broken it in https://github.com/pavlin-policar/openTSNE/commit/adf89ab038743586f7ac20ad5e95d723ee8cd399 ;)

It should probably be if is_package_installed("pynndescent") and (sp.issparse(data) or metric not in [...])

I see it the same as Dmitry does. Small logical error. Although, it doesn't explain why it's exclusively on cosine, should actually fail for all the metrics in the list.
The logic was reverse before the last commit. It used to be the clause for explicitly non-sparse data and checks whether any of the metrics are supported by the default algorithm.

Oh, thanks for uncovering this. A little mistake on my part.


refer to partial in bind docs

It says

Note: R.bind does not provide the additional argument-binding capabilities of Function.prototype.bind.

but doesn't tell you where to go.

Good catch.  Thank you.


Bookstack SQL error

Attempted Debugging

[X] I have read the debugging page

Searched GitHub Issues

[X] I have searched GitHub for the issue.

Describe the Scenario
We had problems with our server and we reinstall the os en put everything back and now after the login we get a error on bookstack
Exact BookStack Version
latest
Log Content
Illuminate\Database\QueryException
SQLSTATE[42S22]: Column not found: 1054 Unknown column 'activities.loggable_id' in 'where clause' (Connection: mysql, SQL: select * from activities where (exists (select entity_id, entity_type, max(owner_id) as owner_id, max(status) as status from joint_permissions where activities.loggable_id = joint_permissions.entity_id and role_id in (1, 3, 4) and activities.loggable_type = joint_permissions.entity_type group by entity_type, entity_id having (status IN (1, 3) or (owner_id = 3 and status != 2)))) and (loggable_type != page or exists (select id from pages where pages.id = activities.loggable_id and activities.loggable_type = page and pages.draft = 0)) order by created_at desc limit 10 offset 0)
Hosting Environment
php8.3 ubuntu server 24.04 apache

Hi @ryanvoorspoels,
When you say "put everything back" what exactly do you mean? Did you restore an old content? Please detail the steps followed there if possible.

Since there's been no further follow-up I'll go ahead and close this off.


Crashes when Ring Alarm is on backup Cellular

Plugin crashes upon homebridge start up with "Cannot find 'reduce' in undefined" when the Ring Alarm is on Cellular network.
"deviceList" can be undefined in location.js

My internet is spotty, so from time to time my Ring Alarm would go into Cellular mode for some time :(

Updated in v2.2.1.  It will now wait until the base station is online before it tries to do anything in homebridge.


GitHub Actions: check editorconfig in PRs

Initial discussion in https://github.com/NixOS/nixpkgs/pull/86376#issuecomment-628688974
Currently this is a completely untested draft.

I don't think the build is a good idea. We used to use TravisCI to do some builds, but almost every PR had failed bulids because it was too slow and nixpkgs builds were too big. Maybe instead ofborg could build the manual by default?

Maybe instead ofborg could build the manual by default?

👍 Whatever works best! I'll drop it from this PR.

For the editorconfig check, is there a way for users to do that validation without pushing to github? I guess I'm wondering how we'll know if we're going to merge this and have everything be broken.

is there a way for users to do that validation without pushing to github?

Pre-commit hook maybe? But then it's more of a suggestion rather than a requirement?

I guess I'm wondering how we'll know if we're going to merge this and have everything be broken.

This (should) only check files changed in PRs against master branch so it shouldn't break anything?

I'm not sure, over time it would require every file be updated to match. I'm not saying this is a bad thing or undesirable, but it is maybe a bigger change than you might be expecting :). For example, the first patch to all-packages.nix would probably be a big one!

Yeah, it will probably take a bit of work to get the repo cleaned up enough that we can merge this without breaking every PR but I think most of the changes can be made automatically and submitted in small batches for easier review?
all-packages.nix doesn't seem to need any changes to comply with the current .editorconfig.

indent_size for .nix files seems to be the the biggest problem by far:
https://github.com/NixOS/nixpkgs/blob/f6bfb371cba2b5a02f200c2747c1fe2c72bd782f/.editorconfig#L17-L19
I'd suggest disabling it for nix files as nixpkgs-fmt might be the better tool for this as lots of these files have somewhat odd patterns.
Using actions to enforce everything for non-nix files and indent_style/newlines/whitespace in nix files seems like decent win?

indent_size for .nix files seems to be the the biggest problem by far:
https://github.com/NixOS/nixpkgs/blob/f6bfb371cba2b5a02f200c2747c1fe2c72bd782f/.editorconfig#L17-L19
I'd suggest disabling it for nix files as nixpkgs-fmt might be the better tool for this as lots of these files have somewhat odd patterns.

It is probably the most useful knob in this file as it sets up the tabwidth correctly (instead of 4 spaces). Is there a way to make to ignore it in CI?

Also cc @zimbatm and @Rizary
https://github.com/nix-community/nixpkgs-fmt/issues/56
who want to integrate nixpkgs-fmt into nixpkgs.

Is there a way to make to ignore it in CI?

Doesn't look like this is possible with any of the actions available via github marketplace.
We could make our own linter using editorconfig-checker or similar but I don't want to start on that unless there is a consensus that we'll actually going to use it.

Is there a way to make to ignore it in CI?

Doesn't look like this is possible with any of the actions available via github marketplace.
We could make our own linter using editorconfig-checker or similar but I don't want to start on that unless there is a consensus that we'll actually going to use it.

How about just patching .editorconfig file before in a step the github ci check runs?

How about just patching .editorconfig file before in a step the github ci check runs?

😆 Yeah, that should work.

Hmmm, might be a good idea to do the same thing for docbook as well.
Even if we "fix" all of them first, using this to enforce a style without ofborg checking that it still builds seems like it might cause problems.

@GrahamcOfBorg if I re-call the problem with travis-ci was that we tried to build every package changed by a pr, including mass-rebuilds. Building only the manual seems like a constant-size amount of work.

I guess the editorconfig and the manual build (if we add it here) would need to also check PRs made against staging (and staging-next maybe?) so that those changes don't end up being a mess that needs to be dealt with by whoever tries to merge staging-next back to master.
Keeping the config in sync across branches might be annoying as well, at least initially until it stabilises.
I suppose this something that nixpkgs-fmt  would need to deal with as well.

DocBook is actually indented with a single space (default value for xmlformat).

Let's leave manual builds for a different PR.

Also cc @zimbatm and @Rizary who want to integrate nixpkgs-fmt into nixpkgs.

IMO both are complementary. As long as the indent for nix is set to 2 spaces both tools shouldn't conflict. So :+1: for this initiative.

I've split the docbook indent size out into https://github.com/NixOS/nixpkgs/pull/87919 so it can be merged without waiting for this.

One thing that popped into my mind is that if we start using GitHub Actions, we should carefully consider the limits that are in place.
Probably the most relevant one is that there is a total concurrent job per account. The free plan is at 20 (and 5 for macOS). It's possible that the NixOS org has been upgraded already (/cc @grahamc).

One thing that popped into my mind is that if we start using GitHub Actions, we should carefully consider the limits that are in place.

I'm not sure what I should do with this until the limits are addressed as there isn't much point in cleaning up the repo to comply with the .editorconfig unless it is going to be enforced.
Moving the check to ofborg would be an option to sidestep this but I'm not a rustacean so it's unlikely that I'll be implementing it anytime soon.

20 concurrent jobs sounds fine to me. This check is quite fast. I don't think there would be a large backlog.

20 concurrent jobs sounds fine to me. This check is quite fast. I don't think there would be a large backlog. We may have around 500 PRs a week which is should be well below the 20 jobs at the time limit.

Cool.
Having given this a bit more thought today, a concern I have is that we might end up having to disable it because people don't like hate it. What I would like to do is test this with reduced set of (hopefully non-controversial) rules first to see how well it works in this repo and how well it is tolerated.
After dropping all of the indent_size rules, this set currently has about 2350 errors across a similar number of files. ~2000 are trim_trailing_whitespace and the others are end_of_line / insert_final_newline.
I think as these are easy to fix and that they would also be the most common type of error to be caught by this check, they should make a reasonable test of how viable this is.
If this doesn't cause too many waves I can start on the clean up and we can enable the other rules.
# EditorConfig configuration for nixpkgs
# http://EditorConfig.org

# Top-most EditorConfig file
root = true

# Unix-style newlines with a newline ending every file, utf-8 charset
[*]
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
charset = utf-8

# Ignore diffs/patches
[*.{diff,patch}]
end_of_line = ignore
insert_final_newline = ignore
trim_trailing_whitespace = ignore

# see https://nixos.org/nixpkgs/manual/#chap-conventions

# Match nix/perl/python/ruby/shell/docbook files, set indent to spaces
[*.{nix,pl,py,rb,sh,xml}]
indent_style = space

20 concurrent jobs sounds fine to me. This check is quite fast. I don't think there would be a large backlog. We may have around 500 PRs a week which is should be well below the 20 jobs at the time limit.

Cool.
Having given this a bit more thought today, a concern I have is that we might end up having to disable it because people ~don't like~ hate it. What I would like to do is test this with reduced set of (hopefully non-controversial) rules first to see how well it works in this repo and how well it is tolerated.
After dropping all of the indent_size rules, this set currently has about 2350 errors across a similar number of files. ~2000 are trim_trailing_whitespace and the others are end_of_line / insert_final_newline.
I think as these are easy to fix and that they would also be the most common type of error to be caught by this check, they should make a reasonable test of how viable this is.
If this doesn't cause too many waves I can start on the clean up and we can enable the other rules.
# EditorConfig configuration for nixpkgs
# http://EditorConfig.org

# Top-most EditorConfig file
root = true

# Unix-style newlines with a newline ending every file, utf-8 charset
[*]
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
charset = utf-8

# Ignore diffs/patches
[*.{diff,patch}]
end_of_line = ignore
insert_final_newline = ignore
trim_trailing_whitespace = ignore

# see https://nixos.org/nixpkgs/manual/#chap-conventions

# Match nix/perl/python/ruby/shell/docbook files, set indent to spaces
[*.{nix,pl,py,rb,sh,xml}]
indent_style = space

Is there a way to differentiate between warnings and hart failures? This way people might not introduce new format inconsistencies but the CI does not fail for existing code.

Unfortunately .editorconfig and its linters doesn't seem to offer that much control over how it's enforced or have the concept of new/existing changes.
A couple of linters do have some options e.g. exclude some files or disable a type of check but that's about it.

I think we should at least enforce 2-space indentation for Nix; that's a pretty universal convention across nixpkgs, though I guess there could be Nix syntax corner cases depending on how exactly the linter checks it.

[*.nix]
indent_style = space
indent_size = 2

Just this by itself has ~240000 errors in ~1800 files.

Also what about the tests? The linter forces 4 spaces for some reason. Or are the contents of multiline strings not checked at all?

Also what about the tests? The linter forces 4 spaces for some reason. Or are the contents of multiline strings not checked at all?

The test linter most likely forces 4 spaces, because it's python and follows PEP8.

Pushed a new version as I wasn't really happy with the original.
It using editorconfig-checker with an image pushed from their repo, it has an option to disable the indentation check, it's faster and it looks a lot better than original linter.

-disable-indent-size is an option in the newest version of editorconfig-checker but that adds another ~1500 errors which might be a bit much for a test.

Ok. Let's gives this a shot.

haskell-modules/hackage-packages.nix has 230755 indentation errors + 66 whitespace errors.
The rest of the repo only has 19455 errors total including indentation errors.
So I guess it either needs to be excluded from this check or fixed in hackage2nix somehow.

Could someone with access consider adding a checkbox in the PR template about editorconfig? The first I heard about it was when my PR failed (and GitHub failed to display the error log), which wasn't the nicest first impression.

Do you really want more checkboxes? What was not clear about the error message given by the check? Maybe we should improve on that.

The error message did not load. Just a spinning little GitHub symbol even though the test was finished and failed. I could access both the earlier setup logs and the later postrun actions logs, but not the actual "editorconfig check" logs. Sorry I can't be more specific, I've fixed and force pushed my PR and can't get back to the error message. I can see editorconfig error messages on other PRs, so it was something specific to mine.
Incase it helps, the error message should have been something along the lines of
pkgs/development/python-modules/cadquery/default.nix:
	25: Trailing whitespace
	38: Trailing whitespace
	71: Trailing whitespace
	71: Wrong amount of left-padding spaces(want multiple of 2)
	78: Trailing whitespace
	78: Wrong amount of left-padding spaces(want multiple of 2)
	82: Trailing whitespace
	82: Wrong amount of left-padding spaces(want multiple of 2)
	95: Trailing whitespace
	95: Wrong amount of left-padding spaces(want multiple of 2)
	97: Trailing whitespace
	97: Wrong amount of left-padding spaces(want multiple of 2)

12 errors found

I also justed it in https://github.com/NixOS/nixpkgs/pull/88594
This is the error message:
default.nix:
	27: Trailing whitespace

1 errors found
##[error]Process completed with exit code 1.

We maybe could rename it from check editorconfig to check codingstyle based on editorconfig to make it a bit more clearer but apart from that the error message looks understandable to me.

Just found an email with a link to the logs: https://github.com/NixOS/nixpkgs/runs/698397328
They work fine now.

add a command to locally reproduce this error

Yeah, that's the most important part to me.

This spawned a bunch of discussion in #nixos-dev yesterday.
The problem here is that now github actions and oforg both have their own unrelated checks which means if one or the other doesn't run everything still looks good (which happened today). I'm not aware of any particular problems with GitHub actions but after giving it some thought I'm not in favour of depending on multiple CI systems for status checks.

I would like to revert this PR and close #88488. Not because I don't like github actions or feel like my pet project ofborg is threatened, but because I think these checks are actually harming the clearness of the checks. I'll explain:
The editorconfig check puts a big green check next to a commit, and hides the list of checks which passed. If ofborg is down or behind, it is likely people will think ofborg has approved the PR before it did. This could cause, well, all the problems ofborg is there to prevent.
The concrete problem here is this green check appears very early and is misleading, and there is no poka yoke to help people do the right thing.
One fear of #88488 is that it will introduce red X's if it takes a long time to build the manual, or something in the target branch is failing to build. This is reminiscent of the Travis times for me: Travis gave out so few green checkmarks, that if Travis gave a PR a green check-mark, it inspired more "okay what is broken that let travis pass it?" than "okay good to merge".
The goal of ofborg, and ever since ofborg became a thing, the "rule" has been green checkmark -> good to merge and red X -> don't merge.
The editorconfig check errodes the clearness of the green checkmark signal.
The big-rebuild failures we'll certainly have with #88488 errodes the clearness of the red X signal.
The clearness of this signal has been my guiding light on the design of ofborg for years now, and I am very afraid of threatening it.
A few suggestions that have been brought up to improve this:

make ofborg faster I'd love to do this, but it doesn't solve this problem if ofborg is seriously delayed or down.
require the ofborg evaluation check for merges this is really the only solution, but not something we can do today, because of some workflow issues we need to resolve.

That makes me think that, today, we should be undoing this check and closing #88488.

A related fix is to enable this option in the branch protections:

One of the benefits of doing that is that it lets the user know in advance, before ofborg or GitHub Actions has even executed, which checks are needed to pass before they can merge the PR.

That is not an option right now, @zimbatm. Let's talk about this later? I have information about this, but not a schedule compatible with spending much time on it right now.

note I included that in my message:

require the ofborg evaluation check for merges this is really the only solution, but not something we can do today, because of some workflow issues we need to resolve.

Maybe we can integrate this check into ofborg itself.

Got reverted in https://github.com/NixOS/nixpkgs/pull/88608
Sorry @zowoq, I know you put effort into this. Do you mind opening a new PR to re-introduce it? I still think it's a good idea to use it.

Seems I picked a bad time to step away from a computer for a couple of hours.

Do you mind opening a new PR to re-introduce it?

That is not an option right now ... I have information about this, but not a schedule compatible with spending much time on it right now.

I think I'll wait to hear more from @grahamc first before doing anything.
Thanks @Mic92 and everyone else for you help on this.

Sorry @zowoq https://github.com/zowoq, I know you put effort into this. Do you mind opening a new PR to re-introduce it? I still think it's a good idea to use it.

I think it is a good idea, too.

I'd like to look at adding checks for formatting/linting in non-nix files as well, currently we have ~20000 loc in ~500 bash/sh files, ~6500 loc in ~40 python files and ~5000 loc in ~30 perl files.
@grahamc Do you know when you'll be able to provide some detail on the workflow issues that are blocking us from using the required status checks with ofborg?

The alternative would be to have ofborg to build derivations described in nixpkgs itself so that we can add features to the CI without having to modify ofborg itself.

The alternative would be to have ofborg to build derivations described in nixpkgs itself so that we can add features to the CI without having to modify ofborg itself.

TBH, I don't think adding more things (making us more dependant) on ofborg is a good idea.

Could there be a dummy github action that like Waiting for ofborg..., which ofborg could stop?

PRs can fail on all 3 platforms (grey neutral builds) or the builds might not even start (and not appear as a status) and they would still be green overall.
I don't think using the required status UX would be any worse than what we have now. I'd certainly like to try using them before attempting to implement anything more complicated.

However at least we should not break evaluation. Failed evaluation will mark the build as read.

This github action might be a suitable workaround: https://github.com/NixOS/nixpkgs/pull/93581


Progressbar not showing when using previewTemplate

I've tried to research more but still didn't come up with a solution. I'm using vue. As of the moment, I have this in my template. Everything works fine. The thumbnail, name, size, and even the custom remove button is displayed. Only the progressbar is missing.
template() {
                return `

Remove

                `
            },

And these are my configurations
dropzoneOptions: {
                    url: 'api/managevehicle/store_image',
                    autoProcessQueue:false,
                    uploadMultiple: true,
                    thumbnailWidth: 50,
                    thumbnailHeight: null,
                    maxFilesize: 5,
                    acceptedFiles: ".jpeg,.jpg,.png,.gif,.pdf",
                    headers: {},
                    previewTemplate: this.template(),
                },

I had the same issue, it's because the CSS is not loading.

Just append dropzone to template container.


Can not remove /categories, /tags pages

Hugo version v0.101.0
How to remove default pages: Page(/categories) Page(/tags) from showing up?
disableKinds does not work

Please use https://discourse.gohugo.io/ for questions/troubleshooting. Also see  Hugo Documentation.


Collisions Are Not Moving

I'm working on a new instance of gridstack and I can't get collisions to move the items. Doesn't matter if it is a generic set of empty containers or my actual data. The _fix_collisions function fires off successfully. It detects the collision and sets the x and y values appropriately. However, these values never actually enter into the grid and the items never move.  Clean project or not clean, doesn't matter. Collision moves never take place. Any thoughts?

Problem was using version 4 of lodash.js. Going to a previous version, 3.5 from one of the demos, appears to have fixed the problem.

Do you have any idea which lodash function in the version 4 pre-release causes this error? I try to figure out if it's a lodash problem or a gridstack problem.

I had the same issue, with lodash 4.0.0. I wonder how many people ran into this issue since it's usually what you do first when you need to install a new dependency : install the latest version. Would probably be worth a warning in the dependencies list.

I had the same issue too. Should it not work with the latest version of lodash? Or is it lodash that has the problem?

If you take a look at PR #309 for the required changes to gridstack, lodash 4.0 removed the context parameter in favor of more explicitly using the _.bind method.

Perfect @andrewr88 That works!!! Cheers. Awesome!


Consider more general render_summary

More general render_summarycan bring much value when different format summary can be delivered (e.g. pdf). The full access to qmd spec header can give even more flexibility. In any case we need more args in run. Possibly an OOP design or spec object can be helpful.  I will be careful with to much responsiblity on the options() function.

Linked with https://github.com/NovoNordisk-OpenSource/whirl/issues/89

We are currently considering this at the moment, and it might be a good idea to export a create_summary() function, so you can render to different formats.
We are also exploring how to create a JSON log with summary information for all scripts.


Missing dependencies?

There is nothing mentioned about this in the documents, but I get the following linker errors if I don't manually include
pod 'TPCircularBuffer'

in the pod file. Is this expected? I was just going to ignore it, but adding use_frameworks! to the Podfile has made the issue come back despite the inclusion of the TPCircularBuffer library.
This is on iOS 8.x using AudioKit 2.0.
Undefined symbols for architecture i386:
"_TPCircularBufferCleanup", referenced from:
+[EZAudio freeCircularBuffer:] in EZAudio.o
"_TPCircularBufferClear", referenced from:
+[EZAudio freeCircularBuffer:] in EZAudio.o
"_TPCircularBufferInit", referenced from:
+[EZAudio circularBuffer:withSize:] in EZAudio.o
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

TPCircularBuffer.c is definitely included in the AudioKit repository. Maybe for some reason it is not getting compiled because it's a C file and not an Objective-C module?

I only recently changed the podspec to include .c files as well.  Perhaps this will get fixed if I push up a new version for pods to point to?

If I point the pod to the git repo at commit 7ea3f5b2863fd82219392f5dbf8eeb683ca0a622 which contains your recent changes, that seems to fix the problem, so I would think that pushing the new podspec should fix it the issue.

I've pushed a 2.0.1 podspec, hopefully that fixing things.  Closing for now.


Column tagging API

* I think we can merge the Columns class and the ColumnGroup class

I thought this too at first, but Columns (soon to be ColumnSchemas) is an expanded version of ColumnNames, not a conceptual parallel to ColumnGroup (which also has the responsibility of being a graph node in addition to collecting information about a set of columns.) I don't think we want to be passing around graph nodes into Operators to identify sets of columns, which would create the very weird situation where a ColumnGroup (node/set of columns) has an Operator that takes a ColumnGroup (set of columns/node.)
Recall also that you mentioned that you probably used ColumnNames instead of ColumnGroup in the Operator public methods due to the circular dependency between Operator and ColumnGroup. If we merged Columns and ColumnGroup, we'd end up exacerbating the circular dependency.
As much as I'd like to avoid having to make deeper changes to the library, this particular aspect of the code is deceptively difficult to wrangle. I'm hoping that the combination of renaming Column to ColumnSchema and Columns to ColumnSchemas will make it clearer what's going on and help us think through this. Pretty sure we're going to need to introduce a new concept somewhere in here to make it work though (possibly by splitting or clarifying the ColumnGroup class.)

* Instead of adding methods like ‘categorical_columns’ to the column_group, I think we can just use a generic select function.  We're going to allow user defined tags , so we can't have an exhaustive list of functions anyways - and it won't be all that much  more verbose

See also my PR on Transformers4Rec which slims down the ColumnGroup API and addresses the query method conundrum.

(I made a few schema-related renames and removed some extraneous changes in the preceding commits.)


Field report: VSCode on clean Windows installation

This describes what I observed, for future reference.
Date: 2024-03-05
Windows 10 Pro Education, standalone installation (not university managed)

VSCode web page, click download, select Windows "User installer" x86
Run the installer

The only really important configuration option seemed to be "add vscode to PATH"

start vscode
Aside: I clicked "remote connection" and "SSH" and it automatically installed the remote-ssh extension.  So vscode does sometimes automatically install extensions.
From the menu bar, I did Terminal → New Terminal.  It started a PowerShell terminal.  e.g. pwd, cd /, cd /Users/user/testproject/ worked (and it tab-completed to C:\Users\...).  So backslashes/forward slashes mostly works

The usual hotkey control-backquote doesn't work to open the terminal.

I click the "version control" tab on the side.  It says "Install git, a popular ..." with a big "Download Git for Windows" button.  So Git installation separately is needed, but it is guided.
Click "Download git for windows".  It launches a web browser to the Git for windows site.  Follow those instructions (same as we have now).

I did select "use VSCode as an editor for git" (instead of Nano)

I go back to vscode.  git doesnt' work from the terminal, and it still prompts me to download Git.  Probably OK: this is probably because of PATH.
Exit and restart vscode.  Now it works: git appears in the terminal and in the "version control" browser.

Let's try using it:

I had made a blank testproject.
I can click "Initialize repository" in the VCS tab.  It also shows something about Github, which I didn't click yet.
I add some files
I go to the VCS tab and add the files.  I cilkc "commit" and it says "Make sure you configure your "user.name" and "user.email" in git.  The dialog says it comes from VSCode itself.  It doesn't let me commit until I fix this.
If I enter a message in the VCS commit sidepanel, it commits directly

If I don't enter a commit message, it starts a new vscode tab where I can edit the message (I guess it did this since I told it to use vscode as an editor).  This basically does what we want: you can edit the message, and the git process waits until you close the tab.

If, from the terminal, I git config --global --edit, it starts a tab in vscode.  As expected.  If I remove the core.editor config, then it starts the editor in the terminal (vi by default)

I can change the core.editor to nano and it works with nano.  Changing back to the default value opens in vscode again.
Setting core.editor to code --wait (no quotes) also works to launch within the vscode tab.
But if core.editor is unset and I click "commit" from the sidebar, it does launch the editor in the a vscode tab.  I wonder if vscode is overriding the editor option on the command line directly (I couldn't find a way to inspect the processes enough to see how it was started).

Output of git config --list --show-origin:
file:C:/Program Files/Git/etc/gitconfig diff.astextplain.textconv=astextplain
file:C:/Program Files/Git/etc/gitconfig filter.lfs.clean=git-lfs clean -- %f
file:C:/Program Files/Git/etc/gitconfig filter.lfs.smudge=git-lfs smudge -- %f
file:C:/Program Files/Git/etc/gitconfig filter.lfs.process=git-lfs filter-process
file:C:/Program Files/Git/etc/gitconfig filter.lfs.required=true
file:C:/Program Files/Git/etc/gitconfig http.sslbackend=schannel
file:C:/Program Files/Git/etc/gitconfig core.autocrlf=true
file:C:/Program Files/Git/etc/gitconfig core.fscache=true
file:C:/Program Files/Git/etc/gitconfig core.symlinks=false
file:C:/Program Files/Git/etc/gitconfig pull.rebase=false
file:C:/Program Files/Git/etc/gitconfig credential.helper=manager
file:C:/Program Files/Git/etc/gitconfig credential.https://dev.azure.com.usehttppath=true
file:C:/Program Files/Git/etc/gitconfig init.defaultbranch=master
file:C:/Users/user/.gitconfig   core.editor="C:\Users\user\AppData\Local\Programs\Microsoft VS Code\bin\code" --wait

Misc screenshots (these may be used, I claim there is no creative work so no copyright by me.  But it might be better to re-generate unless it's windows-specific):
VCS sidebar icon:

New terminal:

Download git for windows:

Git defaults:

Warning to configure username and email:

All text and pictures above should be considered public domain/CC-0 and can be used anywhere to improve git instructions.


Missing information about Github application-gateway-kubernetes-ingress -project

Documentation https://docs.microsoft.com/en-us/azure/terraform/terraform-create-k8s-cluster-with-aks-applicationgateway-ingress describes how to configure application gateway as ingress. But, documentation does not mention Github project https://github.com/Azure/application-gateway-kubernetes-ingress which also describes steps to create application gateway ingress step. Are these instructions aligned together and up-to-date cross-checked?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 20f12c89-40e2-076e-6135-64773551e673
Version Independent ID: c2d6ac4a-fad9-dbc1-d125-b267bcd2a566
Content: Create a Kubernetes cluster with Application Gateway as ingress controller with Azure Kubernetes Service (AKS)
Content Source: articles/terraform/terraform-create-k8s-cluster-with-aks-applicationgateway-ingress.md
Service: azure
GitHub Login: @TomArcher
Microsoft Alias: tarcher

Thanks for the question! We are investigating and will update you shortly.

Thanks. My another question https://github.com/MicrosoftDocs/azure-docs/issues/27904 also relates to this.

@tiholm This documentation describes about setting up the Application gateway as the ingress for AKS using Terraform.
The github repo includes the regular installation process. I think we can add a note in this doc which suggests that the users which are looking for other modes of installation can go to the github.
I have assigned this issue to the content author to investigate further and update the document as appropriate.

@jakaruna-MSFT It appears that you've addressed the issue. If there's an action item for me in updating the article, please email me offline. Thanks #please-close


Weird create function with body and files in Dart SDK

I am trying to create record with data and files (like example in https://pocketbase.io/docs/files-handling/)
here is my code:
final files = await Future.wait(
  images.map(
    (XFile image) => MultipartFile.fromPath(
      'images',
      image.path,
      filename: 'abc.jpg',
    ),
  ),
);

final body = <String, dynamic>{
  "text": "123",
};

final record = await pb.collection('collection').create(
  files: files,
  body: body,
);

but when I run above code, only files are successfully uploaded to DB and no body data is reflected in DB.
if I comment out files like this:
final record = await pb.collection('collection').create(
  // files: files,
  body: body,
);

then body is successfully uploaded to DB.
why is this happening and how can I solve this?
I can't find any difference between my code and example in https://pocketbase.io/docs/files-handling/
thank you

It works correctly for me and I'm not able to reproduce it locally with PocketBase v0.22.4 and PocketBase Dart SDK v0.18.1.
pb.collection("example").create(
  files: [
    http.MultipartFile.fromString(
      'file', // the name of the file field
      'example content...',
      filename: 'example_document.txt',
    ),
  ],
  body: {
    "title": "test",
  },
);

Note that PocketBase Dart SDK v0.18+ is compatible only with PocketBase 0.21+ (see the CHANGELOG).
If you are still not able to resolve it, feel free to provide more details about your testing environment and/or create a minimal reproducible repo and I'll try to investigate it further.

Note that PocketBase Dart SDK v0.18+ is compatible only with PocketBase v0.21+ (see the CHANGELOG).

I had a similar problem. Upgrading the backend fixed it 👍
I setup my Dart project a few weeks after my backend project, which is probably why I didn't check the changelog or consider the versions might be incompatible.


firebase-storage.ts: baseStores* caches not app aware

I recently tried for the first time to open a store using a storageKey identifying a second provider.
The store doesn't work properly because the baseStorageFor method returns the a storage object for the wrong firebase app. It looks to me like there needs to be separate baseStore/baseStorePromise caches per app instead of per storage-engine?

Can you provide the storageKeys you used, please?

firebase://arcs-storage.firebaseio.com/AIzaSyBme42moeI-2k8WgXh-6YK_wYyjEXo4Oz8/0_7_0/wkorman
firebase://my-arcs.firebaseio.com/AIzaSyB89XDMqAV0n8MVEj1LFwvxB18stUYU07M/scott

I'm going to email them to you, as the databases have only security-by-obscurity at the moment.

I sent you the base keys I'm using, but I'm guessing you want fully resolved handle/store keys (not sure what to call them).
I don't have samples for that handy, but I'll work on it.

That's ok, the base keys are probably enough to work with. FYI I'm not in
for the rest of the week, so won't be looking at the bug until next Tuesday
(Monday is a public holiday here).
On Wed, 17 Apr 2019 at 07:54, Scott J. Miles<EMAIL_ADDRESS>wrote:

I sent you the base keys I'm using, but I'm guessing you want fully
resolved handle/store keys (not sure what to call them).
I don't have samples for that handy, but I'll work on it.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/PolymerLabs/arcs/issues/2900#issuecomment-483858461,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Ag7eTSB7obRgyYgXBIogHZ68uRbaqd9Oks5vhkacgaJpZM4cw4Uw
.

Cool, thanks for the update. I'm also OOO until next week, so we'll reconvene then.

I don't have complete info yet, but it looks like #2930 broke context generation. My handles are always empty.
Also, do we need to do similar work in the PouchDB driver?

Fix was easy, to wit: s/typeStr/${typeStr}. See #2933 and #2934.


Use semantic versioning for helm chart

Describe the solution you would like to see happen
I would like the kuberhealthy helm chart to use semantic versioning.
How do you propose we build it?
A change in the release pipeline config
Additional context
This has been already done in the past, however for some reason it has been droped. For now it's confusing to check which version of the chart contains which version of kuberhealthy. Since this chart contains a single product, it could follow the kuberhealthy versions.

This isn't a bad idea, but the helm chart is published programmatically, and moving to semver would mean someone reviewing the cart to ensure the next proper semver version was chosen based on the changes.  Right now, that's not happening, so I think we need to have that become a possibility before we move to a semver version...


Multi-Geo

For the views and rankings in a multi-geo setting, is this calculated for all tenants (ex. Europe, East US and Asia) or for each individual tenant?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 719feeea-d688-78bf-fef5-8b58c2fb047f
Version Independent ID: 78793fa4-e2e2-7113-3652-b1165ee92145
Content: Monitor usage metrics for dashboards and reports - Power BI
Content Source: powerbi-docs/service-usage-metrics.md
Service: powerbi
Sub-service: powerbi-service
GitHub Login: @maggiesMSFT
Microsoft Alias: maggies

Thanks for your comment, @dethompson97 . We’ve forwarded your feedback to the writer, who should respond to this thread shortly. Thanks!
You might also find your answer from the community (https://community.powerbi.com)

Hi, @dethompson97 -- I got an answer for you: "I assume by tenants they mean capacities in this question.
If so then the answer is that usage is across the tenant, regardless where the capacities are."


Switch Argo to PNS

See workflow executors documentation for comparison and configuration.

Addressed in https://github.com/onepanelio/manifests/pull/19


Feature: Document whether scorecard should be used as a requirement for organizations consuming OSS

Is your feature request related to a problem? Please describe.
There have been requests on whether companies should require a scorecard score, and what the score should be, of the OSS software they consume.
Describe the solution you'd like
Add a FAQ entry or clearly identify on the main readme whether scorecard should be used this way, and if so, what a minimum required score should be. If it should not be used that way, describe why the maintainers recommend against it.
Describe alternatives you've considered
Repeated answers in slack threads.
Additional context
N/A.

There have been requests on whether companies should require a scorecard score, and what the score should be, of the OSS software they consume.

I think the answer should be no for a few reasons:

With 19 checks, there's multiple different ways to arrive at score X/10.
Scores change as we add new heuristics
Every OSS consumer has their own risk tolerances
Scorecard isn't perfect at detecting behaviors

I think a more reasonable question is: "Should OSS consumers require certain behaviors?"
With the v5 release, we see Structured Results as a way of doing this. Instead of relying on an overall Scorecard of X, or a Maintained score of Y, an OSS consumer may want to ensure the repo they're depending on isn't archived (which is covered by the archived probe).

I tend to agree that Scorecard should not be used by consumers. An example attack I can think of would be to find popular projects with low scorecard scores, perhaps because maintainers use tools that are not recognized by the scanner, don't have co-maintainers, or similar challenges. The attacker could fork the project, use sock puppets for co-maintainers, and add files that trick the scorecard scanner to give a false positive score (e.g. an empty fuzzing test). Then with a higher scorecard score, they could go around with other sock puppet accounts and force projects to change their dependency to the malicious attacker controlled project citing the better scorecard score.


"Conference" field does not appear in APA or Bibtex

CITATION.cff file
My preferred-citation is a conference proceedings:
preferred-citation:
  type: proceedings
  doi: 10.1145/2882903.2899401
  conference:
    name: "SIGMOD '16"
    website: https://www.sigmod2016.org/
    city: San Francisco
    country: US
  authors:
    - family-names: Rampin
      given-names: Remi
      affiliation: New York University
      orcid: https://orcid.org/0000-0002-0524-2282
      website: https://remi.rampin.org/
    - family-names: Freire
      given-names: Juliana
      affiliation: New York University
      orcid: https://orcid.org/0000-0003-3915-7075
      website: https://vgc.poly.edu/~juliana/
    - family-names: Chirigati
      given-names: Fernando
      affiliation: New York University
      orcid: https://orcid.org/0000-0002-9566-5835
      website: http://fchirigati.com/
    - family-names: Shasha
      given-names: Dennis
      affiliation: New York University
      orcid: https://orcid.org/0000-0002-7036-3312
      website: http://cs.nyu.edu/shasha/
  date-published: 2016-06-26
  year: 2016
  month: 6
  title: "ReproZip: Computational Reproducibility With Ease"

Somehow this gets rendered on GitHub as:
Rampin, R., Freire, J., Chirigati, F., & Shasha, D. (2016). ReproZip: Computational Reproducibility With Ease. https://doi.org/10.1145/2882903.2899401
@proceedings{Rampin_ReproZip_Computational_Reproducibility_2016,
    author = {Rampin, Remi and Freire, Juliana and Chirigati, Fernando and Shasha, Dennis},
    doi = {10.1145/2882903.2899401},
    month = {6},
    title = {{ReproZip: Computational Reproducibility With Ease}},
    year = {2016}
}

As you can see only the title is there, which makes for a very awkward citation.
Context
I am trying to make a CFF equivalent to the existing CITATION.txt:
To reference ReproZip in publications, please cite the following:

ReproZip: Computational Reproducibility With Ease, F. Chirigati, R. Rampin, D. Shasha, and J. Freire. In Proceedings of the 2016 ACM SIGMOD International Conference on Management of Data (SIGMOD), pp. 2085-2088, 2016

BibTeX:

@inproceedings{ChirigatiRSF16,
  title = {ReproZip: Computational Reproducibility With Ease},
  author = {Chirigati, Fernando and Rampin, R{\'e}mi and Shasha, Dennis and Freire, Juliana},
  year = {2016},
  isbn = {978-1-4503-3531-7},
  location = {San Francisco, California, USA},
  doi = {10.1145/2882903.2899401},
  booktitle = {Proceedings of the 2016 International Conference on Management of Data},
  series = {SIGMOD '16},
  pages = {2085--2088},
  numpages = {4},
  publisher = {ACM},
  keywords = {computational reproducibility, provenance, reprozip},
}

Hi @remram44, and thanks for opening this issue.
The decision what (and how) things are being picked up for rendering in the GitHub UI lies not within our hands, but with GitHub. The support for preferred-citation is still relatively new, and as far as I know as of today supports @article type works. I think this is about to change soon though, and would like to bring @arfon into this conversation, who may be able to shed more light on this.

I found this line which is a little scary:
https://github.com/citation-file-format/ruby-cff/blob/3f6c7ac453d9c82f49b5ba9439c6882279a157a2/lib/cff/formatter/apa_formatter.rb#L47
Are only journal articles supported?
Bibtex doesn't seem to have that, only "author", "title", "month", "year", "url". I can't really make any citation work with only that:
https://github.com/citation-file-format/ruby-cff/blob/3f6c7ac453d9c82f49b5ba9439c6882279a157a2/lib/cff/formatter/bibtex_formatter.rb#L27-L38

I assumed GitHub used the cff gem, since APA and Bibtex conversion is available there. Apologies if this is not correct. Either way, the cff gem has the exact same issue and should probably be fixed.

Thanks for opening this issue @remram44. As @sdruskat mentioned, @article is the only preferred-citation type fully supported by GitHub right now, but I'd like to move quickly to support @proceedings.
For reference, here's an example that the Julia Project is using (but this is for a paper in a journal, rather than a conference): https://github.com/JuliaLang/julia
We should probably transfer this issue over to https://github.com/citation-file-format/ruby-cff (not sure if you can do that @sdruskat?) as this is where we will need to add support.

I assumed GitHub used the cff gem, since APA and Bibtex conversion is available there. Apologies if this is not correct. Either way, the cff gem has the exact same issue and should probably be fixed.

You're right, GitHub use ruby-cff (by "we" I meant the schema project, sorry). I'll move this to the ruby-cff repo.


[Filtering]: Sort Sub-Categories alphabetically

Let's try to sort the Sub-Categories alphabetically to make it more easy to find find a particular category  of interest....

That should already be the case :(
Il will rebuild the category tree tonight when I perform the other maintenance.

Ah damn... found maybe why... the sorting of categories is performed based on the english translation. I'll create a workaround.


Streaming Support

I have created a fork that uses streaming (https://github.com/nlindley/hapi-dust), and I thought I’d see if there’s an interest in merging this in. I wouldn’t call it ready for production since I haven’t touched the tests or really studied Hapi’s view engine documentation, but it’s a start.

There is also a demo project at https://github.com/nlindley/hapi-dust-test. If you are trying to use curl, you’ll need to add something like
dust.optimizers.format = function(ctx, node) { return node };

because curl likes to wait until line breaks to print output, and Dust likes to minify the HTML.

@nlindley I'm definitely interested! But I would like to see the tests updated.

Cool. I probably won't have time to get to it for a few days, but I can get them updated once things slow down a little.


ROX-20789: Fix pod hierarchy test flake

Description
This time the flake is in DeleteDeployment test.
IIUC the nil check is not sufficient if the alerts were resolved as opposed to never triggered. So if alert results aren't nil, they should have 0 elements in the slice.
If this doesn't solve the issue, I've added additional logs for the next time this fails.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change

[ ] PodHierarchy_DeleteDeployment passes

Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

/test ?

/test gke-sensor-integration-tests

/test gke-sensor-integration-tests


Music on hold link

please add link  "music on hold " with follwoing URL
https://docs.microsoft.com/en-us/microsoftteams/music-on-hold
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6cfead3c-b0d8-c22a-aa22-63e79fe53ed3
Version Independent ID: 10745875-3d3e-42bb-e324-ff4c83968ccf
Content: Here's what you get with Phone System - Microsoft Teams
Content Source: Teams/here-s-what-you-get-with-phone-system.md
Service: msteams
GitHub Login: @CarolynRowe
Microsoft Alias: crowe

Thank you for submitting feedback and contributing to the docs. We are currently investigating this.


fixes issue 4904

This has already been fixed by PR #4870. Please don't let that discourage you from contributing again in the future though!
Thanks and happy coding!


Fix pickle for tseries dataframes

This was caused by two issues:

__getstate__ and __setstate__ weren't defined for dataframes,
which was causing the default __dict__ implementation to be used.
__getattr__ for timeseries dataframes wouldn't fail properly when
fake columns were getattr'd. This was causing issues in cloudpickle,
as it checks for various attributes differently than pickle.

This fixes both of these issues, and tests that dataframes are picklable
with both pickle and cloudpickle.

No love on Python 2 :(

Apparently protocol 1 doesn't support __getnewargs__. Fixing.


Need use Java Varargs  to optimize some problems

Describe the solution you'd like
In practice, there are many situations that do not need to fill paramObj param, so you need to use Java Varargs  to optimize this problem

There is no need to use Java Varargs to optimize project. But truely it is important to use Polymorphism to optimize this project


Implement search by box number on dashboard

Add the ability to search for a specific box number to the search bar on the admin and general user dashboard. Once the user searches for a box number, that box should open and the map should zoom into that box's zip code.

/cib search box

Branch 35-search-box created!


[admin] Publish

Learn Build status updates of commit 059ba50:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/docs-ref-autogen/excel/excelscript/excelscript.commentmention.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/docs-ref-autogen/excel/excelscript/excelscript.commentrichcontent.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/docs-ref-autogen/excel/excelscript/excelscript.contenttype.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/docs-ref-autogen/excel/excelscript/excelscript.placement.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/docs-ref-autogen/excel/excelscript/excelscript.shape.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/sample-scripts/excel-scripts.yaml
:white_check_mark:Succeeded

generate-docs/api-extractor-inputs-excel/excel.d.ts
:white_check_mark:Succeeded

generate-docs/script-inputs/excel.d.ts
:white_check_mark:Succeeded

generate-docs/tools/API Coverage Report.csv
:white_check_mark:Succeeded

generate-docs/tools/Office Sample Coverage - weighted.osts
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 1dc7f97:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/docs-ref-autogen/excel/excelscript/excelscript.commentmention.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/docs-ref-autogen/excel/excelscript/excelscript.commentrichcontent.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/docs-ref-autogen/excel/excelscript/excelscript.contenttype.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/docs-ref-autogen/excel/excelscript/excelscript.placement.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/docs-ref-autogen/excel/excelscript/excelscript.shape.yml
:white_check_mark:Succeeded
View (office-scripts)

docs/docs-ref-autogen/excel/overview.md
:white_check_mark:Succeeded
View (office-scripts)

docs/sample-scripts/excel-scripts.yaml
:white_check_mark:Succeeded

generate-docs/api-extractor-inputs-excel/excel.d.ts
:white_check_mark:Succeeded

generate-docs/script-inputs/excel.d.ts
:white_check_mark:Succeeded

generate-docs/tools/API Coverage Report.csv
:white_check_mark:Succeeded

generate-docs/tools/Office Sample Coverage - weighted.osts
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


Update sociallogins.rst

add important background info

Hi @leastprivilege, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@leastprivilege  if you can come up with a paragraph I'll update the article - something like
FB OAuth implement a form of OpenID Connect id tokens.
Google implements OpenID Connect
Twitter ..
LinkedIn
Microsoft ..
@MikeWasson @rustd  - Also, how would you rewrite how to build an ASP.NET 5 Web application that enables users to log in using OAuth 2.0 with credentials from an external authentication provider, such as FB, Goog, etc

Much trolling here :trollface:
On a more serious note, it might be a good idea to mention that additional providers for OAuth2/OpenID2 can be found on aspnet-contrib: https://github.com/aspnet-contrib/AspNet.Security.OAuth.Providers and https://github.com/aspnet-contrib/AspNet.Security.OpenId.Providers

added #566

My point is - none of these providers really use OAuth for login, because OAuth does not have that feature. Some use openid connect, some proprietary. Just use the term "external authentication providers".

@leastprivilege Thanks.


Button not rendered correctly ( no text )

Hey , my Login button is very small. it's just a recrangle with no text inside of blue color. :/ Any ideaas why ?

Nevermind..now i see it takes a Buttonview parameters but it's only listed under android setup not in the main documentation.

Can you give us and example what did you do?

@JoseGibran you can close the issue, the only thing is to update the docs to include that ButtonView parameter, for now i think it's in the wrong 'place'. :)


It seems like #selector and #if introduced in swift 2.2

In the Manager.swift you use the #selector and #if syntax, but it is introduced in swift 2.2 and will build fails before that version.
        public override func respondsToSelector(selector: Selector) -> Bool {
            #if !os(OSX)
                if selector == #selector(NSURLSessionDelegate.URLSessionDidFinishEventsForBackgroundURLSession(_:)) {
                    return sessionDidFinishEventsForBackgroundURLSession != nil
                }
            #endif

            switch selector {
            case #selector(NSURLSessionDelegate.URLSession(_:didBecomeInvalidWithError:)):
                return sessionDidBecomeInvalidWithError != nil
            case #selector(NSURLSessionDelegate.URLSession(_:didReceiveChallenge:completionHandler:)):
                return sessionDidReceiveChallenge != nil
            case #selector(NSURLSessionTaskDelegate.URLSession(_:task:willPerformHTTPRedirection:newRequest:completionHandler:)):
                return taskWillPerformHTTPRedirection != nil
            case #selector(NSURLSessionDataDelegate.URLSession(_:dataTask:didReceiveResponse:completionHandler:)):
                return dataTaskDidReceiveResponse != nil
            default:
                return self.dynamicType.instancesRespondToSelector(selector)
            }
        }

Hi @LuoLee,
Xcode 7.3 is now required for the latest Alamofire 3.3.0 release. The README has been updated accordingly to reflect that.
Cheers. 🍻


fall through on errors

I was having some problems with code executing beyond what it should when an error happened, but I can no longer pinpoint where that was for sure, probably in the forgotPassword middleware.
It looks to me that there's some inconsistence on how you handle the way you call next, sometime you just call next() , sometimes you call "return next()" ?
You can compare with my version of the same function:  http://pastie.org/10970014

Thanks for pointing that out. Please let me know what that issue is if you keep having it after pulling the latest. I just pushed some changes that improve consistency with returns.


In Multicurrency org, Best Gift Year Total not rolling up correct value if opp/account currency does not match user currency

If the user's currency (may also be related to corporate currency) is a different value than the currency on the Opp & Account, then Best Gift Year Value appears to be using the converted value of the user's currency, rather than the value of the Opportunity (and then further converting it).
Screen shot from customer org illustrates issue based on user currency in GBP, Account in USD and a single $75K Opp in USD.

**lurch: add

Tracking W-018567

Here and here is where we need to update the value with the correct currency for multicurrency orgs (example here).

Included in beta release 3.100 (Beta 15)

Included in production release rel/3.100


updated version of sqlalchemy in poetry

Pull Request
Description
Updated version of sqlalchemy.
Python Versions
It worked for me with the Python 3.11 version.
I tried first with Python 3.10 which threw me the incompatible error in poetry
The currently activated Python version 3.10.8 is not supported by the project (^3.11).
Trying to find and use a compatible version.

I faced issues with Python 3.12 too. Python 3.11 is compatible with both poetry and sqlalchemy.
Fixes #88

Thanks @roshnaeem

It looks like the tests failed - https://github.com/openclimatefix/pv-site-datamodel/actions/runs/8318096910/job/22759627236
Can you do a fix, test locally? and then a new PR?

@peterdudfield, I tried running the test, but I was getting this error.

you have to install testcontainers, if this is not in the Readme.md that would be great to add

@peterdudfield, yes it was a problem on my end with the python version. Fixed it and opened a PR which passes all pytests.
Please check https://github.com/openclimatefix/pv-site-datamodel/pull/108


Analyze transaction hash in ethers log, but not exists onchain

The hash is generated by ethers to identify the transaction before submitting to chain. If the RPC failed to submit, the TX hash will not exist on the block explorer. This is normal