Missing Kosovo

Hi @ all
Missing Kosovo
https://en.wikipedia.org/wiki/Kosovo
ISO 3166 code | XK

Kosovo is partially recognized and this data is coming form ICU database, so that's where you should report issues. This just converts it to other formats.

I'm not an expert, but I can find the "XK" country code for Kosovo inside the ICU 74.1 release. Should this package get an update?
Thanks in advance!

@umpirsky thanks for this excellent package! I'm also missing XK (Kosovo) and after reading the last comment I'm wondering if this should now be included? Thank you so much 💐

You are free to build a new version and submit PR.


Changed figure to fig in template match (fix issue with fig and fragments)

Hi Stefan,
I was trying to push to the doctales "origin"! :)
I guess forking on github and then cloning locally is the way to go.
Looking forward to contribute more in the future.
Thanks for the opportunity to learn about git, along the DITA-OT!
Raymond

Ok. figure, not being a DITA element, would never match this template. Thank you!

@raybiss, I've talked to Jarno. This template converts HTML5 to XHTML. So this is correct and I close this PR and I'm looking forward to your next PR. :smile:

No problem! The fork was deleted. :( This change was nonetheless fixing my fig/@fragment issue
! :) See attached screen capture comparison between the two outputs.

I'll send you the two html files by email.
Thank you.


Support savepoints

This PR adds support for:

RELEASE SAVEPOINT savepoint_name statements
Adds TO SAVEPOINT savepoint name support to ROLLBACK statements.

If we're going to get this accepted upstream it's probably best not to change formatting.
Otherwise looks awesome!

If we're going to get this accepted upstream it's probably best not to change formatting.
Otherwise looks awesome!

Thanks @freshtonic!
Yeah I'm a bit confused by the formatting changes, but cargo fmt insisted. I'm using the same Rust version and formatter settings as upstream CI, so I have no clue why the formatter decided that these changes only need to happen now. Spent a good 10 min trying to revert them.

If we're going to get this accepted upstream it's probably best not to change formatting.
Otherwise looks awesome!

Thanks @freshtonic!
Yeah I'm a bit confused by the formatting changes, but cargo fmt insisted. I'm using the same Rust version and formatter settings as upstream CI, so I have no clue why the formatter decided that these changes only need to happen now. Spent a good 10 min trying to revert them.

Scratch that. Looks like comments are part of rustfmt's heuristics for choosing when to split things into multiple lines. I was able to revert the formatting changes and appease rustfmt in this commit where I also added in some docs.


stream.lineOracle getting undefined when i'm write a new node?

This isn't a useful bug report. Feel free to try again but put enough effort into it to make it easy for us to understand what is going on the next time.


Remove the extra quote for the class names

class name had an extra quote causing invalid html

Too slow :-)


Changes in epub.js

Description
Some changes in epub.js
Attach Screenshot

Note 2 code reviewer approval needed. Approach in twitter group & discord channel.

Could you explain what all you have changed and how to run the code

Could you explain what all you have changed and how to run the code

Instead of using tweets, created a format, used mock data for using twit-thread.json(will create) but I was stuck on how to create htmlContent and options and passing options variable as argument in new Epub as Tolga suggested.

@tolgaerdonmez could you help out

ons variable as argument in new Epub as Tolga sug

So here I added the generateEpub function and gave the tweets and outputPath created in the index.js

Here is the generateEpub function, which uses the newly created tweets

ons variable as argument in new Epub as Tolga sug

So here I added the generateEpub function and gave the tweets and outputPath created in the index.js

Here is the generateEpub function, which uses the newly created tweets

Thank you Kenny and Tolga

@shekhar10feb I think the epub changes have been made by @tolgaerdonmez already? If yes, please close this and raise a PR just for the article you have written

@shekhar10feb I think the epub changes have been made by @tolgaerdonmez already? If yes, please close this and raise a PR just for the article you have written

Ok


Codegen gives SIGSEGV

Problem statement
Trying to codegen a seemingly valid swagger spec segaults the swagger cli tool.
Swagger specification
Swagger spec that causes the segfault:
swagger: '2.0'
info:
  version: 0.0.1
  title: PowerDNS Authoritative HTTP API
  license:
    name: MIT
host: localhost:8081
basePath: /api/v1
schemes:
  - http
consumes:
  - application/json
produces:
  - application/json
paths:
  /servers:
    get:
      summary: List all servers
      operationId: listServers
      tags:
        - servers
      responses:
        '200':
          description: An array of servers
          schema:
            $ref: '#/definitions/Servers'

  '/servers/{server_id}':
    get:
      summary: List a server
      operationId: listServer
      tags:
        - servers
      parameters:
        - name: server_id
          in: path
          required: true
          description: The id of the server to retrieve
          type: string
      responses:
        '200':
          description: An server
          schema:
            $ref: '#/definitions/Server'

  '/servers/{server_id}/zones':
    get:
      summary: List all Zones in a server
      operationId: listZones
      tags:
        - zones
      parameters:
        - name: server_id
          in: path
          required: true
          description: The id of the server to retrieve
          type: string
      responses:
        '200':
          description: An array of Zones
          schema:
            $ref: '#/definitions/Zones'

  '/servers/{server_id}/zones/{zone_id}':
    get:
      summary: zone managed by a server
      operationId: listZone
      tags:
        - zones
      parameters:
        - name: server_id
          in: path
          required: true
          description: The id of the server to retrieve
          type: string
        - name: zone_id
          type: string
          in: path
          required: true
          description: The id of the zone to retrieve
      responses:
        '200':
          description: A Zone
          schema:
            $ref: '#/definitions/Zone'

definitions:
  Server:
    properties:
      type:
        type: string
        description: 'Set to “Server”'
      id:
        type: string
        description: 'The id of the server, “localhost”'
      daemon_type:
        type: string
        description: '“recursor” for the PowerDNS Recursor and “authoritative” for the Authoritative Server'
      version:
        type: string
        description: 'The version of the server software'
      url:
        type: string
        description: 'The API endpoint for this server'
      config_url:
        type: string
        description: 'The API endpoint for this server’s configuration'
      zones_url:
        type: string
        description: 'The API endpoint for this server’s zones'

  Servers:
    type: array
    items:
      $ref: '#/definitions/Server'

  Zone:
    properties:
      id:
        type: string
        description: 'Opaque zone id (string), assigned by the server, should not be interpreted by the application. Guaranteed to be safe for embedding in URLs.'
      name:
        type: string
        description: 'Name of the zone (e.g. “example.com.”) MUST have a trailing dot'
      type:
        type: string
        description: 'Set to “Zone”'
      url:
        type: string
        description: 'API endpoint for this zone'
      kind:
        type: string
        enum:
          - 'Native'
          - 'Master'
          - 'Slave'
        description: 'Zone kind, one of “Native”, “Master”, “Slave”'
      rrsets:
        type: object
        items:
          $ref: '#/definitions/RRSets'
        description: 'RRSets in this zone'
      serial:
        type: integer
        description: 'The SOA serial number'
      notified_serial:
        type: integer
        description: 'The SOA serial notifications have been sent out for'
      masters:
        type: array
        items:
          type: string
        description: ' List of IP addresses configured as a master for this zone (“Slave” type zones only)'
      dnssec:
        type: boolean
        description: 'Whether or not this zone is DNSSEC signed (inferred from presigned being true XOR presence of at least one cryptokey with active being true)'
      nsec3param:
        type: string
        description: 'The NSEC3PARAM record'
      nsec3narrow:
        type: boolean
        description: 'Whether or not the zone uses NSEC3 narrow'
      presigned:
        type: boolean
        description: 'Whether or not the zone is pre-signed'
      soa_edit:
        type: string
        description: 'The SOA-EDIT metadata item'
      soa_edit_api:
        type: string
        description: 'The SOA-EDIT-API metadata item'
      api_rectify:
        type: boolean
        description: ' Whether or not the zone will be rectified on data changes via the API'
      zone:
        type: string
        description: 'MAY contain a BIND-style zone file when creating a zone'
      account:
        type: string
        description: 'MAY be set. Its value is defined by local policy'
      nameservers:
        type: array
        items:
          type: string
        description: 'MAY be sent in client bodies during creation, and MUST NOT be sent by the server. Simple list of strings of nameserver names, including the trailing dot. Not required for slave zones.'

  Zones:
    type: array
    items:
      $ref: '#/definitions/Zone'

  RRSets:
    type: array
    items:
      $ref: '#/definitions/RRSet'

  RRSet:
    properties:
      name:
        type: string
        description: 'Name for record set (e.g. “www.powerdns.com.”)'
      type:
        type: string
        description: 'Type of this record (e.g. “A”, “PTR”, “MX”)'
      ttl:
        type: integer
        description: 'DNS TTL of the records, in seconds. MUST NOT be included when changetype is set to “DELETE”.'
      changetype:
        type: string
        description: 'MUST be added when updating the RRSet. Must be REPLACE or DELETE. With DELETE, all existing RRs matching name and type will be deleted, including all comments. With REPLACE: when records is present, all existing RRs matching name and type will be deleted, and then new records given in records will be created. If no records are left, any existing comments will be deleted as well. When comments is present, all existing comments for the RRs matching name and type will be deleted, and then new comments given in comments will be created.'
      records:
        type: array
        description: 'All records in this RRSet. When updating Records, this is the list of new records (replacing the old ones). Must be empty when changetype is set to DELETE. An empty list results in deletion of all records (and comments).'
        items:
          $ref: '#/definitions/Record'
      comments:
        type: array
        description: 'List of Comment. Must be empty when changetype is set to DELETE. An empty list results in deletion of all comments. modified_at is optional and defaults to the current server time.'
        items:
          $ref: '#/definitions/Comment'

  Record:
    properties:
      content:
        type: string
        description: 'The content of this record'
      disabled:
        type: boolean
        description: 'Whether or not this record is disabled'
      set-ptr:
        type: boolean
        description: 'f set to true, the server will find the matching reverse zone and create a PTR there. Existing PTR records are replaced. If no matching reverse Zone, an error is thrown. Only valid in client bodies, only valid for A and AAAA types. Not returned by the server.'

  Comment:
    properties:
      content:
        type: string
        description: 'The actual comment'
      account:
        type: string
        description: 'Name of an account that added the comment'
      modifided_at:
        type: integer
        description: 'Timestamp of the last change to the comment'

While the spec is very large, I think the relevant part has something to do with nesting an object in the schema definition. The following patch to the above spec seems to make the problem go away (authoritative-api-swagger.yaml is the working version while the .bkp is the borked one):
$ diff authoritative-api-swagger.yaml{,.bkp}
27,29d26
<             #type: array
<             #items:
<             #  $ref: '#/definitions/Server'
66,68d62
<             #type: array
<             #items:
<             #  $ref: '#/definitions/Zone'
146c140
<         type: array
---
>         type: object
148c142
<           $ref: '#/definitions/RRSet'
---
>           $ref: '#/definitions/RRSets'

Steps to reproduce
$ swagger validate authoritative-api-swagger.yaml.bkp
The swagger spec at "authoritative-api-swagger.yaml.bkp" is valid against swagger specification 2.0
swagger generate client -f authoritative-api-swagger.yaml -A pdns-go

$ swagger generate client -f authoritative-api-swagger.yaml.bkp -A pdns-go
2017/10/30 18:16:40 building a plan for generation
2017/10/30 18:16:40 planning definitions
DEBUG: name - %v RRSets
DEBUG: name - %v rrsets
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xe pc=0x9608ab]

goroutine 1 [running]:
github.com/go-swagger/go-swagger/generator.(*schemaGenContext).NewSliceBranch(0xc421706c00, 0xc421b966c0, 0x1)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/generator/model.go:388 +0x60b
github.com/go-swagger/go-swagger/generator.(*schemaGenContext).buildArray(0xc421706c00, 0x0, 0x0)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/generator/model.go:1082 +0xd5
github.com/go-swagger/go-swagger/generator.(*schemaGenContext).buildItems(0xc421706c00, 0x0, 0x0)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/generator/model.go:1118 +0xc8e
github.com/go-swagger/go-swagger/generator.(*schemaGenContext).makeGenSchema(0xc421706c00, 0xc420cfd8f0, 0x6)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/generator/model.go:1459 +0xa6f
github.com/go-swagger/go-swagger/generator.(*schemaGenContext).buildProperties(0xc421706000, 0xc4217062c0, 0xc4228759b8)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/generator/model.go:674 +0x304
github.com/go-swagger/go-swagger/generator.(*schemaGenContext).makeGenSchema(0xc421706000, 0x0, 0xc421c01a10)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/generator/model.go:1447 +0x9a6
github.com/go-swagger/go-swagger/generator.makeGenDefinitionHierarchy(0xc420d37ce0, 0x4, 0xc421337db0, 0x6, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/generator/model.go:166 +0x31a
github.com/go-swagger/go-swagger/generator.makeGenDefinition(0xc420d37ce0, 0x4, 0xc421337db0, 0x6, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/generator/model.go:133 +0xbc
github.com/go-swagger/go-swagger/generator.(*appGenerator).makeCodegenApp(0xc42031ad20, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/generator/support.go:602 +0x5d9
github.com/go-swagger/go-swagger/generator.(*clientGenerator).Generate(0xc42031ad20, 0xc42031ad20, 0x6)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/generator/client.go:117 +0x78
github.com/go-swagger/go-swagger/generator.GenerateClient(0x7ffc9828b199, 0x7, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xc4204165a0, 0xc4204c7c98, ...)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/generator/client.go:109 +0x751
github.com/go-swagger/go-swagger/cmd/swagger/commands/generate.(*Client).Execute(0xc42080fe00, 0xc42081e420, 0x0, 0x6, 0xc42080fe00, 0x1)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/cmd/swagger/commands/generate/client.go:103 +0x41c
github.com/go-swagger/go-swagger/vendor/github.com/jessevdk/go-flags.(*Parser).ParseArgs(0xc42081e3c0, 0xc4200100f0, 0x6, 0x6, 0x410a98, 0x30, 0xc4202f2a20, 0xc4201ed580, 0xc4201ece48)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/vendor/github.com/jessevdk/go-flags/parser.go:316 +0x893
github.com/go-swagger/go-swagger/vendor/github.com/jessevdk/go-flags.(*Parser).Parse(0xc42081e3c0, 0x6, 0xbaa9d7, 0x6, 0x0, 0xbf3197)
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/vendor/github.com/jessevdk/go-flags/parser.go:186 +0x73
main.main()
        /spare/local/ajaisingh/goworkspace/src/github.com/go-swagger/go-swagger/cmd/swagger/swagger.go:105 +0x858

Environment
swagger version: 2.0
go version: go version go1.8.3 linux/amd64
OS: Ubuntu 16.04

This is likely your problem:
  rrsets:
    type: object
    items:
      $ref: '#/definitions/RRSets'
    description: 'RRSets in this zone'

items is for array, not object.  If you want to embed that directly, just do this:
  rrsets:
    $ref: '#/definitions/RRSets'

Note that you can't then have a description there with the $ref.

@gregmaar You're right, except the validator does not seem to error out, which I was hoping it would.

Interesting.  The spec doesn't actually say that items is not valid for object, only that it's required for array.  That might be why the validator doesn't catch it.

@gregmarr Is that a problem in the spec definition or in the codegen/parser?

I honestly have no idea, @casualjim will need to chime in here.

This issue has been addressed in go-openapi/validate https://github.com/go-openapi/validate/pull/32 but the changes are not pulled to go-swagger/vendor yet

I just merged those changes into master on go-swagger/go-swagger

I verified that the current version correctly detects this as a spec error.
Made a shorter fixture to reproduce the case.
I'll push PR to add this check as a fixture in UT

This issue should be closed now


Error middleware defaults status code to 200?

I noticed that when invoking error-handling middleware (via next(err)) and haven't explicitly set the response status code, it defaults to 200 OK.  This strikes me as strange given it's purpose is to handle errors, so I was just curious if this is intentional and, if so, why?  Perhaps this should default to 5xx instead?  Thanks for any insight!

Yes, that is strange. Is it possible to provide a simple app we can run to replicate the issue to understand what is causing the issue?

Sure!
// Using<EMAIL_ADDRESS>
const express = require('express')
const app = express()
app.get('/', (req, res, next) => next('ruh roh'))
app.use((err, req, res, next) => console.log(err, res.statusCode))
app.listen(3000)

Running curl localhost:3000 will log ruh roh 200.  Let me know if you need more details.

I believe that property comes from node core.  If you check what your curl's response is it will be 500.

Oh, interesting.  Sure enough...
const http = require('http')
http.ServerResponse.prototype.statusCode = 200

From an Express-user point of view it still seems weird 😅

While I see the point you are making, I don't think it would make sense for express to change this behavior either :)
Also, just having an error handling middleware to me does not mean you want to send a 500.  It means you want to have custom error handling, which might include setting a status.  If in the end this got to the final handler as an error, then it would in fact set the 500 status, so it is in that case the expected behavior to the requesting client.

All valid points -- thanks for the feedback!


feat: add monthly_hours usage field for aws/azure/gcp VMs

Updates the following resource types to support a monthly_hours usage flag:

aws_instance
azurerm_virtual_machine
azurerm_linux_virtual_machine
azurerm_windows_virtual_machine
google_compute_instance

This addresses #1556.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

At its core this is a pretty straightforward PR, but the myriad golden file updates have made it appear larger than it is.
Happy to break this up into a separate PR each for AWS / Azure / GCP resources, if the maintainers prefer. Looking forward to getting feedback and getting this landed!

Thanks for the contribution @jessecureton 🙏! One of our team will look at this in the next couple of days.

Sounds good! I took a look at the failing test case in the CI checks and it seems unrelated to this change. I did notice the failing test case (TestBreakdownWithPrivateTerraformRegistryModule) does not run locally, and instead prints the following message.
breakdown_test.go:369: Skipping because INFRACOST_TERRAFORM_CLOUD_TOKEN is not set and external contributors won't have this.

Locally running make test_all passes all tests as expected, so hazarding a guess this seems like it might be something related to CI secrets when running in my forked repo?

@jessecureton you're correct. I pushed a fix to skip this test in https://github.com/infracost/infracost/pull/1809, but I think there might still be issues here I haven't had a chance to investigate today.

1. I think we should we use `monthly_hrs` to be consistent with the other `*_hrs` usage keys.

I used monthly_hours to match the same field name already in use in several other resources - namely azurerm_synapse_spark_pool, aws_glue_job, and aws_glue_crawler. That said, I'm happy to make this change if you still prefer the _hrs syntax, just wanted to point out the mixed convention already in use.

2. Should it be a float value for the use-case if a user only runs the instance for a few minutes in the month?

This seems reasonable! I will make this change alongside the above once I hear back re: the preferred syntax

I've updated this to include both the requested changes for float values and the switch to monthly_hrs! Thanks for the link to the policy doc for naming, I had missed that initially!


Cherry pick root cert auto rotation

Introduce a root cert rotator into Citadel that periodically checks root certificate expiration time and rotates expiry root certificate. Root cert rotation uses old root private key.
Support Citadel to sync root cert in local key cert bundle with root cert in istio-ca-secret, which is needed when multiple Citadels are deployed.
#17059

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test lint_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test lint_istio_release-1.3

racetest_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test racetest_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test lint_istio_release-1.3

racetest_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test racetest_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-new-install-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test lint_istio_release-1.3

racetest_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test racetest_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-new-install-k8s-tests_istio_release-1.3

integ-mixer-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-mixer-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test lint_istio_release-1.3

racetest_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test racetest_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-new-install-k8s-tests_istio_release-1.3

integ-mixer-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-mixer-k8s-tests_istio_release-1.3

integ-security-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-security-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test racetest_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-new-install-k8s-tests_istio_release-1.3

integ-mixer-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-mixer-k8s-tests_istio_release-1.3

integ-security-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-security-k8s-tests_istio_release-1.3

lint_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test lint_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-mixer-k8s-tests_istio_release-1.3

integ-security-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-security-k8s-tests_istio_release-1.3

lint_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test lint_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-new-install-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-security-k8s-tests_istio_release-1.3

lint_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test lint_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-new-install-k8s-tests_istio_release-1.3

integ-mixer-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-mixer-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test lint_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-new-install-k8s-tests_istio_release-1.3

integ-mixer-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-mixer-k8s-tests_istio_release-1.3

integ-security-k8s-tests_istio_release-1.3
3cc2b6cfba0b6d5e1d2d43eee32b52431592b96a
link
/test integ-security-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
1a5895b5af84af79dfbf39a022066cad61450ddf
link
/test lint_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
1a5895b5af84af79dfbf39a022066cad61450ddf
link
/test lint_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
1a5895b5af84af79dfbf39a022066cad61450ddf
link
/test integ-new-install-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
1a5895b5af84af79dfbf39a022066cad61450ddf
link
/test lint_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
1a5895b5af84af79dfbf39a022066cad61450ddf
link
/test integ-new-install-k8s-tests_istio_release-1.3

integ-mixer-k8s-tests_istio_release-1.3
1a5895b5af84af79dfbf39a022066cad61450ddf
link
/test integ-mixer-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

It seems that the lint_istio_release-1.3 job is broken.

Yes the lint test is broken because of yamllint in release-1.3. I'll merge this PR when it's fixed.

I assume this is close to the release-1.1 fix.
Please add an item for this PR into the 1.3.5 release note draft.

I have updated the release note now. Thanks!
I need to update this PR as there are differences between 1.2 and 1.3, and the current PR is based on cherry-pick PR for release 1.2.
I will remove the hold label once the PR is ready.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.3
1a5895b5af84af79dfbf39a022066cad61450ddf
link
/test integ-new-install-k8s-tests_istio_release-1.3

integ-mixer-k8s-tests_istio_release-1.3
1a5895b5af84af79dfbf39a022066cad61450ddf
link
/test integ-mixer-k8s-tests_istio_release-1.3

lint_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test lint_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.3
1a5895b5af84af79dfbf39a022066cad61450ddf
link
/test integ-new-install-k8s-tests_istio_release-1.3

integ-mixer-k8s-tests_istio_release-1.3
1a5895b5af84af79dfbf39a022066cad61450ddf
link
/test integ-mixer-k8s-tests_istio_release-1.3

lint_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test lint_istio_release-1.3

racetest_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test racetest_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio_release-1.3
1a5895b5af84af79dfbf39a022066cad61450ddf
link
/test integ-mixer-k8s-tests_istio_release-1.3

lint_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test lint_istio_release-1.3

racetest_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test racetest_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test integ-new-install-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test lint_istio_release-1.3

racetest_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test racetest_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test integ-new-install-k8s-tests_istio_release-1.3

integ-mixer-k8s-tests_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test integ-mixer-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test racetest_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test integ-new-install-k8s-tests_istio_release-1.3

integ-mixer-k8s-tests_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test integ-mixer-k8s-tests_istio_release-1.3

lint_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test lint_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test integ-mixer-k8s-tests_istio_release-1.3

lint_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test lint_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test integ-new-install-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Legit lint failures:
security/pkg/k8s/controller/workloadsecret_test.go:354:3: U1000: field `rootCertMatchBundle` is unused (unused)
		rootCertMatchBundle bool
		^

security/pkg/pki/ca/selfsignedcarootcertrotator.go:152:11: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
level=info msg="[runner] Issues before processing: 9455, after processing: 2"
			} else {
			       ^

/test racetest_istio_release-1.3

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio_release-1.3
0f4ce7d4143686cdf8b7fce906418c5ba2602546
link
/test integ-new-install-k8s-tests_istio_release-1.3

racetest_istio_release-1.3
0637375e830d87baaff14b64dd6c6dc9504c8eca
link
/test racetest_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JimmyCYJ: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio_release-1.3
0637375e830d87baaff14b64dd6c6dc9504c8eca
link
/test racetest_istio_release-1.3

integ-new-install-k8s-tests_istio_release-1.3
0637375e830d87baaff14b64dd6c6dc9504c8eca
link
/test integ-new-install-k8s-tests_istio_release-1.3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test racetest_istio_release-1.3


Less pkg, mo mojo

Hey Andrew,
I noticed that many of the postcss packages included replicate functionality already included in http://cssnext.io/ and it's successor https://preset-env.cssdb.org/.
This PR removes Autoprefixer, post-css-extend, postcss-hexrgba, postcss-nested, postcss-nested-ancestors and postcss-simple-vars; the functionality they provide is all provided I believe by the most awesome postcss-preset-env: https://preset-env.cssdb.org/features
Options, such as those for Autoprefixer can be passed directly to postcss-preset-env instead. My postcss config, for example, contains:
module.exports = {
  plugins: [
    require("postcss-import")({
      plugins: [
        require("stylelint"),
      ]
    }),
    require('postcss-preset-env')({
      autoprefixer: { grid: true }
    }),
    require('postcss-normalize'),
    require('postcss-easing-gradients'),
    require('tailwindcss')('./tailwind.config.js')
  ]
};

Great, thank you @nternetinspired -- I will test the changes and see if there are any implications.

Seems to work great, thank you!

@nternetinspired in case you have any input on this... I'm oddly not seeing things being auto-prefixed using this setup? I've read the docs, and it doesn't seem like we're doing anything wrong, though.
https://github.com/csstools/postcss-preset-env#autoprefixer
https://github.com/browserslist/browserslist#queries

Figured it out... it was working... but not for anything that Tailwind generated, because it needs to be required after it. I'll update the config.

Good catch @khalwat, apologies for not correcting the ordering myself; I should have spotted that. My current setup is:
module.exports = {
    plugins: [
      require('postcss-import')({
        plugins: [
          require('stylelint'),
        ]
      }),
      require('postcss-normalize'),
      require('tailwindcss')('./tailwind.js'),
      require('postcss-preset-env')({
        autoprefixer: { grid: true },
        features: {
          'nesting-rules': true
        }
      })
    ]
};

You'll hear all about it on the next episode of https://devmode.fm/ -- comes out on Monday January 7th! :)
I like your defaults, and will adopt them into the project repo too

So I ended up with this:
https://github.com/nystudio107/annotated-webpack-4-config/commit/f669742a6fd7d19878b3ea42b95a485415040685
Note the use of stylelint-config-recommended and added .stylelintrc.json to use it, and override the warnings about Tailwind specific things.


Fixed broken link to open issues

Associated Issue: #4
Summary of Changes

Fixed broken link to issues

Pull Request Test Coverage Report for Build 36

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 89.231%

Totals

Change from base Build 35:
0.0%

Covered Lines:
87

Relevant Lines:
99

💛  - Coveralls

Thank you!


Suggestion using git conventional commits

Hi, I think we should use git conventional for our commit message and branch for easy maintenance. https://www.conventionalcommits.org/en/v1.0.0/

That sounds like a great idea. I'll look into it and try to follow the conventions.


Checkbox is not working without these specific attributes

awesome-bootstrap-checkbox: v1.0.1
bootstrap: v4.1.1
Checkbox is only working whenever this code is used:

	<input type="checkbox" class="form-check-input" id="check">

It does not work using the following code below:

whenever the id attribute is missing inside the <input> tag
whenever the for attribute is missing inside the  tag

	<input type="checkbox" class="form-check-input">

Closing it without even saying anything. If it has been solved, or it can't be replicated, or it's a feature that's not a priority as of now. ☹
Nonetheless, I have used another plugin for this matter.
Thanks anyways. 😁


Create a principled way to test documentable on the actual documentation

The problem
In a first approximation, documentable needs to generate exactly the same URLs that there are now. Although these URLs are ad-hoc and not really specified (see this issue in the problem-solving repository) we don't want to lose them in the process of revamping tooling.
Suggestions
Test documentable with current static web pages and check that everything is OK. Or mostly OK.

Since we've cutover, can we close this out?

I'm not totally sure this should be closed. Documentable testing is still hit and miss, and this specific aspect, for instance, is not really tested. Even if there are unit tests all over, there are integration tests that are not really there. The problem also is that there's actually no spec for how URLs should be generated. There's this issue, and then a proposal, but it's impossible to test without specs...

So let's get a ticket for the specs, and the tests for Documentable can go in Documentable, and then this ticket is done.

I've edited the title. It's not really about testing Documentable, but about testing generated docs. And about specs we haven't even agreed we need one yet. I'll make this external, because I sill think there's some need for this. Besides, I see @Altai-man has self-assigned it.

doc-website is using Collection; any future Documentable tests should be covered in https://github.com/Raku/Documentable, any tests of generated documentation files for Collection can go there.


Create *.hks.localplayer.dev

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.
[x] There is no NS Records (Enforced as of Sepetember 4th, 2024)

Description

Will be used to allow me to access my self-hosted VPS instance when out and about, without needing to access it through the IP address. On VPS many projects: docker, Torrserve, Nginx and other. I need the wildcard subdomain to allow me to access the services that I host over secure https, without needing to get an alternative domain for it. For example, I can host the uptime monitor for my VPS on up.hks.localplayer.dev
Link to Website

That is not for website. That is for open projects, like TorrServer, docker monitoring for my router, etc. Its for VPS hosting
I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA


Add expected command formats in certain error messages

Prerequisite PR to be merged: #63
Send the expected format of the command for error messages with the wrong arguments.

[x] Game commands
[x] Lineup commands
[x] User commands

@allendomingo Please update with latest v2.1.0


target_temperature will not change

Hi,
I just tried your lib. This is really great stuff!
Everything is controllable (fan speed, on/off, cooling/only fan) but not the temperature.
When I tried to change it from 20 to 21 (or other temperatures) the device respond always with 17.
I can't figure out why.
Can you help me investigating this?

👋 I cannot take much credit for it, I have only made some minor tweaks.
Does your usage differ somehow from the way @andersonshatch/Midea-ac-py adjusts the temperature? That is the one client I’m aware of, and temp set does work there

Ah ok.
Cannot use the script https://github.com/andersonshatch/midea-ac-py because it's adjusted to hass. But so far I can say, it is the same commands. But I used the complete library from https://github.com/andersonshatch/midea-ac-lib
I tried now with the original ruby library. Just the same Problem :(

I'm attempting to set the temperature from within HA as well.  Did you ever figure out a solution or a workaround for this?  Thanks in advance!


1797650: Remove '?view=azure-cli-latest' syntax

No code changes. Part of an effort to remove unnecessary versioning link syntax.
See user story 1797650 for more information.

@ashishonce, @narula0781, and/or @romil07, please approve the PR so we can sign off and bring closure to the cross-repo update of removing monikers that are for "latest".  Monikers should only be specified when we do NOT want the latest version.  Thanks very much!

#sign-off
These updates are being done in all MSFT repos containing Azure CLI links, and do not require author approval.

@ romil07 or @zhenghao104, could you please merge this PR?

@tedchamb, can you please merge this PR?  Thank you.

@chandrasekharmudili, can you please merge this PR?  Thank you.

@chandrasekharmudili, can you please merge this PR?  Thank you.

I sent email to Ashish and Manish, asking them to Approve this PR #1073.
Thanks.
GeneMi (= MightyPen)

I sent email to Ashish and Manish, asking them to Approve this PR #1073.
Thanks.
GeneMi (= MightyPen)


⚠ Bofrost.de has degraded performance

In 3144c0b, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1555 ms

Resolved: Bofrost.de performance has improved in ce1695e.


[Bitcoin] Invalid base58 data error on a legacy-type wallet

OS: Uduntu-22.0.4 TLS
Bitcoinnode1 - regtest mode
Bitcoinnode2 - regtest mode
Both nodes are connected.
First 101 blocks are generated by bitcoin-cli
If I start mining by cpuminer in solo mode - all works properly.
Pools section from config.json:
 "pools": [
        {
            "id": "bitcoin1",
            "enabled": true,
            "coin": "bitcoin",
            "address": "bcrt1q3vxjg7pe9gu2skmq5w5v2hr5dn0r60nnaspgqv",
            "rewardRecipients": [
                {
                    "address": "bcrt1q3vxjg7pe9gu2skmq5w5v2hr5dn0r60nnaspgqv",
                    "percentage": 1.5
                }

Addresses was retrieved by run
bitcoin-cli -regtest getnewaddress -legacy

After pool start I got the error:
[2023-03-09 20:34:34.9179] [I] [bitcoin1] All daemons synched with blockchain
[2023-03-09 20:34:34.9997] [E] [bitcoin1] System.FormatException: Invalid base58 data System.FormatException: Invalid base58 data
   at NBitcoin.DataEncoders.Base58Encoder.DecodeData(String encoded)
   at NBitcoin.DataEncoders.Base58CheckEncoder.DecodeData(String encoded)
   at Miningcore.Blockchain.Bitcoin.BitcoinUtils.AddressToDestination(String address, Network expectedNetwork) in /home/md0/miningcore/src/Miningcore/Blockchain/Bitcoin/BitcoinUtils.cs:line 20
   at Miningcore.Blockchain.Bitcoin.BitcoinJobManagerBase`1.AddressToDestination(String address, Nullable`1 addressType) in /home/md0/miningcore/src/Miningcore/Blockchain/Bitcoin/BitcoinJobManagerBase.cs:line 527
   at Miningcore.Blockchain.Bitcoin.BitcoinJobManagerBase`1.PostStartInitAsync(CancellationToken ct) in /home/md0/miningcore/src/Miningcore/Blockchain/Bitcoin/BitcoinJobManagerBase.cs:line 481
   at Miningcore.Blockchain.JobManagerBase`1.StartAsync(CancellationToken ct) in /home/md0/miningcore/src/Miningcore/Blockchain/JobManagerBase.cs:line 112
   at Miningcore.Blockchain.Bitcoin.BitcoinPool.SetupJobManager(CancellationToken ct) in /home/md0/miningcore/src/Miningcore/Blockchain/Bitcoin/BitcoinPool.cs:line 368
   at Miningcore.Mining.PoolBase.RunAsync(CancellationToken ct) in /home/md0/miningcore/src/Miningcore/Mining/PoolBase.cs:line 392    at NBitcoin.DataEncoders.Base58Encoder.DecodeData(String encoded)
   at NBitcoin.DataEncoders.Base58CheckEncoder.DecodeData(String encoded)
   at Miningcore.Blockchain.Bitcoin.BitcoinUtils.AddressToDestination(String address, Network expectedNetwork) in /home/md0/miningcore/src/Miningcore/Blockchain/Bitcoin/BitcoinUtils.cs:line 20
   at Miningcore.Blockchain.Bitcoin.BitcoinJobManagerBase`1.AddressToDestination(String address, Nullable`1 addressType) in /home/md0/miningcore/src/Miningcore/Blockchain/Bitcoin/BitcoinJobManagerBase.cs:line 527
   at Miningcore.Blockchain.Bitcoin.BitcoinJobManagerBase`1.PostStartInitAsync(CancellationToken ct) in /home/md0/miningcore/src/Miningcore/Blockchain/Bitcoin/BitcoinJobManagerBase.cs:line 481
   at Miningcore.Blockchain.JobManagerBase`1.StartAsync(CancellationToken ct) in /home/md0/miningcore/src/Miningcore/Blockchain/JobManagerBase.cs:line 112
   at Miningcore.Blockchain.Bitcoin.BitcoinPool.SetupJobManager(CancellationToken ct) in /home/md0/miningcore/src/Miningcore/Blockchain/Bitcoin/BitcoinPool.cs:line 368
   at Miningcore.Mining.PoolBase.RunAsync(CancellationToken ct) in /home/md0/miningcore/src/Miningcore/Mining/PoolBase.cs:line 392

But if I will check Base58 with online base58 decode service I'll got error.
Ok, makes "-bech32" address and got same error from pool, but all correct with base58services.
In production mode (with main blockchain) I get pool work only with bech32 address, not with Legacy.

You can add "addressType": "BechSegwit" to your pool config and use bech32 addresses.

As per closed ticket on same issue...   This worked for me...
./bitcoin-cli getnewaddress "" "legacy"
Pool up and running now.

As per closed ticket on same issue... This worked for me... ./bitcoin-cli getnewaddress "" "legacy"
Pool up and running now.

Not for regtest network.


Complete copy edit pass

@rotycenh

OPS Build status updates of commit d71cace:
:clock10: Preparing: average preparing time is 45 sec(s)

OPS Build status updates of commit d71cace:
:clock10: Incremental building: average incremental building time is 23 sec(s)

OPS Build status updates of commit d71cace:
:warning: Validation status: warnings

File
Status
Preview URL
Details

bread/toc.json
:warning:Warning

Details

toc.json
:warning:Warning

Details

building-blocks/extending-templates/toc.json
:warning:Warning

Details

docs/cloud-adoption/infrastructure/logs-and-reporting/vdc-monitoring.md
:white_check_mark:Succeeded
View

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\nyvq\bread\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\nyvq\toc.json'.

building-blocks/extending-templates/toc.json

[Warning] Error happen when converting building-blocks/extending-templates/toc.json to Pdf. Details: Could not find a part of the path 'T:\nyvq\building-blocks\extending-templates\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

 Details: Could not find a part of the path 'T:\u0ht\building-blocks\extending-templates\toc.json'.

bread/toc.json

[Warning] Error happen when converting bread/toc.json to Pdf. Details: Could not find a part of the path 'T:\u0ht\bread\toc.json'.

toc.json

[Warning] Error happen when converting toc.json to Pdf. Details: Could not find file 'T:\u0ht\toc.json'.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Installation fails with ModuleNotFoundError

Hi,
As of very recently I am unable to start EPS. I suspected some issue with some package upgrade in Ubuntu 20.04.
Starting EPS with electrum-personal-server .eps/config.ini I get:
Traceback (most recent call last):
  File "/home/.local/bin/electrum-personal-server", line 8, in <module>
    sys.exit(main())
  File "/home/.local/lib/python3.7/site-packages/electrumpersonalserver/server/common.py", line 840, in main
    get_scriptpubkeys_to_monitor(rpc, config)
  File "/home/.local/lib/python3.7/site-packages/electrumpersonalserver/server/common.py", line 629, in get_scriptpubkeys_to_monitor
    first_addrs = [hashes.script_to_address(s, rpc) for s in first_spks]
  File "/home/.local/lib/python3.7/site-packages/electrumpersonalserver/server/common.py", line 629, in <listcomp>
    first_addrs = [hashes.script_to_address(s, rpc) for s in first_spks]
  File "/home/.local/lib/python3.7/site-packages/electrumpersonalserver/server/hashes.py", line 76, in script_to_address
    return rpc.call("decodescript", [scriptPubKey])["addresses"][0]
KeyError: 'addresses

I also tried upgrading EPS to 0.2.2. Running the command pip3 install --user I get the error:
  File "/home/loysan/.local/bin/pip3", line 6, in <module>
    from pip._internal.cli.main import main
  File "/home/loysan/.local/lib/python3.7/site-packages/pip/_internal/cli/main.py", line 10, in <module>
    from pip._internal.cli.autocompletion import autocomplete
  File "/home/loysan/.local/lib/python3.7/site-packages/pip/_internal/cli/autocompletion.py", line 9, in <module>
    from pip._internal.cli.main_parser import create_main_parser
  File "/home/loysan/.local/lib/python3.7/site-packages/pip/_internal/cli/main_parser.py", line 7, in <module>
    from pip._internal.cli import cmdoptions
  File "/home/loysan/.local/lib/python3.7/site-packages/pip/_internal/cli/cmdoptions.py", line 19, in <module>
    from distutils.util import strtobool
ModuleNotFoundError: No module named 'distutils.util'

I suspected it might be a broken package dependency, i reinstalled all python3/python3.7/python3.8 packages, including python3-distutils and python3.8-distutils. The package python3.7-distutils could not be found.
I understand this is more of a python problem than a EPS problem, but I can't figure out what EPS dependency I might be missing.
Suddenly, I can neither run EPS 0.2.1 nor install EPS 0.2.2

Did you make any progress with this error?
Closing the issue for now, feel free to reopen

Yeah, sorry for the lack of reply. I've added deprecatedrpc=addresses to my config file and eps is running. Thanks again!


swag init displayed two unexplained warnings

Describe the bug
A clear and concise description of what the bug is.
2024/05/28 17:38:37 warning: failed to evaluate const magic at \pkg\mod\github.com\xo\terminfo@v0.0.0-20220910002029-abceb7e1c41e\dec.go:11:2, strconv.ParseUint: parsing "o432": invalid syntax
2024/05/28 17:38:37 warning: failed to evaluate const magicExtended at \pkg\mod\github.com\xo\terminfo@v0.0.0-20220910002029-abceb7e1c41e\dec.go:14:2, strconv.ParseUint: parsing "o1036": invalid syntax

To Reproduce
Steps to reproduce the behavior:

swag init --parseDependency --generalInfo ./main.go --output ./docs

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots

Your swag version
swag.exe version v1.16.3
Your go version
go1.22.3
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser: [e.g. chrome, safari]
Version: [e.g. 22]

Additional context
Add any other context about the problem here.

swag will evaluate all consts in order to evaluate enums.

@sdghchj
What causes this problem?
Do I need to fix it?
I don't know where this is used...

No need.
Just ignore it.

@sdghchj Thanks


Custom unresponsive message and parameters for timed out website

Target URL: https://img.shields.io/website/http/
The status image takes too long to load for unresponsive websites. Therefore, here are the suggestions:
timeout=<seconds> (try x seconds before showing unresponsive message)
unresponsive_message=<message>
I love this project!
Thank you very much.

Hi! Thanks for the suggestion. The current timeout is probably 30 seconds which seems much too long. I'd suggest we make the default something like 10 seconds and allow configuring it anywhere between 1 and 30.
Shouldn't we use the "down" message for unresponsive?

Thanks for the reply.
I would say the current unresponsive message should be replaced by the down one if that is possible.


Fix unit tests

Description of Change
Removes the net461 target and an API in the mock that is not available in the installed Forms version in order to restore the unit test project to build and run successfully

Maybe this was just something that is not working locally. It seems to build on the build server... 😕


icon in darkmode not available

In Darkmode the left icon is missing to toggle the mode. In light mode a sun is visible.
Here is the setup:
Include the required Javascript
HTML_EXTRA_FILES       = doxygen-awesome-css/doxygen-awesome-darkmode-toggle.js
Add the additional CSS. This is ONLY required for the sidebar-only theme variant!
HTML_EXTRA_STYLESHEET  = doxygen-awesome-css/doxygen-awesome.css \
doxygen-awesome-css/doxygen-awesome-sidebar-only.css
doxygen-awesome-css/doxygen-awesome-sidebar-only-darkmode-toggle.css
set custom header & footer files generated in previous step
HTML_HEADER            = header.html
HTML_FOOTER            = footer.html

What browser and operating system are you using? Can you provide a screenshot?
The icon in the button by default is just using the emojis '☀' and '🌛'. This means that the appearance can differ across different systems. My guess is that your system or browser does not (fully) support emojis? 🤔
My suggestions on how to fix the problem for you:

You could overwrite the --darkmode-toggle-button-icon CSS property here and here with a symbol that works for you.
The toggle button is an empty html node that is styled using CSS here. If emojis/symbols don't work for you, you could probably also set a background-image or use an icon font.

I had the same problem as OP and the error is in this line in the instructions for the footer.html changes:
document.getElementById("MSearchBox").parentNode.appendChild(toggleButton)

The console was throwing an error that it couldn't find MSearchBox or its parent at the time of execution, but copy-pasting this code in the console after it was done loading the page adds the button and it works perfectly. Because of this I moved the location at which it appends the button and changed the css afterwards to make it fit directly from doxygen-awesome.css because for some reason I couldn't select the button even if I has a class attached to it. Here is my footer JS:

And my CSS:
doxygen-awesome-dark-mode-toggle {
    float: right;
    margin: 0 var(--spacing-small) 0 var(--spacing-small);
    padding: 0 ;
    width: var(--searchbar-height);
    height: var(--searchbar-height);
    background: none;
    border: none;
    font-size: 23px;
    border-radius: var(--border-radius-medium);
    vertical-align: middle;
    text-align: center;
    line-height: var(--searchbar-height);
}

It's just a hotfix CSS though. I hope this works for you OP until there's a fix to the repo here.

Yep, the fact that the searchbox is only rendered by JS after the page has loaded is annoying and I'm aware of that. But that's why the JS for adding the toggle button is put at the very end of the body, after the searchbox has been created. Are you sure that you really put the JS call all the way to the end of the body?
Does the button on the demo-page work on your system? If not, pls let me know! This would mean that my assumtion about the loading time of the searchbox is wrong... 🤔

Yes, it works fine on my Chrome version 92 and I'm using Windows 10. Here is my full footer.html

    $navpath

$generatedby  $doxygenversion

<address class="footer">
$generatedby  $doxygenversion
</address>

Thanks for the details! I discovered that this is a compatibility issue with doxygen 1.9.2 😞 .
For the moment I'd recommend you use doxygen 1.9.1 for generating your docs. I've created a new issue (#44) for tracking 1.9.2 support.

I'll close this issue for now. @Marco-Israel feel free to re-open it if updating to the latest version of doxygen-awesome-css doesn't resolve your problem.


[build error] 2.0.0-dev Couldn't find constructor 'FilterGroup'.

Error: Couldn't find constructor 'FilterGroup'.

@rizzi37 - did you find a solution for this? I'm having the same issue running version 2.0.0-dev.0

@jacodek has fixed, current version is 2.0.0


MAISTRA-1825 fix prometheus integration; MAISTRA-1804 specify istio c…

…onfig map name for kiali
Signed-off-by: rcernich<EMAIL_ADDRESS>

I think I'm lacking context here. EnvoyFilter resources in the control plane namespace apply to all mesh namespaces- so why do we copy them around?

Yep.  I need to rework this.  The problem is that the version is not being set correctly in the proxy, so the filters aren't being applied.


ForeignObject not working on ios/android

Hello,
I'm trying to use the ForeignObject component in my expo project but it returns me this error below
I wanted to use this component in order to display non-svg components like Text/TextInput in svg tags.
React native info output:

Library version<EMAIL_ADDRESS>Sample code
here is the code i'm trying to run :
http://pastebin.fr/60472
Is it possible to check why this error is happening ?
Thank you very much for your help

Not sure if expo has any of the versions including ForeignObject yet.

I have the exact same issue with Expo.
@msand

Not sure if expo has any of the versions including ForeignObject yet.

What do you mean by that? The react-native-svg version? I just removed my pm cache, installed react-native-svg again and I can see that in my and the nodes_module's package.json file the version is 12.1.0. But I still get the same error as @guiguithub . Not sure what to do...

I got it... Somehow instead of importing it this way:
import { Circle, ForeignObject } from 'react-native-svg';
I need to import it this way:
import ForeignObject, { Circle } from 'react-native-svg';

I need to import it this way: import ForeignObject, { Circle } from 'react-native-svg';

You are not importing ForeignObject, you are importing the default export of react-native-svg, which is the Svg object
So in your code, ForeignObject is just an alias for Svg


note/homebrew install not available for M1

added note: homebrew install is currently not available for M1 (Apple silicon)

since the current approach for these users is, to run the docker container without AVX, should this be noted as a workaround here? The docker container name is arangodb/arangodb:3.9.X-noavx

@dothebart afaik, this is a development workaround that is not officially supported. if so, I don't think it should be added here.


Add more options to the global config

Description
Fixes the 'tab-click-code-loading' issue

What is the purpose of this pull request?

[x] Bug fix
[ ] New feature
[ ] Other

Have you checked the updates on Colab or locally using a downloaded template?


canlitv.com

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS>. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and am willing to share it if required

Region
No response
Example URLs
canlitv.com/canli-tv8
Description
As it use segments, I looked for master.m3u8 while inspecting, but couldn't find.
Maybe you can add this site if be possible.
Verbose log
-

Open site support request at https://github.com/yt-dlp/yt-dlp/issues


When using the HTTP API, pass CGI parameters (URL?setting_1=value&setting_2=value...).

Is there any way we could add setting parameters on sqlalchemy-clickhouse now.
such as clickhouse://xxx.xxx.xxx.xx:8123/default?max_memory_usage=50000000000

As far as I know, you could use the underlying DBAPI connection to pass parameters, just like
conn = engine.raw_connection()
conn.add_setting('max_memory_usage',<PHONE_NUMBER>0)
cursor = conn.cursor()
cursor.execute('SELECT * FROM mytable LIMIT 10')
data = cursor.fetchall()
cursor.close()
conn.close()

As far as I know, you could use the underlying DBAPI connection to pass parameters, just like
conn = engine.raw_connection()
conn.add_setting('max_memory_usage',<PHONE_NUMBER>0)
cursor = conn.cursor()
cursor.execute('SELECT * FROM mytable LIMIT 10')
data = cursor.fetchall()
cursor.close()
conn.close()

thanks a lot for your reply.


Use gradle plugin eu.xenit.enterprise-conventions.oss:0.3.0-rc.1

kicked off test (snapshot) publication -> https://github.com/xenit-eu/thunx/actions/runs/3190918992/jobs/5206621616


MapEntry class and map assertions using it as parameters are not usable from OSGI projects.

asertj 2.0.0 MANIFEST.MF contains the following Private-Package attribute:
Private-Package: org.assertj.core.data,org.assertj.core.description,org.
 assertj.core.error,org.assertj.core.extractor,org.assertj.core.groups,o
 rg.assertj.core.internal,org.assertj.core.presentation,org.assertj.core
 .util,org.assertj.core.util.introspection,org.assertj.core.util.xml

This prevents usage of MapEntry class and map assertions using it as parameters from OSGI projects.
MapEntry should either be moved out of core.data package or core.data package should be marked public in OSGI metadata.

It seems that more packages are missing like core.extractor, core.description, core.error.
In fact I guess only core.internal package (and maybe util) are really private packages


Pillbox to allow only one item

Is there a way to allow pillbox to have only one item in it?

I'm having trouble picturing the use-case for this...
I could see adding a maxPills option though! You could add this and then set it to "1".
Feel free to issue a PR if you do this, thanks!


demo runtime environment issues

What version of pytorch is required for the environment? When I run the given demo_letr with version 1.10.0, I get the following error, ImportError: cannot import name '_new_empty_tensor' from 'torchvision.ops'.Is there a compatibility problem with my environment so I can't import it?

try torch-1.8.0+cu111,  torchvision-0.9.0+cu111, works for me;
If you use torch1.10.0, you can remove that "import" to solve your problem, but you will meet other version-related problem later.

Thanks. It worked when I downgraded the torch version to 1.8.0+cu111.

fixed here #28


Error: no integrated GPU detected.

After I run this bash ./02_cuda-display-driver-installation.sh I am getting the above error. I am using ubuntu instance as my laptop is of windows . Please help .

Can you try the latest branch 20.04-6.3?


Flux Visualization

Hi! Is this a sort of feature you'd like to see contributed to greaseweazle, or is it better kept separate?  I ask because using greaseweazle code to read .scp files helped provide a short path to producing this visualization.
If you're interested, I'll work to integrate the code in gw via pull request.  It would add a couple of big new prerequisites, numpy and skimage.

The current code lives at https://github.com/jepler/fluxvis/ and can be licensed as needed.

My $0.02: integrating this into Greaseweazle host tools would sorta bloat the codebase past its purpose of performing low-level operations on floppy drives.  However, adding, say, a --visualize option to the read module—dependent on whether fluxvis is found in $PATH—could invoke it with the parameters that were already passed to Greaseweazle.  Please take what I say with a grain of salt, though; I actually know nothing about ideal software design LOL

We were inspired by the flux visualization of applesauce, which people seem to like. It can also help mere humans understand floppy disk structure and problems, such as spiral protection tracks, "degaussed" and dirty media. https://wiki.reactivemicro.com/Applesauce#Applesauce_Image_File_Format_.28.WOZ_and_.A2R.29
It would be interesting to combine the flux density visualization with flux interpretation, possibly using fluxengine's csv format: http://cowlark.com/fluxengine/doc/using.html#visualisation

But as we have the word of the maintainer that this is best NOT added to gw, happy to close this up and let fluxvis live on its own! thanks for your time, as well as for the GW code for reading flux files which made it possible to write this tool.

To be direct: I'll be happy to see visualisation in greaseweazle but to be useful it needs flux interpretation and that is bound to need closer integration with the greaseweazle core and indeed changes to the greaseweazle core. 1s and 0s, or flux length interpretation, is pretty but unenlightening. Thank you for the request and starting a discussion!


update semiology laterality

the following laterality options need updating for the checkboxes on slicer:
TONIC: should have L, R or OTHER
OTHER SIMPLE MOTOR: should have L, R or OTHER
ALL AUTOMATISMS: should have L, R or OTHER

ICTAL SPEECH: should only have OTHER

You can modify the .txt files in https://github.com/thenineteen/Semiology-Visualisation-Tool/tree/master/resources


[Feature] Geometry API Extension

After reviewing common extensions to the Bitmap class, it's evident that shapes such as lines, circles, triangles, polygons, isogons, and ellipses are frequently added. As RGU already includes a Geometry class, extending it to handle common geometry shapes beyond just triangles seems beneficial.

[ ] Line
[ ] Circle
[ ] Polygon
[ ] Isogon
[ ] Ellipse

The development of URGE, utilizing modern graphics backends and coroutine scheduling with web support, has now begun. This project will be converted to an LTSC version for long-term maintenance, and no new features will be added.
https://github.com/Admenri/urge


Latest align2rawsignal executable?

Hello Anshul,
Quick question where should I download the latest align2rawsignal executable from?
I found one version here: https://code.google.com/archive/p/align2rawsignal/downloads
and one here: https://personal.broadinstitute.org/anshul/softwareRepo/align2rawsignal_revised.tar.gz
The latter one looks more recent.
Thanks,
Myrto

Use https://code.google.com/archive/p/align2rawsignal/downloads
On Fri, Feb 10, 2017 at 8:12 AM, Myrto Kostadima<EMAIL_ADDRESS>wrote:

Hello Anshul,
Quick question where should I download the latest align2rawsignal
executable from?
I found one version here: https://code.google.com/
archive/p/align2rawsignal/downloads
and one here: https://personal.broadinstitute.org/anshul/
softwareRepo/align2rawsignal_revised.tar.gz
The latter one looks more recent.
Thanks,
Myrto
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/akundaje/align2rawsignal/issues/2, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI7Ec7TSL5NAoG63oI_OXEDeyZHoo7lks5rbIx7gaJpZM4L9jde
.

Will do. Thanks!


we should error if there is nothing after the pipeline then hit enter,

This is the example of what I am expecting:
>>  where { -not $_.PSIsContainer -and $_.Extension -match 'wma | mp3'} |
>>  Measure-Object -property length -sum -min -max -ave```

Two issues:
1). After I hit <enter> after the pipeline on first line, I am not getting the prompt on the 2nd line or 3rd line.  We return to normal PS command prompt (in the REPL windows).  eg:

```PS C:\> Get-ChildItem 'c:\users\jinglou' -Recurse |
PS C:\> ```

2). We do get a red squiggle after the pipeline, and the message says "An empty pipe element is not allowed". Andre feels we should have an error message.

Dupe of #200 ?

Dupe


Fix Issue 19838 - RefCounted fails to instantiate due to pureness of …

…moveEmplace

Please add a test case to avoid future regressions.

I can't find a reduced test case that reproduces the behavior on our codebase.
Somehow it seems that inferring pureness doesn't work in this particular case, which points to a deeper issue.
This PR will alleviate the situation introduced by manually annotating RefCountedStore.move() as pure in https://github.com/dlang/phobos/commit/c4324f405c6aea75c9c074c42a21b42a2a361d76#diff-4e008aedb3026d4a84f58323e53bf017

Shouldn't this be a dmd bug?

Ping! Any comments on this and if this, or a better fix are going to be merged?

Please add the test case for the issue.

I did try to find a reduced test case but wasn't able to. I suppose once the real bug is found and understood better it will be easier.
Despite not being a real fix, it will at least hopefully revert things to how they used to be before the bug was introduced.
This bug is preventing us from upgrading without a big code refactor so we are stuck in 2.083.1

OK.

Also please target stable.

Done - Thanks!


Fix batch queue handling in Optimism derivation

Fix: preserve the order of received batches with the same timestamp. Use BTreeMap<u64, VecDeque<Batch>> instead of the non-stable BinaryHeap.
Fix: when creating empty batches, consider special case of handling the first batch of an epoch.
Add the corresponding L1 block to the L2 safe head.
Remove the inclusion block from Batch.

Tested (and works) with:
$ RUST_BACKTRACE=1 RUST_LOG=info ../zeth/target/release/op-derive \
    --eth-rpc-url="https://eth-mainnet.g.alchemy.com/v2/[my api key]" \
    --op-rpc-url="https://opt-mainnet.g.alchemy.com/v2[my api key]" \
    --cache=cache \
    --op-block-no=110800000 \
    --op-blocks=10000


[WIP] File.new POSIX like modes.

This PR only contains basic functionality.  Locking will be handled in another PR.

Do you mind if I take this PR for myself? I'd like to implement it and play around with it in a certain way on my own.

If you are wondering why this implementation is so bare, it's based on other PR's (#5651, #5627, #7857, #7931 etc) with tons of design commentary requiring redesigns or closing/reopening issues with completely new code.
I thought a minimalist design would open avenues for comments or a shared code base rather than me writing a complete detailed implementation that has to be scrapped, which already seems like that may be happening.
@RX14 I added you as a collaborator on my fork.

Robustness achieved.  Missing flags are caught.  The prior error disappeared after rebasing.  Maybe my crystal was out of sync.

How many years should I wait for a review?  The opportunity to get this in 1.0 has passed.

I am not in favor of #9073.  It's confusing.  Object.new creates a new object in memory in most programming languages, not creates the resource it represents.
If moving to File.open please tell me which of the following should also happen:
Aws::S3.new # Creates a new s3 object - use .open to read an existing one.
Aws::EC2.new # Starts a new ec2 instance that you're billed for.
Mysql.new # Creates a new database server instance
Memcached.new # Starts a new memcached server.
...

@straight-shoota pointed out that this goes against all other uses of .new/.open where .open takes a block and closes the resource before returning.  .new means you manage it yourself.  When did that convention change?

Specs pass, the modes are simplified based on RX14's suggestions, SYNC was removed.
What  else is required to get this merged?

@didactic-drunk Is this change backwards-compatible? That is, can I still do File.open("file.txt", "w")?

@didactic-drunk Is this change backwards-compatible? That is, can I still do File.open("file.txt", "w")?

Yes.  Proof:

All specs with string modes are unmodified.
open_flags(mode : String) is utilized and unmodified.  open_flags(mode: File::Mode) handles the new symbol(s)/enum.
File.new/File.open contain explicit String mode methods with deprecation warnings.

This change consists of serveral pieces:

Add File::Mode flag enum
Add handling of File::Mode in Crystal::System::File
Add overloads for File.new/.open with File::Mode
Refactor to use new File.new/.open overloads in stdlib and the compiler
Refactor some uses of File.open to File.new ✖
Deprecate old overloads of File.new/.open with String mode ✖

If possible, I'd like to separate some of these changes.
I'm not sure if we're already commited to deprecating the string-based file modes. It would be possible to defer that.
Several refactorings from File.open to File.new throughout stdlib could be extracted as separate changes. We can apply that independent of the other changes.
So I'd like to move the items marked with ✖ out of the main PR. The others are tightly related and should work as a single change set.
WDYT?
It's probably best to start a completely new PR to get rid of the old history. Let's finalize the discussion on the API first, though.
I've created #11901 for that to keep the PR focused on implementation. The API looks good overall, but I'm proposing a few minor adjustments. Let's continue there!

Refactor some uses of File.open to File.new heavy_multiplication_x

Deprecate old overloads of File.new/.open with String mode heavy_multiplication_x

If possible, I'd like to separate some of these changes.

Ok.

I'm not sure if we're already commited to deprecating the string-based file modes. It would be possible to defer that. Several refactorings from File.open to File.new throughout stdlib could be extracted as separate changes.

Ok.

We can apply that independent of the other changes. So I'd like to move the items marked with heavy_multiplication_x out of the main PR. The others are tightly related and should work as a single change set. WDYT?

Ok.

It's probably best to start a completely new PR to get rid of the old history.

Is that preferred to remove changes, rebase, force push?

Yes, I think starting a new PR is better. It means we keep the old review history attached here.
And start with a new review history and a new scope in a new PR.
Let's finalize the API in https://github.com/crystal-lang/crystal/issues/11901 first, though.


Breaks AUGH jetpack mod?

does this actually happen?
mods: voice mod, augh jetpack, ship self destruct, vanillafix

narp it works still LOL i win


added more comprehensive error message for node error check

Fixes #12
Also added extra unit test for the odin

Agreed offline to make it 0-indexed and to change the node_x variable names to match


[Impeller] impellerc will blow up if you specify a layout(location= on a sampler2D.

Error looks like
Compilation failed.
/Users/dnfield/src/flutter_shaders/lib/shaders/pixelation.frag: GLSL to SPIRV failed; Compilation error. 0 error(s) and 2 warning(s).
/Users/dnfield/src/flutter_shaders/lib/shaders/pixelation.frag:10: warning: 'uPixels' : ignoring layout qualifier for uniform location
/Users/dnfield/src/flutter_shaders/lib/shaders/pixelation.frag:11: warning: 'uSize' : ignoring layout qualifier for uniform location
shaderc: internal error: compilation succeeded but failed to optimize: [VUID-StandaloneSpirv-Location-06672] Location decoration must not be applied to this storage class
  %uTexture = OpVariable %_ptr_UniformConstant_44 UniformConstant

Target debug_android_application failed: ShaderCompilerException: Shader compilation of "/Users/dnfield/src/flutter_shaders/lib/shaders/pixelation.frag" to "/Users/dnfield/src/flutter_shaders/example/build/app/intermediates/flutter/debug/flutter_assets/packages/flutter_shaders/shaders/pixelation.frag" failed with exit code 1.
impellerc stdout:

impellerc stderr:
Compilation failed.
/Users/dnfield/src/flutter_shaders/lib/shaders/pixelation.frag: GLSL to SPIRV failed; Compilation error. 0 error(s) and 2 warning(s).
/Users/dnfield/src/flutter_shaders/lib/shaders/pixelation.frag:10: warning: 'uPixels' : ignoring layout qualifier for uniform location
/Users/dnfield/src/flutter_shaders/lib/shaders/pixelation.frag:11: warning: 'uSize' : ignoring layout qualifier for uniform location
shaderc: internal error: compilation succeeded but failed to optimize: [VUID-StandaloneSpirv-Location-06672] Location decoration must not be applied to this storage class
  %uTexture = OpVariable %_ptr_UniformConstant_44 UniformConstant

The solution is to remove the location directive (or even just remove the whole layout specifier).
The error is probably going to be hard for users to understand, but I think it's also probably not super commonly used and maybe the users who do come across it will just know what to do.
I don't know if there's any way to get shaderc to be more permissive of such errors, but I'm also not sure how much more we want shaderc to accept weird input data. The path forward is probably flutter_gpu for this kind of thing anyway?

I think users will be able to figure this out. Solution: remove the layout.


o1 streaming

o1 and o1-mini support streaming now and they are no longer in the beta limitations. please add support for it if possible.
https://platform.openai.com/docs/guides/reasoning#beta-limitations

Done in the v2-dev branch.


Update TEL reference documentation

Rationale
The reference documentation has gone stale - I noticed a couple things during implementation/integration that could be corrected. I will also see if there is room for enhancement.
In particular:

ri is required in rev events
a nonce, n can be added to VC events so their saids are not easily guessable/constructable

I can't assign myself but I'm working on this


adaptive positioning with usePopper vertical position failing in certain circumstances

Reproduction demo
test.zip
Run yarn install && yarn start
What went wrong?

I'm trying to make a gallery of images in buttons that shows a larger version of the image on hover. I'm running into these strange issues when using placement: 'top'. The tooltip shows fine when it is below the but not when it is above.
Trying changing placement, commenting in/out <Svg/> zooming in/out, scrolling. I can't narrow down exactly what is causing the problem, but it happens frequently, and in all browsers.
Packages versions
"@popperjs/core": "^2.4.4",
"react-popper": "^2.2.3",

It seems that this fixes it:
modifiers: [
      {
        name: 'computeStyles',
        options: {
          adaptive: false, // true by default
        },
      },
    ]

Possibly related to this issue on the popperjs core, except that I'm not even using position: relative.

Not sure if the same issue, but most likely it is.
I am using a rather complex combination but it seems it is a superset of what you have. I included some debug hints, so you may try those ...
What I have is

React Tippy in headless mode with inlinePositioning plugin (Tippy is based on Popper)
Default positioning: top
Popper element rendered to document.body
flip modifier with fallbackPlacements: ['top-start', 'top-end', 'bottom', 'bottom-start', 'bottom-end'],
preventOverflow modifier with mainAxis: false, altAxis: true
offset modifier with dynamic offset calculation

What happens to me is that until the flip modifier kicks in, everything is OK

But once the flip modifier triggers the simulation of the alternative positions, it throws the popper element beyond the fold. Thanks to offset and some negative margins I can see it misplaced. Yours may be just below the fold ...

When I disable adaptive mode, it works OK and properly flips

After an agonizing debug session, I narrowed it down to a point where I found out that the popper element has both top: 0 and bottom: 0 set at the same time, making its height the window height instead of my default height and further calculating offsets with it

Upon further debugging, I found out that the initialStyles of the applyStyles modifier write top position but don't reset bottom getting the wrapper element into this situation. It seems that it is not aware of the historical styles applied by the flip modifier, or the flip modifier doesn't reset the complete state.

Hopefully someone with proper knowledge will pick this information up, and try to find a proper fix for it.

I know this is an upstream error, but does any owner from this repo have the knowledge/time/permissions to fix this in @popper/core, or bug one of them to fix it (pressure from dependent library maintainers might hold more weight than random users).

@FezVrasta for me also not working, do you have any update?

@vincerubinetti why you closed? how you fixed?

Per my comment above, doctype fixes it. More of a strange consequence of browser quirks mode.

Okay just going to reopen for @hejtmii's situation. @happylolonly you probably need to upload a minimal reproduction for yours so they can fix it.

ok, I can do it little bit later, @FezVrasta do you need more info and possibilities to fix? I see you have new lib

👋 the library is in low maintenance mode, everyone should move to Floating UI and its React bindings.
https://github.com/floating-ui/react-popper#-this-library-is-in-maintenance-mode
I don't plan to release additional versions unless they are meant to fix vulnerabilities. Hopefully that makes sense.


Can't start on Debian / OpenJDK 11

I just set up the Sourcerer app and ran into this error:
$ sourcerer
Error occurred during initialization of boot layer
java.lang.module.FindException: Module java.activation not found

I saw there's a package libactivation-java in Debian, installing it didn't help though since it contains a different module "javax.activation".
But removing --add-modules java.activation from the sourcerer wrapper script did the trick and I can now successfully use the app.
Not sure if this is issue is specific to Debian sid or OpenJDK 11.
I'm using these packages:
ii  openjdk-11-jdk:amd64          11.0.1+13-3  amd64        OpenJDK Development Kit (JDK)
ii  openjdk-11-jdk-headless:amd64 11.0.1+13-3  amd64        OpenJDK Development Kit (JDK) (headless)
ii  openjdk-11-jre:amd64          11.0.1+13-3  amd64        OpenJDK Java runtime, using Hotspot JIT
ii  openjdk-11-jre-headless:amd64 11.0.1+13-3  amd64        OpenJDK Java runtime, using Hotspot JIT (headless)

it should be fixed now #431

@asurkov looks good, thanks! :+1:

@toupeira glad to hear, thanks for checking out!


[MLDB-2086] passing the config to mldb_runner in debug and release

passing the mldb.conf when doing make  to allow logging
storing the mldb.conf in the docker image and passing it to mldb_runner
fix a crash when failing to parse the command line

I'm not sure if we should overload MLDB_EXTRA_FLAGS for this purpose.
mldb.conf might deserve its own template variable since we probably want to pass it all the time.
I see EXTRA_FLAGS as the hook which can be used to pass image specific parameters.
With this change, we would have to remember to set the config file along with the extra flags we want to pass.
I think we could add --config-path=$(MLDB_CONFIG_FILE) to mldb_runner.sh and set the path directly in TEST_$(1)_RAW_COMMAND  (or change MLDB_CONFIG_FILE when doing a debug build)


oxford_gps_eth: 1.1.1-1 in 'noetic/distribution.yaml' [bloom]

Increasing version of package(s) in repository oxford_gps_eth to 1.1.1-1:

upstream repository: https://bitbucket.org/DataspeedInc/oxford_gps_eth.git
release repository: https://github.com/DataspeedInc-release/oxford_gps_eth-release.git
distro file: noetic/distribution.yaml
bloom version: 0.9.7
previous version for package: null

oxford_gps_eth
* Install Python script
* Add missing rospy dependency
* Contributors: Kevin Hallenbeck, Micho Radovnikovich

@kmhallen friendly ping :)

I'll look into it

@kmhallen friendly ping :)

@kmhallen I'll close this one for now, assuming the solution is a new release.


Lock PHPUnit to the v4.* series

Currently, the composer.json would allow any 4.x or 5.x+ versions PHPUnit, however a composer update may bring the .lock file to a PHPUnit 5.* version - which only supports PHP v5.6+. That would break the Travis matrix for PHP versions 5.3, 5.4, & 5.5 builds.
"phpunit/phpunit":"~4.8" allows for a non-breaking PHPunit from v4.8, which remains compatible with PHP v5.3+ versions, including PHP v7 & HHVM.

From https://getcomposer.org/doc/articles/versions.md#tilde:

Note: The ~ operator has an exception on its behavior for the major release number. This means for example that ~1 is the same as ~1.0 as it will not allow the major number to increase trying to keep backwards compatibility.


Configure end-point probe-time,retry values etc from kube-loxilb

Currently, some values needed to configure end-points like probing timer and retry values need to be manually configured using loxicmd. Otherwise the default values in loxilb are used which may not be suitable for everyone. Linked to this issue

The support has been added. More details can be found in the linked issue.


Postback doesn't work for example in your example (threads-example.js) it should give you saying response if you click on help or sittings but it didn't

`bot.setPersistentMenu([
{
type: 'postback',
title: 'Help',
payload: 'PERSISTENT_MENU_HELP'
},
{
type: 'postback',
title: 'Settings',
payload: 'PERSISTENT_MENU_SETTINGS'
},
{
type: 'web_url',
title: 'Go to Website',
url: 'http://yostik.io'
}
]);
bot.on('postback:PERSISTENT_MENU_HELP', (payload, chat) => {
chat.say(I'm here to help!);
});
bot.on('postback:PERSISTENT_MENU_SETTINGS', (payload, chat) => {
chat.say(Here are your settings: ...);
});`

Hey @Obadh, are you getting any errors when trying to use this example? I just tested it and it seems to be working correctly for me: http://c.hlp.sc/3S2C0J2z1w3W


Spec Improvements

This is a proposal to improve the default slice interfaces in order to have a more scalable system and a more intuitive theme building.
Sizes
The xxs and xxl could become  2xs and 2xl in order to suggest a more scalable naming for all sizes props.
Font Slice
As the font slice keys could be used to define different fonts and even the same fonts with different weights and styles it could be better to leave this slice more flexible by changing regular, medium, bold to just one default property default.
Borders
primary and secondary keys seem to not work properly to define borders. We could change them with some more appropriate like thin and `bold.
Zindices
light, soft and strong keys seem to not work properly to define zIndices. We could change them with some more appropriate like `lowest, lower, low, high, higher, highest.

I agree with the new interfaces, steps needed if we want to change those interfaces are:

update @morfeo/spec package
update @morfeo/preset-default
re-build the theme and update css inside the web-extension
update the docs
Will you do it?

closed with PR #110

closed with PR #110


ArcticWolf_11's Ban Appeal

Name: ArcticWolf_11
Server: Terra
Ban Reason: X-Ray
First of all, though you're probably not going to believe it but, I literally had no idea I even had it installed... Hear me out, I asked Elemental what he thought what rule I was breaking because I literally was confused as to why he was messaging me. Kept asking trying to get to the bottom of it then he said I had X-Ray. No clue I even had it, was typing to ask if he wanted me to reinstall the pack or something, then I get banned. Also I don't know but haven't you thought that maybe someone else other than me uses the computer?... Hence why I was asking if you wanted me to reinstall the pack, thus getting rid of it. Now if in the future it's back there again then yeah I understand getting banned for that. I really do hope you understand and that second chances will be granted, thank you.

As unlikely as this seems, I am willing to give you benefit of a doubt and believe you. As long as you uninstall the modifications, I can unban your account. Please make sure it doesn't happen again.


(1.23) Update etcd version to 3.4.21

Update etcd version to 3.4.21

 test run for 1.21 --> 1.23 upgrade path
ubuntu@wayfarer ~/D/c/m/core (master) $ CHANNELS="1.21 1.22 1.23 latest/edge/etcd-123" ./etcd-upgrade.sh
+ export ID=327465
+ ID=327465
+ export 'CHANNELS=1.21 1.22 1.23 latest/edge/etcd-123'
+ CHANNELS='1.21 1.22 1.23 latest/edge/etcd-123'
+ [[ x = \x ]]
+ JUJU_MODEL=microk8s-etcd-upgrade-327465
+ juju add-model microk8s-etcd-upgrade-327465
Added 'microk8s-etcd-upgrade-327465' model on zerostack/KHY with credential 'admin' for user 'admin'
+ juju add-machine -m microk8s-etcd-upgrade-327465 --constraints 'mem=4G cores=4 root-disk=40G'
created machine 0
+ [[ x != \x\n\o ]]
+ trap cleanup EXIT
+ export JUJU_MODEL=microk8s-etcd-upgrade-327465
+ JUJU_MODEL=microk8s-etcd-upgrade-327465
+ juju run --machine 0 --timeout 20m '
sudo snap install microk8s --classic --channel 1.21
sudo microk8s disable ha-cluster --force
'
microk8s (1.21/stable) v1.21.13 from Canonical** installed
Reverting to a non-HA setup
Generating new cluster certificates.
Waiting for node to start.

Waiting for model to be removed...
Model destroyed.

Test run for 1.23 seems to have failed with
error: failed to create deployment: Post "https://<IP_ADDRESS>:16443/apis/apps/v1/namespaces/default/deployments?fieldManager=kubectl-create": dial tcp <IP_ADDRESS>:16443: connect: connection refused

Running again to check whether this is a flake or an actual issue.
 test run 1.21 --> 1.23

ubuntu@wayfarer ~/D/c/m/core (master) $ CHANNELS="1.21 1.22 1.23 latest/edge/etcd-123" ./etcd-upgrade.sh
+ export ID=327465
+ ID=327465
+ export 'CHANNELS=1.21 1.22 1.23 latest/edge/etcd-123'
+ CHANNELS='1.21 1.22 1.23 latest/edge/etcd-123'
+ [[ x = \x ]]
+ JUJU_MODEL=microk8s-etcd-upgrade-327465
+ juju add-model microk8s-etcd-upgrade-327465
Added 'microk8s-etcd-upgrade-327465' model on zerostack/KHY with credential 'admin' for user 'admin'
+ juju add-machine -m microk8s-etcd-upgrade-327465 --constraints 'mem=4G cores=4 root-disk=40G'
created machine 0
+ [[ x != \x\n\o ]]
+ trap cleanup EXIT
+ export JUJU_MODEL=microk8s-etcd-upgrade-327465
+ JUJU_MODEL=microk8s-etcd-upgrade-327465
+ juju run --machine 0 --timeout 20m '
sudo snap install microk8s --classic --channel 1.21
sudo microk8s disable ha-cluster --force
'
microk8s (1.21/stable) v1.21.13 from Canonical** installed
Reverting to a non-HA setup
Generating new cluster certificates.
Waiting for node to start.

Waiting for model to be removed...
Model destroyed.

Repeating the run gave a success:
 1.21 --> 1.23

ubuntu@wayfarer ~/D/c/m/core (master) $ CLEANUP=no CHANNELS="1.21 1.22 1.23 latest/edge/etcd-123" ./etcd-upgrade.sh
+ export ID=339902
+ ID=339902
+ export 'CHANNELS=1.21 1.22 1.23 latest/edge/etcd-123'
+ CHANNELS='1.21 1.22 1.23 latest/edge/etcd-123'
+ [[ x = \x ]]
+ JUJU_MODEL=microk8s-etcd-upgrade-339902
+ juju add-model microk8s-etcd-upgrade-339902
Added 'microk8s-etcd-upgrade-339902' model on zerostack/KHY with credential 'admin' for user 'admin'
+ juju add-machine -m microk8s-etcd-upgrade-339902 --constraints 'mem=4G cores=4 root-disk=40G'
created machine 0
+ [[ xno != \x\n\o ]]
+ export JUJU_MODEL=microk8s-etcd-upgrade-339902
+ JUJU_MODEL=microk8s-etcd-upgrade-339902
+ juju run --machine 0 --timeout 20m '
sudo snap install microk8s --classic --channel 1.21
sudo microk8s disable ha-cluster --force
'
microk8s (1.21/stable) v1.21.13 from Canonical** installed
Reverting to a non-HA setup
Generating new cluster certificates.
Waiting for node to start.


TIKA-3879 - add s3 testcontainers integration test

add s3 tika pipes integration tests
add integration test for s3 pipe iterator, s3 fetcher, and s3 emitter.

Couple of really small things.  Thank you so much for getting this rolling!


Does Troposphere support Aurora?

Summary
I am trying to use Troposphere code to deploy Aurora. I was looking at the source for DBCluster and I didn't see any place to configure the Instance size, i.e. db.r3.large or some size. Is this configured elsewhere?
Potential examples
I was then looking at the stack_builder Github repo. It seems to configure the Instance size as the param InstanceType here:

https://github.com/remind101/stacker_blueprints/blob/master/conf/rds/aurora/aurora.yaml#L57

But, InstanceType isn't a configurable param in the DBCluster.
I looked around the aurora/base.py Troposphere file too, but didn't see anything for InstanceType:

https://github.com/remind101/stacker_blueprints/blob/master/stacker_blueprints/rds/aurora/base.py

For RDS, the param is called DBInstanceClass to configure the Instance size. I didn't see this param either in the Aurora files linked above.
I hope that is enough context. Thanks in advance for any help.
Cheers,
Aaron

Please disregard. I see in the code that I have to also configure ClusterInstance's and they appear to be connected by the DBClusterIdentifier
Thanks