Fix type so it works instead of using properly

The following does not work:
using System;

type TupleInts : Tuple<int, int>;

procedure void test()
{
    TupleInts a = testTuple();
    log(a.Item1);
    log(a.Item2);
}

function TupleInts testTuple()
{
    TupleInts toReturn = TupleInts(5, 7);
    return toReturn;
}

However the following does work:
using System;

using TupleInts = System.Tuple<int, int>;

procedure void test()
{
    TupleInts a = testTuple();
    log(a.Item1);
    log(a.Item2);
}

function TupleInts testTuple()
{
    TupleInts toReturn = TupleInts(5, 7);
    return toReturn;
}

And the following works:
using System;

type TupleInts : Tuple<int, int>;

procedure void test()
{
    var a = testTuple();
    log(a.Item1);
    log(a.Item2);
}

function TupleInts testTuple()
{
    var toReturn = TupleInts(5, 7);
    return toReturn;
}

This seems to be because the constructor in the "testTuple" function returns a Tuple<int, int> instead of a TupleInts. In the using example, the Tuple is simply aliased, while in the type example the type is derived. In the generated code it would be like saying:
List<int> a = new List<object>();
Which of course should give an error.
However, in our case we should generate code so it should not give an error as we are using TupleInts(); as the constructor and not Tuple<int, int>();


Remove damienmg@ from code owners

I am no longer going to maintain projects in the bazelbuild org.

(I'll remove myself from the admin of that repo afterwards).

If you have question, whichever, I will always be happy to answer them by mail :)


chore: add memo to lnurl and lnaddress send mutations

Description
Add memo field when sending via lnurl or lnaddress

Closing because for now we'd like to prioritize the lnurl/ln-address memo from the invoice description as the final transaction memo


Automated cherry pick of #8961: fix(region): valid qcloud hssd for system disk

Cherry pick of #8961 on release/3.5.
#8961: fix(region): valid qcloud hssd for system disk

Codecov Report

Merging #8963 (24372aa) into release/3.5 (6a15e02) will decrease coverage by 1.77%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/3.5   #8963       +/-   ##
===============================================
- Coverage         5.98%   4.20%    -1.78%
===============================================
  Files              796     163      -633
  Lines           125693   24870   -100823
===============================================
- Hits              7522    1047     -6475
+ Misses          117504   23731    -93773
+ Partials           667      92      -575

Flag
Coverage Δ

aFlag
4.20% <ø> (-1.78%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cloudcommon/db/jointbase.go
0.00% <ø> (ø)

pkg/keystone/models/identitybase.go

pkg/multicloud/aws/dbinstance_parameter.go

pkg/hostman/guestfs/sshpart/sshpart.go

pkg/cloudcommon/validators/validators.go

pkg/compute/models/wires.go

pkg/appsrv/cors.go

pkg/appsrv/fetch.go

pkg/mcclient/options/k8s/releaseapp.go

pkg/compute/models/wireresource.go

... and 617 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb8805...24372aa. Read the comment docs.


Add delete_accountfield to Account_update.Body.Stable.ttype definition

See  this description in the RFC

related to archive nodes (supposed to be archived) --- other issues can fix this, can come later coz lower priority

One of the CI issues (namely replayer test not working) most probably depends on solving this issue

All unit tests issues in #15832 (updating the expected result), minus the replayer issue above, will be resolved applying the method described in this document


fix bug #1122 log.smtp receiver configure error

INI file doesn't support array format with bracket "[]",
It may be better to use ',' to split it.

Thanks!


BBB Web app crashes when App is sharing webcam

The web app suddenly crashes when the app is sharing the webcam

@jo-code Nevermind I think it is a duplicate of #34


Problem: when pointing to the button, outline is visible.

Not sure if it's a bug or it's just me. But when I mouse-down on the clickable element, it's default outline becomes visible. The strange thing is everything is ok with the demo-app I'm running in the same browser (Chrome).
I think it would be better to remove such behaviour by default if not done yet. It's especially not in-place for buttons with icons.

p.s.
I'm able to remove it. Just interested - shouldn't it be disabled by default.

Please provide a codepen so we can investigate further.

Closing this issue as it does not follow the issue template. Please file a new issue that follows the template, which gives the team the information needed to investigate.

I think you are only importing the MdButtonModule correct?


Assign Task - Task name disappears on logout and login again

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Click on + icon
Select Assign task option
Create a new task
Go to settings > logout
Login again

Expected Result:
Should show task name
Actual Result:
Task name disappears on logout and login again
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/93399543/7b6ec887-04e8-4b4d-9508-c3c3be9d8b10
https://github.com/Expensify/App/assets/93399543/8d8e2986-7ed9-4642-a62c-3c54e2565f22
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685357193039949
View all open jobs on GitHub

This is expected right now (due to some recent BE changes that were made), we're fixing this in https://github.com/Expensify/App/issues/19132


"Tree Grows in New Atlantis" Sensor Marked Stolen

One of the bio-sensors required by the quest "A Tree Grows in New Atlantis", specifically the one found in UC Distribution, is marked as stolen even when bought (and therefore obtained legally) from the vendor, Wen Tseng.

Game Version
<IP_ADDRESS>
Language
English (EN)
New Game
Yes
Reproduction Steps

Start the quest "A Tree Grows in New Atlantis"
Talk to Jorden near the SSNN building
Talk to Wen Tseng to purchase the bio-sensor
Look at inventory and notice purchased bio-sensor marked as stolen

Quest ID 00270718

The Sensor is Alias_SensorCommercial identified by LOCREFTYPE City_NA_Botany01_ComSensorLocRef [LCRT:0017AE58]
The Objectreference for this item is [00325E5E] with owner UC_NA_WenTseng "Wen Tseng" [NPC_:00012489].
Stages 65 and 66 of the quest need the fragment updating to add the following:
Alias_Sensor_Commercial.GetReference().SetActorOwner(NONE)


Error Seeding...

Hello, im using latest hyn and laravel 8 and i have the next problem:
inc onfig have:
'tenant-seed-class' => true,
//      eg an admin seeder under `app/Seeders/AdminSeeder.php`:
//        'tenant-seed-class' => App\Seeders\AdminSeeder::class,
        'tenant-seed-class' => Database\Seeds\Tenant\UserTenantSeeder::class,

in fonder database\seeds\tenant\ i have UserTenantSeeder:
<?php
namespace Database\Seeds;
use Illuminate\Database\Seeder;
use User;
class UserTenantSeeder extends Seeder
{
    /**
     * Run the database seeds.
     *
     * @return void
     */
    public function run()
    {
        User::create([
                	'name' => 'Admin One',
                	'email' =><EMAIL_ADDRESS>                	'password' => bcrypt('123456')
                ]);
    }
}

when i run php artisan tenancy:db:seed or adding --website_id=1
Show this:
D:\WebServer74\htdocs>php artisan tenancy:db:seed

   Illuminate\Contracts\Container\BindingResolutionException

  Target class [Database\Seeds\Tenant\UserTenantSeeder] does not exist.

  at D:\WebServer74\htdocs\vendor\laravel\framework\src\Illuminate\Container\Container.php:835
    831▕
    832▕         try {
    833▕             $reflector = new ReflectionClass($concrete);
    834▕         } catch (ReflectionException $e) {
  ➜ 835▕             throw new BindingResolutionException("Target class [$concrete] does not exist.", 0, $e);
    836▕         }
    837▕
    838▕         // If the type is not instantiable, the developer is attempting to resolve
    839▕         // an abstract type such as an Interface or Abstract Class and there is

  1   D:\WebServer74\htdocs\vendor\laravel\framework\src\Illuminate\Container\Container.php:833
      ReflectionException::("Class Database\Seeds\Tenant\TenantDatabaseSeeder does not exist")

  2   D:\WebServer74\htdocs\vendor\laravel\framework\src\Illuminate\Container\Container.php:833
      ReflectionClass::__construct("Database\Seeds\Tenant\TenantDatabaseSeeder")

any can help me please?
Thanks you

Same here, also using L8 and latest hyn/multi-tenant v5.7.3.
Since it's been 5 months, did you find a fix for this?

Database\Seeds\Tenant\UserTenantSeeder::class is not correct.  Your class has namespace Database\Seeds.  Either your class should have namespace Database\Seeds\Tenant, or your seeder class reference shouldn't have \Tenant\ in it.  Given the directory for the class contains tenant, the namespace should as well, so the first suggestion is correct.


Defining own testcase

Hello authors,
Thank you for sharing the code of this amazing work. I am using your framework to solve a multi-person multi-camera problem in real-time environment. I wanted to ask if we need to train the model again with our own data after setting up the environment or if we could use the pre-trained model and test it on the new data.
It would be really helpful if you could help me out in this aspect.
Thank you for your time.

Hello authors, Thank you for sharing the code of this amazing work. I am using your framework to solve a multi-person multi-camera problem in real-time environment. I wanted to ask if we need to train the model again with our own data after setting up the environment or if we could use the pre-trained model and test it on the new data. It would be really helpful if you could help me out in this aspect.
Thank you for your time.

Hello, have you solved the problem of human body pose estimation for multiple people and multiple cameras in a real-time environment?

@342600694 ,
Yes, I have solved the problem of setting up this model for a custom environment and get the results. I have not made it work real-time and am currently finding a way to decrease the latency but I am getting ok-ish results by testing the inference on a custom setup.

@342600694 , Yes, I have solved the problem of setting up this model for a custom environment and get the results. I have not made it work real-time and am currently finding a way to decrease the latency but I am getting ok-ish results by testing the inference on a custom setup.

I am currently reading the author's code and may try to use my own dataset to test and make it work in real time in the future. If there are any issues in the future, can I ask you for advice under this post? Thank you very much.

@342600694
Sure, just be careful with the camera calibration process and your results would be fine.

@342600694 Sure, just be careful with the camera calibration process and your results would be fine.

hey bro I can't understand some of the contents in project_individual.py. Is there any reference information?


Error installing helm chart

Have you

[x] Read Troubleshooting Guide
[x] Searched on GitHub issues and Discussions

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
I received the below error following the helm installation instructions from this link
$ helm repo add secrets-store-csi-driver https://raw.githubusercontent.com/kubernetes-sigs/secrets-store-csi-driver/master/charts
"secrets-store-csi-driver" has been added to your repositories
$ helm install csi-secrets-store secrets-store-csi-driver/secrets-store-csi-driver --namespace kube-system
Error: rendered manifests contain a resource that already exists. Unable to continue with install: ServiceAccount "secrets-store-csi-driver" in namespace "kube-system" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "csi-secrets-store"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "kube-system"
What did you expect to happen:
Successful installation of secrets-store-csi-driver
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
$ helm version
version.BuildInfo{Version:"v3.5.4", GitCommit:"1b5edb69df3d3a08df77c9902dc17af864ff05d1", GitTreeState:"clean", GoVersion:"go1.15.11"}
Which access mode did you use to access the Azure Key Vault instance:
[e.g. Service Principal, Pod Identity, User Assigned Managed Identity, System Assigned Managed Identity]
N/A
Environment:

Secrets Store CSI Driver version: (use the image tag): latest
Azure Key Vault provider version: (use the image tag):
Kubernetes version: (use kubectl version and kubectl get nodes -o wide):

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.0", GitCommit:"cb303e613a121a29364f75cc67d3d580833a7479", GitTreeState:"clean", BuildDate:"2021-04-08T16:31:21Z", GoVersion:"go1.16.1", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.9", GitCommit:"d2ea02d7bcf37724adabbdb9d37ede0cf2c0d627", GitTreeState:"clean", BuildDate:"2020-04-24T22:59:19Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.21) and server (1.16) exceeds the supported minor version skew of +/-1
NAME                     STATUS   ROLES    AGE   VERSION   INTERNAL-IP      EXTERNAL-IP   OS-IMAGE             KERNEL-VERSION      CONTAINER-RUNTIME
aks-default-41725384-0   Ready    agent    19m   v1.16.9   <IP_ADDRESS>               Ubuntu 16.04.6 LTS   4.15.0-1082-azure   docker://3.0.11+azure
aks-default-41725384-1   Ready    agent    19m   v1.16.9   <IP_ADDRESS>               Ubuntu 16.04.6 LTS   4.15.0-1082-azure   docker://3.0.11+azure
aks-default-41725384-2   Ready    agent    19m   v1.16.9   <IP_ADDRESS>               Ubuntu 16.04.6 LTS   4.15.0-1082-azure   docker://3.0.11+azure
k8s-master-41725384-0    Ready    master   19m   v1.16.9   <IP_ADDRESS>           Ubuntu 16.04.6 LTS   4.15.0-1082-azure   docker://3.0.11+azure
k8s-master-41725384-1    Ready    master   19m   v1.16.9   <IP_ADDRESS>           Ubuntu 16.04.6 LTS   4.15.0-1082-azure   docker://3.0.11+azure
k8s-master-41725384-2    Ready    master   19m   v1.16.9   <IP_ADDRESS>           Ubuntu 16.04.6 LTS   4.15.0-1082-azure   docker://3.0.11+azure

Cluster type: (e.g. AKS, aks-engine, etc): AKS Private Preview for Azure Stack Hub

Error: rendered manifests contain a resource that already exists. Unable to continue with install: ServiceAccount "secrets-store-csi-driver" in namespace "kube-system" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "csi-secrets-store"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "kube-system"

@seb0006 This error indicates you already have the driver installed in the cluster with different helm release name.
The helm charts hosted here have the driver charts as a dependency. Using the chart from this repo will install the driver and also the azure provider.

@aramase - It turns out that the AKS Private Preview product on Azure Stack Hub has the driver and azure provider installed when a new cluster is created with Kubernetes version 1.16.9.  This was a surprise since this isn't documented anywhere that I have found, but was able to confirm the installation by creating a new cluster.


Mobile: evaluate footer menu vs header menu

Check these out @jlyon @lukefretwell on mobile and tablet.  See if general approach is appealing.  The answers is just a picture as initial tinkering to get answers going was seeming problematic.
http://pattern.getproudcity.com/markup/layouts/menu-option-header.html
http://pattern.getproudcity.com/markup/layouts/menu-option-footer.html

The footer unfortunately melds with my in screen back/home buttons on my phone.  Possibly different colors could alleviate, but not sure having those 2 layers of buttons on the bottom is appealing (on some android phones at least.)

I think I kind of like it in the footer on mobile, but not on desktop. I think my back/home buttons aren't part of the screen, so there's enough of a color difference for me.
I think the logo (or at least the seal part of the logo) should be in the bar. With the logo in the header, the header/breadcrumb/page title take up more than 50% of my (pretty large) screen. Granted the logo is pretty huge and the hero font size is massive.
Talk more about this in a little bit.

Thoughts specifically for mobile:

Love the behavior and the way it feels. Really elegant.
I'd make common actions (search / report / payment) more visible/accessible (left). The simplicity with just the ?/^ seems to simple. Good to highlight the common action items at top-level.
I like the bottom one better.
I like the ^ feature for "more" and the behavior, so maybe that's the one on the far right.

Try it with

Answers
Payments
Report issue
Menu
Search

This accidentally got added to #24 instead of here.

[ ] New icons, bars for menu morphing into X
[ ] Always show bottom menu bar (in search, 311, etc)
[ ] Show text for icons on desktop
[ ] Move menu to right on desktop
[ ] Make everything consistent colors

@lukefretwell @jlyon check out updates to http://pattern.getproudcity.com/full-page/menu-option-footer.html

Still seeing older footer with that link.

Luke this is the bar, please try to ignore page content.

This looks great.
Comments:

Answers is displayed twice. Does this matter?
Do we need bottom margin on the icon button hovers?

Answers is displayed twice. Does this matter?
I think we should get rid of it in the main menu

In mobile (and maybe desktop), maybe we can get rid of the gray bg around the icons and just have the icons (maybe a little bigger)? I kinda like the cleanness of http://ironsummitmedia.github.io/startbootstrap-sb-admin-2/pages/index.html on mobile.

In mobile (and maybe desktop), maybe we can get rid of the gray bg around the
icons and just have the icons (maybe a little bigger)?

@jlyon Got rid of the default bg, can mess with the icon size, but think it looks pretty nice.

@aschmoe Yeah, I like that on mobile a lot. I think it still looks a little weird on desktop to have some with icons and others without. Maybe we can talk a little about that today.

@lukefretwell @jlyon FYI moved these navbar styles to all the "pages" so you can see current version of this on all http://pattern.getproudcity.com/?v=&page=01-page type URLs now.

I like it. Re: @jlyon comments, this doesn't bother me too much, but see his point. My gut is to just move all menu items to a hamburger.

My gut is to just move all menu items to a hamburger.
On desktop? Doesn't that break your rule about hiding menu items when you don't have to?

Sorry, was mentioning as an option if we wanted to be pure and have everything the same (icons or no). I think it's fine that some have icons and some don't.

@lukefretwell so is the only remaining issue here removing "duplicate answers" ?

I think so, yes.


Add code checks to CI

Add code checks to the CI with something like golang-ci:

Formatting checks
Static analysis checks
Unused code

Done with #28


Star Wars (Independent Publisher) fix for #1624

fix page param and use param in swagger for #1624

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.
Please note that we are experiencing a significant delay due to a high volume of connector submissions. It may take 1-2 weeks for us to provide comments for your connector.

[*] I attest that the connector works and I verified by deploying and testing all the operations.
[*] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[*] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[*] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[*] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[*] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[*] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[*] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[*] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

[[certify-connector]]


Install script for bash has DOS line endings

Basically the title. Because of that shell doesn't correctly process it and it doesn't work:
$ curl -fsSL https://raw.githubusercontent.com/nimsandu/spicetify-bloom/main/install.sh | sh

: command not found
: invalid option -
set: usage: set [--abefhkmnptuvxBCHP] [-o option] [arg ...]

$ ./install.sh
zsh: ./install.sh: bad interpreter: /bin/sh^M: no such file or directory

Side note: the script doesn't work at all on macOS, there are numerous errors with it

can you kindly give me a hand to fix that
I actually don't know about shell scripts
@teidesu please 🥲

please @teidesu 🥺

fixed in #40

@q60 thanx
Im going to close the issue
@teidesu don't hesitate to open another issue if you find another issue
Thanks everyone


[Dependency Update] Upgrade openssl to 1.1.1b

Description
Upgrade the openssl package to 1.1.1b due to the issue list at 1.0.2l
And the openssl < 1.1.0 didn't support -j (multithreading)
Also fix a bug where the lib folder is missing when we done compiling the mkldnn
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] CI check for scala publish build
[x] CI check for python publish build
[x] Ubuntu 16.04 cu100mkl build
[x] Ubuntu 16.04 mkl build

Changes
Comments

ping @lanking520 @szha for review

@mxnet-label-bot add [pr-awaiting-review]


Component stops working if component class is references in itself

Components that reference their classes in themselves stop working. For instance - the use case of providing a custom Angular Material MatFormFieldControl which references the component class in the Component decorator:
@Component({   ...   providers: [{provide: MatFormFieldControl, useExisting: MyTelInput}], }) @UntilDestroy() class MyTelInput implements MatFormFieldControl<MyTel> {   ... }
(from: https://material.angular.io/guide/creating-a-custom-form-field-control)
It will throw an exception like the following:

my-tel-input.component.ts:XX Uncaught ReferenceError: MyTelInput_1 is not defined

Removing UntilDestroy and untilDestroyed makes it work again.

Hey, could you provide a minimal reproducible example? Thanks.

I'm struggling to create an online example with it but I found out that the problem is coming due to having the compilation target set to "es5".
In my particular case I can simply move to "es2015" since I don't really need to support older browser versions, but if you still want to replicate the issue it should be easy to do it with the code generated from a regular 'ng new'.
After the 'ng new' generates the code, change the following:

app.component.ts
Add @UntilDestroy
Add   @ViewChild(AppComponent) self: AppComponent;

tsconfig.json
change target to "es5"

You can avoid creating an online example. Just create a git repo, push your app and give the link.

Here you go:
https://github.com/pedrolsamaral/until-destroy-self-ref

In your example with MatFormFieldControl first of all, you have to wrap classes in the forwardRef function (if you use useExisting): useExisting: forwardRef(() => MyTelInput). This is a normal behavior.
Regarding your example I just tested it out:
@Directive()
class JustSomeCoolDirective {}

@Component({
  selector: 'app-root',
  templateUrl: './app.component.html',
  styleUrls: ['./app.component.scss'],
  providers: [{ provide: JustSomeCoolDirective, useExisting: forwardRef(() => AppComponent) }],
})
@UntilDestroy()
export class AppComponent {
  constructor(private injector: Injector) {}

  ngOnInit() {
    console.log(this.injector.get(JustSomeCoolDirective));
  }
}

And it works.

Even though there's that work-around (when compared to the documentation example that a lot of people might be using directly) I think there might be other use cases where it won't be as easy to fix (i.e. recursive components that inject their parent)

I'm not able to test it out and see what's wrong w/o the reproduction :(

I just copied that example from stackblitz locally and it works for me, seems like you're doing something wrong:

Consider providing reproductions, please.


Updated link to Animated Clojure book

Hi, I noticed that you put a link to my animated group of playbacks in your repo. The link is to an old version. I have a much nicer user interface with the exact same material here: https://markm208.github.io/cljbook/
I think people will prefer this newer user interface.
Mark

Thanks! Sorry the later response, I've updated the link in https://github.com/Camilotk/aprenda-clojure/commit/576a80de49afcd637d49953be7aaa6fe4fe749de.


Powershell script is missing

https://github.com/Microsoft/vsts-rm-documentation/blob/master/Azure/SPNCreation.ps1 - This 404s now.
Also, can we provide instructions to create this SP via CLI, or is it only able to be created with this PS script for Azure Gov.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 11a73dad-9d92-d517-eeae-e730700b97de
Version Independent ID: 775ce7f0-6aa0-38d0-7dea-4aa23d376fdd
Content: Connect to Azure Government from Azure DevOps Service
Content Source: articles/azure-government/connect-with-azure-pipelines.md
Service: azure-government
GitHub Login: @yujhongmicrosoft
Microsoft Alias: yujhong

@mekenthompson Thanks for the feedback! We are currently investigating and will update you shortly.

The script is now linked to the doc.

I need this script ASAP!

The script is linked in this document - like I said above I corrected the link.

https://github.com/yujhongmicrosoft/spncreationn/blob/master/spncreation.ps1

closing issue #17434

triaged

@Juliako  how do I close out this issue?

@mekenthompson
We will now proceed to close this thread. If there are further questions regarding this matter, please respond here and @YutongTie-MSFT and we will gladly continue the discussion.


Adds documentation on using PPG 100Hz

Description
Adds details about

platformIO
100Hz PPG
Oscilloscope plot settings

Also adds changes to the structure of documentation.
Issues Referenced

Fixes # (issue)

Corrections completed as per review 01


chore: adjust EMR initialExecutors for large volume data

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Summary
(describe what this merge request does)

total file size: 291G, 218,345,393 events
if initialExecutors=10 the job ran 219 mins, then failed, changed to 20 the job completed within 21 minutes(tested twice).
Implementation highlights
(describe how the merge request does for feature changes, share the RFC link if it has)
Test checklist

[ ] add new test cases
[ ] all code changes are covered by unit tests
[ ] end-to-end tests

[ ] deploy web console with CloudFront + S3 + API gateway
[ ] deploy web console within VPC
[ ] deploy ingestion server

[ ] with MSK sink
[ ] with KDS sink
[ ] with S3 sink

[ ] deploy data processing
[ ] deploy data modeling

[ ] new Redshift Serverless
[ ] provisioned Redshift
[ ] Athena

[ ] deploy with reporting
[ ] streaming ingestion

[ ] with Redshift Serverless
[ ] with provisioned Redshift

Is it a breaking change

[ ] add parameters without default value in stack
[ ] introduce new service permission in stack
[ ] introduce new top level stack module

Miscellaneous

[ ] introduce new symbol link source file(s) to be shared among infra code, web console frontend, and web console backend

SonarQube Quality Gate Result

Result: :white_check_mark: OK
Triggered by @amliuyong on pull_request

Metric
Status
Value
Error Threshold

Reliability rating
:white_check_mark: OK
1
> 1

Security rating
:white_check_mark: OK
1
> 1

Sqale rating
:white_check_mark: OK
1
> 1

Coverage
:white_check_mark: OK
83.50
< 80

Duplicated lines density
:white_check_mark: OK
5.20
> 30

Blocker violations
:white_check_mark: OK
0
> 0

Bugs
:white_check_mark: OK
0
> 0

Code smells
:white_check_mark: OK
8
> 40

Critical violations
:white_check_mark: OK
0
> 0

Major violations
:white_check_mark: OK
0
> 0

Vulnerabilities
:white_check_mark: OK
0
> 0

View on SonarQube
updated: 5/15/2024, 09:25:58 (UTC+0)

SonarQube Code Analytics
Quality Gate passed

Additional information
The following metrics might not affect the Quality Gate status but improving them will improve your project code quality.
Issues
 0 Bugs
 0 Vulnerabilities
 0 Code Smells
Coverage and Duplications
No data Coverage
No data Duplication


Bump onboarding version

https://www.pivotaltracker.com/story/show/150689380

Closing for https://github.com/ello/webapp/pull/299


Move definition of

https://github.com/UMM-CSci-3601/3601-lab2_client-server/blob/d1863cac5bc4c6b57a626aad6381db0a1cd9cbbd/src/main/resources/public/javascript/users.js#L23
The definition of HttpClient() ends up being copied by most students into their todos.js file, which clearly isn't great. We should instead move it to something like a util.js file which is loaded before users.js and therefore available there and (if they load todos.js after it) in their code as well.
We should also clean up our naming there to match the Google JavaScript style guide.
Actually, our use of HttpClient() as an "object" is quite broken and should be replaced with a simple get() function. We also might want to add a second callback for the case where the HTTP request leads to some sort of error.

This is closed with PR #61


Standalone CRISPRedict

Hi!
I was interested in looking at the standalone version of CRISPRedict as described in your recent NAR paper (https://doi.org/10.1093/nar/gkac466), but it appears not to be uploaded on this repository. Where can I find it?
Best,
Harm

Hello, thank you for your interest in CRISPRedict.
You can now find the source code corresponding to the current version of the Web Server's models on this repository.
The trained models can be found in the "Saved models" folder. Notebook examples are also provided to reproduce our results and illustrate their usage.
Let me know if anything else is needed.
Vasilis


docs: versions bump

Description
Versions bump

Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...

[X] ran linting via yarn lint
[X] wrote tests where necessary
[X] included the correct type prefix in the PR title
[X] targeted the correct branch
[X] provided a link to the relevant issue or specification
[X] reviewed "Files changed" and left comments if necessary
[X] confirmed all CI checks have passed
[X] added a changeset via yarn && yarn changeset

yarn graphql:codegen

yarn ts-check:ci

yarn build:ci

yarn e2e

@rachelhox ready to merge


FaceGoodLiveLink.exe which is placed in /example/ueExample/ folder.

找不到“/example/ueExample/FaceGoodLiveLink.exe”？
cann't find "/example/ueExample/FaceGoodLiveLink.exe"?

download the file but got error "Failed to open descriptor file ../../../FaceGoodLiveLink/FaceGoodLiveLink.uproject", how to solve it?

download the file but got error "Failed to open descriptor file ../../../FaceGoodLiveLink/FaceGoodLiveLink.uproject", how to solve it?

did you download it form google drive or baidu netdisk? and we supply the zip called ueExample just a exe application not ue project. so i don't get your questions

I downloaded the zipped file ueExample from baidu netdisk.
I unzipped it in my local and got a series files and folders.
I found a FaceGoodLiveLink.exe and clicked it and got the above error.
I searched solutions from the internet and didn't help.

sorry ,i can't reappear this problem.maybe is a enviroment error. is there a ue engine in your computer.if not,you can try install one and reopen this applacation

sorry ,i can't reappear this problem.maybe is a enviroment error. is there a ue engine in your computer.if not,you can try install one and reopen this applacation

yes, I have installed a UE 5.1.0.

sorry ,i can't reappear this problem.maybe is a enviroment error. is there a ue engine in your computer.if not,you can try install one and reopen this applacation

did I download the right folders ?

yes

sorry ,i can't reappear this problem.maybe is a enviroment error. is there a ue engine in your computer.if not,you can try install one and reopen this applacation

did I download the right folders ?

yes

I will make some tries again. thank you

Could you please provide a MacOS binary or ue project? Thank you very much. @SZNero


Clean up message store cache rebuilding

A bunch of message store cache rebuilding code is now obsolete and needs to be fixed or removed.

:+1: once Travis is happy.


Remove light-api

We'll use ApiRx directly, and rely on the substrate light client for subscriptions

... for the time being :) ... hopefully it sticks.


Correct equivalent for split without a pattern

The problem
In Perl, split without a pattern is different from split "" — telling users of the former to switch to the latter changes from splitting by words to splitting by characters.
Solution provided
Suggest using words instead, which is probably the most useful Raku alternative, while also mentioning the correct explicit pattern.

split /\s+/ will not strip leading/trailing whitespace.

Ah, OK. Is there an exact equivalent pattern to Perl's behaviour?
Obviously there are several patterns which might exhibit the same behaviour in a user's specific scenario (such as there not being any leading or trailing spaces, or all the whitespace being actual space characters, or all being horizontal whitespace, or all being a single character), so I've gone for not mentioning any pattern in particular.


Alpha2

Unable to edit some macros created in Alpha 1
They work but cant be edited nothing there

Hi woodgray,
This is an expected problem.  A lot of the storage component has been heavily changed to fix existing problems with international clients and while the old macros will execute, the editor is unable to read them or export them.
TimothyLuke

On 24 Apr 2018, at 4:55 am, woodgray<EMAIL_ADDRESS>wrote:
Unable to edit some macros created in Alpha 1
They work but cant be edited nothing there
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

There is an updated alpha 3 that should resolve this


COMPRESS-390: Expose stream offsets and size

Pull request for https://issues.apache.org/jira/browse/COMPRESS-390

Coverage decreased (-0.02%) to 84.286% when pulling 2d3da5a265a42046c15311ecd23554c28c158e95 on kvr000:feature/COMPRESS-390-expose-file-offset-via-api into 0ee8f1e8ab53746ea9f735aa07e857a0c4e55656 on apache:master.

Coverage increased (+0.04%) to 84.329% when pulling 0f74248f5fcfdcc4f4b6782fbacf2ed17674faf7 on kvr000:feature/COMPRESS-390-expose-file-offset-via-api into 65184bc08140c7695ed6b39aa0e77b0dba61be92 on apache:master.


Composer/documentation build fails in Windows

Description:
composer build throws a "fs-readdir-recursive" module not found  error in windows while building documentation

Closing as this issue is outdated.


Support lookbackdelta

Signed-off-by: Ben Ye<EMAIL_ADDRESS>I am not sure if this covers the lookback delta usecase, but currently most of the lookbackdelta is hardcoded to 5m. This pr removes the hardcoded part and use the engine option's lookback delta value.

If you want to test for correctness, you can maybe try leaving the value hardcoded to 5m, and see if the new tests pass or fail. If they still pass, we might need to extend test coverage for staleness.

Correctness wise, I think this works. But when I change the lookbackDelta value to 30s, then I got panic on https://github.com/thanos-community/promql-engine/blob/main/engine/instant_query.go#L92. We need to handle empty vector I think.

Can you try adding this when creating the matrix selector, right before instantiating the filter:
lookbackDelta = maxDuration(lookbackDelta, t.Range)

Also somewhere you can define
func maxDuration(a, b time.Duration) time.Duration {
	if a.Milliseconds() >= b.Milliseconds() {
		return a
	}
	return b
}

@fpetkovski This works. Thanks!


Azure AD v2 Auth with Git

Description
When enabling azure ad OAUTH2, the user will be allowed to authenticate against the azure ad and login to the web ui. However when submitting code via git cli like using "git clone [URL]" the user will never be able to authenticate since the user is always prompted for username & password which seem to be authenticated against the gitea internal user directory but not the SSO. I would expect to be prompted with the azure ad authentication dialog which credentials are then used to authenticate against gitea.
Gitea Version
1.16.6
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
git version 2.36.1.windows.1
Operating System
No response
How are you running Gitea?
we are running gitea inside docker
Database
PostgreSQL

That is not technically possible as git client supports only username/password authentication flow. If Azure AD supports LDAP protocol that could theoretically be configured in gitea under authentication sources

@lafriks
There are more similar issues:

https://github.com/go-gitea/gitea/issues/19336
https://github.com/go-gitea/gitea/issues/17350

@wxiaoguang these are different issues, git client does not support oauth2 authorization workflow

Oh yeah, not exactly the same.
I was thinking about the problem that Gitaa's git auth only use internal database. This one has another problem that git client doesn't support OAuth2.


work record/page

I should be able to go to a page in which the subject is a work, and the page tells me stuff about the work, such as the use data/observations/"reviews" currently being gathered.

In the linked example there are now multiple records: one for the web page, one for the work on the webpage, which links to a separate record for the original.
It might benefit from a more side-by-side comparison of the data.


Merge codegen and npm-js

This is already on top of #52 .
The publishing and re-use of the local codegen is still missing, but all the rest is already fine (sbt test are already in Circle as well)

@pvlugter :

opened #58 with strictly only the merge of folders
I followed those instructions: https://github.com/lightbend/akkaserverless-javascript-sdk/issues/30#issuecomment-866133909 if you prefer something to be done differently please go ahead directly with a PR and I will decline the rest
Not much I can do about those commits other than asking @RoryStokes if he can make sure that all the emails he is committing from are connected to his GH account.
I'll follow up stacking the rest of the needed changes as soon as we start to merge something

@andreaTP, I've created a draft of just the npm-js commits in #61, looking to create a cleaner history:

renamed paths in history to be under npm-js and added npm-js prefix to all commits
rebased to remove all the merge commits and have just one linear history
rewrote Rory's disconnected email address

Similarly created a cleaner history for codegen in #62.

Included in #63


Reconsider reproducible serialization

There were attempts to make Jandex reproducible before:

https://github.com/wildfly/jandex/issues/71
https://github.com/wildfly/jandex-maven-plugin/pull/35

So far, this has been dismissed, but we may want to reconsider. One reason would be to allow incremental builds. If a Maven module carries a Jandex index, rebuilding always changes the JAR, even though the classes perhaps didn't change at all -- the only thing that changed was the index. (Immediate question: would it be possible to avoid rebuilding the index if the classes weren't rebuilt?)
This is not a 3.0 topic, but may be a 3.x topic. This issue is mainly for collecting feedback.

Note to self: this might be more complex than it seems, because Jandex sometimes depends on serializing things in a topological order.

I realized we could easily use hash trees to avoid rebuilding an index if the underlying classes didn't change.
During indexing, we'd compute a hash of each input file (a cryptographically insecure checksum such as CRC32 should be enough) and remember it (ordered map<fully qualified class name, hash>). When the index is being completed, we'd compute a hash of the remembered hashes (in the key order, for reproducibility) and store the resulting hash to the index.
During subsequent indexing, we'd probably just do everything like the usual, but at the very end, we'd compare the currently computed hash with the hash stored in an existing index file. If they are the same, we'd skip writing the index.


[Bug] Engine space should be ignore the version change

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug
We use ${serverSpace}_${KYUUBI_VERSION}_${shareLevel}_${engineType} as the parent path of the engine space, but during hot upgrade kyuubi cluster with different version, we will have two version of engine space. As a result, a user share level engine can be created again since there are two engine space at that monent.
Client A -> Kyuubi Instance 1.5.0 -> engine A
Client A -> Kyuubi Instance 1.5.1 -> engine B

Affects Version(s)
master/1.5
Kyuubi Server Log Output
No response
Kyuubi Engine Log Output
No response
Kyuubi Server Configurations
No response
Kyuubi Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

I plan to change KYUUBI_VERSION to a static version number e.g. 1. But it affects the exists kyuubi ctl. what do you think @yaooqinn @pan3793

versions are used to prevent breaking change，but for patch release，it seems overkilling

yeah, one option is we use a internal version for it like the protocol version of thrift. It is not coupled with kyuubi version, but we can change it once kyuubi version has breaking change.

We can probably handle this issue at client side. e.g. At jdbc client, we always choose a bigger version kyuubi server to connect.

Yes, replace KYUUBI_VERSION by something like PROTOCOL_VERSION is more reasonable to me, and we should only bump PROTOCOL_VERSION when breaking change happens

+1
Using a custom protol version looks fine.
Upgrading from 1.4 to 1.5 today, I had to restart N engines.
Similar to manually killing the old ones, because the idle time is set relatively high.


BUG: Remove redundant arg _key

What do these changes do?

Remove redundant arg _key in _mars.core.base
Related issue number

Fixes #443
Check code requirements

[x] tests added / passed (if needed)
[x] Ensure all linting tests pass

Add a test to check the copied one is same as original.

A fix has been done in #709 so this one closed


Fix issues found by go vet

This change is

Great work, thanks @jell!

Reviewed 18 of 18 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Made a typo in Reviewable comment and can't fix it ;( But ok

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Remove SASI index on dependency column family

While most SASI indexes were removed as part of #80, the one in the dependencies column family still exists, leading to problems when using older versions of cassandra that don't support SASI indexes, or using alternate storage like ScyllaDB .
We can update the dependency schema to not have SASI indexes, and provide a migration script from the old schema to the new schema.
We should also ensure that https://github.com/jaegertracing/spark-dependencies works with the new schema.

I suggest adding a "source" column to the schema, potentially to represent data coming from different sources

I like this idea, but I don't think it should be part of the migration,  I created https://github.com/jaegertracing/jaeger/issues/791 to capture this.

I am not suggesting we implement all of the relevant business logic, but if we are already making a breaking schema change, why not include an extra field?

but if we are already making a breaking schema change, why not include an extra field?

Because it's unrelated to this change, and is unusable without the business logic. Why shouldn't the change be done along with the business logic?

I'm thinking that changing the data model to include a date bucket while making the time stamp as a clustering key would enable us to maintain the current query patterns while removing the SASI index.
The schema looks something like this:
https://github.com/jaegertracing/jaeger/blob/d52969b253ec0d8c3d750071c7ccdc5525de3e3a/plugin/storage/cassandra/schema/v001.cql.tmpl#L191-L196
While the write path is largely unaffected, reads become a bit more involved, as we need to compute buckets that we want to retrieve dependencies from.
We also need to update the spark dependencies job.
The migration path seems to be the following:

Stop dependencies job
Use the Cassandra COPY command to export to a CSV file (which works for tables with less than 2 million rows)
Delete existing dependencies column family
Create dependencies column family with new schema
Massage the CSV file into the new format and load into new schema
Run new version of dependencies job which writes to new schema

@yurishkuro @black-adder @jpkrohling @pavolloffay wdyt?


webpack: fixing use of istanbul plugin only for test builds

Ref. #186

Codecov Report

Merging #187 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #187   +/-   ##
=======================================
  Coverage   69.46%   69.46%
=======================================
  Files           2        2
  Lines         131      131
  Branches       29       29
=======================================
  Hits           91       91
  Misses         40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3684e41...8e6daab. Read the comment docs.

LGTM


Fix welcome view links missing hover color

This PR fixes #121521

What theme are you using? In the default theme I do not see color-based hover feedback in any links in the workbench. If there's an existing color token themes can set to support link color we should be using that.
Could you open an to better track what the problem is here before jumping into a PR?

Thanks! 🍻 Ended up cleaning up quite a bit how we style links.


test: fix docker test for lvm

The CI is still running ceph-disk tests upstream. So until
https://github.com/ceph/ceph-ansible/pull/3187 is merged nothing will
pass anymore.
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

jenkins test pipeline

jenkins test pipeline

jenkins test pipeline

jenkins test pipeline


useQueries doesn't work with 'keepPreviousData' properly

Describe the bug
  const [count, setCount] = useState(0);
  const result = useQueries(
    [1, 2].map((item) => {
      return {
        queryKey: [item, count],
        queryFn: queryFn,
        keepPreviousData: true
      };
    })
  );

The result[x].data should be "previousData" when queryKey change, but it is undefined.
To Reproduce
Steps to reproduce the behavior:

Go to https://codesandbox.io/s/usequeries-with-keeppreviousdata-c9cim?file=/src/index.js:559-781
Click '++count'
See result[x].data

Expected behavior
result[x].data should always be {} when query key changed
Screenshots

Desktop (please complete the following information):

OS: Mac
Browser: chrome
Version: v90

"useInfiniteQuery" seems to work better

Ran into the same issue. The staleTime config is set to 0 by default. Haven't had the time yet to look through this code, but changing it to Infinity (for example) resolved the issue for me.

so I did take a bit of a look. It seems that we are trying to "match" observers by queryKey:
https://github.com/tannerlinsley/react-query/blob/8a613165fc7dbc5213f61ad75f29ba54d248a0df/src/core/queriesObserver.ts#L77-L80
which doesn't work if the key changes, so we create a new observer. A new observer doesn't know anything about the previous result it could possibly "keep", so you'll get a hard loading instead. Tricky situation.

we could document that keepPreviousData doesn't work for useQueries and remove the options in TypeScript types as well.
we could also try and match by index if we don't find an observer and want to keep previous data. This would probably fix your example, because your length is always the same. But if if's dynamic, we might still not find it and get a new observer instead....

So I took a stab and made a PR. Your codesandbox example works with the fix, have a look here: https://codesandbox.io/s/usequeries-with-keeppreviousdata-v92oh

Could this also cause a problem with useQuery if an observer is mounted after a key changes?
I have a problem where I'm using keepPreviousData: true, enabled: false with useQuery.

Could this also cause a problem with useQuery if an observer is mounted after a key changes?
I have a problem where I'm using keepPreviousData: true, enabled: false with useQuery.

if there is something not working, it's likely a separate issue. keepPreviousData for useQueries was just not implemented. If you have something, please open a separate issue with a codesandbox reproduction

Hi @TkDodo!
I have the same scenario from @TIS-OMiddle and your fix works perfectly for my project (congrats!).
How we can help to this PR be merged?

I’m on vacation now an will take another look at everything once I’m back.
Maybe you can try out keepPreviousData with alternating lengths of useQueries (e.g. 2 vs 3 elements) on the PR. I don’t think it would work and there is an alternate suggestion on the PR for that case. Not sure what the desired outcome should be here so input would be appreciated.

Based on your test, I created a new test with 3 elements on useQueries and works fine. I admit that I don't know all things about the project, but I believe that is correct.

Do you want that I commit directly to your PR?

sure, if that works permission-wise 😅. Otherwise, feel free to add as a comment / suggestion and I'll add it.

:tada: This issue has been resolved in version 3.19.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


KeyError for model

I am getting an error when I run demo.py. I am using resnet pretrained model caffe file for VOC
command is
python demo.py --cfg cfgs/res101.yml --net res101 --cuda
Error is
fasterRCNN.load_state_dict(checkpoint['model'])
KeyError: 'model'
Any help would be really appreciated.

Hi, @zeehasham , you should add the checkpoint by adding:
--checksession $SESSION --checkepoch $EPOCH --checkpoint $CHECKPOINT \
check the readme for details


How to add arithmetic mean and variance constraint?

The variance and arithmetic mean of affine function are both convex. There is no such API support for there two constraints. Is it possible to add variance and arithmetic mean in the constraint?

import cvxpy as cp

def mean(x):
    return cp.sum(x) / x.size

def variance(x, mode='unbiased'):
    if mode == 'unbiased':
        scale = x.size - 1
    elif mode == 'mle':
        scale = x.size
    else:
        raise ValueError('unknown mode: ' + str(mode))
    return cp.sum_squares(x - mean(x)) / scale

If someone wants to make a PR for these functions, I'd be happy to review it. Right now those functions only work on individual vectors. A proper implementation will handle axis options, and do more careful parsing of the mode string in the variance function (e.g. convert to lowercase).


feat: [DP-2355] Add clerkgen.sh

What this PR does / why we need it:
This PR add clerkgen.sh. This will run from bootstrap as part of gogenerate. Command will look like this:
//go:generate ../scripts/shell-wrapper.sh clerkgenproto.sh --sn outreach.application.twilio_recording_del_req --sn outreach.tutorial.tutorial_event --od . -l go

In the above command, the schema names will be replaced as per the user's configuration.

JIRA ID: DP-2355

Testing:

chmod +x clerkgenproto.sh <- Hoping this happens automagically when an user runs bootstrap
./clerkgenproto.sh --sn outreach.application.twilio_recording_del_req --sn outreach.tutorial.tutorial_event --od . -l go

Generated all types as expected. Output:
INFO[0000] Starting clerkgen for protobuf
Generating proto clients
Generating go clients
go: finding module for package github.com/getoutreach/clerk/v2/pkg/clerk
go: finding module for package github.com/getoutreach/clerk/v2/pkg/clerk/models
go: finding module for package github.com/getoutreach/clerk/v2/pkg/clerk/models/schema/proto/outreach/system
go: found github.com/getoutreach/clerk/v2/pkg/clerk/models in github.com/getoutreach/clerk/v2 v2.0.0-20210929212026-b669b22b72cb
go: found github.com/getoutreach/clerk/v2/pkg/clerk in github.com/getoutreach/clerk/v2 v2.0.0-20210929212026-b669b22b72cb
go: found github.com/getoutreach/clerk/v2/pkg/clerk/models/schema/proto/outreach/system in github.com/getoutreach/clerk/v2 v2.0.0-20210929212026-b669b22b72cb
INFO[0008] Finished clerkgen for protobuf

@jaredallard Have addressed all the suggestions. Thanks for them.

:tada: This PR is included in version 1.27.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Enhance an ABAP Core Data Services (CDS) View in SAP NetWeaver 7.5

Tutorial URL: https://developers.sap.com/tutorials/abap-dev-enhance-cds-view.html
I think these are practical code examples for how some of the (probably) most used CDS features look like when actually put into the source code.
These examples seem very well produced; which is of course a good thing.
My 2cts would be:

currency conversion is often a lot more complicated than shown in this example. While I understand that this is not the primary topic of the tutorial I don't think that it would hurt to not oversimplify this bit. In fact, I believe that many users/developers would love to see an example that shows, e.g. to include a currency conversion reference date dependent on the transaction data it should work on (i.e. use the reference date that is valid for the transaction date).

the case statement in the example (USD transactions have a mapping to "Premium" levels) demonstrates how to not implement business logic like "customer tiering". This is exactly the kind of knowledge one shouldn't bury in a presentation view definition. Instead, this is the kind of mapping that needs to be consistent across the organisation. Therefore it would be better to create a specific view/function for this.

Again, I get that this is done here for show-casing the use of a CASE statement, but it shows an unfortunate example for it.

Hi Lars,
Thanks a lot for the positive feedback - makes a difference.
Re: Point 2 - Valid point. I can remove it. BUT Do you have ANY ideas on a good example to show-case the CASE statement functionality - I really want to conform to best practice here. Would really appreciate your real-world input here.
Will look into Point 1 as soon as feasible.
Best wishes,
Julie.

Ok, so what would be a "good" example for using a CASE expression?
I mentioned a reason for not using it, namely that business-domain level logic needs to be consistent across the system (ideally across the organisation, but well...). Implementing such logic directly in a CASE statement would likely mean that it will have to be implemented in many places individually. That's obviously not a great situation.
For HANA SQL: Another "non"-use-case is "simple equal mappings". Something in the shape of IF x = 1 THEN ... ELSEIF x = 2 ... ELSE y is very easily doable with a CASE expression, but for this specific case with only equality comparisons, there exists a more concise expression: MAP.
ABAP CDS does not have the MAP expression, so the "simple equal mappings" use case could be used for ABAP examples. However, it would require an explanation about when and why this is preferable over e.g. a lookup table.
So, finally, when would I go for a CASE expression? Whenever the logic involved RANGE conditions and does not implement a core piece of domain logic.
Common examples are data "scrubbing" and output formatting where present data is normalized and formatted to whatever way the consuming processes require it.
A simple example could be this (I just checked my bank statement online):

a table contains transactions, with date, description, and amount.
for debits (money leaves the account) the amount will be a negative number
for credits (money enters the account) the amount will be a positive number
for some transaction lines, there is no amount as these are "commentary" or "information" lines

Now, the view should not only reflect the data in the table but also include a new column that explicitly states what "kind" any given line is (DEBIT, CREDIT, INFO).
That's easy to achieve with the CASE expression:
CASE
    WHEN Amount > 0 THEN 'CREDIT'
    WHEN Amount < 0 THEN 'DEBIT'
    ELSE 'INFO'
END as 'Transaction type'

@julieplummer20 Can you provide update?

I have discussed this with my manager. We have thought up an alternative CASE statement, which I will test myself, and then, if appropriate propose to Lars after my vacation.
BR Julie.

Hi Lars,
We've come up with a CASE statement that highlights the booking status on screen for the booking clerk at the travel agency:
//Highlight early bookings on screen
case
when _Booking.BookingDate < '20210131' then 'Early Bird'
else ' '
end                                                       as EarlyBird,
How do you find that?
BR Julie.

Hi Julie,
thanks a lot for coming back to this.
For something like an "early bird" indicator column, I believe the logic needs to be flexible and not hard-coded (just like the in the currency conversion example). In my experience, "early bird" promotions/statuses are rarely fixed to a single date across the whole range of products and services.
And this would not work with the current CASE statement approach.
If there was a PROMOTIONS table that contains dates for when the promotion is valid and what the cut-off date for each promotion is for bookers to be considered "early bird" then the CASE statement could look like this (and make sense for the application):
case
when _Booking.BookingDate BETWEEN _Promotion.BeginDate AND _Promotion.EndDate
          AND _Booking.BookingDate <= _Promotion.EarlyBirdEndDate
          then 'Early Bird'
else ' '
end as EarlyBird

Actually, I'm not sure if ABAP CDS supports the BETWEEN condition. So I checked the documentation (https://help.sap.com/doc/abapdocu_cp_index_htm/CLOUD/en-US/index.htm) and found that it seems to be supported.
While googling I stumbled over the old documentation (https://help.sap.com/doc/abapdocu_750_index_htm/7.50/en-US/index.htm?file=abenddic_cds_views.htm) that comes with an actually sensible example:
@AbapCatalog.sqlViewName: 'DEMO_CDS_SCASE'
@AccessControl.authorizationCheck: #NOT_REQUIRED
define view demo_cds_searched_case as
  select from spfli
    { key carrid,
      key connid,
      distance,
      distid,
      case
        when distance >= 2000 then 'long-haul flight'
        when distance >= 1000 and
             distance <  2000 then 'medium-haul flight'
        when distance <  1000 then 'short-haul flight'
                              else 'error'
      end as flight_type }
    where distid = 'MI'

I would assume that those groupings are rather stable over time and across organisations. In fact, I'd guess that the travel industry as a whole would probably have a common understanding of what short-/medium-/long-haul flights are.
This is quite different from the ever-changing/adapting marketing ideas of loyalty levels and promotions.
So, for this, I'd probably go for the CASE statement, even though I find the "Early Bird" example more interesting for a tutorial.

"So, for this, I'd probably go for the CASE statement, even though I find the "Early Bird" example more interesting for a tutorial."
Yes, you’re right regarding the stability of flight distance. This is a really nice example.
However, in this tutorial, I have not included an association to Booking (and thence to Connection).
I am looking at the idea of including an Object Page for Booking(s) per Travel. If so, I could then implement the CASE statement as you suggest. (I am also thinking about including other info, e.g. by pop-up.)
I also want to include parameters but am considering how best to implement this.
Right now, that has to be Priority 2, tbh.
In the meantime, I could implement the “Early Bird” approach, but make clear that the hardcoded date is for tutorial purposes only – in real life, the value would be contained in a table.
So I would suggest that I implement the Early Bird for now, but remove it, if / when I implement the Object Page.
Would this be ok?
BR Julie.

Ok, what I'm reading is that this has no importance and that the example won't be changed.
My goal was to have the example code improved in a way that it shows how functions are reasonably be used in "real-life" code and your conclusion of this discussion is to still include the how-not-to-do-it-example but tell readers that this is not how to do it.
I guess we all know that this does not work.
But hey, it's your decision after all.
From my end, I have put in way more time and effort into this improvement proposal than it was worth.
Based on this experience I don't see the point in providing free, constructive feedback to SAP.

" this has no importance and that the example won't be changed."
Sorry, no. That's not what I meant at all.
For clarity, my conclusion is: The distance example is much better. However, it fits (imo) better in an Object Page. This is not an insuperable hurdle, but, it will take longer to describe than simply swapping one CASE statement for another.
In the meantime, I will remove the bad CASE statement.
I need to complete a different mission. Once that's done, I will do this.
I appreciate that you put a lot of work into this. I just don't want to pretend that I am going to drop everything right now, when I can't. That was my meaning with Prio 2, not "I'm not doing it."
Anyway, even if you are dissatisfied with the conclusion, I have benefited a lot from your feedback, so I would still like to thank you.
BR Julie.

" this has no importance and that the example won't be changed."
No. That's not what I meant at all.
For clarity, my conclusion is: The distance example is much better. However, it fits (imo) better in an Object Page. This is not an insuperable hurdle, but, it will take longer to describe than simply swapping one CASE statement for another.
I need to complete a different mission. Once that's done, I will do this.
In the meantime, I will remove the bad CASE statement.
I appreciate that you put a lot of work into this. I just don't want to pretend that I am going to drop everything right now, when I can't. That was my meaning with Prio 2, not "I'm not doing it."
Anyway, I am sorry you are dissatisfied with the conclusion, but I have benefited a lot from your feedback, so I would still like to thank you.
BR Julie.

I'm here to find out what will/has happened to this:
CASE
WHEN Amount > 0 THEN 'CREDIT'
WHEN Amount < 0 THEN 'DEBIT'
ELSE 'INFO'
END as 'Transaction type'
and I have no further comments.
Thank you,
gm

Hi gm,
"CASE
WHEN Amount > 0 THEN 'CREDIT'
WHEN Amount < 0 THEN 'DEBIT'
ELSE 'INFO'
END as 'Transaction type'"
... was an example of output formatting. It was never intended to be used in the current tutorial, which is based on a travel agency. I will be implementing a new CASE statement in the tutorial asap.
BR Julie.

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.

Hi Lars, hi everyone,
I apologise for the delay.
I have now added a CASE statement to the tutorial in the following tutorial: https://developers.sap.com/tutorials/abap-environment-enhance-cds-view.html - ie for SAP Cloud Platform, ABAP Environment.
As soon as I can test this on an on-Premise system, I will add it to this tutorial as well. At present, I cannot access the system.
However, there should be no difference, provided you use an S/4HANA 1909 system.
Best wishes,
Julie.

Hi Julie,
thanks for your continued work on this bit.
I appreciate your work and the constraints and priorities that apply to it. I certainly did not mean to imply that you personally didn't take this "serious enough" or didn't work with your best intentions and efforts on it. On the contrary!
The ongoing and growing need for good tutorials and documentation that show how to best use the technology makes the work of authors like yourself even more important; which is why I am passionate about good knowledge-sharing, too.
The long and short of it is: thanks again for your work.
Cheers,
Lars

Hi Lars,
No problem.
Your commitment to sharing the knowledge inside the SAP Community is well-known and exemplary.
I am just about to watch your SOT on “If your SQL looks like Assembler…”.
However, I am well aware that I have a lot to learn about ABAP, especially in the real world, so I hope, the next time your find something that could be better, you won’t hesitate to let me know.
Thanks for all this – it really helps us all.
Best wishes,
Julie.


Add stackdriver gem

Created the stackdriver umbrella gem that includes all the Stackdriver gem and automatically enables their instrumentation functionalities.
Since there's an existing stackdriver gem, we're also providing backward compatibility for one release.
I've also added as much of the jsondoc functionalities by referencing existing google-cloud gem. But I didn't find a way to actually preview the generated jsondocs without pushing it to Github. Please let me know if there's anything else I'm missing on the docs stuff.

@blowmage Hey Mike, I just submitted this PR, and the Appveyor CI immediately failed without even starting the build. There's no details either. Do you know why?
I noticed the AppVeyor project was completely clogged with releasing builds. Is that the cause?

@dazuma Stackdriver gem PR created. Please review.

@hxiong388 it says:

AppVeyor was unable to build non-mergeable pull request

Not sure why though.

@blowmage Not sure why it broke yesterday, but things seem to be working again today.

Yeah, some builds took 24+ hours to complete, but they seem to have recovered now.

@quartzmo I have fixed all of Daniel's codecheck comments. This PR should be ready for merge.

@hxiong388 Thanks! I was just finishing reading through this and was about to ask if it is ready to merge.
Regarding previewing the JSON docs, you will need to clone gcloud-common and run the Angular site application locally with the new JSON files that you generate locally with rake jsondoc.
Please see:
https://github.com/GoogleCloudPlatform/gcloud-common/tree/master/site#installation
https://github.com/GoogleCloudPlatform/gcloud-common/tree/master/site#previewing-locally
If you have any trouble with it, I am happy to help.

@quartzmo Thanks, I followed the instructions and now I'm able to preview the jsondoc changes.
There are couple things not setup properly on the jsondocs. I will fix them in this PR shortly.

I checked out this branch locally and ran various rake tasks including rake jsondoc and rake acceptance. Everything appears to work OK. I got some acceptance test failures, but none related to this PR. I also anticipate some work will be needed for the jsondoc:umbrella task, but I think it will be best handled in a follow-up PR.

@quartzmo After I'm able to host the generated JSON docs locally, I realized what I did wrong in the jsondoc:umbrella task.
Basically I was trying to copy the code that generates google-cloud docs to create skeleton docs for stackdriver umbrella gem. Then we can fill in more details once we figure out how to document stackdriver vs google-cloud. But I missed couple things and the stackdriver doc doesn't seem to be working. I can fix this in a separate PR like you said.
Thanks

@hxiong388 SGTM, I am going to merge this PR now. The build will most likely fail due to unrelated issues (such as this one in google-cloud-language.


Document server.shutdown.drain_wait setting

Fixes #2791

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/ed8d5c70c4d6347099f113d9dbdd030ca08a9628/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/5061bc50290ae1b1accb9ae300eded1709190fce/

TFTR, @a-robinson!


SAK-40800 add acceptance tests project

This has been sitting in a branch for a while and there are people that want to work on it. This has no functional impact on Sakai but I would like to have this in master so that it is easier for people to contribute to.

This is likely to need some updates (still on 19-SNAPSHOT) but I'm happy to do that so let me what what you pickup.

Stave does it not make sense to create a separate repo? One benefit would be that QA can have write access to manage the test scripts? I will add this as a discussion item to an upcoming core call.

Discussed on the core call and everyone was in agreement about moving this into its own repo that is managed by QA. Thoughts Steve?

Maybe create it as a separate repo and add it into sakai as a submodule. Then others can contribute but it will still appear in the main repo.
The only negative would be that someone would have to clone with --recurse-submodules or submodule init

I don't like it as a separate repo and haven't ever seen it setup this way. The core idea is that developers write feature files as they write features. If you move it to a separate repo then developers will never contribute and it will be left to QA to handle entirely, and it will get out of sync again.
This way the code and features get versioned together and it is simpler to create a PR that adds feature to project X and a corresponding feature file.
Plenty of discussion about this on the net where other devs express their POV. The main takeaway from all of that is keeping it simple and adding complexity later if required.
So IMO this should stay in the main repo until the need arises that it moves. QA would still be sending PRs either way right?

Well I'd be up for seeing how it goes. It's pretty self contained so easy to change if that was the issue. I'd like to see this hooked up to Travis so that developers actually run and notice that something is going wrong. Maybe based on these instructions? This could be in a new issue. https://docs.travis-ci.com/user/gui-and-headless-browsers/

We don't really have any process developed with QA around automated testing - it's all in flux at the moment. We've discussed this on the core call few times now and it's been unanimous that we put this into a repo other then core, then bring it in when the process has matured a bit.

I understand everything you have linked and are saying.
Here is what I am suggesting before this goes into master:

we need the appropriate infrastructure setup
QA needs to understand how to use this
workflows in JIRA and such need to be established and followed (by Devs and QA)
we all need some experience with XBDD

Your arguments suggest that were disagreeing with you, when this is not the case. Simply we want to see this all in action before adding it to master is all.
So setting this up in a separate repo and getting all the pieces lined up and working and once everyone has a little more experience with how this all works then we consider moving it to the sakai repo.
It just doesn't make any sense putting this into master with no support or process around it.

Closing this per Steve


[Improvement][K8S_Task] Set the timeout for k8s tasks

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Description
add .spec.activeDeadlineSeconds

https://kubernetes.io/docs/concepts/workloads/controllers/job/

Are you willing to submit a PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

hi @Gallardot @Radeity The current task timeout is done using the countdownlatch timeout. Is it necessary to add this parameter to replace the above implementation?


App Sync: APPSYNC_JS resolver requires optional request_template (incorrect behavior)

What happened?
Since v5.24.0 APPSYNC_JS resolvers should be creatable. However, when you use the runtime: APPSYNC_JS with the code  and runtime attribute for a aws.appsync.Resolver (seems the doc was forgotten to be updated) you still get an error that you must fill in the requestTemplate parameter (which is used for the VTL language and not APPSYNC_JS).
Therefore, I'm not able to create a APPSYNC_JS resolver :(
Related resolved issue from the terraform aws provider: https://github.com/hashicorp/terraform-provider-aws/issues/28057
Stated as change in the v4.47.0 terraform-provider-aws enhancements:
resource/aws_appsync_function: Make request_mapping_template and response_mapping_template Optional (https://github.com/hashicorp/terraform-provider-aws/issues/28057)

I hope this issue could be resolved soon, so we can automate our APPSYNC_JS resolvers.
Steps to reproduce
import * as aws from "@pulumi/aws";
import fs from "fs";

importFilesAsString(path, resolve, reject) {
  fs.readFile(path, (err, buff) => {
    // if any error
    if (err) {
      reject(err);
      return;
    }
    resolve(buff.toString());
  });
}

const schema = new Promise(importFilesAsString.bind(null, "./appsync/schema.ql"));
const functionCode = new Promise(importFilesAsString.bind(null, "./appsync/function.js"));
const resolverCode = new Promise(importFilesAsString.bind(null, "./appsync/resolver.js"));

// Create API accessible with a key
const api = new aws.appsync.GraphQLApi("graphql-api", {
  authenticationType: "API_KEY",
  schema,
});

const noneDataSource = new aws.appsync.DataSource(`no-ds`, {
  name: "no_data_source",
  apiId: api.id,
  type: "NONE",
});

const function1= new aws.appsync.Function(`function-1`, {
  apiId: api.id,
  dataSource: noneDataSource.name,
  name: "Function1",
  code: functionCode,
  runtime: {
    name: "APPSYNC_JS",
    runtimeVersion: "1.0.0",
  },
});

// This should work as the requestTemplate must be optional, but instead is still required.
const resolverSubmitDeclaration = new aws.appsync.Resolver(`resolver-1`, {
  apiId: api.id,
  kind: "PIPELINE",
  type: "Mutation",
  field: "submit",
  pipelineConfig: {
    functions: [
      function1.functionId,
    ]
  },
  code: resolverCode, // <-- with the current aws package version the `code` and `runtime` attribute should be sufficient to make `requestTemplate` optional.
  runtime: {
    name: "APPSYNC_JS",
    runtimeVersion: "1.0.0",
  },
});

Expected Behavior
As documented:
Request mapping template for UNIT resolver or 'before mapping template' for PIPELINE resolver. Required for **non**-Lambda resolvers.

Being able to create an APPSYNC_JS resolver with the code and runtime attributes, without the requestTemplate and responseTemplate attributes.
Actual Behavior
aws:appsync:Resolver (resolver-1):
    error: 1 error occurred:
        * error creating AppSync Resolver: BadRequestException: Request mapping template not specified.
    {
      RespMetadata: {
        StatusCode: 400,
        RequestID: "2e2b914f-3930-4128-8c26-30ea414d2a27"
      },
      Message_: "Request mapping template not specified."
    }

Output of pulumi about
Dependencies:
NAME                VERSION
@pulumi/aws         5.24.0
@pulumi/pulumi      3.49.0

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Based on this comment this issue is related to changes within the terraform-provider-aws package and will be fixed with their new MR.


Error: Module not found: Error: Can't resolve 'fs'

Bug Report or Feature Request (mark with an x)
- [ x ] bug report -> please search issues before submitting
- [ ] feature request

Versions.
Angular CLI: 1.5.0-rc.6
Node: 6.11.0
OS: darwin x64
Angular: 5.0.0-rc.9
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, platform-server, router
@angular/cli: 1.5.0-rc.6
@angular-devkit/build-optimizer: 0.0.31
@angular-devkit/core: 0.0.20
@angular-devkit/schematics: 0.0.34
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.8.0-rc.6
@schematics/angular: 0.0.49
typescript: 2.6.1
webpack: 3.8.1
Repro steps.
Put some node module inside one file
ng test --code-coverage --watch=false
The log given by the failure.
Error: Module not found: Error: Can't resolve 'fs' in '/Users/luca/src/app/core/service/config'
Desired functionality.
Prior to update the new version of angular cli and angular 5 the error didn't happen.
When I build or serve, no errors.
Fix this functionality before release the final version.

yes, i have the same issue when i run ng test because i have jsonpath package and it use require('fs')

Same here

@deebloo sure!
This is the code:
import { Inject, Injectable, PLATFORM_ID } from '@angular/core';
import { isPlatformBrowser } from '@angular/common';
import { readFile } from 'fs';
import { join } from 'path';
import { IEnvConfig } from './env.config';
import { RestApiClient } from '../rest-api-client/rest-api-client';

@Injectable()
export class ConfigService {

  private envConfig: IEnvConfig;

  constructor(@Inject(PLATFORM_ID) private platformId: Object, private restApiClient: RestApiClient) {
  }

  load() {
    if (isPlatformBrowser(this.platformId)) {
      return this.loadUsingHttpClient();
    } else {
      return this.loadFromFileSystem();
    }
  }

  private loadUsingHttpClient()  {
    return new Promise((resolve, reject) => {
      const DIVISOR = 1000;
      const cacheBuster = Math.round(new Date().getTime() / DIVISOR);

      this.restApiClient.get(`app/config/env.json?v=${cacheBuster}`)
        .catch(error => {
          reject(`Error loading env.json file: ${JSON.stringify(error)}`);
          return 'Server error';
        })
        .subscribe(envConfig => {
          this.envConfig = envConfig as IEnvConfig;
          resolve();
        });
    });
  }

  private loadFromFileSystem() {
    return new Promise((resolve) => {
      const DIST_FOLDER = join(process.cwd(), 'dist');
      readFile(`${DIST_FOLDER}/browser/app/config/env.json`, 'utf8', (err, data) => {
        if (err) {
          return this.handleError(err);
        }
        this.envConfig = JSON.parse(data);
        resolve();
      });
    }).catch(this.handleError);
  }

  private handleError(err) {
    console.log(`Error loading env.json file: ${JSON.stringify(err)}`);
    return 'Server error';
  }

  get (): IEnvConfig {
    return this.envConfig;
  }
}

Before upgrading to the new cli / angular 5, it was working fine.

Angular apps such as the ones Angular CLI creates are browser apps. fs isn't available on the browser, it's only available on node apps.
Even if it worked before this was never a supported feature. I'm sorry but this is working as intended :/

@filipesilva thanks for the feedback, but Angular application are supposed to work in a "universal" context, so using different strategy between client and server is reasonable.
Also webpack support the ability to override the node modules when the target is the browser.
In my opinion this problem is related to the cli because it provide the webpack configuration, but we cannot override it without eject entirely.
I'm asking you to consider to support again this feature.

I fully agree with @Lughino

Closing this issue doesn't make any sense; why it's angular "Universal" if it's suppose to run on browsers only .. @filipesilva
what's the point of having isPlatformBrowser() if there is nothing else needs to be supported

The app in this issue didn't seem to be a universal app. We have some support for universal apps but it requires custom setup as shown in https://github.com/angular/angular-cli/wiki/stories-universal-rendering. Unit tests are also not Universal apps either.
Maybe @MarkPieszak or @Toxicable can direct you to some more information about what node facilities are available with the Universal setup, but as for as the browser apps are concerned there is no fs available.

I had the same issue, when upgrading one of my angular 4.0 universal app to angular 5.
After spending hour, then finally fixed the issue with following snippet in the clientBundleConfig.
I'm not sure if this is the correct solution, someone may have better solution for the error.
node: {             fs: "empty"         }

I'm confused. How the hell am I supposed to use ngx-device-detector now?
@nguniversal/express-engine is a transitive dependency of ngx-device-detector that requires fs: https://github.com/angular/universal/blob/master/modules/express-engine/src/main.ts#L8
Now my tests are failing:
Error: Module not found: Error: Can't resolve 'fs' in './node_modules/@nguniversal/express-engine/src',Module not found: Error: Can't resolve 'fs' in './node_modules/@nguniversal/express-engine/src'

@filipesilva @Toxicable what do you guys recommend? I'm clueless. ):

@alfaproject Try adding @types/node to your project and make sure you have typeRoots: [ "node_modules/@types" ] in your tsconfig.
Let me know if that solves your issue

@Toxicable that's what I have already. ):

@alfaproject do you override that anywhere with a types: [ ... ] declaration?

@pakhuta you save my times, thanks

You can fix it, just add to the "package.json"
"browser": {
    "fs": false,
    "path": false,
    "os": false
  }

Implementing the above code opens up the browser window but shows "Not allowed to load local resource:" error. And the DevTools has node_modules/electron directory and not my project one.

it work for me to add the code after devdependencies
"browser": {
"crypto": false,
"fs": false,
"path": false,
"os": false,
"net": false,
"stream": false,
"tls": false
}


For issue #130: Expose Writer class, add "dirty" property

Can I get some preliminary feedback on this PR? It implements the first idea discussed in #130.

[x] Expose Writer as a public class
[x] Make Writer's .io field expose a similar API in regular Python and Cython
[x] Rerun writer performance benchmark to ensure no performance regressions
[ ] Add new tests for Writer now that it's public? (Would appreciate some suggestions on this.)
[ ] Update documentation to include info on Writer

This PR:
Writing 10000 records to one file...
... 50 runs averaged 0.00858006954193 seconds
Reading 10000 records from one file...
... 50 runs averaged 0.0159693431854 seconds

Writing 10000 records to one file...
... 50 runs averaged 0.0575728607178 seconds
Reading 10000 records from one file...
... 50 runs averaged 0.0941914415359 seconds

Benchmark run from the original _writer.pyx PR:
Writing 10000 records to one file...
... 10 runs averaged 0.0102419137955 seconds
Reading 10000 records from one file...
... 10 runs averaged 0.0207515954971 seconds

Writing 10000 records to one file...
... 10 runs averaged 0.0623118400574 seconds
Reading 10000 records from one file...
... 10 runs averaged 0.121334815025 seconds

So the write performance still looks good.

I made a few changes based on the discussion so far:

In Writer

Make most fields private (only in Cython version; Python doesn't support this)
Rename dump() as _dump() to imply it's private
Add a dirty property so it's possible to implement a cutoff without accessing block_count and io fields

With these changes, the file size cutoff can now be implemented externally as:
        writer.write(record)

        # Block count of zero indicates fastavro just reached an internal max
        # size and ran Writer.dump(). This is a good time to consider starting
        # a new file.
        if not writer.dirty and output_file.tell() >= MAX_FILE_SIZE:
                    output_file.close()
                    writer = Writer(...)

(I noticed the original example in the issue I filed was overly complex as well. I will clean that up for a fair comparison.)

Ok, I reverted the last 3 commits. I'd appreciate any guidance about what level and kind of testing and documentation would be appropriate for this PR.
Thanks!

This seems good to me. As for testing, I think something that just shows the basic use case would be sufficient for the moment. Something like:
from fastavro.writer import Writer

writer = Writer(file, schema)
for record in records:
    writer.write(record)
writer.flush()

...
# read
...
assert read_records == records

This wouldn't test anything new (as the normal writer function basically already tests this) but I think would be useful as a proof of "this is basically how it would work"

I added 3 tests:

Basic test that illustrates writing records and flushing
Test that illustrates a useful scenario for unit testing code that uses Writer, where small files are preferable so tests run quickly. This test specifies a sync_interval of 0, which forces Writer to flush automatically after each record.
Test that illustrates splitting a set of records across two files based on automatic flush behavior. This test approximates the real-world use case of splitting files when they exceed a target size.

Wow, nice tests. I'm good for merging. @tebeka do you have any thoughts?

@scottbelden Sorry, way too busy this week. Whatever you decide is good for me.


Gateway cannot access generated services from gateway portal

Caused by generated cloud-gateway.yml has wrong route url for service.
Generated:
      routes:
      - id: AzureServiceBusApplication
        uri: lb://AzureServiceBusApplication
        predicates:
        - Path=/AzureServiceBusApplication/**

Expected:
      routes:
      - id: AzureServiceBusApplication
        uri: lb://azure-service-bus
        predicates:
        - Path=/azure-service-bus/**

@warrenzhu25


fluid.pca~ fittransform message breaks nameless cascading

When chaining fluid.datasetprocess~ objects (e.g. fluid.normalize~, fluid.pca~, etc...) you can typically just chain them together since the fittransform message cascades quite elegantly.
Except for fluid.pca~ which outputs an additional variable, the variance, which the subsequent object interprets as the name of a dataset (e.g. fittransform firstDataset 0.23523393)

This means you can't simply cascade fluid.pca~ -> fluid.umap~, or any other fluid.datasetprocess~ for that matter.
It's easy enough to code around this (zl slice 2), but it really breaks the elegance of chaining the objects, and makes anything post-fluid.pca~ require additional coding.
A simple solution would be to move the variance output to the fit message instead, which would have the added benefit of allowing for iterative looping to arrive at a suitable variance output without unintentionally processing the rest of the chain. (e.g. if I want to loop over fluid.pca~ to get >95% variance, I would have to gate the output to avoid processing the rest of the chain each loop, which could lock up the scheduler if you have a chunky fluid.umap~ downstream)

As per @tremblap suggestion, I am going through older issues and this one still gets me every time. I get errors and after some confused troubleshooting discover, then re-remember, this issue every time.


unresolvable prev/next meta should lead to warning not crash

Ingesting a document with prev/next urn that does not actually exist in another document leads to a successful ingest, but the html vis for the document is not accessible. Better behavior would be:

Ignore prev/next (behave like the document just doesn't have that field
Output a warning on the cli during ingest

relevant trace:
  File "/usr/local/lib/python3.6/dist-packages/django/core/handlers/base.py", line 124, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/var/www/cts/coptic/coptic/views.py", line 47, in text_view
    visualization = text_object.html_visualizations.get(visualization_format__slug=format)
  File "/usr/local/lib/python3.6/dist-packages/django/db/models/manager.py", line 82, in manager_method
    return getattr(self.get_queryset(), name)(*args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/django/db/models/query.py", line 399, in get
    self.model._meta.object_name
texts.models.HtmlVisualization.DoesNotExist: HtmlVisualization matching query does not exist.

Looks like the logic for this is already in place: https://github.com/CopticScriptorium/cts/blob/master/coptic/coptic/views.py#L57L68
This makes sense since it wasn't the fact that the value of next wasn't a valid document_cts_urn which was causing the exception I pasted above. There must be some subtle interaction between having a bad next and that stack trace above. (They seem connected, since fixing the value of next made the issue go away.)


Updated to allow offline use by pre-downloading MarketplaceItem.zip.

The AzureStack.ComputeAdmin module assumes that it has internet connectivity in order to download the MarketplaceItem.zip file when creating new Marketplace Items in stack.  However in disconnected mode this process fails and so I have added some code to allow for the offline download of the MarketplaceItem.zip file and then running the functions from the module with an argument giving the location of the pre-downloaded zip.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: dfencegit sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Update Chapter 1: COBOL Programming Course #1 - Getting Started to Zowe V3

Proposed changes
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context to communicate to the maintainers why we should accept this pull request.
Fixes # (issue)
This pull request includes the following changes:

Updated the main course markdown file.
Detailed unnecessary files from images.
Updates images in course materials.

Type of change
What type of changes does your PR introduce to the COBOL Programming Course? Put an x in the boxes that apply.

[ ] Bug fix (change which fixes one or more issues)
[ ] New feature (change which adds functionality or features to the course)
[ ] Translations (change which adds or modifies translations of the course)
[x] Documentation (change which modifies documentation related to the course)
[ ] This change requires an update to the course's z/OS environment

Checklist:
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This checklist will be used as reference for both the contributor and the reviewer

[x] I have read the Contributing Guideline
[x] I have included a title and description for this PR
[x] I have DCO-signed all of my commits that are included in this PR
[x] I have tested it manually and there are no regressions found
[x] I have commented my code, particularly in hard-to-understand areas (if appropriate)
[x] I have made corresponding changes to the documentation (if appropriate)

@tanto259 thanks for bringing that to my attention. I think we could remove the Java prerequisite section and just refer to the reader to review the prerequisites at https://marketplace.visualstudio.com/items?itemName=IBM.zopeneditor if they choose to install Z Open Editor. This would remove the need for us to refresh this information in the future if it changes.
Also, we can move the Node.js prerequisite information into the CLI section. Installing Node.js is not required for the VS Code extensions.
If you agree, I think we can merge in these contributions and I'll open a new PR to address this.


4.1-pre-release

Tighten up flags to daemon in default charts, rename package to mina, prepare for tagging / branch cut. Also updates coda-automation to match master w/ the latest docker image, genesis ledger, etc. to use for the community qa net.
Additionally, fixes the zexe-standardize.sh script for the new marlin rust bindings, as well as making bisect_ppx conditional for the new rust bindings to avoid spamming ~/ with .coverage files.

As I mentioned to @lk86, I have a branch that uses the latest bisect_ppx, and eliminates the need to mention --conditional. The ppx will be mentioned in an instrumentation clause instead of in the pps clause.
It's a big change, and it's low priority, so it may take some time before I make it into a PR.


Release 0.9.1

[BUGFIX] Fix report time missing for histogram metrics #94

Update CircleCI orb settings.
Signed-off-by: Ben Kochie<EMAIL_ADDRESS>

LGTM


Domain Alias option not available in Plesk Onyx with Let's Encrypt 2.0.0-21

I updated the extension to Let's Encrypt 2.0.0-21 and Plesk Onyx Version 17.0.17 Update #21 and do not see any options to add aliases as shown in the Plesk Extension Catalog for Let's Encrypt. I tried renewing existing domain and also deleting Let's Encrypt SSL and replacing with self-signed and then re-installing Let's Encrypt SSL and still no alias options. I even uninstalled Let's Encrypt extension and re-installed. No joy. How do I get this option?

Are you sure that you have an Domain alias? It won't work for subdomains.

Domain aliases should have the web service enabled (with the green icon on the overview).
Take a look at the discussion with screenshots here: https://ext.plesk.com/packages/f6847e61-33a7-4104-8dc9-d26a0183a8dd-letsencrypt#comment-3227231448


redesign team page...

...to make the layout more accessible and eye-pleasing

This was implemented in PR #14


Errno::EACCES: Permission denied @ rb_sysopen when using systemd to start sharetribe service

Hi all,
I am new to sharetribe and dont have any experience with ruby etc. I followed the steps to setup sharetribe from here:
https://freedif.org/how-to-install-sharetribe-for-ubuntu-16-04/
When i start the services manually I do not see such issues. I see the below errors when i connect to the terminal again and check the status using 'journalctl -u sharetribe.service'.
I checked the permissions for the path and the files, i did chmod 777 so that all users have permissions. Any thoughts?
Feb 19 03:07:16 ubuntu-xenial-1 sharetri[4628]: W, [2018-02-19T03:07:16.099853 #4775]  WARN -- : Failed creating logger for file /home/arvind_nm/sharetribe/sharetribe/lo
Feb 19 03:07:16 ubuntu-xenial-1 sharetri[4628]: W, [2018-02-19T03:07:16.102594 #4775]  WARN -- : Errno::EACCES: Permission denied @ rb_sysopen -  /home/arvind_nm/sharetribe/sharetribe/log/newrelic_agent.log
Feb 19 03:07:16 ubuntu-xenial-1 sharetri[4628]: D, [2018-02-19T03:07:16.102956 #4775] DEBUG -- : Debugging backtrace:
Feb 19 03:07:16 ubuntu-xenial-1 sharetri[4628]: D, [2018-02-19T03:07:16.102956 #4775] DEBUG -- : Debugging backtrace:

It's not bundler's issue. Maybe, You can resolve your problem with https://stackoverflow.com/.


Added my data

Good job @raihankhan-rk
Congrats 🎉, your PR got merged. To be eligible for the swags from ClueLess. Follow this steps.

Star this repository. ⭐

SignIn / SignUp in ClueLess Website.

Go to profile section from the top right hand corner.

Comment your profile URL under this comment tagging the person who merged your PR.

That’s it. Follow the leaderboard !
And don’t forget to share your achievement with your friends.


Log exception message in NotAcceptableListener

Codecov Report

Merging #72 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
- Coverage     98.65%   98.64%   -0.01%
- Complexity      111      112       +1
============================================
  Files            23       23
  Lines           297      296       -1
============================================
- Hits            293      292       -1
  Misses            4        4

Impacted Files
Coverage Δ
Complexity Δ

src/Error/NotAcceptableListener.php
100.00% <100.00%> (ø)
6.00 <3.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d08d0...178f79d. Read the comment docs.