[DEV]Register a view in Obsidian Projects

Saw your idea in discord, so I decide to file a issue to record this.
Have been playing with something even simpler, though perhaps too simple. Plugins could subscribe to an event with a context that lets you register an onload function that gives you the data and an HTMLElement where you can add your view.

And can't wait to see this happen. I wanted to build a view and use data from projects.

Let me know if I need to share some info or implement internally something inside dbfolder to help you with this =)

I have a working proof-of-concept right now. The Projects plugin scans all enabled plugins and looks for a onRegisterProjectView method.
import { Plugin } from "obsidian";

export default class MyPlugin extends Plugin {
	onRegisterProjectView(data: DataFrame, contentEl: HTMLElement) {
		contentEl.createEl("h1", { text: "Debug" });

		const ul = contentEl.createEl("ul");

		for (let field of data.fields) {
			ul.createEl("li", {
				text: field.name,
			});
		}
	}
}

Most likely we'll need to change the signature to provide a builder-type pattern like for menus so we can extend it with more configuration options in the future.
onRegisterProjectView(ctx: ViewContext) {
  ctx.setTitle("Sample view").setNoPadding().setOnLoad((data, contentEl) => { ... });
}

WDYT?

I'd love to ship it pretty soon so that you can start testing it out and we can start iterating on the API.

I will test it as soon as is released for sure

maybe I have to expose a selector modal with all the current db notes the user have inside that registerproyect

Ok. I think I finally have something you can start testing.

Here's an example of a plugin that does nothing but registers itself as a Projects view.
import { Plugin } from "obsidian";
import { ProjectView } from "obsidian-projects-types";

export default class MyPlugin extends Plugin {
  onRegisterProjectView(view: ProjectView) {
    view.setTitle("Sample view")
      .setIcon("apple")
      .setOnOpen((data, contentEl) => {
        contentEl.createEl("h1", { text: "Debug" });

        const ul = contentEl.createEl("ul");

        for (let field of data.fields) {
          ul.createEl("li", {
            text: field.name,
          });
        }
      });
  }
}

Install the types by running:
yarn add --dev<EMAIL_ADDRESS>
The API is only intended to give you something to experiment for now. Please don't add this to any releases :)
I'm super excited to see if anyone actually gets it to work 😅

with v0.14.7 I try it with dbfolder plugin and an empty one and I am receiving an undefined on view: ProjectView
The function its called when I try to create a new view but breaks the modal

Support was introduced in 0.14.8, so make sure upgrade and try again 🙏

Please, update your manifest.json. BRAT (and also official plugins) reads your main branch > manifest.json to download the version
https://github.com/marcusolsson/obsidian-projects/blob/main/manifest.json

What should I update? 0.14.8 is the latest version and that's what's in the manifest? I don't know BRAT that well tbh :)

now BRAT upload it, thanks!
I am afraid I need a lot of work for integrate the table.
Just like Kanban plugin we use the workspaceLeaf element as input

https://github.com/RafaelGB/obsidian-db-folder/blob/master/src/DatabaseView.tsx
https://github.com/mgmeyers/obsidian-kanban/blob/main/src/KanbanView.tsx

I will try to mock it

The context of the plugin is lost inside the api function.
https://stackoverflow.com/questions/4011793/this-is-undefined-in-javascript-class-methods. We need to bind it on call

Good find! I'll fix it with the next release!

@RafaelGB Should hopefully be fixed in 0.14.10. Let me know if not.

Looks like now the context is available, thanks!
I will let you know if I found another issue

I could mock the table inside! but there is a little problem...
Your API is rendering on loop the view, I don't know if it happens after an exception or that loops provokes de exception
https://user-images.githubusercontent.com/11924043/191769917-ae844d12-8487-4196-a469-940c4a3fa8e0.mov

Wow!! 🤩
I'm not sure I understand what you mean by "rendering on loop the view"? The onOpen function gets called any time there's new data, for example if you add a file to the workspace.

In the case of dbfolder, the refresh of the information is managed internally with Zustand and I think that this refresh trigger jumps in cases where it shouldn't.
Would there be the possibility of disabling refresh as an API option (just like addIcon but toggleRefresh)? If the plugins already have their own way of managing it, you may incur a conflict. I think that is the case here

Also, I just need a path to the ddbb file, but with the view the use will need to select it every time, maybe some kind of config map  per view inside the API?

Would you rather have a separate callbacks for receiving new data and when the user opens the view?
For example:
.setOnData((data: DataFrame) => {
  /...
})
.setOnOpen((contentEl: HTMLElement) => {
  // ...
})

Each view has a config object stored in the data.json. Haven't figured out a good way to expose it yet, but it's coming.

Would you rather have a separate callbacks for receiving new data and when the user opens the view?
For example:
.setOnData((data: DataFrame) => {
  /...
})
.setOnOpen((contentEl: HTMLElement) => {
  // ...
})

Each view has a config object stored in the data.json. Haven't figured out a good way to expose it yet, but it's coming.

Since the plugin rewrite all the config every time it Marshall/unmarshall the yaml info I think it provokes the eternal loop of the callback.
I like the idea of separating them 👌

I've published 0.14.11 of the Projects plugin, and 0.3.3 of obsidian-projects-types package, which exposes a reworked version of the API.
Instead of the builder pattern, in V2, you implement an abstract class:
import { Plugin } from "obsidian";
import { DataFrame, ProjectViewV2 } from "obsidian-projects-types";

class MySampleView extends ProjectViewV2 {
  dataEl?: HTMLElement;

  getViewType(): string {
    return "my-sample-view";
  }

  getDisplayName(): string {
    return "Sample view";
  }

  getIcon(): string {
    return "apple";
  }

  async onData(frame: DataFrame) {
    if (this.dataEl) {
      this.dataEl.empty();

      this.dataEl.createDiv({ text: JSON.stringify(frame.fields) });
      this.dataEl.createDiv({ text: JSON.stringify(frame.records) });
    }
  }

  async onOpen() {
    console.log("Opening ", this.getDisplayName());

    const contentEl = this.containerEl;

    contentEl.createEl("h1", { text: "My Sample View" });

    this.dataEl = contentEl.createEl("div");
  }

  async onClose() {
    console.log("Closing ", this.getDisplayName());
  }
}

export default class MyPlugin extends Plugin {
  onRegisterProjectViewV2 = () => new MySampleView();
}

onOpen is called when the user switches to your view
onClose is called when the user leaves your view
onData is called whenever the data has changed.

Compared to V1, you can now set up more expensive computations in onOpen and only update the relevant parts of the view. You can also use onClose to clean up any resources you created in onOpen.

Really nice job. I will test it this weekend to give you feedback :)

class MySampleView extends ProjectViewV2 {
	private plugin: DBFolderPlugin;
	constructor(plugin: DBFolderPlugin) {
		super();
		this.plugin = plugin;
	}
	dataEl?: HTMLElement;

	getViewType(): string {
		return "my-sample-view";
	}

	getDisplayName(): string {
		return "Sample view";
	}

	getIcon(): string {
		return DB_ICONS.NAME;
	}

	async onData(frame: DataFrame) {
		// Do nothing here
	}

	async onOpen() {
		const [firstKey] = this.plugin.viewMap.keys();
		const db = this.plugin.viewMap.get(firstKey)

		db.initDatabase().then(() => {
			this.containerEl.createDiv().appendChild(db.containerEl)
		})
	}

	async onClose() {
		console.log("Closing ", this.getDisplayName());
	}
}
// ***
onRegisterProjectViewV2 = () => new MySampleView(this);

https://user-images.githubusercontent.com/11924043/192150347-b89126b9-b6b5-4de2-b318-79cbbf4a42b5.mov
With the correct configuration the mock is working =)
For some reason the view had a limited height but it is just a visual detail, the core of the API fits with dbfolder now

0.21.0 contains an updated API for custom views. This release has several breaking changes, but updating should be relatively straight-forward.
Notably, with this release, all the built-in views are now using the custom view API. Hopefully, that means that I'll be able to catch issues early. Feel free to have a look the table view, for example.
For documentation, refer to Custom View API. It's a bit bare, but I'll keep improving it as we go.
With this release, I'll consider this issue closed. Feel free to open new issues for any issues you find. I'll label any issues for custom views with area/view/custom in case you want to keep updated.
Exciting times ahead!

I can't wait to play with it 😄😄


mythos events not working

This is a regression confirmed with the stable House Lynch on the development Valkyrie.

Also perils


GraphQL error when running Gatsby

warn Multiple node fields resolve to the same GraphQL field
warn Multiple node fields resolve to the same GraphQL field
warn There are conflicting field types in your data.

If you have explicitly defined a type for those fields, you can safely ignore this
warning message.
Otherwise, Gatsby will omit those fields from the GraphQL schema.

If you know all field types in advance, the best strategy is to explicitly define them
DefaultJson.author:
 - type: object
   value: { name: 'Daniel O\'Connor', email<EMAIL_ADDRESS>url:
'https://danoc.me/' }
   source: File "../packages/thumbprint-codemods/package.json"
 - type: string
   value: 'Daniel O\'Connor<EMAIL_ADDRESS>ThumbprintComponent.author:
 - type: object
   value: { name: 'Daniel O\'Connor', email<EMAIL_ADDRESS>url:
'https://danoc.me/' }
   source: File "../packages/thumbprint-react/package.json"
 - type: string
   value: 'Tom Genoni<EMAIL_ADDRESS>ThumbprintToken.tokens.value.web:
 - type: number
   value: 1025
   source: File "../packages/thumbprint-tokens/src/tokens/breakpoint.json"
 - type: string
   value: '4px'
   source: File "../packages/thumbprint-tokens/src/tokens/border-radius.json"
ComponentProp.doclets.value:
 - type: boolean
   value: true
   source: File "../packages/thumbprint-react/components/Input/index.jsx"
 - type: string
   value: 'Use `src` instead of `url`.'
   source: File "../packages/thumbprint-react/components/ServiceCard/index.jsx"
ComponentProp.parentType.value:
 - type: [object]
   value: [ { value: '\'bottom\'', computed: false }, ... ]
   source: File "../packages/thumbprint-react/components/BlockList/index.jsx"
 - type: object
   value: { name: 'number' }
   source: File "../packages/thumbprint-react/components/InputRow/index.jsx"
 - type: string
   value: 'Date'
   source: File "../packages/thumbprint-react/components/DatePicker/index.jsx"
ComponentProp.type.value:
 - type: [object]
   value: [ { value: '\'bottom\'', computed: false }, ... ]
   source: File "../packages/thumbprint-react/components/BlockList/index.jsx"
 - type: object
   value: { name: 'number' }
   source: File "../packages/thumbprint-react/components/InputRow/index.jsx"
 - type: string
   value: 'Date'
   source: File "../packages/thumbprint-react/components/DatePicker/index.jsx"

I dug into this last August, but the issue is not yet fixed in Gatsby: https://github.com/gatsbyjs/gatsby/issues/7027.
Happy to have someone dig into this, but it will require a deep-dive into the Gatsby internals to fix.


[SAC-124][SQL] Hive Warehouse Connector support

What changes were proposed in this pull request?
This PR proposes to add HWC support in SAC.
HWC supports four types of operations:

Batch read

Batch write

Batch write (in streaming manner by Hive streaming API)

(Structured) streaming write

In general, It looks up existing Hive tables and link it, rather then newly creating the entities.
1., 2., and 3. supports were added by looking up logical plans and physical plans. It supports when inputs are from other sources.
For 4., it reuses Kafka support; namely, it recognises Kafka input as input entity only for now.
How was this patch tested?
Manually tested:

The examples at https://community.hortonworks.com/content/kbentry/223626/integrating-apache-hive-with-apache-spark-hive-war.html were used and tested.
Closes #124

I tested some combinations with Spark table and etc as well:

Yup, Thanks for quick review. i was working on another fix that needs some utils here.


BrightData's Scraping Browser doesn't work (wss protocol not supported)

Describe the bug
Extra Browsers from BrightData attached on Settings > CAPTCHA & Proxies can't be used in watches.
Version
v0.46.02
To Reproduce
Steps to reproduce the behavior:

Under Settings > CAPTCHAS & Proxies, add any wss:// URL on "Extra Browsers" and save.
Create a new watch using that extra browser (Request > Fetch Method) and save
When trying to fetch the URL, an error is shown: "Exception: Not supported URL scheme wss"

Expected behavior
Fetch completes successfully.
Screenshots

Smartphone (please complete the following information):

Device: iPhone 12 mini
OS: iOS 17.6
Browser: Google Chrome
Version: 127.0.6533.77

Additional context
Required python packages seems to be installed. I'm using docker on amd64. Followed steps from Using Bright Data's "Scraping Browser" to by-pass CAPTCHA's and other protection when monitoring pages. Selenium URLs seems to possible to use (https://brd...:9515), but I'm unable to test (got no free trial).

Heya, OK i spent a bit of time testing this and I cant reproduce it, but then i realised I was using https://example.com when i switched to https://google.com as the test URL i stopped getting the error
so in this case, i think its just that google.com is not supported by BrightData
BrightData are super helpful if you ask them for support on a particular URL tho

hmm yeah https://booking.com works too (can you try that one?)

btw, you didnt say anything about how you are running cdio, like from docker, mac, amiga, hosted, windows or


Flatcar Container Linux support

Description
Flatcar Container Linux (https://www.flatcar.org/) is an interesting immutable Linux OS which suits well to run e.g. Kubernetes. Any change support for Flatcar Linux can be added to Lima as it does not seem to work "out-of-the-box" based on quick testing done.

I think that Flatcar (and CoreOS) use ignition rather than cloud-init, so I'm not sure it is compatible.

Note that you can run Podman Desktop instead of Rancher Desktop, if you want Fedora CoreOS support...
It is "interesting immutable", and has a common ancestor with Container Linux (that would be: CoreOS)

Are you able to provide a YAML file, for the "stable" image ?

Currently there is no support for compressed images in Lima, so the .bz2 needs to be decompressed.

images:
#- location: "https://stable.release.flatcar-linux.net/amd64-usr/3374.2.5/flatcar_production_qemu_image.img.bz2"
#  arch: "x86_64"
#  digest: "sha256:cb8a30d891f1a9c4dd3fe34508c2f00aa2f18956bbe48f649848201292ffd1a9"
- location: "flatcar_production_qemu_image.img"
  arch: "x86_64"
  digest: "sha256:28f570a120f040523972a7cae948eb6ee41cf444f3c7c92f1bc721bf95ee5891"

video:
  display: "default"

For some reason, Flatcar produces every checksum - except for SHA256...
# MD5 HASH
0a8b08387670cbc62c2d5086622a0956  flatcar_production_qemu_image.img.bz2
# SHA1 HASH
52edb61aacf14e19f23716d20311197fe47a9fa9  flatcar_production_qemu_image.img.bz2
# SHA512 HASH
7aa371a6e7013d02f6e3d6031c155420ce617dfe920d4d744950f87faa6b6f83c5e938525fcba5e8d1fb885e647af20fb412c3b56dbaff1a2d3dfcf7815a3145  flatcar_production_qemu_image.img.bz2

The issue was not the OEM, it was that the labels and paths for user-cloudinit are hardcoded...

The label of the CD is "config-2", not "cidata"

The mount path of it is "/media/configdrive", not "/mnt/lima-cidata"

The name of the file is "openstack/latest/user_data", not "user-data"

@afbjorklund Thanks for taking a look, it looks like these files need to be modified?
https://github.com/flatcar/coreos-cloudinit/search?q=%2Fmedia%2Fconfigdrive

Maybe they (the locations) can be configured during runtime somehow, env or cmdline ?

Apparently there is a special image for UEFI, noticed when looking at the arm64 variant.
Debug setup:
images:
- location: "https://stable.release.flatcar-linux.net/amd64-usr/3374.2.5/flatcar_production_qemu_uefi_image.img.bz2"
  arch: "x86_64"
  digest: "sha512:3fe0068f838f8055fbdc374e9d59ab6828d79f1d1d3c0b93fe6b89893ff06d1cbc4acdd19c0c6a54e7462cf86cdd29340eaa2ed6ad3fd114c552f43bce526718"
- location: "https://stable.release.flatcar-linux.net/arm64-usr/3374.2.5/flatcar_production_qemu_uefi_image.img.bz2"
  arch: "aarch64"
  digest: "sha512:0f4ee08e9a17ece104d477cbc1ab0eda6f410683aea0067779771587c3864df9f3527c1c647158064424b33918fd5bbabf6384e9d71ef4a98a672565d154aba8"

video:
  display: "default"

Using Fedora CoreOS seemed to be slightly better documented, and it was used by Podman Desktop

Flatcar doesn't have support for sshfs (or fuse), so it will have to use mountType: "9p" instead.
On a normal operating system you could install it, but that is not possible on an immutable OS.

Not sure that we want to support this (using ignition and butane, instead of cloud-init)

Not sure that we want to support this (using ignition and butane, instead of cloud-init)

Any given reason? This seems interesting.

No interest, duplication of the scripts?
The main user (of CoreOS) is Podman, but they are set on doing their own "machine"...

I'm super interested in this, but I can understand why maintaining ignition.yaml is unappealing.

Most of the cloud-init and ignition/butane is static, so it is actually the OS that is unappealing.


V6 Options /4

Fixes #23747 Fixes #23694
Internal review URL

@halter73 See V6 IValidateOptions for complex validation and Previous V5 IValidateOptions for complex validation
It might be easier to review the code from the links than from here.
Is this the correct replacement for the following?
public void ConfigureServices(IServiceCollection services)
{
    services.Configure<MyConfigOptions>(Configuration.GetSection(
                                        MyConfigOptions.MyConfig));
    services.TryAddEnumerable(ServiceDescriptor.Singleton<IValidateOptions
                              <MyConfigOptions>, MyConfigValidation>());
    services.AddControllersWithViews();
}

"Using the preceding code, validation is enabled in Startup.ConfigureServices with the following code:"

"Startup.ConfigureServices" should probably be updated to "Program.cs". The code looks right though.
As a nit, I think it's very odd to put the newline in the middle of a type. I'd go with the following:
services.TryAddEnumerable(ServiceDescriptor.Singleton<
    IValidateOptions<MyConfigOptions>, MyConfigValidation>());

But that's unchanged from before.
P.S. I've noticed that the fragment changed for the "IValidateOptions for complex validation" section from #ivalidateoptions-for-complex-validation-1 to #ivalidateoptions-for-complex-validation so if you try to switch versions from aspnetcore-5.0 to aspnetcore-6.0 you lose your place in the document. Do you know why that happened?

"Startup.ConfigureServices" should probably be updated to "Program.cs".
Fixed in #23765

so if you try to switch versions from aspnetcore-5.0 to aspnetcore-6.0 you lose your place in the document. Do you know why that happened?

That's a huge problem with using monikers for versioning. Given they have the same exact H2/H3/HN where the link is generated, they need to tack on -1 for the 2nd duplicate, -2 for the 3rd. I put the current version on top (or in this case soon to be current, V6) so the links don't break.
We hope to start using file versioning next year sometime, that will fix the problem.


changes on my README file

Thank you for your contribution. As mentioned in the README - this is a template repo for the open source bootcamp, so we are not accepting PRs unless they are from the project owners.


Windows 11 - Failed installation due to deepspeed

OS: Windows 11
Python 3.9.18

echo %CUDA_HOME%
'C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.7'

set DS_BUILD_SPARSE_ATTN=0
set DS_BUILD_AIO=0
set DS_BUILD_UTILS=1
Error on deepspeed:
Processing deepspeed-0.8.3.tar.gz
Writing C:\Users\nico\AppData\Local\Temp\easy_install-9x4th6th\deepspeed-0.8.3\setup.cfg
Running deepspeed-0.8.3\setup.py -q bdist_egg --dist-dir C:\Users\nico\AppData\Local\Temp\easy_install-9x4th6th\deepspeed-0.8.3\egg-dist-tmp-g275j9m6
No CUDA runtime is found, using CUDA_HOME=''C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v11.7''
[WARNING] Torch did not find cuda available, if cross-compiling or running with cpu only you can ignore this message. Adding compute capability for Pascal, Volta, and Turing (compute capabilities 6.0, 6.1, 6.2)
DS_BUILD_OPS=0
"C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.36.32532\bin\HostX86\x64\cl.exe" /c /nologo /O2 /W3 /GL /DNDEBUG /MD "-IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.36.32532\include" "-IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.36.32532\ATLMFC\include" "-IC:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Auxiliary\VS\include" "-IC:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\um" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\shared" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\winrt" "-IC:\Program Files (x86)\Windows Kits\10\\include\10.0.22621.0\\cppwinrt" "-IC:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\include\um" /TcC:\Users\nico\AppData\Local\Temp\easy_install-9x4th6th\deepspeed-0.8.3\temp\tmplvgsg3hf\test.c /FoC:\Users\nico\AppData\Local\Temp\easy_install-9x4th6th\deepspeed-0.8.3\temp\tmplvgsg3hf\test.obj
test.c
"C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.36.32532\bin\HostX86\x64\link.exe" /nologo /INCREMENTAL:NO /LTCG /MANIFEST:EMBED,ID=1 "/LIBPATH:C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.36.32532\lib\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\NETFXSDK\4.8\lib\um\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.22621.0\ucrt\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\\lib\10.0.22621.0\\um\x64" aio.lib C:\Users\nico\AppData\Local\Temp\easy_install-9x4th6th\deepspeed-0.8.3\temp\tmplvgsg3hf\test.obj /OUT:C:\Users\nico\AppData\Local\Temp\easy_install-9x4th6th\deepspeed-0.8.3\temp\tmplvgsg3hf\a.out.exe
LINK : fatal error LNK1181: impossible d'ouvrir le fichier en entrée 'aio.lib'
 [WARNING]  async_io requires the dev libaio .so object and headers but these were not found.
 [WARNING]  If libaio is already installed (perhaps from source), try setting the CFLAGS and LDFLAGS environment variables to where it can be found.
 [WARNING]  sparse_attn cuda is not available from torch
 [WARNING]  sparse_attn requires a torch version >= 1.5 but detected 2.1
 [WARNING]  please install triton==1.0.0 if you want to use sparse attention
Install Ops={'async_io': False, 'cpu_adagrad': False, 'cpu_adam': False, 'fused_adam': False, 'fused_lamb': False, 'quantizer': False, 'random_ltd': False, 'sparse_attn': False, 'spatial_inference': False, 'transformer': False, 'stochastic_transformer': False, 'transformer_inference': False, 'utils': 1}
fatal: not a git repository (or any of the parent directories): .git

Hi @nlienard - this looks like you are still trying to build the async_io op, based on the fatal link error?  I'd recommend closely taking a look at our Windows installation instructions, we are working to improve those, though.  However, you can more easily use DeepSpeed on Windows today if you use WSL.  That will allow you to use all features, such as AIO, and not have to worry about the linking issues seen here.

I see - unfortunately it can be quite difficult to build certain python packages on Windows, and DeepSpeed is one of those.  We are working on improving that, but the process is different for each user depending on their setup.  Have you followed the instructions here?
WSL doesn't kill performance at all for DeepSpeed.

ok on linux WSL, it works well.

@nlienard - some of the python setup/torch things don't work as well on Windows.  We are trying to work on this, but for now I'm glad that at least WSL solves your problem.  I'll close this for now, but if you hit any other issues, let us know.


[mpfr] unresolved external __gmpfr_set_sj in function fmpz_get_mpfr

This is currently blocking dynamic FLINT compilation.

Filed an upstream issue: https://gforge.inria.fr/tracker/?func=detail&atid=619&aid=21558&group_id=136


Broken yaml hierarchy in the default output

cc @shcheklein
Continuing the discussion on Discord
Hierarchy of parameters seems to be split into multiple columns in the VS code extension.
A simple example where this can be reproduced:
https://github.com/tibor-mach/vscodedvc-example

Was about to report similar.
This is the simplest structure I have found that triggers the bug:
one:
  two:
    three:
      works: true
      four:
        breaks: true

@daavoo  In my example it breaks even earlier though (example.steps should be under steps)

Adding more nested levels cause the top-level row to be expended (one.two.three, etc.)

@daavoo Ah, ok, that could be it ;-)

It's related to this: https://github.com/iterative/vscode-dvc/issues/950

Maybe a good solution would be to add a configuration option to the extension so that users could limit/not limit nesting as they wish?

👍🏻
I can't remember the reason behind the approach right now. All that I can remember is that there was one. I'll check with the team in the morning and get back to you.

@daavoo @tibor-mach folks, to clarify. We do limit number of levels we go down. Do you consider this limitation itself as a problem (and a solution would be to configure it for example), or the problem is that split itself into columns is not properly handled (we have example.steps and example -> steps simultaneously in the table). Second is potentially a bug with the current implementation. I need to check this.

I don't think the logic that limits the number of head layers has a bug inside of it since Studio gives you the same column layout:

Since there's no bug to fix, the only options that come to mind on what to do next are to add some kind of configuration option or leave as is 🤔

Yes, it's not a bug, but rather a feature request. Two options:

we can explore if we can merge still these columns (there will be some empty space at the bottom, similar to features_in), but example.steps` will be a single cell.
we can introduce config

what would it take to implement the first option?

@shcheklein @julieg18 Can I ask what were the reasons to limit nesting to 4 layers? I understand not limiting it can lead to empty spaces, but the structure of the yaml is broken down then. To me it makes sense to preserve the structure the user  (presumably deliberately) set up in the params file.
In my specific case, the hierarchy describes an entire scikit learn Pipeline (or rather a bunch of sub-pipelines in a ColumnTransformer)...the pipeline (and optionally its hyperparameter space for optimization) is serialized in the params file and this makes it quite easy to set up a queue of dvc experiments with various Pipelines setup using the VS code extension.
But if it is "unstacked" like this, the structure is harder to see in the extension. I can still do the same just using dvc but the VS code extension is less useful in this scenario.

@tibor-mach:

Can I ask what were the reasons to limit nesting to 4 layers?

Sure, we made this decision in Studio. Primarily to limit the complexity of the interface. In a lot of cases groups are mergeable (like example.steps) - assumption is there are more leafs and they are more important to end users.
Does it mean the it's set in stone? No. But I'd like to understand better the alternatives.

In my specific case, the hierarchy describes an entire scikit learn Pipeline (or rather a bunch of sub-pipelines in a ColumnTransformer)...the pipeline (and optionally its hyperparameter space for optimization) is serialized in the params file and this makes it quite easy to set up a queue of dvc experiments with various Pipelines setup using the VS code extension.

It makes sense, thanks.

But if it is "unstacked" like this, the structure is harder to see in the extension. I can still do the same just using dvc but the VS code extension is less useful in this scenario.

could you pls clarify what do you mean by "unstacked"? Is it primarily about two impute_missing columns, for example? Two example steps, etc?
What I'm trying to see is if the problem is in an actual number of levels or in the way we split / merge hierarchy at the moment.

To clarify, I removed the bug (since it was done intentionally this way), but it's still an important improvement request for us.

could you pls clarify what do you mean by "unstacked"? Is it primarily about two impute_missing columns, for example? Two example steps, etc?

@shcheklein Personally, I'd like to see everything under example column, which then is split into steps and features_in and steps is further split ... but all in one "master column" (I don't know what to call it but I mean the columns directly under the params_preprocessing.yaml as in this example:
This is because in the VScode extension I can then easily turn on/of visualisation of individual Pipelines (and their parameters) with unchecking a single box. If it is split into multiple "master columns", I have to check/uncheck several.

Makes sense, and it means that we have two options to try:

introduce configurable (potentially including the infinite amount of layers) (can we come up with a "simple" interface to tune this in the table?)
we can try a config option that would go top down and keep leafs with long paths instead.

I would try to prototype both and play with them.

What was the rationale behind choosing 5 levels? Was it just an arbitrary number? How about increasing the limit from 5 to 7?

Basic research of some user's repos. Also to make it less "heavy".
Just increasing the limit sounds like a bandaid to me. What if even in this case @tibor-mach has 8 levels in some places?

I don't have 8 levels anywhere but someone might :-)
On the other hand, there is a point where even more layers would make it very hard to read even in the yaml file...If I had 20 levels in a yaml, I'd probably start thinking about whether I really needed the structure to be that way or whether I needed to do some refactoring.
But someone might plausibly consider 8 or even 10 levels just fine.

Makes sense, and it means that we have two options to try:

introduce configurable (potentially including the infinite amount of layers) (can we come up with a "simple" interface to tune this in the table?)
we can try a config option that would go top down and keep leafs with long paths instead.
I would try to prototype both and play with them.

Sounds good! I'll start working on creating a draft of the first option!

Once we remove the depth limit/concatenation of columns then the table would look like this for the provided demo repo:

@tibor-mach WDYT?

@mattseddon perfect! This is exactly the output I expected.
One more suggestion (probably unrelated and probably not worth its own issue at the moment):
In my setup, some parameters are effectively serialized steps in a pipeline (as in the example). DVC works well with that only as long as the steps are defined as keywords (as it is in the example) but not as a list (lists are grouped like they are for the features_in list). However, since these are steps, a list would be a bit more intuitive in the yaml file (kind of like in GitHub workflows yaml syntax and similar).
But why I am saying that is probably not worth the effor is that since Python 3.7. dictionaries (which is what the yaml is read as) are ordered and will keep the order in the yaml. I think I can live without supporting older Python versions though, so the only drawback is a slightly less explicitly stated need to order things (which I simply manage by ways of documentation...).

With #2436 now merged and shipped, we now have a configuration option that lets you choose the maximum amount of table head layers:
https://user-images.githubusercontent.com/43496356/192805053-05e88ae6-2558-451a-afa3-7ba0f507009f.mov


[NO_REVIEW] Draft - for optimize import maven dependencies

for CI test

Can you describe a bit the rationals backing this change?

Can you describe a bit the rationals backing this change?

I use mvn dependency:tree for filter the duplicate dependencies but different version.
make it synchronized to single version.

I have nothing against the code, should be a bit more careful about the commit description when we merge though...
This one starts by "draft -..."


httplib2.HTTPSConnection returns AttributeError: 'module' object has no attribute 'HTTPSConnection'

httplib2.HTTPSConnection returns AttributeError: 'module' object has no attribute 'HTTPSConnection'

I too have same problem


Is there an example of how to test a resource?

Should we explicitly test the resource, or should it just be included in the controller tests?

@lcpriest our team has been using rspec request specs to test resources.

@lcpriest I've found that request specs are the most useful. I have some very large resource classes and recommend that if you have any nontrivial logic in there that you think deserves some unit tests that you extracted it into testable modules that can be called from the resource getters.
The airborne gem is pretty useful for matching against JSON responses. I'd be curious to hear as well who has had success testing resources calling the serializer directly.

Thanks!


Update ovpn_genconfig

openvpn.conf chage 1194 port to $OVPN_PORT

What's the motivation?  The port is easily overridden by docker port mapping.
The purpose of the OVPN_PORT value is to communicate the external port mapping to generate configurations.  It's expected that the openvpn daemon always listens on port 1194 in the container and docker manages the port mapping.


Improve templating diagnostics

Summary
Users often struggle to diagnoes templating problems. Helping them is time consuming. Everybody looses.
Instead, we log more diagnostics whenever resolution fails:
https://github.com/argoproj/argo-workflows/blob/9c901456a44501f11afc2bb1e856f0d0828fd13f/util/template/simple_template.go#L26
Several times here:
https://github.com/argoproj/argo-workflows/blob/9c901456a44501f11afc2bb1e856f0d0828fd13f/util/template/expression_template.go#L34
Use Cases
When would you use this?

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@lambertsbennett will be working on this.

This is not being worked on.

Add some logging debug statements to that file so when the controller is started with debug logging, then the reason is shown. For example:
Change:
	if err != nil && allowUnresolved {
		return w.Write([]byte(fmt.Sprintf("{{%s%s}}", kindExpression, expression)))
	}

To:
	if err != nil && allowUnresolved {
                log.WithError(err).Debug("unresolved is allowed ")
		return w.Write([]byte(fmt.Sprintf("{{%s%s}}", kindExpression, expression)))

	}

@alexec,  I have added log.WithError(err).Debug("unresolved is allowed ") in expression_template.go and import
log "github.com/sirupsen/logrus", but getting error in line: undefined err
Can you help me with which import will this error be fixed?

@alexec , I have created PR: https://github.com/argoproj/argo-workflows/pull/9533. Please take a look and suggest changes if required.

is this issue still exist or it is solved?

https://github.com/argoproj/argo-workflows/pull/13778 is related


feat: convert unpinned Ubuntu EC2NodeClasses

Fixes #N/A
Description
Updates the EC2NodeClass conversion to successfully convert unpinned Ubuntu NodeClasses. This changes the failure mode from failing at conversion, to failing at NodeClass readiness.
How was this change tested?
/karpenter snapshot
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>2
Details

19 of 21 (90.48%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.007%) to 79.281%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/apis/v1/ec2nodeclass_conversion.go
9
11
81.82%

Files with Coverage Reduction
New Missed Lines
%

pkg/providers/amifamily/ami.go
1
91.67%

Totals

Change from base Build<PHONE_NUMBER>5:
0.007%

Covered Lines:
5996

Relevant Lines:
7563

💛  - Coveralls


[AppVeyor] Only package the installer with rssdk runtime for artifacts

It reduces the artifacts download size.

@DonnaWuDongxia , PTAL. Thanks!

@huningxin , LGTM. Thanks!

Great!. Thanks for reviewing. Merge.


Rescue the time in our DateTime fields

Many of them are now constricted to DateField attributes

After closely examining many of these datetime fields in the source data, it seems clear to me that virtually all of them are only set to midnight, making the the time data superfluous.
I'm sure there are one of two fields somewhere in the source that deserve to be shifted to datetime, but I don't know them and it's not worth switching all fields if most of them aren't worth it.
So if we find one in the future, all it will take is switching the data type for the field and we'll be fine. For now, this is a #wontfix.


Zapier sends 'target_url' in the request and 'target' is expected.

When Zapier POSTs to my /api/v1/hooks/ uri, it sends this as the data...
{"subscription_url": "https://zapier.com/hooks/standard/1453504/8a7907ee05a54e68be99bcdc969155c6/", "target_url": "https://zapier.com/hooks/standard/1453504/8a7907ee05a54e68be99bcdc969155c6/", "event": "entry.created"}
To create a Hook Resource you need to provide user, event, and target.
The target is specified but it is target_url not target. (It also appears to be in subscription_url)
So the new resource is created but the target field is empty.
I realize I can just overwrite my Hook Resource's obj_create method and map target_url to target but it seems that these key names should match up. :)
Is my understanding correct?

Hey @teewuane -  this repository isn't platform support for Zapier. We have a short section that mentions https://zapier.com/developer/documentation/v2/platform/#who-can-help-me. We have engineers at<EMAIL_ADDRESS>who can answer this!

Thanks for the response, @bryanhelmig. To be clear, I wasn't looking for help or support on the Zapier platform.  The reason I opened the issue was to question why the field is named 'target' and not 'target_url'. I would guess that most people using this app in their projects are using it to interact with Zapier (even though it's a rest hooks app could be used anywhere and it's not called "django-zapier-rest-hooks" of reason :)) so it makes sense to me to have the field match. Either way, I have it working in my project just fine :) thanks again!


Much badges & metadata for project from badge.kloud51.com

In response to https://github.com/GrappigPanda/pygemony/commit/b392503dadabec1074ad3b98014cb69e42195394 lol
http://badge.kloud51.com itself has been implemented in Python and it
would make sense to be used here since this project has been implemented in python as well.

Lets do it, lets badge everything.
Thanks for taking the time for this. I never knew about kloud51 before.

Sure, you're welcome.
It's a new project, you can get the source code https://github.com/SavandBros/badge
ps: I forgot these TODOS too, thanks for making pygemony

You should be careful not to hide useful info like build status or code quality check status in a litany of other badges that are basically static information which could just be listed in the README.
To be more specific:

PyPI Downloads - This number is never very accurate since it is heavily inflated by PyPI mirrors downloading your package.
PyPI Wheel - Mostly irrelevant since Pip builds and caches installed packages as wheels since v6.0 or v7.0 (cant remember which offhand). It's also a pretty good idea to upload a source distribution of your package to PyPI.
PyPI Status - Currently says "Unknown" (which is rather unhelpful) since you are missing the appropriate trove classifier in setup.py. This classifier makes more sense for python libraries than it does for standalone command line tools.
PyPI Format - See comment about "PyPI Wheel"
PyPI Py Versions - This would also be irrelevant once Python3 is supported
PyPI Egg - See also: "PyPI Wheel". Most people probably don't even know what an egg is.
PyPI Implementation - See "py versions". For a pure python tool (i.e. no C extensions), it's very unlikely that your package won't work on PyPy.

One good one to add would be a Coveralls badge once you set up test coverage measurement.

Yeah, I originally only wanted ~5, but I was in a YOLO mood last night. I'll revisit them later today because obscuring important information definitely isn't the desired result.

Also @joshfriend, just wanted to thank you for the work youǘe done on flask-restful, we use it extensively at work!


Task dataframe will only keep one task schema row per subject.

If a task dataframe has multiple rows per subject, they should all be kept.

This actually is not true in the current system; this issue does not happen.


Garbage Collection for Cache images

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@barleyj-opengov We had a kick off with arch and reporting and they're looking at solutions this quarter. They didn't understand the urgency and now do.


Add the web config dependent module installation command to the Makefile

What would you like to be added:
I propose to add yarn install to the following Makefile.

https://github.com/pipe-cd/pipecd/blob/master/Makefile#L110-L111

Why is this needed:
According to this document, to install C-Plane in the local environment, make run/pipecd must be run.
However, the one-liner fails to run because there are no dependent modules in the ./web directory.
[webpack-cli] Failed to load '/Users/ren/tmp/pipecd/web/webpack.config.js' config
[webpack-cli] Error: Cannot find module 'dotenv'
Require stack:
- /Users/ren/tmp/pipecd/web/webpack.config.js
- /Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/lib/webpack-cli.js
- /Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/lib/bootstrap.js
- /Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/bin/cli.js
- /Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack/bin/webpack.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1048:15)
    at Module._load (node:internal/modules/cjs/loader:901:27)
    at Module.require (node:internal/modules/cjs/loader:1115:19)
    at require (node:internal/modules/helpers:119:18)
    at Object.<anonymous> (/Users/ren/tmp/pipecd/web/webpack.config.js:3:1)
    at Module._compile (node:internal/modules/cjs/loader:1233:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1287:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Module.require (node:internal/modules/cjs/loader:1115:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/ren/tmp/pipecd/web/webpack.config.js',
    '/Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/lib/webpack-cli.js',
    '/Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/lib/bootstrap.js',
    '/Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack-cli/bin/cli.js',
    '/Users/ren/.nvm/versions/node/v20.5.0/lib/node_modules/webpack/bin/webpack.js'
  ]
}
error Command failed with exit code 2.

Therefore, I propose to add yarn install to the Makefile. Wdyt ?

right +1 on this, I was try to build arm64 and stuck when make build/web doesn't have a step yarn install

@GotoRen @hungran we have make update/web-deps which is preferred to be run once before run/build web with commands. Of course I understand that in some cases, devs only want to run single command for all but just want to share that we let it be that way currently because we handle that in different way. If both feel it's better to make that web deps installation part of other command, then feel free to go (with voting). But I'm still think that we should keep dependencies installation separate from build command, do to we can cache dependencies install layer, but always want to build layer be rerun each time, wdyt?

If it was a docs miss, let's update docs to mention make update/web-deép command.

Maksense!!!
I think just update the document

Me too!!
I agree to update the document.

Thanks @GotoRen @hungran


tagref: 1.3.3 -> 1.4.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/stepchowfun/tagref/releases.
meta.description for tagref is: "Tagref helps you refer to other locations in your codebase."
meta.homepage for tagref is: "https://github.com/stepchowfun/tagref"
meta.changelog for tagref is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.4.1 with grep in /nix/store/ryx3fdkx37jl43ilghyggmhra8k5qh7p-tagref-1.4.1

directory tree listing: https://gist.github.com/90d7a6f95db96ba8de397cb1113c83d4

du listing: https://gist.github.com/47101bddf2ab1f415ffe15e22230b341

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
tagref

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ryx3fdkx37jl43ilghyggmhra8k5qh7p-tagref-1.4.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A tagref https://github.com/r-ryantm/nixpkgs/archive/6f4ad1cf7336c3dcb1b9bf0e96e80abc7e67f139.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ryx3fdkx37jl43ilghyggmhra8k5qh7p-tagref-1.4.1
ls -la /nix/store/ryx3fdkx37jl43ilghyggmhra8k5qh7p-tagref-1.4.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

tagref

Maintainer pings
cc @yusdacra for testing.

LGTM


Added bigscience-LAMA evaluation

Tested locally on GPT2.

Hi @StellaAthena , We think that we can combine them together. We will change the file name here to [lama.py] which same file name in this PR:  #23. Hence, [lama.py] at #23 will have 5 classes. four are subsets from the original one and one is from here.

Hi @StellaAthena , Please check this PR and merge it with the main if everything is OK. This PR contains all the changes from both PR.


[reggen] Automatically generate alert test register

This reuses the automatic interrupt register generation mechanism in reggen to generate alert test registers that allow the SW to test specific alerts in the system in the same way as it would test interrupts.
I regenerated the CSRs, and wired these alert test signals up in all affected modules (aes, keymgr, otbn and otp_ctrl so far).
Note that the alert test registers cannot be locked down at the moment. I am not entirely sure whether that will be needed, though... WDYT?

Currently, the chip_csr_rw test is failing:
UVM_ERROR @ 167440000 ps: (csr_utils_pkg.sv:483) [csr_utils::csr_rd_check] Check failed obs == exp (1 [0x1] vs 0 [0x0]) Regname: ral.otp_ctrl.owner_sw_cfg_read_lock

Thanks for the reviews @rswarbrick and @vogelpi. This PR has to wait for #3905 to go in due to a couple of OTP CSR exclusions that are currently missing (hence the CI failure).

OK, CI passes now. Merging in!


Separate interior state and boundary forcing to only predict state

Describe your changes
The goal of this PR is to establish a clear separation of the (predicted) state in the interior region and the boundary forcing coming from outside (and potentially overlapping with) the limited area. This PR performs these changes on the modeling side. That is from each batch is fetched from the dataset class and onward. Including how the tensors are propagated through the model, loss calculation, evaluation and plotting. This should be complemented with a separate PR for handling the data-loading side of things, where the boundary forcing could come from a separate dataset. That change should then build upon #66, once merged.
Note: In order to allow for working on this before the change has been done on the data loading side this currently includes changes in the MEPS npy dataset class that separates state and boundary already in there. This defines the interface between the dataset and model (currently missing https://github.com/mllam/neural-lam/issues/64 from #66, but that can easily be added later) and allows for working on these separately.
After this change:

The model will only predict outputs within the limited area considered
Plots will only include points within the limited area (this could be expanded in a future PR to plot also boundary fields, but would require a mapping between state and boundary forcing dimensions to plot together)
Graphs will have to be created using a boundary mask as in https://github.com/mllam/weather-model-graphs/pull/34 to make sure that the g2m-component only maps to the interior nodes.

Dependencies:
This introduces a dependency to https://github.com/mllam/weather-model-graphs. In particular, this dependency should be adjusted before merging to require a version after https://github.com/mllam/weather-model-graphs/pull/34 has been merged.
Issue Link
No issue specific to the separation of interior state. This relates to the overall rework of Reading Training Data, but would be good to put as separate point on roadmap.
This includes graph-creation with wmg (#83).
Type of change

[ ] 🐛 Bug fix (non-breaking change that fixes an issue)
[ ] ✨ New feature (non-breaking change that adds functionality)
[x] 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

[x] My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
[x] I have performed a self-review of my code
[x] For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
[x] I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
[ ] I have updated the README to cover introduced code changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have given the PR a name that clearly describes the change, written in imperative form (context).
[x] I have requested a reviewer and an assignee (assignee is responsible for merging). This applies only if you have write access to the repo, otherwise feel free to tag a maintainer to add a reviewer and assignee.

Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:

[ ] the code is readable
[ ] the code is well tested
[ ] the code is documented (including return types and parameters)
[ ] the code is easy to maintain

Author checklist after completed review

[ ] I have added a line to the CHANGELOG describing this change, in a section
reflecting type of change (add section where missing):

added: when you have added new functionality
changed: when default behaviour of the code has been changed
fixes: when your contribution fixes a bug

Checklist for assignee

[ ] PR is up to date with the base branch
[ ] the tests pass
[ ] author has added an entry to the changelog (and designated the change as added, changed or fixed)
Once the PR is ready to be merged, squash commits and merge the PR.

This is now ready for a first review. As mentioned in the description this is only changes to the modeling side of things, and I have tweaked the existing MEPS dataloading to be able to test these changes. We will have to see if the changes to dataloading (building on top of #66) should be in a separate PR or just added to this one. I could see both as good solutions.
There are two things preventing tests to pass for this:

This changes the grid_shape_state  entry in the config to only mean the interior, not boundary. Thus the grid_shape_state in the reduced MEPS data used for tests is wrong. How/if we want to change this depends on how we want to go about with the ordering of this and #66.
This introduces graph creation using weather-models-graph, and in particular relies on the masking functionality in https://github.com/mllam/weather-model-graphs/pull/34. This needs to be merged for the tests to construct the correct graph.

My idea is that this could get a quick review right now, just considering the current changes, and then we can make up a plan w.r.t. the merging or continued work on this. Don't spend time on the changes to the MEPS dataloading made here, as that will anyhow be replaced with #66.

Making a new PR for this, as this is becoming a bit bloated and this is now rebased on #90 .

For future reference this is replaced with https://github.com/mllam/neural-lam/pull/93


Allow set metadata from arguments in DataFrame.from_vineyard.

Hi guys, could we get this one merged?
Has been validated locally.

Thanks a lot!


Typo in challenge instructions: wrong hex code.

The challenge instructions have a typo:
The hex code for orange is spelled with a extra 0 en the end:
#FFAA500
The correct spelling is #FFAA50
Copy and paste from the challenge:

Make the body element's background color orange by giving it the hex code value of #FFA500

Challenge Use Hex Code to Mix Colors has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101

Firefox/45.0.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:
<style>
  body {
    background-color: #FFAA50;
  }
</style>

I don't think there's any error. The hex code #FFA500 is still orange http://www.color-hex.com/color/ffa500 Closing as not a bug on the site. Happy coding!

@amouratoglou @erictleung is correct. Also on a side note I do not see any typo with extra 0.

@erictleung
@raisedadead
Im might be wrong, but have a look to this:
If you try to complete the challenge with #FFAA500 it wont go accept it, so there is something wrong in the verification of the challenge, something is strange at least. .

@amouratoglou #FFAA500 isn't correct code that the tests are expecting. Please consult the Help Chat Room for any assistance to Coding.
Happy Coding!

Unsubscribe
On Monday, April 4, 2016, Mrugesh Mohapatra<EMAIL_ADDRESS>wrote:

@amouratoglou https://github.com/amouratoglou #FFAA500 isn't correct
code that the tests are expecting. Please consult the Help Chat Room
https://gitter.im/FreeCodeCamp/Help for any assistance to Coding.
Happy Coding!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/FreeCodeCamp/FreeCodeCamp/issues/7876#issuecomment-205252937

--
Regards,
*Justin Blankenship *

@JustinRyanBlankenship
Hello Justin!
Looks like you may have accidentally subscribed to all notifications for the FreeCodeCamp repository. To stop receiving notifications please visit the subscriptions page and select "Not watching".
We are sorry for your inconvenience!


aos mobile issue

Hi thanks for the lovely animation plugin
I disabled AOS on mobile using this

disable: 'mobile'

but still the UI broken with me all sections comes together when I scroll to the bottom

Hey @rehamwael. Can you please provide more information? What device are you using and which browser? Also what does it mean UI is broken? Can you create example codepen/sandbox or at least put some screenshots? It would be really helpful. Right know my hands are tight ;/

Maybe unrelated, but I have also noticed some small issues in Safari on iOS. Specifically using the "flip" animation. One "flipping" element seems to break the display of other elements to some extent.

I updated animations in demo/index.html and opened it on ios' safari, but it works fine. Can you provide link to the page that you experience the problem on @VinnyMo ?

The issue is related to the translate property in fade-left transitions... this is pulling space to right on mobile and let you scroll...
Screen of Issue
I found a solution to this: applying a fixed position to the initClass
initClassName: 'aos-init', // class applied after initialization
animatedClassName: 'aos-animate', // class applied on animation
so in your stlye must apply  ".aos-init:not(.aos-animated){ position:fixed} and that's all.

You might need to set overflow-x: hidden on body - it should solve the problem with content pulling space on sides. This duplicates the following issues: #234 #73 #227
v3 is still in beta, but I'll create a FAQ section there to address cases like this.
If you're experiencing any other issues on mobile please create new issue with detailed explanation and examples.

hi

The solution to this problem is exactly as follows.
html, body {    overflow-x: hidden !important;    width: 100%;  }


[TEST] This is a test deploy blocker

TEST deploy blocker, actually not a deploy blocker.
Testing: https://github.com/Expensify/App/pull/9946#issuecomment-1189360815

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Testing one more time!

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Tested well!!!


Is the routerCount definition out of loop body?

https://github.com/openthread/openthread/blob/5c8a9cb5bc28ce6f794c0d8db7189b1f2dd586ba/src/core/thread/mle_router.cpp#L4307
The routerCount is always set to 0. The peerLinkQuality always get from the first one of Route64 TLV.

@nykh2010 , thank you for raising this issue!
I believe this is a bug. I'll submit a PR with a proposed fix soon.

Just submitted #7617. Please review.


Grafana crashes: /var/lib/grafana is not writable

When running docker-compose up grafana crashes with:
grafana_1        | GF_PATHS_DATA='/var/lib/grafana' is not writable.
grafana_1        | You may have issues with file permissions, more information here: http://docs.grafana.org/installation/docker/#migration-from-a-previous-version-of-the-docker-container-to-5-1-or-later
grafana_1        | mkdir: cannot create directory '/var/lib/grafana/plugins': Permission denied

Pretty sure this is related to https://github.com/grafana/grafana-docker/issues/154

This can be solved by manually chown-ing the grafana directory on the host to 472:472, but there's got to be a better way.

Even doing a chown does not fix it. I have fsGroup: 472 runAsUser: 472 and the directories belong to 472:472

@raul1991 newer versions of grafana are using user 104  I had to chown 104:104 /data/grafana and it works with this in my docker compose:
  grafana:
    image: grafana/grafana:7.0.1
    volumes:
        - /data/grafana:/var/lib/grafana
    ports:
        - "3000:3000"
    user: "104"

@brianfeucht Thanks for.the update. Can you confirm if 472:472 works with version 6 of grafana.

@raul1991 the change to uid:104  was made in v5.1 - http://grafana.com/docs/grafana/latest/installation/docker/#migrate-to-v5-1-or-later
I did confirm that chown 472:472 /data/grafana2 works with the following docker-compose config:
  grafana:
    image: grafana/grafana:7.0.1
    volumes:
        - /data/grafana2:/var/lib/grafana
    ports:
        - "3000:3000"
    user: "472"

Hi all:
I had the same issue and solved with 2 steps:

Identified the OS user and id.
Change the docker compose.
Run docker-compos fine without errors !

Example:
    image: grafana/grafana:latest
    container_name: monitoring_grafana
    user: "1014"

The User id
drwxr-xr-x  4 grafana root 4096 Feb  5 16:45 data/
drwxr-xr-x  3 grafana root 4096 Feb  5 17:47 var/

Working Fine !

GF_PATHS_DATA='/var/lib/grafana' is not writable.
You may have issues with file permissions, more information here: http://docs.grafana.org/installation/docker/#migrate-to-v51-or-later

grafana:     image: grafana/grafana:main     container_name: grafana     user: "${UID}:${GID}"

Or try chmod that folder to the correct guid and puid user but like the answer before it should work with puid guid environment values


ignore oneof union types when parent message is ignored

Pull Request Test Coverage Report for Build 468211251

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 95.657%

Totals

Change from base Build 468146430:
0.02%

Covered Lines:
629

Relevant Lines:
647

💛  - Coveralls

Pull Request Test Coverage Report for Build 468211251

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 95.657%

Totals

Change from base Build 468146430:
0.02%

Covered Lines:
629

Relevant Lines:
647

💛  - Coveralls


V3.0.0

Coverage remained the same at ?% when pulling 1303fc2af5d550fc8d392e0cdb17e2dc2f49ad26 on v3.0.0 into 478b9c1e31ce783808b67d59a6a544972345d661 on master.

Coverage remained the same at ?% when pulling 1303fc2af5d550fc8d392e0cdb17e2dc2f49ad26 on v3.0.0 into 478b9c1e31ce783808b67d59a6a544972345d661 on master.

Coverage remained the same at ?% when pulling 1303fc2af5d550fc8d392e0cdb17e2dc2f49ad26 on v3.0.0 into 478b9c1e31ce783808b67d59a6a544972345d661 on master.

Coverage remained the same at ?% when pulling 1303fc2af5d550fc8d392e0cdb17e2dc2f49ad26 on v3.0.0 into 478b9c1e31ce783808b67d59a6a544972345d661 on master.

Coverage remained the same at ?% when pulling 1303fc2af5d550fc8d392e0cdb17e2dc2f49ad26 on v3.0.0 into 478b9c1e31ce783808b67d59a6a544972345d661 on master.

Coverage remained the same at ?% when pulling 1303fc2af5d550fc8d392e0cdb17e2dc2f49ad26 on v3.0.0 into 478b9c1e31ce783808b67d59a6a544972345d661 on master.

Coverage remained the same at ?% when pulling 1303fc2af5d550fc8d392e0cdb17e2dc2f49ad26 on v3.0.0 into 478b9c1e31ce783808b67d59a6a544972345d661 on master.


Remove requirement for teachers to have teams

Allow teachers to access the classroom page without creating a team

wait i think this is fixed already


Allow plot_graph to receive existing fig and ax objects

Currently plot_graph creates it's own axes. It would be nice to allow it to have fig and ax objects as parameters. Use cases would be to plot two graph subnetworks that don't exist as one graph object within the same figure.

In the meantime, you can compose subgraphs into a supergraph using nx.compose. If this is insufficient for your use case, please document it and feel free to open a PR!

nx.compose would indeed work to create a supergraph. However my use case would be trying to generate this plot:

I do it by using my version of plot_graph twice: one to draw the streets in thin gray, and another (taking in the previous figure) to generate the colored edges.
fig, ax = plot_graph(streets, node_size=0, edge_linewidth=0.1)
fig, ax = plot_graph(Gprime, fig=fig, ax=ax, color=color, edge_linewidth=1, show=False,
            node_size=0)

Yes, this could also be done based on your examples by creating a list comprehension that runs over edges and sets the edge widths and colors accordingly, but it seems simpler to have control over the figure and axis objects plot_graph draws on.

@temetski @guenteru this would be useful. PR welcome.

Hi,
I'm currently working on it. It just needs a bit more testing.
Will do the PR the following days.

Closing this issue here as the discussion has moved to the PR in code review.


Please update for Gnome 43

Feature Description:

Please update the extension for Gnome 43.
Thank you!

I'm working on porting the extension to GNOME 43, I'll create a PR once it's done.

Submitted for approval: https://extensions.gnome.org/review/38865
I expect to get some feedback on a few things I skipped from a review of a fork, but I can handle those when they come in (it's also possible they're a little more lenient on already existing extensions getting updates, so who knows.)
Thank you @no-comma ,  keeping the extension up-to-date with Gnome always feels like a cat and mouse game. I wish there was a world in which every Gnome release didn't completely break extensions.

Closing this since the update was accepted upstream


Disable travis jobs

Related Issue:  open-cluster-management/backlog#10511
Description of changes

Disable travis jobs for main and release-2.4.  Moving to Prow.
Test fast-forward

/hold

/unhold


Extend email format tests

Before this, a simple /@/ check passed this format test.
This now extends the test a bit more, to check that obviously invalid domains are rejected, and that local part is checked at least for something.
Symbol check + dot position check is a good indication here, because:

It's common and doesn't need implementing more complex logic (quotes etc)
Dot is the only symbol which validity depends on the position in the local part

This should trigger most of the naive implementations (e.g. /@/) and is still not hard to implement.
JSON Schema uses RFC 5322.
Refs: https://tools.ietf.org/html/rfc5322#page-17
Refs: https://tools.ietf.org/html/rfc5322#page-12
Also, some explanation for the two dots (with links to same RFC pages): https://serverfault.com/questions/395766/are-two-periods-allowed-in-the-local-part-of-an-email-address

ajv should pass all of these.

The library I checked with does not think the last two tests (space in domain; symbol in domain) are correct with respect to RFC 2822.

The library I checked with does not think the last two tests (space in domain; symbol in domain) are correct with respect to RFC 2822.

But they are listed there with valid: false, so that's as it should be?

No, I mean that the library thinks those two cases are valid emails.

Ah, I misread, sorry.
Reading RFC 5322, it does indeed seem that & in the domain part is allowed (which is strange, I would say).
Space shouldn't be allowed though.
But I will remove both to be on the safe side.

Before this, a simple /@/ check passed this format test.

FWIW this is exactly how my implementation implements the email checker as well :) (and will continue to do so) -- though as I've said in #253 I'm fine with other folks adding more tests here obviously, those of us who don't want to implement more strict email format verification will just skip the new ones.

My two cents: email parsing, much more so than hostnames, are hard to parse well, and I wouldn't include any false tests here. Yes, the tests you have here are technically valid, and yes, they follow the RFCs, but email is notoriously "flexible".
Note that even checking for the presence of a "@" is technically wrong because the escaped form, "@" is allowed inside the local-part. And don't get me started on the dot-separated "quoted-string OR atom" form in obs-local-part.

@ssilverman I don't think that \@ is allowed per RFC 5322?
And this purposely excludes any tests for quoted strings.

wouldn't include any false tests here

Then email format should be removed from the spec alltogether, if users can't assume that it return false on at least something.

I don't disagree that test sets should contain false tests. I just think they make life complicated specifically for emails. This is just my opinion and two cents.
Per the link in my comment (RFC 3696, Section 3), the following emails are valid:

Unquoted form: Abc<EMAIL_ADDRESS>Quoted form: "Abc<EMAIL_ADDRESS>
Emails get very messy to parse "properly".

I'll add, regarding backslash-escapes from RFC 5322, just to illustrate that it gets messy:

local-part can contain obs-local-part which can contain _word_s.
_word_s are either _atom_s or _quoted-string_s.
_quoted-string_s may contain qtext or _quoted_pair_s.
And, if you continue going down into the grammar, you'll find that VCHARs include the '@' character. So now, you can have backslash-escaped '@' characters inside quoted strings.

To me, I interpret that RFC 5322 flips what are valid emails with backslash-escapes. They can appear inside quoted strings, just like RFC 2822 allows (heck, I don't even think that they're allowed outside quoted strings there, unlike what RFC 3696 mentions).
Grammars are certainly "fun". :)

For posterity, here was the regex I used until recently: ^[^@]+@[^@]+$.
Here's the regex I use  now: ^.*[^\\]@[^@]+$
Double-yuck.


introducing project mode

First commit extracts a Renderer class from Worker.
Not only Worker is huge and does a lot, but the new class greatly simplifies rendering the template for each project-mode item in the next commit.
The idea behind it was that it encapsulates the template and accepts answers to render the output.
I decided to leave _allow_render in Worker and pass it as a function argument, as it uses data stored in Worker. Let me know if you can think of a better way to split responsibility between those two.
Add looping over items

accept _items in copier.yaml as either a string or a list of strings. Internally it's always a list.
use each key to read a list of items from answers, and render its part of the template, stored under {{template_root}}/{{key}}
So if you have _items: ['a'], copier expects an answer a to be a list of values, and uses each value to render a sub-template stored in 'a'.
all directories under root ,that are named like the keys under _items are excluded from normal rendering.

Not sure how to structure the documentation. Needs changes to both the template and configuration parts. Shell I create a new file for the project mode?
If nobody minds, I'd like to disable the "identical" message for directories. I'm getting it a hundred of times when run in a loop and it doesn't do anything useful for directories.

example template: https://github.com/python-lapidary/lapidary-template/tree/test2

For me these tests fail on master as well

They pass for me on master, and CI seems happy, too. :thinking:

A couple of thoughts from my side:
1. If you think that the `main.Worker` class does too much and it would be better to factor out the rendering methods into `renderer.Renderer`, I suggest to do this refactoring in a dedicated PR to separate concerns and ease the review. In any case, @yajo will need to decide whether he likes the refactoring.

Yeah, I thought it's easier to change from a single PR to multiple, than the other way around

2. From a template creator's perspective, I find it a bit unexpected that the files in the folder marked via `_items` are merged in the target folder. For instance, in `test_render_items_list()` the files in both `src/apples/` and `src/oranges/` are generated to `<dst>/` and not to `<dst>/apples/` and `<dst>/oranges/`, respectively. I imagine there are technical reasons for this behavior, but the point of declarative project templates is to make the them readable and close to the generated project. Arguably, [generating a directory structure](https://copier.readthedocs.io/en/latest/configuring/#generating-a-directory-structure) is also in violation of this goal, but in that case the benefits outweigh the loss in readability IMO, and at least there is no implicit magic unlike the implicit merging of the `src/apples/` and `src/oranges/` folders.

The first version I did was with only one items list and without the directory. In result, all files and directories under the template root had to be named with a condition ({% if _item %} or {% if not _item %}). I found that hard to read.
With multiple item lists it gets slightly worse.
Those directories are already treated specially - their contents is rendered once for every item. I would find it weird if they were copied over to the output, but I guess it's just a matter of expectations of a new user of Copier vs a seasoned one.
I'd rather not add it as a flag, bc removing the directories IMO would be more reasonable default, but not what older users might expect.
How about those directories go to _subtemplates directory to signify their special treatment?
e.g. src/_subtemplates/apples/* -> dst/*

3. I'm a bit confused by `test_render_items_conditional()`. The behavior tested there seems to equivalent to using a dynamic [subdirectory](https://copier.readthedocs.io/en/latest/configuring/#subdirectory). The only difference is the usage of the new special variable `_item`. Is the goal of this test case to test the rendering of dict items?

Good catch. It's from the previous version, updated a bit thoughtlessly.

4. There was some minor discussion about nested loops in #908. Would nested loops be possible with the current design? If yes, could you add a test case? I am vaguely worried that the current design might not be sufficiently flexible to address more advanced cases because the rendering context is only the main context plus the current item's data, but with nested loops the context from the parent loop seems to be unavailable in a child loop.

You're referring to this. I never intended to implement it due to exponential complexity of such templates.
Considering the goal of this change (generating SDK or class model from a machine readable description), I'd say nested loops are out of scope. If you're generating a class model, you have a single list of table definitions or JSON schemas to generate classes for - that's a single list. In case of SDK for OpenAPI, you have a bunch of schemas and operations, that's two lists, processed in parallel. All that assuming your model is large enough to render it as multiple files, otherwise you don't even need project mode.
Do you have a use case in mind?

For me these tests fail on master as well

The tests mostly pass on an identical environment in my fork.
https://github.com/python-lapidary/copier/actions/runs/4333218244

@yajo Any idea how to progress with this?

Oh and regarding the refactor... no problem with it.

@yajo Have you seen my comment in the other discussion about this topic? https://github.com/copier-org/copier/discussions/908#discussioncomment-5466993 I think that approach would cover a broader range of scenarios with more intuitive API. WDYT?

I like that design but i think it can be hard to implement. Gotta think
about this deeply.
El vie., 7 abr. 2023 11:02, Sigurd Spieckermann @.***>
escribió:

@yajo https://github.com/yajo Have you seen my comment in the other
discussion about this topic? #908 (comment)
https://github.com/copier-org/copier/discussions/908#discussioncomment-5466993
I think that approach would cover a broader range of scenarios with more
intuitive API. WDYT?
—
Reply to this email directly, view it on GitHub
https://github.com/copier-org/copier/pull/1022#issuecomment-1500140713,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHNXDPFB7OYJHTM6SSJRLDW77Q4PANCNFSM6AAAAAAVP3DKX4
.
You are receiving this because you were mentioned.Message ID:
@.***>


Billing portal session

Would it be possible to create a billing portal session?
https://stripe.com/docs/billing/subscriptions/integrating-customer-portal#redirect

Follow instruction here: https://github.com/oscarychen/drf-stripe-subscription#stripe-customer-portal


Add the steps to build this project, so that contributors can easily work on this without wasting the time on figuring out that

Please assign this task , as I have lot of knowledge regarding API's it would be cake walk for me.

Good Evening, kindly assign this task to me, as I'm well experienced with python and API's.

Good Afternoon @SAISUPRIYAPAVARALA ,
I would like to explore this by understanding, learning all about this project. Kindly, assign me this task.

@SAISUPRIYAPAVARALA @Jashwanth05 @yashika-ishi @Shambhavee11
The Readme and Contributing guide have been updated. Please go through it and follow all steps in the process that is mentioned.


Added Introduction to Theory of Computation by Anil Maheshwari and Michiel Smid

What does this PR do?
Add resource
For resources
This is the download page for the paper (and PDF) version of the book Introduction to Theory of Computation by Anil Maheshwari and Michiel Smid.
Why is this valuable (or not)?
This book covers important theories and concepts related to theory of computation.
How do we know it's really free?
This book is provided by Carleton University, Ottawa, Canada.
For book lists, is it a book? For course lists, is it a course? etc.
It is a book.
Checklist:

[X] Read our contributing guidelines.
[X] Search for duplicates.
[X] Include author(s) and platform where appropriate.
[X] Put lists in alphabetical order, correct spacing.
[X] Add needed indications (PDF, access notes, under construction).
[X] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

wouldn't this fit better into "Theoretical Computer Science"?

According to me, "Mathematics" is more relevant section than "Theoretical Computer Science".
There is already this book present in "Theoretical Computer Science" section.
So you can close this pull request if you want.


I already seed, but the result also show difference.

could you provide how different are the results?

I encountered the same issue while trying to reproduce the result from hellokan.ipynb. Here are the results with exactly the same setting (I output the result right after the auto_symbolic function) :

Relate: https://github.com/KindXiaoming/pykan/issues/258


Indoor temperature

It would be great to see both the set target temperature and the actual room temperature.
I have an additional thermal sensor. It has ID BT50 and measures the current room temperature.

Plus one would be useful

Hi, thank you for your input. I will implement it for sure. However, it will be next month because the beginning of this year is very busy for me.

@owenselles mentioned also a possibility to change the indoor temperature via this sensor.

Is there any update on this :) ?

I also would greatly appreciate if this would be added. In ideal situation Homekit sees it as a thermostat accessory. Thnx :)


add feature middleware

Coverage decreased (-0.05%) to 96.85% when pulling c5cd3fe81fcd03f143256868015f052382e4d40e on middleware into d5917698e4ac3c2190087cad46b9f68392eaf0a0 on master.


(index):72 Uncaught ReferenceError: $ is not defined

new webpack.ProvidePlugin({ $: 'jquery',
                            jQuery: 'jquery' }),

new webpack.ProvidePlugin({ '$': 'jquery',                             jQuery: 'jquery' }),

I was getting the same error using the eonasdan-bootstrap-datetimepicker widget.
I tried several things, including adding the last two lines here to the ProvidePlugin section of webpack.config.js:
    new webpack.ProvidePlugin({ $: 'jquery',
                                jQuery: 'jquery',
                                'window.$': 'jquery',
                                'window.jQuery': 'jquery' }),

The only thing that actually worked, however, was changing require('jquery'); in main.js to this:
window.$ = window.jQuery = require('jquery');

This might not be ideal, though. Does anyone have a better solution?

I was able to get this resolved by adding the expose-loader, and specifying this as the loader in the exports:
npm i expose-loader -s
And then in
module: {
  loaders {
    ...
    { test: require.resolve('jquery'), loaders: ['expose-loader?$', 'expose-loader?jQuery'] },

This worked for me and seems like a much cleaner solution.
Thanks, @dylanjnz !

Closing, as this issue is stale. Feel free to reopen or comment if there's still an issue.


responsive navbar added

Could you attach screenshots so we can see the changes visually

I see that you have included a package-lock.json in your commit. We use pnpm on this project and i think you used npm to install the packages so can you remove the package-lock.json from your commit.

alright i will remove it

The nav is only visible in small screens right and can you turn the dropdown into an element that covers the full page and lists the links.


Only check if a document has been modified while loading diagnostics during publishDiagnostics

I was seeing some of these errors in VS Code, which uses the pull diagnostics request even though I couldn’t see any concurrent modifications to the document. Move the check up to publishDiagnostics, where it belongs, and log the version of the old and new document version so we can investiage what’s causing the issue.

@swift-ci Please test

@swift-ci Please test Windows

@swift-ci Please test Windows

@swift-ci Please test Windows

@swift-ci Please test Windows

@swift-ci Please test Windows

@swift-ci Please test w

@swift-ci Please test Windows

@swift-ci Please test Windows

@swift-ci Please clean test Windows


Simple bug fixes

Simple fix for action_space not defined in the newest versions of gym.
Simple fix in info.py to get all the environments.

Some checks raised the following error:
ModuleNotFoundError: No module named 'scipy'
which is coming from neurogym.envs.spatialsuppressmotion.SpatialSuppressMotion.
The problem is that scipy is not specified in setup.py, and so it is not installed before running the tests.

In the latest gym, action_space is no more initialized to None in the base class Env. It has to be defined in the child classes.
My comment above is related to these failing tests.

Let's take neurogym.envs.spatialsuppressmotion.SpatialSuppressMotion out of the set of envs used to run the tests then?

Do I remove this env completely from the NATIVE_ALLOW_LIST in neurogym.envs.registration since it requires a library that is not a requirement of neurogym?

This is what is used to get a list of all the environments when running the tests

I think removing from NATIVE_ALLOW_LIST is fine for now. In the long run, we'll probably need to add a try-except to catch module not found errors


THC.h includes THCGeneral.h, does not exist

I tried to change THCGeneral.c / THCGeneral.h.in to .h but it didnt work, I'm not sure if the file was renamed or deleted, but it's missing.

I have the same problem when I am compiling libcuda_utils.so in macOS sierra 10.12.1.

I'm not exactly sure what you are trying to accomplish -- could you describe in some more detail?
THCGeneral.h should be generated by the build, you shouldn't have to rename anything.

I think I find my problem .That is the real THCGeneral.h is located in torch/install/include/THC after we execute torch update.sh script(located in torch source dir) ,not the file THCGeneral.h.in located in torch/extra/cutorch/lib/THC .
That's the reason why we should't rename the file THCGeneral.h.in located in torch/extra/cutorch/lib/THC


lyxal: Watch wikihoo.com

lyxal requests the watch of the watch_keyword wikihoo\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

wikihoo\.com has been seen in 2 true positives, 1 false positive, and 0 NAAs.

Approved by cigien in Charcoal HQ


Added Everest Engineering College name and domain urls

Everest Engineering College was formerly recognized as Everest Engineering College. This institution is providing  IT and Computer related  Bachelors of Engineering degrees since 2001 A.D. I am applying so that i can get my student license and use these awesome IDEs.
https://www.eemc.edu.np/contact

@manojpudasaini First stage of verification passed, official domain is eemc.edu.np as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@philipto Thank you !

@manojpudasaini Thank you for your patience while waiting for a review and processing your request. Pull request merged.

@manojpudasaini Thank you for your patience while waiting for a review and processing your request. Pull request merged.

Thank you so much for your help!


What is the corret syntax for dropzoneOptions? (upload options ignored)

I'm trying to send several options such as file size, max nb of files, etc but these options seems to be completly ignored. Here are the parameters I'm testing:
dropzoneOptions: {     acceptedFiles: ".jpg, .jpeg, .png",     maxFilesize: 10000,     maxFiles: 3, }
<vue-dropzone :options="dropzoneOptions"></vue-dropzone>

That indeed seems correct and aligns with how we do it in all the demos.


chore(VariantGenotypeQualityMetrics): make more dry

This PR contains a small refactor of VariantGenotypeQualityMetrics.tsc to make it more DRY (related to issue #1154).
I have just changed my dev environment (from Linux to MacOS), and am having issues running the tests, but a visual check comparing the Broad-deployed Variant page chart against a locally-served version of the page suggests that the functionality is the same for an ad-hoc selection of variants. I figured this would be good enough for you to give it an initial review while I sort out running the tests.
Of course, happy to hear any feedback - don't hold back with suggestions! Similarly, as per discussion in #1154,
if this seems like it will be more hassle for you than it is worth then feel free to ask me to stop :)

@rileyhgrant - FYI

Thanks @rileyhgrant, Happy New Year to you too :) :tada:
I've addressed your comments by:

changing the interface declaration to type;
updating the snapshots; and,
making changes to get eslint passing.

Let me know if there are other changes you'd like to see.

Ah I see the CI has failed (and I forgot to go through /.github/workflows/browser-ci.yml like you suggested). I'll look at this today.

Thanks for your continued work and your patience on this one @ignatiusm.
I'll plan on adding better documentation on running the test suite that the frontend CI goes through locally, so that the back and forth can be avoided a bit in the future.

"All checks have passed" :tada: Can you please review my recent changes @rileyhgrant? Getting closer :smile:

Thanks @rileyhgrant ! Is it okay for me to work through that priority list in #1154? I'll create a separate PR for each item. Plus I know how to run the tests now, so reviewing should be easier :laughing:

Thanks @rileyhgrant ! Is it okay for me to work through that priority list in #1154? I'll create a separate PR for logical block of refactors (e.g. there are a few related to the ShortTandemRepeat page and it's components). Plus I know how to run the tests now, so reviewing should be easier 😆

Yes, if you're willing, absolutely! :)


Media: Fix conflict with Safe SVG plugin

Summary
Both safe svg and svg support do not filter mime_types, which makes uploading via the editor fail.
Relevant Technical Choices

To-do

User-facing changes
Testing Instructions

Fixes #6003

3 test failures: https://github.com/google/web-stories-wp/pull/6017/checks?check_run_id=1751273079#step:15:47

3 test failures: https://github.com/google/web-stories-wp/pull/6017/checks?check_run_id=1751273079#step:15:47


Net: Hardfault when combining offloaded and non offloaded network interfaces

Describe the bug
When using multiple network interfaces some of which use CONFIG_NET_OFFLOAD, non offloaded interfaces cause a hardfault when attempting to open TCP connections using posix sockets (connect specifically). The network interfaces in my case are the eth_mcux (NXP's ethernet driver) and esp_at (the at command based wifi driver for espressif's ESP-AT firmware).
the function net_if_is_ip_offloaded is passed a NULL iface value which causes the code inside the function:
return (iface->if_dev->offload != NULL);
To attempt to accesss a member of a NULL pointer which triggers a fault.
In the fault callstack when net_context_recv is called NULL is passed into net_if_is_ip_offloaded because its argument is provided by net_context_get_iface which returns NULL when the specified network context has an interface value of -1 for non offloaded contexts at this stage in the posix transaction (I do not know if this is incorrect behaviour).
My current work around is to introduce NULL checks inside net_if_is_ip_offloaded as below:
if(NULL == iface) return false;
if(NULL == iface->if_dev) return false;
return (iface->if_dev->offload != NULL);

To Reproduce
As far as I am aware this bug is not possible to encounter using any of the supported board without using an overaly as none of the supported board include multiple network interfaces of differing types. In my case I am using custom hardware with a custom board file. So for this reason it is not practical to reproduce as you would need to create a setup with an NXP ethernet and some kind of offloaded interface which requires the CONFIG_NET_OFFLOAD config.
Expected behavior
POSIX connect to return success, no hard fault.
Impact
Preventing usage of virgin zephyr, I am currently relying on local file edits to make the firmware function, I am aware of no out of tree solution.
Logs and console output
Code used to produce this log attempts to perform a posix socket connect operation to a server after ~10 seconds.
[00:00:01.349,000] <inf> COR_NET_MAIN: Interface 'Ethernet' is up
[00:00:01.349,000] <inf> COR_NET_MAIN: Interface 'Wi-Fi' is up
Connected
[00:00:03.504,000] <inf> eth_mcux: ETH_0 enabled 10M full-duplex mode.
[00:00:03.510,000] <inf> net_dhcpv4: Received: <IP_ADDRESS>
[00:00:03.510,000] <inf> net_config: IPv4 address: <IP_ADDRESS>
[00:00:03.510,000] <inf> net_config: Lease time: 172800 seconds
[00:00:03.510,000] <inf> net_config: Subnet: <IP_ADDRESS>
[00:00:03.511,000] <inf> net_config: Router: <IP_ADDRESS>
[00:00:03.658,000] <inf> net_config: IPv4 address: <IP_ADDRESS>
[00:00:03.658,000] <inf> net_config: Lease time: 0 seconds
[00:00:03.658,000] <inf> net_config: Subnet: <IP_ADDRESS>
[00:00:03.658,000] <inf> net_config: Router: <IP_ADDRESS>
[00:00:11.350,000] <err> os: ***** BUS FAULT *****
[00:00:11.350,000] <err> os:   Precise data bus error
[00:00:11.350,000] <err> os:   BFAR Address: 0xb083b548
[00:00:11.350,000] <err> os: r0/a1:  0x00000000  r1/a2:  0x00000001  r2/a3:  0x80014938
[00:00:11.350,000] <err> os: r3/a4:  0xb083b530 r12/ip:  0x80014128 r14/lr:  0x60067bbb
[00:00:11.350,000] <err> os:  xpsr:  0x610f0000
[00:00:11.350,000] <err> os: Faulting instruction address (r15/pc): 0x60068284
[00:00:11.350,000] <err> os: >>> ZEPHYR FATAL ERROR 25: Unknown error on CPU 0
[00:00:11.350,000] <err> os: Current thread: 0x80014938 (unknown)
[00:00:11.351,000] <err> os: Halting system

Environment (please complete the following information):

OS: Windows
Toolchain: Zephyr SDK 0.16.3
Commit SHA or Version used: zephyr-v3.4.0 (356c8cbe63ae01b3ab438382639d25bb418a0213)

This is fixed by commit 32bd3aa781523009332f7e102fdd555cf740acdc in 3.5

The relevant PR is #61215
I added there the backport label.

Awesome, thanks guys, I feel a bit silly now wasting time writing up this whole thing.
Thanks for adding the backport request, but I will do my best to migrate to 3.5 anyhow.


Coveralls.io Integration

This provides the necessary configuration via karma to publish coverage results to coveralls.io (pending some environment config by @kentcdodds for coveralls.io authentication).  In addition, a new test coverage badge is being added to the README.  Fixes #78

Changes Unknown when pulling 6178fadbe8258164c09df419047c6628c780fca6 on sparty02:coveralls into ** on formly-js:master**.

Looking at the report it's actually only reporting on the index.test.js file which contains all of angular, api-check, and angular-mocks, as well as angular-formly... Do you know of any way to make the coverage plugin leverage sourcemaps or something to make sure that 1) we're only reporting coverage for angular-formly files and 2) it reports coverage for the specific files, not just the entry file?

I'll take a peek at this and circle back!

Thanks! You're awesome! :-)
-Kent C. Dodds
On Thu, Apr 16, 2015 at 11:29 PM, Ryan Dunckel<EMAIL_ADDRESS>wrote:

I'll take a peek at this and circle back!
—
Reply to this email directly or view it on GitHub
https://github.com/formly-js/angular-formly/pull/250#issuecomment-93896209
.

I think I've figured out a way to get coverage to exclude non-library related files. I tried it out in angular-scope-types (WIP). Just need to take the time to do it in angular-formly.

Finally done!


[AutoPR billing/resource-manager] Corrected the enum value to match it with actual implementation

Created to sync https://github.com/Azure/azure-rest-api-specs/pull/7782

(message created by the CI based on PR content)

This PR has been merged into https://github.com/Azure/azure-sdk-for-python/pull/8613


Update icon: Facebook

URL of the site or app (required): https://www.facebook.com/
Logo resources for the icon (optional, but recommended): https://en.facebookbrand.com/facebookapp/assets/f-logo?audience=landing

Facebook's brand has changed to the more vibrant blue logo quite a while ago (2019), the icon should be updated to reflect this.

Fixed!
For current Aegis:
https://github.com/aegis-icons/aegis-icons/blob/master/PNG/Facebook v2.png
For Aegis beta version:
https://github.com/aegis-icons/aegis-icons/blob/master/PNG/Facebook v2.svg


panic: websocket: close 1006 (abnormal closure): unexpected EOF

Periodically I see this error in my terminal and my connection closes:
panic: websocket: close 1006 (abnormal closure): unexpected EOF

goroutine 1 [running]:
main.(*WebTerm).Run(0xc4201ed8a0)
	/home/jsdevel/.gvm/pkgsets/go1.8/global/src/github.com/fangli/rancherssh/main.go:141 +0x13c
main.main()
	/home/jsdevel/.gvm/pkgsets/go1.8/global/src/github.com/fangli/rancherssh/main.go:308 +0x11d

This same behavior exists in the web UI shell when I have a long running process that neglects stdout.  Anytime a process logs to stdout on a frequent basis I don't have this problem.  Could there be a setting I need to set in rancher?

Possible solution here.

The cattle machines I'm connecting to reside behind ELB which has a default idle timeout of 60 seconds.  Increasing the timeout there isn't really an option because it also means opening up the timeout for HTTP requests as well which I don't want.
Is is possible for rancherssh to "tickle" the connection to keep it open?  Perhaps send a null character every 10 seconds or so?


fixing incompatibility with new gem version

Changes in passing parameters to new ovirt-engine-sdk version.

@borod108 is this the only fix? or is there more coming?
@miq-bot assign durandom
@miq-bot add_labels euwe/yes, providers/rhevm

checked with @borod108 that this is the only fix on manageiq side. the other will come in via the ovirt gem.
@miq-bot assign blomquisg
@blomquisg please merge

@blomquisg @durandom the test does not fail locally, any idea? I would really like to have this in.

Unrelated test failure.  Merging.

Euwe Backport details:
$ git log -1
commit cd366b6b53ff82665093a3687003d6ea547ef473
Author: Oleg Barenboim<EMAIL_ADDRESS>Date:   Fri Oct 14 12:31:08 2016 -0400

    Merge pull request #11933 from borod108/bug/changes_for_new_ovirt_sdk_gem

    fixing incompatibility with new gem version
    (cherry picked from commit 64d932aa8e56efa1a7eaa80f290a3f858809ed7e)


A runtimeerror occured

There is a runtimeerror when i run test_simple.py or evaluate_depth.py, i donot know what exactly wrong, and my torch==2.1.2+cu118

Please make sure that you load the correct checkpoint.

Yes, tried the checkpoints, not every one can work

Obviously this is a mismatch between the checkpoint and the model you are using. What arguments did you use to run the script?

Ohhhhh no, I forgot set --model, thanks for your sincerely help


Allow user customization of colors

I would like this feature too. I use a dark theme on my linux machine and Eclipse overall respects it but the commander windows do not.
Maybe its possible to just use colors from the system theme (at least on linux)?


added docs for telemetry and diagcfg

Added documentation for telemetry configuration behavior and for diagcfg CLI.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.William Jurayj seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.