[BUG]: PublishCodeCoverageResults@2 Error occured while parsing coverage files. System.InvalidOperationException: Nullable object must have a value.

New issue checklist

[x] I searched for existing GitHub issues
[x] I read pipeline troubleshooting guide
[x] I checked how to collect logs

Task name
PublishCodeCoverageResults
Task version
2.248.3
Issue Description
Publishing code coverage stopped working in version 2.248.3 with error Error occured while parsing coverage files. System.InvalidOperationException: Nullable object must have a value.
I have a build from a couple of days ago which worked and was using version 2.242.1 of the task. Running the pipeline from the exact same commit today fails with the only difference being the new task version.
Environment type (Please select at least one enviroment where you face this issue)

[ ] Self-Hosted
[x] Microsoft Hosted
[ ] VMSS Pool
[ ] Container

Azure DevOps Server type
dev.azure.com (formerly visualstudio.com)
Azure DevOps Server Version (if applicable)
No response
Operation system
ubuntu-latest
Relevant log output
2024-11-19T13:59:02: Creating report 621/622 (Assembly: MyModule.Application, Class: MyModule.Application.MyModuleApplicationAssemblyMarker)
2024-11-19T13:59:02: Writing report file 'MyModule.Application_MyModuleApplicationAssemblyMarker.html'
2024-11-19T13:59:02: Creating report 622/622 (Assembly: MyModule.Application, Class: MyModule.Application.MyModuleMappingProfile)
2024-11-19T13:59:02: Writing report file 'MyModule.Application_MyModuleMappingProfile.html'
2024-11-19T13:59:02: Creating summary
2024-11-19T13:59:02: Writing report file '/home/vsts/work/_temp/5011078a-bc1a-4766-afe9-f0f7048b5a65/index.html'
##[error]Error occured while parsing coverage files. System.InvalidOperationException: Nullable object must have a value.
   at System.Nullable`1.get_Value()
   at Microsoft.Azure.Pipelines.CoveragePublisher.Parsers.ReportGeneratorTool.GetFileCoverageInfos() in D:\a\1\s\src\CoveragePublisher\Parsers\CoverageParserTools\ReportGeneratorTool.cs:line 63
   at Microsoft.Azure.Pipelines.CoveragePublisher.Parsers.Parser.GetFileCoverageInfos() in D:\a\1\s\src\CoveragePublisher\Parsers\Parser.cs:line 35

Full task logs with system.debug enabled
No response
Repro steps

I notice the Microsoft Hosted Agents have reverted the task version back to 2.248.1, which does not seem to have this issue.

We've seen the same issue today in production, and have also seen since that the task version has been reverted back to 2.248.1, fixing our build.
I think this issue however can probably be closed, it looks like the fix for this went in 4 days ago in !79 in this commit

Task version is reverted to 2.248.1, which does not have the issue.


Update the current team asap

Following changes are required:

[ ] Move the 2020 batch to the alumi portion.
[ ] Update cards for the current GS and Treasurer. GS - Suryansh Gupta, Treasurer - Arijit Saha
[ ] Update professor in charge. Prof. Shyamalendu kandar, IT
[ ] Update rest of the club members with 2021 and 2022 batch.

@indrarahul2013 Can you merge the PR once it's in?
Professor in charge has asked us to update it and let him know the link asap.
The new website is in progress. Once it is done, we hope to replace this
with the new nuxt based web app.

@raydwaipayan Sure, I will merge the PR. I am sure @suri-kumkaran has also the permission to merge PRs.

Merged the PR.


Allow Alpha Numberic Chracters for Single Attribute Types

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!


Last day in month

Write your question here
Hi Vašek (ahoj Vašku),
how to configure "last friday of every month" as some month is in 4th week and some in 5th week.
Thanks

I am afraid  I do not have an option for 'last Friday'. How about creating a regular 'first Friday' of every month, and then create a template sensor with next_date - 7 days?


Re-adding the windows snapshot with new changes

Description
Re-adding the windows snapshot with new changes
Issues Resolved
https://github.com/opensearch-project/opensearch-build/issues/2306
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2550 (0523d82) into main (b657fba) will increase coverage by 5.60%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #2550      +/-   ##
=============================================
+ Coverage     94.39%   100.00%   +5.60%
=============================================
  Files           219         6     -213
  Lines          4462       105    -4357
  Branches         29        19      -10
=============================================
- Hits           4212       105    -4107
+ Misses          244         0     -244
+ Partials          6         0       -6

Impacted Files
Coverage Δ

src/system/temporary_directory.py

src/manifests/input_manifests.py

src/sign_workflow/sign_args.py

...est_workflow/perf_test/perf_single_node_cluster.py

src/test_workflow/dependency_installer.py

tests/jenkins/jobs/InputManifest_Jenkinsfile

tests/jenkins/jobs/UploadTestResults_Jenkinsfile

src/manifests/test_manifest.py

..._workflow/perf_test/perf_test_runner_opensearch.py

src/manifests/build/build_manifest_1_0.py

... and 203 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


adding specific errors to saga log

Callers need to be able to distinguish between error types, so they know if its transient error i.e. log writes temporarily unavailable or illegal state update.  Test cases updated to check for specific error
Also practicing what I preach In Simple Test Cases Can Prevent Most Critical Failures one of the big discoveries that aborting on overly generic errors / poor error handling resulted in many catastrophic failures in distributed systems.

[Current coverage][cc-pull] is 35.27%

Merging [#39][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.06%

@@             master        #39   diff @@
==========================================
  Files            35         36     +1
  Lines          1576       1596    +20
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            557        563     +6
- Misses          995       1009    +14
  Partials         24         24

Powered by Codecov. Last updated by [b60f8ea...cea6d60][cc-compare]
[cc-base-branch]: https://codecov.io/gh/scootdev/scoot/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/scootdev/scoot/compare/b60f8eaa84c679b8f9e71c7d7ee568f0c0acbf6d...cea6d607d2d77409467a93bfe12e99a8101ec5b0
[cc-pull]: https://codecov.io/gh/scootdev/scoot/pull/39?src=pr

LGTM


Fixed Syntax error in New-ThrottlingPolicy.md

fixed a missing dash in PowerShell Command of Example 3

Docs Build status updates of commit 0261b5a:
:clock10: Full build: the average full build time is 14 min(s) 16 sec(s), this is based on the last 216 build(s) for this repository.

Docs Build status updates of commit 0261b5a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/server-health-and-performance/New-ThrottlingPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit cfe0330:
:clock10: Full build: the average full build time is 14 min(s) 15 sec(s), this is based on the last 218 build(s) for this repository.

Docs Build status updates of commit cfe0330:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/server-health-and-performance/New-ThrottlingPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 80d4085:
:clock10: Full build: the average full build time is 14 min(s) 15 sec(s), this is based on the last 224 build(s) for this repository.

Docs Build status updates of commit 80d4085:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/server-health-and-performance/New-ThrottlingPolicy.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Irregular circle(polygon-like) rendered in linux.

I just ran the example code from getting started page, and here is the circle that i got -

One question - why is it looking more like a polygon and less like a circle? What can i do to make it look more like a  circle?

Please follow the contribution guidelines, which you have been linked to when opening this issue, and post such questions on the forum. We like to keep this tracker for confirmed bugs and features only.
You may find the documentation an interesting read regarding your questions.


Broken link - Overview 2. Virtual User License

Obtain a free Phone System - Virtual User license or a paid Phone System license to use with the resource account.

https://docs.microsoft.com/en-us/MicrosoftTeams/teams-add-on-licensing/virtual-user.md
Hyperlink is broken = 404 - Page not found

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e0703860-c3db-c723-317f-7fab164c006d
Version Independent ID: c6384e2b-ac37-265d-8c33-f004eca97673
Content: Configure a resource account in Skype for Business Server 2019
Content Source: Skype/SfbHybrid/hybrid/configure-onprem-ra.md
Product: skype-for-business-itpro
GitHub Login: @jambirk
Microsoft Alias: jambirk

fixed in https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/commit/eba0ad472f55156c80e56ae8171be4e381018309#diff-0d26df467624d373d8cfa1b28c8c0595


Enable builds without direct torch.cuda availability and support sm89 / sm90.

This PR allows for monarch_cuda kernel to be built for computes sm80, sm89, and sm90, which includes the following GPUs:

A100
H100
L40
RTX 6000 Ada

Additionally the setup.py is updated to enable builds based on nvcc availability but without direct torch.cuda availability for flexible builds.
Update:
The compiler flags have been abstracted to support both PTX and SASS builds while defaulting to the original Ampere-based PTX-only build i.e. -gencode=arch=compute_80,code=compute_80.
Successfully tested by building a docker image and running tests under tests/:

It looks like this PR is introducing some race conditions - when I install using this branch, some tests fail:
pytest -s -q tests/test_flashfftconv.py
Running 1120 items in this shard
......................................................................................................................................................................................................................
F.....................................................................................................................................................................................................................
................................................................F.F...F...............................................................................................................................................
......................................................................................................................................................................................................................
......................................................................................................................................................................................................................
..................................................

@wanderingai Love this PR, its a improvement from the previous setup.py. Can this be merged, worst case with no sm_90 flags by default?


Docker DinD and Swarm initialization

Hi,
Does Docker DinD initialize Swarm by default?
I need to set force_new_cluster to true on cluster initialization by API, even after rebuilding the service. I am not sure what is causing the issue.
docker-engine: 19.03.12, build 48a66213fe
DinD container image: 19.03.12-dind
docker-py: 4.3.1

Thanks.

Swam isn't initialized by default but it can be with docker swarm init
$ docker run -d --name dind --rm --privileged docker:dind
9764dd889f6754fe79802c76e24f666d477d3e82ce0338fdd39228d2ee73ed07

$ curl --unix-socket /var/run/docker.sock http:/v1.40/containers/dind/exec -X POST -H "Content-Type: application/json" -d '{ "AttachStdout": true, "AttachStderr": true, "AttachStdin": true, "Tty": true, "Cmd": [ "docker", "swarm", "init", "--force-new-cluster" ]}'
{"Id":"d49f78baea35cc3e1b862015870cffdfd277780524346700495dc19eacc5ae51"}

$ docker exec dind docker swarm join-token manager
Error response from daemon: This node is not a swarm manager. Use "docker swarm init" or "docker swarm join" to connect this node to swarm and try again.

Swarm isn't initialized, so start the exec instance https://docs.docker.com/engine/api/v1.40/#operation/ExecStart
$ curl --unix-socket /var/run/docker.sock http:/v1.40/exec/5438766e6bbd42e83968edc05ecbe13ecea299fc01890c4a6c01f2aa09e05552/start -X POST -H "Content-Type: application/json" -d '{
  "Detach": false,
  "Tty": true
}'
Swarm initialized: current node (wktzerfyocz1mlf4lpwqxpogr) is now a manager.

To add a worker to this swarm, run the following command:

    docker swarm join --token SWMTKN-1-0njc1fckiii4uzddyxr5r904glb64qst6ucjo8qwomtfvme6c8-8fbwmjdkib5ueq999bx3h1nqm <IP_ADDRESS>:2377

To add a manager to this swarm, run 'docker swarm join-token manager' and follow the instructions.

$ docker exec dind docker swarm join-token manager
To add a manager to this swarm, run the following command:

    docker swarm join --token SWMTKN-1-0njc1fckiii4uzddyxr5r904glb64qst6ucjo8qwomtfvme6c8-a66i78c2n9hjxpd25catd3yiq <IP_ADDRESS>:2377

Thanks @wglambert.


190 dev package agentlogging in py4jps

This PR packaged agentlogging from TheWorldAvatar/Agents/utils/python-utils in py4jps and released version 1.0.29 to both PyPI and TestPyPI. Package pyderivationagent is also updated and released as 1.4.0.

Did you simply copy (and hence duplicate) the logging code into py4jps? I can't see any deletions. I'm guessing you didn't delete anything because that may break a lot of things. If that is the case, I would recommend putting massive deprecation notices ("This is deprecated. Do not use. Do not develop. Instead, use...") into the readme and the sources of the old version.

Did you simply copy (and hence duplicate) the logging code into py4jps? I can't see any deletions. I'm guessing you didn't delete anything because that may break a lot of things. If that is the case, I would recommend putting massive deprecation notices ("This is deprecated. Do not use. Do not develop. Instead, use...") into the readme and the sources of the old version.

As discussed, the deprecation warning is added to the original folder in commit https://github.com/cambridge-cares/TheWorldAvatar/pull/440/commits/76c19d9860bcf8d107e8d1cb5b20ba822bd4c04a
The wiki is also updated accordingly: https://github.com/cambridge-cares/TheWorldAvatar/wiki/Logging/dcab40e4a37fc0b3a8a9ee986f7d9ef312d5ab60


MAINT: mitigate flakey tests

This is an attempt to mitigate flakey tests that sometimes weren't hitting the target scores.

Codecov Report

Merging #230 (0a905b0) into master (247b490) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   99.71%   99.71%
=======================================
  Files           6        6
  Lines         693      693
=======================================
  Hits          691      691
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 247b490...0a905b0. Read the comment docs.

I ran the CI multiple times, did not see any failures. This only seems to increase test time by 1-2 seconds. Hopefully it works long term.


promote: update real time feed to use v1 library

@jadekler Hi Jean, could you please take a look at this PR?

looks like it's complaining there's no such method issue:
github.com/GoogleCloudPlatform/golang-samples/asset/quickstart/delete-feed
vet: asset/quickstart/delete-feed/main_test.go:63:18: client.CreateFeed undefined (type *apiv1.Client has no field or method CreateFeed)
github.com/GoogleCloudPlatform/golang-samples/asset/quickstart/create-feed
vet: asset/quickstart/create-feed/main_test.go:77:9: client.DeleteFeed undefined (type *apiv1.Client has no field or method DeleteFeed)
github.com/GoogleCloudPlatform/golang-samples/asset/quickstart/get-feed
vet: asset/quickstart/get-feed/main_test.go:74:18: client.CreateFeed undefined (type *apiv1.Client has no field or method CreateFeed)
github.com/GoogleCloudPlatform/golang-samples/asset/quickstart/list-feeds
vet: asset/quickstart/list-feeds/main_test.go:74:18: client.CreateFeed undefined (type *apiv1.Client has no field or method CreateFeed)
github.com/GoogleCloudPlatform/golang-samples/asset/quickstart/update-feed
vet: asset/quickstart/update-feed/main_test.go:61:9: client.DeleteFeed undefined (type *apiv1.Client has no field or method DeleteFeed)

go clean -modcache

@jadekler Might this be related to the release issue we talked about earlier?

I think it's because I didn't add the go.mod and go.sum, I've added those files


venial v0.5 release

Would it be possible to release a crates.io version some time in September?
There have been quite a few features going into venial since v0.4, and it would be nice if other published crates could make use of them. Personally I plan to release a first version of godot-rust (GDExtension) in the near future, and this is not possible on crates.io with Git dependencies.
Once everything becomes more stable and forward-compatibility is a topic, #[non_exhaustive] could be applied to structs/enums as well. This could also be done in a v0.6 after getting some feedback from v0.5 (which will likely lead to some breaking changes). In that light, I'd also argue it's better to get a version out soon, advertise it and collect user input, rather than trying to find the perfect API in the darkness 😉
One feature I still plan on implementing are traits. Should be relatively quick to do as a lot of the foundation is now built, but it might make sense to have mod support merged first (https://github.com/PoignardAzur/venial/pull/31).

Sorry for not getting back to you.
Yes, a new release makes sense. I'll give it my undivided attention on Thursday and we'll see it through.

Thanks a lot, appreciate the trust! ❤
I'm not crazy time-constrained, so would appreciate to polish a few things with you before release.
Maybe middle to end of October or so would be nice; I don't know about your availability though.
At some point, we might also look into publishing via CI, i.e. tagging 0.5.0 would invoke cargo publish (after manual confirmation, where you can choose who has the rights). I've implemented this in godot-rust, where things are more complex due to multi-crate workspace. What I would need from you is to create an API key on crates.io and store that in a GitHub secret. I would not need to know the secret, just the name of the variable. This would not require direct crates.io access from other contributors, and you can selectively choose who can approve the deployment.
But this can also be added at any later stage, up to you 🙂

New version released.

Very nice, thanks a lot for this! 👍
Do you want to make an announcement on Reddit/Twitter or so?

I'm not super invested either way.

I could also announce it 😉 but as you wish.
Mid-term, does it make sense if we look for other contributors/maintainers? I'm not sure I will have the capacity once the GDExtension/Rust port is available, as I expect lots of upcoming issues in the early phase. Plus, I also help maintain SFML...

(I noticed! Reading the SFML forums was a blast to the past. My posts from 2012 are still there!)
I'm not too worried about looking for maintainers. The userbase of the project is still tiny, and the project itself has a small enough surface area that I feel I should be able to fix bugs as they come up (with a bit of a delay).
If the project suddenly gets a popularity boost as more than a curiosity, then I expect more potential maintainers to show up.


call send smtp email function in SPI from sendActionHander

Description
Major

Call the smtp functions in SPI from sendMessageAction handler
Add some ITs

Issues Resolved
#39
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #236 (9199730) into develop (ae5ece9) will decrease coverage by 7.61%.
The diff coverage is 88.23%.

@@              Coverage Diff              @@
##             develop     #236      +/-   ##
=============================================
- Coverage      66.94%   59.32%   -7.62%
  Complexity        42       42
=============================================
  Files            134       74      -60
  Lines           4211     2589    -1622
  Branches         731      307     -424
=============================================
- Hits            2819     1536    -1283
+ Misses          1185      847     -338
+ Partials         207      206       -1

Flag
Coverage Δ

dashboards-notifications
?

opensearch-notifications
59.32% <88.23%> (+1.00%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...arch/notifications/send/SendMessageActionHelper.kt
61.64% <88.23%> (+19.10%)
:arrow_up:

...s/Channels/components/modals/DetailsTableModal.tsx

...tions/components/SearchBar/utils/filterHelpers.tsx

...ifications/components/SearchBar/Filter/Filters.tsx

...ges/Channels/components/details/ChannelDetails.tsx

...nels/components/details/ChannelSettingsDetails.tsx

dashboards-notifications/public/utils/helpers.ts

...ions/public/pages/Notifications/utils/constants.ts

...CreateChannel/components/CustomWebhookSettings.tsx

...ateChannel/components/modals/CreateSenderModal.tsx

... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae5ece9...9199730. Read the comment docs.


Can't reproduce results in some environments

I'm having trouble reproducing the results you achieved (in the paper and in scores/dreamer.json) for some environments, using the code in this repository. cartpole_swingup_sparse is one of the environments that most clearly doesn't reproduce, so I'll show examples of it here. I'm just running 1M steps as this environment approximately plateaus in your scores in this time frame.
In dreamer.json, the scores for this env look like:

And in the paper, the scores look like (interestingly decently different than scores.json):

Both reach 700-800 by 1M steps.
I'm running this command: rm -rf logdir/test && CUDA_VISIBLE_DEVICES=0 python3 dreamer.py --logdir ./logdir/test --task dmc_cartpole_swingup_sparse --steps 1e6.
First, I tried it with modern versions of all the packages (easier to set up than old packages). Tensorflow 2.5.0, CUDA 11.3, dm-control 0.0.425341097, A100 GPU, etc. I changed one line of code from experimental_run_v2 to run, but otherwise the code ran fine.
Then, I figured that maybe the reproduction issues were due to differences in package versions, so I tried to create an environment as close as possible to what you might have used (with a clean checkout of this repository):

python 3.8.10
tensorflow 2.2.0
tf probability 0.10.0

cloudpickle 1.3 required to get this working

dm_control commit 5701a00df44b84197692199794ad15cd1d2d0d55 from jan 27, 2020.
mujoco 2.0.0
gym 0.17.1  from march 2020.
PIL 7.1.0  from april 2020
numpy==1.19.5
cuda 10.1
cudnn 7.6.5
one V100 GPU

However, I'm still not able to get results that are close to yours. Here's some tensorboard graphs. Dark blue is from the "modern" environment, and red and light blue are from the env that is hopefully close to yours. I've run other replicates and they look similar to these - none look anything like the ones in dreamer.json.

Let me know what I might be doing wrong here! Happy to provide the full log files. If you have a list of exactly the packages you used I can try running again with those. I've been trying to release a clean Pytorch port of this repository (none of the existing ones really work too well), and my implementation seems to match the results of this code but is also unable to match the results in dreamer.json.

Hi, the paper experiments all used the previous implementation and there are slight performance differences with this code base (in general the performance is a bit better).

To be honest, I don't remember 100% but I'm fairly sure they are from this implementation, just slightly earlier hyper parameters. Also see: https://github.com/danijar/dreamer/issues/55. Hope that helps!


Fix nullable field issue (#420)

UPDATE
changes added to https://github.com/tiangolo/sqlmodel/pull/423
Motivation
Columns that are defined as Optional but are set  = Field(nullable=False) are made nullable. This is a bug that was introduced in https://github.com/tiangolo/sqlmodel/commit/9830ee0d8991ffc068ffb72ccead2427c84e58ee#r82434170 and described in #420.
Actions Taken

Added a test to confirm the regression
Fixed test by re-ordering the code that determines if a field is nullable.

Co-authored-by: Jonas Krüger Svensson<EMAIL_ADDRESS>building off his PR: https://github.com/tiangolo/sqlmodel/pull/423

I have added my changes to https://github.com/tiangolo/sqlmodel/pull/423

Thanks!


add logging to the basic debugging script

What does this PR do?
This PR add some basic logging to the debugging script.

Codecov Report

Merging #3 (a05d1db) into master (514cb22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #3   +/-   ##
=======================================
  Coverage   43.31%   43.31%
=======================================
  Files         116      116
  Lines        8799     8799
=======================================
  Hits         3811     3811
  Misses       4988     4988

Flag
Coverage Δ

cpu
43.31% <ø> (ø)

pytest
43.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 514cb22...a05d1db. Read the comment docs.


Text-Editor enhancements

Suggestions for minor enhancements for the TextEditor:

Currently, when opening the text-color options, the dropdowns get emptied because we dont have focus on the editor anymore
Active options (bold, italics, underlined) aren't indicated that they are active

will be added to #59


[Feature] Considered extending the enum class to include properties and methods like any other class?

Similar to Kotlin...
enum class Color(val rgb: Int) {                      // 1
    RED(0xFF0000),                                    // 2
    GREEN(0x00FF00),
    BLUE(0x0000FF),
    YELLOW(0xFFFF00);

    fun containsRed() = (this.rgb and 0xFF0000 != 0)  // 3
}

With enhanced enums (since 2.17 language version), this is possible
enum Color {
  RED(0xFF0000),
  GREEN(0x00FF00),
  BLUE(0x0000FF),
  YELLOW(0xFFFF00);

  final int x;

  const Color(this.x);

  bool containsRed() => x & 0xFF0000 != 0;
}

With enhanced enums (since 2.17 language version), this is possible
enum Color {
  RED(0xFF0000),
  GREEN(0x00FF00),
  BLUE(0x0000FF),
  YELLOW(0xFFFF00);

  final int x;

  const Color(this.x);

  bool containsRed() => x & 0xFF0000 != 0;
}

Please note that language features are here.

thank you very much


No signer x509 configured for tekton-pipeline-run

Branch local-registry:
When using the local registry, attestations are not being written to the registry, and tekton-chains logs show this after pr pipeline is done:
No signer x509 configured for tekton-pipeline-run

This might be due to the changes introduced in https://github.com/konflux-ci/konflux-ci/pull/263

@gbenhaim @avi-biton let me know if you have any thoughts of why this might happen.
We're distributing to tekton-chains the CA cert from the certificate that was created with the self-signed issuer, while we use that certificate to create a CA issuer that we use for creating the certificates for the registry.
Not sure what's wrong.

This is in fact a regression that was found earlier, fixed on main and not ported to this branch.
Rebased the feature branch on the main branch to address it.


README.md: update descriptions for online bulk load

to fix the markdown rendering and make a brief introduction to online bulk load

@marsishandsome @andylokandy PTAL


Predicted categories wrong

So, it's become clear to me that the prediction labels can be wrong.
What do you mean?
Say I have the following data

x
y

1
a

1
a

1
a

2
b

2
b

2
b

A decision tree trained to predict y form x will have a very easy time.
So what happens when I get the predicted probabilities?

x
y
p(y=a)
p(y=b)

1
a
0
1

1
a
0
1

1
a
0
1

2
b
1
0

2
b
1
0

2
b
1
0

Errr..., this isn't right.
MWE
julia> using MLJ, MLJDecisionTreeInterface, DataFrames

julia> Xind, yind = DataFrame(i=[1, 1, 1, 2, 2, 2]), ["a", "a", "a", "b", "b", "b"];

julia> tmach = machine(DecisionTreeClassifier(), Xind, coerce(yind, Multiclass))
untrained Machine; caches model-specific representations of data
  model: DecisionTreeClassifier(…)
  args:
    1:	Source @508 ⏎ Table{AbstractVector{Count}}
    2:	Source @186 ⏎ AbstractVector{Multiclass{2}}

julia> fit!(tmach)
[ Info: Training machine(DecisionTreeClassifier(max_depth = 4, …), …).
trained Machine; caches model-specific representations of data
  model: DecisionTreeClassifier(max_depth = 4, …)
  args:
    1:	Source @508 ⏎ Table{AbstractVector{Count}}
    2:	Source @186 ⏎ AbstractVector{Multiclass{2}}

julia> MLJ.predict(tmach, Xind)
6-element CategoricalDistributions.UnivariateFiniteVector{Multiclass{2}, String, UInt32, Float64}:
 UnivariateFinite{Multiclass{2}}(a=>0.0, b=>1.0)
 UnivariateFinite{Multiclass{2}}(a=>0.0, b=>1.0)
 UnivariateFinite{Multiclass{2}}(a=>0.0, b=>1.0)
 UnivariateFinite{Multiclass{2}}(a=>1.0, b=>0.0)
 UnivariateFinite{Multiclass{2}}(a=>1.0, b=>0.0)
 UnivariateFinite{Multiclass{2}}(a=>1.0, b=>0.0)

MLJ v0.19
DecisionTree v0.12
MLJDecisionTreeInterface.jl v0.3.0

Hot damn, that's surprising. @tecosaur Thanks for reporting.
Unfortunately, I'm not able to reproduce:
julia> MMI.predict(tmach, Xind)
6-element CategoricalDistributions.UnivariateFiniteVector{Multiclass{2}, String, UInt32, Float64}:
 UnivariateFinite{Multiclass{2}}(a=>1.0, b=>0.0)
 UnivariateFinite{Multiclass{2}}(a=>1.0, b=>0.0)
 UnivariateFinite{Multiclass{2}}(a=>1.0, b=>0.0)
 UnivariateFinite{Multiclass{2}}(a=>0.0, b=>1.0)
 UnivariateFinite{Multiclass{2}}(a=>0.0, b=>1.0)
 UnivariateFinite{Multiclass{2}}(a=>0.0, b=>1.0)

Status `/private/var/folders/4n/gvbmlhdc8xj973001s6vdyw00000gq/T/jl_0CaPUM/Project.toml`
  [a93c6f00] DataFrames v1.4.4
  [add582a8] MLJ v0.19.0
  [c6f25543] MLJDecisionTreeInterface v0.3.0
  [e80e1ace] MLJModelInterface v1.8.0

julia> versioninfo()
Julia Version 1.8.3
Commit 0434deb161e (2022-11-14 20:14 UTC)
Platform Info:
  OS: macOS (x86_64-apple-darwin21.4.0)
  CPU: 12 × Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-13.0.1 (ORCJIT, skylake)
  Threads: 5 on 12 virtual cores
Environment:
  JULIA_LTS_PATH = /Applications/Julia-1.6.app/Contents/Resources/julia/bin/julia
  JULIA_PATH = /Applications/Julia-1.8.app/Contents/Resources/julia/bin/julia
  JULIA_EGLOT_PATH = /Applications/Julia-1.6.app/Contents/Resources/julia/bin/julia
  JULIA_NUM_THREADS = 5
  JULIA_NIGHTLY_PATH = /Applications/Julia-1.8.app/Contents/Resources/julia/bin/julia

Do you ever get the correct response?
@OkonSamuel Can you reproduce this error?
@tecosaur Can you please report your complete manifest (output of ] status -m)? What version of Julia?

@tecosaur Can you please report your version of CategoricalDistributions. It's possible you need a bug fix that only appeared in version 0.1.9.

Sorry, this cross-reference is irrelevant.

Sorry, this cross-reference is irrelevant.

okay.
@tecosaur know the you project versions with] status would be helpful in pinning down the issue.

These are reported above. But  ] status -m would also be helpful.

What do you mean?
Say I have the following data
x	y
1	a
1	a
1	a
2	b
2	b
2	b
A decision tree trained to predict y form x will have a very easy time. So what happens when I get the predicted probabilities?
x	y	p(y=a)	p(y=b)
1	a	0	1
1	a	0	1
1	a	0	1
2	b	1	0
2	b	1	0
2	b	1	0
Errr..., this isn't right.
MWE
julia> using MLJ, MLJDecisionTreeInterface, DataFrames

julia> Xind, yind = DataFrame(i=[1, 1, 1, 2, 2, 2]), ["a", "a", "a", "b", "b", "b"];

julia> tmach = machine(DecisionTreeClassifier(), Xind, coerce(yind, Multiclass))
untrained Machine; caches model-specific representations of data
  model: DecisionTreeClassifier(…)
  args:
    1:	Source @508 ⏎ Table{AbstractVector{Count}}
    2:	Source @186 ⏎ AbstractVector{Multiclass{2}}

julia> fit!(tmach)
[ Info: Training machine(DecisionTreeClassifier(max_depth = 4, …), …).
trained Machine; caches model-specific representations of data
  model: DecisionTreeClassifier(max_depth = 4, …)
  args:
    1:	Source @508 ⏎ Table{AbstractVector{Count}}
    2:	Source @186 ⏎ AbstractVector{Multiclass{2}}

julia> MMI.predict(tmach, Xind)
6-element CategoricalDistributions.UnivariateFiniteVector{Multiclass{2}, String, UInt32, Float64}:
 UnivariateFinite{Multiclass{2}}(a=>0.0, b=>1.0)
 UnivariateFinite{Multiclass{2}}(a=>0.0, b=>1.0)
 UnivariateFinite{Multiclass{2}}(a=>0.0, b=>1.0)
 UnivariateFinite{Multiclass{2}}(a=>1.0, b=>0.0)
 UnivariateFinite{Multiclass{2}}(a=>1.0, b=>0.0)
 UnivariateFinite{Multiclass{2}}(a=>1.0, b=>0.0)

MLJ v0.19
DecisionTree v0.12
MLJDecisionTreeInterface.jl v0.3.0

@tecosaur I wasn't able to reproduce this issue. Even with an older version of MLJ.
However, a few things seem strange about your MWE

The display of the tmach below indicates an older version of MLJBase was used. Especially    model: DecisionTreeClassifier(…) which was supposed to display  model: DecisionTreeClassifier(max_depth=-1, …) since<EMAIL_ADDRESS>
julia> tmach = machine(DecisionTreeClassifier(), Xind, coerce(yind, Multiclass))
untrained Machine; caches model-specific representations of data
  model: DecisionTreeClassifier(…)
  args:
    1:	S iource @508 ⏎ Table{AbstractVector{Count}}
    2:	Source @186 ⏎ AbstractVector{Multiclass{2}}

The display of the output machine after calling fit!(tmach) isn't right. This indicates that the default passed was max_depth=4. The default value for max_depth parameter has always been -1.

[ Info: Training machine(DecisionTreeClassifier(max_depth = 4, …), …).
trained Machine; caches model-specific representations of data
  model: DecisionTreeClassifier(max_depth = 4, …)
  args:
    1:	Source @508 ⏎ Table{AbstractVector{Count}}
    2:	Source @186 ⏎ AbstractVector{Multiclass{2}}

I'm a little curious as to what you were working on before you discovered this issue.

The issue @ablaom raised above, is indeed a bug but it shouldn't affect MLJDecisionTreeInterface.jl because univariate finite objects are created using MMI.UnivariateFinite(classes_seen, scores) rather than MMI.UnivariateFinite(raw_classes, scores, pool=pool)
Here's what I recommend though

Try running the example you gave again exactly as it.
Share a copy of your current Project.toml file and (possibly) manifest.toml file. So I can use exactly the same environment as you.

Thanks for the help guys, upon further investigation there was indeed something funny going on with my environment that was "poisoning" the results. MLJDecisionTreeInterface is fine :sweat_smile:


Invariant Violation: requireNativeComponent: "ManagerClass" was not found in the UIManager.

Environment
React Native Environment Info:
    System:
      OS: macOS High Sierra 10.13.6
      CPU: x64 Intel(R) Core(TM) i7-3740QM CPU @ 2.70GHz
      Memory: 742.25 MB / 16.00 GB
      Shell: 3.2.57 - /bin/bash
    Binaries:
      Node: 8.11.2 - /usr/local/bin/node
      Yarn: 1.5.1 - /usr/local/bin/yarn
      npm: 6.4.1 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
      Android SDK:
        Build Tools: 26.0.2, 26.0.3, 27.0.3, 28.0.2
        API Levels: 23, 26, 27, 28
    IDEs:
      Android Studio: 3.1 AI-173.4720617
      Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.5.0 => 16.5.0
      react-native: 0.57.0 => 0.57.0
    npmGlobalPackages:
      react-native-cli: 2.0.1

Description
I have followed the docs here about creating a new native UI component with Android, as I'm trying to implement the Here maps SDK in RN. I've followed the code and examples they provide, but I can't seem to fix this error I'm getting: Invariant Violation: requireNativeComponent: "ReactHereMapManager" was not found in the UIManager..
ReactHereMapManager is my manager class that I've created according to the docs.
Reproducible Demo
All my code for this app is in this repo here: https://github.com/GRA0007/heremaps-rn

If anyone else has this issue, the solution was making sure that the js file that has the reference to the package has the name of the new component in it, not the manager.
I.e. this:
module.exports = requireNativeComponent('HereMapView');
instead of this:
module.exports = requireNativeComponent('ReactHereMapManager');


NTR: (4S)-4-hydroxy-5-phosphonooxypentane-2,3-dione isomerase activity, EC <IP_ADDRESS>

Hi,
Could someone please create a GO term for EC <IP_ADDRESS>, (4S)-4-hydroxy-5-phosphonooxypentane-2,3-dione isomerase activity?  Proposed definition: Catalysis of the reaction (4S)-4-hydroxy-5-phosphonooxypentane-2,3-dione = 3-hydroxy-5-phosphonooxypentane-2,4-dione.  Synonym: phospho-AI-2 isomerase activity.
Thanks,
Ingrid

@hdrabkin  is this in your list?

No, this is new.

I would think this will be an is_a
isomerase activity
GO id:	GO:0016853
Definition:	Catalysis of the geometric or structural changes within one molecule. Isomerase is the systematic name for any enzyme of EC class 5.
Comments	Note that enzymes of class EC:5.99.-.- should also be annotated to this term.

done


TypeError: responseFn.bind is not a function

Sails version: 1.0.2
Node version: 7.9.0
NPM version: 4.2.0
DB adapter name: N/A
DB adapter version: N/A
Operating system: Ubuntu 14

I'm using sails to create a facebook messenger bot. A post request comes into my app and even before it hits the controller, it throws a server error (I believe in the router):
TypeError: responseFn.bind is not a function
    at eachMethod (/home/cabox/workspace/node_modules/sails/lib/hooks/responses/index.js:142:36)
    at /home/cabox/workspace/node_modules/@sailshq/lodash/lib/index.js:3253:15
    at baseForOwn (/home/cabox/workspace/node_modules/@sailshq/lodash/lib/index.js:2223:14)
    at /home/cabox/workspace/node_modules/@sailshq/lodash/lib/index.js:3223:18
    at Function.<anonymous> (/home/cabox/workspace/node_modules/@sailshq/lodash/lib/index.js:3526:13)
    at addResponseMethods (/home/cabox/workspace/node_modules/sails/lib/hooks/responses/index.js:141:13)
    at routeTargetFnWrapper (/home/cabox/workspace/node_modules/sails/lib/router/bind.js:391:9)
    at Layer.handle [as handle_request] (/home/cabox/workspace/node_modules/express/lib/router/layer.js:95:5)
    at next (/home/cabox/workspace/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/home/cabox/workspace/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/home/cabox/workspace/node_modules/express/lib/router/layer.js:95:5)
    at /home/cabox/workspace/node_modules/express/lib/router/index.js:281:22
    at param (/home/cabox/workspace/node_modules/express/lib/router/index.js:354:14)
    at param (/home/cabox/workspace/node_modules/express/lib/router/index.js:365:14)
    at Function.process_params (/home/cabox/workspace/node_modules/express/lib/router/index.js:410:3)
    at next (/home/cabox/workspace/node_modules/express/lib/router/index.js:275:10)
    at next (/home/cabox/workspace/node_modules/express/lib/router/route.js:127:14)
    at _addResViewMethod (/home/cabox/workspace/node_modules/sails/lib/hooks/views/res.view.js:426:3)
    at routeTargetFnWrapper (/home/cabox/workspace/node_modules/sails/lib/router/bind.js:391:9)
    at Layer.handle [as handle_request] (/home/cabox/workspace/node_modules/express/lib/router/layer.js:95:5)
    at next (/home/cabox/workspace/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/home/cabox/workspace/node_modules/express/lib/router/route.js:112:3)

Please let me know if I need to provide something else.

@fardin01  if you're upgrading from previous versions prior to v1 please be aware, as the documentation dictates, that

If your api or config folders and subfolders contain any non-source files, they’ll need to be moved. The exception is for Markdown (.md) and text (.txt) files, which will continue to be ignored. Sails will attempt to read all other files in those folders as code, allowing for more flexibility in choosing a Javascript dialect (see the notes about CoffeeScript and TypeScript above).

In my case it was a .eslintrc.json file on my responses folder (I just renamed to .eslintrc) and my text editor (vim) was generating some temp files wich also causes the app to crash (I changed the path folder to write temp files).

@tugorez that was it! Thanks a lot.


kong ingress controller need support for multiple ports per service

Summary
Kong Ingress controller "0.5.0" not support for multiple ports per service.
Kong Ingress controller version
0.5.0
Kong version
1.2
Kubernetes version
Kubernetes Cluster version v1.10 (v1.10.12) - git (clean) commit c757b93cf034d49af3a3b8ecee3b9639a7a11df7 - platform linux/amd64
What happened
This is my ingress yaml , there have two ports need setting.
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    configuration.konghq.com: need-strip-path
    kubernetes.io/ingress.class: kong
  labels:
    app: test-api
  name: test-api
  namespace: staging
spec:
  rules:
  - host: test.mydomain.com
    http:
      paths:
      - backend:
          serviceName: test-api
          servicePort: 5000
        path: /test-api
      - backend:
          serviceName: test-api
          servicePort: 5001
        path: /test-socket

kong ingress controller error:
E0722 12:39:24.220304       1 controller.go:125] unexpected failure updating Kong configuration:
error creating a valid state for Kong: duplicate upstream definitions found for: 'test-api.staging.svc'
W0722 12:39:24.220345       1 queue.go:113] requeuing staging/test-api, err error creating a valid state for Kong: duplicate upstream definitions found for: 'test-api.staging.svc'

I think the upstream name should contain port number too.

This was working for me with the helm chart version 0.7.0. I have updated to 0.12.1 and now both ports are showing up in the target.
KongRDSDB=> select * from targets WHERE upstream_id = '214fd01a-4733-4dc4-bb06-123271a393d2';
                  id                  |         created_at         |             upstream_id              |       target       | weight | tags
--------------------------------------+----------------------------+--------------------------------------+--------------------+--------+------
 5df98361-eb76-4ca0-b636-315969865f5f | 2019-08-13 21:24:45.16+00  | 214fd01a-4733-4dc4-bb06-123271a393d2 | <IP_ADDRESS>:10020 |    100 |
 6f6e09d0-4560-4a66-b7b4-bf56dc30ab3f | 2019-08-13 21:24:44.931+00 | 214fd01a-4733-4dc4-bb06-123271a393d2 | <IP_ADDRESS>:8025  |    100 |
(2 rows)

This obviously is causing issues, things supposed to got port 10020 are going to both 10020 and 8025 and things supposed to goto 8025 are going to both as well.

Thanks so much @rainest ! Really looking forward to this feature.


code release

Hi @bruAristimunha, will you release the code soon? We want to use your paper for our hands-on journal club, without code, I can't add it to the list.

Dear prof @rgbayrak,
Done, but I am not sure if the code is good for a hands-on.
Have a nice day!
Fyi @JessyD


tmp := strings.Replace(svid, "spiffe://aegis.z2h.dev/workload/", "", 1) <= that shall be parsed from the SVID instead

already works as expected: closing.


How to return and get value when pop to previous screen ?

I push from screen 1 to screen to using goTo() and going back to previous screen using goBack(). Both are returning void only.
How can i send data from 2nd screen to 1st screen while pop and how to receive data at screen 1 ?
Please suggest me on this.

Returning result on going back is not supported at the moment. It is in the list of future improvements though.
Currently, the possible solution could be like saving the data in your app state on the 2nd screen, and listen that state on the 1st screen.

Okay. Thank you.


[Suggestion] Support to select multiple actions at once when executing "Rerun Action..." command

OS: All
Build Version: 20200917.3
Repro steps:

F1 --> Click "Rerun Action..." --> Select a Static Web App --> Select an Environment --> Select actions.
Check the result.

Actual:
Only allow to select one action at once.

Suggestion:
Support to select multiple actions at once, such as select subscriptions.

More Info:
This issue also reproduces when executing "Cancel Action..." command.

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this issue has received less than 5 community upvotes and we closed it. Still a big Thank You to you for taking the time to create it! To learn more about how we handle issues, please see our documentation.
Happy Coding!


Evaluation of the different neuronal morphologies

We want to explore how the features (size and branches) of the neurons can affect on the GPU performance.
In that sense, we have detailed some test cases regarding the size of the neurons:

Small (about 60 elements)

Medium (about 400 elements)

Big (about 700 elements)

In each test case (size), we explore two different scenarios, high (about 50% of branches regarding the size) and low number (about 10%) of branches.
We obtain the neurons from this web:
http://www.neuromorpho.org
This allows us to carried out the tests on real neurons.

We have evaluated the influence of the neuron morphologies on performance. As shown (see document attached), we obtain a similar scalability by using our approach (Full-Interleaved) independently of the morphology (size and branches) of the neurons
22-12-2016v1.pdf
. Our implementation scales until a very high number of neurons (256,000). The GPU (K40) implementation is able to achieve an acceleration about 3x with respect to the execution time of the multicore (16 cores, 2 sockets of 8 core each) implementation on 25,600 and 256,000 neurons.


'Info Bar Bounces', 'Max Optimization' and Actions workflows

'Info Bar Bounces': This option is made because the bouncing was too annoying. I also decreased the info bar's size a bit
'Max Optimization': Self-explanatory
Actions workflows: Automatic builds for Windows, macOS and Linux with binaries. You can use these binaries when publishing releases.
Resolves #219
Resolves #501

no longer have time to do this, sorry


[bug] incorrect result

function _snparray_ax_additive!(out, s::Matrix{UInt8}, v)
    fill!(out, zero(UInt8))
    k = size(s, 1)
    @avx for j ∈ eachindex(v)
        for l in 1:k
            block = s[(j-1)*size(s, 1) + (l-1) + 1]

            # i = 4 * (l-1) + 1
            Aij = block & 3
            i = 4 * (l-1) + 1
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 2
            Aij = (block >> 2) & 3
            i = 4 * (l-1) + 2
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 3
            Aij = (block >> 4) & 3
            i = 4 * (l-1) + 3
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 4
            Aij = (block >> 6) & 3
            i = 4 * (l-1) + 4
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

        end
    end
    out
end

The result is different from the code without @avx.

Hi, mind giving code I can copy and paste to run the example (and perhaps eventually add to the tests)?

using LoopVectorization
function _snparray_ax_additive!(out, s::Matrix{UInt8}, v)
    fill!(out, zero(UInt8))
    k = size(s, 1)
    @avx for j ∈ eachindex(v)
        for l in 1:k
            block = s[(j-1)*size(s, 1) + (l-1) + 1]

            # i = 4 * (l-1) + 1
            Aij = block & 3
            i = 4 * (l-1) + 1
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 2
            Aij = (block >> 2) & 3
            i = 4 * (l-1) + 2
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 3
            Aij = (block >> 4) & 3
            i = 4 * (l-1) + 3
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 4
            Aij = (block >> 6) & 3
            i = 4 * (l-1) + 4
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

        end
    end
    out
end

function _snparray_ax_additive_noavx!(out, s::Matrix{UInt8}, v)
    fill!(out, zero(UInt8))
    k = size(s, 1)
    for j ∈ eachindex(v)
        for l in 1:k
            block = s[(j-1)*size(s, 1) + (l-1) + 1]

            # i = 4 * (l-1) + 1
            Aij = block & 3
            i = 4 * (l-1) + 1
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 2
            Aij = (block >> 2) & 3
            i = 4 * (l-1) + 2
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 3
            Aij = (block >> 4) & 3
            i = 4 * (l-1) + 3
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 4
            Aij = (block >> 6) & 3
            i = 4 * (l-1) + 4
            out[i] += ((Aij >= 2) + (Aij >= 3)) * v[j]

        end
    end
    out
end

using Random, Test
a = rand(UInt8, 512, 512)
v1 = zeros(512 << 2)
v1_ = zeros(512 << 2)

v2 = rand(Float64, 512)
_snparray_ax_additive!(v1, a, v2)
_snparray_ax_additive_noavx!(v1_, a, v2)

@test isapprox(v1, v1_)

It works correctly without the intermediate variable i:
function _snparray_ax_additive!(out, s::Matrix{UInt8}, v)
    fill!(out, zero(UInt8))
    k = size(s, 1)
    @avx for j ∈ eachindex(v)
        for l in 1:k
            block = s[(j-1)*size(s, 1) + (l-1) + 1]

            # i = 4 * (l-1) + 1
            Aij = block & 3
            out[4*(l-1)+1] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 2
            Aij = (block >> 2) & 3
            i = 4 * (l-1) + 2
            out[4*(l-1)+2] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 3
            Aij = (block >> 4) & 3
            out[4*(l-1)+3] += ((Aij >= 2) + (Aij >= 3)) * v[j]

            # i = 4 * (l-1) + 4
            Aij = (block >> 6) & 3
            out[4*l] += ((Aij >= 2) + (Aij >= 3)) * v[j]

        end
    end
    out
end

The problem is that it doesn't un-alias the names. That is, creating two distinct variables with the same name (i or Aij) is likely to cause problems. It's more likely to cause problems for variables used for indexing (like i), because indexes are going to be reordered more heavily.
This passes the tests:
function _snparray_ax_additive!(out, s::Matrix{UInt8}, v)
    fill!(out, zero(UInt8))
    k = size(s, 1)
    @avx for j ∈ eachindex(v)
        for l in 1:k
            block = s[(j-1)*size(s, 1) + (l-1) + 1]

            # i = 4 * (l-1) + 1
            Aij_1 = block & 3
            i_1 = 4 * (l-1) + 1
            out[i_1] += ((Aij_1 >= 2) + (Aij_1 >= 3)) * v[j]

            # i = 4 * (l-1) + 2
            Aij_2 = (block >> 2) & 3
            i_2 = 4 * (l-1) + 2
            out[i_2] += ((Aij_2 >= 2) + (Aij_2 >= 3)) * v[j]

            # i = 4 * (l-1) + 3
            Aij_3 = (block >> 4) & 3
            i_3 = 4 * (l-1) + 3
            out[i_3] += ((Aij_3 >= 2) + (Aij_3 >= 3)) * v[j]

            # i = 4 * (l-1) + 4
            Aij_4 = (block >> 6) & 3
            i_4 = 4 * (l-1) + 4
            out[i_4] += ((Aij_4 >= 2) + (Aij_4 >= 3)) * v[j]

        end
    end
    out
end

I'll add something to change the names of the repeated variables.
However, I'd also like to point out that LoopVectorization only SIMDs across iterations of the loops.
That means that writing:
out[4*(l-1)+1] += ...
out[4*(l-1)+2] += ...
out[4*(l-1)+3] += ...
out[4*l] += ...

Will force it to load elements like:
out[4*((l .+ 0:7)-1)+1] .+= ...
out[4*((l .+ 0:7)-1)+2] .+= ...
out[4*((l .+ 0:7)-1)+3] .+= ...
out[4*(l .+ 0:7)] .+= ...

This requires using gather and scatter intrinsics. These are slow, and if you don't have AVX512, scatter has to be emulated with repeated extractions and scalar stores.
It would be faster if you could define
v1__ = copy(reshape(v1_, (4, length(v1_) >> 2))'); # make it a matrix

function _snparray_ax_additive_contig!(out, s::Matrix{UInt8}, v)
    fill!(out, zero(UInt8))
    k = size(s, 1)
    # manually set unroll, seems to choose something a little faster
    @avx unroll=(2,2) for j ∈ eachindex(v)
        for l in 1:k
            block = s[l,j]

            Aij_1 = block & 3
            out[l,1] += ((Aij_1 >= 2) + (Aij_1 >= 3)) * v[j]

            Aij_2 = (block >> 2) & 3
            out[l,2] += ((Aij_2 >= 2) + (Aij_2 >= 3)) * v[j]

            Aij_3 = (block >> 4) & 3
            out[l,3] += ((Aij_3 >= 2) + (Aij_3 >= 3)) * v[j]

            Aij_4 = (block >> 6) & 3
            out[l,4] += ((Aij_4 >= 2) + (Aij_4 >= 3)) * v[j]

    end
    out
end
_snparray_ax_additive_contig!(v1__, a, v2);

@test isapprox(vec(v1__'), v1_)

This doesn't actually make much difference for me, because it swaps the order of the loops to make l the outer loop, so that it only has to gather/scatter once per for j in eachindex.

Thanks for the information!


Fixing top_k tokens when k ends up < 0

What does this PR do?

Fixes # (issue)
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline,
Pull Request section?
[ ] Was this discussed/approved via a Github issue or the forum? Please add a link
to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.
[ ] Did you write any new necessary tests?

Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Vinno97

This seems to be triggerable on some GPTQ models (it was for me on a very bad checkpoint).

Hi @Narsil do you have a way to reproduce this? Might be good to also add it to the tests.
How I'm reading the logic:

This fixes top_n_ishes being empty for a certain batch item (request).
Which should only happen when no logprob is higher or equal to the nth_highest logprob.
Which may happen when all logprobs for thatrequest are are -inf?

Yes that's basically it. It was a trash model outputting garbage, therefore we could hit this.
However the fix shouldn't have any impact except let the queries go and not crash.

Okay fair enough. Was thinking of catching this earlier in the process, but this works and is good enough


Top most parent selector

Hi guys,
I've posted this proposal here: (https://github.com/sass/sass/issues/1980). As I expected it has been rejected, I keep thinking this would be a valuable feature though.
What do you think about it? Are you willing to add features like this?

We are just an implementation of Ruby Sass. We do what they do no more no
less.
On Jan 30, 2016 10:34 PM, "Nicolas Gryman"<EMAIL_ADDRESS>wrote:

Hi guys,
I've posted this proposal here: (sass/sass#1980
https://github.com/sass/sass/issues/1980). As I expected it has been
rejected, I keep thinking this would be a valuable feature though.
What do you think about it? Are you willing to add features like this?
—
Reply to this email directly or view it on GitHub
https://github.com/sass/node-sass/issues/1362.


Add next query to social login link so next redirect is done when needed

Set SOCIAL_AUTH_GOOGLE_OAUTH2_WHITELISTED_DOMAINS to STAFF_EMAIL_DOMAINS if not set.
Fixes #642

LGTM


Distance from empty collection is zero

Expected behavior and actual behavior.
Expected behaviour:
The distance from an empty collection should be +inf.
Actual behaviour:
The distance from an empty collection returns zero.
Steps to reproduce the problem.
Run the following script:
from shapely.geometry import Point, LineString

empty_thing = LineString()
assert empty_thing.is_empty
print(empty_thing.distance(Point(1, 1)))  # Returns zero, should probably be +inf

Operating system
Windows 10 64 bit
Shapely version and provenance
Python 3.6
Shapely 1.6b4 installed from PyPI using pip

This behavior is inherited from GEOS. If either geometry is empty the distance method returns 0. I think this is the relevant line of code:
https://github.com/OSGeo/geos/blob/5a730fc50dab2610a9e6c037b521accc66b7777b/src/operation/distance/DistanceOp.cpp#L146

Interesting. Given that they explicitly covered this case, is this WAD? Why should this be the case?

Similar to GEOS, JTS returns 0.0, so perhaps this behavior was drafted a long time ago.
PostGIS returns null for this scenario, since there are not any geometries to measure between. I'd suggest Shapely similarly return None if any of the inputs are empty.

@mwtoews I'd like to see an exception raised instead of getting None: the intent is more clear.
Thanks for bringing this up, @jebob!

SQL Server spatial types return NULL, similar to PostGIS.  Esri's ArcPy generates an error.  It seems we have 0, NULL, or error depending on whom you ask.  I can see some merit behind arguments for any of them, so clear documentation is probably the most important part of addressing this issue.  After all, without a consensus among geospatial products, it is a matter of expectations and not correctness.

I've changed my mind and am inclined to leave it as zero.

I wouldn't accept that the empty geometry is in every non-empty geometry, as the operation isn't analogous.

Two identical strings are in each other, but two identical shapes may have different offsets and therefore aren't "in" each other.

Empty geometries should not be presumed to occupy every space, because then the intersection of an empty geometry and X geometry returns X.

Empty geometries must be further than any shape. dist(foo, X) <= dist(foo, union(X+Y)) by definition. If X is the empty set, then dist(foo, X) must return infinity for the identity to be valid for all foo, Y.

@jebob thanks for being patient with me. I see the logic in +inf now.
Still, I think I'd prefer to treat it as undefined and raise an exception (in a feature release) for usability reasons.

Raising an exception seems a good compromise candidate as it is an unambiguous result, therefore preventing confusion from those who rely on GEOS/JTS returning zero.

With the latest GEOS version (3.10.3 or 3.11.0), the example in the top post now returns NaN instead of 0 (see also the discussion in https://github.com/shapely/shapely/issues/753).
This behaviour now seems consistent, and we are generally fine with NaN as result?

Returning NaN is fine with me.


undefined method `gsub' for nil:NilClass during migration

I just updated my stringer and got this while migrating:
undefined method `gsub' for nil:NilClass/home/bodo02/stringer/db/migrate/20141102103617_fix_invalid_titles_with_unicode_line_endings.rb:4:in `block in up'
/home/bodo02/.gem/gems/activerecord-4.0.13/lib/active_record/relation/batches.rb:26:in `block (2 levels) in find_each'
/home/bodo02/.gem/gems/activerecord-4.0.13/lib/active_record/relation/batches.rb:26:in `each'
/home/bodo02/.gem/gems/activerecord-4.0.13/lib/active_record/relation/batches.rb:26:in `block in find_each'
/home/bodo02/.gem/gems/activerecord-4.0.13/lib/active_record/relation/batches.rb:76:in `find_in_batches'
/home/bodo02/.gem/gems/activerecord-deprecated_finders-1.0.3/lib/active_record/deprecated_finders/relation.rb:70:in `find_in_batches'
/home/bodo02/.gem/gems/activerecord-4.0.13/lib/active_record/relation/batches.rb:25:in `find_each'
/home/bodo02/.gem/gems/activerecord-4.0.13/lib/active_record/querying.rb:8:in `find_each'
/home/bodo02/stringer/db/migrate/20141102103617_fix_invalid_titles_with_unicode_line_endings.rb:3:in `up'
/

I had some story titles with nil in them, so the fix for me was to change the migration to this:
      valid_title = (story.title || "").gsub("\u2028", '').gsub("\u2029", '')

Thanks for the report.
I'd accept a PR that just skips the iteration if the title is nil if you (or someone else) wants to take care of it.


feature(readme): add all-contributors

Changes proposed in this pull request:

Add all-contributors

@all-contributors please add irvelervel

@all-contributors please add irvelervel for code

@all-contributors please add @irvelervel

@all-contributors please add @kumikokashii

@all-contributors add @irvelervel for code

@all-contributors add @jackcmeyer for code


Phase Resistance Measurement

The FOC loop runs with a integrator controller, then phA current becomes steady quickly. The phase resistance is caluculated as the voltage(controller output) divided by the command current.
However, the motor winding current is still discontinuous since MOSFESTS work in PWM mode. The inductance cannot be ignored.
Is it right to measure phase resistance in this way?

For normal sized motors (*) the current renders a triangular waveform with a period of 48kHz (twice the PWM frequency). The current sampling happens almost exactly in the middle of the falling slope (up to a delay of 0.5µs). Thus we sample almost exactly the average current.
(*) if the phase inductance is very low and/or the phase resistance is very high (in other words a short time constant tau = L/R) then the triangle waveform starts becoming curved and the measured current won't be the correct average anymore. For reference the D5065 motor has roughly L = 16µH and R = 39mΩ. The curving starts to appear at L = 1µH and R = 39mΩ as can be seen in this simulation. However then you also get huge current ripples so you'd probably want a higher switching frequency anyway.


Map removal fix

Sometimes Unpinning the eBPF maps don't remove the files ( internally os.Remove not worked). In this PR I have added a condition when Unpinning doesn't remove the map file the we should Remove it.

@Atul-source Please validate this case.

What happens if l3afd gets killed or terminates abruptly ?
Will all the maps remain in /sys/fs/bpf folder & later when l3afd starts again, does it create duplicate maps ?

@Atul-source Better to handle the deletion of Map files while loading the eBPF program, instead of handling during stopping of eBPF program, so that we can guarantee that there are no duplicate Maps.


Google link in bottom left corner doesn't update

Verify latest release

[X] I verified that the issue exists in the latest release

I know how to solve the bug
None
Link to the code that reproduces this issue
https://giorgiabosello.github.io/google-maps-react-markers/
To Reproduce
See the link in demo. On each map occurs this behaviour.
Describe the Bug
In the bottom left corner we have an img with google logo. This is certainly a link to the same place in google maps.
Issue is that link doesn't update on change map position. Only zoom is changing in this link.
Expected Behavior
Link updates properly with map position like here in other package:
https://jsbin.com/ruwogapuke/1/edit?js,output
Which browser are you using? (if relevant)
Chrome 118.0.5993.118

@Emauss did you check if this is reproduced on a Google Map with the API Key implemented?

@giorgiabosello yes there's the same.

It appears mapUrl is updated only the first time. I can't find out why.
onChange and onIdle events are triggering, and so is the overlay view.
I will get into it. Any help debugging is appreciated.

@giorgiabosello there's any new info in this case?

@Emauss I'm sorry, nope. I didn't had any chance to look at it. I should be able to check this within this week.
I'll keep you posted.

@Emauss Fixed in version 2.0.7 :)
Let me know if everything works, working example here.

@giorgiabosello It works!
Thank you so much. :)


Inconsistent behavior clearing combobox

Current behavior
I just noticed the following behavior with the cancel button using autoSelect:
https://user-images.githubusercontent.com/943036/180314309-c62bf844-cc4f-49e5-a79f-2a47bb09a545.mov
Is it the intended behavior? If so, is there any workaround to always unselect the item after clearing the input?
Steps to reproduce the bug

Open sandbox: https://codesandbox.io/s/polished-worker-5ugu3i
Type "a"
Press tab
Hit enter
Notice no item is now selected
Type "a" again
Now, click on the clear button
Notice the first item remains selected

Expected behavior
Keep no item selected after clearing the input.
Workaround
No response
Possible solutions
No response

Steps to reproduce the bug

Open sandbox: https://codesandbox.io/s/polished-worker-5ugu3i
Type "a"
Press tab
Hit enter
Notice no item is now selected
Type "a" again
Now, click on the clear button
Notice the first item remains selected

I can't reproduce these steps with that CodeSandbox. I think you forgot to add the autoSelect prop (make sure you save the file).

Could you please try again?

Thanks! This looks like a bug. I also noticed that the popover doesn't remain open when focusing on the cancel button if the combobox input doesn't have an id prop. That's probably a regression. We might've removed the id prop from the combobox component at some point.

Workaround:
const [autoSelect, setAutoSelect] = useState(true);

<Combobox
  autoSelect={autoSelect}
  onChange={() => setAutoSelect(true)}
  onBlur={() => setAutoSelect(false)}
/>

That's probably a regression. We might've removed the id prop from the combobox component at some point.
Why do you think so? For me, it's expected.

It should work like that out of the box. And it used to be:
https://github.com/ariakit/ariakit/blob/f1af487ef872388dc3234be4b5e741960d9e8467/packages/ariakit/src/combobox/combobox.ts#L347-L349
That default id prop was removed from the combobox by mistake at some point before we had tests for the combobox cancel component.
If hiding the popover when focusing on the cancel button is desirable behavior, there should be a more explicit way to do so. Omitting the id is definitely not a good API, and that's not intentional. Are you relying on that?

No, in fact, keeping it open is the desired behavior. That's why I'm specifying one.

@diegohaz, the inconsistency reported in this issue is still present in the next 37. This PR's point is that using the keyboard or mouse leads to different results.

Steps to reproduce the bug

Open sandbox: https://codesandbox.io/s/polished-worker-5ugu3i
Type "a"
Press tab
Hit enter
Notice no item is now selected
Type "a" again
Now, click on the clear button
Notice the first item remains selected

I can't reproduce 8 anymore in next.37.

The workaround for the bug was the cause of it not working 😵💫:

I can confirm it fixed the issue indeed. Thank you!


Remove version: Jackett.Jackett version 0.20.2113

404 - release deleted
Microsoft Reviewers: Open in CodeFlow

URL: https://github.com/Jackett/Jackett/releases/download/v0.20.2113/Jackett.Installer.Windows.exe
Response Error: The remote server returned an error: (404) Not Found.
(Automated message - build 917)


GoViral + refactoring and tests

add GoViral data retrieval
add filedir-based tests for all data retrieval modules
remove some uses of TemporaryFile in favor of StringIO
refactor duplicated code to methods

@madprime merging this, review at your leisure :)


Hydration mismatch for useId

Environment

Operating System: Darwin
Node Version:     v18.17.1
Nuxt Version:     3.10.1
CLI Version:      3.10.0
Nitro Version:    2.8.1
Package Manager<EMAIL_ADDRESS>Builder:          -
User Config:      nitro, devtools, experimental, runtimeConfig, components, app, css, modules, shadcn, tailwindcss, image, imports, build
Runtime Modules<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Build Modules:    -

Reproduction

Describe the bug
I got this warn when fully reload the page that use useId composable.
Additional context
No response
Logs
No response

I've had that in my project when using client-only and fallback inside of it (needed to render empty input). Fixed by removing client-only and by relying on hydration end.

I have a reproduction link here: https://stackblitz.com/edit/github-rq89e8?file=app.vue,components%2FTestId.vue
This way you don't get the hydration mismatch warning, but you still get the warning added here
[nuxt] `useId` is not compatible with components that have `inheritAttrs: false`.

We need the ability to v-bind attrs to the root element as useId needs to access them when it hydrates.

We need the ability to v-bind attrs to the root element as useId needs to access them when it hydrates.

Why do you need them on the root element?
It's not uncommon to have custom form elements that have a wrapper div with input/label nested inside where you need the attrs to be bound to the input.
And even then, the attributes are still available (just not on the root element), no?

Why do you need them on the root element?

It is because of the mechanics of how we ensure a stable ID that matches between server and client. Of course there are other locations they could be stored, but how can the composable 'know' where to access them?

how can the composable 'know' where to access them?

maybe we can pass a ref of the element we use it on as an optional argument to the composable ?

I believe it's because of how the useId composable was implemented, it had different separators. It is fixed in this commit.

It is still producing this issue as of nuxt 3.11.0, the problem is that the return statement at the bottom of the packages/nuxt/src/app/composables/id.ts file has a different separator than the one specified at the top in a constant
const SEPARATOR = '-'
.
.
.
// this line needs to be changed to use SEPARATOR instead of the hardcoded _ character
return key + '_' + nuxtApp._id++

@manniL can you fix this as well please?

@gregdev00 no, see https://github.com/nuxt/nuxt/pull/26315

Can this be closed then?

I'm still getting this error in various components (not all):
  - rendered on server: id="nnOfIU4QIk8-0"
  - expected on client: id="nnOfIU4QIk8_0"

There still seem to be cases, where a different seperator character used (- vs _ ).
I think it happens in dynamically loaded components.

 useId might not work correctly with components that have inheritAttrs: false.
`
What is the best way to use useId with inheritAttrs: false !?


Roll engine 5e474ee860a3..8d046faf95b3 (8 commits)

https://github.com/flutter/engine/compare/5e474ee860a3...8d046faf95b3
git log 5e474ee860a3..8d046faf95b3 --first-parent --oneline
2020-03-03<EMAIL_ADDRESS>Roll src/third_party/skia ded437003d0e..b43cfa4d3f96 (7 commits) (flutter/engine#16894)
2020-03-03<EMAIL_ADDRESS>Roll fuchsia/sdk/core/linux-amd64 from 9NHsJ... to uiAI5... (flutter/engine#16893)
2020-03-03<EMAIL_ADDRESS>Const finder missing static const list/map/set fields. (flutter/engine#16896)
2020-03-02<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from q2DAy... to WmA2M... (flutter/engine#16892)
2020-03-02<EMAIL_ADDRESS>Roll src/third_party/skia 470f0637aeea..ded437003d0e (6 commits) (flutter/engine#16891)
2020-03-02<EMAIL_ADDRESS>Revert "Try rasterizing images and layers only once , even when their rasterization fails. Further enforce the same access threshold on layers as on Pictures. Previously layers would always be cached. The latter is a semantic change. (#16545)" (flutter/engine#16889)
2020-03-02<EMAIL_ADDRESS>Roll src/third_party/dart fbe9f6115d2f..0b819161d778 (3 commits) (flutter/engine#16888)
2020-03-02<EMAIL_ADDRESS>Roll src/third_party/skia 9dd0bd78b2d7..470f0637aeea (11 commits) (flutter/engine#16887)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Commit queue failed; closing this roll.


Can't get HTTP headers from stubbed request

New Issue Checklist

[x] I have tried with the latest version of OHHTTPStubs
[x] I have read the README
[x] I have read the Using the right Swift Version of OHHTTPStubs for your project section
[x] I have searched in the existing issues
[x] I have read the OHHTTPStubs wiki to see if there wasn't a detailed page talking about my issue

Environment

version of OHHTTPStubs: 6.1.0
integration method you are using:

[x] Cocoapods
[ ] Carthage
[ ] submodule
[ ] other

version of the tool you use: 1.4.0

Issue Description
I always get request.allHTTPHeaderFields == nil. At least there should be an auto-generated user-agent header.
Here is my stub code with redirection to the same url with substituted headers to set my custom cookie. request.allHTTPHeaderFields == nil in both cases: before and after redirection.
[OHHTTPStubs stubRequestsPassingTest:^BOOL(NSURLRequest * _Nonnull request) {
    return YES;
} withStubResponse:^OHHTTPStubsResponse * _Nonnull(NSURLRequest * _Nonnull request) {
    //allHTTPHeaderFields is always nil
    NSDictionary<NSString *,NSString *> *allHTTPHeaderFields = request.allHTTPHeaderFields;
    return [OHHTTPStubsResponse responseWithData:[NSData data]
                                  statusCode:302
                                     headers:@{@"Location"   : downloadURL,
                                               @"Set-Cookie" : @"cookie_name=value"
                                               }];
}];

Network request code:
AFHTTPSessionManager *sessionManager = [AFHTTPSessionManager manager];
NSMutableURLRequest *request = [NSMutableURLRequest requestWithURL:url];
//.....
NSURLSessionDownloadTask *downloadTask = [manager downloadTaskWithRequest:request progress:nil destination:nil
  completionHandler:^(NSURLResponse *response, NSURL *filePath, NSError *error) {
    //....
}];
[downloadTask resume];

Same for the HTTPBody...

Hi
You've checked the "have read the OHHTTPStubs wiki to see if there wasn't a detailed page talking about my issue" checkbox in your issue description, does that mean that the wiki page that exists there for this exact problem already didn't solve your issue either?

Hi, It sounds like I am having the same / similar issue as the OP is having, but I wanted to clarify that it is.
I have read the issue in the OHHTTPStubs wiki, but it's in reference to the httpBody. I just wanted some clarity that it is the same thing which is happening with request headers?
Test Steps

Login request is made to get an authentication cookie from the server
Cookie is automatically stored in the shared cookie store
Successful logout test is then ran

Expected result:
Cookie is automatically added to the headers, and matcher hasHeaderNamed("Cookie") is successful
Actual result:
Cookie is not automatically added to the headers, is not present on the request and the matcher hasHeaderNamed("Cookie") fails and my stub is not used.

I was confused as to why it wasn't working, but wanted to make sure it wasn't Alamofire, or something I had done incorrectly, so I created my own node.js server to fire my log in and logout requests into and ran the "successful logout" test again - the test passed because sure enough my server logs showed that the cookie was included with the request.
See here my stub for the "successful logout" test:
func stubApiToRespond() {
        stub(condition: isAbsoluteURLString(AuthenticationWebApiDeleteSessionTests.sessionsUrl.absoluteString) &&
            isMethodDELETE() && hasHeaderNamed("Cookie"), response: { (request) -> OHHTTPStubsResponse in
                var response: OHHTTPStubsResponse? = nil
                do {
                    let json = try JSONSerialization.data(withJSONObject: [:], options: .prettyPrinted)
                    response = OHHTTPStubsResponse(data: json, statusCode: 204, headers: nil)
                } catch {
                    XCTFail("Error converting credentials to JSON \(error)")
                }
                return response!
        })
    }

Initialiser:
let configuration = URLSessionConfiguration.default
afManager = Alamofire.SessionManager(configuration: configuration)

Code for logout (delete session):
public func deleteSession(withSuccessHandler aSuccess: @escaping DeleteSessionSuccessHandler,
                              andErrorHandler aError: @escaping DeleteSessionErrorHandler) throws {

        afManager.request(self.sessionsUrl, method: .delete, parameters: nil, encoding: JSONEncoding.default)
            .responseJSON { (response: DataResponse<Any>) in
                if (response.response === nil) {
                    aError(DeleteSessionApiError.Network)
                } else if response.response?.statusCode == 204 {
                    aSuccess(response.result.value as? JSONObject ?? [:])
                } else if response.response?.statusCode == 401 {
                    aError(DeleteSessionApiError.Unauthorized)
                } else {
                    aError(DeleteSessionApiError.HTTP(statusCode: response.response!.statusCode))
                }
        }
    }

Again, I have read the issue in the OHHTTPStubs wiki, but it's in reference to the httpBody. I just wanted some clarity that it is the same thing which is happening with request headers, and that I'm not going mad?

@markalbert I am running into exactly same issue. Did you figure out how to retrieve cookies from the request, within the stub?

I'm hitting this issue as well and curious if anyone has found a workaround? It seems that when URLSession sets the Cookie header automatically from the cookie storage, it does not appear in the request.allHTTPHeaderFields dictionary. If I set the Cookie header manually, it does come through correctly in the stub. I'm guessing that the Cookie header gets applied at a  lower-level than OHHTTPStubs can intercept?


add support to link to and expand individual pricing page faqs

just talked with a user who did not know about the faq where we share specific credit examples
even though the faq link was shared with them
it would be so much easier to support folks and share information if we had the ability to link directly to faq questions, with the answer auto-expanded

and past susan already opened an issue for this, lol
dup of https://github.com/pulumi/pulumi-hugo/issues/1115

Closing as dupe of #1115.


Bump version to 1.0.1

Signed-off-by: Alex Co<EMAIL_ADDRESS>
Summary

Ticket:
What's Changed

Changed

Bump version to 1.0.1.
Update tests and dependencies.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: onimsha
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


fix(portal): explicitly set background color

affects: @fremtind/portal
fixes issue in firefox where white background were not set
closes: #993
📥 Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
☑ Submission checklist

[x] I have read the CONTRIBUTING doc
[x] yarn build works locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

💬 Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc...

updated


it appears files shared with me, which i place in my folders, are unseen by skicka

background/scenario I have two drive accounts,

jon@home: skicka is connected to this account, this account owns someDocs/
jon@family: this account has write access to a jon@home folder, someDocs/

Steps to Reproduce
Step 1: Write & Share a File from Other Acct
jon@family writes a new PDF into someDocs/, this means:

new PDF is owned by jon@family
but jon@home can see it in a drive.google.com web UI[1]

Step 2: Download Said File from Owner Acct
jon@home does:
cd someDocs/ && skicka download someDocs/ ./  # no new PDF appears :(

Debugging & Fixing
I don't see anything obvious in gdrive/gdrive.go logic that explicitly says to avoid sharedWithMe files when downloading. Anything else to look for to help fix this? (Assuming this is indeed an issue with skicka's request)

[1]: because the whole folder and its contents are shared

I have many problems with skicka also not seeing files, though I'm not sure if this is the same bug. All the files in a folder are owned and shared by the same user, but skicka will randomly miss the first few. I am sometimes able to fix it by deleting then restoring those files on Google Drive.


useObserve doesn't support returning a Promise?

You might want to do something async
eg
useObserve(selectedId, async (id) => await updateFoo(id))

But the signatures don't support this
export function useObserve<T>(
    selector: ObservableReadable<T>,
    callback: (e: ObserveEventCallback<T>) => T | void
): void;
export function useObserve<T>(selector: (e: ObserveEvent<T>) => T | void): void;
export function useObserve<T>(selector: Selector<T>, reaction?: (e: ObserveEventCallback<T>) => T | void): void;

This is updated in the latest RC version to use any instead of void for the return type. Please let me know if it's still not working right for you after updating.
The RC version what we're currently using in production in two apps so it should be quite stable, but we're just tightening up some last things in the apps before releasing 1.0.

Could you clarify if an async useObserve also has this caveat that you have to read all observable values before you do anything async?

Yes, it would have the same caveat for the same reason - it tracks observables accessed while running the function, so anything after an await would be run after it's stopped tracking.


Fix for calling PieChartData(xVals: nil, dataSet: dataSet) giving the…

… following warning:
"One or more of the DataSet Entry arrays are longer than the x-values array of this Data object."
Cause is that when xVals is used, if it's nil then it is set to an empty array. Later on when it is used, the warning is emitted because dataSets[i].yVals.count > _xVals.count

The warning is good; If you don't have x-indexes, the chart will not calculate positions correctly. That's a "limitation" currently, that you must specify the x-indexes, but we hope it will be lifted soon.
Anyway, your fix will just break other things :-)


Duplicate element in subsetting

The mesh in the seam section seem to sometimes include a two nodes that are almost at the same spot. See https://github.com/noaa-ocs-modeling/SurgeTeamCoordination/issues/143#issuecomment-1844362533
And example in a local test is:
File seam_mesh.2dm
ND 7855 -7.7202011351507991E+01 3.5937568127835952E+01 0.0000000000000000E+00
ND 7856 -7.7202011351507991E+01 3.5937568127835959E+01 0.0000000000000000E+00

which then reappears in the final mesh as:
ND 1897211 -7.7202011351507991E+01 3.5937568127835959E+01 2.1569783265873127E+01
ND 1897212 -7.7202011351507991E+01 3.5937568127835952E+01 2.1569783265877248E+01

This issues seems to be coming from the geometry (shape) used for meshing the seam region (image in UTM17):

The issue seems to go away after dropping extra verts:
https://github.com/noaa-ocs-modeling/OCSMesh/blob/0563a791035cf7f69ee35234ac5c2392d62fdbe2/ocsmesh/cli/subset_n_combine.py#L644-L644
but reappears in poly_seam_8 (the final version) again due to operation:
https://github.com/noaa-ocs-modeling/OCSMesh/blob/0563a791035cf7f69ee35234ac5c2392d62fdbe2/ocsmesh/cli/subset_n_combine.py#L660-L661

After the number of layers fix, if I use 8 layers, I do not get the issue with duplicate nodes, but with 9 I do!! WHY?!


The "sql elapsed time" metric for informix Db is not getting displayed on. UI intermittently

When we are implementing the "sql elapsed time" metric for informix Db, we notice that sometimes, the complete list of data is not getting displayed on UI.However, we see that those metrics are getting printed in the sdk logs completely. This issue is happening intermittently. Can you let us know any insights into this? It seems to be a Backend/UI issue .
UI

Logs

do you have unique id for different sql statement?


Indirect CSP

Hi
I just want to confirm my readings are correct that this cannot be done as an Indirect CSP?
We are an indirect CSP and have implemented this but now struggling with Partner Center Configurations where our research suggests as an Indirect CSP we cannot use as the reference to finding the relevant details in the Cloud App Management is not a feature for Indirect CSP.
Can you pls confirm?   Any other ways out there to be able to get a single view of all tenants Security Score? Its a great value add

@shnax1 with the design of this solution it will not work for indirect resellers. However, I am in the process of retiring this project because it is being replaced by Security and Management Insights Connector. This new project will work with the indirect reseller channel. With this in mind, I would like to encourage you to review that project and open any feature request if there are additional items you are interested in seeing.


Release mode uses unsupported shader model

Describe the bug
On my last gen 980m I can't run the latest shader model. In debug it works fine as it goes down to a previous shader model however when running in release the demo crashes as the shader model used isn't supported.
To Reproduce
Set Solution configuration to Release on a 980m and run the demo
Expected behaviour
A clear and concise description of what you expected to happen.
The program will assert and give a DX error message in the output exclaming the shader model is not supported.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Hardware CPU:6700HQ, GPU:GTX 980m, RAM:32GB]

Additional context
Add any other context about the problem here.

Is it possible that you're trying to run it with the integrated GPU which doesn't support the latest shader model?

spellings control changed reconfigure to deconfiture. 👍


Add Epoch to B9-PWings-Fork

Mod went from 2.1 to 0.40.3 when it upgraded for 1.1

Ah ok, 2.1 was an unofficial mirror of B9 PWings while now they're issuing their own releases under 0.40.X


Spanner: Aborted batch dml should be retried

When executing batchDml statements, it is possible that the transaction is aborted by Spanner for one of the statements. This used to throw a SpannerBatchUpdateException, which would cause the transaction to fail, while the appropriate exception is AbortedException to trigger a retry of the transaction.

@olavloite LGTM after running code formatting


TypeScript typings

Typings I wrote while implementing react-rating in a project.

Thanks for the TypeScript declaration!

Released in version 1.1.0.


migrate from databaseUsername to databaseAccount and fully use MariaDBAccount

This moves heat to fully use MariaDBAccount based on the dev work being done for mariadb-operator:
https://github.com/openstack-k8s-operators/mariadb-operator/pull/184/files
Lead Jira: OSPRH-4095

[x] controller calls EnsureMariaDBAccount up front to make sure MariaDBAccount is present
[x] error code from EnsureMariaDBAccount is handled, Conditions are amended when error is returned
[x] controller calls NewDatabaseForAccount instead of NewDatabase
[x]  GetAccountAndSecret is used to retrieve account /secret to populate template
[x]  GetDatabaseByName() , normally used for delete finalizers, replaced with GetDatabaseByNameAndAccount
[x]  CreateOrPatchAll() used to patch the Database, replacing CreateOrPatchDB / CreateOrPatchDBByName
[x]  controller calls DeleteUnusedMariaDBAccountFinalizers when launched pods are definitely running on a new MariaDBAccount, returns error code if present
[x]  PasswordSelectors that refer to database are removed
[x]  all databaseUser replaced with databaseAccount inside of all XYZ_types.go
[x] all databaseUser replaced with databaseAccount inside of all kuttl/*.yaml
[x] all default databaseUser names become databaseAccount, replacing underscores with dashes inside of all XYZ_types.go
[x] all default databaseUser names become databaseAccount, replacing underscores with dashes inside of all kuttl/*.yaml
[x] MariaDBAccountSuiteTests are used in controller ginkgo tests if it has them
[x] Use configsecrets for database URLs; remove from job hash
[ ] 184 is merged and replaces from go.mod are removed

Depends-On: https://github.com/openstack-k8s-operators/openstack-operator/pull/656

@gibizer if you want to look at this one, with a few of these that had database username/password sent as env to all job templates, I had to change that since a rotation of username/password meant the dbsync job would run again, etc.   I moved these to use configmaps with a "databaseConnection" token containing the URL in them the way nova/neutron/keystone do, but also, I moved from "configmap" to "configsecret" (also how you can see keystone doing it already) since these contain passwords in them and the whole point of what we're doing is trying to increase username/password security.   so that has implications for the volume mounts which become "secret" mounts.    designate is another one where I did this, which i haven't updated to the latest yet.


[Request(s)] - Dark Mode and Roadmap

Loving the work so far, and I know it's super early days, but I was hoping for two things.

Dark Mode version of the character sheets.
And:
Some sort of roadmap. This doesn't need to be completely accurate, or explain what is being worked on next (as nice as that would be), but just a list of all features planned.

Thanks for your hard work, and looking forward to whatever comes of this.

 The goal right now is to add in as much as we can to best support the system mechanics, and to make the game smoother to run on Foundry.
As for a roadmap, there's one pinned in the online-tools channel of the EN World Discord server, but I can post you some notes here. These are the high-priority features which are still outstanding, but it's not an exhaustive list of everything to come:

Damage scaling based on spell level and resource consumption.
An Active Effects interface.
The ability to configure the roll process when activating an item.
Item subtypes with specialised configuration for each (partially completed)
More detailed filtering options and automatic sorting options (partially completed)
Further automated resource consumption
Improvements to the system forms
A suite of hooks to aid in system extensibility through modules
A collection of system compendia containing A5e monsters, items, features, and spells.
A built in action HUD for both players and Narrators.

This is fantastic. Joined the Discord to keep up with it. I'm excited, thank you so much! :D

Closing this issue in favour of a more specific sheet colour configuration issue: #138.


Issues running in Docker on Raspberry Pi

SerialPort version: 4.0.7
NodeJS Version: 4.2.1
Operating System and Hardware Platform: armhf flavor of alpine linux 3.5 running in docker 1.13.0 on a Raspberry Pi 3 Jessie
Are you using an alternative NodeJS runtime? (eg Electron):
node 7.5.0 compiled on the above platform
Summary of Problem
Can't get serialport to read ports through a docker device mount on a armhf build of node on the armhf alipne image.
Steps and Code to Reproduce the Issue
listPorts.js
var serialport = require('serialport');

// list serial ports:
serialport.list(function (err, ports) {
  ports.forEach(function(port) {
    console.log(JSON.stringify(port,undefined,4));
  });
});

package.json
{
  "name": "serial-test",
  "version": "0.0.0",
  "description": "A test bed for the 'serialport' library",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "Arun Kalahasti",
  "license": "ISC",
  "dependencies": {
    "serialport": "^4.0.7"
  }
}

terminal commands:
To install depenedcies and build serialport from source in a removable container
$ docker run --device /dev/ttyACM0:/dev/ttyACM0 -it --rm -v "$PWD":/usr/src/app/ -w /usr/src/app/ arunk3001/armhf-node:7.5.0-alpine sh -c 'apk add --no-cache make gcc g++ python linux-headers udev && npm install serialport --build-from-souce=serialport'

returns no output
$ docker run --device /dev/:/dev/ -it --rm -v "$PWD":/usr/src/app/ -w /usr/src/app/ arunk3001/armhf-node:7.5.0-alpine node listPorts.js

Running without docker
$ node listPorts.js
{
    "comName": "/dev/ttyACM0",
    "manufacturer": "Arduino__www.arduino.cc_",
    "serialNumber": "Arduino__www.arduino.cc__0043_7543932373535141E0B2",
    "pnpId": "usb-Arduino__www.arduino.cc__0043_7543932373535141E0B2-if00",
    "vendorId": "0x2341",
    "productId": "0x0043"
}
{
    "comName": "/dev/ttyAMA0"
}

most progress I made
$ docker run --device /dev/ttyACM0:/dev/ttyACM0 -it --rm -v "$PWD":/usr/src/app/ -w /usr/src/app/ arunk3001/armhf-node:7.5.0-alpine node listPorts.js
(node:1) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'forEach' of undefined
(node:1) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

I've made some further progress.
I realized that some of the alpine dependencies might be required at run time, not just for building so I made an image which kept those dependencies as well as the npm install.
$ docker run -w /usr/src/app/ arunk3001/armhf-node:7.5.0-alpine sh -c 'apk add --no-cache make gcc g++ python linux-headers udev && npm install serialport --build-from-souce=serialport'
$ docker commit armhf-node-serialport

Now I can do:
$ docker run -v /dev:/dev -it --rm -v "$PWD":/usr/src/app/ -w /usr/src/app/ armhf-node-serialport sh -c 'node listPorts.js'
# output:
{
    "comName": "/dev/ttyACM0"
}
{
    "comName": "/dev/ttyAMA0"
}

Unfortunately, this output is still missing the details run without docker.

It seems some application in the stack is not able to show the information using udevadm. I'm not sure if that's docker, alpine, or some configuration I'm getting wrong. Either way, it seems I have gotten working results using the docker image I built and the aforementioned list, but connecting to and reading from a serial port required me to run the container with the --privileged flag on docker. Using the --device flag with a specific com port works, but I had been hoping to discover the expected connection as part of my startup process.
I'm leaving a link to the docker image in case it proves useful to someone hunting for help later:
https://hub.docker.com/r/arunk3001/armhf-node-serialport/

As you guys surely have more experience with serial connections than me, can I ask if there is a way to manually fetch device information based on comName?

I have the same issues. Here is the output of the udevadm command that this library runs udevadm info --query=property -p $(udevadm info -q path -n /dev/ttyUSB0):
DEVNAME=/dev/ttyUSB0
DEVPATH=/devices/platform/soc/3f980000.usb/usb1/1-1/1-1.5/1-1.5:1.0/ttyUSB0/tty/ttyUSB0
MAJOR=188
MINOR=0
SUBSYSTEM=tty

There are no extra attributes returned. After some digging I found the workaround: start your container with -v /run/udev:/run/udev:ro - it gives read-only access to udev data. Now all works as expected:
DEVLINKS=/dev/serial/by-id/usb-FTDI_FT232R_USB_UART_A6028MS6-if00-port0 /dev/serial/by-path/platform-3f980000.usb-usb-0:1.5:1.0-port0
DEVNAME=/dev/ttyUSB0
DEVPATH=/devices/platform/soc/3f980000.usb/usb1/1-1/1-1.5/1-1.5:1.0/ttyUSB0/tty/ttyUSB0
ID_BUS=usb
ID_MODEL=FT232R_USB_UART
ID_MODEL_ENC=FT232R\x20USB\x20UART
ID_MODEL_FROM_DATABASE=FT232 USB-Serial (UART) IC
ID_MODEL_ID=6001
ID_PATH=platform-3f980000.usb-usb-0:1.5:1.0
ID_PATH_TAG=platform-3f980000_usb-usb-0_1_5_1_0
ID_REVISION=0600
ID_SERIAL=FTDI_FT232R_USB_UART_A6028MS6
ID_SERIAL_SHORT=A6028MS6
ID_TYPE=generic
ID_USB_DRIVER=ftdi_sio
ID_USB_INTERFACES=:ffffff:
ID_USB_INTERFACE_NUM=00
ID_VENDOR=FTDI
ID_VENDOR_ENC=FTDI
ID_VENDOR_FROM_DATABASE=Future Technology Devices International, Ltd
ID_VENDOR_ID=0403
MAJOR=188
MINOR=0
SUBSYSTEM=tty
TAGS=:systemd:
USEC_INITIALIZED=95939112