Flutter crash report

Performing hot restart...
Syncing files to device LM Q610 FGN...
Error -32000 received from application: Service protocol could not handle or find a handler for the requested method.
Oops; flutter has exited unexpectedly.
Sending crash report to Google.
Restarted application in 1,310ms.
Crash report sent (report ID: 365b74e1ae075211)
flutter_03.log
(content)
command
flutter --no-color run --machine --track-widget-creation --device-id=LMQ610TA35997ea --start-paused lib/main.dart

exception
RpcException: JSON-RPC error -32000: Service protocol could not handle or find a handler for the requested method.

package:json_rpc_2/src/client.dart 110:64              Client.sendRequest
package:json_rpc_2/src/peer.dart 79:15                 Peer.sendRequest
package:flutter_tools/src/vmservice.dart 316:13        VMService._sendRequest
package:flutter_tools/src/vmservice.dart 851:60        VM.invokeRpcRaw
===== asynchronous gap ===========================
package:flutter_tools/src/vmservice.dart 872:49        VM.invokeRpc
===== asynchronous gap ===========================
package:flutter_tools/src/vmservice.dart 941:12        VM.runInView
package:flutter_tools/src/vmservice.dart 1455:20       FlutterView.runFromSource
===== asynchronous gap ===========================
package:flutter_tools/src/run_hot.dart 372:24          HotRunner._launchInView
package:flutter_tools/src/run_hot.dart 387:19          HotRunner._launchFromDevFS
===== asynchronous gap ===========================
package:flutter_tools/src/run_hot.dart 458:11          HotRunner._restartFromSources
===== asynchronous gap ===========================
package:flutter_tools/src/run_hot.dart 546:46          HotRunner.restart
===== asynchronous gap ===========================
package:flutter_tools/src/commands/daemon.dart 874:19  AppInstance.restart
package:flutter_tools/src/commands/daemon.dart 544:18  AppDomain.restart.<fn>
package:flutter_tools/src/base/context.dart 153:29     AppContext.run.<fn>
===== asynchronous gap ===========================
dart:async/zone.dart 1124:13                           _rootRun
dart:async/zone.dart 1021:19                           _CustomZone.run
dart:async/zone.dart 1516:10                           _runZoned
dart:async/zone.dart 1463:12                           runZoned
package:flutter_tools/src/base/context.dart 152:18     AppContext.run
===== asynchronous gap ===========================
package:flutter_tools/src/commands/daemon.dart 887:20  AppInstance._runInZone
package:flutter_tools/src/commands/daemon.dart 543:32  AppDomain.restart
===== asynchronous gap ===========================
package:flutter_tools/src/commands/daemon.dart 189:34  Domain.handleCommand.<fn>
dart:async/future.dart 224:31                          new Future.sync
package:flutter_tools/src/commands/daemon.dart 186:77  Domain.handleCommand
package:flutter_tools/src/commands/daemon.dart 145:26  Daemon._handleRequest
dart:async/zone.dart 1132:38                           _rootRunUnary
dart:async/zone.dart 1029:19                           _CustomZone.runUnary
dart:async/zone.dart 931:7                             _CustomZone.runUnaryGuarded
dart:async/stream_impl.dart 336:11                     _BufferingStreamSubscription._sendData
dart:async/stream_impl.dart 263:7                      _BufferingStreamSubscription._add
dart:async/stream_pipe.dart 132:11                     _ForwardingStreamSubscription._add
dart:async/stream_pipe.dart 232:10                     _MapStream._handleData
dart:async/stream_pipe.dart 164:13                     _ForwardingStreamSubscription._handleData
dart:async/zone.dart 1132:38                           _rootRunUnary
dart:async/zone.dart 1029:19                           _CustomZone.runUnary
dart:async/zone.dart 931:7                             _CustomZone.runUnaryGuarded
dart:async/stream_impl.dart 336:11                     _BufferingStreamSubscription._sendData
dart:async/stream_impl.dart 263:7                      _BufferingStreamSubscription._add
dart:async/stream_pipe.dart 132:11                     _ForwardingStreamSubscription._add
dart:async/stream_pipe.dart 207:12                     _WhereStream._handleData
dart:async/stream_pipe.dart 164:13                     _ForwardingStreamSubscription._handleData
dart:async/zone.dart 1132:38                           _rootRunUnary
dart:async/zone.dart 1029:19                           _CustomZone.runUnary
dart:async/zone.dart 931:7                             _CustomZone.runUnaryGuarded
dart:async/stream_impl.dart 336:11                     _BufferingStreamSubscription._sendData
dart:async/stream_impl.dart 263:7                      _BufferingStreamSubscription._add
dart:async/stream_transformers.dart 68:11              _SinkTransformerStreamSubscription._add
dart:async/stream_transformers.dart 15:11              _EventSinkWrapper.add
dart:convert/string_conversion.dart 236:11             _StringAdapterSink.add
dart:convert/line_splitter.dart 150:13                 _LineSplitterSink._addLines
dart:convert/line_splitter.dart 125:5                  _LineSplitterSink.addSlice
dart:convert/string_conversion.dart 163:5              StringConversionSinkMixin.add
dart:async/stream_transformers.dart 120:24             _SinkTransformerStreamSubscription._handleData
dart:async/zone.dart 1132:38                           _rootRunUnary
dart:async/zone.dart 1029:19                           _CustomZone.runUnary
dart:async/zone.dart 931:7                             _CustomZone.runUnaryGuarded
dart:async/stream_impl.dart 336:11                     _BufferingStreamSubscription._sendData
dart:async/stream_impl.dart 263:7                      _BufferingStreamSubscription._add
dart:async/stream_transformers.dart 68:11              _SinkTransformerStreamSubscription._add
dart:async/stream_transformers.dart 15:11              _EventSinkWrapper.add
dart:convert/string_conversion.dart 236:11             _StringAdapterSink.add
dart:convert/string_conversion.dart 241:7              _StringAdapterSink.addSlice
dart:convert/string_conversion.dart 312:20             _Utf8ConversionSink.addSlice
dart:convert/string_conversion.dart 305:5              _Utf8ConversionSink.add
dart:convert/chunked_conversion.dart 72:18             _ConverterStreamEventSink.add
dart:async/stream_transformers.dart 120:24             _SinkTransformerStreamSubscription._handleData
dart:async/zone.dart 1132:38                           _rootRunUnary
dart:async/zone.dart 1029:19                           _CustomZone.runUnary
dart:async/zone.dart 931:7                             _CustomZone.runUnaryGuarded
dart:async/stream_impl.dart 336:11                     _BufferingStreamSubscription._sendData
dart:async/stream_impl.dart 263:7                      _BufferingStreamSubscription._add
dart:async/stream_controller.dart 764:19               _SyncStreamController._sendData
dart:async/stream_controller.dart 640:7                _StreamController._add
dart:async/stream_controller.dart 586:5                _StreamController.add
dart:io-patch/socket_patch.dart 1786:41                _Socket._onData
dart:async/zone.dart 1136:13                           _rootRunUnary
dart:async/zone.dart 1029:19                           _CustomZone.runUnary
dart:async/zone.dart 931:7                             _CustomZone.runUnaryGuarded
dart:async/stream_impl.dart 336:11                     _BufferingStreamSubscription._sendData
dart:async/stream_impl.dart 263:7                      _BufferingStreamSubscription._add
dart:async/stream_controller.dart 764:19               _SyncStreamController._sendData
dart:async/stream_controller.dart 640:7                _StreamController._add
dart:async/stream_controller.dart 586:5                _StreamController.add
dart:io-patch/socket_patch.dart 1335:33                new _RawSocket.<fn>
dart:io-patch/socket_patch.dart 856:14                 _NativeSocket.issueReadEvent.issue
dart:async/schedule_microtask.dart 41:21               _microtaskLoop
dart:async/schedule_microtask.dart 50:5                _startMicrotaskLoop
dart:isolate-patch/isolate_patch.dart 116:13           _runPendingImmediateCallback
dart:isolate-patch/isolate_patch.dart 173:5            _RawReceivePortImpl._handleMessage

flutter doctor
[✓] Flutter (Channel stable, v1.7.8+hotfix.3, on Mac OS X 10.14.5 18F132, locale en-US)
    • Flutter version 1.7.8+hotfix.3 at /Users/peteryetti/development/flutter
    • Framework revision b712a172f9 (2 weeks ago), 2019-07-09 13:14:38 -0700
    • Engine revision 54ad777fd2
    • Dart version 2.4.0

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/peteryetti/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/devTools/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 10.3)
    • Xcode at /Applications/devTools/Xcode.app/Contents/Developer
    • Xcode 10.3, Build version 10G8
    • CocoaPods version 1.7.3

[✓] iOS tools - develop for iOS devices
    • ios-deploy 1.9.4

[✓] Android Studio (version 3.4)
    • Android Studio at /Applications/devTools/Android Studio.app/Contents
    • Flutter plugin version 37.1.1
    • Dart plugin version 183.6270
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)

[✓] Connected device (1 available)
    • LM Q610 FGN • LMQ610TA35997ea • android-arm • Android 8.1.0 (API 27)

• No issues found!

Hi . I never got this issue before . But I have a Suggestion that MAYBE can work and it’s Wireless Debugging. In case you're debugging your app on a real Android Device you can debug it without
using a USB Cable hence the name (Wireless Debugging) . This link might help you :
https://android.jlelse.eu/wireless-debugging-through-adb-in-android-using-wifi-965f7edd163a
But this only will work for a Real Android Device but not for an Android Emulator. Maybe you can find a Method for iOS , you can google it. Now as I said this can MAYBE solve it . But yeah I hope this might help.

Closing as there is another the same issue. The fix was landed on master, you can follow #39809. If you experience it after upgrade, please inform about it in #40240.


Random freezes on linux

After some time, the game simply freezes, and nothing can be done except restarting the game. I am using the most recent version of the source, self-compiled.
Injector: cathook's attach script /gamesneeze's toolbox
Distro: Manjaro 21.0.7 Ornara
DE: GNOME 3.38.5 + material-shell
CPU: Intel
GPU: Nvidia

csgo_linux64: /home/me/Coding/Osiris/Osiris/imgui/imgui.cpp:7151: void ImGui::ErrorCheckEndFrameSanityChecks(): Assertion (key_mod_flags == 0 || g.IO.KeyMods == key_mod_flags) && "Mismatching io.KeyCtrl/io.KeyShift/io.KeyAlt/io.KeySuper vs io.KeyMods"' failed.
ERROR: ld.so: object '/home/me/.local/share/Steam/ubuntu12_64/gameoverlayrenderer.so' from LD_PRELOAD cannot be preloaded (wrong ELF class: ELFCLASS64): ignored.
`
Some error-messages from steam (started steam through terminal) after game got freezed & crashed by itself

Also i know the reason why it does crash, For some reason you can change KeyMods in the middle of drawing ImGui frame, still searching for the solution.

@danielkrupinski ?

What have fixed this issue is deleting gnome and installing xfce. Maybe problem was in material-shell but i don't care anymore

Well, i still can get crashed for the same reason, but on XFCE it is happening much rarely than on gnome.  Maybe KDE won't get this issue at all, if someone has the same problem, they should test by yourself.


Add poligran

Add Institución Universitaria Politécnico Grancolombiano
Official URL: https://www.poli.edu.co/
IT program URL: https://www.poli.edu.co/profesional/ingenieria-de-software-virtual
Note: In the footer there are emails with the domain

@davidzapata828 I am sorry, the domain poligran.edu.co is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


[FLINK-6207] Duplicate TypeSerializers for async snapshots of CopyOnW…

This PR fixes a problem for stateful serializers for async snapshots in the CopyOnWriteStateTable. Serializers must be duplicated before they are used in the async snapshot thread.

CC @StephanEwen

Thanks for the fast review @tillrohrmann ! I will let the test extend the TestLogger as suggested and then merge this.


Reading Less than SOCKET_MINIMUM_READ_BUFFER_SIZE?

Is that possible for me to either change SOCKET_MINIMUM_READ_BUFFER_SIZE or read less than SOCKET_MINIMUM_READ_BUFFER_SIZE?
If I allocate only 4 bytes of Data and read from it, what happens if you read more than 4 bytes?

In case someone has the same question.
let buf = 256
var p = UnsafeMutablePointer<CChar>.allocate(capacity: buf)
try socket.read(into: p, bufSize: buf, truncate:true)
let data = Data(bytes: p, count: buf)
p.deallocate()


Docker Desktop 4.6.0 release notes

Proposed changes

Added Docker Desktop 4.6.0 release notes.
Unreleased project version (optional)

Related issues (optional)

I updated with Chris suggestions, thanks!

Updated with latest suggestions!

All right, I think I have addressed everything!


Typo fix in opencart

Line 13: a opencart deployment-> an opencart deployment

/assign @carrodher
the PR #4982 failed to add the cncf-cla label. So I recreate one.

/approve
/ok-to-test
/lgtm


[$250] [Pending/Scanning] The count of pending card transactions on a report is not calculating correctly

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.77-4
Reproducible in staging?:  need reproduction
Reproducible in production?: need reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717026569202759
Details on simulating card transactions below
Action Performed:

Set up workspace with no approvals configured
Assign expensify card to a member on that workspace
Incur a card transaction
Incur another card transaction

Expected Result:
The pending card transaction count should be 2
Actual Result:
Pending card transaction count is 1
Workaround:
unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

View all open jobs on GitHub
Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0179ad48857375d973
Upwork Job ID:<PHONE_NUMBER>668334430
Last Price Increase: 2024-07-29

Internal since you need a card to test. @trjExpensify , I added to  #wave-collect  and set status as Release 2 (since the roadmap doc said 'card support' was then)

Yep! CC: @kevinksullivan @grgia

Waiting to get picked up internally

@trjExpensify what's the (project) priority for this?  Considering how hard I want to push to find an internal volunteer. Thx

Pending/Scanning is high for the summer release. This pending/scanning project is still in dev, so I'm not sure if @grgia's recent work will catch this or it needs to be looked into separately. If it's a frontend issue, I wonder if there's instructions for a contributor to simulate pending card transactions on dev to test we could provide.

Is this still reproducible? This most likely is a FE issue

Assigning to keep track of this for now

Posted in #expensify-open-source

Does anyone know if we have instructions for a contributor to simulate pending card transactions on dev?  I couldn't find anything in SO or searching this room (it's for this GH) (edited)

Since it looks like this might be FE, I'm going to open it up.
Deets on simulating card transactions is here in the #expensify-open-source Slack room

@mallenexpensify could you send an update of where we're at with this issue?

Convo in #qa got derailed a bit cuz of

In short words. Our test account that is linked to our Expensify card is taking a LOT to load in New Expensify.

Checking again about the retest.

I'm not able to reproduce this issue on my side.

The correct amount of pending expenses was displayed in the preview.

@kevinksullivan can you test again to see if you're able to repro?  I'm unsure how to test cards

waiting on retest

here is another example:

There are only 6 expenses on the report, and only one is shown as pending.
This is on<EMAIL_ADDRESS>Here is the report in OldDot

ReportID: R00U97HvvgOn

Hmm weird, let's see how we're calculating these

Hmm weird, let's see how we're calculating these

@grgia , any update on the above?

I haven't had a chance to look at this one yet, I'm OOO thurs/fri but will be able to make any required internal changes on Monday.
@getusha are you able to confirm whether this is a FE or BE bug?

Will look into this first thing tomorrow!

@getusha did you confirm if this is a frontend or backend bug?

@getusha did you confirm if this is a frontend or backend bug?

Following the dev steps i wasn't able to reproduce it, it's showing me the correct amount of pending cards, It might be a BE issue if it still persists with a real card.
https://github.com/user-attachments/assets/9b000f93-75e0-4bde-9172-0fa5f960b3f6
cc @grgia

Posted in the Slack thread to check to see who else is using the card for real world transactions, ie. free lunch

@mallenexpensify yeah if we can test this with a real card that would be great.

if we can test this with a real card that would be great.

@grgia any idea how to do this? I'm more than fine with buying some candy for the bank on my Expensify card, I'm unsure if that'd help here cuz of the first two steps

Set up workspace with no approvals configured
Assign expensify card to a member on that workspace

If it needs to be a new workspace and card, how do we even go about that?

Tagged you in the thread Kevin responded to you.

Thanks Tom, hadn't caught Kev's comment in the thread yet.  I'll see what i can do tomorrow.

FWIW, anyone can test the card transactions on @cardtest.expensify.com . That is how I would recreate this with a workspace that has no approvals.

Checking on in thread

for @cardtest.expensify.com , do you have more details or a link for how that works?
I see the How do I test the Expensify Card on staging or production? SO which states

For now, we are using fake expensify.com accounts, for example you can ask a domain admin to invite<EMAIL_ADDRESS>and use that account to test it.

Is it as simple as creating a GH to get<EMAIL_ADDRESS>invited then to request a card through New or OldDot?
Found this SO too which might be helpful too
I need to test making a real Expensify Card transaction, what do I do?

Checking here

I need to test an expensify card that only has a $5 limit, does anyone know where I can make multiple micro transactions so I can get multiple pending transactions?

Tried a few spots without luck. Will keep thinking.

Got the card setup and made 3 transactions via Paypal, using this SO, but I forgot to create the workspace first so I'm seeing everything in "your space"

I think this is because we are counting the outdated transaction objects. We need to either 1) delete the old parent transaction from ONYX entirely (reportID is set to -4) or filter these out.

Still struggling to reproduce this bug.  Just now followed the steps in the OP

Set up workspace and enable workflows
Navigate to workflows and enable approvals
Assign expensify card to a member on that workspace
Incur a card transaction
Incur another card transaction

This is what  I see

Looking into this https://expensify.slack.com/archives/C036QM0SLJK/p1723032031245939?thread_ts=1723021882.407309&cid=C036QM0SLJK

I've tried testing using Paypal twice and haven't been able to reproduce. I thought I might be able to test today, by purchasing three items at a coffee shop on my Expensify Card but it's not showing in NewDot, only OldDot :/

I 'hacked' my way into view it in NewDot via the report ID,<PHONE_NUMBER>685204,  and in Safari and the transactions are showing as 3 separate.

I thought I might be able to test today, by purchasing three items at a coffee shop on my Expensify Card but it's not showing in NewDot, only OldDot :/

That workspace isn't supported officially on NewDot yet, because it's our Inc policy.

I believe this will be fixed by https://github.com/Expensify/Auth/pull/11941

Now that the auth PR has been deployed, let's retest this.

Actually let's wait on the web PR first https://github.com/Expensify/Web-Expensify/pull/43079

I created 2 transactions on Expense Report #707961321601087 on<EMAIL_ADDRESS>for testing.
$2.00 - TransactionID =<PHONE_NUMBER>917259291
$1.00 - TransactionID =<PHONE_NUMBER>096951689

https://github.com/user-attachments/assets/ad34419b-b71a-453a-8441-184a6f7edfd2
Looks like this is just a simple FE bug where we shouldn't show the "0 expense" part if it's 0

https://github.com/Expensify/App/blob/main/src/languages/en.ts#L754-L755 We can just add a 0 check to this line

Confirming here https://expensify.slack.com/archives/C049HHMV9SM/p1723809488866359?thread_ts=1717026569.202759&cid=C049HHMV9SM

I think we can make it a bit clearer by adding a semi-colon. i.e. Confirming with marketing in the above slack convo
4 expenses: 1 pending, 1 scanning - incl. 2 posted expenses
2 expenses: 1 pending, 1 scanning  - no posted expenses
2 expenses - just 2 expenses

Proposal
Please re-state the problem that we are trying to solve in this issue.
Expense total doesn't include pending or scanning expenses.
What is the root cause of that problem?
You are subtracting the pending and scanning expenses from the total here:
https://github.com/Expensify/App/blob/9940e99abca5b0e7f17c8d29a66df50b2345b8a2/src/components/ReportActionItem/ReportPreview.tsx#L368
What changes do you think we should make in order to solve the problem?
             supportText: translate('iou.expenseCount', {
                count: numberOfRequests,
                 scanningReceipts: numberOfScanningReceipts,
                 pendingReceipts: numberOfPendingRequests,
             }),

if you also decide to add a semi colon then update the copy with a semi colon:
https://github.com/Expensify/App/blob/main/src/languages/en.ts#L754-L755

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e0f61d21e1aedd17

We've landed on total# expenses (x scanning, y pending) as the final pattern

Thanks @grgia , I updated the Expected behaviour in the OP to state

The expense count should show as total# expenses (x scanning, y pending)

Opened a PR here

Expected Result:
The expense count should show as total# expenses (x scanning, y pending)
What I see when testing via this SO with a paypal account on an expensify card.

So I think we're good here... right!??!

PR hit production a few days ago link
@getusha can you confirm it's fixed ?  Thx

So I think we're good here... right!??!

@mallenexpensify yes i think so, all the transactions are pending right (no scanning expense)? before the fix it was showing 0 expenses (3 pending)

@getusha can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01b3d83125b1d4f841
We need to pay via Upwork cuz you were assigned before your eligibility date for NewDot payments.

@mallenexpensify this was created after 2024-05-25 (my eligibility date) so we can use this to knock the remaining $250 i owe https://github.com/Expensify/App/issues/32699#issuecomment-2285081703

@getusha , for this issue, I'm seeing

assigned getusha on Jul 3  - here

And, yes, I see your eligibility date of 2024-05-25

@getusha can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01b3d83125b1d4f841
Also, can you please confirm you have not been paid for this issue via NewDot and that you cancelled any requests you have for payment via NewDot?  Thx

@mallenexpensify accepted

Also, can you please confirm you have not been paid for this issue via NewDot and that you cancelled any requests you have for payment via NewDot? Thx

Yes i haven't been paid via ND

Contributor+: @getusha paid $250 via Upwork
Lastly.. can you fill out the checklist below? I imagine we want a regression test for this, right?
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@] Determine if we should create a regression test for this bug.
[ ] [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@BZ] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[ ]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/34191
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Looks like it was by design at that moment.
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/a
Determine if we should create a regression test for this bug. I don't think there is an easy way to test this for QA

@getusha can you propose regression test steps plz? I agree with you that QA might not be able to test but, if not, I wan to know why so I can possibly update their process/access to allow for testing. Thx

@mallenexpensify QA wasn't able to make transaction using expensify card check this https://github.com/Expensify/App/pull/47745#issuecomment-2306948868

Thanks @getusha I'm going to leave this open for a bit and mark me as the owner.  Working on an internal issue for getting C+ (and possibly QA) access to cards for testing

https://github.com/Expensify/Expensify/issues/423994#issue-2492567759

@mallenexpensify can we close this one

Yup!!!! 📕


Hosted service ObservationPoints/FeatureServer does not have a service definition item

The hosted service "ObservationPoints" item exists 01ba782e2eb3445895d2c81f914977f9 but does not have an associated service definition portal item. Without the service definition item the service won't be published during Ops Server publishing.
NOTE: Only hosted services published from ArcGIS Desktop or ArcGIS Pro, which upload a service definition item to portal, are supported by the ops server config publishing scripts.

@elinz I'll get this cleaned up when we get the ability to publish multipatch buildings to the NSEC Portal. This feature service works in conjunction with a UC presentation I created around the Scene Viewer and without the multipatch buildings the demo is essentially moot...so I'll be tabling this until that's resolved, at which point I'll knock this out.  In the meantime I'll unshare everything so at least others do not see it.

@elinz it doesn't appear I'm going to be able to get data permissions for the main focal point of this demonstration, hence I'm not going to clean this up and have simply deleted it.


Use standardised build system

Not sure why it's waiting for a ci/circleci:build check - there isn't any such check in the workflow for this branch.


Animation tweaks for the Item Collector and Creature Catcher

Two adjustments for special animation effects :)
Item Collector: Smoothed transitions between shrinking and growing in the starry cube special effect https://youtu.be/rEsu1CxpsXg
Mob Catcher: Slowed scaling animation when entity is close to its normal size https://youtu.be/3DHEgiozh8k

Going to redo the PR fork than to fix the conflict


Replace ValidationRule with Cat's Validated

I don't have a particular solution in mind, but I think it's worth to have an opened ticket for this before we forget. I eagerly want to replace Finch's data types with the ones community share and understand. ValidationRule is a good candidate to be reaplced (in some way) with Cat's Validated.

@vkostyukov can you please clarify how exactly do you see this possible?
I don't get it, because finch's ValidationRule is just a some kind of convenient DSL for combining boolean predicates, but cats' Validated is a data type which encodes validation result.

@prayagupd Yes, status should be a part of an error.
In our project services always return F[Either[Error, A]] where Error <: Throwable is a super type that guarantees status, description etc. And then we just fold it into Output using Output.payload or Output.failure

Validation removed in #1471


[REEF-570] VortexTestSuite fails on Mesos

This addressed the issue by

In Vortex, directly create EStage without relying on Tang to avoid duplicate configurations.

JIRA:
REEF-570

I will test and merge on local and Mesos runtimes.


how to generate the dataset_aug_dir?

I can't find the code of the generation of augment dataset,so I don't have ''AIC20_ReID_Cropped" directory.Can you help me?

@Zhanghao5200 Good day to you.  Maybe you can refer to 'AICTIY2020.md'? Follow "prepare_data: step2: use inital model to crop vehicles".

@Zhanghao5200 Good day to you. Maybe you can refer to 'AICTIY2020.md'? Follow "prepare_data: step2: use inital model to crop vehicles".

Thanks!But there is a new error"AIC20_ReID_Cropped/image_query/000001.jpg does not exist".How to solve this problem?

@Xiangyu-CAS
I have arranged data folder as following:
data/ReID/Vehicle/AIC20_ReID
data/ReID/Vehicle/AIC20_ReID_Simulation
And when I run the first step in DataPreparation I got following error.
RuntimeError: '/home/username/data/ReID/Vehicle/VeRi' is not available
@Xiangyu-CAS @Zhanghao5200 How could be solved this problem?

@Xiangyu-CAS I have followed prepare_data: step2. I only can cropped image_train data. But it gives errors for cropping image_query data
OSError: /home/username/projects/re-id/2nd-aicity2020_vehicle_re-id/data/ReID/Vehicle/AIC20_ReID_Cropped/image_query/000001.jpg does not exist

@Xiangyu-CAS @Zhanghao5200
Ok guys. I managed to crop all query, test, train images

@Xiangyu-CAS @Zhanghao5200
Ok guys. I managed to crop all query, test, train images

Good to hear that : )


[DisplayServer] Implement has_hardware_keyboard method for Android and iOS.

For context, this is needed to resolve https://github.com/godotengine/godot/issues/88235 in a way that doesn't harm usability when a physical keyboard is connected.

Just tested it on android and it is working properly.

Is this something that can be implemented for Web too, when using it on mobile devices?

Is this something that can be implemented for Web too, when using it on mobile devices?

If we use this to return from (LineEdit/TextEdit) show_virtual_keyboard when DisplayServer::get_singleton()->has_hardware_keyboard() is true, it will never show the virtual keyboard on Web (android/ios) since it will always return true on Web.

Yeah I'm fine merging this to have the feature for platforms that support it, but we need to be very careful before we rely on it for engine functionality. There are also Windows or Linux tablets with virtual keyboards where this would return true currently, even if no hardware keyboard is attached.

Thanks!


ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))

ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))
I am using python-3.6.5 and Django-2.0.0, getting above error most of the time, please help me out.
Below is the python script that I am using to get content from URL.

Same problem since few weeks !

Please, use StackOverflow to ask this type of questions.


[WIP] Make it work well with automounting

What this patch solves:
make goofys work well with automounting
Issue description:
When using goofys with e.g. x-systemd.automount:

(a). if not in foreground mode (without "-f"), chdir(2) blocks because os.Stat() +
fusermount(1) calls are done in the "Reborn"-ed process, which has called
setsid(2). autofs assumes the access by the reborned process as a normal autofs access, therefore path_lookupat leads to autofs_write. Being blocked before fuse fs mount is problematic because we cannot proceed to fuse fs setup itself.

(b). if in foreground mode (with "-f"), we can reach to fuse server setups because all operations that touches autofs before fuse fs setup are done under the same PGID. But surely it does not return so mount service (which systemd autogenerated) times out. Luckily, we are just doing cd into the mountpoint, so it fails to umount it, and the fuse server servives. Therefore we get to be able to use fuse fs normally, as opposed to (a), where we cannot use it at all.

So I think we have two options without any code change.

(1). tolerate what I described in (b)., with x-systemd.mount_timeout set to some reasonable
value e.g., 10 seconds.
(2). do not support systemd automount support at all

And I chose to suggest this patch (let me say, option (3)) for more flexible goofys use.
NOTE
This depends on https://github.com/jacobsa/fuse/pull/46, so labeling this as [WIP] untill it hopefully gets accepted. CI would fail, though all tests passed in my local env with the patch for jacobsa/fuse.git.

I have not yet tested on various kinds of environments, and I think we better to introduce integration tests for them as well. I'd like some early feedback so before completing them, let me open this PR.
Please review, thanks.

I noticed my original explanation seems incorrect, or at least not accurate. Please let me have some time to dig in and trace the whole process more deeper. At least Reborn-ing before fuse mounting seemed to have led to being blocked, and this patch works well as expected with automounting whether or not goofys is invoked with "-f".

@kahing sorry about leaving this open, I'd like feedback of any sorts if possible :)


fix(llmq): Actually remove old masternode quorum connections

I might be missing smth but it feels like the old code simply doesn't work the way it was expected to. I think it is the reason connection count (and also mem/net usage) on masternodes grows over time (as reported by multiple users) and doesn't recover to previous levels initially after dashd restart.

Do you think you'd be able to implement some tests for this?

Do you think you'd be able to implement some tests for this?

@PastaPastaPasta pls see #4863


fix/identify finish

Added a short time delay after connect, because now with identify and pubsub handshake, tests were finishing before than those handshakes ended, making the streams close before multistream finished.

Is that standard practice in js? In Go we try not to use timings for anything in tests as they are generally unreliable, due to possible CI hickups, load spikes, swap and so on, and thus can cause random failures.

Definitely not a good practice, the alternative is to make some operations lock, which will make things slower for running nodes, but always passing tests in CI.
What we see here is that we drop the listeners so fast that the pubsub multistream handshake doesn't have time to finish.

actually, nvm, thanks @Kubuxu <3


Evaluating on the test set

Is there functionality to evaluate on test set, or dump all images outputs for test set?

Yes.
https://github.com/NVIDIA/semantic-segmentation/blob/main/utils/misc.py#L247
https://github.com/NVIDIA/semantic-segmentation/blob/main/train.py#L224
Let us know if you see issues.

Thanks for pointing it out! I was able to generate some results.


Daisy clock: Battery time remaining varies wildly, not helpful - please revert or give option to change.

Affected hardware version
Bangle 2
Your firmware version
2v23
The bug
The latest version of the Daisy clock app uses 'remaining time until 0%' in Days and Hours for displaying the battery capacity.
This is estimated depending upon the current usage, which means that the values vary wildly and are 100% useless to know when I need to charge the bangle.
Within the last 10 minutes, I had it show anything between 6hours to 120 days.
Please give us back the percentage indicator - at least as an option. I know what to do with those numbers.
(additionally, the long text really looks ugly, I just need a number there with a percent sign, maybe a tiny icon)
Installed apps
Sorry, the list has disappeared from the website (why????) and been replaced by a button that holds the app info. I can paste the link here, but I'm not going to rewrite this bug report that I already made (or login with Chromium to GitHub while I'm actually only using it with the Bangle only, because Firefox can't do WebBluetooth).
https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fespruino%2FBangleApps%2Fissues%2Fnew%3Ftemplate%3Dbangle-bug-report-custom-form.yaml%26fwversion%3D2v23%26apps%3Dbarometer%2520(0.04)%250Acalculator%2520(0.07)%250Acounter%2520(0.04)%250Afileman%2520(0.03)%250Agallery%2520(0.03)%250Ainfo%2520(0.03)%250Aptlaunch%2520(0.15)%250Awclock%2520(0.04)%250Awidlock%2520(0.08)%250Awidtbat%2520(0.02)%250Aabout%2520(0.15)%250Aacmaze%2520(0.05)%250Aactivityreminder%2520(0.12)%250Aagenda%2520(0.15)%250Aandroid%2520(0.36)%250Acalendar%2520(0.18)%250Acompass%2520(0.09)%250Adtlaunch%2520(0.25)%250Agbmusic%2520(0.12)%250Agpsinfo%2520(0.13)%250Ahealth%2520(0.30)%250Ahrm%2520(0.13)%250Ainfoclk%2520(0.10)%250Amessagegui%2520(0.79)%250Amessageicons%2520(0.07)%250Amessages%2520(0.62)%250Amylocation%2520(0.11)%250Anotify%2520(0.14)%250Aopenstmap%2520(0.30)%250Apastel%2520(0.20)%250Apowermanager%2520(0.11)%250Aqcenter%2520(0.05)%250Arandom%2520(0.03)%250Arecorder%2520(0.43)%250Arun%2520(0.19)%250Asched%2520(0.26)%250Asmpltmr%2520(0.09)%250Aweather%2520(0.26)%250Awidalarm%2520(0.02)%250Awidbt%2520(0.09)%250Awidmessages%2520(0.06)%250Awidmp%2520(0.09)%250Alocale%2520(0.19)%250Aac_ac%2520(1.00)%250AUke%2520(0.04)%250Aswiperclocklaunch%2520(0.07)%250Aalarm%2520(0.48)%250Asetting%2520(0.73)%250Aboot%2520(0.63)%250Alcars%2520(0.31)%250Adaisy%2520(0.12)

(the list was useful for more purposes than just for making a bug report...)

Sorry, the list has disappeared from the website (why????) and been replaced by a button that holds the app info.

That's weird. The "Apps Installed" list is still there for me on both the official and development app loader.
The "New issue on GitHub" button is there in addition to the list, not as a replacement. I'f you'd want to use it in the future I just verified it's possible to copy the address from chromium and paste it into firefox and you will auto login and load the issue prefilled.

Please give us back the percentage indicator - at least as an option.

The option is there in the settings: Settings->Apps->Daisy->'Expected Battery Life In Hours' (You'll need to toggle it on and off to get battery % - that's a bug).
@Poolitzer Would you have the time to harmonize the app code and settings code with regards to hours vs percentage left?

Damnit how did I break that. Will have a look tomorrow sorry

Ah, I understood it allowed me to switch between hours and days display. Which wasn't what I wanted. Perhaps it would be possible to rename the option so it's clear that it's 'time remaining' vs. 'percentage charged'?

Confirmed to work now after toggling back and forth.

Sorry, the list has disappeared from the website (why????) and been replaced by a button that holds the app info.

That's weird. The "Apps Installed" list is still there for me on both the official and development app loader.
The "New issue on GitHub" button is there in addition to the list, not as a replacement. I'f you'd want to use it in the future I just verified it's possible to copy the address from chromium and paste it into firefox and you will auto login and load the issue prefilled.

Thanks, and sorry. I don't know why I couldn't find it. I did scroll down completely, and even clicked the button to show advanced options in my search for it. Right now, it's there. Very strange.

Thanks, and sorry. I don't know why I couldn't find it. I did scroll down completely, and even clicked the button to show advanced options

Maybe the app loader had failed to fetch the list from the Bangle? That happens to me sometimes.

@thyttan Thanks, that restores my faith in my sanity a bit :)

Btw. do you take feature requests for Daisy? I've been looking into the code, and I think I even found the place where I'd need to 'hook the change I'd like in', but ... I don't think I could do it myself in a reasonable amount of time.
I would like a setting to choose where to start the cycle, so I do not have to tap 6 times to get the date displayed again every time I have opened the menu.

You're always welcome to open feature requests on the issue tracker 🙂
There's no guarantee on if/when a request gets implemented. Depends on if someone else finds it worthwhile.
If you're eager to have it implemented I'd recommend giving it a shot  yourself. You could open a draft pull request to ask for pointers and feedback.
Some tutorials:

https://www.espruino.com/Bangle.js+Development
https://www.espruino.com/Bangle.js+App+Loader

@Moini feel free to ping me on 05th if you want me to implement your feature request, till then quite busy

Thanks all for the help!
As for the feature request, I don't think I'll find the time to learn enough Bangle scripting to make this work, but I've opened an issue about it.


formal argument cannot be an instance variable in be.rb:99

I am using jruby-<IP_ADDRESS>, rspec 0.9.4
when I run bundle exec rspec, an error occurs, this does not happen when I am using jruby-1.7.22 with same rspec version.
SyntaxError: /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-0.9.4/lib/spec/matchers/be.rb:99: formal argument cannot be an instance variable
            ["be_an_","be_a_","be_"].each do |@prefix|

               require at org/jruby/RubyKernel.java:939
                 <top> at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-0.9.4/lib/spec/matchers.rb:1
               require at org/jruby/RubyKernel.java:939
                 <top> at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-0.9.4/lib/spec/matchers.rb:1
               require at org/jruby/RubyKernel.java:939
                 <top> at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-0.9.4/lib/spec.rb:1
               require at org/jruby/RubyKernel.java:939
                 <top> at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-0.9.4/lib/spec.rb:3
               require at org/jruby/RubyKernel.java:939
                 <top> at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/webmock-0.9.1/lib/webmock/adapters/rspec.rb:1
               require at org/jruby/RubyKernel.java:939
       block in (root) at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/webmock-0.9.1/lib/webmock/adapters/rspec.rb:2
                  each at org/jruby/RubyArray.java:1560
                (root) at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/webmock-0.9.1/lib/webmock/rspec.rb:1
       block in (root) at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/webmock-0.9.1/lib/webmock/rspec.rb:1
                  each at org/jruby/RubyArray.java:1560
                (root) at /Users/zweng/workspace/racy-conversion-facebook/spec/spec_helper.rb:1
                (root) at /Users/zweng/workspace/racy-conversion-facebook/spec/spec_helper.rb:19
                (root) at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1
             requires= at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1280
             requires= at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1280
  process_options_into at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.3.2/lib/rspec/core/configuration_options.rb:109
                 <top> at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/lib/ruby/gems/shared/gems/rspec-core-3.3.2/lib/rspec/core/configuration_options.rb:108
                  load at org/jruby/RubyKernel.java:957
                 <top> at /usr/local/var/rbenv/versions/jruby-<IP_ADDRESS>/bin/rspec:23

nvm, I have used the wrong version of gem.. should be using rspec 3.3.0


"Permission denied" running er-patcher

Describe the bug
Running any seemingly valid er-patcher command seems to result in the same issue:
$ er-patcher -- %command%
/etc/profiles/per-user/username/bin/er-patcher:133: DeprecationWarning: pathlib.Path.link_to() is deprecated and is scheduled for removal in Python 3.12. Use pathlib.Path.hardlink_to() instead.
  f.link_to(game_dir_patched / f)
Traceback (most recent call last):
  File "/etc/profiles/per-user/username/bin/er-patcher", line 138, in <module>
    subprocess.run(steam_cmd, cwd=steam_cmd[-1].parent.absolute())
  File "/nix/store/65cp4izx3bllnwqn7c7dhrq9h9gmjkal-python3-3.10.9/lib/python3.10/subprocess.py", line 503, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/nix/store/65cp4izx3bllnwqn7c7dhrq9h9gmjkal-python3-3.10.9/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/65cp4izx3bllnwqn7c7dhrq9h9gmjkal-python3-3.10.9/lib/python3.10/subprocess.py", line 1847, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
PermissionError: [Errno 13] Permission denied: PosixPath('/mnt/foo/SteamLibrary/steamapps/common/ELDEN RING/Game/er-patcher-tmp/eldenring.exe')

Steps To Reproduce
Steps to reproduce the behavior:

Verify integrity of game files in Steam
cd into the Elden Ring Game directory
Run er-patcher -- %command%

Expected behavior
Should run the game.
Additional context
I have unpacked Elden Mod Loader 3.2 into my Game folder, in case that's relevant.
See also https://github.com/techiew/EldenRingModLoader/issues/8.
Making the relevant files executable results in a different error, which looks like it's trying to run eldenring.exe directly without WINE:
$ chmod a+x dinput8.dll eldenring.exe er-patcher-tmp/eldenring.exe
$ er-patcher -- %command%
/etc/profiles/per-user/username/bin/er-patcher:133: DeprecationWarning: pathlib.Path.link_to() is deprecated and is scheduled for removal in Python 3.12. Use pathlib.Path.hardlink_to() instead.
  f.link_to(game_dir_patched / f)
Traceback (most recent call last):
  File "/etc/profiles/per-user/username/bin/er-patcher", line 138, in <module>
    subprocess.run(steam_cmd, cwd=steam_cmd[-1].parent.absolute())
  File "/nix/store/65cp4izx3bllnwqn7c7dhrq9h9gmjkal-python3-3.10.9/lib/python3.10/subprocess.py", line 503, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/nix/store/65cp4izx3bllnwqn7c7dhrq9h9gmjkal-python3-3.10.9/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/65cp4izx3bllnwqn7c7dhrq9h9gmjkal-python3-3.10.9/lib/python3.10/subprocess.py", line 1847, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
OSError: [Errno 8] Exec format error: PosixPath('/mnt/foo/SteamLibrary/steamapps/common/ELDEN RING/Game/er-patcher-tmp/eldenring.exe')

Notify maintainers
@IvarWithoutBones
Metadata

system: "x86_64-linux"
host os: Linux 5.15.90, NixOS, 22.11 (Raccoon), 22.11.2203.285b3ff0660
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.11.1
channels(root): "nixos-22.11, nixos-unstable"
channels(username): ""
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Looks like I can't run er-patcher from the command line, but changing the launch options within Steam to er-patcher -c -v -s -- %command% worked. This should probably be documented.


Media Query Selectors not work on extended component

Hi, I was trying to insert media queries in my SCs and found the following behavior a bit weird to me.
I tried to apply my media queries like below, and it worked perfectly:
const myComponent = styled.div`
    @media (max-width: 300px) {
        width: 80px !important;
        height: 80px !important;
    }
`;

Instead, if I try to extend a component, it does not give me any error and it does not get added to the DOM element's styles if I resize my window:
const extendedComponent = styled(originalComponent)`
    @media (max-width: 300px) {
        width: 80px !important;
        height: 80px !important;
    }
`;

Can someone please explain me why this happens and if this is an expected or unexpected behavior?
It is weird because, in my opinion, it should be the same and work at the same way and apply the @media only to the extended component.
Thank you very much.

Does your wrapped component forward the className prop to the element you want to style?

@diondiondion I didn't know that, but yes, it is forwarding:
My current situation is this (with real code) is this:
// File 1
// The hideOnSmallWidth has another purpose
export const GenericButton = styled.div<GenericButtonProps>`
  opacity: ${props => props.visible ? 1 : 0};
  visibility: ${props => props.visible ? "visible" : "hidden"};
  transition: opacity .2s ease-in-out;

  ${props => props.hideOnSmallWidth && css`
    @media ${maxWidthRule(300)} {
      display: none;
    }`
  }
`;

export function ActionButton(props: ActionButtonProps): JSX.Element {
  ...

  return (
    <GenericButton
      visible={props.visible || false}
      onClick={props.onClick}
      style={props.style || {}}
      className={props.name}
      hideOnSmallWidth={props.hideOnSmallWidth || false}
    >
        <SVGInline svg={icons[props.name]} {...(props.svgStyle || {})}/>
    </GenericButton>
  );
}

// File 2

const StyledCentralButton = styled(ActionButton)`
  @media (max-width: 300px) {
    width: 80px !important;
    height: 80px !important;
  }
`;

render() {
    ...
    <StyledCentralButton
        visible
        name={midIcon}
        onClick={this.onStatusChange}
    />
   ...
}

midIcon is a string ("play", "pause", "restart") which I use to determine which icon, inside GenericButton content, to choose. And I chose to pass it also as className even if it does not have any real css attached.
So, yes, it forwards the className.

In ActionButton you don't pass className prop but name one:
className={props.name}

Instead you want to do this:
className={props.className}

I see... I misunderstood. The fact is that I use name as a className because I use it also for icon name. But I think I might also use className as name to represent the icons.
Thank you very much!!


Fixes typos in README.md

Fixes environment typo
Adds missing run command

please point the PR to development, not to the main branch


Create akhilesh-jyotishi.md

Notes for Reviewers
Signed commits

[x] Yes, I signed my commits.

🚀 Preview for commit 8a4bf72665f3472401f6ed62ca01e2cd0e1fddd8 at: https://6736073189dd229f6f5e8d58--meshery-docs-preview.netlify.app


Refactor dns cluster api

TODO:

[x] Create new DnsConfig proto
[x] Update deprecation docs
[x] Update strict dns cluster to consume new dns config
[x] Update logical dns cluster to consume new dns config
[x] Test changes

Commit Message: Refactor DNS cluster configuration in its own extension
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@markdroth @wbpcode Just wanted to check in that I'm going in the right direction

@markdroth I would also appreciate some guidance on what you expect for testing.

Sorry can you provide some context on this?
/wait

Sorry I everybody I messed up my git history

@markdroth I think I'm ready for another review. I'm hoping CI is passing now.

/retest

/assign @Stevenjin8

Is this actually ready for review? Can you submit whatever fixes you know about and I can look?
/wait

/retest

/retest

@Stevenjin8 please resolve merge conflict to get CI results

/wait

I will add that there is a subtle breaking change here.
Before the following cluster config would be valid:
cluster_type:
  name: envoy.cluster.strict_dns # or logical_dns
  typed_config:
    "@type": anything  # but not empty

because Envoy would never try to read the cluster_type.typed_config, but now it will try to cast it to a DnsCluster message which would crash.

/retest

@markdroth ready for another review. I think this implements what we agreed on, with a small change in the semantics of config type vs name lookup in cluster factories.

/retest

Forgot to merge main. Should be ready for another review now (even though not much changed)

/retest

This looks great from an API perspective!
/lgtm api


block fold button on mobile

Looks like logseq moved the block fold button from left to right on mobile devices:
Dev theme:

Logseq default theme:

This seems to be a recent change. I can't find the PR or commit, though.
It might be related to the following:
https://github.com/logseq/logseq/blob/2ca70373af6b7ef9b94df074d0caac3ea99bd849/src/main/frontend/components/theme.css#L117
CC: @UNICKCHENG

Looks like logseq moved the block fold button from left to right on mobile devices:
Dev theme:

Logseq default theme:

This seems to be a recent change. I can't find the PR or commit, though.
It might be related to the following:
https://github.com/logseq/logseq/blob/2ca70373af6b7ef9b94df074d0caac3ea99bd849/src/main/frontend/components/theme.css#L117
CC: @UNICKCHENG

sure, it was already mentioned in a previous issue, and at that time I thought it didn't seriously affect the interaction, so I didn't submit PR. See https://github.com/pengx17/logseq-dev-theme/issues/86
I will try to fix this issue in the next few days.

@UNICKCHENG sorry for the duplicate report. This is a significant complaint for multiple users. It prevents the functionality of being able to focus on a block.  I have attempted to figure out a solution without any luck so far. I am not sure what is overwriting it.

@Bad3r I made some simple attempts, which also seemed to fail. I'll try to solve it later.

https://github.com/pengx17/logseq-dev-theme/pull/94: no success, unless the following code is removed. However, removing the code will cause the bullet threading to fail.
.ls-block div.items-center {
  position: relative;
  height: 26px !important;
}


Custom Adapters

Our data model requires the entries in the user table to point to entries in the partner table via a foreign key reference. It is currently not possible to implement this, with the default db connectors.  It would thus be very helpful to enable users to build their own adapters to work around such limitations.

I was going to say something similar, in my case I am using MongoDB. Maybe some configuration functions to be able to abstract database interaction would be amazing

Hey, I was going through the codebase when I saw the comment. I am not a maintainer but I think you can build your own custom adapter that implement the Adapter in adapter.ts line 26.
And also you can see the way other adapter were implemented too.
export interface Adapter {
	id: string;
	create: <T extends Record<string, any>, R = T>(data: {
		model: string;
		data: T;
		select?: string[];
	}) => Promise<R>;
	findOne: <T>(data: {
		model: string;
		where: Where[];
		select?: string[];
	}) => Promise<T | null>;
	findMany: <T>(data: {
		model: string;
		where?: Where[];
		limit?: number;
		sortBy?: {
			field: string;
			direction: "asc" | "desc";
		};
		offset?: number;
	}) => Promise<T[]>;
	/**
	 * ⚠ Update may not return the updated data
	 * if multiple where clauses are provided
	 */
	update: <T>(data: {
		model: string;
		where: Where[];
		update: Record<string, any>;
	}) => Promise<T | null>;
	updateMany: (data: {
		model: string;
		where: Where[];
		update: Record<string, any>;
	}) => Promise<number>;
	delete: <T>(data: { model: string; where: Where[] }) => Promise<void>;
	deleteMany: (data: { model: string; where: Where[] }) => Promise<number>;
	/**
	 *
	 * @param options
	 * @param file - file path if provided by the user
	 * @returns
	 */
	createSchema?: (
		options: BetterAuthOptions,
		file?: string,
	) => Promise<{
		code: string;
		fileName: string;
		append?: boolean;
		overwrite?: boolean;
	}>;
	options?: Record<string, any>;
}

Yeah, this is doable - you can build your own adapter. I'm currently working on Mikro ORM adapter for Better Auth (I will share it once I finish the adapter and port it to Better Auth repo, and after it passes the test suite), however as far as I can tell, Better Auth doesn't support joins - it just calls adapter multiple times (one call per requested data).


Smart Charging - SetChargingProfile object and data types

Hello @LiorBenAri! This PR looks great, I just have a small issue with a part of it:
OCPI.Net uses contract validators for validating the presense of properties instead of marking properties as required in the contract model. Normally, we define all contract properties as nullable and then use contract validators to check whether a property was null or not. This approach allows us to better distinguish between null vs default values (like 0 for numbers) in incoming data, and also allows us to better form validation error messages in case if some properties did not satisfy the protocol requirements. It also allows us to better validate things like arrays (at least one item present, etc.) and define other specific validation rules.
Can we have this PR updated so that it would not define required properties in contract models but would use validators to check for null values instead?
Here is some OCPI.Net documentation on this topic
And Validators code is located under src/OCPI.Net.Validation/Validators

Hello @LiorBenAri! This PR looks great, I just have a small issue with a part of it:
OCPI.Net uses contract validators for validating the presense of properties instead of marking properties as required in the contract model. Normally, we define all contract properties as nullable and then use contract validators to check whether a property was null or not. This approach allows us to better distinguish between null vs default values (like 0 for numbers) in incoming data, and also allows us to better form validation error messages in case if some properties did not satisfy the protocol requirements. It also allows us to better validate things like arrays (at least one item present, etc.) and define other specific validation rules.
Can we have this PR updated so that it would not define required properties in contract models but would use validators to check for null values instead?
Here is some OCPI.Net documentation on this topic
And Validators code is located under src/OCPI.Net.Validation/Validators

Hi Yuri,
Will edit as you requested.
Lior

Hello @LiorBenAri! This PR looks great, I just have a small issue with a part of it:
OCPI.Net uses contract validators for validating the presense of properties instead of marking properties as required in the contract model. Normally, we define all contract properties as nullable and then use contract validators to check whether a property was null or not. This approach allows us to better distinguish between null vs default values (like 0 for numbers) in incoming data, and also allows us to better form validation error messages in case if some properties did not satisfy the protocol requirements. It also allows us to better validate things like arrays (at least one item present, etc.) and define other specific validation rules.
Can we have this PR updated so that it would not define required properties in contract models but would use validators to check for null values instead?
Here is some OCPI.Net documentation on this topic
And Validators code is located under src/OCPI.Net.Validation/Validators

Hi Yuri,
Will edit as you requested.
Lior

I see that there isn't a validation logic for all of the library objects (for example Session\CDRs objects).
Do you consider adding validation logic for the ChargingProfile objects as mandatory?

Thank you Yuri.
I like you to know that the package is great and it is super helpful for us for our OCPI development!

Thank you :)


multi-stage builds

as multi-stage builds is a thing now (and a useful thing) it is a good idea to provide a sample example (maybe just link)
https://docs.docker.com/engine/userguide/eng-image/multistage-build/

Good call.


Adding Guest Monthly Active Users workbook with ispreview = true

PR Checklist

[ ] Explain your changes, so people looking at the PR know what and why, the code changes are the how.

If adding or updating templates:

[ ] post a screenshot of templates and/or gallery changes
[ ] ensure your template has a corresponding gallery entry in the gallery folder
[ ] If you are adding a new template, add your team and template/gallery file(s) to the CODEOWNERS file. CODEOWNERS entries should be teams, not individuals
[ ] ensure all steps have meaningful names
[ ] ensure all parameters and grid columns have display names set so they can be localized
[ ] ensure that parameters id values are unique or they will fail PR validation (parameter ids are used for localization)
[ ] ensure that steps names are unique or they will fail PR validation (step names are used for localization)
[ ] grep /subscription/ and ensure that your parameters don't have any hardcoded resourceIds or they will fail PR validation
[ ] remove fallbackResourceIds and fromTemplateId fields from your template workbook or they will fail PR validation

@jeffbley this PR is open and almost a year old.  If it still applies it needs to be updated and reopened.


Implement renderInsert for Oracle

Hi, I don't if I should get rid of the duplications between the Postgres module and this one.

@peixunzhang seems that some tests have problems, can you please check?


LFS-1206: Questionnaire/Subject selector does not reset internal state when closed before completion

This PR causes the selected Subject and selected Questionnaire within the New Form dialog to be reset to empty if the New Form dialog is closed without actually creating a new Form.
To test, follow the instructions on https://phenotips.atlassian.net/browse/LFS-1206 on the dev branch to reproduce the bug. After that, build and run the LFS-1206 branch and follow the same instructions as before this time ensuring that by step 8 the New Form dialog is reset to its initial state and there are no initially selected Subjects or Questionnaires.

Now I can create 2 Patient Information forms for the same patient.
I followed the steps. At the end I selected John even though the selection option was grayed out (but was not disabled).
I think I saw this earlier, but was not able to reproduce it.

Bah, I now I can no longer reproduce it again!

Oh, the second bug is related, it seems to be exactly what 1206 is reporting. So the issue isn't fixed.

Confirming bug that @sdumitriu reported.

I have this small complaint, that is probably not worth fixing as it happens only if there is one patient in the system ( and that one is disabled).

lfs mode
create a new Patient Information and a new Patient (make sure there's only one Patient subject in the system, not more)
save, go back to the dashboard
new form, Patient Information, Continue; at this point the only existing patient should be disabled, but also selected

If more than one unavailable patient exist, no patient is selected.

REGRESSION:

create few patients
go to Forms
click on +
select Patient Information form
selection dialog appears

click on NEW SUBJECT
click on CANCE:
expected behaviour: the selection form from the above is presented
actual behaviour: this weird dialog appears

click on NEW SUBJECT again
this dialog appears

type the name of the new patient and click on CREATE
a white screen of death appears with a console error greetings


Cluster migration: User is not able to take a backup after a restore

On master-head - commit id: 5d5ef3f8f and backup-restore tag: v0.0.1-rc9

Take a backup into S3
Deploy Rancher in a HA setup in EKS cluster
Deploy  backup-restore app.
Restore from backup.
Rancher is restored successfully.
Create another backup by creating a backup CR.
No Backup is taken
Error seen in backup-restore-operator logs: E0904 03:36:51.157283       1 reflector.go:178] pkg/mod/k8s.io/client-go@v0.18.0/tools/cache/reflector.go:125: Failed to list *v1.Backup: Unauthorized

I think this will be solved by including the Backup-restore operator CRDs in the resourceSet. Will check this and update the resourceset accordingly

Part of the fix is to include the CRDs for backup-restore-operator in the rancher-resource-set. So that on restore we don't delete them.
And the main reason behind "Unauthorized" errors is the service account tied to the pod.
We configure the operator pod to use the serviceaccount that has cluster-admin role. When this service account is created, k8s also creates a secret associated with it and mounts it in the pod. During restore, since prune is enabled by default, this secret gets deleted.
So if we restore with prune=false we shouldn't see this error. But that leads to the duplicate "Default" and "System" projects issue

Along with a change in rancher-resource-set, the following steps should be used for restoring to a new cluster for the DR use case, which will ensure the operator pod retains its serviceaccount and associated secret

Install the backup-restore-operator on the new cluster using Helm CLI
Restore from backup AND set prune=false
This restore also adds in the secret associated with the helm release of rancher from cluster 1. So run helm upgrade instead of helm install and bring up rancher.

Discussed this offline with @cloudnautique  and there is no need to bring up rancher first on the new cluster and then launch the operator from dashboard, if we're restoring from backup, it makes sense for the operator to bring up the entire setup. Will test these steps once again

Steps

helm install backup-restore-operator-crd rancherchart/backup-restore-operator-crd -n cattle-resources-system --create-namespace
helm install backup-restore-operator rancherchart/backup-restore-operator -n cattle-resources-system
kubectl apply -f migrationResource.yaml where prune=false
Helm3 stores chart release info as a secret, so rancher chart from cluster1 is stored as secret in cattle-system namespace, which gets backed up and created on the new cluster due to restore. So now no need to reinstall rancher, we just need to upgrade it
(If needed, also follow steps to install cert-manager from rancher HA install docs)
helm upgrade rancher rancher-alpha/rancher --version 2.5.0-alpha1 --namespace cattle-system --set hostname= --set rancherImageTag=master-head --set webhook.enabled=false

Verified on master-head - commit id: ad697207

Deploy rancher HA setup.
Deploy a couple of user clusters.
deploy backup restore chart/app in the local cluster.
Take a backup b1 which is saved
Delete the local cluster nodes for this HA setup
Deploy a new RKE cluster (3 nodes all roles). Add this node to the target groups/load balancer.
Install the backup-restore-operator chart on the new cluster using Helm CLI

helm repo add rancherchart https://charts.rancher.io
helm repo update
helm install backup-restore-operator-crd rancherchart/backup-restore-operator-crd -n cattle-resources-system --create-namespace
helm install backup-restore-operator rancherchart/backup-restore-operator -n cattle-resources-system

Restore from backup using a restore CR and prune must be set to false. Like this
Install certs - https://rancher.com/docs/rancher/v2.x/en/installation/k8s-install/helm-rancher/#5-install-cert-manager
Bring up rancher by helm upgrade rancher rancher-alpha/rancher --version 2.5.0-alpha1 --namespace cattle-system --set hostname=<same hostname as first rancher server> --set rancherImageTag=master-head
When rancher comes up, the user clusters come up fine.
Deploy a backup CR.
Backup gets saved successfully in S3.


Updated my 1 click auto installer and tutorial install instructions 8 October 2023

Spent over 2 hours to figure out how to do a fresh install with CUDA Torch GPU support
Updated below tutorial GitHub readme file as well for non-Patreon supporters
AI Music Generation Audiocraft & MusicGen Tutorial with Example (Free Text-to-Music Model)
1 Click auto installer : https://www.patreon.com/posts/84334460

Is this an ad?


remove unneeded unwraps

Note, this slightly changes the pub API, so it should require a minor version bump at least.
There is still an unwrap in a Drop where it's unclear if it can happen or it can be handled better (maybe just ignored?) and an expect in a function where the expect should not happen (it's checked before), and I didn't consider that it's worth adding a new Error kind for this in particular.
Signed-off-by: Petre Eftime<EMAIL_ADDRESS>

Looks good, let's
bors merge


Document how to use with type systems TypeScript/ Flowtype

It is unclear how to define types for proxymissed promises.
Providing these guidelines would encourage broader pattern adoption.

PR open to solve this: https://github.com/kozhevnikov/proxymise/pull/7
I don't know if the project is still maintained. However, feel free to use the fork or copy the d.ts file to your project.

Related: https://github.com/kozhevnikov/proxymise/pull/8

Now there is a @types/proxymise package to have correct typings:
import proxymise from 'proxymise';

function example(): ReturnType<typeof proxymise> {
        return proxymise(foo);
}


bicep link in pre-req points to forked repo

"this Bicep script" points to angerl repo instead microsoft/MicroHack
https://github.com/microsoft/MicroHack/blob/main/03-Azure/01-03-Infrastructure/01_Azure_Virtual_Desktop/Challenges/00-Pre-Reqs.md#setup-your-networking-and-resource-groups-structure

fixed


Problem with PROJECT and PROJECT_NAME sections

Dear aiida-cp2k developpers,
Using cp2k-input-tools to generate parameters from an existing CP2K input file that can then be used in the aiida-cp2k builder, my test calculation failed with the following ABORT message in the aiida.out file :
Keyword PROJECT_NAME in section GLOBAL should not repeat.
input/input_parsing.F:268
Indeed, the aiida.inp generated on the remote computer contains the following section :
&GLOBAL
PRINT_LEVEL LOW
PROJECT aiida
PROJECT_NAME TeO2
RUN_TYPE MD
WALLTIME 19:50:00
&END GLOBAL
The GLOBAL section in the initial (sample) CP2K input file looked like :
&GLOBAL
PROJECT TeO2
PRINT_LEVEL LOW
RUN_TYPE MD
WALLTIME 19:50:00
&END GLOBAL
So it looks like there is some interference between the PROJECT keyword generated by aiida-cp2k. The "GLOBAL aiida" line is apparently not added during the conversion of the sample CP2K input file to a dict by the cp2k-input-tools CP2KInputParserAiiDA.parse() method. It appears instead to be generated later on, when the aiida.inp file is created by the builder.
The CP2K documentation (here) indicates that PROJECT in alias name to PROJECT_NAME and should be intterpreted as such by aiida-cp2k to avoid redundancy.
Thanks for your efforts.
Best regards.
Sylvian

I think that the issue above in fact raises a more general problem which concerns conflicts between sections defined in the original sample CP2K input file, which will be modified by the aiida-cp2k builder to create the aiida.inp file in the calculation folder.
This seems to include (probably not exhaustive list) :

the PROJECT and/or PROJECT_NAME section as defined above
the TOPOLOGY section if builder.structure is defined in the script
the BASIS_SET_FILE_NAME and POTENTIAL_FILE_NAME sections

I am not sure whether this is related to the way I use the program or something else. In any case I avoided the problem the following way in my script :
parser = CP2KInputParserAiiDA()
with open(sample_input_file_name) as fhandle:
inputAsDict = parser.parse(fhandle)
try :
inputAsDict['FORCE_EVAL']['SUBSYS'].pop('TOPOLOGY')
except KeyError:
print('No TOPOLOGY section found in GLOBAL section of the sample input file.')
for key in ['PROJECT','PROJECT_NAME']:
try :
inputAsDict['GLOBAL'].pop(key)
except KeyError:
print('No ',key,'section found in GLOBAL section of the sample input file.')
Construct process builder.
builder = cp2k_code.get_builder()
builder.structure = structure
builder.parameters = Dict(dict=inputAsDict)
Does this seem a correct approach ? Should I expect to see an aiida-cp2k improvement that deals with this issue ?
Best regards.
Sylvian


Reconciliation Test Bench POST

@dev-aravind Commented that the Reconciliation API spec only accepts POST requests but the test bench is currently using GET.  I proposed to the Reconciliation CG that we update the Test bench and they agreed.
Reconciliation CG April 2024 meeting notes:

Does the group agree on issue https://github.com/reconciliation-api/testbench/issues/64 to update testbench to use POST? If so I can work on this.
Yes, and that would be great!

@AbhishekPAnil I propose you make your changes in this forked repo. It is synched with the original testbench. It also deploys on one of our Github pages for testing https://culturecreates.github.io/testbench/. Then we can submit the contribution.

@AbhishekPAnil Your code changes look good, but I am having trouble running the tests (the existing ones) and I am not sure which version of node I should be using. Which version of node did you use and did the existing tests pass?

@AbhishekPAnil Your code changes look good, but I am having trouble running the tests (the existing ones) and I am not sure which version of node I should be using. Which version of node did you use and did the existing tests pass?

Can you try it with node 15.That is mentioned in the workflows.For me it worked with 14 as well.


Fixes issue with ListNotificationsAsync not honouring seenAt date

The seenAt query is incorrectly being appended with a ? instead of & as the query string already contains a ?limit query

Kinds weird, in testing this, the endpoint seems to be reporting that seenAt isn't supported, so not sure if there is a bug on the endpoint too 🤦

The values are now correct via the source generated APIs, so I think we can close this PR. But as you said, that endpoint value doesn't seem to do anything regardless. I'm not going to remove it from the API (it's in the lexicon, and that's a Bluesky problem if it doesn't work) but I can mark that down.


Secure KES Forgetting

What
Implement secure KES forgetting in the node. This task is the first part of the full Secure KES forgetting effort (followed by the KES agent task which will come in the next PI). This task will make the changes such that the node handles the keys properly. However, in this first iteration, the keys will still be saved to disk. These changes do not affect user interaction nor block validation.
Why
We use KES to provide security against long range attacks. This is a requirement by the formal analysis and proofs we have for the consensus algorithm. The current node does not safely delete KES keys, and therefore is exposed to this long range attack where an adversary is capable of stealing a bunch of KES keys from the block producers and producing a different adversarial chain. This first part of the task enable a complete solution that uses KES agents (to be defined in the next PI).
Functional requirements

Implement secure forgetting in the node such that keys are not stored to disk while handling the key (serialisation/deserialisation, key evolution, signature)

External dependencies

Node (to update the usage of the new KES handling)
Benchmarking, to guarantee that there is no regression in block propagation

Risks
Regression in block production (unlikely this will affect block propagation in any meaningful way)
Acceptance Criteria
We have a positive audit accepted by Charles Morgan. The current testing framework works positively. No regression
Definition of Done
The new node version uses KES with secure forgetting
Working Assumptions

Hard fork not required

Closing in favour of #122


Bug: Deleting does not update selection format

Lexical version: 0.7.5
Steps To Reproduce

Toggle bold on
addd some text and hit return to add a new line.
Delete the new line

The current behavior
https://user-images.githubusercontent.com/69976884/215519780-02e1ff06-97a2-4e2e-81c1-7a1f22f781af.mov
The expected behavior
The selection format should have bold toggled on when it goes back to the original line after delete

Here is a high level work around I found.
useEffect(() => {
    return editor.registerCommand(
      SELECTION_CHANGE_COMMAND,
      (_payload, newEditor) => {
        const selection = $getSelection();
        if ($isRangeSelection(selection) && selection.isCollapsed()) {
          const node = selection.anchor.getNode();
          if ($isTextNode(node)) {
            const bold = node.hasFormat("bold");
            const italic = node.hasFormat("italic");
            const underline = node.hasFormat("underline");
            const strikethrough = node.hasFormat("strikethrough");

            if (selection.hasFormat("bold") !== bold) selection.toggleFormat("bold");
            if (selection.hasFormat("italic") !== italic) selection.toggleFormat("italic");
            if (selection.hasFormat("underline") !== underline) selection.toggleFormat("underline");
            if (selection.hasFormat("strikethrough") !== strikethrough) selection.toggleFormat("strikethrough");
          }
        }
        return false;
      },
      COMMAND_PRIORITY_EDITOR
    );
  }, [editor]);

I think the bug is likely related to this code:
https://github.com/facebook/lexical/blob/main/packages/lexical/src/LexicalEvents.ts#L310-L322
Could you see if something in there looks wrong for when you go back to the line. Any help with this would be much appreciated. :)


[BEAM-12575] Upgraded ipykernel from v5 to v6

The upgraded ipykernel now supports the debugger in Jupyter notebooks.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @yeandy
PTAL, thx!


Show Git shortcut inconsistent on Mac

VSCode Version: 1.2.0
OS Version: OS X 10.11.5

Steps to Reproduce:
Show Git command uses Ctrl-Shift while all the other Show commands use Cmd-Shift shortcuts.

Show Explorer - Cmd-Shift-E
Show Search - Cmd-Shift-F
Show Git - Ctrl-Shift-G
Show Debug - Cmd-Shift-D

I think cmd+shift+g is used for find/replace to make it consistent with other mac software.

@dotchev Unfortunately, @alexandrudima is right, it used to be that... but was taken away for consistency with other OS X applications.
You can always overwrite it in your keybindings file, so I'll close this issue.


Creating a state object to pass around for DartIsolate, RuntimeController, etc.

We have some very long parameter lists in ui_dart_state.h dart_isolate.h, runtime_controller.h, and engine.h that basically just get forwarded around from Shell to engine to runtime controller to dart isolate to dart state.
 It should be pretty straightforward to refactor this so that it uses a common object to encapsulate these state items, which could allow for sensible defaults for tests and avoid lots of long parameter lists.
Low priority since we don't add these often and this is just about internal code health.
/cc @jason-simmons @chinmaygarde fyi

I've thought about this before and while creating a state or arguments object (constructed via builder) is certainly doable, there are also a ton of things specified to the isolate constructors that look like a violation of the single responsibility principle. For instance, the Dart isolate constructor taking a reference to the unref queue or image decoders which are rendering concerns. We should also clean those up but putting them inside a virtual context object or something.
This is not to say that we can't do the two things separately though. Its just that refactoring away one might make the second step moot.

This was completed in flutter/engine#26247.


Add logging for existing process. Closes #897

Addresses DX improvement requests in #897 , following create-react-app's flow
Added getProcessForPort.js which is a copy of react-dev-utils/getProcessForPort- I figured if we wanted to add react-dev-utils as a dependency we can swap it in pretty easily

Can we directly use react-dev-utils?

Just added it in @MoOx

@pelhage we are freezing phenomic 0.x currently since our time and resources are limited. So we will add this into next branch instead. Is this a heart breaker for you?

@MoOx If it was a heartbreaker would it change anything? ;) Haha, I don't mind at all. I just wanted to contribute to the project and was drawn to this ticket :)
If there are any feature changes for this ticket just ping me when the time is ready to bring it into the project and I'd be happy to continue / tackle it
Does that mean the same goes for other feature tickets?

@pelhage I just cleaned the opened issue this morning. For now our todo list is in the master branch, NEXT.md :)


Net::OpenTimeout (execution expired) errors when trying to access the API

Since 2021-05-20 I've been getting a bunch of timeouts Net::OpenTimeout (execution expired) when using this gem to access the Prismic API. These happen sporadically but frequently. I cannot reliably reproduce them, but I can reproduce them by just refreshing pages that rely on the Prismic API enough times.
The traceback on the error points to my init_api method which is simply:
def init_api
  Prismic.api(ENV['PRISMIC_URL'], ENV['PRISMIC_ACCESS_TOKEN'])
end

Most of the time this works fine but regularly it will fail. There is nothing in the Prismic status dashboard to indicate an issue with the API endpoint.
You can test this by going to https://www.littlefutures.org/blog and refreshing a bunch of times or trying to click into the various blog posts. Eventually one of them will timeout and 500.
Now, yes I should be handling these exceptions, but also, this never happened before 2021-05-20, I haven't changed any code on or around then. So I'm wondering what is going on. Any ideas?

NB. These errors stopped on 2021-05-28 🤷♂


Various refactoring

Rename alvr_client_core::poll_event() to alvr_client_core::get_event() and corresponding C function from alvr_poll_event() to alvr_get_event(). This function doesn't do any polling and just pops the event from the queue.
Use thread::yield_now() instead of sleep in render loop. 1ms sleep introduces additional 1ms client compositor latency for little benefit, while with yield we give time to other threads (and we have plenty).
Use thread::yield_now() in decoder thread. Same as above, this should help to avoid additional latency and give time for other threads.
Remove "Video frame queue underflow!" when attempting to dequeue a frame and place "Timed out when waiting for frame!" warning when the frame dequeue function timed out. Queue polling triggers this warning lots of times under almost any condition and creates a huge log spam.
Refactor VSync thread to start up with proper frame interval from the beginning.

For verification, CPU/GPU load with sleep():

CPU/GPU load with yield_now():

I'm not sure there is any semantic difference between poll_event and get_event. That is, for me they are interchangeable. I think "poll" is valid used here and clearly opposed to the pattern of event subscription (ie callback).

@deiteris Your change for the vsync thread undoes the fix I did for #1388. We should start generating vsync before the client fps negotiation.

I'm not sure there is any semantic difference between poll_event and get_event. That is, for me they are interchangeable. I think "poll" is valid used here and clearly opposed to the pattern of event subscription (ie callback). OpenXR also uses poll_event with similar semantic and inner workings.

You can check OpenXR's .poll_event() method and see that it actually loops until the event is obtained (i.e., it pools), while our method just gets the result (it doesn't poll itself).

@deiteris Your change for the vsync thread undoes the fix I did for #1388. We should start generating vsync before the client fps negotiation.

But .recv() blocks until the message is received. VSync will not be generated before that, and with the logic, it will generate a VSync with 20ms interval.

You can check OpenXR's .poll_event() method and see that it actually loops until the event of required result is obtained (i.e., it polls for the event), while our method just gets the result (it doesn't poll itself but gives out instant result).

Nope, OpenXR does not work like that. Events are generated and queued internally. A hint for this is the EventsLost event when the internal buffer is full (instead we don't limit the internal buffer).

But .recv() blocks until the message is received. VSync will not be generated before that, and with the logic, it will generate a VSync with 20ms interval.

Exactly, we don't want this behavior. We want to generate vsyncs as soon as the ALVR driver is alive, way before a client is discovered and connected.

Exactly, we don't want this behavior. We want to generate vsyncs as soon as the ALVR driver is alive, way before a client is discovered and connected.

Huh, okay, dropping this one.

Nope, OpenXR does not work like that. Events are generated and queued internally. A hint for this is the EventsLost event when the internal buffer is full (instead we don't limit the internal buffer).

Then it sounds like this method doesn't actually do any polling and I don't understand why it would require a loop to get an event (and return regardless of whether an event was available). But our method is a simple getter either way.

I think this can be merged do you want me to test this first or the ffr pr(option 2)

@Vixea you can test both. FFR pull request will have only cosmetic change a bit later.


Implement improved faceting designs

💡 Description
Update facets to sort alphabetically
⚔ Parent Epic / Related Tickets
No response

duplicate of https://github.com/NASA-PDS/portal-wp/issues/119


Add sse4/avx2 support for fast x86 int8 (vpmaddubsw/vpmaddwd/vpaddd)

Extend the list of different target for x86 topi
Extend tests for conv2d x86 int8 for fast i8 x86 platforms

this change in theory can give up to 2x speedup on int8 models vs fp32 models, currently slightly less
Resnet50 performance:

| Core i7-1185G7 sse4 | Core i7-1185G7 avx2 | Core i7-1185G7 avx512 | Core i7-1185G7 VNNI | Core i7-8700B | Core i5-9400T
-- | -- | -- | -- | -- | -- | --
  | FPS | FPS | FPS | FPS | FPS | FPS
TVM FP32 |   | 53 | 53 | 53 | 54 | 48
TVM int32 |   | 12 |   |   | 16 |
TVM int8 default | 34 | 61 | 92 | 142 | 78 | 62
TVM int8 atvm |   | 70 |   | 134 | 95 | 79

The change in get_fp32_len affected ARM flow - now it started to block by 4 instead previous default 8. It must not affect from performance point of view since NEON SIMD vector size if 64 or 128 bit, but will affect the knowledge database of tuned kernels.
Will verify the performance aspect on ARM. As for backward compatibility - still open question. So far I have an impression that we do not care about it so much.

I verified ARM flow and confirm that it started to use 4 channel values instead of 8 for blocking and this fact did not affect performance  anyhow (as i expected)


internal/retry: export backoff errors

@tutububug please add DCO and fix lint issues.

@tutububug please add DCO and fix lint issues.

ok, I'll close this PR and open a new one(#934) to fix the inspection issues, because of encountered many rebase conflicts.

No need to open a new PR, you can push -f your branch of this PR.
Opening a new PR may cause misleading.

Because the master branch code that this pr is based on is relatively early, it needs to be rebased with the latest master code. During the rebase process, there is a lot of go.mod modifications, so it is directly closed.


feat(router): add payments create-intent flow for v2

Type of Change

[ ] Bugfix
[x] New feature
[ ] Enhancement
[ ] Refactoring
[ ] Dependency updates
[ ] Documentation
[ ] CI/CD

Description

add payments create-intent flow for v2
Additional Changes

[x] This PR modifies the API contract
[x] This PR modifies the database schema
[ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested Manually
curl --location '{{BASE_URL}}/v2/payments/create-intent' \
--header 'api-key: {{API_KEY}}' \
--header 'Content-Type: application/json' \
--data '{
    "amount_details": {
        "order_amount": 100,
        "currency": "USD"
    },
    "profile_id": "{{PROFILE_ID}}"
}'

Response
{     "id": "33333_pay_01924980028e7553a7e8b4960efce1fc",     "amount_details": {         "order_amount": {             "Value": 100         },         "currency": "USD",         "shipping_cost": null,         "order_tax_amount": null,         "skip_external_tax_calculation": "Skip",         "skip_surcharge_calculation": "Skip",         "surcharge_amount": null,         "tax_on_surcharge": null     },     "client_secret": "33333_pay_01924980028e7553a7e8b4960efce1fc_secret_01924980029f761288c93d77ff4e5c32",     "merchant_reference_id": null,     "routing_algorithm_id": null,     "capture_method": "automatic",     "authentication_type": "no_three_ds",     "billing": null,     "shipping": null,     "customer_id": null,     "customer_present": "Present",     "description": null,     "return_url": null,     "setup_future_usage": "on_session",     "apply_mit_exemption": "Skip",     "statement_descriptor": null,     "order_details": null,     "allowed_payment_method_types": null,     "metadata": null,     "connector_metadata": null,     "feature_metadata": null,     "payment_link_enabled": "Skip",     "payment_link_config": null,     "request_incremental_authorization": "default",     "expires_on": "2024-10-01T19:27:59.040Z",     "frm_metadata": null,     "request_external_three_ds_authentication": "Skip" }

DB Entry

Checklist

[x] I formatted the code cargo +nightly fmt --all
[x] I addressed lints thrown by cargo clippy
[x] I reviewed the submitted code
[ ] I added unit tests for my changes where possible

The following tasks will be taken up in a separate PR.

change all fields with  serde_json::Value types in PaymentIntent diesel and domain model to respective struct.
Feature gate struct AuthenticationData and remove struct AuthenticationDataV2
Try to eliminate Intermediate Setter Struct for Constructing Structs with private fields.


feature request: retry fetching page

During tests I observed a couple of times that a fetch failed due to 0 bytes being returned from the server. Since it was not deterministic, a simple "retry" could probably work, but there is currently no way to get that behavior.
The "magic" happens inside the private WebCrawler.processPage()-method. When requesting a retry after fetchResult = pageFetcher.fetchPage(curURL); was performed, the rest of the logic should also still be executed.

Just raising this as a possible improvement for anyone who wants to contribute something :-). Creating a good test for this (using WireMock?) is rather important, but requires some effort I currently can't commit to :-(.


Counties do not work well (if at all)

Counties in the Map view are fundamentally broken. County names are not spelled consistently, and even if they were, most counties share names with different counties in other states (See for example).

Hopefully resolved by fe0d50b


Buffering MB

Hey @elgatito
Elementum is Buffering 386MB on a 1.4GB movie. How can I change that?
I've been using elementum for a few years and it never happened so many MB of buffering,
Thanks!

@tw11st disable setting Adjust buffer according to Kodi advancedsettings.xml, if set.


Sound debouncing: Correct submission is more important

Currently, the debounce of sound effectcs does not consider a hierarchy or "importance".
Ideally, there are more important sounds than others, e.g. in doubt, play the correct submission sound instead of the incorrect one, as this might confuse participants

Currently I'm debouncing two subsequent calls to the submission endpoint with an offset of 100ms (previously 500ms). If within such a call, a correct submission occurs, that submission was and still is prioritised for audio playback.
That's imho all I can do. I cannot debounce the calls to the API based on what the APIs would return.


paranoid-2: Allow to compile code with paranoid compiler flags -Wall -Wextra -Wshadow -Werror -pedantic-errors

infra/erpc_simple_server.cpp: fix declaration of ‘err’ shadows a prev…ious local
erpc_simple_server.cpp: In member function ‘virtual erpc_status_t erpc::SimpleServer::run(erpc::RequestContext&)’:
erpc_simple_server.cpp:181:23: error: declaration of ‘err’ shadows a previous local [-Werror=shadow]
erpc_status_t err = runInternalBegin(&codec, buff, msgType, serviceId, methodId, sequence);
^~~
erpc_simple_server.cpp:169:19: note: shadowed declaration is here
erpc_status_t err = kErpcStatus_Success;
^~~

I will probably be too busy this week to continue improving this one. Please merge as is and I will open a new branch for the next pull request.

I will probably be too busy this week to continue improving this one. Please merge as is and I will open a new branch for the next pull request.

OK, thanks anyway!


smdx_00601.xml uses  instead of

All other smdx use  in strings, this one uses  on some.

Resolved with pull request.


Three things cats like? Only two are given...

The problem says add three li elements for the three things cats like, but the question text lists only two. Yes I'm being picky - I just added a third li called 'something else', and it accepted that, but the question ought to really have a third item (or ask for two).
Challenge Name

https://www.freecodecamp.com/challenges/create-a-bulleted-unordered-list
Issue Description

NA
Browser Information

Latest Safari on Mac

Browser Name, Version:
Operating System:
Mobile, Desktop, or Tablet:
NA

Your Code

NA

Screenshot

NA

@andysouthwell2, that is just an example. If i'm misinterpreting your issue, please reopen!

The point is the example should better match what the user is expected to write - it's a bit confusing. Only my opinion though - if you disagree, fine - not worried - just thought I'd raise it.

I personally think it's too easy to have the example practically identical to the real answer.
cc/ @FreeCodeCamp/issue-moderators

Right, the example is a shopping list, not a list of things cats love. Maybe some cats love cheese? I don't know.
The structure of the example is what should match the user-written code, not the content or number of items.

Exactly @BKinahan 👌. Closing.


Update ConfigDump documentation.

Signed-off-by: Paul Gallagher<EMAIL_ADDRESS>Commit Message: update ConfigDump documentation
Additional Description: ScopedRoutesConfigDump and SecretsConfigDump were missing.
Risk Level: Low
Testing: NA
Docs Changes: Yes
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

CI found some issues with generation of shadow protos from the proto you edited.  Could you run ./tools/proto_format/proto_format.sh fix and push a version that contains the changes made by that script.
/wait

/retest

Please merge upstream/main.  The QUIC coverage failure is deterministic so merging main is needed to fix the CI failure.