PTP support when using CRD

Steps:

Copy multus configration file to /etc/cni/net.d/:

{
    "type": "multus",
    "log_level": "debug",
    "kubeconfig": "/etc/kubernetes/admin.conf",
    "delegates": [{
        "name": "flannel",
        "type": "flannel",
        "masterplugin": true
    } ]
}

Start a single node kubernetes cluster:
sudo -E kubeadm init --pod-network-cidr <IP_ADDRESS>/16

Startup flannel, using .yamls from the upstream coreOS repo:

sudo -E kubectl create -f "../k8s/kube-flannel-rbac.yml"
sudo -E kubectl create --namespace kube-system -f "../k8s/kube-flannel.yml"

Taint master so we can schedule work on it and create a custom resource definition for networks:

master=$(hostname)
sudo -E kubectl taint nodes "$master" node-role.kubernetes.io/master:NoSchedule-
kubectl create -f crd-network.yaml

Where crd-network yaml is:
apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
  # name must match the spec fields below, and be in the form: <plural>.<group>
  name: networks.kubernetes.com
spec:
  # group name to use for REST API: /apis/<group>/<version>
  group: kubernetes.com
  # version name to use for REST API: /apis/<group>/<version>
  version: v1
  # either Namespaced or Cluster
  scope: Namespaced
  names:
    # plural name to be used in the URL: /apis/<group>/<version>/<plural>
    plural: networks
    # singular name to be used as an alias on the CLI and for display
    singular: network
    # kind is normally the CamelCased singular type. Your resource manifests use this.
    kind: Network
    # shortNames allow shorter string to match your resource on the CLI
    shortNames:
    - net

Create a few CRD network types on the system, based on following yaml:

---
apiVersion: "kubernetes.com/v1"
kind: Network
metadata:
  name: ptp-net
plugin: ptp
args: '[
    {
        "name": "ptp-net",
        "type": "ptp",
        "ipam": {
                  "type": "host-local",
                  "subnet": "<IP_ADDRESS>/28",
                  "routes": [
                   { "dst": "<IP_ADDRESS>/0" }
        }
    }
]'

---
apiVersion: "kubernetes.com/v1"
kind: Network
metadata:
  name: br-net-1
plugin: bridge
args: '[
    {
        "name": "br-net-1",
        "type": "bridge",
        "bridge": "br-net-1",
        "ipam": {
            "type": "host-local",
            "subnet": "<IP_ADDRESS>/24"
        }
    }
]'

---
apiVersion: "kubernetes.com/v1"
kind: Network
metadata:
  name: br-net-2
plugin: bridge
args: '[
    {
        "name": "br-net-2",
        "type": "bridge",
        "bridge": "br-net-2",
        "ipam": {
            "type": "host-local",
            "subnet": "<IP_ADDRESS>/24"
        }
    }
]'

Start a pod making use of each of these three networks:

$ sudo -E kubectl create -f ptp-pod.yaml
$ cat ptp-pod.yaml
---
apiVersion: v1
kind: Pod # TODO make these deployments later
metadata:
  name: ptp-test
  annotations:
    networks: '[
        { "name": "br-net-1" },
        { "name": "br-net-2" },
        { "name": "ptp-net" }
    ]'
spec:
  containers:
  - name: ptp-test
    image: "ubuntu:14.04"
    command: ["top"]
    stdin: true
    tty: true

See following networks:

$ sudo -E kubectl exec -it ptp-test  -- bash
root@ptp-test:/# ip a
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
3: eth0@if135: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1450 qdisc noqueue state UP group default
    link/ether 0a:58:0a:f4:00:44 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::5433:ff:fe5f:9145/64 scope link
       valid_lft forever preferred_lft forever

Bring up one more pod, this time not using PTP:

sudo -E kubectl create -f test-pod.yaml
 cat test-pod.yaml
---
apiVersion: v1
kind: Pod # TODO make these deployments later
metadata:
  name: no-ptp-test
  annotations:
    networks: '[
        { "name": "br-net-1" },
        { "name": "br-net-2" }
    ]'
spec:
  containers:
  - name: no-ptp-test
    image: "ubuntu:14.04"
    stdin: true
    tty: true

Network comes up without issue:

$ sudo -E kubectl exec -it no-ptp-test2 -- bash -c "ip a"
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
3: eth0@if146: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default
    link/ether 0a:58:0a:01:0a:03 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::8c3e:a1ff:fed1:8659/64 scope link
       valid_lft forever preferred_lft forever
5: net0@if147: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default
    link/ether 0a:58:0b:01:01:03 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/24 scope global net0
       valid_lft forever preferred_lft forever
    inet6 fe80::2098:afff:febf:fbb0/64 scope link
       valid_lft forever preferred_lft forever

Think I see the issue!

@egernst if you attending the Intel's NFV features in Kubernetes Kubecon session , we doing hands-on session with portable Virutal box, and we giving out Intel USB stick with container exp kit as collateral. The collateral has all ansible script to be deployed.

Sorry, thought it was an issue with the ptp network yaml description, but looks like it should be okay from my perspective.  I'm curious if you have tried this out?  My goal is to be able to post some updated documentation / simple example configurations which can be curl'd for folks getting started with multus.

@rkamudhan -- I wish I was heading down - won't make it.
If you have ansible available now on a gist, etc, that's fine -- please share!   I'd prefer a minimal number of steps and simple examples which are hw agnostic for getting up and running with multus.  I was able to get it up with bridge and SRIOV (details @ https://github.com/egernst/k8s-testing-scripts/tree/master/multus-sriov), but am now having issue with PTP on my end.
I saw PTP using the conf in your README.md, but no examples of in CRD; is this something you've run on your end?

Typo error man.
apiVersion: "kubernetes.com/v1"
kind: Network
metadata:
  name: ptp-net
plugin: ptp
args: '[
    {
        "name": "ptp-net",
        "type": "ptp",
        "ipam": {
                  "type": "host-local",
                  "subnet": "<IP_ADDRESS>/28",
                  "routes": [
                   { "dst": "<IP_ADDRESS>/0" }
        }
    }
]'

should be
apiVersion: "kubernetes.com/v1"
kind: Network
metadata:
  name: ptp-net
plugin: ptp
args: '[
    {
        "name": "ptp-net",
        "type": "ptp",
        "ipam": {
                  "type": "host-local",
                  "subnet": "<IP_ADDRESS>/28",
                  "routes": [
                   { "dst": "<IP_ADDRESS>/0" }
             ]
        }
    }
]'

Multus had error recovery mechanism using default network. Can you send me your conf file ? Whether it having default network? Some user wants this mechanism, for some, it is an issue.

Yep -- that's why I ended up closing the book 30 minutes ago.  As soon as I typed it out I noticed the ].
Lame question -- where are the logs sent for this?  I'll push the files onto a Quickstart.gist later tonight -- may be a good addition to have on the multus-cni site.

Please let me know the PR, I like to include your testing script repo link in the Multus README.md

@egernst Is the network in the pod annotation fails in the creation, then the network from default is picked by Multus ?

That was indeed the case. I ended up seeing it pull up my default from flannel. Thanks for the help!


Composer error

Using version ^2.1 for barzahlen/barzahlen-php
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package barzahlen/barzahlen-php No version set (parsed as 1.0.0) is satisfiable by barzahlen/barzahlen-php[No version set (parsed as 1.0.0)] but these conflict with your requirements or minimum-stability.

Installation failed, reverting ./composer.json to its original content.

Hi @MrKampf,
sadly i cannot reproduce your problem. I've setup a plain fresh Debian 9 with php7 and only installed the following packages there (php7.0-cli, curl, git, zip, unzip) whereas PHP version is 7.0.27-0+deb9u1 and installed the latest composer (like described here) and composers version is 1.6.5 (2018-05-04).
The output looks like this:
~$ composer require barzahlen/barzahlen-php
Using version ^2.1 for barzahlen/barzahlen-php
./composer.json has been created
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 instlal, 0 updates, 0 removals
   - Installing barzahlen/barzahlen-php (v2.1.0): Downloading (100%)
Writing lock files
Generating autoload files

Can it be, that you cloned the repo and then ran composer?

I will close this Issue since i haven't heard back from your for some time now. If you still have this problem, just tell me again.


Bug : installing debian version won't work

Hi,
I followed debian instructions and I have the following error.
➜  gg curl -1sLf \
  'https://dl.cloudsmith.io/public/gitguardian/src-fingerprint/setup.deb.sh' \
  | sudo -E bash
Executing the  setup script for the 'gitguardian/src-fingerprint' repository ...

   OK: Checking for required executable 'curl' ...
   OK: Checking for required executable 'apt-get' ...
   OK: Detecting your OS distribution and release using system methods ...
 ^^^^: ... Detected/provided for your OS/distribution, version and architecture:
 >>>>:
 >>>>: ... distro=ubuntu  version=20.04  codename=focal  arch=x86_64
 >>>>:
   OK: Checking for apt dependency 'apt-transport-https' ...
   OK: Checking for apt dependency 'ca-certificates' ...
   OK: Checking for apt dependency 'gnupg' ...
   OK: Importing 'gitguardian/src-fingerprint' repository GPG key into apt ...
   OK: Checking if upstream install config is OK ...
   OK: Installing 'gitguardian/src-fingerprint' repository via apt ...
 NOPE: Updating apt repository metadata cache ...
Failed to update via apt-get update
Hit:1 http://oem.archive.canonical.com focal InRelease
Hit:2 http://dell.archive.canonical.com focal InRelease
Hit:3 https://download.docker.com/linux/ubuntu focal InRelease
Hit:4 https://apt.releases.hashicorp.com focal InRelease
Hit:5 http://dl.google.com/linux/chrome/deb stable InRelease
Hit:6 http://deb.playonlinux.com precise InRelease
Ign:7 http://ppa.launchpad.net/gnome-terminator/ppa/ubuntu focal InRelease
Hit:8 http://ppa.launchpad.net/maarten-fonville/android-studio/ubuntu focal InRelease
Hit:9 http://archive.ubuntu.com/ubuntu focal InRelease
Ign:10 https://storage.googleapis.com/download.dartlang.org/linux/debian stable InRelease
Hit:11 http://archive.ubuntu.com/ubuntu focal-updates InRelease
Hit:12 http://archive.ubuntu.com/ubuntu focal-backports InRelease
Err:13 http://ppa.launchpad.net/gnome-terminator/ppa/ubuntu focal Release
  404  Not Found [IP: 2001:67c:1560:8008::19 80]
Hit:14 http://archive.canonical.com/ubuntu focal InRelease
Hit:15 https://storage.googleapis.com/download.dartlang.org/linux/debian stable Release
Hit:16 http://security.ubuntu.com/ubuntu focal-security InRelease
Get:17 https://dl.cloudsmith.io/public/gitguardian/src-fingerprint/deb/ubuntu focal InRelease [5 069 B]
Reading package lists...
E: The repository 'http://ppa.launchpad.net/gnome-terminator/ppa/ubuntu focal Release' does not have a Release file.
 ^^^^: ... Failed to update via apt-get update - Context above.
 !!!!: Oh no, your setup failed! :-( ... But we might be able to help. :-)
 !!!!:
 !!!!: You can contact GitGuardian for further assistance.
 !!!!:
 !!!!: URL: https://github.com/GitGuardian/src-fingerprint
 !!!!:

Have I missed something ?
Let me know if you need any further informations.

Hey @SofienM,
It seems the ppa gnome-terminator gets you in trouble.
Can you remove it with sudo add-apt-repository -r ppa:gnome-terminator/ppa and retry the install.
Thanks !

I am closing the issue as the proposed solution solved the problem.

Tks, your solution worked like a charm :+1:


[DNM] docs: bump pdf stable version to release-7.5

Update the stable PDF version of TiDB and TiDB Cloud:

TiDB: the stable PDF version is updated from release-7.1 to release-7.5.
TiDB Cloud: the stable PDF version will remain at release-7.1 to ensure consistency with the current TiDB Cloud documentation.

/cc @Yuiham

/cc @Yuiham

Is this PR ready to be merged?


updated ranking list cell layout

@ccsaposs
Merge conflicts should be the added schema which I added so that you can see what seeding looks like with data.
First column: ranking number (etc 1, 2, 3, 4,)
Second column: team number
Third column: Predicted rank/seeding
Fourth column: Predicted number of total ranking points
Fifth column: Current average ranking point / source of seeding

@ccsaposs


Add support for --tags for flutter test command line flags #32836

Description
This PR adds support for --tags and --exclude-tags for flutter test tool.
Related Issues
#32836
Tests
I added the following tests:
flutter test should run a test with given tag
flutter test should run a test when its name contains a string
in test_test.dart file.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.

@bartektartanus are you still interested in continuing it?

@bartektartanus are you still interested in continuing it?

Sorry for late response. I've pushed another commit, but not sure if done everything right. I will add comments in those places.

@bartektartanus are you interested in continuing with this PR?

Because of the lack of activity on this PR I'm going to close it to remove from our review queue. Please feel free to send us a new PR or discuss in an issue anytime.


Hart Research/Garin Hart Yang

Peter D. Hart Research Associates and Garin-Hart-Yang Research Group should be combined into a single pollster, as discussed in #poll-research

done


hasAria('disabled') throws an error

hasAria() currently delegates to hasAttribute(), but the arguments.length check in hasAttribute() does not work correctly, which makes hasAria('disabled') crash.

Also, considering that isChecked() & isNotChecked() state the following:

This also supports aria-checked="true/false".

Would it make sense to extend isDisabled() & isNotDisabled() with support for aria-disabled="true/false"?
As "just" applying aria-disabled="true/false" has no real effect without the accompanying JS / CSS — clicking an <input type="checkbox" aria-disabled="true/false"> toggles just fine — I would understand, if this addition is not desirable.

good question... I guess right now we're a bit inconsistent in that regard 😞
what I'm wondering is if we should have something like .isChecked({ withAriaSupport: true | false }) and then potentially also a global setting like setup(QUnit.assert, { withAriaSupport: true | false }) 🤔

I've started #1194, which adds the withAriaSupport option.

For future archeologists, .hasAria('disabled', {any: true}) works around the issue (and seems to be part of the typescript description as well).


OpenSSL Segmentation Fault when generating certificate

Segmentation fault on first time CME exec
O.S: Kali 2.*

omg dat font.
Hmm it seems openssl is segfaulting when generating the certificate.
Try running:
openssl req -new -x509 -keyout ~/.cme/cme.pem -out ~/.cme/cme.pem -days 365 -nodes -subj "/C=US"

If that doesn't work, the openssl command utility is broken and you'll need to reinstall it

@McZlatan-Bourne any update on this?

Sorry for the late response, i was hospitalized later on the day i asked the question.
I'm home now.
I ran the command and generated the certificate successfully.
CME works now. THANKS!!!

...and before i forget,
A gift from me to you friend.
*Hangyaboly
http://www.dafont.com/hangyaboly.font

Lol thanks
I'm going to leave this open to remember to try and reproduce the segfault.

Closing since I can't seem to reproduce this in anyway.

I am experiencing the issue even after generating the new key.

If you are in kali: apt install crackmapexec

omg dat font.
Hmm it seems openssl is segfaulting when generating the certificate.
Try running:
openssl req -new -x509 -keyout ~/.cme/cme.pem -out ~/.cme/cme.pem -days 365 -nodes -subj "/C=US"

thanks, it fixed it.


Deep into IP <IP_ADDRESS>

Sealos will involve the VIP <IP_ADDRESS> to handle the multiple net card problem. Refer: https://github.com/labring/sealos/blob/release-v4.0.0/docs/3.0/command/route.md.

If there is a VM with IP <IP_ADDRESS> in the VPC, they are conflicted?
I should avoid assign IP <IP_ADDRESS> to a VM or I need to use another VIP?

If I use sealos to setup two clusters in one VPC, The two VIPs are conflicted?
I should use two different VIPs in different clusters?

If so, is it possible to provide a parameter to the seal run command or Clusterfile  to indicate the ipvs VIP?

If there is a VM with IP <IP_ADDRESS> in the VPC, they are conflicted? YES should not use 10.103 subnet
No conflict in theory.

You don't need to care about this field in most scenarios
For more inquiries please fill out this form


Model Generator script

Summary
While working on the test data model, I had to copy/paste a bunch of files and modify them to create new models. I wrote a simple script which generates a model based on the template to make the developer job easier.
Developers can easily create a new model by running the command.
pnpm create-model <model-name>

pnpm create-model attribute-groups

Generated model based on the template

Let me know if this would be helpful or not. Also, any feedback or suggestions are welcome.

This is something I was already proposing as part of this PR.
Perhaps we can align on this one.


Add endpoint for processing family requests

Address #777
Description
The partner app would like to be able to send requests that are expressed in terms of item ID and persons needing that item. This adds the API endpoint for receiving such requests.
TODO: Add actual logic for calculating quantity per person. Currently method just returns 50.
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

rspec specs
manually calling API routes with cURL

Manual testing steps:

Make sample_data.json - see cat of file below.

$ PARTNER_KEY=foo bundle exec rails s
# in a different shell:
$ cat sample_data.json
{
    "organization_id": 1,
    "partner_id": 1,
    "requested_items": [
        {
            "item_id": 75,
            "person_count": 3
        },
        {
            "item_id": 34,
            "person_count": 3
        }
    ]
}
$ curl -H "X-Api-Key: foo" -H "Accept: application/json" -H "Content-Type: application/json"<EMAIL_ADDRESS>localhost:3030/api/v1/family_requests -v

It should return a 201: Created with a body like this (note that person count has been replaced with actual counts:
{
    "organization_id": 1,
    "partner_id": 1,
    "requested_items": [
        {
            "item_id": 75,
            "count": 150
        },
        {
            "item_id": 34,
            "count": 150
        }
    ]
}

Awesome -- will review when Travis finishes!

Can you create an issue for the TODO work, if there isn't one already?

Can you create an issue for the TODO work, if there isn't one already?

@armahillo That issue is https://github.com/rubyforgood/diaper/issues/785

Does Travis run clean now? The last build had issues

I was able to repro the failures locally:
Failed examples:

rspec ./spec/features/item_spec.rb:53 # Item management User can filter the #index by canonical item
rspec ./spec/features/item_spec.rb:42 # Item management User can filter the #index by category type
rspec ./spec/features/item_spec.rb:33 # Item management User updates an existing item with empty attributes
rspec ./spec/features/item_spec.rb:24 # Item management User updates an existing item
rspec ./spec/features/item_spec.rb:120 # Item management Item Table Tabs > Displays items in separate tabs
rspec ./spec/features/storage_location_spec.rb:23 # Barcode management User updates an existing storage location
rspec ./spec/features/storage_location_spec.rb:32 # Barcode management User updates an existing storage location with empty name
rspec ./spec/features/storage_location_spec.rb:70 # Barcode management Items in (adjustments)
rspec ./spec/features/storage_location_spec.rb:80 # Barcode management Items out (distributions)
rspec ./spec/features/storage_location_spec.rb:41 # Barcode management User can filter the #index by those that contain certain items

I'll see if I can piece through why they're failing

I'm also looking into it - I think probably one of the migrations messed with unrelated test setup in some way.

It looks like this line causes other tests to fail:
https://github.com/rubyforgood/diaper/pull/783/files#diff-b0995839188d451eaca1ba57d0f2bbd2R5
However, this test should definitely be allowed to create organizations. Maybe other tests have an accidental brittleness with regards to the orgs table? I will investigate more later, but wanted to share what I have.

I do see that the tests pass -- @organization is created in the rails_helper file, which is probably why it was blowing up for you.
Instead of creating ivars in your specs, use let blocks (they're scoped to the executing block) -- admittedly, we should probably use different ivars in our rails_helper, but in the interim, stick with let blocks to be safe. I'll do the fix for this and push it up

If this runs green, it can be merged.
I made a couple small changes -- mainly to keep test efficiency up (reusing instances that don't change often)


fix: remove unnecessary maps parameter(taiwan, thailand) and chnage readme release link

Please check if the PR fulfills these requirements

[x] It's submitted to right branch according to our branching model
[x] It's right issue type on title
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes/features)
[x] Docs have been added/updated (for bug fixes/features)
[x] It does not introduce a breaking change or has description for the breaking change

Description
remove unnecessary maps parameter(taiwan, thailand) and chnage readme release link
#173

수고하셨어요 리뷰 완료입니다.


Question on Uniqueness of Catalog ID's

Hi there, this is a quick question:
For ID's in a collection, they are intended to be unique. Same with items.
But for catalogs, this appears not to be the case.
Is this intentional?
Thanks. Any answer will go towards building a node-based validator.

To my understanding, Items are not strictly required to have a unique ID.  This works obviously only for unique IDs. The response is always a collection therefore it is required for collections, but not yet necessary for catalogs. It would be useful, but is not strictly required. Same applies for IDs. They need to be unique across a collection, but not necessarily globally unique. The endpoint here is GET /collections/{collectionID}/items/{itemID}. That's a very API centric view, but until now it's the only real constraint for the IDs that derived from inside the STAC specification itself.

Thanks! If this is the consensus among the Collaborators, I'd be happy to see this issue closed.

Maybe let @cholmes or any of the others collaborators confirm it by closing this issue. ;-)

I concur with @m-mohr, collection IDs should be unique, and item IDs should be unique within a collection, or else it wouldn't work with a dynamic API.
However, for static catalogs there really isn't a requirement that any of them are unique. Catalogs, especially sub-catalogs, are not unique in the Landsat catalog right now. These two catalogs both have an ID of 41. One is row 41 in path 180, and the other is row 41 in path 179.
http://landsat-stac.s3.amazonaws.com/landsat-8-l1/180/41/catalog.json
http://landsat-stac.s3.amazonaws.com/landsat-8-l1/179/41/catalog.json
The catalogs each have a unique path, but not necessarily an ID (although maybe in this case I should update the ID to be path-row).
When a static catalog is ingested into a dynamic API, those sub-catalogs are ignored, at least they are in sat-api. Only Collections and Items are ingested so there is no conflict with non-unique IDs.

Thanks!

Concur - collection ID's should be unique, but catalogs I think as like 'folders' - no use case I can think of to make them unique.
Psyched for your work on a node-based validator @brianbancroft !


does not work with create-react-app

Steps to recreate:
Create a new app:
npm install -g create-react-app
create-react-app my-app
cd my-app
npm start

works.
Install leaflet and leaflet-measure:
npm i --save leaflet leaflet-measure

Import into my-app/src/App.js:
import 'leaflet'
import 'leaflet-measure'

See this error in the console:
leaflet-measure.js:15Uncaught TypeError: fs.readFileSync is not a function
    at Object.<anonymous> (leaflet-measure.js:15)
    at Object.<anonymous> (leaflet-measure.js:457)
    at __webpack_require__ (bootstrap 056f279…:555)
    at fn (bootstrap 056f279…:86)
    at Object.<anonymous> (App.js:6)
    at __webpack_require__ (bootstrap 056f279…:555)
    at fn (bootstrap 056f279…:86)
    at Object.<anonymous> (index.js:3)
    at __webpack_require__ (bootstrap 056f279…:555)
    at fn (bootstrap 056f279…:86)
(anonymous) @ leaflet-measure.js:15
(anonymous) @ leaflet-measure.js:457
__webpack_require__ @ bootstrap 056f279…:555
fn @ bootstrap 056f279…:86
(anonymous) @ App.js:6
__webpack_require__ @ bootstrap 056f279…:555
fn @ bootstrap 056f279…:86
(anonymous) @ index.js:3
__webpack_require__ @ bootstrap 056f279…:555
fn @ bootstrap 056f279…:86
(anonymous) @ bootstrap 056f279…:578
__webpack_require__ @ bootstrap 056f279…:555
(anonymous) @ bootstrap 056f279…:578
(anonymous) @ bootstrap 056f279…:578

May be related to https://github.com/ljagis/leaflet-measure/issues/30 and https://github.com/ljagis/leaflet-measure/issues/67

Hm. Nodes fs function is used here: https://github.com/ljagis/leaflet-measure/blob/master/src/leaflet-measure.js#L15-L19
This is quite obviously not going to work in a browser.

For the meantime I can circumvent the problem by importing like this:
import '../../../../node_modules/leaflet-measure/dist/leaflet-measure'

instead of:
import 'leaflet-measure'

Thanks for this great tool!

This control is built with Browserify and intended to be used from the dist directory. It has been this way since originally built in 2015.
I would like to update the build to webpack but have not yet had the opportunity. Until then, importing from dist is probably the best solution.

Closed in favor of issue #70


Missing sensors on Tuya plugs

Describe the bug
I've bought 3 "Aubess Smart Socket 16A/EM"
With Tuya integration, i get the switch status, the child-lock, mut all 3 power meters (power, current and voltage) are not available
Expected behavior
To be available as they are in the tuya app (power, voltage, current and total kwh)
Diagnostics for integrations and devices
config_entry-tuya-ae7c196ef8c615fdf707eea365920524.json.txt
Screenshots

Home Assistant Version
-2022.8.6

It might be that you can simply enable the three sensors that you see (that worked for me with a different plug).
Total kwh seems to be different.

It's "This entity is unavailable", not disabled.

they were just disabled for me as default. i enabled all 3 and they are working fine now


Add custom fields to system history

Closes #4273
⚠ Dependent on fidesplus, check out the branch in https://github.com/ethyca/fidesplus/pull/1170 to run the backend
Description Of Changes
Adding support for system:information and system:data_use custom fields. Includes a few bug fixes and general code cleanup.
Code Changes

[ ] Fixed bug where an incomplete system was set as active after saving the system information form
[ ] Added new SystemCustomFieldGroup component to dynamically render the custom field diffs
[ ] Fixed typo in the Data use diff field
[ ] Cleaned up history/helpers.tsx and added docstrings
[ ] Fixed typo in test_system_history.py

Steps to Confirm

[x] Start fidesplus
[x] Create three custom fields for the system:information location (open text, single select, and multi select)
[x] Create three custom fields for the system:data_use location (open text, single select, and multi select)
[x] Define the custom fields in the system information form for a system
[x] Define the custom fields in a privacy declaration for the system
[ ] Navigate to the system history tab, there should be six system history entries (3 for system info and 3 for data use)
[ ] The open text field should just be text, the single select and multi select fields should show up as badges

Pre-Merge Checklist

[ ] All CI Pipelines Succeeded
[ ] Issue Requirements are Met
[ ] Relevant Follow-Up Issues Created
[x] Update CHANGELOG.md

Testing this out now! leaving an early comment—is this expected? the fields don't quite point to the right places

Testing notes-

I have found a bug - 400 is thrown when updating a custom field if you have a multiselect custom field but do not update it then it is not written is an array https://www.loom.com/share/e5aa1abebfe04a58ba82624e97c31d17?sid=2d397d78-eff5-4684-9d0a-bcb1f011370e
I need to look into the failing tests
everything else looks to be working
-creating a system and adding custom fields; displays properly in system info tab and history tab ✔
-creating a data use and adding custom fields; displays properly in system info tab and history tab ✔
-updating all system:info custom fields; displays properly in system info tab and history tab  ✔
-updating only one system:info custom field; displays properly in system info tab and history tab ✔
-updating all system:data use custom fields; displays properly in data use tab and history tab  ✔
-updating only one system:system data use custom field; displays properly in data use tab and history tab ✖ This is the bug listed above as #1


Create CHANGELOG

I'm not going to fill out those releases with change log items but at least dates and diff links will be useful to some including me.
My hopes are pointed toward the Unreleased section at the top. :pray:
Fixes #756

@sferik Any objections on this one?

Is this really valuable? It seems like a copy of https://rubygems.org/gems/omniauth/versions that needs to be manually updated and may contain inaccurate information.

@sferik What about the change log? I don’t know what to look out for when upgrading omniauth.

Please see my comment here: https://github.com/omniauth/omniauth/issues/756#issuecomment-277494251


MVP is confusing

I have had some problems. With sample.

Is the activity supposed to be a simple container for fragment(controller with no view attached)? It doesn't seem so from the sample (toolbar in activity).
Can/should the presenter methods be called in activity.
The presenter should only contain view related logic? (Routing / service launche etcnot be there?)
Finally can I mix and match(fragment as view and activity as view).

The Rx java sample is in development.

@JoseAlcerreca i have edited the title to better describe my frustration, i think those points are valid for all mvp samples.
It was just that I was using Rx.
So I thought we make a new architecture specifically for android .(not being overconfident) #115


Function getwinpos() was not tested

This PR adds a test for function getwinpos() which was not tested according to codecov:
https://codecov.io/gh/vim/vim/src/master/src/evalfunc.c#L5536

Codecov Report

Merging #2911 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2911      +/-   ##
==========================================
+ Coverage   75.62%   75.63%   +<.01%
==========================================
  Files          92       92
  Lines      135016   135015       -1
==========================================
+ Hits       102106   102115       +9
+ Misses      32910    32900      -10

Impacted Files
Coverage Δ

src/version.c
81.42% <0%> (-0.96%)
:arrow_down:

src/gui_beval.c
62.66% <0%> (-0.43%)
:arrow_down:

src/gui_gtk_x11.c
47.93% <0%> (-0.1%)
:arrow_down:

src/ex_cmds2.c
79.12% <0%> (-0.1%)
:arrow_down:

src/gui.c
49.3% <0%> (-0.06%)
:arrow_down:

src/os_unix.c
54.35% <0%> (-0.05%)
:arrow_down:

src/if_py_both.h
76.59% <0%> (-0.01%)
:arrow_down:

src/channel.c
83.03% <0%> (+0.07%)
:arrow_up:

src/evalfunc.c
84.15% <0%> (+0.17%)
:arrow_up:

src/ex_cmds.c
79.6% <0%> (+0.22%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 620020e...ba19fe3. Read the comment docs.


"Follow+Mute" should only mute them from the feed, not for replies

Describe the Feature
If I mute someone I follow, that should only mute their posts in the main feed and NOT also mute their direct replies to me. Unfollowing someone has social implications but sometimes someone is posting a lot and you want to temporarily mute them from the feed without unfollowing them, but still wanna know if they're contacting you directly
Attachments
No response
Describe Alternatives
alternatively a "hide posts in feed" option instead if you want to make it more clear thats the intent
Additional Context
No response

hmm this would be a pretty good feature to have as certain  followers  can get annoying (venting all up in my tl ) often
a timer would also be useful so I can not see their posts for n minutes  instead of indefinitely

Came here to suggest the same feature.
I follow friends because they are friends, but not all of them are posting or interacting with things I want to see on my Feeds. But I still want to know when they try to interact with me...
If I didn't, then like Tyler says, I'd just unfollow.


esp32-core: Add support for the external SPIFLASH

Summary

Fix some trivial, mostly cosmetic, issues in the driver.
Add support for the board.

Impact
Shouldn't affect any other existing code.
Testing
The provided defconfig was used to test.

@Ouss4 PR https://github.com/apache/incubator-nuttx/pull/1755 should fix the break, please rebase your change again. Since PR https://github.com/apache/incubator-nuttx/pull/1611 send out three weeks ago, It's hard to catch the new project config file added recently. Sorry for inconvenience.

@xiaoxiang781216 It looks like it passed.  The only one failing is a macOS build which is not related to that PR.  I did a similar change as #1755 when I saw your PR, I think if I didn't the build would've failed when #1611 was merged.

The mac fail is:

====================================================================================
Configuration/Tool: esp32-core/random
------------------------------------------------------------------------------------
  Cleaning...
HEAD detached at pull/1754/merge
Changes not staged for commit:
	modified:   boards/xtensa/esp32/esp32-core/configs/mmcsdspi/defconfig

no changes added to commit
  Configuring...
  Building NuttX...
  Normalize esp32-core/random
HEAD detached at pull/1754/merge
Changes not staged for commit:
	modified:   boards/xtensa/esp32/esp32-core/configs/mmcsdspi/defconfig

I think this needs a configuration refresh.

I think this needs a configuration refresh.

That's what I did earlier.  I wonder why only the macOS one caught that, the rest didn't complain.
Anyway, I rebased, let's see again.


Update functions-how-to-azure-devops.md

Making an update on how to create yaml for Python 3.7

@kulkarnisonia16 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@ShannonLeavitt : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Link to project proposal should not be required

When saving a project you can't save without having a link to a proposal. This means that any old projects can not be edited without adding a link. This is an annoying requirement that shouldn't be enforced for user flow. Especially because a new project may not have a proposal link right away

Fixed in PR #635


Consistent check for masked array types

Consistency! And using part of an API for what it was meant for (in this case checking that an object is of a certain type).
To wit, anything that looks like the former will now look like the latter:

if isinstance(thing, ma.core.MaskedArray) --> if ma.isMaskedArray(thing)
if thing is ma.masked --> if ma.is_masked(thing)

Ping @pp-mo

Tests pass! Anyone want to take a look?

It looks you have missed a few:
https://github.com/dkillick/iris/blob/consistent_ma_check/lib/iris/pandas.py#L173
https://github.com/dkillick/iris/blob/consistent_ma_check/lib/iris/pandas.py#L219
https://github.com/dkillick/iris/blob/consistent_ma_check/lib/iris/analysis/__init__.py#L1080
https://github.com/dkillick/iris/blob/consistent_ma_check/lib/iris/fileformats/pp.py#L1384
https://github.com/dkillick/iris/blob/consistent_ma_check/lib/iris/experimental/raster.py#L100
Not sure about this one:
https://github.com/dkillick/iris/blob/consistent_ma_check/lib/iris/fileformats/pp.py#L1384

It looks you have missed a few

Dammit PyCharm! Your search has let me down...

Your search has let me down

But then again, perhaps we should blame my ability to regex.

@dkillick Awesome, but I think that you're still missing a couple of core.MaskedArray and ma.MaskedArray instances ...

@dkillick Let's get this merged ...

./fileformats/grib/_load_convert.py
1384:        if isinstance(data, ma.core.MaskedArray):
./fileformats/pp.py
100:    if isinstance(data, np.ma.core.MaskedArray):
./experimental/raster.py
934:    if not isinstance(a, (np.ndarray, ma.core.MaskedArray)):
./util.py

and
173:    if isinstance(data, np.ma.MaskedArray):
219:    if isinstance(data, np.ma.MaskedArray):
./pandas.py

These are the obvious candidates ... fix those and I'll merge.

@bjlittle I've removed a few more examples...


Use short-circuit evaluation instead of if

I think this is a nice change because it uses less code and also, it is being used in other parts of this same file, such as the first line: var lang = lang || 'en';

Thanks, the whole thing is due for a refactor (see #24) but this is nice improvement in the meantime.


device: a few more cleanups

Continuation of https://github.com/zephyrproject-rtos/zephyr/pull/50827
In this cases this covers mostly Doxygen improvements/fixes and a few formatting adjustments. Please review on a per-commit basis.

Maybe indent multi-line @param? It would be easier to read.

we need to discuss what format we choose for Doxygen, we have a wide variety of styles in-tree...


Field order in template is not consistent with stress period schema

In GitLab by @Huite on Apr 12, 2019, 11:45
This, in imod.run:
stress_period_schema = OrderedDict(
    [
        ("wel", {"systems": True}),
        ("drn", {"systems": True, "order": ("cond", "bot")}),
        ("riv", {"systems": True, "order": ("cond", "stage", "bot", "inff")}),
        ("ghb", {"systems": True, "order": ("cond", "head")}),
        ("rch", {"systems": False}),
        ("chd", {"systems": False}),
    ]
)

Is not consistent with the template!
{%- set names = ["bhead", "cond", "ghbssmdens"] %}

Probably check all these orders just to be sure...

In GitLab by @Huite on Apr 12, 2019, 14:55
closed

In GitLab by @JoerivanEngelen on Apr 12, 2019, 12:52
created merge request !23 to address this issue

In GitLab by @Huite on Apr 12, 2019, 14:55
Fixed by 4433a06ed2d174a469354c832c05882edb2c5aab


Actions V2 error message feedback

Preflight Checklist

[X] I could not find a solution in the existing issues, docs, nor discussions
[X] I have joined the ZITADEL chat

Describe your problem
Forwarded from: https://discord.com/channels/927474939156643850/1253811958508032061
Using the new Actions V2 functionality, when using webhook and call targets, currently there is no way to provide a proper error message to the user when we want to stop the execution.
Use Case: I'm planning to only accept user creation in Zitadel if the user is created in an external system first.
If the external system is not working or the action service is not working, no user could be created.
Beyond that the rest of the IAM functionality should work as usual.
Already tried it in a local deployment without any problem, was able to use webhook and call targets, both on the API and console using /zitadel.user.v2beta.UserService/AddHumanUser and /zitadel.management.v1.ManagementService/AddHumanUser executions.
Only tried with request executions.
When returning an HTTP error status and using the interruptOnError flag in the target, was able to stop the user creation.
The user was not created and the error was shown in the console as ID=EXEC-dra6yamk98 Message=Errors.Execution.Failed.
Describe your ideal solution
I want to properly return an error message, so that on the API response or in the Zitadel console the user could see a better feedback.
Version
v2.54.1
Environment
Self-hosted
Additional Context
No response

@stebenz @adlerhurst I think this issue would absolutely make sense. Can you have a look at it, what it means in regards of implementation?

Estimation: 1d


Readme update

Codecov Report

Merging #30 (8bc0624) into master (40663ca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   85.87%   85.87%
=======================================
  Files           9        9
  Lines         361      361
=======================================
  Hits          310      310
  Misses         51       51

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40663ca...8bc0624. Read the comment docs.


Can't find installation instructions on non-Vagrant machines

Is there an instruction page to install Singularity from a package?
What are the required config files and command line parameters?
Thanks

I am looking at the exact same issue and the same provision script.

Hey folks, i moved the vagrant information into vagrant.md and have updated install.md to describe how to install Singularity for non-vagrant machines. Let me know if anything in it is unclear.


Force simulation makes scatterplot lag

User story
It seems like the force simulation / collision avoidance of cell set labels is making things slow on one of our demos: https://deploy-preview-5--trusting-perlman-9a8667.netlify.app/references/human_fetus/
Preferred solution
Would it be possible to allow the user to configure the threshold for recomputing the force simulation?
Possible alternatives
Or simply turn off this feature when the number of labels is > n
Thanks so much!

If you're interested in just turning them off, that is doable.  There is the coordination type embeddingCellSetLabelsVisible that can be set to false so something like
"coordinationSpace": {
    ...
    "embeddingCellSetLabelSize": {
      "UMAP": 10
    }
  },
....
{
      "component": "scatterplot",
      ...
      "coordinationScopes": {
        ...
        "embeddingCellSetLabelSize": "UMAP",
      }
    }

I do still think we should try to make this more scalable in general so they don't have to be turned off.

Sounds good and thanks for the quick replies! I was referring to turning off the force simulation feature, but I will just remove cell set labels for now.


Add Crypto Tests

Add standalone unit tests for source files in common/cpp
in a new common/cpp/test/ directory.
These are mostly Cryptographic functions implemented with OpenSSL.
Enable in rebuild.sh and run_tests.sh.
Signed-off-by: danintel<EMAIL_ADDRESS>

Merged with PR #454


⚠ Jenkins Plugins Artifactory has degraded performance

In 9201cf7, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1167 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 742beab after 19 minutes.


fy2021q1 refresh

updated demos to SPFx v1.11
update pictures, resources, and steps to account for dependency updates
update broken links

Excellent, thanks AC and Rob for the updates for 1.11.


Is it possible for the post-lexer to consume two tokens and then yield?

I want to have a post-lexer that's essentially looks like this (with more bits of code inserted in between!)?
class PostLexer:
    def __init__(self):
        self.always_accept = ()

    def process(self, stream):
        for tok in stream:
            tok2 = next(stream)
            yield tok
            yield tok2

The way this code is, the parser doesn't work correctly. I get "no terminal defined for..." errors where I do not if I swap the tok2 = next(stream) line with the yield tok line.

I assume you're using LALR.
LALR by default uses the contextual lexer, which depends on the state of the parser to tokenize. Changing the order means it tries to determine a terminal before the parser advanced to the next state.
If you have to do it this way, for whatever reason, you can try to use lexer="standard". It will revert to the traditional YACC/PLY lexer, which doesn't care about the parser state. However, that means that you're losing a bit of parsing power, and might experience more collisions.

Thanks. Yes, switching to standard parser does seem to fix this issue, although I have no idea whether it might degrade parsing power later, for me. The real reason I'm doing this relates to how the END statement and the likes of "END IF" have conflicts. I posted a question about the grammar here on Stack Overflow and apparently this is not something that can be easily and cleanly fixed in an LALR parser.
The plan was to detect the standalone END command and convert it to something else in the post-lexer, this I find cleaner than converting "END IF" to "ENDIF" and so on. In order to do that however, I have to look ahead.
Also, Earley could be a solution here, but Lark's implementation seems to resolve ambiguities in a non-deterministic manner, something that I am mortally afraid of, when it comes to programming, so I decided to switch to LALR and all hell broke loose!
BTW, all that said, this is a really cool library and the best I've found so far, so thank you!

There is a reply there from by sepp2k which describes the problem correctly, and also offers the right solution. I propose that you try it, and if it works (as it should), accept is as an answer.

so thank you!

You're welcome :)

I'll copy the solution part of his answer:
You can fix this, somewhat hackishly, by turning end if into a single token like this:
ENDIF_KW: /end[ \t\f]+if/i

And then using ENDIF_KW instead of END_KW IF_KW.

Yes. I guess that's what I'm going to do then. Thanks.


Added some humourous print() statements to main.py

Changes total two print statements following the last.


BUGFIX: The SpiEventSource impl block should be compiled under the same conditions as the st…

…ruct block.

Thanks!

Thanks for the quick merge !


Faulty header generation or parsing

Short version:
One of the flow-type defs installed/generated during flow-typed install has the following header
// flow-typed signature: 53b581d81115b53eaf3a74ae963c4f43
// flow-typed version: ba3c3d2dca/lodash_v4.x.x/flow_>=v0.38.x <=v0.46.x

Subsequently, when running flow-typed install again the cli errors out
UNCAUGHT ERROR: Error: flow_v0.38.x <=v0.46.x: Unexpected trailing characters:  <=v0.46.x
    at validationError (/app/node_modules/flow-typed/dist/lib/validationErrors.js:14:11)
    at parseDirString (/app/node_modules/flow-typed/dist/lib/flowVersion.js:155:45)
    at _callee2$ (/app/node_modules/flow-typed/dist/lib/npm/npmLibDefs.js:502:146)
    at tryCatch (/app/node_modules/regenerator-runtime/runtime.js:64:40)
    at GeneratorFunctionPrototype.invoke [as _invoke] (/app/node_modules/regenerator-runtime/runtime.js:355:22)
    at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (/app/node_modules/regenerator-runtime/runtime.js:116:21)
    at tryCatch (/app/node_modules/regenerator-runtime/runtime.js:64:40)
    at invoke (/app/node_modules/regenerator-runtime/runtime.js:154:20)
    at /app/node_modules/regenerator-runtime/runtime.js:164:13

We are running flow-typed  "2.1.2"
I've done some basic spelunking around with a colleague and our very vague guesswork is that the cause maybe lies in cli/src/lib/flowVersion.js
It looks the version string is created by toSemverString and explicitly includes a space, but then the header is parsed with parseDirString, which does not expect spaces, and instead expects the versions to be separated by a -.  Maybe the parser is expecting the header version string to be written using toDirString instead, or maybe there should be a parseSemverString method?

Same issue here, is this related to a recent update ?

@eric-burel very much in dangerously little knowledge territory here, but I think this particular bug only manifests itself for certain sets of dependencies, i.e the installed dependency graph of your app at a particular time. There may also be other factors that influence this such as flow-typed version and lunar cycle etc. (caveats, maybe we're seeing different causes of the same symptom?)

Same error for me. Cleaning up node_modules, or ~/.flow-typed dont help at all.

same here, I get UNCAUGHT ERROR: Error: flow_v0.23.x_<=v0.27.x: Unexpected trailing characters: _<=v0.27.x.

Same error for me. Error: flow_v0.38.x <=v0.46.x: Unexpected trailing characters:  <=v0.46.x

Not that I couldn't found those faulty headers in any files, even in the ~/.flow-typed folder, I can't tell where it comes from. Is it dynamically generated ?

Installing flow-typed again after delete all flow flow-typed ~/.flow-typed directory works for me.

Deleting the .flow-typed directory didn't work for me :/

I got:
UNCAUGHT ERROR: Error: flow_v0.30.x <=v0.52.x: Unexpected trailing characters:  <=v0.52.x

PRELUDE: I have a postinstall script on package.json that executes flow-typed install (installed locally) that would look like:
  "scripts": {
    "postinstall": "flow-typed install",
  }

Then I ran:
rm -rf node_modules/flow-typed/
rm -rf flow-typed/
yarn add flow-typed
yarn postinstall

which made:

flow-typed update from "^2.1.2" to "^2.1.5"
yarn.lock changes
several flow-typed definitions to update

This fixed the issue :) (but now flow doesn't recognize jest global functions... but that's a new error...)

Guys, you may want to be careful with just blowing away the flow-typed directory.  It's designed for you to be able to edit it (in case you want to add missing defs for anything) and as such someone else in your org may have added their own defs in there.

This should be fixed in v2.2 by #1311


Fanuc Driver code has been run through visual studio code in ubuntu 20.04. I got the issue Dll not found exception. can you please guide me to register the focus library dlls in ubuntu 20.04.

Exception thrown: 'System.DllNotFoundException' in fanuc.dll: 'Unable to load shared library 'FWLIB32.dll' or one of its dependencies. In order to help diagnose loading problems, consider using a tool like strace. If you're using glibc, consider setting the LD_DEBUG environment variable: /snap/dotnet-sdk/226/shared/Microsoft.NETCore.App/7.0.13/FWLIB32.dll.so: cannot open shared object file: No such file or directory /home/edgegateway/ladder99/fanuc/fanuc-driver/fanuc/bin/Debug/net7.0/FWLIB32.dll.so: cannot open shared object file: No such file or directory /snap/dotnet-sdk/226/shared/Microsoft.NETCore.App/7.0.13/libFWLIB32.dll.so: cannot open shared object file: No such file or directory /home/edgegateway/ladder99/fanuc/fanuc-driver/fanuc/bin/Debug/net7.0/libFWLIB32.dll.so: cannot open shared object file: No such file or directory /snap/dotnet-sdk/226/shared/Microsoft.NETCore.App/7.0.13/FWLIB32.dll: cannot open shared object file: No such file or directory /home/edgegateway/ladder99/fanuc/fanuc-driver/fanuc/bin/Debug/net7.0/FWLIB32.dll: cannot open shared object file: No such file or directory /snap/dotnet-sdk/226/shared/Microsoft.NETCore.App/7.0.13/libFWLIB32.dll: cannot open shared object file: No such file or directory /home/edgegateway/ladder99/fanuc/fanuc-driver/fanuc/bin/Debug/net7.0/libFWLIB32.dll: cannot open shared object file: No such file or directory'

FWLIB32.dll is a Windows library.  To build on Linux you have to use the .so libraries.


Add Vi mode indicator to ZSH

Add Vi mode indicator to ZSH
Add a visual indicator to the current prompt of my zsh configuration that would display the current vi mode.
It can be similar to the current fish config., namely:

I did not get the visual mode indicator to work (with omz's vi-mode). However, the highlight should be enough of a visual cue.

For the sake of brevity, I'll not open a PR with a branch, just commit to main, link the commit to this issue, and close the issue afterwards.

Closing!


FR: Timeline plugin should be drawn at waveform-ready event

Hi,
Wavesurfer v4.0.1
Timeline plugin is currently drawn only at ready event as far as I understood in documentation.
It should also be called at waveform-ready event.
Thanks !
Related issue: https://github.com/katspaugh/wavesurfer.js/issues/2031

@X-Raym pull request welcome!

@thijstriemstra I would but this issue (which surely needs more consideration) is preventing me to make this simple fix :S
https://github.com/katspaugh/wavesurfer.js/issues/2031

@thijstriemstra Any news about this ? :)

@thijstriemstra Any news about this ? :)

there is more plugins need this change too (elan,markers,regions,minimap,spectrogram), it all listening to 'ready' only event

Closing because it works differently in v7.


Bare keys and quoted keys are not equivalent

About
Bare keys and quoted keys are equivalent on toml v1.0.0-rc.2 but taplo doesn't raise error
Reproduction

create toml file and write
# THIS WILL NOT WORK
spelling = "favorite"
"spelling" = "favourite"

create multiple-key-2.toml in test-data/invalid and write
# https://toml.io/en/v1.0.0-rc.2#keys
# THIS WILL NOT WORK
spelling = "favorite"
"spelling" = "favourite"

after that,run cargo run  --bin test-gen --package test-gen -- -i ../../test-data -o ../../taplo/src/tests and run test at project root

Notes
I'm trying to make tests from TOML 1.0.0-rc.2 now. It may solve #3, but I don't know which ones in test-data folder are needed. (almost all are same as toml.io's, but I can't find some ones.) I create prototype of test data so please check and tell me I should proceed as it is or not if you can. (It refers to only toml.io and I've finished up to end of the keys section.)

Thank you!
The current tests are pretty much best-effort scavenged from various places and created based on bug reports, so any additions are welcome.
However I think any effort in that regard should go towards an official test suite that could eventually be used by this library and others as well.


Didn't work on my Linux setup

I have an xmonad setup on top of Ubuntu. I debugged and found that the reason why it wasn't working on my machine: After the elisp command (kill-buffer "*Emacs Anywhere*") gets executed, the X clipboard doesn't have anything in the clipboard. I changed the algorithm slightly like this:
(require 'f)

(defun ea-on-delete (frame)
  (f-write (buffer-string) 'utf-8 "~/.emacs_anywhere/clipboard"))

And then it started working. Ofcourse, I also had to change the run command accordingly. Honestly, I find relying on Clipboard in Linux to be troublesome. I can send you a PR if you agree to change the logic the above way.

Same for me on my Arch setup. I also thought that it'd be better to just write to file and not mess with clipboards, but I'm having an issue with xdotool type bungling the insertion of newline chars and I'm curious to know how you got the run script working.
Here's my version of it:
...
xdotool windowactivate --sync $window type "$(cat ~/.emacs_anywhere/text)"

@beshrkayali  I modified the run command to this:
#!/usr/bin/env bash

window=$( xdotool getwindowfocus )

$HOME/.emacs_anywhere/bin/emacstask

xdotool windowfocus --sync $window

clipboard=$( cat $HOME/.emacs_anywhere/clipboard )

xdotool type "$clipboard"

Let me know if that works for you!

hmm.. looks similar to what I have, but strangely, xdotool is not inserting newlines properly. I think most likely because of this https://unix.stackexchange.com/a/399638.

@beshrkayali Oh yeah, just noticing it. Even my setup doesn't insert newlines properly. Would love to know if  you would come up with any workaround.

@psibi Yep! I borrowed the one-liner from Gilles answer, which basically replaced newlines chars with carriage returns.
Here's how it looks now:
#!/bin/bash
window=$( xdotool getwindowfocus)
$HOME/.emacs_anywhere/bin/emacstask
xdotool windowactivate --sync $window type "$(cat ~/.emacs_anywhere/text | tr \\n \\r | sed s/\\r*\$//)"

Awesome!
That works. This comment is from Emacs. :-)

@beshrkayali  solution works great, but if you want to skip "typing" long buffers and have xclip on hand
#!/bin/bash
window=$( xdotool getwindowfocus)
$HOME/.emacs_anywhere/bin/emacstask
xdotool windowfocus --sync $window
xclip -sel clip ~/.emacs_anywhere/text
xdotool key --clearmodifiers ctrl+v

@BontaVlad The problem with your approach is that it won't work for all applications. For gnome-terminal, the paste command is Shift + Ctrl + V. Also using clipboard mechanism is not that reliable in a Linux machine. Also in my experience, debugging errors from xclip has always been painful.

Thanks! Send a pull request if you think it will help others avoid the same issue. Glad you got it working @psibi !

@psibi I agree. What I proposed should not be taken as a general, solve all solution, it's just a quick hack to solve my use case and maybe should prove useful for some other internaut. My scenario for using emacs anywhere usually involves long text edits so making xdotool type everything either takes to long  or "skips" a letter or two.

@BontaVlad  @psibi
True, but I still prefer not to mess with clipboards or replace previously held text.
Adding a --delay 1 (default is 12ms) somewhat solves the issue of long-ish text:
xdotool windowactivate --sync $window type --delay 1 "$(cat ~/.emacs_anywhere/text | tr \\n \\r | sed s/\\r*\$//)"

@beshrkayali @BontaVlad Have sent a PR with some improvements for Linux: https://github.com/zachcurry/emacs-anywhere/pull/23
Let me know if something there concerns you or can be improved.

@psibi looks good!
One small issue is that the manpage for xdotool suggests that getactivewindow is more reliable than getwindowfocus. I have not found this to be the case however (I'm running i3), it's the opposite actually.
Not exactly sure why or if it might affect other window managers.

@beshrkayali

One small issue is that the manpage for xdotool suggests that getactivewindow is more reliable than getwindowfocus. I have not found this to be the case however (I'm running i3), it's the opposite actually.

I agree! In fact getactivewindow was failing in my setup too (XMonad). Thanks for the review. :-)

Further comments on the PR: PR tests

At this point I'm not ready to adopt this alternative. When I get the time I'll look into the efficacy of avoiding the clipboard. Thanks!


added support to change the installation directory

Added a parameter to change the installation directory of NSClient.

fixed puppet lint

rebased to current master. Tests are passing now.


I want to know where to download 3dmatch dataset in .pth format?

The 3dmatch dataset download link for this repository give us the dataset in .ply format, and the folder branch doesn't match the path in .pkl file. Where should I download the dataset in .pth format corresponding to the .pkl file?

im facing this as well, anyone knows how to get them?

Same question here.


Option to set custom logger

Hi team
Thanks for the SDK - I've been using it to good effect to date!
One request I have is that I already have a logger class that does log filtering, structured logging, etc.  I notice that logging (logger.info and logger.warn specifically) only occurs in the AccountStreamer class, and by way of a statically set logger:
private readonly logger = console
Would you consider adding an option for the library to receive a logger object and use that in the library for logging as an optional alternative to console?  Just something that implements a simple/standard logging interface i.e. functions for trace, debug, info, warn, and error?
A related request is an option to be able to suppress the heartbeat messages that clutter the logs:
{
  status: 'ok',
  action: 'heartbeat',
  'web-socket-session-id': 'beea1e13',
  'request-id': 277
}
Scheduling heartbeat with interval:  20000

with a custom logger being a nice solution to this as well.

@markabrahams yeah we can get that added for you. Sorry for the delayed response. It's a good idea.

Great thanks @dmoss18 - yes I'm thinking along those exact lines!  I can put together a PR for this.

@markabrahams version 5.0.0 supports custom loggers


Feature request: display warning and error count like eslint.

Problem
TypeDoc doesn't show the number of warnings and errors (though it does calculate them!). If a project has a lot of warnings (as it is in our case), it would be very convenient to see the number of warnings to ensure that the count goes down over time and not up.
Suggested Solution
I suggest displaying the warning and error count like ESLint does. Possible outputs:

if there are only warnings: [warning] Found 0, error(s), 70 warning(s).
if there are errors: [error] Found 1, error(s), 70 warning(s).

Considering that TypeDoc already counts errors and warnings, it should only take a couple of lines to add this feature.
I don't mind to make a PR.

Seems like a reasonable request, go for it!

Included in TypeDoc 0.26, which is releasing 2024/06/21


Zba: should add.uw be mode-dependent?

The Zba extension is for bit manipulations related to address generation. As I understand it, it consists of:

sh{n}add{.uw} where n is {1,2,3} to take an index, shift it, and add it to a pointer. With uw the index is a 32-bit unsigned value.
add.uw to take a 32-bit unsigned index, not shift it, and add it to a pointer.
slli.uw to shift an index: this is to use with add (non uw!) in cases where you want to shift the index by more than 3.

We have currently made all the sh{n}add{.uw}s mode dependent, which seems very sensible, and also added sh4add{.uw}, presumably because we imagine a common case where indices are into tables of caps. It seems sh4add{.uw} could be made RV64-only since shift-by-3 is sufficient for 8-byte caps: I doubt it's worth the hassle, but sh4add may imply an extra layer of muxes...
add.uw seems to have been missed. This seems to be filling the gap of sh0add.uw, so I don't see why it should be treated differently. I guess the non uw sh0add is just add, and we do treat that one a little differently in that we have a separate instruction for cadd!
slli.uw should be left un-capified because it's for manipulating the index before it gets combined with the pointer, if I understand correctly.
Hope that makes sense: happy to file a PR to make add.uw mode-dependent if people confirm I haven't missed a good reason it should be left out.

I'm not quite sure how useful add.uw is but for consistency I agree that it should be treated the same way. Also agreed that shadd4 should depend on zba.

https://github.com/riscv/riscv-cheri/pull/160 fixes these and also changes some encodings: I'm fairly sure this is what was intended.
The only remaining question I have is whether sh4add{.uw} should be RV64 only.


Lack of reliable feedback channel for PRs

Describe the bug
When PR is filed against a package, committers are expected to wait at least a week for maintainer feedback (
https://github.com/NixOS/nixpkgs/blob/master/maintainers/README.md?plain=1#L20). However, it turns out that GitHub cannot or does not ensure that maintainers can always reliably comment on the PR. There are configurations where even with access to a GitHub account, commenting on a PR is technically blocked. As far as I'm informed, this can even be configured by the PR author, so there is even the danger of users purposefully creating a PR that does not accept feedback by maintainers of affected packages.
Steps To Reproduce
Steps to reproduce the behavior:

File a PR affecting a package
Use GitHub's facilities to prevent comments by maintainers
After one week, merge the PR according to the guidelines for maintainer involvement

Expected behavior
Maintainers are always given a possibility to provide community-visible feedback on PRs affecting packages they maintain, possibly through additional channels (e.g. from their linked mail or matrix accounts).
Screenshots
An example of a PR with unreliable commenting facilities:

Additional context
This might be due to an incompatibility between GitHub's access controls and the nixpkgs-defined maintainer responsibilities.
Metadata
Not applicable since it's a GitHub platform issue that is expected to apply independently from the local nixpkgs setup.
Notify maintainers
@zimbatm @7c6f434c @fricklerhandwerk @FRidh

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

Use GitHub's facilities to prevent comments by maintainers

I think this only happens if the PR author blocked you. (Or the PR was locked and closed due to mass ping)

I wonder whether GitHub actions (for evaluation, see https://github.com/NixOS/nixpkgs/issues/355847 ) can easily add a comment if the author has blocked any of the maintainers that would be review-requested.

The issue is that @zeuner's maintainer is missing the github and githubId fields. So ofborg and other tools are unable to make the association and tag him.
That's what these fields are for @zeuner.
The last time somebody tried to fix that association, zeuner threatened to sue the NixOS Foundation over GDPR violation. It might have been a heat of the argument type of thing, but please be careful before posting any links and let zeuner decide what they want to do.

The issue is that @zeuner's maintainer is missing the github and githubId fields. So ofborg and other tools are unable to make the association and tag him.
That's what these fields are for @zeuner.
The last time somebody tried to fix that association, zeuner threatened to sue the NixOS Foundation over GDPR violation. It might have been a heat of the argument type of thing, but please be careful before posting any links and let zeuner decide what they want to do.

@zimbatm
Let's keep this discussion on-topic. Apart from misrepresenting the actual facts (maybe a misunderstanding, obviously something better discussed privately), what you write doesn't seem to have much to do with the issue at hand: The lack of a reliable mechanism that ensures maintainers can always provide feedback on PRs that touch packages they maintain.

Use GitHub's facilities to prevent comments by maintainers

I think this only happens if the PR author blocked you. (Or the PR was locked and closed due to mass ping)

This seems to confirm what I wrote above: The PR author having control over maintainers' ability to comment.
The problem might be that the blocking mechanism serves a different purpose, which might be incompatible with what expected from committers and maintainers. Users usually would block someone with whom they don't want to communicate. This is fine, but it collides with the nixpkgs community spirit at least at the point where the user still files PRs that touch packages maintained by those with whom they do not want to communicate with.

Use GitHub's facilities to prevent comments by maintainers

I think this only happens if the PR author blocked you. (Or the PR was locked and closed due to mass ping)

This seems to confirm what I wrote above: The PR author having control over maintainers' ability to comment.
The problem might be that the blocking mechanism serves a different purpose, which might be incompatible with what expected from committers and maintainers. Users usually would block someone with whom they don't want to communicate. This is fine, but it collides with the nixpkgs community spirit at least at the point where the user still files PRs that touch packages maintained by those with whom they do not want to communicate with.

I wonder whether GitHub actions (for evaluation, see #355847 ) can easily add a comment if the author has blocked any of the maintainers that would be review-requested.

If we solve this through automatism, maybe it can even be done in a more generic way, not depending on maintainer GitHub accounts. Like: A bot account writes a comment when the one week feedback period is over. This comment is only posted if no maintainer GitHub account was blocked within that week (not sure whether this is possible to determine, though). The bot account could also react to a procmail and/or matrix-commander component to forward review comments received over other communication channels registered by maintainers.

If GitHub block information was publicly available that'd be quite a safety issue, therefore I doubt that anything can be done about this with CI or automation.


[v2.4] update AuthTokenMaxTTLMinutes default to 0

The old behavior will be preserved by default. It's configurable for opt-in by changing the value.
https://github.com/rancher/rancher/issues/28668

@deniseschannon nope, our settings never override the set values on upgrade. since we're changing the default value itself, it'll only get applied when the setting is newly introduced or the value is empty


Update README.md

When merge my previous commit, one more change in Dockerfile is merged together, which I didn't support to do that.
ENTRYPOINT ["pdf2htmlEX"]
CMD ["-h"]

It is in your repository already.
So we need adjust README, but you also need update the image in hub.docker.com. Otherwise, the information will be inconsistent.

See the image has been built automatically. But build state is error
Build Code	Build Status	Created At	Last Updated
bq57lezaadg5tftatvdgbd7	error	 2015-08-17T13:26:26.867966Z	2015-08-17T13:40:42.860270Z

Thanks for noticing. I´ll revert the changes and the build should be fixed again.


Mobile screenshot and device-width not quite right

Right now, when meta viewport set width to device-width, we render the page on a screen set to the size of the device-width and take a screenshot of that same size. While that behavior is correct for initial-scale=1, it's not for device-width where the zoom level is adjusted to the the widest part of the page.

if we want to provide in the future different kind of browser, switch to firefox can't be the final solution...

fixed in using scrolling.

I don't think that fixes the issue I was reporting, so re-opening


update the usage instructions for dart2js_info

The readme for dart2js_info - https://github.com/dart-lang/sdk/blob/main/pkg/dart2js_info/README.md - indicates that people should try it out via dart pub global activate. However, the dart2js_info package is no longer published and has been marked as discontinued on pub.dev.
I'm not sure what the best way to try the tool out now is (cloning the repo, running gclient sync, and directly running the tool from pkg/dart2js_info?), but we should update the readme to whatever the current best practice is.

cc @Markzipan

Thanks for pointing this out - I'll clean this up. I've noticed some dartium references in there as well, which is concerning


K2recon final edits

big stack of changes to push k2recon work across the line.  most of this was non-converted config refs or double cluster looping.
EDIT:  This is part of #369

if I can get this to work locally I'll merge it and then start trying to kick off pipelet jobs for his.

Boom!  worked first try.  Going to self merge (terrible!) and kick off some pipelet jobs.


Comment Marker Deletion Robustness

On the project page, it notes:

Warning: If you manually delete a comment marker in the score and then activate the stale comment, MuseScore will crash trying to select a no longer existing Staff Text. Always use the Delete button from the plugin itself!

Has this been fixed? Is this a limitation of MuseScore? Or could you add checks so that it wouldn't crash, or something?

I'd consider it a bug in the plugin interface of MuseScore that attempting to select non-existing elements crashes it rather than skipping that element in the selection code.
The cause is that the element pointer the plugin has became a dangling raw pointer to a no longer existing score element.

I'd consider it a bug in the plugin interface of MuseScore

I suppose so, too.
Is there a bug filed on this already, for MuseScore?

Filing one against MS3 is no use, as that branch is no longer in development (nor has it been for over a year).
And given that the plugin API for MS4 is still in flux, it can't hurt to enter one against it; assuming this issue is still the case in there and that the plugin is able to run at all.
Which it currently can't as dockable plugins are not supported in it yet.


Adding 'auto-switch to last assumed role' feature

I haven't done much testing outside of my use case so it would be great to have some people in other AWS configurations experiment with this.

@robsweet Do you want to support the last role for each baseaccount in your work? I think that it is enough to support only one as a whole. There is a possibility that garbage entries will remain.

It’s actually saving the last assumed role for each base account/role combination and that was intentional. As an account admin, I have access to multiple roles in the base account, plus multiple member accounts to assume those roles in. Just base account wasn’t enough, which is why I implemented a hash for each profile. Roles names aren’t unique and account names aren’t unique but the hashed combination is.
Rob Sweet
<EMAIL_ADDRESS>
On Feb 16, 2018, at 7:50 PM, Toshimitsu Takahashi<EMAIL_ADDRESS>wrote:
@robsweet Do you want to support the last role for each baseaccount in your work? I think that it is enough to support only one as a whole. There is a possibility that garbage entries will remain.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

merged alternative #48


Goes back to ListView

When I click in the Task ID menu, it goes back to List View and not in Table View. How to fix this?

On my Kanboard, clicking the Task ID menu links will pop up a modal corresponding to the link.
Can you provide me with more details about this issue?


[Highlight] Feature to set highlight embed colour

This will add a new config named colour, which defaults to discord.Color.red().value (red)
This can be set via [p]highlightset colour <colour>

Thanks for the PR

Np :D


SAMPLED_ADDMM

Click to expand!
Issue Type
Feature Request
Source
binary
Tensorflow Version
2.8
Custom Code
No
OS Platform and Distribution
No response
Mobile device
No response
Python version
3.8
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current Behaviour?
Hi TF team,

Is there a plan to add dense-dense matrix multiplication at sparse locations? Pytorch has such support: https://pytorch.org/docs/1.11/generated/torch.sparse.sampled_addmm.html

It is quite useful in ML modules where using sparse connection accelerates the model and helps prevent overfitting. For example, a multi-head attention module can be more efficient if in certain cases we already know that a sparse attention is needed. Currently, the same effect can be achieved by adding the "attention_mask". But there's no performance benefit when the mask is sparse.

Standalone code to reproduce the issue
layers.MultiHeadAttention(num_heads=num_heads, key_dim=projection_dim, dropout=0.1)(x, x, attention_mask=mask)

Ideally, mask can be both sparse or dense tensor and there's performance improvement when mask's non-zero elements is sparse.

Relevant log output
No response

@sunweilunformatech
Could you elaborate about your feature and please specify the use cases for this feature. Thank you!

The feature is 2 dense matrix multiplication but only at sparse locations. The result is a sparse matrix. Pytorch already has an API for it here. The use case is for example keras multi-head attention layer supports a dense attention_mask to mask out some attention connections. This mask should come with some computation speed up in theory as there's no need for the masked element to be computed. Effectively, this requires an API for 2 dense matrix multiplications at sparse locations specified by a sparse matrix.

One specific example is I wanted to add a multi-head attention layer for vision tasks but only look at a sliding window (like a convolution) for attention. So for a hw feature map, the full attention's complexity is O(h^2w^2) which is too expensive for large image size. While in theory, with a kk sliding window, the complexity can be reduced to O(hw*k^2).

I don't think we have any current plans for this.  The pytorch version seems to only be available for cuda.  If added to TF, we would want support for cpu/gpu/tpu/xla.  Contributions are welcome in the form of a PR if someone is interested.

I'd like to try implementing that.


nvidia_x11 uses non-standard ICD filename

nvidia_x11 uses a non-standard ICD filename: nvidia.json instead of nvidia_icd.json. This breaks applications that rely on nvidia_icd.json existing (e.g. NixGL).
https://github.com/NixOS/nixpkgs/blob/f2d1041b6b5ba35662d1ffd53d2cdfd89951807e/pkgs/os-specific/linux/nvidia-x11/builder.sh#L76

@KaneTW Can you try to send a pull request with a fix?

cc @baracoder @eadwu

I'll make a PR tomorrow if no one ends up making one by then. Currently setting my machine up after a recent filesystem bork.

I think we would need to also add an arch suffix, like in the mesa package
/nix/store/iwwfzyd72a37nbfmq0p7pxqxan5zj1hk-mesa-19.1.3-drivers/share/vulkan/icd.d
intel_icd.x86_64.json  radeon_icd.x86_64.json

The nvidia package contains both 32 and 64 bit version of the associated library file.

nixGL seems to rely on the current path [1] so the update would actually break it.
[1] https://github.com/guibou/nixGL/commit/a02035314b3bfcea855f465bf7ff0ad0e4a665f1

cc @guibou regarding https://github.com/NixOS/nixpkgs/issues/86620#issuecomment-623679718

:thinking: According to this  the file names don't have to to follow any schema

The following section discusses the details of the ICD Manifest JSON file format. The JSON file itself does not have any requirements for naming. The only requirement is that the extension suffix of the file is ".json".

Thank for the notification. I'll update nixGL so it wildcard on nvidia*.json instead.

So I'll keep the file as nvidia_icd.json if it's bundled while for i686-linux, I'll create nvidia-icd.i686.json. I'm not sure if there's a point for creating both files for x86_64 since the file contents are the same.


[Node.js] Add align object to the pool for gc

Align objects should be recored in the pool for cleanup()
to avoid leak.

ping @halton if missed :)


Permission handling

Fulfills UILISTS-7
Added handlers for buttons and URL routes to disable if user does not have needed permissions

We need to cover the logic of adding/hiding buttons depending on permissions by tests because new logic is not covered.


The return of the Complete node

Another go at fixing the Node Messaging API design.
Reusing the Status node for 'done' events simple doesn't work. The work needed in a flow to handle the status node emitting both this and 'regular' status events is too much.
Despite my reluctance to introduce another new node, I have (again) concluded it is the cleanest way to do this.

@HiroyasuNishiyama @dceejay fyi. The Complete node has come back to life.
I am going to start implementing this. I will reuse your work from the existing PR where it is appropriate to do so.
I have concluded that we just need to implement it and see if it feels right in real use.

I think the semantics of this should maybe different to that of the catch node - in that by default it would not apply to all nodes on the page. (You can select all - but default should not be all IMHO)
???

@dceejay good point. Have added a comment to address that.

Following the discussions last week, I have revised this design back to the callback approach.
this.on('input', function(msg, send, done) {
   send = send || node.send;
   // do some work
   send(msg);
   if (done) {
      done();
   }
});

This reflects what is in https://github.com/node-red/node-red/pull/2227

Given the lack of any further comments or feedback, I'm merging this as the current plan for 1.0.


feat: runtimeClassName annotation support so we can support gVisor (GKE Sandbox)

This adds the runtimeClassName annotation to Deployments, Jobs, and StatefulSets so the containers can run within GKE Sandbox (gVisor). This helps with PCI compliance.
values.yaml:
searcher:
  runtimeClassName: gvisor

indexer:
  runtimeClassName: gvisor

metastore:
  runtimeClassName: gvisor

control_plane:
  runtimeClassName: gvisor

janitor:
  runtimeClassName: gvisor

bootstrap:
  runtimeClassName: gvisor

@isaachall, do you mind resolving the conflict and bumping the chart's version to 0.7.3 so we can merge this PR?

@guilload Conflict resolved & version bumped. I just finished testing the update on my cluster. Thanks!


New resdir HARMAN AIR option

works perfectly! Thks!

Initial commit: 3d5b5a1aa153ba5fd9c9a86635205b560098a3c9
Waiting for response to comment on Gamua/Adobe-Runtime-Support#163

Initial commit: 3d5b5a1aa153ba5fd9c9a86635205b560098a3c9
Waiting for response to comment on Gamua/Adobe-Runtime-Support#163


Create ab.svg

Flag icon missing

I'm guessing you haven't check how the whole thing is working.. :)


Ps5 dns settings

Is there a way to manually change the dns settings in the ps5 to be able to have online access because right now the way its set up I can play online with friends or buy games just update games

Hi!
Right now there is not sadly :(
We are only able to proxy "normal" Internet connections, but cannot do online gaming connections because of an Android OS limitation.
The PlayStation store is also very negative towards proxy networks like ours and seems to actively work against us at times sadly :(

i figured but wanted to give it a shoot and i tried everything i found online to help like changing it manually to google dns <IP_ADDRESS> and <IP_ADDRESS> and couple other ones like <IP_ADDRESS> and <IP_ADDRESS> but nothing worked but if you guys on here find a way let me know or need help testing anything im here shoot me a email<EMAIL_ADDRESS>

Thanks! For the time being no amount of tweaking is going to help but as an owner of a PS4 this is always in the back of my mind for support. Happy Holidays!


Running the tests produces a warning

The Boston housing prices dataset is deprecated due to an ethical concern. One of the tests uses it.
; pytest
====================================== test session starts ======================================
platform darwin -- Python 3.9.8, pytest-6.2.4, py-1.10.0, pluggy-0.13.1
rootdir: /Users/drj/prj/scikit-net
plugins: cov-2.12.1
collected 27 items

sknet/network_construction/tests/test_network_construction.py .........                   [ 33%]
sknet/semi_supervised/tests/test_modularity_label_propagation.py .....                    [ 51%]
sknet/supervised/tests/test_ease_of_access.py ......                                      [ 74%]
sknet/supervised/tests/test_high_level_classification.py ...                              [ 85%]
sknet/unsupervised/tests/test_stochastic_particle_competition.py ..                       [ 92%]
sknet/utils/tests/test_network_types_handler.py ..                                        [100%]

======================================= warnings summary ========================================
sknet/supervised/tests/test_ease_of_access.py::test__stationary_distribution_regressor
sknet/supervised/tests/test_ease_of_access.py::test_predictions_regressor
  /usr/local/lib/python3.9/site-packages/sklearn/utils/deprecation.py:87: FutureWarning: Function load_boston is deprecated; `load_boston` is deprecated in 1.0 and will be removed in 1.2.

      The Boston housing prices dataset has an ethical problem. You can refer to
      the documentation of this function for further details.

      The scikit-learn maintainers therefore strongly discourage the use of this
      dataset unless the purpose of the code is to study and educate about
      ethical issues in data science and machine learning.

      In this special case, you can fetch the dataset from the original
      source::

          import pandas as pd
          import numpy as np

          data_url = "http://lib.stat.cmu.edu/datasets/boston"
          raw_df = pd.read_csv(data_url, sep="\s+", skiprows=22, header=None)
          data = np.hstack([raw_df.values[::2, :], raw_df.values[1::2, :2]])
          target = raw_df.values[1::2, 2]

      Alternative datasets include the California housing dataset (i.e.
      :func:`~sklearn.datasets.fetch_california_housing`) and the Ames housing
      dataset. You can load the datasets as follows::

          from sklearn.datasets import fetch_california_housing
          housing = fetch_california_housing()

      for the California housing dataset and::

          from sklearn.datasets import fetch_openml
          housing = fetch_openml(name="house_prices", as_frame=True)

      for the Ames housing dataset.

    warnings.warn(msg, category=FutureWarning)

-- Docs: https://docs.pytest.org/en/stable/warnings.html
================================ 27 passed, 2 warnings in 37.58s ================================

This is not going to affect my review, but it would be a good idea to use a different dataset as sklearn suggest in the above warning.

The dataset was changed for the diabetes one. Therefore the issue is solved.


Date of last high risk contact wrong

Avoid duplicates

[X ] Bug is not mentioned in the FAQ

Technical details
Device name: Google Pixel 4a 5G
iOS/Android version: Android 12
App version: 2.16.2
Describe the bug
positive rapid test and positive PCR  test conducted and registered in CWA at the 20.01.2022
People with very close contact to this person for hours and every day receive high risks warnings for the 14.01 to 17.01 but not for the 18.01, 19.01, 20.01 even so in very close contact to the person for hours at those dates.
Steps to reproduce the issue
see above
Expected behaviour
last contact should be displayed for the 20.01 and not 17.01
Possible Fix
Additional context

Internal Tracking ID: EXPOSUREAPP-11569

The dates come directly from the underlying OS framework.
Seems like on days 18.01-20.01 CWA sees no contacts "above" the threshold.
More information: https://www.coronawarn.app/en/faq/#encounter_19_calc

@masema67
There is no complete up-to-date description of the risk calculation process. You might like to refer though to https://github.com/corona-warn-app/cwa-documentation/blob/master/cwa-risk-assessment.md which shows how the transmission risk level decreases over time. The app also takes account if / when symptoms were reported. The collection of FAQ articles under https://www.coronawarn.app/en/faq/#risk_assessment also discusses some aspects.
So what you describe could be correct. It is impossible to check for an individual case though because access to the data used in the calculations is restricted, due to privacy protections.

The dates come directly from the underlying OS framework.
Seems like on days 18.01-20.01 CWA sees no contacts "above" the threshold.
More information: https://www.coronawarn.app/en/faq/#encounter_19_calc

""above" the threshold" is for sure not possible, as contacts where for hours with partly no distance between the phones for quite some time

@masema67
There is no complete up-to-date description of the risk calculation process. You might like to refer though to https://github.com/corona-warn-app/cwa-documentation/blob/master/cwa-risk-assessment.md which shows how the transmission risk level decreases over time. The app also takes account if / when symptoms were reported. The collection of FAQ articles under https://www.coronawarn.app/en/faq/#risk_assessment also discusses some aspects.
So what you describe could be correct. It is impossible to check for an individual case though because access to the data used in the calculations is restricted, due to privacy protections.

Thank you! The same behavior is observed with CCTG - so it is not google but for sure a not sense making behavior by CWA.

Dear @masema67,
Thank you very much for this report. We have been discussing this case internally, and yes, the indications, although surprising, could be correct as you describe it. However, we would be very interested to talk to you, in order to get a more detailed insight about this specific case.
A developer/architect from the team would talk to you, ideally by telephone. Please, contact us via email (corona-warn-app.opensource@sap.com),  in order to arrange details. Please mention in the email the Internal Tracking ID: EXPOSUREAPP-11569
Best wishes, DS

Corona-Warn-App Open Source Team

There is no complete up-to-date description of the risk calculation process.

@MikeMcC399 what about https://github.com/corona-warn-app/cwa-documentation/blob/master/solution_architecture.md#risk-calculation?

@mlenkeit

There is no complete up-to-date description of the risk calculation process.

what about https://github.com/corona-warn-app/cwa-documentation/blob/master/solution_architecture.md#risk-calculation?

Thanks for reminding us about the section in the Solution Architecture document. This at least contains the description of how Onset of Symptoms is used.
Could you please check about the Figure 16: Risk calculation
https://github.com/corona-warn-app/cwa-documentation/blob/master/images/solution_architecture/risk_calculation.svg
which has a threshold of 13 minutes (where I would expect this to show 9 minutes).
According to https://www.coronawarn.app/en/blog/2021-04-16-corona-warn-app-risk-calculation-further-improved/ dated April 16, 2021 the risk calculation was changed last year:
"For app users, this means: Previously, an encounter between two people had to last at least 13 minutes in order to be considered for an encounter with an increased risk (red tile). Now, the app considers encounters of at least 9 minutes. Thus, encounters that represent an actual relevant contact with COVID-19 infected persons can be detected even more accurately and represented accordingly in the app as a warning about an encounter with increased risk"
So the diagram and the blog information are contradictory.

There is a related open issue https://github.com/corona-warn-app/cwa-documentation/issues/586 from April 2021 which has yet to be resolved.

@mlenkeit
I took a closer look at the diagram https://github.com/corona-warn-app/cwa-documentation/blob/master/images/solution_architecture/risk_calculation.svg
On the left-hand side it is still using 13 minutes and on the right-hand side it uses 9 minutes.

Dear @masema67,
Thank you very much for this report. We have been discussing this case internally, and yes, the indications, although surprising, could be correct as you describe it. However, we would be very interested to talk to you, in order to get a more detailed insight about this specific case.
A developer/architect from the team would talk to you, ideally by telephone. Please, contact us via email (corona-warn-app.opensource@sap.com), in order to arrange details. Please mention in the email the Internal Tracking ID: EXPOSUREAPP-11569
Best wishes, DS
Corona-Warn-App Open Source Team

I sent them an email and will be glad to give more details in the phone.
best
masema67

@masema67 Ok! Thanks!
Best wishes, DS

Corona-Warn-App Open Source Team

The risk calculation diagram images/solution_architecture/risk_calculation.svg has now been corrected.

Thanks for updating the date of symptoms onset. Only 4 days after the onset leads to TRL > 2 which shows a warning to other persons

@thomasaugsten
Thanks for the post with the diagram. This is from the presentation https://www.coronawarn.app/assets/documents/cwa-rc3.pdf from @tklingbeil in Dec 2020 (see https://www.coronawarn.app/en/blog/2020-12-30-cwa-behind-the-scenes/ for anybody who would like to view the video as well).

I see that @masema67 updated the information. Onset of symptoms Jan 14, 2022 together with test date Jan 20, 2022. By my calculation, onset of symptoms is 6 days before submission.
Using the table from the presentation on page 15, with the row 6 "Days since the onset of symptoms (at the point of submission)", Day 1 (Jan 19) and Day 0 (Jan 20) are both shown with roman numeral "II" Transmission Risk Level (TRL).
The updated diagram of risk calculation on images/solution_architecture/risk_calculation.svg shows TRL of "II" being weighted with a factor 0.0. This means that exposures on the days Jan 19 and Jan 20 do not result in a red risk result and therefore the behavior which @masema67 reported as an issue, seems to be correct.
Maybe @thomasaugsten could confirm that the above is correct?

@MikeMcC399 yes, that's correct. The 19th and 20th both translate to TRL <= II, and thus, do not count as exposures and are rightly not considered for the date of the last exposure.

@masema67
It seems that we have a good explanation for what you saw. If you agree that your issue has been addressed, you could close the issue here.

@mlenkeit I assume / hope you are in close feedback loop with RKI if the "risk profile" is still considered good from today's point of view?
Iirc it was published in Dec 2020 (but maybe the numbers were updated since then?)
Since then we had Alpha, Delta, and now Omikron.

@ndegendogo
There was a blog post on this subject a couple of weeks ago.  That wasn't really the subject of this issue however.

The discussion about Omikron is in https://github.com/corona-warn-app/cwa-documentation/issues/787

@ndegendogo the blog post that @MikeMcC399 referenced (thx!) sums it up pretty well 😊

Is there anything further which can be done on this issue?

Closing as suggested.


Data Loss Test for Pause Feature

Summary
We need to gain confidence that the Pause Feature is doing what we expect. Ideally, we'd design a test that could cause data loss, but I'm not sure how difficult that would be. Alternatively, we may just need to verify that pausing happened when it was supposed to.

Message from the maintainers:
If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

I am moving the "Load Test" that was in the original description out of here and making this issue strictly related to a test for "data loss".

I have just now performed a basic test of a Pipeline update in which a vertex gets removed. In this case, I use a vertex which intentionally sleeps, so it builds up a lot of data in its buffer.
If there were no "data loss prevention", the data would get lost. But in this case, the data is drained through all of the way and only once the Numaflow Controller has finished and declared the Pipeline as "Paused" do we resume the Pipeline Running.
I'm attaching the artifacts here:
Archive.zip
The source Pod is an http listener. We send an auto-incrementing integer through a bash script to it. Upon failure, the bash script continues to retry the same integer. The bash script sends at a slightly higher rate than the "cat" Vertex in the Pod sleeps, to build up a buffer. We want to confirm that the Pipeline drains all messages that were successfully sent to the Source Pod before the Pipeline goes back to "Running" state.
Instructions:

kubectl apply -f PipelineRollout1.yaml
Port forward "in" (source) Pod (port 8443)
Tail "out" (sink) log
bash curl-auto-increment.sh
See a new line printed with the next integer in the "out" log every 10 seconds. After a few seconds, see that there are a few more messages that have been sent to Source Pod (you can tell by reading the output from the bash script) than the "out" log.
kubectl apply -f PipelineRollout2.yaml
Watch the Pipeline pause while the "out" log gradually prints the remaining messages
Watch the Pipeline enter Paused and then immediately re-enter Running state once all messages have been printed

I have now performed a test in which 2 Pipelines are running, which are just like the Pipeline from the previous test, where one vertex is a very slow "cat" vertex (it sleeps), but in this case I performed a Numaflow Controller version update and observed that both of them paused correctly. One bash script curled to one Pipeline, and another bash script to the other.
Once I tried to update the Numaflow Controller, both pipelines paused until all of the data that was sent to them went through, and only then did the Numaflow Controller Pod update, and then both pipelines resumed. I observed that the new Numaflow Controller Pod's creation timestamp preceded the timestamp of all of the pipeline Pods.
I then repeated the same test but for updating the ISBService.

This testing is complete.


Add Procfile management tool for application

Why
As having more than one process is very common, Procfile is preferred tool to manage more than one process application.
Acceptance Criteria

Add forego or goreman.

Who Benefits?
Developers

Forego added by @hoangmirs in #50 (PR #62 ) ;-)