improt XD Error:

branches:main
NullReferenceException: Object reference not set to an instance of an object
Unity.VectorGraphics.Editor.SVGImporter.BuildTexture (UnityEngine.Sprite sprite, System.String name) (at Library/PackageCache/com.unity.vectorgraphics@2.0.0-preview.20/Editor/SVGImporter.cs:552)
Unity.VectorGraphics.Editor.SVGImporter.GenerateTexturedSpriteAsset (UnityEditor.AssetImporters.AssetImportContext ctx, UnityEngine.Sprite sprite, System.String name) (at Library/PackageCache/com.unity.vectorgraphics@2.0.0-preview.20/Editor/SVGImporter.cs:452)
Unity.VectorGraphics.Editor.SVGImporter.OnImportAsset (UnityEditor.AssetImporters.AssetImportContext ctx) (at Library/PackageCache/com.unity.vectorgraphics@2.0.0-preview.20/Editor/SVGImporter.cs:336)
UnityEditor.AssetImporters.ScriptedImporter.GenerateAssetData (UnityEditor.AssetImporters.AssetImportContext ctx) (at <11d97693183d4a6bb35c29ae7882c66b>:0)
UnityEditor.AssetDatabase:ImportAsset(String)
AkyuiUnity.Xd.SvgToPng:Convert(String, Vector2, ViewportOptions, XdImportSettings) (at Assets/AkyuiUnity.Xd/Editor/Svg/SvgToPng.cs:52)
AkyuiUnity.Xd.<>c__DisplayClass5_2:b__0() (at Assets/AkyuiUnity.Xd/Editor/XdObjectParser/ShapeObjectParser.cs:126)
AkyuiUnity.Xd.XdAssetHolder:Load(String) (at Assets/AkyuiUnity.Xd/Editor/XdAssetHolder.cs:41)
AkyuiUnity.Xd.XdAkyuiLoader:LoadAsset(String) (at Assets/AkyuiUnity.Xd/Editor/XdAkyuiLoader.cs:69)
AkyuiUnity.Editor.Importer:ImportAssets(IAkyuiImportSettings, IAkyuiLoader, PathGetter, AkyuiLogger, IAkyuiProgress) (at Assets/AkyuiUnity/Editor/Importer.cs:191)
AkyuiUnity.Editor.Importer:Import(IAkyuiImportSettings, IAkyuiLoader, AkyuiLogger, IAkyuiProgress) (at Assets/AkyuiUnity/Editor/Importer.cs:87)
AkyuiUnity.Editor.Importer:Import(IAkyuiImportSettings, IAkyuiLoader[]) (at Assets/AkyuiUnity/Editor/Importer.cs:46)
AkyuiUnity.Xd.XdImporter:Import(XdImportSettings, String[]) (at Assets/AkyuiUnity.Xd/Editor/XdImporter.cs:45)
AkyuiUnity.Xd.XdImportSettingsEditor:OnInspectorGUI() (at Assets/AkyuiUnity.Xd/Editor/XdImportSettingsEditor.cs:38)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)

Asset import failed, "Assets/Temp.svg" > NullReferenceException: Object reference not set to an instance of an object
Unity.VectorGraphics.Editor.SVGImporter.BuildTexture (UnityEngine.Sprite sprite, System.String name) (at Library/PackageCache/com.unity.vectorgraphics@2.0.0-preview.20/Editor/SVGImporter.cs:552)
Unity.VectorGraphics.Editor.SVGImporter.GenerateTexturedSpriteAsset (UnityEditor.AssetImporters.AssetImportContext ctx, UnityEngine.Sprite sprite, System.String name) (at Library/PackageCache/com.unity.vectorgraphics@2.0.0-preview.20/Editor/SVGImporter.cs:452)
Unity.VectorGraphics.Editor.SVGImporter.OnImportAsset (UnityEditor.AssetImporters.AssetImportContext ctx) (at Library/PackageCache/com.unity.vectorgraphics@2.0.0-preview.20/Editor/SVGImporter.cs:336)
UnityEditor.AssetImporters.ScriptedImporter.GenerateAssetData (UnityEditor.AssetImporters.AssetImportContext ctx) (at <11d97693183d4a6bb35c29ae7882c66b>:0)
UnityEditor.AssetDatabase:ImportAsset(String)
AkyuiUnity.Xd.SvgToPng:Convert(String, Vector2, ViewportOptions, XdImportSettings) (at Assets/AkyuiUnity.Xd/Editor/Svg/SvgToPng.cs:52)
AkyuiUnity.Xd.<>c__DisplayClass5_2:b__0() (at Assets/AkyuiUnity.Xd/Editor/XdObjectParser/ShapeObjectParser.cs:126)
AkyuiUnity.Xd.XdAssetHolder:Load(String) (at Assets/AkyuiUnity.Xd/Editor/XdAssetHolder.cs:41)
AkyuiUnity.Xd.XdAkyuiLoader:LoadAsset(String) (at Assets/AkyuiUnity.Xd/Editor/XdAkyuiLoader.cs:69)
AkyuiUnity.Editor.Importer:ImportAssets(IAkyuiImportSettings, IAkyuiLoader, PathGetter, AkyuiLogger, IAkyuiProgress) (at Assets/AkyuiUnity/Editor/Importer.cs:191)
AkyuiUnity.Editor.Importer:Import(IAkyuiImportSettings, IAkyuiLoader, AkyuiLogger, IAkyuiProgress) (at Assets/AkyuiUnity/Editor/Importer.cs:87)
AkyuiUnity.Editor.Importer:Import(IAkyuiImportSettings, IAkyuiLoader[]) (at Assets/AkyuiUnity/Editor/Importer.cs:46)
AkyuiUnity.Xd.XdImporter:Import(XdImportSettings, String[]) (at Assets/AkyuiUnity.Xd/Editor/XdImporter.cs:45)
AkyuiUnity.Xd.XdImportSettingsEditor:OnInspectorGUI() (at Assets/AkyuiUnity.Xd/Editor/XdImportSettingsEditor.cs:38)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)
UnityEditor.AssetDatabase:ImportAsset (string)
AkyuiUnity.Xd.SvgToPng:Convert (string,UnityEngine.Vector2,Unity.VectorGraphics.ViewportOptions,AkyuiUnity.Xd.XdImportSettings) (at Assets/AkyuiUnity.Xd/Editor/Svg/SvgToPng.cs:52)
AkyuiUnity.Xd.ShapeObjectParser/<>c__DisplayClass5_2:b__0 () (at Assets/AkyuiUnity.Xd/Editor/XdObjectParser/ShapeObjectParser.cs:126)
AkyuiUnity.Xd.XdAssetHolder:Load (string) (at Assets/AkyuiUnity.Xd/Editor/XdAssetHolder.cs:41)
AkyuiUnity.Xd.XdAkyuiLoader:LoadAsset (string) (at Assets/AkyuiUnity.Xd/Editor/XdAkyuiLoader.cs:69)
AkyuiUnity.Editor.Importer:ImportAssets (AkyuiUnity.Editor.ScriptableObject.IAkyuiImportSettings,AkyuiUnity.Loader.IAkyuiLoader,AkyuiUnity.Editor.PathGetter,AkyuiUnity.Editor.AkyuiLogger,AkyuiUnity.Editor.IAkyuiProgress) (at Assets/AkyuiUnity/Editor/Importer.cs:191)
AkyuiUnity.Editor.Importer:Import (AkyuiUnity.Editor.ScriptableObject.IAkyuiImportSettings,AkyuiUnity.Loader.IAkyuiLoader,AkyuiUnity.Editor.AkyuiLogger,AkyuiUnity.Editor.IAkyuiProgress) (at Assets/AkyuiUnity/Editor/Importer.cs:87)
AkyuiUnity.Editor.Importer:Import (AkyuiUnity.Editor.ScriptableObject.IAkyuiImportSettings,AkyuiUnity.Loader.IAkyuiLoader[]) (at Assets/AkyuiUnity/Editor/Importer.cs:46)
AkyuiUnity.Xd.XdImporter:Import (AkyuiUnity.Xd.XdImportSettings,string[]) (at Assets/AkyuiUnity.Xd/Editor/XdImporter.cs:45)
AkyuiUnity.Xd.XdImportSettingsEditor:OnInspectorGUI () (at Assets/AkyuiUnity.Xd/Editor/XdImportSettingsEditor.cs:38)
UnityEngine.GUIUtility:ProcessEvent (int,intptr,bool&)

NullReferenceException: Object reference not set to an instance of an object
AkyuiUnity.Loader.AkyuiCompressor.Compress (AkyuiUnity.Loader.IAkyuiLoader loader) (at Assets/AkyuiUnity/Loader/AkyuiCompressor.cs:47)
AkyuiUnity.Xd.XdImporter.ExportAkyui (AkyuiUnity.Xd.XdImportSettings xdSettings, System.Collections.Generic.List`1[T] loaders, AkyuiUnity.Editor.AkyuiLogger logger) (at Assets/AkyuiUnity.Xd/Editor/XdImporter.cs:62)
AkyuiUnity.Xd.XdImporter.Import (AkyuiUnity.Xd.XdImportSettings xdSettings, System.String[] xdFilePaths) (at Assets/AkyuiUnity.Xd/Editor/XdImporter.cs:46)
AkyuiUnity.Xd.XdImportSettingsEditor.OnInspectorGUI () (at Assets/AkyuiUnity.Xd/Editor/XdImportSettingsEditor.cs:38)
UnityEditor.UIElements.InspectorElement+<>c__DisplayClass59_0.b__0 () (at :0)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr, Boolean&)

There seems to be an error within the vectorgraphics package<EMAIL_ADDRESS>) in unity.
It seems that one of the objects in the XD file is causing the problem, but I need to get the XD file to reproduce it in order to find out more.

https://drive.google.com/file/d/1eVa3gupP54Vjg3zMtamWbgFvNlKU2ySt/view?usp=share_link
Thank you very much,XD file in url .

Thank you! You're very helpful!
The reason for the error was that the size of the "直线 2" object in the XD file was zero.
We have fixed it so that objects with size 0 are not parsed, so please update and try it out.
https://github.com/kyubuns/AkyuiUnity/releases/tag/v1.4.1

thanks


Make cssjanus.js work in a browser and compatible with closure compiler.

This will help with an integration I'm trying to do at Google.
Thanks for taking a look!

@scriby Thanks for raising this issue. The current implementation is indeed tailored specifically towards use in Node.js, and does not consider the browser environment.
As you have found, the CSSJanus library itself is dependency-free and should work without issue in any JavaScript-based environment. The only issue is the export mechanism.
I ran into this before with the demo, but found another way for that (see https://cssjanus.github.io/ and index.html).
Regarding the actual change proposal, I would prefer to use the export pattern rather than conditional wrapping of the entire code. Could you update your pull request to use that pattern instead? For an example, see wikimedia/oojs:/src/export.js.

I attempted to account for the feedback, but not quite sure if I got it quite like you wanted. (I couldn't use "this" to export the variable due to a couple things I commented on in the other review).
I went ahead and put the IIFE in, but just let me know if you'd like it back out. I don't really think it's too big of a problem for the node use case, but if you wanted to keep the blame cleaner I could see an argument against it. I am also fine just patching the IIFE in on the Google side.

@scriby Yeah, I'd prefer not to have the IFFE in the Node source, it seems counter-intuitive given Node has files locally scoped by default. I was thinking of adding it in a build step.
If you could remove the IFFE, I'll go ahead and land this. We can look at the build step in a later change.

IIFE is out, thanks!

Do you think you might be able to publish these changes to npm? Thanks!

@scriby Yep. I was going to do the build stuff as well so that it actually works as-is in a browser, but I suppose we can do that later and I don't have the time for it right now.
I'll cut a release as soon as https://github.com/cssjanus/cssjanus/pull/64 lands.

@scriby This is now done!

Thank you!


[IMPROVE] refactor hard-coded component data into parameters (react component props)

Proposed changes
Put all Hardcoded content outside of component in app/data folder and improved the responsiveness of Infotiles and carousel component by adding media query.
ScreenShot
Before

After

Hi @Sing-Li , I think you are trying to explain that we should fetch hard-coded data from strapi and then pass it to any component as a prop as we did in the index.js file.
Let's say we have infotiles, we will create a collection for tiles in strapi and then fetch data from there. Right?

@nishant23122000   For infotiles - partially yes.     But let say for Github or Leaderboard components - we want parameterization at the "backend level"    So the argument would be a URL for a Github repository, or URL to an instance of a GSoC leaderboard.
For one single infotile - I think the parameterization should be right on the props of the component - say with Title ,   Description,  TileImage
How we should initialize a collection of infotiles with data from strapi -- need to be thought out some more.    The mechanism should NOT hinder the use of one single infotile on a page  (in which case it doesn't make sense to have the data always in strapi)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.10 out of 12 committers have signed the CLA.:white_check_mark: nishant23122000:white_check_mark: sidmohanty11:white_check_mark: Sing-Li:white_check_mark: debdutdeb:white_check_mark: samad-yar-khan:white_check_mark: Dnouv:white_check_mark: abhinavkrin:white_check_mark: RonLek:white_check_mark: demonicirfan:white_check_mark: dudanogueira:x: Rohan Lekhwani:x: nik23122000Rohan Lekhwani seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Update sources-dist.json

Adding lupusec to latest

Lupusec is Alarm system, correct? Then please use (in this repo commit and also in your io-package.json) "alarm" as adapter-category please (instead of general/utility mixture)!
Do you have added Bluefox to NPM as owner?
Please add README info that it only supports Admin-v3! (because not stable till now)
It would be cool to offer io-package and Admin translations in all languages (you can use http://iobroker.net:3000/ ...)
Please remove www directory from adapter if not needed.
Thank you!


Not working on mobile browser

Describe the bug
The app is not functioning correctly on mobile browsers.
To Reproduce
Steps to reproduce the behavior:

Launch the sample web demo or create a new one.
Host it on a server.
Access the app from a mobile browser.
Observe a grey overlay screen in the chat area.

Expected behavior
The chat area should be fully functional without any grey overlay.
Screenshots

Desktop (please complete the following information):

OS: android mobile browser and ios mobile browser
Version 2.1.1

Smartphone (please complete the following information):

Device: IPhone all versions tested on IPhone X ,IPhone 15 Pro .
OS: Latest ios and android versions
Version 2.1.1

i have the same issue, need solution pls


Add Chacha8 support in "transport/shadowsocks/shadowstream/cipher.go"

Please don't post code that doesn't work at all.


exceptions for requireCapitalizedComments

I like the requireCapitalizedComments rule, but I ran into the problem, that some tools like jshint or istanbul require their inline configuration to be lowercase.
For example:
/* istanbul ignore else  */
if (foo.hasOwnProperty('bar')) {
    // do something
}

isn't working with the requireCapitalizedComments rule.
My suggestion:
requireCapitalizedComments should accept an array of strings. These words can be exceptions to the upper case rule.
So with
requireCapitalizedComments: ["globals", "istanbul", "jshint"]

the above example would work.
(The same could be done for disallowCapitalizedComments, too.)
Any thoughts?

Want to back this issue? Place a bounty on it! We accept bounties via Bountysource.

Dup of #1045

Closing this one since discussion already started on the dupe.

Don't forget to add labels :-)


Font used in screenshot

Hi, what font did you use to make != appear as ? thanks :)

It's JetBrains Mono with ligatures turned on :)

Oh, thanks!

How do i set JetBrainsMono Nerd Font as my font-family in this theme?

It's in the general settings of Visual Studio Code, the 3rd option from the top should be Font Family.


Adding back missing configurations

Related Issue
CORE-39145
Motivation and Context
Need to expose missing configurations.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All tests pass and I've made any necessary test changes.
[ ] I've updated the schema in extension.json or no changes are necessary.

I'd normally wait for @liljenback to merge this, but we're trying to get a new build out quickly and to simplify the process I'm going to merge it now since it has two approvals.


project that has folder removed is not listed

but sometimes it would be nice to still see the project, so can remember where it used to be..
currently its skipped
https://github.com/unitycoder/UnityLauncher/blob/76213b46c0101b2ae8b32fd27e4ab7361f1adbeb/UnityLauncher/Form1.cs#L351

actually not that useful, cannot really remove it from the list then?

needed this again.. could make it as an option checkbox in settings

this is available in the new version https://github.com/unitycoder/UnityLauncherPro


Prevent self notifications from popping up

@nidalaa this should be just enough :dancer:

Cherry-picked here https://github.com/lonelyplanet/rizzo/pull/1378/commits


Small fix for possible index array error

Description
Small fix for possible index array error
Type of change

[ ] Refactor
[ ] New feature
[x] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library
[ ] Bump-up library or tool used for development (does not change the final image)

/lgtm

/approve


Better to flatten the label array in metric.F1()

Description
Unlike the other metrics, the current metric.F1() doesn't flatten the label. Commonly the label would have the shape of (batch_size, 1), so it could be better to flatten it inside the F1() method. Otherwise it will give a wrong result without error, which could be hard to debug.
Error Message
(Paste the complete error message, including stack trace.)
To Reproduce
(If you developed your own code, please provide a short script that reproduces the error. For existing examples, please provide link.)
Steps to reproduce
(Paste the commands you ran that produced the error.)

What have you tried to solve it?

Environment
We recommend using our script for collecting the diagnositc information. Run the following command and paste the outputs below:
curl --retry 10 -s https://raw.githubusercontent.com/dmlc/gluon-nlp/master/tools/diagnose.py | python

# paste outputs here

We will have label shape = (B, N_labels) in multi-label classification problems, e.g., the PPI dataset used in Graph Neural Networks (https://cs.stanford.edu/people/jure/pubs/graphsage-nips17.pdf), and also multi-class classification, e.g., image classification.
Flattening the labels is thus not an option and you may refer to the definition in scikit_learn: https://scikit-learn.org/stable/modules/generated/sklearn.metrics.f1_score.html and the implementation here https://github.com/apache/incubator-mxnet/issues/9586

Thank you for explanation!
So the current implementation in metric.F1() is not good because it only support binary classification problem and label shape = (B, ). I can refer to the #9586 implementation for my scripts then.

@zburning I think the guideline for the refactoring is to try to follow the convention of scikit_learn.

@zburning Also, would you provided an example of this issue that was labeled as bug? This helps us understand the problem. Currently, I find that this one looks more like a feature request than a bug. Just correct me if I'm wrong.

@sxjscience Sorry I didn't make it clear. An example script is:
import mxnet as mx
pred = mx.nd.array([[-2.4738965  , 2.7095912 ],
 [ 1.4827207 , -1.6053244 ],
 [ 0.66689086 ,-1.0119148 ],
 [ 0.54501575 ,-0.8739182 ],
 [ 1.7229283  ,-1.80466   ],
 [-2.1540372  , 2.3391898 ],
 [-0.574123   , 0.18217295],
 [-1.5451021  , 1.3035003 ],
 [-2.366786   , 2.5836499 ],
 [-2.469643   , 2.6291811 ]])

label = mx.nd.array([[1],
 [0],
 [0],
 [1],
 [0],
 [1],
 [0],
 [1],
 [1],
 [1]])

print(pred.shape, label.shape) # pred shape: (10, 2), label shape: (10, 1)

metric = mx.metric.F1()
metric.update([label], [pred])
print(metric.get()) # ('f1', 0.6)

metric.reset()
metric.update([label.reshape(-1)], [pred]) # label shape: (10,)
print(metric.get()) # ('f1', 0.8333333333333334) This one is the correct result

The current F1() uses the _BinaryClassificationMetrics() class to update the stats. So in _BinaryClassificationMetrics.update_binary_stats(), it has:
 pred = pred.asnumpy()
label = label.asnumpy().astype('int32')
pred_label = numpy.argmax(pred, axis=1)
check_label_shapes(label, pred)

The problem is that numpy.argmax(pred, axis=1) returns an array of shape (batch, ), the following computing method requires the label be the same size, i.e, the label should also be (batch, ). Also the following check_label_shapes() actually does nothing because the key argument "shape" is set to False by default. So the function can run without error but return a wrong result. It is easy to solve but since you mentioned refactoring it to support multi-label classification, we may not rely on the _BinaryClassificationMetrics() in the future? But anyway I think the current setting in _BinaryClassificationMetrics() is not good and actually other metrics(e.g. MCC()) will also suffer this problem potentially.

@sxjscience Sorry I didn't make it clear. An example script is:
import mxnet as mx
pred = mx.nd.array([[-2.4738965  , 2.7095912 ],
 [ 1.4827207 , -1.6053244 ],
 [ 0.66689086 ,-1.0119148 ],
 [ 0.54501575 ,-0.8739182 ],
 [ 1.7229283  ,-1.80466   ],
 [-2.1540372  , 2.3391898 ],
 [-0.574123   , 0.18217295],
 [-1.5451021  , 1.3035003 ],
 [-2.366786   , 2.5836499 ],
 [-2.469643   , 2.6291811 ]])

label = mx.nd.array([[1],
 [0],
 [0],
 [1],
 [0],
 [1],
 [0],
 [1],
 [1],
 [1]])

print(pred.shape, label.shape) # pred shape: (10, 2), label shape: (10, 1)

metric = mx.metric.F1()
metric.update([label], [pred])
print(metric.get()) # ('f1', 0.6)

metric.reset()
metric.update([label.reshape(-1)], [pred]) # label shape: (10,)
print(metric.get()) # ('f1', 0.8333333333333334) This one is the correct result

The current F1() uses the _BinaryClassificationMetrics() class to update the stats. So in _BinaryClassificationMetrics.update_binary_stats(), it has:
 pred = pred.asnumpy()
label = label.asnumpy().astype('int32')
pred_label = numpy.argmax(pred, axis=1)
check_label_shapes(label, pred)

The problem is that numpy.argmax(pred, axis=1) returns an array of shape (batch, ), the following computing method requires the label be the same size, i.e, the label should also be (batch, ). Also the following check_label_shapes() actually does nothing because the key argument "shape" is set to False by default. So the function can run without error but return a wrong result. It is easy to solve but since you mentioned refactoring it to support multi-label classification, we may not rely on the _BinaryClassificationMetrics() in the future? But anyway I think the current setting in _BinaryClassificationMetrics() is not good and actually other metrics(e.g. MCC()) will also suffer this problem potentially.

@zachgk assign [@mli ]

@zburning Are you willing to fix this problem?

@sxjscience Yes, I would like to work on it.


Fixes deployment scripts

This PR fixes the deployment scripts and provides a new method to do it, based on https://docs.travis-ci.com/user/encrypting-files/.
It also removes the pomExtras settings for now, according to https://github.com/scala-exercises/scala-exercises/issues/600
Please, @raulraja could you review? Thanks!

Current coverage is 29.04% (diff: 100%)

No coverage report found for master at fa328c3.

Powered by Codecov. Last update fa328c3...4aa0663


Validation error is misleading when python is not installed

I am attempting to install KET on a 1 node environment (install and target node are the same). Started with the core Ubuntu server image which does not have all the standard libraries.
I tried to run kismatic install validate and received the following error:
 ./kismatic install validate

Validating==========================================================================
Reading installation plan file "kismatic-cluster.yaml"                          [OK]
Validating installation plan file                                               [OK]
error running preflight: error running ansible playbook: error running playbook: fork/exec ansible/bin/ansible-playbook: no such file or directory

There are two asks here:

The validation step should make sure that you have the underlying libraries installed
The documentation should list any foundational requirements to run kismatic

@eriklg can you provide more details about the Ubuntu image you used? Vagrant?

@alexbrand Yep, it was https://www.ubuntu.com/download/server Ubuntu Server 16.04.1 LTS . I installed the core server (gives you an option at the end) with no additional libraries/packages.

Thanks @eriklg . I assume this was on a bare VM and not through something like Vagrant?

Correct. I created a new VM and installed using that ISO.

i got the code from github and built the go source using 'go install main.go'  it compiled all dependent go source in pkg folder. and later when i run 'main install apply' ,I am getting the same error. Do i have to do a build of python classes to get the bin folder in playbook folder ?

in case i want to change to code make file will not help me change it. I want to change my cni to pick up flannel my  approach  needs to be little different than doing a make

I pointed my ansibleDir  to the out folder generated from the  make command and things are working as program is able to find the needed folder

Thanks Dimitri for reply.
I will keep you updated on the changes.
From: Dimitri Koshkin<EMAIL_ADDRESS>Sent: Thursday, November 9, 2017 7:26 AM
To: apprenda/kismatic<EMAIL_ADDRESS>Cc: Ranajit Jana (Service Transformation<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [apprenda/kismatic] Validation error is misleading when python is not installed (#173)
** This mail has been sent from an external source. Treat hyperlinks and attachments in this email with caution**
@ranajit-janahttps://clicktime.symantec.com/a/1/A-O0RvleOXo4ZBjSbUxCGLcdOwS6Y2uGWyY2K1goBTg=?d=epBM-_N2gmcWnjMNX8Il5NOy9pLQTiUa7hQH2i9LXnUOGHityKFFeD4lv_WLCVWV9MgEgQRrsVsvhbAZF-B3iHyyTrQRG6ZMxFqCMWUbhoCSmNRSJRP_4gLLyxX5WEQTAd1B7axQj1LI8KVJCwRtJpHGniqFHa--HnT_DBYSKH2-mv-7QSvV62JYN03Dtc2DjEKrG0KBTEUpHHMr9TNaHA9Y3u2HrzSkADSxwL2R4YJVDrDKFu9OGixPVpwbqZHNMU89v6lwuF43Fy4hA1xh3zV0C3r1QKS1OA3OIuUJqEXc1iQh0AyNMttZVvdXAHkVqAPg9OWnfkLV6iYcMHs_kHQO7Udylfms8JLY3Y_O_qE89MrlyKPDI2KDYoBSMTTgG9JLFNBWJyLb9VrKN0gT6Y-m6Baj8wsh7LJZf-67DfdBxROyYiMnsvP6kqd2Mys6ojUaSx_cUzfRweck4GpZ7VieOxfy0g8ISr6RbpVNF5FZt3sAxhM6wKVvfD_4ebpSRr6F&u=https%3A%2F%2Fgithub.com%2Franajit-jana that will only build the go code you also need all the dependencies.
Run make dist and you should get an out/ directory that will contain the go binary plus all the Ansible code and vendored dependencies.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://clicktime.symantec.com/a/1/A1sGQeUO7wk9iuzCCKi0X1DSAkPiBU72y2gu7-SYQC8=?d=epBM-_N2gmcWnjMNX8Il5NOy9pLQTiUa7hQH2i9LXnUOGHityKFFeD4lv_WLCVWV9MgEgQRrsVsvhbAZF-B3iHyyTrQRG6ZMxFqCMWUbhoCSmNRSJRP_4gLLyxX5WEQTAd1B7axQj1LI8KVJCwRtJpHGniqFHa--HnT_DBYSKH2-mv-7QSvV62JYN03Dtc2DjEKrG0KBTEUpHHMr9TNaHA9Y3u2HrzSkADSxwL2R4YJVDrDKFu9OGixPVpwbqZHNMU89v6lwuF43Fy4hA1xh3zV0C3r1QKS1OA3OIuUJqEXc1iQh0AyNMttZVvdXAHkVqAPg9OWnfkLV6iYcMHs_kHQO7Udylfms8JLY3Y_O_qE89MrlyKPDI2KDYoBSMTTgG9JLFNBWJyLb9VrKN0gT6Y-m6Baj8wsh7LJZf-67DfdBxROyYiMnsvP6kqd2Mys6ojUaSx_cUzfRweck4GpZ7VieOxfy0g8ISr6RbpVNF5FZt3sAxhM6wKVvfD_4ebpSRr6F&u=https%3A%2F%2Fgithub.com%2Fapprenda%2Fkismatic%2Fissues%2F173%23issuecomment-343022726, or mute the threadhttps://clicktime.symantec.com/a/1/37jfQIU6SeapFtJ2Ohs_gxVOeit1TtMqWDOu832zi5g=?d=epBM-_N2gmcWnjMNX8Il5NOy9pLQTiUa7hQH2i9LXnUOGHityKFFeD4lv_WLCVWV9MgEgQRrsVsvhbAZF-B3iHyyTrQRG6ZMxFqCMWUbhoCSmNRSJRP_4gLLyxX5WEQTAd1B7axQj1LI8KVJCwRtJpHGniqFHa--HnT_DBYSKH2-mv-7QSvV62JYN03Dtc2DjEKrG0KBTEUpHHMr9TNaHA9Y3u2HrzSkADSxwL2R4YJVDrDKFu9OGixPVpwbqZHNMU89v6lwuF43Fy4hA1xh3zV0C3r1QKS1OA3OIuUJqEXc1iQh0AyNMttZVvdXAHkVqAPg9OWnfkLV6iYcMHs_kHQO7Udylfms8JLY3Y_O_qE89MrlyKPDI2KDYoBSMTTgG9JLFNBWJyLb9VrKN0gT6Y-m6Baj8wsh7LJZf-67DfdBxROyYiMnsvP6kqd2Mys6ojUaSx_cUzfRweck4GpZ7VieOxfy0g8ISr6RbpVNF5FZt3sAxhM6wKVvfD_4ebpSRr6F&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPjTVKevEna80_VKhTg_XLAQGYo4a-Xlks5s0lu-gaJpZM4LRLkp.

This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com

The information contained in this electronic message and any attachments to this message are intended for the exclusive use of the addressee(s) and may contain proprietary, confidential or privileged information. If you are not the intended recipient, you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately and destroy all copies of this message and any attachments. WARNING: Computer viruses can be transmitted via email. The recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email. www.wipro.com

This email has been scanned by the Symantec Email Security.cloud service.
For more information please visit http://www.symanteccloud.com


Add retry logic to couchdb update

For couchdb, an update conflict shouldn't directly throw an error. It should cause a retry: random wait, GET the new version, re-apply the transformation, try to PUT again. Repeat until it works. Also, I think that it would be good if the update function accepted a transformation function rather than a new version. Have a look at this:
https://github.com/thejh/node-relax#readme
https://github.com/thejh/node-relax/blob/master/index.co#L40-55

Not against this, but it should be optional.


Refactor federated attestation signing logic

closes #9929

I think you need to add @celo/identity to the protocol package.json, as it currently isn't being imported

refactored this PR so /protocol doesn't pull in the identity SDK


Token field is too small

Tokens are typically much longer than the current field, and though they can be pasted there,
it doesn't look good.

@miq-bot add_label providers/containers
@miq-bot add_label ui
cc @simon3z @oschreib

The file we need to edit seems to be this one: app/views/layouts/_container_auth.html.haml
Im not sure what is the correct way to adjust the length of the field.

@dclarizio Should this be fixed or waited out considering the conversion to patternfly?

@epwinchell Please confirm that patternfly will take care of this.

@dclarizio Yes, the Patternfly conversion will take care of this.

Resolved with Patternfly conversion


fixed bug vifino/sled#31; rewrite modules_init; central outmod pointer

Why the hell would you even bother having multiple pointers to outmod?
fixed vifino/sled#31

Hey!
Nice changes overall, a bit cleaner, although I would really like it if we could get rid of the malloc, allocating a single int is not so nice, even though os_unix does it too..
It should be rather trivial.

I renamed outmod to outmod_c as outmod now references to a global pointer to the output module.
We have to pass a pointer to outmodno to the modules_init function to change its value outside the function. Doing this with &outmodno might also work, whilst int outmodno is used.

Yes, doing it this way works.

Awesome, thanks.


Make playground results selectable

https://twitter.com/jamiew/status/1634581483552665601?s=20

Turned out this was Firefox only. Fixed in bed090c. The fix has a side effect that there's now a cursor in the (still uneditable) text area. I think it's an ok compromise. Thanks to Jamie for reporting!


Create interface to select event frames based on attributes for overlay

For example, show me all the fermentations of Brand X between this date range.

Some good DataTables links:
Individual column searching (text inputs)
Search API (regular expressions)
selector-modifier


[TextareaAutosize] Incorrect height calculation when box-sizing: border-box

The component seems to ignore box-sizing: border-box with respect to padding, when calculating the computed height. When I apply vertical padding and a height of 32px, I can’t seem to center the text in the textarea. But I can achieve this with a native textarea using the same styles.
Search keywords:

Auto-sizing can be handled natively these days with field-sizing. So we're going to deprecate this component soon.
Demo


项目启动不起来

1、本仓库工程是否对应这个网站（https://choerodon.com.cn/#/iam/register-organization）的项目
2、使用yarn或者npm都是会报@choerodon/***相关依赖的错误，依赖不是在npm吧？还是说在你们私域源库里，要怎么在本地跑起来你们的工程代码

λ yarn
yarn install v1.22.11
info No lockfile found.
[1/4] Resolving packages...
warning @choerodon/boot > autoprefixer ><EMAIL_ADDRESS>Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools.
warning @choerodon/boot ><EMAIL_ADDRESS>3.x is no longer supported
warning @choerodon/boot > stylelint > autoprefixer ><EMAIL_ADDRESS>Browserslist 2 could fail on reading Browserslist >3.0 config used in other tools.
warning @choerodon/boot > webpack-dev-server ><EMAIL_ADDRESS>Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
warning @choerodon/boot > @pmmmwh/react-refresh-webpack-plugin > native-url ><EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
warning @choerodon/boot > webpack-dev-server > url ><EMAIL_ADDRESS>The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
warning @choerodon/boot > webpack-dev-server > chokidar ><EMAIL_ADDRESS>fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
warning @choerodon/boot > webpack-dev-server > webpack-log ><EMAIL_ADDRESS>Please upgrade
  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details. warning @choerodon/boot > webpack > watchpack > watchpack-chokidar2 ><EMAIL_ADDRESS>Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
warning @choerodon/boot > fork-ts-checker-webpack-plugin > micromatch > snapdragon ><EMAIL_ADDRESS>See https://github.com/lydell/source-map-resolve#deprecated
warning @choerodon/boot > stylelint > file-entry-cache > flat-cache ><EMAIL_ADDRESS>CircularJSON is in maintenance only, flatted is its successor.
warning @choerodon/boot > fork-ts-checker-webpack-plugin > micromatch > snapdragon > source-map-resolve ><EMAIL_ADDRESS>https://github.com/lydell/resolve-url#deprecated warning @choerodon/boot > fork-ts-checker-webpack-plugin > micromatch > snapdragon > source-map-resolve ><EMAIL_ADDRESS>See https://github.com/lydell/source-map-url#deprecated
warning @choerodon/boot > fork-ts-checker-webpack-plugin > micromatch > snapdragon > source-map-resolve ><EMAIL_ADDRESS>Please see https://github.com/lydell/urix#deprecated
Couldn't find any versions for "@choerodon/master" that matches "1.1.0"
? Please choose a version of "@choerodon/master" from this list: 1.0.8
warning @choerodon/master ><EMAIL_ADDRESS>This is a stub types definition. classnames provides its own type definitions, so you do not need this installed.
warning @choerodon/master ><EMAIL_ADDRESS>This is a stub types definition. query-string provides its own type definitions, so you do not need this installed.
warning @choerodon/master ><EMAIL_ADDRESS>Critical security vulnerability fixed in v0.21.1. For more information, see https://github.com/axios/axios/pull/3410
warning @choerodon/master > choerodon-ui ><EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
warning @choerodon/master > @choerodon/components > @ahooksjs/use-url-state ><EMAIL_ADDRESS>This is a stub types definition. query-string provides its own type definitions, so you do not need this installed.
warning @choerodon/master > react-intl ><EMAIL_ADDRESS>the package is rather renamed to @formatjs/ecma-abstract with some changes in functionality (primarily selectUnit is removed and we don't plan to make any further changes to this package
warning @choerodon/master > react-intl ><EMAIL_ADDRESS>We've written a new parser that's 6x faster and is backwards compatible. Please use @formatjs/icu-messageformat-parser ([WARNING] Use 5.4.2 instead of 5.5.1, reason: https://github.com/formatjs/formatjs/issues/2005)
warning @choerodon/master > choerodon-ui > draft-js > fbjs ><EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
warning @choerodon/master > choerodon-ui > jsonlint ><EMAIL_ADDRESS>Package no longer supported. Contact<EMAIL_ADDRESS>for more info.
warning @choerodon/master > choerodon-ui > css-animation > babel-runtime ><EMAIL_ADDRESS><EMAIL_ADDRESS>is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
warning @choerodon/master > choerodon-ui > htmlhint ><EMAIL_ADDRESS>request has been deprecated, see https://github.com/request/request/issues/3142
warning @choerodon/master > choerodon-ui > htmlhint > request ><EMAIL_ADDRESS>Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
error Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
warning @choerodon/master > choerodon-ui > htmlhint > request ><EMAIL_ADDRESS>this library is no longer supported
Error: Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
    at MessageError.ExtendableBuiltin (D:\Program Files\nvm\v14.17.5\node_modules\yarn\lib\cli.js:721:66)
    at new MessageError (D:\Program Files\nvm\v14.17.5\node_modules\yarn\lib\cli.js:750:123)
    at PackageRequest.<anonymous> (D:\Program Files\nvm\v14.17.5\node_modules\yarn\lib\cli.js:36543:17)
    at Generator.throw (<anonymous>)
    at step (D:\Program Files\nvm\v14.17.5\node_modules\yarn\lib\cli.js:310:30)
    at D:\Program Files\nvm\v14.17.5\node_modules\yarn\lib\cli.js:323:13
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
Error: Couldn't find package "<EMAIL_ADDRESS>required by "<EMAIL_ADDRESS>on the "npm" registry.
    at MessageError.ExtendableBuiltin (D:\Program Files\nvm\v14.17.5\node_modules\yarn\lib\cli.js:721:66)
    at new MessageError (D:\Program Files\nvm\v14.17.5\node_modules\yarn\lib\cli.js:750:123)
    at PackageRequest.<anonymous> (D:\Program Files\nvm\v14.17.5\node_modules\yarn\lib\cli.js:36543:17)
    at Generator.throw (<anonymous>)
    at step (D:\Program Files\nvm\v14.17.5\node_modules\yarn\lib\cli.js:310:30)
    at D:\Program Files\nvm\v14.17.5\node_modules\yarn\lib\cli.js:323:13
    at processTicksAndRejections (internal/process/task_queues.js:95:5)

请问你是怎么把依赖装起来的


respect targetPort in gateway.meshExpansionPorts.

Signed-off-by: Masaki Muranaka<EMAIL_ADDRESS>This will fixes warnings reported by Kiali.

[x] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Hi @monaka. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@monaka: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
83479e9ce4ac9f18dbc2a8107dd2db66259fda56
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@monaka: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
83479e9ce4ac9f18dbc2a8107dd2db66259fda56
link
/test gencheck_istio

unit-tests_istio
83479e9ce4ac9f18dbc2a8107dd2db66259fda56
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@monaka: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
83479e9ce4ac9f18dbc2a8107dd2db66259fda56
link
/test gencheck_istio

unit-tests_istio
83479e9ce4ac9f18dbc2a8107dd2db66259fda56
link
/test unit-tests_istio

integ-mixer-k8s-tests_istio
83479e9ce4ac9f18dbc2a8107dd2db66259fda56
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@monaka: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
83479e9ce4ac9f18dbc2a8107dd2db66259fda56
link
/test unit-tests_istio

integ-mixer-k8s-tests_istio
83479e9ce4ac9f18dbc2a8107dd2db66259fda56
link
/test integ-mixer-k8s-tests_istio

gencheck_istio
5848d5a429a0c60f266b3292492e51ba3330b778
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Make SFSymbol struct

Fixes #65

@StevenMagdy Thanks for starting this! If you need any help with the CI, let me know!

@fredpi yeah, it fails but no logs are shown.

@fredpi All tests have passed.

@StevenMagdy Thanks again! Just so that you know: I have quite a busy week ahead and will probably only find time to review this in a week or so :)

As discussed in #65, RawRepresentable and its init(rawValue:) are removed.
Codable methods are added without explicit conformance, Which is the default RawRepresentable behavior.

I’d also like to have SFSymbol: Codable as there seems to be no reason against it.

@StevenMagdy Thanks again for your great work and sorry for my much delayed review!
Except for the 3 comments I left, everything looks very good to me.

I think RawRepresentable carries more significance. As a foundational protocol, RawRepresentable received many special treatments from the compiler (generated Hashable conformance), stdlib (Codable), core libraries (Atomic), system libraries (SwiftUI), and third party libraries (GRDB). And there will be more in the future.
Adding retroactive conformance for a type you don't own to a protocol you don't own is considered bad practice in Swift. So if we don't add SFSymbol: RawRepresentable, nobody else can.

Maybe it doesn't do harm if we explicitly state conformance even if the RawRepresentable behavior is slightly different? This would mean a (rare) breaking change for some users, but it could be fixed quite easily... What do you think? @StevenMagdy @knothed @ddddxxx

I'm indifferent on this, but I like to follow Apple not conforming to Codable for most (all?) RawRepresentable types.

I think RawRepresentable carries more significance. As a foundational protocol, RawRepresentable received many special treatments from the compiler (generated Hashable conformance), stdlib (Codable), core libraries (Atomic), system libraries (SwiftUI), and third party libraries (GRDB). And there will be more in the future.
Adding retroactive conformance for a type you don't own to a protocol you don't own is considered bad practice in Swift. So if we don't add SFSymbol: RawRepresentable, nobody else can.

@ddddxxx The issue I see with RawRepresentable conformance is potential ambiguity. Consider a use case where the app caches SFSymbol.a on iOS 13 using the rawValue property. Now, the app reads the cache on iOS 14.2 and checks whether cachedSymbol == SFSymbol.a. Because SFSymbol.a.rawValue equals character from iOS 14.2 on, the check will fail.
Of course this ambiguity also causes issues with Codable so maybe we should not add init(from decoder: Decoder) and func encode(to encoder: Encoder) at all... Or don't even expose rawValue at all.
Actually I'm quite indifferent on this topic, but just don't want to introduce ambiguous behavior (if that's somehow possible without destroying multiple valid use cases while at it).

@StevenMagdy I've given you write access, so if you want, you may push your branch to the original repo (instead of your fork) and continue work there

The issue I see with RawRepresentable conformance is potential ambiguity.

I think this ambiguity will always be there as long as, we are conforming to Equatable and\or rawValue is exposed. but this ambiguity should be easily clarified in the README.
My issue with RawRepresentable was the initializer. So as discussed in #65, init(customName:) was exposed to support custom symbols. This was under my assumption that UIimage is using the same init for custom symbols (in the assets). it turns out, it uses init(named:). which is not supported in the UIKit extensions.
So in case, we don't want to introduce support for custom symbols, I think we should conform to RawRepresentable again. init(rawValue:) will still be needed when the user want to define system symbols not defined yet in SFSafeSymbols.(eg. iOS 14.5 includes new symbols but SF Symbols.app 2.2 is not out yet.)
@fredpi @ddddxxx @knothed

It seems that you submitted SymbolEnumCreator/.build/manifest.db, ignore it?

Are you sure? I think it was actually tracked and I ignored it in this PR.

RawRepresentable

The issue I see with RawRepresentable conformance is potential ambiguity.

I think this ambiguity will always be there as long as, we are conforming to Equatable and\or rawValue is exposed. but this ambiguity should be easily clarified in the README.

I still don't understand why there is any use case for things like Equatable, Hashable, Codable, RawRepresentable... To my understanding, any user that understands the ambiguity won't ever use those, as they just aren't safe.
@ddddxxx wrote the following:

I think RawRepresentable carries more significance. As a foundational protocol, RawRepresentable received many special treatments from the compiler (generated Hashable conformance), stdlib (Codable), core libraries (Atomic), system libraries (SwiftUI), and third party libraries (GRDB). And there will be more in the future.

But are any of these special treatments something one may want to use if one knows about the ambiguity of the rawValue? I really don't want to limit the user, but if there are no safe use cases it would be best to not allow them at all. Am I missing something here, @ddddxxx @StevenMagdy @knothed?
Custom Symbol Initializer

My issue with RawRepresentable was the initializer. So as discussed in #65, init(customName:) was exposed to support custom symbols. This was under my assumption that UIimage is using the same init for custom symbols (in the assets). it turns out, it uses init(named:). which is not supported in the UIKit extensions.

This is a very important observation, I didn't think about that. So the only use case for a public initializer would be to add symbols that aren't yet available via SFSafeSymbols.

@StevenMagdy i just want to make sure we make a good decision regarding the RawRepresentable conformance because changing it in a later release may be a major hassle for some users; apart from that, everything looks very good to me 👍

I think v3 might have solved this issue for us. @fredpi
This ambiguity was introduced due to rawValue being determined based on the platform version, mostly because of the renamed symbols.

A user might browse the SF Symbols app, see the character symbol and want to use it in their app

This reason was true in SF Symbols.app <3.0 because it didn't expose old names of a symbol. but v3 solved this issue and now it includes a detailed availability section.
The user now will know that character was introduced in 14.2 and it had an old name.
I think conveniences for accessing the most recent version of a symbol (i.e. #if #available) should be placed in the user code or at least in a separate namespace in SFSafeSymbols, e.g. SFSymbol.compat.character.
Why RawRepresentable?
In addition to the special treatments mentioned by @ddddxxx, Explicit RawRepresentable conformance is meant for types that want to behave like an enumeration, which is the goal for this PR.

I'm just gonna throw in my opinion here:
Hashable
It makes much sense for SFSymbol to conform to Hashable and Equatable: There may be use cases where the user would filter an array of SFSymbols by equality or would create a Set<SFSymbol>, which requires Equatable and Hashable, respectively.
Hashable explicitly states that the hashValue is not required to be equal across different executions of the program -- perfect for our use case. So there is nothing against support Hashable.
Codable on the other hand doesn't make sense as the Symbol's rawValue isn't stable across different executions of the program, as we've seen with the character example above.
RawRepresentable
The question remains with RawRepresentable: I don't have any reason against it, but I also don't see any particular reason for supporting RawRepresentable.
Explicitly supporting RawRepresentable but not Codable should be warning enough for the user that they shouldn't store said rawValue across program executions – if they still do, it falls out of our responsibility.
But I would like to see a concrete example of why we should support RawRepresentable. Because I can't imagine any real world use case yet. @StevenMagdy

But I would like to see a concrete example of why we should support RawRepresentable. Because I can't imagine any real world use case yet.

@knothed You are right, There isn't a use case that I can think of. But I think that's also the case with any type conforming to RawRepresentable , including Apple's types.
RawRepresentable in itself doesn't have much significance. it is just used to indicate to the user that it's a type that has enum-like behavior. Even Apple uses it for simple wrapper types like PreviewDevice.

rawValue isn't stable across different executions of the program, as we've seen with the character example above.

I actually agree that we shouldn't conform to RawRepresentable/Codable. My argument is based on us getting rid of the #if #available because SF Symbols.app v3 solved the discoverability problem.

Hey @fredpi, What is the status of this PR? I hope it will be merged before the release of iOS 15 🙏

@StevenMagdy I'm super sorry for the large delay! Life was getting in the way, but that shouldn't count as an excuse for such a long period of inactivity. Looking forward, I'm now committed to merging this and releasing v3 support ASAP, i.e. in the next week.
Looking back at the discussion in this issue, to my understanding it is best to remove RawRepresentableconformance because

rawValue isn't stable across different executions of the program, as we've seen with the character example above.

Or am I missing something again? @knothed @StevenMagdy
If we can't find a quick solution without discussing this for the next three months, I'd suggest we just merge this. But before, let's see if we can make a quick, informed decision.

because

rawValue isn't stable across different executions of the program, as we've seen with the character example above.

Or am I missing something again? @knothed @StevenMagdy

Yes, my argument is that we should not make it unstable across executions of the program and make character only available on iOS >= 14.2 since SFSymbols.app v3.0 solved the discoverability problem for us and now includes the availability in the sidebar, so the user will know that it was called a on earlier iOS versions. Making a convenience function that return character or a based on the iOS version should be decided by the client, not the library.
This will allow us to conform to RawRepresentable, Equatable, and Hashable without worrying about ambiguity, it will also make the new Version 100% source compatible with the older version.
The changes discussed are already implemented in this PR.
@fredpi @knothed I apologize for my poor English, I hope I made my point clear.

@StevenMagdy makes sense, but what if Apple decides to rename some symbols in, say, SFSymbols 4?

@StevenMagdy makes sense, but what if Apple decides to rename some symbols in, say, SFSymbols 4?

We are already supporting that case in the character example, even if apple renames the same symbol again to, say, letter in iOS 16. we would have a symbol in iOS >= 13, character >= 14.2, and letter >= 16, which should be explained in the SFSymbols.app sidebar

Okay so I‘m fine with either way, conforming to RawRepresentable or not.

@fredpi Should we go ahead and merge this? I will follow it with another PR for the v3 symbols.

@StevenMagdy Thanks for your explanation, now I get it! I will now merge this. 😃
Thank you again for your great contribution, I really appreciate it!! If you would also follow up with a v3 symbol PR, that'd be great!
By the way: I don't really understand why you think that your English is poor – it's perfectly understandable and probably better than mine!


Require CMS for tests && run PHP8 tests

@Firesphere not sure this is still needed since we have
https://github.com/lekoala/silverstripe-cms-actions/blob/master/.github/workflows/ci.yml

Part of the failures in Travis were because of missing SiteTree (now missing Page), so I think it did something :laughing:


Discover and load CountryRules via ServiceLoader

Currently the association between Country and CountryRule is hardcoded in the CountryRuleFactory with both available rules carrying a static instance of themselves like e.g
public final static AustriaCountryRule RULE = new AustriaCountryRule();

This is fine for a few countries but gets clunky if we add coverage for more. I'd propose that we switch to using ServiceLoader instead and let the CountryRules tell us which country they are valid for.
public class AustriaCountryRule implements CountryRule {

    @Override
    public Country getCountry() {
        return Country.AUT;
    }

The resulting factory code would be a lot more dynamic:
public class CountryRuleFactory {

    private final Map<Country, CountryRule> rules;

    public CountryRuleFactory() {
        Map<Country, CountryRule> rulesMap = new EnumMap<>(Country.class);
        ServiceLoader<CountryRule> loader = ServiceLoader.load(CountryRule.class);
        for (Iterator<CountryRule> iter = loader.iterator(); iter.hasNext(); ) {
            CountryRule rule = iter.next();
            if (rule.getCountry() == null) {
                throw new IllegalStateException("CountryRule needs to define a countrycode.");
            }
            rulesMap.put(rule.getCountry(), rule);
        }
        this.rules = Collections.unmodifiableMap(rulesMap);
    }

    public CountryRule getCountryRule(Country country) {
        return rules.get(country);
    }
}

This is fine for a few countries but gets clunky if we add coverage for more.

Why? We should not make this more complicated than necessary, especially not if it is no problem at the moment. I see a CountryRule as unique and if someone wants to improve it one can contribute or fork GH.
(I even think at the moment a fork is not necessary as you can create your own country encoded value.)

If we only start with european countries, we'd have maintain a +40 cases switch statement and add the static RULE Boilercode to every implementation. (which is also prone to nasty copy&paste mistakes)

I do not see a big problem in a long switch statement at the moment. And the plain text file approach you proposed is much more prone to copy&paste mistakes whereas the switch statement is compile time checked.

I don't think we even need this switch statement. We could just create a HashMap with all countries and use this instead. Ok, in this case adding a country is a matter of creating the file and adding it to the HashMap, but at least this way we version-control which countries are enabled and this probably doesn't change that often.

Should i craft a PR?

For the HashMap approach? Sure, if you think this helps. Maybe we can even use EnumMap somehow?

.. but is it really more concise than the switch?
        switch (country) {
            case DEU: return GermanyCountryRule.RULE;
            case AUT: return AustriaCountryRule.RULE;
       }

vs.
    map.put(DEU, GermanyCountryRule.RULE);
    map.put(AUT, AustriaCountryRule.RULE);

not sure tbh.

Yes, because we can avoid the nasty RULE :wink:
rules.put(AUT, new AustriaCountryRule());

I would also like to move the country code association into the CountryRule as a rule should know its own countrycode IMHO.
public class AustriaCountryRule implements CountryRule {

    @Override
    public Country getCountry() {
        return Country.AUT;
    }

We'd only have to extend the list and the risk of copy&paste mistakes is near zero :)
public class CountryRuleFactory {

    private final Map<Country, CountryRule> rules = new EnumMap<>(Country.class);

    public CountryRuleFactory() {
        for (CountryRule rule : getAvailableRules()) {
            rules.put(rule.getCountry(), rule);
        }
    }

    public CountryRule getCountryRule(Country country) {
        return rules.get(country);
    }

    private static List<CountryRule> getAvailableRules() {
        return Arrays.asList(
                        new AustriaCountryRule(),
                        new GermanyCountryRule());
    }
}

as a rule should know its own countrycode IMHO

I don't think I agree. Country rules are just country rules. The decision which country rule is applied for which country is something different. For example what if I want to map DEU to some other rule, like:
map.put(DEU, new MyOwnGermanyCountryRule());

Is there any downside to this? I mean, why do you want to move the country code association into the rules?

I have a GraphHopper fork with rules for all european countries. Once you pass the 20+ country mark, copy and paste errors are easily missed:
        switch (country) {
        case AUT:
            return AustriaCountryRule.RULE;
        case BEL:
            return BelgiumCountryRule.RULE;
        case BGR:
            return BulgariaCountryRule.RULE;
        case CHE:
            return SwitzerlandCountryRule.RULE;
        case CZE:
            return CzechiaCountryRule.RULE;
        case DEU:
            return GermanyCountryRule.RULE;
        case DNK:
            return DenmarkCountryRule.RULE;
        case ESP:
            return SpainCountryRule.RULE;
        case FRA:
            return FranceCountryRule.RULE;
        case HRV:
            return CroatiaCountryRule.RULE;
        case HUN:
            return HungaryCountryRule.RULE;
        case ITA:
            return ItalyCountryRule.RULE;
        case LUX:
            return LuxembourgCountryRule.RULE;
        case NLD:
            return NetherlandsCountryRule.RULE;
        case POL:
            return PolandCountryRule.RULE;
        case PRT:
            return PortugalCountryRule.RULE;
        case SRB:
            return SerbiaCountryRule.RULE;
        case SVK:
            return SlovakiaCountryRule.RULE;
        case SVN:
            return SloveniaCountryRule.RULE;
        case SWE:
            return SwedenCountryRule.RULE;
        // ....

map.put(DEU, new MyOwnGermanyCountryRule());

There's nothing wrong with multiple rules sharing the same countrycode in order to override our default rules.
To make things easily pluggable for lib users:
    private final Map<Country, CountryRule> rules = new EnumMap<>(Country.class);

    public CountryRuleFactory() {
        for (CountryRule rule : getDefaultRules()) {
            rules.put(rule.getCountry(), rule);
        }
        for (CountryRule rule : getCustomRules()) {
            rules.put(rule.getCountry(), rule);
        }
    }

    public CountryRule getCountryRule(Country country) {
        return rules.get(country);
    }

    protected List<CountryRule> getCustomRules() {
        return Collections.emptyList();
    }

    private List<CountryRule> getDefaultRules() {
        return Arrays.asList(
                        new AustriaCountryRule(),
                        new GermanyCountryRule());
    }

Hm, how about this: CountryRule manages a Map<Country, CountryRule>. It contains the default/upstream country rules, but can be modified in user code. I don't think it is necessary to differentiate 'default' and 'custom' rules. There is just a map of rules that can be modified.
class CountryRuleFactory {
    private Map<Country, CountryRule> rules;

    CountryRuleFactory default() {
       CountryRuleFactory result = new CountryRuleFactory();
       result.put(Country.AUT, new AustriaCountryRule());
       // ... all the default rules here
    }

    // use this if you want to change the rules. We can also add code so we are able to remove rules, clear the entire map, or set a new map, actually we can just expose the entire map if you will
    public putRule(Country country, CountryRule rule) {
        rules.put(country, rule);
    }

    @Override
    CountryRule getRule(Country country) {
         return rules.get(country);
    }
}

Regarding the Country association I think if this is something you want to do this can be done in user code like, e.g. thi s(?):
interface MyCountryRule extends CountryRule {
    Country getCountry();
}

class MyAustriaCountryRule extends MyCountryRule {
   @Override
   Country getCountry() {
       return AUT;
   }

   /// my country rule implementation
}
CountryRuleFactory factory = new CountryRuleFactory();
replaceCountryRule(factory, new MyAustriaCountryRule());
/// ...

void replaceCountryRule(ConutryRuleFactory factory, MyCountryRule rule) {
    factory.put(rule.getCountry(), rule.getRule());
}

How about this:
public void register(Country country, CountryRule rule)

public void remove(Country country)

I would not mind
Map<Country, CountryRule> getCountryToRuleMap();

Also passing a map via the constructor would be useful. I think there is no reason to hide the map somehow.

Fixed by #2418


update dialog shadow

a little hurt that you didn't tell me you thought we needed a shadow. anyway, i tweaked it to make it a little more subtle w/ a more realistic light source.
also, using a nearly-transparent black will be more versatile for custom themes.
before and after:

looks good. i think all popovers need some kind of shadow, but some of ours had them and some didn't. dialog consolidated them


Nima WebClient Redirects support

This issue needs more work, but for the most cases it will work just fine now. It should unblock others who were blocked by it. PR https://github.com/helidon-io/helidon/pull/6929 added this functionality.

Closing. Tracking further work with #6992


[bug] GET return 404 from https://rpc.walletconnect.com/v1/profile/reverse/xxx

Link to minimal reproducible example
https://web3modal-mre.vercel.app/
Summary
Create new react ts with web3modal ethers.
Connect to smartwallet base testnet:
chainId: 84532,
name: "Base Sepolia",
currency: "ETH",
explorerUrl: "https://sepolia-explorer.base.org",
rpcUrl: "https://sepolia.base.org",
After login got error 404:
GET https://rpc.walletconnect.com/v1/profile/reverse/0x14338152970B7B9A24092382e4B2e9B78Ba13D65?projectId=28e14a91201028f94cee88eb9da0a227 404 (Not Found)
Potential problem: Smartwallet create smart contract address instead of normal wallet address.
smartwallet address on Base testnet: 0x14338152970B7B9A24092382e4B2e9B78Ba13D65
code: https://github.com/tuannx/web3modal-mre
List of related npm package versions
"@testing-library/jest-dom": "^5.17.0",
"@testing-library/react": "^13.4.0",
"@testing-library/user-event": "^13.5.0",
"@types/jest": "^27.5.2",
"@types/node": "^16.18.97",
"@types/react": "^18.3.3",
"@types/react-dom": "^18.3.0",
"@web3modal/ethers": "^4.2.3",
"ethers": "^6.12.1",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-scripts": "5.0.1",
"typescript": "^4.9.5",
"web-vitals": "^2.1.4"

Same here

same issue here

also, on mainnet!

Is something not functioning properly or are you guys just seeing this error in the console?

it happens on https://lab.web3modal.com/ with rabby wallet on chrome

So, as of now, it's been 5 weeks with seemingly no activity or assigned user, I messaged about it in Discord and was ignored, is it super borked, not a priority, gonna take another week, can we get some communication here?

@ZachHandley I replied to the thread above
Is something broken or not-functional with the UI or SDK?
Or is the concern only that there are errors in the console? Our API returns 404s when things don't exist, but this is expected/normal behavior.

Yeah my balances don't show, which isn't a gigantic deal, though it definitely should be fixed cause it's not very clear, but I'm also curious what the profile is and how to reduce the 2-4 errors in the console

I loaded the example from the issue description and my balance displays fine:

/profile is for loading information about ENS name registrations, it is unrelated to the balance request.
@ZachHandley can you please open up a new issue/discussion for your balance not showing issue and include a MRE?

We are planning a new API revision that will remove the use of 4xx's across our APIs for normal conditions, which will avoid the console errors seen here. Tracking issue here.
Closing this issue as it seems like the problem is exclusively the console errors and no functionality is broken.

Closing this issue as it seems like the problem is exclusively the console errors and no functionality is broken.

AppKit is still sending an invalid request so I think still needs fixing if I'm not mistaken.

AppKit is still sending an invalid request so I think still needs fixing if I'm not mistaken.

@glitch-txs please elaborate on what is broken

@chris13524 @glitch-txs I'm following up with the current issue.
It's actually related to the issue https://github.com/WalletConnect/web3modal/issues/1888 I'm expecting a response for, if possible. Thanks a lot for your help in advance.
I'm happy to highlight or elaborate on the issue if needed.
Thanks!

i'm having the same issue. Any update or solution?

This is not longer an issue.  Please update to latest.


tls.Config warning.

I got the warning:
call of xmpp.NewClient copies lock value: gosrc.io/xmpp.Config contains crypto/tls.Config contains sync.Once contains sync.Mutexcopylocks
I think that TLSConfig option in Config should be pointer.

Yes, true, let me check this.


https://github.com/flanksource/karina/issues/449

https://github.com/flanksource/karina/issues/449

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Rodger Francis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Wrong command for local init

NPM version: 3.10.3
Node: 6.3.0
Release: 1.0.3
Documentation (https://holidaypirates.github.io/nucleus/installation.html) states that per-project installation initialization can be run using command node ./node_modules/bin/nucleus.
Very same command throws an error, this seems to be due to the fact that the module is installed as nucleus-styleguide, and that the module is added to node_modules and not node_modules/bin.
Please see error below:
module.js:442
    throw err;
    ^

Error: Cannot find module '/Users/username/Sites/website/node_modules/bin/nucleus'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.runMain (module.js:575:10)
    at run (bootstrap_node.js:352:7)
    at startup (bootstrap_node.js:144:9)
    at bootstrap_node.js:467:3

The command that worked for me was therefore: node ./node_modules/nucleus-styleguide.

Hi and thanks for pointing this out. I will verify and fix this as soon as possible.

Updated w. error message, if that is of any help.
Good job on the project btw - looks very promising.

Thanks a lot. Init script is fixed in 1.0.4 and working as expected when calling nucleus init.


Incluude out of box IArrayPool implementation with JsonSerializerSettings flag to enable it.

It would be also nice if out of box implementation support older  (4.5.2+) .net versions. This could be implemented as a fall back implementation if there is no .net core ArrayPool.Shared available.

I don't want to do this because I don't think I have the necessary skills to create something that is high perf and thread safe. I recommend wrapping the .NET array pooling implementation.


⚠ Turnos 24x7 has degraded performance

In b9c9052, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 898 ms

Resolved: Turnos 24x7 performance has improved in 8ec1554.


Add option to not use Album when Searching

Most of the times removing album from search works specially for musixmatch

I've not experienced this very much (once or twice when my album tags include "[Special Edition]" or something). Also the lack of others reporting the same issue suggests its not "most of the time".
Also there's always manual search so I'm reluctant to do this.

Also the lack of others reporting the same issue suggests its not "most of the time".

It can be discussed.
https://www.reddit.com/r/foobar2000/comments/wy3q61/foo_openlyrics_if_you_find_searching_without/


WebRTC doesn't work on firefox through NAT when webrtcAdditionalHosts contains DNS name

Which version are you using?
1.10
Which operating system are you using?
Linux amd64 Docker
Describe how to replicate the issue
I have the webrtcAdditionalHosts set with the local IP of my server and its DNS name like so :
webrtcAdditionalHosts: [xxx.xxx.xxx.xxx, dns.name]

Everything is working on the LAN.
It also works from the internet when NAT comes into play, but not in Firefox. I tried with Chrome and Edge and it works so it's not an issue with udp, port forwarding or something else.
After a few seconds, the following error shows up in the console in Firefox :
WebRTC: ICE failed, add a STUN server and see about:webrtc for more details

EDIT : when trying in Firefox with webrtcAdditionalHosts containing the public IP instead of the DNS name, it's working.
Server logs
Logs when trying to stream from Edge (ip addresses obfuscated) :
mediamtx  | 2024/12/04 21:34:46 INF MediaMTX v1.10.0
mediamtx  | 2024/12/04 21:34:46 INF configuration loaded from /mediamtx.yml
mediamtx  | 2024/12/04 21:34:46 INF [playback] listener opened on :9996
mediamtx  | 2024/12/04 21:34:46 INF [RTSP] listener opened on :8554 (TCP), :8000 (UDP/RTP), :8001 (UDP/RTCP)
mediamtx  | 2024/12/04 21:34:46 INF [WebRTC] listener opened on :8889 (HTTP), :8189 (ICE/UDP)
mediamtx  | 2024/12/04 21:34:56 INF [WebRTC] [session b6c13f34] created by <IP_ADDRESS>:52170
mediamtx  | 2024/12/04 21:34:56 INF [path camera1] runOnDemand command started
mediamtx  | 2024/12/04 21:34:57 INF [RTSP] [conn <IP_ADDRESS>:41490] opened
mediamtx  | 2024/12/04 21:34:57 INF [RTSP] [session 0429162c] created by <IP_ADDRESS>:41490
mediamtx  | 2024/12/04 21:34:57 INF [path camera1] [recorder] recording 2 tracks (H264, Opus)
mediamtx  | 2024/12/04 21:34:57 INF [RTSP] [session 0429162c] is publishing to path 'camera1', 2 tracks (H264, Opus)
mediamtx  | 2024/12/04 21:34:58 INF [WebRTC] [session b6c13f34] peer connection established, local candidate: host/udp/dns.name/8189, remote candidate: prflx/udp/clientip/31167
mediamtx  | 2024/12/04 21:34:58 INF [WebRTC] [session b6c13f34] is reading from path 'camera1', 2 tracks (H264, Opus)

Logs when trying from Firefox :
mediamtx  | 2024/12/04 21:37:41 INF MediaMTX v1.10.0
mediamtx  | 2024/12/04 21:37:41 INF configuration loaded from /mediamtx.yml
mediamtx  | 2024/12/04 21:37:41 INF [playback] listener opened on :9996
mediamtx  | 2024/12/04 21:37:41 INF [RTSP] listener opened on :8554 (TCP), :8000 (UDP/RTP), :8001 (UDP/RTCP)
mediamtx  | 2024/12/04 21:37:41 INF [WebRTC] listener opened on :8889 (HTTP), :8189 (ICE/UDP)
mediamtx  | 2024/12/04 21:37:45 INF [WebRTC] [session b39b258b] created by <IP_ADDRESS>:35866
mediamtx  | 2024/12/04 21:37:45 INF [path camera1] runOnDemand command started
mediamtx  | 2024/12/04 21:37:46 INF [RTSP] [conn <IP_ADDRESS>:57804] opened
mediamtx  | 2024/12/04 21:37:46 INF [RTSP] [session e94c170d] created by <IP_ADDRESS>:57804
mediamtx  | 2024/12/04 21:37:46 INF [path camera1] [recorder] recording 2 tracks (H264, Opus)
mediamtx  | 2024/12/04 21:37:46 INF [RTSP] [session e94c170d] is publishing to path 'camera1', 2 tracks (H264, Opus)
mediamtx  | 2024/12/04 21:37:56 INF [WebRTC] [session b39b258b] closed: deadline exceeded while waiting connection

Network dump
No response

Same issue...
Any updates on this?


Fhart/tiff convert support

This is the first of a few PR's for Tiff conversion, task AB#2334
Supports converting image tiff as flat images. Have yet to optimise for tile/strip/scanline tiffs, compressed (haven't tested), geotiff, 3d images and image data broken up on multiple planes.

As mentioned in DM's; I have reservations about using virtual functions in the convert pipe (particularly per point). Will merge as this is only partial support anyway and it can continue to evolve.


Automated cherry pick of #11397

Cherrypicking fix for: https://github.com/GoogleCloudPlatform/kubernetes/issues/11377
Original PR:
"Updating kubectl expose to leave service port unnamed"

cc @bgrant0607 @zmerlynn

Cross-link #11397

LGTM

LGTM


Command not found error

Using Kubuntu 16.10, VSCode 1.21.1 (20180314,Shell 1.7.9, Node 7.9.0, x64)
command 'remote.editor.connectRemote' not found

Hi @revren
Was this on the first install? Did you try reloading vscode after install?

Hi @fijiwebdesign yes I reloaded immediately after installing, I still have the issue after numerous retries

@revren I've managed to reproduce this after reinstalling the extension a few times.
Did you happen to have: https://marketplace.visualstudio.com/items?itemName=carlevans.remote-editor installed at some point? I've seen odd behaviour with the extension using the old code from that one.
I'll send you an update when I've managed a fix for this.

@revren The most likely cause of the error is that your .remote file is not valid JSON. I will add a fix to show an error message when the .remote file cannot be read as JSON in the next release.
Here is an example .remote file:
Note: JSON cannot have trailing ",". Last key/prop must not have ",".
{
  "autoConnect": true,
  "connection": {
    "host": "seedess.com",
    "username": "root",
    "privateKey": "/Users/chandra/.ssh/keys/id_rsa",
    "passphrase": "***",
    "port": "2222"
  },
  "basePath": "/var/www/seedess.com/",
  "ignore": [".git", "src/node_modules"],
  "debug": "*"
}

@fijiwebdesign I didnt have https://marketplace.visualstudio.com/items?itemName=carlevans.remote-editor installed at any point.
Correct my JSON was not valid. Sorry about that, my last key /prop did have a ,", and I failed to close the "" in one of the values.
Having fixed that though I still get eh same error? (I have double checked that I have valid JSON now)

Actually scrap that! After a restart of VSCode I now get 'syncing..' in the status bar, then all the files are copied!
Thanks so much for your help and sorry that I caused the error in the first place!

{
"autoConnect": true,
"connection": {
"host": "<IP_ADDRESS>",
"username": "user",
"privateKey": "C:\Users\user\.ssh\key.ppk",
"port": "22"
},
"basePath": "./base/",
"ignore": [".git", "src/node_modules"]
}
This is my .remote file, do take note of the double slash required if you are on Windows

@derence2002 I would suggest using https://github.com/liximomo/vscode-sftp as it's more mature and achieves the same as this package.  I don't have the time to support this package anymore.


Lambda operator is absent in the precedence table

It will be helpful to add the lambda operator in the operator precedence table.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ddc4f59b-159f-5038-fc24-4e78c7dff783
Version Independent ID: f0015080-14af-58f1-15bb-c2691ea4186f
Content: Precedence and order of evaluation
Content Source: docs/c-language/precedence-and-order-of-evaluation.md
Product: visual-cpp
Technology: cpp-c-language
GitHub Login: @corob-msft
Microsoft Alias: corob

@Vaskaran
I'm not sure I understand what you're asking for. I'm not aware of a "lambda operator". There are lambda expressions, which act like any other expression in terms of precedence. Lambda expressions represent a class type called a closure type. They have a public inline function call operator, which is a long-winded way of saying that you can call a lambda immediately by appending () to it (with arguments, if needed). Can you clarify what you mean in your question? What problem are you trying to solve?

@Vaskaran I'm not sure I understand what you're asking for. I'm not aware of a "lambda operator". There are lambda expressions, which act like any other expression in terms of precedence. Lambda expressions represent a class type called a closure type. They have a public inline function call operator, which is a long-winded way of saying that you can call a lambda immediately by appending () to it (with arguments, if needed). Can you clarify what you mean in your question? What problem are you trying to solve?

[Vaskaran] Please refer this link: https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/lambda-expressions where the doc says "Use the lambda declaration operator( =>)  to separate the lambda's parameter list from its body."
The online link https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/operators/lambda-operator also says about the lambda operator.

@Vaskaran
If you want information about the C# lambda operator, you're looking at the wrong documentation. This article is about the C language, which doesn't have lambda constructs. (I was confused by the question and thought it was about C++, which does have lambda expressions.) You want the Operator precedence table for C#, instead. I'm closing this issue as unrelated to the article. Best of luck with your coding.

Purely my mistake.Thanks for the help. My apologies.


Kube

Codecov Report

Merging #861 into master will decrease coverage by 0.1%.
The diff coverage is 47.22%.

@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
- Coverage   45.93%   45.83%   -0.11%
==========================================
  Files          34       34
  Lines        2869     2882      +13
==========================================
+ Hits         1318     1321       +3
- Misses       1357     1367      +10
  Partials      194      194

Impacted Files
Coverage Δ

impl/sql/adminstorage/admin_storage.go
63.79% <ø> (ø)
:arrow_up:

core/keyserver/keyserver.go
0% <0%> (ø)
:arrow_up:

core/sequencer/sequencer.go
8.11% <0%> (-0.22%)
:arrow_down:

core/adminserver/admin_server.go
45.21% <100%> (+1.46%)
:arrow_up:

integration/testutil.go
65.48% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0025f9a...665af4b. Read the comment docs.

Updated. PTAL.


Make bytesToUint internal or public

Currently unavailable for json parsing as it's marked private: https://github.com/foundry-rs/forge-std/blob/f50a63aa9ed5e1aed19df1a39a81e005b8ed119d/src/StdCheats.sol#L469

if no objections, I can add a tiny PR

If this is a desirable feature, you can add in StdUtils.

@ZeroEkkusu I put it in a tiny library and access it from StdUtils and StdCheatsSafe to not run into inheritance conflicts. Open to suggestion if another strategy preferred:
https://github.com/foundry-rs/forge-std/pull/222


Permissions or role-based access

[Enter feedback here]
The diagram that shows Permissions or role-based access needs to be updated and grammar/punctuation corrected.  That diagram is a pretty clunky way to show the access levels and the wording is a bit confusing at times.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8935e913-806f-a92c-d09e-e67df4ffd1b4
Version Independent ID: c7a41cde-66dd-d7cd-1316-42d20ed4841a
Content: Use OneDrive for Business and SharePoint for meeting recordings - Microsoft Teams
Content Source: Teams/tmr-meeting-recording-change.md
Service: msteams
GitHub Login: @cichur
Microsoft Alias: v-cichur

Hello @jrummer, Thank you for your comments. I've made some changes and will publish it this afternoon.

That’s awesome.  Wasn’t sure anyone would actually see this.  Can it be something downloadable?

You can download a PDF of the admin guide. Go to this page. The PDF link is at the bottom left of the page. https://docs.microsoft.com/en-us/MicrosoftTeams/how-to-roll-out-teams


Can't get folder query to work

I have this very basic query for tasks in a folder named "Airtable", where I'm sure there are tasks, but it returns no results:
TASK from "Airtable"

I've confirmed and reconfirmed that the folder name is exactly the same. If I query from the root, it does return the tasks:
TASK from "/"

But I don't want all my tasks in this view. Is the full path required? I've tried that too, but to no avail. Seems like I must be doing something really dumb.

Hmm, I was able to reproduce this for a little while, then it went away when I changed some unrelated things 🤔 . It may be fixed for next release 0.3.10. If not, will have to investigate more.

Ok. Thanks for looking into it!

Do you see the same issues on latest (0.3.12)?

Yep. Just updated. Same result.

Sorry, I just figured it out. It works when I use the full path. I had tried that, but I guess maybe I had a character wrong somewhere because it's a deeply nested path and I mistyped something. I kinda thought that since the query is right above the folder that it applies to that that a relative path would work, but I guess not? But that's why I asked if the full path was necessary. I think the examples in the docs are a little unclear on that. In any case, sorry for the noise!

Thanks! That would be great. Really loving the plugin, by the way.
On Fri, Jun 4, 2021 at 3:26 PM blacksmithgu @.***>
wrote:

Ah, I see, I wasn't considering relative versus full paths. I will add
relative path support for an upcoming release.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/blacksmithgu/obsidian-dataview/issues/242#issuecomment-855049263,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA7YYTXZEBDNLKSW2F6KETTRFHLBANCNFSM45KC66QA
.

I'm having a similar issue (latest version of the plugin and of Obsidian), I can't seem to get folders to work at all, see below screenshot. I tried putting the note with the dataview into the folder I'm trying to use as source but to no avail either.
Not a big deal as I'll just use tags for now as they work. Love the plugin!

Have you tried FROM "15 Skills/Gardening/plants"? (I.e., no leading /). Looks like I need to improve this behavior in multiple ways.

That works! Thank you sir.
 (I.e., no leading /).
Looks like I need to improve this behavior in multiple ways.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/blacksmithgu/obsidian-dataview/issues/242#issuecomment-860106227,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFUPFXY3DCVTKLKUND3OV4DTSPBEBANCNFSM45KC66QA
.


Spelling mistake

For more information about package manifests, see How to: Create a product manifest.
should read
For more information about product manifests, see How to: Create a product manifest.

@danielricci Thanks for your feedback; please if you would, include the name of the page or its URL where you've noticed the text that must be changed?

https://docs.microsoft.com/en-us/visualstudio/deployment/how-to-create-a-product-manifest?view=vs-2017

There are actually two related typos in both https://docs.microsoft.com/en-us/visualstudio/deployment/how-to-create-a-package-manifest?view=vs-2017 and https://docs.microsoft.com/en-us/visualstudio/deployment/how-to-create-a-product-manifest?view=vs-2017, both in the same place. @Mikejo5000 fyi.

Fixing...

Looks good, closing the issue


Update osx workflow

Update osx workflow to make sure that the brew installed version of libxml2 is in the path when compiling xmlsec, rather then the osx system supplied one, to avoid the issue noted in https://github.com/xmlsec/python-xmlsec/issues/283 where the tests segfault. This is done by setting PKG_CONFIG_PATH.
This gets the workflow for osx in a mostly passing state. Tests pass for Python 3.6 - 3.11. Tests for Python 3.5 are still failing because the type annotations added in https://github.com/xmlsec/python-xmlsec/pull/253 are not valid for Python 3.5. So that either needs to be fixed, or Python 3.5 support needs to get dropped for this to be fully passing.

out of curiosity: why not use pkg-config for flags?

@deronnax it seemed like pkg-config wasn't working for me, I kept getting the osx system libxml2 instead of the one from brew. Happy to try again though, pkg-config seems like a better solution here. Any suggestions of things to try?

@deronnax hmm so this seems to be working for me now, just setting PKG_CONFIG_PATH. Not sure what was going on before. Thanks for the suggestion, I pushed a commit to drop the CFLAGS and LDFLAGS.

@deronnax a small follow up to this. For me locally on my mac, its not enough to just setting PKG_CONFIG_PATH, I still end up with segfaults because of mismatching libxml2 versions. I actually have to set CFLAGS and LDFLAGS. Thats why I initially had them set in this PR.
This must be something about my local setup though, since it seems in CI its enough to set PKG_CONFIG_PATH.

@nosnilmot thank you for the great suggestions. I have accepted them into the PR.
I had to make a slight change to https://github.com/xmlsec/python-xmlsec/pull/296#discussion_r1536869063 as it resulted in the build failing because GH actions does not do shell expansion on the env vars defined in the env key. So I moved your suggested change to the PKG_CONFIG_PATH into the run block, so it gets properly expanded.

@jonathangreen thank you for this precious insights. You made me discover that on my mac, I am probably actually linking against the system libxml2 and not homebrew's one, which I thought I did. Do you have tips to check that?
Btw, I see you are not using --no-binary lxml with pip, so you must be getting the lxml wheel and using the libxml2 provided by lxml, no?

Btw, I see you are not using --no-binary lxml with pip, so you must be getting the lxml wheel and using the libxml2 provided by lxml, no?

Yes. In this PR I'm using the lxml wheel, and relying on the fact that the version of libxml2 being installed by brew is the same as the version being used in the most recent lxml builds. So as long as the xmlsec build uses the libxml2 from brew instead of the old version provided by osx everything works as intended.

You made me discover that on my mac, I am probably actually linking against the system libxml2 and not homebrew's one, which I thought I did. Do you have tips to check that?

Now that https://github.com/xmlsec/python-xmlsec/pull/299 is merged in, if you build the latest it should give you a useful exception if that is the case. A couple things to try if you are having issues getting this module to build and link against the correct version of libxml2:

Make sure pip isn't installing a cached previously built wheel
If just setting PKG_CONFIG_PATH isn't working, try also setting CFLAGS and LDFLAGS. For some reason this was necessary for me when building locally on my M1 mac.

@jonathangreen The reason cp35 is failing is because of type hints. Type hints like Dict and List are supported from >=3.6. I removed them in a separate PR (https://github.com/xmlsec/python-xmlsec/pull/303) so yours should pass too after the merge.


[krb5] Update portfile

[x] Changes comply with the maintainer guide.
[x] SHA512s are updated for each updated download.
[x] The "supports" clause reflects platforms that may be fixed by this new version.
[x] Any fixed CI baseline entries are removed from that file.
[x] Any patches that are no longer applied are deleted from the port's directory.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is added to each modified port's versions file.

@microsoft-github-policy-service agree

Thanks everyone for the reviews so far.
It'd be great if this could be tested with any existing ports and non-vcpkg software. I notice curl has a [gssapi] feature; could CI test that it works with these changes?
Additionally, I've been trying to build Samba with this port on macOS, but it hasn't worked and Samba's Waf configure errors out here. It works when using Homebrew krb5, and I'm positive it's a build/install configuration difference that causes the configure to fail.

I notice curl has a [gssapi] feature; could CI test that it works with these changes?

Somebody needs to add corresponding dep to the vcpkg-ci-curl test port.

@sharadhr My PR merge to the master.
you can merge the changes back and revive your PR.


Update contents to match image var name

Looked like a typo. Apologies if it wasn't.

@googlebot I signed it!

Fixed as per: https://github.com/GoogleCloudPlatform/php-docker/pull/533

Fixed as per: https://github.com/GoogleCloudPlatform/php-docker/pull/533


Signature verification failed

I'm getting this error when I try to create Account with System Program.
Error:
WalletSendTransactionError: Signature verification failed
Code:
const newAccount = new Keypair()
const createAccIx = SystemProgram.createAccount({
          fromPubkey: publicKey,
          lamports: await Token.getMinBalanceRentForExemptAccount(connection),
          newAccountPubkey: newAccount.publicKey,
          programId: TOKEN_PROGRAM_ID,
          space: AccountLayout.span,
})
 const createTokenAccountIx = Token.createInitAccountInstruction(
          TOKEN_PROGRAM_ID,
          PRESALE_TOKEN_PROGRAM,
          newAccount.publicKey,
          publicKey
)
const signature = await sendTransaction(
          new Transaction().add(createAccIx, createTokenAccountIx),
          connection
 )
const result = await connection.confirmTransaction(
          signature,
          'processed'
)

That error indicates an issue with the transaction validation, but isn't a bug in wallet-adapter.
I think the issue is that when you're creating a new system account, the new account keypair needs to sign the transaction. You're missing newAccount as a signer.
Try to pass it as a signer with the options here: https://github.com/solana-labs/wallet-adapter/blob/a883ebc5706f38235ee4d5838c2ddb458accdebf/packages/core/base/src/adapter.ts#L14-L16
These options are passed to sendTransaction:
await sendTransaction(transaction, connection, { signers: [newAccount] })

This will set the transaction fee payer to the wallet account, and then add the extra signer(s) your transaction expects.

Thanks


Feature request : Add reencode executable

It would be nice if you could add cmd/jpegli to this module : an executable that can re-encode jpeg files using jpegli.

There is already a cjpegli tool (similar to cjpeg from turbo, or cjxl from libjx, or cwebp, etc. l) in libjxl repo, that will work faster.

That makes sense!
For those looking for the cjpegli binary, it can be found in the libjxl releases.
(For Windows you should look for the static version).


[UI] Settings: Server invocation not made upon delete of Cluster

Current Behavior

Desired Behavior

Screenshots/Logs

Environment

Browser: Chrome Safari Firefox
Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Handbook

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Related to https://github.com/meshery/meshery/issues/8200


Fix broken link in handling errors sections

Fixes #574
Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation about the functionality in the appropriate .md file
[x] I have added in line documentation to the code I modified

Short description of what this PR does:

Fix the broken link to the example

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hello @shubham-padia,Thanks again for the PR! We want to show our appreciation by sending                                              you some swag. Could you please fill out                                              this form so we can send it to you? Thanks!                                             Team SendGrid DX

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.
Our agenda would be: Explore what you liked and is there anything we can do to improve?
You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.
Thank you so much,
Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@SendGrid


Enterprise User Management API v3 (EUMAPIv3)

Motivation:
This is a feature that gets more attention that we give it. The main flaw in v2 is that it's not synchronous. I think it's faster to make a v3 that also improves on RESTness than fixing v2 and breaking existing scripts. I'll leapfrog this if there's no roadmap space for it.
Goals:

[ ] Full REST
[ ] Batch API (for asynchronous creation/deletion) (https://github.com/CartoDB/cartodb/issues/9791)
[ ] Groups support (https://github.com/CartoDB/solutions/issues/650)
[ ] v2 will still work

cc/ @CartoDB/builder-backend @xavijam

Closing automatically because of inactivity. If anybody considers that this still important, please reopen and it'll be prioritized.