VelloScene doesn't respect Bevy RenderLayers

I'm experimenting with Vello in a Bevy 3D project, where I have my cameras set up like this:
fn spawn_cameras(mut cmd: Commands) {
    cmd.spawn((
        Name::new("Main Camera"),
        MainCamera,
        Camera3dBundle::default(),
    ));
    cmd.spawn((
        Name::new("UI Camera"),
        UiCamera,
        Camera2dBundle {
            camera: Camera {
                clear_color: ClearColorConfig::None,
                order: 1,
                ..default()
            },
            ..default()
        },
        RenderLayers::layer(1),
    ));
}

With the intention being that anything that needs to be rendered in 2D-world-space as an overlay on top of the 3D scene should get RenderLayers::layer(1), so that it only gets rendered by the 2D camera.
However, when I tried to spawn a VelloSceneBundle with a RenderLayers::layer(1) component, it didn't render at all. After some debugging, I discovered that after changing the camera's render layers to RenderLayers::layer(0).with(1), the VelloScene started rendering as expected, indicating that bevy_vello's rendering systems are ignoring the RenderLayers component.
This is problematic for me, because allowing my 2D camera to render layer 0 causes it to render some other things that it shouldn't (e.g., 3D-world-space Gizmos with an always-in-front depth bias).
Edit: I just read over the discussion in #49, so it looks like you're already aware of the issue. 🙂 Let me know if there's anything I can do to help!

So it looks like Bevy UI also ignores RenderLayers. 😂 Upon further inspection, there's actually a TargetCamera component in Bevy UI that serves this purpose. That doesn't fix my issue with non-UI stuff rendering to the UI camera, but I guess I'll have to come up with another solution for that. Closing this since it matches Bevy's behavior.

This is definitely something I'd love to accept in a PR, or get to as time permits.

Up to this point, RenderLayer was something I've never worked with. Currently bevy_vello ignores RenderLayers entirely, so at first it was unclear why adding a RenderLayer::layer(1) component to a VelloSceneBundle would make it not render.
I understand this a little better now and I'm committed to pushing this across the finish line.
Here's what I understand, for others:

Changing the camera order will change the ordering of rendering cameras. This is a possible way to make bevy_vello render on top or on bottom of your 3d space. (camera order 1 or -1 respectively should do the trick).

Camera ordering isn't enough because UI, gizmos, bevy_vello, etc. can and will use the same 2d camera. It's also sometimes desirable to say, for example, "I want everything to render above terrain." Hence, RenderLayers is also a way to sort by depth. See https://github.com/bevyengine/bevy/issues/1275 for more conversation.

So there's two considerations that I believe are needing implementation:

The situation where a camera has a RenderLayer. This would be useful to solve this issue with Gizmos. However I believe having camera with a different RenderLayer would mean internally we would need a new framebuffer for every RenderLayer the user wants. Vello is a one-pass renderer, which means it efficiently encodes all applicable scenes at once to create the final image. We do z-ordering via the transform's Z-component, but all of that is within vello. There's no way to render a vello background, 3d sphere, and a vello foreground. That would require 2 texture for Vello to render to, which isn't possible currently with bevy_vello. This situation would require more thought, as it would mean we'd need to adjust the pipeline to synchronize more than 1 vello render pass every frame.
The other situation to account for is if you can have an entity, e.g. VelloSceneBundle on a RenderLayer, as an alternative means of Z-sorting within bevy_vello. This would be that "I want everything above the terrain" example. This is useful, but it doesn't seem like the reason this issue was made. bevy_vello already z-sorts by the transform z-component. Hence, you could set the terrain's VelloScene transform z to f32::MIN. However, I do like the idea, and I would see the value in wanting to render in layers, e.g. Terrain -> Unit layer -> Sky layer.

@dannymcgee Let me know if I'm offbase in my understanding here

I'll add the reason I was looking into this as well:
I have a Camera2d where I want to render all ui from a bevy_vello powered ui crate, and a Camera3d where I want to render "everything else" (gltf scenes, gizmos, effects, etc. game stuff).
If the Camera2d doesn't have a RenderLayers specified, then it will render a bunch of "extra" stuff, such as gizmos I'm using in the 3d camera. So ideally I would be able to order +1 on Camera2d, which places it over the 3d camera, and use RenderLayers to target all vello content to the Camera2d. I believe this still fits the "one pass" model of vello as it is only one layer.

Fixed via #68  - Please re-open a new issue if there are further render layer issues.
There is also a new example for render layers.


nexd: fixes #1426 If your machine's time is set to 15 mins into the future, nexd will fail to login

We now compare the local time with server time to compute if the client needs to adjust for client time skew.

Is there a way to simulate time skew with containers so we can create a tests case?

i think we can set time in the container? I assume that requires SYS_TIME cap and probably need to disable NTP on host.

Is there a way to simulate time skew with containers so we can create a tests case?

i think we can set time in the container? I assume that requires SYS_TIME cap and probably need to disable NTP on host.

Does that change the time in all containers or just one container? Because for e2e tests I want my sever's container time to be different than my nexd container's time.  But they are both on the same host.

I can't remember what the original symptom was. What did the failure look like before this change?

nexd would fail to log into the API as it would verify the OAuth jwt and see that it had expired (due to the clock skew).

Is there a way to simulate time skew with containers so we can create a tests case?

you could wrap the time methods in question and have them adjust behavior based on an env var being set, like NEXD_SIMULATE_CLOCK_SKEW=true or something.

@russellb wrapping like that would complicate the code more than just manually testing on a machine with clock skew.  Maybe we can force the clock skew on one of the qa-dev job machines.


When generating a static site: I hope to support real-time editing while passing the current page data through Astro.props

Description
---
import BaseLayout from 'layouts/BaseLayout.astro';
import StoryblokComponent from<EMAIL_ADDRESS>import { getStories } from 'utils/storyblok';
import { toMeta } from 'utils/meta';

export async function getStaticPaths() {
    const { data } = await getStories({
        language: 'en',
        content_type: 'Page',
        resolve_relations: 'ProgressCarousel.slide',
    });

    return data.stories.map((story) => {
        return {
            params: { page: story.slug === 'home' ? undefined : story.slug },
            props: { data: story },
        };
    });
}

const { data } = Astro.props;
---

<BaseLayout {...toMeta(data)} {...data.content}>
    <StoryblokComponent blok={data.content} />
</BaseLayout>

为了进一步简化代码，让其看起来更酷炫一些，希望能通过 Astro.props 传递当前页面数据时，也能实现可视化编辑与实时预览。
In order to further simplify the code and make it look cooler, we hope to be able to achieve visual editing and real-time preview when passing the current page data through Astro.props.
Suggested solution or improvement
刚接触代码、Astro，Storyblok 不久，之前发现上述代码是没有实时预览（以为还以为是 bug，现在实验性项目中回头过来想，应该是没有重新去抓取数据而引起的（只能通过当前 slug 去抓取当前页面数据），不知道这样理解是否正确）
I am new to code, Astro, and Storyblok. Not long ago, I found that the above code did not have real-time preview (I thought it was a bug. Now I look back at the experimental project and think that it should be caused by not re-grabbing the data (it can only be caused by the current slug). To grab the current page data), I don’t know if this understanding is correct)
Additional context
再次感谢 storyblok 技术团队的付出、sotryblok 的UI实在是是太迷人了，希望其越来越好。对于我这么一个没什么技术的小白来说已经很容易上手了～
Thanks again to the storyblok technical team for their efforts. The UI of sotryblok is really charming. I hope it will get better and better. It’s very easy for a novice like me to get started~
Validations

[X] Follow our Code of Conduct

Hello @JakiChen, thank you for opening this discussion. In order to support real-time editing, you will need to install the latest alpha version of @storyblok/astro: https://www.npmjs.com/package/@storyblok/astro?activeTab=versions
Please follow the instructions here: https://github.com/storyblok/storyblok-astro/tree/alpha?tab=readme-ov-file#enabling-live-preview-for-storybloks-visual-editor
@dipankarmaikap and I currently working on a new major version of @storyblok/astro to introduce stable support of the live preview functionality.


add location of image in the cluster

Adds more information as requested in #7

nice change. thanks!


[resotocore][feat] Separate custom core command configuration

Description
separate configuration for resoto.core and resoto.core.commands.

To-Dos

[x] Add test coverage for new or updated functionality
[x] Lint and test with tox
[ ] Document new or updated functionality (someengineering/resoto.com#XXXX)

Issues Fixed

Fixes #XXXX

Code of Conduct
By submitting this pull request, I agree to follow the code of conduct.

This is great, way cleaner to work with. Just one thing I noticed, in the past I would see the emojis in my vim, now I see unicode escape characters?

Just tested, when I add 🥰 emoji to the config I see it when I edit it, but when I save and reopen the config it's been converted to an escape sequence.

Just tested, when I add 🥰 emoji to the config I see it when I edit it, but when I save and reopen the config it's been converted to an escape sequence.

Good catch - it also misses the documentation on top of every property.
Should be fixed with last commit.


Multi-line comment/uncomment operations in DrRacket

It should be easy to (un)comment multiple lines at once in DrRacket.

Done in ab1450599ff6ae7eb9b804848417e3f98b76b82d.


Rearchitect how we do mapping

Alrighty I finally took a deep look at https://github.com/hughbe/excel-mapper/issues/37, and made some changes.
The first thing I did was rearchitect the way that property mappers work.
I renamed ICellValueReader to ISingleCellValueReader to represent the fact that it reads a single value and changed it to follow the try pattern:
    public interface ISingleCellValueReader
    {
        bool TryGetValue(ExcelSheet sheet, int rowIndex, IExcelDataReader reader, out ReadCellValueResult result);
    }

I kept IMultipleCellValuesReader with the same name to represent the fact that it reads more than one value and changed it to follow the try pattern:
    /// <summary>
    /// An interface that describes an object that can read the values of multiple cells in a row.
    /// This describes a one-to-many or many-to-many mapping between a cell and a mapped value.
    /// </summary>
    public interface IMultipleCellValuesReader
    {
        bool TryGetValues(ExcelSheet sheet, int rowIndex, IExcelDataReader reader, out IEnumerable<ReadCellValueResult> result);
    }

Now, ExcelPropertyMap has a different abstract requirement:
public abstract void SetPropertyValue(ExcelSheet sheet, int rowIndex, IExcelDataReader reader, object instance);

This implies that you should call SetPropertyFactory from within this method.
This let me kill off OptionalCellValueReader and directly add a property Optional to ExcelPropertyMap. This actually has some side effects. Namely, that if the column is optional and isn't found, we exit early and don't call the empty value fallback.
I added some benchmarks. For a simple excel sheet of 10,000 rows with a single column, times for optional/default are essentially the same.

Method
Mean
Error
StdDev

DefaultMap
39.59 ms
0.785 ms
1.788 ms

OptionalMap
37.19 ms
0.695 ms
0.616 ms

OptionalNoSuchValueMap
40.46 ms
1.002 ms
2.761 ms

Previously, OptionalNoSuchValueMap was up to 400ms. So I'm quite happy with this to say the least. For a more complicated document with more rows and more columns, the improvements are going to be massive
/cc @jeffolmstead @BalassaMarton

I like that performance increase! Just to confirm, if you mark a column as optional, would there be no way to use .WithValueFallback()?  Just making sure I understood that right. Would the intellisense let you chain them together? Just trying to see if there is a way to default the value of an optional column, outside that, everything else reads great and my quick look through the code seemed good. Thanks for tackling this!

Just to confirm, if you mark a column as optional, would there be no way to use .WithValueFallback()?

Yeah that is a side effect of this change that if the column isn't found then we don't set the value.
I think this is OK, though, because you can set the default value on the structure. In my opinion this is better, as (from what I can think of on the top of my head), if we fail to find an optional value on one row then we won't find it for any rows.
e.g.
public class DataClass
{
    public int MissingColumnName { get; set; } = 10;
}

Previously we would have actually thrown if we called MakeOptional without WithDefaultValue as we couldn't assign "" to to an int. Now, we bail out if we make an early exit, so the setter never ends up getting called.
See also https://github.com/hughbe/excel-mapper/pull/44/files#diff-ca9b7cf3563e866c893889395228da20


Refactor Package & make it more consistent.

Since all the features of the package are now available, I think we need a refactoring to make everything more consistent.
We should word on following tasks:

core feature dart file should have the name of the feature.

if the name of the feature is commas the file name should have a name of commas.dart.

all the models classes should implement in the model.dart file.
all the constant for the specific feature should move to lib/src/constants/feature_name/constants.dart file.
Values that are not used as public APIs must be converted to private access.

@EhsanAramide  @m-khooryani If you are interested, you can do one of the tasks defined in our current project.  If you have any suggestion for this issue please leave comment and let me know.

Hi
I'd like to contribute to refactoring.

Ok khosro, so I will assign you to this issue.

Is refactoring ended or not?
@makhosravi
@payam-zahedi

Hi,
I'm working on it and will be ready soon

@all-contributors please add @makhosravi  for code, doc, example and test

@all-contributors please add @makhosravi for code, doc, example and test

@all-contributors please add @makhosravi for code, doc, example and test

@all-contributors please add @makhosravi for code

@all-contributors please add @makhosravi for review


ENH: addition of the argument show=True in plot_psd()

Many plot_XXX functions do have the show(=True) argument contrary to plot_psd().
I needed to use it, so here is this small PR adding this arg in this function.

+1 from me for completeness, I'm not worried about it not being at the end since it's so far into a long list of kwags. Okay with you @agramfort?

If this manages to break someone's code because they used enough args to have it not work anymore, we should award them with some sort of prize.

LGTM
+1 for merge when you make travis happy. pyflakes error

+1 for merge once travis is happy

Coverage decreased (-0.23%) to 89.97% when pulling 8c0117ff7375692fe1ebb4adb09ab5c386acb0cc on cmoutard:pr into 8c0117ff7375692fe1ebb4adb09ab5c386acb0cc on mne-tools:master.

I don't know what happened here, I never closed it. Unfortunately, I won't have time to clean this. Maybe this PR should just be ignored ?

It auto-closed -- you must have push forced a branch here that had no new commits relative to upstream master. Feel free to open a new PR if you come back to this at some point.

If you messed up, you can use git reflog to recover. Google it :)

Thanks @mainakjas !!
I am opening a new PR on @Eric89GXL 's advice.


Manifests compilation failing out of the box (possibly due to grafana.libsonnet)

What happened?
Fresh install starting from scratch following docs does not compile (fails on grafana.libsonnet)
in my test I installed the release-0.4 branch because my kubernetes version is 1.17.x but I also tried with master just to test.
This is the main manifest (basic.jsonnet)

local kp =
  (import 'kube-prometheus/kube-prometheus.libsonnet') +
  (import 'kube-prometheus/kube-prometheus-all-namespaces.libsonnet') +
  {
    _config+:: {
      namespace: 'monitoring',

      // given we include the all-namespaces patch above, we need to remove the builtin namespaces
      // otherwise additional (useless) rbacs will be created
      prometheus+:: {
        namespaces: [],
      },
    },
  };

local manifests =
  { ['setup/0namespace-' + name]: kp.kubePrometheus[name] for name in std.objectFields(kp.kubePrometheus) } +
  {
    ['setup/prometheus-operator-' + name]: kp.prometheusOperator[name]
    for name in std.filter((function(name) name != 'serviceMonitor'), std.objectFields(kp.prometheusOperator))
  } +
  // serviceMonitor is separated so that it can be created after the CRDs are ready
  { 'prometheus-operator-serviceMonitor': kp.prometheusOperator.serviceMonitor } +
  { ['node-exporter-' + name]: kp.nodeExporter[name] for name in std.objectFields(kp.nodeExporter) } +
  { ['kube-state-metrics-' + name]: kp.kubeStateMetrics[name] for name in std.objectFields(kp.kubeStateMetrics) } +
  { ['alertmanager-' + name]: kp.alertmanager[name] for name in std.objectFields(kp.alertmanager) } +
  { ['prometheus-' + name]: kp.prometheus[name] for name in std.objectFields(kp.prometheus) } +
  { ['prometheus-adapter-' + name]: kp.prometheusAdapter[name] for name in std.objectFields(kp.prometheusAdapter) } +
  { ['grafana-' + name]: kp.grafana[name] for name in std.objectFields(kp.grafana) };

local kustomizationResourceFile(name) = './manifests/' + name + '.yaml';
local kustomization = {
  apiVersion: 'kustomize.config.k8s.io/v1beta1',
  kind: 'Kustomization',
  resources: std.map(kustomizationResourceFile, std.objectFields(manifests)),
};

manifests {
  'kustomization': kustomization,
}

Did you expect to see some different?
yes, to compile the manifests.
How to reproduce it (as minimally and precisely as possible):
Create a new directory and place the above basic.jsonnet files alongside the following ones:
jsonnetfile.json:
{
  "version": 1,
  "dependencies": [
    {
      "source": {
        "git": {
          "remote": "https://github.com/prometheus-operator/kube-prometheus.git",
          "subdir": "jsonnet/kube-prometheus"
        }
      },
      "version": "release-0.4"
    }
  ],
  "legacyImports": true
}

jsonnetfile.lock.json:
{
  "version": 1,
  "dependencies": [
    {
      "source": {
        "git": {
          "remote": "https://github.com/brancz/kubernetes-grafana.git",
          "subdir": "grafana"
        }
      },
      "version": "4204279da8d3d6317116ee161ac706fadbba9193",
      "sum": "VUavLhri7lTnJ2V7F9lDlL+K96NwIhqqlxMtasYBs3Q="
    },
    {
      "source": {
        "git": {
          "remote": "https://github.com/coreos/etcd.git",
          "subdir": "Documentation/etcd-mixin"
        }
      },
      "version": "a3174d0f8ec6ec58827d7d86448bb4df08ae69e4",
      "sum": "bLqTqEr0jky9zz5MV/7ucn6H5mph2NlXas0TVnGNB1Y="
    },
    {
      "source": {
        "git": {
          "remote": "https://github.com/coreos/prometheus-operator.git",
          "subdir": "jsonnet/prometheus-operator"
        }
      },
      "version": "8b9d024467383d84b55d7e5e0d4f7a33eb5007b3",
      "sum": "exdWZ9NLaBId9tUmkHnAx2zECdVvhfy3RUQsSqI96Fk="
    },
    {
      "source": {
        "git": {
          "remote": "https://github.com/grafana/grafonnet-lib.git",
          "subdir": "grafonnet"
        }
      },
      "version": "4cd00bb4e372bd3ea460c05cece770f9f66831e8",
      "sum": "uJqGLrC9O1zy/Of6IjsveIUbS6I8MCbLMa1e3h3EwKs="
    },
    {
      "source": {
        "git": {
          "remote": "https://github.com/grafana/jsonnet-libs.git",
          "subdir": "grafana-builder"
        }
      },
      "version": "b662248e4dce100139afb050244503c83bd095c1",
      "sum": "9/eJqljTTtJeq9QRjabdKWL6yD8a7VzLmGKBK3ir77k="
    },
    {
      "source": {
        "git": {
          "remote": "https://github.com/ksonnet/ksonnet-lib.git",
          "subdir": ""
        }
      },
      "version": "0d2f82676817bbf9e4acf6495b2090205f323b9f",
      "sum": "h28BXZ7+vczxYJ2sCt8JuR9+yznRtU/iA6DCpQUrtEg=",
      "name": "ksonnet"
    },
    {
      "source": {
        "git": {
          "remote": "https://github.com/kubernetes-monitoring/kubernetes-mixin.git",
          "subdir": ""
        }
      },
      "version": "f0a5099c8214241842b827a08eba6d7b515550ea",
      "sum": "n3D/4k8wAW5NDjmwyvca/GS18ofBoS7Z5F9d3rWiqfw="
    },
    {
      "source": {
        "git": {
          "remote": "https://github.com/kubernetes-monitoring/kubernetes-mixin.git",
          "subdir": "lib/promgrafonnet"
        }
      },
      "version": "243110f771b791e00b52b85c2eb9d20f085c93bd",
      "sum": "zv7hXGui6BfHzE9wPatHI/AGZa4A2WKo6pq7ZdqBsps="
    },
    {
      "source": {
        "git": {
          "remote": "https://github.com/metalmatze/slo-libsonnet.git",
          "subdir": "slo-libsonnet"
        }
      },
      "version": "e238df4fac957357d78a405966c51523ef151cbc",
      "sum": "5XrxbGgMFMHnKGeE++fiduDlDEiDunM2ZMTYCmPbWgA="
    },
    {
      "source": {
        "git": {
          "remote": "https://github.com/prometheus-operator/kube-prometheus.git",
          "subdir": "jsonnet/kube-prometheus"
        }
      },
      "version": "68692f7aec038090bfba951bdf821dd8f1c08e75",
      "sum": "3K86dkG/R9Ejw0SAD84K7quqYsoCLVUA3bdCxeRcMHk="
    },
    {
      "source": {
        "git": {
          "remote": "https://github.com/prometheus/node_exporter.git",
          "subdir": "docs/node-mixin"
        }
      },
      "version": "8a3cc9db052cb12beae8565a363d77d08dce8a24",
      "sum": "rvyiD/yCB4BeYAWqYF53bP8c+aCUt2ipLHW2Ea8ELO8="
    },
    {
      "source": {
        "git": {
          "remote": "https://github.com/prometheus/prometheus.git",
          "subdir": "documentation/prometheus-mixin"
        }
      },
      "version": "e5478983c43cb839a77c144f953b9ea25783b995",
      "sum": "6kUzElCBWZ5U/3cxEpHNMmoKKPubG45QxpmLu8PGg08=",
      "name": "prometheus"
    }
  ],
  "legacyImports": false
}

Then install the dependencies and try to generate the manifests:
❯ jb install
[...]
❯ jsonnet -J vendor -m manifests basic.jsonnet
RUNTIME ERROR: Field does not exist: config
	vendor/grafana/grafana.libsonnet:52:20-44	thunk from <object <anonymous>>
	vendor/grafana/grafana.libsonnet:52:9-45	object <anonymous>
	basic.jsonnet:30:72-82	thunk from <thunk <manifests> from <$>>
	<std>:1293:24-25	thunk from <function <anonymous>>
	<std>:1293:5-33	function <anonymous>
	basic.jsonnet:30:55-83	thunk <manifests> from <$>
	basic.jsonnet:30:3-85
	basic.jsonnet:30:3-85
	basic.jsonnet:39:1-10	$
	During evaluation

Environment

Kubernetes cluster kind:
kind, version 1.17.x.

Manifests:
see above

Anything else we need to know?:
Before opening an issue I reached out over slack. For more background info and what has been tried, you can refer to this thread.

Experiencing the same issue
`RUNTIME ERROR: Field does not exist: config
vendor/grafana/grafana.libsonnet:52:20-44       thunk from <object >
vendor/grafana/grafana.libsonnet:52:9-45        object
grafana-dashboards.libsonnet:41:70-80   thunk from <$>
:1278:24-25        thunk from <function >
:1278:5-33 function
grafana-dashboards.libsonnet:41:53-81   $
    During evaluation`

also seeing the same thing:
√ jcorley@j-corley-md6m:~/tmp % ~/go/bin/jb install
GET https://github.com/prometheus-operator/kube-prometheus/archive/68692f7aec038090bfba951bdf821dd8f1c08e75.tar.gz 200
GET https://github.com/coreos/prometheus-operator/archive/8b9d024467383d84b55d7e5e0d4f7a33eb5007b3.tar.gz 200
GET https://github.com/coreos/etcd/archive/a3174d0f8ec6ec58827d7d86448bb4df08ae69e4.tar.gz 200
GET https://github.com/prometheus/prometheus/archive/e5478983c43cb839a77c144f953b9ea25783b995.tar.gz 200
GET https://github.com/prometheus/node_exporter/archive/8a3cc9db052cb12beae8565a363d77d08dce8a24.tar.gz 200
GET https://github.com/ksonnet/ksonnet-lib/archive/0d2f82676817bbf9e4acf6495b2090205f323b9f.tar.gz 200
GET https://github.com/kubernetes-monitoring/kubernetes-mixin/archive/f0a5099c8214241842b827a08eba6d7b515550ea.tar.gz 200
GET https://github.com/brancz/kubernetes-grafana/archive/4204279da8d3d6317116ee161ac706fadbba9193.tar.gz 200
GET https://github.com/grafana/grafonnet-lib/archive/4cd00bb4e372bd3ea460c05cece770f9f66831e8.tar.gz 200
GET https://github.com/grafana/jsonnet-libs/archive/b662248e4dce100139afb050244503c83bd095c1.tar.gz 200
GET https://github.com/kubernetes-monitoring/kubernetes-mixin/archive/243110f771b791e00b52b85c2eb9d20f085c93bd.tar.gz 200
GET https://github.com/metalmatze/slo-libsonnet/archive/e238df4fac957357d78a405966c51523ef151cbc.tar.gz 200
√ jcorley@j-corley-md6m:~/tmp % jsonnet -J vendor -m manifests basic.jsonnet
RUNTIME ERROR: Field does not exist: config
	vendor/grafana/grafana.libsonnet:52:20-44	thunk from <object <anonymous>>
	vendor/grafana/grafana.libsonnet:52:9-45	object <anonymous>
	basic.jsonnet:29:72-82	thunk from <thunk <manifests> from <$>>
	<std>:1293:24-25	thunk from <function <anonymous>>
	<std>:1293:5-33	function <anonymous>
	basic.jsonnet:29:55-83	thunk <manifests> from <$>
	basic.jsonnet:29:3-85
	basic.jsonnet:29:3-85
	basic.jsonnet:38:1-10	$
	During evaluation

?1 jcorley@j-corley-md6m:~/tmp %

I'm not the best with jsonnet but after some digging around and seeing it complain about 'vendor/grafana/grafana.libsonnet' which I think it points towards this repo - https://github.com/brancz/kubernetes-grafana/tree/master/grafana
Checking that file out it does not have a config section.

I have same your issue when I follow document.
jb install<EMAIL_ADDRESS>./build.sh example.jsonnet
+ set -o pipefail
+ rm -rf manifests
+ mkdir -p manifests/setup
+ jsonnet -J vendor -m manifests example.jsonnet
+ xargs '-I{}' sh -c 'cat {} | gojsontoyaml > {}.yaml; rm -f {}' -- '{}'
RUNTIME ERROR: Field does not exist: config
        vendor/grafana/grafana.libsonnet:52:20-43
        vendor/grafana/grafana.libsonnet:52:9-44        object <anonymous>
        vendor/kube-prometheus/kube-prometheus.libsonnet:(16:36)-(44:1) object <anonymous>
        example.jsonnet:27:70-79        thunk <o>
        std.jsonnet:957:28
        std.jsonnet:957:9-36    function <anonymous>
        example.jsonnet:27:53-80        thunk <a>
        example.jsonnet:27:1-82 function <anonymous>
        example.jsonnet:27:1-82

Also ran into this..
Not positive.. but it looks like this change in the main prometheus repository (upstream) is overwriting the grafana config provided by the grafana lib: https://github.com/prometheus/prometheus/pull/8287
Swapping out line 41 in the vendor/prometheus/config.libsonnet seems to correct.
Old
    grafana: {
New
    grafana+: {

@toscott is right. I experience the same thing when updating to the latest dependencies.

@brancz: I feel this is a better place to discuss your comment ( https://github.com/prometheus/prometheus/pull/8287#issuecomment-752681120 ).
As you mentioned there, there is already a plan to refactor kube-prometheus to avoid a global config ( https://github.com/prometheus-operator/kube-prometheus/issues/566 ).
That doesn't help though users facing this issue right now though. Is there any known workaround that users can implement until #566 is done?

Since https://github.com/prometheus/prometheus/pull/8287 breaks current user behavior, I think we should just add the +: in prometheus/prometheus. I'll open a PR shortly.

Since prometheus/prometheus#8287 breaks current user behavior, I think we should just add the +: in prometheus/prometheus. I'll open a PR shortly.

Perfect, thank you. Will this be back-ported to older branches as well?

I believe all versions of kube-prometheus use latest of the prometheus mixin, so this should happen automatically for every kube-prometheus release after running jb update once it's merged.

Thanks @brancz, https://github.com/prometheus/prometheus/pull/8332 fixed this issue, closing.


Unable to Zoom

Hi .. Is it possible to zoom image while using this Package.

Hi,
View Tools (like zoom) is not something this library aims to cover. In most cases (if not all), you will have full control over the image you are using with the lib.
Here's a simple example: https://codepen.io/extrudejs/pen/mdvZvRW


Implementation for new systemd configuration method

Add a new configuration method called systemd mode.
With this new mode all the VFs are created before kubelet even starts this will allow the operator to have a much better recovery time after reboot.
it will also fix issues like https://github.com/kubernetes/kubernetes/issues/109595
The downside of this solution and the reason why for now it will not be the "default" configuration mode is that every configuration change in sriov will require a node reboot.
After this PR is merged we will need to work on
https://github.com/k8snetworkplumbingwg/sriov-network-operator/issues/225
https://github.com/k8snetworkplumbingwg/sriov-network-operator/issues/226
to improve the configuration/reconfiguration/update time on large clusters

Can one of the admins verify this patch?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

130 of 926 (14.04%)  changed or added relevant lines in 18 files are covered.
5 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-1.5%) to 23.651%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/daemon/writer.go
0
1
0.0%

pkg/webhook/webhook.go
0
1
0.0%

pkg/daemon/plugin.go
0
2
0.0%

api/v1/helper.go
1
4
25.0%

pkg/plugins/intel/intel_plugin.go
0
5
0.0%

pkg/plugins/generic/generic_plugin.go
3
10
30.0%

pkg/utils/utils.go
0
9
0.0%

pkg/plugins/virtual/virtual_plugin.go
0
10
0.0%

pkg/utils/utils_virtual.go
0
19
0.0%

pkg/utils/mock/mock_command.go
0
24
0.0%

Files with Coverage Reduction
New Missed Lines
%

pkg/plugins/k8s/k8s_plugin.go
1
0%

controllers/sriovibnetwork_controller.go
2
67.33%

pkg/utils/utils.go
2
6.44%

Totals

Change from base Build<PHONE_NUMBER>:
-1.5%

Covered Lines:
1963

Relevant Lines:
8300

💛  - Coveralls

@SchSeba Do you have a readme planned explaining how to enable systemd?

waiting for https://github.com/k8snetworkplumbingwg/sriov-network-operator/pull/409


Adjust the error message for missing const initializer

Fixes #1547

Current coverage is 100% (diff: 100%)

Merging #1548 into master will not change coverage

@@           master   #1548   diff @@
=====================================
  Files           1       1
  Lines        3730    3734     +4
  Methods         0       0
  Messages        0       0
  Branches      627     628     +1
=====================================
+ Hits         3730    3734     +4
  Misses          0       0
  Partials        0       0

Powered by Codecov. Last update 4af537f...5a7e612

Whoa, the downstream test failed because one of recast's test relies on the old error message. I need to investigate...

:+1:

As an aside, it would be nice if failure messages were JSON pretty printed like they were during the initial conversion.

As an aside, it would be nice if failure messages were JSON pretty printed...

At some point, we need to normalize those failure reports anyway (#1272).

Oh, it's too bad that the workaround for recast hard-coded test worked in this pull request but it doesn't work after it's merged to master 😿


In a distribute model, if I run 10 worker jobs, how many ps jobs should run?

In a distribute model, 10 nodes each have one GPU and run a worker job, how many ps jobs should run?

sorry, I should ask this problem in at right place.


Project Detail Page - Staging (M)

Summary:
As a DHO user I would like to see all details of an staged proposals on one overview page.
Description:
old URL:
sidebar
new URL:
/activity/
Acceptance Criteria:

[ ] back button / breadcrumb navigation?
[ ] Title: Project Title

Proposal Detail Widget:

[ ] Label: Document Type
[ ] Label: Circle
[ ] Label: Compensation (Salary Band or USD equivalent)
[ ] Titel of Proposal
[ ] Text field with Objectives, Key Results, Description, Documentation Link
[ ] Date & Duration
[ ] Commitment Level
[ ] Deferred Amount
[ ] HUSD, Hypha, HVOICE, Total USD equivalent
[ ] Avatar, Name, Link to profile, badges

Vote Widget:

[ ] Title: Your proposal is on staging
[ ] Explanation copy: https://docs.google.com/document/d/1KHC_6Cha8MC2NMKDV6XRXKuZGS7kPdVGuLtF_kSYvbU/edit
[ ] Button: Publish
[ ] Link: Edit Proposal

Last Votes Widget:

[ ] date
[ ] name
[ ] avatar
[ ] vote (yes, no, support, abstain, harmful, unicorns, etc...)
[ ] % of vote (of HVOICE in organisation - not per this vote (current status)
[ ] Pagination

Comment Widget:

[ ] not MVP see different story: #456

Ressources:
Attachement:
https://xd.adobe.com/view/26643786-1dac-4585-8f94-f76023be3090-7337/screen/ce6a53b2-c119-4dbf-9c43-b17a9d8a931f
https://xd.adobe.com/view/d802317c-bf4d-4084-a77e-b6c2d046d49c-8d51/

Responsive Designs:
To be done

Hey @leonieherma1 what is the diference with this task???  https://github.com/hypha-dao/dho-web-client/issues/324

Oh sorry this is a specific state for this screen right?

@leonieherma1 We need to change that also on the backend

the voting period (7 days) should only start once the proposal is live:

@Gerard097 @josejulio @smonteroMW

@arsenijesavic
Please change the copy on both buttons to:
"Publish to Staging"

And this copy to:
Your proposal is on staging
That means your proposal is not publish to the blockchain yet. You can still make changes to it, when you feel ready click "Publish" and the voting period will start.

@arsenijesavic the "edit proposal" button is not working as expected

Expected behaviour:

[ ] Open the proposal creation wizard on the second screen / step 2 (I cannot change the document type anymore, correct?)

[ ] When I open it then the whole proposal content is gone:
https://dao-dev.hypha.earth/hypha/proposals/30462

@arsenijesavic staging should be toggled on as default

@arsenijesavic after clicking "publish" I see this screen:

Label says "staging" and button says "publish" - but it should be published already (transaction was succesfull)


PyPi package + installation update

Is your feature request related to a problem? Please describe.
This is a stub-issue for myself to ensure that I get PyPi functional, once it is I will update the installation instructions.
Describe the solution you'd like
Package is available on PyPi
Groundwork completed by #99
Will aim to release 3.0.2 as our initial PyPi release

Sorry to have left this for so long, I will attend to this once I can confirm 3.0.2 is a stable release.

Closing this as I dont wish to maintain this package on PyPi.


Can we block a PR from being merged if any commits are still unsigned?

The green, candy-like Merge button is enabled if the latest commit in a PR has a sign-off no matter how many prior commits there many be that are not signed-off. The prior unsigned-off commits will have their red-Xs, but checking that those red-Xs are from the DCO check and not previous failed CI runs is left up to a human.
An example: https://github.com/poboy/paprika/pull/1
Some ideas:

mark a PR as unmergeable directly despite the latest commit passing checks (like the future REST API endpoint for creating a Review that "requests changes")
apply a label, e.g. "Some Commits Need Sign-Off"
add a comment to the PR about some commits needing sign-off and link to them (this would/could be a bit like Curry's old behavior)

It looks like a REST API for the new PR Review feature is on the near-term roadmap. With that implement, DCOBot could submit a "Request Changes" review when it notices any unsigned commits in a PR.

that'd be pretty delightful.

https://developer.github.com/v3/pulls/review_requests/

https://developer.github.com/v3/pulls/reviews/#create-a-pull-request-review


Minor update for K8S install command

... is required due to a newer kubernetes-cni version being available, but kube*1.8 not being able to work with that version

Can this be merged? The original command does not work as-is.


Test handling of character encodings specified in xml encoding attribute and http header

This splits of part of the work from https://github.com/newsboat/newsboat/pull/2340

coverage: 60.511% (+0.06%) from 60.45%
when pulling 07abd795d49a61c59ebd15bca5f54dd329368a3b on dennisschagt:test-charencoding
into 323c4f6cb0ce012d93ea9e1ebe563b45047af092 on newsboat:master.


Fix for upstream 2024.1

homeassistant just released a new tag in their repo, but it hasn't shown up in pypi yet.  It will have to be rerun once it shows up.

#170 is maybe asking for this whole testing_config folder to be copied over, but this is good as a quick patch fix.

#170 is maybe asking for this whole testing_config folder to be copied over, but this is good as a quick patch fix.

I'm not sure that's a good idea. There are so many unnecessary files.

homeassistant just released a new tag in their repo, but it hasn't shown up in pypi yet. It will have to be rerun once it shows up.

pypi has 2024.1.0b8 now, please rerun workflow

Getting caught in a flurry of releases from home assistant that prevent publishing here.  Will keep trying.


The Rows and columns of Table in rich text editor is not Editable , i.e , cells cannot be added / Removed during editing.

The Rows and columns of Table in rich text editor is not Editable , i.e , cells cannot be added / Removed during editing.

Can't reproduce, need better explanation.


ARROW-5206: [Java] Add APIs in MessageSerializer to directly serialize/deserialize ArrowBuf

This PR is related to ARROW-5206, add APIs in MessageSerializer to directly serialize/deserialize ArrowBuf.

A small note, the title should be ARROW-5206: [Java] Add APIs in MessageSerializer...

Changed the title to be more conforming to standard

@fsaintjacques @wesm Thanks for your reminder.

@wesm could you please help review this PR? thanks very much

@tianchen92 I'm not comfortable giving +1 to non-trivial Java PRs. Could @BryanCutler, @siddharthteotia, or @jacques-n take a look?

Thanks very much for your reply @wesm, I am not sure, do you mean to say that these APIs are not necessary or shouldn't added in MessageSerializer? I think provide methods to directly serialize ArrowBuf or even ValueVector may be helpful for users in some cases.
I would appreciate it if you could give me some comments, thanks very much! @BryanCutler @siddharthteotia @jacques-n

@tianchen92 I don't do Java. Someone else will have to review

@tianchen92 , I'm not quite sure these APIs add much value because an ArrowBuf can be written directly with the WriteChannel (you can take a slice before to only write a chunk), or read directly with a ReadChannel.

@BryanCutler Thanks a lot for your comments, I think you are right, we can read/write ArrowBuf through WriteChannel.write(ByteBuffer buffer).
Ask an unrelated question, is there any way to directly serialize/deserialize ValueVector? If not, can we add these APIs? as I described in ARROW-5224. Thanks!

@tianchen92 the usual way to serialize a ValueVector is by adding the Field to a VectorSchemaRoot and serializing it to a RecordBatch. This produces a standard IPC message that can be exchanged with other Arrow implementations. It is possible to just serialize a single vector, but it would probably have to be deserialized in Java as well, and I don't know if this adds much value. If you have a use case for this though, please go ahead and make another jira.

@BryanCutler Sure, thanks for your feedback, I will close this PR.


autocalc rec len for MS3Record

This fails:
#!/usr/bin/env python3

from mseedlib import MS3Record
rec = MS3Record()
rec.formatversion = 3
rec.encoding = 3   # int32
rec.set_starttime_str("2024-01-01T15:13:55.123456789Z")
rec.samplerate = 40.0
#rec.reclen = 999999
data = [(i%99-49) for i in range(0,1000)]

def record_handler(buffer, handlerdata):
    print(f"Got {len(buffer)} bytes")

rec.pack(record_handler, handlerdata={}, datasamples=data, sampletype='i', verbose=1)

with
Error: : Record length is out of range: 0
Traceback (most recent call last):
  File "/Users/crotwell/Code/seis/ms3eh/python/simpleCreateData.py", line 15, in <module>
    rec.pack(record_handler, handlerdata={}, datasamples=data, sampletype='i', verbose=1)
  File "/opt/homebrew/Caskroom/miniforge/base/envs/ms3eh/lib/python3.11/site-packages/mseedlib/msrecord.py", line 419, in pack
    raise MseedLibError(packed_records, f'Error packing miniSEED record(s)')
mseedlib.exceptions.MseedLibError: Generic error :: Error packing miniSEED record(s)

but adding:
rec.reclen = 999999

works, but seems unnecessary.
For miniseed2, a record length makes sense, and probably also for MSTraceList. But for a single MS3Record, there is no problem with arbitrary large records, so would be nice if MS3Record.pack() should just calculate the record size itself when reclen is the default 0. If I ask for a single record and it is really large due to a really long data array, then that is my own fault.

But for a single MS3Record, there is no problem with arbitrary large records
Except that the library/mseedlib will not be able to read them.

But, yeah, the default record length should have been used in that example.

Is there a max record length for the library to read? This is only 1000 points, so seems like it isn't crazy big.
I think in many instances a single large record makes more sense that a whole bunch of pieces, at least when you already have a big array of data in memory. Be nice if the library could deal with that case.

Is there a max record length for the library to read? This is only 1000 points, so seems like it isn't crazy big.

Yes, for the current release, [defined in libmseed.h](from libmseed.h):
#define MAXRECLEN 10485760 //!< Maximum miniSEED record length supported (10MiB)
#define MAXRECLENv2 131172 //!< Maximum v2 miniSEED record length supported (131+ KiB or 2^17)

This probably isn't the source of the issue, but is a counter-point to the assertion that "... for a single MS3Record, there is no problem with arbitrary large records".
limbseed has the concept of a default record length used when not set by the caller.  Regardless of the default or user-specified, the record length is fixed for miniSEED v2 and becomes the maximum for v3.  One of the issues for mseedlib appears to be that the default is not working.

True, let me rephrase:

But for a single MS3Record, the spec allows for very large records

Use case:
I have an array of integers in memory that represents a large but within spec contiguous timeseries. I would like to save it as a single miniseed3 record without having to guess at the final saved byte size. I accept responsibility if the resulting file is ginormous. :)

Context for future readers: the discussion of large record support is not specific to mseedlib (this repository) but to libmseed's support of the specification.

But for a single MS3Record, the spec allows for very large records

libmseed, and therefore mseedlib, do not support the full range of the specification for this reason: the design of software meant to handle relatively small records can be simplified and optimized significantly compared to a design intended to handle record lengths of ~4 GiB.  For example, assuming that a record can be read wholly into memory without potentially impacting the system makes for a much simpler & optimized design.  To that point libmseed re-uses a single pre-allocated buffer for reading records, which is enormously beneficial in that it reduces allocations and allows the decoding logic to operate on a single buffer.  Without this, the reading and decoding logic would require stateful "paging" through partial views of a record incrementally fetched from storage/network/etc, which is a non-trivial complexity.  I would argue that this kind of "paging" through a ginormous record has very little benefit over reading smaller records with the same data.
From a practical perspective, I do not think any real use is seriously hampered by partitioning a continuous time series into multiple records.  Anyone using a miniSEED library (as they should), would not care or even know that the time series was partitioned/chunked/split into records.  When partitioning gigabytes of data into, say, 1 MiB records, the amount of overhead in volume and data series reconstruction is pretty small to the point of non-relevance.

I would like to save it as a single miniseed3 record without having to guess at the final saved byte size.

My argument above is that the vast majority of users do not really care how many records it is.  Regarding guessing the final byte size, I'm guessing that if the default maximum record size of 4096 bytes had worked, most people would not even notice that more than one record was produced.  If you would like to be pedantic about record size you're welcome to set the length up to 10 MiB and create large (but not ginormous) records.
The miniSEED v2 default size of 4096 bytes makes a lot of sense for broad compatibility.  An argument could be made for having a larger default maximum size for v3 records, like 1 MiB for example, or even upping the  libmseed maximum of 10 MiB.  But not 4 GiB as that would require a very different design, and even more complexity to avoid that design effecting the performance of the majority, small-record, use case.

Hi Folks-

I am also reminded of clock drift for sampling, where record breaks allow for milepost assertions of current time before epsilon gets too high.  I could see where kilohertz sample rates might beg for longer records since you can record so much within reasonable time tolerances.  Still, is it really helpful to have such a very long record (as Chad indicates)?  Getting into the megabyte scale of a sample array will challenge most code and libraries as it represents a significant buffer size.  If the data is compressed, the application will likely need to internalize the entire record content just to pull out a decompressed range (unless the compression format is partitioned).

Is there a use case we are looking at where really long arrays make sense?

Just curious.

-Rob

On Feb 19, 2024, at 2:14 PM, Chad Trabant @.***> wrote:
Context for future readers: the discussion of large record support is not specific to mseedlib (this repository) but to libmseed's support of the specification.
But for a single MS3Record, the spec allows for very large records
libmseed, and therefore mseedlib, do not support the full range of the specification for this reason: the design of software meant to handle relatively small records can be simplified and optimized significantly compared to a design intended to handle record lengths of ~4 GiB. For example, assuming that a record can be read wholly into memory without potentially impacting the system makes for a much simpler & optimized design. To that point libmseed re-uses a single pre-allocated buffer for reading records, which is enormously beneficial in that it reduces allocations and allows the decoding logic to operate on a single buffer. Without this, the reading and decoding logic would require stateful "paging" through partial views of a record incrementally fetched from storage/network/etc, which is a non-trivial complexity. I would argue that this kind of "paging" through a ginormous record has very little benefit over reading smaller records with the same data.
From a practical perspective, I do not think any real use is seriously hampered by partitioning a continuous time series into multiple records. Anyone using a miniSEED library (as they should), would not care or even know that the time series was partitioned/chunked/split into records. When partitioning gigabytes of data into, say, 1 MiB records, the amount of overhead in volume and data series reconstruction is pretty small to the point of non-relevance.
I would like to save it as a single miniseed3 record without having to guess at the final saved byte size.
My argument above is that the vast majority of users do not really care how many records it is. Regarding guessing the final byte size, I'm guessing that if the default maximum record size of 4096 bytes had worked, most people would not even notice that more than one record was produced. If you would like to be pedantic about record size you're welcome to set the length up to 10 MiB and create large (but not ginormous) records.
The miniSEED v2 default size of 4096 bytes makes a lot of sense for broad compatibility. An argument could be made for having a larger default maximum size for v3 records, like 1 MiB for example, or even upping the libmseed maximum of 10 MiB. But not 4 GiB as that would require a very different design, and even more complexity to avoid that design effecting the performance of the majority, small-record, use case.
—
Reply to this email directly, view it on GitHub https://github.com/EarthScope/mseedlib/issues/3#issuecomment-1953219695, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFL4VN2P3PPMPQPSWMFOJQLYUPFGFAVCNFSM6AAAAABDMQH5BGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGIYTSNRZGU.
You are receiving this because you are subscribed to this thread.

TL;DR  For those citizens of the future that still wish to create large records, even if the above would suggest it is a bad idea (TM) please have a look at the "competition", simplemseed. Pure python, no limits, plenty of rope to shoot yourself in the foot, etc.
Here is an example of writing a ginormous record.
IMHO, there is a lot of grey area in between my slightly tongue-in-check ginormous array and 4096. Yes, if the array is so large it has trouble fitting into memory, then that is a problem. But it is not really that uncommon for say ambient noise folks to deal in 24 hour segments of data. And while that is large, it is not so large as to be trouble fitting into memory.
My point largely is that in the post-processing, science side of data storage, it is a lot simpler conceptually and practically to just store one contiguous float array into a single record similar to the old SAC file format, especially if you have just processed it as a single float array in memory. And you get the advantage of a single extra header json instead of having to decide to put stuff in every record or only in the first, or how to merge multiple extra header copies on read, etc. People get lots of data in miniseed2, but as soon as they do any processing, I think they tend to save as something else that can hold a big ol array.
Just for giggles, one day at 40sps is 86400*40=3,456,000 samples and comes out to about 13Mb.
Just my $0.02.


AV-X enable GPS for rev C board

Need to review DMA usage, RS485 setup, and test.

Rebase after merging https://github.com/PX4/Firmware/pull/10423

Tested and working.


fix: recipe coarsing shorthands

Closes #1735
📝 Description
This PR fixes an issue where recipe variants that clash with utility shorthand don't get generated due to the normalization that happens internally.
⛳ Current behavior (updates)
Internal coarsion of "rounded" => "borderRadius" leading to a variant mismatch
🚀 New behavior
It works as expected. We skip normalization for recipes
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information

we probably want to add a test for this one


Text Extractor often misses underscores separating words

Microsoft PowerToys version
0.76.0
Installation method
PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
TextExtractor
Steps to reproduce
Hi! Something I often experience with Text Extractor is it misses underscores during the OCR process. This is an example from Notepad++, chosen because it has as plain, recognizable text as possible:

If the zoom is excessive or the font is very thick, it is more likely to capture the underscores.
Steps:

Use Text Extractor to capture text including underscores
Paste text. Underscores are often missing.

✔ Expected Behavior
All selected text and standard punctuation to be captured.
❌ Actual Behavior
Underscores are usually (not always) missed.
Other Software
No response

I'd love to improve the OCR Models, but right now that is not possible. What is possible is adjusting the image like scale, brightness, contrast, etc. If you can define what visual adjustments to the source image produce reliably better OCR results, then I'll work on implementing that in Text Extractor. Otherwise improving the model is out of scope.
Here is me doing OCR on that sample image using different models:
Text Extractor, Windows OCR
Here is an example
Here¯is¯an example/

Text Grab, Windows OCR
Here is an example
Here is an examplel

Text Grab, Tesseract OCR
Here_is_an_example
Here is an exampld

Snipping Tool
Here_is_an_example
Here is an example


Pubsublib IAM Policy update upon subsciption creation

completed and published
https://pypi.org/project/pubsublib/


Create signUp.html

I have made a front end of signup page.

Please add screenshots for the same on how it looks on mobile as well as desktop.

hey, if we want image to serve as a local source, i need to upload that with html and css files, but i think we are not allowed to upload files.
Can you pls guide us in this?
and i am soon uploading the seperated html and css files.
Thank u.

@nik-6947 Can you explain what do you mean by not allowed to upload files?

hey , i m sry that was my git's setting problem. I was getting this error.

My partner nishtha3006 has uploaded all the files.

Review each other's change and then only send a PR. Send a new pull request by thoroughly testing your changes. If you have sent a PR and I have asked to fix some issues, edit the same PR and don't create new ones. For now, I am closing this PR also. Create a fresh PR properly by testing your changes and commits.


Try to disable kernel watchdog

Let's see if those kernel crashes will disappear...

Fingers crossed

Fingers crossed

Too much green to be true;)

Fingers crossed

Too much green to be true;)

Yes, something does not add up :)

Repeated test runs still show some kernel crashes :(

Repeated test runs still show some kernel crashes :(

That's more like it

yes


feat: uppercase method to support lowercased 'patch'

🔗 Linked issue

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The JavaScript Fetch API supports lowercased get, post, delete, and put methods, but not the lowercased patch method. The method option in ofetch accepts a string | undefined, and the mentioned remark may be easy to forget without literal types. Therefore, it makes sense to standardize the behavior of all methods by converting them to uppercase. By convention, standardized methods are defined in all-uppercase, so this change should not break anything.
Additionally, the isPayloadMethod function already checks the method name by converting it to uppercase.
// Works
fetch('https://dummyjson.com/products/1', {
    method: 'PATCH',
    headers: { 'Content-Type': 'application/json' },
    body: JSON.stringify({ title: 'Test' }),
  })
    .then((res) => res.json())
    .then(console.log)

// Doesn't work
fetch('https://dummyjson.com/products/1', {
    method: 'patch', // <-- lowercased
    headers: { 'Content-Type': 'application/json' },
    body: JSON.stringify({ title: 'Test' }),
  })
    .then((res) => res.json())
    .then(console.log)

// Works
fetch('https://dummyjson.com/products/1', {
    method: 'put', // <-- also lowercased, but it works
    headers: { 'Content-Type': 'application/json' },
    body: JSON.stringify({ title: 'Test' }),
  })
    .then((res) => res.json())
    .then(console.log)

📝 Checklist

[ ] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

THanks for pr. Do you have any reference about patch exception?

https://fetch.spec.whatwg.org/#methods

I can confirm patch exception - it's an unfortunate inconsistency and has been at the bottom of several 'bugs' I investigated.


git lib - ability to get the upstream branch

It would be great to get the upstream remote/branch for a given local branch so the user knows what they would be pushing to by default.

Closing. The discussion continues in #5677, no reason to keep this open.


URL Update Stucked

I Harshdeep. The app has suddenly stopped updating URLS. It stops at Fetching access token. I have tried on a fresh clone and it still doesn't work.

Yeah I just saw that too, being actively worked on. For now, you can update the URLs manually

This throws a 502 so pretty sure a CDN is just having a temporary issue^
The introspection endpoint returned a 502: https://accounts.shopify.com/oauth/introspection

This is fixed. If it doesn't work, run shopify auth logout and then run npm run update:url again. This should prompt you to login again and it'll work as expected.


Support for multibranch pipelines outside of GitHub org that use GitHub repo and app credentials

What feature do you want to see added?
I have a very large org, 1000+ repositories.  In this org, we have many teams where each team is grouping their multibranch pipeline projects into folders and each one uses GitHub repo as a source.  This works well since each team creates a project that maps to their repo and there's no coupling between them and no opportunity to potentially misconfigure discovery and ingest 1000+ projects into Jenkins.
This also reduces the load on the API when projects changes are applied since each projects triggers a rescan of that repo, not of the entire org.
I'd love to start using checks API but to do that I would need to roll all these projects under a single org in Jenkins and manage 1 config for them all which is very problematic at the org our size.  What also complicates things is that we have multiple jenkins projects mapping to a single repo but using different Jenkinsfile and job configuration. This allows us to run different workloads on different triggers and maintain simple pipelines from a single repo that logically maps to these jobs.  Think 3-4 projects in a repo, 1 that supports PR pipelines, 1 to do maintenance and infra tasks, 1 to enable additional automation in other scenarios.
I would love to see support in this plugin where the projects can define SCM to be a github repo, using github app authentication, and be able to post checks but not have to be discovered through a github org, since that imposes a lot of restrictions on structuring projects and forces me to adopt a very restrictive structure and frankly doesn't work for us.  This kind of flexibility would really unlock more adoption by larger organizations that have large GitHub orgs and have to manage API access rates.
Upstream changes
No response
Are you interested in contributing this feature?
No response

It doesn't require to be using a GitHub org, multi branch pipelines work just fine.
What makes you think it doesn't? Are you hitting an issue?

Yes, I am hitting an issue.  I am on plugin version 2.0.0.  This is the call I am making from the pipeline:
publishChecks name: 'PR Label Check', title: 'PR Label Check pending title', summary: 'PR Label check pending summary',
                    text: 'PR Label check description pending',
                    detailsURL: env.JOB_URL,
                    status: "IN_PROGRESS",
                    conclusion: "NONE",
                    actions: [[label:'Re-run', description:'Re-run the job', identifier:'rerequested']]

I am getting the following error:
[GitHub Checks] Failed Publishing GitHub checks: org.kohsuke.github.HttpException: {"message":"Resource not accessible by integration","documentation_url":"https://docs.github.com/rest/checks/runs#create-a-check-run"}

The job is using a github app for credentials in the branch source section.  Am I missing any additional configuration in Jenkins?

which plugin version at 2.0.0? github checks doesn't have a 2.0.0 version I can see.

Resource not accessible by integration

This normally means the permissions on your app aren't right, see https://github.com/jenkinsci/github-checks-plugin#getting-started and make sure you've given it Read/Write on Checks

I have all of the permissions set at the required level, or higher.  Here's my app config permissions for the items mentioned in the guide:

Checks: read & write
Contents: read & write
Metadata: read
Pull requests: read & write

I have been using this app to post status checks from my jobs and make releases by minting a token from a private key and that works.  I am pretty confident the app is configured correctly.  Anything else I need to configure in the global Jenkins config?

status checks are different to checks, status only requires a personal access token.
How is your job configured for retrieving the pipeline?

The job is configured as:

GitHub branch source
Credentials: the github app with permissions set
Repository URL: https://github.com/...
Checkout over SSH using SSH private key credentials
Enabled: Skip GitHub Branch Source notifications in Status Checks to disable default Jenkins
Build configuration: By Jenkinsfile

possible to take a screenshot of the configuration? (redacting anything you aren't comfortable sharing)

Here are the screenshots of the config of all things that are non-default.  The branch source credentials are configured at the global scope as a github app.  The checkout credentials are also at global scope, username + private key type.
The job works, checkout works, Jenkins can scan the repo with the provided creds and discovers everything.  Note, the job is configured inside a folder, it is not associated with github org folder.
screenshot1

screenshot2

screenshot3

I've just tested this with a multi branch pipeline and it all worked fine for me:

Repo: https://github.com/timja-org/junit-attachments-test/pull/5

Thanks for trying this out.  So, what else remains that could be different between your environment and mine?  The app config in Jenkins?  The app permissions on GitHub?  Anything else that you can think of?

Normally its either that the app hasn't been installed properly (i.e. install hasn't been clicked on the app after creating) or missing permissions..
Have you tried validating the app by clicking I think it's 'Test connection' on the Jenkins credential side.

Yes, when I click "Test connection" it works.  I also see Jenkins say it is using it to scan the repo when I change the config of the job and that works so that suggests the app credentials are working.  This is from the repo rescan log:

I followed the directions from the page referenced above, including this step to convert the key:
openssl pkcs8 -topk8 -inform PEM -outform PEM -in key-in-your-downloads-folder.pem -out converted-github-app.pem -nocrypt

I wonder if there is some other set of permissions that is preventing the app from accessing the API.  I didn't create the app, it was made for me by my org admin but I can manage it's config which is how I can access and change permissions on it.  There is obviosly a detail somewhere in here that is making a difference.

Your permissions look fine, for reference this is what mine looks like but I can't see anything important in there:

Solved!
I ended up reaching out to my org admin for a consultation and turns out that when I changed GH app permissions, that triggers an approval process on admin side and until they click to approve, the app is not granted the necessary permissions.  The terrible UX part on GitHub side is that there is no mention of a pending approval in the UI, the app settings show the permissions despite them not being in effect.  Once my org admin approved the change, this works now.
Moral of the story, if you're using an app in an org where an admin created the app and gave you control permissions, make sure they approve any permission changes first, or this integration will not work.


Add Redis-backed cache implementation

This is based on the github.com/go-redis/redis library and pins the version to v3 on gopkg.in. The tests are an exact copy of the Memcache unit tests and all are passing.

Thank you for your PR.

Oh wow – that was fast!
Thanks! 👯


Assert triggered in OnionPacket.d:169

We have the following path:
https://github.com/bpfkorea/agora/blob/93b4db119f8809b7cb8681c9f7db098232dbf2d1/source/agora/flash/Node.d#L891-L897
And getPaymentPath may return null. However the above code doesn't handle it, and we later hit an assert:
https://github.com/bpfkorea/agora/blob/93b4db119f8809b7cb8681c9f7db098232dbf2d1/source/agora/flash/OnionPacket.d#L169
This is "possibly a timing issue" according to @AndrejMitrovic (seems to trigger more often on OSX machines which are indeed slower), and can be observed frequently in the CI.

Do we have a full stack trace? Multiple tests could trigger that.

https://github.com/bosagora/agora/blob/309989a54529ec708ecab235547662aabdc5740d/source/agora/flash/OnionPacket.d#L172

Looks like this isn't fixed yet.

Does it say which line in the test file it's coming from?

Unfortunately there's no more log than what you see above :(
It's currently still running: https://github.com/bosagora/agora/pull/1850/checks?check_run_id=2232746880

I think we should remove that assert anyways and propagate the failure to the caller.

Making a PR soon for it.

If this doesn't happen again in the next few days then we can close it.

If this doesn't happen again in the next few days then we can close it.

It didn't.


Some help on download setting.

so I´ve been using this app for a while now, and it´s working great for me. Some issues I still need some help.

in Tumblr there seems to be 'webp' files, how can I save these files (what settings I need to put on) ?
I searched info about the issue: blog is hidden, is there some workaround to help getting those blogs downloaded also (tried setting the one value to 1 but no help there)

It's great to hear that you like TumblThree. Give it a star.

I don't know many blogs that have webp photos. If they are uploaded and used in the official photo structures they should be downloaded without problems. Embedded images (hosted on other platforms) can be downloaded by activating "search for image patterns".
If you have an appropriate/safe blog whose Webp aren't downloaded you can post it (or email), maybe we can find and fix something.

Hidden blogs should be handled automatically. Normally you can see the difference by type "Tumblr Hidden" and the file extension "tmblrpriv".

Ok, now all seems to work just fine, hidden blogs also download perfectly, needed a log in, also needed to make some adjustments to settings. Thank you very much !


Issue creating model with an association

I have created a simple phoenix application (Ecto 2.0) with a simple Role model and a User model that belongs to a role.
I followed the steps for setting up ExAdmin (I use ExAdmin module from Github) with no customization, everything seems to be working fine but when I add a User and associate it to a role, no association is created.
Phoenix traces when creating a User that belongs to a Role:
[info] POST /admin/users
[debug] Processing by ExAdmin.AdminResourceController.create/2
  Parameters: %{"_csrf_token" => "HgpGMBNqN2Yibm5oK3Z4HykzDQdEJgAAHG+RP3cUHZ6/c/4TmPAssg==", "commit" => "Create User", "resource" => "users", "user" => %{"email" =><EMAIL_ADDRESS>"role_id" => "1"}, "utf8" => "✓"}
  Pipelines: [:browser]
[debug] QUERY OK db=0.1ms
begin []
[debug] QUERY OK db=0.6ms
INSERT INTO "users" ("email","inserted_at","updated_at") VALUES ($1,$2,$3) RETURNING "id"<EMAIL_ADDRESS>{{2016, 10, 16}, {7, 4, 2, 0}}, {{2016, 10, 16}, {7, 4, 2, 0}}]
[debug] QUERY OK db=0.7ms
commit []
[debug] QUERY OK source="users" db=0.8ms
SELECT u0."id", u0."email", u0."role_id", u0."inserted_at", u0."updated_at" FROM "users" AS u0 WHERE (u0."id" = $1) [2]
[info] Sent 302 in 3ms
[info] GET /admin/users/2
[debug] Processing by ExAdmin.AdminResourceController.show/2
  Parameters: %{"id" => "2", "resource" => "users"}
  Pipelines: [:browser]
[debug] QUERY OK source="users" db=0.6ms queue=0.1ms
SELECT u0."id", u0."email", u0."role_id", u0."inserted_at", u0."updated_at" FROM "users" AS u0 WHERE (u0."id" = $1) [2]
[info] Sent 200 in 3ms

Am I missing something?
Here's the sample project: https://github.com/ronanh/test_exadmin

I have an exactly same kind of problem. Any idea where this behavior come from?

try adding :role_id to your Users's changeset function cast call here: https://github.com/ronanh/test_exadmin/blob/master/web/models/user.ex#L16


chore: improve cSpell overrides CI message

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[x] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of “no breaking changes
[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

@ruowan any reason why Avocado is failing even with no spec files changed? Can't see the test run

@ruowan any reason why Avocado is failing even with no spec files changed? Can't see the test run

It's an known issue when updating non-swagger file. I will fix it later.

It's an known issue when updating non-swagger file. I will fix it later.

Thanks @ruowan is this good to merge then?

Thanks @ruowan is this good to merge then?

@PhoenixHe-msft @zhenglaizhang  Could you pls help to review this PR? Is there any impact for unified-pipeline?

@PhoenixHe-msft @zhenglaizhang  Could you pls help to review this PR? Is there any impact for unified-pipeline?

/azp run

@PhoenixHe-msft @zhenglaizhang @ruowan it would be good to land this to avoid things like https://github.com/Azure/azure-rest-api-specs/pull/13703

@zhenglaizhang to move this to unified pipeline

@nschonni Thanks for your contribution. We are planing to move the spell check task to our unified pipeline.   And this file will be deprecated.

@ruowan is that happening very soon? Otherwise this might be good to land till it is switched over


dart:j2 - Cross-frame native objects are always proxied in dart2js, but transferred directly in Dartium

This issue was originally filed by<EMAIL_ADDRESS>
0.8.10_r30107
Windows 7x64
The documentation of dart:js states:
"The following types are transferred directly and not proxied:
...
Blob
..."
What I am seeing is that they are transferred directly in Dartium (VM) but still proxied in dart2js compiled javascript (Chrome Beta).  This is causing me problems.  I don't have an isolated repro handy but I could make one if need be...
thanks,

Bumping into this exact same bug with a multi-window dart chrome app. If I was writing this in native code, sharing common objects between windows would be trivial. Here in Dart Land its nearly impossible. I am currently trying to abuse js-interop but having little luck.

I want to share a EventBus across multiple windows in the same chrome app, but having little luck.

This frustration is REALLY making me think of moving to TypeScript when 2.0 hits as they will add Async and Await support. Right now dart is really lacking on the chrome app usability front.

Also the browser already enforces security on this front, and added complication just makes writing dart apps more futile. This adds nothing to security. I've wasted 3 days looking for a workaround.


fix test config for min-blob-size

Add an uint64 test flag min-blob-size for Titan in titandb_bench and titandb_stress tests.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Codecov Report

Merging #10 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #10   +/-   ##
======================================
  Coverage    84.9%   84.9%
======================================
  Files          40      40
  Lines        2047    2047
======================================
  Hits         1738    1738
  Misses        309     309

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05a3755...bf6e2a3. Read the comment docs.

PTAL @Connor1996

PTAL @Connor1996


Check for CodeBuild Project encryption is not disabled

This check validates that encription on any artifact produced by the Code Build Project pipeline is not disabled.
Warning is reported when Code Build Project does not produce any artifacts but the encryption is still disabled
Closes #185

Hey @tomekbielaszewski  - apologies for the delay in reviewing, I've got behind - can you re ID this as AWS080 please then can merge


Remove ISSO_CORS_ORIGIN and references

Reason for revert: This feature never worked.
See discussion in #720

(including @Lucas-C and trying to find someone to convert explanations from #720 into docs)


Add support for Stable Diffusion

What does this PR do?

This PR adds optimized support for Stable Diffusion inference on Habana Gaudi.
Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


ROX-11059: Move environment.Environment to common.

Description
This is the first PR in a series of PRs to finish the migration of roxctl to use Environment.
This PR will be a pre-factor, moving the environment.Environment to common.Environment, due to the fact that the common and common/flags package is pretty much intertwined and will result in cyclic imports once the migration is done.
Which PRs will follow after this:

Use Logger instead of fmt.*Print to write output (#1964).
Move remaining errors from errros.New*/fmt.Errorf to errox sentinel errors (#1965).
Enabled forbidigo to verify neither fmt.*Print/os.Stdout/os.Stderr is used within roxctl.

What would be a generic follow-up for this PR:

Re-organize the common pkg and create independent packages, such that the environment can live in its own package and the flag package can also be migrated to the environment without introducing cyclic imports.

@janisz I've split up the changes into four PRs as suggested, PTAL once more (comments should be addressed within the other PRs).


Use lazier alternatives to count() in Transaction methods where possible

Motivation
Some functions like check::has_inputs_and_outputs in the transaction verifier or check::anchors::sprout_anchors_refer_to_treestates in the state service are accessing more data than is required to compute their result.
It would be faster to use next().is_some() or joinsplit_data.rest.len() + 1 in those cases, map(Vec::len).sum() for getting the nullifier counts for metrics, etc.

Rust is pretty good at optimising iterators. Have you checked that these extra data accesses actually happen in production? Is the performance of this code actually impacting Zebra's performance?

Is the performance of this code actually impacting Zebra's performance?

Not a chance, there are far too few transactions for it to matter.


unable to debug

When I run "sudo google-drive-ocamlfuse -debug ~/google-drive"
I get
"google-drive-ocamlfuse -debug ~/google-driveError: Mountpoint /home/dragondon/google-drive should be an existing directory."
but that IS the directory.
My initial mount command is:
"google-drive-ocamlfuse ~/google-drive"
I'm running this on ChromeOS under Crouton.
I am having syncing issues(as in it ocamlfuse grabs the GDrive initially fine but suddenly it won't update/sync.  I've made changes in Google Drive elsewhere but it's not reflecting any of those updates, despite them being synced between my ChromeBox and Google Drive).  I went to enable the debug option to check but ran into a debug problem(go figure...).
I can view new GDrive folders without any issues but it seems to only do this once and will update GDrive if I create a new folder but it's not grabbing anything after that.
I've restarted the system but it still isn't syncing.

It looks like an issue similar to this one. You should check that your dragondon has the same idenitity inside and outside the chroot.

Seems that it was a permissions thing as "See #624 for a fix: first sudo enter-chroot, then sudo chown -R 1000:1000 "$HOME"." solved the issue.
Thanks!


Update CUDA.gitignore

Reasons for making this change:
TODO
Links to documentation supporting these rule changes:
TODO
If this is a new template:

Link to application or project’s homepage: TODO

Closing this out due to inactivity.
@fgragpp if you're still interested in submitting this contribution, please open a fresh pull request and address the outstanding questions from this review.


Multiple keyrings

Hi guys, I was wondering if it is possible to import two different keyrings with different pass phrases. For example if I imported private key into keyring with one pass phrase and after that I want to import another private key with another pass phrase, is this possible? For now if I try to set another pass phrase for keyring it says that "Error: HMAC does not match! LocalStorage modified?".

We only support a single passphrase, if you need to have multiple secret keyrings (with differing passphrases), you could use E2E in different browser profiles.

@koto OK, thanks a lot for your response!

@koto As I saw there is a local storage key where the keyring is stored... this key is "UserKeyRing". Maybe if I add something (for example current user email) to this key then I would have different keyring, right?

Well, you can do anything really, it's open source, but we won't support multiple keyrings. You might have  to reengineer the code to make ContextImpl compatible with multiple keyrings or have some sort of keyring switching mechanism.

Thanks @koto for your response. It would be great to have multiple keyring support, cos computer may be used by multiple users (for example family or roommates) and they also can use one browser account (or no account at all..), so this means that all of them will have access to each others private keys....

Shared browser profile is definitely not the recommended approach, and the one we do not design for.  Browser profiles provide the least amount of separation needed. Shared computers are not such a good idea too to protect your private keys (other user can just install a keylogger).

Well, here in Ukraine there are a lot of users that do not care about browser profiles (university labs, students in hostels, etc..) :) OK, thank you, security is everything! :)


Could you make respective release for XNA v1.0/v2.0/v3.0/v4.0?

On some systems, it is impossible to instail all those versions of libraries.
In fact, most of the time we only need one version.
However, current release won't work unless all of the above libraries are installed.

I realize this comment is really old, and that this project is completely dead, but for anyone else wanting to get around this issue, you can just delete/move the Alba.XnaConvert.Loader.XnaXX.dll files you don't need out of the folder where the Alba.XnaConvert.exe program is, and it'll work just fine.
So if you're trying to get at XNA 4.0 files, leave only the Alba.XnaConvert.Loader.Xna40.dll file behind.

Thanks for the workaround anyway.

Ugh, how on Earth this still fails? I specifically coded the executable in a way to avoid loading libraries which aren't requested. Need to test this further. Especially now that I don't have all XNA libraries installed on dev machine.


(De facto) Remote control with carb inputs whilst remote control is disabled

Not sure if it ought to be considered an issue, but it's always surprised me a bit that it works this way. So opening an issue for discussion/perhaps additional (optional) security measures:
iAPS imports carb entries from Nightscout and adds them to the COB on the next loop. It adjusts predictions accordingly and under some circumstances it may start (significantly) raising basal or starts administering SMB's (or enables SMB for people who have it set to enable "after carbs" or "with COB"). Abstractly, you could argue that this is a form of Remote Control. This works whilst Remote Control is disabled in the iAPS settings - iAPS will accept the entered carbs and act accordingly. Of course also the bolus suggestions and such change.
I personally do not want Remote Control for boluses enabled, but I find adding carbs through NS to be extraordinary useful as I use another app that contains my Food Database to calculate all carbs, feed them (no pun intended) to Nightscout and iAPS subsequently imports them. Super useful. So I like "remotely" entering carbs, but do not want the ability to remotely bolus (despite my Nightscout not even being available on the internet.). (So by opening this issue I might be shooting myself in the foot, but safety first. :P)
From a security perspective, imho, you:
1.) Should first have to enable Remote Control before iAPS will accept carbs from NS to be taken in to account
2.) But ideally: there will be an option to only accept carbs or to accept carbs and remote bolus.

I don't think we need more settings.
The adding carbs from Nightscout has been used since the day of FreeAPS X and is used by many users. I don't think we need to limit this feature with an added setting. I agree it's convenient to use with shortcuts .

Ok, then maybe we just need to add a note in the documentation that this could be a problem on open Nightscout instances. (Along with the other issues having it open on internet facing servers :P)


Unknown exception thrown when running detekt

Expected Behavior
Expected detekt to finish without any exceptions thrown
Current Behavior
Currently when running detekt, after enabling a rule, not sure which one, we get the following exception stacktrace:
Analyzing '/path/to/the/file.kt' led to an exception.
Running detekt 'unknown' on Java '1.8.0_131-b11' on OS 'Mac OS X'.
Please create an issue and report this exception.
java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273)
java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280)
java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1592)
java.util.concurrent.CompletableFuture$AsyncSupply.exec(CompletableFuture.java:1582)
java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692)
java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157)

The exception above is the result of enabling one of the latest rules we enabled, will probably do a git bisect to find which one, but I am reporting it in case you already know what is wrong so that I could resolve it sooner :D
Before enabling that rule it was running without exxceptions being produced.
Steps to Reproduce (for bugs)
Not sure on that one, I am still trying to figure out the exact repro flow.
Context
We are incrementally enabling more and more detekt rules and one of those caused the above exception.
Your Environment

Version used: 1.0.0.RC8
Operating System and version: macOS Sierra (10.12)
Link to your project: It's a private project.

Update: I tried to manually disable every rule that we have introduced in the branch that it stopped working and had no luck. Also tried reverting to RC07-2 and it was not resolved either. LMK if I need to provide any more info!

Do you have to stau at a beta version of jdk8 ? -> '1.8.0_131-b11'.
In detekt-core we leverage the CompletableFuture Api from java which should be fine.
Maybe an error in beta version of jdku8. Can you upgrade and test with a recent jdk8 please?

I tried upgrading but the Java client did not show any available update for macOS. Is there another way to check that?

It keeps on crashing even o JDK 10.
Running detekt 'unknown' on Java '10.0.2+13' on OS 'Mac OS X'.

Just tested it with java 10u23-openjdk with sdkman. Worked.
Which rules have you enabled lately, which may cause this error?
Is this the whole stacktrace? Because it does not show any detekt related stack traces.

Unfortunately this is the only stacktrace. Also as I said before i tried disabling all rules after bumping to rc08 but did not work...will try some older rules to see if it is resolved.

Update
So, I ran a git bisect to find the offending commit and ended up finding that it was when we enabled LateinitUsage rule. But just disabling it was not enough. I noticed that turning active: false instead of true would still cause a crash on some files.
The thing though was that we have modified the rest of LateinitUsage rule's properties like the following:
LateinitUsage:
    active: false
    excludeAnnotatedProperties: ""
    ignoreOnClassesPattern: "*Fragment"

After removing *Fragment I found that it was no longer crashing. I am not sure why it would crash when it is disabled, but will definitely do a check on the code of that rule and let you know if I find something.

Wow, that's actually scary :D. We create every rule upfront, filter the active ones and throw inactive ones away. Therefore we also initialize everything...
The design decision is here:
interface RuleSetProvider {
    	fun instance(config: Config): RuleSet
}

Every provider creates it's own RuleSet and inits all rules.
Every Rule must have an ID which is used for filtering and which is created on object construction.

solution would be to lazily instantiate all rules by kind of static ids and reflection or factory methods with a DI framework -> much rework, idk if it is worth it as our "garbage" creation is cheap + a detekt run does not live long
or 2. solution create a by regex delegation function which lazily instantiates and evaluates regexes. This could be a function inside the Rule class.

@arturbosch solution number 2 sounds a lot more easy to remember and use :)

@arturbosch shall this be closed once a release containing the fix is out?

I am closing this issue since the fix has been merged into master. :)


Update mac package to error on unsupported version

Steps to reproduce
Install mac package on macOS 10.11
Expected behavior
A friendly message that the package is only supported on 10.12 ( or similar)
Actual behavior
The package installs fine and errors when you run powershell
Details
https://developer.apple.com/library/content/documentation/DeveloperTools/Reference/DistributionDefinitionRef/Chapters/Distribution_XML_Ref.html#//apple_ref/doc/uid/TP40005370-CH100-SW33
https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man1/productbuild.1.html

/cc @TravisEz13

@chunqingchen Have you started working on this?


Fixed handling and formatting of empty requests and responses

Pull Request Checklist

[X] Make sure to read the contributor guide here.
[X] Make sure you are making a pull request against the staging branch.
[X] Make sure your pull request title matches the requested format.
[X] Make sure to lint, type-check, and run unit and API tests.

Description
Fixed handling of empty requests and responses

:tada: This PR is included in version 2.0.4 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


API client can view service route bindings for a route

Requirements
Expose service_route_bindings section in endpoints GET /v3/routes, GET /v3/routes/:guid, GET /v3/apps/:guid/routes
Example response body:
{
  "guid": "route-guid",
  ...
  "service_route_bindings": [
    {
      "guid": "c87ebef2-fd8d-462d-9825-228f3055ddf2",
      "service_instance": {
        "guid": "service-instance-guid",
      }
    },
    {
      "guid": "b8bcce07-efd4-474e-b051-bbdbab12b838",
      "service_instance": {
        "guid": "service-instance-guid",
      }
    }
  ],
}

Acceptance Criteria
Given Logged in with sufficient permissions
And A route exists with guid route-guid
And It is mapped to some service instance
When API client GET /v3/routes/:route-guid
Then a service route binding section is returned as part of the response object, populated as appropriate

✍Docs 📝
Given browsing https://v3-apidocs.cloudfoundry.org
When viewing Routes > List routes, Routes > Get a route, and Routes > List Routes for an app
Then  this field is documented

Decided against this, going to close it out


Questions about training AN4 dataset

I followed the installation guide and tried to run Train.lua on AN4 dataset.
But the results I got was quite strange, the Average Loss turned out to be a huge number, while WER and CER were also larger than 100. (In my understanding, it should be a percentage number which is less than 100).

I didn't make any change on code. So I am really confused about it...
Another question is that, from the DS2 paper CER refers to 'Characer Error Rate' for the Mandarin system, so what is CER here refers to?
Thanks for any advise!

Could you let me know what OS/GPU you are using?

The OS is Ubuntu 16.04.1.
GPU is NVIDIA GTX 1080.
Thanks for reply!

Yeah I had the same issue as you, you need to install warp-ctc a bit differently on pascal cards, check here and try installing this branch instead, and restarting training!

Yes, it works now. I finally got WER = 18, and CER = 3.88 on AN4 dataset.
Thank you!

Great stuff!


IllegalAccessError when load a class in other jars like spark or iceberg

Backend
VL (Velox)
Bug description
Error like
User class threw exception: java.lang.IllegalAccessError: tried to access class org.apache.iceberg.spark.source.SparkBatchQueryScan from class org.apache.iceberg.spark.source.GlutenIcebergSourceUtil$

Spark version
None
Spark configurations
No response
System information
No response
Relevant logs
No response

The root cause is the that Gluten needs to access default or protected classes or class members from other jars like spark or iceberg. Error occur when the jar is sealed. Solution is to remove the sealed feature of the jar


fix(@angular-devkit/build-angular): pin clean-css

We need https://github.com/jakubpawlowicz/clean-css/issues/1050 to be fixed before updating to 4.2.x.
Fix #12408

Does this break anything else?

Doesn't seem to break anything we test.

@filipesilva PR Target?

@hansl none actually, I should have closed this.


Implement array to array broadcasting in assignment

Current coverage is 87.13% (diff: 88.88%)

Merging #2126 into master will decrease coverage by <.01%

@@             master      #2126   diff @@
==========================================
  Files           305        305
  Lines         55997      56049    +52
  Methods           0          0
  Messages          0          0
  Branches       5800       5805     +5
==========================================
+ Hits          48792      48836    +44
- Misses         6265       6270     +5
- Partials        940        943     +3

Powered by Codecov. Last update 6b17b3e...e902950

Great! I'm merging this.