Multiple tasks don't prompt user

When having multiple tasks defined, I would expect a list for me to choose from when I press ctrl+shift+b. Instead, it only runs the first build task (if "isBuildCommand": false it skips to the next build task) and stops.
tasks.json
{
    "version": "0.1.0",
    "command": "cmd",
    "isShellCommand": true,
    "showOutput": "silent",
    "args": ["/C"],

    "tasks": [
        {
        "taskName": "Build CustApp",
        "suppressTaskName": true,
        "isBuildCommand": true,
        "args": ["${cwd}/Sw/A_XMC/make_all.bat"]
        },
        {
        "taskName": "GTAGS",
        "suppressTaskName": true,
        "isBuildCommand": true,
        "args": ["gtags"]
        }
    ]
}

Oh, I see my confusion. I was thinking of the behavior of workbench.action.tasks.runTask which actually prompts a list of all tasks.
Though I still stand by my first post, since I feel this should be the behavior even for workbench.action.tasks.build. That if there a multiple build tasks available, user should be prompted by a list.

Still feel this is expected behaviour. Any plans to move this into a milestone?

This will come for the new terminal task runner and is on the list, but with a slightly different behavior. When more than one task is marked as a build task all of them will be executed since the terminal runner support executing more than one task in parallel. If you want to execute a specific task use Run Task.

Then I consider this closed.


[GitHub] Validate Code Owner Account

Summary
The focus of these changes is to add a script that validates a GitHub account is a valid code owner, according to the Azure SDK onboarding requirements. In addition, the legacy issue tooling has been removed, as it has been replaced and is no longer used.

/check-enforcer override


(LogFusion) Moving to core packages, along with an update script

This should be all set from my end.

You are really detailed...It's done.

You are really detailed...It's done.

I try to be.
As with the voicebot pr, I think you misunderstood me here.
I didn't mean for you to remove the whole au_SearchReplace function, only the line that replaces the $installer variable.
Could you please update again.
Have you gotten permission to migrate this package to this repo?
/cc @The-Running-Dev


IGNITE-13865 Support  DateTime as a key or value in .NET and Java

Currently, .Net type DateTime can't be used as a key or value in the cache in a way that Java will read values in java.util.Date.
This PR fixes it with the new flag BinaryConfiguration#ForceTimestamp.
Currently existing BinaryReflectiveSerializer#_forceTimestamp becomes obsolete.
The Contribution Checklist

[ ] There is a single JIRA ticket related to the pull request.
[ ] The web-link to the pull request is attached to the JIRA ticket.
[ ] The JIRA ticket has the Patch Available state.
[ ] The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
[ ] The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
[ ] A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
[ ] The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

How to Contribute
Coding abbreviation rules
Coding Guidelines
Apache Ignite Teamcity Bot

If you need any help, please email<EMAIL_ADDRESS>or ask anу advice on http://asf.slack.com #ignite channel.

@ptupitsyn I fixed your comments. Please, take a look one more time.


Aspiring Contributor Questions

Hello :slightly_smiling_face:, I would like to contribute to accesskit, but I'm a bit unsure where to start. There are some older issues from 2021 that seem doable. I don't want to ask too much labor from maintainers, so I have two quick questions:

Could accesskit use a (very part time) contributor? (No is okay!)
If so, can someone point me to a good starting issue that no one else is not currently working on for me to try my hand at? Something not super important :laughing:?

If there's anything documentation-oriented I would love to do that. Even if there's no issues, I'd be happy to go through and write tutorials/examples, if that would be useful.
Thank you!

Hi @maniyar1. Thanks for your interest in contributing. It would help to know what previous experience, if any, you have with accessibility, native desktop APIs (e.g. Win32 and Cocoa), or both. Thanks again.

I have experience writing accessible web interfaces using semantic HTML + Aria tags. I have a testing setup for that, which obviously involves a screen reader and adjacent technology. I try to keep up with UX design elements on that side of things. I have experience in Rust, but not really any substantial experience with native desktop APIs. I mostly work on the Linux side of things, so my experience is with x11/wayland/gtk/qt. But even that experience is mostly as a user. I also have a writing background, wherever that is useful.

I'm afraid the remaining open issues from 2021 are things for someone who's familiar with UI Automation and Windows screen readers. They're on my roadmap for sometime this year.
But here's an idea: identify a GUI toolkit that isn't yet accessible, implement AccessKit support in that toolkit, and document the process. We need more documentation, and a document describing the process of making a GUI toolkit accessible from scratch would be especially useful. It could be a Rust, C, or C++ toolkit (we don't have a direct C++ API yet, but we do have a C API).
It would probably be better to do your testing on Windows or macOS if you can. The Linux backend is not as complete as the other two.

Sounds good! I will try my hand at that. I'll close this issue and open a new one for that specifically, if that sounds good?

OK, I'm closing this issue. Feel free to open a new one.

Hi @maniyar1, thanks for stopping by.
One of my short-term projects is to integrate AccessKit into kivy to demonstrate the capabilities of our Python bindings.
If you'd like a guided introduction to AccessKit, we could work on this together. If you're interested or if you have questions on that, feel free to reach out to me directly either on Discord (same username) or via email (available on my GitHub profile).
If you prefer to experiment on your own, it's also fine!


Best model path returns nothing and best model score is none

🐛 Bug
I am currently using lightning 1.5.0dev (Master) and configuring model checkpoint and doing the training as described in the docs. However, the checkpoint best_model_path returns nothing and the best_model_sccore is None.
To Reproduce
 continues training
# ------------------------
checkpoint_callback = ModelCheckpoint(
    dirpath=f"{hparams.output_path}/checkpoints/",
    save_top_k=hparams.save_top_k,
    verbose=True,
    monitor=hparams.early_stopping_metric,
    mode='max',
    #prefix=hparams.name,
    filename=f'{{epoch}}-{{{hparams.early_stopping_metric}:.2f}}'
)
early_stop_callback = EarlyStopping(
    monitor=hparams.early_stopping_metric,
    min_delta=0.00,
    patience=3,
    mode='max')

trainer = Trainer(
    #fast_dev_run=True,
    gpus=hparams.gpus,
    logger=logger,
    #fast_dev_run=hparams.fast_dev_run,
    min_epochs=hparams.min_epochs,
    max_epochs=hparams.max_epochs,
    #checkpoint_callback=checkpoint_callback,
    checkpoint_callback = True,
    resume_from_checkpoint=hparams.resume_from_checkpoint,
    callbacks=[early_stop_callback],
    weights_summary='full',
    num_sanity_val_steps=hparams.num_sanity_val_steps,
    log_every_n_steps=hparams.log_every_n_steps
)
# ------------------------
# 4 START TRAINING
# ------------------------

trainer.fit(module)
print(
    f"Best: {checkpoint_callback.best_model_score} | monitor: {checkpoint_callback.monitor} | path: {checkpoint_callback.best_model_path}"
    f"\nTesting..."
)
trainer.test(ckpt_path=checkpoint_callback.best_model_path)

Hi @MeganClark-Robinson!
The fastest way for us to be able to help you is if you can adapt this script to reproduce the behaviour you are seeing.
Otherwise, it's really hard for us to help you by just looking at that snippet :)
It will also be helpful if you link to the docs you are following.

checkpoint_callback needs to be bassed to the callbacks argument in the trainer. from your script, it's not passed in anywhere, so its fields aren't populated

checkpoint_callback needs to be passed to the callbacks argument in the trainer. from your script, it's not passed in anywhere, so its fields aren't populated

Thank you so much for your help

Hi @MeganClark-Robinson!
The fastest way for us to be able to help you is if you can adapt this script to reproduce the behaviour you are seeing.
Otherwise, it's really hard for us to help you by just looking at that snippet :)
It will also be helpful if you link to the docs you are following.

Thank you so much. Actually I passed checkpoint_callback to callbacks argument and it works.


Filter - Not

In gitlab by @sfalquier on Apr 28, 2017, 11:09
negative filter by prefixing with "-"

In gitlab by @sylvaingaudan on Apr 28, 2017, 13:53
added ~1918909 label

In gitlab by @sylvaingaudan on Apr 28, 2017, 13:46
changed milestone to %4

In gitlab by @sylvaingaudan on Jul 12, 2017, 13:43
removed milestone

In gitlab by @sylvaingaudan on May 5, 2017, 11:10
added ~1918908 and removed ~1918909 labels

In gitlab by @sylvaingaudan on Aug 10, 2017, 08:30
removed ~2424200 label

In gitlab by @sfalquier on Sep 15, 2017, 11:00
removed milestone

In gitlab by @sylvaingaudan on Sep 11, 2017, 11:48
changed milestone to %13

In gitlab by @sylvaingaudan on Jan 2, 2018, 10:41
Not applicable anymore.

In gitlab by @sylvaingaudan on Jan 2, 2018, 10:41
closed


can not work well with storm 1.0.2

my storm version is 1.0.2, when i use the commad : petrel submit --config topology.yaml wordcount ,the spout and bolt can not work well.i wonna ask if the current version of petrel can not support storm 1.0.2?
please help me ~

the error message as follows:
ava.lang.RuntimeException: org.apache.storm.multilang.NoOutputException: Pipe to subprocess seems to be broken! No output read.
Serializer Exception:
at org.apache.storm.utils.ShellProcess.launch(ShellProcess.java:91) ~[storm-core-1.0.2.jar:1.0.2]
at org.apache.storm.spout.ShellSpout.open(ShellSpout.java:94) ~[storm-core-1.0.2.jar:1.0.2]
at org.apache.storm.daemon.executor$fn__7990$fn__8005.invoke(executor.clj:604) ~[storm-core-1.0.2.jar:1.0.2]
at org.apache.storm.util$async_loop$fn__624.invoke(util.clj:482) [storm-core-1.0.2.jar:1.0.2]
at clojure.lang.AFn.run(AFn.java:22) [clojure-1.7.0.jar:?]
at java.lang.Thread.run(Thread.java:745) [?:1.7.0_79]

134237 [Thread-17-split-executor[3 3]] ERROR o.a.s.util - Async loop died!
java.lang.RuntimeException: org.apache.storm.multilang.NoOutputException: Pipe to subprocess seems to be broken! No output read.
Serializer Exception:
at org.apache.storm.utils.ShellProcess.launch(ShellProcess.java:91) ~[storm-core-1.0.2.jar:1.0.2]
at org.apache.storm.task.ShellBolt.prepare(ShellBolt.java:131) ~[storm-core-1.0.2.jar:1.0.2]
at org.apache.storm.daemon.executor$fn__8058$fn__8071.invoke(executor.clj:795) ~[storm-core-1.0.2.jar:1.0.2]
at org.apache.storm.util$async_loop$fn__624.invoke(util.clj:482) [storm-core-1.0.2.jar:1.0.2]
at clojure.lang.AFn.run(AFn.java:22) [clojure-1.7.0.jar:?]
at java.lang.Thread.run(Thread.java:745) [?:1.7.0_79]

20:14:58.300 [Thread-23-spout-executor[4 4]] ERROR org.apache.storm.daemon.executor -

Some suggestions:

Verify that you are running Petrel <IP_ADDRESS>.3 (The first 3 digits of the Petrel version must match the Storm version.)
Try running in local mode, with Petrel logging to the current directory: petrel submit --config topology.yaml --logdir $(pwd). This will write Petrel logs to the current directory. After it fails, you can examine those logs to figure out what happened.

thanks for your help, i can run the program in local model , it take 5~6mins to start up which makes me think the program broken down .the success info like these: But
535562 [Thread-27] INFO  o.a.s.d.executor - TRANSFERING tuple [dest: 2 tuple: source: split:3, stream: default, id: {}, ["away"]]
535562 [Thread-27] INFO  o.a.s.d.executor - BOLT ack TASK: 3 TIME:  TUPLE: source: spout:4, stream: default, id: {}, ["an apple a day keeps the doctor away"]
535562 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Processing received message FOR 2 TUPLE: source: split:3, stream: default, id: {}, ["an"]
535562 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Execute done TUPLE source: split:3, stream: default, id: {}, ["an"] TASK: 2 DELTA:
535563 [Thread-26] INFO  o.a.s.d.task - Emitting: count default ["an",154]
535563 [Thread-26] INFO  o.a.s.d.executor - BOLT ack TASK: 2 TIME:  TUPLE: source: split:3, stream: default, id: {}, ["an"]
535563 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Processing received message FOR 2 TUPLE: source: split:3, stream: default, id: {}, ["apple"]
535563 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Execute done TUPLE source: split:3, stream: default, id: {}, ["apple"] TASK: 2 DELTA:
535563 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Processing received message FOR 2 TUPLE: source: split:3, stream: default, id: {}, ["a"]
535563 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Execute done TUPLE source: split:3, stream: default, id: {}, ["a"] TASK: 2 DELTA:
535563 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Processing received message FOR 2 TUPLE: source: split:3, stream: default, id: {}, ["day"]
535564 [Thread-26] INFO  o.a.s.d.task - Emitting: count default ["apple",154]
535564 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Execute done TUPLE source: split:3, stream: default, id: {}, ["day"] TASK: 2 DELTA: 1
535564 [Thread-26] INFO  o.a.s.d.executor - BOLT ack TASK: 2 TIME:  TUPLE: source: split:3, stream: default, id: {}, ["apple"]
535564 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Processing received message FOR 2 TUPLE: source: split:3, stream: default, id: {}, ["keeps"]
535564 [Thread-26] INFO  o.a.s.d.task - Emitting: count default ["a",154]
535564 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Execute done TUPLE source: split:3, stream: default, id: {}, ["keeps"] TASK: 2 DELTA:
535564 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Processing received message FOR 2 TUPLE: source: split:3, stream: default, id: {}, ["the"]
535564 [Thread-26] INFO  o.a.s.d.executor - BOLT ack TASK: 2 TIME:  TUPLE: source: split:3, stream: default, id: {}, ["a"]
535564 [Thread-26] INFO  o.a.s.d.task - Emitting: count default ["day",154]
535564 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Execute done TUPLE source: split:3, stream: default, id: {}, ["the"] TASK: 2 DELTA:
535564 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Processing received message FOR 2 TUPLE: source: split:3, stream: default, id: {}, ["doctor"]
535564 [Thread-26] INFO  o.a.s.d.executor - BOLT ack TASK: 2 TIME:  TUPLE: source: split:3, stream: default, id: {}, ["day"]
535564 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Execute done TUPLE source: split:3, stream: default, id: {}, ["doctor"] TASK: 2 DELTA:
535564 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Processing received message FOR 2 TUPLE: source: split:3, stream: default, id: {}, ["away"]
535564 [Thread-15-count-executor[2 2]] INFO  o.a.s.d.executor - Execute done TUPLE source: split:3, stream: default, id: {}, ["away"] TASK: 2 DELTA:
535564 [Thread-26] INFO  o.a.s.d.task - Emitting: count default ["keeps",154]

# then i submit the program into the strom ,the spout and bolt all throw the exception:
java.lang.RuntimeException: org.apache.storm.multilang.NoOutputException: Pipe to subprocess seems to be broken! No output read. Serializer Exception: at org.apache.storm.utils.ShellProcess.launch( 	Wed, 14 Dec 2016 10:13:07

Some other suggestions for finding the problem:

Petrel writes logs, as noted above. If it's slow, see what's happening. Maybe you have lots of dependencies. Maybe your network is slow.
When Petrel and Storm runs in cluster mode, Petrel still creates logs. Look at those logs and see what is failing. There are many possibilities.
Try running a pure Java topology on your cluster. Does that work okay?

I'm afraid I can't walk you through every step of solving this. You will need some know-how with your system, Storm, and Python.
The book "Building Python Real-Time Applications with Storm" has more detailed information on Petrel log locations and may be helpful to you.

i am reading the book ~ it's a really good book, i have tried to submit a pure java topology into the storm cluster, it works well.
python 2.7
storm 1.0.2
petrel 1.0.2
centos7
by the way, where is the location of the petrel's logs?

On a cluster, I believe they are in the Storm Supervisor directory. The location of that directory should be shown in the regular Storm (Java) logs.

i just installed in the nimbus and not install petrel in the supervisor, i think that maybe occur that problem?and i find  :
[root@xiaoding01 wordcount]# tail -f petrel25929_virtualenv.log
New python executable in /tmp/petrel-20topology-1-1481685334/venv/bin/python2.7
Also creating executable in /tmp/petrel-20topology-1-1481685334/venv/bin/python
Installing setuptools, pip, wheel...done.
Running virtualenv with interpreter /usr/bin/python2.7
Installing thrift==0.9.3
Requirement already satisfied: thrift==0.9.3 in /usr/lib/python2.7/site-packages/thrift-0.9.3-py2.7.egg
Installing PyYAML==3.10
Requirement already satisfied: PyYAML==3.10 in /usr/lib64/python2.7/site-packages
Installing Petrel from local file petrel-<IP_ADDRESS>.3-py2.7.egg
Processing petrel-<IP_ADDRESS>.3-py2.7.egg
creating /tmp/petrel-20topology-1-1481685334/venv/lib/python2.7/site-packages/petrel-<IP_ADDRESS>.3-py2.7.egg
Extracting petrel-<IP_ADDRESS>.3-py2.7.egg to /tmp/petrel-20topology-1-1481685334/venv/lib/python2.7/site-packages
Adding petrel <IP_ADDRESS>.3 to easy-install.pth file
Installing petrel script to /tmp/petrel-20topology-1-1481685334/venv/bin

Installed /tmp/petrel-20topology-1-1481685334/venv/lib/python2.7/site-packages/petrel-<IP_ADDRESS>.3-py2.7.egg
Processing dependencies for petrel==<IP_ADDRESS>.3
Finished processing dependencies for petrel==<IP_ADDRESS>.3

upper log is produced in local model, i find it will take much time to  Installing setuptools, pip, wheel... and  my virture machine can not connected to the internet，it's a Local Area Network~is that made the start up time longer?

You might try installing the same Python libraries manually. If you're not connected to the internet, I don't know how those packages could install at all.
About Petrel and the cluster -- generally you won't install Petrel on the Storm worker machines, you just need Python 2.7 and virtualenv on each machine in the cluster. Petrel automatically creates a virtualenv and installs itself (plus other Python library dependencies) for each topology. Because the topology startup is doing all these things, there's a lot that can go wrong.
The supervisor directory should be printed at startup time. I think it's called "storm.local.dir". This is a base directory; the actual Storm directory is a level or two below. You should find log files much like the ones created by Petrel for a local topology.

This link may be helpful regarding storm.local.dir:
https://groups.google.com/forum/#!topic/storm-user/iwyTRjxbtM0

i would tell you a good news ,i can run the sample wordcount in my storm cluster,i installed all the libraries manually, then submit the jar into the storm again, it works well. thanks .
through this progress, may i give you some advices:
1、the log can be more details~e.g.show the network situation, the installing steps
2、provide additional scripts to install the libraries and keep petrel module independent, i think that would be more robust
at last , i have a question, that petrel supply some interfaces to intergrate kafka
finally,i very appreciate your kindness to solve my problems ,thx~

The log should show the Python installation steps. See the following part of the code. This is a bash script that sets up the Python environment, then starts Petrel: https://github.com/AirSage/Petrel/blob/master/petrel/petrel/package.py#L271-L314
What kind of network information would you like to see?

provide additional scripts to install the libraries and keep petrel module independent, i think that would make the project more robust

Please explain what you mean?

At last , i have a question, that petrel supply some interfaces to intergrate kafka

Since I don't use Storm at work, I am mostly maintaining Petrel these days rather than adding new features. But I'm open to PRs for useful enhancements. I assume you're familiar with the kafka-python library? It should be fairly easy to use that to write a basic Kafka spout.

i have read the Chapter 4. Example Topology – Twitter in the book, i have alreadly got the way to write a spout to get output stream from kafka, when i have a good knowledge of petrel, i think i would like to submit my code to your resposity, thx~

It sounds like your problem is solved. Closing this issue.


[Payment history] add "Request early cancelation" menu item to the Subscription page (UI)

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/43282
PROPOSAL: N/A
Tests

Log into the app
Make sure you have a control/collect workspace with an annual subscription
Navigate to the Subscription Setttings page
Check if the new menu item (Request early cancellation) renders correctly
Click on it and go through the cancellation process
Once the subscription is successfully cancelled, hange it to an annual subscription and try cancelling it again

[x] Verify that no errors appear in the JS console

Offline tests

N/A
QA Steps

Same as Tests section above

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome
Automatic
chrome_automatic-compressed.webm
Manual
chrome_manual-compressed.webm

iOS: Native

iOS: mWeb Safari
Automatic
https://github.com/Expensify/App/assets/44364829/cf24d46c-1c74-4a2b-83f6-17af807015c6
Manual
https://github.com/Expensify/App/assets/44364829/a7fc7a3e-e6a9-4823-8ebf-720611d843ac

MacOS: Chrome / Safari
Automatic
https://github.com/Expensify/App/assets/44364829/09b5057a-eb90-4e8f-a741-36afad1eacaa
Manual
https://github.com/Expensify/App/assets/44364829/bc0c142a-7886-4d5d-b823-b1a0ef50dc02

MacOS: Desktop
Automatic
https://github.com/Expensify/App/assets/44364829/3d6a5876-febc-4c32-ba8f-7417d66b10d8
Manual
https://github.com/Expensify/App/assets/44364829/24e30b1c-86e0-4c1b-9c72-39e6dee2718c

Screenshots seem to look pretty good.

@mananjadhav PR updated, conflicts resolved!

We've got some weirdness going on with the Done button on the second screen of the flows. Looks like it's not the right size for some reason. Also, is Done the right language to use here?

@dannymcclain right, the "Done" button's size was wrong, but after adding large prop to it (like @mananjadhav suggested) it matches the Submit button's style. When it comes to the language used, I just copied what was in the design doc, let me know if you'd like to change it!

@JKobrynski Should we move the placement of the Request early cancelation menu item button after the Retry payment?

Should we move the placement of the Request early cancelation menu item button after the Retry payment?

Oh good call. Yeah I think we should keep the option rows together below the button.
Also, the option rows should both be using the same icon color. Right now it looks like request cancellation is using an icon colored icon, while view payment history is using a success colored icon. Let's make them both the same using whatever color is the default (I think right now it's success).

@mananjadhav @dannymcclain menu item moved, icon color changed to success!

Can you share the entire screenshot? Thanks!

@shawnborton

Totally agree, I would think it would be the last item in the list. Also, the icon color looks off for some reason?

@JKobrynski One of the comments by @shawnborton was to put this as the last item in the list. @shawnborton We still want this right?

@mananjadhav reordered!

Thanks for the changes @JKobrynski. Waiting on the confirmation here before I can review this again.

Awesome! I don't feel too strongly that Request cancellation needs to go last in the order, but curious if @Expensify/design or @trjExpensify has an opinion there.

I don't have any strong feelings either on the order. 👍

Also don't have super strong feelings on the order, but the updated layout is looking good!

What's the latest on this one?

@shawnborton There is an ongoing discussion on Slack about it

We're working through this issue to hook up the backend in this PR: https://expensify.slack.com/archives/C036QM0SLJK/p1721118930136909?thread_ts=1720528232.854949&cid=C036QM0SLJK

Cool cool, sounds good!

@mananjadhav PR updated!

@JKobrynski Can you please resolve the conflicts?

@mananjadhav done!

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Menu not available on native

Android: mWeb Chrome
https://github.com/user-attachments/assets/1e733500-2b8e-466a-b3ca-363157239a81

iOS: Native
Menu not available on native

iOS: mWeb Safari
https://github.com/user-attachments/assets/eb1b306e-5c43-4946-8253-6da38f77f7a5

MacOS: Chrome / Safari
https://github.com/user-attachments/assets/5a6e32e4-43e4-4c3c-94d9-252a55b0f661
https://github.com/user-attachments/assets/c21c94e5-baed-4c79-8379-3cdcb27f6b62

MacOS: Desktop
https://github.com/user-attachments/assets/cbabc4ed-77ee-4fb3-b219-6d25a012ba5e

I will review this pr and test it locally by the end of my work day today.

@blimpich regarding cancellationType being optional, I am not sure we can make it a mandatory field, as in that case we would have to provide it in successData. What do you think?

@blimpich about the video that you've posted, is it possible that you have an ongoing manual cancellation? I wasn't able to reproduce this on my end

@blimpich regarding cancellationType being optional, I am not sure we can make it a mandatory field, as in that case we would have to provide it in successData. What do you think?

Lets discuss this in slack here: https://expensify.slack.com/archives/C036QM0SLJK/p1721774153958089

@blimpich about the video that you've posted, is it possible that you have an ongoing manual cancellation? I wasn't able to reproduce this on my end

Same with this, separate slack thread here: https://expensify.slack.com/archives/C036QM0SLJK/p1721776484735149

And follow up to this comment, can we add a loading indicator when the user hits "submit?" Having no immediate visual response when the user clicks "submit" feels weird. A loading indicator would be nice. It will load for as long as it takes for the onyx data to come back and move us along to the next page. I think that should work?

@blimpich would adding the loading spinner to the submit button work for what you're talking about? I feel like I've seen that pattern before and I think it would work well here for what we're trying to communicate ("Yes you've hit the button, we're working on it")

@blimpich PR updated! I resolved both issues mentioned on slack, and I added a loading indicator to the form, let me know what you think!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/blimpich in version: 9.0.13-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Segment JS snippet link returns 404

Segment JS snippet link (https://segment.com/docs/sources/website/analytics.js/quickstart/) returns 404.

Looks like this was fixed in this commit: https://github.com/benjaminhoffman/gatsby-plugin-segment-js/commit/ce80f63c4ee2f907a4b1dbd87534caa540adf5d1


fossilizerhttp: use JSON instead of form data

This is breaking change, when Trace updates it go-core dependency it should make a change in its client code as well (maybe use js-core?).

This change is

fossilizer/fossilizerhttp/fossilizerhttp.go, line 206 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
struct field tag json="data" not compatible with reflect.StructTag.Get: bad syntax for struct tag pair

good catch mate


Revise and improve Supply documentation

The problem
The main problem with Supply is that its implementation is divided across, at least, two files, Supply and Supply-factories. Even so, there are methods that are not overriden from base class described, other methods seem to have changed since documentation, and, on top of that, now it mixes in Awaitable, which is not documented either.
Suggestions
Overall revision, and also improvement on all fronts.

Being spread across files is not actually a user-visible thing, though (in fact, all of CORE.setting is compiled as a single file).

Didn't know that... That explains why } was missing. Anyway, I've clarified that it's a problem for us poor doccers. We have to look up methods and functions across all these three files.

I find the documentation on supply blocks themselves a bit lacking. There's a lot of syntax you can use with them (supply whenever ... { ... }, supply for 1..10 { ... }, etc, ditto for gather and react), but AFAIK, it's not documented exactly *what* syntax is allowed for those, or when just a normal supply block is useful over Supplier (they often are).


HIVE-25482: Add option to enable connectionLeak detection for Hikari …

…datasource

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Thanks @avpash43 . Changes LGTM. Some tests are failing, you can view the link and retrigger the tests. Let me retrigger the test now.
+1 pending tests.

I have retriggered the tests (link: http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-2610/4/pipeline)

Thank you @rbalamohan , I will try to trigger tests also.

@rbalamohan , all tests has been finished successfully. Can we make merge?


Duplicate sections in rag_response prompt

I noticed that the  "---Goal---" and "---Target response length and format---" sections appear twice in the rag_response  prompt. Is this intended?
https://github.com/HKUDS/LightRAG/blob/e7a7ff62b264ae7dde437c8dac3e32847090805a/lightrag/prompt.py#L156C1-L183C16

That was my oversight, I will fix it right away.


fixed issue for empty images

Empty diagrams resulted in errors. Have added tests and fixed the issue.

Codecov Report

Merging #9 into master will increase coverage by 0.78%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage      75%   75.78%   +0.78%
==========================================
  Files           7        7
  Lines         216      223       +7
  Branches       44       46       +2
==========================================
+ Hits          162      169       +7
  Misses         47       47
  Partials        7        7

Impacted Files
Coverage Δ

persim/images.py
82.14% <100%> (+1.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4370b5b...63230ec. Read the comment docs.


avro: Add name strategy option for schema registry

What problem does this PR solve?
This improves compatibility with KSQL
This is for issue #1147
What is changed and how it works?
When creating a changefeed with --opts nameStrategy=topic this now
uses the topic name as basis for the schema registry. Before this PR
the schema registry always used {schema}_{table} as basis.
This solves the case where KSQL expect the topic name to be used as
basis for the schema registry.
Example
Setup a test environment and create the changefeed
tiup playground --without-monitor --tiflash 0 v5.3.0
confluent local services start
./bin/cdc server
./bin/cdc cli changefeed create --no-confirm \
--changefeed-id="simple-replication-task" \
--sort-engine="unified" \
--sink-uri="kafka://<IP_ADDRESS>:9092/cdctest?protocol=avro&kafka-version=2.8.0" \
--opts registry="http://<IP_ADDRESS>:8081" \
--opts nameStrategy=topic

To verify the nameStrategy:
$ ./bin/cdc cli changefeed query -c simple-replication-task | jq '.info.opts.nameStrategy'
"topic"

Now let's create a table that uses this changefeed:
CREATE TABLE t1 (
  id INT PRIMARY KEY,
  n VARCHAR(200) NOT NULL,
  ts TIMESTAMP(6) NOT NULL DEFAULT CURRENT_TIMESTAMP(6)
);
INSERT INTO t1(id, n) VALUES (1, 'test');

This now shows up in KSQL like this:
ksql> SHOW TOPICS;

 Kafka Topic                 | Partitions | Partition Replicas
---------------------------------------------------------------
 cdctest                     | 3          | 1
 default_ksql_processing_log | 1          | 1
---------------------------------------------------------------
ksql> PRINT cdctest FROM BEGINNING;
Key format: AVRO or KAFKA_STRING
Value format: AVRO
rowtime: 2021/12/17 07:06:07.227 Z, key: {"id": 1}, value: {"id": 1, "n": "test", "ts":<PHONE_NUMBER>242}, partition: 0
^CTopic printing ceased

And in the schema registry:
$ curl -s http://<IP_ADDRESS>:8081/subjects | jq
[
  "cdctest-key",
  "cdctest-value"
]

This now allows us to do this:
ksql> CREATE STREAM t1str WITH (KAFKA_TOPIC='cdctest', VALUE_FORMAT='avro');

 Message
----------------
 Stream created
----------------

ksql> DESCRIBE t1str;

Name                 : T1STR
 Field | Type
-------------------------
 ID    | INTEGER
 N     | VARCHAR(STRING)
 TS    | TIMESTAMP
-------------------------
For runtime statistics and query details run: DESCRIBE <Stream,Table> EXTENDED;

Note that we didnt' have to specify the columns in the CREATE STREAM
statement as these were fetched from the schema registry.
See also:

https://docs.ksqldb.io/en/latest/operate-and-deploy/schema-registry-integration/#schema-inference

Considerations
If you have a changefeed it maps to a single topic. With the nameStrategy=topic this means that there can only be one set of subjects registered in the registry. As soon as you try to use this topic for more than one table the registry will respond with a "HTTP 409 Conflict".
This doesn't have to be a problem as you could create multiple changefeeds, each with a filter for a single table and an unique topic.
This can even be seen as a feature as this will detect multiple incompatible things being written to the same topic.
Another solution is to implement multi-topic support, where a single changefeed creates one topic per table. However this would run into problems if topic auto creation is disabled, especially with online schema change tools like gh-ost and pt-osc which create temporary tables. However it might be possible to filter out OSC tables as these tables have predictable names.
Without this PR you could reach almost the same functionality by setting the topic in the sink URL to {schema}_{table}, this causes the topic name and the name in the schema registry to match for this table. However when a second table replicated via the same changefeed this will register itself under another name and won't result in an error, so this doesn't enforce schema consistency in the same way. Also when having multiple TiDB and CDC instances using the same Kafka infrastructure this makes it hard to keep topics unique as the {schema}_{table} name might not be unique across multiple sources. With this PR you could name the topic {some_prefix}_{schema}_{table} avoiding this problem.
Check List
Tests

Manual test (add detailed scripts or steps below)

Code changes

Has exported function/method change
Has exported variable/fields change

Side effects

Possible performance regression
Increased code complexity

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release note
A new `nameStrategy` option was added to improve compatibility with Confluent KSQL

Thank you @dveeden for your PR. It would help us a lot because we can now use single-table changefeed and name the Kafka topic as we want without having to match the topic name with the {schema}_{table}.

Another solution is to implement multi-topic support, where a single changefeed creates one topic per table. However this would run into problems if topic auto creation is disabled, especially with online schema change tools like gh-ost and pt-osc which create temporary tables. However it might be possible to filter out OSC tables as these tables have predictable names.

Debezium MySQL Connector uses the above mentioned implementation, it create one Kafka topic per table. Of course, we need to configure the Kafka cluster to enable auto topic creation (or create the topic manually before creating the table), but that doesn't raise any serious issue for us. Debezium also has database.exclude.list and table.exclude.list configuration to filter out temp tables created by gh-ost and pt-osc.

@keweishang Thanks for the information. That helps a lot.

Codecov Report

Merging #3936 (ce3cae0) into master (08da001) will increase coverage by 0.1592%.
The diff coverage is 66.1244%.

Flag
Coverage Δ

cdc
58.8789% <68.3374%> (+0.2341%)
:arrow_up:

dm
52.2966% <58.1497%> (+0.0421%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #3936        +/-   ##
================================================
+ Coverage   55.1722%   55.3314%   +0.1592%
================================================
  Files           485        489         +4
  Lines         59829      60593       +764
================================================
+ Hits          33009      33527       +518
- Misses        23484      23689       +205
- Partials       3336       3377        +41

In 6.1, with the implementation of #5338 and #4423 , now it's possible to achieve what this PR does. Generally speaking, you could use one changefeed to replicate multiple tables to kafka, each table corresponds to one topic. This is the solution 2 described by @dveeden in the PR description.
I think we could close this PR now.


Fix discriminant property check

In #27695 we were slightly too permissive in what we consider a discriminant property. Specifically, we required the combined union type to contain at least one unit type, but that unit type could have occurred in combination with non-unit types. We now check that at least one underlying property has a pure unit type or union of unit types.
Fixes #29106.

Based on your comment and the repro, isn't the real issue that we don't combine discriminant narrowing with other generated facts in control flow well?

@weswigham Well, yes and no. We would do better if we didn't have the design limitation that causes us to reset narrowed types for properties when the shape of an object changes because of a discriminant check, and we might in fact not have this issue. But it would require the ability to "record and replay" preceding narrowing checks, and that would definitely complicate the control flow analyzer. And, either way, there's really no point in considering a and b discriminant properties in the example.

In the given example, sure, but I can't help but feel that someone somewhere has taken a dependency on a property of string | undefined being discriminable since support was added.

@ahejlsberg When you say:

reset narrowed types for properties when the shape of an object changes because of a discriminant check

What does shape mean: changing the apparent properties aggregated across the union type, or something else?
Would it be too difficult (or wrong) to test for this change of shape, rather than classifying a and b as non-discriminable? Narrowing U, where type U = A | B; never changes shape and therefore the narrowing does not need to be reset.

@weswigham Discriminants are meant to be unit types and we only narrow based on equality and truthiness checks. With a discriminant of string | undefined you'd potentially be able to narrow based on obj.x === undefined, but you wouldn't be able to narrow based on a string value or a typeof check. Just doesn't seem useful, it didn't work before, and I can't imagine anyone taking a dependency on that in the last few weeks.

With a discriminant of string | undefined you'd potentially be able to narrow based on obj.x === undefined, but you wouldn't be able to narrow based on a string value or a typeof check. Just doesn't seem useful, it didn't work before, and I can't imagine anyone taking a dependency on that in the last few weeks.

A typeof-based narrowing works juts fine for string | undefined.

Also 3 months != 2 weeks. This has been out for awhile.

@weswigham No, we don't do discriminant based narrowing for typeof checks:
type Foo = { a: string, x: number } | { a: 0, y: number };

function xxx(obj: Foo) {
  if (typeof obj.a === "string") {
    obj.x;  // Error, we don't narrow here
  }
  if (obj.a === 0) {
    obj.y;  // Ok, discriminant based narrowing
  }
}

With the fix in this PR our behavior changes in the following because we no longer consider a a discriminant property:
type Foo = { a: string | undefined, x: number } | { a: string, y: number };

function xxx(obj: Foo) {
  if (obj.a === undefined) {
    obj.x;  // Previously would narrow, now doesn't
  }
}

As I said, I can't imagine anyone having taken a dependency on this in the last few weeks (or months or whatever).
This PR is the right fix for the issue given the design constraints we currently have.

If I understand the issue properly it seems to be a tradeoff between

Not adding this fix: breaking code for people using u.a && u.b && f(u.a, u.b); who have not upgraded to 3.2 yet.

Adding this fix: breaking code for early adopters narrowing on undefined. There probably are a few, as this example was in the original thread on nullable discriminants.

The number of people affected by (1) seems likely to be larger than (2), and (2) can be fixed by replacing the equality test with a type guard.

@jack-williams Yes, that's the tradeoff. But #2 is actually even further qualified: Breaking code for early adopters of discriminant narrowing involving properties that have no single underlying property of a pure unit type or union of unit types.


Rflink cover gives error

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.55
Python release (python3 --version):
Python 3.4.2
Component/platform:
Rflink, cover
Description of problem:
Adding rflink cover produces error
Expected:
Problem-relevant configuration.yaml entries and steps to reproduce:
  - platform: rflink
    devices:
      bofumotor_455201_0f:
        name: Sovrumsgardin

Traceback (if applicable):
2017-10-11 19:43:58 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.4/asyncio/tasks.py", line 237, in _step
    result = next(coro)
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/helpers/entity_component.py", line 381, in async_process_entity
    new_entity, self, update_before_add=update_before_add
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/helpers/entity_component.py", line 238, in async_add_entity
    yield from entity.async_update_ha_state()
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/helpers/entity.py", line 229, in async_update_ha_state
    state = self.state
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/components/cover/__init__.py", line 233, in state
    closed = self.is_closed
  File "/srv/homeassistant/lib/python3.4/site-packages/homeassistant/components/cover/__init__.py", line 283, in is_closed
    raise NotImplementedError()
NotImplementedError

Additional info:

Is this related to #9776 @passie ?

yes it is, I have created the fix and will be release shortly. sorry for the trouble.

Thanks!


Proposal: Rename the io.zipkin.java:zipkin dependency to io.zipkin.java:zipkin-java

Both io.zipkin.java:zipkin:2.6.0 and io.zipkin2.zipkin:zipkin:2.6.0 provides a jar named zipkin-2.6.0.jar.  This has been a problem for us when deploying to an exploded war folder for Tomcat and/or Cargo, since one overwrites the other.  The workaround for us has been to remove or rename one of the jars.
By renaming the io.zipkin.java:zipkin artifact to io.zipkin.java:zipkin-java, the problem could be avoided.

why are you importing both artifacts?

see also #2045 #2046 as there are elaborate explanations. (interesting pile-on of issues in such a short time!)
While understood, we won't be changing the group of a deprecated artifact. Rather, we will make it unnecessary. It  already is unnecessary for current versions of Brave, for example.
Feel free to comment here why you are importing both, or let us know on https://gitter.im/openzipkin/zipkin Perhaps there's a way to make this issue unnecessary for you.

see https://github.com/openzipkin/zipkin/issues/2047

Why are you importing both artifacts?

@adriancole: I don’t.  io.zipkin.java:zipkin adds this dependency itself:
https://github.com/openzipkin/zipkin/blob/328904f476208bc2454626f818798c72e3290bc4/zipkin/pom.xml#L38


stats and Nd4j datatype

If the datatype is not set explicitly (with Nd4j.setDataType(DataBuffer.Type.DOUBLE);), then stats such as mean and standard deviation may have values that are not correct (possibly due to overflows).
tests:
statistics

Probably we should just enforce double for internal state holders, as exception, for SummaryStats op group


DeprecationWarning: 'U' mode is deprecated

When using nanopb I receive the following deprecation warning from nanopb_generator.py
DeprecationWarning: 'U' mode is deprecated
  Globals.separate_options = read_options_file(open(optfilename, "rU"))

How can we fix this warning? Unfortunately I'm not familiar enough with Python to fix it myself.
I'm using Arch Linux with Python 3.7.3

Update: According to the Python documentation the U modifier now longer has an effect

There is an additional mode character permitted, 'U', which no longer has any effect, and is considered deprecated. It previously enabled universal newlines in text mode, which became the default behaviour in Python 3.0. Refer to the documentation of the newline parameter for further details.

Hmm, it will need some check for Python 2 vs. Python 3. It is unfortunate that they've added that warning in Python 3, as it was easier to make code portable between the Python versions without it.
The fix would probably be to assign openmode = 'rU' vs. openmode = 'r' in the existing check on line 119.
For now you can ignore the warning.

Thanks for the feedback! I did not consider Python 2 ./. compatibility


Do not trigger click on a disabled labeled control

Fixes #1925
I opted to test the specific incorrect behavior I discovered (where the labeled control is a checkbox). Alternatively, I could simply test that the "click" event is never dispatched. Let me know if that more generic test would be preferable.

@domenic Sounds good, thanks! I updated the PR with the changes you requested. Let me know if there is anything else.

I wish i would have known this last month @schreifels. :-/ Can't get that hour back. My former self says thanks for this. <3


Can I use js getCurrentPosition in webview ?

Hi,
I am trying to use js getCurrentPosition in some of my webviews ... but, even with the correct permissions, at the start of the app, it's not working.
May I need to add setGeolocationEnabled like there is a setJavaScriptEnabled in TurboSession.kt file.
Thanks in advance.

Hey @Nodalailama! The issue is closed, have you found a solution for this? (Needing to acces getCurrentPosition too)

Hey,
That is great because I gonna to push a commit for you :) I find the way to do it by add some line of code in your code.
I push it by this day.
Cordialement,

It's pushed.

Hi @Nodalailama and @vdegove
I have tried the code @Nodalailama has committed to fixing getCurrentPosition in webview.
override fun onGeolocationPermissionsShowPrompt(origin: String?, callback: GeolocationPermissions.Callback) {         callback.invoke(origin, true, false)     }
But, still, I am unable to get the current position. Any other fix? or something that I am doing wrong?
I have the following permissions enabled for now
<uses-permission android:name="android.permission.INTERNET"/>     <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />     <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />     <uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION" />


cell runs forever and can't interrupt if remote server is unavailable

Connect to a remote jupyter server
Run a cell on a remote kernel
Kill the server
Run a cell on the same kernel

Result:
Cell stays in executing state indefinitely. Interrupt won't stop it.

This seems like a duplicate of https://github.com/microsoft/vscode-jupyter/issues/9828.


dcgm exporter produces 404 page not found

I've been using the python exporter that comes bundled with dcgm to monitor gpu cluster, but have run into issues when building the go package from source to run on bare metal.
Test environment is P100 on ubuntu 18.04.04 LTS
Nvidia driver 430.50
CUDA Version 10.1
dcgmi version 1.7.2
go version 1.14.3
using the default-counters.csv and dcp-metrics-included.csv
Build does not produce any errors, but running produces a 404 page not found on port 9400

dcgm_prometheus.py installed in /usr/local/dcgm/sdk_samples/scripts is running correctly on a separate port

Pretty sure you aren't querying the /metrics path :)
Let me know if this fixes your issue :)

@RenaudWasTaken I apologize, my mistake. I missed the metrics path in the example curl. May want to return something when you query the root path, similar to node-exporter. Is there a simple way to limit the exporter to listen only on localhost:9400 so I can wrap it up with TLS

I can look into that!

Latest commit has this feature request: https://github.com/NVIDIA/gpu-monitoring-tools/commit/57396c44e6f4a78e47e5af7b40860ec395790c78

Should now be part of rc.11

Is there a simple way to limit the exporter to listen only on localhost:9400 so I can wrap it up with TLS

I'm not sure I understand the question  :)
There are a few examples out there on how to add SSL to a service and it really depends on your setup:

https://kubernetes.io/blog/2015/07/strong-simple-ssl-for-kubernetes/
https://github.com/nginx-proxy/docker-letsencrypt-nginx-proxy-companion
...

I'd be happy to review a PR if you want to work on adding TLS support though :)
I'll be opening another issue for that!


[Bug] segmentation bidirectional tool

Describe the Bug
For some reason the annotation added cannot move, I think it makes sense to be able to move/edit it
https://www.cornerstonejs.org/live-examples/segmentbidirectionaltool
Steps to Reproduce

The current behavior
d
The expected behavior
User should be able to move/edit it. More importantly the annotation text box appears right in the middle of the segment and is unreadable, at least it should be movable
OS
d
Node version
d
Browser
d

setToolPassive


chore: update dev instructions to include troubleshooting

Tentative fix for #19, alternative to #20
The goal is to add instructions to help when the local setup is not working, and to try to make sure the difference between niand nris clearer.

After the discussion in #19, I'll close this PR in favor of #20.


[Feature Request] Wildcards (or even regeexp?) in useQuery("#tags")

Would it be possible to support some way querying for tag patterns rather than the fully specified tags?
This would support tag multihierarchical taxonomies where it might be useful to query some common leaf terms across hierarchies (e.g., ``#resource/visual/local", "#resource/visual/link", "#resource/audio/link", "#concept/{{topic}}/definition", "#concept/{{topic}}/support" etc. )
E.g. regexp
@section and `#concept/.*/definition$`

or otherwise something glob-like/simpler:
@section and #concept and #*definition*
@section and #concept/*/definition

great suggestion! should be relatively easy to implement i think :)

UPDATE:
it's already been implemented lol
https://github.com/blacksmithgu/datacore/blob/e8919f6748008a69f47914d9db3e13efda4331ce/src/expression/functions.ts#L526-L531
syntax would be something like:
@section and any($tags, (it) => regextest(it, "#concept/.*/definition$)).
let me know if it works :)

Fantastic! It works really well, thank you :)


Implement playlist item removal

Prereqs:

[ ] https://github.com/ppy/osu/pull/16010

Not super sure about the condition for not being able to delete in host-only mode, but that can be changed at any time.

As a loose aside I'm not sure this strictly depends on the game-side PR. Functionally I can see it, but mechanically speaking this seems to compile fine without.

Would hosts being able to delete other users' items be a follow up? Another case which has come up commonly is a user leaving or being kiced from a room and the remaining players not necessarily wanting to play the beatmap left behind.

I can allow hosts to always delete items, if you think that makes more sense?

I think so, yes. In the case where host would be disallowed to remove, I think the room would be in a special state where the host is delegated to an api owner or banchobot or something.

Applied requested changes re: host being able to always remove items, and allowing removal in host-only mode. Seems to work nicely.


New Content Changes

Should have completed these two tasks:
1- Get Involved tab, at the end where there is info about chapters program

Change first sentence to: Start your own Magnify You Chapter!

2- After pressing Learn More for chapter program info

Change the sentences at the top to this: Start your own Magnify You Chapter, and create a peer mental health support group, with your very own chapter focus are as well!

Hey @LabibUW I love your work, and thank you for it. Here is a merge conflict and I won't be able to solve it until later. So if you could.take a look that would be awesome. Thank you so much again. 😀


404 error on the documentation hyperlink

I cannot access the package documentation using the link in README.rst. Is there any other place I can find the documentation?

We're working to transition over to a new module and documentation at the moment, so I'm sorry that the docs aren't accessible from the old link.  This should be cleaned up shortly
Documentation is live right now at https://mapdldocs.pyansys.com/.  Please note that some of the APIs will change with the upcoming module.

We're working to transition over to a new module and documentation at the moment, so I'm sorry that the docs aren't accessible from the old link.  This should be cleaned up shortly
Documentation is live right now at https://mapdldocs.pyansys.com/.  Please note that some of the APIs will change with the upcoming module.

Thanks for your reply.  I am getting an error executable ansys while running
                             loglevel='ERROR')```
  Where can I define the path?

Thanks for your reply.  I am getting an error executable ansys while running
                             loglevel='ERROR')```
  Where can I define the path?

The path is defined as the first variable:
exec_file = <your path here>
mapdl = pyansys.launch_mapdl(exec_file, override=True, additional_switches='-smp', loglevel='ERROR')

see help(pyansys.launch_mapdl) for more details or see the docs at launch_mapdl.

The path is defined as the first variable:
exec_file = <your path here>
mapdl = pyansys.launch_mapdl(exec_file, override=True, additional_switches='-smp', loglevel='ERROR')

see help(pyansys.launch_mapdl) for more details or see the docs at launch_mapdl.

Thanks. Can I couple pyansys with ansys workbench when I have ansys fluent as the solver and not mapdl?

Thanks. Can I couple pyansys with ansys workbench when I have ansys fluent as the solver and not mapdl?

Thanks. Can I couple pyansys with ansys workbench when I have ansys fluent as the solver and not mapdl?

At the moment that's not an option, but right now we're expanding out the functionality of pyansys to include more than just mapdl.  I'll alert my management that this is a request.  You're not the only one.

Thanks. Can I couple pyansys with ansys workbench when I have ansys fluent as the solver and not mapdl?

At the moment that's not an option, but right now we're expanding out the functionality of pyansys to include more than just mapdl.  I'll alert my management that this is a request.  You're not the only one.

Closing this issue because it appears to be complete.


Spacing & Typography fields' output CSS doesn't support value_pattern, prefix, suffix

Hi Ari,
Why Spacing & Typography fields output CSS doesn't support value_pattern, prefix, and suffix?
We might want to add  !important as suffix, or maybe calc() as the value_pattern.

This one is a bit weird...
Those are fields that return arrays of values.
The spacing control should work, I agree. that one is a bug.
However, on the typography field things get a bit more complicated.
The problem is that the arguments are passed-on to all properties.
suffix & prefixes will be added to font-size, line-height, font-family and so on.
Value_pattern would mess font-families completely and would only make sense in some of the control's sub-values.
Any ideas on how we could differentiate those and make things more modular?
I'm open to suggestions, but I also don't want this to get too complicated... The KISS rule applies everywhere.

Hi,
I stumbled across this issue as I too would like to use value_pattern with the typography field and thought of a solution:
As the theme_mod for the typography field is an array of key-values, couldn't we use the placeholder in the value_pattern like an array?
Say for example that I want to calculate the font-size, then it would look like this:
'output' => array(
    array(
        'element' => '.my-element'
    ),
    array(
        'element' => '.my-element',
        'property' => 'font-size',
        'value-pattern' => "calc($['font-size']em / 2)"
    ),
);

All the typography properties would apply to .my-element like normal except the font-size that is overridden with the value_pattern.
I don't know if it would be easy to implement or even simple enough to respect the KISS but keep in mind this is a simple suggestion.

Fixed in 3.0
You should now be able to use something like this:
'output' => array(
	array(
		'element' => '.my-element'
	),
	array(
		'element'       => '.my-element2',
		'property'      => 'font-size',
		'value-pattern' => 'calc($em / 2)',
		'choice'        => 'font-size',
	),
);

Hey Aristeides, choice is working, but I'm not able to get the value-pattern part of this working.
Also, any particular reason why you're using value-pattern instead of value_pattern for consistency?

That was just a typo, fixed it in the above comment.
Try using value_pattern


CSV output into a file

It would be nice if we added an output mode to save the data into a CSV file.

Once we fix #30, we can add a command line option to write to a file instead of stdout
https://github.com/nikomatsakis/github-metrics/blob/5a3667f890b4668056c1083905e8ca8fd04bf959/src/main.rs#L38-L56

So we would need to save this into a csv file right : )

Opt::List {
            org,
            google_sheet: gs,
            verbose: _,

So we would add another csv to the options list and then write to a csv file,
fn example() -> Result<(), Box<Error>> {
    let mut wtr = Writer::from_path("foo.csv")?;
    wtr.write_record(&["a", "b", "c"])?;
    wtr.write_record(&["x", "y", "z"])?;
    wtr.flush()?;
    Ok(())
}

Probably use a csv writer ?

Yes, I think so, once we merge https://github.com/optopodi/optopodi/pull/37 , we just need to pass the appropriate file writer to the consume method of Print. What do you think ?

Yeah I agree, so should we wait for the #37 to get merged in

@sladyn98 #37 has been merged!

@nikomatsakis closing this issue since it seems no longer relevant


Add stability tests for ran du

This PR adds two new test cases for stability in RAN env:

Stability without workload runnning
Stability with workload runing

The idea for both tests is to collect a series of metrics for a long period of time and finally  verify changes on them at the end of the test duration. These tests can be expanded with more evaluations and checks in the future.
It also includes several functions to be used by other tests such as PTP validators and stability helpers.

Both tests are missing the report ID XML. I need to check internally what values could be set. Apart from that, the PR is ready for review.

lgtm


Allow specifying custom Xcode target in flutter build and flutter run

Use case
I'm developing an iOS App Clip in Flutter and followed the docs here: https://docs.flutter.dev/platform-integration/ios/ios-app-clip. This involves creating a new Xcode target and scheme (called "RunnerAppClip") alongside the main app (called "Runner").
I have several --dart-defines, so running my RunnerAppClip in Xcode is cumbersome; I would have to base64-encode my --dart-defines and update the DART_DEFINES string in Xcode every time I want to build my App Clip. This is cumbersome.
Proposal
I'd like to be able to run flutter build ipa --xcode-target=Runner and flutter build ipa --xcode-target=RunnerAppClip. This feature is similar to flavors, but should allow specifying a custom Xcode target, not just an Xcode scheme.

I found https://github.com/flutter/flutter/issues/66805 which seems similar (with the issue title) but the context of that issue seems to be about size rather than tool command. Keeping this as a separate issue for input from others.

@jmagman

This feature is similar to flavors, but should allow specifying a custom Xcode target, not just an Xcode scheme.

I think you should still be able to do this with flavors.  With https://github.com/flutter/samples/tree/main/ios_app_clip I added an "AppClip" flavor build configuration Debug-AppClip.

The AppClip Scheme uses the AppClip executable (target) and build config:

(I know it's super confusing that the build configs and scheme build config don't need to align, flavors should have originally been written with schemes, not build configs, in my opinion)
With the verbose flag I see flutter selecting the scheme:
$ flutter run --debug --flavor AppClip -v
...
$ xcrun xcodebuild -project samples/ios_app_clip/ios/Runner.xcodeproj -scheme AppClip -configuration Debug-AppClip -destination generic/platform=iOS -showBuildSettings BUILD_DIR=samples/ios_app_clip/build/ios

Does that work for you?

Thanks @jmagman, didn't realize Flutter build flavors could work like this.
In your screenshot, the Build Configuration for the AppClip Run scheme was set to Debug, rather than Debug-AppClip. Was this intended?
I ask because I don't think Debug and Debug-AppClip should be identical: I think the "AppClip" Xcode target's "Skip Install" Build Setting should be YES for Debug and NO for Debug-AppClip
Please correct me if I'm wrong and thanks for your help so far!

I ask because I don't think Debug and Debug-AppClip should be identical: I think the "AppClip" Xcode target's "Skip Install" Build Setting should be YES for Debug and NO for Debug-AppClip. However, if xcodebuild ... -configuration Debug-AppClip ... overrides the setting in the second screenshot, then I guess my question is irrelevant

If the build settings aren't identical then yes, use Debug-AppClip.

Thanks @jmagman -- I tested and I'm able to run flutter run --flavor AppClip but I'm not able to test the App Clip Invocation URL. I added the App Clip Invocation URL to the Xcode scheme, and now when I run within Xcode, the app is able to respond properly to the set URL:

However, when I run via flutter run --flavor AppClip, the invocation URL is not passed to the app. I tried setting _XCAppClipURL as an Environment Variable but that didn't fix the issue.
Any ideas on how I can pass the App Clip Invocation URL when running via the flutter CLI? In other words, can I get flutter to use my Xcode Run scheme?

@jmagman for feedback.

However, when I run via flutter run --flavor AppClip, the invocation URL is not passed to the app. I tried setting _XCAppClipURL as an Environment Variable but that didn't fix the issue.

Can you attach the full flutter run --flavor AppClip --verbose output so I can see what scheme it's using?  The output is large so you'll need to attach it in a file.


OCPBUGS-4089: cherry-pick, do not expose ingress path metric when service is nil

Issue: https://issues.redhat.com/browse/OCPBUGS-4086
Upstream PR: https://github.com/kubernetes/kube-state-metrics/pull/1841
Problem: when in an Ingress Path.Backend.Service is nil kube-state-metrics will crash with a nil pointer
Solution: Validate if Path.Backend.Service is set

/cherry-pick release-4.12


[Feature] Specify secrets for listeners TLS certificates

Is your feature request related to a problem? Please describe.
There does not seem to be a way to use pre-existing certificates in kind: EmqxBroker
Describe the solution you'd like
Have an option to define an existing secret containing a TLS certificate for the secure ports
Describe alternatives you've considered
I can't find one right now in the information available on the kind: EmqxBroker. An other way of doing this would be to be able to specifiy an existing cluster issuer and dns names for automatic generation of the needed certs.
Related issue https://github.com/emqx/emqx/issues/6337

Hi, @mdallaire
It's a good question and we have plans to make it happen, it's already in our roadmap


Add "security" README section with XSS notes

Thanks for bel!  I have had a great time using it for https://commonform.org.
This small doc patch adds a short "security" question with a few notes on XSS mitigation.  I dug into the code and rummaged around GitHub issues to see what, if anything, bel does in terms of escaping and containment.  I imagine this short note may save others the trouble.
Best,
K

Cool thanks!


add versionStage for the createSecret restful API

this restful API will be exposed to public as:
POST <ehsm_srv_address>/ehsm?Action=CreateSecret
test: passed the unittest
Signed-off-by: yidingluo1<EMAIL_ADDRESS>

the commit msg is not make sense.
you need to explain more details about the changes, such as current/previous meaning?

the commit msg is not make sense. you need to explain more details about the changes, such as current/previous meaning?

Commit changed

change the title as " add versionStage for secretdata
versionstage is used to mark the status of versions for the secretdata. by default, the latest version is marked as current(1), and the others are previous(0).
test: passed the unittest "

Changed as required


Fan Control when using Armory Crate from within your software - buggy

When using the Armory Crate option from within your app and a Fan Profile too, then the Fan Profile doesn't always get applied correctly.
Can you make sure, the software first switches the armory crate profil and then the rest. Then Probably check 30 seconds later if the fan profile really corresponds to the active profile. If not apply again?
Or as workaround make the plans visible in the context menu to fast apply them

In order for an armoury crate profile to get applied with a fan curve, it must be at the same time. Also, fan curves are weird in general and frequently cause fan oscillation. This isn't because of my app.. it's because of the g14 hardware.

In order for an armoury crate profile to get applied with a fan curve, it must be at the same time. Also, fan curves are weird in general and frequently cause fan oscillation. This isn't because of my app.. it's because of the g14 hardware.

@aredden is it possile to set fan curve with minimal rpm but not fanless? I used to try with silence/performance and slow fan. Everytime when I set something above 0% rpm It always droped to 0, doesnt matter 20 or 50%

@aredden is it possile to set fan curve with minimal rpm but not fanless? I used to try with silence/performance and slow fan. Everytime when I set something above 0% rpm It always droped to 0, doesnt matter 20 or 50%


[AST] Disable comment printing while emitting diagnostics

There is a problem in PCH builds where source manager might
end up having unorderable source locations for comments, to work
around this (which is going to be fixed separately) let's
disable comment printing while emitting diagnostics since
such comments are not required.
Resolves: rdar://problem/38203776

@swift-ci please smoke test


add Calendar Component https://github.com/keithj2780/svelte-calendar

REPL at https://svelte.dev/repl/5aa7d011c2104b0c8906248f66da22ea?version=3.12.1

Looks great, thank you for sharing!
It appears the days are off - today is Sunday Nov 10 2019, but the screenshot and demo show the 10th as a Saturday.
Do you plan to publish to npm? There's already a svelte-calendar but you could namespace it under a user to keep the name. I don't know all of the best practices (except the "svelte" field in package.json) but there are lots of examples to follow.

Added to the list. If you publish to npm I'll update the formatting - in the successor to this project, sveltejs/community, it'll link to the npm project and probably display stats in the future.


Compose PluginDetails shows weird Waveform

It shows something looking valid-ish for pre-plugin-applied state of wave (inbuf) but most unlikely valid for post-plugin-applied state (outbuf). It is not a big deal and we can simply remove this incomplete bits from the UI at all, but better if we can fix it.

fixed by eb45d9b.


Add animation for progress bar

A sweet improvement would be for the progress bar to slide up with an animation as a profile loads or is selected.

Hello,
I would like to work on this improvement

@jimjja Have you done this yet?  Would you mind me working on it?  Thanks.

This is a reference of the issue #84 which has commits on it already.


Bot not working

I tried to /monitor and /unmonitor cause i changed the Ip but now it isn't working

same issue


Run action on a specific DIR

I need to be able to run the action on a FE dir, working-directory is not supported i also tried command_script_name: "cd ./frontend && yarn knip" with no luck

If you make a root level package script that does that it should work but I'll implement a working directory option too when I can


Compile esm version for better tree shaking in consuming projects

Without including the esm versions of the files it's not possible for consuming projects to tree shake out unused parts of libs.
That means over 1MB of react-icons gets pulled in for just the few icons that this package uses.
This change cut my package size (that depends on this lib) by over 500k!

Accidentally made the PR to main branch


[spi_device] Replace prim_ram_2p_adv by prim_ram_2p_async_adv dependency

The latest version of the SPI_DEVICE block uses either two instances of prim_ram_1r1w_async_adv or one instance of prim_ram_2p_async_adv but not prim_ram_2p_adv.
Reading the prim_ram_2p_adv dependency without having a representation in the target technology (it's currently not used anywhere) leads to issues in the back-end flow.

@a-will , it seems spi_device has supports both 2p and 1r1w memory types. The selection is based on a parameter which for Earlgrey is pointing to the 2p config. Is this intentional?

@a-will , it seems spi_device has supports both 2p and 1r1w memory types. The selection is based on a parameter which for Earlgrey is pointing to the 2p config. Is this intentional?

Yes. The 2p config is the original, the one used in ES, and the selection was not changed because the 2p variant is the one available in the technology.
1r1w is used in Darjeeling, and it's the opposite situation for the technology associated with that top.

Ah, now I understand. Thanks @a-will for explaining!


M UI theme rework

Description
Color variants have been adjusted and missing colors from the design have been added.
Typography was extended. Semantics are not perfect, but cover the general idea and allow for automatic implementation of responsive fonts.
Variant<->HTML element mapping was changed mostly to span to allow the most flexibility. button typography variant was not implemented in favor of the button component utilizing either of the body variants based on passed props.
The heading variants were left for compatibility - they will be removed once all components will be converted while dealing with #163.
Linked issues
Resolves #162

@LostInStatic great stuff! I have changed the CI to use one action only. It contains prettier and eslint checks. The spacing rework has also been merged into this branch through this so let me know whether you want to change anything in this PR since that happened.
The Add Project view throws some errors in console. This is probably due to spacing now.

The Add Project view throws some errors in console. This is probably due to spacing now.

Fixed.


delete notifications and allow unsafe code in cs files

Updated Notify so it now returns notification handle
Added Method to delete a notification from its handle
Uncompiled CS files can use unsafe code

Very good job.

Uhm, out of interest, when does GET_SCREEN_RESOLUTION not return 1280:720?

@JohnnyCrazy Just ran the code, can confirm, still returns 1280x720.

Maybe, we can use size structure instead of two properties?

@JohnnyCrazy , never =\

I don't see any reason changing it then? It will just use more calls (2, not even 1) and doesn't feature any improvements

@JohnnyCrazy Me neither, however the notification code seems cool (havent tested it though).

//----- (000000013FCE6124) ----------------------------------------------------
__int64 __fastcall sub_13FCE6124(__int64 a1)
{
__int64 v1; // rax@1
__int64 v2; // rcx@1
__int64 result; // rax@1
v1 = *(_QWORD *)(a1 + 16);
v2 = *(_QWORD *)(v1 + 8);
result = *(_QWORD *)v1;
*(_DWORD *)result = 1280;
*(_DWORD *)v2 = 720;
return result;
}
Hmm, never mind, just checked the gtav exe, that bit of code can be removed

Just a quick note:
Maybe we can use a small wrapper for the map notifications, something like this?
Notification not = UI.Notify("test", 10000); //Automatically shows it?
//Do some other stuff
not.Hide() //or Remove

That could work, but making a wrapper when there is only 2 methods you can really use (show and hide) seems like a waste of time

Seems easier to handle a bunch of notification objects then integer ids?

"Uncompiled CS files can use unsafe code"
So we can now work with pointers etc? :-D

It lets you work directly with pointers using cs files, you could use pointers with c# already, but you need to compile them as a dll in visual studio beforehand. this means you can release a cs script(people wont be scared about viruses) and still make use of pointers

Changed Notification so they are now a Class
//usage
UI.Notification Notify = new UI.Notification("Message", bBlinking); //bBlinking is a bool, true to make the notification blink
//To Delete
Notify.Delete();

Seems cool to me :+1: @crosire

But it breaks existing scripts using UI.Notify ... Should at least keep it and mark it obsolete.

Agreed. UI.Notify() should be kept - it's a useful debug function.

Or change it to Notification not = UI.Notify("test");, so it won't break.
Would also be better since we are just using methods (like e.g World.CreateVehicle) to create actual stuff ingame, not constructors.

Put the old method back in for older scripts

@JohnnyCrazy @crosire Are there any other issues with this that need fixing first

Seems weird to be implementing it like that, that a constructor creates a notification by itself.
Using UI.Notify seems like the best choice.. Older scripts won't break just because it now returns an object will they??

@Frede1012 The issue is not with cs or vb files, but dll files will break, anyway changed it again to how the messagebox class in windows works. also added a few other little fixes

@JohnnyCrazy I have made a class for using Ray casting, there are still a few unknowns in there, but its good enough to start to work with.

Don't wanna decide alone on this, will leave this to @crosire :D

I like most of the changes, but I'm still not happy with the notification class. "UI::Notify" was much simpler to use and the amount of classes is constantly growing and growing ...
Could we split this in two pull requests and further discuss the notification stuff?

Nothing wrong with having lots of classes! :)

@nevadascout I'm a big supporter of the KISS principle =P

True, but having lots of classes is simpler than one class that does everything in my opinion :P
There's also the Single Responsibility Principal to consider

@crosire right I've removed the notification stuff, arent experienced enough with GIT to make 2 different requests


Bug: Breaks when media-Folder is at another place

Thank you very much for your excellent plugin!
I have the media folder at another place:

echo (new Kirby([
    'roots' => [
        'media' => __DIR__ . '/files',
    ]
]))->render();

Images are linked to a /media/.. location in the image preview page. It should be /files/.. in my case.  As a result there are broken images in the panel. Afterwards the whole panel does not work any more because there seems to be files overwritten or deleted as a side effect.
The problem occurs as soon as you set the focus point and save. Then, the preview image disappears. As a second side effect, the complete kirby panel does not work anymore. The browser page stays white and in the console you can see some 404 errors.

Thanks for reporting. I will have a look at this as soon as possible, but it may take some time because my spare time is limited at the moment. Thanks for your patience.

I tried your config with a fresh starterkit (Kirby 3.3.5) and could reproduce the error – but without the Focus plugin installed. So this one is not Focus related.
Nevertheless, this config seem to fix it:
$kirby = new Kirby([
    'roots' => [
        'media' => __DIR__ . '/files',
    ],
    'urls' => [
        'media' => url('files'),
    ],
]);

echo $kirby->render();

… as described by @pedroborges in this forum answer.
I also found this related Kirby issue.

Oh - i'm sorry to lead you in the wrong direction. Thank you very much for clarify this so fast.

No problem at all. Don't hesitate to get in touch again, if you run into any other issues which might be Focus related.


ci: Always run e2e testing

the "e2e-pr / operator tests" is always required so we have to run it even though it does not make much sense.
This should help with https://github.com/confidential-containers/operator/pull/444

Note that alternative would be to use:
    # Step 1: Checkout the PR code
    - name: Checkout code
      uses: actions/checkout@v3

    # Step 2: Get list of changed files and set 'docs_only' variable
    - name: Determine if only docs/** files changed
      id: set_docs_only
      run: |
        # Get the list of changed files in the PR
        git fetch origin main
        changed_files=$(git diff --name-only origin/main...HEAD)

        echo "Changed files:"
        echo "$changed_files"

        # Check if all files are in the docs/ folder
        docs_only=true
        for file in $changed_files; do
          if [[ ! $file == docs/* ]]; then
            docs_only=false
            break
          fi
        done

        echo "docs_only=$docs_only" >> $GITHUB_ENV

    - name: Operator tests (kata-qemu, ${{ matrix.os }})
      if: ${{ env.docs_only == 'true' }}
      uses: ./.github/workflows/skip_e2e.yaml

and add the skip_e2e test that would only report pass. But IMO it's unnecessary too complex, what do you think?

add the skip_e2e test that would only report pass. But IMO it's unnecessary too complex, what do you think?

I think it's worth discussing an option like this more, but for now just re-enabling the ci to unblock us is probably the best path