firewall gui is confusing when using the "any" protocol option with ports, and produces a more lenient rule than might be expected

The firewall gui currently allows you to make a rule that both includes "Any" protocol, and source and destination ports. For example;

Intuitively I would expect those combination of options to create iptables rules that allow either TCP or UDP connections with a source port of 9999, and a destination port of 8888, and ignore everything else, because those port restrictions could not be met with other protocols. However the rule it generates looks like this;
   0   0 zone_wan_dest_ACCEPT  all  --  *      *       <IP_ADDRESS>/0            <IP_ADDRESS>/0            /* !fw3: an-example-rule */
which is unlikely to be what the user is expecting...
The generated /etc/config/firewall block is also accepting a set of options, that will ignore the ports.... I would have expected this to be an invalid combination of options....
config rule
        option target 'ACCEPT'
        option name 'an-example-rule'
        option family 'ipv4'
        option proto 'all'
        option src 'lan'
        option src_port '9999'
        option dest 'wan'
        option dest_port '8888'

It would make more sense if the source and destination ports were grayed out if the Any protocol options was selected;

Something like this would hide the port options if the protocol wasn't tcp, udp or "tcp udp" etc
https://github.com/limepepper/luci/commit/afe0fecb6863afab5f215206ff439ce31240d0a0


Blazor server-side publish docker image failure

I am trying to publish a docker image of my blazor SSR app but i get this error when running build
Error		The "Microsoft.AspNetCore.Razor.Tasks.RazorTagHelper" task could not be loaded from the assembly /root/.nuget/packages/microsoft.aspnetcore.razor.design/2.1.1/build/netstandard2.0/../../tasks/netstandard2.0/Microsoft.AspNetCore.Razor.Tasks.dll. Assembly with same name is already loaded Confirm that the  declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [/src/testapp/testapp.Server.csproj]
The command '/bin/sh -c dotnet build "testapp.Server.csproj" -c Release -o /app' returned a non-zero code: 1
C:\Users\agonzalez.nuget\packages\microsoft.visualstudio.azure.containers.tools.targets\1.0.1916590\build\Container.targets(132,5): Error MSB3073: The command "docker build -t "testapp" -f "Dockerfile" ".."" exited with code 1.

Same issue here but without Docker.

Thanks for contacting us, @agonzalezm.
This will be fixed in 3.0 release.


[NFC] Comgr include header reorg

some residue which causes warning messages like
In file included from /root/MIOpen/src/comgr.cpp:41:
/opt/rocm-5.5.0-11454/include/amd_comgr.h:27:2: warning: "This file is deprecated. Use file from include path /opt/rocm-ver/include/ and prefix with amd_comgr" [-W#warnings]
#warning "This file is deprecated. Use file from include path /opt/rocm-ver/include/ and prefix with amd_comgr"
 ^
1 warning generated when compiling for gfx1030.

This PR resolve issue mentioned in #1945

@junliume I made a typo in my original suggestion<PHONE_NUMBER>ULL instead of<PHONE_NUMBER>ULL) but you were too fast and incorrect number was merged.

@junliume please expect a PR with fix soon.


Added new packages to distribution

I hope the changes are correct :S

This looks reasonable, but you'll need to rebase it due to a merge conflict. And when you do could you squash it to get ride of all the fixup commits.

Sorry, I'm a bit noob on ros and git. Could you explain me what do you mean with "rebase it", please? Which is the merge conflict?
Thanks.

Overviews of rebasing: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
This pull-request is requesting that we merge your branch into ros/rosdistro's master branch. However your changes are out of date with the latest content on master and there are changes in the same region of the file which means that git cannot automatically merge your changes with the master branch. https://help.github.com/articles/resolving-a-merge-conflict-from-the-command-line/


Inconsistent behavior when using value of partially unknown type as generic argument

Environment data

Language Server version: 2021.4.2
OS and version: Windows 7
Python version (& distribution if applicable, e.g. Anaconda): 3.8.8 Anaconda

Sample Code
from __future__ import annotations

from typing import TypeVar

T = TypeVar("T")

def f(x: list[T]) -> T:
    ...

a = []  # Type: `list[Unknown]`.
b = f(a)  # Type: `Unknown`.
b.xxx  # OK using basic checks.

c = f([])  # Type: `T@f`.
c.xxx  # Warning: Cannot access member `xxx` for type `object`.

Expected behavior
Type of c is Unknown, just like type of b.
Actual behavior
See comments in the sample code.

I can understand why this looks inconsistent, but it is the correct (or at least intended) behavior.
In the first example, you're creating an empty list in a situation where the type checker has no context about how it will be used. It therefore infers that the type of a is list[Unknown]. This allows it to be used flexibly in subsequent statements. For example, you could push values onto the list even if they have various (heterogenous) types.
In the second example, you're creating an empty list in a situation where the type checker has additional context. It knows that the newly-created list is being assigned to a parameter of type list[T] where T is an unbound type variable. The type of this newly-created list is therefore inferred to be list[T], and the type of c is therefore T. When c is used in the next statement, all we know about c is that it must be an object (since T is an unbound type variable), so the expression c.xxx is evaluated as though c is an object instance.
You can eliminate the type error by specifying a type annotation for c, like this:
c: MyType = f([])

Note that mypy (another Python type checker) emits type errors for both cases, forcing you to provide type annotations for both a and c. Pylance can be a bit more permissive in cases like this because of its use of "Unknown".

I'm still not understanding the behavior here.
Is it true that some types displayed the same as list[Unknown] are internally different types?
Here is a modified example:
from __future__ import annotations

from typing import TypeVar

T = TypeVar("T")

def create_list_of_unknown_elements() -> list:
    return []

def f(x: list[T]) -> T:
    return x[0]

a: list = create_list_of_unknown_elements()  # Type: `list[Unknown]`.
b = f(a)  # Type: `Unknown`.
b.xxx  # Type: `Unknown`.

c = create_list_of_unknown_elements()   # Type: `list[Unknown]`.
d = f(c)  # Type: `T@f`.
d.xxx  # Warning: Cannot access member `xxx` for type `object`.

It has passed mypy check (https://mypy-play.net/?mypy=latest&python=3.8&gist=ea89c6a7f0a08c7c3ccefb3e5a2edd8e), but still got warnings from pylance.

Here is one more example that passed mypy checks but failed pylance checks:
from __future__ import annotations

from typing import Any, Generic, TypeVar

T = TypeVar("T")
T_co = TypeVar("T_co", covariant=True)
T_contra = TypeVar("T_contra", contravariant=True)

###

class MyClass0(Generic[T]):
    ...

def my_func_0(x: MyClass0[T]) -> T:
    ...

a0: MyClass0[Any] = MyClass0()  # Type: `MyClass0[Any]`
b0 = my_func_0(a0)  # Type: `Any`
c0 = b0.xxx  # Type: `Any`

###

class MyClass1(Generic[T_co]):
    ...

def my_func_1(x: MyClass1[T]) -> T:
    ...

a1: MyClass1[Any] = MyClass1()  # Type: `MyClass1[Any]`
b1 = my_func_1(a1)  # Type: `Any`
c1 = b1.xxx  # Type: `Any`

###

class MyClass2(Generic[T_contra]):
    ...

def my_func_2(x: MyClass2[T]) -> T:
    ...

a2: MyClass2[Any] = MyClass2()  # Type: `MyClass2[Any]`
b2 = my_func_2(a2)  # Type: `T@my_func_2`
c2 = b2.xxx  # Warning: Cannot access ...

https://mypy-play.net/?mypy=latest&python=3.8&gist=69aa0216b8232966daf851ba7a76604b

This is a bug. There are places where pyright needs to distinguish between two cases: 1) a generic type is specified with an explicit type argument that has an unknown type , and 2) a generic type is specified but omits one or more type arguments, meaning that they are implicitly unknown (e.g. list or Sequence). It does so internally through the use of a boolean field called isTypeArgumentExplicit. This boolean value isn't reflected in the textual form of the type, which is why you were seeing list[Unknown] in both cases. There was a bug where isTypeArgumentExplicit was being used incorrectly in one code path. This resulted in the inconsistent behavior in the sample above. This will be fixed in the next release. With the fix in place, no type errors are reported with this code.
Note that this is different from the first sample you provided in this bug report. As I previously explained, that behavior is intended, not a bug.

Thank you for explaining. By knowing which part my problem is, I can continue my work now.
Looking forward to the new version.

Thank you for explaining. By knowing which part my problem is, I can continue my work now.
Looking forward to the new version.


Fix approval rules for GitHub workflows

Only SIG Docs leads (chairs + tech leads) should be able to approve changes to workflows.
Tweak rules so Prow knows this.

/lgtm
/approve

Thank you for this PR, @sftim. I've lgtmed and approved it.


Doesn't show SHIFT, OPTION, or COMMAND

What the title says. When pressing those keys individually nothing appears.
I need to record a screen using those keys along with the mouse. For example Illustrator (and most graphics software) when using OPTION and dragging an object it duplicates it, or when using SHIFT it constraints the movement and rotation of an object. But those keystrokes do not appear.
I'm on 10.11.2

You should try the Svelte visualizer for this - it has the behavior you want.

On Jan 7, 2016, at 10:07, PierBover<EMAIL_ADDRESS>wrote:
What the title says. When pressing those keys individually nothing appears.
I need to record a screen using those keys along with the mouse. For example Illustrator (and most graphics software) when using OPTION and dragging an object it duplicates it, or when using SHIFT it constraints the movement and rotation of an object. But those keystrokes do not appear.
I'm on 10.11.2
—
Reply to this email directly or view it on GitHub.

Oh thanks.
It would be great is Svelte had a preference to make it bigger.


Investigate why changing input devices in the frontend app causes connection to freeze

@SimonBrandner, should we close this one? It seems like we've found a reason for it (the client did not send an SDP offer).

Should it send one? Shouldn't it use replaceTrack()? Perhaps my memory is failing

Yep, we do a replaceTrack(): https://github.com/matrix-org/matrix-js-sdk/blob/matthew/sfu/src/webrtc/call.ts#L1396

Hm-hm. Is there anything on the SFU side that we need to track to make it work? So far it's observed as a freeze on the other participants' side. We don't seem to get any errors on the SFU side though 🤔

Yeah, I really have no idea what causes this... - it needs investigation

So I've tried it again a couple of times today. In all cases, we don't get any events from the client, and we also don't get anything from Pion (so no callbacks from onTrack or something [though probably it should not fire indeed if we're just replacing a track]). We also don't get any errors on our goroutine that reads the data from the track. So on the server side we don't have any indication that something changed and we don't know what to do next.
Interesting enough, the logs in dev console on the client side are the same for EC Full Mesh and EC with SFU, but the later does not work. Perhaps we need to also investigate it deeper on a client side somehow, not sure.

Turns out the fact we were not cloning streams causes the tracks to be accidentally stopped somewhere
(fixed by https://github.com/matrix-org/matrix-js-sdk/pull/2423/commits/ae2b66ed81b3cd2310c14c532cbfc1646c0d63d0)


No utility classes detected in source files (content option)

Version
@nuxtjs/tailwindcss:  v6.3.0 and above
nuxt:  v3.1.2
Reproduction Link

Steps to reproduce

yarn install
yarn dev

What is Expected?
Tailwind should recognize the content form its config,
yet it throws warnings in both @nuxt/tailwindcss as in the configuration which is provided by tailwind itself. To see the the warning with the other tailwind config, you can switch branch in the repo.
What is actually happening?

Couldn't find a provided reproduction!
But this issue is when there are no CSS classes in your Nuxt app yet.

Couldn't find a provided reproduction!
But this happens when there are no CSS classes in your Nuxt app yet.

Isn't that a bit weird to tell the user? I would expect that if I install a package but I didn't use it yet that it shouldn't give warnings of any form, in this case I wouldn't expect such warnings unless my config is wrong or I started using tailwind classes.

The warning is from Tailwind and the module is forwarding it - I believe it's their decision to have that.


Flowplayer mpegdash: Video without Audio track crashed

Browser: Chrome 46 (64-bit)
System: OSX
Player: Flowplayer 6.0.4 + mpegdash plugin
PLayer:  dash: Unsupported video
Console:  audioCodec (audio/mp4;codecs="unknown") is not supported.
I would like to play videos which have no audio track.
Is it possible to control it by a parameter ?
thx

That looks like:

your mpd has a broken codecs declaration or
the format/codec is broken and leads to codecs="unknown" in your mpd

It's certainly not a problem with a missing audio track.
If you provide the URL of the mpd, I might be able to give a more precise diagnosis.

As per please https://github.com/flowplayer/flowplayer-mpegdash#stream-compatibility also test your stream first in the dash.js sample player at http://dashif.org/reference/players/javascript/v1.5.1/samples/dash-if-reference-player/ - if it does not play there, you may get more/better advice there as well; we will monitor that too, obviously.
Closing for now.


Introduce loglevel logging framework

Fix #926
Notice this comes with a slight behavior change: config.logger, instead of specifying the level of the emits by redux-logger only, now comply with the common case of specifying the minimum logging level of the whole SDK. So:

before: config.logger = 'info' would make redux-logger logging be printed with info level on console
now: config.logger = 'info' will omit anything logged with level < info, i.e. debug

Default levels for redux-logger are: info for action entry, debug for prev & next state. Default config is info. Therefore, on default config, anything info & above will be printed, and redux-logger will print only action, which is cleaner. To enable full debug logging, one must set with: raiden.updateConfig({ config: { logger: 'debug' }});.
This level also applies to matrix logger.

Awesome, thanks for taking care of it :D


model.close() is not called on exit

If the GUI is closed with alt+f4 or the close button, the file handles aren't properly closed.

... or maybe they are. Trying to call self.close() from self.__del__ results in nasty warnings like C:\Users\Max\miniconda3\lib\site-packages\h5py\_hl\files.py:290: RuntimeWarning: Found murdered identifier 112489032 of kind <class 'NoneType'> HDF5 id<PHONE_NUMBER>...

murdered? omg

yeah. thought this would be a simple bug. I'm actually not sure it matters. I think all the files will individually be closed on exit... so it might not be a problem

there are segfaults when quitting sometimes, so something might be wrong...


Debugger stops at at end of file when "stepping into"

Describe the bug
I'm trying to debug tests in Visual Studio Code. I followed this guide: https://vitest.dev/guide/debugging.html to set up the vscode debugger and everything works fine, until I "step into" a function or method. The debugger does not stop on the correct line, but at the end of the file. I created a minimal repo to reproduce the issue: https://github.com/oliverschwendener/vitest-vscode-debugging-issue. Does anyone have an idea what could cause this issue? Did I misconfigure something?
Reproduction
https://github.com/oliverschwendener/vitest-vscode-debugging-issue
Output
[INFO 15:58:09] [v0.8.4] Vitest extension is activated because Vitest is installed or there is a Vite/Vitest config file in the workspace.
[INFO 15:58:09] [API] Running Vitest: v1.5.0 (vite.config.mts)
[INFO 15:58:09] [API] Starting Vitest process with Node.js: /Users/oliverschwendener/.nvm/versions/node/v20.12.2/bin/node
[INFO 15:58:10] [API] Vitest process 94273 created
[INFO 15:58:11] [API] Collecting tests: src/Calculator.test.ts
[INFO 15:58:11] [API] Collecting tests: src/Calculator.test.ts
[INFO 15:58:33] [DEBUG] Starting debugging on localhost:53856
[INFO 15:58:33] Running 1 file(s) with name pattern: ^\s?add should add two numbers$
[Worker] Debugger listening on ws://<IP_ADDRESS>:53856/691b403d-7e0e-4ddc-8605-5c4ff72dd9f6
For help, see: https://nodejs.org/en/docs/inspector
[Worker] Debugger attached.
[INFO 15:58:33] [DEBUG] Debugging started

Version
v0.8.4
Validations

[X] Check that you are using the latest version of the extension
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Thanks for the reproduction.
It looks like this is due to how Vite SSR transforms imports/exports internally. Vite replaces each named export with a getter of magic variable __vite_ssr..., so probably this getter call is making an weird jump.
I'm not sure if there's a solution to this, but probably this issue is reproducible on plain Vite SSR, so actions need to be take there.
Btw, you are using vscode debugger directly with own launch.json, so technically this is not vscode extension issue, which is what this repo is about. But, the same issue can reproduce either way.


add autofix for E721

Summary
Adds autofix for E721. Resolves the right-hand side into a builtin from a constant expression if possible.
Notes:

there's a line in the existing E721.py test code for if res == types.IntType: which is not emitted due to an early guard clause on the left-hand side not using type(), I have not fixed this due to added complexity

Test Plan
cargo test and manually

I'm gonna close this one for now -- sorry for the churn, I appreciate the work but I think it will be hard to get right.


Hostapd bump

Note: Unfortunately, I strongly disagree with the software development practices of hostapd and wpa_supplicant, which is too long of a release cycle and no stable branch with backporting of fixes. Also I am not able to review or track upstream commits to see what's good for backporting. All I can do, is send a PR and hope that upstream testing was sufficient. Given that 2.7 ships 2 years worth of changes, I do expect a fallout however! :(
Motivation for this change
Upstream release
Things done
Pushed to my laptop to test wpa_supplicant.
Pushed to my nixos access point to test hostapd.

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

Some small fallout risk seems normal for master/unstable.  The wording made me think you filed this against the stable 18.09 branch :-)

Sorry, it was on the other side of the huge removal block in the diff. Never mind about my previous statement

I had #55926 pending to bump wpa_supplicant but no reviews in a week. Feel free to close that PR if this one gets merged.

@grahamcofborg build hostapd wpa_supplicant

I'm kind of surprised so little depends on wpa_supplicant.
@vcunat Are you okay with merging this? It looks okay to me, but I didn't test it.

I had #55926 pending to bump wpa_supplicant but no reviews in a week. Feel free to close that PR if this one gets merged.

Sorry for missing your PR. I just used hostapd as a search term.

@xeji merged the other one, so this needs to be thinned out to be just hostapd, @clefru

I haven't done any kind of testing either, not even looking at NEWS.  I can't see anything blocking this either, but it would be better if someone actually used it before merging :-)

I removed the wpa_supplicant part from this PR as it was pushed in the other.

@vcunat hostapd 2.7 is running on my AP since two or three days. Haven't noticed anything bad.

@GrahamcOfBorg build hostapd

@clefru thanks; please consider adding yourself as a maintainer.


Allow PHP-CS-Fixer 2.10.x

I know you locked it to prevent BC breaks. That's why I changed it to ~2.10.0 instead of ^2.10.

I've experienced breaks in minors as well.
And I guess I need this for a reason, so ok

Could you change the root composer as well? And other occurances, if some

I've experienced breaks in minors as well.

Yeah I know. This doesn't allow the next minor release (2.11), just bugfix releases for 2.10. Those should not cause any BC breaks.

It seems you have already done it in root composer.
https://github.com/Symplify/Symplify/commit/1eaa62d21513f70abd31419f105e43adf15316ec

@enumag I see. Thanks :+1:
Btw, does this mean you've moved to Symfony 4 and ECS 3?

Indeed. :-) All the bundles we're using are finally SF4 compatible.

Congrats :+1:  How was the ugprade? Did you leverage some Rector rules?

The only thing I needed to fix were DependencyInjection deprecations with autowiring. Rector can't help with that as far as I know so I didn't use it at all.

DependencyInjection deprecations with autowiring

What exactly?

Things that caused deprecation errors in 3.4 and don't work in 4.0. This is a typical example.
Cannot autowire service "App\Users\Application\SignIn\Field\SignInField": argument "$queryBus" of method "__construct()" references class "App\Library\Prooph\Infrastructure\SynchronousQueryBus" but no such service exists. You should maybe alias this class to the existing "prooph_service_bus.main_query_bus" service.

I usually solve it by adding an alias. I'm not sure if that's the best solution though.

I see. That's been ages for me to see such errors.
If it's 1 interface = 1 class  case, you can use: https://github.com/Symplify/Symplify/pull/645
If you have 1 interace = many classes, but the first one registered is the one (similar to Nette), I'd create own compiler passes to avoid useless manual aliasing.

I'll give it a try. Thanks for the tip!

More details? Can't reproduce

Don't worry about it, I just added php -d memory_limit=-1 for ecs. Previously had to do that only for phpstan so it was a bit funny that ecs now joins the big memory club.

Finding the spot would be better though.
If diff 3.2.20...3.2.25 this helps in any way: https://github.com/Symplify/EasyCodingStandard/compare/v3.2.20...v3.2.25

I was upgrading from 2.x and also changed our ecs configuration quite a bit so it would be very difficult to find.

I see


Add a frequency parameter to TriggerWandbSyncLightningCallback

In order to synchronize every N epoch instead of every epoch (by default), I added a frequency parameter to the Lightning callback.
I did not write any test for that feature, mainly because I am not sure how you proceed (but also because of lazyness 😅)
Tell me if you want me to add a test for that.

I made the changes. Still without testing 😇
I 100% confident it works for the Lightning hook (TriggerWandbSyncLightningCallback), because i use such a setup in my work. However, I never used ray before and can't think of an easy way to test it. Can you have a look and tell me if I implemented something stupid?
Also about #83, I think it can definitely help but won't solve the problem.

Oh you're 100% right, I should have thought about that as well. A totally different avenue of solution (that might also help with syncing hyperparameters of runs that get killed because of #100) would be that the wandb-osh syncer tool remembers which runs were syncing and if it doesn't get triggered for an hour, it runs one final sync call. Of course that's also just another silly workaround.

That would be a pretty robust workaround indeed.
Should I add the on_test_epoch_end() fix I mentionned and we close this PR?
Or should I just add a Warning about this problem in the doc, and we fix it in another PR?
I dug into the problem I raised in #100 and this is deeper that just not syncing the config. i will detail what I found so far in the Issue.
Anyway, it would be handy for me to have the possibility to reduce the number of Triggers to investigate when the problem happens.

@klieret should I push this temporary fix?
Or do you want to solve it in this PR?

Could you give me push permission on the branch (I made some fixes and added some tests to this). You only have to click a checkbox on this PR, I think

Could you give me push permission on the branch (I made some fixes and added some tests to this). You only have to click a checkbox on this PR, I think

The box is checked, it seems to be checked by default btw


klogr logger does not log

/kind bug
What steps did you take and what happened:
If you run the default manager you will not see any logs.
What did you expect to happen:
I expected to see logs
Anything else you would like to add:
I believe a -v flag must be parsed and passed to the klogr instance.
cc @fabriziopandini

klog.InitFlags() ruins our lives yet again

@rudoi it does :D

/assign
/lifecycle active


Logiqa en

logiqa in english.

I'm getting an error when I try to create the dummy data:
aclifton@pop-os:~/data/hf_datasets_sprint/datasets$ python datasets-cli dummy_data ./datasets/logiqa_en/ --auto_generate
2021-01-07 10:50:12.024791: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcudart.so.10.1'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory
2021-01-07 10:50:12.024814: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
Using custom data configuration default
Couldn't generate dummy file 'datasets/dummy/1.1.0/dummy_data/master.zip/LogiQA-dataset-master/README.md'. Ignore that if this file is not useful for dummy data.
Dummy data generation done but dummy data test failed since splits ['train', 'test', 'validation'] have 0 examples for config 'default''.
Automatic dummy data generation failed for some configs of './datasets/logiqa_en/'

I'm getting an error when I try to create the dummy data:
aclifton@pop-os:~/data/hf_datasets_sprint/datasets$ python datasets-cli dummy_data ./datasets/logiqa_en/ --auto_generate
2021-01-07 10:50:12.024791: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcudart.so.10.1'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory
2021-01-07 10:50:12.024814: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
Using custom data configuration default
Couldn't generate dummy file 'datasets/dummy/1.1.0/dummy_data/master.zip/LogiQA-dataset-master/README.md'. Ignore that if this file is not useful for dummy data.
Dummy data generation done but dummy data test failed since splits ['train', 'test', 'validation'] have 0 examples for config 'default''.
Automatic dummy data generation failed for some configs of './datasets/logiqa_en/'

Hi ! Sorry for the delay
To fix your issue for the dummy data you must increase the number of lines that will be kept to generate the dummy files. By default it's 5, and as you need at least 8 lines here to yield one example you must increase this.
You can increase the number of lines to 32 for example by doing
datasets-cli dummy_data ./datasets/logica_en --auto_generate --n_lines 32

Also it looks like there are changes about other datasets in this PR (imppres). Can you fix that ? You may need to create another branch and another PR.

Hi ! Sorry for the delay
To fix your issue for the dummy data you must increase the number of lines that will be kept to generate the dummy files. By default it's 5, and as you need at least 8 lines here to yield one example you must increase this.
You can increase the number of lines to 32 for example by doing
datasets-cli dummy_data ./datasets/logica_en --auto_generate --n_lines 32

Also it looks like there are changes about other datasets in this PR (imppres). Can you fix that ? You may need to create another branch and another PR.

To fix the branch issue, I went ahead and made a backup of the dataset then deleted my local copy of my fork of datasets. I then followed the detailed guide from the beginning to reclone the fork and start a new branch.
However, when it came time to create the dummy data I got the following error:
aclifton@pop-os:~/data/hf_datasets_sprint/datasets$ datasets-cli dummy_data ./datasets/logiqa_en --auto_generate --n_lines 32
2021-02-03 11:23:23.145885: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcudart.so.10.1'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory
2021-02-03 11:23:23.145914: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
Using custom data configuration default
Couldn't generate dummy file 'datasets/logiqa_en/dummy/1.1.0/dummy_data/master.zip/LogiQA-dataset-master/README.md'. Ignore that if this file is not useful for dummy data.
Traceback (most recent call last):
  File "/home/aclifton/anaconda3/bin/datasets-cli", line 36, in <module>
    service.run()
  File "/home/aclifton/anaconda3/lib/python3.7/site-packages/datasets/commands/dummy_data.py", line 317, in run
    keep_uncompressed=self._keep_uncompressed,
  File "/home/aclifton/anaconda3/lib/python3.7/site-packages/datasets/commands/dummy_data.py", line 355, in _autogenerate_dummy_data
    dataset_builder._prepare_split(split_generator)
  File "/home/aclifton/anaconda3/lib/python3.7/site-packages/datasets/builder.py", line 905, in _prepare_split
    example = self.info.features.encode_example(record)
  File "/home/aclifton/anaconda3/lib/python3.7/site-packages/datasets/features.py", line 799, in encode_example
    return encode_nested_example(self, example)
  File "/home/aclifton/anaconda3/lib/python3.7/site-packages/datasets/features.py", line 710, in encode_nested_example
    (k, encode_nested_example(sub_schema, sub_obj)) for k, (sub_schema, sub_obj) in utils.zip_dict(schema, obj)
  File "/home/aclifton/anaconda3/lib/python3.7/site-packages/datasets/features.py", line 710, in <genexpr>
    (k, encode_nested_example(sub_schema, sub_obj)) for k, (sub_schema, sub_obj) in utils.zip_dict(schema, obj)
  File "/home/aclifton/anaconda3/lib/python3.7/site-packages/datasets/features.py", line 737, in encode_nested_example
    return schema.encode_example(obj)
  File "/home/aclifton/anaconda3/lib/python3.7/site-packages/datasets/features.py", line 522, in encode_example
    example_data = self.str2int(example_data)
  File "/home/aclifton/anaconda3/lib/python3.7/site-packages/datasets/features.py", line 481, in str2int
    output.append(self._str2int[str(value)])
KeyError: "Some Cantonese don't like chili, so some southerners don't like chili."

Hi ! The error happens when the script is verifying that the generated dummy data work fine with the dataset script.
Apparently it fails because the text "Some Cantonese don't like chili, so some southerners don't like chili." was given in a field that is a ClassLabel feature (probably the answer field), while it actually expects "a", "b", "c" or "d". Can you fix the script so that it returns the expected labels for this field instead of the text ?
Also it would be awesome to rename this field answerKey instead of answer to have the same column names as the other multiple-choice-QA datasets in the library :)

Ok getting closer! I got the dummy data to work. However I am now getting the following error:
aclifton@pop-os:~/data/hf_datasets_sprint/datasets$ RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_logiqa_en
===================================================================== test session starts ======================================================================
platform linux -- Python 3.7.6, pytest-5.3.5, py-1.8.1, pluggy-0.13.1
rootdir: /home/aclifton/data/hf_datasets_sprint/datasets
plugins: astropy-header-0.1.2, xdist-2.1.0, doctestplus-0.5.0, forked-1.3.0, hypothesis-5.5.4, arraydiff-0.3, remotedata-0.3.2, openfiles-0.4.0
collected 0 items / 1 error

============================================================================ ERRORS ============================================================================
________________________________________________________ ERROR collecting tests/test_dataset_common.py _________________________________________________________
ImportError while importing test module '/home/aclifton/data/hf_datasets_sprint/datasets/tests/test_dataset_common.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_dataset_common.py:42: in <module>
    from datasets.packaged_modules import _PACKAGED_DATASETS_MODULES
E   ModuleNotFoundError: No module named 'datasets.packaged_modules'
----------------------------------------------------------------------- Captured stderr ------------------------------------------------------------------------
2021-02-10 11:06:14.345510: W tensorflow/stream_executor/platform/default/dso_loader.cc:59] Could not load dynamic library 'libcudart.so.10.1'; dlerror: libcudart.so.10.1: cannot open shared object file: No such file or directory
2021-02-10 11:06:14.345551: I tensorflow/stream_executor/cuda/cudart_stub.cc:29] Ignore above cudart dlerror if you do not have a GPU set up on your machine.
======================================================================= warnings summary =======================================================================
/home/aclifton/anaconda3/lib/python3.7/site-packages/tensorflow/python/autograph/utils/testing.py:21
  /home/aclifton/anaconda3/lib/python3.7/site-packages/tensorflow/python/autograph/utils/testing.py:21: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    import imp

/home/aclifton/anaconda3/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:693
  /home/aclifton/anaconda3/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:693: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    if not isinstance(type_params, collections.Iterable):

/home/aclifton/anaconda3/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:532
  /home/aclifton/anaconda3/lib/python3.7/site-packages/apache_beam/typehints/typehints.py:532: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    if not isinstance(type_params, (collections.Sequence, set)):

/home/aclifton/anaconda3/lib/python3.7/site-packages/elasticsearch/compat.py:38
  /home/aclifton/anaconda3/lib/python3.7/site-packages/elasticsearch/compat.py:38: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3,and in 3.9 it will stop working
    from collections import Mapping

-- Docs: https://docs.pytest.org/en/latest/warnings.html
================================================================= 4 warnings, 1 error in 2.74s =================================================================
ERROR: not found: /home/aclifton/data/hf_datasets_sprint/datasets/tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_logiqa_en
(no name '/home/aclifton/data/hf_datasets_sprint/datasets/tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_logiqa_en' in any of [<Module test_dataset_common.py>])

Hi ! It looks like the version of datasets that is installed in your environment doesn't match the version of datasets you're using for the tests. Can you try uninstalling datasets and reinstall it again ?
pip uninstall datasets -y
pip install -e .

Closer still!
aclifton@pop-os:~/data/hf_datasets_sprint/datasets$ git commit
[logiqa_en 2664fe7f] fixed several issues with logiqa_en.
 4 files changed, 324 insertions(+)
 create mode 100644 datasets/logiqa_en/README.md
 create mode 100644 datasets/logiqa_en/dataset_infos.json
 create mode 100644 datasets/logiqa_en/dummy/1.1.0/dummy_data.zip
 create mode 100644 datasets/logiqa_en/logiqa_en.py
aclifton@pop-os:~/data/hf_datasets_sprint/datasets$ git fetch upstream
remote: Enumerating objects: 1, done.
remote: Counting objects: 100% (1/1), done.
remote: Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
Unpacking objects: 100% (1/1), 590 bytes | 590.00 KiB/s, done.
From https://github.com/huggingface/datasets
   6e114a0c..318b09eb  master     -> upstream/master
aclifton@pop-os:~/data/hf_datasets_sprint/datasets$ git rebase upstream/master
error: cannot rebase: You have unstaged changes.
error: Please commit or stash them.
aclifton@pop-os:~/data/hf_datasets_sprint/datasets$ git push -u origin logiqa_en
Username for 'https://github.com': aclifton314
Password for<EMAIL_ADDRESS>
To https://github.com/aclifton314/datasets
 ! [rejected]          logiqa_en -> logiqa_en (non-fast-forward)
error: failed to push some refs to 'https://github.com/aclifton314/datasets'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.


Feature/db improvements

Changed to unlimited length text fields PARAMETER  and STACKTRACE
Created index for task name and timestamp fields.

Codecov Report

Merging #11 into master will decrease coverage by 2.43%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
- Coverage     82.96%   80.53%   -2.44%
+ Complexity      142      140       -2
============================================
  Files            18       18
  Lines           452      452
  Branches         33       33
============================================
- Hits            375      364      -11
- Misses           49       59      +10
- Partials         28       29       +1

Impacted Files
Coverage Δ
Complexity Δ

...main/java/os/failsafe/executor/TaskRepository.java
72.03% <0.00%> (-9.33%)
20.00% <0.00%> (-2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2064461...e48cc2d. Read the comment docs.


Added comment branch?

This comment is essential to the final application. Please add it to the master branch.

All good, test complete


Add TUK, Tech University of Korea

한국공학대학교 (Tech University of Korea)
https://www.tukorea.ac.kr/tukorea/index.do
In 2022, Korea Polytechnic University (KPU) changed its name to Tech University of Korea (TUK).
Introduce
The Korea Polytechnic University (abbreviated as KPU or TU Korea in English, from its official English name "Tech University of Korea") is a four-year private university specializing in engineering, located in Siheung, Gyeonggi Province. It was established in 1997 under the supervision of the Ministry of Trade, Industry, and Energy (MOTIE) and operates as an affiliate of the Korea Industrial Complex Corporation (KICOX), a subsidiary of the Ministry.
KPU was founded to nurture skilled industrial technology professionals and started as the Korea University of Technology and Education (KPU). To overcome limitations posed by its status as an industrial university, it transitioned into a general university in 2012. In 2017, legislation was passed to place the university under the umbrella of KICOX, and it officially became a part of the corporation in 2018. In 2022, on its 25th anniversary, the university rebranded itself as Korea Engineering University to mark a new leap forward as a leading institution in engineering and technology.
Guided by its founding philosophy of Silsa Gu Sisa (seeking truth through fact-based practices), the university aims to nurture creative knowledge leaders who will drive the knowledge-based information society of the 21st century, practical experts who lead corporate growth and technological innovation, and global-minded individuals who contribute to international industrial collaboration and progress. By fostering hands-on, high-level technical professionals with creative thinking skills, Korea Engineering University seeks to establish a new model for engineering education, focusing on practical, field-oriented expertise over theoretical knowledge, thus enhancing national competitiveness.

@ParkSeJun I am sorry, the domain tukorea.ac.kr is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


test.py: error: the following arguments are required: --cfg

I was testing satellite images on your trained model, while running text.py on spyder(python 3.6) I faced some errors and I couldn't find its solution anywhere.
usage: test.py [-h] --cfg CFG
test.py: error: the following arguments are required: --cfg
An exception has occurred, use %tb to see the full traceback.
SystemExit: 2

It means you haven't specified a configure file. You may want to have a look at the files in experiments/faster_rcnn/cfgs and then specify your configure file.

Hi @Shamsa279 , actually I cannot get your problem clearly. I'm confused about your problem.
It should go like this:
python experiments/faster_rcnn/rcnn_dota_quadrangle_test.py --cfg experiments/faster_rcnn/cfgs/DOTA_quadrangle.yaml


Category Screen

The Category screen should consist of category names
1)Grid view
2)List View

Completed Switch view of grid and list view


The policy does not disable the local auth, just marks the resources as non-compliant

This article states that you can disable local auth on Cognitive Services by applying a policy:

You can disable local authentication using the Azure policy Cognitive Services accounts should have local authentication methods disabled. You can set it at the subscription level or resource group level to enforce the policy for a group of services.
Disabling local authentication doesn't take effect immediately. Allow a few minutes for the service to block future authentication requests.

I've tried to set the policy, waited a few hours and the DisableLocalAuth was not set, it only marked the resources as non-compliant and there's no remediation task related to it. The only way it worked for me was by running this command to set the value as disabled:
Set-AzCognitiveServicesAccount -ResourceGroupName [group name] -Name [resource name] -DisableLocalAuth $True

Related to this one I opened another issue so this property can also be set with the az cli: Azure/azure-cli#27897

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 2c63d0ad-6433-1b11-d58d-a16f1d1093f6
Version Independent ID: 17ecdf60-4a6c-f57d-2806-98059af09392
Content: Disable local authentication in Azure AI Services - Azure AI services
Content Source: articles/ai-services/disable-local-auth.md
Service: azure-ai-services
GitHub Login: @PatrickFarley
Microsoft Alias: pafarley

@jmservera
Thanks for your feedback! We will investigate and update as appropriate.

@jmservera
Thank you for providing insights into your experience with configuring the Azure policy to disable local authentication on Cognitive Services. While delays in policy implementation are mentioned in the article, if you've waited for a few hours and the policy hasn't taken effect, there may be an issue either with the policy itself or its application. In your case, it appears that utilizing the Set-AzCognitiveServicesAccount command to configure the DisableLocalAuth property proved effective. This serves as a valid alternative to establishing the policy, and it's beneficial to be aware of this option.
I appreciate you highlighting the problem with configuring the DisableLocalAuth property using the az CLI. I trust that the matter will be resolved promptly, enabling users to set this property through the CLI.

@jmservera
We are going to close this thread, if there are any further questions regarding the documentation, please tag me in your reply and we will be happy to continue the conversation.
#Please-close


migrate uses of legacy namespace folly::io::zlib (#10282)

Summary:
Migrate uses of legacy namespace folly::io::zlib to folly::compression::zlib.
Differential Revision: D58821426

@yfeldblum goes without saying, but please make sure this change is backwards compatible as oss builds are pinned on a slightly older version of folly.


Oref0 determine basal arg parsing cleanup

Thanks.  I think this one is worth testing with both an existing dev rig, and with a clean dev install, to make sure the reports aren't a dependency for anything.

I think I can get to that this weekend.

@scottleibrand, this is successfully running on a new rig with a clean dev install.

although looks like I need to check on why the CI failed.

@scottleibrand, I think this is ready.
It's rebased onto dev so the command-behavior-test could be updated to account for the new restrictions on oref0-determine-basal.


SAM detecting games that aren't there

I downloaded SAM and it detected Dota 2 and Team Fortress 2, even though I never played those games.

I downloaded SAM and it detected Dota 2 and Team Fortress 2, even though I never played those games.

This not a problem of SAM sam dont have this as adddefault games :)

Most likely as they are both free games made by Valve.


Remove strongswan as a cable driver option

....as Submariner no longer supports it.
Signed-Off-By: Janki Chhatbar<EMAIL_ADDRESS>

/assign @Jaanki

Please split this up into two separate PRs — one for the strongSwan removal, the other for the documentation link.

/hold

Please split this up into two separate PRs — one for the strongSwan removal, the other for the documentation link.

Done
/remove-hold

/lgtm
/approve

/assign @therealhaoliu

/lgtm


Add more tests for firebase security rules

Bug, feature request, or proposal:
Now that we have support for testing firebase security rules, we should make sure to cover all possible cases.
What is the expected behavior?
Having more tests
What is the current behavior?
Only basic test
What are the steps to reproduce?
Run test suite :)
What is the use-case or motivation for changing an existing behavior?
Better test coverage
Which version of MachineLabs (or the package) is affected ?
latest

Hi @maartentibau,
super cool you want to help out with this. I think generally it's good to have tests for all of our security rules. Those rules can be derived from the read() and write() conditions in firebase/rules/database.rules.bolt.
For example the following security rules describe that only the system is allowed to read and write invocation ids.
path /invocations/{id} {
  read() { isSystem() }
  write() { isSystem() }
}

Here are some more possible specs:

/labs/{id}/common

read

can only be read by system user or owner of the lab, if lab is private

write

can only be written by owner or system user
if owner has no plan (anonymous user), lab can only be written if it's not set to private (is_private = true)
if owner has plan and lab is set private, plan needs to be higher than beta plan (right now this is just hasPlan() && !hasBetaPlan()

/idx/invocation_rate_proof/{userId}

read

can only be read by authenticated users

write

can only be written by authenticated users

/executions/{id}/common

read

can only be read if corresponding lab is not private or
if corresponding lab is private, reader has to be the owner and a higher plan than beta plan
System user can always read

write

can only be written by owner or system user

/executions/{id}/messages

write

can only be written by system user (test that other users can not write)

Hope this helps to get you started @maartentibau !

If you want to test the system user you can create a user object and set the ID to SYSTEM_USER. Here's how it could look like in your tests:
const systemUser = {
    uid: 'SYSTEM_USER,
    id: 1
  },

And then you can use this to test if that particular user can read / write to certain nodes. For example
expect(systemUser).canRead('/invocations/1');

// Make sure the dummy invocation has the correct format
expect(systemUser).canWrite('/invocations/1/common', dummyInvocation);

expect(currentUser).cannotRead('/invocations/1');
expect(currentUser).cannotWrite('/invocations/1/common', dummyInvocation);

Hope this helps you!

Hey @maartentibau
just checking in here.. Are you still interested in pushing this forward?

Hi @PascalPrecht yes.. for sure, but I'm facing some trouble understanding the errors I get with failing tests. Have tried to contact @d3lm, but we didn't yet found a time to have a chat. If you might have some time this evening to have a Skype chat, that would be great to get me started.

@cburgdorf that works, thx! But when I do the import (via WebStorm) the path is always
import { Invocation, InvocationType } from '@machinelabs/models/src'; and not without the src like I see everywhere in the code.
Also, when I run my tests I get this error
 /Users/webtrix/GitHub/machinelabs/firebase/rules/node_modules/@machinelabs/models/src/index.ts:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){export * from './execution';

SyntaxError: Unexpected token export at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/ScriptTransformer.js:289:17)at Object.<anonymous> (tests/invocations.spec.ts:14:13)

Also I noticed that the property directory of the model InvocationLab is typed as File[], but in the rules it's just a string, will this change in the future?

I think there's a couple of things to say about this:

I think, actually, InvocationLab.directory should be rather of type LabDirectory, which is essentially Array<File | Directory>. This is because a directory is not just a list of files, but a list of files and other directories. My guess is, that this is just a left over and should be changed to LabDirectory. The LabDirectory type can be imported from @machinelabs/models as well - specifically here: https://github.com/machinelabs/machinelabs/blob/master/shared/models/src/directory.ts#L18

Before the data of an invocation is stored in the database, the directory gets stringified on purpose (https://github.com/machinelabs/machinelabs/blob/master/client/src/app/editor/remote-code-execution/remote-lab-exec.service.ts#L56). On of the reasons is that you can't store recursive data structures in Firebase database easily, plus, if I remember correctly (/cc'ing @cburgdorf for correctness) there's some limitation on how many levels deep you can go with your nodes. By stringifying the directory, we basically just have to handle one long string that is, at the time of saving, deterministic. This also means that we parse the data again when we pull it out of the database (https://github.com/machinelabs/machinelabs/blob/master/client/src/app/editor/remote-code-execution/remote-lab-exec.service.ts#L124-L126).

So to answer your question, this is not something we want to change in the future.

import { Invocation, InvocationType } from '@machinelabs/models/src'; and not without the src like I see everywhere in the code.

Yes, you need to import from @machinelabs/models. This requires you to, as @cburgdorf said, link @machinelabs/models as a dependency. Also, the source of that package needs to be build accordingly. For that you can run the build.js script in shared.
I assume that'll fix your error as well.

I think I've covered all test cases for the 'invocations', could you guys maybe have a look and tell me if what I'm doing is what you're expecting? Or if you have remarks or tips, feel free to poke me 😉

That's awesome @maartentibau!
I'll have a look at it today.
On Twitter you asked me a question, let me echo it here so we can keep track of things:

Whats actually the difference between /invocations/1/common and /invocations/1 ?

So you'll notice that not only /invocations but also other nodes in our system follow this pattern of having a /common and /protected child node respectively. This is due to how firebase rules and validation cascading works. For example, if /invocations is readable, all its child nodes will be readable as well.
That's because, unlike Firebase FireStore, Firebase Realtime Database isn't a document based database. Which means, you can't perform queries that only fetch a subset of a certain nodes without its children.
So in order to have nodes that have both, data that should be readable (by everyone), but also data that's considered protected, you can work around this by creating child nodes for public and protected access respectively.
/invocations/{id}/common is therefore considered "readable", "public" data. /invocations/{id}/protected is considered protected data and not readable by everyone.
The names common and protected are somewhat  arbitrary if you will. We could've called them "public" and "private as well. For semantic reasons however, we went with "common" and "protected".
Here's another concrete example from the past, in case you're interested to follow up on this: https://github.com/machinelabs/machinelabs/pull/140#issuecomment-303223367
Hope this answers your question.


Refs #36: Add support for inplace int and string multiplications

Added in-place int multiplication for strings, floats, lists, byte arrays, bytes, tuples, and complex numbers. Sorry the commit history for this is a bit messy; let me know if you want me to squash it. (Realized afterwards I maybe did a bit too much -- let me know if you want me to remove some of this).

Ignore this. Messed up a bit and am starting over--will make a new one when I actually figure out what I'm doing :)


Add instructions to install RethinkDB

Right now README.md displays only instructions on how to install RethinkDB for Ubuntu. I added a link to their official documentation on how to install it on other platforms.

:+1:

Current coverage is 0.00%

Merging #11 into develop will not affect coverage as of 301ac04

No diff could be generated. No reports for #11 found.
Review entire Coverage Diff as of 301ac04

Powered by Codecov. Updated on successful CI builds.


make vcs details optional

if the project is not versioned, there wont be a host

[x] make vcs details optional
[ ] also, the vcs details are really vcs-host details, so might be worth changing the name to clarify

i dont think the second task applies anymore, so closing


View control mouse interaction issues

Environment

OS Version: Ubuntu 18.04
Source or binary build?
both binary and source, ignition fortress pre2

Description
I ran into a few gui view control interaction issues with the mouse.  I don't see these issues using the old GzScene3D plugin.
I can separate them into different issues if needed.

Incorrect mouse anchor point.

This doesn't happen all the time but it happens often enough that it's quite easily reproducible on my machine. I also see incorrect anchor points for panning the camera from time to time, e.g. camera jumps when panning after resizing the render window or unexpected large camera pan movement because anchor point used is closer than actual point.

Context menu triggered on mouse release after a zoom action

Looks like the menu is triggered on all right mouse button releases. We should not open the context menu after a mouse right button drag.

Scroll zoom moves camera in wrong direction

The first zoom with scroll button works as expected. However, if you try to zoom again in the opposite direction, the first scroll increment will be in the wrong direction (still in the previous direction) correct.

Fixes on #295


problem with batch production

Hi All,
Inspiring by the tutorial called “Text generation with an RNN” (https://www.tensorflow.org/text/tutorials/text_generation), I managed to train a model to generate new molecules in SMILES string format. It has been trained very well and I could generate new molecules either consecutively (one after another) and batch production. However, when I saved the trained model and loaded it again, the batch production fails and ends up with an error. could someone help please?

Hello @Jalil-Mahdizadeh ,
We see that the issue template has not been filled, could you do so as it helps us to analyse the issue [tf version, steps followed before you ran into this error or stand alone code to reproduce the issue faced] or if possible please share a colab gist with the issue reported.

Hi,
I just directly pressed the button "Run in Google Colab" from this page : https://www.tensorflow.org/text/tutorials/text_generation
The steps that I followed:
1- I trained the model successfully
2- I was able to generate text with a single input using the trained model
3- I was able to generate text with a batched input using the trained model
4- I saved the one-step model successfully
5- I loaded the saved model successfully
6- I was able to generate text with a single input using the loaded model
7- I COULD NOT generate text with a batched input using the loaded model

Here is the error I got:
ValueError                                Traceback (most recent call last)
 in ()
4
5 for n in range(1000):
----> 6   next_char, states = one_step_reloaded.generate_one_step(next_char, states=states)
7   result.append(next_char)
8
1 frames
/usr/local/lib/python3.7/dist-packages/tensorflow/python/saved_model/function_deserialization.py in restored_function_body(*args, **kwargs)
282           .format(index + 1, _pretty_format_positional(positional), keyword))
283     raise ValueError(
--> 284         "Could not find matching concrete function to call loaded from the "
285         f"SavedModel. Got:\n  {_pretty_format_positional(args)}\n  Keyword "
286         f"arguments: {kwargs}\n\n Expected these arguments to match one of the "
ValueError: Could not find matching concrete function to call loaded from the SavedModel. Got:
Positional arguments (2 total):
* Tensor("inputs:0", shape=(2,), dtype=string)
* None
Keyword arguments: {}
Expected these arguments to match one of the following 4 option(s):
Option 1:
Positional arguments (2 total):
* TensorSpec(shape=(1,), dtype=tf.string, name='inputs')
* None
Keyword arguments: {}
Option 2:
Positional arguments (2 total):
* TensorSpec(shape=(1,), dtype=tf.string, name='inputs')
* TensorSpec(shape=(1, 1024), dtype=tf.float32, name='states')
Keyword arguments: {}
Option 3:
Positional arguments (2 total):
* TensorSpec(shape=(5,), dtype=tf.string, name='inputs')
* None
Keyword arguments: {}
Option 4:
Positional arguments (2 total):
* TensorSpec(shape=(5,), dtype=tf.string, name='inputs')
* TensorSpec(shape=(5, 1024), dtype=tf.float32, name='states')
Keyword arguments: {}

Hi,
I just directly pressed the button "Run in Google Colab" from this page : https://www.tensorflow.org/text/tutorials/text_generation
The steps that I followed:
1- I trained the model successfully
2- I was able to generate text with a single input using the trained model
3- I was able to generate text with a batched input using the trained model
4- I saved the one-step model successfully
5- I loaded the saved model successfully
6- I was able to generate text with a single input using the loaded model
7- I COULD NOT generate text with a batched input using the loaded model
Here is the error I got:
ValueError Traceback (most recent call last)
in ()
4
5 for n in range(1000):
----> 6 next_char, states = one_step_reloaded.generate_one_step(next_char, states=states)
7 result.append(next_char)
8
1 frames
/usr/local/lib/python3.7/dist-packages/tensorflow/python/saved_model/function_deserialization.pyhttps://localhost:8080/ in restored_function_body(*args, **kwargs)
282 .format(index + 1, _pretty_format_positional(positional), keyword))
283 raise ValueError(
--> 284 "Could not find matching concrete function to call loaded from the "
285 f"SavedModel. Got:\n {_pretty_format_positional(args)}\n Keyword "
286 f"arguments: {kwargs}\n\n Expected these arguments to match one of the "
ValueError: Could not find matching concrete function to call loaded from the SavedModel. Got:
Positional arguments (2 total):

Tensor("inputs:0", shape=(2,), dtype=string)
None
Keyword arguments: {}
Expected these arguments to match one of the following 4 option(s):
Option 1:
Positional arguments (2 total):
TensorSpec(shape=(1,), dtype=tf.string, name='inputs')
None
Keyword arguments: {}
Option 2:
Positional arguments (2 total):
TensorSpec(shape=(1,), dtype=tf.string, name='inputs')
TensorSpec(shape=(1, 1024), dtype=tf.float32, name='states')
Keyword arguments: {}
Option 3:
Positional arguments (2 total):
TensorSpec(shape=(5,), dtype=tf.string, name='inputs')
None
Keyword arguments: {}
Option 4:
Positional arguments (2 total):
TensorSpec(shape=(5,), dtype=tf.string, name='inputs')
TensorSpec(shape=(5, 1024), dtype=tf.float32, name='states')
Keyword arguments: {}

From: tilakrayal @.>
Sent: Tuesday, May 17, 2022 11:09 AM
To: tensorflow/tensorflow @.>
Cc: Sayyed Jalil Mahdizadeh @.>; Mention @.>
Subject: Re: [tensorflow/tensorflow] problem with batch production (Issue #56121)
Hello @Jalil-Mahdizadehhttps://github.com/Jalil-Mahdizadeh ,
We see that the issue templatehttps://github.com/tensorflow/tensorflow/issues/new/choose has not been filled, could you do so as it helps us to analyse the issue [tf version, steps followed before you ran into this error or stand alone code to reproduce the issue faced] or if possible please share a colab gist with the issue reported.
—
Reply to this email directly, view it on GitHubhttps://github.com/tensorflow/tensorflow/issues/56121#issuecomment-1128616462, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASE2M6KSR5UUYZYUAXMJTULVKNO2FANCNFSM5WCILZ7A.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>

@Jalil-Mahdizadeh ,
I was able to execute the given code without any issues. Please find the gist of it here.

Hi
It is still not working when I tried to batched generate text by "one_step_reloaded" https://colab.research.google.com/gist/tilakrayal/1e3b0be6e3530f5bd0a50ce0e88da509/text_generation.ipynb

@gowthamkpr ,
I was able to reproduce the issue in tensorflow v2.8, and in v2.7 and nightly the code was failing with different error.Please find the gist.

@Jalil-Mahdizadeh Please take a look at this issue and try all the suggestions mentioned in it and let me know if it helps.
Also take a look at the solutions provided here. Thanks!


Run with Python 3 only

Issue number of the reported bug or feature request: this is a resubmission of https://github.com/bloomberg/python-github-webhook/pull/14
Describe your changes
We drop support for Python 2 which allows us to remove dependencies on mock and six. The minimum Python version is now specified in setup.py.
Testing performed
I've done static review, will probably run it our CI setup shortly.
Additional context
As mentioned earlier, this is a resubmitted version of https://github.com/bloomberg/python-github-webhook/pull/14 to just focus on removing the Python 2 code/dependencies. I backed out the other functional changes so that the scope of this one is smaller and then rebased it against master.

CI is failing because the black style has changed since - I can reformat it if you all want but also didn't want to add extra stuff in to this PR.


Fixed KeyError and UnboundLocalError exceptions on page revision view

centralized check to see if an admin URL request is for history/recovery
fixed KeyError exception ("Key u'<problematic_placeholder_name>' not found in Form"),
raised when a page revision is viewed and template for the page has changed
since the time the revision has been stored, specifically when a new
placeholder has been added that did not exist in the saved revision
fixed UnboundLocalError exception ("local variable 'placeholder' referenced
before assignment"), which occurs when a page revision is viewed and no
placeholders are found for some reason.

This fixes Issue #3814 and Issue #3815

@yakky is this still relevant? given we've dropped 2.4 support.

@czpython I think we can merge this, even if we're not going to release any further 2.4 releases


Java library for bindings doesn't exist

Java uses an attribute model similar to .NET, but the library is created here: https://github.com/azure/azure-functions-java-library
There isn't a great way using that library to do a flexible custom trigger / binding.  It's very limited today. This is the closest I can get:
            @CustomBinding(name = "triggerData", direction = "in", type = "daprBindingTrigger") byte[] triggerData,
            final ExecutionContext context) throws UnsupportedEncodingException {
        context.getLogger().info("Java HTTP trigger processed a request.");

But it doesn't let me define other function.json properties I need like BindingName - so fully blocked for now

Closing this issue as Java support is added here along with samples.
Here is the released maven package.


Universal APN Credential Marked Invalid

Description
We have created a universal (production + development) APN certificate for our VoIP application and made corresponding Twilio Push Credentials (one sandboxed for development and one not).
When trying to place a call with sandboxed credentials on two debug instances of the application the recipient's phone does not receive the call. We are also getting a Twilio Error - 52134 "Invalid APNs device token" in the Twilio console for these calls.
Steps to Reproduce

Build the caller's application in debug on iOS simulator

Build the call recipient's application in debug on a physical device

When both applications are logged in they receive an Access Token from our server and it's been granted sandbox push credentials

Place a call from the simulator to the physical device

We have had success calling from the simulator before, just as long as the recipient application is not running in simulator (since it cannot receive push notifications).
Expected Behavior
Recipient's phone to receive a push notification and begin ringing
Actual Behavior
Caller's phone rings until timeout and recipient never receives call
Reproduces How Often
This happens on every call attempt with these development builds, but we've had successful calls in our recent TestFlight builds for physical devices (which use the non-sandboxed push credential).
Voice iOS SDK
2.0.0-beta13 via CocoaPods
Xcode
Both 8.2.1 and 9.1.0 during testing
iOS Version
10.2 and 11.0
iOS Device
Physical iPhone 7 Plus
Simulated iPhone 7 Plus and iPhone 7

Hi @lassandroan
Thanks for reporting the issue with the template.
Could you provide us the Twilio Account SID and Push Credential SID for the sandbox environment via email? (you know where to find it) Please tag the email with this issue and remember not post any of your credentials here. I'll take a look and check with the Twilio Notify service team to see if there is anything wrong with the VoIP certificate and the (sandbox) push credential SID, and then get back to you here.
Quick question - on the device that you were not getting push notifications for incoming call invites, are both development and production VoIP environments being used, i.e. the same device and same identity used for testing development and production versions of the app? During our dev process we sometimes see the device not getting the notification after installing (from HockeyApp) the release version app and registered. If I then restart the app and register again, I am able to get the notification. Luckily this won't be happening to app end users.
Anyway, we'll take a look at the credentials and get back to you soon.
Thanks.
bobie

Thanks @bchen-twilio, just sent over the email!
We did have a TestFlight build as well as an Xcode debug build on the physical device. However, when testing out the calls the Xcode debug build was logged in with a different account than the TestFlight build.
We also logged out from both app builds just to be sure and were verifying identity using the Twilio Access Token that the debug app was receiving

Thanks for providing us the creds. I'll do what the SDK team can do to dig up more info why the notification delivery failed. Unfortunately most of the Twilio Notify service team members are in Central Europe timezone, which is already their time off but I'll still reach out to them since only they have the permission to query the service DB.
As for using different accounts for debug and release versions, as long as the Push Credential SID belongs to the Account SID (this should check out during registration, otherwise you should get a failure) and the Push Credential SID is generated from the VoIP certificate for the application bundle ID.

Hi @lassandroan
Sorry for my delay of responding back to you.
We've run your Twilio Account SID and the Push Credential SID (ending with a3af) - based on the description of the certificate, it's actually the certificate for a regular APNS.
For the best integration experience, we would recommend that Voice SDK users create their VoIP Service certificate using a fresh CSR (certificate signing request) file. We've seen similar issue reported by other SDK users because the same CSR file was used to create a regular APNS cert.
Let me know if this helps.
Thanks.
-bobie

Hey @bchen-twilio, sorry about the late response
Swapping out for the VoIP certificate fixed our calling issue, thank you!

That's great @lassandroan!

@bchen-twilio I'm facing the same issue. I already have a VoIP Certificate and my SandBox is checked.
On Development it works great. I already created a new CSR and all.

Hi @RUIFERNANDE5
Sorry that you are experiencing the issue.
Could you send your Twilio account SID and (sandbox) Push Credential SID to my email? it'd be better if you can also send me the call SID that you were seeing push notification delivery failure.
Don't post any of your credentials here ;)
Thanks.
-bobie

Hi @RUIFERNANDE5
I've run your credentials and basically things look good to me - the Push Credentials does have sandbox signature in it and the call push notification (of the Call SID you provided) was also delivered successfully.
 The SID also has the sandbox option checked. Is it possible that you are using this push credential SID in your production app?

@bchen-twilio When I found this thread I redid the push certificates / credentials. So, both credentials you're seeing are VoIP certificate keys with sandbox signatures. Not sure what to look for anymore..
Also, not related to this issue but if you could help me on another issue Im having regarding twilio-voice.  Here

Also, in logs I have the following:

Make sure you do not modify the device token before providing it to Twilio. If using a command line tool make sure to url-encode the token.

I'm not sure what this means at all

Let's clarify this - the Push Credential SID works for your in development but not working in the production app?
As for the problem you are seeing in the SO thread - you need to prefix client: in your callerId, otherwise the Twilio Programmable Voice will treat it as a number and dialpad-translates it. Hope this helps.

Yes! It works on development!
Aside:
You were right about the client thing, but now on callKit in iOS it shows 'client:Jose'? Shouldn't it take care of it? Even if I trim the client: string on my app call screen, it will always show 'client:Jose' on calls history.
Thank you!

I think what gets displayed in the system call screen is actually decided when you report the incoming call to CallKit, so you should be able to retrieve what's behind the client: prefix and display to the user.
As for the credential SID - I know this can be confusing but when your app is going production, you will need to create another Push Credential SID

with the same VoIP cert for this app (bundle ID)
only this time don't check the sandbox option
This way the Twilio Notify service knows to send the push notification to the Apple's production APNS service endpoint and then the notification will be delivered to the mobile clients.

@bchen-twilio Alright, thank you very much. I can't test right now but I will tomorrow morning.

I confirm creating a new credential (without the sandbox option) with the same VoIP certificate solved my problem!

That is great! @RUIFERNANDE5
Please feel free to contact us if you run into any problem in the future.


UX fix - Delay hover activation in navigation

The case
If you accidentally hover over the wrong button in the navigation, it will overlap the button you want to interact with.

The fix
Adding a 100ms delay before activating or deactivating the component it will be more forgiving to the user.

Thanks!


"Compatible" hides valid MSU

Hey, not really sure how to debug or provide appropriate information here, but if I have the filter set to "Compatible" it's hiding MSUs that I have used as valid MSUs in ALTTP before.
Specifically I am using the Sonic 2 MSU, and it gets filtered out with compatible on. If I set the filter to "All" it will show up, and if I use it it works correctly.

I should probably have written this better. If you look at the UI it does show as "Unknown" instead of Link to the Past.

I guess the question here is why is this MSU which is a valid ALTTPR MSU is showing as unknown. Is it looking for specific files?

Won't bore you with the details, but I think what's most likely the issue is with how I try to distinguish between Super Metroid MSUs with the future extended tracks and Z3 MSUs. I'm overhauling the way all this works in the next version so that it'll hopefully be better. Worst case scenario, I'm adding in a function into the next version for you to be able to override default MSU types.
That being said, there shouldn't be much of a downside of selecting Unknown tracks until the new version comes out in a couple weeks.
(BTW, nice choices with Steins;Gate and Umineko MSUs 👍)

I'm glad you like them! The S;G is a personal one I made (the Danganronpa is also a personal one, not Zelga's one)--I don't think anyone else has actually taken that one on. The Umineko one I just love the music from that series so much.
This is a small potatoes thing and not a problem to deal with at all, just figured if something was broken you'd probably want to know. Sounds like you're aware and it won't matter. Thanks for the response!

I've created a release candidate here: https://github.com/MattEqualsCoder/MSURandomizer/releases/tag/v0.9.7-rc.1
The MSU detection is completely different and may not work in 100% of cases still because there are some unusual corner cases where people do things differently, but you can now override the MSU type if needed. Let me know if you run into any problems.


Session Destroy and Regenerate not working

I can't seem to get sessions to be destroyed or regenerated. I've tried both memcache and mysql but store.Destroy() and store.Regenerate() aren't doing anything that I can tell. Am I doing something wrong?
Mac OSX        : 10.15.4
Fiber          : v1.12.0
Fiber Session  : v1.2.1

Could you provide a example code to re-produce?

Here's the flow:
/:
/: Logged in
/: true
/logout: Logged out
/: true Expected <nil>
package main

import (
	"github.com/gofiber/fiber"
	"github.com/gofiber/session"
)

func main() {
	app := fiber.New()
	sessions = session.New(session.Config{Secure: true})

	app.Get("/", func(c *fiber.Ctx) {
		store := sessions.Get(c)
		defer store.Save()

		c.Send(store.Get("valid"))
	})

	app.Get("/login", func(c *fiber.Ctx) {
		store := sessions.Get(c)
		defer store.Save()
		store.Set("valid", true)
		c.Send("Logged in! ", store.ID())
	})

	app.Get("/logout", func(c *fiber.Ctx) {
		store := sessions.Get(c)
		defer store.Save()
		store.Destroy()
		c.Send("Logged out!")
	})

	app.Listen(3000)
}

Thank you, I can see that Destroy does not work correctly. We will investigate and keep you updated.

Awesome thanks!

Hi @DanielAtwood
I have tested this locally as well and it seems that store.Destroy() does indeed not remove entries from the session provider.
I do think this is a problem the underlying fasthttp/session.
@Fenny Maybe it's worth to do some more testing and creating an issue there?

I ran this locally and all of the functions worked with mysql and memory. fasthttp/session seems to work just fine.
fasthttp/session examples

@DanielAtwood thanks for the report, fixed in https://github.com/gofiber/session/releases/tag/v1.2.2 ❤


Fixing spelling mistakes; this effects DECOMMISSIONED enumeration

Thanks. I trust git blame won't hold me responsible for these, but better not to check :).


Zenuml support

:bookmark_tabs: Summary
Ported Zen UML to Mermaid
:straight_ruler: Design Decisions

Created a new package mermaid-zenuml.
Allowed for lazyloading of the mermaid-zenuml diagram

:clipboard: Tasks
Make sure you

[x] :book: have read the contribution guidelines
[ ] :computer: have added unit/e2e tests (if appropriate)
[x] :bookmark: targeted develop branch

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.648%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
13203

Relevant Lines:
28213

💛  - Coveralls

Added ZenUML support.


Long delay to open Command Pallete after installation

I noticed it via this HN comment: https://news.ycombinator.com/item?id=17282926
I have the same Sublime Text setup on macOS 10.13 and Windows 10 and it only shows this issue on Windows.
The log on both systems shows this when I open the command pallete and it seems to be unrelated as it happens also on the not affected macOS.
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): localhost
WINDOW COMMAND ENABLED True
WINDOW COMMAND ENABLED True
WINDOW COMMAND ENABLED True
WINDOW COMMAND ENABLED True
WINDOW COMMAND ENABLED True
WINDOW COMMAND ENABLED False

Thanks for reporting this, will investigate


Deploying FHIR server in Azure with convert data flag enabled gives SQL error

Describe the bug
I am trying to deploy the FHIR server in Azure using this template -
https://portal.azure.com/#create/Microsoft.Template/uri/https%3A%2F%2Fraw.githubusercontent.com%2FMicrosoft%2Ffhir-server%2Fmain%2Fsamples%2Ftemplates%2Fdefault-azuredeploy-docker.json
These are the settings I am using in the template:

The deployment gets completed but the application never gets up. It throws the following error:
 Error from SQL database on upserting InstanceSchema information 2022-02-18T18:16:04.793236444Z       Microsoft.Data.SqlClient.SqlException (0x80131904): Could not find stored procedure 'dbo.UpsertInstanceSchema'. 2022-02-18T18:16:04.793246144Z          at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction)
2022-02-18T18:16:04.799508507Z          at Microsoft.Data.SqlClient.SqlInternalConnection.OnError(SqlException exception, Boolean breakConnection, Action1 wrapCloseInAction) 2022-02-18T18:16:04.799518707Z          at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, Boolean callerHasConnectionLock, Boolean asyncClose) 2022-02-18T18:16:04.799522707Z          at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady) 2022-02-18T18:16:04.799526907Z          at Microsoft.Data.SqlClient.SqlDataReader.TryConsumeMetaData() 2022-02-18T18:16:04.799530407Z          at Microsoft.Data.SqlClient.SqlDataReader.get_MetaData() 2022-02-18T18:16:04.801369766Z          at Microsoft.Data.SqlClient.SqlCommand.FinishExecuteReader(SqlDataReader ds, RunBehavior runBehavior, String resetOptionsString, Boolean isInternal, Boolean forDescribeParameterEncryption, Boolean shouldCacheForAlwaysEncrypted) 2022-02-18T18:16:04.801381666Z          at Microsoft.Data.SqlClient.SqlCommand.CompleteAsyncExecuteReader(Boolean isInternal, Boolean forDescribeParameterEncryption) 2022-02-18T18:16:04.801385766Z          at Microsoft.Data.SqlClient.SqlCommand.InternalEndExecuteReader(IAsyncResult asyncResult, Boolean isInternal, String endMethod) 2022-02-18T18:16:04.801390566Z          at Microsoft.Data.SqlClient.SqlCommand.EndExecuteReaderInternal(IAsyncResult asyncResult) 2022-02-18T18:16:04.801500464Z          at Microsoft.Data.SqlClient.SqlCommand.EndExecuteReaderAsync(IAsyncResult asyncResult) 2022-02-18T18:16:04.801504863Z          at Microsoft.Data.SqlClient.SqlCommand.EndExecuteReaderAsyncCallback(IAsyncResult asyncResult) 2022-02-18T18:16:04.801512663Z          at System.Threading.Tasks.TaskFactory1.FromAsyncCoreLogic(IAsyncResult iar, Func2 endFunction, Action1 endAction, Task1 promise, Boolean
FHIR Version?
R4
Data provider?
SQL Server
To Reproduce
Steps to reproduce the behavior:

Use the Azure template in this page to deploy the FHIR server in Azure - https://github.com/Microsoft/fhir-server/blob/main/docs/DefaultDeployment.md
Choose config settings for SQL Server and Convert Data flag enabled
Check the application logs

Expected behavior
The app should be up and running
Actual behavior
App throws SQL exception
Note: When I deploy this app without the convert data flag, i do not see this error in the logs
Log File:
2022_02_18_lw1sdlwk0000EQ_default_docker.log

Any updates on this guys?

hi @sushil-clearsense , seems the Sql Schema Automic Updates Enabled is set to tool which means the sql schema will not be initialized or upgraded on the server startup. The schema migration tool will be required to perform initialize or upgrade. If you set to 'auto', sql schema will be upgraded to the maximum supported version.
See the [Schema Migration Tool] for reference


yarn start doesn't work?

moved from https://github.com/facebook/relay/issues/2836

Seems to work for me, also on a macbook.

Can you check you're on master @j4nos?

Also works for me on a macbook.


DBZ-4949 Compile Debezium core after JDK 17 is installed

hey @vjuranek could you merge this please? I want to base my other stuff on top of that.

@vjuranek In urgent cases (like build not running) feel free to merge the PR yourself and just ping me in the ocmment. There's no need for introducing delays in such cases.


Loging in is impossible

Before you start

[x] Have you updated FluentHub? You might be using an old version.
[X] Have you checked if a similar issue has already been reported?

What version of Windows is this issue present?
Windows 11
What version/architecture of FluentHub are you on?
FluentHub <IP_ADDRESS> | X64 | RELEASE
Description
The redirect after the authentication is not working. After logging in and authorizing nothing happens. I use arc / FluentHub from mss.
Steps To Reproduce

Open the app
Click "login with github"
Authorize
Wait.
Nothing happens.

Expected behavior
The content on the app changes and perhaps you can access the home page at this point.
Stack Trace
Stack trace details
No error message

Assets

The app should have Here we go! button after authorization with successful notification banner.
Could you try the URL on another browser?

Fixed. Turns out the FluentHub app needs to be closed before authorizing in the browser.

Note that this might be an issue with your browser.
I have tested only with Edge and Chrome.


Refactor error handling

Went through and looked at all error handling that uses TaskFailureLogger to ensure that each case has some sensible error handling beyond logging.  In most cases I split onCompleteListener into separate onSuccessListener and onFailureListeners.
Also fixed a crash that can come from repeated uses of GoogleApiClientTaskHelper.
This addresses the following issues:

#257
#287

@amandle PTAL, this is a somewhat large refactor (although not much new logic, still room for errors)

@samtstern LGTM!