Synchronization?

I was wondering how this library handles synchronization. It would appear the answer is that it doesn't, but please correct me if I'm wrong. (In which case, documentation would be nice. :) )
For example, with two tabs using localStorage, each tab will read from localStorage when the middleware is initialized, after which point they will blindly write over each other's writes. (So, whichever tab writes last wins, and the data is not synchronized to the other tab until the app is reloaded.)

I don't think the changes feed is been listened to.
You should checkout redux-pouchdb, it is simpler than this but may suits your needs.

This advice causes to install and depend on whole pouchDB library
@aij did you found satisfying solution?

HI @aij,
You're right; the behaviour you describe is indeed what I would expect to happen.
I hadn't considered this use case/scenario before, my first reaction would be to write a piece of middleware that listens to the 'storage' event and dispatch those changes to update the store state of the other tab(s). Your reducer(s) would consequently determine how to merge these changes.
Is this something you considered? Are there issues you run into with this approach?

I think this improvement should be considered essential for the library. Otherwise, it's limited to a very few use cases, and you basically cannot use it for storing auth tokens for instance.

FWIW, I ended up using redux-persist with redux-persist-crosstab, and handling the the REHYDRATE action explicitly to merge the changes in my reducer. I also had to work around an infinite loop in IE.

@aij thanks, that helped. We just implemented the same approach, exactly what we needed.


How to get the min/max_geo_loc

Hello, thanks for the great work!
I have learned the code and have a question in  lane_render.py: the code tried to get the map_geo_loc  with the following code,
train_min_geo_loc = {'singapore-onenorth': np.array([118., 420.]) - bev_radius,
                     'boston-seaport': np.array([298., 328.]) - bev_radius,
                     'singapore-queenstown': np.array([347., 862.]) - bev_radius,
                     'singapore-hollandvillage': np.array([442., 902.]) - bev_radius}
train_max_geo_loc = {'singapore-onenorth': np.array([1232., 1777.]) + bev_radius,
                     'boston-seaport': np.array([2527., 1896.]) + bev_radius,
                     'singapore-queenstown': np.array([2686., 3298.]) + bev_radius,
                     'singapore-hollandvillage': np.array([2490., 2839.]) + bev_radius}
val_min_geo_loc = {'singapore-onenorth': np.array([118., 408.]) - bev_radius,
                   'boston-seaport': np.array([412., 555.]) - bev_radius,
                   'singapore-queenstown': np.array([524., 871.]) - bev_radius,
                   'singapore-hollandvillage': np.array([608., 2007.]) - bev_radius}
val_max_geo_loc = {'singapore-onenorth': np.array([1232., 1732.]) + bev_radius,
                   'boston-seaport': np.array([2367., 1720.]) + bev_radius,
                   'singapore-queenstown': np.array([2044., 3333.]) + bev_radius,
                   'singapore-hollandvillage': np.array([2460., 2836.]) + bev_radius}

I'm not quite sure how to obtain these specific values (such as np.array([118., 420.]),  I tried to locate them in the nuscenes-devkit based on these values, but I couldn't find the corresponding points.
Could you please explain what these values mean? And how were they obtained?
Thanks a lot !

Thank you for your interest in our project. In our project, we need to build a global map, and since the samples in the nuscene are distributed across four cities, we need to create a separate global map for each city. 'min_geo_loc' and 'max_geo_loc' are the geographic coordinates of the top-left and bottom-right of the virtual global map, respectively. Setting these geographic coordinates ensures that the online maps constructed for each sample in the dataset can be recorded based on the geographic location of the sample as a prior. I have uploaded the code for calculating these two variables here.


Error Loading File - Not a diagram file (error on line 3541 at column 2598: AttValue: " expected

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.
If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.
Describe the bug
A clear and concise description of what the bug is.
I tried opening a .dawio file I worked on yesterday just fine.  When opening today and I get the error window "Error loading File.  Not a diagram file (error on line 3541 at column 2598: AttValue: " expected)".
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
I expect to be able to open my file again.
Screenshots
If applicable, add screenshots to help explain your problem.

draw.io version (In the Help->About menu of the draw.io editor):

draw.io version x.y.z  Desktop draw.io version v21.8.2

Desktop (please complete the following information):

OS: [e.g. iOS]  Win10
Browser [e.g. chrome, safari]  Desktop draw.io, but same error occurs when using the online version via Chrome 117.0.5938.63
Browser Version [e.g. 22]  n/a

Smartphone (please complete the following information):

Device: [e.g. iPhone6]  n/a
OS: [e.g. iOS8.1]  n/a
Browser [e.g. stock browser, safari]  n/a
Version [e.g. 22]  n/a

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

No clue what this is.

Additional context
Add any other context about the problem here.

Please attach the diagram file.

Unfortunately, due to project constraints I am unable to release the drawings offsite.
From: Gaudenz Alder @.>
Sent: Sunday, October 1, 2023 11:01 PM
To: jgraph/drawio @.>
Cc: Neurath, Hansel @.>; Author @.>
Subject: Re: [jgraph/drawio] Error Loading File - Not a diagram file (error on line 3541 at column 2598: AttValue: " expected (Issue #3888)
Please attach the diagram file.
—
Reply to this email directly, view it on GitHubhttps://urldefense.us/v3/__https:/github.com/jgraph/drawio/issues/3888*issuecomment-1742437740__;Iw!!G2kpM7uM-TzIFchu!3lL5zevO4NnWNrsgDKDXeD-77ti4nVi_kKHXllzvvWuQFGzrGIAaUww02SM-9EmGmcPHdb9ORKzd0XZxok7ISqQ1dw$, or unsubscribehttps://urldefense.us/v3/__https:/github.com/notifications/unsubscribe-auth/AGGCKSJXHN65G4SGTNOQDA3X5JKCXANCNFSM6AAAAAA5IWT23A__;!!G2kpM7uM-TzIFchu!3lL5zevO4NnWNrsgDKDXeD-77ti4nVi_kKHXllzvvWuQFGzrGIAaUww02SM-9EmGmcPHdb9ORKzd0XZxok6wtPeGKQ$.
You are receiving this because you authored the thread.Message ID<EMAIL_ADDRESS>

Then we can't investigate.


Can modify switch save files?

Can I modify my own switch save file?

Do you even tried grabbing the save file? "just google it up lol"
It should be named with 32 characters and maybe with .dat extension or otherwise the switch version will always read the file as .dat and ignoring the extension.

but it shows "the file was in unexpected format"

but it still shows "the save file is in an unexpected format"

See my post here: https://github.com/CutFlame/MCDSaveEdit/issues/117


Suggestion: Unify example config file extension

I deployed nebula on some of my machines after listening to a recent episode of Linux Unplugged. It worked really well. Thank you.
One issue that I ran into while setting up systemd service on a linux machine is that, due to the yaml file extension mismatch between the provided example config file and the service file, the service refuse to start. The example config file is named "config.yaml" while the config file path in the systemd service file is "/etc/nebula/config.yml". Toke me a while to figure out.
I would suggest unifying the file extensions to save some head scratch for new users.

Good suggestion, and thanks for noting this! We will probably change the example file name.


Sometimes the project/task id isn't added when creating a new project/task

To prevent unnecessary api calls and latency, when a Project or Task is created, it immediately updates the object with its own id. Sometimes this fails.
Potential solutions:

Use synchronized arrays
Use a fallback api call in case no id is present

This may be related to the getFormType method in cherryform.js. Need to revisit this.


Possible issue with your current naming method.

Came across a possible issue..
If you use the current photo naming method in your script there's a possibility to lose photos, because username_10.jpg today, can be a different than username_10.jpg from last week, if you've uploaded an image, and deleted one.
My personal fix is to just keep the original file name that Instagram supplies.
Not using a pull request to show this, because I just want you to know of a possible issue, and my code isn't the best.
            rawUrl = re.search('https.+;', str(photoDiv));
            photoUrl = str(rawUrl.group(0))[:-2]
            split = urlparse.urlsplit(photoUrl)
            photoName = directory + split.path.split("/")[-1]

            # save full-resolution photo
            urllib.urlretrieve(photoUrl, photoName)

I agree with you that the current naming system is not ideal. I originally built this out of a frustration with trying to download all of my own photos from Instagram after switching from an Android to an iPhone, so the thinking was that this was something I would run once and have all of my photos. But a different naming scheme does make sense if you are going to run this periodically to download all photos, or just the latest photos.
I like your idea and I think you should make a pull request with one minor change. Instead of saving the photo each time, I think it would be better if you loop through all of the photos that are already in the directory and only save the photo if it doesn't exist yet. That way you would still retain a history of when the photo was saved to the directory.
Let me know if you want to make that small modification and create a pull request. If not, I still appreciate the idea and when I have some time to work on this in the future I'll make the change myself. I'll keep this issue open until the change is implemented.

Created the pull request with the modifications!


Support conversion to pytorch for GPT Neo

Now that this PR has been merged (https://github.com/huggingface/transformers/pull/10848) it should be technically possible to convert a GPT Neo model to Pytorch. However, the configs published with the models do not seem to be compatible with the new scripts.
This may be as simple as updating the README with instructions on which config to use when attempting the conversion.

This is much more than "technically possible," the PyTorch checkpoints we released on HuggingFace were generated using their conversion code. What goes wrong when you run it?
TBH, this might be better settled on their repo than ours.

Closing due to lack of activity.


training code

great job, is the training code going to be released?

StyleGan2 trained by stylegan2-pytorch ,and encoder training code used encoder4editing

@TalkUHulk Did you use exactly the default provided parameters for training provided by e4e? Or did you tweak them?


esdoc fails to parse js

Make sure these boxes are checked before submitting your issue - thank you!
(If your issue is neither a both bug nor a request, please write in a free style)

[x] https://esdoc.org/manual/usage/feature.html
[x] https://esdoc.org/manual/configuration/config.html
[x] https://esdoc.org/manual/usage/tags.html
[x] https://esdoc.org/manual/advanced/api.html
[x] https://esdoc.org/manual/faq/faq.html

Short summary of your issue
I have only one file containing only one line of code (provided below). For some reason it breaks esdoc
Input data for reproducing
Configuration
{
  "source": "./lib/",
  "destination": "./doc",
  "includes": ["\\.(js)$"],
  "lint": true,
  "experimentalProposal": {
    "classProperties": true,
    "objectRestSpread": true,
    "decorators": true,
    "doExpressions": true,
    "functionBind": true,
    "asyncGenerators": true,
    "exportExtensions": true,
    "dynamicImport": true
  }
}

Codes
module.exports['test.init'] = function init(context) {};

Output data
Log
> esdoc -c .esdoc.json

parse: lib/index.js
resolve: extends chain
resolve: necessary
resolve: access

Exception output (if possible)
Log

TypeError: Cannot read property 'charAt' of undefined
    at Object.<anonymous> (node_modules/esdoc/out/src/Publisher/Builder/DocResolver.js:96:37)
    at node_modules/taffydb/taffy.js:743:17
    at each (node_modules/taffydb/taffy.js:126:17)
    at Object.<anonymous> (node_modules/taffydb/taffy.js:740:7)
    at Object.API.(anonymous function) [as update] (node_modules/taffydb/taffy.js:166:18)
    at DocResolver._resolveAccess (node_modules/esdoc/out/src/Publisher/Builder/DocResolver.js:94:18)
    at DocResolver.resolve (node_modules/esdoc/out/src/Publisher/Builder/DocResolver.js:35:10)
    at CoverageBuilder.DocBuilder (node_modules/esdoc/out/src/Publisher/Builder/DocBuilder.js:47:37)
    at CoverageBuilder (node_modules/esdoc/out/src/Publisher/Builder/CoverageBuilder.js:16:1)
    at publish (node_modules/esdoc/out/src/Publisher/publish.js:142:5)

npm ERR! Linux 4.4.0-72-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "run" "docs"
npm ERR! node v7.7.1
npm ERR! npm  v4.1.2
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>docs: `esdoc -c .esdoc.json`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>docs script 'esdoc -c .esdoc.json'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the p package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     esdoc -c .esdoc.json
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs p
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls p
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     npm-debug.log

Screen shot of documentation
// attach a image into here
Your environment

OS type and version: Ubuntu 16.04
Node.js version: 7.7.1 and 7.9.0
ESDoc version: 0.5.2

Have you found an answer yet? I have the same problem


[ISSUE #8790]Add Utils for put header to Metadata to avoid duplicate data.

Which Issue(s) This PR Fixes
Add Utils for put header to gRPC Metadata to avoid duplicate data.
Fixes #8790
Brief Description

How Did You Test This Change?

Codecov Report
Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 47.34%. Comparing base (782da70) to head (feeac3f).

Files with missing lines
Patch %
Lines

.../apache/rocketmq/proxy/common/utils/GrpcUtils.java
0.00%
9 Missing :warning:

...etmq/proxy/grpc/interceptor/HeaderInterceptor.java
0.00%
4 Missing :warning:

...xy/grpc/interceptor/AuthenticationInterceptor.java
0.00%
3 Missing :warning:

...mq/proxy/grpc/pipeline/AuthenticationPipeline.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8792      +/-   ##
=============================================
- Coverage      47.38%   47.34%   -0.04%
+ Complexity     11557    11554       -3
=============================================
  Files           1282     1283       +1
  Lines          89864    89873       +9
  Branches       11563    11565       +2
=============================================
- Hits           42578    42550      -28
- Misses         42038    42072      +34
- Partials        5248     5251       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


idp role mapping is not working

When tried to add the IDP role mapping in wso2 identity server, it's not work as expected. As check on this further in the code base,  following line has to added under jQuery('#advancedClaimMappingAddLink').click() in idp_mgt_edit.js file. But in the fix for 5.12.387, it has been mistakenly added under jQuery('#roleAddLink').click() function in the same file.
Therefore, it is not possible to add IdP role mappings now due to undefined variable selectedIDPClaimName under jQuery('#roleAddLink').click().
selectedIDPClaimName = htmlEncode(selectedIDPClaimName);

This issue will be resolved by https://github.com/wso2/carbon-identity-framework/pull/2318


[BUG] Cluster creation stuck with Kubernetes v.1.17.13

What did you do

How was the cluster created?
k3d cluster create test-cluster --image rancher/k3s:v1.17.13-k3s1

What did you expect to happen
I expected the cluster to start successfully
Screenshots or terminal output
The cluster creation gets stuck and doesn't report any errors. Using the default k3s image rancher/k3s:v1.20.4-k3s1 instead works fine.
$ k3d cluster create test-cluster --image rancher/k3s:v1.17.13-k3s1
INFO[0000] Prep: Network
INFO[0000] Created network 'k3d-test-cluster'
INFO[0000] Created volume 'k3d-test-cluster-images'
INFO[0000] Starting new tools node...
INFO[0000] Starting Node 'k3d-test-cluster-tools'
INFO[0001] Creating node 'k3d-test-cluster-server-0'
INFO[0001] Creating LoadBalancer 'k3d-test-cluster-serverlb'
INFO[0001] Using the k3d-tools node to gather environment information
INFO[0001] HostIP: using network gateway <IP_ADDRESS> address
INFO[0001] Starting cluster 'test-cluster'
INFO[0001] Starting servers...
INFO[0001] Starting Node 'k3d-test-cluster-server-0'
INFO[0008] All agents already running.
INFO[0008] Starting helpers...
INFO[0009] Starting Node 'k3d-test-cluster-serverlb'
INFO[0016] Injecting '<IP_ADDRESS> host.k3d.internal' into /etc/hosts of all nodes...
INFO[0016] Injecting records for host.k3d.internal and for 2 network members into CoreDNS configmap... <-- stuck here

Which OS & Architecture

Linux (Ubuntu 18.04), x86

Which version of k3d
$ k3d version
k3d version v5.2.2
k3s version v1.21.7-k3s1 (default)

Which version of docker
$ docker version
Client:
 Version:           20.10.7
 API version:       1.41
 Go version:        go1.13.8
 Git commit:        20.10.7-0ubuntu5~18.04.3
 Built:             Mon Nov  1 01:04:14 2021
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server:
 Engine:
  Version:          20.10.7
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.13.8
  Git commit:       20.10.7-0ubuntu5~18.04.3
  Built:            Fri Oct 22 00:57:37 2021
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.5.5-0ubuntu3~18.04.1
  GitCommit:
 runc:
  Version:          1.0.1-0ubuntu2~18.04.1
  GitCommit:
 docker-init:
  Version:          0.19.0
  GitCommit:

$ docker info
Client:
 Context:    default
 Debug Mode: false

Server:
 Containers: 4
  Running: 4
  Paused: 0
  Stopped: 0
 Images: 8
 Server Version: 20.10.7
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 1
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 io.containerd.runtime.v1.linux runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version:
 runc version:
 init version:
 Security Options:
  apparmor
  seccomp
   Profile: default
 Kernel Version: 5.4.0-92-generic
 Operating System: Ubuntu 18.04.6 LTS
 OSType: linux
 Architecture: x86_64
 CPUs: 8
 Total Memory: 15.61GiB
 Name: ubuntu
 ID: MPOL:Q4UZ:NNQJ:HUPX:4NJW:ZQRH:B6BU:VXLI:D4SK:E7IQ:NDKP:GDZ6
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Registry: https://index.docker.io/v1/
 Labels:
 Experimental: false
 Insecure Registries:
  registry.localhost:5000
  <IP_ADDRESS>/8
 Live Restore Enabled: false

WARNING: No swap limit support

Hi @chaehni , thanks for opening this issue!
Indeed, k3d v5.2.0+ does not support the legacy (i.e. current End-of-Life) versions of K8s/K3s due to a missing required feature on K3s' side.
There's an open issue explaining it and we'll add a proper compatibility/test matrix with the next release.
Sorry for the confusion!
See https://github.com/rancher/k3d/issues/897

Thanks for your reply. I was indeed looking for a compat matrix but couldn't find one. That will be a good addition to the docs.
One minor correction: It's k3d v5.0.2+ which doens't work with legacy k3s.
With v5.0.1 it works fine.
Thanks again!


Use BaseURL for fonts to handle urls that have path components.

If you visit https://themes.gohugo.io/theme/hugo-theme-introduction/ for the demo hosted on the hugo site, you can see that the icons are messed up. I was noticing the same issue on my gitlab pages deployment. The issue is that the CSS compiled was being compiled to url(/fonts/<font file>) which is a relative path. The relative path begins after the domain. However, some sites host the index of a page on a path e.g. https://themes.gohugo.io**/theme/hugo-theme-introduction/**.

Thanks Hudson!


SILGen: Provide compatibility with prior BorrowingSwitch behavior.

To avoid breaking early adopters of this feature, accept attempts to return a let binding in a noncopyable switch when it would be treated as a borrow normally, with a warning that this behavior will change soon. rdar://126775241

@swift-ci Please test


[Ant-Design-Vue] dts cannot work with a path. importStyle will throw a error.

Describe the bug
The dts option cannot work with a path. There is nothing will be generated after serve on.
The importStyle option will throw a error with true(It is a default value).
How I create the minimal repo:
pnpm create vue (all options are false)
pnpm add ant-design-vue
pnpm add -D unplugin-vue-components
pnpm dev
Reproduction
https://github.com/s3xysteak/unplugin-vue-components-dts-bug-minirepo
System Info
System:
    OS: Windows 10 10.0.19045
    CPU: (8) x64 Intel(R) Core(TM) i3-10100 CPU @ 3.60GHz
    Memory: 7.19 GB / 15.90 GB
  Binaries:
    Node: 20.9.0 - ~\AppData\Local\fnm_multishells\8032_1701332906285\node.EXE
    npm: 10.1.0 - ~\AppData\Local\fnm_multishells\8032_1701332906285\npm.CMD
    pnpm: 8.11.0 - ~\AppData\Local\pnpm\pnpm.CMD
  Browsers:
    Edge: Spartan (44.19041.3636.0), Chromium (119.0.2151.72)
    Internet Explorer: 11.0.19041.3636

Used Package Manager
pnpm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

In complex project, sometimes it also cannot generate ant-design-vue components' types when dts: true. But the type of router-view can be generated.

I think it can generate all types when the serve start, just like unplugin-auto-import. That may be a simple solution.


net/http: request with a + in Content-Length is considered valid

What version of Go are you using (go version)?

$ go version
go version go1.14.2 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/juliens/.cache/go-build"
GOENV="/home/juliens/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GOOS="linux"
GOPATH="/home/juliens/dev/go"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/home/juliens/go-current"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/juliens/go-current/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build262375258=/tmp/go-build -gno-record-gcc-switches"

What did you do?
I launch a server using
http.ListenAndServe(":8080", http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
    fmt.Println(req.ContentLength)
}))

and after that, I make a call with a Content-Length: +3
echo -ne "POST / HTTP/1.1\r\nContent-Length: +3\r\nHost: <IP_ADDRESS>\r\n\r\naaa\r\n" | nc <IP_ADDRESS> 8083

What did you expect to see?
A bad request ( because of the RFC https://tools.ietf.org/html/rfc2616#section-14.13 )
What did you see instead?
A valid request, the Content-Length is parsed as just 3
More
For what I saw, it's because the Content-Length is parsed by using strconv.ParseInt and so +3 is valid and becomes 3

I'd like to take a stab if there's no objection from the Go team!
For my first attempt, I simply used strconv.ParseUint (which disallows the prefixed sign), to replace the strconv.ParseInt calls (that allow it), and then cast back to int64.
I'll try to add a test that references this issue for posterity.

Thank you for the report @juliens! Thank you for working on the fix @tpaschalis, awesome!
I've added some suggestions to your CL, please take a look. Our HTTP/2 stack purposefully skips checking for errors from strconv.ParseInt, because such errors don't necessarily affect our framing. Unfortunately this increases the surface area for what could change be broken within this release that we are already in.
@bradfitz would it be pragmatic for us to firstly accept only the fix for HTTP/1.1 for Go1.15? For Go1.16 make the follow-on update in x/net/http2 and subsequently to net/http/h2_bundle.go? We ignore the errors anyways in HTTP/2 so the change could perhaps survive one more release.

@odeke-em sorry for pinging you! A few days ago, I opened a similar CL for HTTP/2.
I'm not sure if I should put you as a reviewer since we had some communication for the HTTP/1.1 part, or if you're busy with other things; in any case I'd be grateful if you could take a look! Thanks in advance.

Too late for 1.15.  Moving to Backlog.

HTTP/2 Content-Lengths are indeed not security-relevant, so now that this is fixed in HTTP/1.1, it's not a security issue anymore. Even in HTTP/1.1, this was only an issue when paired with a misbehaving proxy that forwards invalid Content-Length headers that it ignored, when it's supposed to strip or reject them, so we consider this a security hardening fix, and it won't be backported.
We'd like to also thank Amit Klein, Safebreach for reporting this to<EMAIL_ADDRESS>before this issue was opened.
In the process of looking into this, we found another hardening fix I'll request a freeze exception for in a moment: leading zeroes are accepted the same way a leading + is. The HTTP/2 fix will probably want to fix that as well for Go 1.16.

In the process of looking into this, we found another hardening fix I'll request a freeze exception for in a moment: leading zeroes are accepted the same way a leading + is. The HTTP/2 fix will probably want to fix that as well for Go 1.16.

Sigh, scratch that. Turns out that leading zeroes are wholly unspecified. Someone tried to make an argument for a better spec in 2008 but was met with strong resistance.
This goes to show that

making header parsing and semantics critical to the security of the protocol framing was a catastrophic design decision; and
it's simply impossible for implementations to agree on the exact same set of valid headers, so the only countermeasure to request smuggling is for proxies not to forward headers they did not parse successfully.

(Request smuggling can still occur when two implementations both find a header valid, but disagree on its meaning, but in that case it's likely one of them is simply wrong.)

Shall we make backports for Go1.13 and Go1.14 for this issue for HTTP/1.1?

Shall we make backports for Go1.13 and Go1.14 for this issue for HTTP/1.1?

No need, we decided we'd land this as a hardening measure, not as a security fix.

Cool, thanks!
On Mon, Jun 29, 2020 at 6:16 PM Filippo Valsorda<EMAIL_ADDRESS>wrote:

Shall we make backports for Go1.13 and Go1.14 for this issue for HTTP/1.1?
No need, we decided we'd land this as a hardening measure, not as a
security fix.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/golang/go/issues/39017#issuecomment-651458761, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABFL3V3DH5BB4WOBWXRGAHTRZE4GXANCNFSM4M63G7DQ
.


Add notify about compatible/new version of the mod button

Like in title it will be cool if you would "add notify about compatible/new version of the mod button" ( if we want the mod but we want new version or version that will be comaptible, like wishlist/follow from steam)

I dont mean sth big as desktop notifications . Yes sth like dialog when you load ModFinder would be enough, even sth like red lettered "this mod isnt compatible with your Wrath version" or sth like that for compatibility. And for "new version of the mod" just sth like, "last updated x hours/days ago" near version of the mod would be sufficient I think. Nothing fancy.

Yeah we can probably do that. In general I'd like to rework the UI a bit to make it obvious when:

There's a problem with a mod (bad game version, missing pre-req)
There's an update available

Probably the default sort + alert icons will be sufficient.

Yes, that would be great :)

Oh yeah this is done now. Status icons (quest stamps from the game) indicate status and the default sort shows actionable (missing pre-req for update available) first.


Fix uniqueness validation after source code changes (take 2)

Re-opening @hgani's PR #78, with passing tests (hopefully).

There has been a suggested workaround, but the workaround doesn't work for me.
This pull request aims to fix this problem properly so no workaround is needed.
Basically what it does is use class name as the key for expose instead of using the class itself, which will break when Rails autoloads the class, because then the existing key/class will not match with the reloaded class.

I'm merging this myself as a continuation of https://github.com/joecorcoran/judge/pull/78 and https://github.com/joecorcoran/judge/pull/79.


[🐞 BUG]: Heuristics disappearing on tab change.

Bug Description :
Suppose I am creating some heuristic and want to switch to some other tab(eg. Options tab in the video below), the heuristic just disappears. I think it may lead to some problem if someone is not aware of hitting the save button every time before changing the tab.
https://github.com/ruxailab/RUXAILAB/assets/107767172/a83a5a8e-56df-43e3-bcf9-822ec94247c8

I am planning to auto save the heuristics on tab change. Could you please assign me this issue? @jvJUCA @KarinePistili

I am planning to auto save the heuristics on tab change. Could you please assign me this issue? @jvJUCA @KarinePistili

Ok, assigned @RishabhJain0721 !
Thank you so much for being proactive and volunteering to take on this issue!

Issue was already completed on pull request https://github.com/ruxailab/RUXAILAB/pull/393


Doesn't appear to handle multiple cover profiles concatenated

This is what I talking about with the multiple mode: count lines. The coverage for vip has info for other files that aren't included as well, but isn't listed in cvr.

fetch/fetch.go
fetch/mainip.go
fetch/context.go

Will take a look at it

The other trick here is that files that aren't hit at all don't even show up in the profile. There are other files in the project but aerent counted against the coverage even though the probably should be. I don't know if that means we should do more to generate a better coverage report or if we need to do more to look at the whole source of project.

Or a little of both.

TL;DR Ignore the part about counting files that don't show up in the cover profile; that's on our team to fix with better standards about writing tests for Go projects.
I'm going to investigate what alternatives are available for generating coverage reports, or maybe draft some standards for writing tests for Go projects, because the cover profile generated by go test will only ever refer to files in the package which they are linked to. For instance, even though we have a full suite of resizing tests, that test is part of package main and therefore doesn't record any coverage for fetch/mainip.go where all the resizing code lives.


[improve][misc] Upgrade Netty to 4.1.113 and netty-tcnative to 2.0.66

Motivation
Netty release 4.1.113.Final contains some bug fixes that are relevant for Pulsar.
It's also worth keeping Netty updated since besides bug fixes, we will also catch possible regressions closer to releases when a change in Netty causes a regression.

Netty 4.1.113 release notes
Netty 4.1.112 release notes

Modifications

upgrade Netty to 4.1.113.Final
upgrades netty-tcnative to 2.0.66.Final

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.55%. Comparing base (bbc6224) to head (e2e2bdf).
Report is 562 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23255      +/-   ##
============================================
+ Coverage     73.57%   74.55%   +0.98%
- Complexity    32624    33773    +1149
============================================
  Files          1877     1926      +49
  Lines        139502   145039    +5537
  Branches      15299    15862     +563
============================================
+ Hits         102638   108135    +5497
+ Misses        28908    28636     -272
- Partials       7956     8268     +312

Flag
Coverage Δ

inttests
27.89% <ø> (+3.31%)
:arrow_up:

systests
24.67% <ø> (+0.35%)
:arrow_up:

unittests
73.89% <ø> (+1.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 557 files with indirect coverage changes


[New] Query with CQL filters

Description
This PR implements Query with CQL filters in Search and Query category.
URL to README: Query with CQL filters
Linked Issue(s)

swift/issues/6282

How To Test

Adjust the "CQL Filter" settings and press "Apply" to query the feature table and view the feature count.

Screenshots

Thank you!


Download/upload integration for major tab websites

Investigate how feasible it is to automate downloading/uploading from/to UltimateGuitar and Songsterr. Will most likely require the user auth to each respective service. In so far as whatever is feasible, proceed to implement them.

Note that while we can discuss feasibility for now, actual implementation will be barred on #3 .


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report

Merging #336 (36b937a) into main (2974dfe) will increase coverage by 12.36%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #336       +/-   ##
===========================================
+ Coverage   83.33%   95.69%   +12.36%
===========================================
  Files           2        1        -1
  Lines         126      395      +269
  Branches       31       53       +22
===========================================
+ Hits          105      378      +273
+ Misses         21       17        -4

Impacted Files
Coverage Δ

src/index.ts
95.69% <100.00%> (+13.69%)
:arrow_up:

example/src/main.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9a3c8...36b937a. Read the comment docs.


bug(BUTTON): Icon button is not centered within ripple, causes input height change

Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
2 issues: When putting the clear option in an input, it's seen that the icon is not centered within its ripple. Additionally, when using a custom font, it is seen that the line-height causes the input to increase in height as soon as the icon appears. The issue seems to be:
.mat-form-field-suffix .mat-icon-button .mat-icon { line-height: 1.125 }. This can be solved by setting line-height: 1. Attaching screenshot, video and link from Docs for reference.
https://stackblitz.com/run?file=src/app/input-clearable-example.ts

https://user-images.githubusercontent.com/4698762/181879134-b2a17374-cdbd-4100-8d90-13bbfb7aad11.mov
Reproduction
Steps to reproduce:

Use a clearable input, input text

Alternatively, also use a custom font to see the height issue:
@use '@angular/material' as am;

@font-face {
  font-display: swap;
  font-family: 'Nova';
  font-style: normal;
  font-weight: 300;
  src: url('assets/fonts/Nova-300.woff2') format('woff2');
}

$my-typography: am.define-typography-config(
  $font-family: "'Nova', sans-serif",
);

@include am.core($my-typography);

Expected Behavior

Icon should be centered
Height should remain consistent irrespective of the font

Actual Behavior

Icon is not centered
Height is not consistent

Environment

Angular: 14.1.0
CDK/Material: 14.1.0
Browser(s): Chrome and Firefox
Operating System (e.g. Windows, macOS, Ubuntu): macOS

Changing the font didn't cause an issue for me and the ripple still seems centered. Can you provide a stackblitz with a example that does this for you?

Sorry I am unable to reproduce this on StackBlitz, but it looks different from Docs site (screenshot attached). I will close anyway. It could be an issue with downloaded fonts or the commercial font we're using; will create another ticket if I get more info. Thanks for checking.
https://material.angular.io/components/input/examples
https://stackblitz.com/edit/angular-hmvykm?file=src%2Fstyles.scss

I was able to identify the difference causing this issue: the height calculation in Chrome is different from that on Safari and Firefox. Attaching the screenshot. Firefox isn't allowing me to run StackBlitz but when I compare the same on the Docs site, the value is a round figure (27px) so it works there. I will attach a working sample if I'm able to create one.


fix(tests): keep all golden tests in one place

What this PR does / why we need it:
Golden tests e.g. for internal/dataplane/translator/testdata/golden/tcproute-example/in.yaml are in different place than the rest of them, it's a problem because try to change something in YAML mentioned above and execute
make test.golden.update

it has no effect (basically those tests are not executed).
This PR moves those to the common directory. After the changes, they behave as expected.

Which issue this PR fixes:
Discovered during work on https://github.com/Kong/kubernetes-ingress-controller/issues/6582

@programmer04 FYI kongintegration tests are failing

I know. I'm working on it, because now they are covered with kongintegrations tests too, that were skipped before for TPCRotue, UDPROute and TLSRoute


Force maximum text writing speed

The function at 8c4c0154 is called when a character is drawn, and called in rapid succession when the A button is pressed to show all text instantly.

The motivation for this issue was to reconcile the changing text writing speed of voiced lines. The goal was to force both to be the same, and forcing all text to be drawn instantly was seen as the path of least resistance. However, with documentation on lip movement commands now complete, this will no longer be necessary. Inserting a text write command every three frames will achieve the desired effect.

Fixed in 310cfba9d1be8e2ee4f665e0ebe1b87a68e22bca.


Function signature mismatch for FBInstant.player.getDataAsync()

Lua version accepts a single key only while JS version accepts array of keys

In progress: https://github.com/defold/extension-fbinstant/tree/get_player_data

https://github.com/defold/extension-fbinstant/releases/tag/3.0.0


Fix broken example target which required pthread and m libraries

I couldn't build the example without referencing the pthread and math library, so this should fix that.

/cc @jonathanmarvens


Fixing StatusCode==0 for readMany

Description
CosmosDiagnosticsContext.getStatusCode always returns 0 for readMany. This PR fixes that and adds regression coverage.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests

/azp run java - cosmos - tests


Python tweaks for quick start

A couple small tweaks to smooth out the quick start process:

Add shebang line and chmod +x so that users can ./SetupAWS.py
Git ignore *.pyc

Thank you for taking the time to make these changes. These will be fixed.

jrr, you did the right thing vis-a-vis the PR. Thank you. We took the shebang change, but not the .gitignore one for now. Regarding the latter, we aren't currently including those files in our release process.


appendToArrayField lets me add keywords, but how to remove keywords

I have written a basic data flagger that can analyze datasets in the SciCat database and add keywords to the entries. These can be added easily using the appendToArrayField in the API.
However, I'm still experimenting with the flagging parameters, and now also need to remove incorrect keywords from an entry. How best to do this? Is there a "removeFromArrayField" method planned too?

Such a remove functionality seems to be missing, unfortunately. However there is the workaround: send via PUT an update to the keyword array. This update should then contain all array elements except the one you want to remove, as is currently done in th GUI as well, e.g. send via PUT such a payload:
{"keywords":["flag1"],["flag2"]}
if you want to remove "flag3" from {"keywords":["flag1"],["flag2"],["flag3"]}


Update upload-artifacts GitHub action to v4

It seems there is a breaking change on this GH action at that makes all actions to fail as seen in PR #30048, for example here
The breaking change is documented in here. There's also a GH issue with more information here

Migration help here for this issue.


fix：Solve the problem of discarding extra records by adding table names.

To fix https://github.com/taosdata/kafka-connect-tdengine/issues/19#issue-1312679718
The function unrollAndRetry will be called after a fixed number of retries. The purpose is to insert the correct records in the same batch of records into the database, and the wrong records will be discarded.
During the iteration, because of an exception, the sql connection is closed and the database name is lost, resulting in an error when inserting into the database regardless of whether the record is correct or not.
Fix this problem by re-obtaining the database name before getting the connection.

how about delete writer.close() in unrollAndRetry function?

I have tried your suggestion and it work in my environment.
Commit has been updated.

Thanks for submitting the code


Disapearing umb

🐛 Bug Report
I recieved an "error occured" message after opening 83 tmb and then trying to open 62 umb, when i tryed opening again it said I didnt have any umb. I gained 2 bank tabs but thats after opening the tmb so im not sure if i actually got the umb rolls , ive also searched in my bank text for a "wtf" item and dont have any items worth 73gp either as im told those were broken

`

`

resolved


[docs] Accessibility in Base UI

Described how Base UI components are accessible and what the developers need to do on their side when building applications.
@samuelsycamore, feel free to edit or expand where you feel necessary.
Closes #38539
👉 https://deploy-preview-39264--material-ui.netlify.app/base-ui/getting-started/accessibility/

@samuelsycamore, thanks for your corrections! I included all of them.
Could you do the final review, please?

@danilo-leal, I added the demos. They may need to be updated after #38820 is merged in.

Love the demos! They do a great job of driving home the key points.


save button not reachable

Hello,
this is a layout issue I couldn't work around.
With longer pieces of text (I copy pasted it as text into a new article) I could not reach the 'save/cancel' buttons at the bottom of the entry field because of the bar at the bottom of the page saying 'publish - discard' etc... I guess it's above the button, making it impossible to click. scrolling lower didn't help.
I'm a new user, I guess there must be solution, I'll probably won't be the only one.
thanks,
Bart

I will try to reproduce that behavior.

Yes, this is fixed in version 2. There is an autoscroll on every new line so the focus while writing should stay where it is on the screen now.


Improve node based rules

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (d44a28f) to head (ec5d678).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##                main      #292   +/-   ##
===========================================
  Coverage     100.00%   100.00%
  Complexity       733       733
===========================================
  Files             64        64
  Lines           2286      2286
===========================================
  Hits            2286      2286

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


This has to be a bug.

Challenge Make Dead Links using the Hash Symbol has an issue.
User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
 I literally flipped this challenged in many ways. Thank you for the help. - Max

Thank you for reporting this issue.
This is a standard message notifying you that this issue seems to be a request for help. Instead of asking for help here, please click the "Help" button on the challenge on freeCodeCamp, which will take you to the help chatroom for that specific challenge. You can also view our full list of official chatrooms.
If you think I'm wrong in closing this issue, please reopen it and add further clarification. Thank you, and happy coding.


Set Pact tag/branch/commit properly

Move the definition of those values to new job and depend on its output in other jobs
For SP-1505 #patch

Codecov Report
Patch and project coverage have no change.

Comparison is base (d38eb29) 85.10% compared to head (86d346a) 85.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   85.10%   85.10%
=======================================
  Files          35       35
  Lines        1296     1296
=======================================
  Hits         1103     1103
  Misses        131      131
  Partials       62       62

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


wget fails when installing a rock through a firewall

I'm trying to install distlearn.  I've set my proxy variables as noted, testing them out with direct wget commands.  It appears that something in the luarocks execution sequence doesn't properly export the proxy shell variables: with the straightforward command
sudo luarocks install autograd

I get the error
Missing dependencies for autograd:
totem

Using https://raw.githubusercontent.com/torch/rocks/master/totem-0-0.rockspec... switching to 'build' mode
Cloning into 'torch-totem'...
fatal: unable to connect to github.com:
github.com[0: <IP_ADDRESS>]: errno=Connection timed out

Error: Failed installing dependency: https://raw.githubusercontent.com/torch/rocks/master/totem-0-0.rockspec - Failed cloning git repository.

I've tried downloading the repos (autograd, thrift, dataset, ipc) with git clone, and I now get:
$ luarocks install distlearn
Warning: Failed searching manifest: Failed fetching manifest for https://raw.githubusercontent.com/torch/rocks/master - Failed downloading https://raw.githubusercontent.com/torch/rocks/master/manifest - /home/hadoop/.cache/luarocks/https___raw.githubusercontent.com_torch_rocks_master/manifest
Warning: Failed searching manifest: Failed fetching manifest for https://raw.githubusercontent.com/rocks-moonscript-org/moonrocks-mirror/master - Failed downloading https://raw.githubusercontent.com/rocks-moonscript-org/moonrocks-mirror/master/manifest - /home/hadoop/.cache/luarocks/https___raw.githubusercontent.com_rocks-moonscript-org_moonrocks-mirror_master/manifest

... and ...
$ luarocks install distlearn
Installing https://raw.githubusercontent.com/torch/rocks/master/distlearn-scm-1.rockspec...
Using https://raw.githubusercontent.com/torch/rocks/master/distlearn-scm-1.rockspec... switching to 'build' mode

Missing dependencies for distlearn:
ipc
regress

Using https://raw.githubusercontent.com/torch/rocks/master/ipc-scm-1.rockspec... switching to 'build' mode

Missing dependencies for ipc:
regress

Using https://raw.githubusercontent.com/torch/rocks/master/regress-scm-1.rockspec... switching to 'build' mode
Cloning into 'regress'...
fatal: unable to connect to github.com:
github.com[0: <IP_ADDRESS>]: errno=Connection timed out

Error: Failed installing dependency: https://raw.githubusercontent.com/torch/rocks/master/ipc-scm-1.rockspec - Failed installing dependency: https://raw.githubusercontent.com/torch/rocks/master/regress-scm-1.rockspec - Failed cloning git repository.

Am I diving down the wrong rabbit hole?
What do I need to fix?  Is there more diagnostic information I need to get?
BTW, I'm happily running AlexNet on torch; now I want to use some of the distlearn facilities to expand on the model.

It appears that luarocks has a hidden assumption that the standard git protocol suffices.  Since I'm behind a firewall, I need to reconfigure the applicable proxies, but luarocks doesn't seem to have such a facility.
I finally gave up and consulted my local Powers That Be.  One of them knew to reconfigure git to use HTTPS instead:
sudo git config --global url."https://".insteadOf git://

Indeed, we don't try to auto-configure every SCM tool backend. Perhaps this information could be added to the documentation page in the wiki?
https://github.com/keplerproject/luarocks/wiki/LuaRocks-through-a-proxy

git (like most programs) supports environmental variables such as http_proxy and NO_PROXY. I'm surprised they're not passed through?

They should be. That was added recently.

I think the issue here, more than making https go through the proxy, was to tell git to switch from its own transport protocol to https. It seems specific enough to me so that it can be dealt via documentation rather than implementation (we can't make all git accesses go through https, since not all Git servers in the world support that).

I added @wdwickar's solution to the wiki link above, so I believe this can be closed.

The solution is from @threevi; I'm just the one who tripped over the problem and characterized it.


Fixes bug leaving file presenter installed after ULDocument closes

Hopefully, this one line PR will be merged🤞.
Prior to this, the _presenter variable was being set to nil prior to endPresentation being called. Later, when the ULDocument instance was deallocated, it tried to call endPresentation, but had no effect since the _presenter var was already set to nil. The result was that the presenter proxy instance was left in the +[NSFileCoordinator filePresenters] array. Ultimately this can lead to an iOS app being terminated by iOS when the app is suspended due to background inactivity.
FYI, had to update the base SDK version in the test project to get it to run.

Looks good! Thanks for fixing!

Will submit another PR later today. Found a couple other spots that can lead to the same issue a few seconds ago:
https://github.com/soulmen/ULDocument/blob/master/Source/ULDocument.m#L747
https://github.com/soulmen/ULDocument/blob/master/Source/ULDocument.m#L916


Related topic: dataframe protocol for data interchange/export

In March'20 there was a very detailed discussion about introduction a new __dataframe__ protocol: https://discuss.ossdata.org/t/a-dataframe-protocol-for-the-pydata-ecosystem/267. The purpose of it is being able to exchange data between different implementations, or export data to (e.g.) Apache Arrow or NumPy.
There's a strawman implementation at https://github.com/wesm/dataframe-protocol/pull/1.
The discussion went a little all over the place, with many people misunderstanding the main purpose was data exchange rather than providing an API to manipulate or do computations with a dataframe. That would be a much larger topic, and something this consortium aims to deliver an RFC for.
That said, the __dataframe__ topic is very much related, and is also a potentially interesting example of a cross-dataframe-library topic that could really benefit from having a detailed RFC with requirements and use cases. We should consider picking up that topic, and consider lessons from it in community engagement.

Time to close this. A lot of work has been done here; see https://data-apis.org/dataframe-protocol/latest/ and the "interchange protocol" label.


Implemented StringFragment as own type.

Coverage increased (+0.04%) to 93.781% when pulling d712bccb9291c69f57c020b2f2c1a458014323e6 on cborgolte:StringFragment into a8ecc16bf5c93d0f00eb3e5c09d1f49f3298cbfd on tarent:master.

Coverage increased (+0.03%) to 93.77% when pulling d3bfa7b5ab910bf63336f24bf2598239812b83a1 on cborgolte:StringFragment into a8ecc16bf5c93d0f00eb3e5c09d1f49f3298cbfd on tarent:master.


The resource write operation failed to complete successfully, because it reached terminal provisioning state 'Failed'”

We are doing company communicator migration in Production, we re getting below error
"message": "The resource write operation failed to complete successfully, because it reached terminal provisioning state 'Failed'."

Hi @Prasadj2024 ,
Thanks for raising the query.

To overcome the failed resources, Go to azure portal-->Go to resource group(Where the deployment has been done)-->Select prep-function(or failed resource) from list of resources-->Go to Deployment Center-->Click on Settings. Below is the screenshot for reference.

If the resource is not pointing to intended repository and  showing empty. Please connect to the external Git and point to the official repository(like above)
Once the status turns to Success(active) in the logs section then good to proceed with remaining steps of deployment.
Please do the same for other failed resource as well.
After performing the above steps, don't attempt for re-deploy again

@Prasadj2024, we are closing this issue as this is a duplicate to #1362.


New reduced user-agent

Hello all,
After reading about the new reduced user-agent, I wonder if in the following Google Chrome updates, the old user-agent will keep or it will be removed.
Could you clarify this topic, please? 🙂

Unfortunately this is not a question about the code within this repository, so I’ll close it, but I hope you get your answer elsewhere. You might want to ask @ChromiumDev on Twitter.


machineController.provider field is not respected when deploying machine-controller

What happened:
Setting a different provider for machine-controller using the .machineController.provider key doesn't seem to work at all. Even if the key is set, credentials would be deployed based on .cloudProvider.name.
What is the expected behavior:
The expected behavior is that the secret and environment variables bindings for machine-controller are created respecting .machineController.provider.
How to reproduce the issue:
The common use case is using the none provider, such as:
apiVersion: kubeone.io/v1alpha1
kind: KubeOneCluster
name: demo-cluster
versions:
  kubernetes: 1.16.1
cloudProvider:
  name: none
  external: true
machineController:
  deploy: true
  provider: openstack

Information about the environment:
KubeOne version (kubeone version): master@https://github.com/kubermatic/kubeone/commit/63afc8f4752a30628cf1f6ff33e138c8fdc7c169

This is actually making things a little bit complicated, because if you manually provide these secrets afterwards and patch the deployment of machine-controller and machine-controller-webhook, each time you upgrade, everything is overwritten. So as a workaround, you need to provide the secret and the patching manually after each upgrade.

A quick fix for this problem is to create a secret with the following specs:
# machine-controller-secret.yaml
apiVersion: v1
kind: Secret
metadata:
  name: machine-controller-openstack
  namespace: kube-system
type: Opaque
data:
  OS_AUTH_URL: XXX
  OS_USER_NAME: XXX
  OS_PASSWORD: XXX
  OS_DOMAIN_NAME: XXX
  OS_TENANT_NAME: XXX
  OS_TENANT_ID: XXX
  OS_REGION_NAME: XXX

The secret can be created directly and you have to provide this only once, due to the fact that it gets not overwritten.
Additionally you need two patch files:
# envfrom-controller-patch.yaml
spec:
  template:
    spec:
      containers:
      - name: machine-controller
        envFrom:
          - secretRef:
              name: machine-controller-openstack

# envfrom-webhook-patch.yaml
spec:
  template:
    spec:
      containers:
      - name: machine-controller-webhook
        envFrom:
          - secretRef:
              name: machine-controller-openstack

After this you can patch the deployments by running:
kubectl -n kube-system patch deploy machine-controller --patch "$(cat envfrom-controller-patch.yaml)"
kubectl -n kube-system patch deploy machine-controller-webhook --patch "$(cat envfrom-webhook-patch.yaml)"

You will have to do this after every update.

It was a mistake to provide 2 fields for cloud provider, I suggest in v1beta1 we will drop machineController.provider

@mkjoerg is it necessary to patch the deployments while KubeOne is provisioning? Seems a little bit like a chicken in the egg problem. If I run KubeOne which then fails (which is expected), I patch and rerun KubeOne the deployments are reverted by KubeOne itself. I would need to patch "while" KubeOne is running as soon as kubeconfig is available.
Another solution was to rebuild the machine-controller image like this:
FROM docker.io/kubermatic/machine-controller:v1.8.0
COPY ./ca-certificates/SubCA02_2.crt /usr/local/share/ca-certificates/
USER  root
RUN  update-ca-certificates
USER nobody

and put it on the control-plane nodes before start KubeOne provisioning. KubeOne will use the pre-existing machine-controller images which have the cert built-in (workaround).

@ivomarino I just disabled the machine-deployment while installing (removed the terraform output so it is not in the tf.json) and then I let kubeone run successfully. After this, I patch the controllers and when everything is finished I apply a prepared machine-deployment.

@mkjoerg thanks for this info, how did you deploy the prepared machine-deployment afterwards? Thanks

We are discussing how that field should be handled in #828, so I'm going to close this issue.
/close


Improve configuration system

Closes #24
CC #76
I finally got around to fixing this part of the code and I am pretty happy with it now. Most development time went into writing a macro which generates the required structs (and other items) from a very short (as in: non-boilerplate code) definition of the configuration. This also means we now have the configuration definition with its description and default values in a single place. And with this system, we could easily read some configuration values from environment variables later if we so wish.
This macro part... you can of course review but I'm not sure how useful that time is spent. Your call. In any case, I plan on extracting that logic into a separate public crate at some point because it is widely useful IMO.
The more "user facing" features of this PR are:

Remove cfg(debug) conditionals to provide some default values only for debug mode and instead add a backend/config.toml file intended for development.
Add /etc/tobira/config.toml as default search path
Add ability to specify path to configuration file via command line
Add tobira config subcommand which outputs the TOML config template to a file or stdout. This is also generated from the in-Rust config definition.

Still do decide:

Should the subcommand really be called tobira config or rather something more explicit like tobira write-config-template or sth like that?
Should the subcommand overwrite the given file or error if the given path already exists?

As I already alluded to in the code comments, maybe the actual server should be a subcommand as well, that could then be the default, somehow. This way, nothing in tobira help suggests that running it without a subcommand actually starts the server. :thinking:

As I already alluded to in the code comments, maybe the actual server should be a subcommand as well, that could then be the default, somehow. This way, nothing in tobira help suggests that running it without a subcommand actually starts the server.

If we require a subcommand to run it, then it might be more complicated to integrate into linux systems? Dunno how that usually works with systemctl and friends. But yeah, tobira help should mention it.

Should running things like tobira -h or tobira -V really still display the initial
 INFO  tobira > Starting Tobira backend...

You are right. This will be fixed by #97 which improves logging.

tobira config config.toml and tobira --config config.toml are very similar (especially if tobira is actually cargo run -- ...). We should change either, or make tobira config not override existing configs.

Good point. That's why I would prefer a more explicit subcommand name than config. See top comment. E.g. write-config-template or write-config or sth like that? I'm also fine not overriding existing files. The --config flag should stay that way tho, I think.

Ok, this was certainly not an exhaustive test, but I poked at the macro a bit and it seems to work, cool! :D Should we keep config.toml in sync with this in the CI, though?

Which config.toml? The backend/config.toml doesn't contain all configurations and does not contain any comments. It's just for devs, not for users. There is no other config.toml anywhere. We could however, do it like with schema.graphql and keep the output of tobira config in the repo.

If we require a subcommand to run it, then it might be more complicated to integrate into linux systems? Dunno how that usually works with systemctl and friends. But yeah, tobira help should mention it.

You can specify arguments in systemd units, Dockerfiles and probably every other integration layer specification thingy you can think of. :thinking: But yeah, dunno if I would even want to require it. I just thought it would make the usage more clear.

You are right. This will be fixed by #97 which improves logging.

Great! :D

Good point. That's why I would prefer a more explicit subcommand name than config. See top comment. E.g. write-config-template or write-config or sth like that? I'm also fine not overriding existing files. The --config flag should stay that way tho, I think.

I'm not a fan of these long option names, but I would also not veto any of those suggestions. If it was just me picking in a vacuum, I would probably have come up with config-template, though. :thinking: So there's another suggestion for you to consider. :sweat_smile:

Which config.toml? The backend/config.toml doesn't contain all configurations and does not contain any comments. It's just for devs, not for users. There is no other config.toml anywhere. We could however, do it like with schema.graphql and keep the output of tobira config in the repo.

Right, that's just the dev config; somehow I thought that might already be an example or something like that. In that case, I don't think we need the output in the repo for now.


Add billing info (feature)

So for so great, watson is helping with my daily time tracking. I just miss one thing if it was possible to log time paid or unpaid status with a comment for invoice/billing purpose.
for-example
watson invoice paid --from "2024-04-24" --to "2024-07-17" --comment "Invoice #223" funny-meme-task
and in reporting it should be appear with the invoice status unpaid(by-default) or paid with comment
for exmaple:
Wed 24 April 2024 -> Wed 17 July 2024
funny-meme-task - 5h 15m 59s
   [Research 1h 20m 33s]
   [Invoice Status: Paid(Invoice #233)]

something like this or may be more better. also reporting may also be added additional attribute to filter unpaid and paid hours.

Nice idea: I would love something like that.
I wonder if it's flexible enough. You want to link the invoice to a project? It might also be good to "invoice all projects" or "invoice a tag" to accommodate other Customer strategies/conventions that people could have.

I am not sure about the flexibility, but it seems like the frames are stored as json if i am not wrong so it seems flexible.
A plain text comment will be enough just like a commit message, you can save URL if you want so yes storing a link is a good idea. Yes There can be many options and strategies. I have to maintain a separate sheet for hours which are paid and unpaid even a basic project level option will be very very helpful. rest the options are limitless.

Maybe we don't need to add --paid option as it would be specific to a a paid flag, but I would suggest batch edition of tag and comment.
The idea is to be able to do this:
 watson batch  --from "2024-04-24" --to "2024-07-17" --project myproject --tag mytag --add-comment "My comment" --add-tag hello

The idea is to support the same syntax as log for filtering (from, to, project, tag, ...) and add the following actions:

add-tag, remove-tag, clear-tags
add-comment, remove-comment

Note that the "comment" feature would be a feature on its own.


Do not abort on lint error

Apps that depend on react-native-google-signin will fail to build when using ./gradlew build due to a lint error in react-native-google-signin.  This change fixes that.

@emmby thanks for the PR


Suppress event when fs.stat fails

For issue filed in watchpack repository: https://github.com/webpack/watchpack/issues/9

Thanks! Hopefully you wouldn't mind squashing those extra commits prior to merge?

Not at all - squashed!


Playlog tests: Align skipToNext behavior with Android: don't do anything when there's no nextItem set up

In order to fix the playlog tests, we need to address one of the different behaviors observed. So in this PR we address this different behavior - used by new playlog tests coming up in next PRs.
⚠ The functionality itself (skip to next) is still under testing and therefore under control in case of any issues - the reason why I haven't added a FF.
⚠ We can only run all player tests in all PRs again after this set of PRs are merged and we fix known existing flakiness.

This pull request includes changes to the PlayerEngine class in the PlayerEngine.swift file to streamline the skipToNext method and improve code readability.
Code simplification:

Sources/Player/PlaybackEngine/PlayerEngine.swift: Simplified the skipToNext method by combining the assignment and the guard statement for playerItem, ensuring the current item is unloaded only when the next item is available.

Are we sure this is desired behaviour?
Before skip to next, the client would either load the next item into Player, or, if there is no next item, do something else I guess?
With this change, the next button will do nothing if there is no next track, right? (this can be tested if you disable Autoplay ang go to the last item in the queue)
Or is the button disabled, so there is no way for the client to call skipToNext in that case?

This was a bug found during playlog tests based on their definition.
I believe it works the same way as if next is called when there is no next item. I suppose clients need to address if they want a different behavior, which I guess we don't, and that can be discussed separately.


Problem with ng serve -  reflect-metadata shim

OS.

Mac OSX  El Capitan.

Versions.

angular-cli: 1.0.0-beta.28.3
node: 6.9.5

Repro steps.

ng new projectName --style=sass

The log given by the failure.

ONLY in FireFox getting error messages:
NS_ERROR_FACTORY_NOT_REGISTERED: polyfil...ndle.js (line 2201)
uncaught exception: reflect-metadata shim is required when using class decorators

I have npm i reflect-metadata --save and imported it in polyfills.ts
The error is still there!!!

Are you still getting this problem? If so, can you provide a simple repro?

Closing as inactive.


Enable SIMD when building releases

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
DataFusion has a simd feature, which we are not enabling.
Also, I noticed that Polars builds with these flags to enable SIMD features (on certain platforms):
RUSTFLAGS: -C target-feature=+fxsr,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt,+avx,+fma

See their build script at https://github.com/pola-rs/polars/blob/main/.github/workflows/create-python-release.yml
Describe the solution you'd like
We should try this and see if it helps with performance
Describe alternatives you've considered
Additional context

Obsolete, now that DataFusion no longer has a simd feature.


onTap function doesn't work

   items: dropdownElemnts?.data?.sectors!.map((Sector value) {             return DropdownMenuItem<String>(               onTap: () {                 print('clicked');               },               value: value.id.toString(),               child: Text(value.name!),             );           }).toList(),

Actually i have two issues the first one ,the  search feature doesn't work when the value and child pramters take different values as shown..with the below code search feature will work
    value: value.name,               child: Text(value.name!),
the second issue onTap function doesn't work at all

Hello @EbrahimMosaaed ,
For the onTap not working on the item, I am not surprised this doesn’t work. Though, this may be an interesting improvement. If the onTap of the item is not null, the widget could execute it.
For the search working on the item value string, maybe this issue would help you:
https://github.com/lcuis/search_choices/issues/37#issuecomment-852035040

Hello @EbrahimMosaaed ,
Here is an example working for the onTap with the latest plugin version 2.0.8:
          String printable=new String.fromCharCodes(wordPair.characters.map<int>((element)=>element.codeUnitAt(0)).toList());
          items.add(DropdownMenuItem(
            child: Text(wordPair),
            value: wordPair,
            onTap: (){print("You tapped $printable !!!");},
          ));

This only works with non future items.

@lcuis
onTap function works perfectly fine, with the latest version 2.0.8.
Thanks .👍

You're welcome @EbrahimMosaaed !
Thanks to you for the request and the confirmation!


support for scanning license files in golang packages

Fixes #1056
As discussed with @kzantow
This checks in $GOPATH/pkg/ for a package@version, and, if it finds it, reads the licenses from there. If not found, it falls back to reading the package from the internet via the official go proxy https://proxy.golang.org
In addition, it has two new CLI flags: go-fetch bool  and --go-proxy string. The fetch is supposed to enable fetching over the Internet, default to false; the proxy is supposed to override the default.
The CLI flags are not wired up, as I could not quite figure out how to pass them all the way through to the go cataloger. I managed to get them onto the app *config.Application, but there is a bunch of steps down. Some pointers would be helpful.

I do not understand why the CLI tests fail. 🤷♂

At the request of @kzantow , I am splitting this one up into 2 PRs.
The first #1645 , only checks local GOPATH/mod for packages to find licenses. After that one is in, we will open a second PR, adding a CLI option to reach out to the Internet if a package is not found locally.

Actually, I mostly managed to get it in place. Still needs some help.

@deitch in addition to local caching of downloaded modules, I've added git support and TUI feedback (when I ran this, it seemed like it may have been hung because there was no progress being made on the number of packages), It looks like this:

🥳


Release 14.0.0 tile binary won't run in ubuntu xenial or bionic

Running the tile binary in ubuntu xenial or bionic returns the following error:
[12] Error loading Python lib '/tmp/_MEI0gpyhp/libpython3.7m.so.1.0': dlopen: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /tmp/_MEI0gpyhp/libpython3.7m.so.1.0)
GLIBC_2.28 seems to be a cosmic specific package version. Cosmic is end-of-life.

Fix is already in the pre-releases. Will cut a new stable release.


[Improvement] Support get property from env/jvm/common.properties

Purpose of the pull request
In the current logic, if the property is not in common.properties, then it cannot override from env.
This PR is aim to fix this.
Brief change log
Get the config property by priority, env > jvm > common.properties.
Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

(or)
If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Codecov Report

Merging #14645 (09d9273) into dev (79cf785) will increase coverage by 0.00%.
The diff coverage is 44.18%.

:exclamation: Current head 09d9273 differs from pull request most recent head a0b35d2. Consider uploading reports for the commit a0b35d2 to get more accurate results

@@            Coverage Diff            @@
##                dev   #14645   +/-   ##
=========================================
  Coverage     38.57%   38.58%
- Complexity     4593     4596    +3
=========================================
  Files          1280     1283    +3
  Lines         43833    43809   -24
  Branches       4843     4816   -27
=========================================
- Hits          16907    16902    -5
+ Misses        25047    25031   -16
+ Partials       1879     1876    -3

Files Changed
Coverage Δ

...inscheduler/api/service/impl/UsersServiceImpl.java
70.83% <0.00%> (ø)

...atasource/api/plugin/DataSourceClientProvider.java
0.00% <0.00%> (ø)

...sk/api/shell/BaseLinuxShellInterceptorBuilder.java
0.00% <0.00%> (ø)

...server/worker/utils/TaskExecutionCheckerUtils.java
7.69% <0.00%> (ø)

...phinscheduler/common/config/IPropertyDelegate.java
20.00% <20.00%> (ø)

...heduler/api/service/impl/ResourcesServiceImpl.java
44.53% <33.33%> (+0.05%)
:arrow_up:

...nscheduler/api/service/impl/TenantServiceImpl.java
61.42% <33.33%> (ø)

...e/dolphinscheduler/common/utils/PropertyUtils.java
32.00% <38.88%> (-2.74%)
:arrow_down:

...mmon/config/ImmutablePriorityPropertyDelegate.java
48.97% <48.97%> (ø)

...duler/common/config/ImmutablePropertyDelegate.java
58.33% <58.33%> (ø)

... and 2 more

... and 33 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


KYC : if kyc is declined or after 5 minutes the KYC is still pending, allow user to redo a kyc

and stop the API call

and display a message to say user to redo his kyc as it failed

Size: S


Theoretical Issues with Clique

Background
It seems like clique was crafted as a concensus network for Rinkeby testenet. However, it came across a large swath of issues around halting and deadlock states. For geth it was the longest standing issue in the project, and was closed without resolution due to deprecation of clique support by the geth team. See here
Question: Were you able to resolve the issues with clique that cause deadlocked states?
To give some context, here's a visual:

In a situation of 3 signer nodes, due to network instability, you can arrive in a situation where each party has a split view of the world, such that all sealers/signers are too recent in their view of the chain to sign the next block, but the difficulty in each of their views is equivalent, resulting in no reorgs. Does Besu ever encounter similar issues of halting? If not, how did you resolve these theoretical shortcomings of Clique?
For more examples, here's a simulation script that can demonstrate such stuck states: goerli/diff-simulation

See https://eips.ethereum.org/EIPS/eip-3436, implemented in https://github.com/hyperledger/besu/pull/2084

Thank you!


Debugging "Unable to connect to remote server" on rocketeer check

Not sure where to look to determine why rocketeer is unable to connect to a remote server. I'm able to connect just fine using ssh<EMAIL_ADDRESS>I've tried with a blank key entry in the connection array, as well as the absolute path.
Running rocketeer check -vvv doesn't give me anything useful in trying to solve the connection problem.
Thoughts anyone?

Is this on 2.0 or 2.1-dev? If the former, can you test with the develop branch?

Looks like Rocketeer version 2.0.4. I'll try pulling down 2.1-dev and see where I end up.

The new prompt for passphrase seemed to kick something into gear and things are connecting just fine. I'd imagine it'll work on 2.0.4 now as well. Thanks @Anahkiasen


Add a 'forceUpdate' flag to force the update of an API

Following question #55 ,
In some cases, it is required to force the apim-cli to update an already existing API. For instance, to update the password of an http_basic authenticationProfile.
Currently, in v7.7 some elements (such as passwords) are no longer returned by API Manager REST API, meaning that apim-cli is unable to determine whether or not they need to be updated in API Manager.
It would be helpful to have a "forceUpdate" flag either in the commandLine to indicate apim-cli that the whole content of the api contract file needs to be reapplied.

A new forceUpdate flag will be available in the next release.
"forceUpdate" ....  "If set, the API is Re-Created even if the Desired- and Actual-State are equal."


Potential ABAP command injection in method DESERIALIZE_PROGRAM of class ZCL_ABAPGIT_OBJECTS_PROGRAM

There is a Prio1-ATC-issue in method DESERIALIZE_PROGRAM of class ZCL_ABAPGIT_OBJECTS_PROGRAM in line 88

      INSERT REPORT is_progdir-name
       FROM it_source
       STATE 'I'
       EXTENSION TYPE is_progdir-name+30.

There are a Prio1-ATC-issue in method DESERIALIZE_PROGRAM of class ZCL_ABAPGIT_OBJECTS_PROGRAM in line 96

      INSERT REPORT is_progdir-name
        FROM it_source
        STATE 'I'
        PROGRAM TYPE is_progdir-subc.

I'm not sure how this one can be avoided? The purpose of the abapGit client is to take code from a remote repo and add it into the system

I suppose it would require to mitigate the INSERT REPORT statement by an API to avoid ATC findings.
Will check it with colleagues.


Use 6.1 Copr repo

Only for CI test run
Signed-off-by: Joe Grund<EMAIL_ADDRESS>

This change is

Just to test CI runs?

This will build with the mfl 6.1 repo. We won't want to merge it into master though.