Dnyandeo : Behaviour, Strategy, Implementation, 3 weeks

Learning Objectives

Priorities: 🥚, 🐣, 🐥, 🐔 (click to learn more)

There is a lot to learn in this repository. If you can't master all the material
at once, that's expected! Anything you don't master now will always be waiting
for you to review when you need it. These 4 emoji's will help you prioritize
your study time and to measure your progress:

🥚: Understanding this material is required, it covers the base skills you'll
need to move on. You do not need to finish all of them but should feel
comfortable that you could with enough time.
🐣: You have started all of these exercises and feel you could complete them
all if you just had more time. It may not be easy for you but with effort you
can make it through.
🐥: You have studied the examples and started some exercises if you had time.
You should have a big-picture understanding of these concepts/skills, but may
not be confident completing the exercises.
🐔: These concepts or skills are not necessary but are related to this module.
If you are finished with 🥚, 🐣 and 🐥 you can use the 🐔 exercises to push
yourself without getting distracted from the module's main objectives.

1. Remix
Practice studying and remixing other people's solutions to coding challenges. Create your own solutions by mixing and matching pieces from other people's code.

🐣 Reconstructing: You can reconstruct a variety of solutions to the same challenge when they are presented as parsons problems.
🐣 Analyzing: You can analyze a function written at your level. This includes:

[x] Behavior: Write documentation, test cases and use cases to describe the function's behavior.
[x] Strategy: Describe the function's strategy using plain english.
[x] Implementation: List the language features in a function and explain how each one is used.
[x] Small Changes: You can think of 2+ changes to the function's implementation that would not change it's strategy.

🐣 Remixing You can analyze several solutions to the same challenge then ...

[x] Write: Your own solution by remixing the ones you studied.
[x] Explain: How the other solutions inspired yours; what ideas did you take from them? what ideas did you not take?
[x] Analyze: Complete a write-up your own solution as though someone else wrote it.

2. Write

🐣 Function Design:

[ ] Writing Tests: Given a working function, you can write passing test cases to describe it's behavior.
[ ] Writing Functions: You can design multiple solutions to the same code challenge, keeping notes about different experiments you tried along the way.

[ ] 🐣 Generating Documentation: You can write a JSDoc comment for your solutions and run a script to generate markdown documentation.
[ ] 🐣 Fuzz Testing: You write solutions that pass randomly generated test cases.
🐣 Test Driven Development: You can solve open-ended, ambiguous coding challenges at your level:

[ ] Reading Docs: You can understand what the function is supposed to do by reading it's JSDoc description.
[ ] Writing Tests: You can write test cases before there is a function to test.
[ ] Writing Functions: You can write one function that passes the test cases you have prepared (even if it's just 1 test case!).
[ ] Refactoring: You can improve your function's implementation without failing any test cases that were passing.
[ ] Iterative Development: You can repeat the TDD process until you are satisfied with your test cases and solution.

[ ] 🐔 Code Golf: Write your solutions with the fewest characters possible! This won't help you write readable code, but it will make you think deeply about JS, your strategy and implementation.

3. Review

🐣 Continuous Integration: You can check your code's quality before pushing so your CI checks all pass.

[ ] Formatting
[ ] Linting
[ ] Testing

[ ] 🐣 Code Review: You can use a checklist to give a thorough, positive and constructive review of your classmates' solutions.
[ ] 🐔 Code Coverage: You can explain what code coverage is, why it's important, and can write unit tests with 100% code coverage.

Week 1
I Need Help With:
There are a couple of behavior-driven development frameworks like Jest, Jasmine, Mocha. which one do we need to use?
What went well?
I understood the syntax of testing. The first time testing code seems hard but after exercise getting familiar with testing code.
What went less well?
Testing is not an easy task, I need to think more about positive and negative possibilities. Now It's going hard for me.
Lessons Learned
Testing is essential for every development
Sunday Prep Work
Practice... Practice ... Practice

You can use whichever you llike most, they are VERY similar. For the HYF course, Evan has used Jest, which is probably the most popular at the moment and is maintained by Facebook.

Week 2

[ ] I have pushed my code my fork of exercises repo

What went well?

Getting familiar with some jest framework.
Everything went smoothly
I wrote more and more test cases and exercise with function.
learned more about jets methods and function.

Lessons Learned
Think more according to problems.
Sunday Prep Work
Practice... Practice...Practice...

excellent work

Week 3

[x] This is our group repo
Group4-Practice-code-review

What went well?

All examples are given challenge but because of this revised all methods again.
Everything went smoothly
We almost finished our group exercise.
Tried to write more and more different test cases.

Lessons Learned
For solving problems research is most important. tackle problems one by one. Think according to the user.
Sunday Prep Work
Continue doing exercise...

For solving problems research is most important. tackle problems one by one. Think according to the user.

you are a very good learner and well done for solving the exercises well and quickly.
when helping others, sometimes it can be helpful to help them find the solution on their own by giving tips and guidance, and only if they still struggle for long, reveal part of the solution.

Thank you so much @danielhalasz your appreciation inspires me. As you advised, while helping others first, I give references on the internet for learning. only if they cannot solve, I help them with code.


boards: riscv: Convert HiFive1 to DTS

Adds DTS bindings for sifive,pwm0, sifive,uart0, sifive,spi0, and
riscv,plic0.
Signed-off-by: Nathaniel Graff<EMAIL_ADDRESS>Signed-off-by: Palmer Dabbelt<EMAIL_ADDRESS>

https://github.com/zephyrproject-rtos/zephyr/pull/9195

Codecov Report

Merging #9375 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9375   +/-   ##
=======================================
  Coverage   52.52%   52.52%
=======================================
  Files         201      201
  Lines       25352    25352
  Branches     5299     5299
=======================================
  Hits        13316    13316
  Misses       9941     9941
  Partials     2095     2095

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d04eaf3...1d48b0e. Read the comment docs.


Make accessibility improvements

Now that I've had my tryst with accessibility in SwiftUI, its time to make accessibility improvements and also incorporate it as a part of development (rather than an afterthought). I'll be posting more to this issue as and when I make any improvements in this regard.
Any ideas/criticism/comments for any accessibility features/requirements/improvements are welcome.

This week's experience of running my MacBook pro without a display has made the goals clear for me. Going forward, the goal is to make KiWings usable for blind audience as well. This includes starting and stopping kiwix server. And launching the address in the desired browser.

Respect low power mode and reduce motion like accessibility settings :)


supported helm version

does this project support helm v2.14.1 and helm v3.0.3

@bluebeach avionix only officially supports helm 3, but it's possible that it would work with helm 2 as well


Debugger doesn't break on stackoverflow exceptions

Hi,
I yesterday found out that the debugger although set to break on all exceptions doesn't break on an stackoverflow exception. If putting inside a Try-catch it is caught with the correct stack trace.
Here is a imple reproproject that show the problem.
https://github.com/escamoteur/overflow_exception_repro
PS C:\Entwicklung\FlutterApps\Tests\overflow_exception_repro> flutter doctor -v
[√] Flutter (Channel dev, v0.5.5, on Microsoft Windows [Version 10.0.17134.112], locale de-DE)
• Flutter version 0.5.5 at C:\Entwicklung\Flutter
• Framework revision 020e0ef (10 days ago), 2018-06-14 13:17:08 -0700
• Engine revision c3976b3c71
• Dart version 2.0.0-dev.61.0.flutter-c95617b19c
[√] Android toolchain - develop for Android devices (Android SDK 27.0.3)
• Android SDK at C:\Users\escam\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-27, build-tools 27.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b02)
• All Android licenses accepted.
[√] Android Studio (version 3.1)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 24.2.1
• Dart plugin version 173.4700
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b02)
[!] VS Code, 32-bit edition (version 1.24.1)
• VS Code at C:\Program Files (x86)\Microsoft VS Code
• Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[√] Connected devices (1 available)
• Android SDK built for x86 • emulator-5554 • android-x86 • Android 7.1.1 (API 25) (emulator)
! Doctor found issues in 1 category.

/cc @aam

How do other Languages solve this? Saying that's by design I would respond that's an design flaw.

IIRC I don't think C# breaks on these either; I remember it being a pain to track down some stack overflows I had in the past. I did always think it was weird that they couldn't/didn't reserve some resources to be able to handle it better; but it's well over my head so I don't know all the details!


API docs: initial add of HHS COVIDcast source

Still todo:

limitations
lag
decide whether to include facilities signals or put them off to a future release cycle

I will be out from the 21st through the new year, so @chinandrew and @dfarrow0 will be picking up any remaining work on this PR.

@krivard We didn't discuss it explicitly, but shouldn't we also produce the cumulative version and the per-population version?

@krivard We didn't discuss it explicitly, but shouldn't we also produce the cumulative version and the per-population version?


Allow session to work with callbackQuery and inlineQuery

When using the session on inline queries or on inline buttons sent from inline queries the defaultGetSessionKey was useless and errored: Cannot access session data because the session key was undefined!
With this change both inlineQuery (which has from) and callbackQuery (which has either chat or chat_instance) work out of the box.

When reading the documentation it isn't very specific about the default behaviour of the default session key. It only tells that the session in general is a neat thing to handle data per chat which isn't changed by this PR.
callbackQuery.chat_instance is still the chat (but can be a different key even if the chat is the same) and inlineQuery.from is chat independent in general but this also doesn't change the idea of the session to help with keeping data of chats. If someone wants a different key (for example always ctx.from) it's also described and also isn't changed by this PR.
Am I overlooking something?

For example, when running on webhooks, Telegram delivers updates sequentially per chat.

This sounds like a dangerous assumption as its out of control for this library.

Independent from this change people should be aware of race conditions and that atomic changes are always best for handling them. (But most stuff isn't atomic)
https://grammy.dev/advanced/scaling.html#concurrency-is-hard already notes this and suggests using sequentialize.
I guess this would spark a discussion about many major / breaking releases with small impact vs few big breaking releases or separation of logic vs centralized logic.
As we can't add smaller breaking changes well currently I don't see this change being merged. When needed the getSessionKey can be overwritten so its a simple change anyway.

This sounds like a dangerous assumption

I don't think it'll change soon. The Bot API server developer confirmed this behaviour, so it seems like we can rely on it.


Firebase implementation and persisting data

implemented firebase instantiation inside constants file so that all parts of the app (redux and components will have access to ref)

firebase ref is userData inside constants, to use, just import {userData } from "< path-to-constants-file >"

for your own testing you can create a new ref inside consants by creating a new child/endpoint using firebase methods. See https://www.firebase.com/docs/web/guide/setup.html

generated unique ID's for pins using firebases' unique id (our previous unique id was buggy/insufficient)

now data persists and previously saved pins are rendered after refresh!

In the containers, I also added changes by removing mapDispatchToProps and passing down the dispatch actions using deconstructed references and putting them directly inside the connect. (this works just the same and makes it more explicit which actions/thunk functions we want to use)
let me know if you have any questions about this part =]

resolves #45

@jake-shasteen @asu91 Hi. I've made the appropriate changes. Thanks for all the catches Jake!
note: Right now the app uses way too much cpu since the current location had been built in the component state and keeps rendering/calling render markers many many times.
Since this is a larger change, we need to add a task to fix this.

Thanks @tiffeli


"exported" attribute for Pushe component while targeting Android 12

Hmm
Thanks for reporting this.
Will take a look as soon as I could.
It seems a new release is required.

any solution?

When a project is a business or shared service.
More support is needed.
A few months have passed since the issue, several requests are open.
This is not a good thing for a business.
Best,

M.

Sorry for the delay.
I'm currently working on the next release which also includes a fix for this issue where <service> tags are required to explicitly define exported attr.
First snapshot is up and accessible via
maven { url("https://s01.oss.sonatype.org/content/repositories/snapshots/") }

with version=2.6.0-alpha01-SNAPSHOT

It's currently in progress of being tested and rest of the needed features being added to it. I will resolve this issue as soon as 2.6.0 becomes released as stable version.


CVEs without GitHub advisory are not made available in OSV DB

Hi Colleagues,
There are some Vulnerabilities for which there is no GitHub advisories but the CVEs are made available. For example below:
CVE-2022-3509 = com.google.protobuf:protobuf-java:2.5.0
Additional details: https://security-tracker.debian.org/tracker/CVE-2022-3509
How are we planning to tackle these?

Hi! Thanks for creating this issue. @andrewpollock is tackling this longer term effort as part of #783


Suggestion for improving the dialog component

This function solves the problem (这个功能解决的问题)
Usability of the dialog box
Expected API (期望的 API)

[Very necessary] Blocking the "Negative button" when the loading property = true or give access to button properties;

[Very necessary] Adding a dialog closing event to the "ESC" key;

Make "useDialog" promisable for comfortable work with asynchronous functions.

Example:
async test() {
    await useDialog().success(...);
    // resolve: click on a positive button
}

I'll think of it.

consideration needed
should doo
consideration needed

Thanks :)

consideration needed
should do
consideration needed

2是不是已经做了？

consideration needed
should do
consideration needed

2是不是已经做了？

We haven't finished 2. If esc is pressed, no callback will be fired. You may mean close (clicked) event.

This issue does not have any recent activity. If you are still experiencing similar problems, open a new error, including a minimal copy of the problem


Info

Hi.
I am sorry to contact you here but I am new and I did not find a better way to reach you.
I am looking for a tool that allow me to automatically monitor webpages. Examples of use: track the price of an item and/or check item availability.
Features that I would like to have:

Option to track just a portion of a page, instead of the whole page
Notifications directly on my phone
Option to customize the frequency of the checks

Does your tool allow this?
My intention would be to use this stuff in a raspberry, as it is cheap solution and it has a low power consumption. Is it in your opinion suitable for this?
Thanks

It doesn't really let you do this, since it only monitors content referenced in RSS feeds. However if you write a scraper that creates an RSS feed of content that is to be monitored then you can point diffengine at it.
I do this for https://www.whitehouse.gov/ since Trump killed their RSS feed. I scrape the contents of the web page every hour and generate an RSS feed of recent content:
https://inkdroid.org/rss/whitehouse.xml
Then I point diffengine at that. It's been working nicely for a few years now.


kill pledging

With the move to Teams we no longer support pledging to arbitrary social network accounts. Incorporates #3402, works towards #3399.

Ready for review/merge, @rohitpaulk @techtonik et al.

3ba5d0d c2cf25a are failing at Travis because of a pyflakes violation. Presumably 1eb481e will fail with the same.

Yup. Should be fixed in e67a9e1.

Hmm ... how do I run pyflakes globally locally?

make pyflakes

Not LGTM on killing the code that is useful for potential forks.

@techtonik Don't worry, we use version control. ;-)

Right, but how somebody is supposed to find that? The branch info is erased and there is no like "feature tagging" to know which revisions still fully supported this feature.

And before killing the DB, I'd like to dump my data from it, for example, to know how generous I am and see which project won't be able to receive my donations anymore because of this pivoting.


EPSG:8088 missing in DotSpatial

Hi
Any change to add this coordinate system EPSG:8088 ... ISN2016 / Lambert 2016  to DotSpatial
https://epsg.io/8088
Regards
Sigster

You can use any coordinate system as long as you know its wkt value.

Maybe it would be a good idea to update the epsg.ds anyway. As far as I know DotSpatial.Projections gets the coordinate systems it knows from this file, which is also part of the repo. EPSG 8088 seems to be available in the dataset since 2017.
https://epsg.org/crs_8088/ISN2016-Lambert-2016.html


[BUG] MIDI listener performance

Does the issue occur in the electron-app or the web-app?

[X] midi-bricks-electron
[ ] midi-bricks-web-app
[ ] I do not know nor understand

Can you determine, which version was used?
Version: 0.12.44
Describe the bug
Bad and jittery MIDI listener performance, just as we had some time ago. Cannot clearly reproduce concrete conditions: once it works fine and smooth, next time it doesn't. Seems to interfere with Preset loading.
Steps To Reproduce
Steps to reproduce the behavior:

create large preset with many elements (ca. 100). include several elements with MIDI listener on CCs of an external MIDI device.
save preset and close app
re-open app and load preset
test performance of the MIDI listeners
close and re-open the app again
test performance
load preset and test performance
does it always perform well?

Expected behavior
always, termless good performance
Desktop Version (please complete the following information):

OS: Win 10 64bit

Additional context
@TimSusa hatte dir den Fehler schonmal am 6.2. beschrieben

additional information:
this issue is not only related to preset loading.
steps to reproduce:

Open the Electron app, my previous preset is automatically loaded and LIVE mode is active. Listener performance is fine.
Deactivate LIVE mode: Listener performance is bad!
Reactivation of LIVE mode does not help.
Close App, reopen and stay in LIVE mode (no preset load etc.): performance is fine.

I'm sorry, but I note that the condition in my last comment above is not consistent, too.
@TimSusa : let's have a phone call next week and sort it out :)

Hey, just please try to change the footer page, after you have set to live mode. This should extract the page from the big state and performance should be fine.

Tested on 0.12.53. The problem still is:
After loading a preset, the performance is bad. Even in LIVE mode, after switching pages in the footer.
I'm desperate, because there is no consistent condition for clear reproduction: Like in 90% the performance is fine after opening the App without loading a preset. And in 10% the it's fine after loading a preset.

Maybe, it is an issue with timing or better said events, which are waiting in the queue, where afterwards the digest cycle went further. So would you try to do the actions delayed by some kind of seconds and never ever trigger a midi event from the hardware, before switching to live mode? Maybe wait for 3-5 sec until switching to livemode and after that waiting again when switching footer pages. Do you obtain different behaviour?

Sheeeeeeesh, this is solved in 0.12.66! Sliders controlled by external MIDI hardware are running super smooth!
After opening the app, before and after loading presets and even when not being in LIVE mode - always smooth.
Thanks so much!

I like to hear from this!


Fix image bleed

Large images in the #content box weren't restricted to the width of the box, causing them to disappear behind the right border of the #content box.

:+1:
Lovely, thanks :)

Tested. Looks nice :tada:


Want to use Nhost on Nuxt3 ?

I want to create a Nuxt3 module base on nhost Js client to use it in Nuxt 3.
User ( session, cookie etc )
Graphql ( query + mutation )
Storage
Functions
I'm not expert, but ready to learn and sweat to do so
Someone is already work on it ? can I join ?
@elitan  @plmercereau are you open to this suggestion ?

Salut @plmercereau 🇧🇪 🇫🇷
I go the point with cookie refresh on bot side ( client +server ) without using hasura-auth
thanks for use NUXT 3 got useCookie , good point for use
I will push you some code and demo when it will be ready, now to much buggy .. 🐛
I still learning a lot
Thanks

One main thing to keep in mind is that hasura-auth does not support cookies, so the cookie will be shared with Nuxt client and server, but not hasura-auth. In the meantime, both client and server should be able to refresh the token, while updating the refresh token as a cookie.
@plmercereau why is this not on hasura-auth ? And is this still the case in July

Hey at all,
here you can find a ready to use Nuxt 3 module: https://github.com/maximilian-schwarz/nhost-nuxt3-plugin


[BUG] - BP running 1.34.1 drops connection to relay running 1.35.1 and never restores it w/o bouncing relay

External
Area
Stake pool: network connectivity issues between BP and Relay running different versions of the node, 1.35.1 vs 1.34.1
Summary
Hello, this is Giovanni and I operate EASY1 Stakepool.
I've recently replaced one of the three relays I run with the latest 1.35.1.
In the past few days I've noticed the BP repeadetly loosing connection to the relay and failing to re-enstablishing it. The only way to connect the two again is restarting the relay.
I can't tell if relay-to-relay there is a similar issue, but should there be, this could potentially affect network connectivity among Stakepool upgrading to 1.35.x, while other might be on previous version and dramatically affect block propagation.
I've found at least two more SPOs w/ same issues.
Steps to reproduce
Hard to reproduce, it just happens randomly
Expected behavior
BP and relay shouldn't lost connection to each other
System info (please complete the following information):
BP running 1.34.1 (official docker image)
Relay running 1.35.1 (official docker image)

ALTZ pool - same issue. Additional data: the metric cardano_node_metrics_connectedPeers_int reflect the lost of connection but netstat or gLiveview show simetric outcoming and incoming connections including the 1.35.1 relay. The BP node log shows different message for 1.34.1 relay and 1.35.1 one: {"host":"ip-xxx-x","pid":"16xxx","loc":null,"at":"2022-07-22T17:34:00.81Z","ns":["cardano.node.BlockFetchDecision"],"sev":"Info","env":"1.34.1:a357c","data":{"kind":"PeersFetch","peers":[{"peer":{"remote":{
"port":"xxxx","addr":"<relay 1.35.1 node IP>"},"local":{"port":"xxxxx","addr":"<BP 1.34.1 node IP>"}},"kind":"FetchDecision declined","declined":"FetchDeclineChainNotPlausible"},{"peer":{"remote":{"port":"xxxx","addr":"<relay 1.34.1 node IP"},"local":{"port":"xxxxx","addr":"<BP 1.34.1 node IP"}},"kind":"FetchDecision results","length":"1"}]},"msg":"","thread":"xxx","app":[]}
I don't know if it is related to this issue.

same issue here

I have all these issues fixed finally. But yes I have seen them...
What i had to do is make sure every relay and BP is under a separate public IP, and also had to play around with NAT settings.
I also enabled firewall rules between my relays, so my own relays never connect to each other.

Oh, sorry... this was between 1.34.1 and 1.35.1 ... I had this happening between 1.35.1 relays...

Anyway, it has been recommended to have interconnected the own relays. I don't understand how we have to avoid to connect our 1.35.x relays to each other.

Anyway, it has been recommended to have interconnected the own relays. I don't understand how we have to avoid to connect our 1.35.x relays to each other.

Well, in my test I had choice, have interconnected relays, or have relays missing from the block producer, so i decided my block producer is more important ;-)

Little off-topic question, but how can I enable cardano_node_metrics_connectedPeers_int ? I don't have such a metric in Prometheus metrics

Little off-topic question, but how can I enable cardano_node_metrics_connectedPeers_int ? I don't have such a metric in Prometheus metrics

Hey, good question, you need to update your config.json, there is one of this flag that needs to be set to true
{
  "AlonzoGenesisFile": "mainnet-alonzo-genesis.json",
  "AlonzoGenesisHash": "7e94a15f55d1e82d10f09203fa1d40f8eede58fd8066542cf6566008068ed874",
  "ApplicationName": "cardano-sl",
  "ApplicationVersion": 1,
  "ByronGenesisFile": "mainnet-byron-genesis.json",
  "ByronGenesisHash": "5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb",
  "LastKnownBlockVersion-Alt": 0,
  "LastKnownBlockVersion-Major": 3,
  "LastKnownBlockVersion-Minor": 0,
  "MaxKnownMajorProtocolVersion": 2,
  "Protocol": "Cardano",
  "RequiresNetworkMagic": "RequiresNoMagic",
  "ShelleyGenesisFile": "mainnet-shelley-genesis.json",
  "ShelleyGenesisHash": "1a3be38bcbb7911969283716ad7aa550250226b76a61fc51cc9a9a35d9276d81",
  "TraceAcceptPolicy": false,
  "TraceBlockFetchClient": false,
  "TraceBlockFetchDecisions": true,
  "TraceBlockFetchProtocol": false,
  "TraceBlockFetchProtocolSerialised": false,
  "TraceBlockFetchServer": false,
  "TraceChainDb": false,
  "TraceChainSyncBlockServer": false,
  "TraceChainSyncClient": false,
  "TraceChainSyncHeaderServer": false,
  "TraceChainSyncProtocol": false,
  "TraceConnectionManager": false,
  "TraceDNSResolver": false,
  "TraceDNSSubscription": false,
  "TraceDiffusionInitialization": false,
  "TraceErrorPolicy": false,
  "TraceForge": true,
  "TraceHandshake": false,
  "TraceInboundGovernor": false,
  "TraceIpSubscription": false,
  "TraceLedgerPeers": false,
  "TraceLocalChainSyncProtocol": false,
  "TraceLocalErrorPolicy": false,
  "TraceLocalHandshake": false,
  "TraceLocalRootPeers": false,
  "TraceLocalTxSubmissionProtocol": false,
  "TraceLocalTxSubmissionServer": false,
  "TraceMempool": false,
  "TraceMux": false,
  "TracePeerSelection": false,
  "TracePeerSelectionActions": false,
  "TracePublicRootPeers": false,
  "TraceServer": false,
  "TraceTxInbound": false,
  "TraceTxOutbound": false,
  "TraceTxSubmissionProtocol": false,
  "TracingVerbosity": "NormalVerbosity",
  "TurnOnLogMetrics": false,
  "TurnOnLogging": true,
  "MaxConcurrencyBulkSync": 2,
  "MaxConcurrencyDeadline": 3,
  "defaultBackends": [
    "KatipBK"
  ],
  "defaultScribes": [
    [
      "StdoutSK",
      "stdout"
    ]
  ],
  "hasEKG": 12788,
  "hasPrometheus": [
    "<IP_ADDRESS>",
    12798
  ],
  "minSeverity": "Info",
  "options": {
    "mapBackends": {
      "cardano.node.metrics": [
        "EKGViewBK"
      ],
      "cardano.node.resources": [
        "EKGViewBK"
      ]
    },
    "mapSubtrace": {
      "cardano.node.metrics": {
        "subtrace": "Neutral"
      }
    }
  },
  "rotation": {
    "rpKeepFilesNum": 10,
    "rpLogLimitBytes": 5000000,
    "rpMaxAgeHours": 24
  },
  "setupBackends": [
    "KatipBK"
  ],
  "setupScribes": [
    {
      "scFormat": "ScText",
      "scKind": "StdoutSK",
      "scName": "stdout",
      "scRotation": null
    }
  ]
}

This one is one of my relay tracing for that metric, can't remember exactly which one it is, but I seem to remember to be "TraceBlockFetchDecisions": true,.
Anyway make a diff with your config and you'll easily find out the one or to to change.

This should be fixed in 1.35.3 release. Is it ok to close it?

This should be fixed in 1.35.3 release. Is it ok to close it?

Doing it now. Thanks


[BUG] sharePoolCPUCore not exclude LSE

What happened:
I found sharePoolCPUCore logic not exclude LSE pod which in function getNodeStateForBurst https://github.com/koordinator-sh/koordinator/blob/382f7a03b7dd42eac5866c9fffbc25760807080d/pkg/koordlet/resmanager/cpu_burst.go#L234
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
Environment:

App version:
Kubernetes version (use kubectl version):
Install details (e.g. helm install args):
Node environment (for koordlet/runtime-proxy issue):

Containerd/Docker version:
OS version:
Kernal version:
Cgroup driver: cgroupfs/systemd

Others:

how about this? sharePoolCPUCoresTotal = nodeCPUCoresTotal - LSE - LSR

how about this?
sharePoolCPUCoresTotal = nodeCPUCoresTotal - LSE - LSR
sharePoolCPUCoresUsage = nodeCPUCoresUsage - LSE - LSR - BE

how about this? sharePoolCPUCoresTotal = nodeCPUCoresTotal - LSE - LSR sharePoolCPUCoresUsage = nodeCPUCoresUsage - LSE - LSR - BE

or this?
sharePoolCPUCoresTotal = nodeCPUCoresTotal - LSE
sharePoolCPUCoresUsage = nodeCPUCoresUsage - LSE - LSR - BE

how about this? sharePoolCPUCoresTotal = nodeCPUCoresTotal - LSE - LSR sharePoolCPUCoresUsage = nodeCPUCoresUsage - LSE - LSR - BE

This is correct.

fixed by #1404


new Complex(-0, -0) is changed into new Complex(0, 0) since v2.4.1

In commit https://github.com/rawify/Complex.js/commit/6ee03df1bef664715f2efa5c85e6d387ec2d8e4e the use of parseFloat is introduced. It turns out that parseFloat(-0) returns 0 and not -0.
I came across this when unit testing the result of new Complex(1).acosh(), which returns { re: -0, im: 0 }, but it is now impossible to create a complex value that holds a re value of -0, which needed to compare that outcome in a unit test 😅.

Interesting, parseFloat(-0)==0. Should I revert the use of parseFloat?

What was the reason for adding parseFloat? Is it to parse string input?

I used Complex.js somewhere and and just split() a string and passed the array as argument to Complex.js, while I wondered that this way the return value contained string and saw that for arrays and objects this wasn't the way it was implemented.

To solve this I think it would be good to create your own parseInputValue helper function, which first checks whether the input is a string and only then parse it. You could consider using Number instead of parseFloat (see https://stackoverflow.com/a/11988751/1262753).

@josdejong wrote:

To solve this I think it would be good to create your own parseInputValue helper function, which first checks whether the input is a string and only then parse it. You could consider using Number instead of parseFloat (see https://stackoverflow.com/a/11988751/1262753).

But beware that Number() has its own problems, as someone pointed out in a comment in one of the answers to that stackoverflow question.
I've used this:
      // Do not use parseFloat for this, since that ignores trailing stuff.
      // However, beware that the Number constructor unhelpfully converts
      // zero-or-more spaces to 0.
      let value = /^\s*$/.test(valueString) ? NaN : Number(valueString);

Alternatively, the easier route would be to revert the change and add a note in the readme that the elements of objects and arrays should be Number.

Yes indeed😄

Done, sorry for the interlude.

Thanks, all looks good again 👍


Will this library support TinyMCE 6, and if so, is there an expected release date.

I'm sorry if this isn't the proper venue to ask a question like this, but we recently noted that TinyMCE 5x reaches End of Support on 4/2023 ( https://www.tiny.cloud/blog/tinymce-end-of-support/ ).
We tried configuring django-tinymce with TinyMce 6 to upgrade one of our sites, and it worked locally, but not on our server, where we receive the following JavaScript error:
Uncaught TypeError: Cannot read properties of undefined (reading 'id_body')
at initTinyMCE (init_tinymce.js:39:27)
at init_tinymce.js:59:7
at NodeList.forEach ()
at HTMLDocument. (init_tinymce.js:58:43)
There is an textarea#id_body in the admin page and, as noted, it renders as a TinyMce widget locally, but not when deployed as on a server.  I suspect that the javascript is loading before the HTML, but I don't know how to resolve that.  Any assistance that you can provide is appreciated.

It will support TinyMCE 6 when someone writes the missing bits :smile:
Did you test with the latest 3.5 release or with the code in master?

Does permission need to be given to bundle the new version? Given the new licence, I would assume not?
I tried replacing with the latest version of tinyMCE with the latest code in the repo and it appears to work out of the box as best as I can tell. I had to tweak a test, to get tox to pass, I only tested against 39 and 310.

Oh, would be great to document the license issue. If it happens we are stuck on TinyMCE 5, we may then deprecate this package and recommend an alternative (or several).

We upgraded our site’s import to django-tinymce==3.5.0
As noted in my report, the strange thing for us is that the TinyMCE 6 widget renders when we run our Django site locally, but not when we deploy it to our production Linode/Ubuntu server.
When we run it on the server, we receive this error in a browser console:
init_tinymce.js:39 Uncaught TypeError: Cannot read properties of undefined (reading 'id_body')
at initTinyMCE (init_tinymce.js:39:27)
at init_tinymce.js:59:7
at NodeList.forEach ()
at HTMLDocument. (init_tinymce.js:58:43)
This code is within the page’s html, so there an id_body element:

                    Body:

                        <textarea class="tinymce" cols="40" data-mce-conf="{"theme": "silver", "selector": "textarea.tinymce", "file_picker_callback": "djangoBrowser", "width": 1000, "height": 400, "plugins": ["advlist", "anchor", "charmap", "code", "fullscreen", "hr", "image", "imagetools", "importcss", "link", "lists", "nonbreaking", "powerpaste", "print", "searchreplace", "table", "visualchars", "wordcount"], "menubar": ["file", "edit", "insert", "view", "format", "table", "tools"], "toolbar": ["undo redo| bold italic | alignleft aligncenter alignright alignjustify | link anchor image code | print fullscreen", "cut copy paste pastetext | searchreplace | numlist bullist | outdent indent blockquote | hr charmap | visualchars nonbreaking"], "imagetools_toolbar": "rotateleft rotateright | flipv fliph | editimage imageoptions", "extended_valid_elements": "iframe[src|width|height|name|align|frameBorder],script[language|type|src],object[*],param[name|value]", "image_caption": false, "image_advtab": true, "powerpaste_allow_local_images": true, "powerpaste_word_import": "prompt", "powerpaste_html_import": "prompt", "relative_urls": false, "branding": false, "language": "en", "spellchecker_languages": "Afrikaans=af,Arabic / Algerian Arabic=ar,Asturian=as,Azerbaijani=az,Bulgarian=bg,Belarusian=be,Bengali=bn,Breton=br,Bosnian=bs,Catalan=ca,Czech=cs,Welsh=cy,Danish=da,German=de,Lower Sorbian=ds,Greek=el,+English / Australian English / British English=en,Esperanto=eo,Spanish / Argentinian Spanish / Colombian Spanish / Mexican Spanish / Nicaraguan Spanish / Venezuelan Spanish=es,Estonian=et,Basque=eu,Persian=fa,Finnish=fi,French=fr,Frisian=fy,Irish=ga,Scottish Gaelic=gd,Galician=gl,Hebrew=he,Hindi=hi,Croatian=hr,Upper Sorbian=hs,Hungarian=hu,Armenian=hy,Interlingua=ia,Indonesian=id,Igbo=ig,Ido=io,Icelandic=is,Italian=it,Japanese=ja,Georgian / Kabyle=ka,Kazakh=kk,Khmer=km,Kannada=kn,Korean=ko,Kyrgyz=ky,Luxembourgish=lb,Lithuanian=lt,Latvian=lv,Macedonian=mk,Malayalam=ml,Mongolian=mn,Marathi=mr,Burmese=my,Norwegian Bokm\u00e5l=nb,Nepali=ne,Dutch=nl,Norwegian Nynorsk=nn,Ossetic=os,Punjabi=pa,Polish=pl,Portuguese / Brazilian Portuguese=pt,Romanian=ro,Russian=ru,Slovak=sk,Slovenian=sl,Albanian=sq,Serbian / Serbian Latin=sr,Swedish=sv,Swahili=sw,Tamil=ta,Telugu=te,Tajik=tg,Thai=th,Turkmen=tk,Turkish=tr,Tatar=tt,Udmurt=ud,Ukrainian=uk,Urdu=ur,Uzbek=uz,Vietnamese=vi,Simplified Chinese / Traditional Chinese=zh", "directionality": "ltr", "mode": "exact", "strict_loading_mode": 1, "elements": "id_body"}" id="id_body" name="body" rows="10">

... Because the embedded video is intended for our internal Accounting personnel rather than for the public, I’m removing the textarea content ...
                        </textarea>

From: Claude Paroz @.>
Reply-To: jazzband/django-tinymce @.>
Date: Tuesday, March 14, 2023 at 1:21 PM
To: jazzband/django-tinymce @.>
Cc: Jim Phares @.>, Author @.***>
Subject: Re: [jazzband/django-tinymce] Will this library support TinyMCE 6, and if so, is there an expected release date. (Issue #426)
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
It will support TinyMCE 6 when someone writes the missing bits 😄
Did you test with the latest 3.5 release or with the code in master?
—
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjazzband%2Fdjango-tinymce%2Fissues%2F426%23issuecomment-1468516789&data=05|01|jim.phares%40pcusa.org|9564c6b4bae1466a83f108db24b0925d|99082a1a70af459fa6ac8ad01476a157|0|0|638144113037023072|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=oMxub52hTvwozq4m22vS309WyNZPp0x5rZPDa%2B9Y6l8%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAACVSEFXSWIAIY6PJRU4GQLW4CSKFANCNFSM6AAAAAAV2UDAEQ&data=05|01|jim.phares%40pcusa.org|9564c6b4bae1466a83f108db24b0925d|99082a1a70af459fa6ac8ad01476a157|0|0|638144113037023072|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=pJ2la1yriSvl13Ru9rhPM1Y5wPr8uNxQYL8BFFOWDYw%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

I’m sorry for not responding to yesterday’s email earlier; I didn’t see it until I saw this one.
I’m unsure what you’re asking here, but is your bundle question about using a self-hosted TinyMCE implementation?
If it is, that isn’t what we’re doing.  We’re using the Tiny Cloud subscription implementation because we wanted premium features, most importantly spell checking.
From: Ryan Sevelj @.>
Reply-To: jazzband/django-tinymce @.>
Date: Wednesday, March 15, 2023 at 12:03 PM
To: jazzband/django-tinymce @.>
Cc: Jim Phares @.>, Author @.***>
Subject: Re: [jazzband/django-tinymce] Will this library support TinyMCE 6, and if so, is there an expected release date. (Issue #426)
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
Does permission need to be given to bundle the new version? Given the new licence, I would assume not?
I tried replacing with the latest version of tinyMCE with the latest code in the repo and it appears to work out of the box as best as I can tell. I had to tweak a test, to get tox to pass, I only tested against 39 and 310.
—
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjazzband%2Fdjango-tinymce%2Fissues%2F426%23issuecomment-1470313451&data=05|01|jim.phares%40pcusa.org|e7a662fc773040dddf4d08db256ed006|99082a1a70af459fa6ac8ad01476a157|0|0|638144930093537562|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=oRfmJR7jF2ESMj54bdbqk2NoT59DoTW6ooErDMw6L9o%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAACVSECKGUPIY3ZD5MZIZNTW4HR45ANCNFSM6AAAAAAV2UDAEQ&data=05|01|jim.phares%40pcusa.org|e7a662fc773040dddf4d08db256ed006|99082a1a70af459fa6ac8ad01476a157|0|0|638144930093537562|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=q9e9%2BZwharOleiBUGvfEXXZQAatbmZAHodDCkOFiha0%3D&reserved=0.
You are receiving this because you authored the thread.Message ID: @.***>

@pcusa-jim the code in master has changes that are not in the latest release on pip.
Off the top of my head, the two files with changes that got it working for me were the widgets.py and init_tinymce.js. See #417
I am not sure if that will solve your problem, but it is what got version 6 working at my end.
@claudep the new licence is MIT, so I don't think there will be a problem.

Just some additional information for this, the way that images_upload_handler works is different.
See: https://www.tiny.cloud/docs/tinymce/6/image/#images_upload_handler
In the new example code, example_image_upload_handler is declared as a const, so is not a property of the window object.
See for more info: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/const#description
I am fairly new to coding and have virtually no JS experience, so I do no know how to rewrite this to make it work. I have played around with putting the example code into init_tinymce.js and modifying to suit, which works, but isn't easily user changeable, so not a good solution. I have spent all day trying to find a nice solution, but it is beyond my skill levels currently.

It probably shouldn’t have taken me this long to figure out how to do what you suggested, but we typically install our libraries from pypi rather than github, and as I understand it pypi only has releases, so I didn’t know how to install master.
Today, I was able to get back onto this issue and found this reference to master’s commit:
https://github.com/jazzband/django-tinymce/commit/fe9d1e09e0bbca1d43e0e1f5ac03acdaacc37cf3
That provided me with the commit, so I went onto the server, source activated the site’s  environment and ran:
pip install -U @.***
Then I touched our project’s uwsgi.ini using a deploy script (that’s standard to our sites) to restart the site.  At that point, the site’s admin tinyMCE widget worked with tinyMCE 6.
Thanks much,
Jim Phares
From: Ryan Sevelj @.>
Reply-To: jazzband/django-tinymce @.>
Date: Wednesday, March 15, 2023 at 2:12 PM
To: jazzband/django-tinymce @.>
Cc: Jim Phares @.>, Mention @.***>
Subject: Re: [jazzband/django-tinymce] Will this library support TinyMCE 6, and if so, is there an expected release date. (Issue #426)
You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@pcusa-jimhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpcusa-jim&data=05|01|jim.phares%40pcusa.org|2c233ed888814cb48ab108db2580dda0|99082a1a70af459fa6ac8ad01476a157|0|0|638145007654275693|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=7jxWcXURsQKBubZd1YXzMav3aK%2BcKhm4qOTQ%2FzZmWUc%3D&reserved=0 the code in master has changes that are not in the latest release on pip.
Off the top of my head, the two files with changes that got it working for me were the widgets.py and init_tinymce.js. See #417https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjazzband%2Fdjango-tinymce%2Fissues%2F417&data=05|01|jim.phares%40pcusa.org|2c233ed888814cb48ab108db2580dda0|99082a1a70af459fa6ac8ad01476a157|0|0|638145007654275693|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=S3uDaxToiiHJWn4I%2B9uo8w51KJ4EOffoW6pw8%2FK2hz4%3D&reserved=0
I am not sure if that will solve your problem, but it is what got version 6 working at my end.
@claudephttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fclaudep&data=05|01|jim.phares%40pcusa.org|2c233ed888814cb48ab108db2580dda0|99082a1a70af459fa6ac8ad01476a157|0|0|638145007654275693|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qJy54gI4BvthiIRfdg%2F6lqGdCdOPKRkRZoUsxyGCskU%3D&reserved=0 the new licence is MIT, so I don't think there will be a problem.
—
Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjazzband%2Fdjango-tinymce%2Fissues%2F426%23issuecomment-1470524126&data=05|01|jim.phares%40pcusa.org|2c233ed888814cb48ab108db2580dda0|99082a1a70af459fa6ac8ad01476a157|0|0|638145007654275693|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=qoeeAMU93AQDkVv3T64on4XlSXoVWT2ORoU56IKCG8Y%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAACVSEFAEMKEOAUMUHJPBMDW4IBBRANCNFSM6AAAAAAV2UDAEQ&data=05|01|jim.phares%40pcusa.org|2c233ed888814cb48ab108db2580dda0|99082a1a70af459fa6ac8ad01476a157|0|0|638145007654431923|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=lxix0OdNx46UuCzDlLmIW%2FkCZ13BBedjsgBy03SllBY%3D&reserved=0.
You are receiving this because you were mentioned.Message ID: @.***>

Install the latest version of TinyMCE 6 using your preferred method (e.g. via CDN or by downloading the files).

Replace the existing TinyMCE files in your Django-tinymce installation with the new TinyMCE 6 files.

In your Django settings file, update the TINYMCE_DEFAULT_CONFIG to use the new version of TinyMCE:

TINYMCE_DEFAULT_CONFIG = {
    # ... other options ...
    'tinymce_version': '6',
    'external_plugins': {
        'tiny_mce_wiris': '/static/tinymce/plugins/tiny_mce_wiris/plugin.min.js',
        # ... other external plugins ...
    },
    'toolbar': 'undo redo | formatselect | bold italic underline | alignleft aligncenter alignright alignjustify | bullist numlist outdent indent | link image | tiny_mce_wiris_formulaEditor tiny_mce_wiris_formulaEditorChemistry',
    # ... other options ...
}

In this example, we're setting the tinymce_version option to '6' to indicate that we're using TinyMCE 6. We're also updating the external_plugins option to use the new plugin file for the Wiris Math and Chemistry plugins, and updating the toolbar option to use the new toolbar button names and ordering.
Note that depending on your specific use case, you may need to make additional changes to your TinyMCE configuration to fully support TinyMCE 6.
Download the latest version of TinyMCE 6 from the TinyMCE website (https://www.tiny.cloud/get-tiny/self-hosted/).
Extract the contents of the downloaded package and update the relevant paths in your Django project.
In your Django settings file, update the TINYMCE_JS_URL setting to point to the new tinymce.min.js file:
TINYMCE_JS_URL = STATIC_URL + 'path/to/tinymce/tinymce.min.js'
(OPTIONAL) If you were using the mobile theme in your previous setup, make sure to copy the mobile folder from the previous TinyMCE version to the new TinyMCE 6 folder.
(OPTIONAL) If you were using plugins in your previous setup (e.g. django-tinymce-filebrowser), you may need to update

Unfortunate, I wish the folks at TinyMCE would take on this project officially. This integration is nice but I can't justify starting a project using it. Guess I'll just use the zip...

That’s not entirely fair; the custom model field makes it very easy to get a rich text editor for specific fields, without needing to define custom form or formfield_overrides everywhere.

@rsevs3 Can you share with us all the steps and where in the code you made changes so far? One of us here might be able to help you.
We need to somehow modify the following line in init_tinymce.js to fix this issue's original error:
const el = document.getElementById(field_info['id_body']);
Replace it with:
const el = document.getElementById(field_info['id']);

Maybe something like this but not entirely sure.
(function () {
    'use strict';

    function initTinyMCE(selector) {
        if (typeof selector === 'undefined') {
            selector = 'textarea.tinymce';
        }

        if (typeof tinyMCE === 'undefined') {
            return;
        }

        var elements = document.querySelectorAll(selector);

        elements.forEach(function (element) {
            var config = JSON.parse(element.getAttribute('data-config'));
            if (config) {
                if (config.selector) {
                    console.warn('Overriding the selector in the TinyMCE config is not supported.');
                } else {
                    config.selector = '#' + element.id;
                }

                if (config.external_plugins) {
                    for (var key in config.external_plugins) {
                        if (config.external_plugins.hasOwnProperty(key)) {
                            var url = config.external_plugins[key];
                            tinyMCE.PluginManager.load(key, url);
                        }
                    }
                }

                // Initialize TinyMCE 6
                tinymce.init(config);
            }
        });
    }

    // Initialize TinyMCE on DOMContentLoaded
    document.addEventListener('DOMContentLoaded', function () {
        initTinyMCE();
    });

    // Initialize TinyMCE on elements added to the DOM after DOMContentLoaded
    var observer = new MutationObserver(function (mutations) {
        mutations.forEach(function (mutation) {
            if (mutation.addedNodes.length) {
                for (var i = 0; i < mutation.addedNodes.length; i++) {
                    var node = mutation.addedNodes[i];
                    if (node.nodeType === Node.ELEMENT_NODE && node.matches('textarea.tinymce')) {
                        initTinyMCE('#' + node.id);
                    }
                }
            }
        });
    });

    observer.observe(document.body, { childList: true, subtree: true });

})();

Oh, would be great to document the license issue.

What do you mean by this? TinyMCE before version 6 uses LGPL-2.1, although it is not really clear whether this means LGPL-2.1-only or LGPL-2.1-or-later from the file headers (assuming that it would be LGPL-2.1-only as not stated otherwise): https://github.com/jazzband/django-tinymce/blob/775618637ab7708394f057f49b54202c4bac2133/tinymce/static/tinymce/jquery.tinymce.min.js#L2-L5 Version 6 has been re-licensed to now use the MIT license, see https://github.com/tinymce/tinymce/pull/7647 and https://github.com/tinymce/tinymce/commit/236891ffcdf2fd1b698d020e67c31838fb110019.

Thanks for this clarification. Now looks like all is left is someone biting the bullet and suggest a patch with the latest TinyMCE 6 code.

PR #457 implements the migration to TinyMCE 6. Any test/review would be greatly appreciated!

PR #457 implements the migration to TinyMCE 6. Any test/review would be greatly appreciated!

Seems to be working great as far as I can see. Great work!

Thanks for checking :heart:
I'll let the PR open some more days for further reviews.

Fixed by f04e1c8

So we are waiting for a new release that uses tiny mce 6?

Yes, that's it. I hope that we may get some feedback from people using the master branch.


Handle movie collections

Movie trilogies/collections often have releases containing all the movies. They tend to have the word 'collection' or similar at the end of the title, and have a year range. Examples:

The Maze Runner Collection - Sci-Fi 2014-2018 Eng Fre Ita Multi-Subs 1080p [H264-mp4]
Harry.Potter.Complete.Collection.2001-2011.1080p.BluRay.x264.DTS-ETRG
Scary Movie Collection 1-5 2000-2013 720p BluRay x264 Mkvking
Harry Potter All Movies Collection (2001-2011) 720p Dual Audio Bluray [Hindi-English] - KartiKing
Alien Movie Collection - 9 Films DC SE Unrated 1979-2017 Eng Subs 720p [H264-mp4]
American Pie Collection 1999-2012 (8 Films) Unrated 720p H264 BONE
The Hunger Games 4 Film Complete Collection 1080p BluRay 5.1Ch x265 HEVC SUJAIDR
The Terminator 5 Movie Collection - EX RM DC 1984-2015 Eng Subs 720p [H264-mp4]
xXx Trilogy (2002 to 2017)[720p - BDRip's - [Tamil + Telugu + Hindi + Eng] - x264 - 3.4GB - ESubs]
Spider-Man Trilogy (2002-2007) 720p BrRip x264 - 2GB - YIFY
Austin Powers 1-3 Trilogy 1997-2002 BluRay 720p x264 ac3 jbr 1

Without a year range, it might be difficult to know whether it is a collection (the word could just be in the title). Maybe we first look for an indicator it is a collection ("collection", "trilogy"), then find a confirmation (either a year range, or a description of the collection e.g. "4 Film", "1-3", etc.). This might miss some, but we don't want to mess normal titles up. Maybe this could be specified as a type to the parse() function itself, implementing #1, so not messing up non-specified searches.
This would add a boolean field collection, and a way to list what that collection has - collectionContents? Which would be an integer list most likely - the Harry Potter examples above just say "Complete"/"All Movies" but if that isn't there, it's implied it means all of them (like the Maze Runner example), so it'd just be a true for collection and no collectionContents. This field seems like a pretty niche thing to actually have to use anyway - the boolean should be enough when you know you're looking for a collection.
Not sure how to handle the year range. Currently the last year found would be year, so in the first example, this would be 2018. Could add a collectionStart field? Maybe duplicate year into a collectionEnd field for completeness, still leaving year in?

More examples:

Sushant Singh Rajput All Movie Collection 720p Proper HDRip x264 ESub DD-5.1 - Shadow (BonsaiHD)
Godzilla 1, 2, 3, The Hollywood films - 1998-2019 Eng Rus Multi-Subs 720p [H264-mp4]
Starship Troopers 5 Movie Collection - Sci-Fi 1997-2017 Eng Subs 1080p [H264-mp4]

More examples:

The.Santa.Clause.1994-2006.Trilogy.1-3.720P.H265-Zero00
Planet.of.the.Apes.Collection.2001-2017.1080p.Fra.Eng


BUG? : ExchangedDocument / Name not supported?!

I got the following error:
schema validation fails:org.xml.sax.SAXParseException; lineNumber: 10; columnNumber: 15; cvc-complex-type.2.4.a: Invalid content was found starting with element '{"urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:100":Name}'. One of '{"urn:un:unece:uncefact:data:standard:ReusableAggregateBusinessInformationEntity:100":TypeCode}' is expected.
But ExchangedDocument  support ID, Name, TypeCode and IssueDateTime!
zugferd_2p1_BASIC_Einfach-factur-x_Result.zip

I found my error.
This is only in expand allowed :(


How to run benchmark

Hi,
First of all, thanks a lot for porting this to TensorFlow. I was wondering if you could please provide more instructions on how to run the benchmark tests. What do I do after downloading your code here?
Thanks!

Worked like a charm. Thanks!

Hi,
Thanks for your interest. I have added detailed instructions for benchmark evaluation in the Benchmark section within README. For most of the time, simply copy and paste the commands there should be OK.

i wonder if i can resuse this benchmark for another trcker , like MDNet which is trained by tensorflow ,if that is possible what should i do to change this benchmark?because i follow the step of the readme as the SiamFC-Tensorflow which you write and i got error like this'list out of the range ',and i can evaluate the SiamFC successfully,so if you have any idea about this problem please let me know and i will appreciate  it so much. thanks a lot


OlMfpHandler: fix fill page extent value properly [Ticket#45104839]

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 99.648%

Files with Coverage Reduction
New Missed Lines
%

src/modules/olMap/handler/measure/OlMeasurementHandler.js
1
96.89%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
12512

Relevant Lines:
12514

💛  - Coveralls


Can I use this addon today?

I am currently using https://github.com/intuitivepixel/ember-cli-ember-table for ember-cli.
I am wondering whether I can use this addon today. Or this project is work in progress?

It's a work in progress; technically I think the master branch will work, but I'd wait a little longer if I were you.

Thanks


TNT-32924 - adding Target VEC appendHtml action support

Adding Target VEC appendHtml action support
Description
Adding Target VEC appendHtml action support
Related Issue
NONE
Motivation and Context
In Target VEC there is a way to append some HTML content as a last element of another HTML element identified by selector.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All tests pass and I've made any necessary test changes.
[x] I have run the Sandbox successfully.

@jfkhoury I agree. I think @artur-ciocanu plans on doing some of that later.

@jfkhoury as discussed I'll add a separate PR to clean up all the code repetitions.


What is the way to spider using an input file?

Hello @byt3bl33d3r ,
Steps to reproduce
I am scripting cme (v4.0) to cycle through a network, collect hosts and shares.

I am trying to then spider these shares based on a list file, but cannot find documentation/or examples, my tests don't work for now.

same for spidering contents based on a list of multiple entries: (pass, pwd, usr, etc.)

Command string used
cme smb <IP_ADDRESS> -u 'xx' -p 'xx' --spider Users --pattern (pattern1,pattern2,etc.) --depth 1
same for spidering contents based on a list of multiple entries: (pass, pwd, usr, etc.)
CME verbose output (using the --verbose flag)
CME Version (cme --version)
4.0.1dev - Bug Pr0n
OS
Kali
Target OS
Win 7-10
Detailed issue explanation
I am scripting cme (v4.0) to cycle through a network, collect hosts and shares.

I am trying to then spider these shares based on a list file, but cannot find documentation/or examples, my tests don't work for now.

same for spidering contents based on a list of multiple entries: (pass, pwd, usr, etc.)

Can you advise how this is used? (if it is supported)

yes u can with the command --get-file password.txt


breaks on Storybook 5.0

Current Storybook version: 5.0.1
Curent storybook-state version: 1.5.2
Issues:
After upgrading to storybook 5 there are several issues.
react-keys-error
StatePanel does not apply key prop in children and therefore a react-keys error thrown:
vendors~main.dece1ba2959ef3cd23e2.bundle.js:130734 Warning: Each child in a list should have a unique "key" prop.

Check the top-level render call using <Styled(div)>. See https://fb.me/react-warning-keys for more information.
    in StatePanel
    in Unknown
    in Unknown
    in Unknown
    in Unknown (created by Context.Consumer)
    in _default (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Panel)
    in Panel (created by Layout)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in div (created by Context.Consumer)
    in Styled(div) (created by Main)
    in Main (created by Layout)
    in Layout (created by Context.Consumer)
    in WithTheme(Layout) (created by ResizeDetector)
    in ResizeDetector
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by ResizeDetector)
    in ResizeDetector
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root

performance Issue
When state contains a larger value object, like a simple google place query, the story becomes very laggy.

Should be resolved in v1.6.0


Rework inline comments in camera connect module

Refers to #317
The inline comments of the camera connect module are partly inaccurate and outdated. This should be fixed to improve comprehensibility of the code.

Done.


BREAKING: change join/close api surface. add closeFeed & deprecate to…

change join/close api surface
add closeFeed
deprecate totalConnections and rejoin
fixes #23 and #27

this will be a major bump

I think we should keep our discovery key assumption, and I guess there's nothing actionable to do for the try catch.
I think this is good to go if it's working

this is stale, perhaps we should close it and move on forward with upgrading to hyperswarm which would be a major bump? @sammacbeth @RangerMauve @davidmarkclements

With dat2 a lot of networking and stuff is based on corestore, so I'm wondering whether hyperdiscovery would even be necessary. 🤔🤔🤔


Could you provide the text description file?

Thank you for your excellent work. Could you provide the text description file?

Thank you for your excellent work. Could you provide the text description file?

Hi, thank you for your attention to our work. We have been busy with new projects recently, so the update speed is relatively slow. We will upload the text description as soon as possible.


Let us define our own preserveAspectRatio for SVGs

I'm submitting a...
Feature Request
Current behavior
The preserveAspectRatio attribute of all SVGs are always overriden to be xMidYMid meet in registry.ts#L45
Expected behavior/Proposed solution
An input on the component to set this attribute would be nice. It could also default to that value this library sets it to so there's no breaking changes.
Minimal reproduction of the problem with instructions
Generate an SVG with a preserveAspectRatio value that is not xMidYMid meet and it will always be set to xMidYMid meet
What is the motivation / use case for changing the behavior?
I'd like to output an SVG with a custom preserveAspectRatio to render it/align it differently but cannot

You're welcome to create a PR

Added in v5


[Bug Report] Tabs: nav button "is-disabled" class state is incorrect when tabs can scorll

Element UI version
2.14.1
OS/Browsers version
windows/chrome
Vue version
2.6.10
Reproduction Link
https://codepen.io/privatenine/pen/poExOQR
Steps to reproduce
when click nav until nav is disabled, but "is-disabled" class is not suit with state
What is Expected?
when click nav until nav is disabled, "is-disabled" class is correct
What is actually happening?
when click nav until nav is disabled, "is-disabled" class is incorrect

i have the same problem


chore(extension): add manifest public key

Proposed solution
Add Lace's public key for chromium development to allow external developers to develop lace without hitting CORs issues due to generating a random hash of updated files
Testing

With the official Lace build installed, in the console run chrome.runtime.getManifest().key
Build Lace from this repository, remove the currently installed official Lace build and load the unpacked extension and run the same command in the console

Assert both return the same key

Allure report
allure-report-publisher generated test report!

smokeTests: ❌ test report for fb5370a0

passed
failed
skipped
flaky
total
result

Total
34
1
0
0
35
❌

@mattgonewild this is the update your are looking for

Seems to work, thanks.


Support remote git repo for Terraform configuration

Besides inline HCL Configuration, supprted remote git repo Configuration

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

Does it support specifying directory in the remote git repo?

Does it support specifying directory in the remote git repo?

Currently no. Planning to support this feature, besides with private git repo, in a later release.


[backport] bug-report tool in osm cli

Description:
Backports ea27b738 for release v0.9.2 to be able to generate bug reports.

Affected area:

Functional Area

Other
[X]

Testing done:
$ osm support bug-report --app-namespaces bookbuyer,bookstore --app-deployments bookbuyer/bookbuyer,bookstore/bookstore
[+] Created staging dir /tmp/osm_bug_report_390083083 to generate bug report

[+] Collecting information about meshed namespaces
✓ Finished generating report for meshed namespaces

[+] Collecting information from individual app namespaces
✓ Collected report from Namespace "bookbuyer"
✓ Collected report from Namespace "bookstore"
✓ Finished generating report for individual app namespaces

[+] Collecting information from individual app namespaces
✓ Collected report for Pod "bookbuyer/bookbuyer-6c7f6d5cbd-jn7xg"
✓ Collected report for Pod "bookstore/bookstore-56d8cbd8ff-f6jxx"
✓ Finished generating report for individual app pods

[+] Collecting information from individual app namespaces
✓ Bug report successfully archived to /tmp/700294638_osm-bug-report.zip

Please answer the following questions with yes/no.

Does this change contain code from or inspired by another project? no

Did you notify the maintainers and provide attribution?

Is this a breaking change? no

Codecov Report

Merging #3983 (3d89eec) into release-v0.9 (8e8c692) will decrease coverage by 0.39%.
The diff coverage is 10.52%.

@@               Coverage Diff                @@
##           release-v0.9    #3983      +/-   ##
================================================
- Coverage         66.94%   66.54%   -0.40%
================================================
  Files               169      171       +2
  Lines              9155     9219      +64
================================================
+ Hits               6129     6135       +6
- Misses             2993     3051      +58
  Partials             33       33

Flag
Coverage Δ

unittests
66.54% <10.52%> (-0.40%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/cli/osm.go
0.00% <0.00%> (ø)

cmd/cli/support.go
0.00% <0.00%> (ø)

cmd/cli/support_bugreport.go
0.00% <0.00%> (ø)

pkg/kubernetes/util.go
96.22% <100.00%> (+0.67%)
:arrow_up:

pkg/kubernetes/announcement_handlers.go
72.97% <0.00%> (-5.41%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e8c692...3d89eec. Read the comment docs.


feat(dataframe): support output to a single CSV file

The method allows save a dask data frame to a single CSV file, which
works well with other data processing tools and libraries.
Since specifying a full path to the existing to_csv method leads to
the creation of a folder of the given name, this behaviour cannot be
implemented within the existing to_csv method without breaking its
existing behaviour. Thus, a new method is provided instead.

[x] Tests added / passed
[x] Passes black dask / flake8 dask

Closes https://github.com/dask/distributed/issues/2982

Dose df.compute().to_csv("path/to/csv") work instead?

@TomAugspurger This is for the data that do not fit into the memory. I believe we should not always use .compute() for those cases. This new method provides a way to write the results out in a way that other libraries might be able to read without post-processing or other magics. One case is to compile a huge CSV file for LightGBM to do two-round loading or XGBoost to do out-of-core training.

@mrocklin I have added a second commit to merge to_csv and to_single_csv as you proposed. The implementation is not necessarily cleaner, but API seems neater.
My understanding is that dask.dataframe.DataFrame.to_csv already behaves differently from pandas.DataFrame.to_csv. Therefore I expect that if we are to use the keyword argument, single_file will be False by default.

I'd prefer to add a single_file= parameter to df.to_csv instead of a new df.to_single_csv method. As @hongzmsft mentioned, we already have Dask-specific keyword arguments in df.to_csv (e.g. compute, name_function, scheduler, etc.)

It looks like tests are passing, but there are some code formatting issues causing the CI to fail. @hongzmsft running flake8 and black locally should fix this (https://docs.dask.org/en/latest/develop.html#code-formatting)

@jrbourbeau Fixed.

@mrocklin Thank you for your review. Let me know of any other critiques.

@TomAugspurger Fixed. Thanks.

@TomAugspurger Fixed. Thanks.

@TomAugspurger Sorry, I was clearly not in my top form. Fixed. Thanks.

Thanks!


Revert the order of error backtrace display

This follows the change in CRuby-3.0.

Could you tell me the reason behind this change? I did the current way to print the error messages last (Python way).
I believe this is better. And I once tried to change the CRuby behavior but we had a compatibility issue.

There is no reason other than that it is the way it is in CRuby.
I think it's more likely to be compared to CRuby than Python.
Personally, I prefer the current behavior of CRuby.
However, I don't have a strong reason, so I'm withdrawing the proposal.

Thank you


lib.d.ts contains wrong typings for Number.isFinite()

I'm not sure whether this is the repo to be putting this issue on, please let me know if it isn't.
TypeScript Version:  2.2.2
Code
Compiling with strict null checks:
 Number.isFinite(undefined);

Expected behavior:
No compile error. The argument to isFinite should be any, because the function is used to check the type. According to the spec at https://www.ecma-international.org/ecma-262/6.0/#sec-number.isfinite   the type is checked by the function.
Actual behavior:
error TS2345: Argument of type 'undefined' is not assignable to parameter of type 'number'

Duplicate of https://github.com/Microsoft/TypeScript/issues/4002

@mhegazy this is NOT a duplicate of #4002.  That story is about the isFinite() function and not about Number.isFinite().   The spec for Number.isFinite() is different and the arguments brought forward in #4002 do not apply here.  I still think I have a valid proposal.

Yes, I think Number.isFinite() is intended to be used like Array.isArray, i.e. it is a guard for numbers, not a function that coerces its arguments to number prior to operation.
In this context the right signature for Number.isFinite is:
isFinite(arg: any): arg is number;

In my opinion, Number.isInteger and Number.isSafeInteger should not be changed, because TS doesn't distinguish between integers and numbers yet. When integers start having their own type at a later point, it would be a breaking change if the above mentioned functions were made is number guards now.
PS: the global isFinite is coercing and all arguments from #4002 apply to it. However, Number.isFinite is different.
Number.isFinite('123'); // false
isFinite('123'); // true

isFinite(arg: any): arg is number isn't correct because there are some things that are of type number that aren't finite. Type predicates must return true for all values of a type, not just some, to be correct.

@gcnew:  @RyanCavanaugh  is right, the typing should be:
isFinite(arg: any): boolean;

not sure i understand why this issue is different from #4002.

I think the logic should be the reverse. Every value for which isFinite returns true  is definitely a number. But not every number is finite - the only exceptions are NaN, Infinity and -Infinity. It seems rather pedantic not to guard arg as number because it can theoretically be one of the above three constants, which the type system doesn't even consider as literal types.

just to be clear, are we talking about the argument type for Number.isFinite (currently number) or the return type being a user-defined type guard (currently boolean)?
I am assuming this issue is about the earlier.

From my perspective, if Number.isFinite doesn't become a guard for number, there is no reason to change the type of arg to any.

@mhegazy I consider this issue different than #4002, as Number.isFinite should be usable to narrow a value of unknown type to number, the same way Array.isArray asserts that a value is actually an array.

I guess it should should be
Number.isFinite(argument : any) : boolean

@gcnew see #15048 for type guards which don't cover their entire domains
Regarding accepting any, I don't understand why this is desirable. Any non-number is known to produce false from this function. You could say "Well I want to use this to test a number | string" but we can't narrow the input to number because it's not exhaustive (see above again), so it's not a useful function for this purpose (typeof x === "number" would be better).

The reason that it is desirable is the following:
/**
 * @param n  A finite number (optional)
 */
function doSomething(n?: number) {
  if (Number.isFinite(n)) {
   // process user input
  }
}

is less to type and less to execute than
/**
 * @param n  A finite number (optional)
 */
function doSomething(n?: number) {
  if (n !== undefined && Number.isFinite(n)) {
   // process user input
  }
}

And the ECMA spec says I can simply use the first example but the typescript compiler simply won't compile it
I've seen people do all kinds of things like
if (n !== null && n !== undefined && isFinite(n))

and usually they'll forget the null check in a couple of cases.  FINALLY I can give all my team a guideline that will always work without surprises and it's called Number.isFinite().  It just works.  I only need it to compile with strict null checks on.

You could also write Number.isFinite(n!), or n != null, or typeof n === 'number', depending. I'm not sure why you're using isFinite for this case - you really want to act as if the parameter wasn't provided in the cases where it's Infinity or NaN ?

e.g. I'd be really surprised if I wrote doSomething(n / arr.length) without checking for an empty array and that got silently ignored because Infinity isn't isFinite

Ok so maybe I constructed the wrong example but I've also seen a lot of this
if (!Number.isFinite(userInput)) {
  throw new Error("boo");
}

That's a very nice catch-all that checks exactly what you want to check

We also do in this way:
if(userNumber typeOf number) {
    if(!Number isFinite(userNumber)) {
        console.log("Error")
    }
}

Automatically closing this issue for housekeeping purposes. The issue labels indicate that it is unactionable at the moment or has already been addressed.


Close InfoWindow?

Right now the only way to close an InfoWindow on a MapMarker is by clicking the "X" onCloseClick. Is it possible to close one or all windows when the user clicks elsewhere on the map? Is it possible to close one InfoWindow when the user clicks to open a different InfoWindow so only one is open at any given time?
I feel like adding another property to the InfoWindow (similar to the onRightClick for the Marker component) could handle a function for this or is there already a way to do this that I'm missing? Thanks.

You can close it by changing state of the marker, change property showInfo to false. Have look at this example: https://tomchentw.github.io/react-google-maps/events/closure-listeners

Ah, so don't make the InfoWindow in charge of closing itself all the time. Put that on the Map itself to listen when users click the overlay or elsewhere and that triggers the close InfoWindow. Thank you!

Please refer to Getting Help section in the README (or #469).

@mjvalade Another way to handle the InfoWindow inside Marker is to have an onMouseOver and onMouseOut event handler that invokes a function or class method handler. This would be set on the Marker and the InfoWindow using function currying and maybe if you are open to it, lodash's debounce with a timer. Basically what happens is you can persist that InfoWindow if the user hovers over it and or until the hovering over a different Marker. The problem then is how to disable the "x" which the react-google-maps docs do not state, and I have a stack overflow question out right now for:  https://stackoverflow.com/questions/51253596/how-to-remove-infowindow-x-react-google-maps


smartmontools: 7.0 -> 7.1 and devicedb updated to latest

Motivation for this change
https://www.smartmontools.org/browser/tags/RELEASE_7_1/smartmontools/NEWS
Currently, we have 1+ year old devicedb.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This change is

cc @dtzWill @xeji @andir

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixos-20-03-feature-freeze/5655/37

@worldofpeace any objections against including this in 20.03? It seems like a good addition.

I've backported and tested it #81423

Belated :+1:, thanks!


refactor, fix api

refactor
fix clippy
fix docs
remove unused code
fix bytesfield index api

Codecov Report

Merging #1509 (fbc2b8a) into main (4d634d6) will increase coverage by 0.02%.
The diff coverage is 98.75%.

:exclamation: Current head fbc2b8a differs from pull request most recent head 29d5611. Consider uploading reports for the commit 29d5611 to get more accurate results

@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
+ Coverage   93.96%   93.99%   +0.02%
==========================================
  Files         242      243       +1
  Lines       44936    44921      -15
==========================================
- Hits        42226    42222       -4
+ Misses       2710     2699      -11

Impacted Files
Coverage Δ

fastfield_codecs/src/column.rs
76.92% <0.00%> (ø)

fastfield_codecs/src/lib.rs
99.00% <100.00%> (-0.02%)
:arrow_down:

fastfield_codecs/src/monotonic_mapping.rs
100.00% <100.00%> (ø)

fastfield_codecs/src/serialize.rs
84.43% <100.00%> (-1.89%)
:arrow_down:

src/fastfield/bytes/writer.rs
83.56% <100.00%> (-0.23%)
:arrow_down:

src/fastfield/multivalued/writer.rs
100.00% <100.00%> (ø)

src/fastfield/serializer/mod.rs
100.00% <100.00%> (+5.88%)
:arrow_up:

src/indexer/merger.rs
97.57% <100.00%> (+0.41%)
:arrow_up:

src/fastfield/multivalued/mod.rs
97.92% <0.00%> (+0.51%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[git] Add extension api event for when a file is commit

VSCode Version: 1.10.0-insider 50f8848e44029ffabf0727de49cd18ae4069b4fe
OS Version: macOS Sierra 10.12.3 (16D32)

I would love to be able to listen for an event for when the a file in an open editor has been committed. Currently we have api events for when a document changes and is saved, but nothing for when a document is commit.
Specifically this would help out GitLens, to where I could avoid issues where the blame continues to show "Uncommitted changes" because I haven't detected that the file has been committed.

You should listen to file system events on the .git folder because the user might actually commit the file outside of VS Code.

@joaomoreno that is an excellent suggestion! Thanks so much.

@joaomoreno but at the same time. Vscode must already be doing this to update it's tracking. And with more scm's being added an abstract event would seem to me to be very valuable

Code is listening. But it won't tell you that a file has been committed. At best, it can tell you that something has changed. Which is exactly what you can do with FS events.

True, but when there are multiple different SCM providers, it allows an extension to not have to know about the details of each one (and vscode will already need to know).

It won't actually know. The SCM support is more abstract than that, since some SCM systems don't even have the commit concept;.

Sorry, I was conflating things. I just meant a general SCM changed type of event (with optional other details if possible - but would be specific to the SCM)


Crash upon clicking the search button a second time

Grabber crashes after I hit the search button a second time to either search for a new tag or the same tag.
It's becoming increasingly frustrating.

I think I figured it out. The crash only happens when I'm grabbing from pixiv.net


Update Games List.json

Added Game "Tekken Tag Tournament 2" information
Wanna contribute on adding games with pictures and backgrounds? Now you can! Just do a pull request editing the Games List.json file!

"titlename" should have the original name of the game that shows on Xbox, remove any Copyright or Trademark symbols
Images on "titleicon" should be 1024x1024, and "titlebackground" can be any size but choose one that fits on the app correctly
"titleimage" is a Discord parameter, give it any name or the game name, i will edit it after the pull request
"type" (number) is the kind of game or app, Use the following numbers depending of the type of app or game:

(1) For games, it will show "Playing (game)"
(2) For video apps, it will show "Watching (app)"
(3) For another kind of apps, it will show "Using (app)"

Remember, edit the complete code and add your game array, make sure to add
any necessary commas and brackets
I will check the code later, edit it with my titleimage and merge it if everything is ok.
You can delete this text before doing the pull request if you want

The titleicon should be on 1024x1024, lemme see if I can find one, and the titlebackground link doesn't seem to work

The titleicon should be on 1024x1024, lemme see if I can find one, and the titlebackground link doesn't seem to work

Strange... The titlebackground for me works fine, sorry if any error occured

Dont worry, probably it's region blocked