Add Labels to Backend

Checklist

[x] Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
[x] Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
[x] The description lists all applicable issues this PR seeks to resolve
[x] The description lists any configuration setting(s) that differ from the default settings
[x] All tests and CI builds passing

Description
In preparation for adding functionality to add labels to feed sources, this PR adds labels to the server.
Labels exist and are managed like feed sources do with similar API endpoints. Feed sources can include any number of labels. Labels are attached to feed sources via update or creation (with none being the default).
There is a lot of double permission checking, as we need the request object to determine if labels can be accessed. If there is a cleaner/better way to do this please let me know!
Email notifications are disabled for label updates, checked via a convoluted equals method... I hope someone has a better idea here!
Is best used in tandem with https://github.com/ibi-group/datatools-ui/pull/693

Thank you for all your comments! Have touched everything except the FeedSourceController until we figure out the best course of action there.
I agree the serializer isn’t ideal. The idea behind adding labels to feed sources was to both reduce the complexity of the changes needed in datatools-ui, as well as reducing the number of network requests when rendering the dashboard. However, I agree that things could be a bit cleaner.
One option that might be the best of both worlds could be to change the back-end to assign feed sources to labels, but include a custom method in feed sources that goes through all labels and returns those in the feed source? For updating, the front-end could either be re-written to make a separate call to update each label, or a custom serializer could handle this? Curious about your thoughts. To me, the most important aspect is ensuring the number of network requests doesn't increase, but that may be misguided!

Thanks Landon have made these changes, aside from the FeedSourceController stuff.
The serializer does return both admin and non-admin labels, but FeedSourceController filters the label string list before creating any response so only "correct" labels are serialized! Everything going across the network is correct based on permissions. If we went for Label#feedSourceIds, we’d have to do the same on-server filtering, just in the new endpoint/method we use to return labels.

Thanks Landon have made these changes, aside from the FeedSourceController stuff.
The serializer does return both admin and non-admin labels, but FeedSourceController filters the label string list before creating any response so only "correct" labels are serialized! Everything going across the network is correct based on permissions. If we went for Label#feedSourceIds, we’d have to do the same on-server filtering, just in the new endpoint/method we use to return labels.

This PR already adds all of a project's labels to the Project model in the ProjectController#checkProjectPermissions method, so a new endpoint is not needed and all of the project's label data viewable according to admin permissions is already outputted in the ProjectController responses. See example:

Have amended Project#delete
@evansiroky I think I've come around to doing Label#feedSourceId, since we're already doing a second request to get all project info on the dashboard. With a few helper methods the changes to the UI should be minimal as well.
The only issue I foresee is the assigner making a lot of requests as it has to update each label individually (which might overwhelm the server?). Do you have any thoughts on how to do this better?
Also, wouldn't deleting a feed source still require going through all labels? Since there are generally more labels than feed sources, wouldn't this result in more database write operations?

Have amended Project#delete
@evansiroky I think I've come around to doing Label#feedSourceId, since we're already doing a second request to get all project info on the dashboard. With a few helper methods the changes to the UI should be minimal as well.
The only issue I foresee is the assigner making a lot of requests as it has to update each label individually (which might overwhelm the server?). Do you have any thoughts on how to do this better?
Also, wouldn't deleting a feed source still require going through all labels? Since there are generally more labels than feed sources, wouldn't this result in more database write operations?

I chatted with Miles about these items. The potential for making multiple requests when adding multiple labels to a feed source at once is going to be something that would involve making more http requests. Also, deleting a feed source would involve doing multiple updates in multiple label records. One other option we haven't considered yet is FeedSource#labelIds without LabelSerializer as opposed to FeedSource#labels with LabelSerializer. That route would have the advantage of not having to make any database requests to return Label objects within each feed source. I have gone ahead and made this comparison table with each of these options and tried to quantify how many HTTP vs database requests would happen in each:

Type of request
FeedSource#labels (with LabelSerializer)
FeedSource#labelIds (no LabelSerializer)
Label#feedSourceIds

Http Requests
Database Requests
Http Requests
Database Requests
Http Requests
Database Requests

Get project
1
1
1
1
1
1

Delete project
1
# of labels in project
1
# of labels in project
1
# of labels in project

Get feed source
1
# of feed sources X # of labels on each feed source
1
0 (labels received from Project)
1
0 (labels received from Project)

Update labels for feed source
1
1
1
1
# of labels to be updated
# of labels to be updated

Delete feed source
1
0
1
0
1
fetch all labels + # of labels associated with feed source

Delete label
1
fetch all project feed sources + # of feed sources with label
1
fetch all project feed sources + # of feed sources with label
1
1

As can be seen, the Label#feedSourceIds wins if we expect both 1) that users will typically only add one label at a time to a feed source and 2) that deleting a feed source is rarer than deleting a label. Otherwise, FeedSource#labelIds without LabelSerializer wins.

Have now implemented the FeedSource#labelIds (no LabelSerializer) approach. I think it is the best of both worlds... If this gets the all clear I'll add some tests for all this, although I've been struggling to see how to examine the contents of an HTTP response made with TestUtils.makeRequest()?

Thanks Rob for the feedback, it's addressed.
I've also added some basic tests. I'd like to expand them (to check easily-breakable admin only stuff), but can't figure TestUtils or HTTPUtils out enough to check HTTP response bodies.

Following the new PR policy, have unassigned @landonreed and @evansiroky until @br648's review is in

I don't want upgrading HttpUtils to match otp-middleware to be part of this PR, so have removed those tests from here. They'll be moved to datatools-ui if they're implemented. Have cleaned up here for now.

Thanks @br648! Have got that all sorted. Up next is @evansiroky

Thanks for these, have addressed all or left comments.

Thanks have made adjustments. For the feedSourceController validation, I think I managed to reduce database queries quite a lot, is that what you had in mind?

Good catch and good suggestion thank you!


[Feature] I saw a support of ZED 2i on Foxy, Could you make it available for Eloquent as well?

I saw a support of ZED 2i on Foxy, Could you make it available for Eloquent as well?

The Eloquent branch should support the ZED2i. Are you facing issues with it?

I could not find the launch file on the branch.

i moved to foxy.


fix typo

The title says it all.

@JohnTitor Could you review?

Looks good but I don't have access on the repo so r? @phil-opp

Looks good, thanks!


71

71 - Added text to Vetical Perspective

This ticket has already been done by Richard Hattersley, c.f. comment 4.  The change here, to appf.doc, is to replace "PROJ.4" with "proj.4" (also two lines are merged into one, but that has no effect after processing by ASCIIDOC).
The lower-case name is indeed used in the ticket.  But the official web site, proj4.org, uses it both ways - e.g. lower-case in the home page, upper-case in the FAQ page.   So either upper- or lower- case is ok.   Because upper-case is used in the rest of Appendix F, I'd be inclined to leave it as upper-case here too.


[Add2App iOS] Flutter view takes much longer to load on a device for a debug build than before

When launching a Flutter view in an existing app, as of the latest versions of Flutter, it takes about 4-5 extra seconds before anything is actually rendered on the screen, after seeing logs printed from our route widget's build method.
I think this happens with native Flutter apps as well, seeing they just seem very long to launch (longer than before).
But in our case, we have timed about 4-5 seconds of dead time between the logs from our build method and the view actually rendering.
This was never the case before.
I've noticed this with 1.18.0-dev.3.0 and 1.18.0-11.0.pre.

[✓] Flutter (Channel dev, 1.18.0-11.0.pre, on Mac OS X 10.14.6 18G4032, locale en-US)
• Flutter version 1.18.0-11.0.pre at /Users/danny.valente/Library/flutter/1.18.0-11.0.pre-dev
• Framework revision 8568eda15b (2 days ago), 2020-05-05 16:10:41 -0700
• Engine revision 33d2367950
• Dart version 2.9.0 (build 2.9.0-5.0.dev 9c94f08410)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/danny.valente/Library/Android/sdk
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
• All Android licenses accepted.
[!] Xcode - develop for iOS and macOS (Xcode 11.3.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3.1, Build version 11C505
! CocoaPods 1.7.5 out of date (1.8.0 is recommended).
CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
To upgrade:
sudo gem install cocoapods
[✓] Android Studio (version 3.6)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 45.1.1
• Dart plugin version 192.7761
• Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)

Hi @dannyvalentesonos
can you please provide a reproducible minimal sample project.
Thank you

@iapicca I couldn't reproduce with a sample app, so I dug further into this, and it's something I changed in my application that is causing this.
We can go ahead and close this.
Thanks.

Hi @dannyvalentesonos
thank you for letting me know


update Operational FAQs

Fixes #11245.
Also updated and streamlined the rest of the Operational FAQs.

This change is


with statement is deprecated by web standards.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/with
This makes eta no longer useful for long-term projects.

@AimForNaN eta doesn't use with unless you explicitly enable a flag that's turned off by default.

That's something that I would enable, since I'm not a fan of prefixing template vars.


Dynamic occluders crash when using a hard shadow mode with a group-based renderer

Solution is to replace line 413 __BulbAddOcclusionSoft(_dynamicVBuffer); with __BulbAddOcclusionHard(...)

https://github.com/JujuAdams/Bulb/commit/dd665cda9936a5f8ea61ab824055e53bad107a62


Can't use it with local file:// protocol

I would like to use Pizzicato with local files, like with Howler.

I read some articles and it seems not to be possible because JavaScript cannot go outside the sandbox.

Pizzicato uses AJAX requests to fetch the audio files. If you want to use local files you'll need to start a local server.
If you have Python installed, you can just open the Terminal, go to the folder where you have your html file and audio files, and type python -m SimpleHTTPServer. You'll have a server up and running in no time.


Drone hides extra characters in a build log

Duplicate a thread from forum
I use multiple secret credentials in my job. Drone used to hide the secrets in a job log properly.
I’ve just added 3 more secrets to a drone config and now Drone hides too much information (screenshots attached).

I’ve already tested it.

yes, this is by design.  If you try to print a secret value to the logs it is masked.  If you do not want a value to be masked it should not be stored as a secret.  If you have any further questions, please start a thread in our end-user support forum at discourse.drone.io.


feat(css injection): injects animated.css into the html file for testing

with the help of gulp-inject we can inject the css in the html file. unfortunately it doesn't work
with the pug extension
fixes #50


ISPN-13816 Allow HotRod client to use normalizers

https://issues.redhat.com/browse/ISPN-13816

Merged, thanks

Thank you!


Add routes, api methods & e2e tests for Glyphs

Mapbox GL maps require fonts rendered to SDFs (Signed-distance field), this makes rendering in GL fast and pretty. We need to support this route:

[ ] GET /fonts/{font}/{start}-{end}.pbf - where {font} can be a comma-separated (URL encoded) list of font names, and we should return the first available (similar to how a CSS font-family property works).

It is possible to render SDFs dynamically (e.g. https://github.com/mapbox/node-fontnik) but I'm wary about introducing another native library in our stack. We can download them from the Mapbox API, but that's not a great solution either.
I suggest that we generate SDFs for common fonts as part of our build process and ship them as static files included in the npm bundle. We can use node-fontnik (or maybe there is a better maintained SDF renderer out there?) for generating these at build time. We would probably need to stick to open fonts that we are able to bundle in the app. We should support some kind of fallback lookup table, so that if we do not have a font that is referenced in the {font} part of the URL, then we fall back to the closest equivalent.
We should also support downloading SDFs / glyphs from the Mapbox API when the user downloads a style that references a font that we do not have pre-rendered.
Maybe as an MVP, we proxy / download Mapbox rendered SDFs directly from their API. We should store these in a way that they can be shared across different styles, e.g. if we use the SWR cache then we should normalize the URL to reduce the {font} part to a single font name.

Additional technical notes:

when creating the style:

need to traverse the style to find all the fonts that are being used (see https://github.com/digidem/mapbox-style-downloader/blob/master/lib/glyphs.js#L21-L53 for approximate example)
take the first first font name from the font stack and use it for creating the upstream url. based on testing, requesting glyphs using font names that don't exist causes the request to 404, as opposed to falling back

for initial version, maybe dont reference db table and just bundle a couple of open standard sdf fonts (one serif and one sans-serif) and then serve as static files
need an endpoint that is aware of common fonts and determine/guess whether to serve serif or sans-serif

@gmaclennan can you share thoughts on what you think would be reasonable for the first iteration of this feature? Are we strictly going to serve static files from pre-bundled sdfs or do we still want to handle getting upstream glyphs when online? (note we don't currently have anything that helps us determine online connectivity). if we get upstream glyphs, do we want to store them? (if so, in the db or as a static file?)

rereading the original description, maybe we can just focus supporting two things to start:

Serve prebundled glyphs as static files
Proxying requested glyphs from mapbox but NOT storing them.

We'd do 1 in the case of offline, and 2 in the case of online

Yes, that sounds like a reasonable approach.


Web: Autosave is slow, manual broken

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: vscode.dev
OS Version: Windows 11 with WSL

Steps to Reproduce:

Disable the slow autosave
Edit a local file in stored in a WSL vm from vscode.dev running in Edge
Press Control + S or save.

The changed icon on the filename titlebar should change to unchanged... but it stays in "changed" status. When you try to close the file you'll get a complaint that the file hasn't been saved, when it has.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.67.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

I did not know we support WSL via vscode.dev, maybe a setup problem?

I did not know we support WSL via vscode.dev, maybe a setup problem?

It's a fairly vanilla WSL 2 VM I just started on my new laptop last week. WSL sets up access via a share by default. It looks no different than editing code hosted in a Linux Samba network share / NAS. Regardless, Zone Identifier files should never leave Windows, as they can cause havok when they do, as they are probably a reserved name in Windows.

Looks like this is a known WSL problem: https://github.com/microsoft/WSL/issues/4609#issuecomment-546574922

Marking as dup of https://github.com/microsoft/WSL/issues/4609#issuecomment-546574922


Added missing POSTGRES_USER env variable to local build.

The "make local" was failing with the below error due to the missing POSTGRES_USER env variable.
"no PostgreSQL user name specified in startup packet"
"[TypeOrmModule] Unable to connect to the database. Retrying (4)... +3006ms"

@andrewsignori-aot Please check there is a change package-lock.json file for web package. Is that purposefully or accidental?

@fwpushan, I've just removed the file from this commit.

@andrewsignori-aot Please check there is a change package-lock.json file for web package. Is that purposefully or accidental?

@fwpushan, I've just removed the file from this commit.


doc(assetsRetryPlugin): delete usage limit description on dynamic import

Summary
update document, delete usage limit description on dynamic import
Related Links
#91

Checklist

[ ] Tests updated.
[x] Documentation updated.

❤

thank you! looking forward to help more!


[docs] Fix volume binding in fluentd container example

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "patch-1" git@github.com:sw-double/docker.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

LGTM 🐶

LGTM @thaJeztah @sfsmithcha


Update to go1.19.4

Will update the go.mod files to 1.19 in a separate PR

CI failure seems unrelated

LGTM. I am assuming scanner-build-0.3.56 is using go1.19.4?

yep :) https://github.com/stackrox/rox-ci-image/releases/tag/0.3.56


Does not work out of the box with CakePHP App 3.4.13

I have followed the steps listed, however, I am still getting the default CakePHP App page...
Do I have to copy files into place or anything like that? because it seems like to me, I shouldnt have to copy anything...

I have the same issue. Did you resolve it?

I have the same issue.
After installing this theme with composer, the Gentelella theme ist installed, but the Cake src files are missing. So the example is not working.
Do I have to compare all files manually?
Thanks for your support.

If you delete de Pages/home.ctp theme is displayed


[Documentation request] title/description from ios

Testing with testDPC lets you pull in values from https://github.com/mwaylabs/flutter-managed-configuration/blob/master/example/android/app/src/main/res/xml/app_restrictions.xml
is there an equivalent on ios or mac?
Thanks

I cannot find any documentation besides appconfig.org which seems to be deprecated. It references to deprecated apple dev doc. Quick check on current apple doc, there is not hints that we can configure supported keys like for Android.


add tests for sum of squares in R[Fₙ]

Codecov Report

Merging #7 (ed4787b) into main (3f4e194) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   93.15%   93.15%
=======================================
  Files           8        7    -1
  Lines         263      263
=======================================
  Hits          245      245
  Misses         18       18

Impacted Files
Coverage Δ

src/StarAlgebras.jl

src/types.jl
83.63% <0.00%> (+0.30%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f4e194...ed4787b. Read the comment docs.


Support look-back for nest BMI module input values and bootstrapping of defaults.

Add support for allowing a nested formulation in a BMI multi formulation to use as a provider a later nested formulation.  Previously, only earlier nested formulations could be used like this, where earlier/later is with respect to their listed order in the realization config.  Since a later nested formulation's outputs won't have been (re)calculated yet, this effectively is a look-back to the previous time step.
Also, adding support for configuring a default value for nested formulation outputs, including having it be used as the value during the first time step in the aforementioned look-back scenario.

A couple additional thoughts.  Should the default/init value not found in configuration attempt to use the bmi get_value to query the formulation for a value?
Would we ever want more than a single time step "look back"?

This didn't make AGU/v0.1.0 but I have a feeling it will be wanted for "MVP" to support SoilFreezeThaw along with #343 .

Should the default/init value not found in configuration attempt to use the bmi get_value to query the formulation for a value?

@hellkite500, I'm not sure I understand exactly what you are asking, though it does seem as though perhaps this may not sufficiently handle the case when a default is needed but not provided.  I'll have to double-check that, but I'd like to make sure I understand what you were suggesting before I do.

Would we ever want more than a single time step "look back"?

Possibly, but that has the potential to be a considerably more significant undertaking.  E.g., how far back do we save?  How do we control what is saved beyond one time step?  Where/how is data being saved?  Are we doing anything to ensure we don't exceed storage capacity?
Unless there is something specific that is fairly simple/similar and immediately needed, we should handle expanding this functionality separately.  If there are any particular use cases that we have need for, we'll also need those details.

the intent was for there never be a value less than 1 in the defaultUsageWaits map. If we assume this condition when an object is created, then it should hold throughout, as any values equal to 1 before the decrementing step are instead removed from the map entirely.

@hellkite500, I realized after our discussion last week, as I was working on fixing the "problem" with this, that I been wrong it how I remembered this was supposed to work.   But I think we need to change things anyway.
In short, things were made to support perpetually providing a default value for some output.  The 0-value case you originally asked about was to allow this, as was the possibility of the constructor receiving wait values less than 1.
Or, stated otherwise, the intent was actually for there never be a value less than 1 in the defaultUsageWaits map, except when we would not want a wait value to be altered or removed.  And the latter would be for values indicating that we wanted to perpetually use a default value.
After our talk, I don't think this should be handled by the framework, so I've modified things to take that out.  It would have changed the nature of the type from being a wrapper/proxy to being a data source.
Also,setup_nested_deferred_provider in Bmi_Multi_Formulation is written so that these deferred providers will not have an initialized default if none is provided via the realization config.  And I've added some unit tests to make sure the wrapper falls back to the back to the value of the source provider if no default is given.

Added some test case that were not covered after conversation with @mattw-nws.  Also refactored the test class a bit.  Plus, rebased against latest master.

This (unit conversion stderr text removed:
/Users/runner/work/ngen/ngen/test/realizations/catchments/Bmi_Multi_Formulation_Test.cpp:653: Failure
Expected equality of these values:
  expected
    Which is: 4.86646e-08
  response
    Which is: 2.78098e-08
[  FAILED  ] Bmi_Multi_Formulation_Test.GetResponse_3_b (220 ms)

Looks like you duplicated test GetResponse_0_b before f5b33bc, you'll want to propagate the changes to the values in that commit.

Merging, but noting possible gotcha: I don't see a test that makes sure reading default_output_values through from the realization config works. Testing the use of default vals is done via providing defaults direct via C++ API, though. Just keep an eye on whether it works when doing this via the realization config (wouldn't worry about it except this bit me in #343!).


Change renewal notice email

Hi it would be cool if there is a CLI flag for changing the renewal reminder email address.
There is no easy way currently to do this that I could find. Currently we only get asked once upon first use and no option to update it.
Related thread I found during my research: https://community.letsencrypt.org/t/change-registrations-email-address-on-windows/31235

That's a good idea and the API is actually already implemented by ACMESharpCore, so it shouldn't be too much work to add this in.

I've added some code that will allow changes from the main menu. Actually doing it unattended from the command line will require some extra work.

Awesome that's good enough for my needs.
Cheers,
2E0PGS
On 20 Mar 2019, 19:28, at 19:28, Wouter Tinus<EMAIL_ADDRESS>wrote:

I've added some code that will allow changes from the main menu.
Actually doing it unattended from the command line will require some
extra work.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/PKISharp/win-acme/issues/1076#issuecomment-474994169

Released in 2.0.5


JS error with cshs

I'm getting a JS error with cshs module on Front-end anonymous (https://www.drupal.org/project/cshs)
The jquery.once library is missing. By default it has been removed from Drupal 9.2, see https://www.drupal.org/node/3158256
This issue has been reported on the module: https://www.drupal.org/project/cshs/issues/3347581
The fix will be included in all likelihood in the next release of the module (4.x)
In the meantime I'm using this patch: https://git.drupalcode.org/project/cshs/-/merge_requests/13.patch

This is solved in version 4.0.1


codegen misc

codegen misc updates, pleas see commits.

These changes look great. I assume you're still planning on moving out bytesmatcher and friends in the same way as stringmatcher?

yap, that's the plan :)


docs: Describe multi-currency proposal

Add a summary of the new proposal for multi-currency ledger. I pulled the content from #536 and the mailing list and tried to make it self-contained.

I'm still concerned that the one-transaction-per-token restriction makes it hard to create classes of NFTs which share a "monetary policy" for the issuing of those tokens.

Technically it's a one-transaction-output-per-token restriction

Since all NFTs are unrelated currencies, the current proposal requires some other record of which tokens are "valid" according to X, which is annoying.

I'm not sure I entirely understand what you mean by that, but maybe it can be addressed like this:
data NFT = NFT { nftName :: String, nftBootstrapTx :: TxHash, nftBootstrapIdx :: Int }

-- the validator script (in reality this would be a quoted TH expression)
 nftValidator :: NFT -> Data -> Redeemer -> PendingTx -> ()
 nftValidator (NFT nm txhash txidx) _ _ ptx =
  let
      txout = mkTxOut txhash txidx
      con1 = ptx `spends` txout
      con2 = ptx `forges` 1 (ownAdress ptx)
  in if con1 && con2 then () else error

Then you create a transaction t with say 10 outputs. Now NFT "mytoken" (txhash t) :: Int -> NFT gives you 10 NFTs, and you can get the hash of the i th NFT with \i -> validatorHash (NFT "mytoken" (txhash t) i)

Then you create a transaction t with say 10 outputs.

Sure, this is great if you have a known set of tokens, but that doesn't seem like it's always going to be true.

Consider the following "silly" NFT:

I want to use tokens to represent invitations to my party.
People get invitations by asking me off-chain, then I issue them a token on-chain.
I'm weird so they can sell them and stuff.

In this instance I want:

I should be able to issue invitations
Nobody else should be able to
Anyone (or perhaps just me) should be able to tell who has an invitation

I think this is hard in this proposal.

I think this is hard in this proposal.

Yes that's true, but I think it will be useful to actually implement something like the invitations you described to see how hard it is in practice. I expect that at least some of the work involved in creating and keeping track of tokens can be hidden behind a friendly interface/module on top of the wallet API.

I added a realistic example of a currency with an on-going monetary policy. Realistic meaning that we could implement this right away if the current proposal was adopted. I didn't run or typecheck the example though.

Going to merge this soon if there are no objections


Unfortunately, the PageSpeed Insights extension cannot run because the Native Client plugin is not available. The usual reason for this is your are not running the official Google Chrome such as a Chromium build. Check chrome://plugins/ page to make sure "Native Client" is installed and enabled. If you still get this error message, please file a bug.

Unfortunately, the PageSpeed Insights extension cannot run because the Native Client plugin is not available. The usual reason for this is your are not running the official Google Chrome such as a Chromium build. Check chrome://plugins/ page to make sure "Native Client" is installed and enabled. If you still get this error message, please file a bug.

I find the same problem with Google Chrome dev  Version 97.0.4692.8 (Build officiel) dev (x86_64) on MacOS BigSur.

same issue with me.

me too

您的邮件我已收到，请您放心！

您的邮件我已收到，请您放心！

If you haven’t already done so, enable the Native Client flag in Google Chrome. Type about:flags in the Chrome address bar, scroll down to “Native Client”, click the “Enable” link, scroll down to the bottom of the page, and click the “Relaunch Now” button (all browser windows will restart).


Created CODE_OF_CONDUCT.md file

Fixed issue #10: Adding a Code of Conduct file

Thanks!

Thanks!


feat(@embark/embarkjs): introduce Blockchain.isAvailable() API

This is in order to be consistent with existing isAvailable() APIs on
the EmbarkJS module.
Another reason this API is needed, is because we need a way to fire
EmbarkJS.onReady() even if no blockchain is available. Prior to this
commit, EmbarkJS.onReady() was purely relying on an API on EmbarkJS.Blockchain
that would break if the blockchain feature was disabled, causing
EmbarkJS.onReady() to never fire.

I checked out this branch, reboot:full + build, made a fresh embark_demo + embark run, and I'm getting:
Error: Provider not set or invalid

in the browser console. Note that I'm using the demo's default configs, i.e. I have enabled: true in config/blockchain.js.

Thanks for testing this PR and uncovering big flaw @michaelsbradleyjr !
I've looked into this and would like to explain what's going on and how it can be quick-fixed:
Here's what's going on
Obviously, the error messages say in several places that there isn't a valid provider set when Blockchain.isAvailable() is called. The reason this is coming up, is because of the implementation of Blockchain.isAvailable(), in which we're purely relying on whether we have a blockchainConnector. If we have one, we check for the networkId in order to signal the availability of the blockchain (here:  https://github.com/embark-framework/embark/pull/2096/commits/fdf0ef4f5fafcadcc9894592faa420eb45d9e27d#diff-8131c8e1b7e9bf0fc391bc271d81df7eR96).
Unfortunately, I was wrong with the assumption that, when we have a blockchainConnector we're also connected to the chain. At the time isAvailable() is called, blockchainConnector isn't actually connected yet (iow: it doesn't have a provider set itself yet).
The reason for that is, is because we're connecting implicitly via Blockchain.connect() and Blockchain.doConnect() and those APIs are async. These APIs are called inside the generated embark.js which the user might not even be aware of (I wasn't).
^ All of this wasn't an issue before this PR because EmbarkJS.onReady() would simply use Blockchain.execWhenReady() which simply schedules a callback for execution once blockchainConnector is in fact connected. The only problem is that we don't actually want to rely on execWhenReady() (and Blockchain.connect()) when the blockchain feature is actually disabled.
How to fix this
The core question we want to ask ourselves here is: How can we signal EmbarkJS' readiness without strictly expecting blockchain to be available, given that (at the moment) we don't have access to the blockchain config inside the browser?

One way would be to make the blockchain config available in the browser (right now it won't get generated if blockchain is turned off), and use its enabled property to decide whether we want to run execWhenReady(). This however, has the downside that EmbarkJS.onReady() depends on that config being available. It should better be passed down to EmbarkJS but we don't have an API for that yet.

Another way, and probably the quickest way to solve this, is to rely on heuristics and simply say: if we don't have a blockchainConnector (which we don't if blockchain is disabled), we know blockchain is turned off, so don't run execOnReady(). This quickfix doesn't require us to pass configurations down to EmbarkJS.

Option 2 works fine, I've tested it locally and could update #2097 accordingly.
What about embark-ens relying on onReady
One thing that came up is that embark-ens in the browser as well throws errors. This is because of the same reason discussed above. EmbarkJS.Names.setProvider() relies on EmbarkJS.onReady(), and while it's far from ideal that it does that, the core problem here is actually that isAvailable() can't wait for connect() to be done.
Given all the above, do we still need isAvailable()?
Something that's unclear to me at this point is what the value of isAvailable() would be. If we go with option 2) discussed above, we already know that we're connected to a blockchain, assuming that it's enabled. For consistency's sake, I still think isAvailable() should exist, but we should clarify its semantics and what "availability" means.

Updated #2097 accordingly.
This PR here can be closed if everyone agrees with the points above.

Closing in favour of #2097


Threshold is vertical but it should be horizontal

@GriffGreen in this case the chart shows the Threshold vs Requested Funds and that's why the threshold is represented on the Y axis. If we change it to be the other way around we get a much worst chart because the threshold % grows really quick.

@0xGabi he was referring to the theshold red line on the chart... I find it really confusing, I don't understand at all what this line is showing...


[Question] commented out buffer keyword in artifacts.n1_g1_identical()

We have the commented out buffer keyword in artifacts.n1_g1_identical() that is passed into geometry.voronoi_skeleton(). Should we leave that in there commented out or go ahead and dump it?
Also:

here
here
here
here
here

If it is commented out than it means that it was an attempt to solve some problem which is not needed in this version of the code and can be removed.


try to use MaskedVByte to speed up varint decoding

Refer http://maskedvbyte.org/
We should do the benchmark and see whether it can work well for us or not.

Hi. Since Rust recently started to provide SIMD in the nightly std, I am interested in working on a branch of that. May I have a try?

@codeworm96 Of course! In addition we can consider using foreign libraries if exists.

Looks like this algorithm is mainly for decoding multiple varints at once according to the paper. However in TiKV the scenario is different, we mostly only want to decode 1 varint. Closing.


is it possible to add visualisation dot attribute(s) to nodes and not only to transitions ?

I would like to add this kind of dot output:
digraph "door" {
rankdir=LR;
"closed"  [ style=filled, color = black, fillcolor=red ];
"open"  [ style=filled, color = black, fillcolor=blue ];
"closed" -> "open" [ color="blue" ];
"open" -> "closed" [ color="red" ];
}
So in real time I will be able to change the color of the node according to the node state
I can do it also by postprocessing the dot output of the visualise() function, isn't it simpler ?

I have suggested a way to do this:  allow states to be defined before transitions (rather than as an adjunct to transitions.)  That way, you could provide dot attributes to the state nodes.
It would also have a side benefit - transition definitions could check the provided 'to-from' states and insure they exist.
I'm working on a branch to do just this.  Will issue a pull request when I'm done.

Don't know if anyone is still following this, but I have a branch at https://github.com/rickbsgu/javascript-state-machine that does this.
Clone it and check out the 'statedefs' branch.
To use it, add a 'statedefs' array in the fsm definition, like so:
  ...
  statedefs: [
     { name: 'enter', dot: { fillcolor: 'green', shape:'rect' },
     ...
  ],

'dot' defs are optional, but once you specify statedefs, all states must  be defined in the array.
This triggers additional checks:

Check the states used in transitions and flag an error if one or more are not defined.
Check the transition names and flag an error if the transition name matches a state name

(Helps me...)
rickb

@rickbsgu You may check the dot command line args as well.
For example, you get a graph some graph to be displayed with a box shape
dot -Nshape=box -Tpng some.dot  > some.png


Leptosfmt installation detection does not work cross platform

This line:
https://github.com/codeitlikemiley/leptos-fmt/blob/47415428a2bfcf4ab8ac90846abe70b6d544874f/src/extension.ts#L14
references the file path in a way that does not correctly resolve the file path on windows.
You may want to use a dependency like lookpath to resolve the location from the name alone. It may also be good to have a configuration option where one can provide a direct executable path in case Leptosfmt cannot be found normally.

kindly check v0.0.6 i added custom path on settings for leptos
https://github.com/codeitlikemiley/leptos-fmt/pull/8

would like to know if this would fix the issue on windows , as i have


How to Setup the library ?

Hello, I'm trying to include this library to my Arduino IDE, without success.

So I tried download the TinyUSB (https://github.com/hathach/tinyusb) and merge the src folder, but still getting erros.
Could you teach me the steps to make it work ?

Hi!
don't know if you have already solved... anyway you have to use the "esp32s2" branch of arduino-esp32 with this library. You cannot install it using board manager, do as it follows:
(I assume you're on Windows):
https://github.com/espressif/arduino-esp32/blob/esp32s2/docs/arduino-ide/windows.md
remember to switch to the esp32s2 branch before running get.exe
I was able to run the examples following this procedure.


potential breaking change / bug in uv==0.1.30

the following GHA step
- name: Install packages
  run: |
    python -m pip install -U uv
    uv pip install --upgrade --system -e .[dev]

started failing after the release of 0.1.30 with
Run python -m pip install -U uv
Collecting uv
  Downloading uv-0.1.30-py3-none-manylinux_2_17_x86_64.manylinux20[14](https://github.com/PrefectHQ/prefect/actions/runs/8620086419/job/23626392040?pr=12629#step:6:15)_x86_64.whl.metadata (26 kB)
Downloading uv-0.1.30-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (11.5 MB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.5/11.5 MB 125.0 MB/s eta 0:00:00
Installing collected packages: uv
Successfully installed uv-0.1.30

Notice:  A new release of pip is available: 23.0.1 -> 24.0
Notice:  To update, run: pip install --upgrade pip
Built 1 editable in 1.[17](https://github.com/PrefectHQ/prefect/actions/runs/8620086419/job/23626392040?pr=12629#step:6:18)s
error: Attempted to wait on an unregistered task
Error: Process completed with exit code 2.

full CI run (not much else as far as logs unfortunately)
pinning to 0.1.29 appeared to resolve the issue

more potentially useful context
we use the following step before the install step, pending setup-python support
      - name: UV Cache
        # Manually cache the uv cache directory
        # until setup-python supports it:
        # https://github.com/actions/setup-python/issues/822
        uses: actions/cache@v4
        id: cache-uv
        with:
          path: ~/.cache/uv
          key: uvcache-${{ runner.os }}-${{ steps.setup_python.outputs.python-version }}-${{ hashFiles('requirements-client.txt', 'requirements.txt', 'requirements-dev.txt') }}

I don't have a strong hypothesis for why this error is occurring, sorry. let me know if there's anything useful I can provide

Thanks for the report Nate!
cc @charliermarsh

It does reproduce in CI though, here are the verbose logs https://github.com/zanieb/prefect/actions/runs/8620667551/job/23627935783

Presumably we fail at https://github.com/astral-sh/uv/blob/1512e07a2e7c05b7c9fcb457f35c7ef0f25d8d9b/crates/uv-resolver/src/resolver/mod.rs#L615

We're seeing this in CI for the datahub project as well. It doesn't happen reliably though - seems like it impacts ~50% of our CI workflows, despite the matrixes being pretty similar.
https://github.com/datahub-project/datahub/actions/runs/8620627386/job/23627824491?pr=10256

We've identified this is most likely caused by #2452 and resolved by #2943 though we're still confirming with a reproduction. This wasn't caught by our unit test suite (and you'll only see it in some cases) because the cause is a performance optimization which is only applied when backtracking occurs several times.

I'll leave this open until we release.

Tangential remark: I was able to reproduce consistently with Python 3.9 but not with Python 3.12.

v0.1.31 is out now, which hopefully resolves this.

it does indeed appear to be resolved on v0.1.31 ✨
thanks for the quick fix!

Awesome, thanks for reporting, glad we could resolve!


[ISSUE #4729] Fix ambiguous error log message

Make sure set the target branch to develop
What is the purpose of the change
Close #4729
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.2%) to 48.85% when pulling d4a32a3eec75d5089f2beae03210b8881f1f4b3c on Oliverwqcwrw:develop-log-message-42 into 67b49b55068e85551676a9af1f6cfa3776e41e08 on apache:develop.

Codecov Report

Merging #4730 (d4a32a3) into develop (67b49b5) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4730      +/-   ##
=============================================
+ Coverage      44.81%   44.85%   +0.03%
- Complexity      7560     7564       +4
=============================================
  Files            977      977
  Lines          67640    67640
  Branches        8934     8934
=============================================
+ Hits           30315    30338      +23
+ Misses         33580    33563      -17
+ Partials        3745     3739       -6

Impacted Files
Coverage Δ

...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java
65.99% <0.00%> (ø)

...he/rocketmq/broker/processor/PopReviveService.java
24.90% <0.00%> (-1.81%)
:arrow_down:

...a/org/apache/rocketmq/broker/BrokerController.java
46.69% <0.00%> (-0.60%)
:arrow_down:

.../org/apache/rocketmq/proxy/config/ProxyConfig.java
48.08% <0.00%> (-0.55%)
:arrow_down:

...cketmq/broker/processor/PopBufferMergeService.java
40.71% <0.00%> (+0.23%)
:arrow_up:

...mq/client/impl/producer/DefaultMQProducerImpl.java
44.62% <0.00%> (+0.24%)
:arrow_up:

...mq/store/ha/autoswitch/AutoSwitchHAConnection.java
75.20% <0.00%> (+0.27%)
:arrow_up:

.../apache/rocketmq/logging/inner/LoggingBuilder.java
64.71% <0.00%> (+0.31%)
:arrow_up:

...nt/impl/consumer/ConsumeMessageOrderlyService.java
50.17% <0.00%> (+0.35%)
:arrow_up:

...he/rocketmq/client/trace/AsyncTraceDispatcher.java
83.80% <0.00%> (+0.47%)
:arrow_up:

... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Could you squash all the commits to one commit?

Could you squash all the commits to one commit?

Hello @HScarb ,
Thanks for your suggestion. I will squash it next time when I submit


Bulk Update for updating status in notifications table

As user ,
I want to bulk update notifications ,
so that i don't need to do it for every notification specifically .
Link

blocked by #708

Hints / Details

Selected Notifications get passed to update modal
Modal Update to support multi update of notifications (list selected notifications in modal)
Error handling / Grey out + tooltip if not allowed for selection (Status wrong)

Acceptance Criteria

[ ] Bulk Updating notifications is possible
[ ] Cypress user journey is adjusted and covered over e2e tests

Out of Scope

...

I copied the ticket as the original tickets were deleted due to a spam account.
Orginal Ticket: https://github.com/eclipse-tractusx/traceability-foss/issues/619


Request money - Contact selection list in Request money page is missing user avatars

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.27-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Go to FAB > Request money > Manual
Enter amount > Next

Expected Result:
User avatar will appear next to the contact
Actual Result:
User avatar is missing. The same issue also occurs in Room member list
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/9c4f3232-b08c-49fe-8500-86368e7be65b
View all open jobs on GitHub

#wave6-collect-subt-mitters

confirmed regression from #34008

cc: @filip-solecki

Can reproduce. Found the PR

Proposal
Please re-state the problem that we are trying to solve in this issue.
Contact selection list in Request money page is missing user avatars
What is the root cause of that problem?
It is a regression from this PR
https://github.com/Expensify/App/pull/34008
https://github.com/Expensify/App/blob/c9970e42eeecdc9db9bfe2496e45b4bf798bd0b4/src/components/SelectionList/BaseListItem.tsx#L32-L33
What changes do you think we should make in order to solve the problem?
change this line to as it was before
    const isRadioItem = !item?.icons?.length > 0;

I'm reverting this PR as it introduced two separate issues.


Documentation update

When installing MMTtools in addition to astropy I had to manually
pip install photutils  ccdproc
Although I thought these would be part of astropy, they apparently are not. Once these are
installed
python setup.py install in MMTtools works like a charm.

Welcome to GitHub!
Christopher, thanks for pointing this out.  The documentation is outdated as a setup.py script is available and ccdproc and photutils are included.
Thus, the following will install the appropriate software:
python setup.py develop
However, photutils and ccdproc are not used by the mmirs_pipeline_taskfile.  Ultimately, I would like to refactor the code so that mmirs_pipeline_taskfile is its own package.


WIP port to Julia 0.7

Replace DataValues.jl with Union{Missing,T} and NamedTuples.jl with native named tuples.
Get all but TableTraits.jl code to pass tests.
cc @davidanthoff I have commented tabletraits.jl code for now. Are you planning to make it possible to use it on 0.7 with Union{Missing, T}?
cc @quinnj
@piever maybe _is_subtype is now kind of redundant since Union{Missing, T} can be tested with <: for the same property?

I think we should switch to Base.promote_typejoin to widen element when collecting an iterable of tuples, but @nalimilan probably knows more about this.
I would also like to get rid of is_subtype, but we need to make sure that Base.promote_typejoin(S, T) === T if and only if S <: T. If that's not the case we could even use Base.promote_typejoin(S, T) !== T as a condition to widen (meaning, widen only if it would actually get strictly wider).

I think we should switch to Base.promote_typejoin to widen element when collecting an iterable of tuples, but @nalimilan probably knows more about this.

Yes, that sounds right. Basically, do the same thing as map.

I would also like to get rid of is_subtype, but we need to make sure that Base.promote_typejoin(S, T) === T if and only if S <: T. If that's not the case we could even use Base.promote_typejoin(S, T) !== T as a condition to widen (meaning, widen only if it would actually get strictly wider).

I would say that's the case. At least promote_typejoin is equivalent to typejoin except for Union{T,Missing} and Union{T,Nothing}.

Bump. It would be great to get this merged soon.

David's performance concern here is valid --- it might be better to do everything but the Missing change first.

@davidanthoff I think @piever's iterator based approach with widencolumns was key to making this possible with missing. He did strategically design for that with this change in mind.

It would certainly be helpful if some benchmarks were actually performed. @piever, do you happen to have any comparisons you did in doing the widencolumns work?

Of course. I was just commenting on the point about not being able to use Iterators + missing.

Ah Okay I hadn't schooled myself on that discourse discussion, my bad.

@piever's code is great, but I wouldn't expect it to solve the performance problems. I might be wrong, so benchmarking and comparing would be a good idea.

At the time I mainly tested that it didn't lose performance compared to the previous inference based implementation in the type stable case: as Missing in Julia 0.6 was slow anyway I didn't test it. I suspect there may be issues in the case of multiple columns allowing missing data, with the combinatorial explosion of possible types, but I don't have benchmarks.
OTOH, I think that https://github.com/JuliaData/Tables.jl/pull/10 is managing to combine the good ideas from collect_columns and the good ideas from Tables and may be the ideal implementation: in case my implementation here has performance issues we could try using that one instead (I also think it's slightly suboptimal to have to maintain two separate implementations of the same thing). It would allow several other optimizations as well like iterating lazy rows (see here) rather than materializing NamedTuples like we currently do.
On a related note, I also seem to remember that some functions had yet to be ported to the new iteration framework (join for example) and still rely on inference, so we probably need to keep that in mind.

I suspect there may be issues in the case of multiple columns allowing missing data, with the combinatorial explosion of possible types, but I don't have benchmarks.

Yes, that is the scenario I would worry about. Doesn't seem like a corner case to me :)
I think in general a good strategy would be to get this working on julia 0.7, with the minimal set of change, and then think about broader redesigns. No need to couple those two decisions and thereby delay everything by a lot.

Just pushed a commit that gets this further for 0.7/1.0, some remaining test failures involve:

Some complaints about isnull not being defined: @davidanthoff is this a DataValues thing/change?
Some complaints about no method for setindex_shape_check(::Bool, ::Int64); I'm guessing that was an internal Base method that got changed?
A bunch of join tests are still checking DataValue missing vs. missing
  MethodError: no method matching +(::Int64, ::UnitRange{Int64}) from    [1] valuenames(::NDSparse{Tuple{Int64,Int64},Tuple{Int64,Int64},Columns{Tuple{Int64,Int64},Tuple{Array{Int64,1},Array{Int64,1}}},Columns{Tuple{Int64,Int64},Tuple{Array{Int64,1},Array{Int64,1}}}}) at /Users/jacobquinn/.julia/dev/IndexedTables/src/ndsparse.jl:271
And a PooledArray error like   MethodError: no method matching copy!(::Array{String,1}, ::Int64, ::PooledArray{String,UInt8,1,Array{UInt8,1}}, ::Int64, ::Int64).

Can anybody else pick things up from here? If not, I can try to take another crack or two over the next few days.

Some complaints about isnull not being defined: @davidanthoff is this a DataValues thing/change?

This is also affecting StatPlots, FWIU it is isna now.

The + should be .+ and copy! should be copyto!.

Yes, isna is the new isnull on 0.7+ for DataValue.
I haven’t gotten the broadcasting stuff to work for DataValues.jl on 0.7 yet. Not sure that is used anywhere here, though, just a heads up.

BTW I did a simple map with tables of n missable/DataValue columns. It does scale exponentially with Missing...
Nice work @quinnj ! I'll try to fix up the tests tomorrow (they still use missing and there are a couple of failures related to reflection). You can continue to fix other things...

@quinnj did you happen to test the scaling of your buildcolumns implementation in case of unknown schema? If you have better performance we could try to port IndexedTables to use it, I suspect materializing the NamedTuples is bad for performance with several missable columns.

I wouldn’t expect unknown Schemas to be the problem, I think iterators that produce streams of values with heterogeneous types are the culprit (and those you easily get in a projection with Missing, but not so easily with DataValue). Those are really distinct.

Got tests passing locally.

Now with more TableTraits.

Merge?


Connect Email automation to gmail API

Summary
Connect the email module to gmail and give the user a option to use it instead of a local SMTP server
Link to Python example
Examples

The user should be able to specify that all emails should go through the users gmail account
The user should then be able to for example be able to input "send an email to<EMAIL_ADDRESS>and ask if the report is ready yet" and the email should be sent through the gmail account

Context
The emails sent by our client must be connected to the users actual email account so that the user can see that an email has been sent when logged into their gmail service like Outlook or GMail. Thus we must give the option to use the gmail api for sending the messages. Future work will be to add other email services, for example Outlook.

We already have SMTP support, why should we add another protocol? Gmail have a SMTP-gateway.

See my account setting to see how to send via external account.

Did not know of the SMTP-gateway, my bad. Closing the issue

For Gmail it seems the hostname is smtp.gmail.com:465, using SSL.


tweak for tunnel

makes the tunnel transparent.
(also, removed an extra unused copy of the Red Hat font)

@dudash Tested locally, worked as advertised - merged.


calling historical_decomposition and variance_decomposition

Hi Junior,
This is my first time using RISE. To start, I just ran the codes for your AEJ Macro paper. Everything works fine, except calling historical_decomposition (replicating figure 6) and variance_decomposition. Matlab says "Undefined function 'historical_decomposition' for input arguments of type 'struct'." and "Undefined function 'variance_decomposition' for input arguments of type 'struct'". Is this due to version conflicts or something else? Thanks a lot.
By the way, a minor issue: I followed your instructions to install RISE and ran rise_startup. Matlab says that "MiKTeX: Not installed (no reporting possible)" and "pdflatex/epstopdf (Miktex) could not be located!!!" However, I installed MikTex on my computer (C:\Program Files\MiKTeX 2.9) and it works well. Could you please give me some hints for this issue?  Thanks a lot.

Hi
Historical and variance decomposition functions are to be called on model
objects and not on structures. Make sure the input to the function is an
object of class "rise" or "dsge"
It is also possible that the version we use for writing the paper is not
the one you are using, in which case you will need to update the codes.
If Miktex is installed on your computer, then RISE should be able to detect
it unless, perhaps you are using an operating system that RISE does not
understand well. Windows and Mac should be fine.
Cheers,
J.
On Sun, Feb 10, 2019 at 9:25 AM dingliumath<EMAIL_ADDRESS>wrote:

Hi Junior,
This is my first time using RISE. To start, I just ran the codes for your
AEJ Macro paper. Everything works fine, except calling
historical_decomposition (replicating figure 6) and variance_decomposition.
Matlab says "Undefined function 'historical_decomposition' for input
arguments of type 'struct'." and "Undefined function
'variance_decomposition' for input arguments of type 'struct'". Is this due
to version conflicts or something else? Thanks a lot.
By the way, a minor issue: I followed your instructions to install RISE
and ran rise_startup. Matlab says that "MiKTeX: Not installed (no reporting
possible)" and "pdflatex/epstopdf (Miktex) could not be located!!!"
However, I installed MikTex on my computer (C:\Program Files\MiKTeX 2.9)
and it works well. Could you please give me some hints for this issue?
Thanks a lot.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/jmaih/RISE_toolbox/issues/99, or mute the thread
https://github.com/notifications/unsubscribe-auth/ACagz13eVd3pQVPdbrJFOzPKj5RMGsEWks5vL9dkgaJpZM4ay8pM
.

Hi Junior,
Thank you very much for your timely reply.
I will look into the issues with your advice.
Cheers,
Ding


Make baseUrl, sslProxyUrl and apiKey configurable

Closes #19
So not sure if this was what you had in mind, but at least now it's in a separate file - no build system.

I'll go ahead and write up another ticket for setting up the docker image thingy


Fix scrollHeight issue?

So, this appears to fix the scrollHeight issue I was having in #40, but I'm not 100% sure why. I still get the scrollHeight error message in my console, but it is no longer breaking anything... I can continue to use pikabu without any issue to it or any other operations on the page. Can anyone help me understand why this might work, or if there's anything you see that should be done to make it work even better?

Hey, we’re looking to prune older abandoned PRs. If this PR is still relevant and you would like to see it merged in, please reopen the PR and we’ll add it to our backlog! Thanks!

Nah, I don't really personally care about this for any of my current projects anymore. Maybe again in the future. ;) Thanks.


Provide easy public access to CI artifacts

Is your feature request related to a problem? Please describe.
uss_qualifier produces a large amount of useful output on every CI invocation, which happens (among other times) whenever a PR is merged to the main branch.  This includes artifacts like templated reports, tested requirements reports, sequence view reports, HTML representations of the raw report structure, and the raw reports themselves, usually in .json format.  However, it is currently somewhat difficult to show these outputs to users (developers, regulators, etc) because they are not part of the repo and can only be obtained by either running uss_qualifier directly or navigating into the most recent CI run, downloading the applicable artifact, unzipping it locally, and finding the desired artifact.
Describe the solution you'd like
It would be fantastic to have a fixed public URL that would make the artifacts produced by the CI run for the most recent commit to the main branch accessible.  For HTML artifacts, a subpath of this fixed public URL should directly show the artifact in the browser (rather than having to download a zip and view the HTML locally).
Describe alternatives you've considered
This seems like it shouldn't be too unusual of a use case, so perhaps GitHub already has tools that do this.  Or, perhaps use readthedocs.io.  Or perhaps create an "artifacts" GitHub repo and commit into it from the GitHub CI worker.  Or, perhaps host (and possibly even make, in an extreme case) our own simple webserver that can receive pushes from the GitHub CI worker to update its content.

Resolved by #252


Make an "Apply to Job" page

As a user, I would like to be able to apply to jobs and upload cover letters, write notes and use my stored resume.

DONE on patrick'sUpdatedBranch. Routed as NavLink. Should be routed to job postings button


[GSSOC '23] Data Structures and Algorithm in Python

Aim

implement important data structures and algorithms in python script

@hashfx @avinashkranjan I would love to work on this issue, Please assign this to me under GSSOC'23

Go Ahead @hashfx


fix: 🐛 fix show border not applying to header in month view #306

Description

Show border will apply also to header in month view with showBorder field.

Checklist

[x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[x] I have followed the Contributor Guide when preparing my PR.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[x] I have updated/added relevant examples in examples or docs.

Breaking Change?

[ ] Yes, this PR is a breaking change.
[x] No, this PR is not a breaking change.

Related Issues

Closes #306

Please add before after screenshots


Elixir part of presentation

I would add few things:

more info about phoenix since it's 'web framework for APIs, HTML5 apps & more', because there's a chance to use it inside 10C,
'Elixir function call is an Erlang function call' - without overhead
No dynamic dispatch as a huge +
missing info about metaprogramming as a +

I would mention them, even if there wasn't a word about that in talk :)


Further reduce texture memory usage by clearing pixelData in glTF images after creating Unreal textures.

This depends on CesiumGS/cesium-native#804 and CesiumGS/cesium-native#806 so merge them first.
After we create an Unreal texture from a glTF ImageCesium, we "mostly" don't need the pixelData anymore. Clearing it saves a lot of memory - an entire copy of the raw, uncompressed pixel data. This is an improvement comparable to #1329 again, and it applies even to Windows (unlike that PR).
So that's what this PR set out to do, but it kind of got away from me and ended up being a pretty substantial overall of how textures get created in Unreal. There are a bunch of benefits:

In all cases except metadata textures, we now free the CPU-side copy of the texture data once we've handed it off to Unreal. This was the original goal, and is an enormous reduction in texture memory usage. It would be easy to do this for metadata textures, too, but the assumption is that we (sometimes? always?) need access to that data on the CPU.
Metadata-related textures are now created using the same code path as all the other textures. Previously they used a separate, slower path. (note: I don't expect any major surprises here, but I'm not sure I was able to test every variation of a metadata texture. Bugs are possible, so some attention on this in review would be much appreciated!)
We avoid an extra copy of the texture data in a worker thread on non-Windows platforms. Previously, every time we created a texture on non-D3D platforms, we made one copy of the pixel data in a worker thread, and then copied it again in the renderer thread. Now we only copy it once, in the renderer thread. On D3D, we also make one copy, but in that case that one copy is made only in the worker thread, which is better (this didn't change in this PR).
When multiple glTF texture instances reference a single image, we now only create one copy of the texture data on the GPU. Previously we'd upload the image multiple times. This isn't super common, but it's a big win when it happens. Probably the most notable place it happens is when creating upsampled tiles for raster overlays. Previously the upsampled children would each get a full copy of the parent's textures. Now, they all share the parent's textures.

Some other notes:

Metadata textures are now created in TEXTUREGROUP_8BitData instead of TEXTUREGROUP_World. This is a little bit arbitrary, but I think it's an improvement.
Previously, the size of the pixelData was used to determine the size of texture data for caching purposes. Now that's pretty much always going to be zero, so the new ImageCesium::sizeBytes field (see CesiumGS/cesium-native#804) is used to track the size instead.

I'm using TextureSettingsTest to test support for multiple textures with different sampler settings referencing a single image. I'm using this tileset.json to display it:
{
  "asset": { "version": "1.0" },
  "root": {
    "boundingVolume": {
      "sphere": [
        0,0,0,10
      ]
    },
    "children": [],
    "content": { "uri": "TextureSettingsTest.glb" },
    "geometricError": 0.0,
    "refine": "REPLACE"
  }
}

This is as close as we get to working, because double-sided materials are not supported in Cesium for Unreal:

It's doing a GPU copy of the texture data. There are edge cases, though. What if the first texture didn't have mipmaps, but a later one does? Ugh.

@j9liu , if you have the time, can you help with a sanity check / test on anything that changed related to metadata?
I've already reviewed the dependent cesium-native changes, tested the unreal samples, and am looking at rest of the code the now.

@kring any thoughts on how to test this properly?
I see all the unit tests passed, which is good, but I'm not seeing any unit tests that target texture loading / texture memory specifically.
I've also run through all the Unreal samples, in Windows, but don't have a non-windows device to check against.
As for code review, looks like a lot of "overhaul" type code, like you stated. Can definitely look for obvious issues, but there's a chance that anything subtle and non-obvious can slip through here.

@kring One more thing, do you have any numbers of showing how much texture memory was saved?
Ex. In cesium-unreal-samples, I saw memory usage go from X to X, a X% reduction.

I see all the unit tests passed, which is good, but I'm not seeing any unit tests that target texture loading / texture memory specifically.

It'll be extremely difficult to write tests for. We'd have somehow confirm that the GPU texture has been populated correctly. I'm open to ideas, but it doesn't seem worth the effort when it's very obvious very quickly just by looking if textures aren't being created successfully.
One thing to watch for is memory leaks. I've put a lot of effort into convincing myself there are none, but that's probably the biggest risk. Well, that and the risk that I've broken something related to metadata textures, because breaking those wouldn't be so obvious at a glance.

One more thing, do you have any numbers of showing how much texture memory was saved?

It eliminates a complete copy of the texture in CPU memory. After this PR, there should be none left (as far as I know!), so the CPU texture memory usage goes from X to 0, for an infinite improvement! 😁
Counting CPU and GPU memory together, this will cut the texture memory usage in half.

Well I looked into it, and it's actually not too difficult to read back a texture in Unreal. So I added some tests. I also cleaned up some TODOs. Sadly this PR no longer removes more code than it adds, but it's probably worth it. 😁

I unfortunately had to mark the new tests NonNullRHI, meaning they effectively won't run on CI, because the null RHI doesn't allow to create a texture and then read back its pixels, so all the new tests fail. It's also not possible to run with a non-null RHI on the non-D3D11-capable GH Actions runners.

I ran into a crash earlier that I can't reproduce 🤔 It was because my 06_CesiumMetadata had been changed for #1360, and when I opened it, it crashed some class that was "SharedThread____" ? But after I git restore'd the level, I didn't see it again, and I have no idea what I could have done for my PR to induce the crash!
Unfortunately, I took a screenshot and pasted it here to post later, but I accidentally navigated to a different tab and now I can't reproduce it. I'm documenting this anyway in case I run into it again.

@kring back to you. There's a few comments left here, and also some comments in cesium-native 806.
Appreciate the new texture unit tests, thanks. I think one of your big concerns was memory leaks, and indeed that is a general concern for the plugin right now, so I wrote a new issue to create memory leak tests.
I finished code review and didn't find anything major. It's a lot of code that's changed though, so it's very easy for subtle bugs to slip through. Hopefully unit testing will help. I'll also manual test a bit more through next week.

Thanks for the reviews @csciguy8 and @j9liu. I believe I've addressed all your comments.

Thanks @kring !


[Bug]: Crosshatch burns outside of stroke on low dpi

Summary Description
When make a raster crosshatch with low dpi like 50dpi it burns outside of stroke line.

Additional Details
No response
Crash logs
No response
MeerK40t Version
0.8.4002
MeerK40t Type
Executable
Your Operating System
Windows

Hm. It actually looks like the laser in question needs a turn delay-on or delay-off setting. You can look carefully and it looks like every other line actually does this and the other end of the line does it the other direction. The low DPI means it moves pretty far between lines but you can see one side over-does the line and the other side of the line will be overshot the next time. So it's only overshooting on one side.
I mean please save a gcode (or whatever laser file output you're using), but looking at the image there's some chance this is hardware related like the laser is staying on a split second longer than it should when turning off. I'll do my due diligence here but some lasers like galvo lasers and newlydraw lasers will absolutely provide some timing controls here and there and it really looks like your laser is staying on a bit longer than it should.
Save the job in Plan tab of the Laser-Control , and I'll be happy to check that the file actually says to stop where it should say to stop 25 DPI might also produce a less crisp image, like it actually reduces the DPI such that there might be some slop there but I would expect would cause an issue across the board rather than every other row.

Yeah, that's entirely possible. To do that operation it's creating an extremely small image and simple rounding error on an image that size could possibly result in exceeding those positions. If it's an m2 nano, you could probably save out an .egv file and I could probably check the expected positioning for that.
For speeds your y-axis moves have to move that entire laser bar and the laser head, so because of the weight differences it can absolutely cause some issues, especially at near top speed. In theory you could use a hatch operation for this effect. Or you could cheat and just use a much larger filled image with a hatch already in it, so you get it to look like a hatch but then just raster the image horizontally. Basically raster a picture a picture of a hatch. The actual steps here should be about 40 units which should maybe be a bit long between the scanlines but should work.
Checking the .egv file is probably worth it, and really thinking about it, it very well may be causing some antialiasing around the edges and exceeding the positions at a lower overall power. Since if you're moving 40 units vertically you should also move 40 units horizontally which is probably enough to overshoot the end positions there.
In fact, I'm sort of convinced that's the issue.
It's taking the number 25 and making it extremely small. Then applying a raster to that. Downsizing the image by 1/40 from the full sized image. This means each pixel is technically about 1/40th of an inch wide and high. The height is generally going to be ignored and just gives you a scanline each 1/40th of an inch. But, the width is also affected by this. Meaning chunksize (so to speak) is going to allow stopping only in increments of 1/40th of an inch. And some of pixels will overshoot that amount, even if only slightly. When they do this, the power level of that pixel should be roughly equal to the amount of light pixels that were in the original image. So you should get them all going to the same endpoints but at slightly different PPI for the last little amounts.
This is why you will get very light lines on the inside loops of the 2 and 5. You can see the vertical lines there but clearly that area shouldn't have been black... but it could have been roughly gray. Basically the resolution at 25 dpi gets so reduced that you're talking 20 pixels or so at the fattest part of the raster.

For comparison, here's just normal text 25 about 15mm tall. Set at 25 dpi.

Here it is again with the trace line at the 25 or so.

This is the same thing done as a hatch. 25dpi is a distance of 0.025in so I typed that into the hatch distances. And did 2 one at 0.025 / 0deg and another at 0.025 / 90deg.
This won't invoke raster mode since it's purely a regular movement. So you wouldn't manage 500mm/s maybe 50 or so max. But, it would certainly work.

@tatarize the problem with hatch operations is that it makes too much change of directions and do one path at time.
In raster mode it make scanline from top to bottom of all path at one time and also if is only one path it makes from top to bottom of entire path in one pass without change direction on each intersection that is good for k40 due of it's y axis.
So raster mode is perfect for doing this operation but instead DPI that change the resolution of the path i need something like line height (like in moshidraw software) in steps or mm that basically skips steps on y axis when engrave in horizontal direction and on x axis when engrave in vertical direction.
Is there any function in meerk40t that can do this?
this is the egv file, i added .txt extension for upload to github just remove it in case
test.egv.txt

https://github.com/meerk40t/meerk40t/assets/3302478/3eaa0cda-2d59-4c68-9015-11ee517b418a
The direction changes are that it's doing normal moves and can minimize distances there. You could turn off optimizations.

There isn't an easy method to do this as a raster and clearly a lot of reasons you might well want to do this as a raster. Hatch isn't a full solution obviously, and neither is raster. There is a function to maybe permit this to be done with rasters but it's not a function that is basically ever used outside of ruidacontrol. Basically there's some rastering in ruidacontrol that isn't specifically flagged as rastering so it needs to be detected and treated as such. Which means that if it sees a bunch of flat lines it will classify that as a raster and raster it (otherwise the rastering would be rather dreadful), though actually that caps out at 15 units moved vertically and you're at 40 so that metric wouldn't really apply. It might also be possible to avoid the high resample rate along the horizontal axis. So if I shrunk the data to like 15 pixels tall (the number of scanlines, but kept it like 600 pixels wide). In theory you sort of want to set horizontal DPI to 25 and vertical DPI to 1000 and vice versa. So rather than blend across horizontal pixels it does a hard-cutoff where it needs to do a hard-cutoff.

@tatarize thank's for you video. I had already tried to disable optimization but only in the panel where there is the start button and then tried to simulate but only now i see that disabling the optimization in this panel don't disable automatically the optimization in the simulator so the simulation was altered and does not reflect the real job.
Later i try it and i think in my case it works very well. After the test i close this issue.
Thank you very much for your time


Missing highlight in tab-selected autocompletion

When using any auto-completion, fish suggests items underneath the current line. If you use tab to select the an item, it replaces the contents of the current line with the selected auto-completion. It also highlights the item which you selected.
This highlight is missing since installing lighthaus.
What does it look like?

In this example, I selected the second option but have no visual feedback/state.
What should it look like?

I removed only the lighthaus color scheme and this is how the highlight looks (light gray background).

Como faço para rackear um Instagram?


improve add more info in LoadStreamStub errors

Proposed changes
Add more info (load id, stream id, src id, dst id) in LoadStreamStub errors.
Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Fix incorrect background jobs number

The jobs -l command displays a "pwd now :..." line when a job was launched from a different directory than the current one that cause powerlevel9k to display an incorrect number of background jobs. This change fixes it.

Awesome! Thanks!
Our development branch is next. Could you rebase your PR to next?  That would be awesome.
@bhilburn Works for me on OSX (with zplug) and Linux (with plain ZSH).

Closing and reopening as requested


BUG:TypeError: make_grid() got an unexpected keyword argument 'range'

Hello, I encountered a bug while running this project. Is there any way to solve this bug
Traceback (most recent call last):
  File "train.py", line 188, in <module>
    writer.add_image('sample', vutils.make_grid(samples, nrow=1, normalize=True, range=(-1., 1.)), it+1)
  File "/home/liu/anaconda3/envs/AttGAN/lib/python3.8/site-packages/torch/utils/_contextlib.py", line 115, in decorate_context
    return func(*args, **kwargs)
TypeError: make_grid() got an unexpected keyword argument 'range'

In pytorch's recent updates, the make_grid function doesn't take 'range' argument. Either remove the range=(-1., 1.)) argument from the function call, it will take the default values (min, max from the tensor), or you can replace the rangeparameter by value_range
your call should look like:
  writer.add_image('sample', vutils.make_grid(samples, nrow=1, normalize=True, value_range=(-1, 1)), it+1)
let me know if it works :)

Thank you for providing the method. I used the method you mentioned and it worked so well that the model could be trained, but I would like to know how you came up with this modification.
In addition, I have a question. When I open the NVIDIA-SMI backend, I see that the usage of graphics memory is only 3G, but I currently have 24GB. I would like to know how to modify it to increase my existing usage.

Great, I just went through the official documentation of the PyTorch.
And about the GPU usage, you can set the application priority higher to get maximum resources allocated to it. Also, you can change the PC power plan to high performance to get the max usage. By default, the application resource allocation depends upon various factors, such as battery saver plan, background processes and application holding up the resources.
If you are looking to set an app getting maximum resource allocated to it, refer to some custom methods on YouTube.

Okay, thank you for your guidance.

It works, thanks!!!

Thank @fengfenglong123 for raising up this issue and thank @ghubrakesh for the great solution! I've pushed a fix in https://github.com/elvisyjlin/AttGAN-PyTorch/commit/be2d6c68049eeae4082365738b807aa49d214e77 to close this issue.

thank you so much! Love you!!


Add Pattern Prop to Input Component

Summary
This adds the html pattern attribute as a first class prop to terra-form-input.
Closes #2089

I would expect a jest test to be added and updated


Did we implement buffer capacity for moe models?

https://arxiv.org/abs/2402.05526 shows that it can overflow if there is buffer capacity for an expert.

@zhuohan123 @WoosukKwon

Hi @flexwang, currently, the Mixtral and DeepSeek MoE models don't have anything like capacity factor. Thus, each token's routing decision is not affected by other tokens, besides that the batch size can affect the tile sizes in GEMM for router and thereby can cause minor numerical errors on the outputs.

@WoosukKwon thanks for the confirmation, that's also what I see from code.

@WoosukKwon pip install -e . error,how solve it?


properly spec clip rect

"ISSUE2 TBD: Do the clip rects include clip-path and other clipping properties or just overflow clipping?"
@tabatkins and I just discussed this and we think that we should only take overflow clipping into account. That's the only reasonable think for the non-malicous use cases. For the malicious ones we're going to need to do something else entirely anyways since it need to take masks, etc into account (any masked region would count as clipped regardless of what the mask does).
So, the only thing we need here is to remove ISSUE 2 and to find a well-defined definition of "clip rect" for overflow clipping. @tabatkins says he can help with the latter.

Upon further discussion, let's honor overflow and css clipping, but not masking or occlusion.


custom exception (throw)

By default, the language comes with pre-defined errors (such as rangecheck, stackunderflow, typecheck, undefined...).
Yet for specific use cases, the language must offer the possibility to create custom exceptions.
The operator throw should accept a dictionary (or an existing error in case of forwarding) with at least the following members :

name: (stringtype) exception name
message: (stringtype) message
stack will be set automatically by the keyword (as well as type set to "custom")

Internally, the exception is encapsulated inside a custom exception object which references the dictionary

When caught, the ownership of the dictionary is transferred back to the operand stack.
If not caught, the host is responsible of releasing the reference (not sure this is the best way)

implemented


use cython from the host python

TL;DR: It turns out cythonizing the files will prefer a random cython on the bin path to one imported via python since the subprocess.check uses ['cython'] and not [sys.executable', '-m', 'cython'].
And now for the rest of the story:
In digging around why pypy3.7 + 1.7.0 crashes when calling
pypy runtests.py --python
>>> from scipy.stats import qmc
>>> sampler = qmc.Sobol(d=2, scramble=False)

I came across this oddity. Say I do not use a virtualenv, rather I have some python that I want to test locally with scipy. I install all the dependencies, and then start to build. The code that calls cython assumes the one I want to use is first on the PATH. But, since I am not using a virtualenv or a conda env, that might be any cython, not necessarily the one for my python.
It would seem safer to me to use the cython already in the python environment I am testing. Even more so since the checks just before this for the cython version.
This hasn't helped me find the problem with PyPy, but was a nice distraction.

Can you clean that part up?

I cleaned up the whole function to change handling to "string" via universal_newlines=True and allow exceptions to percolate out

if cython is not available in the interpreter
if cythonizing fails

I don't think we need to wrap these exceptions with reworded error messages, what do others think?
I am not sure how to rewrite the comment at the top

For now, this script should be run by developers when changing Cython files
only, and the resulting C files checked in, so that end-users (and Python-only
developers) do not get the Cython/Tempita dependencies.


Big blank space among documentation cardlist

Why is there a big blank space on https://jupyter.org/documentation?

@palewire do you remember if it was like that before?
Well this is why adding before/after screenshots is useful.

@krassowski, this must be a bug in my effort to replace the jQuery plugin with a pure CSS solution. Apologies. I can debug.

It is not clear to me if it was indeed your refactor, or if it was broken earlier too. Maybe we should re-write it to use CSS grid?

@krassowski There's a patch in #491. I would support a grid rewrite. My PR will better standardize the HTML between the two uses of the boxes. I think your proposal would be a good follow up after the bug is squashed.

@krassowski Tho, my quick second thought is that I would love to see #473 merged before taking further CSS refactoring. It's going to make life easier for everyone writing the code to get SCSS into the mix.


0015 replace text with icons

Fixes #15

Currently this looks a bit like this:

Still some more to go to properly highlight valuable systems (> 500,00 credits) and show which have been first-discovered and frst-mapped.


forward logs, metrics and traces to cncf jaeger

https://www.jaegertracing.io/

Not for near future.


fix(cache): Fix caching all pipelines during sync loop.

https://github.com/spinnaker/spinnaker/issues/6788
Tested on local machine. Does not break other flows. The method is only implemented for SQL storage service.

@jasonmcintosh please review and merge the change. Thanks!

Does this also fix the revision history for pipelines in Deck?

I believe the Deck revision history issue was fixed in a previous commit.   This should fix the cacheing issue that appeared as a result of that commit.

I realize it's me again being that guy who asks for changes to PR descriptions and commit messages.  From my reading of the change, it's something like "fix(sql): populate lastModified field in  when loading objects from sql".
And then, explaining what the bigger value of the change is would also help.  It's hard to see from the current text

Fix caching all pipelines during sync loop

what's really happening.  Like, what's the current behavior?  What's the new behavior with this change?  Is there some related issue to link?

The related issue is linked to in the leading comment (https://github.com/spinnaker/front50/pull/1220#issue-1629366675).
@DanielaS12 -- would you mind updating the PR title and adding some additional context to the description as per David's comment above?

The related issue is linked to in the leading comment (#1220 (comment)).
@DanielaS12 -- would you mind updating the PR title and adding some additional context to the description as per David's comment above?

I changed the pr title and first comment with more details.

@jasonmcintosh could you review and merge?

@mergify backport release-1.27.x release-1.28.x release-1.29.x


Folder icons don't display

Folder icons don't display in the file explorer.

These currently don't exist w/in the theme, but will plan to add in a future release. Thanks!

Oh I see, I was just confused by the picture in the README. Great theme by the way!

Oh I see, I was just confused by the picture in the README. Great theme by the way!

Oh you know what... you're right. :) I must have broken them and then totally forgotten. Will try to get a fix out this weekend.

Okay, fixed as of https://github.com/catppuccin/obsidian/commit/813f8854de2c4ebd685fa0947dec88ef1833090a. The icons should now appear if you update the theme.
Thank you for letting me know!


[content] add Caribbean indigenous tribe content

Add content for indigenous tribes represented within the Caribbean region. Other issues cover Canadian, American and Central American regions, as well as modern Caribbean nations.

This is completed to the level desired at this point. Could add more detail as the pre-modern Caribbean nations are added in #157


Introduce the concept of a Context to slowly get rid of CoreRegistry.

Reasoning: The core registry is just like static variables and it prevents
cool stuff like having a client and headless server running in the same VM.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/72/
Build Log
last 5 lines
[...truncated 4381 lines...]
Build step 'Publish JUnit test result report' changed build result to UNSTABLE
[ANALYSIS-COLLECTOR] Computing warning deltas based on reference build #71
Notifying upstream projects of job completion
Setting status of 0a4b47f420da4365ca702b9ef798a3f2dd963d0b to FAILURE with url http://jenkins.terasology.org/job/TerasologyPRs/72/ and message: Merged build finished.

Uh oh, something went wrong with the build. Need to check on that

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/73/
Hooray Jenkins reported success with all tests good!

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/74/
Hooray Jenkins reported success with all tests good!

It would be great if you could summarize the changes in a few sentences as the PR is quite large.
As I see it, a context is set in constructors of various classes and then used to replace the CoreRegistry? Is that the idea?

Tests out OK locally, although yeah I only get the general idea of the PR and the overall goal :-)
Relates to http://forum.terasology.org/threads/making-singleplayer-a-special-case-of-multiplayer.1291
The only module compile error I noted is in TinyEnvironment in PolyWorld, where the CoreRegistry.putPermanently seems to be gone - what would the replacement be?
CoreRegistry.putPermanently(WorldGeneratorPluginLibrary.class, new WorldGeneratorPluginLibrary() {

PolyWorld should be happy with https://github.com/Terasology/PolyWorld/issues/3 merged after. Thanks @flo !
Pinging @immortius and @MarcinSc for further review :-)

@msteiger the long term goal of this pull request series is to get rid of static variables so that it is for example possible to introduce a test mode in which a client connects to a headless server in a single JVM, possibly with configurable delay.
The main change of this pull request is the intrduction of a Context class.
To make the transition smooth the CoreRegistry class and it's most frequently used method "put" and "get" will remain. To make it possible to use either the non static Context object, or the static CoreRegistry methods the CoreRegistry will now internally work with a Context object.
The Context object provides non static put and get methods that equal in it's functionality those of CoreRegistry. The Context objects are hirachical. The TerasologyEngine class and only that class has access to a engine Context object which stores all objects that exist for the whole lifetime of the TerasologyEngine instance. All objects that got previously added to the CoreRegistry via putPermanently will go into that Context. The putPermanently method got removed from CoreRegistry. It got only used by a test of the PolyWorld module that is not yet considered stable.
For it's other states the TerasologyEngine offers now a method to create a child context. If a child context does not find an object then it will look it up at it's parent. Thus all objects that get for example registered during the loading of the game will only be in the child context that lifes as long as the game goes. The next game has a new context and will thus no longer contain the objects that got added to the context of the previous game.
Until the CoreRegistry usage has been removed completly, it will be necessary to set a context for it. During the initialization of the engine it is set to the engine context. Afterwards it is set to the context owned by the game states.
The main focus of the patch is the introduction of the Context object, it is however also removing a bit of CoreRegistry usage as a side effect.

A couple of side questions:
As far as I understand the CoreRegistry only allowed to register one instance per class. Would it make sense for these Context objects to be more flexible, i.e. able to register any object against a simple string?
Also, in line with my recent suggestion of making Config Observable, it would be useful perhaps for these Context objects to be observable too? It would be useful to be informed if a context-held object has been replaced, removed or has even become available.

I'm not sure if Context objects are supposed to be changing, its main purpose is going to be to set the @In dependencies in systems, and mutating those might require a lot of diligence in each system to be able to respond to those changes.

@emanuele3d  I thought about string keys too, but in the end I think it's better to register just one instance per class: It is simple and nice solution (e.g. type savety, no need to enforce name conventions) and if you really need to have multiple instances of a class then you can still register a Manager class that allows you to get instances by string key. e.g. like a AssetManager.
Yes and I agree with @MarcinSc. They are supposed to be static due to their use in @In and the big question what would happen with existing injected classes when you change it later on.

Good point about registering Managers to obtain instances or other types of objects by string.
Regarding the registered objects being unchanging: good to know that's the aim. I'll double-check what I'm doing in renderland to make sure the objects I register do not change.
Thank you both for your replies.

Thanks - sounds good to me.

Bump - @immortius: got a moment to look at this sometime please? :octocat:

Ran my eyes over it. I see no fundamental issues with the approach, but found a couple of areas needing tweaks. Also suggest name change from Context to Registry (or similar), as I feel Registry describes what the class is better, and the contextual nature of it is how it is used - the class itself does not represent a context as such.

I think Context is a good name, as:

you have one instance per context. e.g. server and client context
it contains the objects that makes up the context e.g. the entity manager that belongs to that context
the name context implies that there is another instance per context, which is exactly what I want to express. Just calling it Registry would you make assume that there is just one instance.

I don't really like naming classes by how they are used rather than what they do (List doesn't have anything to say about whether there is one or many of them) and disagree that Registry implies singleton, but not really bothered enough to argue further.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.terasology.org/job/TerasologyPRs/76/
Hooray Jenkins reported success with all tests good!

Any further comments on this or should we go ahead and merge?
I can see both sides on Context vs. Registry. There is only one solution - Google Fight!
http://www.googlefight.com/index.php?word1=context&word2=registry
Context wins by about double and for some reason I'm getting results in Spanish.
Joking aside I really don't want to pick a winner on arbitrary grounds, but as long as work gets done I'm happy :-)


Add chat input bar placeholder delegate

Add chat input bar placeholder delegate which is triggered only if:

placeholder view appeared,
placeholder view visibility changed.

amending this PR as it will be for swift-3 branch. Fixed in there: #396


MCO-838: machineconfiguration/v1: update MCP feature gated field to omitempty

As per api docs around adding unstable fields to stable API versions. I made a mistake and did not set this field as omitempty. The result is client-go on StatusUpdate will always send the field to the API server. The result is a warning passed via the response header bubbled up as below from client-go.
W0419 20:26:02.583321       1 warnings.go:70] unknown field "status.poolSynchronizersStatus"

This change will generate the type as a reference in client-go so a value will not be sent if it is disabled via feature gate.
ref :https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api_changes.md#adding-unstable-features-to-stable-versions

/lgtm


Find a better audio source

Audiosynth doesn't work well on mobile
https://github.com/keithwhor/audiosynth/issues/2
https://github.com/keithwhor/audiosynth/issues/6
maybe: https://tonejs.github.io/

closed by #8