Retry in case of all exception in start method

To avoid formatting changes, have put the try/catch block without formatting

With this change, which does seem to be required, can the changes from https://github.com/yugabyte/debezium/pull/121 be reverted as this will cover those changes as well


[Automation]  REST restart test cases

This needs to be revisited after discussion.
tests/test_openbmc_service_restart_policy.robot
Disabling Test OpenBMC Services Autorestart Policy
The REST services here are hardcoded and will continue to change either in the service name or the policy as per the development perspective untill things are sorted out in REST. On the other hand, we shouldn't be really hardcode this anyway. We don't want to delete, neither add in known issue list. This surely fails each test run, so disabling this test case
Right now this test case is skipped

It can fall between unit test / Functional test.  But user can play with rest service start etc.

Services identified which are mission critical for functioning of the REST and error.
    @{services}=
    ...  Create List  xyz.openbmc_project.Logging.service
    ...               xyz.openbmc_project.ObjectMapper.service
    ...               xyz.openbmc_project.State.BMC.service
    ...               xyz.openbmc_project.State.Chassis.service
    ...               xyz.openbmc_project.State.Host.service

This estimation will need correction is the current review goes through.. Currently put effort of 1 point identifying the changes, coding, testing and re structuring the code..


Updates Simmy and Polly package references.

Hi @reisenberger
I just updated the Simmy and Polly references in order to avoid to broke the project.

Thanks @vany0114 !


Bulk Calendar Edit

Using Chrome Extension v2.3.0
When adding additional events, appears to just keep adding the 7 days to the original entry.
1st was for Feb 1st, second was for Feb 8th, third was for Feb 8th rather than Feb 15th

Thanks I will fix that in the next release.

Completed and ready for next release.


AutoCompleteTag resizes the AutoCompleteInput component

When using multiple prop in AutoComplete, if I choose multiple tags then it resizes the entire AutoCompleteInput component and makes it wider/longer. Can there be a way to solve this?
Alternatively, can we use tags outside AutoCompleteInput and above that component so that it does not resize the parent.

It would be great to have the possibility to use AutoCompleteTags outside the Input. Above or below.

It would be great to have the possibility to use AutoCompleteTags outside the Input. Above or below.

It's done now @wilsonfaustino

@Overdrive141 The alternative is now available, but you can also set a fixed size on the input's width to prevent autogrowing.

Feel free to reopen this if any issues persit. Closing now.


test: workqueue : add testcase to improve coverage

Set work item's flag in pending state, it cannot be append to a
workqueue. Improve branch coverage of function k_work_submit_to_queue().
Signed-off-by: Ying ming<EMAIL_ADDRESS>

I'm not a fan of this sort of whitebox mutation of state; it's why this test can't be used to validate the behavior of a replacement implementation. But given the way the test application is today this isn't wrong.

Thank you for you comment. I got you point. Test cases should not be white boxed. So I have changed my code using more ordinary API.

@pabigot , are you OK with the code now? If yes, please help to approve it.


Width-filling progress bars wrap around on >1 character wide emojis

Consider the example in report #144, modified to use 🖼 emoji which takes up 2 characters in Windows terminals, and modified to use wide_bar to fill the entire screen:
use std::cmp::min;
use std::thread;
use std::time::Duration;

use indicatif::{ProgressBar, ProgressStyle};

fn main() {
    let mut downloaded = 0;
    let total_size = 231231231;

    let pb = ProgressBar::new(total_size);
    pb.set_style(
        ProgressStyle::default_bar()
            .template("{prefix} {msg:.bold} {wide_bar:.blue} ({pos}/{len}, {elapsed}, ETA {eta})")
            .unwrap()
            .progress_chars("█▇▆▅▄▃▂▁  "),
    );

    pb.set_message("🖼 Downloading textures");
    while downloaded < total_size {
        let new = min(downloaded + 223211, total_size);
        downloaded = new;
        pb.set_position(new);
        thread::sleep(Duration::from_millis(1));
    }

    pb.set_style(
        ProgressStyle::default_bar()
            .template("{msg:>12.green.bold} downloading {total_bytes:.green} in {elapsed:.green}")
            .unwrap(),
    );
    pb.finish_with_message("Finished");
}

As can be seen in the screenshots the ) in Microsoft Terminal and the s) in VScode wrap around to the next line, spamming progress bars.
Note that in the VSCode terminal there appears to be no space between 🖼 and Downloading, which is similar to what I observe on Linux (alacritty terminal): the emoji always takes up a single character even if it is rendered in two characters. Not having a space at all (e.g. 🖼Downloading) gets the D rendered inside the picture frame emoji:

(I'm not familiar with the right ways to solve this in a platform-agnostic manner)

Looking at the organization structure here, perhaps this issue should be transferred to:
https://github.com/console-rs/console

Note that the leading space in the screenshot is simply caused by the unused {prefix}  that I forgot to remove while transferring our progress bars to a minimal example.

Note that in both the example and our own code ansi-parsing and unicode-width are turned on on the console crate.

I'm open to reviewing a fix for this, but probably won't be able to do much other work on this. I suppose the style::measure() function might be implicated? Not sure which part is going wrong here, I think (particularly with those Cargo features) we should have code for handling this kind of thing.

Yeah:
#[test]
fn measure_emojis() {
    assert_eq!(measure("🖼"), 2);
    assert_eq!(measure("🧼"), 2);
}

Fails with measure() returning 1. I'm not sure if this is also something that changes with fonts and the renderer, as shown with Windows Terminal padding the emoji to two characters while VSCode does not. I.e. printing:
println!("abcdef");
println!("🖼  🧼"); // Only 2 spaces here

Gives in VSCode terminal:

But in Microsoft Terminal:

Even Windows Console Host adds a third space, despite not being able to render the emoji:


Memory leaks in transpiled classed of JRE Emul

Hello,
our code makes heavy use of classes from java.util.concurrent that appear to be at the origin of important memory leaks in JRE Emul.
One of the memory leaks is in LinkedBlockingQueue, in particular when used by a ThreadPoolExecutor. It is due to a cyclic reference in LinkedBlockingQueue.Node. This is how Instruments visualizes it:

Our guess is that it can be explained with the second use case of next in the following extract of the JDK's source code:
package java.util.concurrent;

[…]

public class LinkedBlockingQueue<E> extends AbstractQueue<E>
        implements BlockingQueue<E>, java.io.Serializable {

    […]

    /**
     * Linked list node class
     */
    static class Node<E> {
        E item;

        /**
         * One of:
         * - the real successor Node
         * - this Node, meaning the successor is head.next <-- Cyclic reference
         * - null, meaning there is no successor (this is the last node)
         */
        Node<E> next;

        Node(E x) { item = x; }
    }

    […]

Another memory leak is in ScheduledThreadPoolExecutor. It is due to a cyclic reference in ScheduledThreadPoolExecutor.ScheduledFutureTask. This is how Instruments visualizes it:

Our guess is that it can be explained by the following extract of the JDK's source code:
package java.util.concurrent;

    […]

    private class ScheduledFutureTask<V>
            extends FutureTask<V> implements RunnableScheduledFuture<V> {

        […]

        /** The actual task to be re-enqueued by reExecutePeriodic */
        RunnableScheduledFuture<V> outerTask = this; <-- Cyclic reference

        […]

We understand that the source code of the JDK is not under J2ObjC responsibility, but is there something that can be done for cases like these?
Thanks in advance.
Best regards.

I think a similar issue was previously fixed in ConcurrentLinkedQueue e.g. in https://github.com/google/j2objc/commit/db259
It looks like a similar solution might work here.

It looks like a similar issue was previously fixed in ConcurrentLinkedQueue e.g. in https://github.com/google/j2objc/commit/db259
Perhaps a similar solution would work here.

Both LinkedBlockingQueue and ScheduledFutureTask are fixed in current source.


proposal for fixing issue 53: 'Exceeding Max Redirects when using a p…

Hello,
this pull request contains a proposal for fixing issue #53.
When requesting "google.com", the response was suggesting to request "www.google.com". While line 134 of index.js was updating _options with values targeting the suggested url ("www.google.com"), _options.header.Host could still contain the previous host ("google.com"), causing an infinite redirection.
The fix proposes to manually ensure that _options.header.Host has the new host value.
All the tests are OK, and you can test the fix with the following javascript code:
var followRedirect = require('follow-redirects');
var http = followRedirect.http;
var urllib = require('url');

var proxy = "http://<IP_ADDRESS>:3128/"; // public proxy
var target = "http://google.com";
if (process.argv.length == 3) {
	proxy = process.argv[2];
} else if (process.argv.length == 4) {
	proxy = process.argv[2];
	target = process.argv[3];
}

var options = urllib.parse(proxy);
var targetOpt = urllib.parse(target);

options.headers = {
	"Host": targetOpt.host
}

options.pathname = target;
options.path = target;

console.log(options);

var req = http.request(options,function(res){
	var body = "";
	res.on('data',function(chunk){
		body += chunk;
	});

	res.on('end',function(){
		console.log("All Donei %d", res.statusCode);
		console.log(body);
	});
});

req.setTimeout(120000, function(){
	console.log("timeout");
	req.abort();
});

req.on('error', function(err){
	console.log(err);
});

req.end();

Best regards,
Jonathan Pastor

Thanks, will investigate and merge. For some reason, #53 hadn't made it to my inbox.

We will need unit tests for this as well.

I added a unit test for this specific issue. Let me know if there is anything to do!

Thanks for pinpointing the issue with #53. Upon closer inspection, this pull request wasn't the full solution, as it relied on a specific capitalization of Host. An updated fix is in 31c82d0b7168a1a038d29e717c197a38c2eea917, together with a local test.


Type guards have strange narrowing behavior when other guard branches exhaust union constituents

module A {
	export const enum Brand {}
}
interface A {
	brand: A.Brand;
	a: string;
}
function isA(value: S): value is A {
	return 'a' in <any> value;
}

module B {
	export const enum Brand {}
}
interface B {
	brand: B.Brand;
	b: number;
}
function isB(value: S): value is B {
	return 'b' in <any> value;
}

module C {
	export const enum Brand {}
}
function isC(value: S): value is C {
    return isA(value) && isB(value);
}
interface C {
	brand: C.Brand;
	a: string;
	b: number;
}
type S = A | B | C;

function test(state: S) {
	if (isA(state)) {
            // works: state is A
	} else if (isB(state)) {
            // works: state is B
	} else if (isC(state)) {
            // works: state is C
	} else {
            // hey, state is A again! how come?
	}
}

@tinganho wanna take a look?

@mhegazy  I will take a look.

This is not a type predicate issue, this applies to all type guards:
var x: boolean | string | number;

if (typeof x === "string") {
    // string
}
else if (typeof x === "number") {
    // number
}
else if (typeof x === "boolean") {
    // boolean
}
else if (typeof x === "string") {
    // string
}
else {
    // ...number?
}

thanks for narrowing down the problem, interestingly if the last possible cases isn't explicitly typeguarded it gets deduced correctly

if (typeof x === "string") {
    // string
}
else if (typeof x === "number") {
    // number
}
//else if (typeof x === "boolean") {
//    // boolean
//}
//else if (typeof x === "string") {
//    // string
//}
else {
    // boolean as aexpected
}

The root cause is that it narrows down to 1 type. There is nothing that handles if the narrowing type is the same as narrowed type by an if clause.
if (isA(state)) { // narrowed to A again
}
else if (isB(state)) { //  narrowed to A
}
else if (isC(state)) { // narrowed to A | B
}
else { // type begins with to A | B | C
     state // is A
}

we could probably just add one check for it:
if (isA(state)) { // isA(...) returns A and the narrowing type has the value of A so snap back to A | B | C
}
else if (isB(state)) { //  narrowed to A
}
else if (isC(state)) { // narrowed to A | B
}
else { // type begins with to A | B | C
     state // is A | B | C
}

Also instanceof doesn't seem to narrow the type correctly :
class A {
	a: boolean;
}
class B {
	b: boolean;
}
class C {
	c: boolean;
}

let s: A | B | C;
if (s instanceof A) {
	s.a;
}
else if(s instanceof B) {
	s.b;
}
else {
	s.b;// type is A | B | C, should be just C
}

http://www.typescriptlang.org/Playground#src=class A {
	a%3A boolean%3B
}
class B {
	b%3A boolean%3B
}
class C {
	c%3A boolean%3B
}

let s%3A A | B | C%3B
if (s instanceof A) {
	s.a%3B
}
else if(s instanceof B) {
	s.b%3B
}
else {
	s.b%3B
}

@aleksey-bykov it probably makes more sense with void.

hm.. i think there might be something in the specs that clears this out

@tinganho See #1719 re: instanceof not affecting else blocks

I just submitted a PR to handle void narrowing.
I'm just wondering how to handle the case when dealing with distinct types(not union types).
let x: number;
if (typeof x === "number") {
}
else {
      x// is what? void?
}

Though, I think it would mean walking up the parent for every variable, if we support distinct types as well.

I'm just wondering how to handle the case when dealing with distinct types(not union types).

TLDR: should be void
Isn't a distinct case just a special case of a union of one? If so, then void in the else block is quite expected. More to that, if you think about it, what else can it be? It's declared to be of a certain type and this is what we just asserted. According to its declaration it cannot be anything else. So the else block is technically unreachable and doesn't make sense, because the clause always holds true as long as the type system is sound. I'd suggested to disallow such if statements altogether due to lack of sense they make.

This is fixed in 1.8. When the union is exhausted, the original type is used instead.


Group right side of the JOIN in one field

Scenario
Imagine you have two tables, posts and comments, with the following structure:
create table posts (
  id serial,
  title varchar(100) not null,
  description text,
  likes integer default 0,
  dislikes integer default 0
);

create table comments (
  id serial,
  post_id integer,
  text varchar(240),
  likes integer default 0,
  dislikes integer default 0
);

To get the post and all comments in the same request, you have to do something like this:
/database/schema/posts?_join=LEFT:comments:posts.id:$eq:comments.post_id

The problem

For each comment, we have the post data again.
The values of ID, likes, and dislikes of the post, are replaced by the comment data.

Solution
Create on flag _group_table_fields to group the right side of the join and return something like this:
{
  "id": 1,
  "title": "my post",
  "description": "...",
  "likes": 102,
  "dislikes": 13,
  "comments: [.....]
}

It will be nice to use this feature. Any plans to implement?

do you have any further updates


Docs improvemens: Overivew renaming and pre change transformers

This PR addresses #410.
Changes:

Rename the section "Overview and philosopy" to just "Overview"
Add docs section on pre change transformer in the variables tutorial
Minor nit fixes

:D I also tried to address #410
see: https://github.com/unity-atoms/unity-atoms/pull/413
I first thought of taking the best of both worlds, I like that you added pictures (as I did not), but my changes are a good amount larger, so it's not super easy to take both changesets.
I reviewed your changes and have nothing against it, but I will wait with merging until you took a look onto my changes, maybe you find a thing or two you like.
e.g. I created a whole page for pre-change-transformers, and added a code example to how to create one on your own (sure, there is already the ClampInt provided by the library and people could look into that, but i feel people would more likely look into the documentation than into the source code)
also, I added a philosophy page and a page explaining tags.
I feel we could probably take both PRs. E.g. starting with yours and then taking mine where applicable (or vice versa)

Prefering #413


Add auto migration timeout db factory option

Add an optional auto migration timeout so that consumers don't need to wait indefinitely for long running migrations.

Just curious, what's context?

Was seeing super long automigrations -- on the order of an hour -- happening in hub:
2023/04/16 22:47:30 /src/vendor/gorm.io/driver/mysql/migrator.go:32 SLOW SQL >= 200ms
[2816404.211ms] [rows:0] ALTER TABLE `containerreplica` MODIFY COLUMN `kind` longtext

The takeaway was that it would be nice to fail much earlier in these cases.


Hash change event not firing

Stencil version:
 1.8.1

I'm submitting a ...  (check one with "x")
[x] bug report
[ ] feature request
[ ] support request
Current behavior:
When using hashchange listener with historyType="browser" the event is not firing:
<stencil-router historyType="browser">
...
</stencil-router>

private hashChangeHandler(): void {
window.addEventListener('hashchange', (e) => {
      console.log(e)
    })
}

Expected behavior:
even if i use the browser navigation the hashChange listener should work
Steps to reproduce:
Just start a Stencil application with stencil router and navigate programmatically on a route with an hash and add a hashchange listener.
Thank you for your work.
Romeo Nupieri

I'm on the same boat. In the mean time if you want you can just use a regular a tag as it won't cause a page reload if your just updating the hash


feat: serve a JSON schema from website

Summary
I have zero clue if this is gonna work or not 😅 If it does work though, this closes #11963

Test plan
Verify deployment preview

I'm not allowed to see the logs if the deployment 🙈

Just to add, some time ago I was playing with typescript-json-schema. It was able to take a plain TS interface and emit schema. All options of istanbul-reports were included in the schema. Or at least it seemed so. To make sure, I went on writing tests for the schema. That was overwhelming amount of work and this is where I gave up (;

Perhaps it would make sense to add schema URI to documentation? I mean, simply to use it in the JSON config example:
{
  "$schema": "https://jestjs.io/schema.json"
  "bail": 1,
  "verbose": true
}

I think $schema is supposed to be the version of the JSON schema spec it's following?
I added a self link in https://github.com/jestjs/jest/pull/14792/files#diff-cf140d6648a6d236a6a5ce32888aa504827a65dd89139174ec30e7da8db128a4R23


Fix select height

Added a maximum height to select content field.
This fixes #6

BTW, seems to be working today on laptop, external monitor, and both browsers (Chrome, Firefox).  Thanks, @devnoot !


[Test-Only] Add test for adding and removing user to group

Related Issue: https://github.com/owncloud/ocis-ocs/issues/33
Add OCS API HTTP integration tests for ocs api endpoints

List groups for a user
Add user to a group
Remove user from the group

 Here is an overview of what got changed by this pull request:

Clones added
============
- pkg/server/http/svc_test.go  69

See the complete overview on Codacy

 Here is an overview of what got changed by this pull request:

Clones added
============
- pkg/server/http/svc_test.go  68

See the complete overview on Codacy


Update PATRIC publication list

It seems outdated and missing pubs from last year.
https://www.patricbrc.org/content/publications

updated & deployed on production.


[eas-cli] only allow autoIncrementing for managed projects

Checklist

[x] I've added an entry to CHANGELOG.md if necessary.
[ ] I've tagged the changelog entry with [EAS BUILD API] if it's a part of a breaking change to EAS Build API (only possible when updating @expo/eas-build-job package).

Why
We want to only allow auto incrementing for managed projects.
There is a desire to allow it for "simple" BARE projects as well, but what simple means is still under discussion. Also it seems like there is some desire to extend autoIncrementing to simple bare projects only after we work out any kinks with autoIncrementing in a purely managed context.
See slack thread here for more: https://exponent-internal.slack.com/archives/C013ZK4SA12/p1631901018090000?thread_ts=1631784624.081100&cid=C013ZK4SA12
How
Added validation.
Test Plan
Tested in demo repo, both bare and managed.

Thanks for the feedback and discussion!
To summarize what I understand:
There is a PR coming: https://github.com/expo/eas-cli/pull/635 that allows us to support multiple info.plist in iOS so this PR is unnecessary.
However, since support for multiple flavors in android is not currently planned, we will be throwing when trying to auto-increment an android project with multiple flavors.


Adds Asset Checker safety net

Project URL
https://github.com/s4cha/AssetChecker
Description
This adds AssetChecker script to the list of tools
Why it should be included to awesome-ios (optional)
While solutions like Misen or SwiftGen are great they generate extra swift structs and moves us aways from Apple solution aka image literals. They solve one issue: code breaks when asset disappears, because the corresponding struct does as well. This script does exactly that, while enabling us to use the great and very readable image literals :) Plus it warns when an Asset is not used in the code, great for cleaning long lasting projects.
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 or later
[x] Supports Swift 3
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Error

:no_entry_sign:
Found 3 link issues

Link issues by awesome_bot

Line
Status
Link

1311
404
https://github.com/bugfender/BugfenderLive-iOS

2135
301
https://github.com/krzysztofzablocki/Insanity redirects tohttps://github.com/krzysztofzablocki/Sourcery

2358
504
http://wanderbit.us4.list-manage.com/subscribe?u=4e20cd8ea3a0ce09ff4619a52&id=5898a5992b

  Generated by :no_entry_sign: danger


Linker scripts are wrong as they place SRAM into DTCM regions.

The linker scripts mark start of the RAM to 0x2000000 which is where DTCM is placed, for example for the STM32F767, the SRAM1 starts at 0x2002000 and then there is the small SRAM2 further in the memory. This way the data is placed in the wrong memory region and also a significant portion of SRAM is unused.
So if the DTCM can be used as a regular RAM, the sizes should be expanded accordingly, or the start of the RAM region should be moved to the correct SRAM addresses. As of now I propose fixing the addresses to match SRAM.
Can some of the community's embedded wizards please maybe shine a bit of light into the correct mapping? @japaric @jonas-schievink Thanks!

I imagine the linker scripts were written this way for simplicity - viewing SRAM as one contiguous blob. Perhaps enumerating the different SRAM bank types could allow for more advanced placement of data, but I can't think of an example...when would the DTCM region not be used as regular RAM?

I am not really sure as I am not that experienced developer. However, some quick search showed problems with DMA and ethernet peripherals. E.g. here https://community.st.com/s/article/FAQ-Ethernet-not-working-on-STM32H7x3 .

Interesting, thanks for providing some context! This does seem like a more advanced use case.
My concern is that if the linker scripts were changed to enumerate the different banks and place different regions into these banks, a user may run out of RAM quickly and not understand that other regions are available. Maybe there is a way to avoid that though with the linker file or build.rs.

This was fixed in https://github.com/stm32-rs/stm32f7xx-hal/pull/156, so the issue could probably be closed.

Thanks, @systec-ms.


Token staking for listings: contract + Origin.js work

To incentivize legitimate and helpful behavior for sellers, we are going to experiment with one or more forms of staking Origin tokens for listings.
This task is for the contract and Origin.js API work, which are likely to be closely linked.

I would like to work on this issue

Thanks for your interest, @gauravsavanur07 🙏 This task will require some discussion and planning from other members of the team, and it's not as much of a priority now as it was in August. Please feel free to share any thoughts or suggestions here, but it might be better to check out some of the "good first issue" tasks instead.


Fix typo

That would work as well. If that matches the site structure better, I’ll change it.
On Nov 7, 2018, 3:37 AM -0500, Thorsten Lünborg<EMAIL_ADDRESS>wrote:

@LinusBorg commented on this pull request.
In<EMAIL_ADDRESS>
@@ -3,7 +3,7 @@

{{ msg }}

-      For guide and recipes on how to configure / customize this project,
+      For guides and recipes on how to configure / customize this project,
The docs site only has one "Guide" secion, so I think singular is fine. Would
> For a guide and recipes ...
be better?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


PyBind GoldenTensor w/ Integral Types (#1294)

This change introduces a PyBound class GoldenTensor that reflects the same type from TTRT. This binding supports the following element types for a GoldenTensor:

uint8
uint16
uint32
float32

Closes #1294

Context for revert: @ctodTT and I noticed that using the python file line and column as the location results in many of the decomposed ops from TTIR to have that loc appended to it, while use a global id does not (we don't know why yet). This results in ops that shouldn't be doing golden eval (eg to_device op) doing golden eval on the callback. The commit has been reverted while this issue is investigated.


Json file content will be corrupted if mydig instance is killed in the middle of writing file

acquire file write lock
write to file.new
acquire replace lock
rename file to file.old
rename file.new to file
release replace lock and write lock
remove file.old

when starting:

if both file.new and file.old exist, ignore file.old and rename file.new to file (shut down in the middle of replacing, file.new is complete)
if only file.new exists, error (user deletion)
if only file.old exists, error (user deletion)
if only file exists, correct.
if both file.new and file exist, ignore file.new (shut down in the middle of generating file.new).
if three of them exists, error (user operation, system error)

need a timestamp when adding a new task for dumping data (ignore data if timestamp is older then previous)


Light Kardo Band (feat. Aastha Gill) by Badshah unsupported.

Add support for Light Kardo Band (feat. Aastha Gill) by Badshah. Check if issue with swaglyrics or song lyrics available on Genius.

Lyrics not on Genius.


Upstream K8s conformance test "Services should have session affinity timeout work for service with type clusterIP" is flaky

Describe the bug
"Services should have session affinity timeout work for service with type clusterIP" seems to be failing 30% of the time, both in CI and in my Vagrant-based test environment.
This is after merging https://github.com/vmware-tanzu/antrea/pull/1576. Before that, the test was consistently failing all the time.
To Reproduce
Deploy the latest version of Antrea and run the test using our helper script (or with sonobuoy directly): ./ci/run-k8s-e2e-tests.sh --kubeconfig $KUBECONFIG --e2e-focus "Services should have session affinity timeout work for service with type clusterIP"
Expected
Test should pass.
Actual behavior
Test fails about 30% of the time.
Versions:

Antrea version: ToT
Kubernetes version: 1.19.4

When looking at the logs it seems that SessionAffinity is not enforced correctly. An investigation reveals that "Services should have session affinity work for service with type clusterIP" actually suffers from the same issue (confirmed from the logs). However that test consistently succeeds.
Here is a look into what happens: in OVS learning is done by the userspace daemons, which means there is a delay between the actual learning action and the datapath flow cache being updated. Now if we look at the upstream K8s conformance tests for SessionAffinity, they do the following: 1) check for Service connectivity from client Pod, 2) generate 15 back-to-back connections to the Service from the client Pod, 3) verify that for all 15 connections, the selected endpoint is the same.
Based on the logs, it seems that the delay between 1) and 2) is roughly 200ms (on my testbed and for the CI testbed at least). Apparently this delay is not sufficient for the datapath flow cache to be fully updated:
When learning works as expected
 cookie=0x1040000000007, duration=2.248s, table=40, n_packets=17, n_bytes=1258, hard_timeout=10800, priority=200,tcp,nw_src=<IP_ADDRESS>,nw_dst=<IP_ADDRESS>,tp_dst=80 actions=load:0xa0a016d->NXM_NX_REG3[],load:0x24a0->NXM_NX_REG4[0..15],load:0x2->NXM_NX_REG4[16..18],load:0x1->NXM_NX_REG0[19]
 cookie=0x1040000000007, duration=8.777s, table=41, n_packets=1, n_bytes=74, priority=190,tcp,reg4=0x30000/0x70000,nw_dst=<IP_ADDRESS>,tp_dst=80 actions=learn(table=40,hard_timeout=10800,priority=200,delete_learned,cookie=0x1040000000007,eth_type=0x800,nw_proto=6,NXM_OF_TCP_DST[],NXM_OF_IP_DST[],NXM_OF_IP_SRC[],load:NXM_NX_REG3[]->NXM_NX_REG3[],load:NXM_NX_REG4[0..15]->NXM_NX_REG4[0..15],load:0x2->NXM_NX_REG4[16..18],load:0x1->NXM_NX_REG0[19]),load:0x2->NXM_NX_REG4[16..18],resubmit(,42)

When the test fails:
 cookie=0x1040000000007, duration=4.185s, table=40, n_packets=17, n_bytes=1258, hard_timeout=10800, priority=200,tcp,nw_src=<IP_ADDRESS>,nw_dst=<IP_ADDRESS>,tp_dst=80 actions=load:0xa0a015a->NXM_NX_REG3[],load:0x24a0->NXM_NX_REG4[0..15],load:0x2->NXM_NX_REG4[16..18],load:0x1->NXM_NX_REG0[19]
 cookie=0x1040000000007, duration=9.564s, table=41, n_packets=14, n_bytes=1036, priority=190,tcp,reg4=0x30000/0x70000,nw_dst=<IP_ADDRESS>,tp_dst=80 actions=learn(table=40,hard_timeout=10800,priority=200,delete_learned,cookie=0x1040000000007,eth_type=0x800,nw_proto=6,NXM_OF_TCP_DST[],NXM_OF_IP_DST[],NXM_OF_IP_SRC[],load:NXM_NX_REG3[]->NXM_NX_REG3[],load:NXM_NX_REG4[0..15]->NXM_NX_REG4[0..15],load:0x2->NXM_NX_REG4[16..18],load:0x1->NXM_NX_REG0[19]),load:0x2->NXM_NX_REG4[16..18],resubmit(,42)

Notice the packet counter for the learning flow (1 in the first snippet, 14 in the second one).
So why does "Services should have session affinity work for service with type clusterIP" consistently pass?
This is because the test retries for a few times, with a couple seconds between each try, and it is basically guaranteed to succeed on the second try. For this test, the SessionAffinity timeout is 10800s, which means that all 15 connections on the second try will go to the same endpoint. However, for "Services should have session affinity timeout work for service with type clusterIP", the timeout is 15s, which is less than the interval between the successive tries. So the same issue pretty much keeps repeating itself.
Possible solution:
The max default revalidator interval in OVS is 500ms, which means it can take up that time for the datapath flows to be updated and the learned flow to take effect. This setting can be adjusted using ovs-vsctl set Open_vSwitch . other-config:max-revalidator=<X>, where the minimum value for X is 100ms. I tested locally on my testbed with a delay of 200ms, and the test was passing consistently. Beyond just passing the test, 200ms would help reduce of users running into issues in production because they expect SessionAffinity to take effect "immediately", which is not possible when using learning in OVS. On the other hand, decreasing the interval too much would risk increasing CPU usage for ovs-vswitch beyond what's acceptable. 200ms seems like a good compromise, without too much risk of a significant performance impact.
It's likely that an iptables-based implementation (using the recent module) does not suffer from a similar issue, as there is no delay in that case and all packets from the same source after the first one will be sent to the same endpoint.
Big thanks to @blp and @YiHungWei for their help with this issue and for pointing me to the flow revalidator.


Add/verify support for other shells

Currently only ZSH has been tested

It seems like the first step would be to add an argument to the init subcommand to indicate the shell, right? Do you have a preference of how that is then propagated to the default invocation that generates the prompt? It looks like Starship sets the STARSHIP_SHELL environment variable, but it seems like one could also just include the name of the shell as an argument.

Totally agree with you, and great to know how Starship handles this. I think either an environment variable like that or a CLI argument could work here 🤔


Remove the proc keyword from the language

Rendered

A little off-topic, but it seems be is still a keyword albeit being removed long time ago in rust-lang/rust#2227.

Sounds good to me! I think the fact that proc is still there was basically an oversight.

@kennytm  be is reserved word...

Thanks for the RFC! We talked about this today and we think this is fine to do, but it doesn't necessarily need an RFC. Feel free to submit a PR implementing this!


Updated release version of values.yaml to 4.2.stable from 4.1.stable

Current version of 4.1.stable is causing issues within scaler & updater pods. Update pod is unable to find version 4.2.X and results to a STABLE channel of NONE.

Thanks for the PR!


[DeusVault] Update sheet to v0.6

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

Change legacy to false in the sheet.json.
Update sheet to v0.6 of the rules version.

Merge masteries and talents
New skill check formula

Character Sheet Info Roll20 Internal Use only.


chaincode_example02 using C

init, query, invoke and delete function
custom malloc as clang doesn't support system calls
command to compile C to wasm using clang in readme

Resolves #17

Can we hook this in to the existing tests?

Will do. I have one change stashed in local with renaming invoke to execute. Let me create that PR first and then I will add this.
Shall I add it in same wasmcc unit test(that test runs rust wasm) or is it better to make it as part of integration test?

Depends on what it needs? I expect it to test similar to the rust test. Which I think I now realize is simply loading.
Both rust and C should be part of the integration test.
For this PR, a unit test should suffice. The integration tests should be a separate change.

Added unit test case

Added unit test case

uh-oh!! need to install clang in github workflow


2.4 RC1: onInputUp isn't passed the button any more?

this.events.onInputUp.add(this.onMouseUp, this);
this.onMouseUp = function(object, pointer) {
        console.log(pointer.button);
}

in 2.3, this logs the button that was released. in 2.4, it doesn't

It never actually did it properly though! So to avoid any confusion I have removed the properties entirely and updated the jsdocs to explain what you should actually be using now (pointer.leftButton, etc)

Perhaps this was closed too early:
this.events.onInputUp.add(this.onMouseUp, this);
this.onMouseUp = function(object, pointer) {
        console.log(pointer.leftButton);
}

Logs:
false

I realize that after the mouse has gone up no button is being pressed, but how can I read the button that was released to trigger the mouseUp event?

pointer.event.button - but there is no guarantee the event is fired because just one button went up, so never rely on it (it's why the 2.3 implementation is completely wrong, as it relied on that dom event property for everything, when it should really have been using the buttons bitmask instead).

Perhaps I am misunderstanding you, but the pointer that's being passed to my handler does not have a pointer.event, let alone pointer.event.button

I think I just found a workaround: If I collect the active pointer's left/right/middleButton values every frame and then compare those stored values to the one in the pointer I'm being passed in the event handler, I can suss out which one(s) have changed. I'm not sure it's a clean solution (the added overhead from updating a few bools shouldn't matter, but I don't know if there is a chance that the timing could be such that the update function would already have set the button flag to false before the handler is started?)
workaround implemented with 2.4 rc1: http://jsfiddle.net/fpds924d/4/

update: this technique also works in my actual project.

update 2: it DOES happen from time to time that the global variables have already been updated when the event handler starts, so I occasionally get the weird and wrong behaviour, perhaps one in a hundred drag events.
So I'd still really appreciate an ironclad, built-in way to check which button triggered the onInputUp event, if such a thing is possible with the current system

further experimentation reveals that a separate browser event is dispatched for every released button, and the event.button property contains the button that was released (0, 1, 2 for LMB, RMB, MMB). so if you release two buttons at the same time, you get two events. event.buttons always seems to contain the current status of what's pressed and what's not, which in the case of a mouseup isn't very helpful. I think you shouldn't necessarily use the buttons bitmask for everything and the button property for nothing, and it doesn't sound like the 2.3 implementation was all wrong after all! The button property certainly shouldn't be removed, and the docs should be updated to reflect the actual contents of button vs buttons.

(at least, that's how it works in chrome.. IE is a whole different thing apparently?)

I've amended Phaser.Pointer.prototype.updateButtons with the line this.button = event.button;, and now I can check the pointer that's being passed for which button was released. woot! :)

All of the Pointer booleans (leftButton, etc) have been replaced with the new DeviceButton class. These objects have their own signals (onDown, onUp), isDown, isUp, duration properties and things like justReleased.
They are always updated before any of the Pointer signals are dispatched.
So you can now easily check the state of a specific button in a global onInputUp event.
What I'm now considering is that Pointer.stop shouldn't be processed at all if ANY of the buttons are still down. For example it sets things like the timeUp value, etc - but it's misleading imho. I do think those properties probably ought to move to the DeviceButton class itself.

Cool!
I still think you're underestimating the usefulness of event.button, especially for mouseUp, but it's exposed in the pointer and that's all I need ;) Thank you!

Added the mouse consts back in for comparison. Now happy with the way this works so closing off.


feat: config-ui - register new providers azure bitbucket and gitee

Config-UI / Data Provider Integrations 🆕

[x] Azure
[x] Bitbucket
[x] Gitee
[x] Add SVG Assets
[x] Create & Register Transformation Settings Components
[x] Update Data Sources List
[x] Update Connection Manager All Connections List
[x] Update Menu Configuration

Description
This PR registers new Data Providers Azure, BitBucket and Gitee on Configuration UI so feature development can continue. Additional changes to these provider settings will need to be made on related development tickets.
Does this close any open issues?
Closes #3373
Screenshots

It looks like there will be some conflict with https://github.com/apache/incubator-devlake/pull/3371. Let's do more changes only after these two PR merged.


Delete comment in files

Hello Sir! im new in here, i see the issues for deleted comment in many files, if i got wrong im really sorry, i try for PR for hacktoberfest, thank you
Description
Delete comment in files
Fixes #
I delete comment in

lib/providers/books.dart
lib/screens/auth/confirm_email.dart
lib/screens/auth/forgot_password.dart
lib/screens/auth/register.dart
lib/screens/auth/reset_password.dart
lib/screens/book_desciption.dart
lib/screens/bookshelf.dart
lib/screens/dashboard/quotes.dart
lib/screens/home.dart
lib/screens/initial_screen.dart
lib/screens/user_preferences.dart
lib/services/auth.dart
lib/services/database_services.dart
lib/widgets/auth/social_media_handles.dart
lib/widgets/button.dart

Hello Sir! im new in here, i see the issues for deleted comment in many files, if i got wrong im really sorry, i try for PR for hacktoberfest, thank you
Description
Delete comment in files
Fixes #
I delete comment in

lib/providers/books.dart
lib/screens/auth/confirm_email.dart
lib/screens/auth/forgot_password.dart
lib/screens/auth/register.dart
lib/screens/auth/reset_password.dart
lib/screens/book_desciption.dart
lib/screens/bookshelf.dart
lib/screens/dashboard/quotes.dart
lib/screens/home.dart
lib/screens/initial_screen.dart
lib/screens/user_preferences.dart
lib/services/auth.dart
lib/services/database_services.dart
lib/widgets/auth/social_media_handles.dart
lib/widgets/button.dart

@hilmykun There was only 1 issue that was regarding deleting the fully commented files if you read the description of that issue: https://github.com/Project-Easter/Flutter-UI/issues/47
Also, it has been allotted to someone else, so please avoid making PRs for the issues which have not been assigned to you, and make sure to follow the updated README guidelines.


Enhancement: Minimap position highlight

VSCode Version: 1.10.0-insiders (2017-02-24)
OS Version: Windows 10

I have some enhancement requests for the current minimap implementation which are already available in Atom as separate plugins.

Enable the minimap in latest insider build and position your cursor in the editor. The minimap does not highlight (ligh grey background) your current position unless you hover over the minimap. I would like this highlight to be enabled at all time.

This should probably be added as an extra editor setting.

Add CSS color display in the minimap, this is available in Atom as a separate plugin minimap-pigments which I find very convenient.
Highlight the text in the editor would also highlight the text in the minimap. This is only available in Sublime Text and has a white background (instead of grey).

Out of the three requests, the number 1) is the most wanted.

I think 3 is the one I mostly use - so easy to find or find and replace when you can see the highlights in the minimap - as long as they are very visible (strong contrast) - in atom and sublime the highlights are not nearly as visible as they should be, it's too easy to miss them in the syntax colors...

if minimap is enabled AND with the behavior fixed as @ghiscoding suggested, we don't need that slim default bar, minimap replaces it

Request 1 (always show the viewport on the minimap) is now being tracked at https://github.com/Microsoft/vscode/issues/21784. Request 3 seems to be a partial duplicate of  https://github.com/Microsoft/vscode/issues/20934 ("editor selection" is one of the things asked for in that issue). Request 2 does not have any duplicates that I could find.

I would like it when the current line is also highlighted in the minimap.

I'm very surprised there is no highlight on minimap - guess will STILL stick with atom.io for now.

Request 3 is a feature that exists in Atom, at least via third-party packages. In my opinion, that is very much needed and without that the utility of the minimap is questionable at best. Hopefully they will implement this feature soon.
In the meantime, I'll still be sticking with VScode instead of atom as I totally love the git integration in VScode, including the diff feature and due to the search feature being in the sidebar rather than editor window.

I quickly hacked together a rudimentary implementation of Request 1 and 3 at https://github.com/abhijitvalluri/vscode/commit/a1f2d2fdb63eba1838922dae3f10131b289d42ae
For request 3, I couldn't yet figure out how to highlight just the precise token corresponding to the word that is highlighted. So, instead I decided to highlight the entire line. In my opinion, this is probably a bit better as it is easier to see the whole line light up instead of just the word, which will be much smaller and harder to spot.
Example screenshot:

You could take that code, modify it and make your own custom version of vscode. And if you can make it nicer still go ahead and send in a PR!

Made some improvements to the minimap highlight implementation: https://github.com/abhijitvalluri/vscode/commits/minimap_enhancements
Right now, all the implementation details are hardcoded, including it being set up for a dark theme. Also, there is a bug wherein if the file is too large, so that the minimap scrolls and does not fit entirely in one view, then only highlights for the portion of the file that is visible in the minimap works. Once you scroll, there are no highlights for the invisible part of the file in the minimap.

@alexandrudima do you think it would be possible to use/merge the code provided by @abhijitvalluri for the number 3. that I have in the list

Highlight the text in the editor would also highlight the text in the minimap. This is only available in Sublime Text and has a white background (instead of grey).

My code may not be in a good shape for merging. So, I can clean it up if needed so that these changes can be made use of in vscode! Do let me know.

The number 1) from the list has now been implemented Minimap: add a alwaysShowViewport setting - 21784. A new setting will available in the June version. "editor.minimap.showSlider": "always"

+1 would like to get Request #3 implemented. Migrated from Atom and finding it horribly inefficient to hav no word highlighting in the minimap.

Is there already a ticket for the minimap word highlights? I've seen it mentioned in a few tickets but it was always mixed with other things for the minimap.

I need this too

Unfortunately, minimap seems to be very low on the priority list (if not forgotten).

Tweeted to Visual Code and we need a bigger push for this feature just fyi

Someone needs to make a case to the big wigs, because it honestly will improve aggregate employee effectiveness over a known interval of time because all you have to do is double click words and look at the minimap to see if further action is needed.
This increases maximum potential actions over the known interval by minimizing mental and physical boilerplate associated with finding or confirming keyword instances without using the minimap. It is an inversely proportionate relationship. As time spent analyzing increases, file changes per second decreases. Multiply this by the number of Microsoft employees and the cost-benefit ratio warrants the potential gain in sprint velocity.
This upgrade saves unnecessary trips to CTRL+F to iterate through results, and allows you to confirm if keyword placements are present or missing at known locations in the file with an average time-to-completion of 0.5 to 2 seconds with minimap and 5 to 10 seconds with CTRL+F.

Thanks @agm1984. Hopefully, more people will tweet/comment for this feature to make it to next release. Honestly, this is the one feature that keeps me from using VScode as my sole editor, double clicking on a word and seeing it sprinkled throughout the minimap is an amazing thing :)

By the way, I recently looked into rebasing my above hack to enable highlighting for newer builds of vscode. Sadly however, it looks like the underlying code changed by quite a bit and I have not figured out how to redo the same changes on the latest code base. But if it was doable then, it should be doable now, and it OUGHT to be doable by the vscode devs.

If the Vote for popular feature requests listing is any indication of how the team prioritize their work then we have much to lament. This issue in particular is currently on the 3rd page, behind popular requests such as Offline spell checker, Transparent window and A portable version of the app.

How is a transparent window more important than this!!? Sheesh, people want eye-candy more than actual features that are useful for productivity! :(

I'm still using Atom even though is painfully slow sometimes, just because I'm so used to minimap highlighting, it saves me a lot of time for analyzing code. Really cant believe that such a basic feature is still not implemented.

@zemzela I'm doing the same thing. I have Atom open and basically using it as my main editor until I need to use the awesome debugger in VS Code. Hopefully if we keep the conversation going on this topic the good peeps at VS Code will give us this much needed feature. Maybe re/tweet them more to show that the community cares about this feature.

Oh, I really want it!

Minimap word highlighting is the only feature I desperately miss from Atom. Almost a dealbreaker, +1 for giving this feature request higher priority.

Would love these features added. Currently the minimap provides no useful information until these features become available.

The team really go by number of votes before working on these issues. So the best we can do is up vote and wait patiently :|

Progress on this?

I am another one who comes from Atom I guess... and what I really liked also is the git integration in the minimap (yellow line in the minimap for a modified line for example). For now, the minimap is kind of useless without this and the highlight feature.

@bcbane not that I know. It is too bad. I do feel like it is a big missing feature. Also, don't know if there are any extensions that could bring this kind of functionality.

I am still patiently waiting for this feature. It was the first thing I
noticed when I switched over from Atom, and my days have been filled with
crippling sadness due to this lack of mini-map highlight. It would be so
amazing if highlighted words were visible at a glance. The real value comes
in when the highlighted words are off the screen. You know exactly where
they are and can zoom to them by clicking on the mini-map.
On Fri, Sep 21, 2018 at 10:29 AM Juan<EMAIL_ADDRESS>wrote:

@bcbane https://github.com/bcbane not that I know. It is too bad. I do
feel like it is a big missing feature. Also, don't know if there are any
extensions that could bring this kind of functionality.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/21404#issuecomment-423613072,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ1ls6qClO34Vf5wUCmSwKcMOID8vStZks5udSHigaJpZM4ML4SV
.

--
Adam Mackintosh
p:<PHONE_NUMBER>
e<EMAIL_ADDRESS>The contents of this email message and any attachments are intended solely
for the addressee(s) and may contain
confidential and/or privileged information and may be legally protected
from disclosure. If you are not the intended recipient
of this message or their agent, or if this message has been addressed to
you in error, please immediately alert the sender
by reply email and then delete this message and any attachments. If you are
not the intended recipient, you are hereby
notified that any use, dissemination, copying, or storage of this message
or its attachments is strictly prohibited.

A year later, I still want this feature...

As a previous atom fan, I really want this...

Me too! I hope the devs prioritize this at some point!

Actually I am starting to thing that it may be redundant with the scrollbar, which does more or less what we want with the minimap. What do you think ? At least, it may be why they do not prioritize this feature :-/

The scrollbar feature helps, but it's not the same. You still have to look around in which column the marked characters are, while in atom and sublime, you just know exactly where to look. It's something that I really miss once I got used to it, even with the scrollbar markup.

As with the others, I too really miss this feature from Atom. It quickly communicates exactly where in the document (vertically AND horizontally) the highlights are located. In addition to what others have said, the current highlighting in the scrollbar is not a good experience because the minimap slider and the scrollbar are often in difference places. So if you use the minimap slider to scroll to the highlights (either visually or click 'n dragging), you're gonna have a bad time.

This feature would be incredibly useful for me as I work in Haskell and it's really difficult in large files to find all the references. Also, I've heard and seen some people talk about combining the thin scroll bar with the minimap scrollbar, and I think that is a great idea. There is currently a little bit of mismatch between the two and it would be great to unify them.

This feature is super useful when Cmd-D selecting multiple occurences of a word that is scattered across a longer file. Coming from Atom I really miss it in VSCode.

Looking forward to seeing this in vscode. Just switched over from Sublime and really missing this feature.

@katespaghetti
The best thing we can do is to vote ⭐ and hope that this gets higher in their list of popular issues. This issue currently sits in the 3rd page of highest reactions (star), they probably won't take a look at it until it reaches 1st or 2nd page.

Happy Birthday, Y'all!
Its my favorite thread :1st_place_medal:

Is this feature out yet?

I'd like to see the minimap have all the highlighting features of the scrollbar. It feels strange and unnecessary to have two scrollbars for the same window.

I've added a comment in next June 2019 Iteration Plan, you guys can up vote there as well if you wish.

Here is a link to comment to vote: https://github.com/microsoft/vscode/issues/75103#issuecomment-500141645

So....The new version came out. It....sort of has this feature we have been waiting for for 2.5 years. A couple problems:

It only highlights in the minimap if you search the page. Double-clicking on things that highlights other instances of it on the page does not do anything in the minimap.

The highlight is so tiny and subtle it might as well not have been added. Its supposed to highlight in a way that is clear and obvious and instead its so hard to see that in the documentation they had to add a circle around the part of the minimap so people would be able to tell it was there at all.

Any chance these can be fixed in less time than 2.5 years? These seem like pretty simple changes to make.

Our wishes might have been heard...

🔴 Support multi-line decorations in the minimap @RMacfarlane
🔴 Explore improving presentation of search results in minimap (size, theme color) @RMacfarlane

that was pulled from July Iteration Plan (2019), it does sound like this ticket 🤞

With the release of 1.37.0 we kind of have that feature now. The only downside is that it doesn't work on simple selections, but on searches only. That means you need to doubleclick first, and press CTRL+F afterwards... We are almost there. Is there a way to automate searching for the selection?

I tried to talk about it in #78807 along another issue which is assigned to the person who implemented the feature for the search selection. Wait and see

Hey all! I did the work on search results in the minimap, which was the first step of enabling decorations in the minimap. This was meant to be the foundation for further decoration improvements to the minimap. I'm not working on this in the current iteration, but this issue is on my radar!

@RMacfarlane
This is great news, thanks for the info. We waited 2.5 years, so I'm sure we could wait for another iteration before seeing it implemented. We just hope it will be this year lol

I've just checked in the change for showing selection decorations in the minimap, it will be available in tomorrow's VSCode Insiders if you want to try it out early, otherwise in our next stable release in October.

@ghiscoding Can you open a separate issue to track that?


Use /flutter/packages instead of plugins. Fixes #143.

The work is based on instructions from: https://github.com/dart-lang/pub-dartlang-dart/issues/143#issuecomment-305508387
@mkustermann: bin/tools/backfill_search_fields.dart must run in prod before promoting this to live.

@kevmoo we probably don't have a thing to point at yet (other than https://stackoverflow.com/questions/43101373/how-do-i-create-a-pub-package-that-works-with-flutter/43101394#43101394 ) see https://github.com/flutter/flutter/issues/10070

For the index update – I assume running it won't break existing code before the new site is updated – right?

Code won't break, but /flutter/packages will be empty, until the backfill happens or a new version of them is being uploaded.

Right.
From mobile. Sorry for brevity and/or spelling.
On Jun 15, 2017 8:41 AM, "István Soós"<EMAIL_ADDRESS>wrote:

For the index update – I assume running it won't break existing code
before the new site is updated – right?
Code won't break, but /flutter/packages will be empty, until the backfill
happens or a new version of them is being uploaded.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/pub-dartlang-dart/pull/171#issuecomment-308643259,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCigN_NerJI6TIYm8Pm9yhyO-roCqJks5sENH-gaJpZM4N59r4
.

Updated with latest rebase.

Sweet!
On Thu, Jun 15, 2017 at 8:40 PM, István Soós<EMAIL_ADDRESS>wrote:

@isoos commented on this pull request.
In app/test/frontend/handlers_test.dart
https://github.com/dart-lang/pub-dartlang-dart/pull/171#discussion_r122280249
:

@@ -125,40 +125,41 @@ void main() {
});

   tScopedTest('/flutter', () async {

   expectRedirectResponse(await issueGet('/flutter'), '/flutter/plugins');

   expectRedirectResponse(await issueGet('/flutter/'), '/flutter/plugins');

   expectRedirectResponse(await issueGet('/flutter'), '/flutter/packages');

   expectRedirectResponse(

       await issueGet('/flutter/'), '/flutter/packages');

I did (see the line below).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/pub-dartlang-dart/pull/171#discussion_r122280249,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABCil1OrqCaoUZF1ciuw8uiUaANcQaKks5sEXqZgaJpZM4N59r4
.


Ripgrep: can't search for a query containing a space, using the 'whole word' flag

Testing #23319
Version 1.11.0-insider
Commit 646d0f9e0db0c60f81b099472f4a9e3a722744b1
Date 2017-03-28T12:36:25.374Z
Linux
In the vscode repo, search with whole word enabled

'Remove ' without ripgrep: 357 matches, with ripgrep 0 matches
'Remove on' without ripgrep: 1 match, with ripgrep 0 matches
'${1:': with ripgrep: 21 matches, without ripgrep: 235 matches

I agree it's discussable what it 'whole word' means for a search term that is more than a word. But just wanted to bring it to your attention.

If you enable the regex switch, then these work - the problem is actually that strings.escapeRegExpCharacters escapes the space, and ripgrep doesn't recognize that as a valid escape sequence. I don't think it should escape a space, but I won't change it for now.

Possibly March.
@bpasero Do you know why this function escapes whitespace (\s), and is it safe to have it not do that?
export function escapeRegExpCharacters(value: string): string {
	return value.replace(/[\-\\\{\}\*\+\?\|\^\$\.\,\[\]\(\)\#\s]/g, '\\$&');
}

Maybe for march I can clone it without \s just for ripgrep, and remove it for everything else in April.

@roblourens For ripgrep, I don't think you want to escape commas either. The full list of allowable escape characters isn't particularly well documented, but you can see them here: https://github.com/rust-lang/regex/blob/master/regex-syntax/src/parser.rs#L1225

@roblourens Popping up a level, if you want to disable regex entirely, then you can pass the -F/--fixed-strings switch to ripgrep, which will always interpret the pattern as a literal.

Comma also triggers this issue. And that can be a special char in a regex, but only sometimes. JS takes it escaped or unescaped when you want to match a comma, so it seems like that could be removed too.
I use --fixed-strings when not searching for a regex, unless the 'match whole word' option is set. This is because the --word-regexp option only works on a regex, right?

@roblourens Nope! -w works with -F as expected. I admit the name --word-regexp is perhaps bad, but I claim innocence: I snagged it from GNU grep.

Hm, I could have sworn there was a case where it didn't work right, because I went out of my way to do it that way. But now it seems to work fine like you say, so maybe I just don't need to escape those chars.

The number of matches using 'match whole word' is still less than before, because we are tricky about adding the \b flags when the query starts with something like a special character: https://github.com/Microsoft/vscode/blob/master/src/vs/base/common/strings.ts#L211
We can get the same effect by not using the --word-regexp flag and adding them ourselves, of course then we have to escape the regex chars correctly. I'll look at that next month.

Verified that searches or 'Remove ' and 'Remove on' work well, but '${1:' somehow got worse. I annotated #23624


Get rid of user-unsupported NQP

Implemented in https://github.com/rakudo/rakudo/pull/2396

Wouldn't this break when used on Rakudo Star 2018.06 ??

Yeah, it would.
I pushed a backwards-compatible version now.


Update virtual-wan-about.md

Adding content for Network Virtual Appliance in Types of Connectivity.

@ScottNapolitan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Wrong depot!  Cancelling this one to create new PR in private repo


Update inactivity query in 2015 Activity Campaign.

@johngian r?

Just a heads up, this has already been executed in dev so we need to make sure that this is only live on dev ATM.

Code looks OK. r+


Question. Graph-node deployment takes to much space

Hello everyone, I'm sorry if this is not the right place to ask..
I have a graph-node deployed on a virtual machine (in docker), and I'm encountering an issue with disk space consumption. My setup details are as follows:

Network: Polygon
Start block: 2,000,000
Current block: 59,606,297
Database size after initial indexing: 35 GB (on 58,908,274 block)

The problem is that the database size increases by approximately 7 GB every day. Given the number of new blocks generated each day, this seems unusually high.
Here are some additional details:

I have 5 subgraphs deployed to my node.
Subgraphs are tracking events from certain smart contracts.
Using PostgreSQL for the database (nothing special, just like all other subgraphs).
Lately I have no new transaction for my contracts (around few weeks).

I suspect that the rapid increase in disk space usage might not be solely due to new blocks and their associated data. Some potential culprits or considerations might be:

Node configuration (everything is set by default, maybe I should change something?).
Database indexing or maintenance issues.
Possible redundant data or "bloat" in the database.

I know about GRAPH_ETHEREUM_CLEANUP_BLOCKS, but I want to use my graph-node for production purposes.
Should I use Postgres VACUUM or ANALYZE functionality?
Could anyone provide insights or suggestions on what might be causing this rapid increase in database size and how to optimize it?

Hey @statzky
I recommend asking this question to fellow Indexers on The Graph's Discord. That community will have relevant operational experience to share: https://discord.gg/graphprotocol
This recent episode of Indexer Office Hours also goes into some DB optimization techniques for Indexers. I hope it provides some tips you find useful: https://www.youtube.com/watch?v=Xqb027ECq_8&list=PLpbkfkwg_V6Bm7J8Y-8vXxByIXc7C34Ya&index=174


Broken links in Cloud Event docs

https://tekton.dev/docs/pipelines/events/#events-via-cloudevents
Both links in this section to the config for cloud events are broken.
I think they should point here: https://tekton.dev/docs/installation/additional-configs/#configuring-cloudevents-notifications

/kind documentation


Changes to invalid username message

The invalid message for username gives the impression that the char '/' is a valid character for the username.

Decided it is not really an issue. So closing.


Is it copied/borroed from https://github.com/petercunha/Emotion?

Whats the difference? I see the code base is all same?

This is a pre-trained model, the credits have been given to the rightful owner.
Checkout at the bottom of the README.md file.


Is there any identifier to recognize that a particular contact is already present?

We have recordId but it changes (depends on device), I want to check whether a contact is present or not before updating it,

the recordId should be static on a single device. If you want to test if two contacts are the same across devices, you'll have to perform a similarity check. Look into elasticsearch or the ILIKE operator in databases.


Version 0.2.0 Release

[x] #45.
[x] #47.
[x] #51.
[x] #59.
[ ] #58.
[ ] threeal/cpp#21.

The main branch no longer required to be pushed to the latest branch. See #72.


Allow customizing curl DNS cache timeout

Problem
#1529 describes how libcurl reuses connections for 60 seconds by default. Because of that, switching between local and production hosts is inconvenient, if they share the same hostname.
Setting a Connection: close header doesn't seem to help.
It seems like the way to modify that cache is with the CURLOPT_DNS_CACHE_TIMEOUT option. There doesn't seem to be a way to modify that in Insomnia, so I just have to wait 60 seconds each time I switch environments.
Ideal solution
What about introducing an environment variable that would pass the value along to CURLOPT_DNS_CACHE_TIMEOUT? That would let people set it to 0 if they want to disable the cache, or 120 if they want to extend it, etc.
Setting it per-environment would be good, since some environments can share hostnames while others don't.
Alternate solution
Allow plugins to set CURLOPT_DNS_CACHE_TIMEOUT.
cc @AdityaHarindar, @Shawyeok

Still a problem.

Multiple environments (qa/stage/production etc) share a same domain name will met this problem.
@iandunn
I found a workaround, here it is:
Send request with ip address instead of domain name, put domain name into Host header.

Thanks @Shawyeok. I tried that, but I still get SSL errors. It looks like you're using http rather than https in your screenshots.
Maybe your server is setup to accept both? Mine redirects http to https.

Maybe your server is setup to accept both? Mine redirects http to https.

Yes, we still use http protocol for most internal apis.

but I still get SSL errors.
You can disable Validate certificates in preferences if that's ok for you.

Now Validate certificates setting is effect for entire application, maybe add it in per request settings is more convenient.

I need to use HTTPS locally to test code that relies on SSL.
I can't disable cert validation because that would be a significant security problem. Even disabling it for a single site would be a problem in situations where production and local environments share the same hostname.


Add contribution guidelines to GitHub Repo

Would love to add the Contribution Guidelines to the Readme.md file.
For Encouraging Contributors to the contribute to the repo!
Contributor - Sabhi Sharma (GSSOC'23)

Go ahead please
On Sun, 21 May, 2023, 11:09 pm Sabhi Sharma, @.***>
wrote:

Would love to add the Contribution Guidelines to the Readme.md file.
For Encouraging Contributors to the contribute to the repo!
Contributor - Sabhi Sharma (GSSOC'23)
—
Reply to this email directly, view it on GitHub
https://github.com/subhashis2204/project-annapurna/issues/18, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ASKVLE4SJUNA6XHR4QW2RXTXHJHLLANCNFSM6AAAAAAYJQ5C3U
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Go ahead please

@subhashis2204 Kindly assign this issue to me, so that I'll start working on it immediately!

@sabhisharma-ise I have made changes to the env section of the readme.md. See if you can make it a bit nicer to look at.


Extended DataReader to fetch Dividends and Stock Splits from Yahoo!.

Added yahoo-actions data_source to DataReader;
Added get_data_yahoo_actions that returns a DataFrame containing
DIVIDEND and SPLIT corporate actions fetched from Yahoo! Finance;
Added unit tests;
Added documentation example.

this is a nice add, pls direct your PR to https://github.com/pydata/pandas-datareader
as that is how updated to the io/data.py will be handled going forward.
thanks!


Report FIPS results into the stats

Establish a "protocol" to get the results back from a FIPS assessment module and where it will go in the global stats.

/lgtm thanks @bcrochet !


Add testutil packages and clean up copy-pasted code

Adds testutil packages for both generic comparison functions (in pkg) and internal (in internal), and changes all tests to use them
Moves the caveat builder functions to a single definition location and uses them everywhere
Moves types previously defined in util into datasets and renames membership to developmentmembership

Rebased


Add ability to use local plugin

It is currently possible to use plugins from a remote github repo. The plugin repository can also be a local folder and might have other server type too in the future. --plugin-repo is already configurable to set different repo sources. It should be possible to infer local vs remote repo based on the repo uri. The uri scheme can be used a hint to decide which kind of repo to be used or an addition parameter like --plugin-repo-type can be introduced if needed. The --plugin-repo-type might not be needed until support for a new remote repo (eg: gitlab) is added.

closed via https://github.com/kf5i/k3ai-core/pull/42


add support for country regions

Also a good solution! Can you maybe also look at my solution? #37
I think both solutions have certain upsides and downsides. Yours is simple and easier to extend.
Mine is more type-safe when needed and adds the functionality to get only state-specific holidays


jolokia jvm connector broken again in web console

Try to deploy camel cdi quickstart and connect to it from the web console fails

Also if you set that AB auto to false
<fabric8.env.AB_JOLOKIA_AUTH_OPENSHIFT>false</fabric8.env.AB_JOLOKIA_AUTH_OPENSHIFT>

This is with today's release of fabric8

The console expects TLS connections now to Jolokia enabled pods AFAIK. @rhuss - can you confirm?

See #1024


[Crosswalk-17][usecase-wrt]Copy jquery.js to sub app for manual packing

Tester need copy jquery.js to ApplicationlocalStorage/res/res/js/
manually everytime, let's copy it to source code when packing.
Impacted tests(approved): new 0, update 1, delete 0
Unit test platform: Crosswalk Project for Android 17.46.448.10
Unit test result summary: pass 1, fail 0, block 0

LGTM


Broken for Crunchyroll

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like that [x])
Use Preview tab to see how your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2<IP_ADDRESS>. If it's not read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2<IP_ADDRESS>

Before submitting an issue make sure you have:

[x] At least skimmed through README and most notably FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add -v flag to your command line you run youtube-dl with, copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
youtube-dl http://www.crunchyroll.com/konosuba-gods-blessing-on-this-wonderful-world -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'http://www.crunchyroll.com/konosuba-gods-blessing-on-this-wonderful-world', u'-v']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2<IP_ADDRESS>
[debug] Python version 2.7.12 - Linux-4.4.0-62-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: avconv 2.8.10-0ubuntu<IP_ADDRESS>, avprobe 2.8.10-0ubuntu<IP_ADDRESS>, ffmpeg 2.8.10-0ubuntu<IP_ADDRESS>, ffprobe 2.8.10-0ubuntu<IP_ADDRESS>
[debug] Proxy map: {}
[crunchyroll:playlist] konosuba-gods-blessing-on-this-wonderful-world: Downloading webpage
[download] Downloading playlist: KONOSUBA -God's blessing on this wonderful world!
[crunchyroll:playlist] playlist KONOSUBA -God's blessing on this wonderful world!: Collected 14 video ids (downloading 14 of them)
[download] Downloading video 1 of 14
[Crunchyroll] 692393: Downloading webpage
[Crunchyroll] 692393: Downloading media info for 360p
[Crunchyroll] 692393: Downloading m3u8 information
[Crunchyroll] 692393: Downloading media info for 480p
[Crunchyroll] 692393: Downloading m3u8 information
[Crunchyroll] 692393: Downloading media info
[debug] Invoking downloader on u'https://v.vrv.co/evs/assets/0uup32z848wbg2l_2424249.mp4/index-v1-a1.m3u8?Policy=eyJTdGF0ZW1lbnQiOlt7IlJlc291cmNlIjoiaHR0cHM6Ly92LnZydi5jby9ldnMvYXNzZXRzLzB1dXAzMno4NDh3YmcybF8yNDI0MjQ5Lm1wNC8qIiwiQ29uZGl0aW9uIjp7IkRhdGVMZXNzVGhhbiI6eyJBV1M6RXBvY2hUaW1lIjoxNDg2Mzg5MDczfX19XX0_&Signature=E49BbbYgqWU3SwOn~BueOThdaQrDhMwxQSVLXOvM7SEOam4oCxY1TBkfxkaUh4OctcTmZSMccBkVELoF2ady1C8qzw4xeNcfQpgBghSjzBRd6pSJUGSpDPLIE-cQOLRIkfPwrWPHKab-MnH2haRjHEdTpt8pIwz-fkxXDGA1NeBSRXu15zVWACQa78ZtP8wSIyfaW2CK1zJeA2hG4WNHlRjypwCLcC2G1yQlnbMdmdD4EgjW0cOCuW4Uu5Oh2M2dCBYEg77PRjXH2-NIXfdPuDlKLqedy6PPZ2ms2lE1rA~n-E7eKLKjWXZQYr3ljbWI-WS87Tur7UnX2qwZ-oArEg__&Key-Pair-Id=APKAJKQQ2INNHTYFB44A'
[hlsnative] Downloading m3u8 manifest
WARNING: hlsnative has detected features it does not support, extraction will be delegated to ffmpeg
[download] Destination: KONOSUBA -God's blessing on this wonderful world! Episode 1 – This Self-Proclaimed Goddess and Reincarnation in Another World!-692393.mp4
[debug] avconv command line: avconv -y -headers 'Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip, deflate
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20150101 Firefox/47.0 (Chrome)
' -i 'https://v.vrv.co/evs/assets/0uup32z848wbg2l_2424249.mp4/index-v1-a1.m3u8?Policy=eyJTdGF0ZW1lbnQiOlt7IlJlc291cmNlIjoiaHR0cHM6Ly92LnZydi5jby9ldnMvYXNzZXRzLzB1dXAzMno4NDh3YmcybF8yNDI0MjQ5Lm1wNC8qIiwiQ29uZGl0aW9uIjp7IkRhdGVMZXNzVGhhbiI6eyJBV1M6RXBvY2hUaW1lIjoxNDg2Mzg5MDczfX19XX0_&Signature=E49BbbYgqWU3SwOn~BueOThdaQrDhMwxQSVLXOvM7SEOam4oCxY1TBkfxkaUh4OctcTmZSMccBkVELoF2ady1C8qzw4xeNcfQpgBghSjzBRd6pSJUGSpDPLIE-cQOLRIkfPwrWPHKab-MnH2haRjHEdTpt8pIwz-fkxXDGA1NeBSRXu15zVWACQa78ZtP8wSIyfaW2CK1zJeA2hG4WNHlRjypwCLcC2G1yQlnbMdmdD4EgjW0cOCuW4Uu5Oh2M2dCBYEg77PRjXH2-NIXfdPuDlKLqedy6PPZ2ms2lE1rA~n-E7eKLKjWXZQYr3ljbWI-WS87Tur7UnX2qwZ-oArEg__&Key-Pair-Id=APKAJKQQ2INNHTYFB44A' -c copy -f mp4 'file:KONOSUBA -God'"'"'s blessing on this wonderful world! Episode 1 – This Self-Proclaimed Goddess and Reincarnation in Another World!-692393.mp4.part'
ffmpeg version 2.8.10-0ubuntu<IP_ADDRESS> Copyright (c) 2000-2016 the FFmpeg developers
  built with gcc 5.4.0 (Ubuntu 5.4.0-6ubuntu1~16.04.4) 20160609
  configuration: --prefix=/usr --extra-version=0ubuntu<IP_ADDRESS> --build-suffix=-ffmpeg --toolchain=hardened --libdir=/usr/lib/x86_64-linux-gnu --incdir=/usr/include/x86_64-linux-gnu --cc=cc --cxx=g++ --enable-gpl --enable-shared --disable-stripping --disable-decoder=libopenjpeg --disable-decoder=libschroedinger --enable-avresample --enable-avisynth --enable-gnutls --enable-ladspa --enable-libass --enable-libbluray --enable-libbs2b --enable-libcaca --enable-libcdio --enable-libflite --enable-libfontconfig --enable-libfreetype --enable-libfribidi --enable-libgme --enable-libgsm --enable-libmodplug --enable-libmp3lame --enable-libopenjpeg --enable-libopus --enable-libpulse --enable-librtmp --enable-libschroedinger --enable-libshine --enable-libsnappy --enable-libsoxr --enable-libspeex --enable-libssh --enable-libtheora --enable-libtwolame --enable-libvorbis --enable-libvpx --enable-libwavpack --enable-libwebp --enable-libx265 --enable-libxvid --enable-libzvbi --enable-openal --enable-opengl --enable-x11grab --enable-libdc1394 --enable-libiec61883 --enable-libzmq --enable-frei0r --enable-libx264 --enable-libopencv
  libavutil      54. 31.100 / 54. 31.100
  libavcodec     56. 60.100 / 56. 60.100
  libavformat    56. 40.101 / 56. 40.101
  libavdevice    56.  4.100 / 56.  4.100
  libavfilter     5. 40.101 /  5. 40.101
  libavresample   2.  1.  0 /  2.  1.  0
  libswscale      3.  1.101 /  3.  1.101
  libswresample   1.  2.101 /  1.  2.101
  libpostproc    53.  3.100 / 53.  3.100
Input #0, hls,applehttp, from 'https://v.vrv.co/evs/assets/0uup32z848wbg2l_2424249.mp4/index-v1-a1.m3u8?Policy=eyJTdGF0ZW1lbnQiOlt7IlJlc291cmNlIjoiaHR0cHM6Ly92LnZydi5jby9ldnMvYXNzZXRzLzB1dXAzMno4NDh3YmcybF8yNDI0MjQ5Lm1wNC8qIiwiQ29uZGl0aW9uIjp7IkRhdGVMZXNzVGhhbiI6eyJBV1M6RXBvY2hUaW1lIjoxNDg2Mzg5MDczfX19XX0_&Signature=E49BbbYgqWU3SwOn~BueOThdaQrDhMwxQSVLXOvM7SEOam4oCxY1TBkfxkaUh4OctcTmZSMccBkVELoF2ady1C8qzw4xeNcfQpgBghSjzBRd6pSJUGSpDPLIE-cQOLRIkfPwrWPHKab-MnH2haRjHEdTpt8pIwz-fkxXDGA1NeBSRXu15zVWACQa78ZtP8wSIyfaW2CK1zJeA2hG4WNHlRjypwCLcC2G1yQlnbMdmdD4EgjW0cOCuW4Uu5Oh2M2dCBYEg77PRjXH2-NIXfdPuDlKLqedy6PPZ2ms2lE1rA~n-E7eKLKjWXZQYr3ljbWI-WS87Tur7UnX2qwZ-oArEg__&Key-Pair-Id=APKAJKQQ2INNHTYFB44A':
  Duration: 00:23:40.01, start: 0.101000, bitrate: N/A
  Program 0
    Metadata:
      variant_bitrate : 0
    Stream #0:0: Video: h264 (Main) ([27][0][0][0] / 0x001B), yuv420p, 848x480 [SAR 160:159 DAR 16:9], 23.98 fps, 23.98 tbr, 90k tbn, 47.95 tbc
    Stream #0:1: Audio: aac (LC) ([15][0][0][0] / 0x000F), 44100 Hz, stereo, fltp, 104 kb/s
    Stream #0:2: Data: timed_id3 (ID3  / 0x20334449)
[mp4 @ 0x1d9c660] Codec for stream 0 does not use global headers but container format requires global headers
[mp4 @ 0x1d9c660] Codec for stream 1 does not use global headers but container format requires global headers
Output #0, mp4, to 'file:KONOSUBA -God's blessing on this wonderful world! Episode 1 – This Self-Proclaimed Goddess and Reincarnation in Another World!-692393.mp4.part':
  Metadata:
    encoder         : Lavf56.40.101
    Stream #0:0: Video: h264 ([33][0][0][0] / 0x0021), yuv420p, 848x480 [SAR 160:159 DAR 16:9], q=2-31, 23.98 fps, 23.98 tbr, 90k tbn, 90k tbc
    Stream #0:1: Audio: aac ([64][0][0][0] / 0x0040), 44100 Hz, stereo, 104 kb/s
Stream mapping:
  Stream #0:0 -> #0:0 (copy)
  Stream #0:1 -> #0:1 (copy)
Press [q] to stop, [?] for help
[mp4 @ 0x1d9c660] Malformed AAC bitstream detected: use the audio bitstream filter 'aac_adtstoasc' to fix it ('-bsf:a aac_adtstoasc' option with ffmpeg)
av_interleaved_write_frame(): Operation not permitted
frame=    5 fps=0.0 q=-1.0 Lsize=      17kB time=00:00:00.16 bitrate= 844.4kbits/s
video:16kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 3.819854%
Conversion failed!
...
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Single video: https://www.youtube.com/watch?v=BaW_jenozKc
Single video: https://youtu.be/BaW_jenozKc
Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue, suggested solution and other information
It doesn't work to download, latest ffmpeg from debian 7, apparently not at their end.

Could you try this:
youtube-dl http://www.crunchyroll.com/konosuba-gods-blessing-on-this-wonderful-world -v --prefer-ffmpeg

Related: #8622

That does work, thanks!


Netty 4.1 Facing thread Leak issue

Thread count checked through below command should be minimal
ps -u |grep | wc -l
Thread count starts from 41 initially, reaches to 200 within minutes and eventually jvm is not able to support new connections. Total client connections initially are 20, but client tries to reconnect after connection reset.
Also there is a load balancer continuously querying TCP port for active state, which is configured as force close.
Code
                  `final EventLoopGroup bossGroup = new NioEventLoopGroup();
	        final EventLoopGroup workerGroup = new NioEventLoopGroup();
	        try {
	            final ServerBootstrap b = new ServerBootstrap();
	            b.group(bossGroup, workerGroup)
	                    .channel(NioServerSocketChannel.class)
	                    .childHandler(new MySocketInitialiser())
	                    .option(ChannelOption.SO_BACKLOG, 100)
	                    .childOption(ChannelOption.SO_KEEPALIVE, true);
	            String hostname = getHostName();
	            ch = b.bind(hostname, 12110).sync().channel();
	            System.out.println("Started on port : server "+ port + ":"+hostname);
	            ch.closeFuture().sync();
	        } finally {
	            bossGroup.shutdownGracefully();
	            workerGroup.shutdownGracefully();
	        }`

                 `private class MySocketInitialiser extends ChannelInitializer<SocketChannel> {
	        @Override
	        public void initChannel(final SocketChannel ch) throws Exception {
	            final ChannelPipeline pipeline = ch.pipeline();

	            final EventExecutorGroup group = new DefaultEventExecutorGroup(5);
	            pipeline.addLast(group, "handler", new SomeHandler());

	        }
	    }`

                      ` public class SomeHandler extends ChannelInboundHandlerAdapter {
	        @Override
			public void channelRead(ChannelHandlerContext channelHandlerContext, Object notification) throws Exception {
	        	 // Read the message sent from client.
	        		++packetNumber;
	                ByteBuf in = (ByteBuf) notification;
	                incomingMsg = new StringBuffer();
	                try {
	                    while (in.isReadable()) { // (1)
	                    	incomingMsg.append((char) in.readByte());
	                    }

			            System.out.println("Going to write response:"+response);
			            channelHandlerContext.writeAndFlush(Unpooled.copiedBuffer(response, CharsetUtil.UTF_8));
	                }
	                catch(Exception e){

	                }finally{
	                    ReferenceCountUtil.release(channelHandlerContext);
	                    channelHandlerContext.close();
	                }

	        }`

Netty version - 4.1
JVM version - 1.8.0_71-b15
OS version - Linux

   final EventExecutorGroup group = new DefaultEventExecutorGroup(5);
   pipeline.addLast(group, "handler", new SomeHandler());

This line is obviously buggy. You need to reuse group instead of creating new instance for each connection.

thanks @lizhanhui .. let me close this for now as this doesn't seem to be a Netty issue.

hi @lizhanhui
Thanks for your time. As you recommended, I tried reusing the group. But this is not helping, as the thread count is still increasing with pace.
###Code
` final EventExecutorGroup group = new DefaultEventExecutorGroup(20);
                private class MySocketInitialiser extends ChannelInitializer<SocketChannel> {
                    @Override
                    public void initChannel(final SocketChannel ch) throws Exception {
                        final ChannelPipeline pipeline = ch.pipeline();

                        pipeline.addLast(group, "handler", new SomeHandler());
                        System.out.println("Exitting initchannel method()");
                    }
                }`


Test Reticulate in R Markdown within Docker

Run test for reticulate in R Markdown files running inside a Docker container as defined by the image of this project. If bug/confusion, modify the Dockerfile accordingly.

If the above is successful, maybe also change .ipynb to .Rmd


[various] Update to use sharedDarwinSource

Adds sharedDarwinSource: true to shared_preferences so the symlinks won't be used in newer versions of Flutter.
Moves the shared code for in_app_purchase to the now-standarized location, and adds sharedDarwinSource: true there as well.

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

test-exempt: code refactor with no semantic change


Refactor handling of init systems

The idea here is to create and use classes with a common interface to abstract working with the init systems.  Should simplify the code immensely.
This will be a pre-req to fixing http://tracker.ceph.com/issues/13087, which has us use the new ceph-detect-init tool when it is present.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1759/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1760/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1761/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1762/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1763/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1764/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1765/
Test PASSed.

I think this in a good state to review now.
I've tested on CentOS 7, using both Hammer release, and latest Infernalis dev packages.  This covered both sysvinit and systemd.
I did the same thing on Trusty, and that successfully gets upstart on each.
Using the latest Infernalis packages, I did get an error when trying activate file-based OSDs on both Trusty and CentOS 7::
[trusty1][WARNIN] 2015-09-15 23:30:57.355914 7f60eede0980 -1 filestore(/tmp/osd1) mkfs: write_version_stamp() failed: (13) Permission denied
[trusty1][WARNIN] 2015-09-15 23:30:57.355938 7f60eede0980 -1 OSD::mkfs: ObjectStore::mkfs failed with error -13
[trusty1][WARNIN] 2015-09-15 23:30:57.357761 7f60eede0980 -1  ** ERROR: error creating empty object store in /tmp/osd1: (13) Permission denied

This seems more to do with running the daemons as the ceph users than anything to do with the init system, though.
I should still do a couple tests using RGW and MDS, but it's looking good so far.
@alfredodeza @liewegas feel free to take a look.  There is additional clean up that could be done, but this is all the obvious stuff.  It is nice to not have distro-specific versions of the "mon create" stuff anymore. :)
Once this is in, I can work on switching over to ceph-detect-init when its presence is detected.

On Tue, 15 Sep 2015, Travis Rhoden wrote:

[trusty1][WARNIN] 2015-09-15 23:30:57.355914 7f60eede0980 -1 filestore(/tmp/osd1) mkfs: write_version_stamp() failed: (13) Permission denied
[trusty1][WARNIN] 2015-09-15 23:30:57.355938 7f60eede0980 -1 OSD::mkfs: ObjectStore::mkfs failed with error -13
[trusty1][WARNIN] 2015-09-15 23:30:57.357761 7f60eede0980 -1  ** ERROR: error creating empty object store in /tmp/osd1: (13) Permission denied

if it's dcrypt, that's http://tracker.ceph.com/issues/13000

This seems more to do with running the daemons as the ceph users than anything to do with the init system, though.

yeah

FWIW, the permissions error is because I was using directories for OSDs (which I rarely do) and created them as root.
If I did...
chown -R ceph:ceph /tmp/osd1
ceph-deploy osd prepare <host>:/tmp/osd1
ceph-deploy osd activate <host>:/tmp/osd1

things worked just fine.  So as part of Infernalis, we'll probably need to update docs to say that if you are using directories for OSD testing, you need to set the right perms.  :)  Block devices are all taken care of automatically by the tooling.  I wonder if ceph-disk should do something similar when pointed at a directory?

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1766/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1767/
Test PASSed.

RGW and MDS services seem correct on Trusty/Upstart.
I had to push one more commit to fix RGW on sysvinit.  I wasn't properly handling that the 'ceph' and 'ceph-radosgw' init scripts have completely different options (like -c, or that the rgw script can't take a daemon name).
That's all fixed now.

@dmick @alfredodeza care to take a look at this one?

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1794/
Test FAILed.

Okay, so here is what I have done...
@alfredodeza I added unit tests to cover the eventual command invocations.  Right now it apepars I have used some calls in Mock that are not available in py2.6, so I've got to look into that (that's what the test failure is -- all is fine in py2.7).
To address a few of @osynge comments, I have removed the stop, status, and disable methods for the init classes.  These are not used anywhere in the code right now, so adding them is just bloat and leads to confusion.  And as Owen pointed out, some of them weren't even usable.
I need to address the test errors, and also Owen's comments about service mappings and PR #318 still...

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1795/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1796/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1797/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.ceph.com//job/ceph-deploy-pull-requests/1799/
Test PASSed.

Oh man - I never realized this never went in. That's a shame, it was a big improvement! :)
I suppose this should just be closed at this point.

can it be rebased?

@codenrhoden I think this could be rebased and made to work again and is a very big improvement.

@liewegas @osynge I'm sure it can be. I just need to go through any fixes/improvements from the last year to see if there is anything that needs to be added.
I'll try to get to that over the next week or two.
I'm going to be working on some Ceph related stuff over the next few weeks, so I'm happy to help out here!

@codenrhoden sorry this seems to have become old,  the newer centos and ubuntu is only systemd now and the current logic although simple handles it better and is well tested.

well whether it makes sense or not, I'll take a stab at it. I've just pushed an initial rebase, but no testing has been done at this point.

running against this branch on hammer, jewel
http://pulpito.ceph.com/vasu-2016-10-03_16:53:30-ceph-deploy-hammer---basic-vps/
http://pulpito.ceph.com/vasu-2016-10-03_16:54:03-ceph-deploy-jewel---basic-vps/

@vasukulkarni: thanks for the links. I haven't done much testing yet, so I don't expect things to work. However, the errors in Pulpito are not code related. They are all failing when doing git clone -b RM-13087 git://git.ceph.com/ceph-deploy.git. The problem is there is no RM-13087 branch at git.ceph.com/ceph-deploy.git.  That branch only exists in my (codenrhoden) fork.
Not sure how Pulpito normally handles that.
If the branch can be overriden, I believe git clone -b refs/pull/355/head ... might work, but only if refs/pull/* are also copied over to git.ceph.com.

We'll see what Jenkins thinks of the latest changes. I was able to get all tests passing on py27 and py34 plus flake8 with latest changes (updating pytest and mock version requirements). I wasn't easily able to get a py26 env installed on CentOS 7.2. I guess it's no longer in EPEL?

  py26: commands succeeded
  py27: commands succeeded
ERROR:   py34: InterpreterNotFound: python3.4
  flake8: commands succeeded

So, if Python 3.4 is going to be tested, you should probably add it to the Jenkins nodes. :)

@codenrhoden that failure as you said is because its in your git repo which i didn't notice , it only looks for branh in ceph repo https://github.com/ceph/ceph-qa-suite/blob/master/tasks/ceph_deploy.py#L66, If you can create the branch in ceph-deploy repo it will be easy to get some runs on hammer/jewel

ceph is systemd only now


Exploit Guard Evaluation Package

The link to the Exploit Guard Evaluation Package (https://aka.ms/mp7z2w) is dead

Dokumentdetails
⚠ Bearbeiten Sie diesen Abschnitt nicht. Er ist für die Verknüpfung von docs.microsoft.com zum GitHub-Artikel erforderlich.

ID: 89a3e05b-445d-30b2-bdcf-5479a3c9713c
Version Independent ID: 49c3c29a-f816-778c-f92c-f6ca0311a2aa
Content: Verwenden des Netzwerkschutzes, Verbindungen mit schädlichen Websites zu verhindern
Content Source: windows/security/threat-protection/windows-defender-exploit-guard/network-protection-exploit-guard.md
Product: w10
GitHub Login: @andreabichsel
Microsoft Alias: v-anbic

@officedocsbot assign @mypil

@beerisgood  Thank you for the feedback. The is link is working now as expected. Let us know if you have more questions.

@msbemba the link (https://aka.ms/mp7z2w) go to https://demo.wd.microsoft.com/?ocid=cx-wddocs-testground but on https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-defender-exploit-guard/network-protection-exploit-guard the text is:

Download the Exploit Guard Evaluation Package and extract the file np-events.xml to an easily accessible location on the machine.

And on the linked site (https://docs.microsoft.com/en-us/windows/security/threat-protection/windows-defender-exploit-guard/network-protection-exploit-guard) no "Exploit Guard Evaluation Package" exist so i guess the issue is still not fixed?

@kenwith - who can we reach out to get the correct link to be able to download the Exploit Guard Evaluation Package?
Thanks.

The Exploit Guard Evaluation Package is no longer supported. This link needs to be removed.

Thats sad.
Then link to the xml file for manual import

@beerisgood  Thank you for the feedback. Now that Exploit guard evaluation package is no longer supported, We have made changes to the document and it only contains steps for manual import.
Created PR#https://github.com/MicrosoftDocs/windows-itpro-docs/pull/3032


Fix Typo

TL;DR
Please replace this text with a description of what this PR accomplishes.
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[ ] Unit tests added
[ ] Code documentation added
[ ] Any pending items have an associated Issue

Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
https://github.com/lyft/flyte/issues/
Follow-up issue
NA
OR
https://github.com/lyft/flyte/issues/

lgtm, but you need to signoff -> run commit -s  or follow the instructions that you can see when you click Details


Dark and Light Mode implementation

Implementation of dark & light mode version of the website including all the mdoals, buttons etc

Dark mode on modals done ✅


Grammar refactor

For better processing of path expressions:
a(b)[c].d[e](f)

Took a look at this yesterday, test all pass, everything works as expected. LGTM


Add extra attribute in PrintOp to propagate signness info

Applies changes from https://github.com/triton-lang/triton/commit/a94dee0cfd213105831dc91c3d2236856e248035 to intel-specific code.
Closes #1705

@anmyachev Please check if you are ok with changes in e150be30e3654cab9de5532a2d4524a6842d6a08.

@anmyachev Please check if you are ok with changes in e150be3.

@whitneywhtsang looks good! Thank you!